Re: [PATCH 00/19] i3c: aspeed: Add I3C support

2025-06-15 Thread Cédric Le Goater
Hi + Jeremy On 6/13/25 02:03, Joe Komlodi wrote: Hi all, This series adds I3C bus support to QEMU and adds more functionality to the Aspeed I3C controller. This implementation is a basic implementation that introduces IBIs (including hot-join), CCCs, and SDR data transfer. As-is, it doesn't s

Re: [PATCH 01/19] hw/misc/aspeed_i3c: Move to i3c directory

2025-06-15 Thread Cédric Le Goater
On 6/13/25 02:03, Joe Komlodi wrote: Moves the Aspeed I3C model and traces into hw/i3c and creates I3C build files. Signed-off-by: Joe Komlodi Reviewed-by: Cédric Le Goater Reviewed-by: Patrick Venture Reviewed-by: Titus Rwantare Internal reviews are not of much value. It's better to

Re: [PATCH] vdpa: Allow VDPA to work on big-endian machine

2025-06-15 Thread Eugenio Perez Martin
On Sun, Jun 15, 2025 at 12:46 AM Konstantin Shkolnyy wrote: > > After commit 0caed25cd171 vhost_vdpa_net_load_vlan() started seeing > VIRTIO_NET_F_CTRL_VLAN flag and making 4096 calls to the kernel with > VIRTIO_NET_CTRL_VLAN_ADD command. However, it forgot to convert the > 16-bit VLAN IDs to LE f

Re: [PATCH 05/12] include/hw: replace FSF postal address with licenses URL

2025-06-15 Thread Cédric Le Goater
Hello Sean On 6/14/25 22:22, Sean Wei wrote: Hi Cédric, Thanks for pointing me to the earlier thread, moving to the `SPDX-License-Identifier` tags is the better long-term fix. > I think you can convert all QEMU files while at it. To keep traffic on qemu-devel@ manageable, I'd like to work s

Re: [PATCH rfcv3 15/21] intel_iommu: Bind/unbind guest page table to host

2025-06-15 Thread Nicolin Chen
On Thu, Jun 12, 2025 at 02:06:15PM +, Shameerali Kolothum Thodi wrote: > > >> The "switch" in vSMMU model is only needed by KVM for MSI doorbell > > >> translation. By thinking it carefully, maybe it shouldn't switch AS > > >> because VFIO might be confused if it somehow does get_address_space

Re: [PATCH rfcv3 15/21] intel_iommu: Bind/unbind guest page table to host

2025-06-15 Thread Nicolin Chen
On Thu, Jun 12, 2025 at 08:53:40PM +0800, Yi Liu wrote: > > > That being said, IOMMU_NOTIFIER_IOTLB_EVENTS should not be needed > > > for passthrough devices, right? > > > > No, even if x-flts=on is configured in QEMU cmdline, that only mean virtual > > vtd > > supports stage-1 translation, guest

Re: [PATCH v7 0/1] Optimizing the print format of the QEMU monitor 'info mtree'

2025-06-15 Thread Markus Armbruster
Chao Liu writes: > From: Chao Liu > > Hi, all: > > After several rounds of discussion, I think that adding a -t option to the > `info mtree` command, which enables the display of tree-like node characters > (e.g., +--, |--), is a better approach. > > As BALATON Zoltan pointed out, retaining spac

Re: [PATCH v3 2/2] hw/arm: Add the romfile compatatibility

2025-06-15 Thread Shaoqin Huang
On 6/9/25 5:10 PM, Daniel P. Berrangé wrote: On Mon, Jun 09, 2025 at 09:48:36AM +0100, Peter Maydell wrote: On Mon, 9 Jun 2025 at 08:34, Shaoqin Huang wrote: On arm64, it doesn't use the vgabios-ramfb.bin, so set the property "use-legacy-x86-rom" to false, thus the ramfb won't load the vga

Re: [PATCH v3 1/2] ramfb: Add property to control if load the romfile

2025-06-15 Thread Shaoqin Huang
Hi Gerd, Daniel, Sorry for the late reply. On 6/10/25 2:47 PM, Gerd Hoffmann wrote: Hi, $ qemu-system-aarch64 -machine virt -cpu max -device ati-vga qemu-system-aarch64: -device ati-vga: failed to find romfile "vgabios-ati.bin" $ qemu-system-aarch64 -machine virt -cpu max -device cirrus-

Re: [PATCH rfcv3 15/21] intel_iommu: Bind/unbind guest page table to host

2025-06-15 Thread Nicolin Chen
Sorry for a late reply. On Wed, May 28, 2025 at 07:12:25AM +, Duan, Zhenzhong wrote: > >Third, the vSMMU model, for invalidation efficiency and HW Queue > >support, isolates all emulated devices out of the nesting-enabled > >vSMMU instance, suggested by Jason. So, only passthrough devices > >w

Re: [PATCH v3 1/3] hw/arm: make cpu targeted by arm_load_kernel the primary CPU.

2025-06-15 Thread Philippe Mathieu-Daudé
On 13/6/25 15:42, Clément Chigot wrote: Currently, arm booting processus assumes that the first_cpu is the CPU that will boot: `arm_load_kernel` is powering off all but the `first_cpu`; `do_cpu_reset` is setting the loader address only for this `first_cpu`. For most of the boards, this isn't an

Re: [PATCH] docs: remove repeated word

2025-06-15 Thread Markus Armbruster
Cc: qemu-trivial Andrew Kreimer writes: > The word 'find' appears twice, remove the extra one. > > Signed-off-by: Andrew Kreimer > --- > docs/system/introduction.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/system/introduction.rst b/docs/system/introduction

Re: [PATCH v4 2/7] hw/arm/virt-acpi-build: Re-arrange SMMUv3 IORT build

2025-06-15 Thread Nicolin Chen
On Fri, Jun 13, 2025 at 03:44:44PM +0100, Shameer Kolothum wrote: > Introduces a new struct AcpiIortSMMUv3Dev to hold all the information > required for SMMUv3 IORT node and use that for populating the node. > > The current machine wide SMMUv3 is named as legacy SMMUv3 as we will > soon add suppor

Re: [PATCH v4 7/7] qemu-options.hx: Document the arm-smmuv3 device

2025-06-15 Thread Nicolin Chen
On Fri, Jun 13, 2025 at 03:44:49PM +0100, Shameer Kolothum wrote: > Now that arm,virt can have user-creatable smmuv3 devices, document it. > > Signed-off-by: Shameer Kolothum Reviewed-by: Nicolin Chen

Re: [PATCH v4 6/7] hw/arm/virt: Allow user-creatable SMMUv3 dev instantiation

2025-06-15 Thread Nicolin Chen
On Fri, Jun 13, 2025 at 03:44:48PM +0100, Shameer Kolothum wrote: > Allow cold-plug of smmuv3 device to virt if there is no machine > wide legacy smmuv3 or a virtio-iommu is specified. > > Device tree support for new smmuv3 dev is limited to the case where > it is associated with the default pcie.

Re: [PATCH v4 3/7] hw/arm/virt-acpi-build: Update IORT for multiple smmuv3 devices

2025-06-15 Thread Nicolin Chen
On Fri, Jun 13, 2025 at 03:44:45PM +0100, Shameer Kolothum wrote: > With the soon to be introduced user-creatable SMMUv3 devices for > virt, it is possible to have multiple SMMUv3 devices associated > with different PCIe root complexes. > > Update IORT nodes accordingly. > > An example IORT Id ma

Re: [PATCH 12/18] hw/nvram/fw_cfg: Inline fw_cfg_file_slots()

2025-06-15 Thread Philippe Mathieu-Daudé
Hi Igor, On 6/6/25 15:29, Igor Mammedov wrote: On Thu, 1 May 2025 23:04:50 +0200 Philippe Mathieu-Daudé wrote: Now than fw_cfg_file_slots() only returns FW_CFG_FILE_SLOTS_DFLT, we can inline it. Signed-off-by: Philippe Mathieu-Daudé does this even compile? I see more usages of fw_cfg_fil

Re: QEMU emulating ARM Neoverse N1 unexpectectly emulates `retaa`

2025-06-15 Thread Philippe Mathieu-Daudé
Hi Solomon, Cc'ing the qemu-arm@ list. On 14/6/25 06:51, r...@wjsota.com wrote: Hi! Is `qemu-aarch64 -cpu neoverse-n1` supposed to emulate the `retaa` instruction? I have a binary called `main_pac` compiled from https://learn.arm.com/learning-paths/servers-and-cloud-computing/pac/example/ .

Re: [PATCH 4/6] MAX78000 GCR implementation

2025-06-15 Thread Philippe Mathieu-Daudé
Hi, On 10/5/25 06:20, jc...@duck.com wrote: This patch implements the Global Control Register for the MAX78000 SOC Signed-off-by: Jackson Donaldson --- hw/arm/Kconfig | 1 + hw/arm/max78000_soc.c | 9 +- hw/misc/Kconfig| 3 + hw/misc/max78000

Re: [PATCH v4 1/7] hw/arm/smmu-common: Check SMMU has PCIe Root Complex association

2025-06-15 Thread Nicolin Chen
On Fri, Jun 13, 2025 at 03:44:43PM +0100, Shameer Kolothum wrote: > Although this change does not affect functionality at present, it is > required when we add support for user-creatable SMMUv3 devices in > future patches. > > Tested-by: Nathan Chen > Signed-off-by: Shameer Kolothum Reviewed-by

Re: [PATCH 1/2] fsdev/9p-marshal: move G_GNUC_PRINTF to header

2025-06-15 Thread Philippe Mathieu-Daudé
On 14/6/25 04:08, Sean Wei wrote: v9fs_string_sprintf() is annotated with G_GNUC_PRINTF(2, 3) in 9p-marshal.c, but the prototype in fsdev/9p-marshal.h is missing the attribute, so callers that include only the header do not get format checking. Move the annotation to the header and delete the du

Re: [PATCH 2/2] hw/9pfs: move G_GNUC_PRINTF to header

2025-06-15 Thread Philippe Mathieu-Daudé
On 14/6/25 04:09, Sean Wei wrote: v9fs_path_sprintf() is annotated with G_GNUC_PRINTF(2, 3) in hw/9pfs/9p.c, but the prototype in hw/9pfs/9p.h is missing the attribute, so callers that include only the header do not get format checking. Move the annotation to the header and delete the duplicate

RE: [PATCH rfcv3 15/21] intel_iommu: Bind/unbind guest page table to host

2025-06-15 Thread Duan, Zhenzhong
>-Original Message- >From: Liu, Yi L >Subject: Re: [PATCH rfcv3 15/21] intel_iommu: Bind/unbind guest page table to >host > >On 2025/5/28 15:12, Duan, Zhenzhong wrote: >> >> >>> -Original Message- >>> From: Nicolin Chen >>> Subject: Re: [PATCH rfcv3 15/21] intel_iommu: Bind/unbi

Re: [PATCH] vdpa: Allow VDPA to work on big-endian machine

2025-06-15 Thread Jason Wang
On Sun, Jun 15, 2025 at 6:44 AM Konstantin Shkolnyy wrote: > > After commit 0caed25cd171 vhost_vdpa_net_load_vlan() started seeing > VIRTIO_NET_F_CTRL_VLAN flag and making 4096 calls to the kernel with > VIRTIO_NET_CTRL_VLAN_ADD command. However, it forgot to convert the > 16-bit VLAN IDs to LE fo

RE: [PATCH v3] hw/misc/aspeed_scu: Handle AST2600 protection key registers correctly

2025-06-15 Thread Jamin Lin
> Subject: [PATCH v3] hw/misc/aspeed_scu: Handle AST2600 protection key > registers correctly > > The AST2600 SCU has two protection key registers (0x00 and 0x10) that both > need to be unlocked. (Un-)locking 0x00 modifies both protection key registers, > while modifying 0x10 only modifies itse

Re: [PATCH 02/10] loongarch: add virt feature avecintc support

2025-06-15 Thread Bibo Mao
On 2025/6/13 下午3:54, gaosong wrote: 在 2025/6/11 下午2:46, Bibo Mao 写道: On 2025/6/9 下午6:48, Song Gao wrote: LoongArchVirtMachinState add  avecintc features, and it use to check whether virt machine support advance interrupt controller and default is on. Signed-off-by: Song Gao ---   hw/lo

Re: [PATCH v1 1/3] hw/net/can: CTU CAN FD IP core mapping to the platform bus

2025-06-15 Thread Pavel Pisa
Hello Peter, thanks for the response. On Thursday 12 of June 2025 17:50:20 Peter Maydell wrote: > On Wed, 28 May 2025 at 12:50, Pavel Pisa wrote: > > The system/platform bus mapping alternative to PCI/PCIe mapping. > > In this case, the platform bus is used to match FPGA design > > for Xilinx Zy

[PATCH] docs: remove repeated word

2025-06-15 Thread Andrew Kreimer
The word 'find' appears twice, remove the extra one. Signed-off-by: Andrew Kreimer --- docs/system/introduction.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/system/introduction.rst b/docs/system/introduction.rst index 338d3745c3..4cd46b5b8f 100644 --- a/docs/syste

[PATCH v3 0/4] Initial logging support for Rust

2025-06-15 Thread Bernhard Beschow
This series introduces a log_mask_ln! macro which is inspired by the C version and is just a thin wrapper around qemu_log(). It caters to Rust expectations by accepting an enum for logging categories and working like the format! macro. The macro then gets used in the pl011 device which either had i

[PATCH v3 2/4] rust/hw/char/pl011/src/device: Implement logging

2025-06-15 Thread Bernhard Beschow
Now that there is logging support in Rust for QEMU, use it in the pl011 device. Signed-off-by: Bernhard Beschow --- rust/hw/char/pl011/src/device.rs | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/rust/hw/char/pl011/src/device.rs b/rust/hw/char/pl011/src/device.r

[PATCH v3 3/4] rust/hw/char/pl011/src/device: Add missing logging to match C version

2025-06-15 Thread Bernhard Beschow
Co-developed-by: Paolo Bonzini Signed-off-by: Bernhard Beschow --- rust/hw/char/pl011/src/device.rs | 6 ++ 1 file changed, 6 insertions(+) diff --git a/rust/hw/char/pl011/src/device.rs b/rust/hw/char/pl011/src/device.rs index fa591c3ef6..48b4bca6b8 100644 --- a/rust/hw/char/pl011/src/devic

[PATCH v3 1/4] rust/qemu-api: Add initial logging support based on C API

2025-06-15 Thread Bernhard Beschow
A log_mask_ln!() macro is provided which expects similar arguments as the C version. However, the formatting works as one would expect from Rust. To maximize code reuse the macro is just a thin wrapper around qemu_log(). Also, just the bare minimum of logging masks is provided which should suffice

[PATCH v3 4/4] rust/qemu-api: Fix clippy lint `missing_const_for_fn`

2025-06-15 Thread Bernhard Beschow
Signed-off-by: Bernhard Beschow --- rust/qemu-api/src/cell.rs | 2 +- rust/qemu-api/src/qom.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/rust/qemu-api/src/cell.rs b/rust/qemu-api/src/cell.rs index 27063b049d..851573f8ef 100644 --- a/rust/qemu-api/src/cell.rs +++ b/ru