Re: [PATCH 13/19] include/qemu/osdep.h: Add Emscripten-specific OS dependencies

2025-04-17 Thread Kohei Tokunaga
Hi Philippe, > You shouldn't have to modify this file, likely a rebase typo. Thank you for pointing this out. I'll fix this in the next version of the series.

Re: [PATCH 12/19] block: Update block to compile with Emscripten

2025-04-17 Thread Kohei Tokunaga
Hi Philippe, > If meson fails to link, it won't define HAVE_COPY_FILE_RANGE, Yes, meson correctly detects the link failure when checking for copy_file_range, as shown in meson-log.txt: > wasm-ld: error: /tmp/emscripten_temp_oqvz296m/testfile_0.o: undefined symbol: copy_file_range and reflects t

Re: [RFC PATCH 05/13] migration: Reduce a bit of duplication in migration.json

2025-04-17 Thread Markus Armbruster
Markus Armbruster writes: > Fabiano Rosas writes: > >> Introduce a new MigrationConfigBase, to allow most of the duplication >> in migration.json to be eliminated. >> >> The reason we need MigrationParameters and MigrationSetParameters is >> that the internal parameter representation in the migr

Re: [PATCH v3] target/loongarch: Restrict instruction execution based on CPU features

2025-04-17 Thread bibo mao
Rui, Thanks for the patch. Overall it looks good to me. Could you split it into three small patches? such as crc/64/fp specified small patches. Regards Bibo Mao On 2025/4/18 上午11:07, WANG Rui wrote: Previously, some instructions could be executed regardless of CPU mode or feature support. T

[PATCH] hw/usb/hcd-xhci: Unmap canceled packet

2025-04-17 Thread Akihiko Odaki
When the Stop Endpoint Command is received, packets running asynchronously are canceled and then all packets are cleaned up. Packets running asynchronously hold the DMA mapping so cleaning the packets leak the mapping. Remove the mapping after canceling packets to fix the leak. Fixes: 62c6ae04cf43

Re: [PATCH 09/18] amd_iommu: Add helpers to walk AMD v1 Page Table format

2025-04-17 Thread CLEMENT MATHIEU--DRIF
On 17/04/2025 5:27 pm, Alejandro Jimenez wrote: > Caution: External email. Do not open attachments or click links, unless > this email comes from a known sender and you know the content is safe. > > > On 4/17/25 8:40 AM, CLEMENT MATHIEU--DRIF wrote: >> >> >> On 14/04/2025 4:02 am, Alejandro Ji

Re: [RFC PATCH-for-10.1 06/19] target/tricore: Replace TARGET_LONG_BITS -> target_long_bits()

2025-04-17 Thread Paolo Bonzini
On 4/4/25 19:53, Philippe Mathieu-Daudé wrote: On 4/4/25 18:48, Pierrick Bouvier wrote: On 4/3/25 16:49, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé ---   target/tricore/translate.c | 6 --   1 file changed, 4 insertions(+), 2 deletions(-) The temptation is good,

[PATCH 02/11] hw/arm/bananapi: Define machine as generic QOM type

2025-04-17 Thread Philippe Mathieu-Daudé
While DEFINE_MACHINE() is a succinct macro, it doesn't allow registering QOM interfaces to the defined machine. Convert to the generic DEFINE_TYPES() in preparation to register interfaces. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/bananapi_m2u.c | 13 +++-- 1 file changed, 11 inse

Re: [PATCH 03/18] amd_iommu: Add support for IOMMU notifier

2025-04-17 Thread Alejandro Jimenez
On 4/17/25 6:19 AM, Sairaj Kodilkar wrote: On 4/17/2025 3:47 AM, Alejandro Jimenez wrote: On 4/16/25 8:14 AM, Sairaj Kodilkar wrote: + +    /* DMA address translation */ +    bool dma_remap; I think you should use this flag in the remapping path as well. I am aware that you are usi

[PATCH 05/11] hw/arm/imx: Define machines as generic QOM types

2025-04-17 Thread Philippe Mathieu-Daudé
While DEFINE_MACHINE() is a succinct macro, it doesn't allow registering QOM interfaces to the defined machine. Convert to the generic DEFINE_TYPES() in preparation to register interfaces. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/imx25_pdk.c | 14 -- hw/arm/imx8mp-evk.c

[RFC PATCH v2 11/11] hw/arm/raspi: Build objects once

2025-04-17 Thread Philippe Mathieu-Daudé
Now than Raspi machines can be filtered when running a qemu-system-arm or qemu-system-aarch64 binary, we can remove the TARGET_AARCH64 #ifdef'ry and compile the aspeed.c file once, moving it from arm_ss[] source set to arm_common_ss[]. Note, we expose the TYPE_BCM2837 type to qemu-system-arm, but i

Re: [RFC PATCH v2 03/11] system/vl: Filter machine list available for a particular target binary

2025-04-17 Thread Pierrick Bouvier
On 4/17/25 17:50, Philippe Mathieu-Daudé wrote: Binaries can register a QOM type to filter their machines by filling their TargetInfo::machine_typename field. Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/target_info-impl.h | 3 +++ include/qemu/target_info.h | 8 s

Re: [RFC PATCH v2 08/11] config/target: Implement per-binary TargetInfo structure (ARM)

2025-04-17 Thread Pierrick Bouvier
On 4/17/25 17:50, Philippe Mathieu-Daudé wrote: If a file defining the binary TargetInfo structure is available, link with it. Otherwise keep using the stub. Implement such structure for arm-softmmu. Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 7 ++- config

Re: [RFC PATCH v2 11/11] hw/arm/raspi: Build objects once

2025-04-17 Thread Pierrick Bouvier
On 4/17/25 17:50, Philippe Mathieu-Daudé wrote: Now than Raspi machines can be filtered when running a qemu-system-arm or qemu-system-aarch64 binary, we can remove the TARGET_AARCH64 #ifdef'ry and compile the aspeed.c file once, moving it from arm_ss[] source set to arm_common_ss[]. Note, we expo

Re: [RFC PATCH v2 10/11] hw/arm/aspeed: Build objects once

2025-04-17 Thread Pierrick Bouvier
On 4/17/25 17:50, Philippe Mathieu-Daudé wrote: Now than Aspeed machines can be filtered when running a qemu-system-arm or qemu-system-aarch64 binary, we can remove the TARGET_AARCH64 #ifdef'ry and compile the aspeed.c file once, moving it from arm_ss[] source set to arm_common_ss[]. Signed-off-

Re: [RFC PATCH v2 08/11] config/target: Implement per-binary TargetInfo structure (ARM)

2025-04-17 Thread Pierrick Bouvier
On 4/17/25 17:50, Philippe Mathieu-Daudé wrote: If a file defining the binary TargetInfo structure is available, link with it. Otherwise keep using the stub. Implement such structure for arm-softmmu. Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 7 ++- config

Re: [PATCH v5 0/3] vhost: fix the IO error after live migration

2025-04-17 Thread Lei Yang
I tested this series of patches v5 with virtio-net regression tests, everything works fine. Tested-by: Lei Yang On Wed, Apr 16, 2025 at 10:49 AM Haoqian He wrote: > > At the end of the VM live migration, the vhost device will be stopped. > Currently, if the vhost-user backend crashes, vhost dev

Re: [PATCH v4 04/13] memory: Introduce generic state change parent class for RamDiscardManager

2025-04-17 Thread Chenyi Qiang
On 4/18/2025 7:10 AM, Alexey Kardashevskiy wrote: > > > On 16/4/25 13:32, Chenyi Qiang wrote: >> >> >> On 4/10/2025 9:44 AM, Chenyi Qiang wrote: >>> >>> >>> On 4/10/2025 8:11 AM, Alexey Kardashevskiy wrote: On 9/4/25 22:57, Chenyi Qiang wrote: > > > On 4/9/2025 5:56

Re: [RFC PATCH v2 07/11] hw/core: Allow ARM/Aarch64 binaries to use the 'none' machine

2025-04-17 Thread Pierrick Bouvier
On 4/17/25 17:50, Philippe Mathieu-Daudé wrote: When we'll start to use target_machine_interface_typename() to filter machines for the ARM/Aarch64 binaries, the 'none' machine will be filtered out. Register the proper interfaces to keep it available. Signed-off-by: Philippe Mathieu-Daudé ---

[PATCH v3] target/loongarch: Restrict instruction execution based on CPU features

2025-04-17 Thread WANG Rui
Previously, some instructions could be executed regardless of CPU mode or feature support. This patch enforces proper checks so that instructions are only allowed when the required CPU features are enabled. Signed-off-by: WANG Rui --- target/loongarch/cpu.c| 4 +-- targe

Re: [RFC PATCH v2 06/11] hw/arm: Filter machine types for qemu-system-arm binary

2025-04-17 Thread Pierrick Bouvier
On 4/17/25 17:50, Philippe Mathieu-Daudé wrote: Very few machines are restricted to the qemu-system-aarch64 binary: $ git grep TARGET_AARCH64 hw/arm/meson.build hw/arm/meson.build:31:arm_common_ss.add(when: ['CONFIG_RASPI', 'TARGET_AARCH64'], if_true: files('bcm2838.c', 'raspi4b.c')) h

Re: [RFC PATCH v2 04/11] hw/arm: Register TYPE_TARGET_ARM/AARCH64_CPU QOM interfaces

2025-04-17 Thread Pierrick Bouvier
On 4/17/25 17:50, Philippe Mathieu-Daudé wrote: Define the TYPE_TARGET_ARM_MACHINE and TYPE_TARGET_AARCH64_MACHINE QOM interface names to allow machines to implement them. Signed-off-by: Philippe Mathieu-Daudé --- meson.build| 1 + include/hw/boards.h| 1 +

Re: [RFC PATCH v2 02/11] qemu: Convert target_name() to TargetInfo API

2025-04-17 Thread Pierrick Bouvier
On 4/17/25 17:50, Philippe Mathieu-Daudé wrote: Have target_name() be a target-agnostic method, dispatching to a per-target TargetInfo singleton structure. By default a stub singleton is used. No logical change expected. Inspired-by: Pierrick Bouvier Signed-off-by: Philippe Mathieu-Daudé Revie

Re: [RFC PATCH v2 01/11] qapi: Rename TargetInfo structure as BinaryTargetInfo

2025-04-17 Thread Pierrick Bouvier
On 4/17/25 17:50, Philippe Mathieu-Daudé wrote: The QAPI-generated 'TargetInfo' structure name is only used in a single file. We want to heavily use another structure similarly named. Rename the QAPI one, since structure names are not part of the public API. Suggested-by: Pierrick Bouvier Signe

Re: [PATCH 00/11] hw/arm: Define machines as generic QOM types

2025-04-17 Thread Pierrick Bouvier
On 4/17/25 16:58, Philippe Mathieu-Daudé wrote: While DEFINE_MACHINE() is a succinct macro, it doesn't allow registering QOM interfaces to the defined machine. Convert to the generic DEFINE_TYPES() in preparation to register interfaces. Philippe Mathieu-Daudé (11): hw/core/null-machine: Defin

Re: [PATCH v7 1/4] vhost_vdpa : Add a new parameter to enable check mac address

2025-04-17 Thread Lei Yang
I tested this series of patches v7 with virtio-net regression tests, everything works fine. Tested-by: Lei Yang On Thu, Apr 17, 2025 at 6:26 PM Cindy Lu wrote: > > When using a VDPA device, it's important to ensure that the MAC > address is correctly set. > This patch adds a new QEMU command li

Re: [PATCH v6 3/3] hw/ppc/e500: Add Freescale eSDHC to e500plat

2025-04-17 Thread Thomas Huth
On 01/11/2022 23.29, Philippe Mathieu-Daudé wrote: Adds missing functionality to e500plat machine which increases the chance of given "real" firmware images to access SD cards. Signed-off-by: Bernhard Beschow Message-Id: <20221018210146.193159-8-shen...@gmail.com> [PMD: Simplify using create_un

[RFC PATCH v2 02/11] qemu: Convert target_name() to TargetInfo API

2025-04-17 Thread Philippe Mathieu-Daudé
Have target_name() be a target-agnostic method, dispatching to a per-target TargetInfo singleton structure. By default a stub singleton is used. No logical change expected. Inspired-by: Pierrick Bouvier Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Pierrick Bouvier --- meson.build

[RFC PATCH v2 04/11] hw/arm: Register TYPE_TARGET_ARM/AARCH64_CPU QOM interfaces

2025-04-17 Thread Philippe Mathieu-Daudé
Define the TYPE_TARGET_ARM_MACHINE and TYPE_TARGET_AARCH64_MACHINE QOM interface names to allow machines to implement them. Signed-off-by: Philippe Mathieu-Daudé --- meson.build| 1 + include/hw/boards.h| 1 + include/qemu/target_info-qom.h | 18

[RFC PATCH v2 03/11] system/vl: Filter machine list available for a particular target binary

2025-04-17 Thread Philippe Mathieu-Daudé
Binaries can register a QOM type to filter their machines by filling their TargetInfo::machine_typename field. Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/target_info-impl.h | 3 +++ include/qemu/target_info.h | 8 system/vl.c | 14 ++ t

[RFC PATCH v2 06/11] hw/arm: Filter machine types for qemu-system-arm binary

2025-04-17 Thread Philippe Mathieu-Daudé
Very few machines are restricted to the qemu-system-aarch64 binary: $ git grep TARGET_AARCH64 hw/arm/meson.build hw/arm/meson.build:31:arm_common_ss.add(when: ['CONFIG_RASPI', 'TARGET_AARCH64'], if_true: files('bcm2838.c', 'raspi4b.c')) hw/arm/meson.build:50:arm_common_ss.add(when: ['CONFIG

[RFC PATCH v2 09/11] config/target: Implement per-binary TargetInfo structure (Aarch64)

2025-04-17 Thread Philippe Mathieu-Daudé
Implement the TargetInfo structure for qemu-system-aarch64 binary. Signed-off-by: Philippe Mathieu-Daudé --- configs/targets/aarch64-softmmu.c | 22 ++ 1 file changed, 22 insertions(+) create mode 100644 configs/targets/aarch64-softmmu.c diff --git a/configs/targets/aarch64

[RFC PATCH v2 08/11] config/target: Implement per-binary TargetInfo structure (ARM)

2025-04-17 Thread Philippe Mathieu-Daudé
If a file defining the binary TargetInfo structure is available, link with it. Otherwise keep using the stub. Implement such structure for arm-softmmu. Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 7 ++- configs/targets/arm-softmmu.c | 22 ++

[RFC PATCH v2 05/11] hw/arm: Filter machine types for qemu-system-aarch64 binary

2025-04-17 Thread Philippe Mathieu-Daudé
Since the qemu-system-aarch64 binary is able to run all machines indistinctly, simply register the TYPE_TARGET_AARCH64_MACHINE interface for all existing machines under the hw/arm/ directory. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/aspeed.c| 88 ++

[RFC PATCH v2 00/11] single-binary: Make hw/arm/ common

2025-04-17 Thread Philippe Mathieu-Daudé
Since v1: - Dropped unrelated / irrelevant patches - Addressed Pierrick comments - Added R-b tag - Only considering machines, not CPUs. Hi, At this point this series is mostly a draft for Pierrick. After introducing the generic TargetInfo API [*], we implement the ARM variants, then use the API

[PATCH 00/11] hw/arm: Define machines as generic QOM types

2025-04-17 Thread Philippe Mathieu-Daudé
While DEFINE_MACHINE() is a succinct macro, it doesn't allow registering QOM interfaces to the defined machine. Convert to the generic DEFINE_TYPES() in preparation to register interfaces. Philippe Mathieu-Daudé (11): hw/core/null-machine: Define machine as generic QOM type hw/arm/bananapi: De

Re: [PATCH v6 0/6] target/i386: Update EPYC CPU models for Cache property, RAS, SVM feature and add EPYC-Turin CPU model

2025-04-17 Thread Moger, Babu
Hi Paolo, On 3/7/2025 4:47 PM, Moger, Babu wrote: Hi Paolo, Can you please pull these series if you don't have any concerns. Thanks Babu On 2/28/2025 12:07 PM, Babu Moger wrote: Following changes are implemented in this series. 1. Fixed the cache(L2,L3) property details in all the EPYC mod

Re: [PATCH] mailmap: update email address for Matheus Tavares (me)

2025-04-17 Thread Brian Cain
On 4/17/2025 11:33 AM, Matheus Tavares Bernardino wrote: This is the new email I'll be using from now on. Signed-off-by: Matheus Tavares Bernardino --- Reviewed-by: Brian Cain Tested-by: Brian Cain .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap in

Re: [PATCH] exec: Rename target_words_bigendian() -> target_big_endian()

2025-04-17 Thread Pierrick Bouvier
On 4/17/25 14:00, Philippe Mathieu-Daudé wrote: In commit 98ed8ecfc9d ("exec: introduce target_words_bigendian() helper") target_words_bigendian() was matching the definition it was depending on (TARGET_WORDS_BIGENDIAN). Later in commit ee3eb3a7ce7 ("Replace TARGET_WORDS_BIGENDIAN") the definitio

[PATCH 11/11] hw/arm/stm32: Define machines as generic QOM types

2025-04-17 Thread Philippe Mathieu-Daudé
While DEFINE_MACHINE() is a succinct macro, it doesn't allow registering QOM interfaces to the defined machine. Convert to the generic DEFINE_TYPES() in preparation to register interfaces. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/netduino2.c | 13 +++-- hw/arm/netduinoplu

[PATCH 08/11] hw/arm/msf2: Define machine as generic QOM type

2025-04-17 Thread Philippe Mathieu-Daudé
While DEFINE_MACHINE() is a succinct macro, it doesn't allow registering QOM interfaces to the defined machine. Convert to the generic DEFINE_TYPES() in preparation to register interfaces. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/msf2-som.c | 13 +++-- 1 file changed, 11 insertio

[PATCH 10/11] hw/arm/orangepi: Define machine as generic QOM type

2025-04-17 Thread Philippe Mathieu-Daudé
While DEFINE_MACHINE() is a succinct macro, it doesn't allow registering QOM interfaces to the defined machine. Convert to the generic DEFINE_TYPES() in preparation to register interfaces. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/orangepi.c | 13 +++-- 1 file changed, 11 insertio

[PATCH 07/11] hw/arm/kzm: Define machine as generic QOM type

2025-04-17 Thread Philippe Mathieu-Daudé
While DEFINE_MACHINE() is a succinct macro, it doesn't allow registering QOM interfaces to the defined machine. Convert to the generic DEFINE_TYPES() in preparation to register interfaces. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/kzm.c | 14 -- 1 file changed, 12 insertions(+

[PATCH 09/11] hw/arm/musicpal: Define machine as generic QOM type

2025-04-17 Thread Philippe Mathieu-Daudé
While DEFINE_MACHINE() is a succinct macro, it doesn't allow registering QOM interfaces to the defined machine. Convert to the generic DEFINE_TYPES() in preparation to register interfaces. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/musicpal.c | 16 +--- 1 file changed, 13 inser

[PATCH 03/11] hw/arm/cubieboard: Define machine as generic QOM type

2025-04-17 Thread Philippe Mathieu-Daudé
While DEFINE_MACHINE() is a succinct macro, it doesn't allow registering QOM interfaces to the defined machine. Convert to the generic DEFINE_TYPES() in preparation to register interfaces. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/cubieboard.c | 13 +++-- 1 file changed, 11 insert

[PATCH 06/11] hw/arm/integratorcp: Define machine as generic QOM type

2025-04-17 Thread Philippe Mathieu-Daudé
While DEFINE_MACHINE() is a succinct macro, it doesn't allow registering QOM interfaces to the defined machine. Convert to the generic DEFINE_TYPES() in preparation to register interfaces. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/integratorcp.c | 16 +--- 1 file changed, 13 i

Re: [PATCH v4 04/13] memory: Introduce generic state change parent class for RamDiscardManager

2025-04-17 Thread Alexey Kardashevskiy
On 16/4/25 13:32, Chenyi Qiang wrote: On 4/10/2025 9:44 AM, Chenyi Qiang wrote: On 4/10/2025 8:11 AM, Alexey Kardashevskiy wrote: On 9/4/25 22:57, Chenyi Qiang wrote: On 4/9/2025 5:56 PM, Alexey Kardashevskiy wrote: On 7/4/25 17:49, Chenyi Qiang wrote: RamDiscardManager is an in

Re: [PATCH v2 11/11] mirror: Allow QMP override to declare target already zero

2025-04-17 Thread Stefan Hajnoczi
On Thu, Apr 17, 2025 at 01:39:16PM -0500, Eric Blake wrote: > QEMU's attempts to learn whether a destination file starts life with > all zero contents are just a heuristic. There may be cases where the > caller is aware of information that QEMU cannot learn quickly, in > which case telling QEMU wh

Re: [PATCH v2 05/11] iotests: Improve iotest 194 to mirror data

2025-04-17 Thread Stefan Hajnoczi
On Thu, Apr 17, 2025 at 01:39:10PM -0500, Eric Blake wrote: > Mirroring a completely sparse image to a sparse destination should be > practically instantaneous. It isn't yet, but the test will be more > realistic if it has some non-zero to mirror as well as the holes. > > Signed-off-by: Eric Blak

Re: [PATCH v1 17/24] pc-bios/s390-ccw: Add signature verification for secure boot in audit mode

2025-04-17 Thread Collin Walling
On 4/8/25 11:55 AM, Zhuoying Cai wrote: > Enable secure IPL in audit mode, which performs signature verification, > but any error does not terminate the boot process. Only warnings will be > logged to the console instead. > > Add a comp_len variable to store the length of a segment in > zipl_load_

[PATCH v2 07/11] mirror: Skip pre-zeroing destination if it is already zero

2025-04-17 Thread Eric Blake
When doing a sync=full mirroring, QMP drive-mirror requests full zeroing if it did not just create the destination, and blockdev-mirror requests full zeroing unconditionally. This is because during a full sync, we must ensure that the portions of the disk that are not otherwise touched by the sour

Re: [PATCH v2 07/11] mirror: Skip pre-zeroing destination if it is already zero

2025-04-17 Thread Stefan Hajnoczi
On Thu, Apr 17, 2025 at 01:39:12PM -0500, Eric Blake wrote: > When doing a sync=full mirroring, QMP drive-mirror requests full > zeroing if it did not just create the destination, and blockdev-mirror > requests full zeroing unconditionally. This is because during a full > sync, we must ensure that

[PATCH v4 2/2] block/io: skip head/tail requests on EINVAL

2025-04-17 Thread Stefan Hajnoczi
When guests send misaligned discard requests, the block layer breaks them up into a misaligned head, an aligned main body, and a misaligned tail. The file-posix block driver on Linux returns -EINVAL on misaligned discard requests. This causes bdrv_co_pdiscard() to fail and guests configured with w

Re: [PATCH v1 24/24] hw/s390x/ipl: Handle secure boot without specifying a boot device

2025-04-17 Thread Zhuoying Cai
On 4/16/25 6:11 PM, Collin Walling wrote: > On 4/8/25 11:55 AM, Zhuoying Cai wrote: >> If secure boot in audit mode or True Secure IPL mode is enabled without >> specifying a boot device, the boot process will terminate with an error. >> >> Signed-off-by: Zhuoying Cai >> --- >> hw/s390x/ipl.c |

[PATCH 5/8] target/xtensa: Evaluate TARGET_BIG_ENDIAN at compile time

2025-04-17 Thread Philippe Mathieu-Daudé
Rather than evaluating TARGET_BIG_ENDIAN at preprocessing time via #ifdef'ry, do it in C at compile time Signed-off-by: Philippe Mathieu-Daudé --- target/xtensa/translate.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/target/xtensa/translate.c b/target/xtensa/tr

Re: [PATCH-for-10.1 v3 6/9] qtest/bios-tables-test: Whitelist aarch64/virt 'its_off' variant blobs

2025-04-17 Thread Michael S. Tsirkin
On Thu, Apr 17, 2025 at 06:06:14PM -0300, Gustavo Romero wrote: > Hi Igor and Michael, > > On 4/10/25 13:22, Gustavo Romero wrote: > > Hi Igor, > > > > On 4/10/25 03:50, Igor Mammedov wrote: > > > On Wed, 9 Apr 2025 12:49:36 -0300 > > > Gustavo Romero wrote: > > > > > > > Hi Igor, > > > > > >

Re: [PATCH v6 3/3] hw/ppc/e500: Add Freescale eSDHC to e500plat

2025-04-17 Thread BALATON Zoltan
On Thu, 17 Apr 2025, Thomas Huth wrote: On 01/11/2022 23.29, Philippe Mathieu-Daudé wrote: Adds missing functionality to e500plat machine which increases the chance of given "real" firmware images to access SD cards. Signed-off-by: Bernhard Beschow Message-Id: <20221018210146.193159-8-shen...@

[PATCH v2 5/5] qapi: delete un-needed python static analysis configs

2025-04-17 Thread John Snow
Since the previous commit, python/setup.cfg applies to scripts/qapi/ as well. Configuration files in scripts/qapi/ override python/setup.cfg. scripts/qapi/.flake8 and scripts/qapi/.isort.cfg actually match python/setup.cfg exactly, and can go. The differences between scripts/qapi/mypy.ini and py

[PATCH v2 4/5] python: add qapi static analysis tests

2025-04-17 Thread John Snow
Update the python tests to also check QAPI and the QAPI Sphinx extensions. The docs/sphinx/qapidoc_legacy.py file is not included in these checks, as it is destined for removal soon. mypy is also not called on the QAPI Sphinx extensions, owing to difficulties supporting Sphinx 3.x - 8.x while maint

[PATCH v2 2/5] docs/qapidoc: linting fixes

2025-04-17 Thread John Snow
This restores the linting baseline in qapidoc. The order of some imports change slightly here due to configuring isort a little better: previously, isort was having difficulty understanding that "compat" and "qapidoc_legacy" were local modules because docs/sphinx "isn't a python package". Configuri

[PATCH v2 0/5] python: add QAPI and qapidoc et al to python linter tests

2025-04-17 Thread John Snow
Hiya, this series turns on automated linting for scripts/qapi, docs/sphinx/qapidoc.py and docs/sphinx/qapi_domain.py. This includes flake8/isort/pylint/mypy for scripts/qapi, but omits mypy from the Sphinx plugins owing to my inability to strictly type the extensions given the wide versions of Sph

[PATCH] block/file-posix: allow BLKZEROOUT with -t writeback

2025-04-17 Thread Stefan Hajnoczi
The Linux BLKZEROOUT ioctl is only invoked when BDRV_O_NOCACHE is set because old kernels did not invalidate the page cache. In that case mixing BLKZEROOUT with buffered I/O could lead to corruption. However, Linux 4.9 commit 22dd6d356628 ("block: invalidate the page cache when issuing BLKZEROOUT"

Re: [PATCH v2 02/11] file-posix: Handle zero block status hint better

2025-04-17 Thread Stefan Hajnoczi
On Thu, Apr 17, 2025 at 01:39:07PM -0500, Eric Blake wrote: > Although the previous patch to change 'bool want_zero' into an enum > made no semantic change, it is now time to differentiate. When the > caller specifically wants to know what parts of the file read as zero, > we need to use lseek and

Re: [PATCH-for-10.1 v3 0/9] hw/arm: GIC ITS=off ACPI tables fixes

2025-04-17 Thread Gustavo Romero
Hi Phil, On 4/15/25 05:19, Philippe Mathieu-Daudé wrote: Hi Gustavo, Could you take over this series? You seem better suited with ACPI and testing with Aarch64 virt machine :) Thanks, Sure. I just need to clarify a couple of things regarding the IORT spec. Meanwhile I'm (hopefully) waiting I

[PATCH] exec: Rename target_words_bigendian() -> target_big_endian()

2025-04-17 Thread Philippe Mathieu-Daudé
In commit 98ed8ecfc9d ("exec: introduce target_words_bigendian() helper") target_words_bigendian() was matching the definition it was depending on (TARGET_WORDS_BIGENDIAN). Later in commit ee3eb3a7ce7 ("Replace TARGET_WORDS_BIGENDIAN") the definition was renamed as TARGET_BIG_ENDIAN but we didn't u

Re: [PATCH v2 00/11] Make blockdev-mirror dest sparse in more cases

2025-04-17 Thread Stefan Hajnoczi
Looks good overall. I left some comments on individual patches. Maybe one day qemu-img convert and the mirror blockjob can be unified. The write zeroes logic is duplicated. Stefan signature.asc Description: PGP signature

Re: [PATCH v2 10/11] tests: Add iotest mirror-sparse for recent patches

2025-04-17 Thread Stefan Hajnoczi
On Thu, Apr 17, 2025 at 01:39:15PM -0500, Eric Blake wrote: > Prove that blockdev-mirror can now result in sparse raw destination > files, regardless of whether the source is raw or qcow2. By making > this a separate test, it was possible to test effects of individual > patches for the various pie

Re: [PATCH v2 09/11] iotests/common.rc: add disk_usage function

2025-04-17 Thread Stefan Hajnoczi
On Thu, Apr 17, 2025 at 01:39:14PM -0500, Eric Blake wrote: > From: Andrey Drobyshev > > Move the definition from iotests/250 to common.rc. This is used to > detect real disk usage of sparse files. In particular, we want to use > it for checking subclusters-based discards. > > Signed-off-by: A

Re: [PATCH v2 08/11] mirror: Skip writing zeroes when target is already zero

2025-04-17 Thread Stefan Hajnoczi
On Thu, Apr 17, 2025 at 01:39:13PM -0500, Eric Blake wrote: > When mirroring, the goal is to ensure that the destination reads the > same as the source; this goal is met whether the destination is sparse > or fully-allocated. However, if the destination cannot efficiently > write zeroes, then any

Re: [PATCH v2 06/11] mirror: Minor refactoring

2025-04-17 Thread Stefan Hajnoczi
On Thu, Apr 17, 2025 at 01:39:11PM -0500, Eric Blake wrote: > Commit 5791ba52 (v9.2) pre-initialized ret in mirror_dirty_init to > silence a false positive compiler warning, even though in all code > paths where ret is used, it was guaranteed to be reassigned > beforehand. But since the function r

Re: [PATCH v2 04/11] block: Add new bdrv_co_is_all_zeroes() function

2025-04-17 Thread Stefan Hajnoczi
On Thu, Apr 17, 2025 at 01:39:09PM -0500, Eric Blake wrote: > There are some optimizations that require knowing if an image starts > out as reading all zeroes, such as making blockdev-mirror faster by > skipping the copying of source zeroes to the destination. The > existing bdrv_co_is_zero_fast()

Re: [PATCH v2 03/11] block: Let bdrv_co_is_zero_fast consolidate adjacent extents

2025-04-17 Thread Stefan Hajnoczi
On Thu, Apr 17, 2025 at 01:39:08PM -0500, Eric Blake wrote: > Some BDS drivers have a cap on how much block status they can supply > in one query (for example, NBD talking to an older server cannot > inspect more than 4G per query; and qcow2 tends to cap its answers > rather than cross a cluster bo

Re: [PATCH v3 2/2] block/io: skip head/tail requests on EINVAL

2025-04-17 Thread Eric Blake
On Thu, Apr 17, 2025 at 10:49:55AM +0200, Kevin Wolf wrote: > Am 14.04.2025 um 22:12 hat Stefan Hajnoczi geschrieben: > > When guests send misaligned discard requests, the block layer breaks > > them up into a misaligned head, an aligned main body, and a misaligned > > tail. > > > > The file-posix

[PATCH v4 0/3] DIAG 308: extend subcode 10 to return UVC cmd id, RC and RRC values upon failure to enter secure mode

2025-04-17 Thread Gautam Gala
DIAG 308 (subcode 10 - performing secure execution unpack) response code when the configuration is unable to enter secure mode has limited usability as it is a fixed value (0xa02) for variety of different reasons. The aim is to extend this DIAG to return UVC command ID, RC and RRC values in additio

Re: [PATCH v1 06/24] s390x/diag: Implement DIAG 320 subcode 1

2025-04-17 Thread Collin Walling
On 4/11/25 9:57 AM, Thomas Huth wrote: > On 08/04/2025 17.55, Zhuoying Cai wrote: >> DIAG 320 subcode 1 provides information needed to determine >> the amount of storage to store one or more certificates. >> >> The subcode value is denoted by setting the left-most bit >> of an 8-byte field. >> >> T

Re: [PATCH v3 0/7] cpus: Convert cpu_list definition to CPUClass:list_cpus callback

2025-04-17 Thread Philippe Mathieu-Daudé
On 24/3/25 19:58, Philippe Mathieu-Daudé wrote: Based-on: <20250324165356.39540-1-phi...@linaro.org> Philippe Mathieu-Daudé (7): cpus: Introduce CPUClass::list_cpus() callback target/i386: Register CPUClass:list_cpus target/ppc: Register CPUClass:list_cpus target/sparc: Register CPU

Re: [PATCH 4/8] target/ppc: Evaluate TARGET_BIG_ENDIAN at compile time

2025-04-17 Thread Pierrick Bouvier
On 4/17/25 06:10, Philippe Mathieu-Daudé wrote: Rather than evaluating TARGET_BIG_ENDIAN at preprocessing time via #ifdef'ry, do it in C at compile time Signed-off-by: Philippe Mathieu-Daudé --- target/ppc/cpu_init.c | 12 ++-- target/ppc/mem_helper.c | 6 +- target/ppc/trans

Re: CRITICAL Unexpected bottom half exception

2025-04-17 Thread John Snow
How exciting! Can you give me some more information on what occurred? - What is your operating system? - What were you in the process of doing at the time? (It looks like it died during the initial connection attempt) - Did this happen inside of another application, or a script you wrote, or in th

Re: [RFC PATCH-for-10.1 17/19] accel: Move target-agnostic code from accel-target.c -> accel-common.c

2025-04-17 Thread Philippe Mathieu-Daudé
On 4/4/25 18:59, Pierrick Bouvier wrote: On 4/3/25 16:49, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé ---   accel/accel-common.c | 142 +++   accel/accel-target.c | 129 ---   accel/meson.build   

Re: [PATCH 0/7] cpus: Replace CPU_RESOLVING_TYPE -> target_cpu_type()

2025-04-17 Thread Pierrick Bouvier
On 4/17/25 11:38, Philippe Mathieu-Daudé wrote: On 17/4/25 20:28, Pierrick Bouvier wrote: Maybe it would be preferable to focus on providing a minimal but *complete* TargetInfo before upstreaming any of this, as it's really blocking the rest of the work for single binary. I suppose I misunders

Re: [PATCH 09/11] qapi/qapi-schema: Address the introduction's bit rot

2025-04-17 Thread John Snow
On Fri, Apr 4, 2025 at 8:14 AM Markus Armbruster wrote: > Cut the crap that stopped making sense years ago. Adjust the > remainder. > > Signed-off-by: Markus Armbruster > --- > qapi/qapi-schema.json | 27 +++ > 1 file changed, 7 insertions(+), 20 deletions(-) > > diff -

Re: [PATCH v1 14/24] s390x: Guest support for Secure-IPL Facility

2025-04-17 Thread Collin Walling
On 4/8/25 11:55 AM, Zhuoying Cai wrote: > Introduce Secure-IPL (SIPL) facility. > > Use the abbreviation CBL (Consolidated-Boot-Loader facility at bit 0 of > byte 136) to represent bytes 136 and 137 for IPL device facilities of the > SCLP Read Info block. This should *not* be used to label these

[PATCH v3 14/22] arm: qemu: Add an SPL build

2025-04-17 Thread Simon Glass
Add an SPL build for qemu so we can test the standard passage feature. Include a binman definition so that SPL and U-Boot are in the same image. This requires adding a proper devicetree file for qemu_arm. It is only used for the SPL build. Avoid using the QEMU devicetree in U-Boot proper, so we c

Re: [RFC V3 PATCH 02/13] test/acpi: allow DSDT table changes for x86 platform

2025-04-17 Thread Annie Li
Hi Gustavo, On 4/17/2025 1:29 PM, Gustavo Romero wrote: Hi Annie, On 4/11/25 17:31, Annie Li wrote: list changed files in tests/qtest/bios-tables-test-allowed-diff.h nit: List Will fix it. Thanks Annie Signed-off-by: Annie Li ---   tests/qtest/bios-tables-test-allowed-diff.h | 42 +

Re: [RFC V3 PATCH 07/13] microvm: support control method sleep button

2025-04-17 Thread Annie Li
Hi Gustavo, On 4/17/2025 1:34 PM, Gustavo Romero wrote: Hi Annie, On 4/11/25 17:42, Annie Li wrote: Add the support of control method sleep button and System S3 Sleeping State for microvm. I would say "... of ACPI Control Method Sleeping Button ...¨, the important part being "ACPI" to make c

[PATCH v2 02/11] file-posix: Handle zero block status hint better

2025-04-17 Thread Eric Blake
Although the previous patch to change 'bool want_zero' into an enum made no semantic change, it is now time to differentiate. When the caller specifically wants to know what parts of the file read as zero, we need to use lseek and actually reporting holes, rather than short-circuiting and advertis

Re: [RFC V3 PATCH 05/13] acpi: Send the GPE event of suspend and wakeup for x86

2025-04-17 Thread Annie Li
Hi Gustavo, On 4/17/2025 1:32 PM, Gustavo Romero wrote: Hi Annie, On 4/16/25 03:24, Philippe Mathieu-Daudé wrote: On 15/4/25 23:48, Annie Li wrote: On 4/15/2025 11:29 AM, Philippe Mathieu-Daudé wrote: Hi Annie, On 15/4/25 03:24, Annie Li wrote: On 4/14/2025 11:18 AM, Alex Bennée wrote:

Re: [RFC PATCH-for-10.1 07/19] target/hppa: Replace TARGET_LONG_BITS -> target_long_bits()

2025-04-17 Thread Paolo Bonzini
On 4/4/25 01:49, Philippe Mathieu-Daudé wrote: @@ -101,7 +102,7 @@ static void hppa_flush_tlb_ent(CPUHPPAState *env, HPPATLBEntry *ent, tlb_flush_range_by_mmuidx(cs, ent->itree.start, ent->itree.last - ent->itree.start + 1, -

Re: [RFC V3 PATCH 05/13] acpi: Send the GPE event of suspend and wakeup for x86

2025-04-17 Thread Annie Li
Hi Gustavo, On 4/17/2025 1:40 PM, Gustavo Romero wrote: Hi Annie, Some additional comments I forgot :) On 4/11/25 17:41, Annie Li wrote: The GPE event is triggered to notify x86 guest to suppend nit ^ suspend But I prefer to stick with "slee

Re: [RFC PATCH 05/13] migration: Reduce a bit of duplication in migration.json

2025-04-17 Thread Markus Armbruster
Fabiano Rosas writes: > Introduce a new MigrationConfigBase, to allow most of the duplication > in migration.json to be eliminated. > > The reason we need MigrationParameters and MigrationSetParameters is > that the internal parameter representation in the migration code, as > well as the user-fa

Re: [RFC V3 PATCH 04/13] tests/qtest/bios-table-tests: Update ACPI table binaries for x86

2025-04-17 Thread Annie Li
Hi Gustavo, On 4/17/2025 1:31 PM, Gustavo Romero wrote: Hi Annie, On 4/11/25 17:39, Annie Li wrote: Following is the diff generated by the step 5 and 6 in tests/qtest/bios-tables-test.c Diff from iasl to show changes in DSDT table: --- /tmp/asl-34PV42.dsl 2025-04-09 19:04:34.846646690 +

[PATCH v2 08/11] mirror: Skip writing zeroes when target is already zero

2025-04-17 Thread Eric Blake
When mirroring, the goal is to ensure that the destination reads the same as the source; this goal is met whether the destination is sparse or fully-allocated. However, if the destination cannot efficiently write zeroes, then any time the mirror operation wants to copy zeroes from the source to th

[PATCH v2 03/11] block: Let bdrv_co_is_zero_fast consolidate adjacent extents

2025-04-17 Thread Eric Blake
Some BDS drivers have a cap on how much block status they can supply in one query (for example, NBD talking to an older server cannot inspect more than 4G per query; and qcow2 tends to cap its answers rather than cross a cluster boundary of an L1 table). Although the existing callers of bdrv_co_is

[PATCH v2 01/11] block: Expand block status mode from bool to enum

2025-04-17 Thread Eric Blake
This patch is purely mechanical, changing bool want_zero into a new enum BlockStatusMode. As of this patch, all implementations are unchanged (the old want_zero==true is now mode==BDRV_BSTAT_PRECISE), but the callers in io.c are set up so that future patches will be able to differente between whet

[PATCH v2 10/11] tests: Add iotest mirror-sparse for recent patches

2025-04-17 Thread Eric Blake
Prove that blockdev-mirror can now result in sparse raw destination files, regardless of whether the source is raw or qcow2. By making this a separate test, it was possible to test effects of individual patches for the various pieces that all have to work together for a sparse mirror to be success

[PATCH v2 09/11] iotests/common.rc: add disk_usage function

2025-04-17 Thread Eric Blake
From: Andrey Drobyshev Move the definition from iotests/250 to common.rc. This is used to detect real disk usage of sparse files. In particular, we want to use it for checking subclusters-based discards. Signed-off-by: Andrey Drobyshev Reviewed-by: Alexander Ivanov Reviewed-by: Alberto Garci

[PATCH v2 11/11] mirror: Allow QMP override to declare target already zero

2025-04-17 Thread Eric Blake
QEMU's attempts to learn whether a destination file starts life with all zero contents are just a heuristic. There may be cases where the caller is aware of information that QEMU cannot learn quickly, in which case telling QEMU what to assume about the destination can make the mirror operation fas

[PATCH v2 05/11] iotests: Improve iotest 194 to mirror data

2025-04-17 Thread Eric Blake
Mirroring a completely sparse image to a sparse destination should be practically instantaneous. It isn't yet, but the test will be more realistic if it has some non-zero to mirror as well as the holes. Signed-off-by: Eric Blake --- tests/qemu-iotests/194 | 1 + 1 file changed, 1 insertion(+)

[PATCH v2 04/11] block: Add new bdrv_co_is_all_zeroes() function

2025-04-17 Thread Eric Blake
There are some optimizations that require knowing if an image starts out as reading all zeroes, such as making blockdev-mirror faster by skipping the copying of source zeroes to the destination. The existing bdrv_co_is_zero_fast() is a good building block for answering this question, but it tends

[PATCH v2 00/11] Make blockdev-mirror dest sparse in more cases

2025-04-17 Thread Eric Blake
V1 was here: https://lists.gnu.org/archive/html/qemu-devel/2025-04/msg01654.html In v2: - Rearrange and split several patches - Fewer changes to file-posix.c; instead, - New bdrv_co_is_all_zeroes() in io.c, which works on both file-posix and NBD - Clean up several corner cases spotted during r

  1   2   3   >