Re: [PATCH] intel_iommu: Take the bql before registering a new address space

2025-04-14 Thread Michael S. Tsirkin
On Tue, Apr 15, 2025 at 06:18:08AM +, CLEMENT MATHIEU--DRIF wrote: > Address space creation might end up being called without holding the > bql as it is exposed through the IOMMU ops. > > Signed-off-by: Clement Mathieu--Drif Indeed, and this can maybe explain some failures we are seeing ...

Re: [PATCH 1/2] hw/i386/amd_iommu: Fix device setup failure when PT is on.

2025-04-14 Thread Sairaj Kodilkar
Hi Alejandro, On 4/15/2025 1:56 AM, Alejandro Jimenez wrote: Hi Sairaj, I'm conflicted by the implementation of the change, so I'd like to make sure I fully understand... On 4/10/25 2:44 AM, Sairaj Kodilkar wrote: Current amd_iommu enables the iommu_nodma address space when pt_supported

Re: [PATCH] intel_iommu: Take the bql before registering a new address space

2025-04-14 Thread Philippe Mathieu-Daudé
On 15/4/25 08:18, CLEMENT MATHIEU--DRIF wrote: Address space creation might end up being called without holding the bql as it is exposed through the IOMMU ops. Signed-off-by: Clement Mathieu--Drif --- hw/i386/intel_iommu.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/i3

Re: [PATCH v4 2/3] include: Add a header to define host PCI MMIO functions

2025-04-14 Thread Philippe Mathieu-Daudé
Hi, On 14/4/25 23:36, Farhan Ali wrote: Add a generic API for host PCI MMIO reads/writes (e.g. Linux VFIO BAR accesses). The functions access little endian memory and returns the result in host cpu endianness. Signed-off-by: Farhan Ali --- include/qemu/host-pci-mmio.h | 141 +

[PATCH] intel_iommu: Take the bql before registering a new address space

2025-04-14 Thread CLEMENT MATHIEU--DRIF
Address space creation might end up being called without holding the bql as it is exposed through the IOMMU ops. Signed-off-by: Clement Mathieu--Drif --- hw/i386/intel_iommu.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index dffd

Re: [PATCH 1/5] target/loongarch: Move header file helper.h to directory tcg

2025-04-14 Thread bibo mao
On 2025/4/15 上午11:22, Richard Henderson wrote: On 4/13/25 18:25, Bibo Mao wrote: +#ifdef CONFIG_TCG +#include "tcg/helper.h"   #endif You don't need the ifdef. This header is only used for tcg. Sure, will remove #ifdef CONFIG_TCG since it is only used by tcg. Regards Bibo Mao r~

Re: Issue with stoptrigger.c Plugin in QEMU Emulation

2025-04-14 Thread Saanjh Sengupta
Hi Alex, The below command line argument works perfectly. ./build/qemu-system-x86_64 -m 2048M -boot c -nographic -serial mon:stdio -nic tap,ifname=tap0,script=no,downscript=no -hda debian11.qcow2 -icount shift=0 -plugin ./build/contrib/plugins/libstoptrigger.so,icount=90 -d plugin -q

Re: [PATCH 1/5] target/loongarch: Move header file helper.h to directory tcg

2025-04-14 Thread Richard Henderson
On 4/13/25 18:25, Bibo Mao wrote: +#ifdef CONFIG_TCG +#include "tcg/helper.h" #endif You don't need the ifdef. This header is only used for tcg. r~

[PATCH v4] target/i386: Fix model number of Zhaoxin YongFeng vCPU template

2025-04-14 Thread Ewan Hai
The model number was mistakenly set to 0x0b (11) in commit ff04bc1ac4. The correct value is 0x5b. This mistake occurred because the extended model bits in cpuid[eax=0x1].eax were overlooked, and only the base model was used. Using the wrong model number can affect guest behavior. One known issue i

Re: [PATCH 1/2] system/main: transfer replay mutex ownership from main thread to main loop thread

2025-04-14 Thread Nicholas Piggin
On Tue Apr 15, 2025 at 1:24 AM AEST, Pierrick Bouvier wrote: > On 4/14/25 03:25, Philippe Mathieu-Daudé wrote: >> On 12/4/25 19:24, Pierrick Bouvier wrote: >>> On 4/11/25 22:30, Nicholas Piggin wrote: On Fri Apr 11, 2025 at 8:55 AM AEST, Pierrick Bouvier wrote: > On MacOS, UI event loop ha

[PATCH v2 1/3] target/s390x: Introduce constant when checking if PV header couldn't be decrypted

2025-04-14 Thread Gautam Gala
Introduce a named constant when checking the Set Secure Configuration parameters UV call return code for the case where no valid host key was found and therefore the PV header couldn't be decrypted (0x108). Reviewed-by: Steffen Eiden Signed-off-by: Gautam Gala --- target/s390x/kvm/pv.c | 3 ++-

Re: [PATCH v3] target/i386: Fix model number of Zhaoxin YongFeng vCPU template

2025-04-14 Thread Ewan Hai
On 4/14/25 11:05 PM, Zhao Liu wrote: On Mon, Apr 14, 2025 at 03:53:42AM -0400, Ewan Hai wrote: Date: Mon, 14 Apr 2025 03:53:42 -0400 From: Ewan Hai Subject: [PATCH v3] target/i386: Fix model number of Zhaoxin YongFeng vCPU template X-Mailer: git-send-email 2.34.1 The model number was mis

Re: [PATCH 4/5] target/loongarch: Set function loongarch_map_address() with common code

2025-04-14 Thread bibo mao
On 2025/4/14 下午6:51, Philippe Mathieu-Daudé wrote: On 14/4/25 03:25, Bibo Mao wrote: Function loongarch_map_address is to get physical address from virtual address, it is used by qmp commands to dump memeory from virtual Typo "memory", Will fix in next version. address. It is used by kv

Re: [RFC V3 PATCH 05/13] acpi: Send the GPE event of suspend and wakeup for x86

2025-04-14 Thread Annie Li
On 4/14/2025 11:18 AM, Alex Bennée wrote: Annie Li writes: The GPE event is triggered to notify x86 guest to suppend itself. The function acpi_send_sleep_event will also trigger GED events on HW-reduced systems where ACPI GED sleep event is supported. Signed-off-by: Annie Li --- hw/acpi/

Re: [PATCH v4 2/3] include: Add a header to define host PCI MMIO functions

2025-04-14 Thread Farhan Ali
On 4/14/2025 2:36 PM, Farhan Ali wrote: Add a generic API for host PCI MMIO reads/writes (e.g. Linux VFIO BAR accesses). The functions access little endian memory and returns the result in host cpu endianness. Signed-off-by: Farhan Ali --- include/qemu/host-pci-mmio.h | 141

Re: [PATCH v2] Revert "virtio-net: Copy received header to buffer"

2025-04-14 Thread Stefan Hajnoczi
On Mon, Apr 14, 2025 at 6:48 PM Michael S. Tsirkin wrote: > > On Thu, Apr 10, 2025 at 03:00:40PM -0400, Stefan Hajnoczi wrote: > > On Tue, Apr 8, 2025 at 10:55 AM Antoine Damhet wrote: > > > > > > This reverts commit 7987d2be5a8bc3a502f89ba8cf3ac3e09f64d1ce. > > > > > > The goal was to remove the

Re: [PATCH] vfio/igd: Check host PCI address when probing

2025-04-14 Thread Alex Williamson
On Sun, 13 Apr 2025 19:30:10 +0800 Tomita Moeko wrote: > On 4/10/25 01:18, Alex Williamson wrote: > > On Wed, 26 Mar 2025 01:22:39 +0800 > > Tomita Moeko wrote: > > > >> So far, all Intel VGA adapters, including discrete GPUs like A770 and > >> B580, were treated as IGD devices. While this ha

Re: [PATCH 1/3] include/hw/pci: Attach BDF to Memory Attributes

2025-04-14 Thread Michael S. Tsirkin
On Sun, Mar 02, 2025 at 05:12:07PM +0800, Jason Chien wrote: > This commit adds the BDF to the memory attributes for DMA operations. > > Signed-off-by: Jason Chien > --- > include/hw/pci/pci_device.h | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/include/hw/

Re: [PATCH v2] Revert "virtio-net: Copy received header to buffer"

2025-04-14 Thread Michael S. Tsirkin
On Thu, Apr 10, 2025 at 03:00:40PM -0400, Stefan Hajnoczi wrote: > On Tue, Apr 8, 2025 at 10:55 AM Antoine Damhet wrote: > > > > This reverts commit 7987d2be5a8bc3a502f89ba8cf3ac3e09f64d1ce. > > > > The goal was to remove the need to patch the (const) input buffer > > with a recomputed UDP checksu

[PATCH v4 2/3] include: Add a header to define host PCI MMIO functions

2025-04-14 Thread Farhan Ali
Add a generic API for host PCI MMIO reads/writes (e.g. Linux VFIO BAR accesses). The functions access little endian memory and returns the result in host cpu endianness. Signed-off-by: Farhan Ali --- include/qemu/host-pci-mmio.h | 141 +++ 1 file changed, 141 inse

Re: [PATCH] vfio/igd: Check host PCI address when probing

2025-04-14 Thread Alex Williamson
On Mon, 14 Apr 2025 01:23:56 +0800 Tomita Moeko wrote: > On 4/10/25 15:34, Cédric Le Goater wrote: > > + Corvin > > > > On 4/9/25 19:18, Alex Williamson wrote: > >> On Wed, 26 Mar 2025 01:22:39 +0800 > >> Tomita Moeko wrote: > >> > >>> So far, all Intel VGA adapters, including discrete GPUs

[PATCH v4 3/3] block/nvme: Use host PCI MMIO API

2025-04-14 Thread Farhan Ali
Use the host PCI MMIO functions to read/write to NVMe registers, rather than directly accessing them. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi Signed-off-by: Farhan Ali --- block/nvme.c | 41 +++-- 1 file changed, 23 insertions(+), 18

[PATCH v4 0/3] Enable QEMU NVMe userspace driver on s390x

2025-04-14 Thread Farhan Ali
Hi, Recently on s390x we have enabled mmap support for vfio-pci devices [1]. This allows us to take advantage and use userspace drivers on s390x. However, on s390x we have special instructions for MMIO access. Starting with z15 (and newer platforms) we have new PCI Memory I/O (MIO) instructions w

Re: [PATCH v2 07/10] hw/arm/aspeed: Add support for loading vbootrom image via "-bios"

2025-04-14 Thread Nabih Estefan
Hi Jamin and Cedric, On Sun, Apr 13, 2025 at 8:17 PM Jamin Lin wrote: > > Hi Cedric, > > > Subject: Re: [PATCH v2 07/10] hw/arm/aspeed: Add support for loading > > vbootrom image via "-bios" > > > > On 4/10/25 04:38, Jamin Lin wrote: > > > Introduce "aspeed_load_vbootrom()" to support loading a v

RE: [PATCH v3 5/5] target/hexagon: Remove unreachable

2025-04-14 Thread ltaylorsimpson
> -Original Message- > From: Matheus Tavares Bernardino > > Sent: Monday, April 14, 2025 12:10 PM > To: ltaylorsimp...@gmail.com > Cc: brian.c...@oss.qualcomm.com; qemu-devel@nongnu.org; > richard.hender...@linaro.org; phi...@linaro.org; > matheus.bernard...@oss.qualcomm.com; a...@rev.n

Re: [PATCH 1/3] include/hw/pci: Attach BDF to Memory Attributes

2025-04-14 Thread Jason Chien
Ping. Jason Chien 於 2025年3月20日 週四 上午12:40寫道: > Ping > > Jason Chien 於 2025年3月13日 週四 上午12:59寫道: > >> Ping. >> >> Michael/Marcel, would you mind taking a look? Thanks! >> >> >> Jason >> >> Daniel Henrique Barboza 於 2025年3月7日 週五 >> 下午8:40寫道: >> >>> >>> >>> On 3/2/25 6:12 AM, Jason Chien wrote: >>

Re: [PATCH 1/2] hw/i386/amd_iommu: Fix device setup failure when PT is on.

2025-04-14 Thread Alejandro Jimenez
Hi Sairaj, I'm conflicted by the implementation of the change, so I'd like to make sure I fully understand... On 4/10/25 2:44 AM, Sairaj Kodilkar wrote: Current amd_iommu enables the iommu_nodma address space when pt_supported flag is on. As it should, that is the intended purpose of the i

Re: [RFC PATCH 00/13] migration: Unify capabilities and parameters

2025-04-14 Thread Daniel P . Berrangé
On Fri, Apr 11, 2025 at 04:14:30PM -0300, Fabiano Rosas wrote: > Open questions: > --- > > - Deprecations/compat? > > I think we should deprecate migrate-set/query-capabilities and everything to > do > with capabilities (specifically the validation in the JSON at the end of the > str

[PATCH v3 2/2] block/io: skip head/tail requests on EINVAL

2025-04-14 Thread Stefan Hajnoczi
When guests send misaligned discard requests, the block layer breaks them up into a misaligned head, an aligned main body, and a misaligned tail. The file-posix block driver on Linux returns -EINVAL on misaligned discard requests. This causes bdrv_co_pdiscard() to fail and guests configured with w

[PATCH v3 0/2] block: discard alignment fixes

2025-04-14 Thread Stefan Hajnoczi
v3: - Refine error handling when pdiscard_alignment is not a multiple of request_alignment [Hanna] v2: - Fix inverted logic in alignment check [Qing Wang] Two discard alignment issues were identified in https://issues.redhat.com/browse/RHEL-86032: 1. pdiscard_alignment is not populated for host_d

Re: [PATCH 0/2] fix record/replay on MacOS

2025-04-14 Thread Stefan Hajnoczi
On Thu, Apr 10, 2025 at 03:55:48PM -0700, Pierrick Bouvier wrote: > Recently, it was found that rr tests fail on MacOS, with a > replay_mutex_unlock() > assertion. This is a recent regression, related to running qemu main event > loop > in a separate thread, like first commit explain. > > We fir

KVM/QEMU community call 15/04/2025 agenda items?

2025-04-14 Thread Alex Bennée
Hi, The KVM/QEMU community call is at: https://meet.jit.si/kvmcallmeeting @ 15/04/2025 14:00 UTC Are there any agenda items for the sync-up? -- Alex Bennée Virtualisation Tech Lead @ Linaro

[RFC PATCH 0/1] add fixed file table support

2025-04-14 Thread Brian Song
Hi everyone, I am a GSoC QEMU community applicant this year, and I have just completed this contribution task suggested by the project mentors Kevin and Stefan. This task requires registering the file descriptor of a block file that currently uses io_uring as the AIO method to an io_uring instance

[RFC PATCH 1/1] This work adds support for registering block file descriptors to the io_uring instance and uses IOSQE_FIXED_FILE in I/O requests (SQEs) to avoid the cost of fdget() in the kernel. It i

2025-04-14 Thread Brian Song
Suggested-by: Kevin Wolf Suggested-by: Stefan Hajnoczi Signed-off-by: Brian Song --- block/io_uring.c | 60 1 file changed, 60 insertions(+) diff --git a/block/io_uring.c b/block/io_uring.c index dd4f304910..94a875fbae 100644 --- a/block/io_urin

Re: [PULL v2 0/3] Trivial patches for 2025-04-13

2025-04-14 Thread Stefan Hajnoczi
Applied, thanks! Stefan

Re: [PULL for 10.0 0/3] final fixes (tcg tests, plugins)

2025-04-14 Thread Stefan Hajnoczi
Applied, thanks! Stefan

Re: [RFC PATCH 00/13] migration: Unify capabilities and parameters

2025-04-14 Thread Daniel P . Berrangé
On Mon, Apr 14, 2025 at 02:40:25PM -0300, Fabiano Rosas wrote: > Daniel P. Berrangé writes: > > > On Mon, Apr 14, 2025 at 02:12:35PM -0300, Fabiano Rosas wrote: > >> Daniel P. Berrangé writes: > >> > >> > On Fri, Apr 11, 2025 at 04:14:30PM -0300, Fabiano Rosas wrote: > >> >> Open questions: > >

Re: [RFC PATCH 05/13] migration: Reduce a bit of duplication in migration.json

2025-04-14 Thread Daniel P . Berrangé
On Fri, Apr 11, 2025 at 04:14:35PM -0300, Fabiano Rosas wrote: > Introduce a new MigrationConfigBase, to allow most of the duplication > in migration.json to be eliminated. > > The reason we need MigrationParameters and MigrationSetParameters is > that the internal parameter representation in the

[PATCH v3 10/10] arm/cpu-features: document ID reg properties

2025-04-14 Thread Cornelia Huck
Add some documentation for how individual ID registers can be configured with the host cpu model. [CH: adapt to removal of the 'custom' model, added some more explanations about using the ID register props] Signed-off-by: Eric Auger Signed-off-by: Cornelia Huck --- docs/system/arm/cpu-features

Re: [PATCH 2/6] file-posix: Allow lseek at offset 0 when !want_zero

2025-04-14 Thread Eric Blake
On Mon, Apr 14, 2025 at 08:05:21PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 11.04.25 04:04, Eric Blake wrote: > > The 'want_zero' parameter to raw_co_block_status() was added so that > > we can avoid potentially time-consuming lseek(SEEK_DATA) calls > > throughout the file (working around po

RE: [PATCH v3 5/5] target/hexagon: Remove unreachable

2025-04-14 Thread Matheus Tavares Bernardino
On Mon, 14 Apr 2025 11:19:38 -0600 wrote: > > > -Original Message- > > From: Brian Cain > > Sent: Monday, April 7, 2025 1:27 PM > > To: qemu-devel@nongnu.org > > Cc: brian.c...@oss.qualcomm.com; richard.hender...@linaro.org; > > phi...@linaro.org; matheus.bernard...@oss.qualcomm.com; a...

Re: [PATCH v1 03/24] s390x: Guest support for Certificate Store Facility (CS)

2025-04-14 Thread Zhuoying Cai
On 4/11/25 9:28 AM, Thomas Huth wrote: > On 08/04/2025 17.55, Zhuoying Cai wrote: >> DIAG 320 is supported when the certificate-store (CS) facility >> is installed. >> >> Availability of CS facility is determined by byte 134 bit 5 of the >> SCLP Read Info block. >> >> Signed-off-by: Zhuoying Cai

Re: [RFC PATCH 00/13] migration: Unify capabilities and parameters

2025-04-14 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Mon, Apr 14, 2025 at 02:12:35PM -0300, Fabiano Rosas wrote: >> Daniel P. Berrangé writes: >> >> > On Fri, Apr 11, 2025 at 04:14:30PM -0300, Fabiano Rosas wrote: >> >> Open questions: >> >> --- >> >> >> >> - Deprecations/compat? >> >> >> >> I think w

Re: [PATCH v2 1/1] target/riscv: fix endless translation loop on big endian systems

2025-04-14 Thread Philippe Mathieu-Daudé
Hi, On 14/4/25 18:59, Ziqiao Kong wrote: Hello Philippe, Any further concern regarding this series? I certainly would like to investigate and help =). Short term I can't keep looking because I'm busy with other stuffs and tagged this patch for another review, because there is some endianness

Re: [RFC PATCH 00/13] migration: Unify capabilities and parameters

2025-04-14 Thread Daniel P . Berrangé
On Mon, Apr 14, 2025 at 02:12:35PM -0300, Fabiano Rosas wrote: > Daniel P. Berrangé writes: > > > On Fri, Apr 11, 2025 at 04:14:30PM -0300, Fabiano Rosas wrote: > >> Open questions: > >> --- > >> > >> - Deprecations/compat? > >> > >> I think we should deprecate migrate-set/query-cap

RE: [PATCH v3 5/5] target/hexagon: Remove unreachable

2025-04-14 Thread ltaylorsimpson
> -Original Message- > From: Brian Cain > Sent: Monday, April 7, 2025 1:27 PM > To: qemu-devel@nongnu.org > Cc: brian.c...@oss.qualcomm.com; richard.hender...@linaro.org; > phi...@linaro.org; matheus.bernard...@oss.qualcomm.com; a...@rev.ng; > a...@rev.ng; marco.lie...@oss.qualcomm.com;

RE: [PATCH v3 4/5] target/hexagon: s/pkt_has_store/pkt_has_scalar_store

2025-04-14 Thread ltaylorsimpson
> -Original Message- > From: Brian Cain > Sent: Monday, April 7, 2025 1:27 PM > To: qemu-devel@nongnu.org > Cc: brian.c...@oss.qualcomm.com; richard.hender...@linaro.org; > phi...@linaro.org; matheus.bernard...@oss.qualcomm.com; a...@rev.ng; > a...@rev.ng; marco.lie...@oss.qualcomm.com;

[PATCH v2 2/3] target/s390x: introduce function when exiting PV

2025-04-14 Thread Gautam Gala
introduce a static function when exiting PV. The function replaces an existing macro (s390_pv_cmd_exit). Signed-off-by: Gautam Gala --- target/s390x/kvm/pv.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/target/s390x/kvm/pv.c b/target/s390x/kvm/pv.c index 3a0

Re: [PATCH v2 1/1] target/riscv: fix endless translation loop on big endian systems

2025-04-14 Thread Ziqiao Kong
Hello Philippe, Any further concern regarding this series? I certainly would like to investigate and help =). Bests, Ziqiao On Mon, Apr 14, 2025 at 7:17 PM Ziqiao Kong wrote: > > On Mon, Apr 14, 2025 at 6:41 PM Philippe Mathieu-Daudé > wrote: > > > > Hi, > > > > On 14/4/25 05:46, Ziqiao Kong w

Re: [PATCH 2/6] file-posix: Allow lseek at offset 0 when !want_zero

2025-04-14 Thread Vladimir Sementsov-Ogievskiy
On 11.04.25 04:04, Eric Blake wrote: The 'want_zero' parameter to raw_co_block_status() was added so that we can avoid potentially time-consuming lseek(SEEK_DATA) calls throughout the file (working around poor filesystems that have O(n) rather than O(1) extent probing). But when it comes to lear

RE: [PATCH v3 3/5] target/hexagon: Add missing A_CALL attr, hintjumpr to multi_cof

2025-04-14 Thread ltaylorsimpson
> -Original Message- > From: Brian Cain > Sent: Monday, April 7, 2025 1:27 PM > To: qemu-devel@nongnu.org > Cc: brian.c...@oss.qualcomm.com; richard.hender...@linaro.org; > phi...@linaro.org; matheus.bernard...@oss.qualcomm.com; a...@rev.ng; > a...@rev.ng; marco.lie...@oss.qualcomm.com;

RE: [PATCH v3 1/5] target/hexagon: handle .new values

2025-04-14 Thread ltaylorsimpson
> -Original Message- > From: Brian Cain > Sent: Monday, April 7, 2025 1:27 PM > To: qemu-devel@nongnu.org > Cc: brian.c...@oss.qualcomm.com; richard.hender...@linaro.org; > phi...@linaro.org; matheus.bernard...@oss.qualcomm.com; a...@rev.ng; > a...@rev.ng; marco.lie...@oss.qualcomm.com;

Re: [RFC PATCH 05/13] migration: Reduce a bit of duplication in migration.json

2025-04-14 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Fri, Apr 11, 2025 at 04:14:35PM -0300, Fabiano Rosas wrote: >> Introduce a new MigrationConfigBase, to allow most of the duplication >> in migration.json to be eliminated. >> >> The reason we need MigrationParameters and MigrationSetParameters is >> that the inter

RE: [PATCH v3 2/5] target/hexagon: Fix badva reference, delete CAUSE

2025-04-14 Thread ltaylorsimpson
> -Original Message- > From: Brian Cain > Sent: Monday, April 7, 2025 1:27 PM > To: qemu-devel@nongnu.org > Cc: brian.c...@oss.qualcomm.com; richard.hender...@linaro.org; > phi...@linaro.org; matheus.bernard...@oss.qualcomm.com; a...@rev.ng; > a...@rev.ng; marco.lie...@oss.qualcomm.com;

Re: [PATCH 2/9] cxl-mailbox-utils: 0x5600 - FMAPI Get DCD Info

2025-04-14 Thread Anisa Su
Hi Jonathan, Any update on this? Thanks, Anisa On Mon, Mar 31, 2025 at 12:38 PM Anisa Su wrote: > On Tue, Mar 18, 2025 at 03:56:24PM +, Jonathan Cameron wrote: > > On Mon, 17 Mar 2025 16:31:29 + > > anisa.su...@gmail.com wrote: > > > > > From: Anisa Su > > > > > > FM DCD Management co

[PATCH v3 04/10] kvm: kvm_get_writable_id_regs

2025-04-14 Thread Cornelia Huck
Add an helper to retrieve the writable id reg bitmask. The status of the query is stored in the CPU struct so that an an error, if any, can be reported on vcpu realize(). Signed-off-by: Eric Auger Signed-off-by: Cornelia Huck --- target/arm/cpu.h | 26 ++ target/arm/

[PATCH v3 09/10] arm-qmp-cmds: introspection for ID register props

2025-04-14 Thread Cornelia Huck
Implement the capability to query available ID register values by adding SYSREG_* options and values to the cpu model expansion for the host model, if available. Excerpt: (QEMU) query-cpu-model-expansion type=full model={"name":"host"} {"return": {"model": {"name": "host", "props": {"SYSREG_ID_AA6

[PATCH v3 07/10] arm/kvm: write back modified ID regs to KVM

2025-04-14 Thread Cornelia Huck
From: Eric Auger We want to give a chance to override the value of host ID regs. In a previous patch we made sure all their values could be fetched through kvm_get_one_reg() calls before their modification. After their potential modification we need to make sure we write back the values through k

[PATCH v3 08/10] arm/cpu: more customization for the kvm host cpu model

2025-04-14 Thread Cornelia Huck
From: Eric Auger If the interface for writable ID registers is available, expose uint64 SYSREG properties for writable ID reg fields exposed by the host kernel. Properties are named SYSREG__ with REG and FIELD being those used in linux arch/arm64/tools/sysreg. This done by matching the writable

[PATCH v3 03/10] arm/cpu: Add generated sysreg properties

2025-04-14 Thread Cornelia Huck
Generated against Linux 6.14-rc1. Signed-off-by: Cornelia Huck --- target/arm/cpu-sysreg-properties.c | 716 - 1 file changed, 694 insertions(+), 22 deletions(-) diff --git a/target/arm/cpu-sysreg-properties.c b/target/arm/cpu-sysreg-properties.c index 8b7ef5badfb9.

[PATCH v3 06/10] arm/kvm: Allow reading all the writable ID registers

2025-04-14 Thread Cornelia Huck
From: Eric Auger At the moment kvm_arm_get_host_cpu_features() reads a subset of the ID regs. As we want to introduce properties for all writable ID reg fields, we want more genericity and read more default host register values. Introduce a new get_host_cpu_idregs() helper and add a new exhausti

[PATCH v3 02/10] arm/cpu: Add sysreg properties generation

2025-04-14 Thread Cornelia Huck
From: Eric Auger Introduce a script that automates the generation of system register properties definitions from a given linux source tree arch/arm64/tools/sysreg. Invocation of ./update-aarch64-sysreg-code.sh $PATH_TO_LINUX_SOURCE_TREE in scripts directory additionally generates target/arm/cpu-

[PATCH v3 00/10] kvm/arm: Introduce a customizable aarch64 KVM host model

2025-04-14 Thread Cornelia Huck
[This is on top of v5 of the ID register storage rework: https://lore.kernel.org/qemu-devel/20250409144304.912325-1-coh...@redhat.com/T/#t] It's been a while, but here's finally a respin of the series to make ID registers configurable directly via the command line. Major changes from v2 include:

Re: [RFC PATCH 02/13] migration: Normalize tls arguments

2025-04-14 Thread Daniel P . Berrangé
On Fri, Apr 11, 2025 at 04:14:32PM -0300, Fabiano Rosas wrote: > The tls_creds, tls_authz and tls_hostname arguments are strings that > can be set by the user. They are allowed to be either a valid string, > an empty string or NULL. The values "" and NULL are effectively > treated the same by the c

Re: [PATCH 1/6] mirror: Skip pre-zeroing destination if it is already zero

2025-04-14 Thread Vladimir Sementsov-Ogievskiy
On 11.04.25 04:04, Eric Blake wrote: When doing a sync=full mirroring, QMP drive-mirror requests full zeroing if it did not just create the destination, and blockdev-mirror requests full zeroing unconditionally. This is because during a full sync, we must ensure that the portions of the disk tha

Re: [PATCH v2] tests/avocado: add memlock tests

2025-04-14 Thread Alexandr Moshkov
On 4/14/25 14:14, Paolo Bonzini wrote: On 4/14/25 09:57, Alexandr Moshkov wrote: Add new tests to check the correctness of the `-overcommit memlock` option (possible values: off, on, on-fault) by using `/proc/{qemu_pid}/smaps` file to check in Size, Rss and Locked fields of anonymous segments:

Re: [RFC 0/2] python: integrate linter tests natively with meson

2025-04-14 Thread Daniel P . Berrangé
Ping: would like to hear John's thoughts on this series. We're likely to eliminate usage of avocado for functional testing in this dev cycle. That leaves python testing as the main outstanding bit of QEMU that is not natively using meson's test integration and also still pulling in avocado as a de

Re: [PATCH v2 1/2] file-posix: probe discard alignment on Linux block devices

2025-04-14 Thread Stefan Hajnoczi
On Fri, Apr 11, 2025 at 10:15:13AM +0200, Hanna Czenczek wrote: > On 10.04.25 20:41, Stefan Hajnoczi wrote: > > Populate the pdiscard_alignment block limit so the block layer is able > > align discard requests correctly. > > > > Signed-off-by: Stefan Hajnoczi > > --- > > block/file-posix.c | 56

Re: [PATCH] MAINTAINERS: Add functional tests that are not covered yet

2025-04-14 Thread Philippe Mathieu-Daudé
On 14/4/25 14:15, Thomas Huth wrote: From: Thomas Huth Some functional tests are currently not covered by the entries in MAINTAINERS yet, so scripts/get_maintainers.pl fails to suggest the right people who should be CC:-ed for related patches. Add the uncovered tests to the right sections to cl

Re: [PATCH] tests/functional: Remove unnecessary import statements

2025-04-14 Thread Philippe Mathieu-Daudé
On 14/4/25 16:54, Thomas Huth wrote: From: Thomas Huth pylint complains about these unnecessary import statements, so let's remove them. Signed-off-by: Thomas Huth --- tests/functional/qemu_test/ports.py | 3 +-- tests/functional/qemu_test/tuxruntest.py | 2 -- tests/

[PATCH 1/4] hw/s390x/s390-virtio-ccw: Remove the deprecated 3.0 machine type

2025-04-14 Thread Thomas Huth
From: Thomas Huth The s390-ccw-virtio-3.0 machine is older than 6 years, so according to our machine support policy, it can be removed now. Signed-off-by: Thomas Huth --- hw/s390x/s390-virtio-ccw.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/hw/s390x/s390-virtio-ccw.c b

Re: [PULL v2 0/3] Trivial patches for 2025-04-13

2025-04-14 Thread Michael Tokarev
On 13.04.2025 15:59, Michael Tokarev wrote: The following changes since commit 56c6e249b6988c1b6edc2dd34ebb0f1e570a1365: Update version for v10.0.0-rc3 release (2025-04-09 04:33:10 -0400) are available in the Git repository at: https://gitlab.com/mjt0k/qemu.git tags/pull-trivial-patches

[PATCH v2 3/3] target/s390x: Return UVC cmd code, RC and RRC value when DIAG 308 Subcode 10 fails to enter secure mode

2025-04-14 Thread Gautam Gala
Extend DIAG308 subcode 10 to return the UVC RC, RRC and command code in bit positions 32-47, 16-31, and 0-15 of register R1 + 1 if the function does not complete successfully (in addition to the previously returned diag response code in bit position 47-63). Signed-off-by: Gautam Gala --- hw/s390

[PATCH v2 0/3] DIAG 308: extend subcode 10 to return UVC cmd id, RC and RRC values upon failure to enter secure mode

2025-04-14 Thread Gautam Gala
DIAG 308 (subcode 10 - performing secure execution unpack) response code when the configuration is unable to enter secure mode has limited usability as it is a fixed value (0xa02) for variety of different reasons. The aim is to extend this DIAG to return UVC command ID, RC and RRC values in additio

[PATCH 8/9] rust/hpet: Support migration

2025-04-14 Thread Zhao Liu
Based on commit 1433e38cc8 ("hpet: do not overwrite properties on post_load"), add the basic migration support to Rust HPET. The current migration implementation introduces multiple unsafe callbacks. Before the vmstate builder, one possible cleanup approach is to wrap callbacks in the vmstate bind

[PATCH v2 4/4] target/arm/ptw: fix arm_cpu_get_phys_page_attrs_debug

2025-04-14 Thread Pierrick Bouvier
It was reported that QEMU monitor command gva2gpa was reporting unmapped memory for a valid access (qemu-system-aarch64), during a copy from kernel to user space (__arch_copy_to_user symbol in Linux) [1]. This was affecting cpu_memory_rw_debug also, which is used in numerous places in our codebase.

Re: [RFC 0/3] Qemu FM emulation

2025-04-14 Thread Fan Ni
On Tue, Apr 08, 2025 at 11:04:20AM -0400, Gregory Price wrote: > On Mon, Apr 07, 2025 at 09:20:27PM -0700, nifan@gmail.com wrote: > > From: Fan Ni > > > > The RFC provides a way for FM emulation in Qemu. The goal is to provide > > a context where we can have more FM emulation discussions and

[PATCH v2 3/4] target/arm/ptw: extract arm_cpu_get_phys_page

2025-04-14 Thread Pierrick Bouvier
Allow to call that function easily several times in next commit. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- target/arm/ptw.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/target/arm/ptw

[PATCH v2 1/4] target/arm/ptw: extract arm_mmu_idx_to_security_space

2025-04-14 Thread Pierrick Bouvier
We'll reuse this function later. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- target/arm/ptw.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/target/arm/ptw.c b/target/arm/ptw.c index 8d4e9e07

[PATCH v2 0/4] target/arm: fix arm_cpu_get_phys_page_attrs_debug

2025-04-14 Thread Pierrick Bouvier
It was reported that QEMU monitor command gva2gpa was reporting unmapped memory for a valid access (qemu-system-aarch64), during a copy from kernel to user space (__arch_copy_to_user symbol in Linux) [1]. This was affecting cpu_memory_rw_debug also, which is used in numerous places in our codebase.

[PATCH v2 2/4] target/arm/ptw: get current security_space for current mmu_idx

2025-04-14 Thread Pierrick Bouvier
It should be equivalent to previous code. Allow to call common function to get a page address later. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- target/arm/ptw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/ptw.c b/target/arm/ptw.c index

Re: [PATCH 0/2] fix record/replay on MacOS

2025-04-14 Thread Pierrick Bouvier
On 4/14/25 08:14, Stefan Hajnoczi wrote: On Thu, Apr 10, 2025 at 03:55:48PM -0700, Pierrick Bouvier wrote: Recently, it was found that rr tests fail on MacOS, with a replay_mutex_unlock() assertion. This is a recent regression, related to running qemu main event loop in a separate thread, like f

Re: [PATCH for-10.0] docs: Document removal of 64-bit on 32-bit emulation

2025-04-14 Thread Richard Henderson
On 4/14/25 08:16, Stefan Hajnoczi wrote: On Sat, Apr 12, 2025 at 12:43 PM Richard Henderson wrote: With acce728cbc6c we disallowed configuring 64-bit guests on 32-bit hosts, but forgot to document that in removed-features. Signed-off-by: Richard Henderson --- docs/about/removed-features.rs

Re: [PATCH 1/2] system/main: transfer replay mutex ownership from main thread to main loop thread

2025-04-14 Thread Pierrick Bouvier
On 4/14/25 03:25, Philippe Mathieu-Daudé wrote: On 12/4/25 19:24, Pierrick Bouvier wrote: On 4/11/25 22:30, Nicholas Piggin wrote: On Fri Apr 11, 2025 at 8:55 AM AEST, Pierrick Bouvier wrote: On MacOS, UI event loop has to be ran in the main thread of a process. Because of that restriction, on

Re: [RFC V3 PATCH 05/13] acpi: Send the GPE event of suspend and wakeup for x86

2025-04-14 Thread Alex Bennée
Annie Li writes: > The GPE event is triggered to notify x86 guest to suppend > itself. The function acpi_send_sleep_event will also > trigger GED events on HW-reduced systems where ACPI GED > sleep event is supported. > > Signed-off-by: Annie Li > --- > hw/acpi/core.c | 10

Re: [PATCH for-10.0] docs: Document removal of 64-bit on 32-bit emulation

2025-04-14 Thread Stefan Hajnoczi
On Sat, Apr 12, 2025 at 12:43 PM Richard Henderson wrote: > > With acce728cbc6c we disallowed configuring 64-bit guests on > 32-bit hosts, but forgot to document that in removed-features. > > Signed-off-by: Richard Henderson > --- > docs/about/removed-features.rst | 9 + > 1 file changed

[PATCH 3/9] rust/vmstate_test: Test varray with num field wrapped in BqlCell

2025-04-14 Thread Zhao Liu
Signed-off-by: Zhao Liu --- rust/qemu-api/tests/vmstate_tests.rs | 41 ++-- 1 file changed, 33 insertions(+), 8 deletions(-) diff --git a/rust/qemu-api/tests/vmstate_tests.rs b/rust/qemu-api/tests/vmstate_tests.rs index b8d8b45b19de..d1e37c45eea4 100644 --- a/rust/qemu-a

Re: [RFC PATCH v4 5/5] s390: implementing CHSC SEI for AP config change

2025-04-14 Thread Rorie Reyes
On 4/14/25 10:54 AM, Thomas Huth wrote: On 14/04/2025 16.37, Rorie Reyes wrote: On 4/11/25 2:45 AM, Thomas Huth wrote: #include CONFIG_DEVICES at the beginning of the ioinst.c file. Then you should be able to do: #ifdef CONFIG_VFIO_AP     if (s390_has_feat(S390_FEAT_AP)) {    return ap

[PATCH] tests/functional: Remove unnecessary import statements

2025-04-14 Thread Thomas Huth
From: Thomas Huth pylint complains about these unnecessary import statements, so let's remove them. Signed-off-by: Thomas Huth --- tests/functional/qemu_test/ports.py | 3 +-- tests/functional/qemu_test/tuxruntest.py | 2 -- tests/functional/qemu_test/uncompress.py

Re: [RFC PATCH v4 5/5] s390: implementing CHSC SEI for AP config change

2025-04-14 Thread Thomas Huth
On 14/04/2025 16.37, Rorie Reyes wrote: On 4/11/25 2:45 AM, Thomas Huth wrote: #include CONFIG_DEVICES at the beginning of the ioinst.c file. Then you should be able to do: #ifdef CONFIG_VFIO_AP     if (s390_has_feat(S390_FEAT_AP)) {    return ap_chsc_sei_nt0_get_event(res);     } #endif

[PATCH for-10.1 0/4] s390x: Remove deprecated machine types v3.0 up to v4.0

2025-04-14 Thread Thomas Huth
These machine types are older than 6 years, so according to our new support policy, it should be fine to remove them now in QEMU v10.1. This series is Based-on: <20250115073819.15452-1-th...@redhat.com> Thomas Huth (4): hw/s390x/s390-virtio-ccw: Remove the deprecated 3.0 machine type hw/s390x

Re: [PATCH v11 04/10] virtio-gpu: Support asynchronous fencing

2025-04-14 Thread Dmitry Osipenko
On 4/11/25 04:42, 刘聪 wrote: > > > >> -Original Messages- >> From: "Dmitry Osipenko" >> Send time:Friday, 04/11/2025 05:59:11 >> To: "Cong Liu" >> Cc: jiqian.c...@amd.com, akihiko.od...@daynix.com, alex.ben...@linaro.org, >> alexander.deuc...@amd.com, christian.koe...@amd.com, >> gert

Re: [PATCH v3] target/i386: Fix model number of Zhaoxin YongFeng vCPU template

2025-04-14 Thread Zhao Liu
On Mon, Apr 14, 2025 at 03:53:42AM -0400, Ewan Hai wrote: > Date: Mon, 14 Apr 2025 03:53:42 -0400 > From: Ewan Hai > Subject: [PATCH v3] target/i386: Fix model number of Zhaoxin YongFeng vCPU > template > X-Mailer: git-send-email 2.34.1 > > The model number was mistakenly set to 0x0b (11) in com

Re: [PATCH for-10.0] Fix objdump output parser in "nsis.py"

2025-04-14 Thread Stefan Hajnoczi
On Sat, Apr 12, 2025 at 08:19:50PM +0200, Stefan Weil wrote: > Am 12.04.25 um 20:08 schrieb Arthur Sengileyev: > > > In msys2 distribution objdump from gcc is using single tab character > > prefix, but objdump from clang is using 4 white space characters instead. > > The script will not identify a

[PATCH 5/9] rust/timer: Define NANOSECONDS_PER_SECOND binding as u64

2025-04-14 Thread Zhao Liu
NANOSECONDS_PER_SECOND is often used in operations with get_ns(), which currently returns a u64. Therefore, define a new NANOSECONDS_PER_SECOND binding is with u64 type to eliminate unnecessary type conversions (from u32 to u64). Signed-off-by: Zhao Liu --- rust/qemu-api/src/timer.rs | 2 ++ 1

[PATCH 7/9] rust/hpet: convert HPETTimer index to u8 type

2025-04-14 Thread Zhao Liu
The C version of HPET uses the uint8_t type for timer index ("tn"), and usize type in Rust version will break migration between the C and Rust versions. So convert HPETTimer index' type to u8 (consistent with the C version of HPET) to make it friendly for vmstate support. Signed-off-by: Zhao Liu

[PATCH 1/9] rust/vmstate: Support field_exists check in vmstate_struct macro

2025-04-14 Thread Zhao Liu
Unfortunately, at present it's not possible to have a const "with_exist_check" method to append test_fn after vmstate_struct (due to error on "constant functions cannot evaluate destructors" for `F`). Before the vmstate builder, the only way to support "test_fn" is to extend vmstate_struct macro t

Re: [RFC PATCH v4 5/5] s390: implementing CHSC SEI for AP config change

2025-04-14 Thread Rorie Reyes
On 4/11/25 2:45 AM, Thomas Huth wrote: #include CONFIG_DEVICES at the beginning of the ioinst.c file. Then you should be able to do: #ifdef CONFIG_VFIO_AP     if (s390_has_feat(S390_FEAT_AP)) {    return ap_chsc_sei_nt0_get_event(res);     } #endif This worked (or whatever the code shou

Re: [PATCH] hw: add compat machines for 10.1

2025-04-14 Thread Zhao Liu
On Mon, Apr 14, 2025 at 11:45:43AM +0200, Cornelia Huck wrote: > Date: Mon, 14 Apr 2025 11:45:43 +0200 > From: Cornelia Huck > Subject: [PATCH] hw: add compat machines for 10.1 > > Add 10.1 machine types for arm/i440fx/m68k/q35/s390x/spapr. > > Signed-off-by: Cornelia Huck > --- > hw/arm/virt.

[PATCH v2 09/15] tests/functional: Convert the 64-bit big endian Wheezy mips test

2025-04-14 Thread Thomas Huth
From: Thomas Huth Reuse the test function from the 32-bit big endian test to easily convert the 64-bit big endian Wheezy mips test. Since this was the last test in tests/avocado/linux_ssh_mips_malta.py, we can remove this avocado file now, too. Reviewed-by: Daniel P. Berrangé Signed-off-by: Th

  1   2   >