Re: Broken NetBSD Orange Pi image URL in QEMU tests

2025-03-15 Thread Stefan Hajnoczi
On Sat, Mar 15, 2025 at 5:01 PM Niek Linnenbank wrote: > > Hello Stefan, > > As of today, it seems the URL is working properly again. I've done a few > downloads without any error. > What I did notice is that NetBSD provides a 'cdn.netbsd.org' also, but I > can't see any noticable difference yet

[PATCH] alsaaudio: Set try-poll to false by default

2025-03-15 Thread BALATON Zoltan
Quoting Volker Rümelin: "try-poll=on tells the ALSA backend to try to use an event loop instead of the audio timer. This works most of the time. But the poll event handler in the ALSA backend has a bug. For example, if the guest can't provide enough audio frames in time, the ALSA buffer is only par

Re: Broken NetBSD Orange Pi image URL in QEMU tests

2025-03-15 Thread Niek Linnenbank
Hello Stefan, As of today, it seems the URL is working properly again. I've done a few downloads without any error. What I did notice is that NetBSD provides a 'cdn.netbsd.org' also, but I can't see any noticable difference yet. Tests are also running OK now, at least on my local system: $ QEMU_

Re: [PATCH v4 00/47] x86: Improve operation under QEMU

2025-03-15 Thread Tom Rini
On Sat, Mar 15, 2025 at 12:54:25PM +, Simon Glass wrote: > Hi Tom, > > On Fri, 14 Mar 2025 at 16:06, Tom Rini wrote: > > > > On Fri, Mar 14, 2025 at 02:44:35PM +, Simon Glass wrote: > > > Hi Tom, > > > > > > On Fri, 7 Mar 2025 at 14:23, Tom Rini wrote: > > > > > > > > On Thu, Mar 06, 202

[PULL 10/17] target/arm: Forbid return to AArch32 when CPU is AArch64-only

2025-03-15 Thread Peter Maydell
In the Arm ARM, rule R_TYTWB states that returning to AArch32 is an illegal exception return if: * AArch32 is not supported at any exception level * the target EL is configured for AArch64 via SCR_EL3.RW or HCR_EL2.RW or via CPU state at reset We check the second of these, but not the first (

[PULL 33/54] target/rx: Ensure not being build on user emulation

2025-03-15 Thread Philippe Mathieu-Daudé
Currently only system emulation is supported. Assert no target code is built for user emulation. Remove #ifdef'ry since more work is required before being able to emulate a user process. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20250121142341.17001-3-phi.

Re: [PATCH 5/7] hw/ppc: Preserve Memory Regions as per MDST/MDDT tables

2025-03-15 Thread Harsh Prateek Bora
On 2/17/25 12:49, Aditya Gupta wrote: When MPIPL is used, OPAL/Linux registers memory regions to be preserved on a Memory-Preserving boot ('crashkernel boot'). The regions are added to two tables: MDST and MDDT (source and destination tables) The MDST contains the start address of the region

Re: [PATCH v2 43/62] docs/qapidoc: add preamble() method

2025-03-15 Thread John Snow
On Sun, Mar 9, 2025 at 5:03 PM Markus Armbruster wrote: > John Snow writes: > > > This method adds the options/preamble to each definition block. Notably, > > :since: and :ifcond: are added, as are any "special features" such as > > :deprecated: and :unstable:. > > > > Signed-off-by: John Snow

[PULL 12/17] tests/functional: Bump up arm_replay timeout

2025-03-15 Thread Peter Maydell
On my machine the arm_replay test takes over 2 minutes to run in a config with Rust enabled and debug enabled: $ time (cd build/rust ; PYTHONPATH=../../python:../../tests/functional QEMU_TEST_QEMU_BINARY=./qemu-system-arm ./pyvenv/bin/python3 ../../tests/functional/test_arm_replay.py) TAP version

[PATCH RFC v2] Integration coroutines into fuse export

2025-03-15 Thread saz97
Signed-off-by: Changzhi Xie This commit refactors the FUSE export to process read and write operations using coroutines, improving concurrency and avoiding blocking the main loop. The main changes include: 1. Introduce FuseIORequest structure to encapsulate I/O parameters and state 2. Move rea

[PATCH 0/1 RFC] FUSE Export Coroutine Integration Cover Letter

2025-03-15 Thread saz97
Signed-off-by: Changzhi Xie FUSE Export Coroutine Integration Cover Letter This patch series refactors QEMU's FUSE export module to leverage coroutines for read/write operations, addressing concurrency limitations and aligning with QEMU's asynchronous I/O model. The changes demonstrate measu

Re: Bad error handling in loongarch's kvm_arch_init_vcpu(), need advice

2025-03-15 Thread Paolo Bonzini
On 3/12/25 09:39, Markus Armbruster wrote: scripts/coccinelle/error-use-after-free.cocci led me to target/loongarch/kvm/kvm.c: ret = kvm_cpu_check_lsx(cs, &local_err); if (ret < 0) { error_report_err(local_err); Reporting an error, but continue anyway. This is su

[Stable-9.2.3 29/51] docs/about/build-platforms: Correct minimum supported Python version

2025-03-15 Thread Michael Tokarev
From: Markus Armbruster Fixes: ca056f4499c2 (Python: Drop support for Python 3.7) Signed-off-by: Markus Armbruster Message-ID: <20250227080757.3978333-2-arm...@redhat.com> Reviewed-by: Daniel P. Berrangé (cherry picked from commit 87c8b4fc3c1c89ec52540bfb74f9b0518f247323) Signed-off-by: Michael

Re: [PATCH] target/arm: Define raw write for PMU CLR registers

2025-03-15 Thread Peter Maydell
On Fri, 14 Mar 2025 at 08:15, Akihiko Odaki wrote: > > On 2025/03/14 3:34, Peter Maydell wrote: > > On Thu, 13 Mar 2025 at 07:16, Akihiko Odaki > > wrote: > >> > >> PMCNTENCLR_EL0 and PMINTENCLR_EL1 clears written bits so we need an > >> alternative raw write functions, which will be used to cop

[PATCH v2] ppc/spapr: fix default cpu for pre-9.0 machines.

2025-03-15 Thread Harsh Prateek Bora
When POWER10 CPU was made as default, we missed keeping POWER9 as default for older pseries releases (pre-9.0) at that time. This caused breakge in default cpu evaluation for older pseries machines and hence this fix. Fixes: 51113013f3 ("ppc/spapr: change pseries machine default to POWER10 CPU") C

Re: [PATCH 15/16] system/memory: make compilation unit common

2025-03-15 Thread Pierrick Bouvier
On 3/10/25 10:58, Richard Henderson wrote: On 3/10/25 10:47, Pierrick Bouvier wrote: Maybe better as   MemOp mop = (target_words_bigendian() ? MO_BE : MO_LE) | size_memop(size);   adjust_endianness(mr, &mrfd.data, size_memop(size), mop); Do you think defining MO_TE as this express

Re: [PATCH] meson.build: Set RUST_BACKTRACE for all tests

2025-03-15 Thread Philippe Mathieu-Daudé
On 10/3/25 11:29, Peter Maydell wrote: We want to capture potential Rust backtraces on panics in our test logs, which isn't Rust's default behaviour. Set RUST_BACKTRACE=1 in the add_test_setup environments, so that all our tests get run with this environment variable set. This makes the setting

[PULL 05/17] target/arm: Move arm_cpu_data_is_big_endian() etc to internals.h

2025-03-15 Thread Peter Maydell
The arm_cpu_data_is_big_endian() and related functions are now used only in target/arm; they can be moved to internals.h. The motivation here is that we would like to move arm_current_el() to internals.h. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target/arm/cpu.h |

Re: [PATCH] block: Zero block driver state before reopening

2025-03-15 Thread Kevin Wolf
Am 10.03.2025 um 11:48 hat Kevin Wolf geschrieben: > Block drivers assume in their .bdrv_open() implementation that their > state in bs->opaque has been zeroed; it is initially allocated with > g_malloc0() in bdrv_open_driver(). > > bdrv_snapshot_goto() needs to make sure that it is zeroed again b

Re: [PATCH v2 2/2] target/riscv: fixes a bug against `ssamoswap` behavior in M-mode

2025-03-15 Thread Deepak Gupta
On Thu, Mar 6, 2025 at 6:05 PM Alistair Francis wrote: > > On Thu, Mar 6, 2025 at 4:47 PM Deepak Gupta wrote: > > > > Commit f06bfe3dc38c ("target/riscv: implement zicfiss instructions") adds > > `ssamoswap` instruction. `ssamoswap` takes the code-point from existing <... snipped...> > > Fixes: f

[PATCH v8 5/6] tests/qtest/bios-table-test: testing new ARM ACPI PPTT topology

2025-03-15 Thread Alireza Sanaee via
Test new PPTT topolopy with cache representation. Signed-off-by: Alireza Sanaee Reviewed-by: Jonathan Cameron --- tests/qtest/bios-tables-test.c | 4 1 file changed, 4 insertions(+) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index 0a333ec43536..6bdc25f4df

Re: [PATCH] block/snapshot: fix *errp handling in bdrv_snapshot_goto

2025-03-15 Thread Kevin Wolf
Am 04.03.2025 um 09:01 hat ger...@altlinux.org geschrieben: > From: Denis Rastyogin > > This error was discovered by fuzzing qemu-img. > > If bdrv_snapshot_goto() returns an error, it is not handled immediately, > allowing *errp to be reassigned when qcow_open() fails, which triggers > assert(*e

[PATCH v2] target/arm: Define raw write for PMU CLR registers

2025-03-15 Thread Akihiko Odaki
Raw writes to PMCNTENCLR and PMCNTENCLR_EL0 incorrectly used their default write function, which clears written bits instead of writes the raw value. PMINTENCLR and PMINTENCLR_EL1 are similar registers, but they instead had ARM_CP_NO_RAW. target/arm/cpregs.h suggests this flag usage is inappropria

Re: [PATCH 25/37] common-user: Split out watchpoint-stub.c

2025-03-15 Thread Pierrick Bouvier
On 3/14/25 09:37, Richard Henderson wrote: On 3/13/25 03:39, Philippe Mathieu-Daudé wrote: --- /dev/null +++ b/common-user/watchpoint-stub.c @@ -0,0 +1,28 @@ +/* + * CPU watchpoint stubs + * + * Copyright (c) 2003 Fabrice Bellard + * SPDX-License-Identifier: LGPL-2.1-or-later + */ + +#include "q

Re: [PATCH v2 03/14] ppc/xive2: Support group-matching when looking for target

2025-03-15 Thread Nicholas Piggin
On Tue Dec 10, 2024 at 10:05 AM AEST, Michael Kowal wrote: > From: Frederic Barrat > > If an END has the 'i' bit set (ignore), then it targets a group of > VPs. The size of the group depends on the VP index of the target > (first 0 found when looking at the least significant bits of the > index) s

Re: [PATCH 5/7] hw/hyperv/syndbg: common compilation unit

2025-03-15 Thread Pierrick Bouvier
On 3/6/25 08:19, Richard Henderson wrote: On 3/5/25 22:41, Pierrick Bouvier wrote: Replace TARGET_PAGE.* by runtime calls Signed-off-by: Pierrick Bouvier --- hw/hyperv/syndbg.c| 7 --- hw/hyperv/meson.build | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/h

[PATCH v3 3/4] hw/s390x/ccw: Have CCW machine implement a qmp_dump_skeys() callback

2025-03-15 Thread Philippe Mathieu-Daudé
In preparation to make @dump-skeys command generic, extract s390_qmp_dump_skeys() out of qmp_dump_skeys(). Register it as CCW qmp_dump_skeys() callback. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/s390x/storage-keys.h | 1 + hw/s390x/s390-skeys.c | 7 ++- hw/s390x/s390-vir

[PATCH 00/16] Add Multi-Core Debug (MCD) API support

2025-03-15 Thread Mario Fleischmann
This patch series introduces support for the Multi-Core Debug (MCD) API, a commonly used debug interface by emulators. The MCD API, defined through a header file, consists of 54 functions for implementing debug and trace. However, since it is a header-file-only interface, MCD does not specify a com

Re: [PATCH 12/16] exec/ram_addr: call xen_hvm_modified_memory only if xen is enabled

2025-03-15 Thread Richard Henderson
On 3/9/25 21:58, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- include/exec/ram_addr.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

[PATCH] doc: add missing 'Asset' type in function test doc

2025-03-15 Thread Aditya Gupta
Seems 'Asset' got missed in the documentation by mistake. Also fix the one spellcheck issue pointed by spellcheck Signed-off-by: Aditya Gupta --- docs/devel/testing/functional.rst | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/devel/testing/functional.rst b/docs

Re: [PATCH 02/37] accel/tcg: Build plugin-gen.c once

2025-03-15 Thread Alex Bennée
Richard Henderson writes: > We assert that env immediately follows CPUState in cpu-all.h. > Change the offsetof expressions to be based on CPUState instead > of ArchCPU. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: Cross-compilation artifact is broken

2025-03-15 Thread Daniel P . Berrangé
On Fri, Mar 14, 2025 at 03:21:49PM +0100, Paolo Bonzini wrote: > On 3/12/25 15:23, Daniel P. Berrangé wrote: > > > > My question is, is this expected behavior or is this a bug? > > > > > > Your configure args don't include "--enable-debug", so I would > > > not have expected -gsplit-dwarf to have

Re: [RFC PATCH] meson.build: don't bother with split-debug for windows

2025-03-15 Thread Peter Maydell
On Fri, 14 Mar 2025 at 10:23, Alex Bennée wrote: > > It was reported this breaks the final artefacts on windows when run > under Wine. > > Signed-off-by: Alex Bennée > Cc: Konstantin Kostiuk > --- > meson.build | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/meson

Re: [PATCH 4/7] hw/hyperv/hyperv-proto: move SYNDBG definition from target/i386

2025-03-15 Thread Philippe Mathieu-Daudé
On 6/3/25 07:41, Pierrick Bouvier wrote: Allows them to be available for common compilation units. Signed-off-by: Pierrick Bouvier --- include/hw/hyperv/hyperv-proto.h | 12 target/i386/kvm/hyperv-proto.h | 12 2 files changed, 12 insertions(+), 12 deletions(-)

[PATCH v3 18/63] docs/qapi-domain: add "Return:" field lists

2025-03-15 Thread John Snow
Add "Return:" field list syntax to QAPI Commands. Like "Arguments:" and "Errors:", the type name isn't currently processed for cross-referencing, but this will be addressed in a forthcoming commit. The syntax of the new field is: :return TypeName: description description cont'd This patch ad

[PATCH 11/16] mcd test: Implement core state query

2025-03-15 Thread Mario Fleischmann
Depending on the VM and CPU state, core states can be queried: * MCD_CORE_STATE_DEBUG: VM halted or CPU artifically stopped * MCD_CORE_STATE_RUNNING: VM and CPU running * MCD_CORE_STATE_HALTED: CPU suspended Signed-off-by: Mario Fleischmann --- mcd/libmcd_qapi.c | 16 + mcd/libm

[PATCH v3 33/63] qapi: clean up encoding of section kinds

2025-03-15 Thread John Snow
We have several kinds of sections, and to tell them apart, we use Section attribute @tag and also the section object's Python type: type@tag untagged Section None @foo: ArgSection 'foo' Returns: Section 'Returns' Errors: Section 'Errors'

Re: [RFC PATCH v3 3/5] hw/vfio/ap: store object indicating AP config changed in a queue

2025-03-15 Thread Anthony Krowiak
On 3/10/25 11:35 AM, Rorie Reyes wrote: Creates an object indicating that an AP configuration change event has been received and stores it in a queue. These objects will later be used to store event information for an AP configuration change when the CHSC instruction is intercepted. Signed-o

[PULL 08/54] accel/tcg: Build tcg_flags helpers as common code

2025-03-15 Thread Philippe Mathieu-Daudé
While cpu-exec.c is build for each target,tcg_flags helpers aren't target specific. Move them to cpu-exec-common.c to build them once. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20250123234415.59850-8-phi...@linaro.org> --- accel/tcg/cpu-exec-common.c | 33

Re: [PATCH 07/16] codebase: prepare to remove cpu.h from exec/exec-all.h

2025-03-15 Thread Richard Henderson
On 3/9/25 21:58, Pierrick Bouvier wrote: diff --git a/page-vary-target.c b/page-vary-target.c index 3f81144cda8..12fda410bb0 100644 --- a/page-vary-target.c +++ b/page-vary-target.c @@ -20,8 +20,9 @@ #define IN_PAGE_VARY 1 #include "qemu/osdep.h" -#include "exec/page-vary.h" #include "e

[PATCH] docs: Explain how to use passt

2025-03-15 Thread Laurent Vivier
Add a chapter to explain how to use passt(1) instead of '-net user'. passt(1) can be connected to QEMU using UNIX socket or vhost-user. With vhost-user, migration of the VM is allowed and internal state of passt(1) is transfered from one side to the other Bug: https://gitlab.com/qemu-project/qemu/

Re: [PATCH 05/16] qemu/bswap: implement {ld,st}.*_p as functions

2025-03-15 Thread Richard Henderson
On 3/10/25 09:43, Pierrick Bouvier wrote: On 3/10/25 09:37, Richard Henderson wrote: On 3/10/25 09:14, Pierrick Bouvier wrote: On 3/10/25 09:08, Richard Henderson wrote: On 3/9/25 21:58, Pierrick Bouvier wrote: For now, they are duplicate of the same macros in cpu-all.h that we eliminate in n

Re: [PATCH V5] migration: ram block cpr blockers

2025-03-15 Thread Fabiano Rosas
Steve Sistare writes: > Unlike cpr-reboot mode, cpr-transfer mode cannot save volatile ram blocks > in the migration stream file and recreate them later, because the physical > memory for the blocks is pinned and registered for vfio. Add a blocker > for volatile ram blocks. > > Also add a blocke

Re: [PATCH v2 02/21] hw/vfio/spapr: Do not include

2025-03-15 Thread Eric Auger
On 3/9/25 12:08 AM, Philippe Mathieu-Daudé wrote: > is already include by "system/kvm.h" in the next line. included > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Pierrick Bouvier > Reviewed-by: Richard Henderson > Reviewed-by: Cédric Le Goater > --- > hw/vfio/spapr.c | 3 --- >

[PULL 08/42] MAINTAINERS: Add myself as vfio-igd maintainer

2025-03-15 Thread Cédric Le Goater
From: Tomita Moeko As suggested by Cédric, I'm glad to be a maintainer of vfio-igd. Signed-off-by: Tomita Moeko Reviewed-by: Alex Williamson Reviewed-by: Cédric Le Goater Link: https://lore.kernel.org/qemu-devel/20250227162741.9860-1-tomitamo...@gmail.com Signed-off-by: Cédric Le Goater ---

[PATCH 15/16] mcd: Implement trigger control

2025-03-15 Thread Mario Fleischmann
MCD's trigger API functions support multiple triggers by expecting a pointer to the trigger instance. Each trigger structure reserves the first four bytes for its size. To get the specific structure, read a uint32_t at passed pointer and compare it to the sizes of known trigger structures. This ap

Re: [BUG, RFC] cpr-transfer: qxl guest driver crashes after migration

2025-03-15 Thread Andrey Drobyshev
On 3/5/25 11:19 PM, Steven Sistare wrote: > On 3/5/2025 11:50 AM, Andrey Drobyshev wrote: >> On 3/4/25 9:05 PM, Steven Sistare wrote: >>> On 2/28/2025 1:37 PM, Andrey Drobyshev wrote: On 2/28/25 8:35 PM, Andrey Drobyshev wrote: > On 2/28/25 8:20 PM, Steven Sistare wrote: >> On 2/28/202

[PATCH v5 00/17] make system memory API available for common code

2025-03-15 Thread Pierrick Bouvier
The main goal of this series is to be able to call any memory ld/st function from code that is *not* target dependent. As a positive side effect, we can turn related system compilation units into common code. The first 5 patches remove dependency of memory API to cpu headers and remove dependency

Re: [PATCH 2/7] hw/hyperv/hyperv.h: header cleanup

2025-03-15 Thread Alex Bennée
Pierrick Bouvier writes: > Signed-off-by: Pierrick Bouvier > --- > include/hw/hyperv/hyperv.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/hw/hyperv/hyperv.h b/include/hw/hyperv/hyperv.h > index d717b4e13d4..c6f7039447f 100644 > --- a/include/hw/hyperv/hyp

Re: [PATCH 3/4] hw/rx: Reset the CPU at qemu reset time

2025-03-15 Thread Peter Maydell
On Tue, 18 Feb 2025 at 21:22, Keith Packard via wrote: > > This ensure that the CPU gets reset every time QEMU resets. Use either > the kernel entry point or the reset vector if no kernel was loaded. > > Signed-off-by: Keith Packard > --- > hw/rx/rx-gdbsim.c | 36

Re: [PATCH 0/4] hw/s390x: Alias @dump-skeys -> @dump-s390-skey and deprecate

2025-03-15 Thread Daniel P . Berrangé
On Mon, Mar 10, 2025 at 07:50:57AM +0100, Thomas Huth wrote: > On 09/03/2025 19.55, Pierrick Bouvier wrote: > > On 6/3/24 05:18, Daniel P. Berrangé wrote: > > > On Fri, May 31, 2024 at 06:47:45AM +0200, Thomas Huth wrote: > > > > On 30/05/2024 09.45, Philippe Mathieu-Daudé wrote: > > > > > We are t

[PULL 17/17] meson.build: Set RUST_BACKTRACE for all tests

2025-03-15 Thread Peter Maydell
We want to capture potential Rust backtraces on panics in our test logs, which isn't Rust's default behaviour. Set RUST_BACKTRACE=1 in the add_test_setup environments, so that all our tests get run with this environment variable set. This makes the setting of that variable in the gitlab CI templa

[PULL 04/25] rust: qemu_api_macros: add Wrapper derive macro

2025-03-15 Thread Paolo Bonzini
Add a derive macro that makes it easy to peel off all the layers of specialness (UnsafeCell, MaybeUninit, etc.) and just get a pointer to the wrapped type; and likewise add them back starting from a *mut. Reviewed-by: Zhao Liu Signed-off-by: Paolo Bonzini --- docs/devel/rust.rst |

Re: [PATCH v2 24/62] docs/qapi-domain: add :unstable: directive option

2025-03-15 Thread Markus Armbruster
John Snow writes: > Although "unstable" is a feature (and *will* appear in the features > list), add a special :unstable: option to generate an eye-catch that > makes this information very hard to miss. > > (The intent is to modify qapidoc.py to add this option whenever it > detects that the feat

[Stable-9.2.3 02/51] target/arm: Report correct syndrome for UNDEFINED AT ops with wrong NSE, NS

2025-03-15 Thread Michael Tokarev
From: Peter Maydell R_NYXTL says that these AT insns should be UNDEFINED if they would operate on an EL lower than EL3 and SCR_EL3.{NSE,NS} is set to the Reserved {1, 0}. We were incorrectly reporting them with the wrong syndrome; use CP_ACCESS_TRAP_UNCATEGORIZED so they are reported as UNDEFINED

Re: [PATCH 04/16] exec/memory.h: make devend_memop target agnostic

2025-03-15 Thread Pierrick Bouvier
On 3/10/25 08:25, Richard Henderson wrote: On 3/9/25 21:58, Pierrick Bouvier wrote: Will allow to make system/memory.c common later. Signed-off-by: Pierrick Bouvier --- include/exec/memory.h | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) I guess this was split from p

Re: [PATCH 31/37] include/hw/core: Drop ifndef CONFIG_USER_ONLY from cpu.h

2025-03-15 Thread Pierrick Bouvier
On 3/12/25 20:45, Richard Henderson wrote: We were hiding a number of declarations from user-only, although it hurts nothing to allow them. Signed-off-by: Richard Henderson --- include/hw/core/cpu.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/include/hw/core/cpu.h b/includ

[PULL 01/17] target/arm: Move A32_BANKED_REG_{GET, SET} macros to cpregs.h

2025-03-15 Thread Peter Maydell
The A32_BANKED_REG_{GET,SET} macros are only used inside target/arm; move their definitions to cpregs.h. There's no need to have them defined in all the code that includes cpu.h. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target/arm/cpregs.h | 28 +++

[Stable-9.2.3 09/51] Kconfig: Extract CONFIG_USB_CHIPIDEA from CONFIG_IMX

2025-03-15 Thread Michael Tokarev
From: Bernhard Beschow TYPE_CHIPIDEA models an IP block which is also used in TYPE_ZYNQ_MACHINE which itself is not an IMX device. CONFIG_ZYNQ selects CONFIG_USB_EHCI_SYSBUS while TYPE_CHIPIDEA is a separate compilation unit, so only works by accident if CONFIG_IMX is given. Fix that by extractin

Re: [PATCH 2/3] hw/loongarch/virt: Remove unnecessary NULL pointer checking

2025-03-15 Thread bibo mao
On 2025/3/14 下午1:38, Markus Armbruster wrote: bibo mao writes: On 2025/3/13 下午6:32, Markus Armbruster wrote: [...] diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index a5840ff968..4674bd9163 100644 --- a/hw/loongarch/virt.c +++ b/hw/loongarch/virt.c @@ -859,30 +859,29 @@ static vo

[PATCH 09/13] hw/arm: Introduce ASPEED AST2700 a0 full core machine

2025-03-15 Thread Steven Lee via
This commit introduces support for the ASPEED AST2700 full core machine. It includes the initialization of CA35, SSP, and TSP components with their respective memory regions and clocks. The new file aspeed_ast27x0-fc.c defines the machine type "ast2700fc-a0" and its initialization functions. Additi

Re: [PATCH v5 8/8] ppc/pnv: Update skiboot to support Power11

2025-03-15 Thread Aditya Gupta
On 09/03/25 19:40, Cédric Le Goater wrote: On 3/8/25 21:51, Aditya Gupta wrote: Update skiboot.lid to below commit which adds support for booting on Power11: commit 785a5e3070a8 ("platform: Identify correct bmc platform based on bmc hw version") Built with glibc 2.40 and gcc 14.2 (Fedo

[PATCH v6 28/29] tests/functional/aspeed: Add test case for AST2700 A1

2025-03-15 Thread Jamin Lin via
Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater --- tests/functional/test_aarch64_aspeed.py | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tests/functional/test_aarch64_aspeed.py b/tests/functional/test_aarch64_aspeed.py index 8df6a97a28..c25c966278 100755 --- a/tests/fu

[PATCH v2 1/3] tests/functional/asset: Fail assert fetch when retries are exceeded

2025-03-15 Thread Nicholas Piggin
Currently the fetch code does not fail gracefully when retry limit is exceeded, it just falls through the loop with no file, which ends up hitting other errors. Add a check for non-existing file, which indicates the retry limit was exceeded. Signed-off-by: Nicholas Piggin --- tests/functional/q

[Stable-9.2.3 44/51] xen: No need to flush the mapcache for grants

2025-03-15 Thread Michael Tokarev
From: Stefano Stabellini On IOREQ_TYPE_INVALIDATE we need to invalidate the mapcache for regular mappings. Since recently we started reusing the mapcache also to keep track of grants mappings. However, there is no need to remove grant mappings on IOREQ_TYPE_INVALIDATE requests, we shouldn't do th

Re: [PATCH 28/37] plugins: Move api.c, core.c to libuser_ss, libsystem_ss

2025-03-15 Thread Pierrick Bouvier
On 3/12/25 20:45, Richard Henderson wrote: Headers used by these files require CONFIG_USER_ONLY. Signed-off-by: Richard Henderson --- plugins/meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/plugins/meson.build b/plugins/meson.build index 3be8245a69..5383c7

[PULL 36/54] target: Set disassemble_info::endian value for little-endian targets

2025-03-15 Thread Philippe Mathieu-Daudé
Have the CPUClass::disas_set_info() callback set the disassemble_info::endian field for little-endian targets. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Message-Id: <20250210212931.62401-2-phi...@linaro.org> --- target/alpha/cpu.c | 1 +

[PULL 18/54] accel/tcg: Move cpu_memory_rw_debug() user implementation to user-exec.c

2025-03-15 Thread Philippe Mathieu-Daudé
cpu_memory_rw_debug() system implementation is defined in system/physmem.c. Move the user one to accel/tcg/user-exec.c to simplify cpu-target.c maintenance. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20250217130610.18313-6-phi...@linaro.org> --- accel/tcg/

Re: [PATCH v2] vfio/igd: Update IGD passthrough documentation

2025-03-15 Thread Cédric Le Goater
On 3/13/25 16:03, Tomita Moeko wrote: A previous change made the OpRegion and LPC quirks independent of the existing legacy mode, update the documentation accordingly. More related topics, like creating EFI Option ROM of IGD for OVMF, how to solve the VFIO_DMA_MAP Invalid Argument warning, as wel

[PATCH for-10.1 v9 4/9] pcie_sriov: Check PCI Express for SR-IOV PF

2025-03-15 Thread Akihiko Odaki
SR-IOV requires PCI Express. Signed-off-by: Akihiko Odaki --- hw/pci/pcie_sriov.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/pci/pcie_sriov.c b/hw/pci/pcie_sriov.c index 109b2ebcccba..a5b546abe8bb 100644 --- a/hw/pci/pcie_sriov.c +++ b/hw/pci/pcie_sriov.c @@ -42,6 +42,11 @@ bool

[PATCH 02/16] mcd: Introduce MCD server

2025-03-15 Thread Mario Fleischmann
The MCD implementation follows a remote procedure call approach and uses QMP as the communication protocol: * mcdserver implements the MCD API * mcd.json and mcdstub_qapi.c declare and implement the server stub Our client stub supporting QMP can be found at: https://gitlab.com/lauterbach/mcdrefsr

Re: [RFC PATCH 04/18] qemu: Introduce 'qemu/legacy_binary_info.h'

2025-03-15 Thread BALATON Zoltan
On Thu, 6 Mar 2025, Pierrick Bouvier wrote: On 3/6/25 07:28, BALATON Zoltan wrote: On Thu, 6 Mar 2025, Daniel P. Berrangé wrote: On Thu, Mar 06, 2025 at 02:45:52PM +0100, BALATON Zoltan wrote: On Thu, 6 Mar 2025, Daniel P. Berrangé wrote: On Thu, Mar 06, 2025 at 12:34:13PM +0100, Paolo Bonzin

[PATCH v6 24/29] hw/arm/aspeed_ast27x0: Sort the memmap table by mapping address

2025-03-15 Thread Jamin Lin via
To improve readability, sort the memmap table by mapping address Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater --- hw/arm/aspeed_ast27x0.c | 54 - 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/as

[PATCH v2] tests/qtest: Unit test for pcf8563_rtc

2025-03-15 Thread Ilya Chichkov
Add a unit test for pcf8563_rtc module - Check default value after initialization - Check set/get time - Check minute alarm - Check hour alarm - Check day alarm - Check wday alarm - Check minute & hour alarm - Check minute & day alarm - Check day & wday alarm - Check timer --- v1->v2 Phil: - Add h

Re: [PATCH 16/16] system/ioport: make compilation unit common

2025-03-15 Thread Richard Henderson
On 3/9/25 21:58, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- system/ioport.c| 1 - system/meson.build | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH] block: Fix bdrv_activate() not to fail without medium

2025-03-15 Thread Kevin Wolf
Am 12.03.2025 um 15:37 hat Markus Armbruster geschrieben: > bdrv_activate() returns failure without setting an error when > !bs->drv. This is suspicious. Turns out it used to succeed then, > until commit 5416645fcf82 changed it to return -ENOMEDIUM. > > Return zero instead. > > Fixes: 5416645fc

Re: [PATCH v2 13/21] hw/vfio/igd: Compile once

2025-03-15 Thread Cédric Le Goater
On 3/9/25 00:09, Philippe Mathieu-Daudé wrote: The file doesn't use any target-specific knowledge anymore, move it to system_ss[] to build it once. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/vfio/meson.build | 5 +++-- 1 file changed, 3 ins

RE: [PATCH v4 18/23] hw/arm/aspeed_ast27x0: Support two levels of INTC controllers for AST2700 A1

2025-03-15 Thread Jamin Lin
Hi Cedric, > Cc: Troy Lee > Subject: Re: [PATCH v4 18/23] hw/arm/aspeed_ast27x0: Support two levels of > INTC controllers for AST2700 A1 > > On 3/3/25 10:54, Jamin Lin wrote: > > The design of INTC controllers has significantly changed in AST2700 A1. > > > > There are a total of 480 interrupt so

Re: [PATCH 10/37] accel/tcg: Use cpu_ld*_code_mmu in translator.c

2025-03-15 Thread Philippe Mathieu-Daudé
On 13/3/25 10:54, Philippe Mathieu-Daudé wrote: Hi Richard, On 13/3/25 04:44, Richard Henderson wrote: Cache the mmu index in DisasContextBase. Perform the read on host endianness, which lets us share code with the translator_ld fast path. Signed-off-by: Richard Henderson ---   include/exec/t

[PATCH 1/7] hw/hyperv/hv-balloon-stub: common compilation unit

2025-03-15 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- hw/hyperv/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/hyperv/meson.build b/hw/hyperv/meson.build index d3d2668c71a..f4aa0a5ada9 100644 --- a/hw/hyperv/meson.build +++ b/hw/hyperv/meson.build @@ -2,4 +2,5 @@ specific_ss.a

Re: [PATCH v3 6/7] memory: Attach MemoryAttributeManager to guest_memfd-backed RAMBlocks

2025-03-15 Thread Chenyi Qiang
Hi David & Alexey, To keep the bitmap aligned, I add the undo operation for set_memory_attributes() and use the bitmap + replay callback to do set_memory_attributes(). Does this change make sense? Alexey, I didn't add your Reivewed-by since this patch introduced some new changes. On 3/10/2025 4:

Re: [RFC] Proposal for a QEMU video subsystem for cameras and webcams

2025-03-15 Thread Thomas Huth
On 10/03/2025 17.51, Alex Bennée wrote: David Milosevic writes: Dear QEMU Developers, I would like to propose the development of a video subsystem in QEMU, with the initial implementation focusing on UVC video device emulation and support for multiple backends, including V4L2, GStreamer, and

Re: [PATCH 0/7] hw/hyperv: remove duplication compilation units

2025-03-15 Thread Richard Henderson
On 3/5/25 22:41, Pierrick Bouvier wrote: Work towards having a single binary, by removing duplicated object files. hw/hyperv/hyperv.c was excluded at this time, because it depends on target dependent symbols: - from system/kvm.h - kvm_check_extension - kvm_vm_ioctl - from exec/cpu-all.

[PATCH v2 0/2] i.MX 8M Plus EVK Fixes

2025-03-15 Thread Bernhard Beschow
As discussed in [1], this series modifies the SoC class be derived from TYPE_SYS_BUS_DEVICE to fix the reset mechanism and to prevent it from being user-creatable. It also removes an unused define. v2: * Do not set user_creatable = false; (Zoltan, Peter) [1] https://lore.kernel.org/qemu-devel/1c

Re: [PATCH v3 0/2] target/riscv: throw debug exception before page fault

2025-03-15 Thread Alistair Francis
On Thu, Mar 6, 2025 at 4:33 PM Michael Tokarev wrote: > > 21.01.2025 20:06, Daniel Henrique Barboza wrote: > > Hi, > > > > In this new version, in patch 2, we're using the address 'size' val from > > riscv_cpu_tlb_fill() instead of infering it from the CPU XLEN. > > > > No other changes made. Pat

[RFC] Proposal for a QEMU video subsystem for cameras and webcams

2025-03-15 Thread David Milosevic
Dear QEMU Developers, I would like to propose the development of a video subsystem in QEMU, with the initial implementation focusing on UVC video device emulation and support for multiple backends, including V4L2, GStreamer, and libcamera. This work is already in progress at 9elements, and we wou

Re: [PATCH v2] docs: Explain how to use passt

2025-03-15 Thread Laurent Vivier
cc: trivial On 11/03/2025 14:27, Laurent Vivier wrote: Add a chapter to explain how to use passt(1) instead of '-net user'. passt(1) can be connected to QEMU using UNIX socket or vhost-user. With vhost-user, migration of the VM is allowed and internal state of passt(1) is transfered from one sid

Re: [PATCH v2 03/14] ppc/xive2: Add grouping level to notification

2025-03-15 Thread Nicholas Piggin
On Tue Dec 10, 2024 at 10:05 AM AEST, Michael Kowal wrote: > From: Frederic Barrat > > The NSR has a (so far unused) grouping level field. When a interrupt > is presented, that field tells the hypervisor or OS if the interrupt > is for an individual VP or for a VP-group/crowd. This patch reworks >

[PULL 06/17] target/arm: Move arm_current_el() and arm_el_is_aa64() to internals.h

2025-03-15 Thread Peter Maydell
The functions arm_current_el() and arm_el_is_aa64() are used only in target/arm and in hw/intc/arm_gicv3_cpuif.c. They're functions that query internal state of the CPU. Move them out of cpu.h and into internals.h. This means we need to include internals.h in arm_gicv3_cpuif.c, but this is justi

[PATCH v3 2/4] hw/s390x/skeys: Introduce TYPE_DUMP_SKEYS_INTERFACE

2025-03-15 Thread Philippe Mathieu-Daudé
The storage keys are part of the machine memory. Introduce the TYPE_DUMP_SKEYS_INTERFACE type, allowing machine using storage keys to dump them when a DumpSKeysInterface::qmp_dump_skeys() callback is provided. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/s390x/storage-keys.h | 15 ++

[PATCH 4/7] hw/hyperv/hyperv-proto: move SYNDBG definition from target/i386

2025-03-15 Thread Pierrick Bouvier
Allows them to be available for common compilation units. Signed-off-by: Pierrick Bouvier --- include/hw/hyperv/hyperv-proto.h | 12 target/i386/kvm/hyperv-proto.h | 12 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/include/hw/hyperv/hyperv-proto.h

[PULL 24/42] migration/multifd: Make MultiFDSendData a struct

2025-03-15 Thread Cédric Le Goater
From: Peter Xu The newly introduced device state buffer can be used for either storing VFIO's read() raw data, but already also possible to store generic device states. After noticing that device states may not easily provide a max buffer size (also the fact that RAM MultiFDPages_t after all als

Re: [PATCH v2 7/9] cpu: Introduce cpu_get_phys_bits()

2025-03-15 Thread Philippe Mathieu-Daudé
On 30/1/25 14:43, Cédric Le Goater wrote: The Intel CPU has a complex history regarding setting of the physical address space width on KVM. A 'phys_bits' field and a "phys-bits" property were added by commit af45907a1328 ("target-i386: Allow physical address bits to be set") to tune this value.

[PATCH 03/14] hw/vfio: Compile some common objects once

2025-03-15 Thread Philippe Mathieu-Daudé
Some files don't rely on any target-specific knowledge and can be compiled once: - helpers.c - container-base.c - migration.c (removing unnecessary "exec/ram_addr.h") - migration-multifd.c - cpr.c Signed-off-by: Philippe Mathieu-Daudé --- hw/vfio/migration.c | 1 - hw/vfio/meson.build | 1

Re: [PATCH 0/4] hw/s390x: Alias @dump-skeys -> @dump-s390-skey and deprecate

2025-03-15 Thread Thomas Huth
On 09/03/2025 19.55, Pierrick Bouvier wrote: On 6/3/24 05:18, Daniel P. Berrangé wrote: On Fri, May 31, 2024 at 06:47:45AM +0200, Thomas Huth wrote: On 30/05/2024 09.45, Philippe Mathieu-Daudé wrote: We are trying to unify all qemu-system-FOO to a single binary. In order to do that we need to

[PATCH v2 15/16] system/memory: make compilation unit common

2025-03-15 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- system/memory.c| 17 + system/meson.build | 2 +- 2 files changed, 6 insertions(+), 13 deletions(-) diff --git a/system/memory.c b/system/memory.c index 4c829793a0a..eddd21a6cdb 100644 --- a/system/memory.c +++ b/system/memory.c @@ -353,15

Re: [PATCH v2 02/10] target/i386: disable PERFCORE when "-pmu" is configured

2025-03-15 Thread Zhao Liu
Hi Dongli, > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > index b6d6167910..61a671028a 100644 > --- a/target/i386/cpu.c > +++ b/target/i386/cpu.c > @@ -7115,6 +7115,10 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index, > uint32_t count, > !(env->hflags & HF_LMA_MASK)) {

Re: [PATCH] tests/functional: fix race in virtio balloon test

2025-03-15 Thread Thomas Huth
On 05/03/2025 13.25, Philippe Mathieu-Daudé wrote: Hi Daniel, On 4/3/25 19:33, Daniel P. Berrangé wrote: There are two race conditions in the recently added virtio balloon test   * The /dev/vda device node is not ready   * The virtio-balloon driver has not issued the first stats refresh To fi

Re: [PATCH v2 1/3] hw/s390x: Expose s390_qmp_dump_skeys() prototype

2025-03-15 Thread Thomas Huth
On 10/03/2025 14.31, Philippe Mathieu-Daudé wrote: In preparation to make @dump-skeys command generic, extract s390_qmp_dump_skeys() out of qmp_dump_skeys(). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/s390x/storage-keys.h | 1 + hw/s390x/s390-skeys.c | 7 ++- 2 files

[PULL 13/17] Revert "hw/char/pl011: Warn when using disabled receiver"

2025-03-15 Thread Peter Maydell
From: Paolo Bonzini The guest does not control whether characters are sent on the UART. Sending them before the guest happens to boot will now result in a "guest error" log entry that is only because of timing, even if the guest _would_ later setup the receiver correctly. This reverts the bulk o

  1   2   3   >