Re: [PATCH] tests/functional: Require 'user' netdev for ppc64 e500 test

2025-03-07 Thread Philippe Mathieu-Daudé
On 8/3/25 08:13, Cédric Le Goater wrote: When commit 72cdd672e18c extended the ppc64 e500 test to add network support, it forgot to require the 'user' netdev backend. Fix that. Fixes: 72cdd672e18c ("tests/functional: Replace the ppc64 e500 advent calendar test") Signed-off-by: Cédric Le Goater

[PATCH v2 15/18] accel/tcg: Restrict GETPC_ADJ() to 'tb-internal.h'

2025-03-07 Thread Philippe Mathieu-Daudé
GETPC_ADJ() is only used within accel/tcg/, no need to expose it to all the code base. Signed-off-by: Philippe Mathieu-Daudé --- accel/tcg/tb-internal.h | 11 +++ include/exec/exec-all.h | 9 - 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/accel/tcg/tb-internal

[PATCH v2 16/18] accel/tcg: Split out getpc.h

2025-03-07 Thread Philippe Mathieu-Daudé
From: Richard Henderson Split out GETPC to a target-independent header. Signed-off-by: Richard Henderson Reviewed-by: Pierrick Bouvier Signed-off-by: Philippe Mathieu-Daudé --- include/accel/tcg/getpc.h | 24 include/exec/exec-all.h | 11 ++- accel/tcg/tcg-

[PATCH v2 17/18] accel/tcg: Build tcg-runtime.c once

2025-03-07 Thread Philippe Mathieu-Daudé
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Pierrick Bouvier Signed-off-by: Philippe Mathieu-Daudé --- accel/tcg/tcg-runtime.c | 7 +-- accel/tcg/meson.build | 2 +- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/accel/tcg/tcg-runtime.c b/accel/

[PATCH v2 00/18] accel/tcg: Compile more files once

2025-03-07 Thread Philippe Mathieu-Daudé
Since v1: - Patches 1-13,16 unmodified - Restrict GETPC_ADJ() - Rename accel/tcg/getpc.h - Guard GETPC() within CONFIG_TCG Take care of some easy cases in accel/tcg/. >From here it starts getting harder. 🙂 Philippe Mathieu-Daudé (7): exec: Declare tlb_reset_dirty*() in 'exec/cputlb.h' exec:

Re: [PATCH 19/57] docs/qapi-domain: add qapi:event directive

2025-03-07 Thread Markus Armbruster
John Snow writes: > On Fri, Mar 7, 2025 at 5:26 AM Markus Armbruster wrote: > >> John Snow writes: >> >> > Adds the .. qapi:event:: directive, object, and :qapi:event:`name` >> > cross-referencing role. >> > >> > Adds the :memb type name: field list syntax for documenting event data >> > member

[PATCH v6 00/29] Support AST2700 A1

2025-03-07 Thread Jamin Lin via
v1: 1. Refactor INTC model to support both INTC0 and INTC1. 2. Support AST2700 A1. 3. Create ast2700a0-evb machine. v2: To streamline the review process, split the following patch series into three parts. https://patchwork.kernel.org/project/qemu-devel/cover/20250121070424.2465942-1-jam

Re: [PATCH 18/57] docs/qapi-domain: add qapi:alternate directive

2025-03-07 Thread Markus Armbruster
John Snow writes: > On Fri, Mar 7, 2025 at 5:18 AM Markus Armbruster wrote: > >> John Snow writes: >> >> > Add the .. qapi:alternate:: directive, object, and qapi:alt:`name` >> > cross-reference role. >> > >> > Add the "Choices:" field list for describing alternate choices. Like >> > other fiel

Re: [PATCH 16/57] docs/qapi-domain: add "Returns:" field lists

2025-03-07 Thread Markus Armbruster
John Snow writes: > On Fri, Mar 7, 2025 at 2:58 AM Markus Armbruster wrote: > >> John Snow writes: >> >> > Add "Returns:" field list syntax to QAPI Commands. >> > >> > Like "Arguments:" and "Errors:", the type name isn't currently processed >> > for cross-referencing, but this will be addressed

Re: [PATCH 15/57] docs/qapi-domain: add "Errors:" field lists

2025-03-07 Thread Markus Armbruster
John Snow writes: > On Fri, Mar 7, 2025 at 2:48 AM Markus Armbruster wrote: > >> John Snow writes: >> >> > ``:error: descr`` can now be used to document error conditions. The >> > format of the description is not defined here; so the ability to name >> > specific types is left to the document w

Re: [PATCH] usb-storage: Allow manually adding SCSI device

2025-03-07 Thread Akihiko Odaki
On 2025/03/03 21:17, Paolo Bonzini wrote: On 3/3/25 11:28, Akihiko Odaki wrote: usb-storage automatically adds a SCSI device, but it limits configurability of the added SCSI device and causes usability problems as observed in: https://gitlab.com/libvirt/libvirt/-/issues/368 Allow manually addin

Re: [PATCH qemu v2 1/3] hw/s390x: add CPI identifiers to QOM

2025-03-07 Thread shalini
On 2025-03-05 16:56, Thomas Huth wrote: On 24/02/2025 13.04, Shalini Chellathurai Saroja wrote: Add Control-Program Identification (CPI) to the QEMU Object Model (QOM). The CPI identifiers provide information about the guest operating system. The CPI identifiers are: system type, system name, sy

[PULL 18/42] migration: Add thread pool of optional load threads

2025-03-07 Thread Cédric Le Goater
From: "Maciej S. Szmigiero" Some drivers might want to make use of auxiliary helper threads during VM state loading, for example to make sure that their blocking (sync) I/O operations don't block the rest of the migration process. Add a migration core managed thread pool to facilitate this use c

Re: [PULL 8/8] migration: Add qtest for migration over RDMA

2025-03-07 Thread Philippe Mathieu-Daudé
Hi, On 7/3/25 19:15, Fabiano Rosas wrote: From: Li Zhijian This qtest requires there is a RDMA(RoCE) link in the host. In order to make the test work smoothly, introduce a scripts/rdma-migration-helper.sh to - setup a new Soft-RoCE(aka RXE) if it's root - detect existing RoCE link Test will b

[PULL 04/10] qdev: Delete unused qdev_prop_enum

2025-03-07 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-ID: <20250227085601.4140852-2-arm...@redhat.com> Reviewed-by: Daniel P. Berrangé --- include/hw/qdev-properties.h | 1 - hw/core/qdev-properties.c| 7 --- 2 files changed, 8 deletions(-) diff --git a/include/hw/qdev-properties.h b/include/hw/qdev

[PULL 29/42] vfio/migration: Add vfio_add_bytes_transferred()

2025-03-07 Thread Cédric Le Goater
From: "Maciej S. Szmigiero" This way bytes_transferred can also be incremented in other translation units than migration.c. Signed-off-by: Maciej S. Szmigiero Reviewed-by: Cédric Le Goater Link: https://lore.kernel.org/qemu-devel/d1fbc27ac2417b49892f354ba20f6c6b3f7209f8.1741124640.git.maciej.

Re: [PATCH v2 5/7] hw/virtio/virtio-mem: Convert VIRTIO_MEM_USABLE_EXTENT to runtime

2025-03-07 Thread Philippe Mathieu-Daudé
On 7/3/25 23:39, Philippe Mathieu-Daudé wrote: Use qemu_arch_available() to check at runtime if a target architecture is built in. Consider the maximum extent size of any architecture built in. Signed-off-by: Philippe Mathieu-Daudé --- hw/virtio/virtio-mem.c | 28

[PULL 39/42] vfio/migration: Multifd device state transfer support - send side

2025-03-07 Thread Cédric Le Goater
From: "Maciej S. Szmigiero" Implement the multifd device state transfer via additional per-device thread inside save_live_complete_precopy_thread handler. Switch between doing the data transfer in the new handler and doing it in the old save_state handler depending if VFIO multifd transfer is en

[PATCH 1/5] file-posix: Support FUA writes

2025-03-07 Thread Kevin Wolf
Until now, FUA was always emulated with a separate flush after the write for file-posix. The overhead of processing a second request can reduce performance significantly for a guest disk that has disabled the write cache, especially if the host disk is already write through, too, and the flush isn'

RE: [PATCH 25/38] target/hexagon: Add TCG overrides for thread ctl

2025-03-07 Thread ltaylorsimpson
> -Original Message- > From: Brian Cain > Sent: Friday, February 28, 2025 11:26 PM > To: qemu-devel@nongnu.org > Cc: brian.c...@oss.qualcomm.com; richard.hender...@linaro.org; > phi...@linaro.org; quic_mathb...@quicinc.com; a...@rev.ng; a...@rev.ng; > quic_mlie...@quicinc.com; ltaylorsi

RE: [PATCH 24/38] target/hexagon: Add TCG overrides for int handler insts

2025-03-07 Thread ltaylorsimpson
> -Original Message- > From: Brian Cain > Sent: Friday, February 28, 2025 11:26 PM > To: qemu-devel@nongnu.org > Cc: brian.c...@oss.qualcomm.com; richard.hender...@linaro.org; > phi...@linaro.org; quic_mathb...@quicinc.com; a...@rev.ng; a...@rev.ng; > quic_mlie...@quicinc.com; ltaylorsi

RE: [PATCH 22/38] target/hexagon: Add sysemu TCG overrides

2025-03-07 Thread ltaylorsimpson
> -Original Message- > From: Brian Cain > Sent: Friday, February 28, 2025 11:26 PM > To: qemu-devel@nongnu.org > Cc: brian.c...@oss.qualcomm.com; richard.hender...@linaro.org; > phi...@linaro.org; quic_mathb...@quicinc.com; a...@rev.ng; a...@rev.ng; > quic_mlie...@quicinc.com; ltaylorsi

RE: [PATCH 21/38] target/hexagon: Add system reg insns

2025-03-07 Thread ltaylorsimpson
> -Original Message- > From: Brian Cain > Sent: Friday, February 28, 2025 11:26 PM > To: qemu-devel@nongnu.org > Cc: brian.c...@oss.qualcomm.com; richard.hender...@linaro.org; > phi...@linaro.org; quic_mathb...@quicinc.com; a...@rev.ng; a...@rev.ng; > quic_mlie...@quicinc.com; ltaylorsi

Re: [RFC PATCH 0/5] hw/arm/virt: Add support for user-creatable nested SMMUv3

2025-03-07 Thread Eric Auger
Hi Shammeer, On 2/18/25 7:52 AM, Shameerali Kolothum Thodi wrote: > Hi Zhenzhong, > >> -Original Message- >> From: Duan, Zhenzhong >> Sent: Monday, February 17, 2025 9:17 AM >> To: Shameerali Kolothum Thodi >> ; Nicolin Chen >> ; Donald Dutile >> Cc: eric.au...@redhat.com; Peter Maydell

Re: [PATCH v7 0/5] Allow to enable multifd and postcopy migration together

2025-03-07 Thread Prasad Pandit
Hello Fabiano, On Wed, 5 Mar 2025 at 19:26, Fabiano Rosas wrote: > Note that none of this is out of the ordinary, you'll find such > discussions in any thread on this community. It may feel arbitrary to > you because that's tacit knowledge we gathered along the years. * I understand. I don't fin

RE: [PATCH 08/38] target/hexagon: Add guest, system reg number defs

2025-03-07 Thread Sid Manning
> -Original Message- > From: ltaylorsimp...@gmail.com > Sent: Thursday, March 6, 2025 3:30 PM > To: 'Brian Cain' ; qemu-devel@nongnu.org > Cc: richard.hender...@linaro.org; phi...@linaro.org; Matheus Bernardino > (QUIC) ; a...@rev.ng; a...@rev.ng; Marco > Liebel (QUIC) ; alex.ben...@lina

Re: [PATCH v7 2/2] target/loongarch: check tlb_ps

2025-03-07 Thread bibo mao
Reviewed-by: Bibo Mao On 2025/3/5 下午2:33, Song Gao wrote: For LoongArch th min tlb_ps is 12(4KB), for TLB code, the tlb_ps may be 0,this may case UndefinedBehavior Add a check-tlb_ps fuction to check tlb_ps, to make sure the tlb_ps is avalablie. we check tlb_ps when get the tlb_ps from tlb->mis

[PATCH 00/14] hw/vfio: Build various objects once

2025-03-07 Thread Philippe Mathieu-Daudé
By doing the following changes: - Clean some headers up - Replace compile-time CONFIG_KVM check by kvm_enabled() - Replace compile-time CONFIG_IOMMUFD check by iommufd_builtin() we can build less vfio objects. Philippe Mathieu-Daudé (14): hw/vfio/common: Include missing 'system/tcg.h' header h

[PULL 02/21] hw/gpio: npcm7xx: fixup out-of-bounds access

2025-03-07 Thread Peter Maydell
From: Patrick Venture The reg isn't validated to be a possible register before it's dereferenced for one case. The mmio space registered for the gpio device is 4KiB but there aren't that many registers in the struct. Cc: qemu-sta...@nongnu.org Fixes: 526dbbe0874 ("hw/gpio: Add GPIO model for Nu

Re: [PATCH 10/14] system/iommufd: Introduce iommufd_builtin() helper

2025-03-07 Thread Pierrick Bouvier
On 3/7/25 10:03, Philippe Mathieu-Daudé wrote: iommufd_builtin() can be used to check at runtime whether the IOMMUFD feature is built in a qemu-system binary. Signed-off-by: Philippe Mathieu-Daudé --- docs/devel/vfio-iommufd.rst | 2 +- include/system/iommufd.h| 8 2 files chan

Re: [PATCH 00/16] accel/tcg: Compile more files once

2025-03-07 Thread Pierrick Bouvier
On 3/7/25 10:56, Richard Henderson wrote: Take care of some easy cases in accel/tcg/. From here it starts getting harder. :-) It would be convenient to work on top of it. Could you rebase it on top of master? Thanks, Pierrick r~ Philippe Mathieu-Daudé (6): exec: Declare tlb_reset_di

[PATCH v3 6/7] hw/hyperv/balloon: common balloon compilation units

2025-03-07 Thread Pierrick Bouvier
Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/hyperv/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/hyperv/meson.build b/hw/hyperv/meson.build index a9f2045a9af..5acd709bdd5 100644 --- a/hw/hyperv/meson.build +++ b/hw/hyperv/meson.build

Re: [PATCH V1 1/4] migration: cpr_is_incoming

2025-03-07 Thread Peter Xu
On Fri, Mar 07, 2025 at 12:55:51PM -0800, Steve Sistare wrote: > Define the cpr_is_incoming helper, to be used in several cpr fix patches. > > Signed-off-by: Steve Sistare Reviewed-by: Peter Xu -- Peter Xu

Re: [PATCH 19/57] docs/qapi-domain: add qapi:event directive

2025-03-07 Thread John Snow
On Fri, Mar 7, 2025 at 5:26 AM Markus Armbruster wrote: > John Snow writes: > > > Adds the .. qapi:event:: directive, object, and :qapi:event:`name` > > cross-referencing role. > > > > Adds the :memb type name: field list syntax for documenting event data > > members. As this syntax and phrasing

Re: [PATCH 18/57] docs/qapi-domain: add qapi:alternate directive

2025-03-07 Thread John Snow
On Fri, Mar 7, 2025 at 5:18 AM Markus Armbruster wrote: > John Snow writes: > > > Add the .. qapi:alternate:: directive, object, and qapi:alt:`name` > > cross-reference role. > > > > Add the "Choices:" field list for describing alternate choices. Like > > other field lists that reference QAPI ty

Re: [PATCH v6 0/6] target/i386: Update EPYC CPU models for Cache property, RAS, SVM feature and add EPYC-Turin CPU model

2025-03-07 Thread Moger, Babu
Hi Paolo, Can you please pull these series if you don't have any concerns. Thanks Babu On 2/28/2025 12:07 PM, Babu Moger wrote: Following changes are implemented in this series. 1. Fixed the cache(L2,L3) property details in all the EPYC models. 2. Add RAS feature bits (SUCCOR, McaOverflowRec

Re: [PATCH 16/57] docs/qapi-domain: add "Returns:" field lists

2025-03-07 Thread John Snow
On Fri, Mar 7, 2025 at 2:58 AM Markus Armbruster wrote: > John Snow writes: > > > Add "Returns:" field list syntax to QAPI Commands. > > > > Like "Arguments:" and "Errors:", the type name isn't currently processed > > for cross-referencing, but this will be addressed in a forthcoming > > commit.

[PATCH v2 4/7] hw/virtio/virtio-mem: Remove CONFIG_DEVICES include

2025-03-07 Thread Philippe Mathieu-Daudé
Rather than checking ACPI availability at compile time by checking the CONFIG_ACPI definition from CONFIG_DEVICES, check at runtime via acpi_builtin(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: David Hildenbrand Reviewed-by: Pierrick Bouvier --- hw/virtio/virtio-mem.c | 6 ++ 1 fi

[PATCH v2 0/7] hw/virtio: Build virtio-mem.c once

2025-03-07 Thread Philippe Mathieu-Daudé
Missing review: #5 (reworked, R-b tags dropped) Since v1: - Use max extent size of all archs (David) Replace compile-time checks by runtime ones: - CONFIG_DEVICES::CONFIG_ACPI -> acpi_builtin() - TARGET_FOO || TARGET_BAR -> qemu_arch_available(FOO|BAR) Philippe Mathieu-Daudé (7): system: Repla

[PULL 03/54] gdbstub: Check for TCG before calling tb_flush()

2025-03-07 Thread Philippe Mathieu-Daudé
Use the tcg_enabled() check so the compiler can elide the call when TCG isn't available, allowing to remove the tb_flush() stub. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20250123234415.59850-4-phi...@linaro.org> --- accel/stubs/

[PATCH v2 4/7] hw/hyperv/hyperv-proto: move SYNDBG definition from target/i386

2025-03-07 Thread Pierrick Bouvier
Allows them to be available for common compilation units. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Pierrick Bouvier --- include/hw/hyperv/hyperv-proto.h | 12 target/i386/kvm/hyperv-proto.h | 12 2 files changed, 12 insertions(+), 12 deletions(-) diff --gi

[PATCH 12/14] hw/vfio/ap: Check CONFIG_IOMMUFD at runtime using iommufd_builtin()

2025-03-07 Thread Philippe Mathieu-Daudé
Convert the compile time check on the CONFIG_IOMMUFD definition by a runtime one by calling iommufd_builtin(). Since the file doesn't use any target-specific knowledge anymore, move it to system_ss[] to build it once. Signed-off-by: Philippe Mathieu-Daudé --- target/s390x/kvm/kvm_s390x.h | 2 +

Re: [PULL 00/10] QAPI patches patches for 2025-03-06

2025-03-07 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.0 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH v7 5/5] migration: add MULTIFD_RECV_SYNC migration command

2025-03-07 Thread Peter Xu
On Fri, Mar 07, 2025 at 05:15:03PM +0530, Prasad Pandit wrote: > diff --git a/migration/migration.c b/migration/migration.c > index 65fc4f5eed..da2c49c303 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -3401,9 +3401,10 @@ static MigIterateState > migration_iteration_run(Mig

Re: [PATCH 15/57] docs/qapi-domain: add "Errors:" field lists

2025-03-07 Thread John Snow
On Fri, Mar 7, 2025 at 2:48 AM Markus Armbruster wrote: > John Snow writes: > > > ``:error: descr`` can now be used to document error conditions. The > > format of the description is not defined here; so the ability to name > > specific types is left to the document writer. > > > > Signed-off-by

Re: [PATCH v7 5/5] migration: add MULTIFD_RECV_SYNC migration command

2025-03-07 Thread Peter Xu
On Fri, Mar 07, 2025 at 05:15:03PM +0530, Prasad Pandit wrote: > Hello Peter, > > On Wed, 5 Mar 2025 at 18:24, Peter Xu wrote: > > > On Tue, 4 Mar 2025 at 20:05, Peter Xu wrote: > > > > I think we need the header, the ram is a module. > > > > Do similarly like qemu_savevm_state_complete_precopy_

Re: [PATCH v2 05/10] target/i386/kvm: extract unrelated code out of kvm_x86_build_cpuid()

2025-03-07 Thread Dongli Zhang
Hi Zhao, On 3/7/25 1:15 AM, Zhao Liu wrote: >> +static void kvm_init_pmu_info(CPUX86State *env) >> +{ >> +uint32_t eax, edx; >> +uint32_t unused; >> +uint32_t limit; >> + >> +cpu_x86_cpuid(env, 0, 0, &limit, &unused, &unused, &unused); > > At this stage, CPUID has already been fil

Re: [PATCH 13/57] docs/qapi-domain: add "Arguments:" field lists

2025-03-07 Thread John Snow
On Fri, Mar 7, 2025 at 2:46 AM Markus Armbruster wrote: > John Snow writes: > > > This adds special rendering for Sphinx's typed field lists. > > > > This patch does not add any QAPI-aware markup, rendering, or > > cross-referencing for the type names, yet. That feature requires a > > subclass t

Re: [PULL 11/18] tests/functional: Convert the arm replay avocado tests

2025-03-07 Thread Peter Maydell
On Wed, 26 Feb 2025 at 10:00, Thomas Huth wrote: > > Put the tests into a separate file now (since in the functional > framework, each file is run with one specific qemu-system-* binary). > > Signed-off-by: Thomas Huth > Message-ID: <20250218152744.228335-10-th...@redhat.com> > --- > tests/avoca

[PATCH v2 7/7] hw/virtio: Compile virtio-mem.c once

2025-03-07 Thread Philippe Mathieu-Daudé
Remove unused "exec/ram_addr.h" header. This file doesn't use any target specific definitions anymore, compile it once by moving it to system_virtio_ss[]. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: David Hildenbrand --- hw/virtio/virtio-mem.c | 1 - hw/virtio/meson.build | 2 +- 2 file

Re: [PATCH 12/57] docs/qapi-domain: add :since: directive option

2025-03-07 Thread John Snow
On Fri, Mar 7, 2025 at 1:59 AM Markus Armbruster wrote: > John Snow writes: > > > Add a little special markup for registering "Since:" information. Adding > > it as an option instead of generic content lets us hoist the information > > into the Signature bar, optionally put it in the index, etc.

[PATCH v2 2/7] hw/acpi: Introduce acpi_builtin() helper

2025-03-07 Thread Philippe Mathieu-Daudé
acpi_builtin() can be used to check at runtime whether the ACPI subsystem is built in a qemu-system binary. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Ani Sinha --- include/hw/acpi/acpi.h | 3 +++ hw/acpi/acpi-stub.c| 5 + hw/acpi/core.c | 5 + 3 files changed, 13 in

[PATCH v2 5/7] hw/virtio/virtio-mem: Convert VIRTIO_MEM_USABLE_EXTENT to runtime

2025-03-07 Thread Philippe Mathieu-Daudé
Use qemu_arch_available() to check at runtime if a target architecture is built in. Consider the maximum extent size of any architecture built in. Signed-off-by: Philippe Mathieu-Daudé --- hw/virtio/virtio-mem.c | 28 1 file changed, 20 insertions(+), 8 deletions(-)

[PATCH v2 3/7] hw/i386/fw_cfg: Check ACPI availability with acpi_builtin()

2025-03-07 Thread Philippe Mathieu-Daudé
Replace the compile-time CONFIG_ACPI check by a runtime one. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Ani Sinha --- hw/i386/fw_cfg.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/i386/fw_cfg.c b/hw/i386/fw_cfg.c index d08aefa0291..a7f1b60b98c 100644 --

Re: [PATCH 11/57] docs/qapi-domain: add qapi:command directive

2025-03-07 Thread John Snow
On Fri, Mar 7, 2025 at 1:34 AM Markus Armbruster wrote: > John Snow writes: > > > This commit adds a stubbed version of QAPICommand that utilizes the > > QAPIObject class, the qapi:command directive, the :qapi:cmd: > > cross-reference role, and the "command" object type in the QAPI object > > re

[PATCH v2 6/7] hw/virtio/virtio-mem: Convert VIRTIO_MEM_HAS_LEGACY_GUESTS to runtime

2025-03-07 Thread Philippe Mathieu-Daudé
Use qemu_arch_available() to check at runtime if a target architecture is built in. Register virtio_mem_legacy_guests_properties[] at runtime. Code churn in virtio_mem_device_realize() is due to re-indentation. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: David Hildenbrand --- hw/virtio/v

[PATCH v2 1/7] system: Replace arch_type global by qemu_arch_available() helper

2025-03-07 Thread Philippe Mathieu-Daudé
qemu_arch_available() is a bit simpler to understand while reviewing than the undocumented arch_type variable. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- include/system/arch_init.h | 2 +- hw/scsi/scsi-disk.c| 2 +- system/arch_init.c | 5 - sys

Re: [PATCH v4 0/7] hw/hyperv: remove duplication compilation units

2025-03-07 Thread Pierrick Bouvier
On 3/7/25 14:06, Philippe Mathieu-Daudé wrote: On 7/3/25 22:56, Pierrick Bouvier wrote: Work towards having a single binary, by removing duplicated object files. hw/hyperv/hyperv.c was excluded at this time, because it depends on target dependent symbols: - from system/kvm.h - kvm_check_e

Re: [PATCH v4 0/7] hw/hyperv: remove duplication compilation units

2025-03-07 Thread Philippe Mathieu-Daudé
On 7/3/25 23:31, Maciej S. Szmigiero wrote: Hi Philippe, On 7.03.2025 23:25, Philippe Mathieu-Daudé wrote: Hi Maciej, On 7/3/25 22:56, Pierrick Bouvier wrote: Work towards having a single binary, by removing duplicated object files. Pierrick Bouvier (7):    hw/hyperv/hv-balloon-stub: commo

[PATCH 5/5] aio-posix: Separate AioPolledEvent per AioHandler

2025-03-07 Thread Kevin Wolf
Adaptive polling has a big problem: It doesn't consider that an event loop can wait for many different events that may have very different typical latencies. For example, think of a guest that tends to send a new I/O request soon after the previous I/O request completes, but the storage on the hos

[PATCH v4 7/7] hw/hyperv/hyperv_testdev: common compilation unit

2025-03-07 Thread Pierrick Bouvier
Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/hyperv/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/hyperv/meson.build b/hw/hyperv/meson.build index 5acd709bdd5..ef5a596c8ab 100644 --- a/hw/hyperv/meson.build +++ b/hw/hyperv/meson.build

Re: [PATCH v4 0/7] hw/hyperv: remove duplication compilation units

2025-03-07 Thread Maciej S. Szmigiero
Hi Philippe, On 7.03.2025 23:25, Philippe Mathieu-Daudé wrote: Hi Maciej, On 7/3/25 22:56, Pierrick Bouvier wrote: Work towards having a single binary, by removing duplicated object files. Pierrick Bouvier (7):    hw/hyperv/hv-balloon-stub: common compilation unit    hw/hyperv/hyperv.h: hea

Re: [PATCH 14/16] include/exec: Split out helper-getpc.h

2025-03-07 Thread Philippe Mathieu-Daudé
On 7/3/25 23:00, Philippe Mathieu-Daudé wrote: On 7/3/25 19:56, Richard Henderson wrote: Split out GETPC and GETPC_ADJ to a target-independent header. Signed-off-by: Richard Henderson ---   include/exec/exec-all.h | 19 +--   include/exec/helper-getpc.h | 31

[PATCH v2 03/14] target/i386/hvf: provide and use handle_io in emul_ops

2025-03-07 Thread Wei Liu
This drops the calls to hvf_handle_io from x86_emu.c. Signed-off-by: Wei Liu --- target/i386/hvf/hvf.c | 1 + target/i386/hvf/x86_emu.c | 29 +++-- target/i386/hvf/x86_emu.h | 2 ++ 3 files changed, 18 insertions(+), 14 deletions(-) diff --git a/target/i386/hvf/hvf

Re: [PATCH v4 0/7] hw/hyperv: remove duplication compilation units

2025-03-07 Thread Philippe Mathieu-Daudé
Hi Maciej, On 7/3/25 22:56, Pierrick Bouvier wrote: Work towards having a single binary, by removing duplicated object files. Pierrick Bouvier (7): hw/hyperv/hv-balloon-stub: common compilation unit hw/hyperv/hyperv.h: header cleanup hw/hyperv/vmbus: common compilation unit hw/hyp

Re: [PATCH v2 5/7] hw/hyperv/syndbg: common compilation unit

2025-03-07 Thread Richard Henderson
On 3/7/25 11:10, Pierrick Bouvier wrote: Replace TARGET_PAGE.* by runtime calls The description needs updating for MSG_BUFSZ. @@ -374,6 +376,8 @@ static const Property hv_syndbg_properties[] = { static void hv_syndbg_class_init(ObjectClass *klass, void *data) { +g_assert(MSG_BUFSZ

[PATCH 3/5] aio: Create AioPolledEvent

2025-03-07 Thread Kevin Wolf
As a preparation for having multiple adaptive polling states per AioContext, move the 'ns' field into a separate struct. Signed-off-by: Kevin Wolf --- include/block/aio.h | 6 +- util/aio-posix.c| 31 --- util/async.c| 3 ++- 3 files changed, 23 inse

[PATCH 2/5] block/io: Ignore FUA with cache.no-flush=on

2025-03-07 Thread Kevin Wolf
For block drivers that don't advertise FUA support, we already call bdrv_co_flush(), which considers BDRV_O_NO_FLUSH. However, drivers that do support FUA still see the FUA flag with BDRV_O_NO_FLUSH and get the associated performance penalty that cache.no-flush=on was supposed to avoid. Clear FUA

[PATCH 4/5] aio-posix: Factor out adjust_polling_time()

2025-03-07 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- util/aio-posix.c | 77 ++-- 1 file changed, 41 insertions(+), 36 deletions(-) diff --git a/util/aio-posix.c b/util/aio-posix.c index 95bddb9e4b..259827c7ad 100644 --- a/util/aio-posix.c +++ b/util/aio-posix.c @@ -600,6 +60

Re: [PATCH 1/2] migration: Add some documentation for multifd

2025-03-07 Thread Peter Xu
On Fri, Mar 07, 2025 at 04:06:17PM -0300, Fabiano Rosas wrote: > > I never tried vsock, would it be used in any use case? > > > > I don't know, I'm going by what's in the code. > > > It seems to be introduced by accident in 72a8192e225cea, but I'm not sure. > > Maybe there's something I missed. >

[PATCH 0/5] block: Improve writethrough performance

2025-03-07 Thread Kevin Wolf
Write requests in writethrough mode mean that QEMU sends a separate flush request (i.e. fdatasync) after each completed write request. This is unnecessary overhead when we can just pass a flag for the write request that gives us the desired FUA semantics. Unfortunately, this made a problem in the

Re: [PATCH v4 0/7] hw/hyperv: remove duplication compilation units

2025-03-07 Thread Philippe Mathieu-Daudé
On 7/3/25 22:56, Pierrick Bouvier wrote: Work towards having a single binary, by removing duplicated object files. hw/hyperv/hyperv.c was excluded at this time, because it depends on target dependent symbols: - from system/kvm.h - kvm_check_extension - kvm_vm_ioctl Bug, these should

Re: [PATCH 14/16] include/exec: Split out helper-getpc.h

2025-03-07 Thread Philippe Mathieu-Daudé
On 7/3/25 19:56, Richard Henderson wrote: Split out GETPC and GETPC_ADJ to a target-independent header. Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 19 +-- include/exec/helper-getpc.h | 31 +++ 2 files changed, 32 insertions

Re: [PATCH 01/16] include/exec: Split out exec/cpu-interrupt.h

2025-03-07 Thread Philippe Mathieu-Daudé
On 7/3/25 19:56, Richard Henderson wrote: Some of these bits are actually common to all cpus; while the reset have common reservations for target-specific usage. While generic code cannot know what the target-specific usage is, common code can know what to do with the bits, e.g. single-step. Sig

Re: [PATCH 02/16] accel/tcg: Compile watchpoint.c once

2025-03-07 Thread Philippe Mathieu-Daudé
On 7/3/25 19:56, Richard Henderson wrote: Move tb_check_watchpoint declaration from tb-internal.h, which is still target-specific, to internal-common.h, which isn't. Otherwise, all that is required to build watchpoint.c once is to include the new exec/cpu-interrupt.h instead of exec/exec-all.h.

Re: [PATCH 09/16] system: Build watchpoint.c once

2025-03-07 Thread Philippe Mathieu-Daudé
On 7/3/25 19:56, Richard Henderson wrote: Now that watchpoint.c uses cputlb.h instead of exec-all.h, it can be built once. Signed-off-by: Richard Henderson --- system/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe

[PATCH v4 2/7] hw/hyperv/hyperv.h: header cleanup

2025-03-07 Thread Pierrick Bouvier
Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- include/hw/hyperv/hyperv.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/hw/hyperv/hyperv.h b/include/hw/hyperv/hyperv.h index d717b4e13d4..63a8b65278f 100644 --- a/include/hw/hyperv/hyperv.h +++ b

[PATCH v4 1/7] hw/hyperv/hv-balloon-stub: common compilation unit

2025-03-07 Thread Pierrick Bouvier
Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/hyperv/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/hyperv/meson.build b/hw/hyperv/meson.build index d3d2668c71a..f4aa0a5ada9 100644 --- a/hw/hyperv/meson.build +++ b/hw/hyperv/meson.bui

[PATCH v4 6/7] hw/hyperv/balloon: common balloon compilation units

2025-03-07 Thread Pierrick Bouvier
Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/hyperv/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/hyperv/meson.build b/hw/hyperv/meson.build index a9f2045a9af..5acd709bdd5 100644 --- a/hw/hyperv/meson.build +++ b/hw/hyperv/meson.build

[PATCH v4 4/7] hw/hyperv/hyperv-proto: move SYNDBG definition from target/i386

2025-03-07 Thread Pierrick Bouvier
Allows them to be available for common compilation units. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Pierrick Bouvier --- include/hw/hyperv/hyperv-proto.h | 12 target/i386/kvm/hyperv-proto.h | 12 2 files changed, 12 insertions(+), 12 deletions(-) diff --gi

[PATCH v4 3/7] hw/hyperv/vmbus: common compilation unit

2025-03-07 Thread Pierrick Bouvier
Replace TARGET_PAGE.* by runtime calls. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/hyperv/vmbus.c | 50 +-- hw/hyperv/meson.build | 2 +- 2 files changed, 26 insertions(+), 26 deletions(-) diff --git a/hw/hyperv/vmbus.c b/

[PATCH v4 5/7] hw/hyperv/syndbg: common compilation unit

2025-03-07 Thread Pierrick Bouvier
Replace TARGET_PAGE.* by runtime calls We assume that page size is 4KB only, to dimension buffer size for receiving message. Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Pierrick Bouvier --- hw/hyperv/syndbg.c| 11 --- hw/hyperv/meson.build | 2

[PATCH v4 0/7] hw/hyperv: remove duplication compilation units

2025-03-07 Thread Pierrick Bouvier
Work towards having a single binary, by removing duplicated object files. hw/hyperv/hyperv.c was excluded at this time, because it depends on target dependent symbols: - from system/kvm.h - kvm_check_extension - kvm_vm_ioctl - from exec/cpu-all.h | memory_ldst_phys.h.inc - ldq_phys v2

Re: [PATCH v3 5/7] hw/hyperv/syndbg: common compilation unit

2025-03-07 Thread Pierrick Bouvier
On 3/7/25 12:56, Philippe Mathieu-Daudé wrote: On 7/3/25 20:37, Pierrick Bouvier wrote: Replace TARGET_PAGE.* by runtime calls We assume that page size is 4KB only, to dimension buffer size for receiving message. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/hyperv/

Re: [PATCH 5/7] hw/virtio/virtio-mem: Convert VIRTIO_MEM_USABLE_EXTENT to runtime

2025-03-07 Thread Philippe Mathieu-Daudé
On 7/3/25 20:28, Pierrick Bouvier wrote: On 3/7/25 08:49, Philippe Mathieu-Daudé wrote: On 7/3/25 17:38, Alex Bennée wrote: Philippe Mathieu-Daudé writes: Use qemu_arch_available() to check at runtime if a target architecture is built in. Signed-off-by: Philippe Mathieu-Daudé ---    hw/vir

[PATCH v8 05/20] acpi/ghes: Cleanup the code which gets ghes ged state

2025-03-07 Thread Mauro Carvalho Chehab
Move the check logic into a common function and simplify the code which checks if GHES is enabled and was properly setup. Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Jonathan Cameron Reviewed-by: Igor Mammedov --- hw/acpi/ghes-stub.c| 7 --- hw/acpi/ghes.c | 38 +

Re: [PATCH 16/16] accel/tcg: Build tcg-runtime-gvec.c once

2025-03-07 Thread Philippe Mathieu-Daudé
On 7/3/25 19:56, Richard Henderson wrote: Signed-off-by: Richard Henderson --- accel/tcg/tcg-runtime-gvec.c | 1 - accel/tcg/meson.build| 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) 💞 Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé

Re: make check-functional failures with --enable-rust: unsafe precondition(s) violated: NonNull::new_unchecked

2025-03-07 Thread Philippe Mathieu-Daudé
On 7/3/25 19:24, Peter Maydell wrote: I noticed that 'make check-functional' for arm targets doesn't all pass when QEMU is built with --enable-rust: 11/46 qemu:func-thorough+func-aarch64-thorough+thorough / func-aarch64-aarch64_virtTIMEOUT 720.03s killed by signal 15 SIGTER

[PULL 8/8] migration: Add qtest for migration over RDMA

2025-03-07 Thread Fabiano Rosas
From: Li Zhijian This qtest requires there is a RDMA(RoCE) link in the host. In order to make the test work smoothly, introduce a scripts/rdma-migration-helper.sh to - setup a new Soft-RoCE(aka RXE) if it's root - detect existing RoCE link Test will be skipped if there is no available RoCE link.

Re: [PATCH 00/16] accel/tcg: Compile more files once

2025-03-07 Thread Philippe Mathieu-Daudé
On 7/3/25 19:56, Richard Henderson wrote: Philippe Mathieu-Daudé (6): exec: Declare tlb_reset_dirty*() in 'exec/cputlb.h' exec: Declare tlb_set_page_full() in 'exec/cputlb.h' exec: Declare tlb_set_page_with_attrs() in 'exec/cputlb.h' exec: Declare tlb_set_page() in 'exec/cputlb.h'

Re: [PATCH] rust: pl011: Allow NULL chardev argument to pl011_create()

2025-03-07 Thread Philippe Mathieu-Daudé
On 7/3/25 20:00, Peter Maydell wrote: It's valid for the caller to pass a NULL chardev to pl011_create(); this means "don't set the chardev property on the device", which in turn means "act like there's no chardev". All the chardev frontend APIs (in C, at least) accept a NULL pointer to mean "do

[PATCH v8 18/20] tests/acpi: virt: update HEST and DSDT tables

2025-03-07 Thread Mauro Carvalho Chehab
@@ -1,39 +1,39 @@ /* * Intel ACPI Component Architecture * AML/ASL+ Disassembler version 20240322 (64-bit version) * Copyright (c) 2000 - 2023 Intel Corporation * - * Disassembly of tests/data/acpi/aarch64/virt/HEST + * Disassembly of /tmp/aml-DMPE22 * * ACPI Data Table [HEST] * *

Re: [PATCH rfcv2 06/20] host_iommu_device: Define two new capabilities HOST_IOMMU_DEVICE_CAP_[NESTING|FS1GP]

2025-03-07 Thread Eric Auger
On 2/28/25 9:29 AM, Duan, Zhenzhong wrote: > Hi Eric, > >> -Original Message- >> From: Eric Auger >> Subject: Re: [PATCH rfcv2 06/20] host_iommu_device: Define two new >> capabilities HOST_IOMMU_DEVICE_CAP_[NESTING|FS1GP] >> >> Hi Zhenzhong, >> >> >> On 2/19/25 9:22 AM, Zhenzhong Duan

[PATCH v8 13/20] acpi/generic_event_device: add an APEI error device

2025-03-07 Thread Mauro Carvalho Chehab
Adds a generic error device to handle generic hardware error events as specified at ACPI 6.5 specification at 18.3.2.7.2: https://uefi.org/specs/ACPI/6.5/18_Platform_Error_Interfaces.html#event-notification-for-generic-error-sources using HID PNP0C33. The PNP0C33 device is used to report hardware

[PATCH 09/14] hw/vfio/pci: Convert CONFIG_KVM check to runtime one

2025-03-07 Thread Philippe Mathieu-Daudé
Use the runtime kvm_enabled() helper to check whether KVM is available or not. Signed-off-by: Philippe Mathieu-Daudé --- hw/vfio/pci.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index fdbc15885d4..9872884ff8a 100644 ---

[PATCH 7/7] hw/hyperv/hyperv_testdev: common compilation unit

2025-03-07 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- hw/hyperv/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/hyperv/meson.build b/hw/hyperv/meson.build index 5acd709bdd5..ef5a596c8ab 100644 --- a/hw/hyperv/meson.build +++ b/hw/hyperv/meson.build @@ -1,5 +1,5 @@ specific_ss.ad

Re: [PATCH v8 18/20] tests/acpi: virt: update HEST and DSDT tables

2025-03-07 Thread Philippe Mathieu-Daudé
On 7/3/25 20:14, Mauro Carvalho Chehab wrote: @@ -1,39 +1,39 @@ /* * Intel ACPI Component Architecture * AML/ASL+ Disassembler version 20240322 (64-bit version) * Copyright (c) 2000 - 2023 Intel Corporation * - * Disassembly of tests/data/acpi/aarch64/virt/HEST + * Disassembly of /t

[PATCH 12/16] accel/tcg: Build tcg-accel-ops-rr.c once

2025-03-07 Thread Richard Henderson
All that is required is to use cpu-common.h instead of exec-all.h. Signed-off-by: Richard Henderson --- accel/tcg/tcg-accel-ops-rr.c | 2 +- accel/tcg/meson.build| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/accel/tcg/tcg-accel-ops-rr.c b/accel/tcg/tcg-accel-ops-

RE: [PATCH 20/38] target/hexagon: Implement do_raise_exception()

2025-03-07 Thread ltaylorsimpson
> -Original Message- > From: Brian Cain > Sent: Friday, February 28, 2025 11:26 PM > To: qemu-devel@nongnu.org > Cc: brian.c...@oss.qualcomm.com; richard.hender...@linaro.org; > phi...@linaro.org; quic_mathb...@quicinc.com; a...@rev.ng; a...@rev.ng; > quic_mlie...@quicinc.com; ltaylorsi

RE: [PATCH 19/38] target/hexagon: Define register fields for system regs

2025-03-07 Thread ltaylorsimpson
> -Original Message- > From: Brian Cain > Sent: Friday, February 28, 2025 11:26 PM > To: qemu-devel@nongnu.org > Cc: brian.c...@oss.qualcomm.com; richard.hender...@linaro.org; > phi...@linaro.org; quic_mathb...@quicinc.com; a...@rev.ng; a...@rev.ng; > quic_mlie...@quicinc.com; ltaylorsi

  1   2   3   4   5   >