[PATCH] hw/misc/macio/gpio.c: Add defines for register bits

2025-02-22 Thread BALATON Zoltan
Add named constants for register bit values that should make it easier to understand what these mean. Signed-off-by: BALATON Zoltan --- hw/misc/macio/gpio.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/hw/misc/macio/gpio.c b/hw/misc/macio/gpio.c index 43

Re: [PATCH v2 11/12] hw/arm/raspi: Deprecate old raspiX machine names

2025-02-22 Thread Jared Mauch
On Tue, Feb 04, 2025 at 10:58:39AM +0100, BALATON Zoltan wrote: > On Tue, 4 Feb 2025, Philippe Mathieu-Daudé wrote: > > On 4/2/25 10:22, Peter Maydell wrote: > > > On Tue, 4 Feb 2025 at 00:23, Philippe Mathieu-Daudé > > > wrote: > > > > > > > > All previous raspi machines can be created using the

Re: [PULL 33/42] tcg/riscv: Require TCG_TARGET_REG_BITS == 64

2025-02-22 Thread Richard Henderson
On 2/20/25 15:27, Philippe Mathieu-Daudé wrote: On 5/5/23 23:24, Richard Henderson wrote: The port currently does not support "oversize" guests, which means riscv32 can only target 32-bit guests.  We will soon be building TCG once for all guests.  This implies that we can only support riscv64.

Re: [PATCH v3 122/162] tcg: Add tcg_gen_addcio_{i32,i64,tl}

2025-02-22 Thread Richard Henderson
On 2/21/25 07:41, Paolo Bonzini wrote: Ok, this one definitely caught my eye. :) On 2/17/25 00:09, Richard Henderson wrote: +    tcg_gen_add_i32(t0, a, b); +    tcg_gen_setcond_i32(TCG_COND_LTU, t1, t0, a); Compare against b instead?  If there's an immediate (which could even be zero)

[PATCH 1/4] ppc/amigaone: Simplify replacement dummy_fw

2025-02-22 Thread BALATON Zoltan
There's no need to do shift in a loop, doing it in one instruction works just as well, only the result is used. Signed-off-by: BALATON Zoltan --- hw/ppc/amigaone.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/hw/ppc/amigaone.c b/hw/ppc/amigaone.c index b02792221c..4290

[PATCH 2/4] ppc/amigaone: Implement NVRAM emulation

2025-02-22 Thread BALATON Zoltan
The board has a battery backed NVRAM where U-Boot environment is stored which is also accessed by AmigaOS and e.g. C:NVGetVar command crashes without it having at least a valid checksum. Signed-off-by: BALATON Zoltan --- hw/ppc/amigaone.c | 116 -- 1 f

[PATCH 3/4] ppc/amigaone: Add default environment

2025-02-22 Thread BALATON Zoltan
Initialise empty NVRAM with default values. This also enables IDE UDMA mode in AmigaOS that is faster but has to be enabled in environment due to problems with real hardware but that does not affect emulation so we can use faster defaults here. Signed-off-by: BALATON Zoltan --- hw/ppc/amigaone.c

[PATCH 4/4] ppc/amigaone: Add kernel and initrd support

2025-02-22 Thread BALATON Zoltan
Add support for -kernel, -initrd and -append command line options. Signed-off-by: BALATON Zoltan --- hw/ppc/amigaone.c | 113 +- 1 file changed, 112 insertions(+), 1 deletion(-) diff --git a/hw/ppc/amigaone.c b/hw/ppc/amigaone.c index 35e4075cc3..9468

[PATCH 0/4] ppc/amigaone patches

2025-02-22 Thread BALATON Zoltan
Hello, This series adds NVRAM and support for -kernel, -initrd and -append options to the amigaone machine. This makes it easier to boot AmigaOS and avoids a crash in the guest when it tries to access NVRAM. While the -kernel option emulates what U-Boot passes to the kernel, old Linux kernels for

Re: [PATCH v3 028/162] tcg: Convert sub to TCGOutOpSubtract

2025-02-22 Thread Richard Henderson
On 2/20/25 15:07, Philippe Mathieu-Daudé wrote: Hi Richard, On 17/2/25 00:07, Richard Henderson wrote: Create a special subclass for sub, because two backends can support "subtract from immediate".  Drop all backend support for an immediate as the second operand, as we transform sub to add duri

Re: [PATCH v3 002/162] tcg: Remove INDEX_op_ext{8,16,32}*

2025-02-22 Thread Richard Henderson
On 2/20/25 14:17, Philippe Mathieu-Daudé wrote: @@ -1794,23 +1715,19 @@ void tcg_gen_andi_i64(TCGv_i64 ret, TCGv_i64 arg1, int64_t arg2)   case -1:   tcg_gen_mov_i64(ret, arg1);   return; -    case 0xff: -    /* Don't recurse with tcg_gen_ext8u_i64.  */ -    if (TCG_T

Re: [PATCH 0/4] target/arm: Move vfp_helper.c TCG code into tcg/ subdir

2025-02-22 Thread Richard Henderson
On 2/21/25 11:09, Peter Maydell wrote: Peter Maydell (4): target/arm: Move TCG-only VFP code into tcg/ subdir target/arm: Move FPSCR get/set helpers to tcg/vfp_helper.c target/arm: Move softfloat specific FPCR/FPSR handling to tcg/ target/arm: Rename vfp_helper.c to vfp_fpscr.c Revi

Building QEMU as a Shared Library

2025-02-22 Thread Saanjh Sengupta
Hi, I referred to your mailing chains on suggesting QEMU to be built as a shared library. Change meson.build to build QEMU as a shared library (with PIC enabled for static libraries) Could you please suggest what exactly has to be enabled in the meson.build? I am confused on that front. Rega

[PATCH] hw/misc/macio: Improve trace logs

2025-02-22 Thread BALATON Zoltan
Add macio_gpio_read trace event and use that in macio_gpio_read() instead of macio_gpio_write. Also change log message to match macio_timer_{read,write}. Signed-off-by: BALATON Zoltan --- hw/misc/macio/gpio.c | 2 +- hw/misc/macio/trace-events | 3 ++- 2 files changed, 3 insertions(+), 2 d

Re: [PATCH v4 00/33] Multifd 🔀 device state transfer support with VFIO consumer

2025-02-22 Thread Maciej S. Szmigiero
Thanks Yanghang for your measurements. Maciej On 21.02.2025 07:57, Yanghang Liu wrote: Let me share my performance report after applying the patches for the information: 1. live mlx VF migration outgoing migration: +--+---+---++ | VF(s)

Re: [PATCH v2 8/9] hw/char/mcf_uart: Really use RX FIFO depth

2025-02-22 Thread Thomas Huth
Am Thu, 20 Feb 2025 10:29:01 +0100 schrieb Philippe Mathieu-Daudé : > While we model a 4-elements RX FIFO since the MCF UART model > was introduced in commit 20dcee94833 ("MCF5208 emulation"), > we only read 1 char at a time! > > Have the IOCanReadHandler handler return how many elements are > av