Re: [PATCH v1 01/18] hw/intc/aspeed: Rename INTC to INTC0

2025-02-03 Thread Cédric Le Goater
On 2/4/25 07:50, Jamin Lin wrote: Hi Cedric, Andrew From: Andrew Jeffery Sent: Thursday, January 30, 2025 11:22 AM To: Cédric Le Goater ; Jamin Lin ; Peter Maydell ; Steven Lee ; Troy Lee ; Joel Stanley ; open list:ASPEED BMCs ; open list:All patches CC here Cc: Troy Lee ; Yunlin Tang Subjec

Re: [PATCH v3 18/26] hw/arm/boot: Mark all guest memory as RIPAS_RAM.

2025-02-03 Thread Gavin Shan
On 11/26/24 5:56 AM, Jean-Philippe Brucker wrote: All Realm IPA states are by default RIPAS_EMPTY, and accessing them in that state causes injection of synchronous exception. Either the loader or the guest needs to set IPA state to RIPAS_RAM before accessing it. Since a Linux guest needs all memo

Re: [PATCH v1 11/18] hw/misc/aspeed_scu: Add Support for AST2700/AST2750 A1 Silicon Revisions

2025-02-03 Thread Cédric Le Goater
Hello Jamin, --- a/hw/misc/aspeed_scu.c +++ b/hw/misc/aspeed_scu.c @@ -559,6 +559,8 @@ static uint32_t aspeed_silicon_revs[] = { AST2700_A0_SILICON_REV, AST2720_A0_SILICON_REV, AST2750_A0_SILICON_REV, +    AST2700_A1_SILICON_REV, +    AST2750_A1_SILICON_REV,  };  bool is_sup

RE: [PATCH v1 11/18] hw/misc/aspeed_scu: Add Support for AST2700/AST2750 A1 Silicon Revisions

2025-02-03 Thread Jamin Lin
Hi Andrew, > From: Andrew Jeffery > Sent: Thursday, January 30, 2025 12:05 PM > To: Jamin Lin ; Cédric Le Goater ; > Peter Maydell ; Steven Lee > ; Troy Lee ; Joel Stanley > ; open list:ASPEED BMCs ; open > list:All patches CC here > Cc: Troy Lee ; Yunlin Tang > > Subject: Re: [PATCH v1 11/18]

Re: [PATCH-for-10.0 0/3] hw/boards: Try to make sense of MachineClass::no_sdcard flag

2025-02-03 Thread Thomas Huth
On 26/11/2024 06.24, Philippe Mathieu-Daudé wrote: On 25/11/24 19:14, Philippe Mathieu-Daudé wrote: Invert MachineClass 'no_sdcard' flag logic and rename it to 'create_default_sdcard_drive' to make sense of this default value applied to all machines. No logical change intended. Philippe Mathieu

[PATCH 2/3] hw/cxl/cxl-mailbox-utils.c: Added support for Clear Log (Opcode 0403h)

2025-02-03 Thread Arpit Kumar
Signed-off-by: Arpit Kumar Reviewed-by: Alok Rathore Reviewed-by: Krishna Kanth Reddy --- hw/cxl/cxl-mailbox-utils.c | 36 1 file changed, 36 insertions(+) diff --git a/hw/cxl/cxl-mailbox-utils.c b/hw/cxl/cxl-mailbox-utils.c index 3d66a425a9..5fd7f850c4 100

[PATCH 0/1] CXL CCI Health Information & Alerts Commands implementation

2025-02-03 Thread Sweta Kumari
CXL CCI get/set alert config commands implmented as per CXL Specification 3.1 8.2.9.9.3 1)get alert configuration(Opcode 4201h) 2)set alert configuration(Opcode 4202h) The patches are generated against the Johnathan's tree https://gitlab.com/jic23/qemu.git and branch cxl-2024-11-27. Signed-off

Re: [PATCH-for-10.0 3/3] hw/boards: Rename no_sdcard -> create_default_sdcard_drive

2025-02-03 Thread Thomas Huth
On 25/11/2024 19.14, Philippe Mathieu-Daudé wrote: Invert the 'no_sdcard' logic, renaming it as the more explicit "create_default_sdcard_drive". Machines are supposed to create a SD Card drive when this flag is set. In many cases it doesn't make much sense (as boards don't expose SD Card host con

RE: [PATCH v1 02/18] hw/intc/aspeed: Support different memory region ops

2025-02-03 Thread Jamin Lin
Hi Andrew, > From: Andrew Jeffery > Sent: Thursday, January 30, 2025 11:32 AM > To: Jamin Lin ; Cédric Le Goater ; > Peter Maydell ; Steven Lee > ; Troy Lee ; Joel Stanley > ; open list:ASPEED BMCs ; open > list:All patches CC here > Cc: Troy Lee ; Yunlin Tang > > Subject: Re: [PATCH v1 02/18]

Re: [PATCH-for-10.0 1/3] hw/boards: Convert no_sdcard flag to OnOffAuto tri-state

2025-02-03 Thread Thomas Huth
On 25/11/2024 19.14, Philippe Mathieu-Daudé wrote: MachineClass::no_sdcard is initialized as false by default. To catch all uses, convert it to a tri-state, having the current default (false) becoming AUTO. No logical change intended. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/boar

[PATCH 3/3] hw/cxl/cxl-mailbox-utils.c: Added support for Populate Log (Opcode 0404h) as background operation

2025-02-03 Thread Arpit Kumar
Signed-off-by: Arpit Kumar Reviewed-by: Alok Rathore Reviewed-by: Krishna Kanth Reddy --- hw/cxl/cxl-mailbox-utils.c | 95 + include/hw/cxl/cxl_device.h | 2 + 2 files changed, 97 insertions(+) diff --git a/hw/cxl/cxl-mailbox-utils.c b/hw/cxl/cxl-mailbox-u

[PATCH 0/3] CXL CCI Log Commands implementation

2025-02-03 Thread Arpit Kumar
CXL CCI log commands implmented as per CXL Specification 3.1 8.2.9.5 1) get_log_capabilities (Opcode 0402h) 2) clear_log (Opcode 0403h) 3) populate_log (Opcode 0404h) The patches are generated against the Johnathan's tree https://gitlab.com/jic23/qemu.git and branch cxl-2024-11-27. Signed-off-by

[PATCH 1/1] Added support for get/set alert configuration commands

2025-02-03 Thread Sweta Kumari
Signed-off-by: Sweta Kumari Reviewed-by: Alok Rathore Reviewed-by: Krishna Kanth Reddy --- hw/cxl/cxl-mailbox-utils.c | 91 + hw/mem/cxl_type3.c | 20 include/hw/cxl/cxl_device.h | 24 ++ 3 files changed, 135 insertions(+) diff --g

Re: [PATCH-for-10.0 2/3] hw/boards: Explicit no_sdcard=false as ON_OFF_AUTO_OFF

2025-02-03 Thread Thomas Huth
On 25/11/2024 19.14, Philippe Mathieu-Daudé wrote: Update MachineClass::no_sdcard default implicit AUTO initialization to explicit OFF. This flag is consumed in system/vl.c::qemu_disable_default_devices(). Use this place to assert we don't have anymore AUTO state. In hw/ppc/e500.c we add the ppc

[PATCH 1/3] hw/cxl/cxl-mailbox-utils.c: Added support for Get Log Capabilities (Opcode 0402h)

2025-02-03 Thread Arpit Kumar
Signed-off-by: Arpit Kumar Reviewed-by: Alok Rathore Reviewed-by: Krishna Kanth Reddy --- hw/cxl/cxl-mailbox-utils.c | 55 include/hw/cxl/cxl_device.h | 31 include/hw/cxl/cxl_mailbox.h | 5 3 files changed, 91 insertions(+) di

RE: [PATCH v1 01/18] hw/intc/aspeed: Rename INTC to INTC0

2025-02-03 Thread Jamin Lin
Hi Cedric, Andrew > From: Andrew Jeffery > Sent: Thursday, January 30, 2025 11:22 AM > To: Cédric Le Goater ; Jamin Lin ; > Peter Maydell ; Steven Lee > ; Troy Lee ; Joel Stanley > ; open list:ASPEED BMCs ; open > list:All patches CC here > Cc: Troy Lee ; Yunlin Tang > > Subject: Re: [PATCH v1

Re: [PATCH v2 04/14] meson: Introduce CONFIG_TCG_TARGET

2025-02-03 Thread Thomas Huth
On 03/02/2025 17.38, Richard Henderson wrote: On 2/3/25 02:08, Thomas Huth wrote: On 03/02/2025 04.18, Richard Henderson wrote: Use CONFIG_TCG as a project-wide flag to indicate that TCG is enabled for *some* target.  Use CONFIG_TCG_TARGET to indicate that TCG is enabled for a specific target.

Re: [PATCH v1 1/1] aspeed/soc: Support Non-maskable Interrupt for AST2700

2025-02-03 Thread Cédric Le Goater
+ Philippe On 2/4/25 07:09, Jamin Lin wrote: QEMU supports GICv3 Non-maskable Interrupt, adds to support Non-maskable Interrupt for AST2700. Reference: https://github.com/qemu/qemu/commit/b36a32ead Signed-off-by: Jamin Lin --- hw/arm/aspeed_ast27x0.c | 4 1 file changed, 4 insertions(

[PATCH v1 1/1] aspeed/soc: Support Non-maskable Interrupt for AST2700

2025-02-03 Thread Jamin Lin via
QEMU supports GICv3 Non-maskable Interrupt, adds to support Non-maskable Interrupt for AST2700. Reference: https://github.com/qemu/qemu/commit/b36a32ead Signed-off-by: Jamin Lin --- hw/arm/aspeed_ast27x0.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/

Re: [PATCH v3 08/26] hw/core/loader: Add ROM loader notifier

2025-02-03 Thread Gavin Shan
On 11/26/24 5:56 AM, Jean-Philippe Brucker wrote: Add a function to register a notifier, that is invoked after a ROM gets loaded into guest memory. It will be used by Arm confidential guest support, in order to register all blobs loaded into memory with KVM, so that their content is moved into R

Re: [PATCH v3 09/26] target/arm/kvm-rme: Initialize Realm memory

2025-02-03 Thread Gavin Shan
On 11/26/24 5:56 AM, Jean-Philippe Brucker wrote: Initialize the IPA state of RAM. Collect the images copied into guest RAM into a sorted list, and issue POPULATE_REALM KVM ioctls once we've created the Realm Descriptor. The images are part of the Realm Initial Measurement. Signed-off-by: Jean-P

Re: [RFC PATCH v12 qemu 2/2] qtest/cxl: Add aarch64 virt test for CXL

2025-02-03 Thread Itaru Kitayama
Jonathan, > On Feb 4, 2025, at 2:30, Jonathan Cameron wrote: > > Add a single complex case for aarch64 virt machine. > Given existing much more comprehensive tests for x86 cover the > common functionality, a single test should be enough to verify > that the aarch64 part continue to work. > > Si

Re: [PATCH v3 06/26] target/arm/kvm-rme: Initialize vCPU

2025-02-03 Thread Gavin Shan
On 11/26/24 5:56 AM, Jean-Philippe Brucker wrote: The target code calls kvm_arm_vcpu_init() to mark the vCPU as part of a Realm. For a Realm vCPU, only x0-x7 can be set at runtime. Before boot, the PC can also be set, and is ignored at runtime. KVM also accepts a few system register changes durin

RE: [PATCH v5 13/17] aspeed/soc: Add AST2700 support

2025-02-03 Thread Jamin Lin
Hi Philippe, > From: Philippe Mathieu-Daudé > Sent: Tuesday, February 4, 2025 12:41 AM > To: Jamin Lin ; Cédric Le Goater ; > Peter Maydell ; Andrew Jeffery > ; Joel Stanley ; Alistair > Francis ; Cleber Rosa ; Wainer > dos Santos Moschetta ; Beraldo Leal > ; open list:ASPEED BMCs ; open > list:A

RE: [PATCH v6 00/10] Support virtio-gpu DRM native context

2025-02-03 Thread Kim, Dongwon
> Subject: Re: [PATCH v6 00/10] Support virtio-gpu DRM native context > > "Kim, Dongwon" writes: > > > Hi, > > > > The commit below could change the timing of drawing by making the > > drawing done at refresh cycle instead of via drawing event. So it > > looks like either dmabuf or client's fram

[PATCH v2 11/12] hw/arm/raspi: Deprecate old raspiX machine names

2025-02-03 Thread Philippe Mathieu-Daudé
All previous raspi machines can be created using the generic machine. Deprecate the old names to maintain a single one. Update the tests. Signed-off-by: Philippe Mathieu-Daudé --- QOM HMP introspection test fails because without the 'model' argument set, no machine is created... $ qemu-system-

[PATCH v2 09/12] hw/arm/raspi: Have the generic machine take a 'revision' property

2025-02-03 Thread Philippe Mathieu-Daudé
Add a property to specify the board revision. This allows to create a Raspberry Pi 2B with BCM2836 SoC (rev 1.0 and 1.1) or BCM2837 (rev 1.2 up to 1.5). Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 39 +++ 1 file changed, 39 insertions(+) diff -

[PATCH v2 10/12] hw/arm/raspi: List models creatable by the generic 'raspi' machine

2025-02-03 Thread Philippe Mathieu-Daudé
All the following models can be created (with different RAM size): $ qemu-system-aarch64 -M raspi qemu-system-aarch64: Missing model, try -M raspi,model=help $ qemu-system-aarch64 -M raspi,model=help Available models (processor): - A (BCM2835) - B (BCM2835) - A+

[PATCH v2 01/12] hw/arm/raspi: Access SoC parent object using BCM283X_BASE() macro

2025-02-03 Thread Philippe Mathieu-Daudé
We shouldn't access a QOM parent object directly. Use the appropriate type-cast macro. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 2 +- hw/arm/raspi4b.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c index a7a662f40db..508

[PATCH v2 05/12] hw/arm/raspi: Consider processor id in types[] array

2025-02-03 Thread Philippe Mathieu-Daudé
Expand the current type2model array to include the processor id. Since the BCM2838 is indistinctly used as BCM2711 (within the Linux community), add it as alias in RaspiProcessorId. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 33 +++-- 1 file changed,

[PATCH v2 03/12] hw/arm/raspi: Unify RASPI_MACHINE types

2025-02-03 Thread Philippe Mathieu-Daudé
Merge Raspi4bMachineState within RaspiMachineState by using an unnamed union. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c index 3fa382d62ce..ef94d57dab5 100644

[PATCH v2 12/12] hw/arm/raspi: Support more models

2025-02-03 Thread Philippe Mathieu-Daudé
Allow to create the following machines: - Zero2W - 400 - CM4 and CM4S Fill the arrays with the BCM2712-based machines (raspi5), but since we don't model the SoC, these machines can't be created (and aren't listed in the 'help' output). List taken from: https://github.com/raspberrypi/docume

[PATCH v2 04/12] hw/arm/raspi: Pass board_rev as argument to raspi_base_machine_init()

2025-02-03 Thread Philippe Mathieu-Daudé
Since callers already have reference to the RaspiBaseMachineClass, directly pass 'board_rev' as argument to raspi_base_machine_init(). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/arm/raspi_platform.h | 2 +- hw/arm/raspi.c | 8 +++- 2 files changed, 4 insertions(+),

[PATCH v2 07/12] hw/arm/raspi: Check ramsize is within chipset aperture

2025-02-03 Thread Philippe Mathieu-Daudé
Add the 'max_ramsize' field to the soc_property[] array, corresponding to the maximum DRAM size a SoC can map. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c index

[PATCH v2 06/12] hw/arm/raspi: Consider network interface for B models

2025-02-03 Thread Philippe Mathieu-Daudé
Raspberry Pi 'B' models have an ethernet chipset (the LAN9512). Since we don't yet model it, add a /* TODO */ comment. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c index 1a6a1f8ff22..6

[PATCH v2 08/12] hw/arm/raspi: Introduce generic Raspberry Pi machine

2025-02-03 Thread Philippe Mathieu-Daudé
The generic 'raspi' machine takes a 'model' argument and create the machine associated with the model, with the RAM size requested (or default to the minimum of 256MB if not precised). Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2797 Signed-off-by: Philippe Mathieu-Daudé --- include/

[PATCH v2 00/12] hw/arm/raspi: Allow creating any Raspberry Pi machine

2025-02-03 Thread Philippe Mathieu-Daudé
Full rewrite of v1 [1], addressing Zoltan & Peter suggestion. Introduce a generic 'raspi' machine, which takes a 'model' and 'revision' properties, and any memory size. The 'board_rev' register is filled appropriately. Before, merge raspi4b.c within raspi.c (more is planned here with the MPCore r

[PATCH v2 02/12] hw/arm/raspi: Merge model 4B with other models

2025-02-03 Thread Philippe Mathieu-Daudé
Except we alter the device tree blob, the 4B is just another raspi model. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 114 - hw/arm/raspi4b.c | 136 - hw/arm/meson.build | 2 +- 3 files changed

Re: [PATCH 0/7] hw/arm/raspi4b: Add models with 4GB and 8GB of DRAM

2025-02-03 Thread BALATON Zoltan
On Mon, 3 Feb 2025, Philippe Mathieu-Daudé wrote: On 3/2/25 15:50, Daniel P. Berrangé wrote: On Mon, Feb 03, 2025 at 02:45:06PM +, Peter Maydell wrote: On Mon, 3 Feb 2025 at 14:33, Daniel P. Berrangé wrote: On Mon, Feb 03, 2025 at 02:29:49PM +, Alex Bennée wrote: Peter Maydell writ

Re: [PATCH 21/21] hw/gpio/imx_gpio: Don't clear input GPIO values upon reset

2025-02-03 Thread Bernhard Beschow
Am 28. Januar 2025 14:33:27 UTC schrieb Gustavo Romero : >Hi, > >On 1/20/25 17:37, Bernhard Beschow wrote: >> Input GPIO values such as a present SD card may get notified before the GPIO >> controller itself gets reset. Claring the input values thus loses data. >> Assuming > >

Re: [PATCH v4 13/33] migration/multifd: Device state transfer support - receive side

2025-02-03 Thread Maciej S. Szmigiero
On 3.02.2025 22:27, Peter Xu wrote: On Thu, Jan 30, 2025 at 11:08:34AM +0100, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" Add a basic support for receiving device state via multifd channels - channels that are shared with RAM transfers. Depending whether MULTIFD_FLAG_DEVICE_STATE f

Re: [PATCH v4 09/33] migration: postcopy_ram_listen_thread() needs to take BQL for some calls

2025-02-03 Thread Peter Xu
On Mon, Feb 03, 2025 at 10:41:43PM +0100, Maciej S. Szmigiero wrote: > On 3.02.2025 21:36, Peter Xu wrote: > > On Mon, Feb 03, 2025 at 09:15:52PM +0100, Maciej S. Szmigiero wrote: > > > On 3.02.2025 20:58, Peter Xu wrote: > > > > On Mon, Feb 03, 2025 at 02:57:36PM +0100, Maciej S. Szmigiero wrote:

Re: [PATCH 08/21] hw/arm/fsl-imx8mp: Add USDHC storage controllers

2025-02-03 Thread Bernhard Beschow
Am 21. Januar 2025 02:52:58 UTC schrieb BALATON Zoltan : >On Mon, 20 Jan 2025, Bernhard Beschow wrote: >> The USDHC emulation allows for running real-world images such as those >> generated >> by Buildroot. Convert the board documentation accordingly instead of running >> a >> Linux kernel wit

Re: [PATCH v4 13/33] migration/multifd: Device state transfer support - receive side

2025-02-03 Thread Peter Xu
On Mon, Feb 03, 2025 at 11:18:11PM +0100, Maciej S. Szmigiero wrote: > On 3.02.2025 22:27, Peter Xu wrote: > > On Thu, Jan 30, 2025 at 11:08:34AM +0100, Maciej S. Szmigiero wrote: > > > From: "Maciej S. Szmigiero" > > > > > > Add a basic support for receiving device state via multifd channels - >

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-03 Thread Peter Xu
On Mon, Feb 03, 2025 at 10:41:32PM +0100, Maciej S. Szmigiero wrote: > On 3.02.2025 21:20, Peter Xu wrote: > > On Mon, Feb 03, 2025 at 07:53:00PM +0100, Maciej S. Szmigiero wrote: > > > On 3.02.2025 19:20, Peter Xu wrote: > > > > On Thu, Jan 30, 2025 at 11:08:29AM +0100, Maciej S. Szmigiero wrote:

Re: [PATCH 20/21] hw/i2c: Import TCA6416 emulation from Xilinx

2025-02-03 Thread Bernhard Beschow
Am 2. Februar 2025 17:09:06 UTC schrieb "Philippe Mathieu-Daudé" : >On 1/2/25 16:28, Bernhard Beschow wrote: >> >> >> Am 30. Januar 2025 23:05:53 UTC schrieb "Philippe Mathieu-Daudé" >> : >>> Cc'ing AMD folks >>> >>> Hi Bernhard, >>> >>> TL;DR; can't you use the PCF8574 which is a more com

Re: [PATCH v2 00/14] meson: Deprecate 32-bit host support

2025-02-03 Thread Stefano Stabellini
+Xen maintainers On Mon, 3 Feb 2025, Richard Henderson wrote: > On 2/3/25 04:54, Paolo Bonzini wrote: > > On 2/3/25 04:18, Richard Henderson wrote: > > > v1: 20250128004254.33442-1-richard.hender...@linaro.org > > > > > > For v2, immediately disable 64-on-32 TCG. > > > > > > I *suspect* that we

[PATCH 2/2] nbd/server: Allow users to adjust handshake limit in QMP

2025-02-03 Thread Eric Blake
Although defaulting the handshake limit to 10 seconds was a nice QoI change to weed out intentionally slow clients, it can interfere with integration testing done with manual NBD_OPT commands over 'nbdsh --opt-mode'. Expose a QMP knob 'handshake-max-secs' to allow the user to alter the timeout awa

[PATCH 1/2] qemu-nbd: Allow users to adjust handshake limit

2025-02-03 Thread Eric Blake
Although defaulting the handshake limit to 10 seconds was a nice QoI change to weed out intentionally slow clients, it can interfere with integration testing done with manual NBD_OPT commands over 'nbdsh --opt-mode'. Expose a command line option to allow the user to alter the timeout away from the

Re: [PATCH V1 06/26] vfio/container: preserve DMA mappings

2025-02-03 Thread Steven Sistare
On 2/3/2025 1:25 PM, Cédric Le Goater wrote: On 1/29/25 15:43, Steve Sistare wrote: Preserve DMA mappings during cpr-transfer. In the container pre_save handler, suspend the use of virtual addresses in DMA mappings with VFIO_DMA_UNMAP_FLAG_VADDR, because guest RAM will be remapped at a differen

[PATCH 0/2] nbd: Allow debugging tuning of handshake limit

2025-02-03 Thread Eric Blake
Reviving a patch that has been sitting in my tree for a while. It's mostly useful for low-level integration testing (such as debugging libnbd as an NBD client). Eric Blake (2): qemu-nbd: Allow users to adjust handshake limit nbd/server: Allow users to adjust handshake limit in QMP docs/tool

Re: [PATCH V1 05/26] vfio/container: preserve descriptors

2025-02-03 Thread Steven Sistare
On 2/3/2025 12:48 PM, Cédric Le Goater wrote: On 1/29/25 15:43, Steve Sistare wrote: At vfio creation time, save the value of vfio container, group, and device descriptors in CPR state.  On qemu restart, vfio_realize() finds and uses the saved descriptors, and remembers the reused status for sub

Re: [PATCH V1 04/26] vfio/container: register container for cpr

2025-02-03 Thread Steven Sistare
On 2/3/2025 12:01 PM, Cédric Le Goater wrote: On 1/29/25 15:43, Steve Sistare wrote: Register a legacy container for cpr-transfer.  Add a blocker if the kernel does not support VFIO_UPDATE_VADDR or VFIO_UNMAP_ALL. This is mostly boiler plate.  The fields to to saved and restored are added in su

Re: [PATCH v2 00/14] meson: Deprecate 32-bit host support

2025-02-03 Thread Richard Henderson
On 2/3/25 04:54, Paolo Bonzini wrote: On 2/3/25 04:18, Richard Henderson wrote: v1: 20250128004254.33442-1-richard.hender...@linaro.org For v2, immediately disable 64-on-32 TCG. I *suspect* that we should disable 64-on-32 for *all* accelerators. The idea that an i686 binary on an x86_64 host m

Re: [PATCH v4 10/33] error: define g_autoptr() cleanup function for the Error type

2025-02-03 Thread Maciej S. Szmigiero
On 3.02.2025 22:13, Daniel P. Berrangé wrote: On Thu, Jan 30, 2025 at 11:08:31AM +0100, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" Automatic memory management helps avoid memory safety issues. Signed-off-by: Maciej S. Szmigiero --- include/qapi/error.h | 2 ++ 1 file changed,

Re: [PATCH v4 16/33] migration/multifd: Device state transfer support - send side

2025-02-03 Thread Peter Xu
On Thu, Jan 30, 2025 at 11:08:37AM +0100, Maciej S. Szmigiero wrote: > From: "Maciej S. Szmigiero" > > A new function multifd_queue_device_state() is provided for device to queue > its state for transmission via a multifd channel. > > Signed-off-by: Maciej S. Szmigiero Reviewed-by: Peter Xu

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-03 Thread Maciej S. Szmigiero
On 3.02.2025 21:20, Peter Xu wrote: On Mon, Feb 03, 2025 at 07:53:00PM +0100, Maciej S. Szmigiero wrote: On 3.02.2025 19:20, Peter Xu wrote: On Thu, Jan 30, 2025 at 11:08:29AM +0100, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" Multifd send channels are terminated by calling qio_ch

Re: [PATCH v4 09/33] migration: postcopy_ram_listen_thread() needs to take BQL for some calls

2025-02-03 Thread Maciej S. Szmigiero
On 3.02.2025 21:36, Peter Xu wrote: On Mon, Feb 03, 2025 at 09:15:52PM +0100, Maciej S. Szmigiero wrote: On 3.02.2025 20:58, Peter Xu wrote: On Mon, Feb 03, 2025 at 02:57:36PM +0100, Maciej S. Szmigiero wrote: On 2.02.2025 13:45, Dr. David Alan Gilbert wrote: * Maciej S. Szmigiero (m...@macie

Re: [PATCH v4 13/33] migration/multifd: Device state transfer support - receive side

2025-02-03 Thread Peter Xu
On Thu, Jan 30, 2025 at 11:08:34AM +0100, Maciej S. Szmigiero wrote: > From: "Maciej S. Szmigiero" > > Add a basic support for receiving device state via multifd channels - > channels that are shared with RAM transfers. > > Depending whether MULTIFD_FLAG_DEVICE_STATE flag is present or not in th

Re: [PATCH v4 10/33] error: define g_autoptr() cleanup function for the Error type

2025-02-03 Thread Daniel P . Berrangé
On Thu, Jan 30, 2025 at 11:08:31AM +0100, Maciej S. Szmigiero wrote: > From: "Maciej S. Szmigiero" > > Automatic memory management helps avoid memory safety issues. > > Signed-off-by: Maciej S. Szmigiero > --- > include/qapi/error.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/i

Re: [PATCH v2 14/15] iotests: Add qsd-migrate case

2025-02-03 Thread Kevin Wolf
Am 03.02.2025 um 20:35 hat Eric Blake geschrieben: > On Fri, Jan 31, 2025 at 10:50:50AM +0100, Kevin Wolf wrote: > > Test that it's possible to migrate a VM that uses an image on shared > > storage through qemu-storage-daemon. > > > > Signed-off-by: Kevin Wolf > > --- > > tests/qemu-iotests/test

Re: [PATCH v4 10/33] error: define g_autoptr() cleanup function for the Error type

2025-02-03 Thread Peter Xu
On Thu, Jan 30, 2025 at 11:08:31AM +0100, Maciej S. Szmigiero wrote: > From: "Maciej S. Szmigiero" > > Automatic memory management helps avoid memory safety issues. > > Signed-off-by: Maciej S. Szmigiero Reviewed-by: Peter Xu -- Peter Xu

Re: [PATCH v4 09/33] migration: postcopy_ram_listen_thread() needs to take BQL for some calls

2025-02-03 Thread Peter Xu
On Mon, Feb 03, 2025 at 09:15:52PM +0100, Maciej S. Szmigiero wrote: > On 3.02.2025 20:58, Peter Xu wrote: > > On Mon, Feb 03, 2025 at 02:57:36PM +0100, Maciej S. Szmigiero wrote: > > > On 2.02.2025 13:45, Dr. David Alan Gilbert wrote: > > > > * Maciej S. Szmigiero (m...@maciej.szmigiero.name) wrot

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-03 Thread Peter Xu
On Mon, Feb 03, 2025 at 07:53:00PM +0100, Maciej S. Szmigiero wrote: > On 3.02.2025 19:20, Peter Xu wrote: > > On Thu, Jan 30, 2025 at 11:08:29AM +0100, Maciej S. Szmigiero wrote: > > > From: "Maciej S. Szmigiero" > > > > > > Multifd send channels are terminated by calling > > > qio_channel_shutd

Re: [PATCH v4 09/33] migration: postcopy_ram_listen_thread() needs to take BQL for some calls

2025-02-03 Thread Maciej S. Szmigiero
On 3.02.2025 20:58, Peter Xu wrote: On Mon, Feb 03, 2025 at 02:57:36PM +0100, Maciej S. Szmigiero wrote: On 2.02.2025 13:45, Dr. David Alan Gilbert wrote: * Maciej S. Szmigiero (m...@maciej.szmigiero.name) wrote: On 2.02.2025 03:06, Dr. David Alan Gilbert wrote: * Maciej S. Szmigiero (m...@ma

Re: [PATCH v2 07/14] accel/stubs: Expand stubs for TCG

2025-02-03 Thread Richard Henderson
On 2/3/25 09:38, Thomas Huth wrote: On 03/02/2025 17.43, Richard Henderson wrote: On 2/3/25 02:22, Thomas Huth wrote: On 03/02/2025 04.18, Richard Henderson wrote: Add tcg_allowed, qmp_x_query_jit, qmp_x_query_opcount. These are referenced when CONFIG_TCG is enabled globally, but not for a spe

Re: [PATCH v4 09/33] migration: postcopy_ram_listen_thread() needs to take BQL for some calls

2025-02-03 Thread Peter Xu
On Mon, Feb 03, 2025 at 02:57:36PM +0100, Maciej S. Szmigiero wrote: > On 2.02.2025 13:45, Dr. David Alan Gilbert wrote: > > * Maciej S. Szmigiero (m...@maciej.szmigiero.name) wrote: > > > On 2.02.2025 03:06, Dr. David Alan Gilbert wrote: > > > > * Maciej S. Szmigiero (m...@maciej.szmigiero.name) w

Re: [PATCH] block: remove unused BLOCK_OP_TYPE_DATAPLANE

2025-02-03 Thread Eric Blake
On Mon, Feb 03, 2025 at 01:25:29PM -0500, Stefan Hajnoczi wrote: > BLOCK_OP_TYPE_DATAPLANE prevents BlockDriverState from being used by > virtio-blk/virtio-scsi with IOThread. Commit b112a65c52aa ("block: > declare blockjobs and dataplane friends!") eliminated the main reason > for this blocker in

Re: [PATCH v2 15/15] iotests: Add (NBD-based) tests for inactive nodes

2025-02-03 Thread Eric Blake
On Fri, Jan 31, 2025 at 10:50:51AM +0100, Kevin Wolf wrote: > This tests different types of operations on inactive block nodes > (including graph changes, block jobs and NBD exports) to make sure that > users manually activating and inactivating nodes doesn't break things. > > Support for inactive

Re: [PATCH v2 14/15] iotests: Add qsd-migrate case

2025-02-03 Thread Eric Blake
On Fri, Jan 31, 2025 at 10:50:50AM +0100, Kevin Wolf wrote: > Test that it's possible to migrate a VM that uses an image on shared > storage through qemu-storage-daemon. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/tests/qsd-migrate | 132 +++ > tests/qemu-iot

Re: [PATCH v6 00/10] Support virtio-gpu DRM native context

2025-02-03 Thread Alex Bennée
"Kim, Dongwon" writes: > Hi, > > The commit below could change the timing of drawing by making the drawing > done at refresh cycle instead of via drawing event. So it looks like either > dmabuf > or client's framebuffer is being written and read at the same time. Hey, can > you > describe how t

Re: [PATCH v2 13/15] iotests: Add filter_qtest()

2025-02-03 Thread Eric Blake
On Fri, Jan 31, 2025 at 10:50:49AM +0100, Kevin Wolf wrote: > The open-coded form of this filter has been copied into enough tests > that it's better to move it into iotests.py. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/iotests.py | 4 > tests/qemu-iotests/041

Re: [PATCH v2 12/15] nbd/server: Support inactive nodes

2025-02-03 Thread Stefan Hajnoczi
On Fri, Jan 31, 2025 at 10:50:48AM +0100, Kevin Wolf wrote: > In order to support running an NBD export on inactive nodes, we must > make sure to return errors for any operations that aren't allowed on > inactive nodes. Reads are the only operation we know we need for > inactive images, so to err o

Re: [PATCH v2 10/14] configure: Define TARGET_LONG_BITS in configs/targets/*.mak

2025-02-03 Thread Richard Henderson
On 2/3/25 10:30, Philippe Mathieu-Daudé wrote: On 3/2/25 04:18, Richard Henderson wrote: Define TARGET_LONG_BITS in each target's configure fragment. Do this without removing the define in target/*/cpu-param.h so that errors are caught like so: In file included from .../src/include/exec/cpu-def

Re: [PATCH v2 12/15] nbd/server: Support inactive nodes

2025-02-03 Thread Eric Blake
On Fri, Jan 31, 2025 at 10:50:48AM +0100, Kevin Wolf wrote: > In order to support running an NBD export on inactive nodes, we must > make sure to return errors for any operations that aren't allowed on > inactive nodes. Reads are the only operation we know we need for > inactive images, so to err o

Re: [PATCH v2 11/15] block/export: Add option to allow export of inactive nodes

2025-02-03 Thread Stefan Hajnoczi
On Fri, Jan 31, 2025 at 10:50:47AM +0100, Kevin Wolf wrote: > Add an option in BlockExportOptions to allow creating an export on an > inactive node without activating the node. This mode needs to be > explicitly supported by the export type (so that it doesn't perform any > operations that are forb

Re: [PATCH v2 11/15] block/export: Add option to allow export of inactive nodes

2025-02-03 Thread Eric Blake
On Fri, Jan 31, 2025 at 10:50:47AM +0100, Kevin Wolf wrote: > Add an option in BlockExportOptions to allow creating an export on an > inactive node without activating the node. This mode needs to be > explicitly supported by the export type (so that it doesn't perform any > operations that are forb

Re: [PATCH v2 10/15] block/export: Don't ignore image activation error in blk_exp_add()

2025-02-03 Thread Stefan Hajnoczi
On Fri, Jan 31, 2025 at 10:50:46AM +0100, Kevin Wolf wrote: > Currently, block jobs can't handle inactive images correctly. Incoming Did you mean "block exports" instead of "block jobs"? If it's really "block jobs", please give an example scenario of the iteraction between jobs and exports. Other

Re: [PATCH v2 09/15] block: Support inactive nodes in blk_insert_bs()

2025-02-03 Thread Stefan Hajnoczi
On Thu, Jan 30, 2025 at 06:12:40PM +0100, Kevin Wolf wrote: > Device models have a relatively complex way to set up their block > backends, in which blk_attach_dev() sets blk->disable_perm = true. > We want to support inactive images in exports, too, so that > qemu-storage-daemon can be used with m

Re: [PATCH v2 08/15] block: Add blockdev-set-active QMP command

2025-02-03 Thread Stefan Hajnoczi
On Thu, Jan 30, 2025 at 06:12:39PM +0100, Kevin Wolf wrote: > The system emulator tries to automatically activate and inactivate block > nodes at the right point during migration. However, there are still > cases where it's necessary that the user can do this manually. > > Images are only activate

Re: [PATCH v2 07/15] block: Add option to create inactive nodes

2025-02-03 Thread Stefan Hajnoczi
On Thu, Jan 30, 2025 at 06:12:38PM +0100, Kevin Wolf wrote: > In QEMU, nodes are automatically created inactive while expecting an > incoming migration (i.e. RUN_STATE_INMIGRATE). In qemu-storage-daemon, > the notion of runstates doesn't exist. It also wouldn't necessarily make > sense to introduce

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-03 Thread Maciej S. Szmigiero
On 3.02.2025 19:20, Peter Xu wrote: On Thu, Jan 30, 2025 at 11:08:29AM +0100, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" Multifd send channels are terminated by calling qio_channel_shutdown(QIO_CHANNEL_SHUTDOWN_BOTH) in multifd_send_terminate_threads(), which in the TLS case essent

Re: [PATCH v2 06/15] block: Fix crash on block_resize on inactive node

2025-02-03 Thread Stefan Hajnoczi
On Thu, Jan 30, 2025 at 06:12:37PM +0100, Kevin Wolf wrote: > In order for block_resize to fail gracefully on an inactive node instead > of crashing with an assertion failure in bdrv_co_write_req_prepare() > (called from bdrv_co_truncate()), we need to check for inactive nodes > also when they are

Re: [RFC PATCH 0/5] hw/arm/virt: Add support for user-creatable nested SMMUv3

2025-02-03 Thread Nicolin Chen
On Fri, Jan 31, 2025 at 05:54:56PM +0100, Eric Auger wrote: > On 1/9/25 5:45 AM, Nicolin Chen wrote: > > On Mon, Dec 16, 2024 at 10:01:29AM +, Shameerali Kolothum Thodi wrote: > >> And patches prior to this commit adds that support: > >> 4ccdbe3: ("cover-letter: Add HW accelerated nesting supp

Re: [PATCH v2 05/15] block: Allow inactivating already inactive nodes

2025-02-03 Thread Stefan Hajnoczi
On Thu, Jan 30, 2025 at 06:12:36PM +0100, Kevin Wolf wrote: > What we wanted to catch with the assertion is cases where the recursion > finds that a child was inactive before its parent. This should never > happen. But if the user tries to inactivate an image that is already > inactive, that's harm

Re: [PATCH v2 04/15] block: Don't attach inactive child to active node

2025-02-03 Thread Stefan Hajnoczi
On Thu, Jan 30, 2025 at 06:12:35PM +0100, Kevin Wolf wrote: > An active node makes unrestricted use of its children and would possibly > run into assertion failures when it operates on an inactive child node. > > Signed-off-by: Kevin Wolf > --- > block.c | 5 + > 1 file changed, 5 insertions

Re: [PATCH v2 03/15] migration/block-active: Remove global active flag

2025-02-03 Thread Stefan Hajnoczi
On Thu, Jan 30, 2025 at 06:12:34PM +0100, Kevin Wolf wrote: > Block devices have an individual active state, a single global flag > can't cover this correctly. This becomes more important as we allow > users to manually manage which nodes are active or inactive. > > Now that it's allowed to call b

Re: [PATCH v2 02/15] block: Inactivate external snapshot overlays when necessary

2025-02-03 Thread Stefan Hajnoczi
On Thu, Jan 30, 2025 at 06:12:33PM +0100, Kevin Wolf wrote: > Putting an active block node on top of an inactive one is strictly > speaking an invalid configuration and the next patch will turn it into a > hard error. > > However, taking a snapshot while disk images are inactive after > completing

Re: [PATCH v2 01/15] block: Add 'active' field to BlockDeviceInfo

2025-02-03 Thread Stefan Hajnoczi
On Thu, Jan 30, 2025 at 06:12:32PM +0100, Kevin Wolf wrote: > This allows querying from QMP (and also HMP) whether an image is > currently active or inactive (in the sense of BDRV_O_INACTIVE). > > Signed-off-by: Kevin Wolf > --- > qapi/block-core.json | 6 +- > block/monitor/block

Re: qemu-iotests 302 failing

2025-02-03 Thread Nir Soffer
> On 3 Feb 2025, at 20:26, Stefan Hajnoczi wrote: > > Hi Nir, > qemu-iotests 302 is failing: > > $ git show > commit 6fccaa2fba391815308a746d68f7fa197bc93586 > ... > $ python --version # on Fedora 41 x86_64 > Python 3.13.1 > $ tests/qemu-iotests/check -qcow2 302 > 302 fail [13:1

Re: [PATCH v2 01/14] meson: Drop tcg as a module

2025-02-03 Thread Philippe Mathieu-Daudé
On 3/2/25 10:58, Thomas Huth wrote: On 03/02/2025 04.18, Richard Henderson wrote: The fact that this is only enabled for x86 probably means it was done incorrectly.  Certainly the set of files selected to go into the module is woefully incomplete.  Drop it for now. Maybe add: This mostly reve

Re: [PATCH v2 01/14] meson: Drop tcg as a module

2025-02-03 Thread Philippe Mathieu-Daudé
On 3/2/25 04:18, Richard Henderson wrote: The fact that this is only enabled for x86 probably means it was done incorrectly. Certainly the set of files selected to go into the module is woefully incomplete. Drop it for now. Signed-off-by: Richard Henderson --- accel/tcg/meson.build | 11 +++

Re: [PATCH v2 11/14] target/*: Remove TARGET_LONG_BITS from cpu-param.h

2025-02-03 Thread Philippe Mathieu-Daudé
On 3/2/25 04:18, Richard Henderson wrote: This is now handled by the configs/targets/*.mak fragment. Signed-off-by: Richard Henderson --- target/alpha/cpu-param.h | 2 -- target/arm/cpu-param.h| 2 -- target/avr/cpu-param.h| 1 - target/hexagon/cpu-param.h| 1 - t

Re: [PATCH v2 10/14] configure: Define TARGET_LONG_BITS in configs/targets/*.mak

2025-02-03 Thread Philippe Mathieu-Daudé
On 3/2/25 04:18, Richard Henderson wrote: Define TARGET_LONG_BITS in each target's configure fragment. Do this without removing the define in target/*/cpu-param.h so that errors are caught like so: In file included from .../src/include/exec/cpu-defs.h:26, from ../src/target/hpp

qemu-iotests 302 failing

2025-02-03 Thread Stefan Hajnoczi
Hi Nir, qemu-iotests 302 is failing: $ git show commit 6fccaa2fba391815308a746d68f7fa197bc93586 ... $ python --version # on Fedora 41 x86_64 Python 3.13.1 $ tests/qemu-iotests/check -qcow2 302 302 fail [13:16:45] [13:16:45] 0.5s (last: 0.5s) failed, exit status 1 ---

Re: [PATCH V1 06/26] vfio/container: preserve DMA mappings

2025-02-03 Thread Cédric Le Goater
On 1/29/25 15:43, Steve Sistare wrote: Preserve DMA mappings during cpr-transfer. In the container pre_save handler, suspend the use of virtual addresses in DMA mappings with VFIO_DMA_UNMAP_FLAG_VADDR, because guest RAM will be remapped at a different VA after exec. DMA to already-mapped pages

[PATCH] block: remove unused BLOCK_OP_TYPE_DATAPLANE

2025-02-03 Thread Stefan Hajnoczi
BLOCK_OP_TYPE_DATAPLANE prevents BlockDriverState from being used by virtio-blk/virtio-scsi with IOThread. Commit b112a65c52aa ("block: declare blockjobs and dataplane friends!") eliminated the main reason for this blocker in 2014. Nowadays the block layer supports I/O from multiple AioContexts, s

Re: [PATCH v7 51/52] i386/tdx: Validate phys_bits against host value

2025-02-03 Thread Paolo Bonzini
On 2/2/25 15:39, Xiaoyao Li wrote: On 2/1/2025 2:27 AM, Paolo Bonzini wrote: On Fri, Jan 24, 2025 at 2:40 PM Xiaoyao Li wrote: For TDX guest, the phys_bits is not configurable and can only be host/native value. Validate phys_bits inside tdx_check_features(). Hi Xiaoyao, to avoid qemu-kvm

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-03 Thread Peter Xu
On Thu, Jan 30, 2025 at 11:08:29AM +0100, Maciej S. Szmigiero wrote: > From: "Maciej S. Szmigiero" > > Multifd send channels are terminated by calling > qio_channel_shutdown(QIO_CHANNEL_SHUTDOWN_BOTH) in > multifd_send_terminate_threads(), which in the TLS case essentially > calls shutdown(SHUT_R

RE: [PATCH v6 00/10] Support virtio-gpu DRM native context

2025-02-03 Thread Kim, Dongwon
Hi, The commit below could change the timing of drawing by making the drawing done at refresh cycle instead of via drawing event. So it looks like either dmabuf or client's framebuffer is being written and read at the same time. Hey, can you describe how the corruption looks like? Is it just garb

  1   2   3   >