init_out_device may only commit some part of the result and leave the
state inconsistent when it encounters a fatal error or the device gets
unplugged during the operation, which is expressed by
kAudioHardwareBadObjectError or kAudioHardwareBadDeviceError. Commit the
result in the end of the functi
Reallocate buffers when the active device change as the required buffer
size may differ.
Signed-off-by: Akihiko Odaki
Reviewed-by: Phil Dennis-Jordan
Acked-by: Christian Schoenebeck
---
audio/coreaudio.m | 1 +
1 file changed, 1 insertion(+)
diff --git a/audio/coreaudio.m b/audio/coreaudio.m
These functions can be used to re-initialize buffers when hardware
parameters change due to device hotplug, for example.
Signed-off-by: Akihiko Odaki
Reviewed-by: Phil Dennis-Jordan
Reviewed-by: Christian Schoenebeck
---
audio/audio_int.h | 2 ++
audio/audio.c | 24 ++-
coreaudio had names that are not conforming to QEMU codding style.
coreaudioVoiceOut also had some members that are prefixed with redundant
words like "output" or "audio".
Global names included "out" to tell they are specific to output devices,
but this rule was not completely enforced.
The frame s
This series contains two fixes for coreaudio. See each one for details.
Signed-off-by: Akihiko Odaki
---
Changes in v5:
- Added patch "coreaudio: Improve naming", removing verbose names like
outputDeviceID and audioDevicePropertyBufferFrameSize altogether.
- Link to v4:
https://lore.kernel.org
On Fri, Jan 17, 2025 at 10:26:57AM +0100, Paolo Bonzini wrote:
> Date: Fri, 17 Jan 2025 10:26:57 +0100
> From: Paolo Bonzini
> Subject: [PATCH 10/10] rust: qdev: make reset take a shared reference
> X-Mailer: git-send-email 2.47.1
>
> Because register reset is within a borrow_mut() call, reset
>
On Fri, Jan 17, 2025 at 10:26:56AM +0100, Paolo Bonzini wrote:
> Date: Fri, 17 Jan 2025 10:26:56 +0100
> From: Paolo Bonzini
> Subject: [PATCH 09/10] rust: pl011: pull device-specific code out of
> MemoryRegionOps callbacks
> X-Mailer: git-send-email 2.47.1
>
> read() can now return a simple u64
On Fri, Jan 17, 2025 at 10:26:55AM +0100, Paolo Bonzini wrote:
> Date: Fri, 17 Jan 2025 10:26:55 +0100
> From: Paolo Bonzini
> Subject: [PATCH 08/10] rust: pl011: remove duplicate definitions
> X-Mailer: git-send-email 2.47.1
>
> Unify the "Interrupt" enum and the "INT_*" constants with a struct
On Fri, Jan 17, 2025 at 10:26:54AM +0100, Paolo Bonzini wrote:
> Date: Fri, 17 Jan 2025 10:26:54 +0100
> From: Paolo Bonzini
> Subject: [PATCH 07/10] rust: pl011: wrap registers with BqlRefCell
> X-Mailer: git-send-email 2.47.1
>
> This is a step towards making memory ops use a shared reference t
Hi Don,
On Fri, Jan 10, 2025 at 11:05:24PM -0500, Donald Dutile wrote:
> On 1/8/25 11:45 PM, Nicolin Chen wrote:
> > On Mon, Dec 16, 2024 at 10:01:29AM +, Shameerali Kolothum Thodi wrote:
> > > And patches prior to this commit adds that support:
> > > 4ccdbe3: ("cover-letter: Add HW accelerate
> --- a/rust/hw/char/pl011/src/device_class.rs
> +++ b/rust/hw/char/pl011/src/device_class.rs
> @@ -6,11 +6,11 @@
> use std::os::raw::{c_int, c_void};
>
> use qemu_api::{
> -bindings::*, c_str, vmstate_clock, vmstate_fields, vmstate_of,
> vmstate_subsections,
> -vmstate_unused, zeroabl
On 1/22/25 01:50, Paolo Bonzini wrote:
Now that everything has been cleaned up, look at DF and prefixes
in a single function, and call that one from gen_repz and gen_repz_nz.
Based-on:<20241215090613.89588-1-pbonz...@redhat.com>
Suggested-by: Richard Henderson
Signed-off-by: Paolo Bonzini
---
On Wed, Jan 22, 2025 at 3:55 PM Eric Auger wrote:
>
> Hi Jason,
>
>
> On 1/22/25 8:17 AM, Jason Wang wrote:
> > On Wed, Jan 22, 2025 at 12:25 AM Eric Auger wrote:
> >>
> >> Hi Jason,
> >>
> >> On 1/21/25 4:27 AM, Jason Wang wrote:
> >>> On Tue, Jan 21, 2025 at 1:33 AM Eric Auger wrote:
> Wh
For consistency, rename the remaining parts of ivshmem PCI device after
it was renamed from ivshmem to ivshmem-pci.
Signed-off-by: Gustavo Romero
---
contrib/ivshmem-client/ivshmem-client.h | 2 +-
contrib/ivshmem-server/ivshmem-server.h | 2 +-
docs/system/device-emula
Add me as the maintainer for the ivshmem-pci.c device, the ivshmem
server, and the ivshmem client tool. Also, adjust remaining parts left
behind after ivshmem PCI device was renamed from ivshmem.c to
ivshmem-pci.c, like header files, Kconfig, docs, and build scripts.
Cheers,
Gustavo
Gustavo Rome
Add me as the maintainer for the ivshmem-pci device and for the ivshmem
server and client tool.
Signed-off-by: Gustavo Romero
---
MAINTAINERS | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 846b81e3ec..8327ce9c79 100644
--- a/MAINTAINER
On 1/16/2025 11:02 AM, Eugenio Perez Martin wrote:
On Fri, Jan 10, 2025 at 6:09 PM Jonah Palmer wrote:
Adds the in_xlat_addr & out_xlat_addr hwaddr arrays to the
VirtQueueElement struct and introduces an optional GPA output parameter
to dma_memory_map().
These arrays will store a VirtQueue
On 22.01.25 20:40, “William Roche wrote:
From: William Roche
Punching a hole in a file with fallocate needs to take into account the
fd_offset value for a correct file location.
But guest_memfd internal use doesn't currently consider fd_offset.
Fixes: 4b870dc4d0c0 ("hostmem-file: add offset op
Philippe Mathieu-Daudé writes:
> CpuState caches its CPUClass since commit 6fbdff87062
> ("cpu: cache CPUClass in CPUState for hot code paths"),
> use it.
>
> Signed-off-by: Philippe Mathieu-Daudé
> Reviewed-by: Richard Henderson
Acked-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead
* Laurent Vivier :
> [...]
> It would be cleaner to replace all the IFA_XXX by their QEMU_IFA_XXX.
Thanks for review, Laurent!
Below I've merged patch #1 and #7, as suggested by you.
Is this OK?
Can you review?
Thanks!
Helge
From: Helge Deller
Date: Mon
Philippe Mathieu-Daudé writes:
> Both CPUClass::gdb_read_register() and CPUClass::gdb_write_register()
> handlers are called from common gdbstub code, and won't be called with
> register index over CPUClass::gdb_num_core_regs:
>
> int gdb_read_register(CPUState *cpu, GByteArray *buf, int reg)
>
On Wed, Jan 22, 2025 at 10:19:41PM +0300, Michael Tokarev wrote:
> 08.01.2025 21:43, Daniel P. Berrangé пишет:
> > We're seeing periodic reports of errors like:
> >
> > $ qemu-img create -f luks --object secret,data=123456,id=sec0 \
> >-o key-secret=sec0 luks-info.img 1M
> >
On Wed, Jan 22, 2025 at 07:40:53PM +, “William Roche wrote:
> From: William Roche
>
> Punching a hole in a file with fallocate needs to take into account the
> fd_offset value for a correct file location.
> But guest_memfd internal use doesn't currently consider fd_offset.
>
> Fixes: 4b870dc
From: William Roche
Working on the poisoned memory recovery mechanisms with David
Hildenbrand, it appeared that the file hole punching done with
the memory discard functions are missing the file offset value
fd_offset to correctly modify the right file location.
Note that guest_memfd would not c
From: William Roche
Punching a hole in a file with fallocate needs to take into account the
fd_offset value for a correct file location.
But guest_memfd internal use doesn't currently consider fd_offset.
Fixes: 4b870dc4d0c0 ("hostmem-file: add offset option")
Signed-off-by: William Roche
---
On Friday, January 17, 2025 7:47:00 AM CET Akihiko Odaki wrote:
> init_out_device may only commit some part of the result and leave the
> state inconsistent when it encounters a fatal error or the device gets
> unplugged during the operation, which is expressed by
> kAudioHardwareBadObjectError or
On 1/22/25 09:01, David Hildenbrand wrote:
On 21.01.25 23:54, “William Roche wrote:
From: William Roche
[...]
--- a/system/physmem.c
+++ b/system/physmem.c
@@ -3655,6 +3655,7 @@ int ram_block_discard_range(RAMBlock *rb,
uint64_t start, size_t length)
need_madvise = (rb->page_size ==
08.01.2025 21:43, Daniel P. Berrangé пишет:
We're seeing periodic reports of errors like:
$ qemu-img create -f luks --object secret,data=123456,id=sec0 \
-o key-secret=sec0 luks-info.img 1M
Formatting 'luks-info.img', fmt=luks size=1048576 key-secret=sec0
qemu-img: luks-
On Friday, January 17, 2025 7:47:02 AM CET Akihiko Odaki wrote:
> Reallocate buffers when the active device change as the required buffer
> size may differ.
>
> Signed-off-by: Akihiko Odaki
OTOH it also re-allocates the buffer when the size did not change, but Ok.
Acked-by: Christian Schoenebec
From: Helge Deller
Commit 20f7b890173b ("hw/hppa: Reset vCPUs calling resettable_reset()")
broke booting the Linux kernel with initrd which may have been provided
on the command line. The problem is, that the mentioned commit zeroes
out initial registers which were preset with addresses for the L
From: Helge Deller
Allow up to 256 GB RAM, which is the maximum a rp8440 machine (the very
last 64-bit PA-RISC machine) physically supports.
Signed-off-by: Helge Deller
---
hw/hppa/hppa_hardware.h | 2 ++
hw/hppa/machine.c | 26 +++---
2 files changed, 21 insertions(
From: Helge Deller
Two patches: The first fixes booting a Linux kernel which
is provided on the command line.
The second patch adds support for more than 4GB RAM on 64-bit boxes
(requires additional patch for SeaBIOS-hppa which will be pushed
before qemu v10).
Helge Deller (2):
hw/hppa: Suppor
On 22/01/2025 18.33, Alex Bennée wrote:
Thomas Huth writes:
Unfortunately, this test had not been added to meson.build, so we did
not notice a regression: Looking for 'Kernel panic - not syncing: VFS:'
as the indication for the final boot state of the kernel was a bad
idea since 'Kernel panic
Paolo Savini writes:
> This patch replaces the use of a helper function with direct tcg ops
> generation
> in order to emulate whole register loads and stores. This is done in order to
> improve the performance of QEMU.
Generally having the frontend second guess what the backend will do is
not
On 1/22/25 02:32, Philippe Mathieu-Daudé wrote:
As Daniel mentioned:
"The number of instances of MachineClass is not large enough
that we save a useful amount of memory through bitfields."
Also, see recent commit ecbf3567e21 ("docs/devel/style: add a
section about bitfield, and disallow th
Thomas Huth writes:
> Unfortunately, this test had not been added to meson.build, so we did
> not notice a regression: Looking for 'Kernel panic - not syncing: VFS:'
> as the indication for the final boot state of the kernel was a bad
> idea since 'Kernel panic - not syncing' is the default failu
On Wed, Jan 22, 2025 at 06:22:06PM +0100, Laurent Vivier wrote:
> On 22/01/2025 17:51, Stefano Garzarella wrote:
> > On Wed, Jan 22, 2025 at 05:41:15PM +0100, Laurent Vivier wrote:
> > > On 22/01/2025 17:20, Stefano Garzarella wrote:
> > > > On Wed, Jan 22, 2025 at 08:59:22AM -0500, Michael S. Tsir
On 1/22/25 13:33, Zhao Liu wrote:
On Fri, Jan 17, 2025 at 10:00:41AM +0100, Paolo Bonzini wrote:
Date: Fri, 17 Jan 2025 10:00:41 +0100
From: Paolo Bonzini
Subject: [PATCH 05/10] rust: vmstate: implement VMState for scalar types
X-Mailer: git-send-email 2.47.1
Scalar types are those that have t
On 22/01/2025 17:51, Stefano Garzarella wrote:
On Wed, Jan 22, 2025 at 05:41:15PM +0100, Laurent Vivier wrote:
On 22/01/2025 17:20, Stefano Garzarella wrote:
On Wed, Jan 22, 2025 at 08:59:22AM -0500, Michael S. Tsirkin wrote:
On Wed, Jan 22, 2025 at 02:42:14PM +0100, Stefano Garzarella wrote:
The actual IO BAR4 write quirk in vfio_probe_igd_bar4_quirk() was
removed in previous change, leaving the function not matching its name,
so move it into the newly introduced vfio_config_quirk_setup(). There
is no functional change in this commit. If any failure occurs, the
function simply returns
The IO BAR4 of IGD devices contains a pair of 32-bit address/data
registers, MMIO_Index (0x0) and MMIO_Data (0x4), which provide access
to the MMIO BAR0 (GTTMMADR) from IO space. These registers are probably
only used by the VBIOS, and are not documented by intel. The observed
layout of MMIO_Index
Based on experiments and reverse engineering about the mysterious IO
BAR4, it appears that the current quirk implementation is incorrect.
As discussed in a previous mail thread [1], current implementation
believes VBIOS is writing HPA of Data Stolen Memory (DSM) in GTT
entries, so it intercepts and
Some devices, such as IGD, require device-specific quirks to be applied
to their pci config spaces. Currently, these quirks are either part of
BAR quirk, or being a part of vfio_realize(). Add a placeholder for pci
config quirks for moving the quirks to one place later.
Signed-off-by: Tomita Moeko
Though GTT Stolen Memory (GSM) is right below Data Stolen Memory (DSM)
in host address space, direct access to GSM is prohibited, and it is
not mapped to guest address space. Both host and guest accesses GSM
indirectly through the second half of MMIO BAR0 (GTTMMADR).
Guest firmware only need to re
Dmitry Osipenko writes:
> This patchset adds DRM native context support to VirtIO-GPU on Qemu.
>
> Contarary to Virgl and Venus contexts that mediates high level GFX APIs,
> DRM native context [1] mediates lower level kernel driver UAPI, which
> reflects in a less CPU overhead and less/simpler co
On 22/1/25 16:27, Thomas Huth wrote:
On 22/01/2025 15.33, Peter Maydell wrote:
On Wed, 22 Jan 2025 at 12:36, Thomas Huth wrote:
On 22/01/2025 11.32, Philippe Mathieu-Daudé wrote:
As Daniel mentioned:
"The number of instances of MachineClass is not large enough
that we save a useful a
Le 20/01/2025 à 22:33, del...@kernel.org a écrit :
From: Helge Deller
Fixes this warning:
Unknown host IFA type: 11
IFA_PROTO has been introduced in kernel v5.18, and as such using it
unconditionally breaks build on Ubuntu 22.04. Instead convert the IFA_XXX
values to QEMU_IDA_XXX values and
Le 20/01/2025 à 22:33, del...@kernel.org a écrit :
From: Helge Deller
Convert existing places to use QEMU_IFA_XXX values.
Signed-off-by: Helge Deller
---
linux-user/fd-trans.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/linux-user/fd-trans.c b/linux
On Wed, Jan 22, 2025 at 05:41:15PM +0100, Laurent Vivier wrote:
On 22/01/2025 17:20, Stefano Garzarella wrote:
On Wed, Jan 22, 2025 at 08:59:22AM -0500, Michael S. Tsirkin wrote:
On Wed, Jan 22, 2025 at 02:42:14PM +0100, Stefano Garzarella wrote:
On Tue, Jan 21, 2025 at 11:00:29AM +0100, Laure
Il mer 22 gen 2025, 17:31 Zhao Liu ha scritto:
> > if event == bindings::QEMUChrEvent::CHR_EVENT_BREAK &&
> !self.loopback_enabled() {
> > -self.put_fifo(registers::Data::BREAK.into());
> > +let update = self.put_fifo(registers::Data::BREAK.into());
>
> We can omi
Previous versions:
- RFC v1:
https://lore.kernel.org/all/20241218170840.1090473-1-paolo.sav...@embecosm.com/
- RFC v2:
https://lore.kernel.org/all/20241220153834.16302-1-paolo.sav...@embecosm.com/
Thanks Max for the feedback here:
https://lore.kernel.org/all/258795e9-4e97-4cd7-949f-24e88d24f..
This patch replaces the use of a helper function with direct tcg ops generation
in order to emulate whole register loads and stores. This is done in order to
improve the performance of QEMU.
We still use the helper function when vstart is not 0 at the beginning of the
emulation of the whole registe
On Wed, Jan 22, 2025 at 05:41:31PM +0800, Xu Yilun wrote:
> On Wed, Jan 22, 2025 at 03:30:05PM +1100, Alexey Kardashevskiy wrote:
> >
> >
> > On 22/1/25 02:18, Peter Xu wrote:
> > > On Tue, Jun 25, 2024 at 12:31:13AM +0800, Xu Yilun wrote:
> > > > On Mon, Jan 20, 2025 at 03:46:15PM -0500, Peter X
> > > -pub fn read(&mut self, offset: hwaddr, _size: c_uint) ->
> > > std::ops::ControlFlow {
> > > +fn regs_read(&mut self, offset: RegisterOffset) -> ControlFlow > > u32> {
> > > use RegisterOffset::*;
> >
> > Can we move this "use" to the start of the file?
>
> I don't think
On 22/01/2025 17:20, Stefano Garzarella wrote:
On Wed, Jan 22, 2025 at 08:59:22AM -0500, Michael S. Tsirkin wrote:
On Wed, Jan 22, 2025 at 02:42:14PM +0100, Stefano Garzarella wrote:
On Tue, Jan 21, 2025 at 11:00:29AM +0100, Laurent Vivier wrote:
> In vhost_user_receive() if vhost_net_notify_mi
Hi, Shivam,
On Wed, Jan 22, 2025 at 10:54:17AM +, Shivam Kumar wrote:
> There is one place where we set the migration status to FAILED but we don’t
> set
> s->error, i.e. in save_snapshot workflow, please check qemu_savevm_state but
> not sure setting s->error in this case is possible (or req
On Fri, Jan 17, 2025 at 10:26:52AM +0100, Paolo Bonzini wrote:
> Date: Fri, 17 Jan 2025 10:26:52 +0100
> From: Paolo Bonzini
> Subject: [PATCH 05/10] rust: pl011: pull interrupt updates out of
> read/write ops
> X-Mailer: git-send-email 2.47.1
>
> qemu_irqs are not part of the vmstate, therefore
On Wed, Jan 22, 2025 at 08:59:22AM -0500, Michael S. Tsirkin wrote:
On Wed, Jan 22, 2025 at 02:42:14PM +0100, Stefano Garzarella wrote:
On Tue, Jan 21, 2025 at 11:00:29AM +0100, Laurent Vivier wrote:
> In vhost_user_receive() if vhost_net_notify_migration_done() reports
> an error we display on
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/10.0 for any
user-visible changes.
signature.asc
Description: PGP signature
On Wed, Jan 22, 2025 at 05:20:06PM +0100, Stefano Garzarella wrote:
> On Wed, Jan 22, 2025 at 08:59:22AM -0500, Michael S. Tsirkin wrote:
> > On Wed, Jan 22, 2025 at 02:42:14PM +0100, Stefano Garzarella wrote:
> > > On Tue, Jan 21, 2025 at 11:00:29AM +0100, Laurent Vivier wrote:
> > > > In vhost_us
On 1/21/25 12:25 PM, Eugenio Perez Martin wrote:
On Tue, Jan 21, 2025 at 3:53 PM Jonah Palmer wrote:
On 1/16/25 11:44 AM, Eugenio Perez Martin wrote:
On Fri, Jan 10, 2025 at 6:09 PM Jonah Palmer wrote:
Decouples the IOVA allocator from the full IOVA->HVA tree to support a
SVQ IOVA->HV
On Wed, Jan 22, 2025 at 01:26:21PM +0530, Prasad Pandit wrote:
> Hi,
> On Tue, 21 Jan 2025 at 21:17, Peter Xu wrote:
> > https://lore.kernel.org/qemu-devel/ZykJBq7ME5jgSzCA@x1n/
> > Would you please add all the tests mentioned there?
>
> /x86_64/migration/multifd/file/mapped-ram/
> /x86_6
Adds support to ARM virtualization to allow handling
generic error ACPI Event via GED & error source device.
It is aligned with Linux Kernel patch:
https://lore.kernel.org/lkml/1272350481-27951-8-git-send-email-ying.hu...@intel.com/
Co-authored-by: Mauro Carvalho Chehab
Co-authored-by: Jonathan
Using the QMP GHESv2 API requires preparing a raw data array
containing a CPER record.
Add a helper script with subcommands to prepare such data.
Currently, only ARM Processor error CPER record is supported.
Signed-off-by: Mauro Carvalho Chehab
---
MAINTAINERS| 3 +
scrip
Adds a generic error device to handle generic hardware error
events as specified at ACPI 6.5 specification at 18.3.2.7.2:
https://uefi.org/specs/ACPI/6.5/18_Platform_Error_Interfaces.html#event-notification-for-generic-error-sources
using HID PNP0C33.
The PNP0C33 device is used to report hardware
Creates a QMP command to be used for generic ACPI APEI hardware error
injection (HEST) via GHESv2, and add support for it for ARM guests.
Error injection uses ACPI_HEST_SRC_ID_QMP source ID to be platform
independent. This is mapped at arch virt bindings, depending on the
types supported by QEMU a
Move the check logic into a common function and simplify the
code which checks if GHES is enabled and was properly setup.
Signed-off-by: Mauro Carvalho Chehab
---
hw/acpi/ghes-stub.c| 4 ++--
hw/acpi/ghes.c | 33 +++--
include/hw/acpi/ghes.h | 9 +---
Create a new property (x-has-hest-addr) and use it to detect if
the GHES table offsets can be calculated from the HEST address
(qemu 9.2 and upper) or via the legacy way via an offset obtained
from the hardware_errors firmware file.
Signed-off-by: Mauro Carvalho Chehab
---
hw/acpi/generic_event_
The GHES migration logic at GED should now support HEST table
location too.
Signed-off-by: Mauro Carvalho Chehab
---
hw/acpi/generic_event_device.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c
i
Now that the ghes preparation patches were merged, let's add support
for error injection.
I'm opting to fold two patch series into one here:
1.
https://lore.kernel.org/qemu-devel/20250113130854.848688-1-mchehab+hua...@kernel.org/
It is the first 5 patches containing changes to the math used to
The current code is actually dependent on having just one error
structure with a single source.
As the number of sources should be arch-dependent, as it will depend on
what kind of synchronous/assynchronous notifications will exist, change
the logic to dynamically build the table.
Yet, for a prop
Store HEST table address at GPA, placing its content at
hest_addr_le variable.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Jonathan Cameron
---
Change from v8:
- hest_addr_lr is now pointing to the error source size and data.
Signed-off-by: Mauro Carvalho Chehab
---
hw/acpi/ghes.c
There are two pointers that are needed during error injection:
1. The start address of the CPER block to be stored;
2. The address of the ack, which needs a reset before next error.
It is preferable to calculate them from the HEST table. This allows
checking the source ID, the size of the table
Some error injection notify methods are async, like GPIO
notify. Add a notifier to be used when the error record is
ready to be sent to the guest OS.
Signed-off-by: Mauro Carvalho Chehab
---
hw/acpi/ghes.c | 5 -
include/hw/acpi/ghes.h | 3 +++
2 files changed, 7 insertions(+), 1 del
On 22/01/2025 15.33, Peter Maydell wrote:
On Wed, 22 Jan 2025 at 12:36, Thomas Huth wrote:
On 22/01/2025 11.32, Philippe Mathieu-Daudé wrote:
As Daniel mentioned:
"The number of instances of MachineClass is not large enough
that we save a useful amount of memory through bitfields."
A
When the IOMMU address space width is smaller than the physical
address width, a MMIO region of a device can fail to map because the
region is outside the supported IOVA ranges of the VM. In this case,
PCI peer-to-peer transactions on BARs are not supported.
This can occur with the 39-bit IOMMU ad
Hello,
Under certain circumstances, a MMIO region of a device fails to map
because the region is outside the supported IOVA ranges of the VM. In
this case, PCI peer-to-peer transactions on BARs are not supported.
This typically occurs when the IOMMU address space width is less than
the physical ad
We plan to use vfio_viommu_preset() in MemoryListener handlers which
operate at the container level. Change the parameter to VFIOContainerBase
to ease future changes.
Signed-off-by: Cédric Le Goater
---
include/hw/vfio/vfio-common.h | 2 +-
hw/vfio/common.c | 4 ++--
hw/vfio/migrati
This is to be consistent with other reported errors related to vIOMMU
devices.
Signed-off-by: Cédric Le Goater
---
hw/vfio/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index
cf14987e42bd9188d5040b51a2f84cfa959f632d..ad326839db49cf3a5052
The Intel CPU has a complex history regarding setting of the physical
address space width on KVM. A 'phys_bits' field and a "phys-bits"
property were added by commit af45907a1328 ("target-i386: Allow
physical address bits to be set") to tune this value.
In certain circumstances, it is interesting
On Wed, Jan 22, 2025 at 3:44 PM Alex Bennée wrote:
>
> Roman Penyaev writes:
>
> > This patch implements a new chardev backend `hub` device, which
> > aggregates input from multiple backend devices and forwards it to a
> > single frontend device. Additionally, `hub` device takes the output
> > fr
Print a warning if IOMMU address space width is smaller than the
physical address width. In this case, PCI peer-to-peer transactions on
BARs are not supported and failures of device MMIO regions are to be
expected.
This can occur with the 39-bit IOMMU address space width as found on
consumer grade
On 1/22/25 15:59, Zhao Liu wrote:
if size > 0 {
debug_assert!(!buf.is_null());
-state.as_mut().put_fifo(c_uint::from(buf.read_volatile()))
An extra question...here I'm not sure, do we really need read_volatile?
No, the buffer is not guest visible. It will
On 1/22/25 15:34, Zhao Liu wrote:
On Fri, Jan 17, 2025 at 10:26:50AM +0100, Paolo Bonzini wrote:
Date: Fri, 17 Jan 2025 10:26:50 +0100
From: Paolo Bonzini
Subject: [PATCH 03/10] rust: pl011: extract conversion to RegisterOffset
X-Mailer: git-send-email 2.47.1
As an added bonus, this also makes
Hi Gavin,
On Fri, Dec 13, 2024 at 10:03:08PM +1000, Gavin Shan wrote:
> Hi Jean,
>
> On 11/26/24 5:56 AM, Jean-Philippe Brucker wrote:
> > When RME is enabled, the upper GPA bit is used to distinguish protected
> > from unprotected addresses. Reserve it when setting up the guest memory
> > map.
>
On Fri, 17 Jan 2025 at 12:42, Daniel P. Berrangé wrote:
>
> We expect all new code to be contributed with the "GPL-2.0-or-later"
> license tag. Divergence is permitted if the new file is derived from
> pre-existing code under a different license, whether from elsewhere
> in QEMU codebase, or outsi
Roman Penyaev writes:
> This patch implements a new chardev backend `hub` device, which
> aggregates input from multiple backend devices and forwards it to a
> single frontend device. Additionally, `hub` device takes the output
> from the frontend device and sends it back to all the connected
> b
On Fri, Jan 17, 2025 at 10:26:51AM +0100, Paolo Bonzini wrote:
> Date: Fri, 17 Jan 2025 10:26:51 +0100
> From: Paolo Bonzini
> Subject: [PATCH 04/10] rust: pl011: extract CharBackend receive logic into
> a separate function
> X-Mailer: git-send-email 2.47.1
>
> Prepare for moving all references
On Wed, 22 Jan 2025 at 12:36, Thomas Huth wrote:
>
> On 22/01/2025 11.32, Philippe Mathieu-Daudé wrote:
> > As Daniel mentioned:
> >
> > "The number of instances of MachineClass is not large enough
> >that we save a useful amount of memory through bitfields."
> >
> > Also, see recent commit
On Thu, 16 Jan 2025 19:05:46 +0100
Philippe Mathieu-Daudé wrote:
> On 28/11/23 17:42, Igor Mammedov wrote:
> > On Mon, 18 Sep 2023 18:02:39 +0200
> > Philippe Mathieu-Daudé wrote:
> >
> >> While create_vcpu_thread() creates a vCPU thread, its counterpart
> >> is cpu_remove_sync(), which join
On Fri, Jan 17, 2025 at 10:26:50AM +0100, Paolo Bonzini wrote:
> Date: Fri, 17 Jan 2025 10:26:50 +0100
> From: Paolo Bonzini
> Subject: [PATCH 03/10] rust: pl011: extract conversion to RegisterOffset
> X-Mailer: git-send-email 2.47.1
>
> As an added bonus, this also makes the new function return
On Fri, 17 Jan 2025 09:43:11 +
Jonathan Cameron via wrote:
> On Fri, 17 Jan 2025 10:13:41 +0900
> Itaru Kitayama wrote:
>
> > > On Jan 16, 2025, at 19:58, Jonathan Cameron
> > > wrote:
> > >
> > > On Thu, 16 Jan 2025 15:04:53 +0900
> > > Itaru Kitayama wrote:
> > >
> > >> Hi Jonath
On Wed, Jan 22, 2025 at 02:42:14PM +0100, Stefano Garzarella wrote:
> On Tue, Jan 21, 2025 at 11:00:29AM +0100, Laurent Vivier wrote:
> > In vhost_user_receive() if vhost_net_notify_migration_done() reports
> > an error we display on the console:
> >
> > Vhost user backend fails to broadcast fake
This patch addresses a potential data race involving the global variable
goflag in the rcutorture test. The issue is resolved by adding the atomic
qualifier to ensure proper synchronization.
Fixes: 8fda74a52b ("rcu: add rcutorture")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2750
Sign
Am 12.12.2024 um 21:47 hat Peter Xu geschrieben:
> v1: https://lore.kernel.org/r/20241211201739.1380222-1-pet...@redhat.com
>
> Changelog: in previous v1, I got a wrong cut-off accident in commit
> message, which is now fixed (along with some small touchup elsewhere).
> When at it, I also tried to
On Wed, Jan 22, 2025 at 02:43:13PM +0100, Thomas Huth wrote:
> skipIfMissingImports should use importlib.import_module() for checking
> whether a module with the name stored in the "impname" variable is
> available or not, otherwise the code tries to import a module with
> the name "impname" instea
On 2025/1/21 20:25, Yong Huang wrote:
On Tue, Dec 31, 2024 at 9:56 AM fuqiang wang wrote:
Using the current algorithm, there are issues with precision not being
handled correctly during division operations. (Even though double type
casting is used in the function, it does not seem to have an
Many of the new decorators of the functional tests don't work as
expected (and simply always allow to run the tests). Let's fix them!
v2:
- Use importlib.import_module() to check whether we can import a module
- Split the import check into a separate patch
Thomas Huth (2):
tests/functional/qemu
The decorators that use a lambda function are currently broken
and do not properly skip the test if the condition is not met.
Using "return skipUnless(lambda: ...)" does not work as expected.
To fix it, rewrite the decorators without lambda, it's simpler
that way anyway.
Reviewed-by: Daniel P. Ber
skipIfMissingImports should use importlib.import_module() for checking
whether a module with the name stored in the "impname" variable is
available or not, otherwise the code tries to import a module with
the name "impname" instead.
(This bug hasn't been noticed before since there is another issue
1 - 100 of 181 matches
Mail list logo
