[PATCH 5/5] qtest/e1000e|igb: Fix msix to re-trigger interrupts

The e1000e and igb tests don't clear the msix pending bit after waiting for it, as it is masked so the irq doesn't get sent. Failing to clear the pending interrupt means all subsequent waits for that interrupt after the first do not actually wait for an interrupt genreated by the device. This affe

[PATCH 3/5] qtest/libqos/pci: Do not write to PBA memory

The PCI Local Bus Specification says the result of writes to MSI-X PBA memory is undefined. QEMU implements them as no-ops, so remove the pointless write from qpci_msix_pending(). Cc: Michael S. Tsirkin Cc: Marcel Apfelbaum Cc: Dmitry Fleytman Cc: Akihiko Odaki Cc: Sriram Yagnaraman Signed-of

[PATCH 4/5] qtest/e1000e|igb: Clear interrupt-cause bits after irq

The e1000e and igb tests do not clear the ICR/EICR cause bits (or set auto-clear) on seeing queue interrupts, which inhibits the triggering of a new interrupt. Fix this by clearing the cause bits, and verify that the expected cause bit was set. Cc: Michael S. Tsirkin Cc: Marcel Apfelbaum Cc: Dm

[PATCH 0/5] qtest: pci and e1000e/igb msix fixes

Hi, This series is split out from a larger one that added some more XHCI functionality and tests here. Just wanted to get more focus on the PCI issues first. https://lore.kernel.org/qemu-devel/20241212083502.1439033-1-npig...@gmail.com/T/#t It is quite reworked after feedback about the incorrect

[PATCH 1/5] qtest/pci: Enforce balanced iomap/unmap

Add assertions to ensure a BAR is not mapped twice, and only previously mapped BARs are unmapped. This can help catch some bugs. Cc: Michael S. Tsirkin Cc: Marcel Apfelbaum Reviewed-by: Fabiano Rosas Signed-off-by: Nicholas Piggin --- tests/qtest/libqos/ahci.h | 1 + tests/qtest/libqos

[PATCH 2/5] qtest/libqos/pci: Fix qpci_msix_enable sharing bar0

Devices where the MSI-X addresses are shared with other MMIO on BAR0 can not use msi_enable because it unmaps and remaps BAR0, which interferes with device MMIO mappings. xhci-nec is one such device we would like to test msix with. Use the BAR iomap tracking structure introduced in the previous ch

Re: [PATCH 26/26] rust: callbacks: allow passing optional callbacks as ()

Il mer 18 dic 2024, 07:50 Zhao Liu ha scritto: > Am I using the wrong terminology? Function pointers in a structure should > be called a vtable, rather than callbacks (for example, methods in > TypeInfo, > read/write methods in MemoryRegionOps). Callbacks are typically function > pointers used as

[PATCH v2 1/2] target/riscv: refactor VSTART_CHECK_EARLY_EXIT() to accept vl as a parameter

Some vector instructions are special, such as the vlm.v instruction, where setting its vl actually sets evl = (vl + 7) >> 3. To improve maintainability, we will uniformly use VSTART_CHECK_EARLY_EXIT() to check for the condition vstart >= vl. This function will also handle cases involving evl. Sign

[PATCH v2 2/2] target/riscv: fix handling of nop for vstart >= vl in some vector instruction

fix: https://lore.kernel.org/all/20240322085319.1758843-8-alistair.fran...@wdc.com/ Signed-off-by: Chao Liu --- target/riscv/vector_helper.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c index 4

[PATCH v2 0/2] Enhanced VSTART and VL Checks for Vector Instructions

Hi, all: In the second version of this patch, I addressed the issue that other vector instructions didn't check for vstart >= vl correctly. I refactored the VSTART_CHECK_EARLY_EXIT() macro. This change is intended to: Vector instructions with special vl values can also be checked with this macro,

Re: [PATCH 24/26] rust: qom: move device_id to PL011 class side

Il mer 18 dic 2024, 07:39 Zhao Liu ha scritto: > I supposed a case, where there is such a QOM (QEMU Object Model) > structure relationship: > > * DummyState / DummyClass: defined in Rust side, and registered the > TypeInfo by `Object` macro. > > - So its class_init will be called by C QOM cod

[PATCH] meson.build: Disallow libnfs v6 to fix the broken macOS build

The macOS build in our CI is currently broken since homebrew updated libnfs to version 6 - and that version apparently comes with a big API breakage. Disallow that version for now to get the broken CI job working again. Once somebody had enough time to adapt our code in block/nfs.c, we can revert t

Re: [PATCH 26/26] rust: callbacks: allow passing optional callbacks as ()

On Tue, Dec 17, 2024 at 05:40:14PM +0100, Paolo Bonzini wrote: > Date: Tue, 17 Dec 2024 17:40:14 +0100 > From: Paolo Bonzini > Subject: Re: [PATCH 26/26] rust: callbacks: allow passing optional > callbacks as () > > Il mar 17 dic 2024, 16:55 Zhao Liu ha scritto: > > > On Mon, Dec 09, 2024 at 0

Re: [PATCH 2/7] guest_memfd: Introduce an object to manage the guest-memfd with RamDiscardManager

On 12/13/2024 3:08 PM, Chenyi Qiang wrote: > As the commit 852f0048f3 ("RAMBlock: make guest_memfd require > uncoordinated discard") highlighted, some subsystems like VFIO might > disable ram block discard. However, guest_memfd relies on the discard > operation to perform page conversion between

Re: [PATCH 24/26] rust: qom: move device_id to PL011 class side

On Tue, Dec 17, 2024 at 05:50:09PM +0100, Paolo Bonzini wrote: > Date: Tue, 17 Dec 2024 17:50:09 +0100 > From: Paolo Bonzini > Subject: Re: [PATCH 24/26] rust: qom: move device_id to PL011 class side > > Il mar 17 dic 2024, 04:39 Zhao Liu ha scritto: > > > > +impl ClassInitImpl for PL011State {

Re: [PATCH 41/46] tcg/optimize: Use fold_masks_zs in fold_xor

On 12/17/24 14:45, Pierrick Bouvier wrote: On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson ---   tcg/optimize.c | 17 +++--   1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 46116970f3..fec46014be 10064

Re: [PATCH 27/46] tcg/optimize: Use fold_masks_zs in fold_qemu_ld

On 12/17/24 14:35, Pierrick Bouvier wrote: @@ -3001,11 +3010,18 @@ void tcg_optimize(TCGContext *s)   break;   case INDEX_op_qemu_ld_a32_i32:   case INDEX_op_qemu_ld_a64_i32: +    done = fold_qemu_ld_1reg(&ctx, op); +    break;   case INDEX_op_q

Re: [PATCH 03/46] tcg/optimize: Add fold_masks_zsa, fold_masks_zs, fold_masks_z

On 12/17/24 14:03, Pierrick Bouvier wrote: +__attribute__((unused)) +static bool fold_masks_zs(OptContext *ctx, TCGOp *op, +  uint64_t z_mask, uint64_t s_mask) +{ +    return fold_masks_zsa(ctx, op, z_mask, s_mask, -1); +} + +__attribute__((unused)) +static bool fold_masks

Re: [PATCH 3/8] pci/msix: Implement PBA writes

On Fri Dec 13, 2024 at 3:14 PM AEST, Akihiko Odaki wrote: > On 2024/12/12 17:34, Nicholas Piggin wrote: > > Implement MMIO PBA writes, 1 to trigger and 0 to clear. > > > > This functionality is used by some qtests, which keep the msix irq > > masked and test irq pending via the PBA bits, for simpl

Re: [PATCH v2 1/2] hw/usb/hcd-xhci-pci: Make PCI device more configurable

On Thu Dec 12, 2024 at 8:41 PM AEST, Phil Dennis-Jordan wrote: > Hey Nicholas, > > I'm not an XHCI & PCI expert (yet?) so apologies if I've got some of this > wrong, but I've asked some questions and made some comments inline: Hey Phil, Thanks for the review, looks like you are the expert now :)

Re: [PATCH for-10.0 3/9] target/riscv: add shcounterenw

On Thu, Nov 14, 2024 at 3:20 AM Daniel Henrique Barboza wrote: > > shcounterenw is defined in RVA22 as: > > "For any hpmcounter that is not read-only zero, the corresponding bit in > hcounteren must be writable." > > This is always true in TCG so let's claim support for it. > > Signed-off-by: Dani

Re: [PATCH v2] riscv/gdb: add virt mode debug interface

On Mon, 2024-12-16 at 15:33 +1000, Alistair Francis wrote: > On Thu, Dec 5, 2024 at 7:17 PM Yanfeng Liu wrote: > > > > On Thu, 2024-12-05 at 08:10 +, Alex Bennée wrote: > > > Yanfeng Liu writes: > > > > > > > On Wed, 2024-12-04 at 17:03 +0100, Mario Fleischmann wrote: > > > > > Hi everyone,

Re: (Proposal) New TDX Global Metadata To Report FIXED0 and FIXED1 CPUID Bits

On Tue, Dec 17, 2024, Rick P Edgecombe wrote: > On Mon, 2024-12-16 at 17:53 -0800, Sean Christopherson wrote: > > Every new feature that lands in hardware needs to either be "benign" or > > have the > > appropriate virtualization controls.  KVM already has to deal with cases > > where > > feature

Re: [PATCH V4 02/19] physmem: fd-based shared memory

On Tue, Dec 17, 2024 at 04:54:43PM -0500, Steven Sistare wrote: > On 12/16/2024 1:19 PM, Peter Xu wrote: > > On Fri, Dec 13, 2024 at 11:41:45AM -0500, Steven Sistare wrote: > > > On 12/12/2024 4:22 PM, Peter Xu wrote: > > > > On Thu, Dec 12, 2024 at 03:38:00PM -0500, Steven Sistare wrote: > > > > >

[PATCH v3 09/11] contrib/plugins/hwprofile: fix 32-bit build

Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- contrib/plugins/hwprofile.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/contrib/plugins/hwprofile.c b/contrib/plugins/hwprofile.c index 739ac0c66b5..2a4cbc47d40 100644 --- a/c

[PATCH v3 01/11] tests/tcg/plugins/insn: remove unused callback parameter

Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- tests/tcg/plugins/insn.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/tcg/plugins/insn.c b/tests/tcg/plugins/insn.c index baf2d07205d..0c723cb9ed8 100644 --- a/tests/tcg/p

Re: [PATCH v2 00/11] Fix 32-bit build for plugins

On 12/17/24 14:38, Pierrick Bouvier wrote: Since 9.2.0 release, we are building contrib plugins using the QEMU build system (before, it was external makefiles). When building for 32-bit host platform, some warnings are triggered and build fail. Thus, at the time, the decision was to not fix thos

[PATCH v3 11/11] configure: reenable plugins by default for 32-bit hosts

Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- configure | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/configure b/configure index 18336376bff..02f1dd2311f 100755 --- a/configure +++ b/configure @@ -528,25 +528,6 @@ case "$cpu" in

[PATCH v3 07/11] contrib/plugins/hotblocks: fix 32-bit build

Signed-off-by: Pierrick Bouvier --- contrib/plugins/hotblocks.c | 29 - 1 file changed, 24 insertions(+), 5 deletions(-) diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c index 02bc5078bdd..f12bfb7a267 100644 --- a/contrib/plugins/hotblocks.c +++

[PATCH v3 04/11] tests/tcg/plugins/mem: fix 32-bit build

Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- tests/tcg/plugins/mem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/tcg/plugins/mem.c b/tests/tcg/plugins/mem.c index b0fa8a9f277..d87d6628e09 100644 --- a/tests/tcg/plugins/mem.c +++ b/tests/t

[PATCH v3 10/11] contrib/plugins/hotpages: fix 32-bit build

Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- contrib/plugins/hotpages.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/contrib/plugins/hotpages.c b/contrib/plugins/hotpages.c index 8316ae50c72..c6e64937194 100644 --- a/contrib/plugins/hotpages.c +

[PATCH v3 00/11] Fix 32-bit build for plugins

Since 9.2.0 release, we are building contrib plugins using the QEMU build system (before, it was external makefiles). When building for 32-bit host platform, some warnings are triggered and build fail. Thus, at the time, the decision was to not fix those plugins, and disable by default plugins for

[PATCH v3 03/11] tests/tcg/plugins/syscall: fix 32-bit build

Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- tests/tcg/plugins/syscall.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/tcg/plugins/syscall.c b/tests/tcg/plugins/syscall.c index ff452178b18..47aad55fc1b 100644 --- a/tests/tcg/plugins/syscall

[PATCH v3 08/11] contrib/plugins/cflow: fix 32-bit build

Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- contrib/plugins/cflow.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/contrib/plugins/cflow.c b/contrib/plugins/cflow.c index b39974d1cf3..930ecb46fcd 100644 --- a/contrib/plugins/cflow.c

[PATCH v3 05/11] contrib/plugins/stoptrigger: fix 32-bit build

Signed-off-by: Pierrick Bouvier --- contrib/plugins/stoptrigger.c | 48 --- 1 file changed, 27 insertions(+), 21 deletions(-) diff --git a/contrib/plugins/stoptrigger.c b/contrib/plugins/stoptrigger.c index 03ee22f4c6a..b3a6ed66a7b 100644 --- a/contrib/plugins/sto

[PATCH v3 02/11] contrib/plugins/howvec: ensure we don't regress if this plugin is extended

Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- contrib/plugins/howvec.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/contrib/plugins/howvec.c b/contrib/plugins/howvec.c index 9be67f74534..2aa9029c3f0 100644 --- a/contrib/plugins/howvec.c +++ b/co

[PATCH v3 06/11] contrib/plugins/cache: fix 32-bit build

Signed-off-by: Pierrick Bouvier --- contrib/plugins/cache.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/contrib/plugins/cache.c b/contrib/plugins/cache.c index 512ef6776b7..7baff868609 100644 --- a/contrib/plugins/cache.c +++ b/contrib/plugins/cache.c @

[PATCH v2 04/11] tests/tcg/plugins/mem: fix 32-bit build

Signed-off-by: Pierrick Bouvier --- tests/tcg/plugins/mem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/tcg/plugins/mem.c b/tests/tcg/plugins/mem.c index b0fa8a9f277..d87d6628e09 100644 --- a/tests/tcg/plugins/mem.c +++ b/tests/tcg/plugins/mem.c @@ -135,14 +135

[PATCH v2 00/11] Fix 32-bit build for plugins

Since 9.2.0 release, we are building contrib plugins using the QEMU build system (before, it was external makefiles). When building for 32-bit host platform, some warnings are triggered and build fail. Thus, at the time, the decision was to not fix those plugins, and disable by default plugins for

[PATCH v2 03/11] tests/tcg/plugins/syscall: fix 32-bit build

Signed-off-by: Pierrick Bouvier --- tests/tcg/plugins/syscall.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/tcg/plugins/syscall.c b/tests/tcg/plugins/syscall.c index ff452178b18..47aad55fc1b 100644 --- a/tests/tcg/plugins/syscall.c +++ b/tests/tcg/plugins/sysca

[PATCH v2 01/11] tests/tcg/plugins/insn: remove unused callback parameter

Signed-off-by: Pierrick Bouvier --- tests/tcg/plugins/insn.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/tcg/plugins/insn.c b/tests/tcg/plugins/insn.c index baf2d07205d..0c723cb9ed8 100644 --- a/tests/tcg/plugins/insn.c +++ b/tests/tcg/plugins/insn.c @@ -150,10 +1

[PATCH v2 09/11] contrib/plugins/hwprofile: fix 32-bit build

Signed-off-by: Pierrick Bouvier --- contrib/plugins/hwprofile.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/contrib/plugins/hwprofile.c b/contrib/plugins/hwprofile.c index 739ac0c66b5..2a4cbc47d40 100644 --- a/contrib/plugins/hwprofile.c +++ b

[PATCH v2 07/11] contrib/plugins/hotblocks: fix 32-bit build

Signed-off-by: Pierrick Bouvier --- contrib/plugins/hotblocks.c | 29 - 1 file changed, 24 insertions(+), 5 deletions(-) diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c index 02bc5078bdd..f12bfb7a267 100644 --- a/contrib/plugins/hotblocks.c +++

[PATCH v2 08/11] contrib/plugins/cflow: fix 32-bit build

Signed-off-by: Pierrick Bouvier --- contrib/plugins/cflow.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/contrib/plugins/cflow.c b/contrib/plugins/cflow.c index b39974d1cf3..930ecb46fcd 100644 --- a/contrib/plugins/cflow.c +++ b/contrib/plugins/cflow.c @@

[PATCH v2 05/11] contrib/plugins/stoptrigger: fix 32-bit build

Signed-off-by: Pierrick Bouvier --- contrib/plugins/stoptrigger.c | 48 --- 1 file changed, 27 insertions(+), 21 deletions(-) diff --git a/contrib/plugins/stoptrigger.c b/contrib/plugins/stoptrigger.c index 03ee22f4c6a..b3a6ed66a7b 100644 --- a/contrib/plugins/sto

[PATCH v2 10/11] contrib/plugins/hotpages: fix 32-bit build

Signed-off-by: Pierrick Bouvier --- contrib/plugins/hotpages.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/contrib/plugins/hotpages.c b/contrib/plugins/hotpages.c index 8316ae50c72..c6e64937194 100644 --- a/contrib/plugins/hotpages.c +++ b/contrib/plugins/hotpages.c

[PATCH v2 11/11] configure: reenable plugins by default for 32-bit hosts

Signed-off-by: Pierrick Bouvier --- configure | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/configure b/configure index 18336376bff..02f1dd2311f 100755 --- a/configure +++ b/configure @@ -528,25 +528,6 @@ case "$cpu" in ;; esac -# Now we have ou

[PATCH v2 02/11] contrib/plugins/howvec: ensure we don't regress if this plugin is extended

Signed-off-by: Pierrick Bouvier --- contrib/plugins/howvec.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/contrib/plugins/howvec.c b/contrib/plugins/howvec.c index 9be67f74534..2aa9029c3f0 100644 --- a/contrib/plugins/howvec.c +++ b/contrib/plugins/howvec.c @@ -253,6

[PATCH v2 06/11] contrib/plugins/cache: fix 32-bit build

Signed-off-by: Pierrick Bouvier --- contrib/plugins/cache.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/contrib/plugins/cache.c b/contrib/plugins/cache.c index 512ef6776b7..7baff868609 100644 --- a/contrib/plugins/cache.c +++ b/contrib/plugins/cache.c @

Re: [PATCH V4 02/19] physmem: fd-based shared memory

On 12/16/2024 1:19 PM, Peter Xu wrote: On Fri, Dec 13, 2024 at 11:41:45AM -0500, Steven Sistare wrote: On 12/12/2024 4:22 PM, Peter Xu wrote: On Thu, Dec 12, 2024 at 03:38:00PM -0500, Steven Sistare wrote: On 12/9/2024 2:42 PM, Peter Xu wrote: On Mon, Dec 02, 2024 at 05:19:54AM -0800, Steve S

Re: [PATCH] tests/qtest/migration: Restore include for postcopy

On Tue, Dec 17, 2024 at 06:22:01PM -0300, Fabiano Rosas wrote: > Commit 124a3c58b8 ("tests/qtest/migration: Move ufd_version_check to > utils") moved the ufd_version_check() function to another file but > failed to bring along the include, which is necessary to > pull in for __NR_userfaultd. > >

Re: [PATCH 01/13] plugins: change signature of qemu_plugin_insn_haddr

On 12/17/24 06:41, Richard Henderson wrote: On 12/16/24 19:06, Pierrick Bouvier wrote: It makes more sense to return the same type than qemu_plugin_insn_vaddr. Signed-off-by: Pierrick Bouvier --- include/qemu/qemu-plugin.h | 2 +- plugins/api.c | 12 ++-- 2 files c

Re: (Proposal) New TDX Global Metadata To Report FIXED0 and FIXED1 CPUID Bits

On Mon, 2024-12-16 at 17:53 -0800, Sean Christopherson wrote: > Every new feature that lands in hardware needs to either be "benign" or have > the > appropriate virtualization controls.  KVM already has to deal with cases where > features can effectively be used without KVM's knowledge.  E.g. ther

Re: [PATCH 09/13] contrib/plugins/hotblocks: fix 32-bit build

On 12/17/24 07:34, Richard Henderson wrote: On 12/16/24 19:07, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- contrib/plugins/hotblocks.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c index

[PATCH] tests/qtest/migration: Restore include for postcopy

Commit 124a3c58b8 ("tests/qtest/migration: Move ufd_version_check to utils") moved the ufd_version_check() function to another file but failed to bring along the include, which is necessary to pull in for __NR_userfaultd. Restore the missing include. While here, remove the ifdef __linux__ that'

Re: [PATCH] contrib/plugins/bbv.c: Start bb index from 1

Hi, On 12/17/24 06:24, ckf104 wrote: Standard simpoint tool reqeusts that index of basic block index starts from 1. Signed-off-by: ckf104 <1900011...@pku.edu.cn> --- contrib/plugins/bbv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/plugins/bbv.c b/contrib/plug

Re: [PATCH 0/2] Change default pointer authentication algorithm on aarch64 to impdef

On 12/17/24 02:38, Peter Maydell wrote: On Tue, 17 Dec 2024 at 07:40, Alex Bennée wrote: Pierrick Bouvier writes: On 12/16/24 11:50, Richard Henderson wrote: On 12/16/24 13:26, Pierrick Bouvier wrote: On 12/16/24 11:10, Richard Henderson wrote: On 12/4/24 15:12, Pierrick Bouvier wrote:

Re: [PATCH 29/46] tcg/optimize: Use finish_folding in fold_remainder

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index ee00620ce0..eac5ef5eec 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2134,7 +2134,7

Re: [PATCH 46/46] tcg/optimize: Move fold_cmp_vec, fold_cmpsel_vec into alphabetic sort

On 12/10/24 07:24, Richard Henderson wrote: The big comment just above says functions should be sorted. Signed-off-by: Richard Henderson --- tcg/optimize.c | 60 +- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/tcg/optimize.c

Re: [PATCH 45/46] tcg/optimize: Move fold_bitsel_vec into alphabetic sort

On 12/10/24 07:24, Richard Henderson wrote: The big comment just above says functions should be sorted. Add forward declarations as needed. Signed-off-by: Richard Henderson --- tcg/optimize.c | 114 + 1 file changed, 59 insertions(+), 55 deleti

Re: [PATCH 44/46] tcg/optimize: Remove [zsa]_mask from OptContext

On 12/10/24 07:23, Richard Henderson wrote: All mask setting is now done with parameters via fold_masks_*. Signed-off-by: Richard Henderson --- tcg/optimize.c | 16 1 file changed, 16 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 94e942e1cf..eb6e93809e 100

Re: [PATCH 43/46] tcg/optimize: Use finish_folding as default in tcg_optimize

On 12/10/24 07:23, Richard Henderson wrote: All non-default cases now finish folding within each function. Do the same with the default case and assert it is done after. Signed-off-by: Richard Henderson --- tcg/optimize.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --gi

Re: [PATCH 42/46] tcg/optimize: Use finish_folding in fold_bitsel_vec

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index fec46014be..24ec14f476 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2821,7 +2821,7

Re: [PATCH 41/46] tcg/optimize: Use fold_masks_zs in fold_xor

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 46116970f3..fec46014be 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c

Re: [PATCH 38/46] tcg/optimize: Use finish_folding in fold_sub, fold_sub_vec

On 12/10/24 07:23, Richard Henderson wrote: Duplicate fold_sub_vec into fold_sub instead of calling it, now that fold_sub_vec always returns true. Signed-off-by: Richard Henderson --- tcg/optimize.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tcg/optimize.c b

Re: [PATCH 39/46] tcg/optimize: Use fold_masks_zs in fold_tcg_ld

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 6412d5df37..4cccb3b0cf 100644 --- a/tcg/optimize.c +++ b/tcg/optim

Re: [PATCH 40/46] tcg/optimize: Use finish_folding in fold_tcg_ld_memcopy

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 4cccb3b0cf..46116970f3 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2674,7 +2674,7

Re: [PATCH 37/46] tcg/optimize: Use fold_masks_zs in fold_shift

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 551f96dfaa..bec5a07288 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@

Re: [PATCH 36/46] tcg/optimize: Use fold_masks_zsa in fold_sextract

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index c99e6f79d2..551f96dfaa 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2488,7

Re: [PATCH 35/46] tcg/optimize: Use finish_folding in fold_cmpsel_vec

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 30446baabd..c99e6f79d2 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2483,7 +2483,7

Re: [PATCH 35/46] tcg/optimize: Use finish_folding in fold_cmpsel_vec

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 30446baabd..c99e6f79d2 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2483,7 +2483,7

Re: [PATCH 33/46] tcg/optimize: Use fold_masks_z in fold_setcond2

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 0097502425..dd6ef3d831 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2450,9 +2450

Re: [PATCH 34/46] tcg/optimize: Use finish_folding in fold_cmp_vec

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index dd6ef3d831..30446baabd 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2462,7 +2462,7

Re: [PATCH 32/46] tcg/optimize: Use fold_masks_zs in fold_negsetcond

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index cfd4c08f11..0097502425 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2369,8 +2369,

Re: [PATCH 31/46] tcg/optimize: Use fold_masks_z in fold_setcond

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 7b1d437c27..cfd4c08f11 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2349,9 +2349

Re: [PATCH 30/46] tcg/optimize: Distinguish simplification in fold_setcond_zmask

On 12/10/24 07:23, Richard Henderson wrote: Change return from bool to int; distinguish between complete folding, simplification, and no change. Signed-off-by: Richard Henderson --- tcg/optimize.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/tcg

Re: [PATCH 27/46] tcg/optimize: Use fold_masks_zs in fold_qemu_ld

On 12/10/24 07:23, Richard Henderson wrote: Be careful not to call fold_masks_zs when the memory operation is wide enough to require multiple outputs, so split into two functions: fold_qemu_ld_1reg and fold_qemu_ld_2reg. Signed-off-by: Richard Henderson --- tcg/optimize.c | 28 +++

Re: [PATCH 28/46] tcg/optimize: Return true from fold_qemu_st, fold_tcg_st

On 12/10/24 07:23, Richard Henderson wrote: Stores have no output operands, and so need no further work. Signed-off-by: Richard Henderson --- tcg/optimize.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 6f41ef5adb..ee006

Re: [PATCH 26/46] tcg/optimize: Use fold_masks_zs in fold_orc

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 3d852b44e4..76ad02d73b 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2078,6

Re: [PATCH 25/46] tcg/optimize: Use fold_masks_zs in fold_or

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index ae1386c681..3d852b44e4 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -20

Re: [PATCH 24/46] tcg/optimize: Use fold_masks_zs in fold_not

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index aa5242a380..ae1386c681 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2056,12 +

Re: [PATCH 23/46] tcg/optimize: Use fold_masks_zs in fold_nor

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index cc3dc91d3f..aa5242a380 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2039,14

Re: [PATCH 22/46] tcg/optimize: Use fold_masks_z in fold_neg_no_const

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 924ee165ba..cc3dc91d3f 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2027,1

Re: [PATCH 21/46] tcg/optimize: Use fold_masks_zs in fold_nand

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 111969c2e3..924ee165ba 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2011,14

Re: [PATCH 20/46] tcg/optimize: Use finish_folding in fold_mul*

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 6d2d55f053..111969c2e3 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1952,7 +1

Re: [PATCH 19/46] tcg/optimize: Use fold_masks_zs in fold_movcond

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 260e3ea072..6d2d55f053 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -187

Re: [PATCH 18/46] tcg/optimize: Use fold_masks_zsa in fold_extu

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 5d10e704a7..260e3ea072 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1804

Re: [PATCH 17/46] tcg/optimize: Use fold_masks_zsa in fold_exts

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index a0ccf7f3f2..5d10e704a7 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1759,7

Re: [PATCH 16/46] tcg/optimize: Use finish_folding in fold_extract2

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 955151f4cf..a0ccf7f3f2 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1754,7 +1754,7

Re: [PATCH 15/46] tcg/optimize: Use fold_masks_zsa in fold_extract

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 5f3a824a07..955151f4cf 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1716,7

Re: [PATCH 14/46] tcg/optimize: Use fold_masks_zs in fold_eqv

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index e6dc9f2e28..5f3a824a07 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1701,15

Re: [PATCH 13/46] tcg/optimize: Use finish_folding in fold_dup, fold_dup2

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 59f510b49a..e6dc9f2e28 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1681,7 +168

Re: [PATCH 11/46] tcg/optimize: Use fold_and and fold_masks_z in fold_deposit

On 12/10/24 07:23, Richard Henderson wrote: When we fold to and, use fold_and, which sets s_mask and a_mask more intelligently than we do for the rest of deposit. Signed-off-by: Richard Henderson --- tcg/optimize.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --

Re: [PATCH 12/46] tcg/optimize: Use finish_folding in fold_divide

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 4d5fa04199..59f510b49a 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1671,7 +1671,7

Re: [PATCH 09/46] tcg/optimize: Use fold_masks_z in fold_count_zeros

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 3363ebd48c..c97ec10989 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1088,7 +

Re: [PATCH 10/46] tcg/optimize: Use fold_masks_z in fold_ctpop

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index c97ec10989..424ed7674d 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1598,2

Re: [PATCH 08/46] tcg/optimize: Use fold_masks_zs in fold_bswap

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 285407ce05..3363ebd48c 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1082,7 +108

Re: [PATCH 07/46] tcg/optimize: Use fold_masks_zsa in fold_andc

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 000ac0f810..285407ce05 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@

Re: [PATCH 06/46] tcg/optimize: Use fold_masks_zsa in fold_and

On 12/10/24 07:23, Richard Henderson wrote: Avoid the use of the OptContext slots. Signed-off-by: Richard Henderson --- tcg/optimize.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 135b14974f..000ac0f810 100644 --- a/tc

Re: [PATCH 00/46] tcg: Remove in-flight mask data from OptContext

On 12/10/24 07:23, Richard Henderson wrote: The desire is to start re-using some of the fold_* functions while lowering or simplifying operations during tcg_optmize. Many of these fold_* functions set z_mask, s_mask, and a_mask, which hang around until the end of the tcg_optmize loop and are app

  1   2   3   4   >