Re: [PATCH 12/71] hw/9pfs: Constify all Property

2024-12-13 Thread Greg Kurz
On Fri, 13 Dec 2024 13:06:46 -0600 Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- Reviewed-by: Greg Kurz > hw/9pfs/virtio-9p-device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c > index e

Re: [PATCH v2 31/34] next-cube: move next_rtc_cmd_is_write() and next_rtc_data_in_irq() functions

2024-12-13 Thread Thomas Huth
Am Thu, 12 Dec 2024 11:46:17 + schrieb Mark Cave-Ayland : > Move these functions in next-cube.c so that they are with the rest of the > next-rtc functions. > > Signed-off-by: Mark Cave-Ayland > --- > hw/m68k/next-cube.c | 172 ++-- > 1 file changed, 8

Re: [PATCH v2 11/34] next-cube: move ESCC to be QOM child of next-pc device

2024-12-13 Thread Thomas Huth
Am Thu, 12 Dec 2024 11:45:57 + schrieb Mark Cave-Ayland : > Since the ESCC is part of the next-pc device, move the ESCC to be a QOM child > of the next-pc device. > > Signed-off-by: Mark Cave-Ayland > --- > hw/m68k/next-cube.c | 54 ++--- > 1 file cha

Re: contrib/plugins does not build on 32-bit host

2024-12-13 Thread Pierrick Bouvier
On 12/13/24 21:29, Richard Henderson wrote: On 12/13/24 21:44, Pierrick Bouvier wrote: Hi Richard, On 12/13/24 13:47, Richard Henderson wrote: Hi, Several of the recent contrib/plugins/ patches do not build on e.g. arm32. All of the issues are related to casting between pointers and uint64_t;

Re: [PATCH v2 25/34] next-cube: QOMify NeXTRTC

2024-12-13 Thread Thomas Huth
Am Thu, 12 Dec 2024 11:46:11 + schrieb Mark Cave-Ayland : > This is to allow the RTC functionality to be maintained within its own > separate > device rather than as part of the next-pc device. > > Signed-off-by: Mark Cave-Ayland > --- > hw/m68k/next-cube.c | 71 +++

Re: [PATCH v2 11/34] next-cube: move ESCC to be QOM child of next-pc device

2024-12-13 Thread Thomas Huth
Am Thu, 12 Dec 2024 11:45:57 + schrieb Mark Cave-Ayland : > Since the ESCC is part of the next-pc device, move the ESCC to be a QOM child > of the next-pc device. > > Signed-off-by: Mark Cave-Ayland > --- > hw/m68k/next-cube.c | 54 ++--- > 1 file cha

Re: [PATCH v2 03/34] next-cube: create new next.scsi container memory region

2024-12-13 Thread Thomas Huth
Am Thu, 12 Dec 2024 11:45:49 + schrieb Mark Cave-Ayland : > Move the ESP SCSI and SCSI CSR registers to the new next.scsi container memory > region. > > Signed-off-by: Mark Cave-Ayland > --- > hw/m68k/next-cube.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) Reviewed-by: T

Re: [PATCH v2 08/34] next-cube: move SCSI 4020/4021 logic from next-pc device to next-scsi device

2024-12-13 Thread Thomas Huth
Am Thu, 12 Dec 2024 11:45:54 + schrieb Mark Cave-Ayland : > The SCSI 4020/4021 logic refers to the offset of the SCSI CSRs within the > NeXTCube > address space. Due to the previously overlapping memory regions, there were > duplicate MMIO accessors in the next.scr memory region for these reg

Re: contrib/plugins does not build on 32-bit host

2024-12-13 Thread Richard Henderson
On 12/13/24 21:44, Pierrick Bouvier wrote: Hi Richard, On 12/13/24 13:47, Richard Henderson wrote: Hi, Several of the recent contrib/plugins/ patches do not build on e.g. arm32. All of the issues are related to casting between pointers and uint64_t; there is a Werror generated for casting bet

Re: [PATCH v2 07/34] next-cube: move SCSI CSRs from next-pc to the next-scsi device

2024-12-13 Thread Thomas Huth
Am Thu, 12 Dec 2024 11:45:53 + schrieb Mark Cave-Ayland : > The SCSI CSRs are located within the SCSI subsystem of the NeXT PC (Peripheral > Contoller) which is now modelled as a separate QEMU device. Add a new memory > region subregion to contain the SCSI CSRs that simply store and retrieve t

Re: contrib/plugins does not build on 32-bit host

2024-12-13 Thread Pierrick Bouvier
Hi Richard, On 12/13/24 13:47, Richard Henderson wrote: Hi, Several of the recent contrib/plugins/ patches do not build on e.g. arm32. All of the issues are related to casting between pointers and uint64_t; there is a Werror generated for casting between pointers and integers of different size

Re: [PATCH v3] riscv/gdb: add V bit to priv register

2024-12-13 Thread Yanfeng Liu
On Fri, 2024-12-13 at 10:04 +0100, Mario Fleischmann wrote: > Hi, > > apologies for the delayed review; I've just gotten to it now. > > On 06.12.2024 01:14, Yanfeng Liu wrote: > > This adds virtualization mode (V bit) as bit(2) of register `priv` > > per RiscV debug spec v1.0.0-rc3. Checked with

Re: [PATCH 61/71] hw/tpm: Constify all Property

2024-12-13 Thread Stefan Berger
On 12/13/24 2:07 PM, Richard Henderson wrote: Signed-off-by: Richard Henderson Reviewed-by: Stefan Berger --- hw/tpm/tpm_crb.c| 2 +- hw/tpm/tpm_spapr.c | 2 +- hw/tpm/tpm_tis_i2c.c| 2 +- hw/tpm/tpm_tis_isa.c| 2 +- hw/tpm/tpm_tis_sysbus.c | 2 +- 5 files cha

Re: [PATCH 33/71] hw/ipack: Constify all Property

2024-12-13 Thread Alberto Garcia
On Fri 13 Dec 2024 01:07:07 PM -06, Richard Henderson wrote: > Signed-off-by: Richard Henderson Acked-by: Alberto Garcia Berto

Re: [PATCH 20/71] hw/char: Constify all Property

2024-12-13 Thread Alberto Garcia
On Fri 13 Dec 2024 01:06:54 PM -06, Richard Henderson wrote: > Signed-off-by: Richard Henderson Acked-by: Alberto Garcia Berto

[PULL 16/20] hw/ide/ahci: Decouple from PCI

2024-12-13 Thread Philippe Mathieu-Daudé
From: Bernhard Beschow In some adhoc profiling booting Linux VMs, it's observed that ahci_irq_lower() can be a hot path (1+ triggers until login prompt appears). Even though the parent device never changes, this method re-determines whether the parent device is a PCI device or not using the r

[PULL 14/20] hw/usb/hcd-xhci-nec: Remove unused XHCINecState::flags field

2024-12-13 Thread Philippe Mathieu-Daudé
Commit b9599519a01 ("hw/usb/hcd-xhci: Remove XHCI_FLAG_SS_FIRST flag") remove the last use of XHCINecState::flags but neglected to remove it; do that now. Reported-by: Nicholas Piggin Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20241127122812.89487-1-phi...@linar

[PULL 08/20] hw/pci: Have PCI_BUS implement TYPE_FW_CFG_DATA_GENERATOR_INTERFACE

2024-12-13 Thread Philippe Mathieu-Daudé
The FW_CFG_DATA_GENERATOR interface allows any object to produce a blob of data consumable by the fw_cfg device. Implement that for PCI bus objects. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Message-Id: <20241213133352.10915-5-phi...@linaro.org> --- hw/pci/pci.c | 37

[PULL 06/20] hw/nvram/fw_cfg: Pass QOM parent to fw_cfg_add_file_from_generator()

2024-12-13 Thread Philippe Mathieu-Daudé
Currently fw_cfg_add_file_from_generator() is restricted to command line created objects which reside in the '/objects' QOM container. In order to extend to other types of containers, pass the QOM parent by argument. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Message-I

[PULL 15/20] hw/usb/hcd-xhci-pci: Indentation fix

2024-12-13 Thread Philippe Mathieu-Daudé
From: Phil Dennis-Jordan Fixes number of spaces used for indentation on one line. Signed-off-by: Phil Dennis-Jordan Message-ID: <20241208191646.64857-6-p...@philjordan.eu> Signed-off-by: Philippe Mathieu-Daudé --- hw/usb/hcd-xhci-pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PULL 13/20] hw/usb/msd: Add status to usb_msd_packet_complete() function

2024-12-13 Thread Philippe Mathieu-Daudé
From: Nicholas Piggin This is a convenience change that accepts a status when completing a packet. Signed-off-by: Nicholas Piggin Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20241110034000.379463-2-npig...@gmail.com> Signed-off-by: Philippe Mathieu-Daudé --- hw/usb/dev-storage.c | 17 ++

[PULL 17/20] hw/ide/ahci: Extract TYPE_SYSBUS_AHCI into dedicated file

2024-12-13 Thread Philippe Mathieu-Daudé
From: Bernhard Beschow Implement in dedicated file, just like TYPE_ICH9_AHCI. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20241212110926.23548-3-shen...@gmail.com> Signed-off-by: Philippe Mathieu-Daudé --- hw/ide/ahci-sysbus.c | 91 +++

[PULL 18/20] hw/mips: Include missing 'exec/tswap.h' header

2024-12-13 Thread Philippe Mathieu-Daudé
Some files indirectly get "exec/tswap.h" declarations via "exec/cpu-all.h". Include it directly to be able to remove the former from the latter, otherwise we get: hw/mips/malta.c:674:22: error: call to undeclared function 'tswap32'; ISO C99 and later do not support implicit function declaration

[PULL 05/20] hw/nvram/fw_cfg: Rename fw_cfg_add_[file]_from_generator()

2024-12-13 Thread Philippe Mathieu-Daudé
fw_cfg_add_from_generator() is adding a 'file' entry, so rename as fw_cfg_add_file_from_generator() for clarity. Besides, we might introduce generators for other entry types. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Message-Id: <20241206181352.6836-2-phi...@linaro.or

[PULL 20/20] hw/xtensa: Include missing 'exec/tswap.h' header

2024-12-13 Thread Philippe Mathieu-Daudé
Some files indirectly get "exec/tswap.h" declarations via "exec/cpu-all.h". Include it directly to be able to remove the former from the latter, otherwise we get: hw/xtensa/bootparam.h:40:16: error: call to undeclared function 'tswap16'; ISO C99 and later do not support implicit function declar

[PULL 09/20] hw/pci: Add pci_bus_add_fw_cfg_extra_pci_roots() helper

2024-12-13 Thread Philippe Mathieu-Daudé
pci_bus_add_fw_cfg_extra_pci_roots() calls the fw_cfg API with PCI bus specific arguments. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Message-Id: <20241206181352.6836-5-phi...@linaro.org> --- include/hw/pci/pci.h | 3 +++ hw/pci/pci.c | 16 2

[PULL 00/20] Misc HW patches for 2024-12-14

2024-12-13 Thread Philippe Mathieu-Daudé
The following changes since commit 83aaec1d5a49f158abaa31797a0f976b3c07e5ca: Merge tag 'pull-tcg-20241212' of https://gitlab.com/rth7680/qemu into staging (2024-12-12 18:45:39 -0500) are available in the Git repository at: https://github.com/philmd/qemu.git tags/hw-misc-20241214 for you to

[PULL 19/20] hw/sh4/r2d: Include missing 'exec/tswap.h' header

2024-12-13 Thread Philippe Mathieu-Daudé
r2d.c indirectly get "exec/tswap.h" declarations via "exec/cpu-all.h". Include it directly to be able to remove the former from the latter, otherwise we get: hw/sh4/r2d.c:357:35: error: call to undeclared function 'tswap32'; ISO C99 and later do not support implicit function declarations [-Wim

[PULL 11/20] hw/nvram/fw_cfg: Remove fw_cfg_add_extra_pci_roots()

2024-12-13 Thread Philippe Mathieu-Daudé
Now that all uses of fw_cfg_add_extra_pci_roots() have been converted to the newer pci_bus_add_fw_cfg_extra_pci_roots(), we can remove that bogus method. hw/nvram/fw_cfg must stay generic. Device specific entries have to be implemented using TYPE_FW_CFG_DATA_GENERATOR_INTERFACE. This mostly revert

[PULL 07/20] hw/nvram/fw_cfg: Skip FW_CFG_DATA_GENERATOR when no data to generate

2024-12-13 Thread Philippe Mathieu-Daudé
Allow the FW_CFG_DATA_GENERATOR interface get_data() handler to return NULL when there is nothing to generate. In that case fw_cfg_add_file_from_generator() will not add any item and return %true. Reported-by: Daniel P. Berrangé Reviewed-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Dau

[PULL 10/20] hw: Use pci_bus_add_fw_cfg_extra_pci_roots()

2024-12-13 Thread Philippe Mathieu-Daudé
We want to remove fw_cfg_add_extra_pci_roots() which introduced PCI bus knowledge within the generic hw/nvram/fw_cfg.c file. Replace the calls by the pci_bus_add_fw_cfg_extra_pci_roots() which is a 1:1 equivalent, but using correct API. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P.

[PULL 04/20] hw/riscv/virt: Remove pointless GPEX_HOST() cast

2024-12-13 Thread Philippe Mathieu-Daudé
No need to QOM-cast twice, since the intermediate value is not used. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20241125140535.4526-7-phi...@linaro.org> --- hw/riscv/virt.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a

[PULL 12/20] hw/net/can: clean-up unnecessary includes

2024-12-13 Thread Philippe Mathieu-Daudé
From: Alex Bennée The event_notifier, thread and socket includes look like copy and paste of standard headers. None of the canbus devices use chardev although some relied on chardev to bring in bitops and byte swapping headers. In this case include them directly. Signed-off-by: Alex Bennée Acke

[PULL 01/20] docs/nitro-enclave: Fix terminal commands formatting

2024-12-13 Thread Philippe Mathieu-Daudé
From: Dorjoy Chowdhury Signed-off-by: Dorjoy Chowdhury Reviewed-by: Alexander Graf Message-ID: <20241109122844.24057-1-dorjoychy...@gmail.com> Signed-off-by: Philippe Mathieu-Daudé --- docs/system/i386/nitro-enclave.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PULL 03/20] hw/virtio/virtio-nsm: Support string data for extendPCR

2024-12-13 Thread Philippe Mathieu-Daudé
From: Dorjoy Chowdhury NSM device in AWS Nitro Enclaves supports extending with both bytestring and string data. Signed-off-by: Dorjoy Chowdhury Reviewed-by: Alexander Graf Message-ID: <20241109123208.24281-1-dorjoychy...@gmail.com> Signed-off-by: Philippe Mathieu-Daudé --- hw/virtio/virtio-

[PULL 02/20] hw/core/eif: Use stateful qcrypto apis

2024-12-13 Thread Philippe Mathieu-Daudé
From: Dorjoy Chowdhury We were storing the pointers to buffers in a GList due to lack of stateful crypto apis and instead doing the final hash computation at the end after we had all the necessary buffers. Now that we have the stateful qcrypto apis available, we can instead update the hashes inli

Re: [PATCH v2 0/7] hw/nvram/fw_cfg: Move PCI bus methods out

2024-12-13 Thread Philippe Mathieu-Daudé
On 13/12/24 14:33, Philippe Mathieu-Daudé wrote: Philippe Mathieu-Daudé (7): hw/nvram/fw_cfg: Rename fw_cfg_add_[file]_from_generator() hw/nvram/fw_cfg: Pass QOM parent to fw_cfg_add_file_from_generator() hw/nvram/fw_cfg: Skip FW_CFG_DATA_GENERATOR when no data to generate hw/pci: Ha

Re: [PATCH] MAINTAINERS: correct my email address

2024-12-13 Thread Philippe Mathieu-Daudé
On 13/12/24 20:16, Philippe Mathieu-Daudé wrote: On 9/12/24 19:12, Brian Cain wrote: Mea culpa, I don't know how I got this wrong in 2dfe93699c.  Still getting used to the new address, I suppose.  Somehow I got it right in the mailmap, though. Signed-off-by: Brian Cain ---   MAINTAINERS | 2

[PATCH v2 2/2] s390x/pci: indicate QEMU supports relaxed translation for passthrough

2024-12-13 Thread Matthew Rosato
Specifying this bit in the guest CLP response indicates that the guest can optionally choose to skip translation and instead use identity-mapped operations. Signed-off-by: Matthew Rosato --- hw/s390x/s390-pci-vfio.c| 5 - include/hw/s390x/s390-pci-clp.h | 1 + 2 files changed, 5 inse

[PATCH v2 1/2] s390x/pci: add support for guests that request direct mapping

2024-12-13 Thread Matthew Rosato
When receiving a guest mpcifc(4) or mpcifc(6) instruction without the T bit set, treat this as a request to perform direct mapping instead of address translation. In order to facilitate this, pin the entirety of guest memory into the host iommu. Subsequent guest DMA operations are all expected to

[PATCH v2 0/2] s390x/pci: relax I/O address translation requirement

2024-12-13 Thread Matthew Rosato
This series introduces the concept of the relaxed translation requirement for s390x guests in order to allow bypass of the guest IOMMU for more efficient PCI passthrough. With this series, QEMU can indicate to the guest that an IOMMU is not strictly required for a zPCI device. This would subseque

Re: [PATCH v2] tests/qtest/sse-timer-test: Add watchdog reset to sse-timer test

2024-12-13 Thread Nabih Estefan
Some of the info I was asked for in V1 of the patch: I'm seeing the failure on 2 different machines, the compiler versions are: - gcc version 11.4.0 (Ubuntu 11.4.0-1ubuntu1~22.04) - gcc version 14.2.0 (Debian 14.2.0-3+build3) Both of the outputs below are run on the Debian machine. Output of the

Re: [PATCH 1/2] s390x/pci: add support for guests that request direct mapping

2024-12-13 Thread Matthew Rosato
On 12/10/24 3:58 AM, David Hildenbrand wrote: > Maybe there is a reason s390x needs to handle this using > memory_region_notify_iommu() callbacks instead of doing it similar to "struct > vfio_memory_listener" when registered on &address_space_memory without a > viommu. > Hi David, I think I

[PATCH v2] tests/qtest/sse-timer-test: Add watchdog reset to sse-timer test

2024-12-13 Thread Nabih Estefan
V2: Removed scripts/meson-buildoptions.sh.tmp Extra file that slipped through the cracks and shouldn't be in this patch Recent CDMSK Watchdog changes (eff9dc5660fad3a610171c56a5ec3fada245e519) updated the CDMSK APB Watchdog to not free run out of reset. That led to this test failing since it never

contrib/plugins does not build on 32-bit host

2024-12-13 Thread Richard Henderson
Hi, Several of the recent contrib/plugins/ patches do not build on e.g. arm32. All of the issues are related to casting between pointers and uint64_t; there is a Werror generated for casting between pointers and integers of different sizes. I suspect all of the instances will need to use separ

Re: [PATCH] tests/qtest/sse-timer-test: Add watchdog reset to sse-timer test

2024-12-13 Thread Fabiano Rosas
Nabih Estefan writes: > Recent CDMSK Watchdog changes (eff9dc5660fad3a610171c56a5ec3fada245e519) > updated the CDMSK APB Watchdog to not free run out of reset. That led to > this test failing since it never triggers the watchdog to start running. > No watchdog running means that the timer and cou

Re: [PATCH] include/hw/qdev-properties: Shrink struct Property by 8 bytes

2024-12-13 Thread Richard Henderson
On 12/13/24 15:06, Richard Henderson wrote: Before, via pahole: Bah. s/by 8 bytes// in subject; moved to the summary at the end. Afterward there are no holes in either structure. For arm32, size 48, padding 2, saved 8 bytes. For arm64, size 72, padding 6, saved 16 bytes. Also meant to say,

Re: [PATCH] tests/qtest/sse-timer-test: Add watchdog reset to sse-timer test

2024-12-13 Thread Fabiano Rosas
Nabih Estefan writes: > From what I can tell this is the same issue Thomas was looking at yes. > > I saw the failure on the master branch at the v9.2.0 tag (ae35f033) and just > re-tested it against (83aaec1d) and still see it. I haven't seen it be an > intermittent failure, it has failed 100% of

[PATCH] include/hw/qdev-properties: Shrink struct Property by 8 bytes

2024-12-13 Thread Richard Henderson
Before, via pahole: arm32, a 32-bit host which aligns uint64_t: struct Property { const char * name; /* 0 4 */ const PropertyInfo * info; /* 4 4 */ ptrdiff_t offset; /* 8

Re: [PATCH 32/71] hw/intc: Constify all Property

2024-12-13 Thread Daniel Henrique Barboza
On 12/13/24 4:07 PM, Richard Henderson wrote: Signed-off-by: Richard Henderson --- For all riscv controllers, pnv controllers and spapr_xive: Reviewed-by: Daniel Henrique Barboza hw/intc/apic_common.c | 2 +- hw/intc/arm_gic_common.c | 2 +- hw/intc/arm_gicv2m.c

Re: [PATCH 08/71] target/riscv: Constify all Property

2024-12-13 Thread Daniel Henrique Barboza
On 12/13/24 4:06 PM, Richard Henderson wrote: Signed-off-by: Richard Henderson --- Reviewed-by: Daniel Henrique Barboza target/riscv/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 80b09952e7..4329015076 100644 -

Re: [PATCH 51/71] hw/riscv: Constify all Property

2024-12-13 Thread Daniel Henrique Barboza
On 12/13/24 4:07 PM, Richard Henderson wrote: Signed-off-by: Richard Henderson --- Reviewed-by: Daniel Henrique Barboza hw/riscv/opentitan.c | 2 +- hw/riscv/riscv-iommu-pci.c | 2 +- hw/riscv/riscv-iommu.c | 2 +- hw/riscv/riscv_hart.c | 2 +- hw/riscv/sifive_u.c

Re: [PATCH 0/6] linux-user: Add support for various missing netlink sockopt entries

2024-12-13 Thread Helge Deller
ping for review... On 11/29/24 15:38, del...@kernel.org wrote: From: Helge Deller This patchset adds various missing sockopt calls, so that qemu linux-user is able to successfully build the debian gupnp package in a chroot. Tested with a 32-bit big-endian hppa linux-user chroot running on a p

Re: [PATCH 36/71] hw/m68k: Constify all Property

2024-12-13 Thread Thomas Huth
Am Fri, 13 Dec 2024 13:07:10 -0600 schrieb Richard Henderson : > Signed-off-by: Richard Henderson > --- > hw/m68k/mcf5206.c | 2 +- > hw/m68k/mcf_intc.c | 2 +- > hw/m68k/next-cube.c | 2 +- > hw/m68k/q800-glue.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Thomas

Re: [PATCH] docs/nitro-enclave: Fix terminal commands formatting

2024-12-13 Thread Philippe Mathieu-Daudé
On 9/11/24 13:28, Dorjoy Chowdhury wrote: Signed-off-by: Dorjoy Chowdhury --- docs/system/i386/nitro-enclave.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) Queued, thanks!

[PATCH 23/71] hw/cxl: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/cxl/switch-mailbox-cci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/cxl/switch-mailbox-cci.c b/hw/cxl/switch-mailbox-cci.c index 4f419443ab..3fde0f8aae 100644 --- a/hw/cxl/switch-mailbox-cci.c +++ b/hw/cxl/switch-mailbox-cci.c @@

Re: [PATCH 03/71] target/hexagon: Constify all Property

2024-12-13 Thread Brian Cain
On 12/13/2024 1:06 PM, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/hexagon/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/hexagon/cpu.c b/target/hexagon/cpu.c index c9aa9408ec..a70007245e 100644 --- a/target/hexagon/cpu.c +++ b/targ

Re: [PATCH v2 02/34] next-cube: remove overlap between next.dma and next.mmio memory regions

2024-12-13 Thread Thomas Huth
Hi Mark! Am Thu, 12 Dec 2024 11:45:48 + schrieb Mark Cave-Ayland : > Change the start of the next.mmio memory region so that it follows on directly > after the next.dma memory region. Increase the address offsets in > next_mmio_read() and next_mmio_write(), and reduce the size of the next.

Re: [PATCH 00/71] whole-tree: Constify Property structures

2024-12-13 Thread Philippe Mathieu-Daudé
On 13/12/24 20:06, Richard Henderson wrote: Since d36f165d952 (qdev: make properties array "const"), we can define our Property structure const. Do this across the entire tree. There are a few other minor changes: - Two instances where it was obvious that an empty property list could be

Re: [PATCH 28/71] hw/i2c: Constify all Property

2024-12-13 Thread Corey Minyard
Yeah, a no brainer. Acked-by: Corey Minyard On Fri, Dec 13, 2024 at 01:07:02PM -0600, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > hw/i2c/aspeed_i2c.c | 4 ++-- > hw/i2c/core.c| 2 +- > hw/i2c/i2c_mux_pca954x.c | 2 +- > hw/i2c/omap_i2c.c| 2 +- >

Re: [PATCH 34/71] hw/ipmi: Constify all Property

2024-12-13 Thread Corey Minyard
Acked-by: Corey Minyard On Fri, Dec 13, 2024 at 01:07:08PM -0600, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > hw/ipmi/ipmi.c| 2 +- > hw/ipmi/ipmi_bmc_extern.c | 2 +- > hw/ipmi/ipmi_bmc_sim.c| 2 +- > hw/ipmi/isa_ipmi_bt.c | 2 +- > hw/ipmi/isa_ipmi_

[PULL 4/4] target/sparc: Use memcpy() and remove memcpy32()

2024-12-13 Thread Richard Henderson
From: Philippe Mathieu-Daudé Rather than manually copying each register, use the libc memcpy(), which is well optimized nowadays. Suggested-by: Pierrick Bouvier Reviewed-by: Pierrick Bouvier Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20241205205418.6761

[PATCH 70/71] tests/unit: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tests/unit/test-qdev-global-props.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/test-qdev-global-props.c b/tests/unit/test-qdev-global-props.c index c8862cac5f..1eb95d2429 100644 --- a/tests/unit/test-qdev-global-props.c +++

[PATCH 65/71] hw/vfio: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/vfio/ap.c | 2 +- hw/vfio/ccw.c | 2 +- hw/vfio/pci.c | 4 ++-- hw/vfio/platform.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c index 4013e7b436..2e6ea2dd93 100644 --- a/hw/vfio/ap.c +++

[PATCH 60/71] hw/timer: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/timer/a9gtimer.c | 2 +- hw/timer/allwinner-a10-pit.c | 2 +- hw/timer/arm_mptimer.c | 2 +- hw/timer/arm_timer.c | 2 +- hw/timer/aspeed_timer.c | 2 +- hw/timer/avr_timer16.c | 2 +- hw/timer/grlib_gptimer.c | 2 +- h

[PATCH 64/71] hw/usb: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/usb/bus.c | 2 +- hw/usb/canokey.c | 2 +- hw/usb/ccid-card-emulated.c | 2 +- hw/usb/ccid-card-passthru.c | 2 +- hw/usb/dev-audio.c| 2 +- hw/usb/dev-hid.c | 6 +++--- hw/usb/dev-hub.c

[PATCH 19/71] hw/block: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/block/fdc-isa.c| 2 +- hw/block/fdc-sysbus.c | 4 ++-- hw/block/fdc.c| 2 +- hw/block/m25p80.c | 2 +- hw/block/nand.c | 2 +- hw/block/pflash_cfi01.c | 2 +- hw/block/pflash_cfi02.c | 2 +- hw/block/swim.c

[PATCH 68/71] hw/xen: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/xen/xen-bus.c| 2 +- hw/xen/xen-legacy-backend.c | 4 ++-- hw/xen/xen_pt.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c index 95b207ac8b..0d7defb8cd 100644 --- a/hw/xen/xe

[PATCH 71/71] docs: Constify all Property in examples

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- docs/devel/migration/compatibility.rst | 4 ++-- docs/devel/virtio-backends.rst | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/devel/migration/compatibility.rst b/docs/devel/migration/compatibility.rst index 5a5417ef06..c7

[PATCH 20/71] hw/char: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/char/avr_usart.c | 2 +- hw/char/bcm2835_aux.c | 2 +- hw/char/cadence_uart.c | 2 +- hw/char/cmsdk-apb-uart.c| 2 +- hw/char/debugcon.c | 2 +- hw/char/digic-uart.c| 2 +- hw/char/escc.c | 2 +- hw/char/

[PATCH 67/71] hw/watchdog: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/watchdog/sbsa_gwdt.c | 2 +- hw/watchdog/wdt_aspeed.c | 2 +- hw/watchdog/wdt_imx2.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/watchdog/sbsa_gwdt.c b/hw/watchdog/sbsa_gwdt.c index 80f9b36e79..2e25d4b4e9 100644 --- a/hw/wat

[PATCH 50/71] hw/remote: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/remote/proxy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/remote/proxy.c b/hw/remote/proxy.c index 302a0a4d4d..6f84fdd3fa 100644 --- a/hw/remote/proxy.c +++ b/hw/remote/proxy.c @@ -191,7 +191,7 @@ static void pci_proxy_write_conf

Re: [PATCH] device/virtio-nsm: Support string data for extendPCR

2024-12-13 Thread Philippe Mathieu-Daudé
On 9/11/24 13:32, Dorjoy Chowdhury wrote: NSM device in AWS Nitro Enclaves supports extending with both bytestring and string data. Signed-off-by: Dorjoy Chowdhury --- hw/virtio/virtio-nsm.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) Queued, thanks!

[PATCH 43/71] hw/nvme: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/nvme/ctrl.c | 2 +- hw/nvme/ns.c | 2 +- hw/nvme/subsys.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index ec75419566..33a3062466 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -8927,7 +

[PATCH 39/71] hw/misc/xlnx-versal-trng: Constify trng_props

2024-12-13 Thread Richard Henderson
Use DEFINE_PROP_UNSIGNED instead of DEFINE_PROP_UINT64 so that we can set the PropertyInfo during initialization, instead of updating within trng_class_init. Signed-off-by: Richard Henderson --- hw/misc/xlnx-versal-trng.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/

[PATCH 69/71] hw/xen: Use DEFINE_PROP_END_OF_LIST in xen_sysdev_properties

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/xen/xen-legacy-backend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xen/xen-legacy-backend.c b/hw/xen/xen-legacy-backend.c index b15393e934..f6ad58fe13 100644 --- a/hw/xen/xen-legacy-backend.c +++ b/hw/xen/xen-legacy-backend.c @@

[PATCH 36/71] hw/m68k: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/m68k/mcf5206.c | 2 +- hw/m68k/mcf_intc.c | 2 +- hw/m68k/next-cube.c | 2 +- hw/m68k/q800-glue.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/m68k/mcf5206.c b/hw/m68k/mcf5206.c index 7247cdbe5e..45e5f74600 100644 --- a/hw/m6

Re: [PATCH v14 00/15] macOS PV Graphics and new vmapple machine type

2024-12-13 Thread Phil Dennis-Jordan
Sigh… apologies for re-sending v13 together with v14 here. Please ignore v13 of course. git send-email is not my friend… On Fri, 13 Dec 2024 at 16:24, Phil Dennis-Jordan wrote: > > This patch series has been through months of review and > refinement. It now has end-to-end Reviewed-by: tags and

[PATCH 63/71] hw/ufs: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/ufs/lu.c | 2 +- hw/ufs/ufs.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ufs/lu.c b/hw/ufs/lu.c index 81bfff9b4e..74ff52ad09 100644 --- a/hw/ufs/lu.c +++ b/hw/ufs/lu.c @@ -274,7 +274,7 @@ static UfsReqResult ufs_process_scsi_

Re: [PATCH] tests/qtest/sse-timer-test: Add watchdog reset to sse-timer test

2024-12-13 Thread Nabih Estefan
>From what I can tell this is the same issue Thomas was looking at yes. I saw the failure on the master branch at the v9.2.0 tag (ae35f033) and just re-tested it against (83aaec1d) and still see it. I haven't seen it be an intermittent failure, it has failed 100% of the time that I have tested it

[PATCH 66/71] hw/virtio: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/virtio/vdpa-dev-pci.c | 2 +- hw/virtio/vdpa-dev.c | 2 +- hw/virtio/vhost-scsi-pci.c | 2 +- hw/virtio/vhost-user-blk-pci.c | 2 +- hw/virtio/vhost-user-device.c| 2 +- hw/virtio/vhost-user-fs-pci.c| 2 +- hw/virtio/vhos

[PATCH 51/71] hw/riscv: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/riscv/opentitan.c | 2 +- hw/riscv/riscv-iommu-pci.c | 2 +- hw/riscv/riscv-iommu.c | 2 +- hw/riscv/riscv_hart.c | 2 +- hw/riscv/sifive_u.c| 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/riscv/opentitan.c b

[PATCH 32/71] hw/intc: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/intc/apic_common.c | 2 +- hw/intc/arm_gic_common.c | 2 +- hw/intc/arm_gicv2m.c | 2 +- hw/intc/arm_gicv3_common.c| 2 +- hw/intc/arm_gicv3_its.c | 2 +- hw/intc/arm_gicv3_its_kvm.c | 2 +- hw/intc/armv7m_nvic.c |

[PATCH 01/71] target/arm: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/cpu.c | 26 +- target/arm/cpu64.c | 6 +++--- target/arm/tcg/cpu64.c | 2 +- 3 files changed, 17 insertions(+), 17 deletions(-) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 0cbda76ba0..1afa07511e 100644

[PATCH 42/71] hw/nubus: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/nubus/nubus-bridge.c | 2 +- hw/nubus/nubus-device.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/nubus/nubus-bridge.c b/hw/nubus/nubus-bridge.c index a42c86080f..83893e5a46 100644 --- a/hw/nubus/nubus-bridge.c +++ b/hw/nubus/nu

[PATCH 44/71] hw/nvram: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/nvram/ds1225y.c | 2 +- hw/nvram/eeprom_at24c.c| 2 +- hw/nvram/fw_cfg.c | 6 +++--- hw/nvram/mac_nvram.c | 2 +- hw/nvram/nrf51_nvm.c | 2 +- hw/nvram/spapr_nvram.c | 2 +-

[PATCH 63/71] hw/ufs: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/ufs/lu.c | 2 +- hw/ufs/ufs.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ufs/lu.c b/hw/ufs/lu.c index 81bfff9b4e..74ff52ad09 100644 --- a/hw/ufs/lu.c +++ b/hw/ufs/lu.c @@ -274,7 +274,7 @@ static UfsReqResult ufs_process_scsi_

[PATCH 24/71] hw/display: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/display/artist.c | 2 +- hw/display/ati.c | 2 +- hw/display/bcm2835_fb.c | 2 +- hw/display/bochs-display.c | 2 +- hw/display/cg3.c | 2 +- hw/display/cirrus_vga.c | 2 +- hw/display/cir

Re: [PATCH] MAINTAINERS: correct my email address

2024-12-13 Thread Philippe Mathieu-Daudé
On 9/12/24 19:12, Brian Cain wrote: Mea culpa, I don't know how I got this wrong in 2dfe93699c. Still getting used to the new address, I suppose. Somehow I got it right in the mailmap, though. Signed-off-by: Brian Cain --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 59/71] hw/ssi: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/ssi/aspeed_smc.c | 4 ++-- hw/ssi/ibex_spi_host.c| 2 +- hw/ssi/npcm7xx_fiu.c | 2 +- hw/ssi/pnv_spi.c | 2 +- hw/ssi/sifive_spi.c | 2 +- hw/ssi/ssi.c | 2 +- hw/ssi/xilinx_spi.c | 2 +- hw/ssi/xilinx_spips.

[PATCH 46/71] hw/pci-host/astro: Remove empty Property list

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/pci-host/astro.c | 5 - 1 file changed, 5 deletions(-) diff --git a/hw/pci-host/astro.c b/hw/pci-host/astro.c index 379095b356..62e9c8acbf 100644 --- a/hw/pci-host/astro.c +++ b/hw/pci-host/astro.c @@ -461,10 +461,6 @@ static void elroy_pcihost_init(Ob

[PATCH 27/71] hw/hyperv: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/hyperv/hv-balloon.c | 2 +- hw/hyperv/syndbg.c | 2 +- hw/hyperv/vmbus.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/hyperv/hv-balloon.c b/hw/hyperv/hv-balloon.c index 3a9ef07691..74897b1604 100644 --- a/hw/hyperv/hv

[PATCH 12/71] hw/9pfs: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/9pfs/virtio-9p-device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c index efa41cfd73..b764e4cd3d 100644 --- a/hw/9pfs/virtio-9p-device.c +++ b/hw/9pfs/virtio-9p-device.c @@ -243

[PATCH 40/71] hw/misc: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/misc/a9scu.c | 2 +- hw/misc/allwinner-h3-dramc.c | 2 +- hw/misc/allwinner-r40-dramc.c| 2 +- hw/misc/allwinner-sid.c | 2 +- hw/misc/applesmc.c | 2 +- hw/misc/arm11scu.c | 2 +- hw/misc/arm_l2

[PATCH 03/71] target/hexagon: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hexagon/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/hexagon/cpu.c b/target/hexagon/cpu.c index c9aa9408ec..a70007245e 100644 --- a/target/hexagon/cpu.c +++ b/target/hexagon/cpu.c @@ -48,7 +48,7 @@ static ObjectClass

[PATCH 52/71] hw/rtc: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/rtc/allwinner-rtc.c | 2 +- hw/rtc/goldfish_rtc.c | 2 +- hw/rtc/m48t59-isa.c| 2 +- hw/rtc/m48t59.c| 2 +- hw/rtc/mc146818rtc.c | 2 +- hw/rtc/pl031.c | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/rtc/allw

Re: [PATCH] hw/intc/arm_gicv3_its: Zero initialize local DTEntry etc structs

2024-12-13 Thread Philippe Mathieu-Daudé
On 13/12/24 19:23, Peter Maydell wrote: In the GICv3 ITS model, we have a common coding pattern which has a local C struct like "DTEntry dte", which is a C representation of an in-guest-memory data structure, and we call a function such as get_dte() to read guest memory and fill in the C struct.

[PATCH 57/71] hw/sparc: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/sparc/sun4m.c | 2 +- hw/sparc/sun4m_iommu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c index d52e6a7213..b8cce271a7 100644 --- a/hw/sparc/sun4m.c +++ b/hw/sparc/sun4m.c @@ -732,7 +732,7

[PATCH 45/71] hw/pci-bridge: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/pci-bridge/cxl_downstream.c | 2 +- hw/pci-bridge/cxl_root_port.c | 2 +- hw/pci-bridge/cxl_upstream.c| 2 +- hw/pci-bridge/gen_pcie_root_port.c | 2 +- hw/pci-bridge/pci_bridge_dev.c | 2 +- hw/pci-bridge/pci_expander_bridge.c | 4

[PULL 2/4] tcg/riscv: Fix StoreStore barrier generation

2024-12-13 Thread Richard Henderson
From: Roman Artemev On RISC-V to StoreStore barrier corresponds `fence w, w` not `fence r, r` Cc: qemu-sta...@nongnu.org Fixes: efbea94c76b ("tcg/riscv: Add slowpath load and store instructions") Reviewed-by: Richard Henderson Signed-off-by: Denis Tomashev Signed-off-by: Roman Artemev Message

  1   2   3   4   >