Re: [PATCH 0/2] Misc OpenRISC fixes for 9.2.0

2024-11-23 Thread Stafford Horne
On Sun, Nov 24, 2024 at 08:03:53AM +0300, Michael Tokarev wrote: > 23.11.2024 20:01, Stafford Horne wrote: > > On Sat, Nov 23, 2024 at 03:12:12PM +0300, Michael Tokarev wrote: > > > On 23.11.2024 13:38, Stafford Horne wrote: > > > > This series has 2 fixes for OpenRISC that came in over that past f

Re: QEMU commit 0a923be2f642 broke my or1k image.

2024-11-23 Thread Stafford Horne
On Sat, Nov 23, 2024 at 11:18:53PM -0600, Rob Landley wrote: ... > I'm attempting to regression test as many targets as I can to get consistent > basic behavior out of: > > https://landley.net/bin/mkroot/0.8.11/ > > I'm trying to get a new release out with the 6.12 kernel which is why I'm > rev

Re: QEMU commit 0a923be2f642 broke my or1k image.

2024-11-23 Thread Rob Landley
On 11/23/24 02:28, Stafford Horne wrote: Just a guess, but given the alignment change, I suspect it's barfing on the statically linked initramfs? That seems the most likely step to go off the rails given the failing patch is a symbol alignment change in the flattened device tree plumbing, and I t

Re: [PATCH 0/2] Misc OpenRISC fixes for 9.2.0

2024-11-23 Thread Michael Tokarev
23.11.2024 20:01, Stafford Horne wrote: On Sat, Nov 23, 2024 at 03:12:12PM +0300, Michael Tokarev wrote: On 23.11.2024 13:38, Stafford Horne wrote: This series has 2 fixes for OpenRISC that came in over that past few months. Ahmad Fatoum (1): hw/openrisc/openrisc_sim: keep serial@9000

Re: [PATCH] system/physmem: Fix cpu_memory_rw_debug for armv7m MPU

2024-11-23 Thread xndcn
Thanks. This patch at least guarantees normal read/write access to addresses with r/w flags, although there is still a risk of misidentifying accessible regions within continuous address spaces. Actually, initially I did write a patch with a modified page size as an argument, but I soon found that

Re: QEMU patches for native windows support through clang-cl

2024-11-23 Thread Pierrick Bouvier
Hi, On 11/21/24 13:42, Erwin Jansen wrote: Would a good next step be to work out some more details in a document that outlines what process we are using, what we are planning to do and include a set of suggestions as a starting point to see if we can upstream some of the changes to the larger

Supporting clang on windows

2024-11-23 Thread Pierrick Bouvier
Hi all, very recently, I've been working on enabling clang builds on Windows [1]. As part of it, the major blocking point is that currently, clang does not support gcc_attribute on Windows. The change proposed [2] was to use the compiler option [3] -mno-ms-bitfields, which enables the same beh

Re: [PATCH 2/2] hw/openrisc: Fixed undercounting of TTCR in continuous mode

2024-11-23 Thread Richard Henderson
On 11/23/24 11:11, Stafford Horne wrote: On Sat, Nov 23, 2024 at 07:39:57AM -0600, Richard Henderson wrote: On 11/23/24 04:38, Stafford Horne wrote: +or1k_timer->ttcr = or1k_timer->ttcr_offset + +(now - or1k_timer->clk_offset + TIMER_PERIOD - 1) / TIMER_PERIOD; Better using DIV_RO

Re: [PULL 1/2] linux-user: Print tid not pid with strace

2024-11-23 Thread J . Neuschäfer
On Sat, Nov 23, 2024 at 09:07:05AM -0600, Richard Henderson wrote: > From: J. Neuschäfer > > This aligns with strace, and is very useful when tracing multi-threaded > programs. The result is the same in single-threaded programs. > > Signed-off-by: J. Neuschäfer > Message-Id: 20241024-strace-v1-1-

Re: Re: [RFC PATCH v1 0/1] Add helper_print functions for printing intermediate results of complex instructions in RISC-V target

2024-11-23 Thread Chao Liu
Currently, the v1-patch is not yet capable of achieving the desired effect. It still requires passing the number of variable arguments to the helper_print() function: static bool gen_lr(DisasContext *ctx, arg_atomic *a, MemOp mop) { TCGv src1; decode_save_opc(ctx, 0);

Re: [RFC PATCH v1 0/1] Add helper_print functions for printing intermediate results of complex instructions in RISC-V target

2024-11-23 Thread Chao Liu
For example: static bool gen_lr(DisasContext *ctx, arg_atomic *a, MemOp mop) { TCGv src1; decode_save_opc(ctx, 0); src1 = get_address(ctx, a->rs1, 0); gen_helper_print("src1 %x\n", src1); ... return true; } When the TCG executes instruc

[RFC PATCH v1 0/1] Add helper_print functions for printing intermediate results of complex instructions in RISC-V target

2024-11-23 Thread Chao Liu
Hi all, Recently, I have been working on functional simulation and verification of an extended complex instruction set for an AI chip based on the RISC-V architecture using QEMU. Given the complexity of some instructions, I attempted to introduce a set of helper functions that can print certain i

[RFC PATCH v1 1/1] riscv: Add helper_print() for printing intermediate results of IR

2024-11-23 Thread Chao Liu
Signed-off-by: Chao Liu --- target/riscv/helper.h| 13 target/riscv/op_helper.c | 46 2 files changed, 59 insertions(+) diff --git a/target/riscv/helper.h b/target/riscv/helper.h index 451261ce5a..667da16988 100644 --- a/target/riscv/help

Re: [PATCH 2/2] hw/openrisc: Fixed undercounting of TTCR in continuous mode

2024-11-23 Thread Stafford Horne
On Sat, Nov 23, 2024 at 07:39:57AM -0600, Richard Henderson wrote: > On 11/23/24 04:38, Stafford Horne wrote: > > +or1k_timer->ttcr = or1k_timer->ttcr_offset + > > +(now - or1k_timer->clk_offset + TIMER_PERIOD - 1) / TIMER_PERIOD; > > Better using DIV_ROUND_UP. Sure, I can change it t

Re: [PATCH 0/2] Misc OpenRISC fixes for 9.2.0

2024-11-23 Thread Stafford Horne
On Sat, Nov 23, 2024 at 03:12:12PM +0300, Michael Tokarev wrote: > On 23.11.2024 13:38, Stafford Horne wrote: > > This series has 2 fixes for OpenRISC that came in over that past few months. > > > > Ahmad Fatoum (1): > >hw/openrisc/openrisc_sim: keep serial@9000 as default > > > > Joel Ho

[PATCH 0/1] Update email addr

2024-11-23 Thread Brian Cain
For reviewers: note also that I have signed a tag with my GPG key fingerprint 635020F967A7716479EF49E0175C464E541B6D47 that has had this new uid added to it. See https://github.com/quic/qemu/tree/bcain-email-addr-update-oss.qualcomm.com and https://github.com/quic/qemu/releases/tag/bcain-email-ad

[PATCH 1/1] MAINTAINERS: update email addr for Brian Cain

2024-11-23 Thread Brian Cain
From: Brian Cain Also: add mapping for "quic_bc...@quicinc.com" which was ~briefly used for some replies to mailing list traffic. Signed-off-by: Brian Cain Signed-off-by: Brian Cain --- .mailmap| 2 ++ MAINTAINERS | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.mail

Re: [PATCH 00/39] maintainer updates for -rc2 pre-PR

2024-11-23 Thread Alex Bennée
Thomas Huth writes: > On 21/11/2024 18.31, Alex Bennée wrote: >> Peter Maydell writes: >> >>> On Thu, 21 Nov 2024 at 16:58, Alex Bennée wrote: This is a mostly testing focused set of patches but a few bug fixes as well. I plan to send the PR in on Monday. I can drop any patches

[PULL 0/2] linux-user patch queue

2024-11-23 Thread Richard Henderson
The following changes since commit 34754a3a627e1937be7f3daaa0c5e73d91c7d9b5: Update version for v9.2.0-rc1 release (2024-11-20 18:27:48 +) are available in the Git repository at: https://gitlab.com/rth7680/qemu.git tags/pull-lu-20241122 for you to fetch changes up to d95fd9838b540e69da9

[PULL 1/2] linux-user: Print tid not pid with strace

2024-11-23 Thread Richard Henderson
From: J. Neuschäfer This aligns with strace, and is very useful when tracing multi-threaded programs. The result is the same in single-threaded programs. Signed-off-by: J. Neuschäfer Message-Id: 20241024-strace-v1-1-56c416143...@gmx.net [rth: Use TaskState.ts_tid via get_task_state()] Signed-of

[PULL 2/2] linux-user: Fix strace output for s390x mmap()

2024-11-23 Thread Richard Henderson
From: Ilya Leoshkevich print_mmap() assumes that mmap() receives arguments via memory if mmap2() is present. s390x (as opposed to s390) does not fit this pattern: it does not have mmap2(), but mmap() still receives arguments via memory. Fix by sharing the detection logic between syscall.c and st

Re: [PATCH 07/12] docs/system/arm/fby35: update link to product page

2024-11-23 Thread Richard Henderson
On 11/22/24 16:50, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- docs/system/arm/fby35.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~ diff --git a/docs/system/arm/fby35.rst b/docs/system/arm/fby35.rst index 742b887d44c..bf6da6b

Re: [PATCH 05/12] docs/system/arm/: add FEAT_MTE_ASYNC

2024-11-23 Thread Richard Henderson
On 11/22/24 16:50, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- docs/system/arm/emulation.rst | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Richard Henderson diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst index 50d0250b1eb..47f5123a31d 100

Re: [PATCH 04/12] target/arm/tcg/: fix typo in FEAT name

2024-11-23 Thread Richard Henderson
On 11/22/24 16:50, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- target/arm/tcg/cpu32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Oops. :-) Reviewed-by: Richard Henderson diff --git a/target/arm/tcg/cpu32.c b/target/arm/tcg/cpu32.c index 20c2737f17b..4e589b74

Re: [PATCH 03/12] docs/system/arm/emulation: add FEAT_SSBS2

2024-11-23 Thread Richard Henderson
On 11/22/24 16:50, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- docs/system/arm/emulation.rst | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Richard Henderson diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst index af613b9c8b8..50d0250b1eb 10

Re: [PATCH 02/12] docs/system/arm/emulation: fix typo in feature name

2024-11-23 Thread Richard Henderson
On 11/22/24 16:50, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- docs/system/arm/emulation.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst index 2956c22a1b7

Re: [PATCH 01/12] docs/system/arm/emulation: mention armv9

2024-11-23 Thread Richard Henderson
On 11/22/24 16:50, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- docs/system/arm/emulation.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~ diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst index a2a

Re: [PATCH 2/2] hw/openrisc: Fixed undercounting of TTCR in continuous mode

2024-11-23 Thread Richard Henderson
On 11/23/24 04:38, Stafford Horne wrote: +or1k_timer->ttcr = or1k_timer->ttcr_offset + +(now - or1k_timer->clk_offset + TIMER_PERIOD - 1) / TIMER_PERIOD; Better using DIV_ROUND_UP. +/* Zero the count by applying a negative offset to the counter */ +or1k_timer->ttcr

Re: [PATCH 0/2] Misc OpenRISC fixes for 9.2.0

2024-11-23 Thread Michael Tokarev
On 23.11.2024 13:38, Stafford Horne wrote: This series has 2 fixes for OpenRISC that came in over that past few months. Ahmad Fatoum (1): hw/openrisc/openrisc_sim: keep serial@9000 as default Joel Holdsworth (1): hw/openrisc: Fixed undercounting of TTCR in continuous mode Is there a

[PATCH 2/2] hw/openrisc: Fixed undercounting of TTCR in continuous mode

2024-11-23 Thread Stafford Horne
From: Joel Holdsworth In the existing design, TTCR is prone to undercounting when running in continuous mode. This manifests as a timer interrupt appearing to trigger a few cycles prior to the deadline set in SPR_TTMR_TP. When the timer triggers, the virtual time delta in nanoseconds between the

[PATCH 0/2] Misc OpenRISC fixes for 9.2.0

2024-11-23 Thread Stafford Horne
This series has 2 fixes for OpenRISC that came in over that past few months. Ahmad Fatoum (1): hw/openrisc/openrisc_sim: keep serial@9000 as default Joel Holdsworth (1): hw/openrisc: Fixed undercounting of TTCR in continuous mode hw/openrisc/cputimer.c | 26 +++--

[PATCH 1/2] hw/openrisc/openrisc_sim: keep serial@90000000 as default

2024-11-23 Thread Stafford Horne
From: Ahmad Fatoum We used to only have a single UART on the platform and it was located at address 0x9000. When the number of UARTs was increased to 4, the first UART remained at it's location, but instead of being the first one to be registered, it became the last. This caused QEMU to pick

RE: [PATCH] hw/virtio: Fix getting the correct ring number on loading

2024-11-23 Thread Wafer
> -Original Message- > From: Philippe Mathieu-Daudé > Sent: 2024年11月22日 15:02 > To: Wafer ; m...@redhat.com; > jasow...@redhat.com; gr...@kaod.org > Cc: epere...@redhat.com; qemu-devel@nongnu.org; Angus Chen > > Subject: Re: [PATCH] hw/virtio: Fix getting the correct ring number on load

Re: QEMU commit 0a923be2f642 broke my or1k image.

2024-11-23 Thread Stafford Horne
On Fri, Nov 22, 2024 at 06:54:21PM -0600, Rob Landley wrote: > On 11/22/24 10:35, Stafford Horne wrote: > > > I just regression tested linux-6.12 against qemu-9.2.0-rc1 and I'm still > > > getting no output from or1k, with the current image or the old or1k > > > release > > > image that worked und