Re: [PATCH v2] rust/pl011: Fix DeviceID reads

2024-11-16 Thread Paolo Bonzini
Il sab 16 nov 2024, 23:18 Manos Pitsidianakis < manos.pitsidiana...@linaro.org> ha scritto: > -const PL011_ID_ARM: [c_uchar; 8] = [0x11, 0x10, 0x14, 0x00, 0x0d, > 0xf0, 0x05, 0xb1]; > -const PL011_ID_LUMINARY: [c_uchar; 8] = [0x11, 0x00, 0x18, 0x01, > 0x0d, 0xf0, 0x05, 0xb1]; > +/// Va

[PATCH v2] rust/pl011: Fix DeviceID reads

2024-11-16 Thread Manos Pitsidianakis
DeviceId, which maps the peripheral and PCell registers of a PL011 device, was not treating each register value as a 32 bit value. Change DeviceId enum to return register values via constified getter functions instead of leveraging the std::ops::Index<_> trait. While at it, print errors when gues

[PATCH RISU] risugen/aarch64: FCMP*Z* require rm == 0

2024-11-16 Thread Richard Henderson
Do not generate rm other than 0, as it is UNPREDICTABLE whether the instruction will trap as invalid. Signed-off-by: Richard Henderson --- aarch64.risu | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/aarch64.risu b/aarch64.risu index 87d9c72..bfea659 100644 --- a/aarc

Re: [PATCH 1/6] linux-user: Honor elf alignment when placing images

2024-11-16 Thread Michael Tokarev
12.11.2024 23:37, Richard Henderson wrote: Most binaries don't actually depend on more than page alignment, but any binary can request it. Not honoring this was a bug. This became obvious when gdb reported Failed to read a valid object file image from memory when examining some vdso whic

Re: [PATCH v3 1/2] target/i386: fix hang when using slow path for ptw_setl

2024-11-16 Thread Michael Tokarev
25.10.2024 20:58, Pierrick Bouvier wrote: When instrumenting memory accesses for plugin, we force memory accesses to use the slow path for mmu [1]. This create a situation where we end up calling ptw_setl_slow. This was fixed recently in [2] but the issue still could appear out of plugins use cas

Ping: [PATCH v3] net/vmnet: Pad short Ethernet frames

2024-11-16 Thread William Hooper
On Sat, Nov 2, 2024 at 1:56 PM William Hooper wrote: > At least on macOS 12.7.2, vmnet doesn't pad Ethernet frames, such as the > host's ARP replies, to the minimum size (60 bytes before the frame check > sequence) defined in IEEE Std 802.3-2022, so guests' Ethernet device > drivers may drop them

Re: [PATCH v1] rust/pl011: Fix DeviceID reads

2024-11-16 Thread Manos Pitsidianakis
On Sat, Nov 16, 2024 at 10:24 PM Paolo Bonzini wrote: > > On 11/16/24 19:15, Manos Pitsidianakis wrote: > > impl DeviceId { > > -const PL011_ID_ARM: [c_uchar; 8] = [0x11, 0x10, 0x14, 0x00, 0x0d, > > 0xf0, 0x05, 0xb1]; > > -const PL011_ID_LUMINARY: [c_uchar; 8] = [0x11, 0x00, 0x18, 0x01,

Re: [PATCH v1] rust/pl011: Fix DeviceID reads

2024-11-16 Thread Peter Maydell
On Sat, 16 Nov 2024 at 20:24, Paolo Bonzini wrote: > > On 11/16/24 19:15, Manos Pitsidianakis wrote: > > match RegisterOffset::try_from(offset) { > > +Ok(PeriphID0) | Ok(PeriphID1) | Ok(PeriphID2) | Ok(PeriphID3) > > | Ok(PCellID0) > > +| Ok(PCellID1) | Ok(PCellI

Re: [PULL v2 00/15] tcg + linux-user patch queue

2024-11-16 Thread Peter Maydell
he following changes since commit 43f2def68476697deb0d119cbae51b20019c6c86: > > Merge tag 'migration-20241113-pull-request' of > https://gitlab.com/peterx/qemu into staging (2024-11-15 14:53:36 +) > > are available in the Git repository at: > > https://gitlab.com/rth7680/qe

Re: [PATCH v1] rust/pl011: Fix DeviceID reads

2024-11-16 Thread Paolo Bonzini
On 11/16/24 19:15, Manos Pitsidianakis wrote: impl DeviceId { -const PL011_ID_ARM: [c_uchar; 8] = [0x11, 0x10, 0x14, 0x00, 0x0d, 0xf0, 0x05, 0xb1]; -const PL011_ID_LUMINARY: [c_uchar; 8] = [0x11, 0x00, 0x18, 0x01, 0x0d, 0xf0, 0x05, 0xb1]; +/// Value of `UARTPeriphID0` register, wh

[PATCH v1] rust/pl011: Fix DeviceID reads

2024-11-16 Thread Manos Pitsidianakis
DeviceId, which maps the peripheral and PCell registers of a PL011 device, was not treating each register value as a 32 bit value. Change DeviceId enum to return register values via constified getter functions instead of leveraging the std::ops::Index<_> trait. Signed-off-by: Manos Pitsidianakis

[PULL v2 00/15] tcg + linux-user patch queue

2024-11-16 Thread Richard Henderson
; of https://gitlab.com/peterx/qemu into staging (2024-11-15 14:53:36 +) are available in the Git repository at: https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20241116 for you to fetch changes up to 8377e3fb854d126ba10e61cb6b60885af8443ad4: tcg: Allow top bit of SIMD_DATA_BITS to be set in

[PULL v2 02/15] target/arm: Drop user-only special case in sve_stN_r

2024-11-16 Thread Richard Henderson
This path is reachable with plugins enabled, and provoked with run-plugin-catch-syscalls-with-libinline.so. Cc: qemu-sta...@nongnu.org Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-ID: <20241112141232.321354-1-richard.hender...@linaro.org> --- target/arm/tcg/sve_helper.c |

Re: [PULL 00/14] tcg + linux-user patch queue

2024-11-16 Thread Richard Henderson
On 11/16/24 02:39, Peter Maydell wrote: cpu: ensure we don't call start_exclusive from cpu_exec tcg: Allow top bit of SIMD_DATA_BITS to be set in simd_desc() accel/tcg: Fix user-only probe_access_internal plugin check linux-user: Fix setreuid and setregid to use direct syscalls linux-user: Tolera

Re: [PATCH] vdpa: Support setting vring_base for packed svq

2024-11-16 Thread Sahil Siddiq
Hi, On 11/14/24 12:28 PM, Michael S. Tsirkin wrote: On Mon, Nov 04, 2024 at 09:51:24PM +0530, Sahil Siddiq wrote: Linux commit v5.14-rc1~30^2~8 enabled the vp_vdpa driver to set the vq state to the device's initial state. This works differently for split and packed vqs. With shadow virtqueues

Re: [PULL 00/14] tcg + linux-user patch queue

2024-11-16 Thread Peter Maydell
On Fri, 15 Nov 2024 at 20:59, Richard Henderson wrote: > > The following changes since commit f0a5a31c33a8109061c2493e475c8a2f4d022432: > > Update version for v9.2.0-rc0 release (2024-11-13 21:44:45 +) > > are available in the Git repository at: > > https://gitlab.com/rth7680/qemu.git tags