Re: [PATCH] virtio/vhost-user: fix qemu crash when hotunplug vhost-user-net device

I am very sorry that my previous description was not accurate. Below I will describe the steps to reproduce this problem and my analysis in detail.The conditions for reproducing this problem are quite demanding. First, let me introduce my environment. I use DPDK vdpa to drive DPU to implement a vho

Re: [PATCH v9 09/10] hw/nvme: add reservation protocal command

On Jul 12 10:36, Changqi Lu wrote: > Add reservation acquire, reservation register, > reservation release and reservation report commands > in the nvme device layer. > > By introducing these commands, this enables the nvme > device to perform reservation-related tasks, including > querying keys, q

Re: [PATCH 0/2] chardev: fixes for recent record/replay on muxed

Hi On Wed, Aug 28, 2024 at 8:34 AM Nicholas Piggin wrote: > Fix a couple of issues that Peter found with recent record/replay > fix for muxed device. > > Thanks, > Nick > > Nicholas Piggin (2): > chardev: Fix record/replay error path NULL deref in device creation > chardev: Remove __-prefixe

[PATCH 1/1] plugins: add API to read guest CPU memory from hwaddr

Signed-off-by: Rowan Hart --- include/qemu/qemu-plugin.h | 22 ++ plugins/api.c| 17 + plugins/qemu-plugins.symbols | 2 ++ 3 files changed, 41 insertions(+) diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h index c71c705b

[PATCH 0/1] plugins: add API to read guest CPU memory from hwaddr

This patch adds a single API function which allows reading from a guest CPU physical address. I don't know of a good way to add a self-contained test for this feature to tests/tcg/plugins, but I did come up with a small test case to demonstrate the functionality using peiyuanix/riscv-os: First, g

Re: [External] Re: [PATCH v9 09/10] hw/nvme: add reservation protocal command

Hi, Thanks for your advice. Previously, g_malloc0 was used, but a segmentation fault occurred during testing. Later, debugging revealed that a field in struct NvmeReservationStatusExt, struct NvmeRegisteredCtrlExt regctl_eds[], was a variable-length array. Therefore, g_malloc was used to apply aft

Re: [PATCH v4 1/2] kvm: replace fprintf with error_report/printf() in kvm_init()

Ani Sinha writes: > error_report() is more appropriate for error situations. Replace fprintf with > error_report. Cosmetic. No functional change. > > CC: qemu-triv...@nongnu.org > CC: zhao1@intel.com > CC: arm...@redhat.com > Reviewed-by: Zhao Liu > Signed-off-by: Ani Sinha > --- > accel/k

Re: [PATCH v9 09/10] hw/nvme: add reservation protocal command

On Jul 12 10:36, Changqi Lu wrote: > Add reservation acquire, reservation register, > reservation release and reservation report commands > in the nvme device layer. > > By introducing these commands, this enables the nvme > device to perform reservation-related tasks, including > querying keys, q

Re: [External] Re: [PATCH v9 09/10] hw/nvme: add reservation protocal command

On Jul 26 05:54, 卢长奇 wrote: > Hi; > > You can test it in spdk. > First start spdk and execute the following command. > > ``` > dd if=/dev/zero of=test.img bs=1G count=10 > RPC=/root/source/spdk/spdk/scripts/rpc.py > FILE=/root/test.img > > $RPC bdev_aio_create $FILE aio0 512 > $RPC iscsi_create_

Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion

On 2024/08/28 1:11, Peter Xu wrote: On Tue, Aug 27, 2024 at 01:14:51PM +0900, Akihiko Odaki wrote: On 2024/08/27 4:42, Peter Xu wrote: On Mon, Aug 26, 2024 at 06:10:25PM +0100, Peter Maydell wrote: On Mon, 26 Aug 2024 at 16:22, Peter Xu wrote: On Fri, Aug 23, 2024 at 03:13:11PM +0900, Akihi

Re: [PATCH v4 2/2] kvm: refactor core virtual machine creation into its own function

Ani Sinha writes: > On Tue, 27 Aug, 2024, 8:59 pm Peter Maydell, > wrote: > >> On Tue, 27 Aug 2024 at 16:11, Ani Sinha wrote: >> > >> > Refactoring the core logic around KVM_CREATE_VM into its own separate >> function >> > so that it can be called from other functions in subsequent patches. >>

[PATCH 0/2] chardev: fixes for recent record/replay on muxed

Fix a couple of issues that Peter found with recent record/replay fix for muxed device. Thanks, Nick Nicholas Piggin (2): chardev: Fix record/replay error path NULL deref in device creation chardev: Remove __-prefixed names chardev/char.c | 22 -- 1 file changed, 12 inse

[PATCH 1/2] chardev: Fix record/replay error path NULL deref in device creation

qemu_chardev_set_replay() was being called in chardev creation to set up replay parameters even if the chardev is NULL. A segfault can be reproduced by specifying '-serial chardev:bad' with an rr=record mode. Fix this with a NULL pointer check. Reported-by: Peter Maydell Resolves: Coverity CID

[PATCH 2/2] chardev: Remove __-prefixed names

Peter points out double underscore prefix names tend to be reserved for the system. Clean these up. Suggested-by: Peter Maydell Signed-off-by: Nicholas Piggin --- chardev/char.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/chardev/char.c b/chardev/ch

[PATCH RESEND v9 2/9] build-sys: Add rust feature option

Add rust feature in meson.build, configure, to prepare for adding Rust code in the followup commits. Signed-off-by: Manos Pitsidianakis --- MAINTAINERS | 5 + meson.build | 25 - Kconfig | 1 + Kconfig.host

[PATCH RESEND v9 5/9] .gitattributes: add Rust diff and merge attributes

Set rust source code to diff=rust (built-in with new git versions) and merge=binary for Cargo.lock files (they should not be merged but auto-generated by cargo) Reviewed-by: Alex Bennée Reviewed-by: Zhao Liu Signed-off-by: Manos Pitsidianakis --- .gitattributes | 3 +++ 1 file changed, 3 inser

[PATCH RESEND v9 8/9] rust: add utility procedural macro crate

This commit adds a helper crate library, qemu-api-macros for derive (and other procedural) macros to be used along qemu-api. It needs to be a separate library because in Rust, procedural macros, or macros that can generate arbitrary code, need to be special separate compilation units. Only one ma

[PATCH RESEND v9 9/9] rust: add PL011 device model

This commit adds a re-implementation of hw/char/pl011.c in Rust. How to build: 1. Configure a QEMU build with: --enable-system --target-list=aarch64-softmmu --enable-rust 2. Launching a VM with qemu-system-aarch64 should use the Rust version of the pl011 device Co-authored-by: Junjie Mao

[PATCH RESEND v9 3/9] configure, meson: detect Rust toolchain

From: Paolo Bonzini Include the correct path and arguments to rustc in the native and cross files (native compilation is needed for procedural macros). Signed-off-by: Paolo Bonzini --- configure | 50 -- meson.build | 8 +++- 2 files chang

[PATCH RESEND v9 6/9] meson.build: add HAVE_GLIB_WITH_ALIGNED_ALLOC flag

Rust crates, introduced from the next commit onwards, use the glib allocator API and need to know whether g_aligned_alloc etc are available. This commit adds a define in config_host_data that depends on glib version >= 2.72. Signed-off-by: Manos Pitsidianakis --- meson.build | 4 1 file ch

[PATCH RESEND v9 4/9] rust: add bindgen step as a meson dependency

Add bindings_rs target for generating rust bindings to target-independent qemu C APIs. The bindings need be created before any rust crate that uses them is compiled. The bindings.rs file will end up in BUILDDIR/bindings.rs and have the same name as a target: ninja bindings.rs Signed-off-by: P

[PATCH RESEND v9 7/9] rust: add crate to expose bindings and interfaces

Add rust/qemu-api, which exposes rust-bindgen generated FFI bindings and provides some declaration macros for symbols visible to the rest of QEMU. Co-authored-by: Junjie Mao Co-authored-by: Paolo Bonzini Signed-off-by: Junjie Mao Signed-off-by: Paolo Bonzini Signed-off-by: Manos Pitsidianakis

[PATCH RESEND v9 0/9] Add Rust build support, ARM PL011 device impl

Hello everyone, This series adds: - build system support for the Rust compiler - a small Rust library, qemu-api, which includes bindings to QEMU's C interface generated with bindgen, and qemu-api-macros, a procedural macro library. - a proof of concept ARM PL011 device implementation in Rust,

[PATCH] hw/arm/xilinx_zynq: Enable Security Extensions

The system supports the Security Extensions (core and GIC). This change is necessary to run tests which pass on the real hardware. Signed-off-by: Sebastian Huber --- hw/arm/xilinx_zynq.c | 8 1 file changed, 8 deletions(-) diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c index

Re: [PATCH v10 02/21] linux-user/riscv: set priv for qemu-user and defaults for *envcfg

On Wed, Aug 28, 2024 at 10:10:44AM +1000, Alistair Francis wrote: On Wed, Aug 28, 2024 at 9:20 AM Deepak Gupta wrote: set priv to be PRV_U for qemu-user on riscv. And set default value for *envcfg CSR. Signed-off-by: Deepak Gupta You can probably just squash this with the previous patch

Re: [PATCH v10 00/21] riscv support for control flow integrity extensions

On Wed, Aug 28, 2024 at 10:04 AM Deepak Gupta wrote: > > On Wed, Aug 28, 2024 at 10:02:42AM +1000, Alistair Francis wrote: > >On Wed, Aug 28, 2024 at 9:21 AM Deepak Gupta wrote: > >> > >> v10 for riscv zicfilp and zicfiss extensions support in qemu. > > > >Please specify the exact version of the

Re: [PATCH v10 02/21] linux-user/riscv: set priv for qemu-user and defaults for *envcfg

On Wed, Aug 28, 2024 at 9:20 AM Deepak Gupta wrote: > > set priv to be PRV_U for qemu-user on riscv. And set default value for > *envcfg CSR. > > Signed-off-by: Deepak Gupta You can probably just squash this with the previous patch > --- > linux-user/riscv/cpu_loop.c | 4 > 1 file changed

Re: [PATCH v10 01/21] target/riscv: expose *envcfg csr and priv to qemu-user as well

On Wed, Aug 28, 2024 at 9:21 AM Deepak Gupta wrote: > > Execution environment config CSR controlling user env and current > privilege state shouldn't be limited to qemu-system only. *envcfg > CSRs control enabling of features in next lesser mode. In some cases > bits *envcfg CSR can be lit up by k

Re: [PATCH v10 00/21] riscv support for control flow integrity extensions

On Wed, Aug 28, 2024 at 10:02:42AM +1000, Alistair Francis wrote: On Wed, Aug 28, 2024 at 9:21 AM Deepak Gupta wrote: v10 for riscv zicfilp and zicfiss extensions support in qemu. Please specify the exact version of the spec you used https://github.com/riscv/riscv-cfi/releases/download/v1.

Re: [PATCH v10 00/21] riscv support for control flow integrity extensions

On Wed, Aug 28, 2024 at 9:21 AM Deepak Gupta wrote: > > v10 for riscv zicfilp and zicfiss extensions support in qemu. Please specify the exact version of the spec you used Alistair > > Links for previous versions > [1] - v1 > https://lists.nongnu.org/archive/html/qemu-devel/2024-07/msg06017.ht

Re: [PATCH v10 10/21] target/riscv: Expose zicfilp extension as a cpu property

On Wed, Aug 28, 2024 at 9:23 AM Deepak Gupta wrote: > > Signed-off-by: Deepak Gupta Reviewed-by: Alistair Francis Alistair > --- > target/riscv/cpu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c > index 2d031e3e74..8e1f05e5b1 100644 > --- a

Re: [PATCH v10 03/21] target/riscv: Add zicfilp extension

On Wed, Aug 28, 2024 at 9:20 AM Deepak Gupta wrote: > > zicfilp [1] riscv cpu extension enables forward control flow integrity. > If enabled, all indirect calls must land on a landing pad instruction. > > This patch sets up space for zicfilp extension in cpuconfig. zicfilp > is dependend on zicsr.

Re: [PATCH v10 11/21] target/riscv: Add zicfiss extension

On Wed, Aug 28, 2024 at 9:20 AM Deepak Gupta wrote: > > zicfiss [1] riscv cpu extension enables backward control flow integrity. > > This patch sets up space for zicfiss extension in cpuconfig. And imple- > ments dependency on A, zicsr, zimop and zcmop extensions. > > [1] - https://github.com/risc

[PATCH v10 18/21] target/riscv: compressed encodings for sspush and sspopchk

sspush/sspopchk have compressed encodings carved out of zcmops. compressed sspush is designated as c.mop.1 while compressed sspopchk is designated as c.mop.5. Note that c.sspush x1 exists while c.sspush x5 doesn't. Similarly c.sspopchk x5 exists while c.sspopchk x1 doesn't. Signed-off-by: Deepak

[PATCH v10 16/21] target/riscv: update `decode_save_opc` to store extra word2

Extra word 2 is stored during tcg compile and `decode_save_opc` needs additional argument in order to pass the value. This will be used during unwind to get extra information about instruction like how to massage exceptions. Updated all callsites as well. Signed-off-by: Deepak Gupta Reviewed-by:

[PATCH v10 12/21] target/riscv: introduce ssp and enabling controls for zicfiss

zicfiss introduces a new state ssp ("shadow stack register") in cpu. ssp is expressed as a new unprivileged csr (CSR_SSP=0x11) and holds virtual address for shadow stack as programmed by software. Shadow stack (for each mode) is enabled via bit3 in *envcfg CSRs. Shadow stack can be enabled for a m

[PATCH v10 14/21] target/riscv: mmu changes for zicfiss shadow stack protection

zicfiss protects shadow stack using new page table encodings PTE.W=1, PTE.R=0 and PTE.X=0. This encoding is reserved if zicfiss is not implemented or if shadow stack are not enabled. Loads on shadow stack memory are allowed while stores to shadow stack memory leads to access faults. Shadow stack ac

[PATCH v10 15/21] target/riscv: AMO operations always raise store/AMO fault

This patch adds one more word for tcg compile which can be obtained during unwind time to determine fault type for original operation (example AMO). Depending on that, fault can be promoted to store/AMO fault. Signed-off-by: Deepak Gupta Suggested-by: Richard Henderson Reviewed-by: Richard Hende

[PATCH v10 19/21] disas/riscv: enable disassembly for zicfiss instructions

Enable disassembly for sspush, sspopchk, ssrdp & ssamoswap. Disasembly is only enabled if zimop and zicfiss ext is set to true. Signed-off-by: Deepak Gupta --- disas/riscv.c | 40 +++- disas/riscv.h | 1 + 2 files changed, 40 insertions(+), 1 deletion(-) dif

[PATCH v10 10/21] target/riscv: Expose zicfilp extension as a cpu property

Signed-off-by: Deepak Gupta --- target/riscv/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 2d031e3e74..8e1f05e5b1 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -1476,6 +1476,7 @@ const RISCVCPUMultiExtConfig riscv_cpu_extensi

[PATCH v10 08/21] target/riscv: zicfilp `lpad` impl and branch tracking

Implements setting lp expected when `jalr` is encountered and implements `lpad` instruction of zicfilp. `lpad` instruction is taken out of auipc x0, . This is an existing HINTNOP space. If `lpad` is target of an indirect branch, cpu checks for 20 bit value in x7 upper with 20 bit value embedded in

[PATCH v10 04/21] target/riscv: Introduce elp state and enabling controls for zicfilp

zicfilp introduces a new state elp ("expected landing pad") in cpu. During normal execution, elp is idle (NO_LP_EXPECTED) i.e not expecting landing pad. On an indirect call, elp moves LP_EXPECTED. When elp is LP_EXPECTED, only a subsquent landing pad instruction can set state back to NO_LP_EXPECTED

Re: [PATCH v10 00/21] riscv support for control flow integrity extensions

On Tue, Aug 27, 2024 at 04:18:44PM -0700, Deepak Gupta wrote: v10 for riscv zicfilp and zicfiss extensions support in qemu. Links for previous versions [1] - v1 https://lists.nongnu.org/archive/html/qemu-devel/2024-07/msg06017.html [2] - v2 https://lore.kernel.org/all/ed23bcbc-fdc4-4492-803c-da

[PATCH v10 05/21] target/riscv: save and restore elp state on priv transitions

elp state is recorded in *status on trap entry (less privilege to higher privilege) and restored in elp from *status on trap exit (higher to less privilege). Additionally this patch introduces a forward cfi helper function to determine if current privilege has forward cfi is enabled or not based o

[PATCH v10 06/21] target/riscv: additional code information for sw check

sw check exception support was recently added. This patch further augments sw check exception by providing support for additional code which is provided in *tval. Adds `sw_check_code` field in cpuarchstate. Whenever sw check exception is raised *tval gets the value deposited in `sw_check_code`. Si

[PATCH v10 09/21] disas/riscv: enable `lpad` disassembly

Signed-off-by: Deepak Gupta Co-developed-by: Jim Shu Co-developed-by: Andy Chiu Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis --- disas/riscv.c | 18 +- disas/riscv.h | 2 ++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/disas/riscv.c b/disas/r

[PATCH v10 00/21] riscv support for control flow integrity extensions

v10 for riscv zicfilp and zicfiss extensions support in qemu. Links for previous versions [1] - v1 https://lists.nongnu.org/archive/html/qemu-devel/2024-07/msg06017.html [2] - v2 https://lore.kernel.org/all/ed23bcbc-fdc4-4492-803c-daa958803...@linaro.org/T/ [3] - v3 https://lists.nongnu.org/archi

[PATCH v10 01/21] target/riscv: expose *envcfg csr and priv to qemu-user as well

Execution environment config CSR controlling user env and current privilege state shouldn't be limited to qemu-system only. *envcfg CSRs control enabling of features in next lesser mode. In some cases bits *envcfg CSR can be lit up by kernel as part of kernel policy or software (user app) can choos

[PATCH v10 17/21] target/riscv: implement zicfiss instructions

zicfiss has following instructions - sspopchk: pops a value from shadow stack and compares with x1/x5. If they dont match, reports a sw check exception with tval = 3. - sspush: pushes value in x1/x5 on shadow stack - ssrdp: reads current shadow stack - ssamoswap: swaps contents of shadow sta

[PATCH v10 20/21] disas/riscv: enable disassembly for compressed sspush/sspopchk

sspush and sspopchk have equivalent compressed encoding taken from zcmop. cmop.1 is sspush x1 while cmop.5 is sspopchk x5. Due to unusual encoding for both rs1 and rs2 from space bitfield, this required a new codec. Signed-off-by: Deepak Gupta --- disas/riscv.c | 19 ++- disas/ri

[PATCH v10 13/21] target/riscv: tb flag for shadow stack instructions

Shadow stack instructions can be decoded as zimop / zcmop or shadow stack instructions depending on whether shadow stack are enabled at current privilege. This requires a TB flag so that correct TB generation and correct TB lookup happens. `DisasContext` gets a field indicating whether bcfi is enab

[PATCH v10 07/21] target/riscv: tracking indirect branches (fcfi) for zicfilp

zicfilp protects forward control flow (if enabled) by enforcing all indirect call and jmp must land on a landing pad instruction `lpad`. If target of an indirect call or jmp is not `lpad` then cpu/hart must raise a sw check exception with tval = 2. This patch implements the mechanism using TCG. Ta

[PATCH v10 11/21] target/riscv: Add zicfiss extension

zicfiss [1] riscv cpu extension enables backward control flow integrity. This patch sets up space for zicfiss extension in cpuconfig. And imple- ments dependency on A, zicsr, zimop and zcmop extensions. [1] - https://github.com/riscv/riscv-cfi Signed-off-by: Deepak Gupta Co-developed-by: Jim Sh

[PATCH v10 03/21] target/riscv: Add zicfilp extension

zicfilp [1] riscv cpu extension enables forward control flow integrity. If enabled, all indirect calls must land on a landing pad instruction. This patch sets up space for zicfilp extension in cpuconfig. zicfilp is dependend on zicsr. [1] - https://github.com/riscv/riscv-cfi Signed-off-by: Deepa

[PATCH v10 21/21] target/riscv: Expose zicfiss extension as a cpu property

Signed-off-by: Deepak Gupta --- target/riscv/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index d6cdd81fd8..66dc5af20c 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -1481,6 +1481,7 @@ const RISCVCPUMultiExtConfig riscv_cpu_extensi

[PATCH v10 02/21] linux-user/riscv: set priv for qemu-user and defaults for *envcfg

set priv to be PRV_U for qemu-user on riscv. And set default value for *envcfg CSR. Signed-off-by: Deepak Gupta --- linux-user/riscv/cpu_loop.c | 4 1 file changed, 4 insertions(+) diff --git a/linux-user/riscv/cpu_loop.c b/linux-user/riscv/cpu_loop.c index 52c49c2e42..7a68e8717b 100644 --

Re: [PATCH v9 11/17] target/riscv: mmu changes for zicfiss shadow stack protection

On Tue, Aug 27, 2024 at 03:59:08PM +1000, Alistair Francis wrote: On Tue, Aug 27, 2024 at 1:31 AM Deepak Gupta wrote: zicfiss protects shadow stack using new page table encodings PTE.W=0, PTE.R=0 and PTE.X=0. This encoding is reserved if zicfiss is not Shouldn't this be R=0, W=1, and X=0 ?

[PATCH v3 2/2] plugins: add option to dump write argument to syscall plugin

Signed-off-by: Rowan Hart Reviewed-by: Pierrick Bouvier Tested-by: Pierrick Bouvier --- docs/about/emulation.rst| 14 - tests/tcg/plugins/syscall.c | 117 2 files changed, 130 insertions(+), 1 deletion(-) diff --git a/docs/about/emulation.rst b/doc

[PATCH v3 0/2] plugins: add plugin API to read guest memory

This patch adds one API function to the QEMU plugin API bool qemu_plugin_read_memory_vaddr(vaddr, GByteArray *, size_t); The API allows reading memory from an arbitrary guest virtual address, which is useful for many things but the motivating examples are: * Virtual Machine Introspection (VMI) *

[PATCH v3 1/2] plugins: add plugin API to read guest memory

Signed-off-by: Rowan Hart Reviewed-by: Pierrick Bouvier --- include/qemu/qemu-plugin.h | 32 +++- plugins/api.c| 20 plugins/qemu-plugins.symbols | 1 + 3 files changed, 52 insertions(+), 1 deletion(-) diff --git a/include/qemu

Re: [PATCH v6 19/19] migration/multifd: Add documentation for multifd methods

On Tue, Aug 27, 2024 at 05:22:32PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Tue, Aug 27, 2024 at 04:17:59PM -0300, Fabiano Rosas wrote: > >> Peter Xu writes: > >> > >> > On Tue, Aug 27, 2024 at 03:54:51PM -0300, Fabiano Rosas wrote: > >> >> Peter Xu writes: > >> >> > >> >> > On

Re: [PULL for-9.1-rc4 0/1] NBD patches for 2024-08-26

On 8/26/24 23:49, Eric Blake wrote: The following changes since commit f259e4cb8a8b4ef5463326fc214a7d8d7703d5de: Merge tag 'pull-trivial-patches' of https://gitlab.com/mjt0k/qemu into staging (2024-08-24 08:09:27 +1000) are available in the Git repository at: https://repo.or.cz/qemu/eri

Re: [PATCH 0/6] refactor RDMA live migration based on rsocket API

On Tue, Aug 27, 2024 at 04:15:42PM -0400, Peter Xu wrote: > On Tue, Jun 04, 2024 at 08:14:06PM +0800, Gonglei wrote: > > From: Jialin Wang > > > > Hi, > > > > This patch series attempts to refactor RDMA live migration by > > introducing a new QIOChannelRDMA class based on the rsocket API. > > >

Re: [PATCH v3] vhost-user: Do not wait for reply for not sent VHOST_USER_SET_LOG_BASE

On Tue, Aug 27, 2024 at 09:00:35PM +0800, BillXiang wrote: > > > From: "Prasad Pandit" > > Date:  Tue, Aug 27, 2024, 20:37 > > Subject:  Re: [PATCH v3] vhost-user: Do not wait for reply for not sent > > VHOST_USER_SET_LOG_BASE > > To: "BillXiang" > > Cc: "Michael S. Tsirkin", > > On Tue, 27 Aug

Re: [PULL 02/96] spapr: Migrate ail-mode-3 spapr cap

26.07.2024 02:52, Nicholas Piggin пишет: This cap did not add the migration code when it was introduced. This results in migration failure when changing the default using the command line. Cc: qemu-sta...@nongnu.org Fixes: ccc5a4c5e10 ("spapr: Add SPAPR_CAP_AIL_MODE_3 for AIL mode 3 support for

Re: [PATCH v6 19/19] migration/multifd: Add documentation for multifd methods

Peter Xu writes: > On Tue, Aug 27, 2024 at 04:17:59PM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Tue, Aug 27, 2024 at 03:54:51PM -0300, Fabiano Rosas wrote: >> >> Peter Xu writes: >> >> >> >> > On Tue, Aug 27, 2024 at 02:46:06PM -0300, Fabiano Rosas wrote: >> >> >> Add documen

Re: [PATCH 0/6] refactor RDMA live migration based on rsocket API

On Tue, Jun 04, 2024 at 08:14:06PM +0800, Gonglei wrote: > From: Jialin Wang > > Hi, > > This patch series attempts to refactor RDMA live migration by > introducing a new QIOChannelRDMA class based on the rsocket API. > > The /usr/include/rdma/rsocket.h provides a higher level rsocket API > tha

Re: [PATCH v6 18/19] migration/multifd: Stop changing the packet on recv side

On Tue, Aug 27, 2024 at 04:27:42PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Tue, Aug 27, 2024 at 03:45:11PM -0300, Fabiano Rosas wrote: > >> Peter Xu writes: > >> > >> > On Tue, Aug 27, 2024 at 02:46:05PM -0300, Fabiano Rosas wrote: > >> >> @@ -254,12 +250,10 @@ int multifd_ram_u

Re: [PATCH v6 19/19] migration/multifd: Add documentation for multifd methods

On Tue, Aug 27, 2024 at 04:17:59PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Tue, Aug 27, 2024 at 03:54:51PM -0300, Fabiano Rosas wrote: > >> Peter Xu writes: > >> > >> > On Tue, Aug 27, 2024 at 02:46:06PM -0300, Fabiano Rosas wrote: > >> >> Add documentation clarifying the usage

[PATCH v3 1/2] qdev-monitor: avoid QemuOpts in QMP device_add

The QMP device_add monitor command converts the QDict arguments to QemuOpts and then back again to QDict. This process only supports scalar types. Device properties like virtio-blk-pci's iothread-vq-mapping (an array of objects) are silently dropped by qemu_opts_from_qdict() during the QemuOpts con

[PATCH v3 2/2] vl: use qmp_device_add() in qemu_create_cli_devices()

qemu_create_cli_devices() should use qmp_device_add() to match the behavior of the QMP monitor. A comment explained that libvirt changes implementing strict CLI syntax were needed. Peter Krempa has confirmed that modern libvirt uses the same JSON for -device (CLI) and device_add (QMP). Go ahead a

[PATCH v3 0/2] qdev-monitor: avoid QemuOpts in QMP device_add()

v3: - Duplicate drain_call_rcu() into hmp_device_add() because moving it into qdev_device_add_from_qdict turned out to be unsafe. v2: - Rename Patch 1 to indicate that we're avoiding QemuOpts rather than doing a full conversion to QAPI. Also mention that 'gen': false is still being used. [Mar

Re: [PATCH v6 18/19] migration/multifd: Stop changing the packet on recv side

Peter Xu writes: > On Tue, Aug 27, 2024 at 03:45:11PM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Tue, Aug 27, 2024 at 02:46:05PM -0300, Fabiano Rosas wrote: >> >> @@ -254,12 +250,10 @@ int multifd_ram_unfill_packet(MultiFDRecvParams *p, >> >> Error **errp) >> >> return

Re: [ANNOUNCE] QEMU 8.2.6 Stable released

On Wednesday, July 17 2024, Michael Tokarev wrote: > Hi everyone, Hey Michael, > The QEMU v8.2.6 stable release is now available. > > You can grab the tarball from our download page here: > > https://www.qemu.org/download/#source > > https://download.qemu.org/qemu-8.2.6.tar.xz > https://do

Re: [PATCH v2 0/2] qdev-monitor: avoid QemuOpts in QMP device_add

On Tue, Aug 13, 2024 at 09:18:46AM +0100, Paul Durrant wrote: > On 12/08/2024 19:15, Stefan Hajnoczi wrote: > > On Fri, Aug 02, 2024 at 10:10:43AM +0200, Markus Armbruster wrote: > > > Can we additionally cut out the QemuOpts middleman in > > > usbback_portid_add()? > > > > > > qdict = qdict_

Re: [PATCH v6 19/19] migration/multifd: Add documentation for multifd methods

Peter Xu writes: > On Tue, Aug 27, 2024 at 03:54:51PM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Tue, Aug 27, 2024 at 02:46:06PM -0300, Fabiano Rosas wrote: >> >> Add documentation clarifying the usage of the multifd methods. The >> >> general idea is that the client code calls

Re: [PATCH v6 19/19] migration/multifd: Add documentation for multifd methods

On Tue, Aug 27, 2024 at 03:54:51PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Tue, Aug 27, 2024 at 02:46:06PM -0300, Fabiano Rosas wrote: > >> Add documentation clarifying the usage of the multifd methods. The > >> general idea is that the client code calls into multifd to trigger >

Re: [PATCH v6 18/19] migration/multifd: Stop changing the packet on recv side

On Tue, Aug 27, 2024 at 03:45:11PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Tue, Aug 27, 2024 at 02:46:05PM -0300, Fabiano Rosas wrote: > >> @@ -254,12 +250,10 @@ int multifd_ram_unfill_packet(MultiFDRecvParams *p, > >> Error **errp) > >> return 0; > >> } > >> > >>

Re: [PATCH v6 19/19] migration/multifd: Add documentation for multifd methods

Peter Xu writes: > On Tue, Aug 27, 2024 at 02:46:06PM -0300, Fabiano Rosas wrote: >> Add documentation clarifying the usage of the multifd methods. The >> general idea is that the client code calls into multifd to trigger >> send/recv of data and multifd then calls these hooks back from the >> wo

Re: [PATCH RESEND] hw/openrisc/openrisc_sim: keep serial@90000000 as default

On Sun, Aug 25, 2024 at 03:09:20PM +0100, Peter Maydell wrote: > On Sun, 25 Aug 2024 at 12:35, Jason A. Donenfeld wrote: > > > > On Fri, Aug 23, 2024 at 07:28:43AM +0100, Stafford Horne wrote: > > > Also, I will wait to see if Jason has anything to say. > > > > So long as this doesn't change the a

Re: [PATCH v6 18/19] migration/multifd: Stop changing the packet on recv side

Peter Xu writes: > On Tue, Aug 27, 2024 at 02:46:05PM -0300, Fabiano Rosas wrote: >> @@ -254,12 +250,10 @@ int multifd_ram_unfill_packet(MultiFDRecvParams *p, >> Error **errp) >> return 0; >> } >> >> -/* make sure that ramblock is 0 terminated */ >> -packet->ramblock[255]

Re: [PATCH v1] softmmu/physmem: fix memory leak in dirty_memory_extend()

On Tue, Aug 27, 2024 at 08:00:07PM +0200, David Hildenbrand wrote: > On 27.08.24 19:57, Peter Xu wrote: > > On Tue, Aug 27, 2024 at 10:37:15AM +0200, David Hildenbrand wrote: > > > /* Called with ram_list.mutex held */ > > > -static void dirty_memory_extend(ram_addr_t old_ram_size, > > > -

Re: [PATCH v6 19/19] migration/multifd: Add documentation for multifd methods

On Tue, Aug 27, 2024 at 02:46:06PM -0300, Fabiano Rosas wrote: > Add documentation clarifying the usage of the multifd methods. The > general idea is that the client code calls into multifd to trigger > send/recv of data and multifd then calls these hooks back from the > worker threads at opportune

Re: [PATCH v6 18/19] migration/multifd: Stop changing the packet on recv side

On Tue, Aug 27, 2024 at 02:46:05PM -0300, Fabiano Rosas wrote: > @@ -254,12 +250,10 @@ int multifd_ram_unfill_packet(MultiFDRecvParams *p, > Error **errp) > return 0; > } > > -/* make sure that ramblock is 0 terminated */ > -packet->ramblock[255] = 0; > -p->block = qemu

Re: [PATCH v3 4/4] tests/tcg/aarch64: Extend MTE gdbstub tests to system mode

Hi Phil, On 8/27/24 9:42 AM, Gustavo Romero wrote: Hi Phil! On 8/26/24 3:10 AM, Philippe Mathieu-Daudé wrote: Hi Gustavo, On 25/8/24 16:52, Gustavo Romero wrote: Extend MTE gdbstub tests to also run in system mode (share tests between user mode and system mode). The tests will only run if a

Re: [PATCH v1] softmmu/physmem: fix memory leak in dirty_memory_extend()

On 27.08.24 19:57, Peter Xu wrote: On Tue, Aug 27, 2024 at 10:37:15AM +0200, David Hildenbrand wrote: /* Called with ram_list.mutex held */ -static void dirty_memory_extend(ram_addr_t old_ram_size, -ram_addr_t new_ram_size) +static void dirty_memory_extend(ram_a

Re: [PATCH v1] softmmu/physmem: fix memory leak in dirty_memory_extend()

On 27.08.24 19:50, Peter Xu wrote: On Tue, Aug 27, 2024 at 01:28:02PM -0400, Stefan Hajnoczi wrote: On Tue, 27 Aug 2024 at 13:24, David Hildenbrand wrote: On 27.08.24 18:52, Stefan Hajnoczi wrote: On Tue, 27 Aug 2024 at 04:38, David Hildenbrand wrote: As reported by Peter, we might be lea

[PATCH v2 05/17] thread-pool: Implement non-AIO (generic) pool support

From: "Maciej S. Szmigiero" Migration code wants to manage device data sending threads in one place. QEMU has an existing thread pool implementation, however it was limited to queuing AIO operations only and essentially had a 1:1 mapping between the current AioContext and the ThreadPool in use.

[PATCH v2 12/17] migration/multifd: Device state transfer support - send side

From: "Maciej S. Szmigiero" A new function multifd_queue_device_state() is provided for device to queue its state for transmission via a multifd channel. Signed-off-by: Maciej S. Szmigiero --- include/migration/misc.h | 4 ++ migration/meson.build| 1 + migration/multifd-

[PATCH v2 16/17] vfio/migration: Add x-migration-multifd-transfer VFIO property

From: "Maciej S. Szmigiero" This property allows configuring at runtime whether to send the particular device state via multifd channels when live migrating that device. It is ignored on the receive side and defaults to "false" for bit stream compatibility with older QEMU versions. Signed-off-b

[PATCH v2 08/17] migration: Add load_finish handler and associated functions

From: "Maciej S. Szmigiero" load_finish SaveVMHandler allows migration code to poll whether a device-specific asynchronous device state loading operation had finished. In order to avoid calling this handler needlessly the device is supposed to notify the migration code of its possible readiness

[PATCH v2 03/17] migration/multifd: Zero p->flags before starting filling a packet

From: "Maciej S. Szmigiero" This way there aren't stale flags there. p->flags can't contain SYNC to be sent at the next RAM packet since syncs are now handled separately in multifd_send_thread. Signed-off-by: Maciej S. Szmigiero --- migration/multifd.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH v2 00/17] Multifd 🔀 device state transfer support with VFIO consumer

From: "Maciej S. Szmigiero" This is an updated v2 patch series of the v1 series located here: https://lore.kernel.org/qemu-devel/cover.1718717584.git.maciej.szmigi...@oracle.com/ Changes from v1: * Extended the QEMU thread-pool with non-AIO (generic) pool support, implemented automatic memory ma

Re: [PATCH v1] softmmu/physmem: fix memory leak in dirty_memory_extend()

On Tue, Aug 27, 2024 at 10:37:15AM +0200, David Hildenbrand wrote: > /* Called with ram_list.mutex held */ > -static void dirty_memory_extend(ram_addr_t old_ram_size, > -ram_addr_t new_ram_size) > +static void dirty_memory_extend(ram_addr_t new_ram_size) > { > -

[PATCH v2 02/17] migration/ram: Add load start trace event

From: "Maciej S. Szmigiero" There's a RAM load complete trace event but there wasn't its start equivalent. Signed-off-by: Maciej S. Szmigiero --- migration/ram.c| 1 + migration/trace-events | 1 + 2 files changed, 2 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index 6

[PATCH v2 17/17] vfio/migration: Multifd device state transfer support - send side

From: "Maciej S. Szmigiero" Implement the multifd device state transfer via additional per-device thread inside save_live_complete_precopy_thread handler. Switch between doing the data transfer in the new handler and doing it in the old save_state handler depending on the x-migration-multifd-tra

[PATCH v2 11/17] migration/multifd: Add an explicit MultiFDSendData destructor

From: "Maciej S. Szmigiero" This way if there are fields there that needs explicit disposal (like, for example, some attached buffers) they will be handled appropriately. Add a related assert to multifd_set_payload_type() in order to make sure that this function is only used to fill a previously

[PATCH v2 07/17] migration: Add qemu_loadvm_load_state_buffer() and its handler

From: "Maciej S. Szmigiero" qemu_loadvm_load_state_buffer() and its load_state_buffer SaveVMHandler allow providing device state buffer to explicitly specified device via its idstr and instance id. Signed-off-by: Maciej S. Szmigiero --- include/migration/register.h | 15 +++ migrat

[PATCH v2 15/17] vfio/migration: Multifd device state transfer support - receive side

From: "Maciej S. Szmigiero" The multifd received data needs to be reassembled since device state packets sent via different multifd channels can arrive out-of-order. Therefore, each VFIO device state packet carries a header indicating its position in the stream. The last such VFIO device state

[PATCH v2 01/17] vfio/migration: Add save_{iterate, complete_precopy}_started trace events

From: "Maciej S. Szmigiero" This way both the start and end points of migrating a particular VFIO device are known. Add also a vfio_save_iterate_empty_hit trace event so it is known when there's no more data to send for that device. Signed-off-by: Maciej S. Szmigiero --- hw/vfio/migration.c

  1   2   3   >