[PATCH v3] kvm: replace fprintf with error_report/printf() in kvm_init()

2024-08-08 Thread Ani Sinha
error_report() is more appropriate for error situations. Replace fprintf with error_report. Cosmetic. No functional change. CC: qemu-triv...@nongnu.org CC: zhao1@intel.com Reviewed-by: Zhao Liu Signed-off-by: Ani Sinha --- accel/kvm/kvm-all.c | 40 ++-- 1

Re: [PATCH v1 2/3] target/i386: Add VMX control bits for nested FRED support

2024-08-08 Thread Xin Li
@@ -1450,7 +1450,7 @@ FeatureWordInfo feature_word_info[FEATURE_WORDS] = { NULL, "vmx-entry-ia32e-mode", NULL, NULL, NULL, "vmx-entry-load-perf-global-ctrl", "vmx-entry-load-pat", "vmx-entry-load-efer", "vmx-entry-load-bndcfgs", NULL, "vmx-entry-load-r

Re: [RFC PATCH 03/23] scripts: add script to generate C header files from SVD XML files

2024-08-08 Thread Paolo Bonzini
On 8/8/24 23:56, John Snow wrote: I haven't read the rest of this series; I'm chiming in solely from the build/python maintainer angle. Do we *always* need pysvd, no matter how QEMU was configured? Adding it to the meson line here is a very big hammer. In general I'd agree, though for a 7.5 kB

Re: [PATCH v1 3/3] target/i386: Raise the highest index value used for any VMCS encoding

2024-08-08 Thread Xin Li
+if (f[FEAT_7_1_EAX] & CPUID_7_1_EAX_FRED) { +/* FRED injected-event data (0x2052). */ +kvm_msr_entry_add(cpu, MSR_IA32_VMX_VMCS_ENUM, 0x52); HMM, I have the questions when I check the FRED spec. Section 9.3.4 said, (for injected-event data) "This field has uses the encodin

Re: [PATCH v5 7/7] scripts/ghes_inject: add a script to generate GHES error inject

2024-08-08 Thread Mauro Carvalho Chehab
Em Fri, 9 Aug 2024 00:41:37 +0200 Mauro Carvalho Chehab escreveu: > > You should be able to use e.g. > > > > legacy.py's QEMUMonitorProtocol class for synchronous connections, e.g. > > > > from qemu.qmp.legacy import QEMUMonitorProtocol > > > > qmp = QEMUMonitorProtocol((host, port)) > > qmp.c

Re: [PATCH 3/3] tests/acpi: Add expected ACPI SRAT AML file for RISC-V

2024-08-08 Thread Sunil V L
On Fri, Aug 09, 2024 at 11:09:49AM +0800, Haibo Xu wrote: > As per the step 5 in the process documented in bios-tables-test.c, > generate the expected ACPI SRAT AML data file for RISC-V using the > rebuild-expected-aml.sh script and update the > bios-tables-test-allowed-diff.h. > > This is a new f

Re: [PATCH 2/3] tests/qtest/bios-tables-test.c: Enable numamem testing for RISC-V

2024-08-08 Thread Sunil V L
On Fri, Aug 09, 2024 at 11:09:48AM +0800, Haibo Xu wrote: > Add ACPI SRAT table test case for RISC-V when NUMA was enabled. > > Signed-off-by: Haibo Xu > --- > tests/qtest/bios-tables-test.c | 28 > 1 file changed, 28 insertions(+) > > diff --git a/tests/qtest/bios-

Re: [PATCH 1/3] tests/acpi: Add empty ACPI SRAT data file for RISC-V

2024-08-08 Thread Sunil V L
On Fri, Aug 09, 2024 at 11:09:47AM +0800, Haibo Xu wrote: > As per process documented (steps 1-3) in bios-tables-test.c, add > empty AML data file for RISC-V ACPI SRAT table and add the entry > in bios-tables-test-allowed-diff.h. > > Signed-off-by: Haibo Xu > --- > tests/data/acpi/riscv64/virt/S

Re: [PATCH for-9.1] tcg/ppc: Sync tcg_out_test and constraints

2024-08-08 Thread Nicholas Piggin
On Thu Aug 8, 2024 at 2:46 AM AEST, Philippe Mathieu-Daudé wrote: > On 7/8/24 06:08, Richard Henderson wrote: > > Ensure the code structure is the same for matching constraints > > and emitting code, lest we allow constants that cannot be > > trivially tested. > > > > Cc: qemu-sta...@nongnu.org >

Re: [PATCH v2 1/2] kvm: replace fprintf with error_report() in kvm_init() for error conditions

2024-08-08 Thread Zhao Liu
On Fri, Aug 09, 2024 at 10:40:53AM +0530, Ani Sinha wrote: > Date: Fri, 9 Aug 2024 10:40:53 +0530 > From: Ani Sinha > Subject: [PATCH v2 1/2] kvm: replace fprintf with error_report() in > kvm_init() for error conditions > X-Mailer: git-send-email 2.45.2 > > error_report() is more appropriate fo

Re: [PATCH v4 1/4] target/riscv: Add Smrnmi cpu extension.

2024-08-08 Thread Tommy Wu
On Mon, Jun 12, 2023 at 1:04 PM Alistair Francis wrote: > > On Thu, Jun 8, 2023 at 5:25 PM Tommy Wu wrote: > > > > Signed-off-by: Frank Chang > > Signed-off-by: Tommy Wu > > --- > > hw/riscv/riscv_hart.c | 21 + > > include/hw/riscv/riscv_hart.h | 4 > > targe

Re: [PATCH v4 1/4] target/riscv: Add Smrnmi cpu extension.

2024-08-08 Thread Tommy Wu
On Thu, Jun 8, 2023 at 5:52 PM Andrew Jones wrote: > > > Please add a commit message to all patches of the series. > > Another comment below. Thanks for the suggestion, I'll add commit messages to all patches in the v5 patches. > > On Thu, Jun 08, 2023 at 12:23:11AM -0700, Tommy Wu wrote: > > Si

Re: [PATCH v4 0/4] target/riscv: Add Smrnmi support.

2024-08-08 Thread Tommy Wu
On Thu, Jun 8, 2023 at 5:43 PM Andrew Jones wrote: > > On Thu, Jun 08, 2023 at 12:23:10AM -0700, Tommy Wu wrote: > > This patchset added support for Smrnmi Extension in RISC-V. > > > > There are four new CSRs and one new instruction added to allow NMI to be > > resumable in RISC-V, which are: > >

Re: [PATCH v3 2/2] kvm: refactor core virtual machine creation into its own function

2024-08-08 Thread Zhao Liu
On Fri, Aug 09, 2024 at 10:40:54AM +0530, Ani Sinha wrote: > Date: Fri, 9 Aug 2024 10:40:54 +0530 > From: Ani Sinha > Subject: [PATCH v3 2/2] kvm: refactor core virtual machine creation into > its own function > X-Mailer: git-send-email 2.45.2 > > Refactoring the core logic around KVM_CREATE_VM

[PATCH 0/2] Some refactoring

2024-08-08 Thread Ani Sinha
replace fprintf() with error_report() in kvm_init() refactor code in kvm_init() to move core vm creation operation to its own function. CC: qemu-triv...@nongnu.org CC: qemu-devel@nongnu.org CC: zhao1@intel.com CC: pbonz...@redhat.com Ani Sinha (2): kvm: replace fprintf with error_report()

[PATCH v2 1/2] kvm: replace fprintf with error_report() in kvm_init() for error conditions

2024-08-08 Thread Ani Sinha
error_report() is more appropriate for error situations. Replace fprintf with error_report. Cosmetic. No functional change. CC: qemu-triv...@nongnu.org CC: zhao1@intel.com Signed-off-by: Ani Sinha --- accel/kvm/kvm-all.c | 40 ++-- 1 file changed, 18 inser

[PATCH v3 2/2] kvm: refactor core virtual machine creation into its own function

2024-08-08 Thread Ani Sinha
Refactoring the core logic around KVM_CREATE_VM into its own separate function so that it can be called from other functions in subsequent patches. There is no functional change in this patch. CC: pbonz...@redhat.com CC: zhao1@intel.com CC: cfont...@suse.de CC: qemu-triv...@nongnu.org Signed-o

Re: [PATCH 1/2] kvm: replace fprintf with error_report() in kvm_init() for error conditions

2024-08-08 Thread Ani Sinha
On Fri, Aug 9, 2024 at 10:23 AM Ani Sinha wrote: > > error_report() is more appropriate for error situations. Replace fprintf with > error_report. Cosmetic. No functional change. > > CC: qemu-triv...@nongnu.org > CC: zhao1@intel.com > Signed-off-by: Ani Sinha > --- > accel/kvm/kvm-all.c | 42

[PATCH v3 2/2] kvm: refactor core virtual machine creation into its own function

2024-08-08 Thread Ani Sinha
Refactoring the core logic around KVM_CREATE_VM into its own separate function so that it can be called from other functions in subsequent patches. There is no functional change in this patch. CC: pbonz...@redhat.com CC: zhao1@intel.com CC: cfont...@suse.de CC: qemu-triv...@nongnu.org Signed-o

[PATCH 1/2] kvm: replace fprintf with error_report() in kvm_init() for error conditions

2024-08-08 Thread Ani Sinha
error_report() is more appropriate for error situations. Replace fprintf with error_report. Cosmetic. No functional change. CC: qemu-triv...@nongnu.org CC: zhao1@intel.com Signed-off-by: Ani Sinha --- accel/kvm/kvm-all.c | 42 +++--- 1 file changed, 19 ins

Re: [PATCH 1/6] qapi/char: Supply missing member documentation

2024-08-08 Thread Markus Armbruster
John Snow writes: > On Thu, Aug 8, 2024 at 2:26 PM Markus Armbruster wrote: > >> Since we neglect to document several members of ChardevBackendKind, >> their description in the QEMU QMP Reference manual is "Not >> documented". Fix that, and improve the existing member documentation. >> >> Signe

Re: [PATCH v6 4/5] vvfat: Fix reading files with non-continuous clusters

2024-08-08 Thread Amjad Alsharafi
On Aug 5 2024, at 6:22 pm, Kevin Wolf wrote: > Am 20.07.2024 um 12:13 hat Amjad Alsharafi geschrieben: >> When reading with `read_cluster` we get the `mapping` with >> `find_mapping_for_cluster` and then we call `open_file` for this >> mapping. >> The issue appear when its the same file, but a

Re: [PATCH v2 4/4] target/i386: Update CMPLegacy handling for Zhaoxin CPUs

2024-08-08 Thread Ewan Hai
On 8/8/24 23:47, Zhao Liu wrote: On Thu, Aug 08, 2024 at 11:25:45PM -0400, Ewan Hai wrote: [snip] Thank you for your suggestion; the changes will indeed make it clearer. I have a question: since you’ve already added your reviewed-by tag to the first three patches, if I want to modify these des

[PATCH 0/4] hw/arm/virt: Improve virt_kvm_type()

2024-08-08 Thread Gavin Shan
hw/arm/virt.c::virt_kvm_type() can be improved due to the facts as below, when I inspect the code to review Salil's (RFCv3) vCPU hotplug series. * virt_kvm_type() and MachineClass::kvm_type() are needed only when CONFIG_KVM is enabled. * kvm_arm_get_max_vm_ipa_size() and kvm_arch_get_defa

[PATCH 2/4] hw/arm/virt: Avoid multiple lines of comments in virt_kvm_type()

2024-08-08 Thread Gavin Shan
The comment needn't to span multiple lines and can be merged to one line perfectly. Signed-off-by: Gavin Shan --- hw/arm/virt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 83be57db37..09b7a158a9 100644 --- a/hw/arm/virt.c +++ b/hw/ar

[PATCH 3/4] hw/arm/virt: Use kvm_arch_get_default_type()

2024-08-08 Thread Gavin Shan
kvm_arch_get_default_type() and kvm_arm_get_max_vm_ipa_size() are interchangeable since the type is equivalent to IPA size (bits) with one exception that IPA size (bits) is 40 when the type is zero. Replace kvm_arm_get_max_vm_ipa_size() with kvm_arch_get_default_type(). After this, kvm_arm_get_max

[PATCH 4/4] target/arm/kvm: Remove kvm_arm_get_max_vm_ipa_size()

2024-08-08 Thread Gavin Shan
Remove kvm_arm_get_max_vm_ipa_size() after its logics are moved to its only caller kvm_arch_get_default_type(). Signed-off-by: Gavin Shan --- target/arm/kvm.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/target/arm/kvm.c b/target/arm/kvm.c index 65893c9c12..

[PATCH 1/4] hw/arm/virt: hide virt_kvm_type() on !CONFIG_KVM

2024-08-08 Thread Gavin Shan
virt_kvm_type() and mc->kvm_type() are only needed when CONFIG_KVM is enabled. It's reasonable to hide them when CONFIG_KVM is disabled. Signed-off-by: Gavin Shan --- hw/arm/virt.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 719e83e6a1..83be57db37

Re: [PATCH v2 4/4] target/i386: Update CMPLegacy handling for Zhaoxin CPUs

2024-08-08 Thread Zhao Liu
On Thu, Aug 08, 2024 at 11:25:45PM -0400, Ewan Hai wrote: [snip] > Thank you for your suggestion; the changes will indeed make it clearer. > I have a question: since you’ve already added your reviewed-by tag to > the first three patches, if I want to modify these descriptions, should > I submit a

Re: [PATCH 1/1] hw/intc/riscv_aplic: Fix APLIC in clrip and clripnum write emulation

2024-08-08 Thread Yong-Xuan Wang
Hi Daniel, On Fri, Aug 9, 2024 at 5:40 AM Daniel Henrique Barboza wrote: > > Ccing Anup > > On 8/8/24 5:20 AM, Yong-Xuan Wang wrote: > > In the section "4.7 Precise effects on interrupt-pending bits" > > of the RISC-V AIA specification defines that: > > > > If the source mode is Level1 or Level0

Re: [PATCH v2 4/4] target/i386: Update CMPLegacy handling for Zhaoxin CPUs

2024-08-08 Thread Ewan Hai
On 8/8/24 23:22, Zhao Liu wrote: Hi EwanHai, On Thu, Jul 04, 2024 at 07:25:11AM -0400, EwanHai wrote: Date: Thu, 4 Jul 2024 07:25:11 -0400 From: EwanHai Subject: [PATCH v2 4/4] target/i386: Update CMPLegacy handling for Zhaoxin CPUs X-Mailer: git-send-email 2.34.1 Zhaoxin CPUs handle th

Re: [PATCH v2] kvm: refactor core virtual machine creation into its own function

2024-08-08 Thread Zhao Liu
Hi Ani, On Thu, Aug 08, 2024 at 05:08:38PM +0530, Ani Sinha wrote: > Date: Thu, 8 Aug 2024 17:08:38 +0530 > From: Ani Sinha > Subject: [PATCH v2] kvm: refactor core virtual machine creation into its > own function > X-Mailer: git-send-email 2.45.2 > > Refactoring the core logic around KVM_CREA

Re: [PATCH v2 4/4] target/i386: Update CMPLegacy handling for Zhaoxin CPUs

2024-08-08 Thread Zhao Liu
On Thu, Aug 08, 2024 at 09:44:18PM -0400, Ewan Hai wrote: > Date: Thu, 8 Aug 2024 21:44:18 -0400 > From: Ewan Hai > Subject: Re: [PATCH v2 4/4] target/i386: Update CMPLegacy handling for > Zhaoxin CPUs > > > Hi Zhao Liu, > > Thank you for your feedback. > > On 8/8/24 06:30, Zhao Liu wrote: >

[PATCH 3/3] tests/acpi: Add expected ACPI SRAT AML file for RISC-V

2024-08-08 Thread Haibo Xu
As per the step 5 in the process documented in bios-tables-test.c, generate the expected ACPI SRAT AML data file for RISC-V using the rebuild-expected-aml.sh script and update the bios-tables-test-allowed-diff.h. This is a new file being added for the first time. Hence, iASL diff output is not add

[PATCH 1/3] tests/acpi: Add empty ACPI SRAT data file for RISC-V

2024-08-08 Thread Haibo Xu
As per process documented (steps 1-3) in bios-tables-test.c, add empty AML data file for RISC-V ACPI SRAT table and add the entry in bios-tables-test-allowed-diff.h. Signed-off-by: Haibo Xu --- tests/data/acpi/riscv64/virt/SRAT.numamem | 0 tests/qtest/bios-tables-test-allowed-diff.h | 1 + 2

[PATCH 2/3] tests/qtest/bios-tables-test.c: Enable numamem testing for RISC-V

2024-08-08 Thread Haibo Xu
Add ACPI SRAT table test case for RISC-V when NUMA was enabled. Signed-off-by: Haibo Xu --- tests/qtest/bios-tables-test.c | 28 1 file changed, 28 insertions(+) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index 36e5c0adde..e79f3a03d

Re: [PATCH v2 4/4] target/i386: Update CMPLegacy handling for Zhaoxin CPUs

2024-08-08 Thread Ewan Hai
Hi Zhao Liu, Thank you for your feedback. On 8/8/24 06:30, Zhao Liu wrote: Hi EwanHai, On Thu, Jul 04, 2024 at 07:25:11AM -0400, EwanHai wrote: Date: Thu, 4 Jul 2024 07:25:11 -0400 From: EwanHai Subject: [PATCH v2 4/4] target/i386: Update CMPLegacy handling for Zhaoxin CPUs X-Mailer: git

[ANNOUNCE] QEMU 9.1.0-rc1 is now available

2024-08-08 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the second release candidate for the QEMU 9.1 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu.org/qemu-9.1.0-rc1.tar.xz http://download.qemu

Re: [PATCH v5 7/7] scripts/ghes_inject: add a script to generate GHES error inject

2024-08-08 Thread John Snow
On Thu, Aug 8, 2024 at 6:41 PM Mauro Carvalho Chehab < mchehab+hua...@kernel.org> wrote: > Em Thu, 8 Aug 2024 17:21:33 -0400 > John Snow escreveu: > > > On Fri, Aug 2, 2024 at 5:44 PM Mauro Carvalho Chehab < > > mchehab+hua...@kernel.org> wrote: > > > > > > diff --git a/scripts/qmp_helper.py b/sc

Re: [RFC PATCH 03/23] scripts: add script to generate C header files from SVD XML files

2024-08-08 Thread John Snow
On Thu, Aug 8, 2024 at 6:30 PM Octavian Purdila wrote: > On Thu, Aug 8, 2024 at 2:56 PM John Snow wrote: > > > > > > > > On Mon, Aug 5, 2024 at 4:17 PM Octavian Purdila > wrote: > >> > >> From: Stefan Stanacar > >> > >> From: Stefan Stanacar > >> > >> The CMSIS System View Description format(

Re: [PULL 0/6] hex queue

2024-08-08 Thread Brian Cain
On 8/8/2024 5:39 PM, Richard Henderson wrote: On 8/8/24 13:42, Brian Cain wrote: The following changes since commit 4c395ac42e55ff8e9fd4c992e351a04b10785503:    Merge tag 'pull-tcg-20240808' of https://gitlab.com/rth7680/qemu into staging (2024-08-08 09:07:00 +1000) are availa

Re: [PATCH v5 7/7] scripts/ghes_inject: add a script to generate GHES error inject

2024-08-08 Thread Mauro Carvalho Chehab
Em Thu, 8 Aug 2024 17:21:33 -0400 John Snow escreveu: > On Fri, Aug 2, 2024 at 5:44 PM Mauro Carvalho Chehab < > mchehab+hua...@kernel.org> wrote: > > > diff --git a/scripts/qmp_helper.py b/scripts/qmp_helper.py > > new file mode 100644 > > index ..13fae7a7af0e > > --- /dev/null >

Re: [PULL 0/6] hex queue

2024-08-08 Thread Richard Henderson
On 8/8/24 13:42, Brian Cain wrote: The following changes since commit 4c395ac42e55ff8e9fd4c992e351a04b10785503: Merge tag 'pull-tcg-20240808' of https://gitlab.com/rth7680/qemu into staging (2024-08-08 09:07:00 +1000) are available in the Git repository at: https://github.com

Re: [RFC PATCH 03/23] scripts: add script to generate C header files from SVD XML files

2024-08-08 Thread Octavian Purdila
On Thu, Aug 8, 2024 at 2:56 PM John Snow wrote: > > > > On Mon, Aug 5, 2024 at 4:17 PM Octavian Purdila wrote: >> >> From: Stefan Stanacar >> >> From: Stefan Stanacar >> >> The CMSIS System View Description format(CMSIS-SVD) is an XML based >> description of Arm Cortex-M microcontrollers provid

Re: [PATCH v2] aspeed: Deprecate the tacoma-bmc machine

2024-08-08 Thread Guenter Roeck
Hi, On Tue, Jun 25, 2024 at 09:08:30AM +0200, Cédric Le Goater wrote: > The tacoma-bmc machine was a board including an AST2600 SoC based BMC > and a witherspoon like OpenPOWER system. It was used for bring up of > the AST2600 SoC in labs. It can be easily replaced by the rainier-bmc > machine whi

[PULL 5/5] nbd/server: CVE-2024-7409: Close stray clients at server-stop

2024-08-08 Thread Eric Blake
A malicious client can attempt to connect to an NBD server, and then intentionally delay progress in the handshake, including if it does not know the TLS secrets. Although the previous two patches reduce this behavior by capping the default max-connections parameter and killing slow clients, they

Re: [RFC PATCH 03/23] scripts: add script to generate C header files from SVD XML files

2024-08-08 Thread John Snow
On Mon, Aug 5, 2024 at 4:17 PM Octavian Purdila wrote: > From: Stefan Stanacar > > From: Stefan Stanacar > > The CMSIS System View Description format(CMSIS-SVD) is an XML based > description of Arm Cortex-M microcontrollers provided and maintained > by sillicon vendors. It includes details such

[PULL 1/5] nbd: Minor style and typo fixes

2024-08-08 Thread Eric Blake
Touch up a comment with the wrong type name, and an over-long line, both noticed while working on upcoming patches. Signed-off-by: Eric Blake Message-ID: <20240807174943.771624-10-ebl...@redhat.com> Reviewed-by: Daniel P. Berrangé --- nbd/server.c | 2 +- qemu-nbd.c | 3 ++- 2 files changed,

[PULL 0/5] NBD: fix CVE-2024-7409 for 9.1

2024-08-08 Thread Eric Blake
The following changes since commit 75c7f574035622798e9361a942bdfbb0af930f0e: Merge tag 'pull-hex-20240807' of https://github.com/quic/qemu into staging (2024-08-08 16:08:18 +1000) are available in the Git repository at: https://repo.or.cz/qemu/ericb.git tags/pull-nbd-2024-08-08 for you to

[PULL 3/5] nbd/server: CVE-2024-7409: Cap default max-connections to 100

2024-08-08 Thread Eric Blake
Allowing an unlimited number of clients to any web service is a recipe for a rudimentary denial of service attack: the client merely needs to open lots of sockets without closing them, until qemu no longer has any more fds available to allocate. For qemu-nbd, we default to allowing only 1 connecti

[PULL 2/5] nbd/server: Plumb in new args to nbd_client_add()

2024-08-08 Thread Eric Blake
Upcoming patches to fix a CVE need to track an opaque pointer passed in by the owner of a client object, as well as request for a time limit on how fast negotiation must complete. Prepare for that by changing the signature of nbd_client_new() and adding an accessor to get at the opaque pointer, al

[PULL 4/5] nbd/server: CVE-2024-7409: Drop non-negotiating clients

2024-08-08 Thread Eric Blake
A client that opens a socket but does not negotiate is merely hogging qemu's resources (an open fd and a small amount of memory); and a malicious client that can access the port where NBD is listening can attempt a denial of service attack by intentionally opening and abandoning lots of unfinished

Re: [PATCH v5 7/7] scripts/ghes_inject: add a script to generate GHES error inject

2024-08-08 Thread Mauro Carvalho Chehab
Em Thu, 8 Aug 2024 16:58:38 -0400 John Snow escreveu: > On Fri, Aug 2, 2024 at 5:44 PM Mauro Carvalho Chehab < > mchehab+hua...@kernel.org> wrote: > > > +#!/usr/bin/env python3 > > +# > > +# pylint: disable=C0301, C0114, R0912, R0913, R0914, R0915, W0511 > > > > Out of curiosity, what tool

Re: [PATCH 1/1] hw/intc/riscv_aplic: Fix APLIC in clrip and clripnum write emulation

2024-08-08 Thread Daniel Henrique Barboza
Ccing Anup On 8/8/24 5:20 AM, Yong-Xuan Wang wrote: In the section "4.7 Precise effects on interrupt-pending bits" of the RISC-V AIA specification defines that: If the source mode is Level1 or Level0 and the interrupt domain is configured in MSI delivery mode (domaincfg.DM = 1): The pending bit

Re: [RFC PATCH 20/23] hw/ssi: add support for flexspi

2024-08-08 Thread Octavian Purdila
On Wed, Aug 7, 2024 at 10:11 PM Philippe Mathieu-Daudé wrote: > > Hi Octavian, > Hi Philippe, Thanks for the review! > On 5/8/24 22:17, Octavian Purdila wrote: > > This is mostly a stub which completes SPI transactions as noops > > by masking out the error interrupts and never clearing the IPCM

Re: [PATCH v5 7/7] scripts/ghes_inject: add a script to generate GHES error inject

2024-08-08 Thread John Snow
On Fri, Aug 2, 2024 at 5:44 PM Mauro Carvalho Chehab < mchehab+hua...@kernel.org> wrote: > Using the QMP GHESv2 API requires preparing a raw data array > containing a CPER record. > > Add a helper script with subcommands to prepare such data. > > Currently, only ARM Processor error CPER record is

Re: [PATCH v5 7/7] scripts/ghes_inject: add a script to generate GHES error inject

2024-08-08 Thread John Snow
On Fri, Aug 2, 2024 at 5:44 PM Mauro Carvalho Chehab < mchehab+hua...@kernel.org> wrote: > Using the QMP GHESv2 API requires preparing a raw data array > containing a CPER record. > > Add a helper script with subcommands to prepare such data. > > Currently, only ARM Processor error CPER record is

Re: [PATCH 0/6] qapi: Supply some of the missing member documentation

2024-08-08 Thread John Snow
On Thu, Aug 8, 2024 at 2:26 PM Markus Armbruster wrote: > This series gets a few of modules off the pragma > documentation-exceptions list of shame that require minimal effort. > > Many undocumented members still remain: > > module type or command #missing > -

Re: [PATCH 1/6] qapi/char: Supply missing member documentation

2024-08-08 Thread John Snow
On Thu, Aug 8, 2024 at 2:26 PM Markus Armbruster wrote: > Since we neglect to document several members of ChardevBackendKind, > their description in the QEMU QMP Reference manual is "Not > documented". Fix that, and improve the existing member documentation. > > Signed-off-by: Markus Armbruster

Re: [PATCH V2 01/11] machine: alloc-anon option

2024-08-08 Thread Steven Sistare
On 7/29/2024 8:29 AM, Igor Mammedov wrote: On Sat, 20 Jul 2024 16:28:25 -0400 Steven Sistare wrote: On 7/16/2024 5:19 AM, Igor Mammedov wrote: On Sun, 30 Jun 2024 12:40:24 -0700 Steve Sistare wrote: Allocate anonymous memory using mmap MAP_ANON or memfd_create depending on the value of

Re: [PATCH v4 1/2] cxl/core: introduce device reporting poison hanlding

2024-08-08 Thread Fan Ni
On Thu, Aug 08, 2024 at 11:13:27PM +0800, Shiyang Ruan wrote: > CXL device can find&report memory problems, even before MCE is detected > by CPU. AFAIK, the current kernel only traces POISON error event > from FW-First/OS-First path, but it doesn't handle them, neither > notify processes who are u

[PATCH 5/6] qapi/pci: Supply missing member documentation

2024-08-08 Thread Markus Armbruster
Since we neglect to document a member of PciMemoryRegion, its description in the QEMU QMP Reference manual is "Not documented". Fix that. Signed-off-by: Markus Armbruster --- qapi/pci.json| 2 ++ qapi/pragma.json | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/qapi/pci.

[PATCH 2/6] qapi/common: Supply missing member documentation

2024-08-08 Thread Markus Armbruster
Since we neglect to document the members of GrabToggleKeys, their description in the QEMU QMP Reference manual is "Not documented". Fix that. Signed-off-by: Markus Armbruster --- qapi/common.json | 14 +- qapi/pragma.json | 1 - 2 files changed, 13 insertions(+), 2 deletions(-) di

[PATCH 3/6] qapi/crypto: Supply missing member documentation

2024-08-08 Thread Markus Armbruster
Since we neglect to document the members of QCryptoAkCipherKeyType, their description in the QEMU QMP Reference manual is "Not documented". Fix that. Signed-off-by: Markus Armbruster --- qapi/crypto.json | 4 qapi/pragma.json | 1 - 2 files changed, 4 insertions(+), 1 deletion(-) diff --g

[PATCH 6/6] qapi/rocker: Supply missing member documentation

2024-08-08 Thread Markus Armbruster
Since we neglect to document the argument of query-rocker and query-rocker-ports, their description in the QEMU QMP Reference manual is "Not documented". Fix that. Signed-off-by: Markus Armbruster --- qapi/pragma.json | 4 +--- qapi/rocker.json | 4 2 files changed, 5 insertions(+), 3 dele

[PATCH 1/6] qapi/char: Supply missing member documentation

2024-08-08 Thread Markus Armbruster
Since we neglect to document several members of ChardevBackendKind, their description in the QEMU QMP Reference manual is "Not documented". Fix that, and improve the existing member documentation. Signed-off-by: Markus Armbruster --- qapi/char.json | 44 ---

[PATCH 0/6] qapi: Supply some of the missing member documentation

2024-08-08 Thread Markus Armbruster
This series gets a few of modules off the pragma documentation-exceptions list of shame that require minimal effort. Many undocumented members still remain: module type or command #missing audio

[PATCH 4/6] qapi/introspect: Supply missing member documentation

2024-08-08 Thread Markus Armbruster
Since we neglect to document the members of JSONType, their description in the QEMU QMP Reference manual is "Not documented". Fix that. Signed-off-by: Markus Armbruster --- qapi/introspect.json | 16 qapi/pragma.json | 1 - 2 files changed, 16 insertions(+), 1 deletion(-)

RE: [PATCH v4 03/15] crypto/hash-gcrypt: Implement new hash API

2024-08-08 Thread Alejandro Zeise
> On Wed, Aug 07, 2024 at 07:51:10PM +, Alejandro Zeise wrote: > > Implements the new hashing API in the gcrypt hash driver. > > Supports creating/destroying a context, updating the context with > > input data and obtaining an output hash. > > > > Signed-off-by: Alejandro Zeise > > --- > > c

Re: [PATCH v5 6/7] acpi/ghes: add support for generic error injection via QAPI

2024-08-08 Thread Mauro Carvalho Chehab
Em Thu, 8 Aug 2024 10:11:07 +0200 Igor Mammedov escreveu: > On Wed, 7 Aug 2024 15:25:47 +0100 > Jonathan Cameron wrote: > > > On Tue, 6 Aug 2024 16:31:13 +0200 > > Igor Mammedov wrote: > > > > > On Fri, 2 Aug 2024 23:44:01 +0200 > > > Mauro Carvalho Chehab wrote: > > > > > > > Provid

The members of QCryptodevBackendServiceType are undocumented

2024-08-08 Thread Markus Armbruster
Hi Zhenwei Pi, You added the type in commit bc304a6442e (cryptodev: Introduce server type in QAPI). The doc comment describes none of the members. Can you supply me brief descriptions? I'm happy to do the actual patch.

Re: [PATCH 2/4] reset: Add RESET_TYPE_WAKEUP

2024-08-08 Thread David Hildenbrand
On 08.08.24 19:30, Peter Maydell wrote: On Thu, 8 Aug 2024 at 17:29, David Hildenbrand wrote: On 08.08.24 18:17, Peter Maydell wrote: On Thu, 8 Aug 2024 at 17:04, David Hildenbrand wrote: On 08.08.24 17:56, Peter Maydell wrote: Right, I guess that's my question -- is "WAKEUP" ever any dif

CxlCorErrorType member @retry-threshold is undocumented

2024-08-08 Thread Markus Armbruster
Hi Jonathan, You added the type in commit 415442a1b4a (hw/mem/cxl_type3: Add CXL RAS Error Injection Support.) The doc comment is missing a description of @retry-threshold. Can you supply me one? I'm happy to do the actual patch.

Re: [PATCH 2/4] reset: Add RESET_TYPE_WAKEUP

2024-08-08 Thread Peter Maydell
On Thu, 8 Aug 2024 at 17:29, David Hildenbrand wrote: > > On 08.08.24 18:17, Peter Maydell wrote: > > On Thu, 8 Aug 2024 at 17:04, David Hildenbrand wrote: > >> > >> On 08.08.24 17:56, Peter Maydell wrote: > >>> Right, I guess that's my question -- is "WAKEUP" ever any > >>> different from "WARM"

Re: bug?

2024-08-08 Thread Daniel P . Berrangé
On Thu, Aug 08, 2024 at 03:41:46PM +, Yusuf said Çolak wrote: > I installed qemu successfully and downloaded emulator you published on > github, i runned > > mkdir buildcd build > > but if i run ../configure it gives ; > > > > > ERROR: missing GIT submodules > This is not a GIT checkout b

Re: [PATCH v4 14/15] crypto/hashpriv: Remove old hash API function

2024-08-08 Thread Daniel P . Berrangé
On Wed, Aug 07, 2024 at 07:51:21PM +, Alejandro Zeise wrote: > Remove old hash_bytesv function, as it was replaced by the 4 > new functions. > > Signed-off-by: Alejandro Zeise > --- > crypto/hashpriv.h | 6 -- > 1 file changed, 6 deletions(-) Reviewed-by: Daniel P. Berrangé With rega

Re: [PATCH v4 13/15] crypto/hash-afalg: Remove old hash API functions

2024-08-08 Thread Daniel P . Berrangé
On Wed, Aug 07, 2024 at 07:51:20PM +, Alejandro Zeise wrote: > Removes the old hash API functions in the afalg driver, > and modifies the hmac function to use the new helper functions. > > Signed-off-by: Alejandro Zeise > --- > crypto/hash-afalg.c | 59 +++

Re: [PATCH v4 12/15] crypto/hash-nettle: Remove old hash API functions

2024-08-08 Thread Daniel P . Berrangé
On Wed, Aug 07, 2024 at 07:51:19PM +, Alejandro Zeise wrote: > Removes old hash implemention in the nettle hash driver. > > Signed-off-by: Alejandro Zeise > --- > crypto/hash-nettle.c | 53 > 1 file changed, 53 deletions(-) Reviewed-by: Daniel P.

Re: [PATCH v4 11/15] crypto/hash-gnutls: Remove old hash API functions

2024-08-08 Thread Daniel P . Berrangé
On Wed, Aug 07, 2024 at 07:51:18PM +, Alejandro Zeise wrote: > Removes old hash implemention in the gnutls hash driver. > > Signed-off-by: Alejandro Zeise > --- > crypto/hash-gnutls.c | 47 > 1 file changed, 47 deletions(-) Reviewed-by: Daniel P.

Re: [PATCH v4 10/15] crypto/hash-gcrypt: Remove old hash API functions

2024-08-08 Thread Daniel P . Berrangé
On Wed, Aug 07, 2024 at 07:51:17PM +, Alejandro Zeise wrote: > Removes old hash implemention in the gcrypt hash driver. > > Signed-off-by: Alejandro Zeise > --- > crypto/hash-gcrypt.c | 67 > 1 file changed, 67 deletions(-) Reviewed-by: Daniel P.

Re: [PATCH v4 09/15] crypto/hash-glib: Remove old hash API functions

2024-08-08 Thread Daniel P . Berrangé
On Wed, Aug 07, 2024 at 07:51:16PM +, Alejandro Zeise wrote: > Removes old hash implemention in the GLib hash driver. > > Signed-off-by: Alejandro Zeise > --- > crypto/hash-glib.c | 53 -- > 1 file changed, 53 deletions(-) Reviewed-by: Daniel P. B

Re: [PATCH v4 08/15] tests/unit/test-crypto-hash: accumulative hashing

2024-08-08 Thread Daniel P . Berrangé
On Wed, Aug 07, 2024 at 07:51:15PM +, Alejandro Zeise wrote: > Added an accumulative hashing test. Checks for functionality of > the new hash create, update, finalize and free functions. > > Signed-off-by: Alejandro Zeise > --- > tests/unit/test-crypto-hash.c | 48 +++

Re: [PATCH v4 06/15] crypto/hash-afalg: Implement new hash API

2024-08-08 Thread Daniel P . Berrangé
On Wed, Aug 07, 2024 at 07:51:13PM +, Alejandro Zeise wrote: > Updates the afalg hash driver to support the new accumulative > hashing changes as part of the patch series. > > Implements opening/closing of contexts, updating hash data > and finalizing the hash digest. > > In order to support

Re: [PATCH v4 03/15] crypto/hash-gcrypt: Implement new hash API

2024-08-08 Thread Daniel P . Berrangé
On Wed, Aug 07, 2024 at 07:51:10PM +, Alejandro Zeise wrote: > Implements the new hashing API in the gcrypt hash driver. > Supports creating/destroying a context, updating the context > with input data and obtaining an output hash. > > Signed-off-by: Alejandro Zeise > --- > crypto/hash-gcryp

Re: [PATCH v4 04/15] crypto/hash-gnutls: Implement new hash API

2024-08-08 Thread Daniel P . Berrangé
On Wed, Aug 07, 2024 at 07:51:11PM +, Alejandro Zeise wrote: > Implements the new hashing API in the gnutls hash driver. > Supports creating/destroying a context, updating the context > with input data and obtaining an output hash. > > Signed-off-by: Alejandro Zeise > --- > crypto/hash-gnutl

Re: [PATCH v4 03/15] crypto/hash-gcrypt: Implement new hash API

2024-08-08 Thread Daniel P . Berrangé
On Wed, Aug 07, 2024 at 07:51:10PM +, Alejandro Zeise wrote: > Implements the new hashing API in the gcrypt hash driver. > Supports creating/destroying a context, updating the context > with input data and obtaining an output hash. > > Signed-off-by: Alejandro Zeise > --- > crypto/hash-gcryp

Re: [PATCH] block/blkio: use FUA flag on write zeroes only if supported

2024-08-08 Thread Philippe Mathieu-Daudé
On 8/8/24 10:05, Stefano Garzarella wrote: libblkio supports BLKIO_REQ_FUA with write zeros requests only since version 1.4.0, so let's inform the block layer that the blkio driver supports it only in this case. Otherwise we can have runtime errors as reported in https://issues.redhat.com/browse/

Re: [PATCH v4 03/15] crypto/hash-gcrypt: Implement new hash API

2024-08-08 Thread Daniel P . Berrangé
On Wed, Aug 07, 2024 at 07:51:10PM +, Alejandro Zeise wrote: > Implements the new hashing API in the gcrypt hash driver. > Supports creating/destroying a context, updating the context > with input data and obtaining an output hash. > > Signed-off-by: Alejandro Zeise > --- > crypto/hash-gcryp

Re: [PATCH v4 01/15] crypto: accumulative hashing API

2024-08-08 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Aug 07, 2024 at 07:51:08PM +, Alejandro Zeise wrote: >> Changes the hash API to support accumulative hashing. >> Hash objects are created with "qcrypto_hash_new", >> updated with data with "qcrypto_hash_update", and >> the hash obtained with "qcrypto_hash_

bug?

2024-08-08 Thread Yusuf said Çolak
I installed qemu successfully and downloaded emulator you published on github, i runned mkdir buildcd build but if i run ../configure it gives ; ERROR: missing GIT submodules This is not a GIT checkout but module content appears to be missing. Do not use 'git archive' or GitHub download links

Re: [PATCH v4 02/15] crypto/hash-glib: Implement new hash API

2024-08-08 Thread Daniel P . Berrangé
On Wed, Aug 07, 2024 at 07:51:09PM +, Alejandro Zeise wrote: > Implements the new hashing API in the GLib hash driver. > Supports creating/destroying a context, updating the context > with input data and obtaining an output hash. > > Signed-off-by: Alejandro Zeise > --- > crypto/hash-glib.c

Re: [PATCH v4 01/15] crypto: accumulative hashing API

2024-08-08 Thread Daniel P . Berrangé
On Wed, Aug 07, 2024 at 07:51:08PM +, Alejandro Zeise wrote: > Changes the hash API to support accumulative hashing. > Hash objects are created with "qcrypto_hash_new", > updated with data with "qcrypto_hash_update", and > the hash obtained with "qcrypto_hash_finalize". > > These changes bring

Re: [PATCH 2/4] reset: Add RESET_TYPE_WAKEUP

2024-08-08 Thread David Hildenbrand
On 08.08.24 17:56, Peter Maydell wrote: On Thu, 8 Aug 2024 at 16:31, David Hildenbrand wrote: On 08.08.24 17:28, Juraj Marcin wrote: On Thu, Aug 8, 2024 at 2:18 PM Peter Maydell wrote: On Tue, 6 Aug 2024 at 17:08, Juraj Marcin wrote: +``RESET_TYPE_WAKEUP`` + This type is used when the m

Re: [PATCH 2/4] reset: Add RESET_TYPE_WAKEUP

2024-08-08 Thread Peter Maydell
On Thu, 8 Aug 2024 at 17:04, David Hildenbrand wrote: > > On 08.08.24 17:56, Peter Maydell wrote: > > Right, I guess that's my question -- is "WAKEUP" ever any > > different from "WARM" reset? I think the latter is a more > > common general concept. > > > > On the other hand it looks like we alrea

Re: [PATCH v2] kvm: refactor core virtual machine creation into its own function

2024-08-08 Thread Claudio Fontana
Hello, as a suggestion you could adjust the names of the functions to match the existing pattern in this module. It is modulename_method ie kvm_* , so: On 8/8/24 13:38, Ani Sinha wrote: > Refactoring the core logic around KVM_CREATE_VM into its own separate function > so that it can be called f

Re: [PATCH 2/4] reset: Add RESET_TYPE_WAKEUP

2024-08-08 Thread David Hildenbrand
On 08.08.24 18:17, Peter Maydell wrote: On Thu, 8 Aug 2024 at 17:04, David Hildenbrand wrote: On 08.08.24 17:56, Peter Maydell wrote: Right, I guess that's my question -- is "WAKEUP" ever any different from "WARM" reset? I think the latter is a more common general concept. On the other hand

Re: [PATCH v4 07/15] crypto/hash: Implement and use new hash API

2024-08-08 Thread Daniel P . Berrangé
On Wed, Aug 07, 2024 at 07:51:14PM +, Alejandro Zeise wrote: > Changes the public hash API implementation to support accumulative hashing. > > Implementations for the public functions are added to call the new > driver functions that implement context creation, updating, > finalization, and de

Re: [PATCH 2/4] reset: Add RESET_TYPE_WAKEUP

2024-08-08 Thread Peter Maydell
On Thu, 8 Aug 2024 at 16:31, David Hildenbrand wrote: > > On 08.08.24 17:28, Juraj Marcin wrote: > > On Thu, Aug 8, 2024 at 2:18 PM Peter Maydell > > wrote: > >> > >> On Tue, 6 Aug 2024 at 17:08, Juraj Marcin wrote: > >>> +``RESET_TYPE_WAKEUP`` > >>> + This type is used when the machine is wok

Re: [PATCH] block/blkio: use FUA flag on write zeroes only if supported

2024-08-08 Thread Eric Blake
On Thu, Aug 08, 2024 at 10:05:45AM GMT, Stefano Garzarella wrote: > libblkio supports BLKIO_REQ_FUA with write zeros requests only since > version 1.4.0, so let's inform the block layer that the blkio driver > supports it only in this case. Otherwise we can have runtime errors > as reported in http

Re: [PATCH 3/4] virtio-mem: Implement Resettable interface instead of using LegacyReset

2024-08-08 Thread Peter Maydell
On Thu, 8 Aug 2024 at 13:37, David Hildenbrand wrote: > > On 08.08.24 14:25, Peter Maydell wrote: > > On Tue, 6 Aug 2024 at 17:08, Juraj Marcin wrote: > >> > >> LegacyReset does not pass ResetType to the reset callback method, which > >> the new Resettable interface uses. Due to this, virtio-mem

  1   2   3   >