ping :) 06.05.2024, 11:34, "Daniil Tatianin" :This can be used to force-synchronize the time in guest after a longstop-cont pause, which can be useful for serverless-type workload.Also add a comment to highlight the fact that this (and one other QMPcommand) only works for the MC146818 RTC controlle
> -Original Message-
> From: Fabiano Rosas
> Sent: Monday, May 13, 2024 11:14 PM
> To: Liu, Yuan1 ; pet...@redhat.com
> Cc: qemu-devel@nongnu.org; Liu, Yuan1 ; Zou, Nanhai
>
> Subject: Re: [PATCH v6 6/7] migration/multifd: implement qpl compression
> and decompression
>
> Yuan Liu write
On Tue, Apr 30, 2024 at 5:29 AM Atish Patra wrote:
>
> This series contains few miscallenous fixes related to hpmcounters
> and related code. The first patch fixes an issue with cycle/instret
> counters overcouting while the remaining two are more for specification
> compliance.
>
> Signed-off-by:
On Thu, Apr 25, 2024 at 9:36 AM Richard Henderson
wrote:
>
> Signed-off-by: Richard Henderson
Reviewed-by: Alistair Francis
Alistair
> ---
> target/riscv/translate.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/target/riscv/translate.c b/target/riscv/transla
On Tue, Apr 30, 2024 at 5:29 AM Atish Patra wrote:
>
> scounteren/hcountern are also WARL registers similar to mcountern.
> Only set the bits for the available counters during the write to
> preserve the WARL behavior.
>
> Signed-off-by: Atish Patra
Reviewed-by: Alistair Francis
Alistair
> --
On Tue, Apr 30, 2024 at 5:29 AM Atish Patra wrote:
>
> Currently, if a counter monitoring cycle/instret is stopped via
> mcountinhibit we just update the state while the value is saved
> during the next read. This is not accurate as the read may happen
> many cycles after the counter is stopped. I
On Fri, May 3, 2024 at 8:32 PM Alexei Filippov
wrote:
>
> Previous patch fixed the PMP priority in raise_mmu_exception() but we're still
> setting mtval2 incorrectly. In riscv_cpu_tlb_fill(), after pmp check in 2
> stage
> translation part, mtval2 will be set in case of successes 2 stage translat
This reverts commit f02a4b8e6431598612466f76aac64ab492849abf.
Since the current patch cannot completely fix the lost reconnect
problem, there is a scenario that is not considered:
- When the virtio-blk driver is removed from the guest os,
s->connected has no chance to be set to false, resulting
When the vhost-user is reconnecting to the backend, and if the vhost-user fails
at the get_features in vhost_dev_init(), then the reconnect will fail
and it will not be retriggered forever.
The reason is:
When the vhost-user fail at get_features, the vhost_dev_cleanup will be called
immediately.
Thanks ;)
>cmd
On 14/05/2024 07:50, Duan, Zhenzhong wrote:
> Caution: External email. Do not open attachments or click links, unless this
> email comes from a known sender and you know the content is safe.
>
>
> Hi Clement,
>
> I'll learn and try to give comments this week.
>
> Thanks
> Zhenzho
On Fri, May 3, 2024 at 8:32 PM Alexei Filippov
wrote:
>
> Previous patch fixed the PMP priority in raise_mmu_exception() but we're still
> setting mtval2 incorrectly. In riscv_cpu_tlb_fill(), after pmp check in 2
> stage
> translation part, mtval2 will be set in case of successes 2 stage translat
On Sat, Apr 13, 2024 at 9:00 PM Alexei Filippov
wrote:
>
> From: Daniel Henrique Barboza
>
> raise_mmu_exception(), as is today, is prioritizing guest page faults by
> checking first if virt_enabled && !first_stage, and then considering the
> regular inst/load/store faults.
>
> There's no mention
Hi Clement,
I'll learn and try to give comments this week.
Thanks
Zhenzhong
>-Original Message-
>From: CLEMENT MATHIEU--DRIF
>Subject: Re: [PATCH intel_iommu 0/7] FLTS for VT-d
>
>Hi Zhenzhong
>
>Have you had time to review the ATS series rebased on you FLTS patches?
>
>Thanks
> >cmd
>
On Fri, Mar 22, 2024 at 7:33 PM Max Chou wrote:
>
> When SEW is 16, we need to check whether the Zvfhmin is enabled for the
> single width operator for vector floating point widen/narrow
> instructions.
>
> The commits in this patchset fix the single width operator checking and
> remove the reduda
On Thu, Apr 4, 2024 at 5:02 AM Eric DeVolder wrote:
>
> I've been using QEMU8 to collect instruction information on U-Boot + OpenSBI.
>
> I'm running QEMU in this fashion to collect the information:
>
> # qemu-system-riscv64 -plugin file=qemu/build/contrib/plugins/libexeclog.so
> -singlestep -d p
Previously we only listed a single pmpcfg CSR and the first 16 pmpaddr
CSRs. This patch fixes this to list all 16 pmpcfg and all 64 pmpaddr
CSRs are part of the dissassembly.
Reported-by: Eric DeVolder
Signed-off-by: Alistair Francis
---
disas/riscv.c | 65 ++
Hi Zhenzhong
Have you had time to review the ATS series rebased on you FLTS patches?
Thanks
>cmd
On 06/05/2024 03:38, Duan, Zhenzhong wrote:
> Caution: External email. Do not open attachments or click links, unless this
> email comes from a known sender and you know the content is safe.
>
>
>
Hey, Marc-Andre,
On Mon, May 13, 2024 at 11:19:04AM +0400, marcandre.lur...@redhat.com wrote:
> diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
> index ae831b6b3e..7f9fb5eacc 100644
> --- a/hw/display/virtio-gpu.c
> +++ b/hw/display/virtio-gpu.c
> @@ -1234,7 +1234,8 @@ static int vi
On Mon, May 13, 2024 at 11:19:03AM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
Reviewed-by: Peter Xu
--
Peter Xu
On Mon, May 13, 2024 at 5:58 PM Eugenio Perez Martin
wrote:
>
> On Mon, May 13, 2024 at 10:28 AM Jason Wang wrote:
> >
> > On Mon, May 13, 2024 at 2:28 PM Eugenio Perez Martin
> > wrote:
> > >
> > > On Sat, May 11, 2024 at 6:07 AM Jason Wang wrote:
> > > >
> > > > On Fri, May 10, 2024 at 3:16 P
Hi All,
When I looked into more functions passing 'Error **',
I see many are in "int testfunc(..., Error **errp)" format. I was a bit
confused.
The qapi/error.h suggests:
* - Whenever practical, also return a value that indicates success /
* failure. This can make the error checking more co
> I'm failing to see what real world technical problems QEMU faces
> with a parameter being set to '1' by a mgmt app, when QEMU itself
> treats all omitted values as being '1' anyway.
>
> If we're trying to faithfully model the real world, then restricting
> the topology against machine types thou
On Tue Apr 23, 2024 at 4:30 PM AEST, Harsh Prateek Bora wrote:
> + qemu-devel
>
> On 4/23/24 11:40, Harsh Prateek Bora wrote:
> > On ppc64, the PowerVM hypervisor runs with limited memory and a VCPU
> > creation during hotplug may fail during kvm_ioctl for KVM_CREATE_VCPU,
> > leading to terminatio
If VM runs in kvm mode, VM mode is added in IOCSR feature register.
So guest can detect kvm hypervisor type and enable possible pv functions.
Signed-off-by: Bibo Mao
---
hw/loongarch/virt.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/hw/loongarch/virt.c b/hw/
When running the instruction
```
cbo.flush 0(x0)
```
QEMU would segfault.
The issue was in cpu_gpr[a->rs1] as QEMU does not have cpu_gpr[0]
allocated.
In order to fix this let's use the existing get_address()
helper. This also has the benefit of performing pointer mask
calculations on the a
On 19/04/2024 07:11, nifan@gmail.com wrote:
> +} else if (type == DC_EVENT_ADD_CAPACITY) {
> +if (cxl_extents_overlaps_dpa_range(&dcd->dc.extents, dpa, len)) {
> +error_setg(errp,
> + "cannot add DPA already accessible to the same
Hi Fan
Do you have a newer instruction to play with the DCD. It seems that
the instruction in RFC[0] doesn't work for current code.
[0] https://lore.kernel.org/all/20230511175609.2091136-1-fan...@samsung.com/
On 19/04/2024 07:10, nifan@gmail.com wrote:
> A git tree of this series can be f
Hi Steve,
Thanks for the response.
It looks like literally *just today* 8.2.4 was released. I'll go check
it out.
- Michael
On 5/13/24 15:10, Steven Sistare wrote:
Hi Michael,
No surprise here, I did see some of the same failure messages and they
prompted me to submit the fix. They are a
Writes from GDB to memory-mapped IO regions are currently silently
dropped. cpu_memory_rw_debug() calls address_space_write_rom(), which
calls address_space_write_rom_internal(), which ignores all non-ram/rom
regions.
Add a check for MMIO regions and direct those to address_space_rw()
instead.
Re
marcandre.lur...@redhat.com writes:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> migration/vmstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/vmstate.c b/migration/vmstate.c
> index b51212a75b..ff5d589a6d 100644
> --- a/migrati
Cédric Le Goater writes:
> Use it to update the current error of the migration stream if
> available and if not, simply print out the error. Next changes will
> update with an error to report.
>
> Signed-off-by: Cédric Le Goater
Acked-by: Fabiano Rosas
On 2024-05-13 13:36-0700, Sean Christopherson wrote:
> Hmm, a slightly crazy idea (ok, maybe wildly crazy) would be to support
> mapping
> all of guest_memfd into kernel address space, but as USER=1 mappings. I.e.
> don't
> require a carve-out from userspace, but do require CLAC/STAC when access
Steven Sistare writes:
> On 5/9/2024 3:14 PM, Fabiano Rosas wrote:
>> Steve Sistare writes:
>>
>>> Add the only-migratable-modes option as a generalization of only-migratable.
>>> Only devices that support all requested modes are allowed.
>>>
>>> Signed-off-by: Steve Sistare
>>> ---
>>> incl
Steven Sistare writes:
> On 5/6/2024 7:34 PM, Fabiano Rosas wrote:
>> Steve Sistare writes:
>>
>>> Provide migration_precreate_save for saving precreate vmstate across exec.
>>> Create a memfd, save its value in the environment, and serialize state
>>> to it. Reverse the process in migration_p
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Hi everyone,
The QEMU v8.2.4 stable release is now available.
You can grab the tarball from our download page here:
https://www.qemu.org/download/#source
https://download.qemu.org/qemu-8.2.4.tar.xz
https://download.qemu.org/qemu-8.2.4.tar.x
On Mon, May 13, 2024, James Gowans wrote:
> On Mon, 2024-05-13 at 10:09 -0700, Sean Christopherson wrote:
> > On Mon, May 13, 2024, James Gowans wrote:
> > > On Mon, 2024-05-13 at 08:39 -0700, Sean Christopherson wrote:
> > > > > Sean, you mentioned that you envision guest_memfd also supporting
>
Hi Michael,
No surprise here, I did see some of the same failure messages and they
prompted me to submit the fix. They are all symptoms of "the possibility of
ram and device state being out of sync" as mentioned in the commit.
I am not familiar with the process for maintaining old releases for
On 5/9/2024 3:14 PM, Fabiano Rosas wrote:
Steve Sistare writes:
Add the only-migratable-modes option as a generalization of only-migratable.
Only devices that support all requested modes are allowed.
Signed-off-by: Steve Sistare
---
include/migration/misc.h | 3 +++
include/sysemu/
On Mon, 2024-05-13 at 10:09 -0700, Sean Christopherson wrote:
> On Mon, May 13, 2024, James Gowans wrote:
> > On Mon, 2024-05-13 at 08:39 -0700, Sean Christopherson wrote:
> > > > Sean, you mentioned that you envision guest_memfd also supporting
> > > > non-CoCo VMs.
> > > > Do you have some thoug
On 5/13/2024 2:37 PM, Fabiano Rosas wrote:
Steve Sistare writes:
Create a common subroutine to allocate a RAMBlock, de-duping the code to
populate its common fields. Add a trace point for good measure.
No functional change.
Signed-off-by: Steve Sistare
---
system/physmem.c| 47 +++
On 5/10/2024 3:54 AM, Daniel P. Berrangé wrote:
On Mon, Apr 29, 2024 at 08:55:33AM -0700, Steve Sistare wrote:
cpr-exec mode needs permission to exec. Block it if permission is denied.
Signed-off-by: Steve Sistare
---
include/sysemu/seccomp.h | 1 +
system/qemu-seccomp.c| 10 -
On 5/9/2024 2:01 PM, Fabiano Rosas wrote:
Steve Sistare writes:
Unlike cpr-reboot mode, cpr-exec mode cannot save volatile ram blocks in the
migration stream file and recreate them later, because the physical memory for
the blocks is pinned and registered for vfio. Add an exec-mode blocker fo
On 5/9/2024 10:32 AM, Fabiano Rosas wrote:
Fabiano Rosas writes:
Steve Sistare writes:
Define vmstate_register_named which takes the instance name as its first
parameter, instead of generating the name from VMStateIf of the Object.
This will be needed to register objects that are not Object
On 5/7/2024 5:02 PM, Fabiano Rosas wrote:
Steve Sistare writes:
Provide the VMStateDescription precreate field to mark objects that must
be loaded on the incoming side before devices have been created, because
they provide properties that will be needed at creation time. They will
be saved to
On 5/6/2024 7:34 PM, Fabiano Rosas wrote:
Steve Sistare writes:
Provide migration_precreate_save for saving precreate vmstate across exec.
Create a memfd, save its value in the environment, and serialize state
to it. Reverse the process in migration_precreate_load.
Signed-off-by: Steve Sista
On 5/6/2024 7:17 PM, Fabiano Rosas wrote:
Steve Sistare writes:
Define an abstraction SAVEVM_FOREACH to loop over all savevm state
handlers, and replace QTAILQ_FOREACH. Define variants for ALL so
we can loop over all handlers vs a subset of handlers in a subsequent
patch, but at this time the
One thing to keep in mind here (despite me not having any hardware to
test) was that one of the original goals here
in the RDMA implementation was not simply raw throughput nor raw
latency, but a lack of CPU utilization in kernel
space due to the offload. While it is entirely possible that newer
Am 13. Mai 2024 11:30:04 UTC schrieb "Philippe Mathieu-Daudé"
:
>On 13/5/24 12:11, Bernhard Beschow wrote:
>> Signed-off-by: Bernhard Beschow
>> ---
>> hw/timer/imx_gpt.c| 18 +-
>> hw/timer/trace-events | 6 ++
>> 2 files changed, 11 insertions(+), 13 deletions(-)
Steve Sistare writes:
> Create a common subroutine to allocate a RAMBlock, de-duping the code to
> populate its common fields. Add a trace point for good measure.
> No functional change.
>
> Signed-off-by: Steve Sistare
> ---
> system/physmem.c| 47 ++---
Hi Steve,
We found that this specific change in particular ("migration: stop vm
for cpr") fixes a bug that we've identified in testing back-to-back live
updates in a lab environment.
More specifically, *without* this change (which is not available in
8.2.2, but *is* available in 9.0.0) cause
On 4/24/24 16:31, Richard Henderson wrote:
We can delay the computation of haddr until the plugin
actually requests it.
Signed-off-by: Richard Henderson
---
include/qemu/plugin.h | 4
accel/tcg/plugin-gen.c | 20
plugins/api.c | 25 ++
Markus Armbruster writes:
> Functions that use an Error **errp parameter to return errors should
> not also report them to the user, because reporting is the caller's
> job. When the caller does, the error is reported twice. When it
> doesn't (because it recovered from the error), there is no e
Hi,
On Monday, May 13, 2024 7:53:40 PM GMT+5:30 Eugenio Perez Martin wrote:
> [...]
> > I have started working on implementing packed virtqueue support in
> > vhost-shadow-virtqueue.c. The changes I have made so far are very
> > minimal. I have one confusion as well.
> >
> > In "vhost_svq_add()"
On Mon, May 13, 2024, James Gowans wrote:
> On Mon, 2024-05-13 at 08:39 -0700, Sean Christopherson wrote:
> > > Sean, you mentioned that you envision guest_memfd also supporting
> > > non-CoCo VMs.
> > > Do you have some thoughts about how to make the above cases work in the
> > > guest_memfd cont
On 5/13/24 15:14, Avihai Horon wrote:
On 06/05/2024 12:20, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
Change commit title:
vfio: Extend migration_file_set_error() with Error** argument
to:
migration: Extend migration_file_set_error() with Error* argume
On 5/13/24 15:08, Avihai Horon wrote:
On 06/05/2024 12:20, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
This allows to update the Error argument of the VFIO log_global_start()
handler. Errors detected when device level logging is started will be
propagated
Hi Marc-André,
This commit looks good but are you planning to merge this before "ui/console:
Private QemuDmaBuf struct"?
It will cause some conflict. Let me know if rebasing is needed on "ui/console:
Private QemuDmaBuf struct".
> -Original Message-
> From: marcandre.lur...@redhat.com
>
On 5/13/24 15:03, Avihai Horon wrote:
Hi Cedric,
On 06/05/2024 12:20, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
We will use the Error object to improve error reporting in the
.log_global*() handlers of VFIO. Add documentation while at it.
First of all,
On Mon, 2024-05-13 at 08:39 -0700, Sean Christopherson wrote:
> > Sean, you mentioned that you envision guest_memfd also supporting non-CoCo
> > VMs.
> > Do you have some thoughts about how to make the above cases work in the
> > guest_memfd context?
>
> Yes. The hand-wavy plan is to allow selec
On Mon, May 13, 2024, Patrick Roy wrote:
> For non-CoCo VMs, where memory is not encrypted, and the threat model assumes
> a
> trusted host userspace, we would like to avoid changing the VM model so
> completely. If we adopt CoCo’s approaches where KVM / Userspace touches guest
> memory we would
Yuan Liu writes:
> each qpl job is used to (de)compress a normal page and it can
> be processed independently by the IAA hardware. All qpl jobs
> are submitted to the hardware at once, and wait for all jobs
> completion. If hardware path(IAA) is not available, use software
> for compression and d
Philippe Mathieu-Daudé writes:
> On 13/5/24 16:16, Markus Armbruster wrote:
>> create_win_dump() and write_run report qemu_write_full() failure to
>> their callers as
>> An IO error has occurred
>> The errno set by qemu_write_full() is lost.
>> Improve this to
>> win-dump: failed to wri
On 13/5/24 16:45, Markus Armbruster wrote:
Philippe Mathieu-Daudé writes:
On 13/5/24 16:17, Markus Armbruster wrote:
qmp_memsave() and qmp_pmemsave() report fwrite() error as
An IO error has occurred
Improve this to
writing memory to '' failed
Signed-off-by: Markus Armbruster
---
On 13/5/24 16:48, Markus Armbruster wrote:
Philippe Mathieu-Daudé writes:
On 13/5/24 16:16, Markus Armbruster wrote:
create_win_dump() and write_run report qemu_write_full() failure to
their callers as
An IO error has occurred
The errno set by qemu_write_full() is lost.
Improve this to
On 13/05/2024 17:43, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
On 5/13/24 16:34, Avihai Horon wrote:
On 13/05/2024 17:01, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
On 5/9/24 11:09, Avihai Horon wrote:
Emit VFIO
Philippe Mathieu-Daudé writes:
> On 13/5/24 16:17, Markus Armbruster wrote:
>> qmp_memsave() and qmp_pmemsave() report fwrite() error as
>> An IO error has occurred
>> Improve this to
>> writing memory to '' failed
>> Signed-off-by: Markus Armbruster
>> ---
>> system/cpus.c | 6 -
On 5/13/24 16:34, Avihai Horon wrote:
On 13/05/2024 17:01, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
On 5/9/24 11:09, Avihai Horon wrote:
Emit VFIO migration QAPI event when a VFIO device changes its migration
state. This can be used by management appli
On 5/13/24 03:11, Bernhard Beschow wrote:
The same statement is executed unconditionally right before the if statement.
Cc: Guenter Roeck
Signed-off-by: Bernhard Beschow
---
The duplicate line may indicate a bug. I'm not familiar with the code, so this
patch may go into the wrong direction.
On Mon, May 13, 2024 at 10:22:22PM +0800, Zhao Liu wrote:
> Cc Paolo for x86 topology part
>
> Hi Daniel,
>
> On Mon, May 13, 2024 at 01:33:57PM +0100, Daniel P. Berrangé wrote:
> > Date: Mon, 13 May 2024 13:33:57 +0100
> > From: "Daniel P. Berrangé"
> > Subject: [PATCH 1/2] hw/core: allow param
On 13/05/2024 17:13, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
On 5/9/24 11:09, Avihai Horon wrote:
When migrating a VFIO device that supports pre-copy, it is transitioned
to STOP_COPY twice: once in vfio_vmstate_change() and second time in
vfio_save_co
On 13/05/2024 17:01, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
On 5/9/24 11:09, Avihai Horon wrote:
Emit VFIO migration QAPI event when a VFIO device changes its migration
state. This can be used by management applications to get updates on the
current
On Mon, May 13, 2024 at 04:22:00PM +0200, Thomas Huth wrote:
> On 13/05/2024 14.11, Daniel P. Berrangé wrote:
> > On Mon, May 13, 2024 at 02:05:16PM +0200, Thomas Huth wrote:
> > > On 13/05/2024 12.28, Daniel P. Berrangé wrote:
> > > > A better way to handle this would be to define a separate proje
On 13/5/24 16:17, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster
---
include/qapi/qmp/qerror.h | 3 ---
1 file changed, 3 deletions(-)
One less!
Reviewed-by: Philippe Mathieu-Daudé
On 13/5/24 16:17, Markus Armbruster wrote:
qmp_memsave() and qmp_pmemsave() report fwrite() error as
An IO error has occurred
Improve this to
writing memory to '' failed
Signed-off-by: Markus Armbruster
---
system/cpus.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-
On 06/05/2024 12:20, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
vfio_set_migration_error() sets the 'return' error on the migration
stream if a migration is in progress. To improve error reporting, add
a new Error* argument to also set the Error object on
On 13/5/24 16:16, Markus Armbruster wrote:
external_snapshot_action() reports bdrv_flush() failure to its caller
as
An IO error has occurred
The errno code returned by bdrv_flush() is lost.
Improve this to
Write to node '' failed:
Signed-off-by: Markus Armbruster
---
blockdev.c
On Mon, May 13, 2024 at 3:49 PM Sahil wrote:
>
> Hi,
>
> On Wednesday, May 8, 2024 8:53:12 AM GMT+5:30 Sahil wrote:
> > Hi,
> >
> > On Tuesday, May 7, 2024 12:44:33 PM IST Eugenio Perez Martin wrote:
> > > [...]
> > >
> > > > Shall I start by implementing a mechanism to check if the feature bit
>
On 13/5/24 16:17, Markus Armbruster wrote:
vmdk_init_extent() reports blk_co_pwrite() failure to its caller as
An IO error has occurred
The errno code returned by blk_co_pwrite() is lost.
Improve this to
failed to write VMDK :
Signed-off-by: Markus Armbruster
---
block/vmdk.c |
On 13/5/24 16:17, Markus Armbruster wrote:
Functions that use an Error **errp parameter to return errors should
not also report them to the user, because reporting is the caller's
job. When the caller does, the error is reported twice. When it
doesn't (because it recovered from the error), ther
On 13/5/24 16:16, Markus Armbruster wrote:
create_win_dump() and write_run report qemu_write_full() failure to
their callers as
An IO error has occurred
The errno set by qemu_write_full() is lost.
Improve this to
win-dump: failed to write header:
and
win-dump: failed to save
On 13/05/2024 14.11, Daniel P. Berrangé wrote:
On Mon, May 13, 2024 at 02:05:16PM +0200, Thomas Huth wrote:
On 13/05/2024 12.28, Daniel P. Berrangé wrote:
On Mon, May 13, 2024 at 12:22:50PM +0200, Thomas Huth wrote:
We don't need C++ for the normal QEMU builds anymore, so installing
g++ in eac
On 5/9/24 11:09, Avihai Horon wrote:
When migrating a VFIO device that supports pre-copy, it is transitioned
to STOP_COPY twice: once in vfio_vmstate_change() and second time in
vfio_save_complete_precopy().
The second transition is harmless, as it's a STOP_COPY->STOP_COPY no-op
transition. Howe
qmp_memsave() and qmp_pmemsave() report fwrite() error as
An IO error has occurred
Improve this to
writing memory to '' failed
Signed-off-by: Markus Armbruster
---
system/cpus.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/system/cpus.c b/system/cpus.c
ind
external_snapshot_action() reports bdrv_flush() failure to its caller
as
An IO error has occurred
The errno code returned by bdrv_flush() is lost.
Improve this to
Write to node '' failed:
Signed-off-by: Markus Armbruster
---
blockdev.c | 6 --
1 file changed, 4 insertions(+), 2
Cc'ing Pierrick & Alex on this last one :)
On 25/4/24 01:31, Richard Henderson wrote:
We can delay the computation of haddr until the plugin
actually requests it.
Signed-off-by: Richard Henderson
---
include/qemu/plugin.h | 4
accel/tcg/plugin-gen.c | 20
plugin
Markus Armbruster (6):
block: Improve error message when external snapshot can't flush
dump/win_dump: Improve error messages on write error
block/vmdk: Improve error messages on extent write error
cpus: Improve error messages on memsave, pmemsave write error
migration: Rephrase message on
create_win_dump() and write_run report qemu_write_full() failure to
their callers as
An IO error has occurred
The errno set by qemu_write_full() is lost.
Improve this to
win-dump: failed to write header:
and
win-dump: failed to save memory:
This matches how dump.c reports simil
Functions that use an Error **errp parameter to return errors should
not also report them to the user, because reporting is the caller's
job. When the caller does, the error is reported twice. When it
doesn't (because it recovered from the error), there is no error to
report, i.e. the report is b
vmdk_init_extent() reports blk_co_pwrite() failure to its caller as
An IO error has occurred
The errno code returned by blk_co_pwrite() is lost.
Improve this to
failed to write VMDK :
Signed-off-by: Markus Armbruster
---
block/vmdk.c | 10 +-
1 file changed, 5 insertions(+),
Signed-off-by: Markus Armbruster
---
include/qapi/qmp/qerror.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h
index 00b18e9082..bc9116f76a 100644
--- a/include/qapi/qmp/qerror.h
+++ b/include/qapi/qmp/qerror.h
@@ -20,9 +20,6 @@
#define
On 13/5/24 15:23, Richard Henderson wrote:
On 5/13/24 13:18, Philippe Mathieu-Daudé wrote:
Hi Richard,
On 13/5/24 09:46, Richard Henderson wrote:
Signed-off-by: Richard Henderson
---
target/hppa/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/hppa/tra
On 5/9/24 11:09, Avihai Horon wrote:
Add a new QAPI event for VFIO migration. This event will be emitted when
a VFIO device changes its migration state, for example, during migration
or when stopping/starting the guest.
This event can be used by management applications to get updates on the
curr
Cc Paolo for x86 topology part
Hi Daniel,
On Mon, May 13, 2024 at 01:33:57PM +0100, Daniel P. Berrangé wrote:
> Date: Mon, 13 May 2024 13:33:57 +0100
> From: "Daniel P. Berrangé"
> Subject: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any
> machine
>
> This effectively reverts
>
On 5/9/24 11:09, Avihai Horon wrote:
Emit VFIO migration QAPI event when a VFIO device changes its migration
state. This can be used by management applications to get updates on the
current state of the VFIO device for their own purposes.
A new per VFIO device capability, "migration-events", is
Hi Mostafa,
On 29/04/2024 04:23, Mostafa Saleh wrote:
Future improvements:
=
1) One small improvement, that I don’t think it’s worth the extra
complexity, is in case of Stage-1 TLB miss for nested translation,
we can do stage-1 walk and lookup for stage-2 TLBs, instea
On a Monday in 2024, Daniel P. Berrangé wrote:
Since QEMU 9.0, users are complaining that depecation messages are shown
for every VM libvirt starts. This is due to the newly introduced
deprecation of 'parameter=1' for -smp. This proposes reverting that, see
the 1st patch for further commentary.
On 06/05/2024 12:20, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
vfio_save_complete_precopy() currently returns before doing the trace
event. Change that.
Signed-off-by: Cédric Le Goater
Reviewed-by: Avihai Horon
---
hw/vfio/migration.c | 3 ---
On 06/05/2024 12:20, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
Let the callers do the error reporting. Add documentation while at it.
Signed-off-by: Cédric Le Goater
---
Changes in v5:
- Replaced error_setg() by error_setg_errno() in
vfio_dev
On 10/5/24 16:10, Rayhan Faizel wrote:
Four mailbox properties are implemented as follows:
1. Customer OTP: GET_CUSTOMER_OTP and SET_CUSTOMER_OTP
2. Device-specific private key: GET_PRIVATE_KEY and
SET_PRIVATE_KEY.
The customer OTP is located in the rows 36-43. The device-specific private key
is
Hi,
On Wednesday, May 8, 2024 8:53:12 AM GMT+5:30 Sahil wrote:
> Hi,
>
> On Tuesday, May 7, 2024 12:44:33 PM IST Eugenio Perez Martin wrote:
> > [...]
> >
> > > Shall I start by implementing a mechanism to check if the feature bit
> > > "VIRTIO_F_RING_PACKED" is set (using "virtio_vdev_has_featu
1 - 100 of 262 matches
Mail list logo
