On Tue, Mar 26, 2024 at 10:52 PM Huang, Ying wrote:
>
> "Ho-Ren (Jack) Chuang" writes:
>
> > The current implementation treats emulated memory devices, such as
> > CXL1.1 type3 memory, as normal DRAM when they are emulated as normal memory
> > (E820_TYPE_RAM). However, these emulated devices have
For indirect descriptors the elelm->ndescs was one,
For direct descriptors the elele->ndesc was the numbe of entries.
elem->ndescs = (desc_cache == &indirect_desc_cache) ? 1 : elem_entries;
When flushing multiple elemes,
the used_idx should be added to all the privious numeric entry value.
Signed
On Wed, Mar 27, 2024 at 11:05 AM Jason Wang wrote:
>
> Hi Cindy:
>
> On Wed, Mar 27, 2024 at 9:29 AM Cindy Lu wrote:
> >
> > we need a crash in Non-standard image, here is the jira for this
> > https://issues.redhat.com/browse/RHEL-28522
> > The root cause of the issue is that an IRQFD was used
On 3/22/24 06:14, Philippe Mathieu-Daudé wrote:
Slightly simplify by checking NEED_CPU_H definition in header.
Signed-off-by: Philippe Mathieu-Daudé
---
include/gdbstub/helpers.h | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
Reviewed-by: Richard Henderson
r~
On 3/22/24 06:14, Philippe Mathieu-Daudé wrote:
'NEED_CPU_H' guard target-specific code; it is defined by meson
altogether with the 'CONFIG_TARGET' definition. Rename NEED_CPU_H
as COMPILING_PER_TARGET to clarify its meaning.
Mechanical change running:
$ sed -i s/NEED_CPU_H/COMPILING_PER_TARG
On 3/25/24 09:22, Ilya Leoshkevich wrote:
v1:
https://lore.kernel.org/qemu-devel/20240325153313.526888-1-...@linux.ibm.com/
v1 -> v2: Remove an unnecessary ifdef, add R-Bs (Richard).
Hi,
I noticed that while shmat() now works with /proc/self/maps,
shmat(NULL) got broken. This series fixes that
"Ho-Ren (Jack) Chuang" writes:
> The current implementation treats emulated memory devices, such as
> CXL1.1 type3 memory, as normal DRAM when they are emulated as normal memory
> (E820_TYPE_RAM). However, these emulated devices have different
> characteristics than traditional DRAM, making it im
On 3/26/24 21:32, Peter Maydell wrote:
On Tue, 12 Mar 2024 at 17:11, Nicholas Piggin wrote:
From: Harsh Prateek Bora
Introduce the nested PAPR hcalls:
- H_GUEST_GET_STATE which is used to get state of a nested guest or
a guest VCPU. The value field for each element in the requ
Since different memory devices require finding, allocating, and putting
memory types, these common steps are abstracted in this patch,
enhancing the scalability and conciseness of the code.
Signed-off-by: Ho-Ren (Jack) Chuang
---
drivers/dax/kmem.c | 20 ++--
include/li
The current implementation treats emulated memory devices, such as
CXL1.1 type3 memory, as normal DRAM when they are emulated as normal memory
(E820_TYPE_RAM). However, these emulated devices have different
characteristics than traditional DRAM, making it important to
distinguish them. Thus, we mod
When a memory device, such as CXL1.1 type3 memory, is emulated as
normal memory (E820_TYPE_RAM), the memory device is indistinguishable
from normal DRAM in terms of memory tiering with the current implementation.
The current memory tiering assigns all detected normal memory nodes
to the same DRAM t
On 2024/03/27 12:24, Jason Wang wrote:
On Wed, Mar 27, 2024 at 11:11 AM Akihiko Odaki wrote:
On 2024/03/27 12:06, Jason Wang wrote:
On Wed, Mar 27, 2024 at 11:05 AM Akihiko Odaki wrote:
On 2024/03/27 11:59, Jason Wang wrote:
On Wed, Mar 27, 2024 at 10:53 AM Akihiko Odaki wrote:
On 2024
On Wed, Mar 27, 2024 at 11:11 AM Akihiko Odaki wrote:
>
> On 2024/03/27 12:06, Jason Wang wrote:
> > On Wed, Mar 27, 2024 at 11:05 AM Akihiko Odaki
> > wrote:
> >>
> >> On 2024/03/27 11:59, Jason Wang wrote:
> >>> On Wed, Mar 27, 2024 at 10:53 AM Akihiko Odaki
> >>> wrote:
>
> On 202
On 2024/03/27 12:06, Jason Wang wrote:
On Wed, Mar 27, 2024 at 11:05 AM Akihiko Odaki wrote:
On 2024/03/27 11:59, Jason Wang wrote:
On Wed, Mar 27, 2024 at 10:53 AM Akihiko Odaki wrote:
On 2024/03/27 11:50, Jason Wang wrote:
On Tue, Mar 26, 2024 at 3:04 PM Akihiko Odaki wrote:
On 2024/
When running in a stubdomain, the config space access via sysfs needs to
use BDF as seen inside stubdomain (connected via xen-pcifront), which is
different from the real BDF. For other purposes (hypercall parameters
etc), the real BDF needs to be used.
Get the in-stubdomain BDF by looking up releva
On Wed, Mar 27, 2024 at 11:05 AM Akihiko Odaki wrote:
>
> On 2024/03/27 11:59, Jason Wang wrote:
> > On Wed, Mar 27, 2024 at 10:53 AM Akihiko Odaki
> > wrote:
> >>
> >> On 2024/03/27 11:50, Jason Wang wrote:
> >>> On Tue, Mar 26, 2024 at 3:04 PM Akihiko Odaki
> >>> wrote:
>
> On 2024
Introduce global xen_is_stubdomain variable when qemu is running inside
a stubdomain instead of dom0. This will be relevant for subsequent
patches, as few things like accessing PCI config space need to be done
differently.
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v3:
- move to xen
This is minimal set of changes necessary to run Xen device model inside a
stubdomain and still support PCI passthrough.
Marek Marczykowski-Górecki (2):
hw/xen: detect when running inside stubdomain
xen: fix stubdom PCI addr
hw/i386/xen/xen-hvm.c| 22 +++-
hw/xen/xen-host-pci-
On 2024/03/27 11:59, Jason Wang wrote:
On Wed, Mar 27, 2024 at 10:53 AM Akihiko Odaki wrote:
On 2024/03/27 11:50, Jason Wang wrote:
On Tue, Mar 26, 2024 at 3:04 PM Akihiko Odaki wrote:
On 2024/03/26 15:51, Jason Wang wrote:
On Sun, Mar 24, 2024 at 4:32 PM Akihiko Odaki wrote:
It is inc
Hi Cindy:
On Wed, Mar 27, 2024 at 9:29 AM Cindy Lu wrote:
>
> we need a crash in Non-standard image, here is the jira for this
> https://issues.redhat.com/browse/RHEL-28522
> The root cause of the issue is that an IRQFD was used without initialization..
>
> During the booting process of the Vyat
On 3/25/2024 10:14 PM, Paolo Bonzini wrote:
From: Gerd Hoffmann
Allows to set guest-phys-bits (cpuid leaf 8008, eax[23:16])
via -cpu $model,guest-phys-bits=$nr.
Signed-off-by: Gerd Hoffmann
Message-ID: <20240318155336.156197-3-kra...@redhat.com>
Signed-off-by: Paolo Bonzini
Reviewed-by
On Wed, Mar 27, 2024 at 10:53 AM Akihiko Odaki wrote:
>
> On 2024/03/27 11:50, Jason Wang wrote:
> > On Tue, Mar 26, 2024 at 3:04 PM Akihiko Odaki
> > wrote:
> >>
> >> On 2024/03/26 15:51, Jason Wang wrote:
> >>> On Sun, Mar 24, 2024 at 4:32 PM Akihiko Odaki
> >>> wrote:
>
> It is in
On Wed, Mar 27, 2024 at 9:29 AM Cindy Lu wrote:
>
> Only the vdpa device support configure interrupt, we need to disable the
> configure interrupt process in all other device.
I think we need to tweak the terminology here at least.
It's not about configure interrupt, it's about whether or not we
On 2024/03/27 11:50, Jason Wang wrote:
On Tue, Mar 26, 2024 at 3:04 PM Akihiko Odaki wrote:
On 2024/03/26 15:51, Jason Wang wrote:
On Sun, Mar 24, 2024 at 4:32 PM Akihiko Odaki wrote:
It is incorrect to have the VIRTIO_NET_HDR_F_NEEDS_CSUM set when
checksum offloading is disabled so clear
On Tue, Mar 26, 2024 at 3:04 PM Akihiko Odaki wrote:
>
> On 2024/03/26 15:51, Jason Wang wrote:
> > On Sun, Mar 24, 2024 at 4:32 PM Akihiko Odaki
> > wrote:
> >>
> >> It is incorrect to have the VIRTIO_NET_HDR_F_NEEDS_CSUM set when
> >> checksum offloading is disabled so clear the bit. Set the
>
在 2024/3/26 下午11:19, Breno Leitao 写道:
There is a bug when setting the RSS options in virtio_net that can break
the whole machine, getting the kernel into an infinite loop.
Running the following command in any QEMU virtual machine with virtionet
will reproduce this problem:
# ethtool -X
> -Original Message-
> From: Peter Xu
> Sent: Wednesday, March 27, 2024 1:58 AM
> To: Liu, Yuan1
> Cc: faro...@suse.de; qemu-devel@nongnu.org; hao.xi...@bytedance.com;
> bryan.zh...@bytedance.com; Zou, Nanhai
> Subject: Re: [PATCH v5 1/7] docs/migration: add qpl compression feature
>
>
Some recent changes made RSS unfunctional so here are fixes.
Signed-off-by: Akihiko Odaki
---
Changes in v2:
- Fixed a potential problem with big-endian hosts.
- Link to v1:
https://lore.kernel.org/r/20240326-vhost-v1-0-09bd85b1b...@daynix.com
---
Akihiko Odaki (2):
virtio-net: Fix vhost
virtio_net_guest_notifier_pending() and virtio_net_guest_notifier_mask()
checked VIRTIO_NET_F_MQ to know there are multiple queues, but
VIRTIO_NET_F_RSS also enables multiple queues. Refer to n->multiqueue,
which is set to true either of VIRTIO_NET_F_MQ or VIRTIO_NET_F_RSS is
enabled.
Fixes: 68b0a
The kernel documentation says:
> The value stored can be of any size, however, all array elements are
> aligned to 8 bytes.
https://www.kernel.org/doc/html/v6.8/bpf/map_array.html
Fixes: 333b3e5fab75 ("ebpf: Added eBPF map update through mmap.")
Signed-off-by: Akihiko Odaki
---
ebpf/ebpf_rss.c |
The arguments in MESONINTROSPECT are quoted with shlex.quote() so it
must be parsed with shlex.split().
meson<1.4.0 quotes arguments in MESONINTROSPECT with the
Windows-specific format on the platform, which is incompatible with
shlex.split(). meson>=1.4.0 uses shlex.quote() also on the platform a
: Paolo Bonzini
Cc: Cleber Rosa
Cc: John Snow
Cc: Michael Tokarev
Changes in v3:
- Ensured meson>=1.4.0 on Windows.
- Link to v2:
https://lore.kernel.org/r/20240326-meson-v2-0-d9f900377...@daynix.com
Changes in v2:
- Added patch "buildsys: Bump known good meson version to v1.4.0".
In 3, 6, 12 interleave ways, we could not access cxl memory properly,
and when the process is running on it, a 'segmentation fault' error will
occur.
According to the CXL specification '8.2.4.20.13 Decoder Protection',
there are two branches to convert HPA to DPA:
b1: Decoder[m].IW < 8 (for 1, 2,
Only the vdpa device support configure interrupt, we need to disable the
configure interrupt process in all other device.
In order to achieve this, I added a check in the virtio_net_device_realize().
When the peer's type is vdpa, the value of config_irq_enabled in the structure
VirtIODevice will se
If config_irq_enabled is not true, it means that configure interrupt is
not supported. Therefore, the config vector will not be handled during
the interrupt process.
Signed-off-by: Cindy Lu
---
hw/virtio/virtio-pci.c | 41 +++--
1 file changed, 23 insertions(+
we need a crash in Non-standard image, here is the jira for this
https://issues.redhat.com/browse/RHEL-28522
The root cause of the issue is that an IRQFD was used without initialization..
During the booting process of the Vyatta image, the behavior of the called
function in qemu is as follows:
On Tue, Mar 26, 2024 at 05:06:50PM +, Anthony PERARD wrote:
> On Tue, Mar 05, 2024 at 08:12:29PM +0100, Marek Marczykowski-Górecki wrote:
> > diff --git a/hw/xen/xen-legacy-backend.c b/hw/xen/xen-legacy-backend.c
> > index 124dd5f3d6..6bd4e6eb2f 100644
> > --- a/hw/xen/xen-legacy-backend.c
> >
> -Original Message-
> From: Philippe Mathieu-Daudé
> Sent: Tuesday, March 26, 2024 8:04 PM
> To: Peter Maydell
> Cc: Pierrick Bouvier ; Yao, Xingtao/姚 幸涛
> ; qemu-devel@nongnu.org; alex.ben...@linaro.org;
> erdn...@crans.org; ma.mando...@gmail.com
> Subject: Re: [PATCH v3] contrib/plug
Hello,
On behalf of the QEMU Team, I'd like to announce the availability of the
second release candidate for the QEMU 9.0 release. This release is meant
for testing purposes and should not be used in a production environment.
http://download.qemu.org/qemu-9.0.0-rc1.tar.xz
http://download.qemu
Adds an integration test for 'qatzip'.
Signed-off-by: Bryan Zhang
Signed-off-by: Hao Xiang
---
Revision: This commit now does some parameter setting to test that
changing the 'multifd-qatzip-level' parameter works, and to enable
software fallback so that the QATzip test can be run even if the te
Uses QAT to offload deflate compression and decompression in the
'qatzip' compression method for multifd migration.
Signed-off-by: Bryan Zhang
Signed-off-by: Hao Xiang
---
migration/multifd-qatzip.c | 331 +
1 file changed, 298 insertions(+), 33 deletions(-)
Adds support for 'qatzip' as an option for the multifd compression
method parameter, but copy-pastes the no-op logic to leave the actual
methods effectively unimplemented. This is in preparation of a subsequent
commit that will implement actually using QAT for compression and
decompression.
Signed
Add a 'qatzip' feature, which is automatically disabled, and which
depends on the QATzip library if enabled.
Signed-off-by: Bryan Zhang
Signed-off-by: Hao Xiang
---
meson.build | 10 ++
meson_options.txt | 2 ++
scripts/meson-buildoptions.sh | 3 +++
3 fi
Adds support for migration parameters to control QATzip compression
level and to enable/disable software fallback when QAT hardware is
unavailable. This is a preparatory commit for a subsequent commit that
will actually use QATzip compression.
Signed-off-by: Bryan Zhang
Signed-off-by: Hao Xiang
The 'sign' computation is attempting to locate the sign bit that has
been repeated, so that we can test if that bit is known zero. That
computation can be zero if there are no known sign repetitions.
Cc: qemu-sta...@nongnu.org
Fixes: 93a967fbb57 ("tcg/optimize: Propagate sign info for shifting")
Het Gala writes:
Some comments, mostly just thinking out loud...
> For --> migrate
> //
> //O:/...
>
> For --> validate
> ///O:/O:/
> /O:/O:/...
Do we need an optional 'capability' element? I'm not sure how practical
is to leave that as 'others', because that puts it at the end of the
str
On 3/26/24 19:10, Richard Henderson wrote:
The 32-bit 7300LC CPU and the 64-bit PCX-W 8500 CPU use different
I initially should have used the correct naming in my patch.
So this sentence above should read:
The 32-bit PA-7300LC (PCX-L2) CPU and the 64-bit PA8700 (PCX-W2) CPU use
different
On 3/26/24 19:10, Richard Henderson wrote:
This operation is trivial and does not require a helper.
Signed-off-by: Richard Henderson
Reviewed-by: Helge Deller
Helge
---
target/hppa/helper.h | 1 -
target/hppa/sys_helper.c | 4 ++--
target/hppa/translate.c | 17 +
On 3/26/24 19:10, Richard Henderson wrote:
Split trans_diag into per-operation functions.
Signed-off-by: Richard Henderson
Reviewed-by: Helge Deller
Helge
---
target/hppa/insns.decode | 8 +++-
target/hppa/translate.c | 34 +-
2 files changed, 28
On 26/3/24 19:35, Richard Henderson wrote:
Along this path we have already skipped the insn to be
nullified, so the subsequent insn should be executed.
Cc: qemu-sta...@nongnu.org
Reported-by: Sven Schnelle
Signed-off-by: Richard Henderson
---
target/hppa/translate.c | 1 +
1 file changed, 1
Hi Maintainers, this is my first attempt trying to standardise the
grammar around migration qtests. I am not sure at multiple places on
whether a particular string is placed at the right place with the
right grammar. Please comment on the patch, if anything you feel can
be improvised in the existi
On Tue, 26 Mar 2024 at 13:54, Kevin Wolf wrote:
>
> The following changes since commit 096ae430a7b5a704af4cd94dca7200d6cb069991:
>
> Merge tag 'pull-qapi-2024-03-26' of https://repo.or.cz/qemu/armbru into
> staging (2024-03-26 09:50:21 +)
>
> are available in the Git repository at:
>
> ht
available in the Git repository at:
>
> https://github.com/philmd/qemu.git tags/hw-misc-20240326
>
> for you to fetch changes up to ccebb9ae352eea63cb1491cb829e4cd0f7576f1c:
>
> ui/cocoa: Use NSTrackingInVisibleRect (2024-03-26 14:32:54 +0100)
>
> A pair of &
For --> migrate
//
//O:/...
For --> validate
///O:/O:/
/O:/O:/...
test-type:: migrate | validate
migration-mode
a. migrate --> :: precopy | postcopy | multifd
b. validate -->:: (what to validate)
methods :: preempt | recovery | reboot | suspend | simple
Richard Henderson writes:
> Along this path we have already skipped the insn to be
> nullified, so the subsequent insn should be executed.
>
> Cc: qemu-sta...@nongnu.org
> Reported-by: Sven Schnelle
> Signed-off-by: Richard Henderson
> ---
> target/hppa/translate.c | 1 +
> 1 file changed, 1 i
On 3/26/24 08:22, Eric Auger wrote:
From: Haibo Xu
Up to now virt support on guest has been only supported with TCG.
Now it becomes feasible to use it with KVM acceleration.
Also check only in-kernel GICv3 is used along with KVM EL2.
Signed-off-by: Haibo Xu
Signed-off-by: Miguel Luis
Signed-of
On 3/26/24 08:22, Eric Auger wrote:
From: Haibo Xu
KVM_CAP_ARM_EL2 must be supported by the cpu to enable ARM_FEATURE_EL2.
In case the host does support NV, expose the feature.
Signed-off-by: Haibo Xu
Signed-off-by: Miguel Luis
Signed-off-by: Eric Auger
---
v2 -> v3:
- check pmu->has_el2 on kv
On 3/26/24 2:34 PM, Eugenio Perez Martin wrote:
On Tue, Mar 26, 2024 at 5:49 PM Jonah Palmer wrote:
On 3/25/24 4:33 PM, Eugenio Perez Martin wrote:
On Mon, Mar 25, 2024 at 5:52 PM Jonah Palmer wrote:
On 3/22/24 7:18 AM, Eugenio Perez Martin wrote:
On Thu, Mar 21, 2024 at 4:57 PM Jo
On 3/26/24 02:34, Pierrick Bouvier wrote:
Count number of tb and insn executed using a conditional callback. We
ensure the callback has been called expected number of time (per vcpu).
Signed-off-by: Pierrick Bouvier
---
tests/plugin/inline.c | 89 +--
1
On 3/26/24 02:34, Pierrick Bouvier wrote:
Signed-off-by: Pierrick Bouvier
---
include/qemu/plugin.h | 1 -
plugins/plugin.h | 4 +++-
plugins/core.c| 13 +++--
3 files changed, 10 insertions(+), 8 deletions(-)
Reviewed-by: Richard Henderson
r~
On Tue, Mar 26, 2024 at 5:49 PM Jonah Palmer wrote:
>
>
>
> On 3/25/24 4:33 PM, Eugenio Perez Martin wrote:
> > On Mon, Mar 25, 2024 at 5:52 PM Jonah Palmer
> > wrote:
> >>
> >>
> >>
> >> On 3/22/24 7:18 AM, Eugenio Perez Martin wrote:
> >>> On Thu, Mar 21, 2024 at 4:57 PM Jonah Palmer
> >>> w
Along this path we have already skipped the insn to be
nullified, so the subsequent insn should be executed.
Cc: qemu-sta...@nongnu.org
Reported-by: Sven Schnelle
Signed-off-by: Richard Henderson
---
target/hppa/translate.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/hppa/transla
From: Haibo Xu
Introduce query support for KVM_CAP_ARM_EL2.
Signed-off-by: Haibo Xu
Signed-off-by: Miguel Luis
Signed-off-by: Eric Auger
Reviewed-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
---
target/arm/kvm.c | 5 +
target/arm/kvm_arm.h | 12
2 files c
From: Haibo Xu
Allow virt arm machine to set the interrupt ID for the KVM
GIC maintenance interrupt.
This setting must be done before the KVM_DEV_ARM_VGIC_CTRL_INIT
hence the choice to perform the setting in the GICv3 realize
instead of proceeding the same way as kvm_arm_pmu_set_irq().
Signed-o
From: Haibo Xu
Up to now virt support on guest has been only supported with TCG.
Now it becomes feasible to use it with KVM acceleration.
Also check only in-kernel GICv3 is used along with KVM EL2.
Signed-off-by: Haibo Xu
Signed-off-by: Miguel Luis
Signed-off-by: Eric Auger
---
v2 -> v3:
-
From: Haibo Xu
For now let's only import the pieces needed to run NV on KVM.
Later on this will be replaced by a standard and comprehensive
linux header update using scripts/update-linux-headers.sh.
For now the changes are taken from
https://github.com/eauger/linux/tree/nv-6.8-rc1-sr-enforcement
From: Haibo Xu
KVM_CAP_ARM_EL2 must be supported by the cpu to enable ARM_FEATURE_EL2.
In case the host does support NV, expose the feature.
Signed-off-by: Haibo Xu
Signed-off-by: Miguel Luis
Signed-off-by: Eric Auger
---
v2 -> v3:
- check pmu->has_el2 on kvm_arch_init_vcpu() when setting
This series adds ARM Nested Virtualization support in KVM mode.
This is a respin of previous contributions from Miguel [1] and Haibo [2].
This was tested with Marc's v11 [3] on Ampere HW with fedora L1 guest and
L2 guests booted without EDK2. However it does not work yet with
EDK2 but it looks unr
Don't do all the decode for diag in trans_diag; do it in
decodetree instead. Add {get,put}shadowregs for ODE tests.
r~
Richard Henderson (3):
target/hppa: Generate getshadowregs inline
target/hppa: Move diag argument handling to decodetree
target/hppa: Fix diag instructions to set/restore
Split trans_diag into per-operation functions.
Signed-off-by: Richard Henderson
---
target/hppa/insns.decode | 8 +++-
target/hppa/translate.c | 34 +-
2 files changed, 28 insertions(+), 14 deletions(-)
diff --git a/target/hppa/insns.decode b/target/hppa/in
The 32-bit 7300LC CPU and the 64-bit PCX-W 8500 CPU use different
diag instructions to save or restore the CPU registers to/from
the shadow registers.
Implement those per-CPU architecture diag instructions to fix those
parts of the HP ODE testcases (L2DIAG and WDIAG, section 1) which test
the shad
This operation is trivial and does not require a helper.
Signed-off-by: Richard Henderson
---
target/hppa/helper.h | 1 -
target/hppa/sys_helper.c | 4 ++--
target/hppa/translate.c | 17 +
3 files changed, 15 insertions(+), 7 deletions(-)
diff --git a/target/hppa/helper.h
On Wed, Mar 20, 2024 at 12:45:21AM +0800, Yuan Liu wrote:
> add Intel Query Processing Library (QPL) compression method
> introduction
>
> Signed-off-by: Yuan Liu
> Reviewed-by: Nanhai Zou
> ---
> docs/devel/migration/features.rst| 1 +
> docs/devel/migration/qpl-compression.rst | 231
On 3/26/24 14:05, Greg Kurz wrote:
On Tue, 26 Mar 2024 10:26:04 -0300
Daniel Henrique Barboza wrote:
The local 9p driver in virtio-9p-test.c its temporary dir right at the
start of qos-test (via virtio_9p_create_local_test_dir()) and only
deletes it after qos-test is finished (via
virtio_9p
Hi,
On 3/26/24 18:10, Philippe Mathieu-Daudé wrote:
> Similarly to commit 9de9fa5cf2 ("hw/arm/smmu-common: Avoid using
> inlined functions with external linkage"):
>
> None of our code base require / use inlined functions with external
> linkage. Some places use internal inlining in the hot pa
First things first, could you fix the coding style?
Run something like `./scripts/checkpatch.pl @^..` or
`./scripts/checkpatch.pl master..`. Patchew might have run that for you
if the patch series had a cover letter.
On Tue, Mar 05, 2024 at 08:12:30PM +0100, Marek Marczykowski-Górecki wrote:
> di
On 26/03/2024 18.10, Philippe Mathieu-Daudé wrote:
Compilers are clever enough to inline code when necessary.
The only case we accept an inline function is static in
header (we use C, not C++).
Add the -Wstatic-in-inline CPPFLAG to prevent public and
I think this is rather a compiler than a p
On 26/03/2024 18.10, Philippe Mathieu-Daudé wrote:
Since size_to_prdtl() is only used within ahci.c,
declare it statically. This removes the last use
of "inlined function with external linkage". See
previous commit and commit 9de9fa5cf2 for rationale.
Suggested-by: Peter Maydell
Signed-off-by:
On Tue, 26 Mar 2024 at 17:10, Philippe Mathieu-Daudé wrote:
>
> Since size_to_prdtl() is only used within ahci.c,
> declare it statically. This removes the last use
> of "inlined function with external linkage". See
> previous commit and commit 9de9fa5cf2 for rationale.
>
> Suggested-by: Peter May
Similarly to commit 9de9fa5cf2 ("hw/arm/smmu-common: Avoid using
inlined functions with external linkage"):
None of our code base require / use inlined functions with external
linkage. Some places use internal inlining in the hot path. These
two functions are certainly not in any hot path an
Since size_to_prdtl() is only used within ahci.c,
declare it statically. This removes the last use
of "inlined function with external linkage". See
previous commit and commit 9de9fa5cf2 for rationale.
Suggested-by: Peter Maydell
Signed-off-by: Philippe Mathieu-Daudé
---
tests/qtest/libqos/ahci.
See previous commit and commit 9de9fa5cf2 ("Avoid using inlined
functions with external linkage") for rationale.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Peter Maydell
Reviewed-by: Richard Henderson
Message-Id: <20240313184954.42513-3-phi...@linaro.org>
---
target/arm/hvf/hvf.c | 2
Compilers are clever enough to inline code when necessary.
The only case we accept an inline function is static in
header (we use C, not C++).
Add the -Wstatic-in-inline CPPFLAG to prevent public and
inline function to be added in the code base.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by
Oops, I forgot patch 3 needed rework :/ Is it too late to
enforce that flag for 9.0?
Missing review: #3
Since v1:
- Reduce size_to_prdtl() scope
Mostly as a C style cleanup, use -Wstatic-in-inline to avoid
using inlined function with external linkage.
Philippe Mathieu-Daudé (4):
hw/arm/smmu:
On Tue, Mar 05, 2024 at 08:12:29PM +0100, Marek Marczykowski-Górecki wrote:
> diff --git a/hw/xen/xen-legacy-backend.c b/hw/xen/xen-legacy-backend.c
> index 124dd5f3d6..6bd4e6eb2f 100644
> --- a/hw/xen/xen-legacy-backend.c
> +++ b/hw/xen/xen-legacy-backend.c
> @@ -603,6 +603,20 @@ static void xen_s
On Tue, 26 Mar 2024 10:26:04 -0300
Daniel Henrique Barboza wrote:
> The local 9p driver in virtio-9p-test.c its temporary dir right at the
> start of qos-test (via virtio_9p_create_local_test_dir()) and only
> deletes it after qos-test is finished (via
> virtio_9p_remove_local_test_dir()).
>
> T
Richard Henderson writes:
> On 3/25/24 09:33, Sven Schnelle wrote:
>> diff --git a/target/hppa/translate.c b/target/hppa/translate.c
>> index 7546a5f5a2..56c68a7cbe 100644
>> --- a/target/hppa/translate.c
>> +++ b/target/hppa/translate.c
>> @@ -3847,7 +3849,7 @@ static bool trans_be(DisasContext
On 3/25/24 4:33 PM, Eugenio Perez Martin wrote:
On Mon, Mar 25, 2024 at 5:52 PM Jonah Palmer wrote:
On 3/22/24 7:18 AM, Eugenio Perez Martin wrote:
On Thu, Mar 21, 2024 at 4:57 PM Jonah Palmer wrote:
The goal of these patches is to add support to a variety of virtio and
vhost devices
On Tue, 26 Mar 2024 19:01:50 +0300
Michael Tokarev wrote:
> 26.03.2024 18:58, Philippe Mathieu-Daudé:
>
> >> This is not enough. This step is good already, but it lacks default
> >> machine
> >> type selection. In debian we carry a tiny patch to make microvm the
> >> default
> >> machine typ
On Tue, 26 Mar 2024 at 16:03, Michael Tokarev wrote:
>
> 26.03.2024 18:58, Philippe Mathieu-Daudé:
>
> >> This is not enough. This step is good already, but it lacks default
> >> machine
> >> type selection. In debian we carry a tiny patch to make microvm the
> >> default
> >> machine type or
On 26/03/2024 14.26, Daniel Henrique Barboza wrote:
Hi,
Thomas reported in [1] a problem that happened with the RISC-V machine
where some tests from virtio-9p-test.c were failing with '-m slow', i.e.
enabling slow tests.
In the end it wasn't a RISC-V specific problem. It just so happens that
th
On Tue, 26 Mar 2024 13:30:48 +
Mark Cave-Ayland wrote:
> On 26/03/2024 12:51, Igor Mammedov wrote:
>
> > ISAPC machine was introduced 25 years ago and it's a lot of time since
> > such machine was around with real ISA only PC hardware practically defunct.
> > Also it's slowly bit-rots (for e
On Tue, 26 Mar 2024 14:29:58 +0100
Philippe Mathieu-Daudé wrote:
> Hi Igor,
>
> On 26/3/24 14:08, Thomas Huth wrote:
> >
> > s/iaspc/isapc/ in the subject
> >
> > On 26/03/2024 13.51, Igor Mammedov wrote:
> >> ISAPC machine was introduced 25 years ago and it's a lot of time since
> >> such m
Hi,
I am simulating an i2c slave device, listening on address 0x30.
My intention is that in the hosted Linux OS, my driver will communicate with
this (simulated) HW device.
The problem I have is that ever since I start QEMU, and even before the hosted
Linux OS was fully loaded, the device recei
On 3/26/24 12:55, Greg Kurz wrote:
Bom dia Daniel !
Bonne après-midi !
On Tue, 26 Mar 2024 10:26:03 -0300
Daniel Henrique Barboza wrote:
Hi,
Thomas reported in [1] a problem that happened with the RISC-V machine
where some tests from virtio-9p-test.c were failing with '-m slow', i.e.
26.03.2024 15:26, Igor Mammedov wrote:
QEMU build fails with
hw/i386/fw_cfg.c:74: undefined reference to `smbios_get_table_legacy'
when it's built with only 'microvm' enabled i.e. with config patch
+++ b/configs/devices/i386-softmmu/default.mak
@@ -26,7 +26,7 @@
# Boards:
#
On Tue, 12 Mar 2024 at 17:11, Nicholas Piggin wrote:
>
> From: Harsh Prateek Bora
>
> Introduce the nested PAPR hcalls:
> - H_GUEST_GET_STATE which is used to get state of a nested guest or
> a guest VCPU. The value field for each element in the request is
> destination to be upda
26.03.2024 18:58, Philippe Mathieu-Daudé:
This is not enough. This step is good already, but it lacks default machine
type selection. In debian we carry a tiny patch to make microvm the default
machine type or else it crashes at startup not finding "pc" machine or one
of its required devices.
On Mon, Mar 25, 2024 at 02:55:11PM +, Peter Maydell wrote:
> On Mon, 25 Mar 2024 at 14:45, Gerd Hoffmann wrote:
> >
> > Turned out hard-coding version and date in the Makefile wasn't a bright
> > idea. Updating it on edk2 updates is easily forgotten. Fetch the info
> > from git instead.
> >
On 26/3/24 16:48, Michael Tokarev wrote:
26.03.2024 16:14, Philippe Mathieu-Daudé wrote:
Add a config file to build a binary only containing the
microvm machine, inspired by a discussion on the list:
https://lore.kernel.org/qemu-devel/604bf457-23a7-4d06-b59f-a7b46945c...@tls.msk.ru/
As suggeste
1 - 100 of 248 matches
Mail list logo
