Re: [PATCH 0/3] ui/gtk: introducing vc->visible

2024-03-07 Thread Marc-André Lureau
Hi On Fri, Mar 8, 2024 at 4:59 AM Kim, Dongwon wrote: > > Hi Marc-André, > > > -Original Message- > > From: Marc-André Lureau > > Sent: Tuesday, March 5, 2024 4:18 AM > > To: Kim, Dongwon ; P. Berrange, Daniel > > > > Cc: qemu-devel@nongnu.org > > Subject: Re: [PATCH 0/3] ui/gtk: introd

Re: [PATCH v4 24/25] vfio: Also trace event failures in vfio_save_complete_precopy()

2024-03-07 Thread Eric Auger
On 3/7/24 14:36, Cédric Le Goater wrote: > On 3/7/24 10:28, Eric Auger wrote: >> >> >> On 3/6/24 14:34, Cédric Le Goater wrote: >>> vfio_save_complete_precopy() currently returns before doing the trace >>> event. Change that. >>> >>> Signed-off-by: Cédric Le Goater >>> --- >>>   hw/vfio/migrati

Re: [PATCH v2 2/4] mirror: allow specifying working bitmap

2024-03-07 Thread Markus Armbruster
Fiona Ebner writes: > From: John Snow > > for the mirror job. The bitmap's granularity is used as the job's > granularity. > > The new @bitmap parameter is marked unstable in the QAPI and can > currently only be used for @sync=full mode. > > Clusters initially dirty in the bitmap as well as new

Re: [PATCH v4 20/25] vfio: Add Error** argument to .vfio_save_config() handler

2024-03-07 Thread Eric Auger
On 3/7/24 14:55, Cédric Le Goater wrote: > On 3/7/24 10:13, Eric Auger wrote: >> >> >> On 3/6/24 14:34, Cédric Le Goater wrote: >>> Use vmstate_save_state_with_err() to improve error reporting in the >>> callers and store a reported error under the migration stream. Add >>> documentation while a

Re: [PATCH 1/5] scripts/kernel-doc: teach kdoc about QLIST_ macros

2024-03-07 Thread Peter Xu
On Thu, Mar 07, 2024 at 06:11:01PM +, Alex Bennée wrote: > The kernel-doc script does some pre-processing on structure > definitions before parsing for names. Teach it about QLIST and replace > with simplified structures representing the base type. > > Signed-off-by: Alex Bennée > --- > scri

Re: [PATCH v4 16/25] vfio: Add Error** argument to .set_dirty_page_tracking() handler

2024-03-07 Thread Eric Auger
On 3/7/24 13:06, Cédric Le Goater wrote: > On 3/7/24 09:09, Eric Auger wrote: >> Hi Cédric, >> >> On 3/6/24 14:34, Cédric Le Goater wrote: >>> We will use the Error object to improve error reporting in the >>> .log_global*() handlers of VFIO. Add documentation while at it. >>> >>> Reviewed-by: P

Re: [PATCH v2 0/4] physmem: Fix MemoryRegion for second access to cached MMIO Address Space

2024-03-07 Thread Peter Xu
On Thu, Mar 07, 2024 at 03:37:06PM +, Jonathan Cameron wrote: > v2: (Thanks to Peter Xu for reviewing!) > - New patch 1 to rename addr1 to mr_addr in the interests of meaningful > naming. > - Take advantage of a cached address space only allow for a single MR to > simplify > the new code. >

Re: [PATCH v2 1/4] qapi/block-core: avoid the re-use of MirrorSyncMode for backup

2024-03-07 Thread Markus Armbruster
Fiona Ebner writes: > Backup supports all modes listed in MirrorSyncMode, while mirror does > not. Introduce BackupSyncMode by copying the current MirrorSyncMode > and drop the variants mirror does not support from MirrorSyncMode as > well as the corresponding manual check in mirror_start(). Res

Re: [PATCH v2 14/20] smbios: extend smbios-entry-point-type with 'auto' value

2024-03-07 Thread Markus Armbruster
Igor Mammedov writes: > later patches will use it to pick SMBIOS version at runtime > depending on configuration. > > Signed-off-by: Igor Mammedov > Acked-by: Markus Armbruster > Reviewed-by: Ani Sinha > Tested-by: Fiona Ebner > --- > qapi/machine.json | 5 - > 1 file changed, 4 insertio

Re: Problem with migration/rdma

2024-03-07 Thread Peter Xu
On Fri, Mar 08, 2024 at 07:03:56AM +, Zhijian Li (Fujitsu) wrote: > > > On 08/03/2024 14:55, Peter Xu wrote: > > On Fri, Mar 08, 2024 at 07:27:59AM +0100, Yu Zhang wrote: > >> Hello Zhijian and Peter, > >> > >> Thank you so much for testing and confirming it. > >> I created a patch in the ema

Re: [PATCH v4 11/25] migration: Add Error** argument to .save_setup() handler

2024-03-07 Thread Peter Xu
On Thu, Mar 07, 2024 at 02:39:31PM +0300, Vladimir Sementsov-Ogievskiy wrote: > > I would be glad to have most of this series merged in QEMU 9.0. So, > > unless there is something major, I will keep that for followups. Unfortunately I found this series won't apply to master.. starting from "migrat

Re: Problem with migration/rdma

2024-03-07 Thread Zhijian Li (Fujitsu)
On 08/03/2024 14:55, Peter Xu wrote: > On Fri, Mar 08, 2024 at 07:27:59AM +0100, Yu Zhang wrote: >> Hello Zhijian and Peter, >> >> Thank you so much for testing and confirming it. >> I created a patch in the email format, unfortunately got an issue for >> setting up the >> "Application-specific P

Re: [PATCH v4 07/25] migration: Always report an error in block_save_setup()

2024-03-07 Thread Peter Xu
On Wed, Mar 06, 2024 at 02:34:22PM +0100, Cédric Le Goater wrote: > @@ -404,6 +403,10 @@ static int init_blk_migration(QEMUFile *f) > sectors = bdrv_nb_sectors(bs); > if (sectors <= 0) { Not directly relevant to this patch, but just to mention that this looks suspicious (even if

Re: Problem with migration/rdma

2024-03-07 Thread Peter Xu
On Fri, Mar 08, 2024 at 07:27:59AM +0100, Yu Zhang wrote: > Hello Zhijian and Peter, > > Thank you so much for testing and confirming it. > I created a patch in the email format, unfortunately got an issue for > setting up the > "Application-specific Password" in Gmail. It seems that in my gmail >

Re: [PATCH v9 0/5] eBPF RSS through QMP support.

2024-03-07 Thread Jason Wang
On Mon, Feb 26, 2024 at 6:23 PM Andrew Melnichenko wrote: > > Hi all, > Jason, can you please review the patch set, thank you. Queued. Thanks

Re: Problem with migration/rdma

2024-03-07 Thread Yu Zhang
Hello Zhijian and Peter, Thank you so much for testing and confirming it. I created a patch in the email format, unfortunately got an issue for setting up the "Application-specific Password" in Gmail. It seems that in my gmail account there is no option at all for selecting "mail" before creating

Re: [PATCH v2] docs/acpi/bits: add some clarity and details while also improving formating

2024-03-07 Thread Michael Tokarev
08.03.2024 07:22, Ani Sinha : Update bios-bits docs to add more details on why a pre-OS environment for testing bioses is useful. Add author's FOSDEM talk link. Also improve the formating of the document while at it. CC: qemu-triv...@nongnu.org Signed-off-by: Ani Sinha Reviewed-by: Michael To

Re: [PATCH 0/3] cxl: Fix issues with g_steal_pointer()

2024-03-07 Thread Michael Tokarev
04.03.2024 13:44, Thomas Huth wrote: When setting GLIB_VERSION_MAX_ALLOWED to GLIB_VERSION_2_58 or higher (which we'll certainly do in the not too distant future), glib adds type safety checks to the g_steal_pointer() macro. This triggers errors in the cxl code since the pointer types do not alwa

Re: [PATCH 0/4] hw/i386/pc: Trivial cleanups

2024-03-07 Thread Michael Tokarev
07.03.2024 21:57, Bernhard Beschow : Am 1. März 2024 18:59:32 UTC schrieb "Philippe Mathieu-Daudé" : Trivial cleanups, mostly around the 'isapc' machine. Philippe Mathieu-Daudé (4): hw/i386/pc: Remove pc_compat_1_4..1.7[] left over declarations hw/i386/pc: Use generated NotifyVmexitOption_

[PATCH] configure: Fix error message when C compiler is not working

2024-03-07 Thread Thomas Huth
If you try to run the configure script on a system without a working C compiler, you get a very misleading error message: ERROR: Unrecognized host OS (uname -s reports 'Linux') We should rather tell the user that we were not able to use the C compiler instead, otherwise they will have a hard tim

Re: [PATCH v2 2/2] kvm: add support for guest physical bits

2024-03-07 Thread Xiaoyao Li
On 3/5/2024 6:52 PM, Gerd Hoffmann wrote: Query kvm for supported guest physical address bits, in cpuid function 8008, eax[23:16]. Usually this is identical to host physical address bits. With NPT or EPT being used this might be restricted to 48 (max 4-level paging address space size) even

Re: [PATCH 1/5] target/sparc/cpu: Rename the CPU models with a "+" in their names

2024-03-07 Thread Thomas Huth
On 07/03/2024 22.22, Richard Henderson wrote: On 3/7/24 07:43, Thomas Huth wrote: +    /* Fix up legacy names with '+' in it */ +    if (g_str_equal(typename, SPARC_CPU_TYPE_NAME("Sun-UltraSparc-IV+"))) { +    g_free(typename); +    typename = g_strdup(SPARC_CPU_TYPE_NAME("Sun-UltraSparc

[PATCH v2] docs/acpi/bits: add some clarity and details while also improving formating

2024-03-07 Thread Ani Sinha
Update bios-bits docs to add more details on why a pre-OS environment for testing bioses is useful. Add author's FOSDEM talk link. Also improve the formating of the document while at it. CC: qemu-triv...@nongnu.org Signed-off-by: Ani Sinha --- docs/devel/acpi-bits.rst | 55 ++

Re: [PATCH 2/2] linux-user/riscv: Sync hwprobe keys with Linux

2024-03-07 Thread Alistair Francis
On Wed, Feb 7, 2024 at 10:00 PM Christoph Müllner wrote: > > Upstream Linux recently added many additional keys to the hwprobe API. > This patch adds support for all of them with the exception of Ztso, > which is currently not supported in QEMU. > > Signed-off-by: Christoph Müllner > --- > linux

Re: [PULL 0/4] machine development tool

2024-03-07 Thread Peter Xu
On Thu, Mar 07, 2024 at 12:06:59PM +0300, Maksim Davydov wrote: > > On 3/6/24 04:57, Peter Xu wrote: > > On Tue, Mar 05, 2024 at 03:43:41PM +0100, Markus Armbruster wrote: > > > Peter Maydell writes: > > > > > > > On Mon, 4 Mar 2024 at 13:52, Maksim Davydov > > > > wrote: > > > > > The followi

Re: [PATCH] input-linux: Add option to not grab a device upon guest startup

2024-03-07 Thread Justinien Bouron
> This last two lines doesn't make sense to me. Isn't the grab > toggling entirely in control of the QEMU process, regardless > of what state the guest is at ? Actually, you're right, they do not make sense. This issue of having the guest taking a while to start and the toggle keys not working, on

Re: [PATCH v7 3/9] target/riscv: remove 'over' brconds from vector trans

2024-03-07 Thread LIU Zhiwei
Hi Daniel and Alistair, Hope it is not too late. I think there are two bugs in this patch. 1) The first is for instruction vfmv.s.f.  vfmv.s.f doesn't use helper function. If we remove the over check, it will set the first element of destination vector register, which is against the specificat

RE: [PATCH v8 7/9] hw/i386/q35: Set virtio-iommu aw-bits default value to 39

2024-03-07 Thread Duan, Zhenzhong
>-Original Message- >From: Eric Auger >Subject: [PATCH v8 7/9] hw/i386/q35: Set virtio-iommu aw-bits default >value to 39 > >Currently the default input range can extend to 64 bits. On x86, >when the virtio-iommu protects vfio devices, the physical iommu >may support only 39 bits. Let's

Enabling internal errors for VH CXL devices: [was: Re: Questions about CXL RAS injection test in qemu]

2024-03-07 Thread Yuquan Wang
On 2024-03-07 20:10, jonathan.cameron wrote: > Hack is fine the relevant device with lspci -tv and then use > setpci -s 0d:00.0 0x208.l=0 > to clear all the mask bits for uncorrectable errors. Thanks! The suggestions from you and Terry did work! BTW, is my understanding below about CXL RAS corr

Re: [PATCH v3 00/20] Use Intel DSA accelerator to offload zero page checking in multifd live migration.

2024-03-07 Thread liulongfang via
On 2024/1/4 8:44, Hao Xiang wrote: > v3 > * Rebase on top of 7425b6277f12e82952cede1f531bfc689bf77fb1. > * Fix error/warning from checkpatch.pl > * Fix use-after-free bug when multifd-dsa-accel option is not set. > * Handle error from dsa_init and correctly propogate the error. > * Remove unnecessa

RE: [PATCH 0/3] ui/gtk: introducing vc->visible

2024-03-07 Thread Kim, Dongwon
Hi Marc-André, > -Original Message- > From: Marc-André Lureau > Sent: Tuesday, March 5, 2024 4:18 AM > To: Kim, Dongwon ; P. Berrange, Daniel > > Cc: qemu-devel@nongnu.org > Subject: Re: [PATCH 0/3] ui/gtk: introducing vc->visible > > Hi Kim > > I am uncomfortable with the series in ge

Re: [PATCH] disas/riscv: Further correction to LUI disassembly

2024-03-07 Thread Richard Bagley
NACK We have established that the change is a workaround for a bug in the assembler. I withdraw the merge request. Thank you for this careful review. On Fri, Aug 11, 2023 at 4:55 AM Andrew Jones wrote: > On Fri, Aug 11, 2023 at 10:25:52AM +0200, Andrew Jones wrote: > > On Thu, Aug 10, 2023 at

Re: [PATCH v5 06/13] hw/mem/cxl_type3: Add host backend and address space handling for DC regions

2024-03-07 Thread fan
On Thu, Mar 07, 2024 at 12:16:05PM +, Jonathan Cameron wrote: > > > > @@ -868,16 +974,24 @@ static int > > > > cxl_type3_hpa_to_as_and_dpa(CXLType3Dev *ct3d, > > > > AddressSpace **as, > > > > uint64_t *dpa_offset)

[PATCH] hw/m68k/mcf5208: add support for reset

2024-03-07 Thread Angelo Dureghello
Add reset support. Signed-off-by: Angelo Dureghello --- hw/m68k/mcf5208.c | 51 --- 1 file changed, 48 insertions(+), 3 deletions(-) diff --git a/hw/m68k/mcf5208.c b/hw/m68k/mcf5208.c index 0cfb806c20..b1ab3896d0 100644 --- a/hw/m68k/mcf5208.c +++ b/h

Re: [PATCH 4/5] include/exec: annotate all the MemoryRegion fields

2024-03-07 Thread Alex Bennée
Richard Henderson writes: > On 3/7/24 08:11, Alex Bennée wrote: >> Signed-off-by: Alex Bennée >> --- >> include/exec/memory.h | 47 +++ >> 1 file changed, 43 insertions(+), 4 deletions(-) >> diff --git a/include/exec/memory.h b/include/exec/memory.h >>

Re: [PATCH v2 3/5] gdbstub: Save target's siginfo

2024-03-07 Thread Alex Bennée
Richard Henderson writes: > On 3/7/24 08:26, Gustavo Romero wrote: >> Save target's siginfo into gdbserver_state so it can be used later, for >> example, in any stub that requires the target's si_signo and si_code. >> This change affects only linux-user mode. >> Signed-off-by: Gustavo Romero >>

Re: [PATCH] virt: set the CPU type in BOOTINFO

2024-03-07 Thread Mark Cave-Ayland
On 23/02/2024 15:57, Laurent Vivier wrote: BI_CPUTYPE/BI_MMUTYPE/BI_FPUTYPE were statically assigned to the 68040 information. This patch changes the code to set in bootinfo the information provided by the command line '-cpu' parameter. Bug: https://gitlab.com/qemu-project/qemu/-/issues/2091 Re

Re: [RFC 0/2] Add RISC-V Server Platform Reference Board

2024-03-07 Thread Marcin Juszkiewicz
W dniu 4.03.2024 o 11:25, Fei Wu pisze: The RISC-V Server Platform specification[1] defines a standardized set of hardware and software capabilities, that portable system software, such as OS and hypervisors can rely on being present in a RISC-V server platform. This patchset provides a RISC-V S

Re: [PATCH] target/riscv: Implement dynamic establishment of custom decoder

2024-03-07 Thread Daniel Henrique Barboza
On 3/7/24 17:11, Richard Henderson wrote: On 3/7/24 09:55, Daniel Henrique Barboza wrote: (--- adding Richard ---) On 3/6/24 06:33, Huang Tao wrote: In this patch, we modify the decoder to be a freely composable data structure instead of a hardcoded one. It can be dynamically builded up ac

Re: [PATCH 3/5] target/sparc/cpu: Improve the CPU help text

2024-03-07 Thread Richard Henderson
On 3/7/24 07:43, Thomas Huth wrote: Remove the unnecessary "Sparc" at the beginning of the line and put the chip information into parentheses so that it is clearer which part of the line have to be passed to "-cpu" to specify a different CPU. Resolves:https://gitlab.com/qemu-project/qemu/-/issue

Re: [PATCH 2/5] target/sparc/cpu: Avoid spaces by default in the CPU names

2024-03-07 Thread Richard Henderson
On 3/7/24 07:43, Thomas Huth wrote: The output of "-cpu help" is currently rather confusing to the users: It is not clear which part of the output defines the CPU names since the CPU names contain white spaces (which we later have to convert into dashes internally) For example: Sparc TI UltraSpa

Re: [PATCH 1/5] target/sparc/cpu: Rename the CPU models with a "+" in their names

2024-03-07 Thread Richard Henderson
On 3/7/24 07:43, Thomas Huth wrote: +/* Fix up legacy names with '+' in it */ +if (g_str_equal(typename, SPARC_CPU_TYPE_NAME("Sun-UltraSparc-IV+"))) { +g_free(typename); +typename = g_strdup(SPARC_CPU_TYPE_NAME("Sun-UltraSparc-IVp")); +} else if (g_str_equal(typename,

Re: [PATCH v2 5/5] tests/tcg: Add multiarch test for Xfer:siginfo:read stub

2024-03-07 Thread Richard Henderson
On 3/7/24 08:26, Gustavo Romero wrote: Add multiarch test for testing if Xfer:siginfo:read query is properly handled by gdbstub. Signed-off-by: Gustavo Romero --- tests/tcg/multiarch/Makefile.target | 10 ++- .../gdbstub/test-qxfer-siginfo-read.py| 26 +++

Re: [PATCH v2 4/5] gdbstub: Add Xfer:siginfo:read stub

2024-03-07 Thread Richard Henderson
On 3/7/24 08:26, Gustavo Romero wrote: +void gdb_handle_query_xfer_siginfo(GArray *params, void *user_ctx) +{ +unsigned long offset, len; +uint8_t *siginfo_offset; + +offset = get_param(params, 0)->val_ul; +len = get_param(params, 1)->val_ul; + +if (offset + len > sizeof(targe

Re: [PATCH v2 3/5] gdbstub: Save target's siginfo

2024-03-07 Thread Richard Henderson
On 3/7/24 08:26, Gustavo Romero wrote: Save target's siginfo into gdbserver_state so it can be used later, for example, in any stub that requires the target's si_signo and si_code. This change affects only linux-user mode. Signed-off-by: Gustavo Romero Suggested-by: Richard Henderson --- gd

Re: [PATCH 0/4] hw/i386/pc: Trivial cleanups

2024-03-07 Thread Bernhard Beschow
Am 1. März 2024 18:59:32 UTC schrieb "Philippe Mathieu-Daudé" : >Trivial cleanups, mostly around the 'isapc' machine. > >Philippe Mathieu-Daudé (4): > hw/i386/pc: Remove pc_compat_1_4..1.7[] left over declarations > hw/i386/pc: Use generated NotifyVmexitOption_str() > hw/i386/pc: Remove 'hos

Re: [PATCH v2 2/5] linux-user: Move tswap_siginfo out of target code

2024-03-07 Thread Richard Henderson
On 3/7/24 09:21, Alex Bennée wrote: +/* + * Writes out siginfo values byteswapped, accordingly to the target. It also + * cleans the si_type from si_code making it correct for the target. + */ +tswap_siginfo(&k->info, &k->info); + I'm not sure I like this, you have the same

Re: [PATCH v2 2/5] linux-user: Move tswap_siginfo out of target code

2024-03-07 Thread Richard Henderson
On 3/7/24 08:26, Gustavo Romero wrote: Move tswap_siginfo from target code to handle_pending_signal. This will allow some cleanups and having the siginfo ready to be used in gdbstub. Signed-off-by: Gustavo Romero Suggested-by: Richard Henderson --- linux-user/aarch64/signal.c | 2 +- lin

Re: [PATCH v2 1/5] gdbstub: Rename back gdb_handlesig

2024-03-07 Thread Richard Henderson
On 3/7/24 08:26, Gustavo Romero wrote: Rename gdb_handlesig_reason back to gdb_handlesig. There is no need to add a wrapper for gdb_handlesig and rename it when a new parameter is added. Signed-off-by: Gustavo Romero --- gdbstub/user.c | 8 include/gdbstub/user.h | 15 ++---

Re: [PATCH 4/5] include/exec: annotate all the MemoryRegion fields

2024-03-07 Thread Richard Henderson
On 3/7/24 08:11, Alex Bennée wrote: Signed-off-by: Alex Bennée --- include/exec/memory.h | 47 +++ 1 file changed, 43 insertions(+), 4 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index 17b741bc4f5..312ed564dbe 100644 --- a/i

Re: [PATCH 3/5] include/exec: remove warning_printed from MemoryRegion

2024-03-07 Thread Richard Henderson
On 3/7/24 08:11, Alex Bennée wrote: Since d197063fcf9 (memory: move unassigned_mem_ops to memory.c) this field is unused. Signed-off-by: Alex Bennée --- include/exec/memory.h | 1 - 1 file changed, 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH 3/5] include/exec: remove warning_printed from MemoryRegion

2024-03-07 Thread Philippe Mathieu-Daudé
On 7/3/24 19:11, Alex Bennée wrote: Since d197063fcf9 (memory: move unassigned_mem_ops to memory.c) this field is unused. Signed-off-by: Alex Bennée --- include/exec/memory.h | 1 - 1 file changed, 1 deletion(-) 10+ years ;) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] target/riscv: Implement dynamic establishment of custom decoder

2024-03-07 Thread Richard Henderson
-    for (size_t i = 0; i < ARRAY_SIZE(decoders); ++i) { -    if (decoders[i].guard_func(ctx->cfg_ptr) && -    decoders[i].decode_func(ctx, opcode32)) { +    for (size_t i = 0; i < decoder_table_size; ++i) { +    if (ctx->decoder[i](ctx, opcode32)) {    

Re: [PATCH] target/riscv: Implement dynamic establishment of custom decoder

2024-03-07 Thread Richard Henderson
On 3/7/24 09:55, Daniel Henrique Barboza wrote: (--- adding Richard ---) On 3/6/24 06:33, Huang Tao wrote: In this patch, we modify the decoder to be a freely composable data structure instead of a hardcoded one. It can be dynamically builded up according to the extensions. This approach has s

Re: [PATCH] target/riscv: Implement dynamic establishment of custom decoder

2024-03-07 Thread Daniel Henrique Barboza
(--- adding Richard ---) On 3/6/24 06:33, Huang Tao wrote: In this patch, we modify the decoder to be a freely composable data structure instead of a hardcoded one. It can be dynamically builded up according to the extensions. This approach has several benefits: 1. Provides support for heteroge

RE: [PATCH 1/3] ui/gtk: skip drawing guest scanout when associated VC is invisible

2024-03-07 Thread Kim, Dongwon
Hi Daniel, > -Original Message- > From: Daniel P. Berrangé > Sent: Thursday, March 7, 2024 10:01 AM > To: Kim, Dongwon > Cc: Marc-André Lureau ; qemu- > de...@nongnu.org > Subject: Re: [PATCH 1/3] ui/gtk: skip drawing guest scanout when associated > VC is invisible > > On Thu, Mar 07, 2

Re: [PATCH v2 00/10] mirror: allow switching from background to active mode

2024-03-07 Thread Vladimir Sementsov-Ogievskiy
On 04.03.24 14:09, Peter Krempa wrote: On Mon, Mar 04, 2024 at 11:48:54 +0100, Kevin Wolf wrote: Am 28.02.2024 um 19:07 hat Vladimir Sementsov-Ogievskiy geschrieben: On 03.11.23 18:56, Markus Armbruster wrote: Kevin Wolf writes: [...] Is the job abstraction a failure? We have bloc

Re: [RFC PATCH 4/5] hw/i386/q35: Wire virtual SMI# lines to ICH9 chipset

2024-03-07 Thread Thomas Huth
On 28/02/2024 17.43, Zhao Liu wrote: Hi Philippe, +/* + * Real ICH9 contains a single SMI output line and doesn't broadcast CPUs. + * Virtualized ICH9 allows broadcasting upon negatiation with guest, see + * commit 5ce45c7a2b. + */ +enum { +ICH9_VIRT_SMI_BROADCAST, +ICH9_VIRT_SMI_CURREN

Re: [PATCH 2/2] tests/tcg: Add multiarch test for Xfer:siginfo:read stub

2024-03-07 Thread Richard Henderson
On 3/7/24 07:50, Gustavo Romero wrote: Hi Richard, On 3/4/24 7:51 PM, Richard Henderson wrote: On 3/4/24 10:59, Gustavo Romero wrote: Perhaps just abort for SIGABRT instead? Although this can make a simpler test, the test can't control the si_addr value easily, which I think is interesting t

Re: [PATCH V3 1/1] target/loongarch: Fixed tlb huge page loading issue

2024-03-07 Thread Richard Henderson
On 3/6/24 21:37, Xianglai Li wrote: When we use qemu tcg simulation, the page size of bios is 4KB. When using the level 2 super large page (page size is 1G) to create the page table, it is found that the content of the corresponding address space is abnormal, resulting in the bios can not start

Re: [RISC-V][tech-server-platform] [RISC-V][tech-server-soc] [RFC 2/2] target/riscv: Add server platform reference cpu

2024-03-07 Thread Daniel Henrique Barboza
On 3/7/24 09:17, Heinrich Schuchardt wrote: On 07.03.24 08:36, Wu, Fei2 wrote: On 3/6/2024 9:26 PM, Wu, Fei wrote: On 3/5/2024 1:58 PM, Wu, Fei wrote: On 3/5/2024 3:43 AM, Daniel Henrique Barboza wrote: On 3/4/24 07:25, Fei Wu wrote: The harts requirements of RISC-V server platform [1]

Re: [PATCH 05/17] hw/vfio/ap: Fix missing ERRP_GUARD() for error_prepend()

2024-03-07 Thread Thomas Huth
On 04/03/2024 16.12, Anthony Krowiak wrote: On 2/29/24 12:30 PM, Thomas Huth wrote: On 29/02/2024 15.39, Zhao Liu wrote: From: Zhao Liu As the comment in qapi/error, passing @errp to error_prepend() requires ERRP_GUARD(): * = Why, when and how to use ERRP_GUARD() = * * Without ERRP_GUARD(),

Re: [PATCH v2 2/5] linux-user: Move tswap_siginfo out of target code

2024-03-07 Thread Alex Bennée
Gustavo Romero writes: > Move tswap_siginfo from target code to handle_pending_signal. This will > allow some cleanups and having the siginfo ready to be used in gdbstub. > > Signed-off-by: Gustavo Romero > Suggested-by: Richard Henderson > --- > linux-user/aarch64/signal.c | 2 +- > linu

Re: [RISC-V][tech-server-soc] [RFC 2/2] target/riscv: Add server platform reference cpu

2024-03-07 Thread Daniel Henrique Barboza
On 3/7/24 04:36, Wu, Fei wrote: On 3/6/2024 9:26 PM, Wu, Fei wrote: On 3/5/2024 1:58 PM, Wu, Fei wrote: On 3/5/2024 3:43 AM, Daniel Henrique Barboza wrote: On 3/4/24 07:25, Fei Wu wrote: The harts requirements of RISC-V server platform [1] require RVA23 ISA profile support, plus Sv48, Sv

Re: [PATCH v2 1/5] gdbstub: Rename back gdb_handlesig

2024-03-07 Thread Alex Bennée
Gustavo Romero writes: > Rename gdb_handlesig_reason back to gdb_handlesig. There is no need to > add a wrapper for gdb_handlesig and rename it when a new parameter is > added. > > Signed-off-by: Gustavo Romero Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v1 2/5] hw/ppc: SPI controller model - registers implementation

2024-03-07 Thread Stefan Berger
On 3/7/24 13:54, Stefan Berger wrote: On 2/7/24 11:08, Chalapathi V wrote: +#define COUNTER_CONFIG_REG_SHIFT_COUNT_N1   PPC_BITMASK(0 , 7) No space before the ',' ==> PPC_BITMASK(0, 7)

Re: [PATCH v1 2/5] hw/ppc: SPI controller model - registers implementation

2024-03-07 Thread Stefan Berger
On 2/7/24 11:08, Chalapathi V wrote: SPI controller device model supports a connection to a single SPI responder. This provide access to SPI seeproms, TPM, flash device and an ADC controller. All SPI function control is mapped into the SPI register space to enable full control by firmware. In

Re: [PATCH 3/5] target/sparc/cpu: Improve the CPU help text

2024-03-07 Thread Philippe Mathieu-Daudé
On 7/3/24 18:43, Thomas Huth wrote: Remove the unnecessary "Sparc" at the beginning of the line and put the chip information into parentheses so that it is clearer which part of the line have to be passed to "-cpu" to specify a different CPU. Resolves: https://gitlab.com/qemu-project/qemu/-/issu

[PATCH] pci: Add option to disable device level INTx masking

2024-03-07 Thread Alex Williamson
The PCI 2.3 spec added definitions of the INTx disable and status bits, in the command and status registers respectively. The command register bit, commonly known as DisINTx in lspci, controls whether the device can assert the INTx signal. Operating systems will often write to this bit to test wh

[PATCH v2] hmp: Add option to info qtree to omit details

2024-03-07 Thread BALATON Zoltan
The output of info qtree monitor command is very long. Add an option to print a brief overview omitting all the details. Signed-off-by: BALATON Zoltan Reviewed-by: Dr. David Alan Gilbert --- v2: - Change the variable name to deails too - Add braces to if (checkpatch did not warn for this so just

[PATCH v2 2/5] linux-user: Move tswap_siginfo out of target code

2024-03-07 Thread Gustavo Romero
Move tswap_siginfo from target code to handle_pending_signal. This will allow some cleanups and having the siginfo ready to be used in gdbstub. Signed-off-by: Gustavo Romero Suggested-by: Richard Henderson --- linux-user/aarch64/signal.c | 2 +- linux-user/alpha/signal.c | 2 +- lin

[PATCH v2 5/5] tests/tcg: Add multiarch test for Xfer:siginfo:read stub

2024-03-07 Thread Gustavo Romero
Add multiarch test for testing if Xfer:siginfo:read query is properly handled by gdbstub. Signed-off-by: Gustavo Romero --- tests/tcg/multiarch/Makefile.target | 10 ++- .../gdbstub/test-qxfer-siginfo-read.py| 26 +++ tests/tcg/multiarch/segfault.c

[PATCH v2 4/5] gdbstub: Add Xfer:siginfo:read stub

2024-03-07 Thread Gustavo Romero
Add stub to handle Xfer:siginfo:read packet query that requests the machine's siginfo data. This is used when GDB user executes 'print $_siginfo' and when the machine stops due to a signal, for instance, on SIGSEGV. The information in siginfo allows GDB to determiner further details on the signal,

[PATCH v2 3/5] gdbstub: Save target's siginfo

2024-03-07 Thread Gustavo Romero
Save target's siginfo into gdbserver_state so it can be used later, for example, in any stub that requires the target's si_signo and si_code. This change affects only linux-user mode. Signed-off-by: Gustavo Romero Suggested-by: Richard Henderson --- gdbstub/internals.h| 3 +++ gdbstub/use

[PATCH v2 1/5] gdbstub: Rename back gdb_handlesig

2024-03-07 Thread Gustavo Romero
Rename gdb_handlesig_reason back to gdb_handlesig. There is no need to add a wrapper for gdb_handlesig and rename it when a new parameter is added. Signed-off-by: Gustavo Romero --- gdbstub/user.c | 8 include/gdbstub/user.h | 15 ++- linux-user/main.c | 2 +-

[PATCH 4/5] include/exec: annotate all the MemoryRegion fields

2024-03-07 Thread Alex Bennée
Signed-off-by: Alex Bennée --- include/exec/memory.h | 47 +++ 1 file changed, 43 insertions(+), 4 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index 17b741bc4f5..312ed564dbe 100644 --- a/include/exec/memory.h +++ b/include/exec/

[PATCH 1/5] scripts/kernel-doc: teach kdoc about QLIST_ macros

2024-03-07 Thread Alex Bennée
The kernel-doc script does some pre-processing on structure definitions before parsing for names. Teach it about QLIST and replace with simplified structures representing the base type. Signed-off-by: Alex Bennée --- scripts/kernel-doc | 9 - 1 file changed, 8 insertions(+), 1 deletion(-

[PATCH 5/5] docs/devel: mark out defined functions and structures

2024-03-07 Thread Alex Bennée
This allows sphinx to hyperlink the references to their kdoc definitions for easy navigation. Signed-off-by: Alex Bennée --- docs/devel/memory.rst | 48 +-- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/docs/devel/memory.rst b/docs/devel/

[PATCH 0/5] docs: improve the memory API documentation

2024-03-07 Thread Alex Bennée
As I've been looking through the Memory API for our Xen work I thought I should take the time to clean it up. I needed to teach kdoc about our QLIST_ macros and I found at least one unused field in the structure. Looking through the definitions I do wander if the meaning of romd_mode and ram_devic

[PATCH 2/5] docs: include ramblock.h in the memory API docs

2024-03-07 Thread Alex Bennée
The RAMBlock concept is fairly central to RAM-like MemoryRegions so lets update the structure documentation and include in the docs. Signed-off-by: Alex Bennée --- docs/devel/memory.rst | 1 + include/exec/ramblock.h | 76 +++-- 2 files changed, 52 insertio

[PATCH 3/5] include/exec: remove warning_printed from MemoryRegion

2024-03-07 Thread Alex Bennée
Since d197063fcf9 (memory: move unassigned_mem_ops to memory.c) this field is unused. Signed-off-by: Alex Bennée --- include/exec/memory.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index 8626a355b31..17b741bc4f5 100644 --- a/include/exec/mem

Re: [PATCH 1/3] ui/gtk: skip drawing guest scanout when associated VC is invisible

2024-03-07 Thread Daniel P . Berrangé
On Thu, Mar 07, 2024 at 05:53:24PM +, Kim, Dongwon wrote: > Hi Daniel, > > > -Original Message- > > From: Daniel P. Berrangé > > Sent: Thursday, March 7, 2024 1:46 AM > > To: Kim, Dongwon > > Cc: Marc-André Lureau ; qemu- > > de...@nongnu.org > > Subject: Re: [PATCH 1/3] ui/gtk: skip

RE: [PATCH 1/3] ui/gtk: skip drawing guest scanout when associated VC is invisible

2024-03-07 Thread Kim, Dongwon
Hi Daniel, > -Original Message- > From: Daniel P. Berrangé > Sent: Thursday, March 7, 2024 1:46 AM > To: Kim, Dongwon > Cc: Marc-André Lureau ; qemu- > de...@nongnu.org > Subject: Re: [PATCH 1/3] ui/gtk: skip drawing guest scanout when associated > VC is invisible > > On Thu, Feb 01, 20

Re: [PATCH 1/2] gdbstub: Add Xfer:siginfo:read stub

2024-03-07 Thread Gustavo Romero
On 3/4/24 2:18 PM, Richard Henderson wrote: On 3/3/24 09:26, Gustavo Romero wrote: +    /* Filter out si_type from si_code. See comment in siginfo_noswap(). */ > +    tmp_siginfo = ts->sync_signal.info; +    tmp_siginfo.si_code = sextract32(tmp_siginfo.si_code, 0, 16); This is incorrect, as

Re: [PATCH 2/2] tests/tcg: Add multiarch test for Xfer:siginfo:read stub

2024-03-07 Thread Gustavo Romero
Hi Richard, On 3/4/24 7:51 PM, Richard Henderson wrote: On 3/4/24 10:59, Gustavo Romero wrote: Perhaps just abort for SIGABRT instead? Although this can make a simpler test, the test can't control the si_addr value easily, which I think is interesting to be tested. Why do you prefer SIGABRT?

[PATCH 5/5] docs/about: Deprecate the old "UltraSparc" CPU names that contain a "+"

2024-03-07 Thread Thomas Huth
For consistency we should drop the names with a "+" in it in the long run. Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 8565644da6..7058341f8f 100644 --- a/docs/ab

[PATCH 3/5] target/sparc/cpu: Improve the CPU help text

2024-03-07 Thread Thomas Huth
Remove the unnecessary "Sparc" at the beginning of the line and put the chip information into parentheses so that it is clearer which part of the line have to be passed to "-cpu" to specify a different CPU. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2141 Signed-off-by: Thomas Huth --

[PATCH 4/5] docs/system/target-sparc: Improve the Sparc documentation

2024-03-07 Thread Thomas Huth
Add some words about how to enable or disable boolean features, and remove the note about a Linux kernel being available on the QEMU website (they have been removed long ago already). Signed-off-by: Thomas Huth --- docs/system/target-sparc.rst | 8 ++-- 1 file changed, 6 insertions(+), 2 del

[PATCH 1/5] target/sparc/cpu: Rename the CPU models with a "+" in their names

2024-03-07 Thread Thomas Huth
Commit b447378e12 ("qom/object: Limit type names to alphanumerical ...") cut down the amount of allowed characters for QOM types to a saner set. The "+" character was not meant to be included in this set, so we had to add a hack there to still allow the legacy names of POWER and Sparc64 CPUs. Howev

[PATCH 0/5] Sparc CPU naming and help text improvements

2024-03-07 Thread Thomas Huth
The Sparc CPU naming and the corresponding help text is somewhat confusing for the users. We should avoid spaces in the Names and provide clear information to the users what can be passed to the "-cpu" option. While we're at it, also remove the "+" from two of the CPU names since this character is

[PATCH 2/5] target/sparc/cpu: Avoid spaces by default in the CPU names

2024-03-07 Thread Thomas Huth
The output of "-cpu help" is currently rather confusing to the users: It is not clear which part of the output defines the CPU names since the CPU names contain white spaces (which we later have to convert into dashes internally) For example: Sparc TI UltraSparc II IU 001700112000 FPU

RE: [PATCH 1/3] ui/gtk: skip drawing guest scanout when associated VC is invisible

2024-03-07 Thread Kim, Dongwon
Hi Daniel, > -Original Message- > From: Daniel P. Berrangé > Sent: Thursday, March 7, 2024 1:41 AM > To: Kim, Dongwon > Cc: qemu-devel@nongnu.org > Subject: Re: [PATCH 1/3] ui/gtk: skip drawing guest scanout when associated > VC is invisible > > On Tue, Jan 30, 2024 at 03:48:38PM -0800,

KVM internal error due to non-atomic memslot updates by pci_update_vga()

2024-03-07 Thread Marcello Sylvester Bauer
Greetings, I'm facing a problem with KVM memslot updates in pci_update_vga() and I'm looking for a possible solution to prevent this error. Background: Over the past few weeks, we have been investigating a bug where QEMU Windows 10 VMs using VT-d Intel GPU passthrough suddenly crash due to an

Re: [PATCH] linux-aio: add IO_CMD_FDSYNC command support

2024-03-07 Thread Prasad Pandit
Hi, On Thu, 7 Mar 2024 at 19:21, Kevin Wolf wrote: > Kernel support for this is "relatively" new, added in 2018. Should we > fall back to the thread pool if we receive -EINVAL? laio_co_submit laio_do_submit ioq_submit io_submit * When an aio operation is not supported by the kernel,

[PATCH v6 10/17] hw/loongarch: fdt adds cpu interrupt controller node

2024-03-07 Thread Song Gao
fdt adds cpu interrupt controller node, we use 'loongson,cpu-interrupt-controller'. See: https://github.com/torvalds/linux/blob/v6.7/drivers/irqchip/irq-loongarch-cpu.c https://lore.kernel.org/r/20221114113824.1880-2-liupei...@loongson.cn Signed-off-by: Song Gao Message-Id: <20240301093839.66394

[PATCH v6 12/17] hw/loongarch: fdt adds pch_pic Controller

2024-03-07 Thread Song Gao
fdt adds pch pic controller, we use 'loongson,pch-pic-1.0' See: https://github.com/torvalds/linux/blob/v6.7/drivers/irqchip/irq-loongson-pch-pic.c https://lore.kernel.org/r/20200528152757.1028711-4-jiaxun.y...@flygoat.com Signed-off-by: Song Gao Message-Id: <20240301093839.663947-13-gaos...@loon

[PATCH v6 01/17] hw/loongarch: Move boot fucntions to boot.c

2024-03-07 Thread Song Gao
Move some boot functions to boot.c and struct loongarch_boot_info into struct LoongArchMachineState. Signed-off-by: Song Gao Message-Id: <20240301093839.663947-2-gaos...@loongson.cn> --- hw/loongarch/boot.c | 128 hw/loongarch/meson.build| 1 +

[PATCH v6 14/17] hw/loongarch: fdt adds pcie irq_map node

2024-03-07 Thread Song Gao
Signed-off-by: Song Gao Message-Id: <20240301093839.663947-15-gaos...@loongson.cn> --- hw/loongarch/virt.c | 73 ++--- 1 file changed, 69 insertions(+), 4 deletions(-) diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index 1e767c49f8..d00343f0c2 1006

[PATCH v6 15/17] hw/loongarch: fdt remove unused irqchip node

2024-03-07 Thread Song Gao
Signed-off-by: Song Gao Message-Id: <20240301093839.663947-16-gaos...@loongson.cn> --- hw/loongarch/virt.c | 31 +-- 1 file changed, 1 insertion(+), 30 deletions(-) diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index d00343f0c2..c80732a223 100644 --- a/hw/loo

[PATCH v6 11/17] hw/loongarch: fdt adds Extend I/O Interrupt Controller

2024-03-07 Thread Song Gao
fdt adds Extend I/O Interrupt Controller, we use 'loongson,ls2k2000-eiointc'. See: https://github.com/torvalds/linux/blob/v6.7/drivers/irqchip/irq-loongson-eiointc.c https://lore.kernel.org/r/764e02d924094580ac0f1d15535f4b98308705c6.1683279769.git.zhoubin...@loongson.cn Signed-off-by: Song Gao M

  1   2   3   4   >