Re: [PATCH v5] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER

2024-01-25 Thread Shaoqin Huang
Hi Eric, On 1/17/24 20:59, Eric Auger wrote: Hi Shaoqin, On 1/15/24 09:01, Shaoqin Huang wrote: The KVM_ARM_VCPU_PMU_V3_FILTER provides the ability to let the VMM decide which PMU events are provided to the guest. Add a new option `kvm-pmu-filter` as -cpu sub-option to set the PMU Event Filte

Re: [PATCH v7 9/9] ppc/pnv: Test pnv i2c master and connected devices

2024-01-25 Thread Cédric Le Goater
On 1/25/24 23:48, Glenn Miles wrote: Tests the following for both P9 and P10: - I2C master POR status - I2C master status after immediate reset Tests the following for powernv10-ranier only: - Config pca9552 hotplug device pins as inputs then Read the INPUT0/1 registers to verify a

Re: [PATCH trivial 1/2] close_all_open_fd(): move to oslib-posix.c

2024-01-25 Thread Laurent Vivier
Le 25/01/2024 à 23:29, Michael Tokarev a écrit : Initially in async-teardown.c, but the same construct is used elsewhere too. Signed-off-by: Michael Tokarev --- include/sysemu/os-posix.h | 1 + system/async-teardown.c | 37 + util/oslib-posix.c

RE: [PATCH v1 1/7] ui/spice: Add an option for users to provide a preferred codec

2024-01-25 Thread Kasireddy, Vivek
Hi Marc-Andre, > > Hi > > On Sat, Jan 20, 2024 at 4:54 AM Vivek Kasireddy > wrote: > > > > Giving users an option to choose a particular codec will enable > > them to make an appropriate decision based on their hardware and > > use-case. > > > > Cc: Gerd Hoffmann > > Cc: Marc-André Lureau > >

RE: [PATCH v1 3/7] ui/spice: Submit the gl_draw requests at 60 FPS for remote clients

2024-01-25 Thread Kasireddy, Vivek
Hi Marc-Andre, > > Hi > > On Sat, Jan 20, 2024 at 4:54 AM Vivek Kasireddy > wrote: > > > > In the specific case where the display layer (virtio-gpu) is using > > dmabuf, and if remote clients are enabled (-spice gl=on,port=), > > it makes sense to limit the maximum (streaming) rate to 60 FP

RE: [PATCH v1 2/7] ui/spice: Enable gl=on option for non-local or remote clients

2024-01-25 Thread Kasireddy, Vivek
Hi Marc-Andre, > > Hi > > On Sat, Jan 20, 2024 at 4:54 AM Vivek Kasireddy > wrote: > > > > Newer versions of Spice server should be able to accept dmabuf > > fds from Qemu for clients that are connected via the network. > > In other words, when this option is enabled, Qemu would share > > a dma

RE: [PATCH v1 7/7] ui/spice: Create another texture with linear layout when gl=on is enabled

2024-01-25 Thread Kasireddy, Vivek
Hi Marc-Andre, > > Hi > > On Sat, Jan 20, 2024 at 4:54 AM Vivek Kasireddy > wrote: > > > > Since most encoders (invoked by Spice) may not work with tiled memory > > associated with a texture, we need to create another texture that has > > linear memory layout and use that instead. > > > > Note

Re: [PATCH] vfio/pci: Clear MSI-X IRQ index always

2024-01-25 Thread Cédric Le Goater
On 1/25/24 15:42, Cédric Le Goater wrote: When doing device assignment of a physical device, MSI-X can be enabled with no vectors enabled and this sets the IRQ index to VFIO_PCI_MSIX_IRQ_INDEX. However, when MSI-X is disabled, the IRQ index is left untouched if no vectors are in use. Then, when I

[PULL 5/8] docs/interop/bitmaps: Clean up a reference to qemu-qmp-ref

2024-01-25 Thread Markus Armbruster
docs/interop/bitmaps.rst uses references like `qemu-qmp-ref `_ `query-block `_ to refer to and into docs/interop/qemu-qmp-ref.rst. Clean up the former: use :doc:`qemu-qmp-ref`. I don't know how to clean up the latter. Signed-off-by: Markus Armbruster Message-ID: <20240120095327.666239

[PULL 8/8] qapi: Fix malformed "Since:" section tags (again)

2024-01-25 Thread Markus Armbruster
"Since X.Y" is not recognized as a tagged section, and therefore not formatted as such in generated documentation. Fix by adding the required colon. Previously fixed in commit 433a4fdc420 (qapi: Fix malformed "Since:" section tags) Signed-off-by: Markus Armbruster Message-ID: <20240120095327.66

[PULL 1/8] docs/devel/qapi-code-gen: Don't reserve types ending with 'Kind'

2024-01-25 Thread Markus Armbruster
We reserved type names ending with 'Kind' because a simple union 'SomeSimpleUnion' generated both a struct type SomeSimpleUnion and an enum type SomeSimpleUnionKind. Gone since commit 4e99f4b12c0 (qapi: Drop simple unions). The commit neglected to update the documentation not to reserve type name

[PULL 0/8] QAPI patches patches for 2024-01-26

2024-01-25 Thread Markus Armbruster
The following changes since commit 5bab95dc74d43bbb28c6a96d24c810a664432057: Merge tag 'pull-request-2024-01-24' of https://gitlab.com/thuth/qemu into staging (2024-01-25 12:33:42 +) are available in the Git repository at: https://repo.or.cz/qemu/armbru.git tags/pull-qapi-2024-01-26 fo

[PULL 4/8] qapi: Fix dangling references to docs/devel/qapi-code-gen.txt

2024-01-25 Thread Markus Armbruster
Conversion of docs/devel/qapi-code-gen.txt to ReST left several dangling references behind. Fix them to point to docs/devel/qapi-code-gen.rst. Fixes: f7aa076dbdfc (docs: convert qapi-code-gen.txt to ReST) Signed-off-by: Markus Armbruster Message-ID: <20240120095327.666239-4-arm...@redhat.com> Re

[PULL 6/8] qapi: Fix mangled "Returns" sections in documentation

2024-01-25 Thread Markus Armbruster
Commit e050e426782e (qapi: Use explicit bulleted lists) added list markup to correct bad rendering: A JSON block comment like this: Returns: nothing on success If @node is not a valid block device, DeviceNotFound If @name is not found, GenericError

[PULL 3/8] docs: Replace dangling references to docs/interop/qmp-intro.txt

2024-01-25 Thread Markus Armbruster
Deletion of docs/interop/qmp-intro.txt left two dangling references behind. Replace them by references to docs/interop/qmp-spec.rst. Fixes: 0ec4468f233c (docs/interop: Delete qmp-intro.txt) Signed-off-by: Markus Armbruster Message-ID: <20240120095327.666239-3-arm...@redhat.com> Reviewed-by: Eric

[PULL 7/8] qapi: Indent tagged doc comment sections properly

2024-01-25 Thread Markus Armbruster
docs/devel/qapi-code-gen demands that the "second and subsequent lines of sections other than "Example"/"Examples" should be indented". Commit a937b6aa739 (qapi: Reformat doc comments to conform to current conventions) missed a few instances, and a few more have crept in since. Indent them. Signe

[PULL 2/8] docs/devel/qapi-code-gen: Fix missing ':' in tagged section docs

2024-01-25 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-ID: <20240120095327.666239-2-arm...@redhat.com> Reviewed-by: Eric Blake --- docs/devel/qapi-code-gen.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/devel/qapi-code-gen.rst b/docs/devel/qapi-code-gen.rst index 0c6f4201bc..

Re: [PATCH 0/7] qapi qmp: Documentation fixes

2024-01-25 Thread Markus Armbruster
Queued.

Re: [PATCH] docs/devel/qapi-code-gen: Don't reserve types ending with 'Kind'

2024-01-25 Thread Markus Armbruster
Markus Armbruster writes: > We reserved type names ending with 'Kind' because a simple union > 'SomeSimpleUnion' generated both a struct type SomeSimpleUnion and an > enum type SomeSimpleUnionKind. Gone since commit 4e99f4b12c0 (qapi: > Drop simple unions). The commit neglected to update the do

[PULL 10/15] migration: Fix use-after-free of migration state object

2024-01-25 Thread peterx
From: Fabiano Rosas We're currently allowing the process_incoming_migration_bh bottom-half to run without holding a reference to the 'current_migration' object, which leads to a segmentation fault if the BH is still live after migration_shutdown() has dropped the last reference to current_migrati

[PULL 15/15] Make 'uri' optional for migrate QAPI

2024-01-25 Thread peterx
From: Het Gala 'uri' argument should be optional, as 'uri' and 'channels' arguments are mutally exclusive in nature. Fixes: 074dbce5fcce (migration: New migrate and migrate-incoming argument 'channels') Signed-off-by: Het Gala Link: https://lore.kernel.org/r/20240123064219.40514-1-het.g...@nut

[PULL 09/15] migration/yank: Use channel features

2024-01-25 Thread peterx
From: Fabiano Rosas Stop using outside knowledge about the io channels when registering yank functions. Query for features instead. The yank method for all channels used with migration code currently is to call the qio_channel_shutdown() function, so query for QIO_CHANNEL_FEATURE_SHUTDOWN. We co

[PULL 08/15] ci: Disable migration compatibility tests for aarch64

2024-01-25 Thread peterx
From: Fabiano Rosas Until 9.0 is out, we need to keep the aarch64 job disabled because the tests always use the n-1 version of migration-test. That happens to be broken for aarch64 in 8.2. Once 9.0 is out, it will become the n-1 version and it will bring the fixed tests. We can revert this patch

[PULL 12/15] migration: Reference migration state around loadvm_postcopy_handle_run_bh

2024-01-25 Thread peterx
From: Fabiano Rosas We need to hold a reference to the current_migration object around async calls to avoid it been freed while still in use. Even on this load-side function, we might still use the MigrationState, e.g to check for capabilities. Signed-off-by: Fabiano Rosas Link: https://lore.ke

[PULL 13/15] migration: Add a wrapper to qemu_bh_schedule

2024-01-25 Thread peterx
From: Fabiano Rosas Wrap qemu_bh_schedule() to ensure we always hold a reference to the current_migration object. Signed-off-by: Fabiano Rosas Link: https://lore.kernel.org/r/20240119233922.32588-5-faro...@suse.de Signed-off-by: Peter Xu --- migration/migration.c | 31 ++--

[PULL 03/15] migration: Make threshold_size an uint64_t

2024-01-25 Thread peterx
From: Peter Xu It's always used to compare against another uint64_t. Make it always clear that it's never a negative. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Fabiano Rosas Link: https://lore.kernel.org/r/20240117075848.139045-2-pet...@redhat.com Signed-off-by: Peter Xu --- migratio

[PULL 04/15] migration: Drop unnecessary check in ram's pending_exact()

2024-01-25 Thread peterx
From: Peter Xu When the migration frameworks fetches the exact pending sizes, it means this check: remaining_size < s->threshold_size Must have been done already, actually at migration_iteration_run(): if (must_precopy <= s->threshold_size) { qemu_savevm_state_pending_exact(&must

[PULL 02/15] migration: Plug memory leak on HMP migrate error path

2024-01-25 Thread peterx
From: Markus Armbruster hmp_migrate() leaks @caps when qmp_migrate() fails. Plug the leak with g_autoptr(). Fixes: 967f2de5c9ec (migration: Implement MigrateChannelList to hmp migration flow.) v8.2.0-rc0 Fixes: CID 1533125 Signed-off-by: Markus Armbruster Link: https://lore.kernel.org/r/20240

[PULL 00/15] Migration 20240126 patches

2024-01-25 Thread peterx
From: Peter Xu The following changes since commit 5bab95dc74d43bbb28c6a96d24c810a664432057: Merge tag 'pull-request-2024-01-24' of https://gitlab.com/thuth/qemu into staging (2024-01-25 12:33:42 +) are available in the Git repository at: https://gitlab.com/peterx/qemu.git tags/migrati

[PULL 14/15] migration: Centralize BH creation and dispatch

2024-01-25 Thread peterx
From: Fabiano Rosas Now that the migration state reference counting is correct, further wrap the bottom half dispatch process to avoid future issues. Move BH creation and scheduling together and wrap the dispatch with an intermediary function that will ensure we always keep the ref/unref balance

[PULL 05/15] analyze-migration.py: Remove trick on parsing ramblocks

2024-01-25 Thread peterx
From: Peter Xu RAM_SAVE_FLAG_MEM_SIZE contains the total length of ramblock idstr to know whether scanning of ramblocks is complete. Drop the trick. Reviewed-by: Fabiano Rosas Link: https://lore.kernel.org/r/20240117075848.139045-4-pet...@redhat.com Signed-off-by: Peter Xu --- scripts/analyz

[PULL 11/15] migration: Take reference to migration state around bg_migration_vm_start_bh

2024-01-25 Thread peterx
From: Fabiano Rosas We need to hold a reference to the current_migration object around async calls to avoid it been freed while still in use. Signed-off-by: Fabiano Rosas Link: https://lore.kernel.org/r/20240119233922.32588-3-faro...@suse.de Signed-off-by: Peter Xu --- migration/migration.c |

[PULL 06/15] tests/qtest/migration: Don't use -cpu max for aarch64

2024-01-25 Thread peterx
From: Fabiano Rosas The 'max' cpu is not expected to be stable in terms of features across QEMU versions, so it should not be expected to migrate. While the tests currently all pass with -cpu max, that is only because we're not testing across QEMU versions, which is the more common use-case for

[PULL 07/15] ci: Add a migration compatibility test job

2024-01-25 Thread peterx
From: Fabiano Rosas The migration tests have support for being passed two QEMU binaries to test migration compatibility. Add a CI job that builds the lastest release of QEMU and another job that uses that version plus an already present build of the current version and run the migration tests wi

[PULL 01/15] userfaultfd: use 1ULL to build ioctl masks

2024-01-25 Thread peterx
From: Paolo Bonzini There is no need to use the Linux-internal __u64 type, 1ULL is guaranteed to be wide enough. Signed-off-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé Link: https://lore.kernel.org/r/20240117160313.175609-1-pbonz...@redhat.com Signed-off-by: Peter Xu --- migration/

[PATCH v11 04/11] hw/fsi: Introduce IBM's fsi-slave model

2024-01-25 Thread Ninad Palsule
This is a part of patchset where IBM's Flexible Service Interface is introduced. The FSI slave: The slave is the terminal point of the FSI bus for FSI symbols addressed to it. Slaves can be cascaded off of one another. The slave's configuration registers appear in address space of the CFAM to whic

[PATCH v11 10/11] hw/fsi: Added FSI documentation

2024-01-25 Thread Ninad Palsule
Documentation for IBM FSI model. Signed-off-by: Ninad Palsule --- v11: - Removed Cedri's signoff. --- docs/specs/fsi.rst | 138 +++ docs/specs/index.rst | 1 + 2 files changed, 139 insertions(+) create mode 100644 docs/specs/fsi.rst diff --git a/do

[PATCH v11 09/11] hw/fsi: Added qtest

2024-01-25 Thread Ninad Palsule
Added basic qtests for FSI model. Acked-by: Thomas Huth Signed-off-by: Ninad Palsule --- v11: - Removed Cedric's signoff --- tests/qtest/aspeed-fsi-test.c | 205 ++ tests/qtest/meson.build | 1 + 2 files changed, 206 insertions(+) create mode 100644 te

[PATCH v11 06/11] hw/fsi: Introduce IBM's FSI master

2024-01-25 Thread Ninad Palsule
This is a part of patchset where IBM's Flexible Service Interface is introduced. This commit models the FSI master. CFAM is hanging out of FSI master which is a bus controller. The FSI master: A controller in the platform service processor (e.g. BMC) driving CFAM engine accesses into the POWER c

[PATCH v11 01/11] hw/fsi: Introduce IBM's Local bus

2024-01-25 Thread Ninad Palsule
This is a part of patchset where IBM's Flexible Service Interface is introduced. The LBUS is modelled to maintain mapped memory for the devices. The memory is mapped after CFAM config, peek table and FSI slave registers. Signed-off-by: Andrew Jeffery [ clg: - removed lbus_add_device() bc unused

[PATCH v11 05/11] hw/fsi: Introduce IBM's cfam

2024-01-25 Thread Ninad Palsule
This is a part of patchset where IBM's Flexible Service Interface is introduced. The Common FRU Access Macro (CFAM), an address space containing various "engines" that drive accesses on busses internal and external to the POWER chip. Examples include the SBEFIFO and I2C masters. The engines hang o

[PATCH v11 11/11] hw/fsi: Update MAINTAINER list

2024-01-25 Thread Ninad Palsule
Added maintainer for IBM FSI model Signed-off-by: Ninad Palsule --- v11: - Added Cedric as reviewer. --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index dfaca8323e..39deb8ee1f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3585,6 +3585,15

[PATCH v11 02/11] hw/fsi: Introduce IBM's scratchpad device

2024-01-25 Thread Ninad Palsule
This is a part of patchset where IBM's Flexible Service Interface is introduced. The scratchpad provides a set of non-functional registers. The firmware is free to use them, hardware does not support any special management support. The scratchpad registers can be read or written from LBUS slave. T

[PATCH v11 08/11] hw/arm: Hook up FSI module in AST2600

2024-01-25 Thread Ninad Palsule
This patchset introduces IBM's Flexible Service Interface(FSI). Time for some fun with inter-processor buses. FSI allows a service processor access to the internal buses of a host POWER processor to perform configuration or debugging. FSI has long existed in POWER processes and so comes with some

[PATCH v11 03/11] hw/fsi: Introduce IBM's FSI Bus

2024-01-25 Thread Ninad Palsule
This is a part of patchset where FSI bus is introduced. The FSI bus is a simple bus where FSI master is attached. Signed-off-by: Andrew Jeffery [ clg: - removed include/hw/fsi/engine-scratchpad.h and hw/fsi/engine-scratchpad.c - dropped FSI_SCRATCHPAD - included FSIBus def

[PATCH v11 00/11] Introduce model for IBM's FSI

2024-01-25 Thread Ninad Palsule
Hello, Please review the patch-set version 11. I have incorporated review comments from Cedric. v10: - Moved aspeed-apb2opb to hw/fsi directory - Split some patches. - Fixed crash. - make check Ok: 319 Expected Fail: 0 Fail: 0 Une

[PATCH v11 07/11] hw/fsi: Aspeed APB2OPB & On-chip peripheral bus

2024-01-25 Thread Ninad Palsule
This is a part of patchset where IBM's Flexible Service Interface is introduced. An APB-to-OPB bridge enabling access to the OPB from the ARM core in the AST2600. Hardware limitations prevent the OPB from being directly mapped into APB, so all accesses are indirect through the bridge. The On-Chip

Re: [PATCH v7 10/16] i386/cpu: Introduce cluster-id to X86CPU

2024-01-25 Thread Zhao Liu
Hi Xiaoyao, > > > > generic cluster just means the cluster of processors, i.e, a group of > > > > cpus/lps. It is just a middle level between die and core. > > > > > > Not sure if you mean the "cluster" device for TCG GDB? "cluster" device > > > is different with "cluster" option in -smp. > > >

Re: [PATCH 03/17] migration: Rename default_channel to main_channel

2024-01-25 Thread Peter Xu
On Thu, Jan 25, 2024 at 06:25:14PM +0200, Avihai Horon wrote: > migration_ioc_process_incoming() uses the term "default_channel" to > describe the main migration channel. Rename it to the more commonly used > and informative term "main_channel". > > Signed-off-by: Avihai Horon Reviewed-by: Peter

Re: [PATCH 02/17] migration: Move local_err check in migration_ioc_process_incoming()

2024-01-25 Thread Peter Xu
On Thu, Jan 25, 2024 at 06:25:13PM +0200, Avihai Horon wrote: > local_err in migration_ioc_process_incoming() is used only in the > multifd if branch. Move the local_err check under the multifd branch, > where it is actually used. > > Signed-off-by: Avihai Horon Reviewed-by: Peter Xu -- Peter

Re: [PATCH 01/17] migration: Fix logic of channels and transport compatibility check

2024-01-25 Thread Peter Xu
On Thu, Jan 25, 2024 at 06:25:12PM +0200, Avihai Horon wrote: > The commit in the fixes line mistakenly modified the channels and > transport compatibility check logic so it now checks multi-channel > support only for socket transport type. > > Thus, running multifd migration using a transport oth

Re: [PATCH v10 5/9] hw/fsi: Aspeed APB2OPB interface, Onchip perif bus

2024-01-25 Thread Ninad Palsule
Hello Cedric, Signed-off-by: Andrew Jeffery Signed-off-by: Cédric Le Goater Signed-off-by: Ninad Palsule Reviewed-by: Joel Stanley Nah. Joel you should re-review next respin :) Removed Joel's review tag. ---   include/hw/misc/aspeed-apb2opb.h |  50 +   hw/misc/aspeed-apb2opb.c  

Re: [PATCH v15 0/9] rutabaga_gfx + gfxstream

2024-01-25 Thread Gurchetan Singh
On Sat, Jan 20, 2024 at 4:19 AM Alyssa Ross wrote: > Gurchetan Singh writes: > > > On Fri, Jan 19, 2024 at 1:13 PM Alyssa Ross wrote: > >> > >> Hi Gurchetan, > >> > >> > Thanks for the reminder. I did make a request to create the release > >> > tags, but changes were requested by Fedora packag

[PATCH v2 1/3] hw/i2c: core: Add reset

2024-01-25 Thread Joe Komlodi
It's possible for a reset to come in the middle of a transaction, which causes the bus to be in an old state when a new transaction comes in. Signed-off-by: Joe Komlodi --- hw/i2c/core.c| 30 +- include/hw/i2c/i2c.h | 6 +- 2 files changed, 30 insertions(

[PATCH v2 3/3] hw/i2c: smbus_slave: Reset state on reset

2024-01-25 Thread Joe Komlodi
If a reset comes while the SMBus device is not in its idle state, it's possible for it to get confused on valid transactions post-reset. Signed-off-by: Joe Komlodi --- hw/i2c/smbus_slave.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/i2c/smbus_slave.c b/hw/i2c/smbus_slave.c in

[PATCH v2 0/3] hw/i2c: smbus: Reset fixes

2024-01-25 Thread Joe Komlodi
Changelog: v1 -> v2 - Dropped 4th patch "hw/i2c: smbus: mux: Reset SMBusDevice state on reset". After more testing and Corey's comment, I realized it wasn't needed. Original message: Hi all, This series adds some resets for SMBus and for the I2C core. Along with it, we make SMBus slave error pr

[PATCH v2 2/3] hw/i2c/smbus_slave: Add object path on error prints

2024-01-25 Thread Joe Komlodi
The current logging doesn't tell us which specific smbus device is an error state. Signed-off-by: Joe Komlodi --- hw/i2c/smbus_slave.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/i2c/smbus_slave.c b/hw/i2c/smbus_slave.c index 1300c9ec72..e24a1ef472 100644 --- a

Re: [PATCH v10 3/9] hw/fsi: Introduce IBM's cfam

2024-01-25 Thread Ninad Palsule
Hello Cedric, [ clg: - moved object FSIScratchPad under FSICFAMState     - moved FSIScratchPad code under cfam.c     - introduced fsi_cfam_instance_init()     - reworked fsi_cfam_realize() ] Move the list down before my S-o-b. Done. + +/* Valid, slots, version, type, crc */ +

Re: [PATCH v10 2/9] hw/fsi: Introduce IBM's FSI Bus and FSI slave

2024-01-25 Thread Ninad Palsule
Hello Cedric, The FSI slave: The slave is the terminal point of the FSI bus for FSI symbols addressed to it. Slaves can be cascaded off of one another. The slave's configuration registers appear in address space of the CFAM to which it is attached. Please add another patch. Added new patch f

Re: [External] Re: [PATCH v2 04/20] So we use multifd to transmit zero pages.

2024-01-25 Thread Hao Xiang
On Thu, Jan 25, 2024 at 3:14 PM Fabiano Rosas wrote: > > Hao Xiang writes: > > > On Mon, Jan 22, 2024 at 8:28 PM Hao Xiang wrote: > >> > >> On Thu, Nov 16, 2023 at 7:14 AM Fabiano Rosas wrote: > >> > > >> > Hao Xiang writes: > >> > > >> > > From: Juan Quintela > >> > > > >> > > Signed-off-by:

Re: [PATCH v10 1/9] hw/fsi: Introduce IBM's Local bus and scratchpad

2024-01-25 Thread Ninad Palsule
Hello Cedric, [ clg: - removed lbus_add_device() bc unused     - removed lbus_create_device() bc used only once     - removed "address" property     - updated meson.build to build fsi dir     - included an empty hw/fsi/trace-events ] this list of modifications should be befo

Re: [External] Re: [PATCH v2 04/20] So we use multifd to transmit zero pages.

2024-01-25 Thread Fabiano Rosas
Hao Xiang writes: > On Mon, Jan 22, 2024 at 8:28 PM Hao Xiang wrote: >> >> On Thu, Nov 16, 2023 at 7:14 AM Fabiano Rosas wrote: >> > >> > Hao Xiang writes: >> > >> > > From: Juan Quintela >> > > >> > > Signed-off-by: Juan Quintela >> > > Reviewed-by: Leonardo Bras >> > > --- >> > > migrati

[PATCH v7 8/9] ppc/pnv: Add a pca9554 I2C device to powernv10-rainier

2024-01-25 Thread Glenn Miles
For powernv10-rainier, the Power Hypervisor code expects to see a pca9554 device connected to the 3rd PNV I2C engine on port 1 at I2C address 0x25 (or left-justified address of 0x4A). This is used by the hypervisor code to detect if a "Cable Card" is present. Reviewed-by: Cédric Le Goater Signed

[PATCH v7 4/9] ppc/pnv: Add pca9552 to powernv10-rainier for PCIe hotplug power control

2024-01-25 Thread Glenn Miles
The Power Hypervisor code expects to see a pca9552 device connected to the 3rd PNV I2C engine on port 1 at I2C address 0x63 (or left- justified address of 0xC6). This is used by hypervisor code to control PCIe slot power during hotplug events. Reviewed-by: Cédric Le Goater Signed-off-by: Glenn M

[PATCH v7 3/9] ppc/pnv: New powernv10-rainier machine type

2024-01-25 Thread Glenn Miles
Create a new powernv machine type, powernv10-rainier, that will contain rainier-specific devices. Reviewed-by: Cédric Le Goater Signed-off-by: Glenn Miles --- No changes from previous version hw/ppc/pnv.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --

[PATCH v7 2/9] misc/pca9552: Let external devices set pca9552 inputs

2024-01-25 Thread Glenn Miles
Allow external devices to drive pca9552 input pins by adding input GPIO's to the model. This allows a device to connect its output GPIO's to the pca9552 input GPIO's. In order for an external device to set the state of a pca9552 pin, the pin must first be configured for high impedance (LED is off

[PATCH v7 9/9] ppc/pnv: Test pnv i2c master and connected devices

2024-01-25 Thread Glenn Miles
Tests the following for both P9 and P10: - I2C master POR status - I2C master status after immediate reset Tests the following for powernv10-ranier only: - Config pca9552 hotplug device pins as inputs then Read the INPUT0/1 registers to verify all pins are high - Connected GPIO pin tes

[PATCH v7 7/9] misc: Add a pca9554 GPIO device model

2024-01-25 Thread Glenn Miles
Specs are available here: https://www.nxp.com/docs/en/data-sheet/PCA9554_9554A.pdf This is a simple model supporting the basic registers for GPIO mode. The device also supports an interrupt output line but the model does not yet support this. Reviewed-by: Cédric Le Goater Signed-off-by: Gl

[PATCH v7 1/9] misc/pca9552: Fix inverted input status

2024-01-25 Thread Glenn Miles
The pca9552 INPUT0 and INPUT1 registers are supposed to hold the logical values of the LED pins. A logical 0 should be seen in the INPUT0/1 registers for a pin when its corresponding LSn bits are set to 0, which is also the state needed for turning on an LED in a typical usage scenario. Existing

[PATCH v7 5/9] ppc/pnv: Wire up pca9552 GPIO pins for PCIe hotplug power control

2024-01-25 Thread Glenn Miles
For power10-rainier, a pca9552 device is used for PCIe slot hotplug power control by the Power Hypervisor code. The code expects that some time after it enables power to a PCIe slot by asserting one of the pca9552 GPIO pins 0-4, it should see a "power good" signal asserted on one of pca9552 GPIO p

[PATCH v7 6/9] ppc/pnv: Use resettable interface to reset child I2C buses

2024-01-25 Thread Glenn Miles
The QEMU I2C buses and devices use the resettable interface for resetting while the PNV I2C controller and parent buses and devices have not yet transitioned to this new interface and use the old reset strategy. This was preventing the I2C buses and devices wired to the PNV I2C controller from bein

[PATCH v7 0/9] Add powernv10 I2C devices and tests

2024-01-25 Thread Glenn Miles
This series of patches includes support, tests and fixes for adding PCA9552 and PCA9554 I2C devices to the powernv10 chip. The PCA9552 device is used for PCIe slot hotplug power control and monitoring, while the PCA9554 device is used for presence detection of IBM CableCard devices. Both devices

[PATCH trivial 1/2] close_all_open_fd(): move to oslib-posix.c

2024-01-25 Thread Michael Tokarev
Initially in async-teardown.c, but the same construct is used elsewhere too. Signed-off-by: Michael Tokarev --- include/sysemu/os-posix.h | 1 + system/async-teardown.c | 37 + util/oslib-posix.c| 36 3 files cha

[PATCH trivial 2/2] net/tap: use os_close_all_open_fd() instead of open-coding it

2024-01-25 Thread Michael Tokarev
Current code loops over every file descriptor up to SC_OPEN_MAX/RLIMIT_NOFILE which might be huge and the loop might be slow. But we already have os_close_all_open_fd() which is fast. Use it. Signed-off-by: Michael Tokarev --- net/tap.c | 15 ++- 1 file changed, 2 insertions(+), 13

[PATCH trivial 0/2] split out os_close_all_open_fd and use it in net/tap.c too

2024-01-25 Thread Michael Tokarev
We have at least two places in qemu where we're closing all possible file descriptors, - in async-teardown.c and in net/tap.c. While async-teardown one uses either close_range() or readdir(/proc/self/fd), the two calls in net/tap.c loops from 3 to RLIMIT_NOFILE, which might be quite slow, and it a

Re: [External] Re: [PATCH v2 04/20] So we use multifd to transmit zero pages.

2024-01-25 Thread Hao Xiang
On Mon, Jan 22, 2024 at 8:28 PM Hao Xiang wrote: > > On Thu, Nov 16, 2023 at 7:14 AM Fabiano Rosas wrote: > > > > Hao Xiang writes: > > > > > From: Juan Quintela > > > > > > Signed-off-by: Juan Quintela > > > Reviewed-by: Leonardo Bras > > > --- > > > migration/multifd.c | 7 --- > > >

Re: [PATCH v2] target/i386/host-cpu: Use iommu phys_bits with VFIO assigned devices on Intel h/w

2024-01-25 Thread Alex Williamson
On Thu, 25 Jan 2024 09:18:02 +0100 Eric Auger wrote: > Hi Vivek, > > On 1/18/24 20:20, Vivek Kasireddy wrote: > > Recent updates in OVMF and Seabios have resulted in MMIO regions > > being placed at the upper end of the physical address space. As a > > result, when a Host device is assigned to t

Re: [PATCH 04/17] migration/multifd: Set p->running = true in the right place

2024-01-25 Thread Fabiano Rosas
Avihai Horon writes: > The commit in the fixes line moved multifd thread creation to a > different location, but forgot to move the p->running = true assignment > as well. Thus, p->running is set to true before multifd thread is > actually created. > > p->running is used in multifd_save_cleanup()

Re: [PATCH] iotests: don't run tests requiring cached writes in '-nocache' mode

2024-01-25 Thread Eric Blake
On Mon, Dec 11, 2023 at 03:32:23PM +0200, Andrey Drobyshev wrote: > There're tests whose logic implies running without O_DIRECT set, > otherwise they fail when running iotests in '-nocache' mode. For these > tests let's add _require_no_o_direct() helper which can be put in the > preabmle and which

Re: [PATCH] iotests/264: Use iotests.sock_dir for socket creation

2024-01-25 Thread Eric Blake
On Thu, Jan 25, 2024 at 03:52:37PM +0200, Andrey Drobyshev wrote: > If socket path is too long (longer than 108 bytes), socket can't be > opened. This might lead to failure when test dir path is long enough. > Make sure socket is created in iotests.sock_dir to avoid such a case. > > This commit b

Re: [PATCH] vfio/pci: Clear MSI-X IRQ index always

2024-01-25 Thread Alex Williamson
On Thu, 25 Jan 2024 15:42:20 +0100 Cédric Le Goater wrote: > When doing device assignment of a physical device, MSI-X can be > enabled with no vectors enabled and this sets the IRQ index to > VFIO_PCI_MSIX_IRQ_INDEX. However, when MSI-X is disabled, the IRQ > index is left untouched if no vectors

Re: [PATCH v2] hw/arm: add PCIe to Freescale i.MX6

2024-01-25 Thread Nikita Ostrenkov
Ping https://patchew.org/QEMU/20240108140325.1291-1-n.ostren...@gmail.com/ пн, 8 янв. 2024 г., 17:03 Nikita Ostrenkov : > Signed-off-by: Nikita Ostrenkov > --- > hw/arm/Kconfig| 2 ++ > hw/arm/fsl-imx6.c | 25 ++ > include/hw/arm/fsl-imx6.h | 44

[PATCH] {linux, bsd}-user: Fail mmap() if size doesn't fit into host's size_t

2024-01-25 Thread Ilya Leoshkevich
s390x's branch-relative-long test fails with the following error message on 32-bit hosts: qemu-s390x: ../accel/tcg/user-exec.c:493: page_set_flags: Assertion `last <= GUEST_ADDR_MAX' failed. The root cause is that the size passed to mmap() by this test does not fit into 32 bits and gets trun

Re: [PATCH v3] hw/usb: fix xhci port notify

2024-01-25 Thread Nikita Ostrenkov
ping https://patchew.org/QEMU/20231117173916.3658-1-n.ostren...@gmail.com/ пн, 18 дек. 2023 г., 13:40 Nikita Ostrenkov : > ping > https://patchew.org/QEMU/20231117173916.3658-1-n.ostren...@gmail.com/ > > пт, 17 нояб. 2023 г., 20:39 Nikita Ostrenkov : > >> From MCF5253 Reference manual >> https://

[PATCH 6/6] target/riscv: Promote svade to a normal extension

2024-01-25 Thread Daniel Henrique Barboza
From: Andrew Jones Named features are extensions which don't make sense for users to control and are therefore not exposed on the command line. However, svade is an extension which makes sense for users to control, so treat it like a "normal" extension. The default is false, since QEMU has always

[PATCH 5/6] target/riscv: Gate hardware A/D PTE bit updating

2024-01-25 Thread Daniel Henrique Barboza
From: Andrew Jones Gate hardware A/D PTE bit updating on {m,h}envcfg.ADUE and only enable menvcfg.ADUE on reset if svade has not been selected. Now that we also consider svade, we have four possible configurations: 1) !svade && !svadu use hardware updating and there's no way to disable it

[PATCH 3/6] target/riscv: add remaining named features

2024-01-25 Thread Daniel Henrique Barboza
The RVA22U64 and RVA22S64 profiles mandates certain extensions that, until now, we were implying that they were available. We can't do this anymore since named features also has a riscv,isa entry. Let's add them to riscv_cpu_named_features[]. They will also need to be explicitly enabled in both

[PATCH 1/6] target/riscv/tcg: set 'mmu' with 'satp' in cpu_set_profile()

2024-01-25 Thread Daniel Henrique Barboza
Recent changes in options handling removed the 'mmu' default the bare CPUs had, meaning that we must enable 'mmu' by hand when using the rva22s64 profile CPU. Given that this profile is setting a satp mode, it already implies that we need a 'mmu'. Enable the 'mmu' in this case. Signed-off-by: Dan

[PATCH 2/6] target/riscv: add riscv,isa to named features

2024-01-25 Thread Daniel Henrique Barboza
Further discussions after the introduction of rva22 support in QEMU revealed that what we've been calling 'named features' are actually regular extensions, with their respective riscv,isa DTs. This is clarified in [1]. [2] is a bug tracker asking for the profile spec to be less cryptic about it. A

[PATCH 0/6] riscv: named features riscv,isa, 'svade' rework

2024-01-25 Thread Daniel Henrique Barboza
Hi, This is a bundle of fixes based on discoveries that were made in the last week or so: - what we call "named features" are actually real extensions, which are considered to be ratified by the profile spec that defines them. This means that we need to add riscv,isa strings for them. More in

[PATCH 4/6] target/riscv: Reset henvcfg to zero

2024-01-25 Thread Daniel Henrique Barboza
From: Andrew Jones The hypervisor should decide what it wants to enable. Zero all configuration enable bits on reset. Also, commit ed67d63798f2 ("target/riscv: Update CSR bits name for svadu extension") missed one reference to 'hade'. Change it now. Fixes: 0af3f115e68e ("target/riscv: Add *envc

[PATCH 1/3] tests/vm: Set UseDNS=no in the sshd configuration

2024-01-25 Thread Ilya Leoshkevich
make vm-build-freebsd sometimes fails with "Connection timed out during banner exchange". The client strace shows: 13:59:30 write(3, "SSH-2.0-OpenSSH_9.3\r\n", 21) = 21 13:59:30 getpid() = 252655 13:59:30 poll([{fd=3, events=POLLIN}], 1, 5000) = 1 ([{fd=3, revent

[PATCH 2/3] tests/vm/freebsd: Reload the sshd configuration

2024-01-25 Thread Ilya Leoshkevich
After console_sshd_config(), the SSH server needs to be nudged to pick up the new configs. The scripts for the other BSD flavors already do this with a reboot, but a simple reload is sufficient. Signed-off-by: Ilya Leoshkevich --- tests/vm/freebsd | 2 ++ 1 file changed, 2 insertions(+) diff --

Re: [PATCH 0/7] qapi qmp: Documentation fixes

2024-01-25 Thread Eric Blake
On Sat, Jan 20, 2024 at 10:53:20AM +0100, Markus Armbruster wrote: > Markus Armbruster (7): > docs/devel/qapi-code-gen: Fix missing ':' in tagged section docs > docs: Replace dangling references to docs/interop/qmp-intro.txt > qapi: Fix dangling references to docs/devel/qapi-code-gen.txt >

[PATCH 3/3] meson: Disable CONFIG_NOTIFY1 on FreeBSD

2024-01-25 Thread Ilya Leoshkevich
make vm-build-freebsd fails with: ld: error: undefined symbol: inotify_init1 >>> referenced by filemonitor-inotify.c:183 (../src/util/filemonitor-inotify.c:183) >>> util_filemonitor-inotify.c.o:(qemu_file_monitor_new) in archive libqemuutil.a On FreeBSD inotify functio

[PATCH 0/3] make vm-build-freebsd fixes

2024-01-25 Thread Ilya Leoshkevich
Hi, I needed to verify that my qemu-user changes didn't break BSD, and Daniel Berrange suggested vm-build-freebsd on IRC. I had several problems with it, which this series resolves. Best regards, Ilya Ilya Leoshkevich (3): tests/vm: Set UseDNS=no in the sshd configuration tests/vm/freebsd: R

[PATCH v15 8/9] hw/net: GMAC Tx Implementation

2024-01-25 Thread Nabih Estefan
From: Nabih Estefan Diaz - Implementation of Transmit function for packets - Implementation for reading and writing from and to descriptors in memory for Tx Added relevant trace-events NOTE: This function implements the steps detailed in the datasheet for transmitting messages from the GMAC.

[PATCH v15 4/9] hw/net: Add NPCMXXX GMAC device

2024-01-25 Thread Nabih Estefan
From: Hao Wu This patch implements the basic registers of GMAC device and sets registers for networking functionalities. Squashed IRQ Implementation patch into this one for compliation. Tested: The following message shows up with the change: Broadcom BCM54612E stmmac-0:00: attached PHY driver [Br

[PATCH v15 6/9] tests/qtest: Creating qtest for GMAC Module

2024-01-25 Thread Nabih Estefan
From: Nabih Estefan Diaz - Created qtest to check initialization of registers in GMAC Module. - Implemented test into Build File. Change-Id: I8b2fe152d3987a7eec4cf6a1d25ba92e75a5391d Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- tests/qtest/meson.build | 1 + tests/qtest/

[PATCH v15 5/9] hw/arm: Add GMAC devices to NPCM7XX SoC

2024-01-25 Thread Nabih Estefan
From: Hao Wu Change-Id: Id8a3461fb5042adc4c3fd6f4fbd1ca0d33e22565 Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- hw/arm/npcm7xx.c | 36 ++-- include/hw/arm/npcm7xx.h | 2 ++ 2 files changed, 36 insertions(+), 2 deletion

  1   2   3   >