Re: [PATCH 20/71] hw/9pfs: Constify VMState

2023-11-05 Thread Greg Kurz
On Sun, 5 Nov 2023 22:57:36 -0800 Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- Acked-by: Greg Kurz > hw/9pfs/virtio-9p-device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c > index 5f52

[PULL 16/23] ui/vnc: VNC requires PIXMAN

2023-11-05 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- meson.build| 6 +- ui/meson.build | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 2d67cbf6d6..f3fc1ba68d 100644 --- a/meson.build +++ b/meson.bui

[PULL 20/23] arm/kconfig: XLNX_ZYNQMP_ARM depends on PIXMAN

2023-11-05 Thread marcandre . lureau
From: Marc-André Lureau The Display Port has some strong PIXMAN dependency. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- hw/arm/Kconfig | 3 ++- hw/display/Kconfig | 5 + hw/display/meson.build | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) diff --g

[PULL 14/23] vhost-user-gpu: skip VHOST_USER_GPU_UPDATE when !PIXMAN

2023-11-05 Thread marcandre . lureau
From: Marc-André Lureau This simply means that 2d drawing updates won't be handled, but 3d should work. Signed-off-by: Marc-André Lureau Acked-by: Michael S. Tsirkin --- hw/display/vhost-user-gpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/display/vhost-user-gpu.c b/hw/display/

[PULL 22/23] hw/display: make ATI_VGA depend on PIXMAN

2023-11-05 Thread marcandre . lureau
From: Marc-André Lureau To avoid a kconfig cycle, change "depends on PCI" to "select PCI". Signed-off-by: Marc-André Lureau Acked-by: BALATON Zoltan --- configs/devices/mips64el-softmmu/default.mak | 3 +-- hw/display/Kconfig | 3 ++- hw/display/meson.build

[PULL 15/23] ui/gl: opengl doesn't require PIXMAN

2023-11-05 Thread marcandre . lureau
From: Marc-André Lureau The QEMU fallback covers the requirements. We still need the flags of header inclusion with CONFIG_PIXMAN. Signed-off-by: Marc-André Lureau --- ui/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/meson.build b/ui/meson.build index 3

[PULL 21/23] hw/sm501: allow compiling without PIXMAN

2023-11-05 Thread marcandre . lureau
From: Marc-André Lureau Change the "x-pixman" property default value and use the fallback path when PIXMAN support is disabled. Signed-off-by: Marc-André Lureau Reviewed-by: BALATON Zoltan --- hw/display/sm501.c | 46 +- 1 file changed, 33 insertion

[PULL 08/23] vl: move display early init before default devices

2023-11-05 Thread marcandre . lureau
From: Marc-André Lureau The next commit needs to have the display registered itself before creating the default VCs. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- system/vl.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/

[PULL 04/23] ui: add pixman-minimal.h

2023-11-05 Thread marcandre . lureau
From: Marc-André Lureau This is a tiny subset of PIXMAN API that is used pervasively in QEMU codebase to manage images and identify the underlying format. It doesn't seems worth to wrap this in a QEMU-specific API. Signed-off-by: Marc-André Lureau Acked-by: Thomas Huth --- include/ui/pixman-

[PULL 19/23] ui/dbus: do not require PIXMAN

2023-11-05 Thread marcandre . lureau
From: Marc-André Lureau Implement a fallback path for region 2D update. Signed-off-by: Marc-André Lureau --- ui/dbus-listener.c | 90 -- ui/meson.build | 4 +-- 2 files changed, 65 insertions(+), 29 deletions(-) diff --git a/ui/dbus-listener.c

[PULL 13/23] ui/console: when PIXMAN is unavailable, don't draw placeholder msg

2023-11-05 Thread marcandre . lureau
From: Marc-André Lureau When we can't draw text, simply show a blank display. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- ui/console.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/console.c b/ui/console.c index a72c495b5a..8e688d3569 100644 --- a/ui/console.c +++

[PULL 23/23] build-sys: make pixman actually optional

2023-11-05 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- meson.build | 3 --- 1 file changed, 3 deletions(-) diff --git a/meson.build b/meson.build index ad1e0155ee..a35cd860aa 100644 --- a/meson.build +++ b/meson.build @@ -817,9 +817,6 @@ if not get_option('pixma

[PULL 09/23] ui/console: allow to override the default VC

2023-11-05 Thread marcandre . lureau
From: Marc-André Lureau If a display is backed by a specialized VC, allow to override the default "vc:80Cx24C". As suggested by Paolo, if the display doesn't implement a VC (get_vc() returns NULL), use a fallback that will use a muxed console on stdio. This changes the behaviour of "qemu -displ

[PULL 11/23] qmp/hmp: disable screendump if PIXMAN is missing

2023-11-05 Thread marcandre . lureau
From: Marc-André Lureau The command requires color conversion and line-by-line feeding. We could have a simple fallback for simple formats though. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- qapi/ui.json | 3 ++- ui/ui-hmp-cmds.c | 2

[PULL 18/23] ui/gtk: -display gtk requires PIXMAN

2023-11-05 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- meson.build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 0dbad80fcc..ad1e0155ee 100644 --- a/meson.build +++ b/meson.build @@ -1507,7 +1507,11 @@ gt

[PULL 10/23] ui/vc: console-vc requires PIXMAN

2023-11-05 Thread marcandre . lureau
From: Marc-André Lureau Add stubs for the fallback paths. get_vc() now returns NULL by default if !PIXMAN. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- ui/console-vc-stubs.c | 33 + ui/console.c | 3 +++ ui/meson.build| 2 +-

[PULL 03/23] ui: compile out some qemu-pixman functions when !PIXMAN

2023-11-05 Thread marcandre . lureau
From: Marc-André Lureau Those functions require the PIXMAN library. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- include/ui/qemu-pixman.h | 7 +-- ui/qemu-pixman.c | 6 ++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/include/ui/qemu-pixman.h

[PULL 12/23] virtio-gpu: replace PIXMAN for region/rect test

2023-11-05 Thread marcandre . lureau
From: Marc-André Lureau Use a simpler implementation for rectangle geometry & intersect, drop the need for (more complex) PIXMAN functions. Signed-off-by: Marc-André Lureau Acked-by: Michael S. Tsirkin --- include/ui/rect.h | 59 + hw/display/virt

[PULL 17/23] ui/spice: SPICE/QXL requires PIXMAN

2023-11-05 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- meson.build| 6 +- hw/display/Kconfig | 2 +- ui/meson.build | 10 +- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/meson.build b/meson.build index f3fc1ba68d..0dba

[PULL 06/23] qemu-options: define -vnc only #ifdef CONFIG_VNC

2023-11-05 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- system/vl.c | 13 + ui/vnc-stubs.c | 12 qemu-options.hx | 2 ++ 3 files changed, 11 insertions(+), 16 deletions(-) diff --git a/system/vl.c b/system/vl.c index fb0389e4d0..19a

[PULL 01/23] build-sys: add a "pixman" feature

2023-11-05 Thread marcandre . lureau
From: Marc-André Lureau For now, pixman is mandatory, but we set config_host.h and Kconfig. Once compilation is fixed, "pixman" will become actually optional. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- meson.build | 10 -- include/ui/qemu-pixman.h

[PULL 00/23] Pixman patches

2023-11-05 Thread marcandre . lureau
From: Marc-André Lureau The following changes since commit d762bf97931b58839316b68a570eecc6143c9e3e: Merge tag 'pull-target-arm-20231102' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2023-11-03 10:04:12 +0800) are available in the Git repository at: https://gitlab.com

[PULL 05/23] vl: drop needless -spice checks

2023-11-05 Thread marcandre . lureau
From: Marc-André Lureau Since commit 5324e3e958e ("qemu-options: define -spice only #ifdef CONFIG_SPICE"), it is unnecessary to check at runtime for "-spice" option. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- system/vl.c | 7 +-- 1 file changed, 1 insertion(+), 6 deleti

[PULL 07/23] vl: simplify display_remote logic

2023-11-05 Thread marcandre . lureau
From: Marc-André Lureau Bump the display_remote variable when the -vnc option is parsed, just like -spice. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- system/vl.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/system/vl.c b/system/vl.c index 19aef76

[PULL 02/23] build-sys: drop needless warning pragmas for old pixman

2023-11-05 Thread marcandre . lureau
From: Marc-André Lureau Since commit 236f282c1c7 ("configure: check for pixman-1 version"), QEMU requires >= 0.21.8. Suggested-by: Thomas Huth Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- include/ui/qemu-pixman.h | 4 1 file changed, 4 deletions(-) diff --git a/include

Re: [PATCH v2 02/16] target: Mention 'cpu-qom.h' is target agnostic

2023-11-05 Thread Philippe Mathieu-Daudé
On 20/10/23 09:14, Zhao Liu wrote: Hi Philippe, On Fri, Oct 13, 2023 at 04:01:01PM +0200, Philippe Mathieu-Daudé wrote: Date: Fri, 13 Oct 2023 16:01:01 +0200 From: Philippe Mathieu-Daudé Subject: [PATCH v2 02/16] target: Mention 'cpu-qom.h' is target agnostic X-Mailer: git-send-email 2.41.0 "

[PATCH 10/71] target/m68k: Constify VMState in machine.c

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/m68k/cpu.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/target/m68k/cpu.c b/target/m68k/cpu.c index 538d9473c2..63b40de762 100644 --- a/target/m68k/cpu.c +++ b/target/m68k/cpu.c @@ -382,7 +382,7 @@ static const VM

[PATCH 37/71] hw/isa: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/isa/apm.c | 2 +- hw/isa/i82378.c | 2 +- hw/isa/lpc_ich9.c | 8 hw/isa/pc87312.c | 2 +- hw/isa/piix.c | 8 hw/isa/vt82c686.c | 4 ++-- 6 files changed, 13 insertions(+), 13 deletions(-) diff --git a/hw/isa/apm.c b/hw/isa/apm

[PATCH 48/71] hw/riscv: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/riscv/virt-acpi-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/riscv/virt-acpi-build.c b/hw/riscv/virt-acpi-build.c index 7331248f59..d3bfaf502e 100644 --- a/hw/riscv/virt-acpi-build.c +++ b/hw/riscv/virt-acpi-build.c @@ -374

[PATCH 35/71] hw/ipack: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/ipack/ipack.c | 2 +- hw/ipack/tpci200.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ipack/ipack.c b/hw/ipack/ipack.c index ae20f36da6..c39dbb481f 100644 --- a/hw/ipack/ipack.c +++ b/hw/ipack/ipack.c @@ -93,7 +93,7 @@ const V

[PATCH 49/71] hw/rtc: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/rtc/allwinner-rtc.c | 2 +- hw/rtc/aspeed_rtc.c | 2 +- hw/rtc/ds1338.c | 2 +- hw/rtc/exynos4210_rtc.c | 2 +- hw/rtc/goldfish_rtc.c| 2 +- hw/rtc/ls7a_rtc.c| 2 +- hw/rtc/m48t59.c | 2 +- hw/rtc/mc146818rtc.c | 6

[PATCH 62/71] hw/misc/macio: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/misc/macio/cuda.c | 2 +- hw/misc/macio/gpio.c | 2 +- hw/misc/macio/mac_dbdma.c | 8 hw/misc/macio/macio.c | 4 ++-- hw/misc/macio/pmu.c | 6 +++--- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/hw/misc/macio

[PATCH 71/71] docs: Constify VMstate in examples

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- docs/devel/clocks.rst| 2 +- docs/devel/migration.rst | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/devel/clocks.rst b/docs/devel/clocks.rst index 675fbeb6ab..c4d14bde04 100644 --- a/docs/devel/clocks.rst +++ b/docs/deve

[PATCH 23/71] hw/audio: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/audio/ac97.c| 4 ++-- hw/audio/asc.c | 4 ++-- hw/audio/cs4231.c | 2 +- hw/audio/cs4231a.c | 2 +- hw/audio/es1370.c | 4 ++-- hw/audio/gus.c | 2 +- hw/audio/hda-codec.c | 8 hw/

[PATCH 24/71] hw/block: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/block/ecc.c| 2 +- hw/block/fdc-isa.c| 2 +- hw/block/fdc-sysbus.c | 2 +- hw/block/fdc.c| 20 ++-- hw/block/m25p80.c | 12 ++-- hw/block/nand.c | 2 +- hw/block/onenand.c

[PATCH 31/71] hw/i386: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/i386/acpi-build.c | 2 +- hw/i386/intel_iommu.c | 2 +- hw/i386/kvm/clock.c| 6 +++--- hw/i386/kvm/xen_evtchn.c | 4 ++-- hw/i386/kvm/xen_gnttab.c | 2 +- hw/i386/kvm/xen_overlay.c | 2 +- hw/i386/kvm/xen_xenstore.c | 2 +- hw/i386/k

[PATCH 44/71] hw/pci: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- include/hw/pci/shpc.h | 2 +- hw/pci/msix.c | 4 ++-- hw/pci/pci.c | 8 hw/pci/pci_host.c | 2 +- hw/pci/pcie_aer.c | 4 ++-- hw/pci/shpc.c | 2 +- 6 files changed, 11 insertions(+), 11 deletions(-) diff --git a/inclu

[PATCH 68/71] replay: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- replay/replay-snapshot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/replay/replay-snapshot.c b/replay/replay-snapshot.c index 10a7cf7992..e5e39161e3 100644 --- a/replay/replay-snapshot.c +++ b/replay/replay-snapshot.c @@ -51,7 +51,7 @@

[PATCH 55/71] hw/ssi: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/ssi/aspeed_smc.c | 2 +- hw/ssi/ibex_spi_host.c| 2 +- hw/ssi/imx_spi.c | 2 +- hw/ssi/mss-spi.c | 2 +- hw/ssi/npcm7xx_fiu.c | 2 +- hw/ssi/npcm_pspi.c| 2 +- hw/ssi/pl022.c| 2 +- hw/ssi/ssi.c

[PATCH 32/71] hw/ide: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/ide/ahci-allwinner.c | 2 +- hw/ide/ahci.c | 8 hw/ide/core.c | 16 hw/ide/ich.c| 2 +- hw/ide/isa.c| 2 +- hw/ide/macio.c | 2 +- hw/ide/microdrive.c | 2 +- hw/ide/mm

[PATCH 15/71] target/riscv: Constify VMState in machine.c

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/riscv/machine.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/target/riscv/machine.c b/target/riscv/machine.c index c7c862cdd3..7d857f479b 100644 --- a/target/riscv/machine.c +++ b/target/riscv/machin

[PATCH 53/71] hw/sensor: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/sensor/adm1272.c| 2 +- hw/sensor/dps310.c | 2 +- hw/sensor/emc141x.c| 2 +- hw/sensor/lsm303dlhc_mag.c | 2 +- hw/sensor/max31785.c | 2 +- hw/sensor/max34451.c | 2 +- hw/sensor/tmp105.c | 6 +++--- hw/sensor/t

[PATCH 42/71] hw/nvram: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/nvram/ds1225y.c| 2 +- hw/nvram/eeprom93xx.c | 2 +- hw/nvram/fw_cfg.c | 8 hw/nvram/mac_nvram.c | 2 +- hw/nvram/npcm7xx_otp.c| 2 +- hw/nvram/nrf51_nvm.c | 2 +- hw

[PATCH 34/71] hw/intc: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/intc/allwinner-a10-pic.c| 2 +- hw/intc/apic_common.c | 6 +++--- hw/intc/arm_gic_common.c | 8 hw/intc/arm_gicv3_common.c | 16 hw/intc/arm_gicv3_its_common.c | 2 +- hw/intc/armv7m_nvic.c | 8

[PATCH 66/71] migration: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- migration/global_state.c | 2 +- migration/savevm.c | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/migration/global_state.c b/migration/global_state.c index 4e2a9d8ec0..8ee15dbb06 100644 --- a/migration/global_state.c ++

[PATCH 63/71] audio: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- audio/audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/audio/audio.c b/audio/audio.c index f91e05b72c..efb6cc0a01 100644 --- a/audio/audio.c +++ b/audio/audio.c @@ -1683,7 +1683,7 @@ static const VMStateDescription vmstate_audio = {

[PATCH 45/71] hw/pci-bridge: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/pci-bridge/gen_pcie_root_port.c | 2 +- hw/pci-bridge/i82801b11.c | 2 +- hw/pci-bridge/ioh3420.c| 2 +- hw/pci-bridge/pci_bridge_dev.c | 2 +- hw/pci-bridge/pcie_pci_bridge.c| 2 +- hw/pci-bridge/xio3130_downstream.c | 2 +- hw

[PATCH 60/71] hw/virtio: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/virtio/vdpa-dev.c | 2 +- hw/virtio/vhost-vsock.c| 2 +- hw/virtio/virtio-balloon.c | 10 +- hw/virtio/virtio-crypto.c | 2 +- hw/virtio/virtio-iommu.c | 12 ++-- hw/virtio/virtio-mem.c | 8 hw/virtio/virtio-mmi

[PATCH 06/71] target/cris: Constify VMState in machine.c

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/cris/machine.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/cris/machine.c b/target/cris/machine.c index f370f33486..7b9bde872a 100644 --- a/target/cris/machine.c +++ b/target/cris/machine.c @@ -26,7 +26,7 @@ static c

[PATCH 41/71] hw/net: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/net/allwinner-sun8i-emac.c | 2 +- hw/net/allwinner_emac.c| 4 ++-- hw/net/cadence_gem.c | 2 +- hw/net/can/can_kvaser_pci.c| 2 +- hw/net/can/can_mioe3680_pci.c | 2 +- hw/net/can/can_pcm3680_pci.c | 2 +- hw/net/can/can_sja

[PATCH 47/71] hw/ppc: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/ppc/ppc.c| 2 +- hw/ppc/ppc4xx_pci.c | 6 +++--- hw/ppc/prep_systemio.c | 2 +- hw/ppc/rs6000_mc.c | 2 +- hw/ppc/spapr.c | 20 ++-- hw/ppc/spapr_caps.c | 2 +- hw/ppc/spapr_cpu_core.c | 12 ++-

[PATCH 40/71] hw/misc: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/misc/a9scu.c| 2 +- hw/misc/allwinner-a10-ccm.c| 2 +- hw/misc/allwinner-a10-dramc.c | 2 +- hw/misc/allwinner-cpucfg.c | 2 +- hw/misc/allwinner-h3-ccu.c | 2 +- hw/misc/allwinner-h3-dramc.c | 2

[PATCH 43/71] hw/openrisc: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/openrisc/cputimer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/openrisc/cputimer.c b/hw/openrisc/cputimer.c index 10163b391b..835986c4db 100644 --- a/hw/openrisc/cputimer.c +++ b/hw/openrisc/cputimer.c @@ -145,7 +145,7 @@ static

[PATCH 59/71] hw/vfio: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/vfio/display.c | 2 +- hw/vfio/pci.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/vfio/display.c b/hw/vfio/display.c index 7a10fa8604..1aa440c663 100644 --- a/hw/vfio/display.c +++ b/hw/vfio/display.c @@ -560,7 +560,7 @@

[PATCH 70/71] tests/unit/test-vmstate: Constify VMState

2023-11-05 Thread Richard Henderson
While const data in tests is not particularly important, this makes a grep test clear across the tree. Signed-off-by: Richard Henderson --- tests/unit/test-vmstate.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/tests/unit/test-vmstate

[PATCH 09/71] target/loongarch: Constify VMState in machine.c

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/loongarch/machine.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/target/loongarch/machine.c b/target/loongarch/machine.c index 1c4e01d076..c7029fb9b4 100644 --- a/target/loongarch/machine.c +++ b/target/loongarc

[PATCH 58/71] hw/usb: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/usb/bus.c| 2 +- hw/usb/ccid-card-passthru.c | 2 +- hw/usb/dev-hid.c| 4 ++-- hw/usb/dev-hub.c| 8 hw/usb/dev-mtp.c| 2 +- hw/usb/dev-smartcard-reader

[PATCH 56/71] hw/timer: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/timer/a9gtimer.c| 8 hw/timer/allwinner-a10-pit.c | 2 +- hw/timer/arm_mptimer.c | 4 ++-- hw/timer/arm_timer.c | 4 ++-- hw/timer/armv7m_systick.c | 2 +- hw/timer/aspeed_timer.c| 4 ++-- hw/timer

[PATCH 51/71] hw/scsi: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/scsi/esp-pci.c | 2 +- hw/scsi/esp.c | 8 hw/scsi/lsi53c895a.c | 2 +- hw/scsi/megasas.c | 4 ++-- hw/scsi/mptsas.c | 2 +- hw/scsi/scsi-bus.c| 6 +++--- hw/scsi/scsi-disk.c | 2 +- hw/scsi/sp

[PATCH 28/71] hw/gpio: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/gpio/aspeed_gpio.c | 4 ++-- hw/gpio/bcm2835_gpio.c | 2 +- hw/gpio/gpio_key.c | 2 +- hw/gpio/imx_gpio.c | 2 +- hw/gpio/max7310.c | 2 +- hw/gpio/mpc8xxx.c | 2 +- hw/gpio/npcm7xx_gpio.c | 2 +- hw/gpio/nrf51_gpio.c | 2 +- hw/gpio/pl

[PATCH 61/71] hw/watchdog: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/watchdog/allwinner-wdt.c | 2 +- hw/watchdog/cmsdk-apb-watchdog.c | 2 +- hw/watchdog/sbsa_gwdt.c | 2 +- hw/watchdog/spapr_watchdog.c | 2 +- hw/watchdog/wdt_aspeed.c | 2 +- hw/watchdog/wdt_diag288.c| 2 +- hw/watchdog/wd

[PATCH 67/71] system: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- system/cpu-timers.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/system/cpu-timers.c b/system/cpu-timers.c index 7452d97b67..bdf3a41dcb 100644 --- a/system/cpu-timers.c +++ b/system/cpu-timers.c @@ -165,7 +165,7 @@ static

[PATCH 04/71] target/alpha: Constify VMState in machine.c

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/alpha/machine.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/alpha/machine.c b/target/alpha/machine.c index 2b7c8148ff..f09834f635 100644 --- a/target/alpha/machine.c +++ b/target/alpha/machine.c @@ -24,7 +24,7 @@ stati

[PATCH 02/71] target/arm: Constify VMState in machine.c

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/machine.c | 54 ++-- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/target/arm/machine.c b/target/arm/machine.c index 9e20b41189..542be14bec 100644 --- a/target/arm/machine.c +++ b/target/arm/

[PATCH 65/71] cpu-target: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- cpu-target.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/cpu-target.c b/cpu-target.c index 79363ae370..c16b8942d6 100644 --- a/cpu-target.c +++ b/cpu-target.c @@ -88,7 +88,7 @@ static const VMStateDescription vmstate_cpu_common

[PATCH 46/71] hw/pci-host: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/pci-host/astro.c | 4 ++-- hw/pci-host/bonito.c | 2 +- hw/pci-host/designware.c | 10 +- hw/pci-host/dino.c | 2 +- hw/pci-host/gpex.c | 2 +- hw/pci-host/gt64120.c| 2 +- hw/pci-host/i440fx.c | 2 +- hw/pci-host/

[PATCH 57/71] hw/tpm: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/tpm/tpm_crb.c| 2 +- hw/tpm/tpm_spapr.c | 2 +- hw/tpm/tpm_tis_common.c | 2 +- hw/tpm/tpm_tis_i2c.c| 2 +- hw/tpm/tpm_tis_isa.c| 2 +- hw/tpm/tpm_tis_sysbus.c | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/tp

[PATCH 21/71] hw/acpi: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/acpi/cpu.c | 4 ++-- hw/acpi/erst.c | 2 +- hw/acpi/generic_event_device.c | 12 ++-- hw/acpi/ich9.c | 12 ++-- hw/acpi/ich9_tco.c | 2 +- hw/acpi/memory_hotplug.c | 4 ++

[PATCH 01/71] migration: Make VMStateDescription.subsections const

2023-11-05 Thread Richard Henderson
Allow the array of pointers to itself be const. Propagate this through the copies of this field. Signed-off-by: Richard Henderson --- include/migration/vmstate.h | 2 +- migration/savevm.c | 12 ++-- migration/vmstate.c | 15 +-- 3 files changed, 16 insertio

[PATCH 54/71] hw/sparc: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/sparc/sun4m_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/sparc/sun4m_iommu.c b/hw/sparc/sun4m_iommu.c index eb40f9377c..06703b1d96 100644 --- a/hw/sparc/sun4m_iommu.c +++ b/hw/sparc/sun4m_iommu.c @@ -331,7 +331,7 @@ static

[PATCH 69/71] util/fifo8: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- util/fifo8.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/fifo8.c b/util/fifo8.c index d4d1c135e0..de8fd0f1c5 100644 --- a/util/fifo8.c +++ b/util/fifo8.c @@ -109,7 +109,7 @@ const VMStateDescription vmstate_fifo8 = { .name = "

[PATCH 29/71] hw/hyperv: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/hyperv/vmbus.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/hyperv/vmbus.c b/hw/hyperv/vmbus.c index 271289f902..7183f4e367 100644 --- a/hw/hyperv/vmbus.c +++ b/hw/hyperv/vmbus.c @@ -526,7 +526,7 @@ static const VM

[PATCH 30/71] hw/i2c: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/i2c/allwinner-i2c.c | 2 +- hw/i2c/aspeed_i2c.c | 4 ++-- hw/i2c/core.c | 4 ++-- hw/i2c/exynos4210_i2c.c | 2 +- hw/i2c/imx_i2c.c| 2 +- hw/i2c/microbit_i2c.c | 2 +- hw/i2c/mpc_i2c.c| 2 +- hw/i2c/npcm7xx_smbus.c | 2 +-

[PATCH 38/71] hw/loongarch: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/loongarch/acpi-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/loongarch/acpi-build.c b/hw/loongarch/acpi-build.c index ae292fc543..730bc4a748 100644 --- a/hw/loongarch/acpi-build.c +++ b/hw/loongarch/acpi-build.c @@ -564,7 +5

[PATCH 50/71] hw/s390x: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/s390x/ccw-device.c | 2 +- hw/s390x/css.c| 36 ++-- hw/s390x/event-facility.c | 8 hw/s390x/ipl.c| 8 hw/s390x/sclpquiesce.c| 2 +- hw/s390x/virtio-ccw.c | 4 ++-- 6

[PATCH 25/71] hw/char: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/char/bcm2835_aux.c | 2 +- hw/char/cadence_uart.c | 2 +- hw/char/cmsdk-apb-uart.c| 2 +- hw/char/digic-uart.c| 2 +- hw/char/escc.c | 4 ++-- hw/char/exynos4210_uart.c | 4 ++-- hw/char/goldfish_tty.c | 2 +

[PATCH 64/71] backends: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- backends/dbus-vmstate.c | 2 +- backends/tpm/tpm_emulator.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/backends/dbus-vmstate.c b/backends/dbus-vmstate.c index a9d8cb0acd..be6c4d8e0a 100644 --- a/backends/dbus-vmstate.c +++ b/bac

[PATCH 12/71] target/mips: Constify VMState in machine.c

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/mips/sysemu/machine.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/target/mips/sysemu/machine.c b/target/mips/sysemu/machine.c index 80d37f9c2f..218f4c3a67 100644 --- a/target/mips/sysemu/machine.c +++

[PATCH 52/71] hw/sd: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/sd/allwinner-sdhost.c | 2 +- hw/sd/aspeed_sdhci.c | 2 +- hw/sd/bcm2835_sdhost.c | 2 +- hw/sd/cadence_sdhci.c| 2 +- hw/sd/npcm7xx_sdhci.c| 2 +- hw/sd/pl181.c| 2 +- hw/sd/pxa2xx_mmci.c | 2 +- hw/sd/sd.c | 6

[PATCH 39/71] hw/m68k: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/m68k/next-cube.c | 4 ++-- hw/m68k/q800-glue.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c index fabd861941..baca38bf39 100644 --- a/hw/m68k/next-cube.c +++ b/hw/m68k/next-cube.c @@ -996,7

[PATCH 33/71] hw/input: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/input/adb-kbd.c | 2 +- hw/input/adb-mouse.c | 2 +- hw/input/adb.c | 4 ++-- hw/input/ads7846.c | 2 +- hw/input/hid.c | 6 +++--- hw/input/lasips2.c | 4 ++-- hw/input/lm832x.c

[PATCH 20/71] hw/9pfs: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/9pfs/virtio-9p-device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c index 5f522e68e9..efa41cfd73 100644 --- a/hw/9pfs/virtio-9p-device.c +++ b/hw/9pfs/virtio-9p-device.c @@ -237

[PATCH 36/71] hw/ipmi: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/ipmi/ipmi_bmc_extern.c | 2 +- hw/ipmi/ipmi_bmc_sim.c| 2 +- hw/ipmi/ipmi_bt.c | 2 +- hw/ipmi/ipmi_kcs.c| 2 +- hw/ipmi/isa_ipmi_bt.c | 2 +- hw/ipmi/isa_ipmi_kcs.c| 2 +- hw/ipmi/pci_ipmi_bt.c | 2 +- hw/ipmi/pci_ipmi_kcs.c

[PATCH 03/71] targt/arm: Constify hvf/hvf.c

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/hvf/hvf.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index 757e13b0f9..203d88f80b 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -36,7 +36,7 @@ #def

[PATCH 17/71] target/sparc: Constify VMState in machine.c

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/machine.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/sparc/machine.c b/target/sparc/machine.c index 274e1217df..b1b1e16b13 100644 --- a/target/sparc/machine.c +++ b/target/sparc/machine.c @@ -10,7 +10,7 @@ s

[PATCH 26/71] hw/display: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/display/artist.c | 2 +- hw/display/bcm2835_fb.c | 2 +- hw/display/bochs-display.c| 2 +- hw/display/cg3.c | 2 +- hw/display/cirrus_vga.c | 4 ++-- hw/display/dpcd.c | 2 +- hw/display/exynos4210_fi

[PATCH 22/71] hw/adc: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/adc/aspeed_adc.c| 2 +- hw/adc/max111x.c | 2 +- hw/adc/npcm7xx_adc.c | 2 +- hw/adc/stm32f2xx_adc.c | 2 +- hw/adc/zynq-xadc.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/adc/aspeed_adc.c b/hw/adc/aspeed_adc.c

[PATCH 18/71] hw/arm: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/arm/armsse.c | 2 +- hw/arm/armv7m.c | 2 +- hw/arm/highbank.c| 2 +- hw/arm/integratorcp.c| 6 +++--- hw/arm/musicpal.c| 14 +++--- hw/arm/pxa2xx.c | 18 +- hw/arm/pxa2xx_gpio.c

[PATCH 08/71] target/i386: Constify VMState in machine.c

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/i386/machine.c | 128 +- 1 file changed, 64 insertions(+), 64 deletions(-) diff --git a/target/i386/machine.c b/target/i386/machine.c index a1041ef828..c3ae320814 100644 --- a/target/i386/machine.c +++ b/target/i

[PATCH 13/71] target/openrisc: Constify VMState in machine.c

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/openrisc/machine.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/openrisc/machine.c b/target/openrisc/machine.c index b7d7388640..3574e571cb 100644 --- a/target/openrisc/machine.c +++ b/target/openrisc/machine.c @@ -

[PATCH 27/71] hw/dma: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/dma/bcm2835_dma.c | 4 ++-- hw/dma/i82374.c | 2 +- hw/dma/i8257.c| 4 ++-- hw/dma/pl080.c| 4 ++-- hw/dma/pl330.c| 10 +- hw/dma/pxa2xx_dma.c | 4 ++-- hw/dma/rc4030.c | 2 +-

[PATCH 05/71] target/avr: Constify VMState in machine.c

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/avr/machine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/avr/machine.c b/target/avr/machine.c index 16f7a3e031..4402862fb9 100644 --- a/target/avr/machine.c +++ b/target/avr/machine.c @@ -100,7 +100,7 @@ const VMStateDesc

[PATCH 19/71] hw/core: Constify VMState

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/core/clock-vmstate.c | 6 +++--- hw/core/or-irq.c| 6 +++--- hw/core/ptimer.c| 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/core/clock-vmstate.c b/hw/core/clock-vmstate.c index 7eccb6d4ea..e831fc596f 100644 --- a/h

[PATCH 11/71] target/microblaze: Constify VMState in machine.c

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/microblaze/machine.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/microblaze/machine.c b/target/microblaze/machine.c index d24def3992..51705e4f5c 100644 --- a/target/microblaze/machine.c +++ b/target/microblaze/machin

[PATCH 16/71] target/s390x: Constify VMState in machine.c

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/s390x/machine.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/target/s390x/machine.c b/target/s390x/machine.c index 37a076858c..a125ebcc2f 100644 --- a/target/s390x/machine.c +++ b/target/s390x/ma

[PATCH 07/71] target/hppa: Constify VMState in machine.c

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/machine.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/hppa/machine.c b/target/hppa/machine.c index 905991d7f9..e4b358d038 100644 --- a/target/hppa/machine.c +++ b/target/hppa/machine.c @@ -122,7 +122,7 @@ static c

[PATCH 00/71] *: Constify VMState

2023-11-05 Thread Richard Henderson
Most of this can be done without the first patch. But with it, we get to constify subsections as well. For qemu-system-aarch64, this moves 472k from .data to .data.ro and/or .rodata (mostly depending on -fpie). For qemu-system-x86_64, 272k. For qemu-system-ppc64, 267k. r~ Richard Henderson (7

[PATCH 14/71] target/ppc: Constify VMState in machine.c

2023-11-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/ppc/machine.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/target/ppc/machine.c b/target/ppc/machine.c index 68cbdffecd..203fe28e01 100644 --- a/target/ppc/machine.c +++ b/target/ppc/machine.c @@

Re: [PATCH v3 1/1] hmp: synchronize cpu state for lapic info

2023-11-05 Thread Thomas Huth
On 02/11/2023 07.00, Markus Armbruster wrote: Dongli Zhang writes: Hi Juan, On 10/30/23 09:31, Juan Quintela wrote: Dongli Zhang wrote: While the default "info lapic" always synchronizes cpu state ... mon_get_cpu() -> mon_get_cpu_sync(mon, true) -> cpu_synchronize_state(cpu) ->

Error detecting linker while compiling qemu-system-ppc on macOS

2023-11-05 Thread Howard Spoelstra
Hi all, I'm getting a error while compiling on macOS (Intel). It seems linker detection is passed an unknown argument "--version", whereas "-v" works OK? See log below. Thanks for looking into this, Howard Build started at 2023-11-06T07:29:19.181487 Main binary: /Users/hsp/src/qemu-ppc/build/pyv

  1   2   >