On Fri, 22 Sept, 2023, 10:25 pm Philippe Mathieu-Daudé,
wrote:
> On 22/9/23 18:04, Ani Sinha wrote:
> > 32-bit x86 systems do not have a reserved memory for hole64. On those
> 32-bit
> > systems without PSE36 or PAE CPU features, hotplugging memory devices
> are not
> > supported by QEMU as QEMU
Cédric Le Goater writes:
> Remove superfluous local 'irq' variables and use the one define at the
> top of the routine. This fixes warnings in aspeed_soc_ast2600_realize()
> such as :
>
> ../hw/arm/aspeed_ast2600.c: In function ‘aspeed_soc_ast2600_realize’:
> ../hw/arm/aspeed_ast2600.c:420:18
Am 21.09.23 um 14:10 schrieb Paolo Bonzini:
> bios.bin is now used only by ISA PC, so PCI drivers are not necessary.
>
> Signed-off-by: Paolo Bonzini
> ---
> pc-bios/bios.bin | Bin 131072 -> 131072 bytes
> roms/config.seabios-128k | 30 ++
> 2 files changed,
[Trimming Cc list]
22.09.2023 13:45, Anton Johansson:
On 21/09/23, Michael Tokarev wrote:
Anton Johansson (9):
accel/kvm: Widen pc/saved_insn for kvm_sw_breakpoint
accel/hvf: Widen pc/saved_insn for hvf_sw_breakpoint
target: Use vaddr for kvm_arch_[insert|remove]_hw_breakpoint
Code changes that addresses all compiler complaints coming from enabling
-Wshadow flags. Enabling -Wshadow catches cases of local variables shadowing
other local variables or parameters. These makes the code confusing and/or adds
bugs that are difficult to catch.
CC: Markus Armbruster
CC: Philipp
Niagara uses which presently limits its compatibility to
linux hosts. Change build to only build it on linux.
Add Kconfig file for skhynix directory, and make niagara depend on
CXL_MEM_DEVICE and LINUX. Add an explicit flag for niagara.
Signed-off-by: Gregory Price
---
hw/cxl/Kconfig
On Fri, 22 Sep 2023, Paolo Bonzini wrote:
On Fri, Sep 22, 2023 at 2:17 PM BALATON Zoltan wrote:
mc->default_cpu_type = POWERPC_CPU_TYPE_NAME("460exb");
mc->default_ram_size = 512 * MiB;
mc->default_ram_id = "ppc4xx.sdram";
+
+machine_add_audiodev_property(mc);
This hunk has no
On Fri, Sep 22, 2023 at 01:06:53PM -0300, Fabiano Rosas wrote:
> Elena Ufimtseva writes:
>
> > In multifd_send_sync_main we need to wait for channels_ready
> > before submitting sync packet as the threads may still be sending
> > their previous pages.
> > There is also no need to check for channe
On Fri, Sep 22, 2023 at 11:53:17AM -0300, Fabiano Rosas wrote:
> Commit d2026ee117 ("multifd: Fix the number of channels ready") moved
> the "post" of channels_ready to the start of the multifd_send_thread()
> loop and added a missing "wait" at multifd_send_sync_main(). While it
> does work, the pl
No. This patch does not address that issue and is not related. I was able
to reproduce it about 2/1000 iterations with and without this patch. I
will look into that issue separately.
-Chris
On Fri, Sep 22, 2023 at 11:24 AM Hao Wu wrote:
> Is this related to this error?
>
> https://lists.gnu
On Fri, Sep 22, 2023 at 12:04:10PM -0400, Peter Xu wrote:
> This patch fixes the warning of shadowed local variable:
>
> ../hw/i386/intel_iommu.c: In function ‘vtd_address_space_unmap’:
> ../hw/i386/intel_iommu.c:3773:18: warning: declaration of ‘size’ shadows a
> previous local [-Wshadow=compati
On 9/22/23 13:08, Michael Tokarev wrote:
> 04.09.2023 16:28, Jonathan Cameron:
>> From: Dave Jiang
>>
>> According to ACPI spec 6.5 5.2.28.4 System Locality Latency and Bandwidth
>> Information Structure, if the "Entry Base Unit" is 1024 for BW and the
>> matrix entry has the value of 100, the
On Mon, 18 Sep 2023 05:45:03 -0400
Jing Liu wrote:
> Changes since v1:
> - v1: https://www.mail-archive.com/qemu-devel@nongnu.org/msg982842.html
> - Revise Qemu to QEMU. (Cédric)
> - Add g_free when failure of getting MSI-X irq info. (Cédric)
> - Apply Cédric's Reviewed-by. (Cédric)
> - Use g_aut
Address all compiler complaints from -Wshadow in qemu-nbd. Several
instances of 'int ret' became shadows when commit 4fbec260 added 'ret'
at a higher scope in main. More interesting was the 'void *ret'
capturing the result of a pthread; where we were conceptually doing
'(void*)(intptr_t)EXIT_FAIL
On Mon, 18 Sep 2023 05:45:05 -0400
Jing Liu wrote:
> The vector_use callback is used to enable vector that is unmasked in
> guest. The kernel used to only support static MSI-X allocation. When
> allocating a new interrupt using "static MSI-X allocation" kernels,
> QEMU first disables all previous
20.09.2023 12:23, Alex Bennée:
..
I wonder if I should keep 0d58c6606 for 8.1.1 (the deadline is
tomorrow)..
Unfortunately 0d58c is not the full fix, it papered over one crack but
revealed others. It might be leading to a false sense of security. So I
would argue:
- keep the assert - better
04.09.2023 16:28, Jonathan Cameron:
From: Dave Jiang
According to ACPI spec 6.5 5.2.28.4 System Locality Latency and Bandwidth
Information Structure, if the "Entry Base Unit" is 1024 for BW and the
matrix entry has the value of 100, the BW is 100 GB/s. So the
entry_base_unit should be changed f
On 9/14/2023 2:21 AM, Zhao Liu wrote:
From: Zhao Liu
CPUID[0x801D].EAX[bits 25:14] NumSharingCache: number of logical
processors sharing cache.
The number of logical processors sharing this cache is
NumSharingCache + 1.
After cache models have topology information, we can use
CPUCacheIn
On 9/14/2023 2:21 AM, Zhao Liu wrote:
From: Zhao Liu
The commit 8f4202fb1080 ("i386: Populate AMD Processor Cache Information
for cpuid 0x801D") adds the cache topology for AMD CPU by encoding
the number of sharing threads directly.
From AMD's APM, NumSharingCache (CPUID[0x801D].EAX
On 9/22/23 20:20, Philippe Mathieu-Daudé wrote:
On 22/9/23 17:59, Cédric Le Goater wrote:
Hello,
Here are cleanups for local variable shadowing warnings in aspeed models.
Joel, Andrew,
Could you please double check patch 4 ?
Could Markus' MAKE_IDENTFIER() help there?
ah ! you typed too fa
On Fri, Sep 22, 2023 at 11:49 AM Peter Maydell
wrote:
> On Fri, 22 Sept 2023 at 18:43, Daniel Henrique Barboza
> wrote:
> > Can you publish your branch with the current -Wshadow=local patches in
> > gitlab/github? I'm hitting (and fixing) a lot of errors that aren't
> listed
> > here, meaning th
Elena Ufimtseva writes:
> Sometimes multifd sends just sync packet with no pages
> (normal_num is 0). In this case the old value is being
> preserved and being accounted for while only packet_len
> is being transferred.
> Reset it to 0 after sending and accounting for.
>
Usually you'd finish you
On 22/9/23 17:59, Cédric Le Goater wrote:
commit 8137355e850f ("aspeed/timer: Fix behaviour running Linux")
introduced a MAX() expression to calculate the next timer deadline :
return calculate_time(t, MAX(MAX(t->match[0], t->match[1]), 0));
The second MAX() is not necessary since the comp
Elena Ufimtseva writes:
> Sometimes multifd sends just sync packet with no pages
> (normal_num is 0). In this case the old value is being
> preserved and being accounted for while only packet_len
> is being transferred.
> Reset it to 0 after sending and accounting for.
>
> TODO: Fix the same pack
Is this related to this error?
https://lists.gnu.org/archive/html/qemu-devel/2023-09/msg04903.html
On Fri, Sep 22, 2023 at 11:14 AM Chris Rauer wrote:
> The counter register is only 24-bits and counts down. If the timer is
> running but the qtimer to reset it hasn't fired off yet, there is a c
On 22/9/23 17:59, Cédric Le Goater wrote:
Remove superfluous local 'irq' variables and use the one define at the
top of the routine. This fixes warnings in aspeed_soc_ast2600_realize()
such as :
../hw/arm/aspeed_ast2600.c: In function ‘aspeed_soc_ast2600_realize’:
../hw/arm/aspeed_ast2600.
On 22/9/23 17:59, Cédric Le Goater wrote:
Remove superfluous local 'data' variable and use the one define at the
top of the routine. This fixes :
../hw/i2c/aspeed_i2c.c: In function ‘aspeed_i2c_bus_recv’:
../hw/i2c/aspeed_i2c.c:315:17: warning: declaration of ‘data’ shadows a
previous loc
On 22/9/23 17:59, Cédric Le Goater wrote:
Hello,
Here are cleanups for local variable shadowing warnings in aspeed models.
Joel, Andrew,
Could you please double check patch 4 ?
Could Markus' MAKE_IDENTFIER() help there?
Thanks,
C.
Cédric Le Goater (4):
aspeed/i2c: Clean up local vari
On 22/9/23 18:06, Daniel P. Berrangé wrote:
Both instances of 'ret' are used to store a gnutls API return code.
Signed-off-by: Daniel P. Berrangé
---
crypto/tls-cipher-suites.c | 1 -
1 file changed, 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé
On 22/9/23 18:04, Peter Xu wrote:
This patch fixes the warning of shadowed local variable:
../hw/i386/intel_iommu.c: In function ‘vtd_address_space_unmap’:
../hw/i386/intel_iommu.c:3773:18: warning: declaration of ‘size’ shadows a
previous local [-Wshadow=compatible-local]
3773 | uint
On 22/9/23 18:37, Thomas Huth wrote:
When compiling this file with -Wshadow=local , we get:
../tests/qtest/m48t59-test.c: In function ‘bcd_check_time’:
../tests/qtest/m48t59-test.c:195:17: warning: declaration of ‘s’
shadows a previous local [-Wshadow=local]
195 | long t, s;
The counter register is only 24-bits and counts down. If the timer is
running but the qtimer to reset it hasn't fired off yet, there is a chance
the regster read can return an invalid result.
Signed-off-by: Chris Rauer
---
hw/timer/npcm7xx_timer.c | 3 +++
1 file changed, 3 insertions(+)
diff
Elena Ufimtseva writes:
> Previous commit cbec7eb76879d419e7dbf531ee2506ec0722e825
> "migration/multifd: Compute transferred bytes correctly"
> removed accounting for packet_len in non-rdma
> case, but the next_packet_size only accounts for pages, not for
> the header packet (normal_pages * PAGE_
On Fri, 22 Sept 2023 at 18:43, Daniel Henrique Barboza
wrote:
> Can you publish your branch with the current -Wshadow=local patches in
> gitlab/github? I'm hitting (and fixing) a lot of errors that aren't listed
> here, meaning they're either fixed already in your local branch or needs to
> be fix
On Fri, Sep 22, 2023 at 06:37:42PM +0200, Thomas Huth wrote:
> When compiling this file with -Wshadow=local , we get:
>
> ../tests/qtest/m48t59-test.c: In function ‘bcd_check_time’:
> ../tests/qtest/m48t59-test.c:195:17: warning: declaration of ‘s’
> shadows a previous local [-Wshadow=local]
>
Elena Ufimtseva writes:
> In migration rate limiting atomic operations are used
> to read the rate limit variables and transferred bytes and
> they are expensive. Check first if rate_limit_max is equal
> to RATE_LIMIT_DISABLED and return false immediately if so.
>
> Signed-off-by: Elena Ufimtseva
> On 22-Sep-2023, at 3:07 PM, Markus Armbruster wrote:
>
> X86 Machines
>
> PC
> M: Michael S. Tsirkin
> M: Marcel Apfelbaum
>hw/i386/acpi-build.c(*3*)
>hw/i386/acpi-microvm.c(*2*)
>hw/i386/intel_iommu.c(*3*)
>hw/i386/pc.c(*2*)
>hw/i386/x86.c(*2*)
Since I al
On 22/9/23 18:04, Ani Sinha wrote:
32-bit x86 systems do not have a reserved memory for hole64. On those 32-bit
systems without PSE36 or PAE CPU features, hotplugging memory devices are not
supported by QEMU as QEMU always places hotplugged memory above 4 GiB boundary
which is beyond the physical
On 07/09/2023 21.57, Michael Tokarev wrote:
24.08.2023 12:42, Thomas Huth wrote:
Commit 0db0fbb5cf ("Add conditional dependency for libkeyutils")
tried to provide a possibility for the user to disable keyutils
if not required by makeing it depend on the keyring feature. This
looked reasonable at
On 31/07/2023 11.10, Akihiko Odaki wrote:
A build of GCC 13.2 will have stack protector enabled by default if it
was configured with --enable-default-ssp option. For such a compiler,
it is necessary to explicitly disable stack protector when linking
without standard libraries.
Signed-off-by: Aki
When compiling this file with -Wshadow=local , we get:
../tests/qtest/m48t59-test.c: In function ‘bcd_check_time’:
../tests/qtest/m48t59-test.c:195:17: warning: declaration of ‘s’
shadows a previous local [-Wshadow=local]
195 | long t, s;
| ^
../tests/qtest/m48t59-
On 9/22/23 16:30, Yazen Ghannam wrote:
On 9/22/23 4:36 AM, William Roche wrote:
On 9/21/23 19:41, Yazen Ghannam wrote:
[...]
Also, during page migration, does the data flow through the CPU core?
Sorry for the basic question. I haven't done a lot with virtualization.
Yes, in most cases (with t
On 22.09.23 16:21, Michal Orzel wrote:
Hello Michal
> On an attempt to access CNTPCT_EL0 from EL0 using a guest running on top
> of Xen, a trap from EL2 was observed which is something not reproducible
> on HW (also, Xen does not trap accesses to physical counter).
>
> This is because gt_coun
On Fri, Sep 22, 2023 at 12:59:37PM -0300, Fabiano Rosas wrote:
> Peter Xu writes:
>
> > On Wed, Sep 20, 2023 at 05:04:11PM +0800, Li Zhijian wrote:
> >> From: Li Zhijian
> >>
> >> Destination will fail with:
> >> qemu-system-x86_64: rdma: Too many requests in this message
> >> (3638950032).Bai
Tested the series on AMD system. Created a VM and ran some basic commands.
Everything looks good.
Tested-by: Babu Moger
On 9/14/2023 2:21 AM, Zhao Liu wrote:
From: Zhao Liu
Hi list,
(CC k...@vger.kernel.org for better browsing.)
This is the our v4 patch series, rebased on the master bran
Elena Ufimtseva writes:
> In multifd_send_sync_main we need to wait for channels_ready
> before submitting sync packet as the threads may still be sending
> their previous pages.
> There is also no need to check for channels_ready in the loop
> before the wait for sem_sync, next iteration of send
This is confusing as one 'action' variable is used for storing
a SCMP_ enum value, while the other 'action' variable is used
for storing a SECCOMP_ enum value.
Signed-off-by: Daniel P. Berrangé
---
softmmu/qemu-seccomp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sof
Both instances of 'ret' are used to store a gnutls API return code.
Signed-off-by: Daniel P. Berrangé
---
crypto/tls-cipher-suites.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/crypto/tls-cipher-suites.c b/crypto/tls-cipher-suites.c
index 5e4f597464..d0df4badc0 100644
--- a/crypto/tls-cip
Daniel P. Berrangé (2):
crypto: remove shadowed 'ret' variable
seccomp: avoid shadowing of 'action' variable
crypto/tls-cipher-suites.c | 1 -
softmmu/qemu-seccomp.c | 4 ++--
2 files changed, 2 insertions(+), 3 deletions(-)
--
2.41.0
On 9/14/2023 2:21 AM, Zhao Liu wrote:
From: Zhao Liu
For function comments in this file, keep the comment style consistent
with other files in the directory.
Signed-off-by: Zhao Liu
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Yanan Wang
Reviewed-by: Xiaoyao Li
Acked-by: Michael S. T
On Fri, Sep 22, 2023 at 06:12:02PM +0530, Ani Sinha wrote:
> Code changes in acpi that addresses all compiler complaints coming from
> enabling
> -Wshadow flags. Enabling -Wshadow catches cases of local variables shadowing
> other local variables or parameters. These makes the code confusing and/o
32-bit x86 systems do not have a reserved memory for hole64. On those 32-bit
systems without PSE36 or PAE CPU features, hotplugging memory devices are not
supported by QEMU as QEMU always places hotplugged memory above 4 GiB boundary
which is beyond the physical address space of the processor. Linu
Peter Xu writes:
> On Wed, Sep 20, 2023 at 05:04:11PM +0800, Li Zhijian wrote:
>> From: Li Zhijian
>>
>> Destination will fail with:
>> qemu-system-x86_64: rdma: Too many requests in this message
>> (3638950032).Bailing.
>>
>> migrate with RDMA is different from tcp. RDMA has its own control
This patch fixes the warning of shadowed local variable:
../hw/i386/intel_iommu.c: In function ‘vtd_address_space_unmap’:
../hw/i386/intel_iommu.c:3773:18: warning: declaration of ‘size’ shadows a
previous local [-Wshadow=compatible-local]
3773 | uint64_t size = mask + 1;
|
to fix warning :
../hw/i3c/aspeed_i3c.c: In function ‘aspeed_i3c_realize’:
../hw/i3c/aspeed_i3c.c:1959:17: warning: declaration of ‘dev’ shadows a
parameter [-Wshadow=local]
1959 | Object *dev = OBJECT(&s->devices[i]);
| ^~~
../hw/i3c/aspeed_i3c.c:1942:45:
Remove superfluous local 'data' variable and use the one define at the
top of the routine. This fixes :
../hw/i2c/aspeed_i2c.c: In function ‘aspeed_i2c_bus_recv’:
../hw/i2c/aspeed_i2c.c:315:17: warning: declaration of ‘data’ shadows a
previous local [-Wshadow=compatible-local]
315 |
Hello,
Here are cleanups for local variable shadowing warnings in aspeed models.
Joel, Andrew,
Could you please double check patch 4 ?
Thanks,
C.
Cédric Le Goater (4):
aspeed/i2c: Clean up local variable shadowing
aspeed: Clean up local variable shadowing
aspeed/i3c: Rename variable s
Remove superfluous local 'irq' variables and use the one define at the
top of the routine. This fixes warnings in aspeed_soc_ast2600_realize()
such as :
../hw/arm/aspeed_ast2600.c: In function ‘aspeed_soc_ast2600_realize’:
../hw/arm/aspeed_ast2600.c:420:18: warning: declaration of ‘irq’ shadow
commit 8137355e850f ("aspeed/timer: Fix behaviour running Linux")
introduced a MAX() expression to calculate the next timer deadline :
return calculate_time(t, MAX(MAX(t->match[0], t->match[1]), 0));
The second MAX() is not necessary since the compared values are an
unsigned and 0. Simply rem
On Wed, Sep 20, 2023 at 05:04:12PM +0800, Li Zhijian wrote:
> From: Li Zhijian
>
> Previously, we got a confusion error that complains
> the RDMAControlHeader.repeat:
> qemu-system-x86_64: rdma: Too many requests in this message
> (3638950032).Bailing.
>
> Actually, it's caused by an unexpected
From: Martin Kletzander
No return values are used anywhere, so switch the functions to be void
and add support for error reporting using errp for use in next patches.
Signed-off-by: Martin Kletzander
Reviewed-by: Daniel P. Berrangé
Message-ID:
Signed-off-by: Paolo Bonzini
---
hw/audio/hda-
From: Martin Kletzander
This deduplicates several lines and will make future changes more
concise.
Signed-off-by: Martin Kletzander
Reviewed-by: Daniel P. Berrangé
Message-ID:
<1d75877cf4cc2a38f87633ff16f9fea3e1bb0c03.1650874791.git.mklet...@redhat.com>
Signed-off-by: Paolo Bonzini
---
hw/i
From: Martin Kletzander
This will be used in future commit.
Signed-off-by: Martin Kletzander
Reviewed-by: Daniel P. Berrangé
Message-ID:
Signed-off-by: Paolo Bonzini
---
hw/audio/lm4549.c | 3 ++-
hw/audio/lm4549.h | 3 ++-
hw/audio/pl041.c | 2 +-
3 files changed, 5 insertions(+), 3 dele
This is necessary for the q35 configuration tests to pass,
once audiodev becomes mandatory.
Signed-off-by: Paolo Bonzini
---
docs/config/q35-emulated.cfg | 4
docs/config/q35-virtio-graphical.cfg | 4
softmmu/vl.c | 10 ++
3 files changed, 18 i
From: Martin Kletzander
This will enable removing deprecated default audiodev support.
I did not figure out how to make the audiodev represented as an
interface node, so this is a workaround. I am not sure what would be
the proper way.
Signed-off-by: Martin Kletzander
Reviewed-by: Daniel P. B
From: Martin Kletzander
There was no way to set this and we need that for it to be able to properly
initialise.
Signed-off-by: Martin Kletzander
Message-ID:
<16963256573fcbfa7720aa2fd000ba74a4055222.1650874791.git.mklet...@redhat.com>
Signed-off-by: Paolo Bonzini
---
hw/display/xlnx_dp.c | 6
From: LIU Zhiwei
Signed-off-by: LIU Zhiwei
Message-ID: <20230911063223.742-1-zhiwei_...@linux.alibaba.com>
Signed-off-by: Paolo Bonzini
---
include/qemu/timer.h | 22 ++
1 file changed, 22 insertions(+)
diff --git a/include/qemu/timer.h b/include/qemu/timer.h
index 9a91cb1
On parts that enumerate IA32_VMX_BASIC MSR bit as 1, any exception vector
can be delivered with or without an error code if the other consistency
checks are satisfied.
Signed-off-by: Paolo Bonzini
---
scripts/kvm/vmxcap | 1 +
target/i386/cpu.c | 1 +
target/i386/cpu.h | 1 +
3 files changed,
From: Pawan Gupta
Gather Data Sampling (GDS) is a side-channel attack using Gather
instructions. Some Intel processors will set ARCH_CAP_GDS_NO bit in
MSR IA32_ARCH_CAPABILITIES to report that they are not vulnerable to
GDS.
Make this bit available to guests.
Closes:
https://lore.kernel.org/qe
The following changes since commit 005ad32358f12fe9313a4a01918a55e60d4f39e5:
Merge tag 'pull-tpm-2023-09-12-3' of https://github.com/stefanberger/qemu-tpm
into staging (2023-09-13 13:41:57 -0400)
are available in the Git repository at:
https://gitlab.com/bonzini/qemu.git tags/for-upstream
On Wed, Sep 20, 2023 at 05:04:11PM +0800, Li Zhijian wrote:
> From: Li Zhijian
>
> Destination will fail with:
> qemu-system-x86_64: rdma: Too many requests in this message
> (3638950032).Bailing.
>
> migrate with RDMA is different from tcp. RDMA has its own control
> message, and all traffic b
On 22/9/23 17:29, Peter Maydell wrote:
Avoid shadowing a local variable in arm_sysctl_write():
../../hw/misc/arm_sysctl.c: In function ‘arm_sysctl_write’:
../../hw/misc/arm_sysctl.c:537:26: warning: declaration of ‘val’ shadows a
parameter [-Wshadow=local]
537 | uint32_t val;
On 22/9/23 17:29, Peter Maydell wrote:
Avoid shadowing a variable in smmuv3_notify_iova():
../../hw/arm/smmuv3.c: In function ‘smmuv3_notify_iova’:
../../hw/arm/smmuv3.c:1043:23: warning: declaration of ‘event’ shadows a
previous local [-Wshadow=local]
1043 | SMMUEventInfo event = {.i
On 22/9/23 17:29, Peter Maydell wrote:
Avoid shadowing a local variable in do_process_its_cmd():
../../hw/intc/arm_gicv3_its.c:548:17: warning: declaration of ‘ite’ shadows a
previous local [-Wshadow=compatible-local]
548 | ITEntry ite = {};
| ^~~
../../hw/intc
22.09.2023 18:18, Michael Tokarev wrote:
This update contains a pile of fixes for various architectures/subsystems,
fixing a number of various bugs. Unfortunately some known bugs remain
unfixed still, and hopefully will be addressed in subsequent 8.1.x releases.
In particular, the following issu
On 22/9/23 17:01, Ani Sinha wrote:
32-bit x86 systems do not have a reserved memory for hole64. On those 32-bit
systems without PSE36 or PAE CPU features, hotplugging memory devices are not
supported by QEMU as QEMU always places hotplugged memory above 4 GiB boundary
which is beyond the physical
If printing a QAPI schema object for debugging we get the classname and
a hex value for the instance:
With this change we instead get the classname and the human friendly
name of the QAPI type instance:
Signed-off-by: Daniel P. Berrangé
---
v1 was two & half years ago:
ht
Avoid shadowing a variable in smmuv3_notify_iova():
../../hw/arm/smmuv3.c: In function ‘smmuv3_notify_iova’:
../../hw/arm/smmuv3.c:1043:23: warning: declaration of ‘event’ shadows a
previous local [-Wshadow=local]
1043 | SMMUEventInfo event = {.inval_ste_allowed = true};
|
Avoid shadowing a local variable in do_process_its_cmd():
../../hw/intc/arm_gicv3_its.c:548:17: warning: declaration of ‘ite’ shadows a
previous local [-Wshadow=compatible-local]
548 | ITEntry ite = {};
| ^~~
../../hw/intc/arm_gicv3_its.c:518:13: note: shadowed dec
The STE_CTXPTR() and STE_S2TTB() macros both extract two halves
of an address from fields in the STE and combine them into a
single value to return. The current code for this uses a GCC
statement expression. There are two problems with this:
(1) The type chosen for the variable in the statement ex
Avoid shadowing a local variable in arm_sysctl_write():
../../hw/misc/arm_sysctl.c: In function ‘arm_sysctl_write’:
../../hw/misc/arm_sysctl.c:537:26: warning: declaration of ‘val’ shadows a
parameter [-Wshadow=local]
537 | uint32_t val;
| ^~~
../.
These patches fix some -Wshadow warnings in arm related code.
-- PMM
Peter Maydell (4):
hw/intc/arm_gicv3_its: Avoid shadowing variable in
do_process_its_cmd()
hw/misc/arm_sysctl.c: Avoid shadowing local variable
hw/arm/smmuv3.c: Avoid shadowing variable
hw/arm/smmuv3-internal.h: Don'
On Wed, Sep 20, 2023 at 01:06:19AM -0700, Mattias Nissler wrote:
> When DMA memory can't be directly accessed, as is the case when
> running the device model in a separate process without shareable DMA
> file descriptors, bounce buffering is used.
>
> It is not uncommon for device models to reques
On Thu, Sep 21, 2023 at 08:27:24AM +, Zhijian Li (Fujitsu) wrote:
> I'm worried that I may not have enough time, ability, or environment to
> review/test
> the RDMA patches. but for this patch set, i will take a look later.
That'll be helpful, thanks!
So it seems maybe at least we should hav
Print a debug message as is done for other unsupported audio formats
to give the user the chance to understand their mistake.
Signed-off-by: Daniel P. Berrangé
---
audio/wavaudio.c | 4
1 file changed, 4 insertions(+)
diff --git a/audio/wavaudio.c b/audio/wavaudio.c
index 6445a2cb90..e70e5
Hi everyone,
The QEMU v8.1.1 stable release is now available.
You can grab the tarball from our download page here:
https://www.qemu.org/download/#source
v8.1.1 is now tagged in the official qemu.git repository, and the
stable-8.1 branch has been updated accordingly:
https://gitlab.com/qe
Hi everyone,
The QEMU v8.0.5 stable release is now available.
You can grab the tarball from our download page here:
https://www.qemu.org/download/#source
v8.0.5 is now tagged in the official qemu.git repository, and the
stable-8.0 branch has been updated accordingly:
https://gitlab.com/qe
Reviewed-by: Thomas Huth
Maybe this could go via qemu-trivial?
On 12/09/2023 16.08, Peter Maydell wrote:
Ping^2 for review/pickup by the rdma folks, please?
Is anybody still using this subsystem? ... if not, then it's maybe time to
set this on the deprecation list? ... just my 0.02 €.
Kevin Wolf writes:
> Until now, array properties are actually implemented with a hack that
> uses multiple properties on the QOM level: a static "foo-len" property
> and after it is set, dynamically created "foo[i]" properties.
>
> In external interfaces (-device on the command line and device_ad
32-bit x86 systems do not have a reserved memory for hole64. On those 32-bit
systems without PSE36 or PAE CPU features, hotplugging memory devices are not
supported by QEMU as QEMU always places hotplugged memory above 4 GiB boundary
which is beyond the physical address space of the processor. Linu
We currently have the sem_sync semaphore that is used:
1) on the sending side, to know when the multifd_send_thread has
finished sending the MULTIFD_FLAG_SYNC packet;
This is unnecessary. Multifd sends packets (not pages) one by one
and completion is already bound by both the channels_read
This helps document the intent of the loop via the function name and
we can reuse this in the future.
Signed-off-by: Fabiano Rosas
---
migration/multifd.c | 38 +-
1 file changed, 5 insertions(+), 33 deletions(-)
diff --git a/migration/multifd.c b/migration/m
I'm putting this RFC out early so we can discuss the issues around the
SYNC packet of the multifd protocol. There's a related series posted
by Elena Ufimtseva:
https://lore.kernel.org/r/20230922065625.21848-1-elena.ufimts...@oracle.com
My interest in this (aside from correctness) is that when doi
Commit d2026ee117 ("multifd: Fix the number of channels ready") moved
the "post" of channels_ready to the start of the multifd_send_thread()
loop and added a missing "wait" at multifd_send_sync_main(). While it
does work, the placement of the wait goes against what the rest of the
code does.
The s
Hi everyone,
The QEMU v7.2.6 stable release is now available.
You can grab the tarball from our download page here:
https://www.qemu.org/download/#source
v7.2.6 is now tagged in the official qemu.git repository, and the
stable-7.2 branch has been updated accordingly:
https://gitlab.com/qe
On Fri, Sep 22, 2023 at 04:36:00PM +0200, Thomas Huth wrote:
> On 22/09/2023 16.00, Peter Maydell wrote:
> > On Fri, 22 Sept 2023 at 14:56, Daniel P. Berrangé
> > wrote:
> > >
> > > This can be useful for setting some meson global options, such as the
> > > optimization level or debug state, whi
20.09.2023 18:04, Alex Bennée wrote:
..
Sorry my previous reply was eaten by my MUA.
That happens.. especially when MUA becomes hungry :)
The main purpose of the asserts is to catch corruption to the Memory
Regions early so we don't see weird failures later on (c.f. the 3
separate bugs for cr
On 22/09/2023 16.00, Peter Maydell wrote:
On Fri, 22 Sept 2023 at 14:56, Daniel P. Berrangé wrote:
This can be useful for setting some meson global options, such as the
optimization level or debug state, which don't have an analogous
option explicitly defined in QEMU's configure wrapper script
On 9/22/23 04:52, Zhenzhong Duan wrote:
vfio_put_device() is a VFIO PCI specific function, rename it with
'vfio_pci' prefix to avoid confusing.
No functional change.
There is more to be done but it can wait after the big code reshuffle.
Suggested-by: Cédric Le Goater
Signed-off-by: Zhenzhon
On 9/22/23 4:36 AM, William Roche wrote:
> On 9/21/23 19:41, Yazen Ghannam wrote:
>> On 9/20/23 7:13 AM, Joao Martins wrote:
>>> On 18/09/2023 23:00, William Roche wrote:
[...]
So it looks like the mechanism works fine... unless the VM has migrated
between the SRAO error and the firs
1 - 100 of 208 matches
Mail list logo
