Re: [QEMU PATCH v4 06/13] virtio-gpu: Configure context init for virglrenderer

2023-09-03 Thread Huang Rui via
On Thu, Aug 31, 2023 at 05:39:38PM +0800, Philippe Mathieu-Daudé wrote: > On 31/8/23 11:32, Huang Rui wrote: > > Configure context init feature flag for virglrenderer. > > > > Originally-by: Antonio Caggiano > > Signed-off-by: Huang Rui > > --- > > > > New patch, result of splitting > > [RFC QE

Re: [PATCH v8 02/12] Add virtio-sound-pci device

2023-09-03 Thread Volker Rümelin
This patch adds a PCI wrapper device for the virtio-sound device. It is necessary to instantiate a virtio-snd device in a guest. All sound logic will be added to the virtio-snd device in the following commits. To add this device with a guest, you'll need a >=5.13 kernel compiled with CONFIG_SND_V

Re: [PATCH 4/8] hw/core/cpu: Return static value with gdb_arch_name()

2023-09-03 Thread Akihiko Odaki
On 2023/09/04 14:54, Michael Tokarev wrote: 03.09.2023 07:30, Akihiko Odaki wrote: All implementations of gdb_arch_name() returns dynamic duplicates of static strings. It's also unlikely that there will be an implementation of gdb_arch_name() that returns a truly dynamic value due to the nature

Re: [PATCH 4/8] hw/core/cpu: Return static value with gdb_arch_name()

2023-09-03 Thread Michael Tokarev
03.09.2023 07:30, Akihiko Odaki wrote: All implementations of gdb_arch_name() returns dynamic duplicates of static strings. It's also unlikely that there will be an implementation of gdb_arch_name() that returns a truly dynamic value due to the nature of the function returning a well-known identi

Re: [PATCH 4/8] hw/core/cpu: Return static value with gdb_arch_name()

2023-09-03 Thread Philippe Mathieu-Daudé
On 3/9/23 06:30, Akihiko Odaki wrote: All implementations of gdb_arch_name() returns dynamic duplicates of static strings. It's also unlikely that there will be an implementation of gdb_arch_name() that returns a truly dynamic value due to the nature of the function returning a well-known identif

Re: [PATCH v9 08/20] target/riscv/cpu.c: add riscv_cpu_add_kvm_unavail_prop_array()

2023-09-03 Thread Alistair Francis
On Sat, Sep 2, 2023 at 5:50 AM Daniel Henrique Barboza wrote: > > Use a helper in riscv_cpu_add_kvm_properties() to eliminate some of its > code repetition. > > Signed-off-by: Daniel Henrique Barboza > Reviewed-by: Andrew Jones Reviewed-by: Alistair Francis Alistair > --- > target/riscv/cpu

Re: [PATCH v9 07/20] target/riscv/cpu.c: add riscv_cpu_add_qdev_prop_array()

2023-09-03 Thread Alistair Francis
On Sat, Sep 2, 2023 at 5:49 AM Daniel Henrique Barboza wrote: > > The code inside riscv_cpu_add_user_properties() became quite repetitive > after recent changes. Add a helper to hide the repetition away. > > Signed-off-by: Daniel Henrique Barboza > Reviewed-by: Andrew Jones Reviewed-by: Alistai

Re: [PATCH v9 04/20] target/riscv: add DEFINE_PROP_END_OF_LIST() to riscv_cpu_options[]

2023-09-03 Thread Alistair Francis
On Sat, Sep 2, 2023 at 5:50 AM Daniel Henrique Barboza wrote: > > Add DEFINE_PROP_END_OF_LIST() and eliminate the ARRAY_SIZE() usage when > iterating in the riscv_cpu_options[] array, making it similar to what > we already do when working with riscv_cpu_extensions[]. > > We also have a more sophis

Re: [PATCH v2 3/3] gdbstub: replace exit(0) with proper shutdown

2023-09-03 Thread Alistair Francis
On Wed, Aug 23, 2023 at 5:08 PM Clément Chigot wrote: > > This replaces the exit(0) call by a shutdown request, ensuring a proper > cleanup of Qemu. Otherwise, some connections could be broken without > being correctly flushed. > > Signed-off-by: Clément Chigot Acked-by: Alistair Francis Alist

Re: [PATCH v3 16/16] tcg/loongarch64: Implement 128-bit load & store

2023-09-03 Thread gaosong
Hi, yijun 在 2023/9/3 上午9:10, Jiajie Chen 写道: On 2023/9/3 09:06, Richard Henderson wrote: On 9/1/23 22:02, Jiajie Chen wrote: If LSX is available, use LSX instructions to implement 128-bit load & store. Is this really guaranteed to be an atomic 128-bit operation? Song Gao, please check th

Re: [PATCH] target/riscv/pmp.c: respect mseccfg.RLB for pmpaddrX changes

2023-09-03 Thread Alistair Francis
On Wed, Aug 30, 2023 at 7:50 AM wrote: > > From: Leon Schuermann > > When the rule-lock bypass (RLB) bit is set in the mseccfg CSR, the PMP > configuration lock bits must not apply. While this behavior is > implemented for the pmpcfgX CSRs, this bit is not respected for > changes to the pmpaddrX

Re: [PATCH] target/riscv/pmp.c: respect mseccfg.RLB for pmpaddrX changes

2023-09-03 Thread Alistair Francis
On Wed, Aug 30, 2023 at 7:50 AM wrote: > > From: Leon Schuermann > > When the rule-lock bypass (RLB) bit is set in the mseccfg CSR, the PMP > configuration lock bits must not apply. While this behavior is > implemented for the pmpcfgX CSRs, this bit is not respected for > changes to the pmpaddrX

Re: [PATCH 10/22] Implement shmid_ds conversion between host and target.

2023-09-03 Thread Kariiem Taha
Richard Henderson writes: > On 8/19/23 02:47, Karim Taha wrote: >> +if (!lock_user_struct(VERIFY_WRITE, target_sd, target_addr, 0)) { >> +return -TARGET_EFAULT; >> +} >> +if (host_to_target_ipc_perm(target_addr, &(host_sd->shm_perm))) { >> +return -TARGET_EFAULT; >> +

Re: [PATCH v2 4/5] vfio/migration: Block VFIO migration with postcopy migration

2023-09-03 Thread Avihai Horon
On 01/09/2023 18:51, Peter Xu wrote: External email: Use caution opening links or attachments On Thu, Aug 31, 2023 at 03:57:01PM +0300, Avihai Horon wrote: VFIO migration is not compatible with postcopy migration. A VFIO device in the destination can't handle page faults for pages that have