Re: [PATCH v2 2/5] vdpa: export vhost_vdpa_set_vring_ready

2023-08-13 Thread Jason Wang
On Thu, Aug 10, 2023 at 11:36 PM Eugenio Pérez wrote: > > The vhost-vdpa net backend needs to enable vrings in a different order > than default, so export it. > > No functional change intended except for tracing, that now includes the > (virtio) index being enabled and the return value of the ioct

Re: [PATCH v2 5/5] vdpa: remove net cvq migration blocker

2023-08-13 Thread Jason Wang
On Thu, Aug 10, 2023 at 11:36 PM Eugenio Pérez wrote: > > Now that we have add migration blockers if the device does not support > all the needed features, remove the general blocker applied to all net > devices with CVQ. > > Signed-off-by: Eugenio Pérez Acked-by: Jason Wang Thanks > --- > n

Re: [PATCH v2 3/5] vdpa: rename vhost_vdpa_net_load to vhost_vdpa_net_cvq_load

2023-08-13 Thread Jason Wang
On Thu, Aug 10, 2023 at 11:36 PM Eugenio Pérez wrote: > > Next patches will add the corresponding data load. > > Signed-off-by: Eugenio Pérez Acked-by: Jason Wang Thanks > --- > net/vhost-vdpa.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/vhost-vdpa.c b/n

Re: [PATCH v2 1/5] vdpa: use first queue SVQ state for CVQ default

2023-08-13 Thread Jason Wang
On Thu, Aug 10, 2023 at 11:36 PM Eugenio Pérez wrote: > > Previous to this patch the only way CVQ would be shadowed is if it does > support to isolate CVQ group or if all vqs were shadowed from the > beginning. The second condition was checked at the beginning, and no > more configuration was don

Re: [PATCH v2 4/5] vdpa: move vhost_vdpa_set_vrings_ready to the caller

2023-08-13 Thread Jason Wang
On Thu, Aug 10, 2023 at 11:36 PM Eugenio Pérez wrote: > > Doing that way allows CVQ to be enabled before the dataplane vqs, > restoring the state as MQ or MAC addresses properly in the case of a > migration. > A typo in the subject, should be vhost_vdpa_set_vring_ready. > Signed-off-by: Eugenio

Re: [PATCH v2] target/i386: Avoid cpu number overflow in legacy topology

2023-08-13 Thread Wen, Qian
On 8/14/2023 7:59 AM, Zhao Liu wrote: > Hi Qian, > > On Sun, Aug 13, 2023 at 06:49:40PM +0800, Wen, Qian wrote: > > [snip] > >>> also perhaps double check if we could do induce similar overflow >>> tweaking other -smp properties (todo for another patch[es] if there are >>> such places). >> I have

Re: [PATCH v2] target/i386: Avoid cpu number overflow in legacy topology

2023-08-13 Thread Zhao Liu
Hi Qian, On Sun, Aug 13, 2023 at 06:49:40PM +0800, Wen, Qian wrote: [snip] > > > also perhaps double check if we could do induce similar overflow > > tweaking other -smp properties (todo for another patch[es] if there are > > such places). > > I have a check, the CPUID.0x4:EAX[31:26] indicate

[PATCH v3 28/32] Add os-stat.c to the build

2023-08-13 Thread Karim Taha
Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/bsd-user/freebsd/meson.build b/bsd-user/freebsd/meson.build index f87c788e84..f2f047cca3 100644 --- a/bsd-user/freebsd/meson.build +++ b/bsd-user/freebsd/

[PATCH v3 04/32] Declarations of h2t and t2h conversion functions.

2023-08-13 Thread Karim Taha
From: Stacey Son Declarations of functions that convert between host and target structs. Co-authored-by: Michal Meloun Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/qemu-os.h | 50 ++ bsd-user/qem

[PATCH v3 14/32] Implement h2t_freebds11_statfs

2023-08-13 Thread Karim Taha
From: Stacey Son Implement the stat conversion functions: h2t_freebds11_statfs Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-stat.c | 41 ++ 1 file changed, 41 insertions(+) diff --git a/bsd-use

[PATCH v3 21/32] Implement stat related syscalls

2023-08-13 Thread Karim Taha
From: Stacey Son Implement the following syscalls: fcntl(2) Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-stat.h | 74 ++ 1 file changed, 74 insertions(+) diff --git a/bsd-user/freebsd/os-stat.h

[PATCH v3 09/32] Add struct target_freebsd_fhandle and fcntl flags to bsd-user/syscall_defs.h

2023-08-13 Thread Karim Taha
From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Acked-by: Richard Henderson --- bsd-user/syscall_defs.h | 51 + 1 file changed, 51 insertions(+) diff --git a/bsd-user/syscall_defs.h b/bsd-user/syscall_defs.h index 2aefdd205e..68db9

[PATCH v3 30/32] Add glue to call the following syscalls to the freebsd_syscall function:

2023-08-13 Thread Karim Taha
From: Warner Losh getfh lgetfh fhopen freebsd11_fhstat freebsd11_fhstatfs fhstat fhstatfs Signed-off-by: Warner Losh Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-syscall.c | 28 1 file changed, 28 insertions(+) diff --git a/bs

[PATCH v3 07/32] Add structs target_freebsd11_nstat and target_freebsd11_statfs to bsd-user/syscall_defs.h

2023-08-13 Thread Karim Taha
From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Acked-by: Richard Henderson --- bsd-user/syscall_defs.h | 64 + 1 file changed, 64 insertions(+) diff --git a/bsd-user/syscall_defs.h b/bsd-user/syscall_defs.h index 41259848cd..f8f37

[PATCH v3 08/32] Add struct target_statfs to bsd-user/syscall_defs.h

2023-08-13 Thread Karim Taha
From: Michal Meloun Signed-off-by: Michal Meloun Signed-off-by: Karim Taha Acked-by: Richard Henderson --- bsd-user/syscall_defs.h | 25 + 1 file changed, 25 insertions(+) diff --git a/bsd-user/syscall_defs.h b/bsd-user/syscall_defs.h index f8f37517b2..2aefdd205e 1006

[PATCH v3 22/32] Implement freebsd11 stat related syscalls

2023-08-13 Thread Karim Taha
From: Michal Meloun Rename the following syscalls to the freebsd11 variant: do_freebsd_lstat -> do_freebsd11_lstat do_freebsd_stat -> do_freebsd11_stat Co-authored-by: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Michal Meloun Signed-off-by: Karim Taha Reviewed-by: Richard Henderson

[PATCH v3 31/32] Add glue to call the following syscalls to the freebsd_syscall function:

2023-08-13 Thread Karim Taha
From: Warner Losh freebsd11_statfs statfs freebsd11_fstatfs fstatfs freebsd11_getfsstat getfsstat Signed-off-by: Warner Losh Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-syscall.c | 24 1 file changed, 24 insertions(+) diff --git

[PATCH v3 10/32] Define safe_fcntl macro in bsd-user/syscall_defs.h

2023-08-13 Thread Karim Taha
From: Kyle Evans Signed-off-by: Kyle Evans Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/syscall_defs.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/bsd-user/syscall_defs.h b/bsd-user/syscall_defs.h index 68db9cf4b2..bdcdc4c0fe 100644 --- a/bsd-user/syscall_de

[PATCH v3 12/32] Implement h2t_freebsd11_stat h2t_freebsd_nstat

2023-08-13 Thread Karim Taha
From: Stacey Son Implement the stat conversion functions: h2t_freebsd11_stat h2t_freebsd_nstat Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-stat.c | 94 ++ 1 file changed, 94 insertions(+) crea

[PATCH v3 23/32] Implement freebsd11 stat related syscalls

2023-08-13 Thread Karim Taha
From: Michal Meloun Implement the freebsd11 variant of the following syscalls: fstat(2) fstatat(2) fhstat(2) fhstatfs(2) Co-authored-by: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Michal Meloun Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-stat.h

[PATCH v3 05/32] Add struct target_freebsd11_stat to bsd-user/syscall_defs

2023-08-13 Thread Karim Taha
From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Acked-by: Richard Henderson --- bsd-user/syscall_defs.h | 33 + 1 file changed, 33 insertions(+) diff --git a/bsd-user/syscall_defs.h b/bsd-user/syscall_defs.h index b6d113d24a..30c24bfe1b 10

[PATCH v3 24/32] Implement freebsd11 stat related syscalls

2023-08-13 Thread Karim Taha
From: Michal Meloun Implement the freebsd11 variant of the following syscalls: statfs(2) fstatfs(2) getfsstat(2) Co-authored-by: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Michal Meloun Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-stat.h | 75 ++

[PATCH v3 06/32] Add struct target_stat to bsd-user/syscall_defs.h

2023-08-13 Thread Karim Taha
From: Michal Meloun Signed-off-by: Michal Meloun Signed-off-by: Karim Taha Acked-by: Richard Henderson --- bsd-user/syscall_defs.h | 38 ++ 1 file changed, 38 insertions(+) diff --git a/bsd-user/syscall_defs.h b/bsd-user/syscall_defs.h index 30c24bfe1b..4

[PATCH v3 15/32] Implement target_to_host_fcntl_cmd

2023-08-13 Thread Karim Taha
From: Stacey Son Implement the stat conversion functions: target_to_host_fcntl_cmd Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-stat.c | 8 1 file changed, 8 insertions(+) diff --git a/bsd-user/freebsd/os-stat.c b/bsd-us

[PATCH v3 18/32] Implement stat related syscalls

2023-08-13 Thread Karim Taha
From: Stacey Son Implement the following syscalls: getfh(2) lgetfh(2) fhopen(2) fhstat(2) fhstatfs(2) Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-stat.h | 83 ++ 1 file changed, 83 insertions(+

[PATCH v3 27/32] Implement do_freebsd_realpathat syscall

2023-08-13 Thread Karim Taha
From: Mikaël Urankar Signed-off-by: Mikaël Urankar Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-stat.h | 26 ++ 1 file changed, 26 insertions(+) diff --git a/bsd-user/freebsd/os-stat.h b/bsd-user/freebsd/os-stat.h index e31b2aab9e..

[PATCH v3 03/32] Update the definitions of __put_user and __get_user macros

2023-08-13 Thread Karim Taha
From: Warner Losh Use __builtin_choose_expr to avoid type promotion from ?: in __put_user_e and __get_user_e macros. Copied from linux-user/qemu.h, originally by Blue Swirl. Signed-off-by: Warner Losh Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/qemu.h | 81 +++

[PATCH v3 26/32] Implement freebsd11 stat related syscalls

2023-08-13 Thread Karim Taha
From: Michal Meloun Forward declaration of the nstat syscalls: nstat nlstat nfstat Co-authored-by: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Michal Meloun Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-stat.h | 7 +++ 1 file changed, 7 insert

[PATCH v3 16/32] Implement h2t_freebsd_stat and h2t_freebsd_statfs functions

2023-08-13 Thread Karim Taha
From: Michal Meloun They are the 64-bit variants of h2t_freebsd11_stat and h2t_freebsd11_statfs, respectively Signed-off-by: Michal Meloun Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-stat.c | 82 ++ 1 file changed, 82 i

[PATCH v3 19/32] Implement stat related syscalls

2023-08-13 Thread Karim Taha
From: Stacey Son Implement the following syscalls: statfs(2) fstatfs(2) getfsstat(2) Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-stat.h | 69 ++ 1 file changed, 69 insertions(+) diff --git a/b

[PATCH v3 17/32] Implement stat related syscalls

2023-08-13 Thread Karim Taha
From: Stacey Son Implement the following syscalls: stat(2) lstat(2) fstat(2) fstatat(2) nstat nfstat nlstat Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-stat.h | 130 + 1 file changed, 130 inser

[PATCH v3 25/32] Implement freebsd11 stat related syscalls

2023-08-13 Thread Karim Taha
From: Michal Meloun Implement the freebsd11 variant of the following syscalls: getdirecentries(2) Co-authored-by: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Michal Meloun Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-stat.h | 44 +

[PATCH v3 32/32] Add glue to call the following syscalls to the freebsd_syscall function:

2023-08-13 Thread Karim Taha
From: Warner Losh freebsd11_getdents getdirentries freebsd11_getdirentries fcntl Signed-off-by: Warner Losh Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-syscall.c | 16 1 file changed, 16 insertions(+) diff --git a/bsd-user/freebsd/os-sys

[PATCH v3 20/32] Implement stat related syscalls

2023-08-13 Thread Karim Taha
From: Stacey Son Implement the following syscalls: getdents(2) getdirecentries(2) Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-stat.h | 72 ++ 1 file changed, 72 insertions(+) diff --git a/bsd-

[PATCH v3 29/32] Add glue to call the following syscalls to the freebsd_syscall function:

2023-08-13 Thread Karim Taha
From: Warner Losh freebsd11_stat freebsd11_lstat freebsd11_fstat freebsd11_fstatat freebsd11_nstat, freebsd11_nfstat, freebsd11_nlstat fstatat fstat Signed-off-by: Warner Losh Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-syscall.c | 42

[PATCH v3 13/32] Implement h2t_freebsd_fhandle t2h_freebsd_fhandle functions

2023-08-13 Thread Karim Taha
From: Stacey Son Implement the stat conversion functions: h2t_freebsd_fhandle t2h_freebsd_fhandle Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-stat.c | 37 + 1 file changed, 37 insertions(+) di

[PATCH v3 11/32] Rename target_freebsd_time_t to target_time_t

2023-08-13 Thread Karim Taha
From: Warner Losh This is necessary for future code using target_time_t, in bsd-user/syscall_defs. Signed-off-by: Warner Losh Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/syscall_defs.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/bsd-u

[PATCH v3 01/32] Move _WANT_FREEBSD macros to include/qemu/osdep.h

2023-08-13 Thread Karim Taha
From: Warner Losh move _WANT_FREEBSD macros from bsd-user/freebsd/os-syscall.c to include/qemu/osdep.h in order to pull some struct defintions needed later in the build. Signed-off-by: Warner Losh Signed-off-by: Karim Taha Acked-by: Richard Henderson --- bsd-user/freebsd/os-syscall.c | 11 --

[PATCH v3 00/32] Implement the stat system calls for FreeBSD.

2023-08-13 Thread Karim Taha
Upstream the implementation of the stat system calls from the qemu-bsd-user fork, the following system calls are implemented: stat(2), lstat(2), fstat(2), fstatat(2), nstat, nfstat, nlstat getfh(2), lgetfh(2), fhopen(2), fhstat(2), fhstatfs(2), statfs(2) fstatfs(2), getfsstat(2), getdents(2), getdi

[PATCH v3 02/32] Disable clang warnings

2023-08-13 Thread Karim Taha
From: Kyle Evans Implement PRAGMA_DISABLE_PACKED_WARNING and PRAGMA_REENABLE_PACKED_WARNING macros in include/qemu/compiler.h. Signed-off-by: Kyle Evans Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- include/qemu/compiler.h | 30 ++ 1 file changed,

[PATCH for-8.2] target/m68k: Use tcg_gen_deposit_i32 in gen_partset_reg

2023-08-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/m68k/translate.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 37954d11a6..15b3701b8f 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -697,19

Re: [PATCH v2 27/32] Implement do_freebsd_realpathat syscall

2023-08-13 Thread Richard Henderson
On 8/12/23 20:10, Karim Taha wrote: +#if defined(__FreeBSD_version) && __FreeBSD_version >= 1300080 +extern int __realpathat(int fd, const char *path, char *buf, size_t size, +int flags); +//https://svnweb.freebsd.org/base?view=revision&revision=358172 +// no man page C comments, not C+

Re: [PATCH v2 04/32] Declarations of h2t and t2h conversion functions.

2023-08-13 Thread Richard Henderson
On 8/12/23 20:09, Karim Taha wrote: From: Stacey Son Declarations of functions that convert between host and target structs. Co-authored-by: Michal Meloun Signed-off-by: Stacey Son Signed-off-by: Karim Taha --- bsd-user/freebsd/qemu-os.h | 50 ++ bsd-user

Re: [PATCH v2 07/32] Add structs target_freebsd11_nstat and target_freebsd11_statfs to bsd-user/syscall_defs.h

2023-08-13 Thread Richard Henderson
On 8/12/23 20:09, Karim Taha wrote: From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha --- bsd-user/syscall_defs.h | 64 + 1 file changed, 64 insertions(+) Acked-by: Richard Henderson r~

[PATCH v2 22/32] Implement freebsd11 stat related syscalls

2023-08-13 Thread Karim Taha
From: Michal Meloun Rename the following syscalls to the freebsd11 variant: do_freebsd_lstat -> do_freebsd11_lstat do_freebsd_stat -> do_freebsd11_stat Co-authored-by: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Michal Meloun Signed-off-by: Karim Taha Reviewed-by: Richard Henderson

[PATCH v2 24/32] Implement freebsd11 stat related syscalls

2023-08-13 Thread Karim Taha
From: Michal Meloun Implement the freebsd11 variant of the following syscalls: statfs(2) fstatfs(2) getfsstat(2) Co-authored-by: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Michal Meloun Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-stat.h | 75 ++

[PATCH v2 23/32] Implement freebsd11 stat related syscalls

2023-08-13 Thread Karim Taha
From: Michal Meloun Implement the freebsd11 variant of the following syscalls: fstat(2) fstatat(2) fhstat(2) fhstatfs(2) Co-authored-by: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Michal Meloun Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-stat.h

[PATCH v2 31/32] Add glue to call the following syscalls to the freebsd_syscall function:

2023-08-13 Thread Karim Taha
From: Warner Losh freebsd11_statfs statfs freebsd11_fstatfs fstatfs freebsd11_getfsstat getfsstat Signed-off-by: Warner Losh Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-syscall.c | 24 1 file changed, 24 insertions(+) diff --git

[PATCH v2 25/32] Implement freebsd11 stat related syscalls

2023-08-13 Thread Karim Taha
From: Michal Meloun Implement the freebsd11 variant of the following syscalls: getdirecentries(2) Co-authored-by: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Michal Meloun Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-stat.h | 44 +

[PATCH v2 30/32] Add glue to call the following syscalls to the freebsd_syscall function:

2023-08-13 Thread Karim Taha
From: Warner Losh getfh lgetfh fhopen freebsd11_fhstat freebsd11_fhstatfs fhstat fhstatfs Signed-off-by: Warner Losh Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-syscall.c | 28 1 file changed, 28 insertions(+) diff --git a/bs

[PATCH v2 21/32] Implement stat related syscalls

2023-08-13 Thread Karim Taha
From: Stacey Son Implement the following syscalls: fcntl(2) Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-stat.h | 74 ++ 1 file changed, 74 insertions(+) diff --git a/bsd-user/freebsd/os-stat.h

[PATCH v2 17/32] Implement stat related syscalls

2023-08-13 Thread Karim Taha
From: Stacey Son Implement the following syscalls: stat(2) lstat(2) fstat(2) fstatat(2) nstat nfstat nlstat Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-stat.h | 130 + 1 file changed, 130 inser

[PATCH v2 18/32] Implement stat related syscalls

2023-08-13 Thread Karim Taha
From: Stacey Son Implement the following syscalls: getfh(2) lgetfh(2) fhopen(2) fhstat(2) fhstatfs(2) Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-stat.h | 83 ++ 1 file changed, 83 insertions(+

[PATCH v2 04/32] Declarations of h2t and t2h conversion functions.

2023-08-13 Thread Karim Taha
From: Stacey Son Declarations of functions that convert between host and target structs. Co-authored-by: Michal Meloun Signed-off-by: Stacey Son Signed-off-by: Karim Taha --- bsd-user/freebsd/qemu-os.h | 50 ++ bsd-user/qemu.h| 1 + 2 files c

[PATCH v2 05/32] Add struct target_freebsd11_stat to bsd-user/syscall_defs

2023-08-13 Thread Karim Taha
From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Acked-by: Richard Henderson --- bsd-user/syscall_defs.h | 33 + 1 file changed, 33 insertions(+) diff --git a/bsd-user/syscall_defs.h b/bsd-user/syscall_defs.h index b6d113d24a..30c24bfe1b 10

[PATCH v2 08/32] Add struct target_statfs to bsd-user/syscall_defs.h

2023-08-13 Thread Karim Taha
From: Michal Meloun Signed-off-by: Michal Meloun Signed-off-by: Karim Taha Acked-by: Richard Henderson --- bsd-user/syscall_defs.h | 25 + 1 file changed, 25 insertions(+) diff --git a/bsd-user/syscall_defs.h b/bsd-user/syscall_defs.h index f8f37517b2..2aefdd205e 1006

[PATCH v2 32/32] Add glue to call the following syscalls to the freebsd_syscall function:

2023-08-13 Thread Karim Taha
From: Warner Losh freebsd11_getdents getdirentries freebsd11_getdirentries fcntl Signed-off-by: Warner Losh Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-syscall.c | 16 1 file changed, 16 insertions(+) diff --git a/bsd-user/freebsd/os-sys

[PATCH v2 14/32] Implement h2t_freebds11_statfs

2023-08-13 Thread Karim Taha
From: Stacey Son Implement the stat conversion functions: h2t_freebds11_statfs Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-stat.c | 41 ++ 1 file changed, 41 insertions(+) diff --git a/bsd-use

[PATCH v2 07/32] Add structs target_freebsd11_nstat and target_freebsd11_statfs to bsd-user/syscall_defs.h

2023-08-13 Thread Karim Taha
From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha --- bsd-user/syscall_defs.h | 64 + 1 file changed, 64 insertions(+) diff --git a/bsd-user/syscall_defs.h b/bsd-user/syscall_defs.h index 41259848cd..f8f37517b2 100644 --- a/bsd-user/s

[PATCH v2 15/32] Implement target_to_host_fcntl_cmd

2023-08-13 Thread Karim Taha
From: Stacey Son Implement the stat conversion functions: target_to_host_fcntl_cmd Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-stat.c | 8 1 file changed, 8 insertions(+) diff --git a/bsd-user/freebsd/os-stat.c b/bsd-us

[PATCH v2 13/32] Implement h2t_freebsd_fhandle t2h_freebsd_fhandle functions

2023-08-13 Thread Karim Taha
From: Stacey Son Implement the stat conversion functions: h2t_freebsd_fhandle t2h_freebsd_fhandle Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-stat.c | 37 + 1 file changed, 37 insertions(+) di

[PATCH v2 02/32] Disable clang warnings

2023-08-13 Thread Karim Taha
From: Kyle Evans Implement PRAGMA_DISABLE_PACKED_WARNING and PRAGMA_REENABLE_PACKED_WARNING macros in include/qemu/compiler.h. Signed-off-by: Kyle Evans Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- include/qemu/compiler.h | 30 ++ 1 file changed,

[PATCH v2 19/32] Implement stat related syscalls

2023-08-13 Thread Karim Taha
From: Stacey Son Implement the following syscalls: statfs(2) fstatfs(2) getfsstat(2) Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-stat.h | 69 ++ 1 file changed, 69 insertions(+) diff --git a/b

[PATCH v2 11/32] Rename target_freebsd_time_t to target_time_t

2023-08-13 Thread Karim Taha
From: Warner Losh This is necessary for future code using target_time_t, in bsd-user/syscall_defs. Signed-off-by: Warner Losh Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/syscall_defs.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/bsd-u

[PATCH v2 29/32] Add glue to call the following syscalls to the freebsd_syscall function:

2023-08-13 Thread Karim Taha
From: Warner Losh freebsd11_stat freebsd11_lstat freebsd11_fstat freebsd11_fstatat freebsd11_nstat, freebsd11_nfstat, freebsd11_nlstat fstatat fstat Signed-off-by: Warner Losh Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-syscall.c | 42

[PATCH v2 09/32] Add struct target_freebsd_fhandle and fcntl flags to bsd-user/syscall_defs.h

2023-08-13 Thread Karim Taha
From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Acked-by: Richard Henderson --- bsd-user/syscall_defs.h | 51 + 1 file changed, 51 insertions(+) diff --git a/bsd-user/syscall_defs.h b/bsd-user/syscall_defs.h index 2aefdd205e..68db9

[PATCH v2 20/32] Implement stat related syscalls

2023-08-13 Thread Karim Taha
From: Stacey Son Implement the following syscalls: getdents(2) getdirecentries(2) Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-stat.h | 72 ++ 1 file changed, 72 insertions(+) diff --git a/bsd-

[PATCH v2 06/32] Add struct target_stat to bsd-user/syscall_defs.h

2023-08-13 Thread Karim Taha
From: Michal Meloun Signed-off-by: Michal Meloun Signed-off-by: Karim Taha Acked-by: Richard Henderson --- bsd-user/syscall_defs.h | 38 ++ 1 file changed, 38 insertions(+) diff --git a/bsd-user/syscall_defs.h b/bsd-user/syscall_defs.h index 30c24bfe1b..4

[PATCH v2 01/32] Move _WANT_FREEBSD macros to include/qemu/osdep.h

2023-08-13 Thread Karim Taha
From: Warner Losh move _WANT_FREEBSD macros from bsd-user/freebsd/os-syscall.c to include/qemu/osdep.h in order to pull some struct defintions needed later in the build. Signed-off-by: Warner Losh Signed-off-by: Karim Taha Acked-by: Richard Henderson --- bsd-user/freebsd/os-syscall.c | 11 --

[PATCH v2 10/32] Define safe_fcntl macro in bsd-user/syscall_defs.h

2023-08-13 Thread Karim Taha
From: Kyle Evans Signed-off-by: Kyle Evans Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/syscall_defs.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/bsd-user/syscall_defs.h b/bsd-user/syscall_defs.h index 68db9cf4b2..bdcdc4c0fe 100644 --- a/bsd-user/syscall_de

[PATCH v2 16/32] Implement h2t_freebsd_stat and h2t_freebsd_statfs functions

2023-08-13 Thread Karim Taha
From: Michal Meloun They are the 64-bit variants of h2t_freebsd11_stat and h2t_freebsd11_statfs, respectively Signed-off-by: Michal Meloun Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-stat.c | 82 ++ 1 file changed, 82 i

[PATCH v2 27/32] Implement do_freebsd_realpathat syscall

2023-08-13 Thread Karim Taha
From: Mikaël Urankar Signed-off-by: Mikaël Urankar Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-stat.h | 26 ++ 1 file changed, 26 insertions(+) diff --git a/bsd-user/freebsd/os-stat.h b/bsd-user/freebsd/os-stat.h index e31b2aab9e..

[PATCH v2 03/32] Update the definitions of __put_user and __get_user macros

2023-08-13 Thread Karim Taha
From: Warner Losh Use __builtin_choose_expr to avoid type promotion from ?: in __put_user_e and __get_user_e macros. Copied from linux-user/qemu.h, originally by Blue Swirl. Signed-off-by: Warner Losh Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/qemu.h | 81 +++

[PATCH v2 12/32] Implement h2t_freebsd11_stat h2t_freebsd_nstat

2023-08-13 Thread Karim Taha
From: Stacey Son Implement the stat conversion functions: h2t_freebsd11_stat h2t_freebsd_nstat Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-stat.c | 94 ++ 1 file changed, 94 insertions(+) crea

[PATCH v2 26/32] Implement freebsd11 stat related syscalls

2023-08-13 Thread Karim Taha
From: Michal Meloun Forward declaration of the nstat syscalls: nstat nlstat nfstat Co-authored-by: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Michal Meloun Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-stat.h | 7 +++ 1 file changed, 7 insert

[PATCH v2 28/32] Add os-stat.c to the build

2023-08-13 Thread Karim Taha
Signed-off-by: Karim Taha Reviewed-by: Richard Henderson --- bsd-user/freebsd/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/bsd-user/freebsd/meson.build b/bsd-user/freebsd/meson.build index f87c788e84..f2f047cca3 100644 --- a/bsd-user/freebsd/meson.build +++ b/bsd-user/freebsd/

[PATCH v2 00/32] Implement the stat system calls for FreeBSD.

2023-08-13 Thread Karim Taha
Upstream the implementation of the stat system calls from the qemu-bsd-user fork, the following system calls are implemented: stat(2), lstat(2), fstat(2), fstatat(2), nstat, nfstat, nlstat getfh(2), lgetfh(2), fhopen(2), fhstat(2), fhstatfs(2), statfs(2) fstatfs(2), getfsstat(2), getdents(2), getdi

[RFC PATCH v2 0/3] Vhost-vdpa Shadow Virtqueue RSS Support

2023-08-13 Thread Hawkins Jiawei
This series enables shadowed CVQ to intercept RSS command through shadowed CVQ, update the virtio NIC device model so qemu send it in a migration, and the restore of that RSS state in the destination. Note that this patch should be based on patch "Vhost-vdpa Shadow Virtqueue Hash calculation Suppo

[RFC PATCH v2 3/3] vdpa: Allow VIRTIO_NET_F_RSS in SVQ

2023-08-13 Thread Hawkins Jiawei
Enable SVQ with VIRTIO_NET_F_RSS feature. Signed-off-by: Hawkins Jiawei --- net/vhost-vdpa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index e21b3ac67a..2a276ef528 100644 --- a/net/vhost-vdpa.c +++ b/net/vhost-vdpa.c @@ -119,6 +119,7 @@ static const

[RFC PATCH v2 1/3] vdpa: Add SetSteeringEBPF method for NetClientState

2023-08-13 Thread Hawkins Jiawei
At present, to enable the VIRTIO_NET_F_RSS feature, eBPF must be loaded for the vhost backend. Given that vhost-vdpa is one of the vhost backend, we need to implement the SetSteeringEBPF method to support RSS for vhost-vdpa, even if vhost-vdpa calculates the rss hash in the hardware device instead

[RFC PATCH v2 2/3] vdpa: Restore receive-side scaling state

2023-08-13 Thread Hawkins Jiawei
This patch reuses vhost_vdpa_net_load_rss() with some refactorings to restore the receive-side scaling state at device's startup. Signed-off-by: Hawkins Jiawei --- v2: - Correct the feature usage to VIRTIO_NET_F_HASH_REPORT when loading the hash calculation state v1: https://lore.kernel.org/a

Re: [RFC PATCH 2/3] vdpa: Restore receive-side scaling state

2023-08-13 Thread Hawkins Jiawei
On 2023/8/11 23:28, Hawkins Jiawei wrote: > This patch reuses vhost_vdpa_net_load_rss() with some > refactorings to restore the receive-side scaling state > at device's startup. > > Signed-off-by: Hawkins Jiawei > --- > net/vhost-vdpa.c | 53 > 1

Re: [PATCH v2] target/i386: Avoid cpu number overflow in legacy topology

2023-08-13 Thread Wen, Qian
On 8/9/2023 9:47 PM, Igor Mammedov wrote: > On Wed, 9 Aug 2023 21:20:48 +0800 > "Wen, Qian" wrote: > >> On 8/9/2023 7:14 PM, Igor Mammedov wrote: >>> On Wed, 9 Aug 2023 18:27:32 +0800 >>> Qian Wen wrote: >>> The legacy topology enumerated by CPUID.1.EBX[23:16] is defined in SDM Vol2:

qemu-system-m68k: ../hw/scsi/scsi-disk.c:557: scsi_write_data: Assertion `r->req.aiocb == NULL' failed.

2023-08-13 Thread Waldemar Brodkorb
Hi, I am using Qemu 8.0.3 and getting this error: qemu-system-m68k: ../hw/scsi/scsi-disk.c:557: scsi_write_data: Assertion `r->req.aiocb == NULL' failed. It happens f.e. when I extract the glibc source code inside Linux. Linux 6.1.44, glibc 2.38 is used for the Linux system. I am starting qemu t

Re: [PATCH v2 00/12] tests: enable meson test timeouts to improve debuggability

2023-08-13 Thread Thomas Huth
On 08/08/2023 10.57, Alex Bennée wrote: Daniel P. Berrangé writes: Perhaps the most painful of all the GitLab CI failures we see are the enforced job timeouts: "ERROR: Job failed: execution took longer than 1h15m0s seconds" https://gitlab.com/qemu-project/qemu/-/jobs/4387047648 whe