Re: [PATCH v2] target/riscv: Add Zihintntl extension ISA string to DTS

2023-07-10 Thread Jason Chien
Hi all, I am sorry that I forgot to add "Reviewed-by". I will add "Reviewed-by" and send v3 shortly. Jason Chien On Tue, Jul 11, 2023 at 1:47 PM Jason Chien wrote: > RVA23 Profiles states: > The RVA23 profiles are intended to be used for 64-bit application > processors that will run rich OS sta

Re: [RFC PATCH 6/9] ui/gtk: Add a new parameter to assign connectors/monitors to GFX VCs

2023-07-10 Thread Markus Armbruster
"Kim, Dongwon" writes: > On 7/9/2023 11:05 PM, Markus Armbruster wrote: >> "Kim, Dongwon" writes: >> >>> On 7/7/2023 7:07 AM, Markus Armbruster wrote: [...] Ignorant questions: 1. How would I plug / unplug display cables? >>> >>> I am not sure if I understood your question corre

[PATCH v2] target/riscv: Add Zihintntl extension ISA string to DTS

2023-07-10 Thread Jason Chien
RVA23 Profiles states: The RVA23 profiles are intended to be used for 64-bit application processors that will run rich OS stacks from standard binary OS distributions and with a substantial number of third-party binary user applications that will be supported over a considerable length of time in t

Re: tests/avocado/replay_kernel: ReplayKernelNormal.test_aarch64_virt failing

2023-07-10 Thread Pavel Dovgalyuk
On 10.07.2023 20:14, Philippe Mathieu-Daudé wrote: Hi, Per tests/avocado/replay_kernel.py:     def test_aarch64_virt(self):     ...     console_pattern = 'VFS: Cannot open root device' the test is succeeding, but Avocado reports an error. Does the emulator exit when error "Cannot

Re: [PATCH v8 6/6] hw/pci: add comment explaining the reason for checking function 0 in hotplug

2023-07-10 Thread Ani Sinha
> On 11-Jul-2023, at 9:43 AM, Michael Tokarev wrote: > > 11.07.2023 07:03, Ani Sinha wrote: >>> On 11-Jul-2023, at 9:21 AM, Michael Tokarev wrote: >>> >>> 11.07.2023 06:46, Ani Sinha wrote: >>> Sure. Since this is only a comment addition, should I also CC qemu-trivial? >>> >>> A comme

Re: [PATCH v8 6/6] hw/pci: add comment explaining the reason for checking function 0 in hotplug

2023-07-10 Thread Michael Tokarev
11.07.2023 07:03, Ani Sinha wrote: On 11-Jul-2023, at 9:21 AM, Michael Tokarev wrote: 11.07.2023 06:46, Ani Sinha wrote: Sure. Since this is only a comment addition, should I also CC qemu-trivial? A comment change does not mean the change is trivial. It's a trivial in a sense the code c

Re: [PATCH V2] vhost_vdpa: no need to fetch vring base when poweroff

2023-07-10 Thread Zhu, Lingshan
On 7/11/2023 10:50 AM, Jason Wang wrote: On Mon, Jul 10, 2023 at 4:53 PM Zhu Lingshan wrote: In the poweroff routine, no need to fetch last available index. This is because there's no concept of shutdown in the vhost layer, it only knows start and stop. This commit also provides a better

Re: [PATCH v8 6/6] hw/pci: add comment explaining the reason for checking function 0 in hotplug

2023-07-10 Thread Ani Sinha
> On 11-Jul-2023, at 9:21 AM, Michael Tokarev wrote: > > 11.07.2023 06:46, Ani Sinha wrote: > >> Sure. Since this is only a comment addition, should I also CC qemu-trivial? > > A comment change does not mean the change is trivial. It's a trivial in a > sense > the code changes are trivial

Re: [PATCH v7 12/15] target/riscv: Add Zvkg ISA extension support

2023-07-10 Thread Max Chou
On 2023/7/11 11:15 AM, Alistair Francis wrote: On Mon, Jul 10, 2023 at 6:37 PM Max Chou wrote: On 2023/7/8 5:25 PM, Daniel Henrique Barboza wrote: Hi, This patch breaks some gitlab runners because of this: On 7/2/23 12:53, Max Chou wrote: From: Nazar Kazakov This commit adds support for

Re: [PATCH v8 6/6] hw/pci: add comment explaining the reason for checking function 0 in hotplug

2023-07-10 Thread Michael Tokarev
11.07.2023 06:46, Ani Sinha wrote: Sure. Since this is only a comment addition, should I also CC qemu-trivial? A comment change does not mean the change is trivial. It's a trivial in a sense the code changes are trivial (actually not-existent), but the meaning of the comment is not trivial a

Re: [PATCH v8 6/6] hw/pci: add comment explaining the reason for checking function 0 in hotplug

2023-07-10 Thread Ani Sinha
> On 11-Jul-2023, at 1:13 AM, Michael S. Tsirkin wrote: > > On Wed, Jul 05, 2023 at 05:33:31PM +0530, Ani Sinha wrote: >> >> >>> On 05-Jul-2023, at 5:29 PM, Ani Sinha wrote: >>> >>> This change is cosmetic. A comment is added explaining why we need to check >>> for >>> the availability of

Re: [PATCH v7 12/15] target/riscv: Add Zvkg ISA extension support

2023-07-10 Thread Alistair Francis
On Mon, Jul 10, 2023 at 6:37 PM Max Chou wrote: > > On 2023/7/8 5:25 PM, Daniel Henrique Barboza wrote: > > > Hi, > > > > This patch breaks some gitlab runners because of this: > > > > On 7/2/23 12:53, Max Chou wrote: > >> From: Nazar Kazakov > >> > >> This commit adds support for the Zvkg vector

Re: [PATCH] net: add initial support for AF_XDP network backend

2023-07-10 Thread Jason Wang
On Mon, Jul 10, 2023 at 11:14 PM Stefan Hajnoczi wrote: > > On Thu, 6 Jul 2023 at 21:43, Jason Wang wrote: > > > > On Fri, Jul 7, 2023 at 3:08 AM Stefan Hajnoczi wrote: > > > > > > On Wed, 5 Jul 2023 at 02:02, Jason Wang wrote: > > > > > > > > On Mon, Jul 3, 2023 at 5:03 PM Stefan Hajnoczi >

Re: [QEMU PATCH v2 1/1] virtgpu: do not destroy resources when guest suspend

2023-07-10 Thread Chen, Jiqian
Hi, On 2023/7/11 04:28, Michael S. Tsirkin wrote: > On Fri, Jun 30, 2023 at 03:00:16PM +0800, Jiqian Chen wrote: >> After suspending and resuming guest VM, you will get >> a black screen, and the display can't come back. >> >> This is because when guest did suspending, it called >> into qemu to ca

Re: [PATCH] net: add initial support for AF_XDP network backend

2023-07-10 Thread Jason Wang
On Mon, Jul 10, 2023 at 11:21 PM Stefan Hajnoczi wrote: > > On Mon, 10 Jul 2023 at 06:55, Ilya Maximets wrote: > > > > On 7/10/23 05:51, Jason Wang wrote: > > > On Fri, Jul 7, 2023 at 7:21 PM Ilya Maximets wrote: > > >> > > >> On 7/7/23 03:43, Jason Wang wrote: > > >>> On Fri, Jul 7, 2023 at 3:0

Re: [PATCH] net: add initial support for AF_XDP network backend

2023-07-10 Thread Jason Wang
On Mon, Jul 10, 2023 at 6:55 PM Ilya Maximets wrote: > > On 7/10/23 05:51, Jason Wang wrote: > > On Fri, Jul 7, 2023 at 7:21 PM Ilya Maximets wrote: > >> > >> On 7/7/23 03:43, Jason Wang wrote: > >>> On Fri, Jul 7, 2023 at 3:08 AM Stefan Hajnoczi wrote: > > On Wed, 5 Jul 2023 at 02:02,

[PATCH v1 2/9] virtio-gpu: CONTEXT_INIT feature

2023-07-10 Thread Gurchetan Singh
From: Antonio Caggiano The feature can be enabled when a backend wants it. Signed-off-by: Antonio Caggiano Reviewed-by: Marc-André Lureau Signed-off-by: Gurchetan Singh Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Akihiko Odaki --- hw/display/virtio-gpu-base.c | 3 +++ include/hw/vir

[PATCH v1 9/9] docs/system: add basic virtio-gpu documentation

2023-07-10 Thread Gurchetan Singh
This adds basic documentation for virtio-gpu. Suggested-by: Akihiko Odaki Signed-off-by: Gurchetan Singh --- docs/system/device-emulation.rst | 1 + docs/system/devices/virtio-gpu.rst | 80 ++ 2 files changed, 81 insertions(+) create mode 100644 docs/system/devic

[PATCH v1 0/9] gfxstream + rutabaga_gfx

2023-07-10 Thread Gurchetan Singh
From: Gurchetan Singh Latest iteration of rutabaga_gfx + gfxstream patches. Previous version and more background available here: https://patchew.org/QEMU/20230421011223.718-1-gurchetansi...@chromium.org/ Changes since RFC: - All important memory tests pass - Went with separate virtio-gpu-rutab

[PATCH v1 4/9] virtio-gpu: blob prep

2023-07-10 Thread Gurchetan Singh
From: Antonio Caggiano This adds preparatory functions needed to: - decode blob cmds - tracking iovecs Signed-off-by: Antonio Caggiano Signed-off-by: Dmitry Osipenko Signed-off-by: Gurchetan Singh --- hw/display/virtio-gpu.c | 11 +++ include/hw/virtio/virtio-

[PATCH v1 5/9] gfxstream + rutabaga prep: added need defintions, fields, and options

2023-07-10 Thread Gurchetan Singh
This modifies the common virtio-gpu.h file have the fields and defintions needed by gfxstream/rutabaga, by VirtioGpuRutabaga. - a colon separated list of capset names, defined in the virtio spec - a wayland socket path to enable guest Wayland passthrough The command to run these would be: -devic

[PATCH v1 6/9] gfxstream + rutabaga: add initial support for gfxstream

2023-07-10 Thread Gurchetan Singh
This adds initial support for gfxstream and cross-domain. Both features rely on virtio-gpu blob resources and context types, which are also implemented in this patch. gfxstream has a long and illustrious history in Android graphics paravirtualization. It has been powering graphics in the Android

[PATCH v1 1/9] virtio: Add shared memory capability

2023-07-10 Thread Gurchetan Singh
From: "Dr. David Alan Gilbert" Define a new capability type 'VIRTIO_PCI_CAP_SHARED_MEMORY_CFG' to allow defining shared memory regions with sizes and offsets of 2^32 and more. Multiple instances of the capability are allowed and distinguished by a device-specific 'id'. Signed-off-by: Dr. David A

[PATCH v1 3/9] virtio-gpu: hostmem

2023-07-10 Thread Gurchetan Singh
From: Gerd Hoffmann Use VIRTIO_GPU_SHM_ID_HOST_VISIBLE as id for virtio-gpu. Signed-off-by: Antonio Caggiano Acked-by: Michael S. Tsirkin --- hw/display/virtio-gpu-pci.c| 14 ++ hw/display/virtio-gpu.c| 1 + hw/display/virtio-vga.c| 33

[PATCH v1 7/9] gfxstream + rutabaga: meson support

2023-07-10 Thread Gurchetan Singh
- Add meson detection of rutabaga_gfx - Build virtio-gpu-rutabaga.c + associated vga/pci files when present Signed-off-by: Gurchetan Singh --- hw/display/meson.build| 22 ++ meson.build | 7 +++ meson_options.txt | 2 ++ scripts/m

[PATCH v1 8/9] gfxstream + rutabaga: enable rutabaga

2023-07-10 Thread Gurchetan Singh
This change enables rutabaga to receive virtio-gpu-3d hypercalls when it is active. Signed-off-by: Gurchetan Singh --- hw/display/virtio-gpu-base.c | 3 ++- hw/display/virtio-gpu.c | 5 +++-- softmmu/qdev-monitor.c | 3 +++ softmmu/vl.c | 1 + 4 files changed, 9 insert

Re: [PATCH V2] vhost_vdpa: no need to fetch vring base when poweroff

2023-07-10 Thread Jason Wang
On Mon, Jul 10, 2023 at 4:53 PM Zhu Lingshan wrote: > > In the poweroff routine, no need to fetch last available index. > This is because there's no concept of shutdown in the vhost layer, it only knows start and stop. > This commit also provides a better debug message in the vhost > caller vhos

Re: [PATCH v4 0/6] net/tap: Fix QEMU frozen issue when the maximum number of file descriptors is very large

2023-07-10 Thread Jason Wang
On Mon, Jul 10, 2023 at 2:07 PM Markus Armbruster wrote: > > Jason Wang writes: > > > On Sun, Jul 9, 2023 at 11:48 PM Bin Meng wrote: > >> > >> On Wed, Jun 28, 2023 at 11:29 PM Bin Meng wrote: > >> > > >> > > >> > Current codes using a brute-force traversal of all file descriptors > >> > do not

Re: [PATCH] vdpa: Increase out buffer size for CVQ commands

2023-07-10 Thread Hawkins Jiawei
On 2023/7/11 2:52, Michael S. Tsirkin wrote: > On Mon, Jun 26, 2023 at 04:26:04PM +0800, Hawkins Jiawei wrote: >> It appears that my commit message and comments did not take this into >> account. I will refactor them in the v2 patch.. > > does not look like you ever sent v2. > Sorry for not mentio

[RFC PATCH v2 6/9] ui/gtk: Add a new parameter to assign connectors/monitors to GFX VCs

2023-07-10 Thread Dongwon Kim
From: Vivek Kasireddy The new parameter named "connector" can be used to assign physical monitors/connectors to individual GFX VCs such that when the monitor is connected or hotplugged, the associated GTK window would be moved to it. If the monitor is disconnected or unplugged, the associated GTK

RE: [PATCH v2] Hexagon: move GETPC() calls to top level helpers

2023-07-10 Thread ltaylorsimpson
> -Original Message- > From: Matheus Tavares Bernardino > Sent: Thursday, July 6, 2023 5:23 AM > To: ltaylorsimp...@gmail.com > Cc: bc...@quicinc.com; qemu-devel@nongnu.org; > quic_mathb...@quicinc.com; quic_mlie...@quicinc.com; > richard.hender...@linaro.org > Subject: Re: [PATCH v2] H

PING: [PATCH v2 0/5] Misc fixes for throttle

2023-07-10 Thread zhenwei pi
Hi, This series has been reviewed by Alberto, can someone review / merge this? On 6/27/23 15:24, zhenwei pi wrote: v1 -> v2: - rename 'ThrottleTimerType' to 'ThrottleType' - add assertion to throttle_schedule_timer Something remained: - 'bool is_write' is no longer appropriate, the related fun

[PULL 39/66] vdpa: Return -EIO if device ack is VIRTIO_NET_ERR in _load_offloads()

2023-07-10 Thread Michael S. Tsirkin
From: Hawkins Jiawei According to VirtIO standard, "The class, command and command-specific-data are set by the driver, and the device sets the ack byte. There is little it can do except issue a diagnostic if ack is not VIRTIO_NET_OK." Therefore, QEMU should stop sending the queued SVQ commands

[PULL 01/66] vdpa: Remove status in reset tracing

2023-07-10 Thread Michael S. Tsirkin
From: Eugenio Pérez It is always 0 and it is not useful to route call through file descriptor. Reviewed-by: Stefano Garzarella Acked-by: Jason Wang Signed-off-by: Eugenio Pérez Message-Id: <20230526153736.472443-1-epere...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S.

[PULL 22/66] hw/pci-host/q35: Make some property name macros reusable by i440fx

2023-07-10 Thread Michael S. Tsirkin
From: Bernhard Beschow Signed-off-by: Bernhard Beschow Message-Id: <20230630073720.21297-7-shen...@gmail.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/i386/pc.h | 4 include/hw/pci-host/q35.h | 5 - hw/i386/pc_q35.c | 8

[PULL 63/66] vdpa: Avoid forwarding large CVQ command failures

2023-07-10 Thread Michael S. Tsirkin
From: Hawkins Jiawei Due to the size limitation of the out buffer sent to the vdpa device, which is determined by vhost_vdpa_net_cvq_cmd_len(), excessive CVQ command is truncated in QEMU. As a result, the vdpa device rejects this flawd CVQ command. However, the problem is that, the VIRTIO_NET_CT

[PULL 58/66] vdpa: Use iovec for vhost_vdpa_net_load_cmd()

2023-07-10 Thread Michael S. Tsirkin
From: Hawkins Jiawei According to VirtIO standard, "The driver MUST follow the VIRTIO_NET_CTRL_MAC_TABLE_SET command by a le32 number, followed by that number of non-multicast MAC addresses, followed by another le32 number, followed by that number of multicast addresses." Considering that these

[PULL 62/66] vdpa: Accessing CVQ header through its structure

2023-07-10 Thread Michael S. Tsirkin
From: Hawkins Jiawei We can access the CVQ header through `struct virtio_net_ctrl_hdr`, instead of accessing it through a `uint8_t` pointer, which improves the code's readability and maintainability. Signed-off-by: Hawkins Jiawei Message-Id: Reviewed-by: Michael S. Tsirkin Signed-off-by: Mic

[PULL 60/66] vdpa: Restore packet receive filtering state relative with _F_CTRL_RX feature

2023-07-10 Thread Michael S. Tsirkin
From: Hawkins Jiawei This patch introduces vhost_vdpa_net_load_rx_mode() and vhost_vdpa_net_load_rx() to restore the packet receive filtering state in relation to VIRTIO_NET_F_CTRL_RX feature at device's startup. Signed-off-by: Hawkins Jiawei Message-Id: <804cedac93e19ba3b810d52b274ca5ec11469f

[PULL 47/66] virtio-iommu: Rework the traces in virtio_iommu_set_page_size_mask()

2023-07-10 Thread Michael S. Tsirkin
From: Eric Auger The current error messages in virtio_iommu_set_page_size_mask() sound quite similar for different situations and miss the IOMMU memory region that causes the issue. Clarify them and rework the comment. Also remove the trace when the new page_size_mask is not applied as the curr

[PULL 45/66] hw/pci: warn when PCIe device is plugged into non-zero slot of downstream port

2023-07-10 Thread Michael S. Tsirkin
From: Ani Sinha PCIe downstream ports only have a single device 0, so PCI Express devices can only be plugged into slot 0 on a PCIe port. Add a warning to let users know when the invalid configuration is used. We may enforce this more strongly later once we get more clarity on whether we are intr

[PULL 20/66] hw/pci/pci_host: Introduce PCI_HOST_BYPASS_IOMMU macro

2023-07-10 Thread Michael S. Tsirkin
From: Bernhard Beschow Introduce a macro to avoid copy and pasting strings which can easily cause typos. Suggested-by: Michael S. Tsirkin Signed-off-by: Bernhard Beschow Reviewed-by: Igor Mammedov Message-Id: <20230630073720.21297-5-shen...@gmail.com> Reviewed-by: Michael S. Tsirkin Signed-o

[PULL 56/66] pcie: Use common ARI next function number

2023-07-10 Thread Michael S. Tsirkin
From: Akihiko Odaki Currently the only implementers of ARI is SR-IOV devices, and they behave similar. Share the ARI next function number. Signed-off-by: Akihiko Odaki Reviewed-by: Ani Sinha Message-Id: <20230710153838.33917-2-akihiko.od...@daynix.com> Reviewed-by: Michael S. Tsirkin Signed-o

[PULL 42/66] tests/acpi/bios-tables-test: use the correct slot on the pcie-root-port

2023-07-10 Thread Michael S. Tsirkin
From: Ani Sinha PCIE ports only have one slot, slot 0. Hence, non-zero slots are not available for PCIE devices on PCIE root ports. Fix test_acpi_q35_tcg_no_acpi_hotplug() so that the test does not use them. Signed-off-by: Ani Sinha Reviewed-by: Igor Mammedov Message-Id: <20230705115925.5339-3

[PULL 64/66] vdpa: Allow VIRTIO_NET_F_CTRL_RX in SVQ

2023-07-10 Thread Michael S. Tsirkin
From: Hawkins Jiawei Enable SVQ with VIRTIO_NET_F_CTRL_RX feature. Signed-off-by: Hawkins Jiawei Acked-by: Eugenio Pérez Message-Id: <5d6173a6d7c4c514c98362b404c019f52d73b06c.1688743107.git.yin31...@gmail.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- net/vhost-

[PULL 54/66] include/hw/virtio: add kerneldoc for virtio_init

2023-07-10 Thread Michael S. Tsirkin
From: Alex Bennée Signed-off-by: Alex Bennée Message-Id: <20230710153522.3469097-6-alex.ben...@linaro.org> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/virtio.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/hw/virtio/virtio.h b/in

[PULL 55/66] include/hw/virtio: document some more usage of notifiers

2023-07-10 Thread Michael S. Tsirkin
From: Alex Bennée Lets document some more of the core VirtIODevice structure. Signed-off-by: Alex Bennée Message-Id: <20230710153522.3469097-7-alex.ben...@linaro.org> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/virtio.h | 8 1 file changed

[PULL 48/66] pcie: Add hotplug detect state register to cmask

2023-07-10 Thread Michael S. Tsirkin
From: Leonardo Bras When trying to migrate a machine type pc-q35-6.0 or lower, with this cmdline options, -device driver=pcie-root-port,port=18,chassis=19,id=pcie-root-port18,bus=pcie.0,addr=0x12 \ -device driver=nec-usb-xhci,p2=4,p3=4,id=nex-usb-xhci0,bus=pcie-root-port18,addr=0x12.0x1 the

[PULL 46/66] virtio-iommu: Fix 64kB host page size VFIO device assignment

2023-07-10 Thread Michael S. Tsirkin
From: Eric Auger When running on a 64kB page size host and protecting a VFIO device with the virtio-iommu, qemu crashes with this kind of message: qemu-kvm: virtio-iommu page mask 0xf000 is incompatible with mask 0x2001 qemu: hardware error: vfio: DMA mapping failed, unable to co

[PULL 37/66] vdpa: Return -EIO if device ack is VIRTIO_NET_ERR in _load_mac()

2023-07-10 Thread Michael S. Tsirkin
From: Hawkins Jiawei According to VirtIO standard, "The class, command and command-specific-data are set by the driver, and the device sets the ack byte. There is little it can do except issue a diagnostic if ack is not VIRTIO_NET_OK." Therefore, QEMU should stop sending the queued SVQ commands

[PULL 43/66] tests/acpi/bios-tables-test: update acpi blob q35/DSDT.noacpihp

2023-07-10 Thread Michael S. Tsirkin
From: Ani Sinha Some fixes were committed in bios-tables-test in the previous commit. Update the acpi blob and clear bios-tables-test-allowed-diff.h so that the test continues to pass with the changes in the bios-tables-test. Following is the asl diff between the old and the newly updated blob:

[PULL 52/66] hw/virtio: fix typo in VIRTIO_CONFIG_IRQ_IDX comments

2023-07-10 Thread Michael S. Tsirkin
From: Alex Bennée Fixes: 544f0278af (virtio: introduce macro VIRTIO_CONFIG_IRQ_IDX) Signed-off-by: Alex Bennée Message-Id: <20230710153522.3469097-4-alex.ben...@linaro.org> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/display/vhost-user-gpu.c| 4 ++-- hw/net/vi

[PULL 51/66] include/hw: document the device_class_set_parent_* fns

2023-07-10 Thread Michael S. Tsirkin
From: Alex Bennée These are useful functions for when you want proper inheritance of functionality across realize/unrealize calls. Signed-off-by: Alex Bennée Message-Id: <20230710153522.3469097-3-alex.ben...@linaro.org> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- in

[PULL 14/66] hw/smbios: Fix core count in type4

2023-07-10 Thread Michael S. Tsirkin
From: Zhao Liu >From SMBIOS 3.0 specification, core count field means: Core Count is the number of cores detected by the BIOS for this processor socket. [1] Before 003f230e37d7 ("machine: Tweak the order of topology members in struct CpuTopology"), MachineState.smp.cores means "the number of co

[PULL 18/66] hw/pci-host/q35: Fix double, contradicting .endianness assignment

2023-07-10 Thread Michael S. Tsirkin
From: Bernhard Beschow Fixes the following clangd warning (-Winitializer-overrides): q35.c:297:19: Initializer overrides prior initialization of this subobject q35.c:292:19: previous initialization is here Settle on little endian which is consistent with using pci_host_conf_le_ops. Fixes:

[PULL 35/66] hw/pci/pci: Remove multifunction parameter from pci_new_multifunction()

2023-07-10 Thread Michael S. Tsirkin
From: Bernhard Beschow There is also pci_new() which creates non-multifunction PCI devices. Accordingly the parameter is always set to true when a multi function PCI device is to be created. The reason for the parameter's existence seems to be that it is used in the internal PCI code as well whi

[PULL 44/66] tests/qtest/hd-geo-test: fix incorrect pcie-root-port usage and simplify test

2023-07-10 Thread Michael S. Tsirkin
From: Ani Sinha The test attaches a SCSI controller to a non-zero slot and a pcie-to-pci bridge on slot 0 on the same pcie-root-port. Since a downstream device can be attached to a pcie-root-port only on slot 0, the above test configuration is not allowed. Additionally using pcie.0 as id for pcie

[PULL 50/66] include: attempt to document device_class_set_props

2023-07-10 Thread Michael S. Tsirkin
From: Alex Bennée I'm still not sure how I achieve by use case of the parent class defining the following properties: static Property vud_properties[] = { DEFINE_PROP_CHR("chardev", VHostUserDevice, chardev), DEFINE_PROP_UINT16("id", VHostUserDevice, id, 0), DEFINE_PROP_UINT3

[PULL 65/66] vdpa: Restore packet receive filtering state relative with _F_CTRL_RX_EXTRA feature

2023-07-10 Thread Michael S. Tsirkin
From: Hawkins Jiawei This patch refactors vhost_vdpa_net_load_rx() to restore the packet receive filtering state in relation to VIRTIO_NET_F_CTRL_RX_EXTRA feature at device's startup. Signed-off-by: Hawkins Jiawei Message-Id: Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

[PULL 05/66] docs: vhost-user-gpu: add protocol changes for EDID

2023-07-10 Thread Michael S. Tsirkin
From: Erico Nunes VHOST_USER_GPU_GET_EDID is defined as a message from the backend to the frontend to retrieve the EDID data for a given scanout. The VHOST_USER_GPU_PROTOCOL_F_EDID protocol feature is defined as a way to check whether this new message is supported or not. Signed-off-by: Erico N

[PULL 27/66] hw/pci-host/i440fx: Move i440fx_realize() into PCII440FXState section

2023-07-10 Thread Michael S. Tsirkin
From: Bernhard Beschow i440fx_realize() realizes the PCI device inside the host bridge (PCII440FXState), but is implemented between i440fx_pcihost_realize() and i440fx_init() which deal with the host bridge itself (I440FXState). Since we want to append i440fx_init() to i440fx_pcihost_realize() la

[PULL 08/66] hw/virtio: Add boilerplate for vhost-user-scmi device

2023-07-10 Thread Michael S. Tsirkin
From: Milan Zamazal This creates the QEMU side of the vhost-user-scmi device which connects to the remote daemon. It is based on code of similar vhost-user devices. Signed-off-by: Milan Zamazal Message-Id: <20230628100524.342666-2-mzama...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-of

[PULL 49/66] vdpa: Fix possible use-after-free for VirtQueueElement

2023-07-10 Thread Michael S. Tsirkin
From: Hawkins Jiawei QEMU uses vhost_handle_guest_kick() to forward guest's available buffers to the vdpa device in SVQ avail ring. In vhost_handle_guest_kick(), a `g_autofree` `elem` is used to iterate through the available VirtQueueElements. This `elem` is then passed to `svq->ops->avail_handl

[PULL 34/66] hw/pci/pci: Remove multifunction parameter from pci_create_simple_multifunction()

2023-07-10 Thread Michael S. Tsirkin
From: Bernhard Beschow There is also pci_create_simple() which creates non-multifunction PCI devices. Accordingly the parameter is always set to true when a multi function PCI device is to be created. The reason for the parameter's existence seems to be that it is used in the internal PCI code a

[PULL 53/66] include/hw/virtio: document virtio_notify_config

2023-07-10 Thread Michael S. Tsirkin
From: Alex Bennée Signed-off-by: Alex Bennée Message-Id: <20230710153522.3469097-5-alex.ben...@linaro.org> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/virtio.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/hw/virtio/virtio.h b/i

[PULL 31/66] hw/pci-host/i440fx: Add I440FX_HOST_PROP_PCI_TYPE property

2023-07-10 Thread Michael S. Tsirkin
From: Bernhard Beschow I440FX needs a different PCI device model if the "igd-passthru" property is enabled. The type name is currently passed as a parameter to i440fx_init(). This parameter will be replaced by a property assignment once i440fx_init() gets resolved. Signed-off-by: Bernhard Bescho

[PULL 29/66] hw/pci-host/i440fx: Add PCI_HOST_PROP_IO_MEM property

2023-07-10 Thread Michael S. Tsirkin
From: Bernhard Beschow Introduce the property in anticipation of QOM'ification; Q35 has the same property. Signed-off-by: Bernhard Beschow Message-Id: <20230630073720.21297-14-shen...@gmail.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/pci-host/i440fx.c | 14 +

[PULL 57/66] pcie: Specify 0 for ARI next function numbers

2023-07-10 Thread Michael S. Tsirkin
From: Akihiko Odaki The current implementers of ARI are all SR-IOV devices. The ARI next function number field is undefined for VF according to PCI Express Base Specification Revision 5.0 Version 1.0 section 9.3.7.7. The PF still requires some defined value so end the linked list formed with the

[PULL 38/66] vdpa: Return -EIO if device ack is VIRTIO_NET_ERR in _load_mq()

2023-07-10 Thread Michael S. Tsirkin
From: Hawkins Jiawei According to VirtIO standard, "The class, command and command-specific-data are set by the driver, and the device sets the ack byte. There is little it can do except issue a diagnostic if ack is not VIRTIO_NET_OK." Therefore, QEMU should stop sending the queued SVQ commands

[PULL 61/66] vhost: Fix false positive out-of-bounds

2023-07-10 Thread Michael S. Tsirkin
From: Hawkins Jiawei QEMU uses vhost_svq_translate_addr() to translate addresses between the QEMU's virtual address and the SVQ IOVA. In order to validate this translation, QEMU checks whether the translated range falls within the mapped range. Yet the problem is that, the value of `needle_last`

[PULL 66/66] vdpa: Allow VIRTIO_NET_F_CTRL_RX_EXTRA in SVQ

2023-07-10 Thread Michael S. Tsirkin
From: Hawkins Jiawei Enable SVQ with VIRTIO_NET_F_CTRL_RX_EXTRA feature. Signed-off-by: Hawkins Jiawei Acked-by: Eugenio Pérez Message-Id: <15ecc49975f9b8d1316ed4296879564a18abf31e.1688797728.git.yin31...@gmail.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- net/

[PULL 26/66] hw/pci-host/i440fx: Have common names for some local variables

2023-07-10 Thread Michael S. Tsirkin
From: Bernhard Beschow `PCIHostState` is often referred to as `phb`, own device state usually as `s`. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230630073720.21297-11-shen...@gmail.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

[PULL 59/66] vdpa: Restore MAC address filtering state

2023-07-10 Thread Michael S. Tsirkin
From: Hawkins Jiawei This patch refactors vhost_vdpa_net_load_mac() to restore the MAC address filtering state at device's startup. Signed-off-by: Hawkins Jiawei Message-Id: <4b9550c14bc8c98c8f48e04dbf3d3ac41489d3fd.1688743107.git.yin31...@gmail.com> Reviewed-by: Michael S. Tsirkin Signed-off

[PULL 36/66] pcie: Release references of virtual functions

2023-07-10 Thread Michael S. Tsirkin
From: Akihiko Odaki pci_new() automatically retains a reference to a virtual function when registering it so we need to release the reference when unregistering. Fixes: 7c0fa8dff8 ("pcie: Add support for Single Root I/O Virtualization (SR/IOV)") Signed-off-by: Akihiko Odaki Message-Id: <202304

[PULL 24/66] hw/pci-host/i440fx: Add "i440fx" child property in board code

2023-07-10 Thread Michael S. Tsirkin
From: Bernhard Beschow The parent-child relation is usually established near a child's qdev_new(). For i440fx this allows for reusing the machine parameter, thus avoiding qdev_get_machine() which relies on a global variable. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Bernhard Beschow

[PULL 19/66] hw/pci-host/q35: Initialize PCMachineState::bus in board code

2023-07-10 Thread Michael S. Tsirkin
From: Bernhard Beschow The Q35 PCI host currently sets the PC machine's PCI bus attribute through global state, thereby assuming the machine to be a PC machine. The Q35 machine code already holds on to Q35's pci bus attribute, so can easily set its own property while preserving encapsulation. Si

[PULL 02/66] vhost: register and change IOMMU flag depending on Device-TLB state

2023-07-10 Thread Michael S. Tsirkin
From: Viktor Prutyanov The guest can disable or never enable Device-TLB. In these cases, it can't be used even if enabled in QEMU. So, check Device-TLB state before registering IOMMU notifier and select unmap flag depending on that. Also, implement a way to change IOMMU notifier flag if Device-TL

[PULL 25/66] hw/pci-host/i440fx: Replace magic values by existing constants

2023-07-10 Thread Michael S. Tsirkin
From: Bernhard Beschow Signed-off-by: Bernhard Beschow Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230630073720.21297-10-shen...@gmail.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/pci-host/i440fx.c | 8 1 file chang

[PULL 15/66] vhost-user: Change one_time to per_device request

2023-07-10 Thread Michael S. Tsirkin
From: Tom Lonergan Some devices, like virtio-scsi, consist of one vhost_dev, while others, like virtio-net, contain multiple vhost_devs. The QEMU vhost-user code has a concept of one-time messages which is misleading. One-time messages are sent once per operation on the device, not once for the l

[PULL 40/66] vhost-vdpa: mute unaligned memory error report

2023-07-10 Thread Michael S. Tsirkin
From: Laurent Vivier With TPM CRM device, vhost-vdpa reports an error when it tries to register a listener for a non aligned memory region: qemu-system-x86_64: vhost_vdpa_listener_region_add received unaligned region qemu-system-x86_64: vhost_vdpa_listener_region_del received unaligned regio

[PULL 17/66] hw/i386/pc_q35: Resolve redundant q35_host variable

2023-07-10 Thread Michael S. Tsirkin
From: Bernhard Beschow The variable is redundant to "phb" and is never used by its real type. Signed-off-by: Bernhard Beschow Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230630073720.21297-2-shen...@gmail.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Mic

[PULL 32/66] hw/pci-host/i440fx: Resolve i440fx_init()

2023-07-10 Thread Michael S. Tsirkin
From: Bernhard Beschow i440fx_init() is a legacy init function. The previous patches worked towards TYPE_I440FX_PCI_HOST_BRIDGE to be instantiated the QOM way. Do this now by transforming the parameters passed to i440fx_init() into property assignments. Signed-off-by: Bernhard Beschow Message-I

[PULL 41/66] tests/acpi: allow changes in DSDT.noacpihp table blob

2023-07-10 Thread Michael S. Tsirkin
From: Ani Sinha We are going to fix bio-tables-test in the next patch and hence need to make sure the acpi tests continue to pass. Signed-off-by: Ani Sinha Acked-by: Igor Mammedov Message-Id: <20230705115925.5339-2-anisi...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S.

[PULL 11/66] machine: Add helpers to get cores/threads per socket

2023-07-10 Thread Michael S. Tsirkin
From: Zhao Liu The number of cores/threads per socket are needed for smbios, and are also useful for other modules. Provide the helpers to wrap the calculation of cores/threads per socket so that we can avoid calculation errors caused by other modules miss topology changes. Suggested-by: Igor M

[PULL 33/66] hw/i386/pc_piix: Move i440fx' realize near its qdev_new()

2023-07-10 Thread Michael S. Tsirkin
From: Bernhard Beschow I440FX realization is currently mixed with PIIX3 creation. Furthermore, it is common practice to only set properties between a device's qdev_new() and qdev_realize(). Clean up to resolve both issues. Since I440FX spawns a PCI bus let's also move the pci_bus initialization

[PULL 07/66] vhost-user-gpu: implement get_edid frontend feature

2023-07-10 Thread Michael S. Tsirkin
From: Erico Nunes Implement the frontend side of the get_edid feature in the qemu vhost-user-gpu frontend device. Signed-off-by: Erico Nunes Reviewed-by: Marc-André Lureau Message-Id: <20230626164708.1163239-5-ernu...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirk

[PULL 28/66] hw/pci-host/i440fx: Make MemoryRegion pointers accessible as properties

2023-07-10 Thread Michael S. Tsirkin
From: Bernhard Beschow The goal is to eliminate i440fx_init() which is a legacy init function. This neccessitates the memory regions to be properties, like in Q35, which will be assigned in board code. Since i440fx needs different PCI devices in Xen mode, and since i440fx shall be self-contained

[PULL 13/66] hw/smbios: Fix thread count in type4

2023-07-10 Thread Michael S. Tsirkin
From: Zhao Liu >From SMBIOS 3.0 specification, thread count field means: Thread Count is the total number of threads detected by the BIOS for this processor socket. It is a processor-wide count, not a thread-per-core count. [1] So here we should use threads per socket other than threads per cor

[PULL 30/66] hw/pci-host/i440fx: Add PCI_HOST_{ABOVE, BELOW}_4G_MEM_SIZE properties

2023-07-10 Thread Michael S. Tsirkin
From: Bernhard Beschow Introduce the properties in anticipation of QOM'ification; Q35 has the same properties. Note that we want to avoid a "ram size" property in the QOM interface since it seems redundant to both properties introduced in this change. Thus the removal of the ram_size parameter.

[PULL 21/66] hw/pci-host/q35: Initialize PCI_HOST_BYPASS_IOMMU property from board code

2023-07-10 Thread Michael S. Tsirkin
From: Bernhard Beschow The Q35 PCI host already has a PCI_HOST_BYPASS_IOMMU property. However, the host initializes this property itself by accessing global machine state, thereby assuming it to be a PC machine. Avoid this by having board code set this property. Signed-off-by: Bernhard Beschow

[PULL 23/66] hw/i386/pc_piix: Turn some local variables into initializers

2023-07-10 Thread Michael S. Tsirkin
From: Bernhard Beschow Eliminates an else branch. Suggested-by: Igor Mammedov Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230630073720.21297-8-shen...@gmail.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/pc_piix.c |

[PULL 06/66] contrib/vhost-user-gpu: implement get_edid feature

2023-07-10 Thread Michael S. Tsirkin
From: Erico Nunes Implement the virtio-gpu feature in contrib/vhost-user-gpu, which was unsupported until now. In this implementation, the feature is enabled inconditionally to avoid creating another optional config argument. Similarly to get_display_info, vhost-user-gpu sends a message back to t

[PULL 16/66] vhost-user: Make RESET_DEVICE a per device message

2023-07-10 Thread Michael S. Tsirkin
From: Tom Lonergan A device reset is issued per device, not per VQ. The legacy device reset message, VHOST_USER_RESET_OWNER, is already a per device message. Therefore, this change adds the proper message, VHOST_USER_RESET_DEVICE, to per device messages. Signed-off-by: Tom Lonergan Message-Id:

[PULL 09/66] hw/virtio: Add vhost-user-scmi-pci boilerplate

2023-07-10 Thread Michael S. Tsirkin
From: Milan Zamazal This allows is to instantiate a vhost-user-scmi device as part of a PCI bus. It is mostly boilerplate similar to the other vhost-user-*-pci boilerplates of similar devices. Signed-off-by: Milan Zamazal Message-Id: <20230628100524.342666-3-mzama...@redhat.com> Reviewed-by: Mi

[PULL 10/66] tests/qtest: enable tests for virtio-scmi

2023-07-10 Thread Michael S. Tsirkin
From: Milan Zamazal We don't have a virtio-scmi implementation in QEMU and only support a vhost-user backend. This is very similar to virtio-gpio and we add the same set of tests, just passing some vhost-user messages over the control socket. Signed-off-by: Milan Zamazal Acked-by: Thomas Huth

[PULL 04/66] virtio-gpu: refactor generate_edid function to virtio_gpu_base

2023-07-10 Thread Michael S. Tsirkin
From: Erico Nunes This functionality can be shared with upcoming use in vhost-user-gpu, so move it to the shared file to avoid duplicating it. Signed-off-by: Erico Nunes Reviewed-by: Marc-André Lureau Message-Id: <20230626164708.1163239-2-ernu...@redhat.com> Reviewed-by: Michael S. Tsirkin Si

[PULL 12/66] hw/smbios: Fix smbios_smp_sockets caculation

2023-07-10 Thread Michael S. Tsirkin
From: Zhao Liu smp.sockets is the number of sockets which is configured by "-smp" ( otherwise, the default is 1). Trying to recalculate it here with another rules leads to errors, such as: 1. 003f230e37d7 ("machine: Tweak the order of topology members in struct CpuTopology") changes the meani

[PULL 00/66] pc,pci,virtio: cleanups, fixes, features

2023-07-10 Thread Michael S. Tsirkin
The following changes since commit fcb237e64f9d026c03d635579c7b288d0008a6e5: Merge tag 'pull-vfio-20230710' of https://github.com/legoater/qemu into staging (2023-07-10 09:17:06 +0100) are available in the Git repository at: https://git.kernel.org/pub/scm/virt/kvm/mst/qem

[PULL 03/66] virtio-net: pass Device-TLB enable/disable events to vhost

2023-07-10 Thread Michael S. Tsirkin
From: Viktor Prutyanov If vhost is enabled for virtio-net, Device-TLB enable/disable events must be passed to vhost for proper IOMMU unmap flag selection. Signed-off-by: Viktor Prutyanov Acked-by: Jason Wang Message-Id: <20230626091258.24453-3-vik...@daynix.com> Reviewed-by: Michael S. Tsirkin

Re: [PULL 00/54] riscv-to-apply queue

2023-07-10 Thread Richard Henderson
On 7/10/23 13:31, Alistair Francis wrote: The following changes since commit fcb237e64f9d026c03d635579c7b288d0008a6e5: Merge tag 'pull-vfio-20230710' ofhttps://github.com/legoater/qemu into staging (2023-07-10 09:17:06 +0100) are available in the Git repository at: https://

  1   2   3   4   5   >