Re: [PATCH v2 2/5] disas: Remove target_ulong from the interface

2023-05-09 Thread Thomas Huth
On 09/05/2023 18.33, Richard Henderson wrote: Use uint64_t for the pc, and size_t for the size. Signed-off-by: Richard Henderson Message-Id: <20230503072331.1747057-81-richard.hender...@linaro.org> --- include/disas/disas.h | 17 ++--- bsd-user/elfload.c| 5 +++-- disas/dis

Re: [PATCH v2 0/5] Make the core disassembler functions target-independent

2023-05-09 Thread Thomas Huth
On 09/05/2023 18.33, Richard Henderson wrote: Merges Thomas' RFC patch set with part of my "build-tcg-once" patch set. The only real change from Thomas' is to use uint64_t instead of hwaddr. Thanks for integrating it! There's a minor nit in patch 5, but apart from that, I think this series is

Re: [PATCH v2 5/5] disas: Move disas.c into the target-independent source set

2023-05-09 Thread Thomas Huth
On 09/05/2023 18.33, Richard Henderson wrote: From: Thomas Huth By using target_words_bigendian() instead of an ifdef, we can build this code once. Signed-off-by: Thomas Huth [rth: Type change done in a separate patch] Signed-off-by: Richard Henderson --- ... diff --git a/disas/meson.build

Re: [PATCH v1 1/1] s390x/pv: Fix spurious warning with asynchronous teardown

2023-05-09 Thread Thomas Huth
On 09/05/2023 18.27, Claudio Imbrenda wrote: When rebooting a small VM using asynchronous teardown, a spurious warning is emitted when the KVM_PV_ASYNC_CLEANUP_PREPARE ioctl fails. Why does the _PREPARE fail in that case? Why 4GiB and not more or less? This sounds racy... what if you have a fa

Re: [PATCH v2 0/2] tests/lcitool: Add mtools and xorriso and remove genisoimage as dependencies

2023-05-09 Thread Michael S. Tsirkin
On Wed, May 10, 2023 at 08:39:54AM +0200, Thomas Huth wrote: > On 09/05/2023 18.16, Michael S. Tsirkin wrote: > > On Thu, May 04, 2023 at 09:16:09PM +0530, Ani Sinha wrote: > > > mformat and xorriso tools are needed by biosbits avocado tests. This > > > patchset > > > adds those two tools in the d

Re: [PATCH v2 0/2] tests/lcitool: Add mtools and xorriso and remove genisoimage as dependencies

2023-05-09 Thread Thomas Huth
On 09/05/2023 18.16, Michael S. Tsirkin wrote: On Thu, May 04, 2023 at 09:16:09PM +0530, Ani Sinha wrote: mformat and xorriso tools are needed by biosbits avocado tests. This patchset adds those two tools in the docker container images. xorriso package conflicts with genisoimage package on some

RE: [PATCH] intel-iommu: Set status bit after operation completed

2023-05-09 Thread Duan, Zhenzhong
>-Original Message- >From: Michael S. Tsirkin >Sent: Wednesday, May 10, 2023 2:29 PM >To: Duan, Zhenzhong >Cc: qemu-devel@nongnu.org; pet...@redhat.com; jasow...@redhat.com; >pbonz...@redhat.com; richard.hender...@linaro.org; edua...@habkost.net; >marcel.apfelb...@gmail.com >Subject: Re

Re: css_clear_io_interrupt() error handling

2023-05-09 Thread Markus Armbruster
Halil Pasic writes: > On Mon, 08 May 2023 11:01:55 +0200 > Cornelia Huck wrote: > >> On Mon, May 08 2023, Markus Armbruster wrote: >> >> > css_clear_io_interrupt() aborts on unexpected ioctl() errors, and I >> > wonder whether that's appropriate. Let's have a closer look: > > Just for my unde

Re: [PATCH] migration: for snapshots, hold the BQL during setup callbacks

2023-05-09 Thread Juan Quintela
Peter Xu wrote: Hi [Adding Kevin to the party] > On Fri, May 05, 2023 at 03:46:52PM +0200, Fiona Ebner wrote: >> To fix it, ensure that the BQL is held during setup. To avoid changing >> the behavior for migration too, introduce conditionals for the setup >> callbacks that need the BQL and only

Re: [PATCH] intel-iommu: Set status bit after operation completed

2023-05-09 Thread Michael S. Tsirkin
On Thu, Mar 09, 2023 at 05:23:19PM +0800, Zhenzhong Duan wrote: > According to SDM 11.4.4.2 Global Status Register: > "This field is cleared by hardware when software sets the SRTP field in the > Global Command register. This field is set by hardware when hardware > completes the ‘Set Root Table Po

[PATCH HOTFIX] target/loongarch: Terminate vmstate subsections list

2023-05-09 Thread Richard Henderson
This list requires a NULL terminator. Fixes: 16f5396cec23 ("target/loongarch: Add LSX data type VReg") Signed-off-by: Richard Henderson --- This failure can be seen https://gitlab.com/qemu-project/qemu/-/jobs/4253259728#L5579 5/789 qemu:qtest+qtest-loongarch64 / qtest-loongarch64/qom-test

[PATCH v16 1/4] vhost: expose function vhost_dev_has_iommu()

2023-05-09 Thread Cindy Lu
To support vIOMMU in vdpa, need to exposed the function vhost_dev_has_iommu, vdpa will use this function to check if vIOMMU enable. Signed-off-by: Cindy Lu --- hw/virtio/vhost.c | 2 +- include/hw/virtio/vhost.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/virt

[PATCH v16 4/4] vhost-vdpa: Add support for vIOMMU.

2023-05-09 Thread Cindy Lu
1. The vIOMMU support will make vDPA can work in IOMMU mode. This will fix security issues while using the no-IOMMU mode. To support this feature we need to add new functions for IOMMU MR adds and deletes. Also since the SVQ does not support vIOMMU yet, add the check for IOMMU in vhost_vdpa_dev_st

[PATCH v16 3/4] vhost-vdpa: Add check for full 64-bit in region delete

2023-05-09 Thread Cindy Lu
The unmap ioctl doesn't accept a full 64-bit span. So need to add check for the section's size in vhost_vdpa_listener_region_del(). Signed-off-by: Cindy Lu --- hw/virtio/vhost-vdpa.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/hw/virtio/vhost-vdpa.c b

[PATCH v16 0/4] vhost-vdpa: add support for vIOMMU

2023-05-09 Thread Cindy Lu
These patches are to support vIOMMU in vdpa device changes in V3 1. Move function vfio_get_xlat_addr to memory.c 2. Use the existing memory listener, while the MR is iommu MR then call the function iommu_region_add/ iommu_region_del changes in V4 1.make the comments in vfio_get_xlat_addr more gen

[PATCH v16 2/4] vhost_vdpa: fix the input in trace_vhost_vdpa_listener_region_del()

2023-05-09 Thread Cindy Lu
In trace_vhost_vdpa_listener_region_del, the value for llend should change to int128_get64(int128_sub(llend, int128_one())) Signed-off-by: Cindy Lu --- hw/virtio/vhost-vdpa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c ind

Re: [PULL 00/16] Misc patches for 2023-05-09

2023-05-09 Thread Richard Henderson
On 5/9/23 10:04, Paolo Bonzini wrote: The following changes since commit 792f77f376adef944f9a03e601f6ad90c2f891b2: Merge tag 'pull-loongarch-20230506' ofhttps://gitlab.com/gaosong/qemu into staging (2023-05-06 08:11:52 +0100) are available in the Git repository at: https://gitlab.com/b

Re: [PATCH 1/1] e1000e: Fix tx/rx counters

2023-05-09 Thread Jason Wang
在 2023/4/10 23:33, Akihiko Odaki 写道: On 2023/04/11 0:27, timothee.coca...@gmail.com wrote: The bytes and packets counter registers are cleared on read. Copying the "total counter" registers to the "good counter" registers has side effects. If the "total" register is never read by the OS, it

[PATCH] target/riscv: Move zc* out of the experimental properties

2023-05-09 Thread Weiwei Li
Zc* extensions (version 1.0) are ratified. Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/cpu.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index db0875fb43..99ed9cb80e 100644 --- a/target/r

Re: [PATCH RESEND] vhost: fix possible wrap in SVQ descriptor ring

2023-05-09 Thread Lei Yang
QE applied this patch to do sanity testing on vhost-net, there is no any regression problem. Tested-by: Lei Yang On Tue, May 9, 2023 at 1:28 AM Eugenio Perez Martin wrote: > > On Sat, May 6, 2023 at 5:01 PM Hawkins Jiawei wrote: > > > > QEMU invokes vhost_svq_add() when adding a guest's elem

Re: [PATCH v2] piix: fix regression during unplug in Xen HVM domUs

2023-05-09 Thread Olaf Hering
Resuming this old thread about an unfixed bug, which was introduced in qemu-4.2: qemu ends up in piix_ide_reset from pci_unplug_disks. This was not the case prior 4.2, the removed call to qemu_register_reset(piix3_reset, d) in ee358e919e385fdc79d59d0d47b4a81e349cd5c9 did apparently nothing. In my

Re: [SeaBIOS] [PATCH v3 0/6] misc tweaks for kvm and the 64bit pci window

2023-05-09 Thread Kevin O'Connor
On Fri, May 05, 2023 at 09:11:11AM +0200, Gerd Hoffmann wrote: > v3 changes: > - rename variables, use u8 for CPULongMode. > v2 changes: > - e820 conflict fix Thanks. Looks fine to me. -Kevin > > Gerd Hoffmann (6): > better kvm detection > detect physical address space size > move 64b

[PULL 3/3] vfio/pci: Static Resizable BAR capability

2023-05-09 Thread Alex Williamson
The PCI Resizable BAR (ReBAR) capability is currently hidden from the VM because the protocol for interacting with the capability does not support a mechanism for the device to reject an advertised supported BAR size. However, when assigned to a VM, the act of resizing the BAR requires adjustment

[PULL 0/3] VFIO updates 2023-05-09

2023-05-09 Thread Alex Williamson
The following changes since commit 271477b59e723250f17a7e20f139262057921b6a: Merge tag 'compression-code-pull-request' of https://gitlab.com/juan.quintela/qemu into staging (2023-05-08 20:38:05 +0100) are available in the Git repository at: https://gitlab.com/alex.williamson/qemu.git tags/v

[PULL 1/3] vfio/pci: add support for VF token

2023-05-09 Thread Alex Williamson
From: Minwoo Im VF token was introduced [1] to kernel vfio-pci along with SR-IOV support [2]. This patch adds support VF token among PF and VF(s). To passthu PCIe VF to a VM, kernel >= v5.7 needs this. It can be configured with UUID like: -device vfio-pci,host=:BB:DD:F,vf-token=,... [1]

[PULL 2/3] vfio/migration: Skip log_sync during migration SETUP state

2023-05-09 Thread Alex Williamson
From: Avihai Horon Currently, VFIO log_sync can be issued while migration is in SETUP state. However, doing this log_sync is at best redundant and at worst can fail. Redundant -- all RAM is marked dirty in migration SETUP state and is transferred only after migration is set to ACTIVE state, so d

Re: [PATCH 11/11] cutils: Improve qemu_strtosz handling of fractions

2023-05-09 Thread Eric Blake
On Tue, May 09, 2023 at 07:54:30PM +0200, Hanna Czenczek wrote: > On 08.05.23 22:03, Eric Blake wrote: > > We have several limitations and bugs worth fixing; they are > > inter-related enough that it is not worth splitting this patch into > > smaller pieces: > > > > * ".5k" should work to specify

RE: [PATCH] Remove test_vshuff from hvx_misc tests

2023-05-09 Thread Taylor Simpson
> -Original Message- > From: Brian Cain > Sent: Tuesday, May 9, 2023 3:01 PM > To: Taylor Simpson ; Marco Liebel (QUIC) > ; qemu-devel@nongnu.org > Cc: Matheus Bernardino (QUIC) > Subject: RE: [PATCH] Remove test_vshuff from hvx_misc tests > > > > > -Original Message- > > Fr

Re: [PATCH v5 05/21] virtio-scsi: stop using aio_disable_external() during unplug

2023-05-09 Thread Stefan Hajnoczi
On Tue, May 09, 2023 at 08:55:14PM +0200, Kevin Wolf wrote: > Am 04.05.2023 um 21:53 hat Stefan Hajnoczi geschrieben: > > This patch is part of an effort to remove the aio_disable_external() > > API because it does not fit in a multi-queue block layer world where > > many AioContexts may be submitt

Re: ssl fips self check fails with 7.2.0 on x86 TCG

2023-05-09 Thread Patrick Venture
On Tue, May 9, 2023 at 9:51 AM Michael Tokarev wrote: > 09.05.2023 17:39, Philippe Mathieu-Daudé пишет: > ..> Should be fixed in v7.2-stable: > > > > $ git log --oneline --grep=1d0b9261 v7.2.2 > > c45d10f655 target/i386: fix ADOX followed by ADCX > > 6809dbc5c5 target/i386: Fix C flag for BLSI, B

RE: [PATCH] Remove test_vshuff from hvx_misc tests

2023-05-09 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Tuesday, May 9, 2023 2:28 PM > To: Marco Liebel (QUIC) ; qemu- > de...@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > > Subject: RE: [PATCH] Remove test_vshuff from hvx_misc tests > > > > > -Original Message- > >

RE: [PATCH] Remove test_vshuff from hvx_misc tests

2023-05-09 Thread Brian Cain
> -Original Message- > From: Marco Liebel (QUIC) > Sent: Tuesday, May 9, 2023 1:43 PM > To: qemu-devel@nongnu.org > Cc: Taylor Simpson ; Brian Cain ; > Matheus Bernardino (QUIC) ; Marco Liebel > (QUIC) > Subject: [PATCH] Remove test_vshuff from hvx_misc tests > > test_vshuff checks th

RE: [PATCH] Remove test_vshuff from hvx_misc tests

2023-05-09 Thread Taylor Simpson
> -Original Message- > From: Marco Liebel (QUIC) > Sent: Tuesday, May 9, 2023 1:43 PM > To: qemu-devel@nongnu.org > Cc: Taylor Simpson ; Brian Cain > ; Matheus Bernardino (QUIC) > ; Marco Liebel (QUIC) > > Subject: [PATCH] Remove test_vshuff from hvx_misc tests > > test_vshuff checks

Re: [PATCH 0/2] gitlab: improve artifact handling

2023-05-09 Thread Juan Quintela
Daniel P. Berrangé wrote: > We are missing test log artifacts from various check jobs on failure, > and also missing test logs from the coverage job > > Daniel P. Berrangé (2): > gitlab: explicit set artifacts publishing criteria > gitlab: ensure coverage job also publishes meson log > > .git

[PULL 06/10] build: move COLO under CONFIG_REPLICATION

2023-05-09 Thread Juan Quintela
From: Vladimir Sementsov-Ogievskiy We don't allow to use x-colo capability when replication is not configured. So, no reason to build COLO when replication is disabled, it's unusable in this case. Note also that the check in migrate_caps_check() is not the only restriction: some functions in mig

[PULL 09/10] migration: disallow change capabilities in COLO state

2023-05-09 Thread Juan Quintela
From: Vladimir Sementsov-Ogievskiy COLO is not listed as running state in migrate_is_running(), so, it's theoretically possible to disable colo capability in COLO state and the unexpected error in migration_iteration_finish() is reachable. Let's disallow that in qmp_migrate_set_capabilities. Tha

[PULL 03/10] multifd: Add the ramblock to MultiFDRecvParams

2023-05-09 Thread Juan Quintela
From: Lukas Straub This will be used in the next commits to add colo support to multifd. Signed-off-by: Lukas Straub Reviewed-by: Juan Quintela Message-Id: <88135197411df1a71d7832962b39abf60faf0021.1683572883.git.lukasstra...@web.de> Signed-off-by: Juan Quintela --- migration/multifd.c | 11

[PULL 07/10] migration: drop colo_incoming_thread from MigrationIncomingState

2023-05-09 Thread Juan Quintela
From: Vladimir Sementsov-Ogievskiy have_colo_incoming_thread variable is unused. colo_incoming_thread can be local. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Juan Quintela Reviewed-by: Peter Xu Reviewed-by: Zhang Chen Message-Id: <20230428194928.1426370-6-vsement...@yandex-tea

[PULL 10/10] migration: block incoming colo when capability is disabled

2023-05-09 Thread Juan Quintela
From: Vladimir Sementsov-Ogievskiy We generally require same set of capabilities on source and target. Let's require x-colo capability to use COLO on target. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Juan Quintela Reviewed-by: Peter Xu Reviewed-by: Lukas Straub Reviewed-by: Zh

[PULL 08/10] migration: process_incoming_migration_co: simplify code flow around ret

2023-05-09 Thread Juan Quintela
From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Juan Quintela Reviewed-by: Peter Xu Reviewed-by: Zhang Chen Message-Id: <20230428194928.1426370-7-vsement...@yandex-team.ru> Signed-off-by: Juan Quintela --- migration/migration.c | 11 ++- 1

[PULL 02/10] ram: Let colo_flush_ram_cache take the bitmap_mutex

2023-05-09 Thread Juan Quintela
From: Lukas Straub This is not required, colo_flush_ram_cache does not run concurrently with the multifd threads since the cache is only flushed after everything has been received. But it makes me more comfortable. This will be used in the next commits to add colo support to multifd. Signed-off

[PULL 00/10] Migration 20230509 patches

2023-05-09 Thread Juan Quintela
u.git tags/migration-20230509-pull-request for you to fetch changes up to 5f43d297bc2b9530805ad8602c6e2ea284b08628: migration: block incoming colo when capability is disabled (2023-05-09 20:52:21 +0200) Migration Pull request

[PULL 04/10] block/meson.build: prefer positive condition for replication

2023-05-09 Thread Juan Quintela
From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Juan Quintela Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Lukas Straub Reviewed-by: Zhang Chen Message-Id: <20230428194928.1426370-2-vsement...@yandex-team.ru> Signed-off-by: Juan Quintela ---

[PULL 05/10] colo: make colo_checkpoint_notify static and provide simpler API

2023-05-09 Thread Juan Quintela
From: Vladimir Sementsov-Ogievskiy colo_checkpoint_notify() is mostly used in colo.c. Outside we use it once when x-checkpoint-delay migration parameter is set. So, let's simplify the external API to only that function - notify COLO that parameter was set. This make external API more robust and h

[PULL 01/10] ram: Add public helper to set colo bitmap

2023-05-09 Thread Juan Quintela
From: Lukas Straub The overhead of the mutex in non-multifd mode is negligible, because in that case its just the single thread taking the mutex. This will be used in the next commits to add colo support to multifd. Signed-off-by: Lukas Straub Reviewed-by: Juan Quintela Message-Id: <22d83cb4

RE: [PATCH v3 3/6] Hexagon: add core gdbstub xml data for LLDB

2023-05-09 Thread Taylor Simpson
> -Original Message- > From: Matheus Tavares Bernardino > Sent: Thursday, May 4, 2023 10:38 AM > To: qemu-devel@nongnu.org > Cc: alex.ben...@linaro.org; Brian Cain ; > f4...@amsat.org; peter.mayd...@linaro.org; Taylor Simpson > ; phi...@linaro.org; > richard.hender...@linaro.org; Lauren

Re: [PATCH v5 00/21] block: remove aio_disable_external() API

2023-05-09 Thread Kevin Wolf
Am 04.05.2023 um 21:53 hat Stefan Hajnoczi geschrieben: > v5: > - Use atomic accesses for in_flight counter in vhost-user-server.c [Kevin] > - Stash SCSIDevice id/lun values for VIRTIO_SCSI_T_TRANSPORT_RESET event > before unrealizing the SCSIDevice [Kevin] > - Keep vhost-user-blk export .detach(

command line, guest console output missing from avocado log

2023-05-09 Thread Peter Maydell
I just noticed that the guest console output seems to no longer be in the avocado log file. Can it be reinstated, please? The console logs are typically the most useful clue to "why did this test fail" and without it you're just guessing in the dark... The details of what QEMU command line avocado

Re: [PATCH v5 05/21] virtio-scsi: stop using aio_disable_external() during unplug

2023-05-09 Thread Kevin Wolf
Am 04.05.2023 um 21:53 hat Stefan Hajnoczi geschrieben: > This patch is part of an effort to remove the aio_disable_external() > API because it does not fit in a multi-queue block layer world where > many AioContexts may be submitting requests to the same disk. > > The SCSI emulation code is alrea

Re: [PATCH v4 09/10] migration: disallow change capabilities in COLO state

2023-05-09 Thread Juan Quintela
Vladimir Sementsov-Ogievskiy wrote: > COLO is not listed as running state in migrate_is_running(), so, it's > theoretically possible to disable colo capability in COLO state and the > unexpected error in migration_iteration_finish() is reachable. > > Let's disallow that in qmp_migrate_set_capabili

Re: [PATCH] hw/mips/malta: Fix the malta machine on big endian hosts

2023-05-09 Thread Peter Maydell
On Thu, 13 Apr 2023 at 17:26, Peter Maydell wrote: > > On Thu, 13 Apr 2023 at 17:08, Michael Tokarev wrote: > > > > 30.03.2023 18:26, Thomas Huth wrote: > > > Booting a Linux kernel with the malta machine is currently broken > > > on big endian hosts. The cpu_to_gt32 macro wants to byteswap a val

[PATCH] Remove test_vshuff from hvx_misc tests

2023-05-09 Thread Marco Liebel
test_vshuff checks that the vshuff instruction works correctly when both vector registers are the same. Using vshuff in this way is undefined and will be rejected by the compiler in a future version of the toolchain. Signed-off-by: Marco Liebel --- tests/tcg/hexagon/hvx_misc.c | 45 -

Re: [PATCH v4 04/10] configure: add --disable-colo-proxy option

2023-05-09 Thread Juan Quintela
"Zhang, Chen" wrote: >> -Original Message- >> From: Vladimir Sementsov-Ogievskiy >> Sent: Saturday, April 29, 2023 3:49 AM >> To: qemu-devel@nongnu.org >> Cc: lukasstra...@web.de; quint...@redhat.com; Zhang, Chen >> ; vsement...@yandex-team.ru; Paolo Bonzini >> ; Marc-André Lureau >> ; Da

Re: [PATCH v5 00/21] block: remove aio_disable_external() API

2023-05-09 Thread Kevin Wolf
Am 09.05.2023 um 19:51 hat Stefan Hajnoczi geschrieben: > On Thu, May 04, 2023 at 11:44:42PM +0200, Kevin Wolf wrote: > > Am 04.05.2023 um 21:53 hat Stefan Hajnoczi geschrieben: > > > v5: > > > - Use atomic accesses for in_flight counter in vhost-user-server.c [Kevin] > > > - Stash SCSIDevice id/lu

Re: [PATCH v4 10/10] migration: block incoming colo when capability is disabled

2023-05-09 Thread Juan Quintela
Vladimir Sementsov-Ogievskiy wrote: > We generally require same set of capabilities on source and target. > Let's require x-colo capability to use COLO on target. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Juan Quintela I will update the docs as said by lukas. > --- > migra

Re: [PATCH v4 09/10] migration: disallow change capabilities in COLO state

2023-05-09 Thread Juan Quintela
"Zhang, Chen" wrote: >> -Original Message- >> From: Vladimir Sementsov-Ogievskiy >> Sent: Thursday, May 4, 2023 4:23 PM >> To: Zhang, Chen ; qemu-devel@nongnu.org >> Cc: lukasstra...@web.de; quint...@redhat.com; Peter Xu >> ; Leonardo Bras >> Subject: Re: [PATCH v4 09/10] migration: disa

Re: [PATCH v4 03/10] build: move COLO under CONFIG_REPLICATION

2023-05-09 Thread Juan Quintela
Vladimir Sementsov-Ogievskiy wrote: > We don't allow to use x-colo capability when replication is not > configured. So, no reason to build COLO when replication is disabled, > it's unusable in this case. > > Note also that the check in migrate_caps_check() is not the only > restriction: some funct

[PATCH] multifd: Add colo support

2023-05-09 Thread Juan Quintela
From: Lukas Straub Like in the normal ram_load() path, put the received pages into the colo cache and mark the pages in the bitmap so that they will be flushed to the guest later. Signed-off-by: Lukas Straub --- Hi Lukas What about this instead of your other three patches? I think it is cle

Re: [PATCH] make: clean after distclean deletes source files

2023-05-09 Thread Steven Sistare
Any takers? I believe this patch is correct and clean. Examples, run in the top level of a git tree: $ configure ... $ make clean ... cleans ... $ make clean ... cleans ... $ make distclean ... cleans ... $ make distclean Makefile:180: *** Please call configure before running make. Stop. $ m

Re: [PATCH 00/11] Fix qemu_strtosz() read-out-of-bounds

2023-05-09 Thread Hanna Czenczek
On 08.05.23 22:03, Eric Blake wrote: This series blew up in my face when Hanna first pointed me to https://gitlab.com/qemu-project/qemu/-/issues/1629 Basically, 'qemu-img dd bs=9.9e999' killed a sanitized build because of a read-out-of-bounds (".9e999" parses as infinity, but qemu_strtosz wasn't

Re: [PATCH 11/11] cutils: Improve qemu_strtosz handling of fractions

2023-05-09 Thread Hanna Czenczek
On 08.05.23 22:03, Eric Blake wrote: We have several limitations and bugs worth fixing; they are inter-related enough that it is not worth splitting this patch into smaller pieces: * ".5k" should work to specify 512, just as "0.5k" does * "1.k" and "1." + "9"*50 + "k" should both produce the

Re: [PATCH v3 0/5] virtio-gpu cleanups and obvious definitions

2023-05-09 Thread Gurchetan Singh
On Tue, May 9, 2023 at 5:43 AM Marc-André Lureau wrote: > Hi > > On Thu, May 4, 2023 at 11:13 PM Gurchetan Singh < > gurchetansi...@chromium.org> wrote: > >> From: Gurchetan Singh >> >> v3 of "virtio-gpu cleanups and obvious definitions" >> >> https://lists.gnu.org/archive/html/qemu-devel/2023-0

Re: [PATCH v5 00/21] block: remove aio_disable_external() API

2023-05-09 Thread Stefan Hajnoczi
On Thu, May 04, 2023 at 11:44:42PM +0200, Kevin Wolf wrote: > Am 04.05.2023 um 21:53 hat Stefan Hajnoczi geschrieben: > > v5: > > - Use atomic accesses for in_flight counter in vhost-user-server.c [Kevin] > > - Stash SCSIDevice id/lun values for VIRTIO_SCSI_T_TRANSPORT_RESET event > > before unre

Re: [PATCH v2 00/20] Graph locking, part 3 (more block drivers)

2023-05-09 Thread Stefan Hajnoczi
On Thu, May 04, 2023 at 01:57:30PM +0200, Kevin Wolf wrote: > The first few patches in this series fix coroutine correctness problems > that have existed for a while, but only actually start to make things > fail in practice with stricter checks that we're going to introduce with > the graph lockin

Re: css_clear_io_interrupt() error handling

2023-05-09 Thread Halil Pasic
On Mon, 08 May 2023 11:01:55 +0200 Cornelia Huck wrote: > On Mon, May 08 2023, Markus Armbruster wrote: > > > css_clear_io_interrupt() aborts on unexpected ioctl() errors, and I > > wonder whether that's appropriate. Let's have a closer look: Just for my understanding, was there a field probl

Re: [PATCH 2/4] vhost-user: Interface for migration state transfer

2023-05-09 Thread Stefan Hajnoczi
On Tue, 9 May 2023 at 11:35, Eugenio Perez Martin wrote: > > On Tue, May 9, 2023 at 5:09 PM Stefan Hajnoczi wrote: > > > > On Tue, May 09, 2023 at 08:45:33AM +0200, Eugenio Perez Martin wrote: > > > On Mon, May 8, 2023 at 10:10 PM Stefan Hajnoczi > > > wrote: > > > > > > > > On Thu, Apr 20, 202

Re: [PULL 00/17] QAPI patches patches for 2023-05-09

2023-05-09 Thread Paolo Bonzini
On 5/9/23 18:20, Richard Henderson wrote: This has a number of CI failures, including https://gitlab.com/qemu-project/qemu/-/jobs/4252925621#L4673 ../docs/meson.build:27:6: ERROR: Problem encountered: Install a Python 3 version of python-sphinx and the readthedoc theme No Python 3.8 yet (n

Re: [PATCH] block: compile out assert_bdrv_graph_readable() by default

2023-05-09 Thread Kevin Wolf
Am 01.05.2023 um 19:34 hat Stefan Hajnoczi geschrieben: > reader_count() is a performance bottleneck because the global > aio_context_list_lock mutex causes thread contention. Put this debugging > assertion behind a new ./configure --enable-debug-graph-lock option and > disable it by default. > >

RE: [PATCH v2] Hexagon (decode): look for pkts with multiple insns at the same slot

2023-05-09 Thread Taylor Simpson
> -Original Message- > From: Taylor Simpson > Sent: Tuesday, May 9, 2023 11:46 AM > To: Matheus Tavares Bernardino ; qemu- > de...@nongnu.org > Subject: RE: [PATCH v2] Hexagon (decode): look for pkts with multiple insns > at the same slot > > > > > -Original Message- > > From:

Re: [PATCH v2 00/20] Graph locking, part 3 (more block drivers)

2023-05-09 Thread Kevin Wolf
Am 04.05.2023 um 13:57 hat Kevin Wolf geschrieben: > The first few patches in this series fix coroutine correctness problems > that have existed for a while, but only actually start to make things > fail in practice with stricter checks that we're going to introduce with > the graph locking work. >

[PATCH] migration: Fix duplicated included in meson.build

2023-05-09 Thread Juan Quintela
This is the commint with the merge error (not in the submited patch). commit 52623f23b0d114837a0d6278180b3e3ae8947117 Author: Lukas Straub Date: Thu Apr 20 11:48:35 2023 +0200 ram-compress.c: Make target independent Make ram-compress.c target independent. Fixes: 52623f23b0d114837a0d6

Re: ssl fips self check fails with 7.2.0 on x86 TCG

2023-05-09 Thread Michael Tokarev
09.05.2023 17:39, Philippe Mathieu-Daudé пишет: ..> Should be fixed in v7.2-stable: $ git log --oneline --grep=1d0b9261 v7.2.2 c45d10f655 target/i386: fix ADOX followed by ADCX 6809dbc5c5 target/i386: Fix C flag for BLSI, BLSMSK, BLSR 8d3c9fc439 target/i386: Fix BEXTR instruction Unfortunately

Re: [PTACH v2 2/6] target/riscv: support the AIA device emulateion with KVM enabled

2023-05-09 Thread Andrew Jones
sed 's/emulateion/emulation' <<<$SUBJECT and for the whole series sed 's/PTACH/PATCH/' <<<$SUBJECT Thanks, drew On Fri, May 05, 2023 at 11:39:37AM +, Yong-Xuan Wang wrote: > Remove M mode AIA devices when using KVM acceleration > > Signed-off-by: Yong-Xuan Wang > Reviewed-by: Jim Shu >

RE: [PATCH v2] Hexagon (decode): look for pkts with multiple insns at the same slot

2023-05-09 Thread Taylor Simpson
> -Original Message- > From: Matheus Tavares Bernardino > Sent: Monday, May 8, 2023 8:37 AM > To: qemu-devel@nongnu.org > Cc: Taylor Simpson > Subject: [PATCH v2] Hexagon (decode): look for pkts with multiple insns at > the same slot > > Each slot in a packet can be assigned to at mos

[PATCH v2 1/5] disas: Move disas.c to disas/

2023-05-09 Thread Richard Henderson
Reviewed-by: Thomas Huth Signed-off-by: Richard Henderson Message-Id: <20230503072331.1747057-80-richard.hender...@linaro.org> --- meson.build | 3 --- disas.c => disas/disas.c | 0 disas/meson.build| 4 +++- 3 files changed, 3 insertions(+), 4 deletions(-) rename disas.c =

[PATCH v2 3/5] disas: Remove target-specific headers

2023-05-09 Thread Richard Henderson
Reviewed-by: Thomas Huth Signed-off-by: Richard Henderson Message-Id: <20230503072331.1747057-83-richard.hender...@linaro.org> --- include/disas/disas.h | 6 -- disas/disas.c | 3 ++- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/include/disas/disas.h b/include/disas

[PATCH v2 5/5] disas: Move disas.c into the target-independent source set

2023-05-09 Thread Richard Henderson
From: Thomas Huth By using target_words_bigendian() instead of an ifdef, we can build this code once. Signed-off-by: Thomas Huth [rth: Type change done in a separate patch] Signed-off-by: Richard Henderson --- disas/disas.c | 10 +- disas/meson.build | 3 ++- 2 files changed, 7 i

[PATCH v2 2/5] disas: Remove target_ulong from the interface

2023-05-09 Thread Richard Henderson
Use uint64_t for the pc, and size_t for the size. Signed-off-by: Richard Henderson Message-Id: <20230503072331.1747057-81-richard.hender...@linaro.org> --- include/disas/disas.h | 17 ++--- bsd-user/elfload.c| 5 +++-- disas/disas.c | 19 +-- linux-user/e

[PATCH v2 0/5] Make the core disassembler functions target-independent

2023-05-09 Thread Richard Henderson
Merges Thomas' RFC patch set with part of my "build-tcg-once" patch set. The only real change from Thomas' is to use uint64_t instead of hwaddr. r~ Richard Henderson (3): disas: Move disas.c to disas/ disas: Remove target_ulong from the interface disas: Remove target-specific headers Tho

[PATCH v2 4/5] disas: Move softmmu specific code to separate file

2023-05-09 Thread Richard Henderson
From: Thomas Huth We'd like to move disas.c into the common code source set, where CONFIG_USER_ONLY is not available anymore. So we have to move the related code into a separate file instead. Signed-off-by: Thomas Huth [rth: Type change done in a separate patch] Signed-off-by: Richard Henderson

[PATCH v1 1/1] s390x/pv: Fix spurious warning with asynchronous teardown

2023-05-09 Thread Claudio Imbrenda
When rebooting a small VM using asynchronous teardown, a spurious warning is emitted when the KVM_PV_ASYNC_CLEANUP_PREPARE ioctl fails. Avoid using asynchronous teardown altogether when the VM is small enough; the cutoff is set at 4GiB. This will avoid triggering the warning and also avoid pointle

Re: [PATCH v2] iotests: Test resizing image attached to an iothread

2023-05-09 Thread Eric Blake
On Tue, May 09, 2023 at 03:41:33PM +0200, Kevin Wolf wrote: > This tests that trying to resize an image with QMP block_resize doesn't > hang or otherwise fail when the image is attached to a device running in > an iothread. > > This is a regression test for the recent fix that changed > qmp_block_

Re: [PULL 00/17] QAPI patches patches for 2023-05-09

2023-05-09 Thread Richard Henderson
On 5/9/23 08:59, Markus Armbruster wrote: The following changes since commit 792f77f376adef944f9a03e601f6ad90c2f891b2: Merge tag 'pull-loongarch-20230506' of https://gitlab.com/gaosong/qemu into staging (2023-05-06 08:11:52 +0100) are available in the Git repository at: https://repo.or.

Re: [PATCH v2 0/2] tests/lcitool: Add mtools and xorriso and remove genisoimage as dependencies

2023-05-09 Thread Michael S. Tsirkin
On Thu, May 04, 2023 at 09:16:09PM +0530, Ani Sinha wrote: > mformat and xorriso tools are needed by biosbits avocado tests. This patchset > adds those two tools in the docker container images. > xorriso package conflicts with genisoimage package on some distributions. > Therefore, it is not possib

Re: [PATCH] iotests: Test resizing image attached to an iothread

2023-05-09 Thread Eric Blake
On Tue, May 09, 2023 at 12:59:31PM +0200, Kevin Wolf wrote: > This tests that trying to resize an image with QMP block_resize doesn't > hang or otherwise fail when the image is attached to a device running in > an iothread. > > This is a regression test for the recent fix that changed > qmp_block_

Re: [PATCH 06/11] test-cutils: Add more coverage to qemu_strtosz

2023-05-09 Thread Eric Blake
On Mon, May 08, 2023 at 03:03:38PM -0500, Eric Blake wrote: > Add some more strings that the user might send our way. In > particular, some of these additions include FIXME comments showing > where our parser doesn't quite behave the way we want. > > Signed-off-by: Eric Blake > --- > tests/unit

Re: [PATCH v2 3/3] pci: ROM preallocation for incoming migration

2023-05-09 Thread David Hildenbrand
On 09.05.23 17:54, Michael S. Tsirkin wrote: On Wed, May 03, 2023 at 02:39:15PM +0300, Vladimir Sementsov-Ogievskiy wrote: On 03.05.23 13:05, Michael S. Tsirkin wrote: On Wed, May 03, 2023 at 12:50:09PM +0300, Vladimir Sementsov-Ogievskiy wrote: On 03.05.23 12:20, David Hildenbrand wrote: On

Re: [PATCH 06/11] test-cutils: Add more coverage to qemu_strtosz

2023-05-09 Thread Eric Blake
On Tue, May 09, 2023 at 02:31:08PM +0200, Hanna Czenczek wrote: > On 08.05.23 22:03, Eric Blake wrote: > > Add some more strings that the user might send our way. In > > particular, some of these additions include FIXME comments showing > > where our parser doesn't quite behave the way we want. >

Re: [PATCH v2 3/3] pci: ROM preallocation for incoming migration

2023-05-09 Thread Michael S. Tsirkin
On Wed, May 03, 2023 at 02:39:15PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 03.05.23 13:05, Michael S. Tsirkin wrote: > > On Wed, May 03, 2023 at 12:50:09PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > On 03.05.23 12:20, David Hildenbrand wrote: > > > > On 25.04.23 18:14, Vladimir S

Re: [RFC PATCH 0/2] Make the core disassembler functions target-independent

2023-05-09 Thread Richard Henderson
On 5/8/23 15:04, Richard Henderson wrote: On 5/8/23 14:37, Thomas Huth wrote: Move disas.c into the target-independent source set, so that we only have to compile this code once instead multiple times (one time for each target). Marked as RFC since we have to replace the target_ulongs here with

Re: [PATCH 06/11] test-cutils: Add more coverage to qemu_strtosz

2023-05-09 Thread Eric Blake
On Tue, May 09, 2023 at 05:15:04PM +0200, Hanna Czenczek wrote: > On 08.05.23 22:03, Eric Blake wrote: > > Add some more strings that the user might send our way. In > > particular, some of these additions include FIXME comments showing > > where our parser doesn't quite behave the way we want. >

Re: [PATCH v2 3/3] pci: ROM preallocation for incoming migration

2023-05-09 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Tue, May 02, 2023 at 12:11:38PM +0200, Juan Quintela wrote: >> "Michael S. Tsirkin" wrote: >> >> >> > CC pbonzini,dgilbert,quintela,armbru : guys, is poking at >> >> > runstate_check like >> >> > this the right way to figure out we are not going to use the >> >>

[PATCH v3 4/5] vdpa: return errno in vhost_vdpa_get_vring_group error

2023-05-09 Thread Eugenio Pérez
We need to tell in the caller, as some errors are expected in a normal workflow. In particular, parent drivers in recent kernels with VHOST_BACKEND_F_IOTLB_ASID may not support vring groups. In that case, -ENOTSUP is returned. This is the case of vp_vdpa in Linux 6.2. Next patches in this serie

[PATCH v3 3/5] vdpa: add vhost_vdpa_set_dev_features_fd

2023-05-09 Thread Eugenio Pérez
This allows to set the features of a vhost-vdpa device from external subsystems like vhost-net. It is used in subsequent patches to negotiate features and probe for CVQ ASID isolation. Reviewed-by: Stefano Garzarella Acked-by: Jason Wang Signed-off-by: Eugenio Pérez --- include/hw/virtio/vhos

Re: QEMU developers fortnightly call for agenda for 2023-05-16

2023-05-09 Thread Juan Quintela
Mark Burton wrote: > I’d appreciate an update on single binary. > Also, What’s the status on the “icount” plugin ? Annotated. BTW, if people are interested I can expose the "idea" of all the migration patches going on the tree. Later, Juan.

[PATCH v3 2/5] vdpa: add vhost_vdpa_reset_status_fd

2023-05-09 Thread Eugenio Pérez
This allows to reset a vhost-vdpa device from external subsystems like vhost-net, since it does not have any struct vhost_dev by the time we need to use it. It is used in subsequent patches to negotiate features and probe for CVQ ASID isolation. Reviewed-by: Stefano Garzarella Signed-off-by: Eug

[PATCH v3 1/5] vdpa: Remove status in reset tracing

2023-05-09 Thread Eugenio Pérez
It is always 0 and it is not useful to route call through file descriptor. Reviewed-by: Stefano Garzarella Acked-by: Jason Wang Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-vdpa.c | 2 +- hw/virtio/trace-events | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virti

[PATCH v3 0/5] Move ASID test to vhost-vdpa net initialization

2023-05-09 Thread Eugenio Pérez
QEMU v8.0 is able to switch dynamically between vhost-vdpa passthrough and SVQ mode as long as the net device does not have CVQ. The net device state followed (and migrated) by CVQ requires special care. A pre-requisite to add CVQ to that framework is to determine if devices with CVQ are migratab

[PATCH v3 5/5] vdpa: move CVQ isolation check to net_init_vhost_vdpa

2023-05-09 Thread Eugenio Pérez
Evaluating it at start time instead of initialization time may make the guest capable of dynamically adding or removing migration blockers. Also, moving to initialization reduces the number of ioctls in the migration, reducing failure possibilities. As a drawback we need to check for CVQ isolatio

Re: [PATCH 0/4] vhost-user-fs: Internal migration

2023-05-09 Thread Eugenio Perez Martin
On Tue, May 9, 2023 at 5:30 PM Stefan Hajnoczi wrote: > > On Fri, May 05, 2023 at 04:26:08PM +0200, Eugenio Perez Martin wrote: > > On Fri, May 5, 2023 at 11:51 AM Hanna Czenczek wrote: > > > > > > (By the way, thanks for the explanations :)) > > > > > > On 05.05.23 11:03, Hanna Czenczek wrote: >

  1   2   3   >