On Mon, May 08, 2023 at 02:44:21PM +0800, Jason Wang wrote:
> On Sun, May 7, 2023 at 2:01 PM Michael S. Tsirkin wrote:
> >
> > On Sat, May 06, 2023 at 10:13:36AM +0800, Xuan Zhuo wrote:
> > > On Thu, 4 May 2023 12:14:47 +0200, =?utf-8?q?Eugenio_P=C3=A9rez?=
> > > wrote:
> > > > The commit 93a97
On Sun, May 7, 2023 at 2:01 PM Michael S. Tsirkin wrote:
>
> On Sat, May 06, 2023 at 10:13:36AM +0800, Xuan Zhuo wrote:
> > On Thu, 4 May 2023 12:14:47 +0200, =?utf-8?q?Eugenio_P=C3=A9rez?=
> > wrote:
> > > The commit 93a97dc5200a ("virtio-net: enable vq reset feature") enables
> > > unconditio
css_clear_io_interrupt() aborts on unexpected ioctl() errors, and I
wonder whether that's appropriate. Let's have a closer look:
static void css_clear_io_interrupt(uint16_t subchannel_id,
uint16_t subchannel_nr)
{
Error *err = NULL;
s
On Mon, May 08, 2023 at 07:37:23AM +0200, Heinrich Schuchardt wrote:
> On 4/25/23 12:25, Sunil V L wrote:
> > Currently, virt machine supports two pflash instances each with
> > 32MB size. However, the first pflash is always assumed to
> > contain M-mode firmware and reset vector is set to this if
On 4/25/23 12:25, Sunil V L wrote:
Currently, virt machine supports two pflash instances each with
32MB size. However, the first pflash is always assumed to
contain M-mode firmware and reset vector is set to this if
enabled. Hence, for S-mode payloads like EDK2, only one pflash
instance is availa
On Mon, May 8, 2023 at 1:25 PM Jason Wang wrote:
>
> On Mon, May 1, 2023 at 10:02 AM Viktor Prutyanov wrote:
> >
> > The guest can disable or never enable Device-TLB. In these cases,
> > it can't be used even if enabled in QEMU. So, check Device-TLB state
> > before registering IOMMU notifier and
On Mon, May 1, 2023 at 10:02 AM Viktor Prutyanov wrote:
>
> If vhost is enabled for virtio-net, Device-TLB enable/disable events
> must be passed to vhost for proper IOMMU unmap flag selection.
The patch looks good, just wonder if you have tested it with vhost-user?
(It looks to me like it shoul
On Mon, May 1, 2023 at 10:02 AM Viktor Prutyanov wrote:
>
> The guest can disable or never enable Device-TLB. In these cases,
> it can't be used even if enabled in QEMU. So, check Device-TLB state
> before registering IOMMU notifier and select unmap flag depending on
> that. Also, implement a way
Signed-off-by: Sam Li
Reviewed-by: Stefan Hajnoczi
---
hw/block/trace-events | 7 +++
hw/block/virtio-blk.c | 12
2 files changed, 19 insertions(+)
diff --git a/hw/block/trace-events b/hw/block/trace-events
index 2c45a62bd5..34be8b9135 100644
--- a/hw/block/trace-events
+++ b/
This patch extends virtio-blk emulation to handle zoned device commands
by calling the new block layer APIs to perform zoned device I/O on
behalf of the guest. It supports Report Zone, four zone oparations (open,
close, finish, reset), and Append Zone.
The VIRTIO_BLK_F_ZONED feature bit will only
Add the documentation about the example of using virtio-blk driver
to pass the zoned block devices through to the guest.
Signed-off-by: Sam Li
---
docs/devel/zoned-storage.rst | 17 +
1 file changed, 17 insertions(+)
diff --git a/docs/devel/zoned-storage.rst b/docs/devel/zoned-s
Taking account of the new zone append write operation for zoned devices,
BLOCK_ACCT_ZONE_APPEND enum is introduced as other I/O request type (read,
write, flush).
Signed-off-by: Sam Li
---
block/qapi-sysemu.c| 11 ++
block/qapi.c | 18 ++
hw/block/virtio-blk.c
This patch adds zoned storage emulation to the virtio-blk driver. It
implements the virtio-blk ZBD support standardization that is
recently accepted by virtio-spec. The link to related commit is at
https://github.com/oasis-tcs/virtio-spec/commit/b4e8efa0fa6c8d844328090ad15db65af8d7d981
The Linux
This patch series add zone append operation based on the previous
zoned device support part. The file-posix driver is modified to
add zone append emulation using regular writes.
v10-v11:
- fix CI issues [Stefan]
v9:
- address review comments [Stefan]
* fix get_zones_wp() for wrong offset index
The patch tests zone append writes by reporting the zone wp after
the completion of the call. "zap -p" option can print the sector
offset value after completion, which should be the start sector
where the append write begins.
Signed-off-by: Sam Li
Reviewed-by: Stefan Hajnoczi
---
qemu-io-cmds.c
A zone append command is a write operation that specifies the first
logical block of a zone as the write position. When writing to a zoned
block device using zone append, the byte offset of the call may point at
any position within the zone to which the data is being appended. Upon
completion the d
Signed-off-by: Sam Li
Reviewed-by: Dmitry Fomichev
Reviewed-by: Stefan Hajnoczi
---
block/file-posix.c | 3 +++
block/trace-events | 2 ++
2 files changed, 5 insertions(+)
diff --git a/block/file-posix.c b/block/file-posix.c
index aacb50d5aa..cd47167d04 100644
--- a/block/file-posix.c
+++ b/bl
Since Linux doesn't have a user API to issue zone append operations to
zoned devices from user space, the file-posix driver is modified to add
zone append emulation using regular writes. To do this, the file-posix
driver tracks the wp location of all zones of the device. It uses an
array of uint64_
Signed-off-by: Sam Li
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Dmitry Fomichev
Acked-by: Kevin Wolf
Message-id: 20230324090605.28361-8-faithilike...@gmail.com
Signed-off-by: Stefan Hajnoczi
---
block/file-posix.c | 3 +++
block/trace-events | 2 ++
2 files changed, 5 insertions(+)
diff --gi
raw-format driver usually sits on top of file-posix driver. It needs to
pass through requests of zone commands.
Signed-off-by: Sam Li
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Damien Le Moal
Reviewed-by: Hannes Reinecke
Reviewed-by: Dmitry Fomichev
Acked-by: Kevin Wolf
Message-id: 2023032409
Zoned Block Devices (ZBDs) devide the LBA space to block regions called zones
that are larger than the LBA size. It can only allow sequential writes, which
reduces write amplification in SSD, leading to higher throughput and increased
capacity. More details about ZBDs can be found at:
https://zone
Putting zoned/non-zoned BlockDrivers on top of each other is not
allowed.
Signed-off-by: Sam Li
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Hannes Reinecke
Reviewed-by: Dmitry Fomichev
Acked-by: Kevin Wolf
Message-id: 20230324090605.28361-6-faithilike...@gmail.com
[Adjust commit message prefix
Use get_sysfs_str_val() to get the string value of device
zoned model. Then get_sysfs_zoned_model() can convert it to
BlockZoneModel type of QEMU.
Use get_sysfs_long_val() to get the long value of zoned device
information.
Signed-off-by: Sam Li
Reviewed-by: Hannes Reinecke
Reviewed-by: Stefan H
The new block layer APIs of zoned block devices can be tested by:
$ tests/qemu-iotests/check zoned
Run each zone operation on a newly created null_blk device
and see whether it outputs the same zone information.
Signed-off-by: Sam Li
Reviewed-by: Stefan Hajnoczi
Acked-by: Kevin Wolf
Message-id:
Signed-off-by: Sam Li
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Damien Le Moal
Reviewed-by: Hannes Reinecke
Reviewed-by: Dmitry Fomichev
Acked-by: Kevin Wolf
Message-id: 20230324090605.28361-2-faithilike...@gmail.com
[Adjust commit message prefix as suggested by Philippe Mathieu-Daudé
.
--Ste
Add zoned device option to host_device BlockDriver. It will be presented only
for zoned host block devices. By adding zone management operations to the
host_block_device BlockDriver, users can use the new block layer APIs
including Report Zone and four zone management operations
(open, close, finis
Add the documentation about the zoned device support to virtio-blk
emulation.
Signed-off-by: Sam Li
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Damien Le Moal
Reviewed-by: Dmitry Fomichev
Acked-by: Kevin Wolf
Message-id: 20230324090605.28361-9-faithilike...@gmail.com
[Add index-api.rst to fix "
Hi Alistair,
On Tue, Apr 25, 2023 at 03:55:45PM +0530, Sunil V L wrote:
> Currently, virt machine supports two pflash instances each with
> 32MB size. However, the first pflash is always assumed to
> contain M-mode firmware and reset vector is set to this if
> enabled. Hence, for S-mode payloads l
On Mon, May 1, 2023 at 10:02 AM Viktor Prutyanov wrote:
>
> Guest may enable or disable PCI ATS and, accordingly, Device-TLB for
> the device. Add a flag and a trigger function to handle Device-TLB
> enable/disable in VirtIO devices and hook it to ATS enable/disable for
> PCI transport.
>
> Signed
On Mon, May 1, 2023 at 10:02 AM Viktor Prutyanov wrote:
>
> When IOMMU and vhost are enabled together, QEMU tracks IOTLB or
> Device-TLB unmap events depending on whether Device-TLB is enabled. But
> even if Device-TLB and PCI ATS is enabled, the guest can reject to use
> it. For example, this sit
ping~~
在 2023/4/26 上午9:37, Song Gao 写道:
ping~
在 2023/4/6 下午6:00, Song Gao 写道:
Add separate macro EXTIOI_CPUS for extioi interrupt controller, extioi
only supports 4 cpu. And set macro LOONGARCH_MAX_CPUS as 256 so that
loongarch virt machine supports more cpus.
Interrupts from external devices
Hi Alistair,
Thanks for the information, what I'm doing is to implement the
StandaloneMm and secure boot feature for RISC-V by following the ARM's way
https://trustedfirmware-a.readthedocs.io/en/latest/components/secure-partition-manager-mm.html
So here what I need from virt is actually the V
Copy Hailiang Zhang
On Mon, May 08, 2023 at 02:51:43AM +0200, Lukas Straub wrote:
> Hello Everyone,
> These patches add support for colo to multifd.
>
> Lukas Straub (5):
> ram: Add public helper to set colo bitmap
> ram: Let colo_flush_ram_cache take the bitmap_mutex
> multifd: Introduce m
On Tue, 02 May 2023 12:39:12 +0200
Juan Quintela wrote:
> [...]
>
> my patches are only code movement and cleanups, so Lukas any clue?
>
> Lukas, I am going to drop the compress code for now and pass the other
> patches. In the meanwhile, I am going to try to setup some machine
> where I can r
Signed-off-by: Lukas Straub
---
migration/multifd-colo.c | 30 +-
migration/multifd.c | 11 +--
migration/multifd.h | 2 ++
3 files changed, 36 insertions(+), 7 deletions(-)
diff --git a/migration/multifd-colo.c b/migration/multifd-colo.c
index c035
在 2023/5/6 下午7:21, Alexander Bulekov 写道:
loongarch_ipi_iocsr MRs rely on re-entrant IO through the ipi_send
function. As such, mark these MRs re-entrancy-safe.
Fixes: a2e1753b80 ("memory: prevent dma-reentracy issues")
Signed-off-by: Alexander Bulekov
---
hw/intc/loongarch_ipi.c | 4
Introduce multifd-internal.h so code that would normally go into
multifd.c can go into an extra file. This way, multifd.c hopefully
won't grow to 4000 lines like ram.c
This will be used in the next commits to add colo support to multifd.
Signed-off-by: Lukas Straub
---
migration/multifd-interna
Hello Everyone,
These patches add support for colo to multifd.
Lukas Straub (5):
ram: Add public helper to set colo bitmap
ram: Let colo_flush_ram_cache take the bitmap_mutex
multifd: Introduce multifd-internal.h
multifd: Introduce a overridable revc_pages method
multifd: Add colo suppor
The overhead of the mutex in non-multifd mode is negligible,
because in that case its just the single thread taking the mutex.
This will be used in the next commits to add colo support to multifd.
Signed-off-by: Lukas Straub
---
migration/ram.c | 17 ++---
migration/ram.h | 1 +
2
This allows to override the behaviour around recv_pages. Think of
it like a "multifd_colo" child class of multifd.
This will be used in the next commits to add colo support to multifd.
Signed-off-by: Lukas Straub
---
migration/meson.build| 1 +
migration/multifd-colo.c | 39 +++
This will be used in the next commits to add colo support to multifd.
Signed-off-by: Lukas Straub
---
migration/ram.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/migration/ram.c b/migration/ram.c
index 2d3fd2112a..f9e7aeda12 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -4230,6
On Sun, May 07, 2023 at 03:54:00PM +0300, Avihai Horon wrote:
>
> On 04/05/2023 18:50, Peter Xu wrote:
> > External email: Use caution opening links or attachments
> >
> >
> > On Thu, May 04, 2023 at 01:18:04PM +0300, Avihai Horon wrote:
> > > On 03/05/2023 18:49, Peter Xu wrote:
> > > > Externa
On Fri, Apr 28, 2023 at 6:58 AM Daniel Henrique Barboza
wrote:
>
> The function is a no-op if 'vta' is zero but we're still doing a lot of
> stuff in this function regardless. vext_set_elems_1s() will ignore every
> single time (since vta is zero) and we just wasted time.
>
> Skip it altogether in
On Fri, Apr 28, 2023 at 6:58 AM Daniel Henrique Barboza
wrote:
>
> The function is a no-op if 'vta' is zero but we're still doing a lot of
> stuff in this function regardless. vext_set_elems_1s() will ignore every
> single time (since vta is zero) and we just wasted time.
>
> Skip it altogether in
On Fri, Apr 21, 2023 at 11:29 PM Daniel Henrique Barboza
wrote:
>
> write_misa() must use as much common logic as possible. We want to open
> code just the bits that are exclusive to the CSR write operation and TCG
> internals.
>
> Our validation is done with riscv_cpu_validate_set_extensions(), b
On Fri, Apr 28, 2023 at 7:35 PM Yu Chien Peter Lin
wrote:
>
> The pmu encodes the event to counter mappings and is only used
> by the SBI firmware. Currently, pmu is a subnode of soc but has
> no reg properties included, causing the following failure when
> checked with dt-validate.
>
> /tmp/virt.
On Fri, Apr 28, 2023 at 7:33 PM Yu Chien Peter Lin
wrote:
>
> Fix a few minor typos for PMU events.
>
> Signed-off-by: Yu Chien Peter Lin
Acked-by: Alistair Francis
Alistair
> ---
> target/riscv/cpu.h| 2 +-
> target/riscv/cpu_helper.c | 2 +-
> target/riscv/pmu.c| 8
On Tue, Apr 25, 2023 at 5:36 PM Yong Li wrote:
>
> The virt machine can have two UARTs and the second UART
> can be used by the secure payload, firmware or OS residing
> in secure world. Will include the UART device to FDT in a
> seperated patch.
>
> Signed-off-by: Yong Li
> Reviewed-by: LIU Zhiw
Hi all,
On Wed, May 3, 2023 at 2:09 PM Daniel P. Berrangé wrote:
>
> On Mon, May 01, 2023 at 10:21:00AM +0300, Andrew Melnychenko wrote:
> > Added command "request-ebpf". This command returns
> > eBPF program encoded base64. The program taken from the
> > skeleton and essentially is an ELF object
On Fri, May 5, 2023 at 11:04 AM Alistair Francis wrote:
>
> From: LIU Zhiwei
>
> When I boot a ubuntu image, QEMU output a "Bad icount read" message and exit.
> The reason is that when execute helper_mret or helper_sret, it will
> cause a call to icount_get_raw_locked (), which needs set can_do_i
On Fri, May 5, 2023 at 11:08 AM Alistair Francis wrote:
>
> From: Bin Meng
>
> When reading a non-existent CSR QEMU should raise illegal instruction
> exception, but currently it just exits due to the g_assert() check.
>
> This actually reverts commit 0ee342256af9205e7388efdf193a6d8f1ba1a617.
> S
Hi all,
On Wed, May 3, 2023 at 2:07 PM Daniel P. Berrangé wrote:
>
> On Mon, May 01, 2023 at 10:20:57AM +0300, Andrew Melnychenko wrote:
> > Changed eBPF map updates through mmaped array.
> > Mmaped arrays provide direct access to map data.
> > It should omit using bpf_map_update_elem() call,
> >
Hi all,
Thank you for your comments. I'll update it in the next patch version.
On Wed, May 3, 2023 at 2:03 PM Daniel P. Berrangé wrote:
>
> On Mon, May 01, 2023 at 10:20:58AM +0300, Andrew Melnychenko wrote:
> > eBPF RSS program and maps may now be passed during initialization.
> > Initially was
Hi all,
On Wed, May 3, 2023 at 11:22 AM Daniel P. Berrangé wrote:
>
> On Mon, May 01, 2023 at 10:20:56AM +0300, Andrew Melnychenko wrote:
> > This series of patches provides the ability to retrieve eBPF program
> > through qmp, so management application may load bpf blob with proper
> > capabili
Hi!
In old good world ;), there was qemu which didn't require boot roms to be
present
for all devices for which bootrom file is defined, missing rom was just a
warning.
But this changed in 2014, 9 years ago, with this commit:
commit 178e785fb4507ec3462dc772bbe08303416ece47
From: Marcel Apfelba
From: Marc-André Lureau
create_stream() now reports on all error paths.
Signed-off-by: Marc-André Lureau
---
audio/pwaudio.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
Reviewed-by: Volker Rümelin
diff --git a/audio/pwaudio.c b/audio/pwaudio.c
index 5c706a9fde..389
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
audio/pwaudio.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
Reviewed-by: Volker Rümelin
diff --git a/audio/pwaudio.c b/audio/pwaudio.c
index 67df53948c..5c706a9fde 100644
--- a/audio/pwaudio.c
+++ b/audio/pwaudio
From: Marc-André Lureau
PipeWire uses errno to report error details.
Signed-off-by: Marc-André Lureau
---
audio/pwaudio.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
Reviewed-by: Volker Rümelin
diff --git a/audio/pwaudio.c b/audio/pwaudio.c
index 2b12b40934..d0bc4680a6 1
From: Marc-André Lureau
Follow PulseAudio backend comment and code, and only implement the
channels QEMU actually supports at this point, and add the same comment
about limits and future mappings. Simplify a bit the code.
Signed-off-by: Marc-André Lureau
---
audio/pwaudio.c | 75
From: Marc-André Lureau
The stream is actually created connected.
Signed-off-by: Marc-André Lureau
---
audio/pwaudio.c | 1 -
1 file changed, 1 deletion(-)
Reviewed-by: Volker Rümelin
diff --git a/audio/pwaudio.c b/audio/pwaudio.c
index 38905f5be2..f74d506ec6 100644
--- a/audio/pwaudio
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
audio/pwaudio.c | 85 -
1 file changed, 34 insertions(+), 51 deletions(-)
Reviewed-by: Volker Rümelin
diff --git a/audio/pwaudio.c b/audio/pwaudio.c
index d0bc4680a6..67df53948c
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
audio/pwaudio.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Volker Rümelin
diff --git a/audio/pwaudio.c b/audio/pwaudio.c
index 6ca4ef4f62..2b12b40934 100644
--- a/audio/pwaudio.c
+++ b/audio/pwaudi
From: Marc-André Lureau
g_clear_pointer() already checks for NULL.
Signed-off-by: Marc-André Lureau
---
audio/pwaudio.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
Reviewed-by: Volker Rümelin
diff --git a/audio/pwaudio.c b/audio/pwaudio.c
index 51cfc0b052..6ca4ef4f62
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
audio/pwaudio.c | 10 --
1 file changed, 10 deletions(-)
Reviewed-by: Volker Rümelin
diff --git a/audio/pwaudio.c b/audio/pwaudio.c
index 9eb69bfd18..51cfc0b052 100644
--- a/audio/pwaudio.c
+++ b/audio/pwaudio.c
@@ -19
From: Marc-André Lureau
"PipeWire" is the correct case.
Signed-off-by: Marc-André Lureau
---
meson.build | 2 +-
qapi/audio.json | 12 ++--
audio/pwaudio.c | 10 +-
audio/trace-events| 2 +-
meson_options.txt
On 04/05/2023 18:50, Peter Xu wrote:
External email: Use caution opening links or attachments
On Thu, May 04, 2023 at 01:18:04PM +0300, Avihai Horon wrote:
On 03/05/2023 18:49, Peter Xu wrote:
External email: Use caution opening links or attachments
On Wed, May 03, 2023 at 06:22:59PM +030
On Fri, 5 May 2023 at 19:57, Richard Henderson
wrote:
>
> On 5/4/23 16:02, Peter Maydell wrote:
> > On Wed, 3 May 2023 at 08:15, Richard Henderson
> > wrote:
> >>
> >> Instead of playing with offsetof in various places, use
> >> MMUAccessType to index an array. This is easily defined
> >> instea
67 matches
Mail list logo