Re: [PATCH for-7.2] vhost: enable vrings in vhost_dev_start() for vhost-user devices

2022-11-23 Thread Stefano Garzarella
On Thu, Nov 24, 2022 at 01:50:19AM -0500, Michael S. Tsirkin wrote: On Thu, Nov 24, 2022 at 12:19:25AM +, Raphael Norwitz wrote: > On Nov 23, 2022, at 8:16 AM, Stefano Garzarella wrote: > > Commit 02b61f38d3 ("hw/virtio: incorporate backend features in features") > properly negotiates VHOS

Re: [PATCH for 7.2?] vhost: fix vq dirt bitmap syncing when vIOMMU is enabled

2022-11-23 Thread Michael S. Tsirkin
On Thu, Nov 24, 2022 at 03:31:59PM +0800, Jason Wang wrote: > On Thu, Nov 24, 2022 at 3:06 PM Michael S. Tsirkin wrote: > > > > On Thu, Nov 24, 2022 at 12:12:15PM +0800, Jason Wang wrote: > > > On Wed, Nov 23, 2022 at 3:21 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Wed, Nov 23, 2022 a

Re: [PATCH for 7.2?] vhost: fix vq dirt bitmap syncing when vIOMMU is enabled

2022-11-23 Thread Jason Wang
On Thu, Nov 24, 2022 at 3:06 PM Michael S. Tsirkin wrote: > > On Thu, Nov 24, 2022 at 12:12:15PM +0800, Jason Wang wrote: > > On Wed, Nov 23, 2022 at 3:21 PM Michael S. Tsirkin wrote: > > > > > > On Wed, Nov 23, 2022 at 03:08:25PM +0800, Jason Wang wrote: > > > > On Wed, Nov 23, 2022 at 2:15 PM M

[PULL 4/4] ui/gtk: prevent ui lock up when dpy_gl_update called again before current draw event occurs

2022-11-23 Thread Gerd Hoffmann
From: Dongwon Kim A warning, "qemu: warning: console: no gl-unblock within" followed by guest scanout lockup can happen if dpy_gl_update is called in a row and the second call is made before gd_draw_event scheduled by the first call is taking place. This is because draw call returns without decre

[PULL 2/4] gtk: disable GTK Clipboard with a new meson option

2022-11-23 Thread Gerd Hoffmann
From: Claudio Fontana The GTK Clipboard implementation may cause guest hangs. Therefore implement new configure switch: --enable-gtk-clipboard, as a meson option disabled by default, which warns in the help text about the experimental nature of the feature. Regenerate the meson build options to

[PULL 3/4] hw/usb/hcd-xhci.c: spelling: tranfer

2022-11-23 Thread Gerd Hoffmann
From: Michael Tokarev Fixes: effaf5a240e03020f4ae953e10b764622c3e87cc Signed-off-by: Michael Tokarev Reviewed-by: Thomas Huth Reviewed-by: Stefan Weil Message-Id: <20221105114851.306206-1-...@msgid.tls.msk.ru> Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 2 +- 1 file changed, 1 inser

[PULL 0/4] Fixes 20221124 patches

2022-11-23 Thread Gerd Hoffmann
The following changes since commit 7c09a7f6ae1770d15535980d15dffdb23f4d9786: Update VERSION for v7.2.0-rc2 (2022-11-22 18:59:56 -0500) are available in the Git repository at: https://gitlab.com/kraxel/qemu.git tags/fixes-20221124-pull-request for you to fetch changes up to 64f1359bd08060ffe

[PULL 1/4] Revert "usbredir: avoid queuing hello packet on snapshot restore"

2022-11-23 Thread Gerd Hoffmann
From: Joelle van Dyne Run state is also in RUN_STATE_PRELAUNCH while "-S" is used. This reverts commit 0631d4b448454ae8a1ab091c447e3f71ab6e088a Signed-off-by: Joelle van Dyne Reviewed-by: Ján Tomko The original commit broke the usage of usbredir with libvirt, which starts every domain with "

Re: [PATCH] hw/usb: add configuration flags for emulated and passthru usb smartcard

2022-11-23 Thread Paolo Bonzini
Il mer 23 nov 2022, 08:59 Marc-André Lureau ha scritto: > config USB_SMARTCARD_PASSTHRU > bool > default y > select USB_SMARTCARD > > config USB_SMARTCARD_EMULATED > bool > default y > select USB_SMARTCARD > Yes, this is the way. (TM) Also, you should add a "config LIBCA

Re: [PATCH for 7.2?] vhost: fix vq dirt bitmap syncing when vIOMMU is enabled

2022-11-23 Thread Michael S. Tsirkin
On Thu, Nov 24, 2022 at 12:12:15PM +0800, Jason Wang wrote: > On Wed, Nov 23, 2022 at 3:21 PM Michael S. Tsirkin wrote: > > > > On Wed, Nov 23, 2022 at 03:08:25PM +0800, Jason Wang wrote: > > > On Wed, Nov 23, 2022 at 2:15 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Wed, Nov 23, 2022 a

Re: [PATCH v5 01/15] block-io: introduce coroutine_fn duplicates for bdrv_common_block_status_above callers

2022-11-23 Thread Paolo Bonzini
Il mer 23 nov 2022, 17:29 Kevin Wolf ha scritto: > As I said, personally, I don't feel like putting QEMU_IN_COROUTINE() > assertions into every coroutine_fn is a useful thing to do. Static > analysis (maybe even with something vrc based in 'make check'? Paolo, > would this be realistic?) Yes, u

Re: [PATCH v5 07/15] block: introduce QEMU_IN_COROUTINE macro

2022-11-23 Thread Paolo Bonzini
Il mer 23 nov 2022, 17:49 Kevin Wolf ha scritto: > I already asked about other opinions on this in patch 1. > > These assertions are runtime checks and I don't feel they are the right > tool to verify coroutine_fn consistency. Asserting in tricky places > makes sense to me, especially as long as

Re: [PATCH for-7.2] vhost: enable vrings in vhost_dev_start() for vhost-user devices

2022-11-23 Thread Michael S. Tsirkin
On Thu, Nov 24, 2022 at 12:19:25AM +, Raphael Norwitz wrote: > > > On Nov 23, 2022, at 8:16 AM, Stefano Garzarella wrote: > > > > Commit 02b61f38d3 ("hw/virtio: incorporate backend features in features") > > properly negotiates VHOST_USER_F_PROTOCOL_FEATURES with the vhost-user > > backend,

[PATCH 2/2] target/ppc: Check DEXCR on hash{st, chk} instructions

2022-11-23 Thread Nicholas Miehlbradt
Adds checks to the hashst and hashchk instructions to only execute if enabled by the relevant aspect in the DEXCR and HDEXCR. This behaviour is guarded behind TARGET_PPC64 since Power10 is currently the only implementation which has the DEXCR. Signed-off-by: Nicholas Miehlbradt --- target/ppc/e

[PATCH 1/2] target/ppc: Implement the DEXCR and HDEXCR

2022-11-23 Thread Nicholas Miehlbradt
Define the DEXCR and HDEXCR as special purpose registers. Each register occupies two SPR indicies, one which can be read in an unprivileged state and one which can be modified in the appropriate priviliged state, however both indicies refer to the same underlying value. Note that the ISA uses the

[PATCH 0/2] target/ppc: Implement Dynamic Execution Control Registers

2022-11-23 Thread Nicholas Miehlbradt
Implements the Dynamic Execution Control Register (DEXCR) and the Hypervisor Dynamic Execution Control Register (HDEXCR) in TCG as defined in Power ISA 3.1B. Only aspects 5 (Non-privileged hash instruction enable) and 6 (Privileged hash instruction enable) have architectural effects. Other aspec

Re: [PATCH for 7.2?] vhost: fix vq dirt bitmap syncing when vIOMMU is enabled

2022-11-23 Thread Jason Wang
On Wed, Nov 23, 2022 at 3:21 PM Michael S. Tsirkin wrote: > > On Wed, Nov 23, 2022 at 03:08:25PM +0800, Jason Wang wrote: > > On Wed, Nov 23, 2022 at 2:15 PM Michael S. Tsirkin wrote: > > > > > > On Wed, Nov 23, 2022 at 01:47:04PM +0800, Jason Wang wrote: > > > > On Wed, Nov 23, 2022 at 1:26 PM J

Re: [PATCH for-7.2] vhost: enable vrings in vhost_dev_start() for vhost-user devices

2022-11-23 Thread Raphael Norwitz
> On Nov 23, 2022, at 8:16 AM, Stefano Garzarella wrote: > > Commit 02b61f38d3 ("hw/virtio: incorporate backend features in features") > properly negotiates VHOST_USER_F_PROTOCOL_FEATURES with the vhost-user > backend, but we forgot to enable vrings as specified in > docs/interop/vhost-user.rst

[ANNOUNCE] QEMU 7.2.0-rc2 is now available

2022-11-23 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the third release candidate for the QEMU 7.2 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-7.2.0-rc2.tar.xz http://downlo

Re: [RFC PATCH] tests/avocado: use new rootfs for orangepi test

2022-11-23 Thread Philippe Mathieu-Daudé
On 23/11/22 19:49, Cédric Le Goater wrote: On 11/23/22 19:13, Philippe Mathieu-Daudé wrote: On 23/11/22 15:12, Alex Bennée wrote: Thomas Huth writes: On 23/11/2022 12.15, Philippe Mathieu-Daudé wrote: On 18/11/22 12:33, Alex Bennée wrote: The old URL wasn't stable. I suspect the current URL

Re: [PULL 0/7] Fixes 20221123 patches

2022-11-23 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/3] Avocado tests and qtests improvements

2022-11-23 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes. signature.asc Description: PGP signature

[PATCH] cpu/i386: update xsave components after CPUID filtering

2022-11-23 Thread Huanyu ZHAI
Subject: [PATCH] cpu/i386: update xsave components after CPUID filtering On i386 platform, CPUID data are setup through three consecutive steps: CPU model definition, expansion and filtering. XSAVE components are enabled during the expansion stage, by checking if they are enabled in CPUID. Howev

Re: [PULL 0/7] Fixes 20221123 patches

2022-11-23 Thread Peter Maydell
axel/qemu.git tags/fixes-20221123-pull-request > > for you to fetch changes up to 7d3cf19548b7f9afd9d25c30dd1450aad7d1877d: > > hw/audio/intel-hda: Drop unnecessary prototype (2022-11-23 12:30:45 +0100) > > ---

Re: [PATCH v2] vfio/pci: Verify each MSI vector to avoid invalid MSI vectors

2022-11-23 Thread Alex Williamson
On Wed, 23 Nov 2022 12:08:05 + Marc Zyngier wrote: > On Wed, 23 Nov 2022 01:42:36 +, > chenxiang wrote: > > > > From: Xiang Chen > > > > Currently the number of MSI vectors comes from register PCI_MSI_FLAGS > > which should be power-of-2 in qemu, in some scenaries it is not the same a

Re: [PATCH v3 12/17] vfio/migration: Implement VFIO migration protocol v2

2022-11-23 Thread Dr. David Alan Gilbert
* Avihai Horon (avih...@nvidia.com) wrote: > +ret = qemu_file_get_to_fd(f, migration->data_fd, data_size); > +if (!ret) { > +trace_vfio_load_state_device_data(vbasedev->name, data_size); > + > +} I notice you had a few cases like that; I wouldn't bother making that condition

Re: [RFC PATCH] tests/avocado: use new rootfs for orangepi test

2022-11-23 Thread Cédric Le Goater
On 11/23/22 19:13, Philippe Mathieu-Daudé wrote: On 23/11/22 15:12, Alex Bennée wrote: Thomas Huth writes: On 23/11/2022 12.15, Philippe Mathieu-Daudé wrote: On 18/11/22 12:33, Alex Bennée wrote: The old URL wasn't stable. I suspect the current URL will only be stable for a few months so may

Re: [PATCH v3 01/17] migration: Remove res_compatible parameter

2022-11-23 Thread Dr. David Alan Gilbert
* Avihai Horon (avih...@nvidia.com) wrote: > > On 08/11/2022 19:52, Vladimir Sementsov-Ogievskiy wrote: > > External email: Use caution opening links or attachments > > > > > > On 11/3/22 19:16, Avihai Horon wrote: > > > From: Juan Quintela > > > > > > It was only used for RAM, and in that cas

Re: [PATCH] gdbstub: move update guest debug to accel ops

2022-11-23 Thread Philippe Mathieu-Daudé
Hi, On 23/11/22 13:17, Mads Ynddal wrote: From: Mads Ynddal Continuing the refactor of a48e7d9e52 (gdbstub: move guest debug support check to ops) by removing hardcoded kvm_enabled() from generic cpu.c code, and replace it with a property of AccelOpsClass. Signed-off-by: Mads Ynddal --- ac

Re: [RFC PATCH] tests/avocado: use new rootfs for orangepi test

2022-11-23 Thread Philippe Mathieu-Daudé
On 23/11/22 15:12, Alex Bennée wrote: Thomas Huth writes: On 23/11/2022 12.15, Philippe Mathieu-Daudé wrote: On 18/11/22 12:33, Alex Bennée wrote: The old URL wasn't stable. I suspect the current URL will only be stable for a few months so maybe we need another strategy for hosting rootfs sna

Re: [PATCH 00/15] Protect the block layer with a rwlock: part 3

2022-11-23 Thread Kevin Wolf
Am 23.11.2022 um 18:04 hat Paolo Bonzini geschrieben: > On 11/23/22 14:45, Kevin Wolf wrote: > > I think this means that if we clean up everything, in the end we'll have > > coroutine_wrapper and coroutine_wrapper_bdrv (the fourth version not in > > the above list, but that Paolo mentioned we may w

Re: [PATCH v5 1/2] io: Add support for MSG_PEEK for socket channel

2022-11-23 Thread Peter Xu
On Wed, Nov 23, 2022 at 05:27:34PM +, manish.mishra wrote: > MSG_PEEK reads from the peek of channel, The data is treated as > unread and the next read shall still return this data. This > support is currently added only for socket class. Extra parameter > 'flags' is added to io_readv calls to

Re: [PATCH v2] Drop more useless casts from void * to pointer

2022-11-23 Thread Markus Armbruster
BALATON Zoltan writes: > On Wed, 23 Nov 2022, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >>> On Wed, Nov 23, 2022 at 02:51:49PM +0100, BALATON Zoltan wrote: On Wed, 23 Nov 2022, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > Reviewed-by: Laurent Vivier >

Re: [PATCH v9 3/8] KVM: Add KVM_EXIT_MEMORY_FAULT exit

2022-11-23 Thread Sean Christopherson
On Tue, Nov 22, 2022, Chao Peng wrote: > On Fri, Nov 18, 2022 at 03:59:12PM +, Sean Christopherson wrote: > > On Fri, Nov 18, 2022, Alex Benn?e wrote: > > > > We don't actually need a new bit, the opposite side of private is > > > > shared, i.e. flags with KVM_MEMORY_EXIT_FLAG_PRIVATE cleared e

Re: [PATCH 3/4] hw/cxl: Multi-Region CXL Type-3 Devices (Volatile and Persistent)

2022-11-23 Thread Gregory Price
> > - -object > > memory-backend-file,id=cxl-mem1,share=on,mem-path=/tmp/cxltest.raw,size=256M > > \ > > - -object > > memory-backend-file,id=cxl-lsa1,share=on,mem-path=/tmp/lsa.raw,size=256M \ > > + -object > > memory-backend-file,pmem=true,id=pmem0,share=on,mem-path=/tmp/cxltest.raw,size=2

Re: [RFC 6/7] migration: simplify migration_iteration_run()

2022-11-23 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > migration/migration.c | 24 > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/migration/migration.c b/migration/migration.c > ind

[PATCH v5 0/2] check magic value for deciding the mapping of channels

2022-11-23 Thread manish.mishra
Current logic assumes that channel connections on the destination side are always established in the same order as the source and the first one will always be the main channel followed by the multifid or post-copy preemption channel. This may not be always true, as even if a channel has a connectio

[PATCH v5 1/2] io: Add support for MSG_PEEK for socket channel

2022-11-23 Thread manish.mishra
MSG_PEEK reads from the peek of channel, The data is treated as unread and the next read shall still return this data. This support is currently added only for socket class. Extra parameter 'flags' is added to io_readv calls to pass extra read flags like MSG_PEEK. Reviewed-by: Daniel P. Berrangé

[PATCH v5 2/2] migration: check magic value for deciding the mapping of channels

2022-11-23 Thread manish.mishra
Current logic assumes that channel connections on the destination side are always established in the same order as the source and the first one will always be the main channel followed by the multifid or post-copy preemption channel. This may not be always true, as even if a channel has a connectio

Re: [PATCH v5 13/15] block-coroutine-wrapper.py: support also basic return types

2022-11-23 Thread Kevin Wolf
Am 23.11.2022 um 12:42 hat Emanuele Giuseppe Esposito geschrieben: > Extend the regex to cover also return type, pointers included. > This implies that the value returned by the function cannot be > a simple "int" anymore, but the custom return type. > Therefore remove poll_state->ret and instead u

Re: [PATCH v5 12/15] block-coroutine-wrapper.py: default to main loop aiocontext if function does not have a BlockDriverState parameter

2022-11-23 Thread Kevin Wolf
Am 23.11.2022 um 12:42 hat Emanuele Giuseppe Esposito geschrieben: > Right now, we take the first parameter of the function to get the > BlockDriverState to pass to bdrv_poll_co(), that internally calls > functions that figure in which aiocontext the coroutine should run. > > However, it is useles

Re: [PATCH v5 10/15] block-coroutine-wrapper.py: introduce generated_co_wrapper_simple

2022-11-23 Thread Kevin Wolf
Am 23.11.2022 um 12:42 hat Emanuele Giuseppe Esposito geschrieben: > This new annotation creates just a function wrapper that creates > a new coroutine. It assumes the caller is not a coroutine. > > This is much better as g_c_w, because it is clear if the caller > is a coroutine or not, and provid

Re: [PATCH 00/15] Protect the block layer with a rwlock: part 3

2022-11-23 Thread Paolo Bonzini
On 11/23/22 14:45, Kevin Wolf wrote: I think this means that if we clean up everything, in the end we'll have coroutine_wrapper and coroutine_wrapper_bdrv (the fourth version not in the above list, but that Paolo mentioned we may want to have). Yes, I agree. The only thing I'm unsure about is

Re: [PATCH v5 09/15] block: bdrv_create_file is a coroutine_fn

2022-11-23 Thread Kevin Wolf
Am 23.11.2022 um 12:42 hat Emanuele Giuseppe Esposito geschrieben: > It is always called in coroutine_fn callbacks, therefore > it can directly call bdrv_co_create(). > > Rename it to bdrv_co_create_file too. > > Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Kevin Wolf

Re: [PATCH v5 08/15] block: distinguish between bdrv_create running in coroutine and not

2022-11-23 Thread Kevin Wolf
Am 23.11.2022 um 12:42 hat Emanuele Giuseppe Esposito geschrieben: > Call two different functions depending on whether bdrv_create > is in coroutine or not, following the same pattern as > generated_co_wrapper functions. > > This allows to also call the coroutine function directly, > without using

Re: [PATCH v5 07/15] block: introduce QEMU_IN_COROUTINE macro

2022-11-23 Thread Kevin Wolf
Am 23.11.2022 um 12:42 hat Emanuele Giuseppe Esposito geschrieben: > This macro will be used to mark all coroutine_fn functions. > Right now, it will be used for the newly introduced coroutine_fn, since > we know the callers. > > As a TODO, in the future we might want to add this macro to all > co

Re: [PATCH v5 06/15] block: avoid duplicating filename string in bdrv_create

2022-11-23 Thread Kevin Wolf
Am 23.11.2022 um 12:42 hat Emanuele Giuseppe Esposito geschrieben: > We know that the string will stay around until the function > returns, and the parameter of drv->bdrv_co_create_opts is const char*, > so it must not be modified either. > > Suggested-by: Kevin Wolf > Signed-off-by: Emanuele Giu

Re: [PATCH v5 04/15] block-backend: replace bdrv_*_above with blk_*_above

2022-11-23 Thread Kevin Wolf
Am 23.11.2022 um 12:42 hat Emanuele Giuseppe Esposito geschrieben: > Avoid mixing bdrv_* functions with blk_*, so create blk_* counterparts > for bdrv_block_status_above and bdrv_is_allocated_above. > > Note that since bdrv_block_status_above only calls the g_c_w function > bdrv_common_block_statu

Re: [RFC 5/7] migration: Remove unused threshold_size parameter

2022-11-23 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Until previous commit, save_live_pending() was used for ram. Now with > the split into state_pending_estimate() and state_pending_exact() it > is not needed anymore, so remove them. > > Signed-off-by: Juan Quintela > --- > include/migration/registe

Re: [PATCH v5 02/15] block-copy: add missing coroutine_fn annotations

2022-11-23 Thread Kevin Wolf
Am 23.11.2022 um 12:42 hat Emanuele Giuseppe Esposito geschrieben: > These functions end up calling bdrv_common_block_status_above(), a > generated_co_wrapper function. > In addition, they also happen to be always called in coroutine context, > meaning all callers are coroutine_fn. > This means tha

Re: [PATCH v4 2/2] migration: check magic value for deciding the mapping of channels

2022-11-23 Thread manish.mishra
On 23/11/22 9:57 pm, Peter Xu wrote: On Wed, Nov 23, 2022 at 09:28:14PM +0530, manish.mishra wrote: On 23/11/22 9:22 pm, Peter Xu wrote: On Wed, Nov 23, 2022 at 03:05:27PM +, manish.mishra wrote: +int migration_channel_read_peek(QIOChannel *ioc, +const cha

Re: [PATCH v2] Drop more useless casts from void * to pointer

2022-11-23 Thread BALATON Zoltan
On Wed, 23 Nov 2022, Markus Armbruster wrote: Daniel P. Berrangé writes: On Wed, Nov 23, 2022 at 02:51:49PM +0100, BALATON Zoltan wrote: On Wed, 23 Nov 2022, Markus Armbruster wrote: Signed-off-by: Markus Armbruster Reviewed-by: Laurent Vivier --- v2: * PATCH 1+2 merged as commit 0a553c12c7

Re: [PATCH v5 01/15] block-io: introduce coroutine_fn duplicates for bdrv_common_block_status_above callers

2022-11-23 Thread Kevin Wolf
Am 23.11.2022 um 12:42 hat Emanuele Giuseppe Esposito geschrieben: > bdrv_common_block_status_above() is a g_c_w, and it is being called by > many "wrapper" functions like bdrv_is_allocated(), > bdrv_is_allocated_above() and bdrv_block_status_above(). > > Because we want to eventually split the co

Re: [PATCH v4 2/2] migration: check magic value for deciding the mapping of channels

2022-11-23 Thread Peter Xu
On Wed, Nov 23, 2022 at 09:28:14PM +0530, manish.mishra wrote: > > On 23/11/22 9:22 pm, Peter Xu wrote: > > On Wed, Nov 23, 2022 at 03:05:27PM +, manish.mishra wrote: > > > +int migration_channel_read_peek(QIOChannel *ioc, > > > +const char *buf, > > > +

Re: [qemu-web PATCH] Add a blog post about zoned storage emulation

2022-11-23 Thread Stefan Hajnoczi
Cool, thanks for posting an update. An short introduction would be nice before diving into the details of ZBDs: "This summer I worked on adding Zoned Block Device (ZBD) support to virtio-blk as part of the https://www.outreachy.org/";>Outreachy internship program. QEMU hasn't directly supported ZB

Re: [PATCH 3/3] tcg: Move ffi_cif pointer into TCGHelperInfo

2022-11-23 Thread Philippe Mathieu-Daudé
On 22/11/22 19:08, Philippe Mathieu-Daudé wrote: From: Richard Henderson Instead of requiring a separate hash table lookup, put a pointer to the CIF into TCGHelperInfo. Signed-off-by: Richard Henderson Message-Id: <2022074101.2069454-27-richard.hender...@linaro.org> [PMD: Split from bigge

Re: [PATCH v4 2/2] migration: check magic value for deciding the mapping of channels

2022-11-23 Thread Daniel P . Berrangé
On Wed, Nov 23, 2022 at 09:34:35PM +0530, manish.mishra wrote: > > On 23/11/22 9:28 pm, Daniel P. Berrangé wrote: > > On Wed, Nov 23, 2022 at 03:05:27PM +, manish.mishra wrote: > > > Current logic assumes that channel connections on the destination side are > > > always established in the same

Re: [PATCH for 7.2-rc3 v1 0/2] virtio fixes

2022-11-23 Thread Michael S. Tsirkin
On Wed, Nov 23, 2022 at 04:03:49PM +, Alex Bennée wrote: > > "Michael S. Tsirkin" writes: > > > On Wed, Nov 23, 2022 at 03:21:32PM +, Alex Bennée wrote: > >> Hi, > >> > >> This hopefully fixes the problems with VirtIO migration caused by the > >> previous refactoring of virtio_device_st

Re: [PATCH v4 2/2] migration: check magic value for deciding the mapping of channels

2022-11-23 Thread manish.mishra
On 23/11/22 9:28 pm, Daniel P. Berrangé wrote: On Wed, Nov 23, 2022 at 03:05:27PM +, manish.mishra wrote: Current logic assumes that channel connections on the destination side are always established in the same order as the source and the first one will always be the main channel followed

Re: [PATCH for 7.2-rc3 v1 0/2] virtio fixes

2022-11-23 Thread Alex Bennée
"Michael S. Tsirkin" writes: > On Wed, Nov 23, 2022 at 03:21:32PM +, Alex Bennée wrote: >> Hi, >> >> This hopefully fixes the problems with VirtIO migration caused by the >> previous refactoring of virtio_device_started(). That introduced a >> different order of checking which didn't give

Re: [PATCH v4 2/2] migration: check magic value for deciding the mapping of channels

2022-11-23 Thread manish.mishra
On 23/11/22 9:22 pm, Peter Xu wrote: On Wed, Nov 23, 2022 at 03:05:27PM +, manish.mishra wrote: +int migration_channel_read_peek(QIOChannel *ioc, +const char *buf, +const size_t buflen, +Error *

Re: [PATCH v4 2/2] migration: check magic value for deciding the mapping of channels

2022-11-23 Thread Daniel P . Berrangé
On Wed, Nov 23, 2022 at 03:05:27PM +, manish.mishra wrote: > Current logic assumes that channel connections on the destination side are > always established in the same order as the source and the first one will > always be the main channel followed by the multifid or post-copy > preemption cha

Re: [PATCH v4 2/2] migration: check magic value for deciding the mapping of channels

2022-11-23 Thread Peter Xu
On Wed, Nov 23, 2022 at 03:05:27PM +, manish.mishra wrote: > +int migration_channel_read_peek(QIOChannel *ioc, > +const char *buf, > +const size_t buflen, > +Error **errp) > +{ > + ssize_t len = 0;

Re: [PATCH v4 1/2] io: Add support for MSG_PEEK for socket channel

2022-11-23 Thread Daniel P . Berrangé
On Wed, Nov 23, 2022 at 03:05:26PM +, manish.mishra wrote: > MSG_PEEK reads from the peek of channel, The data is treated as > unread and the next read shall still return this data. This > support is currently added only for socket class. Extra parameter > 'flags' is added to io_readv calls to

Re: [PATCH v2 2/3] hw/mips/malta: Set PIIX4 IRQ routes in embedded bootloader

2022-11-23 Thread Jiaxun Yang
> 2022年11月22日 12:37,BALATON Zoltan 写道: > > Hello, > > On Mon, 21 Nov 2022, Bernhard Beschow wrote: >> Am 21. November 2022 22:43:50 UTC schrieb "Philippe Mathieu-Daudé" >> : >>> On 21/11/22 16:34, Bernhard Beschow wrote: Am 27. Oktober 2022 20:47:19 UTC schrieb "Philippe Mathieu-Daudé"

Re: [PATCH for 7.2-rc3 v1 0/2] virtio fixes

2022-11-23 Thread Michael S. Tsirkin
On Wed, Nov 23, 2022 at 03:21:32PM +, Alex Bennée wrote: > Hi, > > This hopefully fixes the problems with VirtIO migration caused by the > previous refactoring of virtio_device_started(). That introduced a > different order of checking which didn't give the VM state primacy but > wasn't notice

Re: [qemu-web PATCH] Add a blog post about zoned storage emulation

2022-11-23 Thread Sam Li
Thomas Huth 于2022年11月23日周三 20:48写道: > > On 17/11/2022 20.12, Stefan Hajnoczi wrote: > > Hi Sam, > > Please send a git repo URL so Thomas can fetch the commit without > > email/file size limitations. > > The size obviously comes from the PNG image ... since this seems to be a > photo, I think JPG w

[PATCH v1 1/2] include/hw: attempt to document VirtIO feature variables

2022-11-23 Thread Alex Bennée
We have a bunch of variables associated with the device and the vhost backend which are used inconsistently throughout the code base. Lets start trying to bring some order by agreeing what each variable is for. Signed-off-by: Alex Bennée Cc: Stefano Garzarella Cc: "Michael S. Tsirkin" Cc: Stefa

[PATCH v1 2/2] include/hw: VM state takes precedence in virtio_device_should_start

2022-11-23 Thread Alex Bennée
The VM status should always preempt the device status for these checks. This ensures the device is in the correct state when we suspend the VM prior to migrations. This restores the checks to the order they where in before the refactoring moved things around. While we are at it lets improve our do

[PATCH for 7.2-rc3 v1 0/2] virtio fixes

2022-11-23 Thread Alex Bennée
Hi, This hopefully fixes the problems with VirtIO migration caused by the previous refactoring of virtio_device_started(). That introduced a different order of checking which didn't give the VM state primacy but wasn't noticed as we don't properly exercise VirtIO device migration and caused issues

Re: [PATCH] target/mips: Properly set C0_CMGCRBase after CPU reset

2022-11-23 Thread Jiaxun Yang
> 2022年11月14日 16:25,Jiaxun Yang 写道: > > Value of C0_CMGCRBase will be reseted to default when cpu reset > happens. In some cases software may move GCR base and then initiate > a CPU reset, this will leave C0_CMGCRBase of reseted core incorrect. > > Implement a callback in CMGCR device to allo

Re: [PATCH v2] Drop more useless casts from void * to pointer

2022-11-23 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Nov 23, 2022 at 02:51:49PM +0100, BALATON Zoltan wrote: >> On Wed, 23 Nov 2022, Markus Armbruster wrote: >> > Signed-off-by: Markus Armbruster >> > Reviewed-by: Laurent Vivier >> > --- >> > v2: >> > * PATCH 1+2 merged as commit 0a553c12c7 and 3f7febc937 >> >

[PATCH v4 0/2] migration: check magic value for deciding the mapping of channels

2022-11-23 Thread manish.mishra
Current logic assumes that channel connections on the destination side are always established in the same order as the source and the first one will always be the main channel followed by the multifid or post-copy preemption channel. This may not be always true, as even if a channel has a connectio

[PATCH v4 2/2] migration: check magic value for deciding the mapping of channels

2022-11-23 Thread manish.mishra
Current logic assumes that channel connections on the destination side are always established in the same order as the source and the first one will always be the main channel followed by the multifid or post-copy preemption channel. This may not be always true, as even if a channel has a connectio

[PATCH v4 1/2] io: Add support for MSG_PEEK for socket channel

2022-11-23 Thread manish.mishra
MSG_PEEK reads from the peek of channel, The data is treated as unread and the next read shall still return this data. This support is currently added only for socket class. Extra parameter 'flags' is added to io_readv calls to pass extra read flags like MSG_PEEK. Suggested-by: Daniel P. Berrangé

arm: gdb-stub is broken by FEAT_HAFDBS

2022-11-23 Thread Changbin Du via
Hello, Richard, We just noticed the gdb-stub is broken and probably caused by commit 4a3585568 ("target/arm: Plumb debug into S1Translate"). (gdb) target remote :1234 Remote debugging using :1234 0x0e1716d0 in ?? () => 0x0e1716d0: Cannot access memory at address 0xe1716d0 This is

[QEMU][Question] Is there any way to backup a dirty-bitmap that can be executed at the other server?

2022-11-23 Thread 너구리맨
First of all, Thanks for the hard work. With QMP, I can backup dirty-bitmap - like 'blockdev-backup' incremental sync mode. But this command should be executed at the host where the QEMU process is live. I want to execute a backup at the other host so it does not affect running Guest. - `blockdev

[PULL 6/7] hw/audio/intel-hda: don't reset codecs twice

2022-11-23 Thread Gerd Hoffmann
From: Peter Maydell Currently the intel-hda device has a reset method which manually resets all the codecs by calling device_legacy_reset() on them. This means they get reset twice, once because child devices on a qbus get reset before the parent device's reset method is called, and then again b

[PULL 7/7] hw/audio/intel-hda: Drop unnecessary prototype

2022-11-23 Thread Gerd Hoffmann
From: Peter Maydell The only use of intel_hda_reset() is after its definition, so we don't need to separately declare its prototype at the top of the file; drop the unnecessary line. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20221014142632.2092404-3-peter.ma

[PULL 4/7] ui/gtk: prevent ui lock up when dpy_gl_update called again before current draw event occurs

2022-11-23 Thread Gerd Hoffmann
From: Dongwon Kim A warning, "qemu: warning: console: no gl-unblock within" followed by guest scanout lockup can happen if dpy_gl_update is called in a row and the second call is made before gd_draw_event scheduled by the first call is taking place. This is because draw call returns without decre

[PULL 1/7] Revert "usbredir: avoid queuing hello packet on snapshot restore"

2022-11-23 Thread Gerd Hoffmann
From: Joelle van Dyne Run state is also in RUN_STATE_PRELAUNCH while "-S" is used. This reverts commit 0631d4b448454ae8a1ab091c447e3f71ab6e088a Signed-off-by: Joelle van Dyne Reviewed-by: Ján Tomko The original commit broke the usage of usbredir with libvirt, which starts every domain with "

[PULL 2/7] gtk: disable GTK Clipboard with a new meson option

2022-11-23 Thread Gerd Hoffmann
From: Claudio Fontana The GTK Clipboard implementation may cause guest hangs. Therefore implement new configure switch: --enable-gtk-clipboard, as a meson option disabled by default, which warns in the help text about the experimental nature of the feature. Regenerate the meson build options to

[PULL 0/7] Fixes 20221123 patches

2022-11-23 Thread Gerd Hoffmann
The following changes since commit 7c09a7f6ae1770d15535980d15dffdb23f4d9786: Update VERSION for v7.2.0-rc2 (2022-11-22 18:59:56 -0500) are available in the Git repository at: https://gitlab.com/kraxel/qemu.git tags/fixes-20221123-pull-request for you to fetch changes up to

[PULL 5/7] hw/usb/hcd-xhci: Reset the XHCIState with device_cold_reset()

2022-11-23 Thread Gerd Hoffmann
From: Peter Maydell Currently the hcd-xhci-pci and hcd-xhci-sysbus devices, which are mostly wrappers around the TYPE_XHCI device, which is a direct subclass of TYPE_DEVICE. Since TYPE_DEVICE devices are not on any qbus and do not get automatically reset, the wrapper devices both reset the TYPE_

[PULL 3/7] hw/usb/hcd-xhci.c: spelling: tranfer

2022-11-23 Thread Gerd Hoffmann
From: Michael Tokarev Fixes: effaf5a240e03020f4ae953e10b764622c3e87cc Signed-off-by: Michael Tokarev Reviewed-by: Thomas Huth Reviewed-by: Stefan Weil Message-Id: <20221105114851.306206-1-...@msgid.tls.msk.ru> Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 2 +- 1 file changed, 1 inser

Re: [PATCH] gdbstub: move update guest debug to accel ops

2022-11-23 Thread Mads Ynddal
> On 23 Nov 2022, at 15.05, Alex Bennée wrote: > > Nice. Looks good to me but I'll have a proper look when I go through my > gdbstub/next queue. I don't think this is critical for 7.2. > Thanks, and I agree. It can easily wait.

[PULL 0/3] Avocado tests and qtests improvements

2022-11-23 Thread Thomas Huth
Hi Stefan! The following changes since commit 7c09a7f6ae1770d15535980d15dffdb23f4d9786: Update VERSION for v7.2.0-rc2 (2022-11-22 18:59:56 -0500) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2022-11-23 for you to fetch changes up to 4189af72d

[PULL 1/3] tests/avocado: Update the URLs of the advent calendar images

2022-11-23 Thread Thomas Huth
The qemu-advent-calendar.org server will be decommissioned soon. I've mirrored the images that we use for the QEMU CI to gitlab, so update their URLs to point to the new location. Message-Id: <20221121102436.78635-1-th...@redhat.com> Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu

[PULL 2/3] tests/qtest: Decrease the amount of output from the qom-test

2022-11-23 Thread Thomas Huth
The logs in the gitlab-CI have a size constraint, and sometimes we already hit this limit. The biggest part of the log then seems to be filled by the qom-test, so we should decrease the size of the output - which can be done easily by not printing the path for each property, since the path has alre

[PULL 3/3] tests/avocado: use new rootfs for orangepi test

2022-11-23 Thread Thomas Huth
From: Alex Bennée The old URL wasn't stable. I suspect the current URL will only be stable for a few months so maybe we need another strategy for hosting rootfs snapshots? Signed-off-by: Alex Bennée Message-Id: <20221118113309.1057790-1-alex.ben...@linaro.org> Signed-off-by: Thomas Huth --- t

Re: [PATCH] vhost: mask VIRTIO_F_RING_RESET for vhost and vhost-user devices

2022-11-23 Thread Stefano Garzarella
On Tue, Nov 22, 2022 at 07:01:38PM +0100, Eugenio Perez Martin wrote: On Tue, Nov 22, 2022 at 4:13 AM Jason Wang wrote: On Mon, Nov 21, 2022 at 6:11 PM Stefano Garzarella wrote: > > Commit 69e1c14aa2 ("virtio: core: vq reset feature negotation support") > enabled VIRTIO_F_RING_RESET by defaul

Re: [RFC PATCH] tests/avocado: use new rootfs for orangepi test

2022-11-23 Thread Alex Bennée
Thomas Huth writes: > On 23/11/2022 12.15, Philippe Mathieu-Daudé wrote: >> On 18/11/22 12:33, Alex Bennée wrote: >>> The old URL wasn't stable. I suspect the current URL will only be >>> stable for a few months so maybe we need another strategy for hosting >>> rootfs snapshots? >>> >>> Signed-

Re: [PATCH v6 11/11] tests/qtest: Enable qtest build on Windows

2022-11-23 Thread Thomas Huth
On 23/11/2022 15.13, Marc-André Lureau wrote: Hi Bin On Fri, Oct 28, 2022 at 9:06 AM Bin Meng wrote: Now that we have fixed various test case issues as seen when running on Windows, let's enable the qtest build on Windows. Signed-off-by: Bin Meng Reviewed-by: Thomas Huth We haven't solve

Re: [PATCH v6 11/11] tests/qtest: Enable qtest build on Windows

2022-11-23 Thread Marc-André Lureau
Hi Bin On Fri, Oct 28, 2022 at 9:06 AM Bin Meng wrote: > > Now that we have fixed various test case issues as seen when running > on Windows, let's enable the qtest build on Windows. > > Signed-off-by: Bin Meng > Reviewed-by: Thomas Huth We haven't solved the CI timing out or eating all the CP

Re: [PATCH v2] Drop more useless casts from void * to pointer

2022-11-23 Thread Daniel P . Berrangé
On Wed, Nov 23, 2022 at 02:51:49PM +0100, BALATON Zoltan wrote: > On Wed, 23 Nov 2022, Markus Armbruster wrote: > > Signed-off-by: Markus Armbruster > > Reviewed-by: Laurent Vivier > > --- > > v2: > > * PATCH 1+2 merged as commit 0a553c12c7 and 3f7febc937 > > * PATCH 3 change to util/coroutine-uc

Re: [PATCH] gdbstub: move update guest debug to accel ops

2022-11-23 Thread Alex Bennée
Mads Ynddal writes: > From: Mads Ynddal > > Continuing the refactor of a48e7d9e52 (gdbstub: move guest debug support > check to ops) by removing hardcoded kvm_enabled() from generic cpu.c > code, and replace it with a property of AccelOpsClass. > > Signed-off-by: Mads Ynddal Nice. Looks good

Re: [PATCH v2] Drop more useless casts from void * to pointer

2022-11-23 Thread BALATON Zoltan
On Wed, 23 Nov 2022, Markus Armbruster wrote: Signed-off-by: Markus Armbruster Reviewed-by: Laurent Vivier --- v2: * PATCH 1+2 merged as commit 0a553c12c7 and 3f7febc937 * PATCH 3 change to util/coroutine-ucontext.c dropped [Laurent] bsd-user/elfload.c | 2 +- contrib/plugi

Re: [PATCH v5 1/2] sysemu: tpm: Add a stub function for TPM_IS_CRB

2022-11-23 Thread Michael S. Tsirkin
On Wed, Nov 23, 2022 at 02:01:32PM +0100, Eric Auger wrote: > > > On 11/23/22 12:24, Michael S. Tsirkin wrote: > > On Wed, Nov 23, 2022 at 12:10:09PM +0100, Eric Auger wrote: > >> > >> On 11/23/22 10:30, Michael S. Tsirkin wrote: > >>> On Wed, Nov 23, 2022 at 09:18:39AM +0100, Eric Auger wrote: >

Re: [PATCH 00/15] Protect the block layer with a rwlock: part 3

2022-11-23 Thread Kevin Wolf
Am 23.11.2022 um 12:45 hat Emanuele Giuseppe Esposito geschrieben: > > > Am 18/11/2022 um 11:57 schrieb Paolo Bonzini: > > On 11/16/22 15:07, Emanuele Giuseppe Esposito wrote: > >> Here we introduce generated_co_wrapper_simple, a simplification of > >> g_c_w that > >> only considers the case wher

[PATCH v2] Drop more useless casts from void * to pointer

2022-11-23 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Laurent Vivier --- v2: * PATCH 1+2 merged as commit 0a553c12c7 and 3f7febc937 * PATCH 3 change to util/coroutine-ucontext.c dropped [Laurent] bsd-user/elfload.c | 2 +- contrib/plugins/cache.c | 8 contr

  1   2   >