Re: [PATCH 2/2] tpm_emulator: Have swtpm relock storage upon migration fall-back

2022-09-07 Thread Marc-André Lureau
Hi On Thu, Sep 8, 2022 at 2:28 AM Stefan Berger wrote: > > Swtpm may release the lock once the last one of its state blobs has been > migrated out. In case of VM migration failure QEMU now needs to notify > swtpm that it should again take the lock, which it can otherwise only do > once it has rec

Re: [PATCH v2] audio: add help option for -audio and -audiodev

2022-09-07 Thread Volker Rümelin
Am 07.09.22 um 19:30 schrieb Claudio Fontana: add a simple help option for -audio and -audiodev to show the list of available drivers, and document them. Signed-off-by: Claudio Fontana --- audio/audio.c | 20 audio/audio.h | 1 + qemu-options.hx | 10 ++

Re: [PATCH 1/2] tpm_emulator: Use latest tpm_ioctl.h from swtpm project

2022-09-07 Thread Marc-André Lureau
On Thu, Sep 8, 2022 at 2:28 AM Stefan Berger wrote: > > Use the latest tpm_ioctl.h from upstream swtpm project. > > Signed-off-by: Stefan Berger Reviewed-by: Marc-André Lureau > --- > backends/tpm/tpm_ioctl.h | 96 +++- > 1 file changed, 76 insertions(+), 2

Re: [PATCH v5 0/2] block: add missed block_acct_setup with new block device init procedure

2022-09-07 Thread Markus Armbruster
"Denis V. Lunev" writes: > On 8/24/22 11:50, Denis V. Lunev wrote: >> Commit 5f76a7aac156ca75680dad5df4a385fd0b58f6b1 is looking harmless from >> the first glance, but it has changed things a lot. 'libvirt' uses it to >> detect that it should follow new initialization way and this changes >> thin

Re: [PATCH] audio: add help option (?) for -audiodev

2022-09-07 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Sep 07, 2022 at 05:06:36PM +0200, Markus Armbruster wrote: >> Claudio Fontana writes: >> >> > add a simple help option for -audiodev, so users can do >> > >> > qemu -audiodev ? >> >> The preferred form is actually '-audiodev help'. The other one is >> depr

Re: [PATCH v7 00/14] KVM: mm: fd-based approach for supporting KVM guest private memory

2022-09-07 Thread Kirill A. Shutemov
On Wed, Aug 31, 2022 at 05:24:39PM +0300, Kirill A . Shutemov wrote: > On Sat, Aug 20, 2022 at 10:15:32PM -0700, Hugh Dickins wrote: > > > I will try next week to rework it as shim to top of shmem. Does it work > > > for you? > > > > Yes, please do, thanks. It's a compromise between us: the initi

RE: [PATCH] Hexagon (target/hexagon) implement mutability mask for GPRs

2022-09-07 Thread Brian Cain
> -Original Message- > From: Qemu-devel > On Behalf Of Anton Johansson via ... > Hi, Brian! > > I've taken a look and most of this patch seems good, however I have a few > comments/observations. Anton, sorry I missed this message last week, only following up now. > > Some registers are

[PATCH 2/2] tpm_emulator: Have swtpm relock storage upon migration fall-back

2022-09-07 Thread Stefan Berger
Swtpm may release the lock once the last one of its state blobs has been migrated out. In case of VM migration failure QEMU now needs to notify swtpm that it should again take the lock, which it can otherwise only do once it has received the first TPM command from the VM. Only try to send the lock

[PATCH 0/2] tpm_emulator: Signal swtpm to again lock storage

2022-09-07 Thread Stefan Berger
Swtpm has been extended to release the lock on the storage where its state is written to upon migration of the last one of its state blobs. Signal swtpm to again lock the storage upon migration fallback. An explicit signal helps swtpm to lock the storage earlier because otherwise it would have to w

[PATCH 1/2] tpm_emulator: Use latest tpm_ioctl.h from swtpm project

2022-09-07 Thread Stefan Berger
Use the latest tpm_ioctl.h from upstream swtpm project. Signed-off-by: Stefan Berger --- backends/tpm/tpm_ioctl.h | 96 +++- 1 file changed, 76 insertions(+), 20 deletions(-) diff --git a/backends/tpm/tpm_ioctl.h b/backends/tpm/tpm_ioctl.h index d67bf0283b..e

Re: [PATCH] Hexagon (target/hexagon) implement mutability mask for GPRs

2022-09-07 Thread Richard Henderson
On 9/6/22 23:26, Taylor Simpson wrote: diff --git a/target/hexagon/genptr.c b/target/hexagon/genptr.c index 8a334ba07b..21385f556e 100644 --- a/target/hexagon/genptr.c +++ b/target/hexagon/genptr.c static inline void gen_log_reg_write(int rnum, TCGv val) { -tcg_gen_mov_tl(hex_new_value[rnu

Re: [PATCH] hw/intc: Handle software disabling of APIC correctly

2022-09-07 Thread Jay Khandkar
Have sent in v2. On Wed, Aug 17, 2022 at 4:20 PM Michael S. Tsirkin wrote: > On Fri, Jul 29, 2022 at 11:04:47PM +0530, Jay Khandkar wrote: > > On Fri, Jul 29, 2022 at 06:09:01PM +0100, Peter Maydell wrote: > > > On Tue, 12 Jul 2022 at 19:38, Jay Khandkar > wrote: > > > > > > > > When the local

[PATCH V2] hw/intc: Handle software disabling of APIC correctly

2022-09-07 Thread Jay Khandkar
When the local APIC is in a software disabled state, all local interrupt sources must be masked and all attempts to unmask them should be ignored. Currently, we don't do either. Fix this by handling it correctly in apic_mem_write(). Signed-off-by: Jay Khandkar --- hw/intc/apic.c | 8 1

Re: Seeing qtest assertion failure with 7.1

2022-09-07 Thread Peter Maydell
On Wed, 7 Sept 2022 at 16:39, Patrick Venture wrote: > > # Start of nvme tests > # Start of pci-device tests > # Start of pci-device-tests tests > # starting QEMU: exec ./qemu-system-aarch64 -qtest unix:/tmp/qtest-1431.sock > -qtest-log /dev/null -chardev socket,path=/tmp/qtest-1431.qmp,id=char0

[PATCH v2] audio: add help option for -audio and -audiodev

2022-09-07 Thread Claudio Fontana
add a simple help option for -audio and -audiodev to show the list of available drivers, and document them. Signed-off-by: Claudio Fontana --- audio/audio.c | 20 audio/audio.h | 1 + qemu-options.hx | 10 ++ softmmu/vl.c| 9 +++-- 4 files changed, 34 i

Re: [PATCH v5 0/2] block: add missed block_acct_setup with new block device init procedure

2022-09-07 Thread Denis V. Lunev
On 8/24/22 11:50, Denis V. Lunev wrote: Commit 5f76a7aac156ca75680dad5df4a385fd0b58f6b1 is looking harmless from the first glance, but it has changed things a lot. 'libvirt' uses it to detect that it should follow new initialization way and this changes things considerably. With this procedure fo

Re: [PATCH for 7.2] minor fixups in block code

2022-09-07 Thread Denis V. Lunev
On 8/17/22 10:37, Denis V. Lunev wrote: These 2 patches are just minor improvements to make code a bit better. Signed-off-by: Denis V. Lunev CC: Kevin Wolf CC: Hanna Reitz CC: Stefan Hajnoczi CC: Fam Zheng CC: Ronnie Sahlberg CC: Paolo Bonzini CC: Peter Lieven CC: Vladimir Sementsov-Ogie

Re: [PATCH 3/8] scripts/ci/setup: Fix libxen requirements

2022-09-07 Thread Alex Bennée
"Lucas Mateus Castro(alqotel)" writes: > XEN hypervisor is only available in ARM and x86, but the yaml only > checked if the architecture is different from s390x, changed it to > a more accurate test. > Tested this change on a Ubuntu 20.04 ppc64le. > > Signed-off-by: Lucas Mateus Castro(alqotel

Re: [PATCH v2 16/20] disas/nanomips: Replace exception handling

2022-09-07 Thread Milica Lazarevic
On 9/5/22 10:55, Milica Lazarevic wrote: > Since there's no support for exception handling in C, the try-catch > blocks have been deleted, and throw clauses are replaced. When a runtime > error happens, we're printing out the error message. Disassembling of > the current instruction interrupts. Th

Re: [PATCH] crypto/block-luks: always set splitkeylen to 0

2022-09-07 Thread Patrick Venture
On Wed, Sep 7, 2022 at 9:34 AM Daniel P. Berrangé wrote: > On Wed, Sep 07, 2022 at 09:21:25AM -0700, Patrick Venture wrote: > > This was caught by a sanitized build, that was perhaps oversensitive. > > > > Signed-off-by: Patrick Venture > > --- > > crypto/block-luks.c | 6 +++--- > > 1 file cha

Re: [PATCH] crypto/block-luks: always set splitkeylen to 0

2022-09-07 Thread Daniel P . Berrangé
On Wed, Sep 07, 2022 at 09:21:25AM -0700, Patrick Venture wrote: > This was caught by a sanitized build, that was perhaps oversensitive. > > Signed-off-by: Patrick Venture > --- > crypto/block-luks.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/crypto/block-luk

Re: [PATCH 0/6] parallels: Add duplication check, repair at open, fix bugs

2022-09-07 Thread Denis V. Lunev
On 9/2/22 10:52, Alexander Ivanov wrote: This patchset is based on git: https://src.openvz.org/~den/qemu.git parallels Fix incorrect data end calculation in parallels_open(). Add parallels_handle_leak() and highest_offset() helpers. Add checking and repairing duplicate offsets in BAT. Dedupli

Re: [PATCH v7 05/14] mm/memfd: Introduce MFD_INACCESSIBLE flag

2022-09-07 Thread Kirill A. Shutemov
On Fri, Aug 05, 2022 at 03:28:50PM +0200, David Hildenbrand wrote: > On 06.07.22 10:20, Chao Peng wrote: > > Introduce a new memfd_create() flag indicating the content of the > > created memfd is inaccessible from userspace through ordinary MMU > > access (e.g., read/write/mmap). However, the file

[PATCH] crypto/block-luks: always set splitkeylen to 0

2022-09-07 Thread Patrick Venture
This was caught by a sanitized build, that was perhaps oversensitive. Signed-off-by: Patrick Venture --- crypto/block-luks.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/crypto/block-luks.c b/crypto/block-luks.c index f62be6836b..8633fb7e9f 100644 --- a/crypto/block-

Re: [PATCH 2/6] parallels: Create parallels_handle_leak() to truncate excess clusters

2022-09-07 Thread Denis V. Lunev
On 9/2/22 10:52, Alexander Ivanov wrote: This helper will be reused in the next patch for duplications check. Signed-off-by: Alexander Ivanov --- block/parallels.c | 65 +++ 1 file changed, 43 insertions(+), 22 deletions(-) diff --git a/block/para

Re: [PATCH 3/6] parallels: Add checking and repairing duplicate offsets in BAT

2022-09-07 Thread Denis V. Lunev
On 9/2/22 10:52, Alexander Ivanov wrote: Cluster offsets must be unique among all BAT entries. Find duplicate offsets in the BAT. If a duplicated offset is found fix it by copying the content of the relevant cluster to a new allocated cluster and set the new cluster offset to the duplicated entr

Re: [PATCH] audio: add help option (?) for -audiodev

2022-09-07 Thread BALATON Zoltan
On Wed, 7 Sep 2022, Daniel P. Berrangé wrote: On Wed, Sep 07, 2022 at 05:06:36PM +0200, Markus Armbruster wrote: Claudio Fontana writes: add a simple help option for -audiodev, so users can do qemu -audiodev ? The preferred form is actually '-audiodev help'. The other one is deprecated.

Re: [PATCH] audio: add help option (?) for -audiodev

2022-09-07 Thread Claudio Fontana
On 9/7/22 17:06, Markus Armbruster wrote: > Claudio Fontana writes: > >> add a simple help option for -audiodev, so users can do >> >> qemu -audiodev ? > > The preferred form is actually '-audiodev help'. The other one is > deprecated. Recommend to stay away from it even in commit messages. I

Re: [PATCH 6/6] parallels: Image repairing in parallels_open()

2022-09-07 Thread Denis V. Lunev
On 9/2/22 10:53, Alexander Ivanov wrote: Repair an image at opening if the image is unclean or out-of-image corruption was detected. Signed-off-by: Alexander Ivanov --- block/parallels.c | 95 --- 1 file changed, 65 insertions(+), 30 deletions(-)

Re: [PATCH 5/6] parallels: Replace fprintf by qemu_log

2022-09-07 Thread Denis V. Lunev
On 9/2/22 10:52, Alexander Ivanov wrote: Use a standard QEMU function for logging. Signed-off-by: Alexander Ivanov --- block/parallels.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/block/parallels.c b/block/parallels.c index 688aa081e2..08526196da 100644 --

Re: [PATCH 4/6] parallels: Use highest_offset() helper in leak check

2022-09-07 Thread Denis V. Lunev
On 9/2/22 10:52, Alexander Ivanov wrote: Deduplicate code by using highest_offset() helper. Signed-off-by: Alexander Ivanov --- block/parallels.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/block/parallels.c b/block/parallels.c index 339ce45634..688aa081e2

Seeing qtest assertion failure with 7.1

2022-09-07 Thread Patrick Venture
# Start of nvme tests # Start of pci-device tests # Start of pci-device-tests tests # starting QEMU: exec ./qemu-system-aarch64 -qtest unix:/tmp/qtest-1431.sock -qtest-log /dev/null -chardev socket,path=/tmp/qtest-1431.qmp,id=char0 -mon chardev=char0,mode=control -display none -M virt, -cpu max -dr

Re: [PATCH 1/6] parallels: Incorrect data end calculation in parallels_open()

2022-09-07 Thread Denis V. Lunev
On 9/2/22 10:52, Alexander Ivanov wrote: The BDRVParallelsState structure contains data_end field that is measured in sectors. In parallels_open() initially this field is set by data_off field from parallels image header. According to the parallels format documentation, data_off field contains a

Re: [PATCH] audio: add help option (?) for -audiodev

2022-09-07 Thread Daniel P . Berrangé
On Wed, Sep 07, 2022 at 05:06:36PM +0200, Markus Armbruster wrote: > Claudio Fontana writes: > > > add a simple help option for -audiodev, so users can do > > > > qemu -audiodev ? > > The preferred form is actually '-audiodev help'. The other one is > deprecated. Recommend to stay away from it

Re: [PATCH] audio: add help option (?) for -audiodev

2022-09-07 Thread Markus Armbruster
Claudio Fontana writes: > add a simple help option for -audiodev, so users can do > > qemu -audiodev ? The preferred form is actually '-audiodev help'. The other one is deprecated. Recommend to stay away from it even in commit messages. > > to get the list of drivers available. > > Signed-off

[PULL 04/10] qapi: fix example of BLOCK_JOB_READY event

2022-09-07 Thread Markus Armbruster
From: Victor Toso Example output is missing ',' delimiter. Fix it. Problem was noticed when trying to load the example into python's json library. Signed-off-by: Victor Toso Message-Id: <20220901085840.22520-5-victort...@redhat.com> Signed-off-by: Markus Armbruster --- qapi/block-core.json |

[PULL 10/10] qapi: fix examples of events missing timestamp

2022-09-07 Thread Markus Armbruster
From: Victor Toso I've used real timestamp and changing them one by one so they would not be all equal. Problem was noticed when using the example as a test case for Go bindings. Signed-off-by: Victor Toso Message-Id: <20220901085840.22520-11-victort...@redhat.com> Signed-off-by: Markus Armbru

[PULL 03/10] qapi: fix example of query-dump-guest-memory-capability command

2022-09-07 Thread Markus Armbruster
From: Victor Toso Example output is missing closing curly brackets. Fix it. Problem was noticed when trying to load the example into python's json library. Signed-off-by: Victor Toso Message-Id: <20220901085840.22520-4-victort...@redhat.com> Signed-off-by: Markus Armbruster --- qapi/dump.jso

[PULL 01/10] qapi: fix example of query-ballon command

2022-09-07 Thread Markus Armbruster
From: Victor Toso Example output has an extra ',' delimiter. Fix it. Problem was noticed when trying to load the example into python's json library. Signed-off-by: Victor Toso Message-Id: <20220901085840.22520-2-victort...@redhat.com> Signed-off-by: Markus Armbruster --- qapi/machine.json |

[PULL 07/10] qapi: fix example of MEM_UNPLUG_ERROR event

2022-09-07 Thread Markus Armbruster
From: Victor Toso Example output was missing ',' delimiter. Fix it. Problem was noticed when trying to load the example into python's json library. Signed-off-by: Victor Toso Message-Id: <20220901085840.22520-8-victort...@redhat.com> Signed-off-by: Markus Armbruster --- qapi/machine.json | 2

[PULL 02/10] qapi: fix example of query-vnc command

2022-09-07 Thread Markus Armbruster
From: Victor Toso Example output has an extra ',' delimiter in member "websocket" and it lacks it in "family" member. Fix it. Problem was noticed when trying to load the example into python's json library. Signed-off-by: Victor Toso Message-Id: <20220901085840.22520-3-victort...@redhat.com> Si

[PULL 08/10] qapi: fix examples of blockdev-add with qcow2

2022-09-07 Thread Markus Armbruster
From: Victor Toso The examples use "qcow2" driver with the wrong member name for BlockdevRef alternate type. This patch changes all wrong member names from "file" to "data-file" which is the correct member name in BlockdevOptionsQcow2 for the BlockdevRef field. Problem was noticed when using the

[PULL 05/10] qapi: fix example of NIC_RX_FILTER_CHANGED event

2022-09-07 Thread Markus Armbruster
From: Victor Toso Example output has an extra ending curly bracket. Fix it. Problem was noticed when trying to load the example into python's json library. Signed-off-by: Victor Toso Message-Id: <20220901085840.22520-6-victort...@redhat.com> Signed-off-by: Markus Armbruster --- qapi/net.json

[PULL 09/10] qapi: fix example of query-hotpluggable-cpus command

2022-09-07 Thread Markus Armbruster
From: Victor Toso The example return type has the wrong member name. Fix it. Problem was noticed when using the example as a test case for Go bindings. Signed-off-by: Victor Toso Message-Id: <20220901085840.22520-10-victort...@redhat.com> Signed-off-by: Markus Armbruster --- qapi/machine.jso

[PULL 00/10] QAPI patches patches for 2022-09-07

2022-09-07 Thread Markus Armbruster
The following changes since commit 946e9bccf12f2bcc3ca471b820738fb22d14fc80: Merge tag 'samuel-thibault' of https://people.debian.org/~sthibault/qemu into staging (2022-09-06 08:31:24 -0400) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2022-09-07

[PULL 06/10] qapi: fix example of DEVICE_UNPLUG_GUEST_ERROR event

2022-09-07 Thread Markus Armbruster
From: Victor Toso Example output is missing a ',' delimiter and it has an extra ending curly bracket. Fix it. Problem was noticed when trying to load the example into python's json library. Signed-off-by: Victor Toso Message-Id: <20220901085840.22520-7-victort...@redhat.com> Signed-off-by: Mar

Re: [PATCH 06/20] ppc4xx_sdram: Move size check to ppc4xx_sdram_init()

2022-09-07 Thread BALATON Zoltan
On Wed, 7 Sep 2022, Cédric Le Goater wrote: On 8/19/22 18:55, BALATON Zoltan wrote: Instead of checking if memory size is valid in board code move this check to ppc4xx_sdram_init() as this is a restriction imposed by the SDRAM controller. Signed-off-by: BALATON Zoltan It looks like a good cl

Re: [PATCH v1 0/8] migration: introduce dirtylimit capability

2022-09-07 Thread Hyman
在 2022/9/7 4:46, Peter Xu 写道: On Fri, Sep 02, 2022 at 01:22:28AM +0800, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) v1: - make parameter vcpu-dirty-limit experimental - switch dirty limit off when cancel migrate - add cancel logic in migration test Please review, thanks, Yong A

Re: [PATCH 14/20] ppc440_sdram: Move RAM size check to ppc440_sdram_init

2022-09-07 Thread BALATON Zoltan
On Wed, 7 Sep 2022, Cédric Le Goater wrote: On 8/19/22 18:55, BALATON Zoltan wrote: Move the check for valid memory sizes from board to sdram contrller controller init. Board now only checks for additinal restrictions imposed by additional Thanks for finding these spelling mistakes, look

Re: [PATCH 13/20] ppc4xx_sdram: Rename functions to prevent name clashes

2022-09-07 Thread BALATON Zoltan
On Wed, 7 Sep 2022, Cédric Le Goater wrote: On 8/19/22 18:55, BALATON Zoltan wrote: Rename functions to avoid name clashes when moving the DDR2 controller model currently called ppc440_sdram to ppc4xx_devs. This also more clearly shows which function belongs to which model. Shouldn't we introd

Re: [PATCH 10/20] ppc440_sdram: Implement enable bit in the DDR2 SDRAM controller

2022-09-07 Thread BALATON Zoltan
On Wed, 7 Sep 2022, Cédric Le Goater wrote: On 8/19/22 18:55, BALATON Zoltan wrote: To allow removing the do_init hack we need to improve the DDR2 SDRAM controller model to handle the enable/disable bit that it ignored so far. Signed-off-by: BALATON Zoltan --- hw/ppc/ppc440_uc.c | 34 +++

Re: [PATCH 09/20] ppc440_sdram: Split off map/unmap of sdram banks for later reuse

2022-09-07 Thread BALATON Zoltan
On Wed, 7 Sep 2022, Cédric Le Goater wrote: On 8/19/22 18:55, BALATON Zoltan wrote: Signed-off-by: BALATON Zoltan --- hw/ppc/ppc440_uc.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/hw/ppc/ppc440_uc.c b/hw/ppc/ppc440_uc.c index 3507c35

Re: [PATCH 08/20] ppc4xx_sdram: Drop extra zeros for readability

2022-09-07 Thread BALATON Zoltan
On Wed, 7 Sep 2022, Cédric Le Goater wrote: On 8/19/22 18:55, BALATON Zoltan wrote: Constants that are written zero padded for no good reason are hard to read, it's easier to see what is meant if it's just 0 or 1 instead. I would keep the 0x prefix though. I'm not a fan of 0x0 or 0x prefix f

[PATCH] audio: add help option (?) for -audiodev

2022-09-07 Thread Claudio Fontana
add a simple help option for -audiodev, so users can do qemu -audiodev ? to get the list of drivers available. Signed-off-by: Claudio Fontana --- audio/audio.c | 20 1 file changed, 20 insertions(+) diff --git a/audio/audio.c b/audio/audio.c index 4f4bb10cce..bd8c18c3cd 1

Re: [PULL 00/11] OpenRISC updates for 7.2.0

2022-09-07 Thread Stefan Hajnoczi
On Sun, 4 Sept 2022 at 03:27, Stafford Horne wrote: > > The following changes since commit 61fd710b8da8aedcea9b4f197283dc38638e4b60: > > Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging > (2022-09-02 13:24:28 -0400) > > are available in the Git repository at: > > g...@

Re: [PULL 00/44] riscv-to-apply queue

2022-09-07 Thread Stefan Hajnoczi
; > are available in the Git repository at: > > g...@github.com:alistair23/qemu.git tags/pull-riscv-to-apply-20220907 Hi Alistair, Please update .git/config to separate the push URL from the fetch URL: [remote "github"] url = https://github.com/alistair23/qemu.git

Re: [PULL 00/44] riscv-to-apply queue

2022-09-07 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH 14/20] ppc440_sdram: Move RAM size check to ppc440_sdram_init

2022-09-07 Thread Cédric Le Goater
On 8/19/22 18:55, BALATON Zoltan wrote: Move the check for valid memory sizes from board to sdram contrller controller init. Board now only checks for additinal restrictions imposed by additional firmware then sdram init checks for valid sizes for SoC. Signed-off-by: BALATON Zoltan ---

Re: [PATCH 15/20] ppc440_sdram: QOM'ify

2022-09-07 Thread Cédric Le Goater
On 8/19/22 18:55, BALATON Zoltan wrote: Change the ppc440_sdram model to a QOM class derived from the PPC4xx-dcr-device and name it ppc4xx-sdram-ddr2. This is mostly modelling the DDR2 SDRAM controller found in the 460EX (used on the sam460ex board). Newer SoCs (regardless of their PPC core, e.g.

Re: [PATCH 13/20] ppc4xx_sdram: Rename functions to prevent name clashes

2022-09-07 Thread Cédric Le Goater
On 8/19/22 18:55, BALATON Zoltan wrote: Rename functions to avoid name clashes when moving the DDR2 controller model currently called ppc440_sdram to ppc4xx_devs. This also more clearly shows which function belongs to which model. Shouldn't we introduce class handlers instead ? Thanks, C.

Re: [PATCH 12/20] ppc440_sdram: Rename local variable for readibility

2022-09-07 Thread Cédric Le Goater
On 8/19/22 18:55, BALATON Zoltan wrote: Rename local sdram variable in ppc440_sdram_init to s for readibility. readability Signed-off-by: BALATON Zoltan Reviewed-by: Cédric Le Goater Thanks, C. --- hw/ppc/ppc440_uc.c | 36 ++-- 1 file changed, 18 in

Re: [PATCH 10/20] ppc440_sdram: Implement enable bit in the DDR2 SDRAM controller

2022-09-07 Thread Cédric Le Goater
On 8/19/22 18:55, BALATON Zoltan wrote: To allow removing the do_init hack we need to improve the DDR2 SDRAM controller model to handle the enable/disable bit that it ignored so far. Signed-off-by: BALATON Zoltan --- hw/ppc/ppc440_uc.c | 34 -- 1 file changed,

Re: PING: Re: [PATCH v4 1/1] monitor: Support specified vCPU registers

2022-09-07 Thread Dr. David Alan Gilbert
* zhenwei pi (pizhen...@bytedance.com) wrote: > PING! It's OK, I've got it lined up for a pull I'll do in a few days time. Dave > On 8/15/22 20:00, Dr. David Alan Gilbert wrote: > > * zhenwei pi (pizhen...@bytedance.com) wrote: > > > Originally we have to get all the vCPU registers and parse the

Re: [PATCH 09/20] ppc440_sdram: Split off map/unmap of sdram banks for later reuse

2022-09-07 Thread Cédric Le Goater
On 8/19/22 18:55, BALATON Zoltan wrote: Signed-off-by: BALATON Zoltan --- hw/ppc/ppc440_uc.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/hw/ppc/ppc440_uc.c b/hw/ppc/ppc440_uc.c index 3507c35b63..c33f91e134 100644 --- a/hw/ppc/ppc440_uc

Re: [PATCH 08/20] ppc4xx_sdram: Drop extra zeros for readability

2022-09-07 Thread Cédric Le Goater
On 8/19/22 18:55, BALATON Zoltan wrote: Constants that are written zero padded for no good reason are hard to read, it's easier to see what is meant if it's just 0 or 1 instead. I would keep the 0x prefix though. Thanks, C. Signed-off-by: BALATON Zoltan --- hw/ppc/ppc4xx_devs.c | 40 ++

Re: [PATCH 07/20] ppc4xx_sdram: QOM'ify

2022-09-07 Thread Cédric Le Goater
On 8/19/22 18:55, BALATON Zoltan wrote: Change the ppc4xx_sdram model to a QOM class derived from the PPC4xx-dcr-device and name it ppc4xx-sdram-ddr. This is mostly modelling the DDR SDRAM controller found in the 440EP (used on the bamboo board) but also backward compatible with the older DDR con

[PATCH v3] audio: Add sndio backend

2022-09-07 Thread Alexandre Ratchov
sndio is the native API used by OpenBSD, although it has been ported to other *BSD's and Linux (packages for Ubuntu, Debian, Void, Arch, etc.). Signed-off-by: Brad Smith Signed-off-by: Alexandre Ratchov --- References to the previous patch versions and related discussions are here: https://mar

Re: [PATCH 06/20] ppc4xx_sdram: Move size check to ppc4xx_sdram_init()

2022-09-07 Thread Cédric Le Goater
On 8/19/22 18:55, BALATON Zoltan wrote: Instead of checking if memory size is valid in board code move this check to ppc4xx_sdram_init() as this is a restriction imposed by the SDRAM controller. Signed-off-by: BALATON Zoltan It looks like a good clean up. At some point, I think we will need t

Re: [PATCH 05/20] ppc440_bamboo: Add missing 4 MiB valid memory size

2022-09-07 Thread Cédric Le Goater
On 8/19/22 18:55, BALATON Zoltan wrote: Signed-off-by: BALATON Zoltan Reviewed-by: Cédric Le Goater Thanks, C. --- hw/ppc/ppc440_bamboo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/ppc440_bamboo.c b/hw/ppc/ppc440_bamboo.c index 2aac8a3fe9..2bd5e41140 10

Re: [PATCH] migration/multifd: Remove redundant copy of page offsets during send

2022-09-07 Thread Nikolay Borisov
On 10.08.22 г. 13:39 ч., Nikolay Borisov wrote: All pages which are going to be migrated are first added to MultiFDSendParams::MultiFDPages_t::offset array by the main migration thread and are subsequently copied to MultiFDSendParams::normal by the multifd thread. This is really unnecessary as

Re: [PATCH REPOST] hw/i386/e820: remove legacy reserved entries for e820

2022-09-07 Thread Ani Sinha
On Wed, Aug 31, 2022 at 10:23 AM Ani Sinha wrote: > > e820 reserved entries were used before the dynamic entries with fw config > files > were intoduced. Please see the following change: > 7d67110f2d9a6("pc: add etc/e820 fw_cfg file") > > Identical support was introduced into seabios as well with

Re: Maximum QMP reply size

2022-09-07 Thread Markus Armbruster
John Snow writes: > Hi, I suspect I have asked this before, but I didn't write it down in > a comment, so I forget my justification... > > In the QMP lib, we need to set a buffering limit for how big a QMP > message can be -- In practice, I found that the largest possible > response was the QAPI

[PATCH v2 3/3] accel: abort if we fail to load the accelerator plugin

2022-09-07 Thread Claudio Fontana
if QEMU is configured with modules enabled, it is possible that the load of an accelerator module will fail. Abort in this case, relying on module_object_class_by_name to report the specific load error if any. Signed-off-by: Claudio Fontana --- accel/accel-softmmu.c | 8 +++- 1 file changed,

[PATCH v2 0/3] improve error handling for module load

2022-09-07 Thread Claudio Fontana
while investigating a permission issue in accel, where accel-tcg-x86_64.so was not accessible, I noticed that no errors were produced regarding the module load failure. This series attempts to improve module_load_one and module_load_qom_one to handle the error cases better and produce some errors.

[PATCH v2 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-07 Thread Claudio Fontana
improve error handling during module load, by changing: bool module_load_one(const char *prefix, const char *lib_name); void module_load_qom_one(const char *type); to: bool module_load_one(const char *prefix, const char *name, Error **errp); bool module_load_qom_one(const char *type, Error **err

[PATCH v2 1/3] module: removed unused function argument "mayfail"

2022-09-07 Thread Claudio Fontana
mayfail is always passed as false for every invocation throughout the program. It controls whether to printf or not to printf an error on g_module_open failure. Remove this unused argument. Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- i

Re: [PATCH v9 05/10] s390x/cpu: reporting drawers and books topology to the guest

2022-09-07 Thread Janis Schoetterl-Glausch
On Fri, 2022-09-02 at 09:55 +0200, Pierre Morel wrote: > The guest can ask for a topology report on drawer's or book's > level. > Let's implement the STSI instruction's handling for the corresponding > selector values. > > Signed-off-by: Pierre Morel > --- > hw/s390x/cpu-topology.c | 19

Re: [PATCH v9 03/10] s390x/cpu topology: reporting the CPU topology to the guest

2022-09-07 Thread Janis Schoetterl-Glausch
On Fri, 2022-09-02 at 09:55 +0200, Pierre Morel wrote: > The guest can use the STSI instruction to get a buffer filled > with the CPU topology description. > > Let us implement the STSI instruction for the basis CPU topology > level, level 2. > > Signed-off-by: Pierre Morel > --- > hw/s390x/cpu

Re: [PATCH 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-07 Thread Claudio Fontana
On 9/7/22 09:36, Gerd Hoffmann wrote: > Hi, > >> For this module_load_qom_all() maybe Gerd has a bit more context on >> was should be the error reporting here? > > Use case for module_load_qom_all() is someone enumerating the qom > objects available. So we load all modules known to have all o

Re: [PATCH 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-07 Thread Claudio Fontana
On 9/6/22 13:55, Claudio Fontana wrote: > improve error handling during module load, by changing: > > bool module_load_one(const char *prefix, const char *lib_name); > void module_load_qom_one(const char *type); > > to: > > bool module_load_one(const char *prefix, const char *name, Error **errp)

Re: [PATCH v6 09/14] hw/ppc: set machine->fdt in pnv_reset()

2022-09-07 Thread Frederic Barrat
On 05/09/2022 01:34, Daniel Henrique Barboza wrote: This will enable support for the 'dumpdtb' QMP/HMP command for all powernv machines. Cc: Cédric Le Goater Cc: Frederic Barrat Signed-off-by: Daniel Henrique Barboza --- LGTM Reviewed-by: Frederic Barrat Fred hw/ppc/pnv.c | 8 +

[PULL 44/44] target/riscv: Update the privilege field for sscofpmf CSRs

2022-09-07 Thread Alistair Francis via
From: Atish Patra The sscofpmf extension was ratified as a part of priv spec v1.12. Mark the csr_ops accordingly. Reviewed-by: Weiwei Li Reviewed-by: Alistair Francis Signed-off-by: Atish Patra Message-Id: <20220824221701.41932-6-ati...@rivosinc.com> Signed-off-by: Alistair Francis --- targ

Re: [PATCH] fw_cfg: Don't set callback_opaque NULL in fw_cfg_modify_bytes_read()

2022-09-07 Thread Gerd Hoffmann
> > QEMU_EFI reports the below error: > > ProcessCmdAddPointer: invalid pointer value in "etc/acpi/tables" > > OnRootBridgesConnected: InstallAcpiTables: Protocol Error > > > > Debugging shows that on first reboot(after hot-adding NVDIMM), > > Qemu updates the etc/table-loader len, > > > > qemu_r

Re: [PATCH v3 3/5] acpi/nvdimm: define macro for NVDIMM Device _DSM

2022-09-07 Thread Igor Mammedov
On Thu, 1 Sep 2022 11:27:19 +0800 Robert Hoo wrote: > Since it will be heavily used in next patch, define macro > NVDIMM_DEVICE_DSM_UUID for "4309AC30-0D11-11E4-9191-0800200C9A66", which is > NVDIMM device specific method uuid defined in NVDIMM _DSM interface spec, > Section 3. [1] > > No funct

[PULL 43/44] hw/riscv: virt: Add PMU DT node to the device tree

2022-09-07 Thread Alistair Francis via
From: Atish Patra Qemu virt machine can support few cache events and cycle/instret counters. It also supports counter overflow for these events. Add a DT node so that OpenSBI/Linux kernel is aware of the virt machine capabilities. There are some dummy nodes added for testing as well. Acked-by:

Re: [PATCH] fw_cfg: Don't set callback_opaque NULL in fw_cfg_modify_bytes_read()

2022-09-07 Thread Igor Mammedov
On Thu, 25 Aug 2022 17:18:42 +0100 Shameer Kolothum wrote: > Hi > > On arm/virt platform, Chen Xiang reported a Guest crash while > attempting the below steps, > > 1. Launch the Guest with nvdimm=on > 2. Hot-add a NVDIMM dev > 3. Reboot > 4. Guest boots fine. > 5. Reboot again. > 6. Guest boot

[PULL 41/44] target/riscv: Simplify counter predicate function

2022-09-07 Thread Alistair Francis via
From: Atish Patra All the hpmcounters and the fixed counters (CY, IR, TM) can be represented as a unified counter. Thus, the predicate function doesn't need handle each case separately. Simplify the predicate function so that we just handle things differently between RV32/RV64 and S/HS mode. Re

[PULL 31/44] hw/riscv: virt: fix uart node name

2022-09-07 Thread Alistair Francis via
From: Conor Dooley "uart" is not a node name that complies with the dt-schema. Change the node name to "serial" to ix warnings seen during dt-validate on a dtbdump of the virt machine such as: /stuff/qemu/qemu.dtb: uart@1000: $nodename:0: 'uart@1000' does not match '^serial(@.*)?$'

[PULL 42/44] target/riscv: Add few cache related PMU events

2022-09-07 Thread Alistair Francis via
From: Atish Patra Qemu can monitor the following cache related PMU events through tlb_fill functions. 1. DTLB load/store miss 3. ITLB prefetch miss Increment the PMU counter in tlb_fill function. Reviewed-by: Alistair Francis Tested-by: Heiko Stuebner Signed-off-by: Atish Patra Signed-off-b

[PULL 39/44] target/riscv: Add vstimecmp support

2022-09-07 Thread Alistair Francis via
From: Atish Patra vstimecmp CSR allows the guest OS or to program the next guest timer interrupt directly. Thus, hypervisor no longer need to inject the timer interrupt to the guest if vstimecmp is used. This was ratified as a part of the Sstc extension. Reviewed-by: Alistair Francis Signed-off

[PULL 29/44] hw/riscv: microchip_pfsoc: fix kernel panics due to missing peripherals

2022-09-07 Thread Alistair Francis via
From: Conor Dooley Booting using "Direct Kernel Boot" for PolarFire SoC & skipping u-boot entirely is probably not advisable, but it does at least show signs of life. Recent Linux kernel versions make use of peripherals that are missing definitions in QEMU and lead to kernel panics. These issues

[PULL 38/44] target/riscv: Add stimecmp support

2022-09-07 Thread Alistair Francis via
From: Atish Patra stimecmp allows the supervisor mode to update stimecmp CSR directly to program the next timer interrupt. This CSR is part of the Sstc extension which was ratified recently. Reviewed-by: Alistair Francis Signed-off-by: Atish Patra Message-Id: <20220824221357.41070-3-ati...@riv

[PULL 34/44] hw/core: fix platform bus node name

2022-09-07 Thread Alistair Francis via
From: Conor Dooley "platform" is not a valid name for a bus node in dt-schema, so warnings can be see in dt-validate on a dump of the riscv virt dtb: /stuff/qemu/qemu.dtb: platform@400: $nodename:0: 'platform@400' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?

[PULL 28/44] hw/riscv: opentitan: bump opentitan version

2022-09-07 Thread Alistair Francis via
From: Wilfred Mallawa The following patch updates opentitan to match the new configuration, as per, lowRISC/opentitan@217a0168ba118503c166a9587819e3811eeb0c0c Note: with this patch we now skip the usage of the opentitan `boot_rom`. The Opentitan boot rom contains hw verification for devies which

Re: sphinx-build is really slow, any way to improve that?

2022-09-07 Thread Markus Armbruster
Peter Maydell writes: > On Tue, 6 Sept 2022 at 08:55, Daniel P. Berrangé wrote: >> >> On Mon, Sep 05, 2022 at 10:21:55PM +0100, Peter Maydell wrote: >> > On Mon, 5 Sept 2022 at 20:51, Claudio Fontana wrote: >> > > when I build qemu, there is a lot of time spent at the end of the build >> > > w

[PULL 35/44] target/riscv: Add xicondops in ISA entry

2022-09-07 Thread Alistair Francis via
From: Rahul Pathak XVentanaCondOps is Ventana custom extension. Add its extension entry in the ISA Ext array Signed-off-by: Rahul Pathak Reviewed-by: Alistair Francis Message-id: 20220816045408.1231135-1-rpat...@ventanamicro.com Signed-off-by: Alistair Francis --- target/riscv/cpu.c | 1 + 1

[PULL 36/44] target/riscv: Use official extension names for AIA CSRs

2022-09-07 Thread Alistair Francis via
From: Anup Patel The arch review of AIA spec is completed and we now have official extension names for AIA: Smaia (M-mode AIA CSRs) and Ssaia (S-mode AIA CSRs). Refer, section 1.6 of the latest AIA v0.3.1 stable specification at https://github.com/riscv/riscv-aia/releases/download/0.3.1-draft.32

[PULL 33/44] hw/riscv: virt: fix syscon subnode paths

2022-09-07 Thread Alistair Francis via
From: Conor Dooley The reset and poweroff features of the syscon were originally added to top level, which is a valid path for a syscon subnode. Subsequently a reorganisation was carried out while implementing NUMA in which the subnodes were moved into the /soc node. As /soc is a "simple-bus", th

[PULL 21/44] target/riscv: rvv: Add mask agnostic for vector floating-point instructions

2022-09-07 Thread Alistair Francis via
From: "Yueh-Ting (eop) Chen" Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li Acked-by: Alistair Francis Message-Id: <165570784143.17634.3509581658457369...@git.sr.ht> Signed-off-by: Alistair Francis --- target/riscv/vector_helper.c| 26 +++

[PULL 30/44] target/riscv: Remove additional priv version check for mcountinhibit

2022-09-07 Thread Alistair Francis via
From: Atish Patra With .min_priv_version, additiona priv version check is uncessary for mcountinhibit read/write functions. Reviewed-by: Heiko Stuebner Tested-by: Heiko Stuebner Reviewed-by: Alistair Francis Signed-off-by: Atish Patra Message-Id: <20220816232321.558250-7-ati...@rivosinc.com>

  1   2   >