Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

2022-06-30 Thread Michael S. Tsirkin
On Fri, Jul 01, 2022 at 06:12:14AM +0200, Thomas Huth wrote: > I even wouldn't mind if you put your python stuff in a new directory like > tests/pytests/ for example, as long as it downloads your binaries separately > - as I wrote in another mail, the avocado framework rather looks like an > oddbal

Re: [PATCH v2 09/13] hw/i2c/pmbus: Add read-only IC_DEVICE_ID support

2022-06-30 Thread Cédric Le Goater
> Thanks for the new device. It helps me see where to expand on PMBus. Thanks for adding the whole pmbus infrastructure! It’s really useful. And thanks for the review. Off-topic, but I’ve been meaning to reach out to you guys (Google engineers working on QEMU for OpenBMC) ab

Re: [PATCH v1 2/2] migration/multifd: Warn user when zerocopy not working

2022-06-30 Thread Leonardo Brás
On Tue, 2022-06-28 at 17:56 +0100, Dr. David Alan Gilbert wrote: > * Leonardo Bras Soares Passos (leob...@redhat.com) wrote: > > On Tue, Jun 28, 2022 at 10:52 AM Dr. David Alan Gilbert > > wrote: > > > > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > > On Tue, Jun 28, 2022 at 09:32:0

RE: [RFC PATCH 00/12] Introduce QEMU userspace ebpf support

2022-06-30 Thread Zhang, Chen
> -Original Message- > From: Andrew Melnichenko > Sent: Wednesday, June 29, 2022 6:43 PM > To: Zhang, Chen > Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Paolo Bonzini ; Daniel P. > Berrangé ; Eduardo Habkost > ; Eric Blake ; Markus > Armbruster ; Peter Maydell > ; Thomas Huth ; Lauren

Re: [PATCH] contrib/vhost-user-blk: Clean up deallocation of VuVirtqElement

2022-06-30 Thread Markus Armbruster
Raphael Norwitz writes: > On Thu, Jun 30, 2022 at 10:52:19AM +0200, Markus Armbruster wrote: >> We allocate VuVirtqElement with g_malloc() in >> virtqueue_alloc_element(), but free it with free() in >> vhost-user-blk.c. Harmless, but use g_free() anyway. >> >> One of the calls is guarded by a "

Re: [PATCH v3 14/14] hw/arm/aspeed: Add oby35-cl machine

2022-06-30 Thread Cédric Le Goater
On 7/1/22 01:06, Peter Delevoryas wrote: On Thu, Jun 30, 2022 at 06:42:52PM +0200, Cédric Le Goater wrote: On 6/30/22 18:15, Peter Delevoryas wrote: On Thu, Jun 30, 2022 at 01:02:54PM +0200, Cédric Le Goater wrote: On 6/30/22 06:51, Peter Delevoryas wrote: From: Peter Delevoryas The fby35 m

Re: [PATCH v3 10/14] hw/sensor: Add Renesas ISL69259 device model

2022-06-30 Thread Cédric Le Goater
On 6/30/22 21:16, Titus Rwantare wrote: On Wed, 29 Jun 2022 at 23:30, Cédric Le Goater wrote: On 6/30/22 06:51, Peter Delevoryas wrote: From: Peter Delevoryas This adds the ISL69259, using all the same functionality as the existing ISL69260 but overriding the IC_DEVICE_ID. Signed-off-by: P

Re: [PATCH 3/3] aspeed: sbc: Allow per-machine settings

2022-06-30 Thread Peter Delevoryas
On Fri, Jul 01, 2022 at 07:23:58AM +0200, Cédric Le Goater wrote: > On 7/1/22 03:36, Peter Delevoryas wrote: > > On Tue, Jun 28, 2022 at 05:47:40PM +0200, Cédric Le Goater wrote: > > > From: Joel Stanley > > > > > > In order to correctly report secure boot running firmware the values > > > of cer

Re: [PATCH 3/3] aspeed: sbc: Allow per-machine settings

2022-06-30 Thread Cédric Le Goater
On 7/1/22 03:36, Peter Delevoryas wrote: On Tue, Jun 28, 2022 at 05:47:40PM +0200, Cédric Le Goater wrote: From: Joel Stanley In order to correctly report secure boot running firmware the values of certain registers must be set. We don't yet have documentation from ASPEED on what they mean. T

Re: [PATCH] contrib/vhost-user-blk: Clean up deallocation of VuVirtqElement

2022-06-30 Thread Raphael Norwitz
On Thu, Jun 30, 2022 at 10:52:19AM +0200, Markus Armbruster wrote: > We allocate VuVirtqElement with g_malloc() in > virtqueue_alloc_element(), but free it with free() in > vhost-user-blk.c. Harmless, but use g_free() anyway. > > One of the calls is guarded by a "not null" condition. Useless, >

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

2022-06-30 Thread Thomas Huth
On 28/06/2022 15.53, Ani Sinha wrote: On Tue, Jun 28, 2022 at 19:15 Peter Maydell > wrote: On Tue, 28 Jun 2022 at 14:23, Ani Sinha mailto:a...@anisinha.ca>> wrote: > On Tue, Jun 28, 2022 at 6:25 PM Daniel P. Berrangé mailto:berra...@redhat.com>> w

Re: [PULL 00/14] (Mostly) build system changes for 2022-06-24

2022-06-30 Thread Paolo Bonzini
Il ven 1 lug 2022, 02:26 Richard Henderson ha scritto: > >> Does that mean that Ubuntu installs GCC without a 32-bit libgcc.a? > > > > I think they package it in a separate package, eg lib32gcc-9-dev > > (adjust package name to suit gcc version). > > It's there, as Peter says, but it's not instal

Re: Why we should avoid new submodules if possible

2022-06-30 Thread Thomas Huth
On 29/06/2022 08.28, Ani Sinha wrote: On Tue, Jun 28, 2022 at 11:30 PM Michael S. Tsirkin wrote: On Tue, Jun 28, 2022 at 05:15:05PM +0100, Daniel P. Berrangé wrote: FYI, the reason much of this is intentionally NOT under the /qemu-project gitlab namespace is that we did not want to be respons

[PATCH] qga: add command 'guest-get-cpustats'

2022-06-30 Thread zhenwei pi
A vCPU thread always reaches 100% utilization when: - guest uses idle=poll - disable HLT vm-exit - enable MWAIT Add new guest agent command 'guest-get-cpustats' to get guest CPU statistics, we can know the guest workload and how busy the CPU is. Signed-off-by: zhenwei pi --- qga/commands-posix.

[PATCH] hw/intc: loongarch_pch_msi: Fix msi vector convertion

2022-06-30 Thread Mao Bibo
Loongarch pch msi intc connects to extioi controller, the range of irq number is 64-255. Here adds irqbase property for loongarch pch msi controller, we can get irq offset from view of pch_msi controller with the method: msi vector (from view of upper extioi intc) - irqbase Signed-off-by: Mao Bi

[PATCH] include/qemu/host-utils: Remove unused code in the *_overflow wrappers

2022-06-30 Thread Thomas Huth
According to commit cec07c0b612975 the code in the #else paths was required for GCC < 5.0 and Clang < 3.8. We don't support such old compilers at all anymore, so we can remove these lines now. We keep the wrapper function, though, since they are easier to read and help to make sure that the paramet

Re: [PATCH 5/5] multifd: Only sync once each full round of memory

2022-06-30 Thread Leonardo Brás
Hello Juan, On Tue, 2022-06-21 at 16:05 +0200, Juan Quintela wrote: > We need to add a new flag to mean to sync at that point. > Notice that we still synchronize at the end of setup and at the end of > complete stages. > > Signed-off-by: Juan Quintela > --- >  migration/migration.c |  2 +- >  mi

Re: [PATCH 3/3] gitlab: honour QEMU_CI variable in edk2/opensbi jobs

2022-06-30 Thread Richard Henderson
On 6/29/22 22:36, Daniel P. Berrangé wrote: +# In forks, if QEMU_CI=1 is set, then create manual job +# if the branch/tag starts with 'edk2' +- if: '$QEMU_CI == "1" && $CI_PROJECT_NAMESPACE != "qemu-project" && $CI_COMMIT_REF_NAME =~ /^edk2/' + when: manual + +# In forks, if

Re: [PATCH 2/3] gitlab: tweak comments in edk2/opensbi jobs

2022-06-30 Thread Richard Henderson
On 6/29/22 22:36, Daniel P. Berrangé wrote: Get rid of comments stating the obvious and re-arrange remaining comments. The opensbi split of rules for file matches is also merged into one rule. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.d/edk2.yml| 14 -- .gitlab-ci.d/ope

Re: [PATCH 1/3] gitlab: normalize indentation in edk2/opensbi rules

2022-06-30 Thread Richard Henderson
On 6/29/22 22:36, Daniel P. Berrangé wrote: The edk2/opensbi gitlab CI config was using single space indents which is not consistent with the rest of the gitlab CI config files. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.d/edk2.yml| 108 +++--- .gitla

Re: [PATCH] scripts: check if .git exists before checking submodule status

2022-06-30 Thread Richard Henderson
On 6/29/22 21:38, Daniel P. Berrangé wrote: Currently we check status of each submodule, before actually checking if we're in a git repo. These status commands will all fail, but we are hiding their output so we don't see it currently. Signed-off-by: Daniel P. Berrangé --- scripts/git-submodul

Re: [PATCH 3/3] aspeed: sbc: Allow per-machine settings

2022-06-30 Thread Peter Delevoryas
On Tue, Jun 28, 2022 at 05:47:40PM +0200, Cédric Le Goater wrote: > From: Joel Stanley > > In order to correctly report secure boot running firmware the values > of certain registers must be set. > > We don't yet have documentation from ASPEED on what they mean. The > meaning is inferred from u-

Re: [PATCH v2] io_uring: fix short read slow path

2022-06-30 Thread Dominique Martinet
Dominique Martinet wrote on Fri, Jul 01, 2022 at 07:52:31AM +0900: > Stefano Garzarella wrote on Thu, Jun 30, 2022 at 05:49:21PM +0200: > > > so when we ask for more we issue an extra short reads, making sure we go > > > through the two short reads path. > > > (Unfortunately I wasn't quite sure wha

Re: [PULL 00/27] aspeed queue

2022-06-30 Thread Richard Henderson
ository at: https://github.com/legoater/qemu/ tags/pull-aspeed-20220630 for you to fetch changes up to 55c57023b740c29151d42600af9ac43ba00e56cc: hw/misc/aspeed: Add PECI controller (2022-06-30 09:21:14 +0200) aspeed queue:

Re: [PATCH v6 6/8] KVM: Handle page fault for private memory

2022-06-30 Thread Xiaoyao Li
On 7/1/2022 6:21 AM, Michael Roth wrote: On Thu, Jun 30, 2022 at 12:14:13PM -0700, Vishal Annapurve wrote: With transparent_hugepages=always setting I see issues with the current implementation. Scenario: 1) Guest accesses a gfn range 0x800-0xa00 as private 2) Guest calls mapgpa to convert the

Re: [PULL 00/14] (Mostly) build system changes for 2022-06-24

2022-06-30 Thread Richard Henderson
On 6/30/22 23:02, Peter Maydell wrote: On Thu, 30 Jun 2022 at 18:14, Paolo Bonzini wrote: Il ven 24 giu 2022, 17:57 Richard Henderson ha scritto: But then the i386 cross-compiler isn't used: Yeah, that was intentional. In theory a softmmu target is freestanding and does not need anyt

[PATCH 1/3] hw/i2c/pmbus: Add idle state to return 0xff's

2022-06-30 Thread Peter Delevoryas
From: Peter Delevoryas Signed-off-by: Peter Delevoryas Reviewed-by: Titus Rwantare --- hw/i2c/pmbus_device.c | 9 + include/hw/i2c/pmbus_device.h | 7 +++ 2 files changed, 16 insertions(+) diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c index 62885fa6a1..f89fea6

[PATCH 3/3] hw/sensor: Add Renesas ISL69259 device model

2022-06-30 Thread Peter Delevoryas
From: Peter Delevoryas This adds the ISL69259, using all the same functionality as the existing ISL69260 but overriding the IC_DEVICE_ID. Signed-off-by: Peter Delevoryas Reviewed-by: Titus Rwantare --- hw/sensor/isl_pmbus_vr.c | 28 1 file changed, 28 insertions(+

[PATCH 0/3] hw/sensor: Add ISL69259 with IC_DEVICE_ID

2022-06-30 Thread Peter Delevoryas
From: Peter Delevoryas Resubmitting these patches separately after having included and partially reviewd them here: - https://lore.kernel.org/qemu-devel/20220630045133.32251-9...@pjd.dev/ - https://lore.kernel.org/qemu-devel/20220630045133.32251-10...@pjd.dev/ - https://lore.kernel.org/qemu-deve

[PATCH 2/3] hw/sensor: Add IC_DEVICE_ID to ISL voltage regulators

2022-06-30 Thread Peter Delevoryas
From: Peter Delevoryas This commit adds a passthrough for PMBUS_IC_DEVICE_ID to allow Renesas voltage regulators to return the integrated circuit device ID if they would like to. The behavior is very device specific, so it hasn't been added to the general PMBUS model. Additionally, if the device

Re: [PATCH v3 14/14] hw/arm/aspeed: Add oby35-cl machine

2022-06-30 Thread Peter Delevoryas
On Thu, Jun 30, 2022 at 06:42:52PM +0200, Cédric Le Goater wrote: > On 6/30/22 18:15, Peter Delevoryas wrote: > > On Thu, Jun 30, 2022 at 01:02:54PM +0200, Cédric Le Goater wrote: > > > On 6/30/22 06:51, Peter Delevoryas wrote: > > > > From: Peter Delevoryas > > > > > > > > The fby35 machine incl

Re: [PATCH v2] io_uring: fix short read slow path

2022-06-30 Thread Dominique Martinet
Stefano Garzarella wrote on Thu, Jun 30, 2022 at 05:49:21PM +0200: > > so when we ask for more we issue an extra short reads, making sure we go > > through the two short reads path. > > (Unfortunately I wasn't quite sure what to fiddle with to issue short > > reads in the first place, I tried cutti

Re: [PATCH v2 0/3] python/qemu/machine: fix potential hang in QMP accept

2022-06-30 Thread John Snow
On Thu, Jun 30, 2022 at 8:34 AM wrote: > > From: Marc-André Lureau > > Hi, > > As reported earlier by Richard Henderson ("virgl avocado hang" thread), > avocado > tests may hang when QEMU exits before the QMP connection is established. > > v2: > - use a socketpair() for QMP (instead of async co

Re: [PATCH 2/2] python/qemu/machine: accept QMP connection asynchronously

2022-06-30 Thread John Snow
On Thu, Jun 30, 2022 at 4:23 AM Daniel P. Berrangé wrote: > > On Wed, Jun 29, 2022 at 07:54:08PM -0400, John Snow wrote: > > On Tue, Jun 28, 2022 at 10:17 AM Daniel P. Berrangé > > wrote: > > > > > > On Tue, Jun 28, 2022 at 05:49:39PM +0400, marcandre.lur...@redhat.com > > > wrote: > > > > From

Re: [PATCH v6 6/8] KVM: Handle page fault for private memory

2022-06-30 Thread Michael Roth
On Thu, Jun 30, 2022 at 12:14:13PM -0700, Vishal Annapurve wrote: > With transparent_hugepages=always setting I see issues with the > current implementation. > > Scenario: > 1) Guest accesses a gfn range 0x800-0xa00 as private > 2) Guest calls mapgpa to convert the range 0x84d-0x86e as shared > 3)

Re: [PATCH v3 10/14] hw/sensor: Add Renesas ISL69259 device model

2022-06-30 Thread Peter Delevoryas
On Thu, Jun 30, 2022 at 12:16:05PM -0700, Titus Rwantare wrote: > On Wed, 29 Jun 2022 at 21:52, Peter Delevoryas wrote: > > > > From: Peter Delevoryas > > > > This adds the ISL69259, using all the same functionality as the existing > > ISL69260 but overriding the IC_DEVICE_ID. > > > > Signed-off-

Re: [PATCH v2] target/ppc: Return default CPU for max CPU

2022-06-30 Thread Víctor Colombo
On 28/06/2022 17:55, Murilo Opsfelder Araujo wrote: All ppc CPUs represent hardware that exists in the real world, i.e.: we do not have a "max" CPU with all possible emulated features enabled. Return the default CPU type for the machine because that has greater chance of being useful as the "max"

[PATCH 5/9] target/ppc: use Error pointer in kvmppc_get_clockfreq()

2022-06-30 Thread Daniel Henrique Barboza
Callers will then be able to handle any errors that might happen when reading the clock frequency. Signed-off-by: Daniel Henrique Barboza --- hw/ppc/e500.c | 2 +- hw/ppc/ppc440_bamboo.c | 2 +- hw/ppc/sam460ex.c | 2 +- hw/ppc/spapr.c | 2 +- target/ppc/kvm.c | 4 ++-

[PATCH 0/9] cleanup error handling in kvmppc_read_int_cpu_dt()

2022-06-30 Thread Daniel Henrique Barboza
Hi, This series is a cleanup that fixes the issues observed by Markus Armbruster in the review of jianchunfu's patch: https://lists.gnu.org/archive/html/qemu-devel/2022-06/msg05393.html I've also included jianchunfu's patch, with the relevant bits, in the series. Daniel Henrique Barboza (8):

[PATCH 1/9] target/ppc/kvm.c: do not return -1 on uint64_t return

2022-06-30 Thread Daniel Henrique Barboza
kvmppc_read_int_dt() and kvmppc_read_int_cpu_dt() return an uint64_t, while returning -1 when an error occurs. kvmppc_read_int_cpu_dt() claims that it will return 0 if anything wrong happens, but it's returning -1 if kmvppc_find_cpu_dt() fails. The elephant in the room is that returning -1 while c

[PATCH 9/9] spapr.c: handle clock freq read errors in spapr_dt_cpu()

2022-06-30 Thread Daniel Henrique Barboza
Let's put the default spapr clock value in a SPAPR_CLOCK_FREQ for better readability. After that, make 'cpufreq' default to SPAPR_CLOCK_FREQ if kvmppc_get_clockfreq() fails to read the clock from the DT. Signed-off-by: Daniel Henrique Barboza --- hw/ppc/spapr.c | 12 +++- includ

[PATCH 8/9] e500.c: use PLATFORM_CLK_FREQ_HZ if unable to read clock freq from DT

2022-06-30 Thread Daniel Henrique Barboza
Default 'clock_freq' to PLATFORM_CLK_FREQ_HZ if kvmppc_get_clockfreq() fails to read the clock from the DT. Signed-off-by: Daniel Henrique Barboza --- hw/ppc/e500.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c index 4b4e99ef3c..dc53d99b

[PATCH 7/9] sam460ex.c: use CPU_FREQ if unable to read DT clock

2022-06-30 Thread Daniel Henrique Barboza
Fallback 'clock_freq' to CPU_FREQ if kvmppc_get_clockfreq() fails to read the clock from the DT. Signed-off-by: Daniel Henrique Barboza --- hw/ppc/sam460ex.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/ppc/sam460ex.c b/hw/ppc/sam460ex.c index 4d25cb2c2e..0b3ce0c

[PATCH 2/9] target/ppc: add errp to kvmppc_read_int_cpu_dt()

2022-06-30 Thread Daniel Henrique Barboza
The function can't just return 0 whether an error happened and call it a day. We must provide a way of letting callers know if the zero return is legitimate or due to an error. Add an Error pointer to kvmppc_read_int_cpu_dt() that will be filled with an appropriate error, if one occurs. Callers ar

[PATCH 6/9] ppc440_bamboo.c: handle clock freq read error in load_device_tree

2022-06-30 Thread Daniel Henrique Barboza
Let's put the default clock and timebase freq value in macros for better readability. Use PPC440EP_CLOCK_FREQ as the default value of 'clock_freq' if kvmppc_get_clockfreq() throws an error. Signed-off-by: Daniel Henrique Barboza --- hw/ppc/ppc440_bamboo.c | 17 ++--- 1 file changed,

[PATCH 3/9] target/ppc: Add error reporting when opening file fails

2022-06-30 Thread Daniel Henrique Barboza
From: jianchunfu Add error reporting before return when opening file fails in kvmppc_read_int_dt(). Signed-off-by: jianchunfu [danielhb: use error_setg() instead of fprintf] Signed-off-by: Daniel Henrique Barboza --- target/ppc/kvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

[PATCH 5/5] target/arm: Correctly implement Feat_DoubleLock

2022-06-30 Thread Peter Maydell
The architecture defines the OS DoubleLock as a register which (similarly to the OS Lock) suppresses debug events for use in CPU powerdown sequences. This functionality is required in Arm v7 and v8.0; from v8.2 it becomes optional and in v9 it must not be implemented. Currently in QEMU we impleme

[PATCH 4/9] target/ppc: use g_autofree in kvmppc_read_int_cpu_dt()

2022-06-30 Thread Daniel Henrique Barboza
This spares us a g_free() call. Let's also not use 'val' and return the value of kvmppc_read_int_dt() directly. Signed-off-by: Daniel Henrique Barboza --- target/ppc/kvm.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 7611e9

[PATCH 2/5] target/arm: Move define_debug_regs() to debug_helper.c

2022-06-30 Thread Peter Maydell
The target/arm/helper.c file is very long and is a grabbag of all kinds of functionality. We have already a debug_helper.c which has code for implementing architectural debug. Move the code which defines the debug-related system registers out to this file also. This affects the define_debug_regs(

[PATCH 4/5] target/arm: Implement AArch32 DBGDEVID, DBGDEVID1, DBGDEVID2

2022-06-30 Thread Peter Maydell
Starting with v7 of the debug architecture, there are three extra ID registers that add information on top of that provided in DBGDIDR. These are DBGDEVID, DBGDEVID1 and DBGDEVID2. In the v7 debug architecture, DBGDEVID is optional, present only of DBGDIDR.DEVID_imp is set. In v7.1 all three must b

[PATCH 3/5] target/arm: Suppress debug exceptions when OS Lock set

2022-06-30 Thread Peter Maydell
The "OS Lock" in the Arm debug architecture is a way for software to suppress debug exceptions while it is trying to power down a CPU and save the state of the breakpoint and watchpoint registers. In QEMU we implemented the support for writing the OS Lock bit via OSLAR_EL1 and reading it via OSLSR_

[PATCH 0/5] target/arm: Implement (or don't) OS Lock and DoubleLock properly

2022-06-30 Thread Peter Maydell
Continuing in my series of filling in bits of the architecture that probably nobody much cares about, this series fixes up Feat_DoubleLock. DoubleLock is a part of the debug architecture which allows a guest OS to suppress debug exceptions while it is powering down a CPU so that they don't cause up

[PATCH 1/5] target/arm: Fix code style issues in debug helper functions

2022-06-30 Thread Peter Maydell
Before moving debug system register helper functions to a different file, fix the code style issues (mostly block comment syntax) so checkpatch doesn't complain about the code-motion patch. Signed-off-by: Peter Maydell --- target/arm/helper.c | 58 + 1

Re: [PATCH v3 09/14] hw/sensor: Add IC_DEVICE_ID to ISL voltage regulators

2022-06-30 Thread Titus Rwantare
On Wed, 29 Jun 2022 at 21:52, Peter Delevoryas wrote: > > From: Peter Delevoryas > > This commit adds a passthrough for PMBUS_IC_DEVICE_ID to allow Renesas > voltage regulators to return the integrated circuit device ID if they > would like to. > > The behavior is very device specific, so it hasn

Re: [PATCH v3 08/14] hw/i2c/pmbus: Add idle state to return 0xff's

2022-06-30 Thread Titus Rwantare
On Wed, 29 Jun 2022 at 21:52, Peter Delevoryas wrote: > > From: Peter Delevoryas > > Signed-off-by: Peter Delevoryas > --- > hw/i2c/pmbus_device.c | 9 + > include/hw/i2c/pmbus_device.h | 7 +++ > 2 files changed, 16 insertions(+) > > diff --git a/hw/i2c/pmbus_device.c b/hw/

Re: [PATCH v3 10/14] hw/sensor: Add Renesas ISL69259 device model

2022-06-30 Thread Titus Rwantare
On Wed, 29 Jun 2022 at 21:52, Peter Delevoryas wrote: > > From: Peter Delevoryas > > This adds the ISL69259, using all the same functionality as the existing > ISL69260 but overriding the IC_DEVICE_ID. > > Signed-off-by: Peter Delevoryas > --- > hw/sensor/isl_pmbus_vr.c | 28 +++

Re: [PATCH v3 10/14] hw/sensor: Add Renesas ISL69259 device model

2022-06-30 Thread Titus Rwantare
On Wed, 29 Jun 2022 at 23:30, Cédric Le Goater wrote: > > On 6/30/22 06:51, Peter Delevoryas wrote: > > From: Peter Delevoryas > > > > This adds the ISL69259, using all the same functionality as the existing > > ISL69260 but overriding the IC_DEVICE_ID. > > > > Signed-off-by: Peter Delevoryas >

Re: [PATCH v6 6/8] KVM: Handle page fault for private memory

2022-06-30 Thread Vishal Annapurve
... > > > /* > > > diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c > > > index afe18d70ece7..e18460e0d743 100644 > > > --- a/arch/x86/kvm/mmu/mmu.c > > > +++ b/arch/x86/kvm/mmu/mmu.c > > > @@ -2899,6 +2899,9 @@ int kvm_mmu_max_mapping_level(struct kvm *kvm, > > > if (max_level

Re: [PATCH v3 14/14] hw/arm/aspeed: Add oby35-cl machine

2022-06-30 Thread Peter Delevoryas
On Thu, Jun 30, 2022 at 06:42:52PM +0200, Cédric Le Goater wrote: > On 6/30/22 18:15, Peter Delevoryas wrote: > > On Thu, Jun 30, 2022 at 01:02:54PM +0200, Cédric Le Goater wrote: > > > On 6/30/22 06:51, Peter Delevoryas wrote: > > > > From: Peter Delevoryas > > > > > > > > The fby35 machine incl

[Bug 1838390] Re: vmx_write_mem: mmu_gva_to_gpa failed when using hvf

2022-06-30 Thread Daniel Kolakowski
It still happens to me when I try to run Haiku builds on my macos 10.14. * QEMU emulator version 7.0.0 Command line: qemu-system-x86_64 -machine q35,accel=hvf -cpu host -smp 4 -m 2048 -vga vmware -boot menu=on -drive file="haiku-minimum.mmc",if=none,format=raw,id=x0 -device ide-hd,drive=x0,bus=i

Re: [PATCH] Align Raspberry Pi DMA interrupts with Linux DTS

2022-06-30 Thread Makarov, Andrey
> Is there any hardware documentation that says whether QEMU or > the DTB is correct? The device tree is at best a secondary source... No. It should have been in the "BCM2835 ARM Peripherals" datasheet but the appropriate "ARM peripherals interrupt table" there is nearly empty. > You can't con

Re: [PULL 00/14] (Mostly) build system changes for 2022-06-24

2022-06-30 Thread Peter Maydell
On Thu, 30 Jun 2022 at 18:14, Paolo Bonzini wrote: > > > > Il ven 24 giu 2022, 17:57 Richard Henderson ha > scritto: >> >> But then the i386 cross-compiler isn't used: > > > Yeah, that was intentional. In theory a softmmu target is freestanding and > does not need anything beyond the compiler i

Re: [PULL 00/14] (Mostly) build system changes for 2022-06-24

2022-06-30 Thread Paolo Bonzini
Il ven 24 giu 2022, 17:57 Richard Henderson ha scritto: > But then the i386 cross-compiler isn't used: > Yeah, that was intentional. In theory a softmmu target is freestanding and does not need anything beyond the compiler install, so configure defaults to the native compiler, which is biarch. T

[PATCH] linux-user: Fix stracing in-memory mmap arguments

2022-06-30 Thread Ilya Leoshkevich
On some architectures mmap() arguments are passed via an in-memory array, and qemu's strace support does not recognize that. Fix by sharing the argument fetching logic between mmap() implementation and tracing. An alternative approach would be to fetch arguments only once at the beginning of do_sy

Re: [PATCH v3 14/14] hw/arm/aspeed: Add oby35-cl machine

2022-06-30 Thread Cédric Le Goater
On 6/30/22 18:15, Peter Delevoryas wrote: On Thu, Jun 30, 2022 at 01:02:54PM +0200, Cédric Le Goater wrote: On 6/30/22 06:51, Peter Delevoryas wrote: From: Peter Delevoryas The fby35 machine includes 4 server boards, each of which has a "bridge interconnect" (BIC). This chip abstracts the pin

Re: [PATCH v3 13/14] hw/misc/aspeed: Add intel-me

2022-06-30 Thread Peter Delevoryas
On Thu, Jun 30, 2022 at 01:09:09PM +0200, Cédric Le Goater wrote: > On 6/30/22 06:51, Peter Delevoryas wrote: > > From: Peter Delevoryas > > > > The Intel Management Engine is an IPMI endpoint that responds to various > > IPMI commands. > > Have you looked at the ipmi-bmc-sim device ? It is rela

Re: [PATCH v3 14/14] hw/arm/aspeed: Add oby35-cl machine

2022-06-30 Thread Peter Delevoryas
On Thu, Jun 30, 2022 at 01:02:54PM +0200, Cédric Le Goater wrote: > On 6/30/22 06:51, Peter Delevoryas wrote: > > From: Peter Delevoryas > > > > The fby35 machine includes 4 server boards, each of which has a "bridge > > interconnect" (BIC). This chip abstracts the pinout for the server board > >

Re: [PATCH v2] target/i386: Add unaccepted memory configuration

2022-06-30 Thread Dionna Amalie Glaze
> > The most recent patches I recall for SEV-SNP introduced a new > > 'sev-snp-guest' object instead of overloading the existing > > 'sev-guest' object: > > > >https://lists.gnu.org/archive/html/qemu-devel/2021-08/msg04757.html > > > > Correct, the SNP support for Qemu is only RFC at this point

Re: [PATCH RFC 0/2] arm: enable MTE for QEMU + kvm

2022-06-30 Thread Cornelia Huck
On Wed, Jun 29 2022, Eric Auger wrote: > Hi Connie, > > On 6/13/22 18:02, Cornelia Huck wrote: >> On Fri, Jun 10 2022, Eric Auger wrote: >> >>> Hi Connie, >>> >>> On 5/12/22 15:11, Cornelia Huck wrote: This series enables MTE for kvm guests, if the kernel supports it. Lightly tested w

Re: [PATCH RFC 1/2] arm/kvm: enable MTE if available

2022-06-30 Thread Cornelia Huck
On Wed, Jun 29 2022, Eric Auger wrote: > Hi Connie, > > On 6/14/22 10:40, Cornelia Huck wrote: >> On Fri, Jun 10 2022, Eric Auger wrote: >> >>> Hi Connie, >>> On 5/12/22 15:11, Cornelia Huck wrote: We need to disable migration, as we do not yet have a way to migrate the tags as well.

Re: [PATCH v2] io_uring: fix short read slow path

2022-06-30 Thread Stefano Garzarella
On Thu, Jun 30, 2022 at 10:01:37AM +0900, Dominique Martinet wrote: sqeq.off here is the offset to read within the disk image, so obviously not 'nread' (the amount we just read), but as the author meant to write its current value incremented by the amount we just read. Normally recent versions o

Re: [PATCH v2 09/13] hw/i2c/pmbus: Add read-only IC_DEVICE_ID support

2022-06-30 Thread Patrick Venture
On Wed, Jun 29, 2022 at 11:34 AM Peter Delevoryas wrote: > > > > On Jun 29, 2022, at 11:04 AM, Titus Rwantare wrote: > > > > On Tue, 28 Jun 2022 at 20:36, Peter Delevoryas > > wrote: > >> > >> Signed-off-by: Peter Delevoryas > >> --- > > > >> --- a/hw/i2c/pmbus_device.c > >> +++ b/hw/i2c/pmbus

Re: [PATCH v2] io_uring: fix short read slow path

2022-06-30 Thread Hanna Reitz
On 30.06.22 03:01, Dominique Martinet wrote: sqeq.off here is the offset to read within the disk image, so obviously not 'nread' (the amount we just read), but as the author meant to write its current value incremented by the amount we just read. Normally recent versions of linux will not issue

Re: [PATCH v3 2/2] ui/gtk: a new array param monitor to specify the target displays

2022-06-30 Thread Markus Armbruster
Dongwon Kim writes: > New integer array parameter, 'monitor' is for specifying the target > monitors where individual GTK windows are placed upon launching. > > Monitor numbers in the array are associated with virtual consoles > in the order of [VC0, VC1, VC2 ... VCn]. > > Every GTK window contai

Re: [PATCH v5 05/12] qapi: net: add stream and dgram netdevs

2022-06-30 Thread Laurent Vivier
On 29/06/2022 13:20, Markus Armbruster wrote: Laurent Vivier writes: Copied from socket netdev file and modified to use SocketAddress to be able to introduce new features like unix socket. "udp" and "mcast" are squashed into dgram netdev, multicast is detected according to the IP address type

Re: [PATCH v3 1/3] ui/gtk: detach VCs for additional guest displays

2022-06-30 Thread Markus Armbruster
Dongwon Kim writes: > Detaching any addtional guest displays in case multiple displays are > assigned to the guest OS (e.g. max_outputs=n) so that all of them are > visible upon lauching. > > v2: - making sure type of VC is GD_VC_GFX before qemu_console_is_graphic > (Gerd Hoffman) > - v

Re: [PATCH] gtk: Add show_tabs=on|off command line option.

2022-06-30 Thread Markus Armbruster
Hanna Reitz writes: > Hi, > > (Thanks for the patch!) > > On 27.06.22 18:44, Felix xq Queißner wrote: >> The patch adds "show_tabs" command line option for GTK ui similar to >> "grab_on_hover". This option allows tabbed view mode to not have to be >> enabled by hand at each start of the VM. > >

Re: [PATCH v2] target/i386: Add unaccepted memory configuration

2022-06-30 Thread Tom Lendacky
On 6/30/22 03:14, Daniel P. Berrangé wrote: On Wed, Jun 29, 2022 at 07:37:01PM +, Dionna Glaze wrote: For SEV-SNP, an OS is "SEV-SNP capable" without supporting this UEFI v2.9 memory type. In order for OVMF to be able to avoid pre-validating potentially hundreds of gibibytes of data before b

Re: [PATCH 1/5] multifd: Create property multifd-sync-each-iteration

2022-06-30 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We used to synchronize all channels at the end of each RAM section > sent. That is not needed, so preparing to only synchronize once every > full round in latests patches. > > Notice that we initialize the property as true. We will change the > defa

Re: [PATCH] gtk: Add show_tabs=on|off command line option.

2022-06-30 Thread Hanna Reitz
On 30.06.22 16:09, Hanna Reitz wrote: Hi, (Thanks for the patch!) On 27.06.22 18:44, Felix xq Queißner wrote: The patch adds "show_tabs" command line option for GTK ui similar to "grab_on_hover". This option allows tabbed view mode to not have to be enabled by hand at each start of the VM.

Re: [PATCH] gtk: Add show_tabs=on|off command line option.

2022-06-30 Thread Hanna Reitz
Hi, (Thanks for the patch!) On 27.06.22 18:44, Felix xq Queißner wrote: The patch adds "show_tabs" command line option for GTK ui similar to "grab_on_hover". This option allows tabbed view mode to not have to be enabled by hand at each start of the VM. I’m not sure we have a hard rule on it

Re: [PATCH v3 2/3] target/ppc: Improve Radix xlate level validation

2022-06-30 Thread Fabiano Rosas
Leandro Lupori writes: > Check if the number and size of Radix levels are valid on > POWER9/POWER10 CPUs, according to the supported Radix Tree > Configurations described in their User Manuals. > > Signed-off-by: Leandro Lupori Reviewed-by: Fabiano Rosas > --- > target/ppc/mmu-radix64.c | 49

Re: [PATCH v4 0/4] hmat acpi: Don't require initiator value in -numa

2022-06-30 Thread Michael S. Tsirkin
On Thu, Jun 30, 2022 at 02:40:13PM +0200, Brice Goglin wrote: > > Le 30/06/2022 à 14:23, Igor Mammedov a écrit : > > On Thu, 30 Jun 2022 09:36:47 +0200 > > Brice Goglin wrote: > > > > > Allow -numa without initiator value when hmat=on so that we may > > > build more complex topologies, e.g. NUMA

Re: [PATCH v4 0/4] hmat acpi: Don't require initiator value in -numa

2022-06-30 Thread Michael S. Tsirkin
On Thu, Jun 30, 2022 at 02:56:16PM +0200, Igor Mammedov wrote: > On Thu, 30 Jun 2022 14:40:13 +0200 > Brice Goglin wrote: > > > Le 30/06/2022 à 14:23, Igor Mammedov a écrit : > > > On Thu, 30 Jun 2022 09:36:47 +0200 > > > Brice Goglin wrote: > > > > > >> Allow -numa without initiator value whe

Re: [PATCH v4 1/4] hmat acpi: Don't require initiator value in -numa

2022-06-30 Thread Michael S. Tsirkin
On Thu, Jun 30, 2022 at 09:40:19AM +0200, Brice Goglin wrote: ... > > Before this patch, we had to add ",initiator=X" to "-numa > node,nodeid=2,memdev=ram2". > The lstopo output difference between initiator=1 and no initiator is: > @@ -1,10 +1,10 @@ > Machine (2966MB total) + Package P#0 > +

Re: [PATCH v6 00/15] block: cleanup backing and file handling

2022-06-30 Thread Hanna Reitz
On 24.06.22 23:28, Vladimir Sementsov-Ogievskiy wrote: Hi all! That's the first part of "[PATCH v5 00/45] Transactional block-graph modifying API", updated and almost reviewed. On commit (15) is added to original scope of "block: cleanup backing and file handling", as it's related. 01: add Han

Re: [PATCH v20 00/13] Add LoongArch linux-user emulation support

2022-06-30 Thread gaosong
Hi, Richard On 2022/6/24 上午11:10, Song Gao wrote: Hi All, This series adds support linux-user emulation. As the LoongArch kernel had merged into 5.19-rc1, you can see the latest kernel at https://kernel.org Need review patch: 0002-linux-user-Add-LoongArch-signal-support.patch V20: - Up

Re: [PULL 15/18] qapi: introduce x-query-ramblock QMP command

2022-06-30 Thread Claudio Fontana
On 6/30/22 12:20, Daniel P. Berrangé wrote: > On Thu, Jun 30, 2022 at 12:14:36PM +0200, Claudio Fontana wrote: >> On 6/9/22 14:52, Dr. David Alan Gilbert wrote: >>> * Daniel P. Berrangé (berra...@redhat.com) wrote: On Thu, Jun 09, 2022 at 12:07:31PM +0200, Claudio Fontana wrote: > Hello al

Re: [PATCH v4 0/4] hmat acpi: Don't require initiator value in -numa

2022-06-30 Thread Igor Mammedov
On Thu, 30 Jun 2022 14:40:13 +0200 Brice Goglin wrote: > Le 30/06/2022 à 14:23, Igor Mammedov a écrit : > > On Thu, 30 Jun 2022 09:36:47 +0200 > > Brice Goglin wrote: > > > >> Allow -numa without initiator value when hmat=on so that we may > >> build more complex topologies, e.g. NUMA nodes wh

Re: [PATCH v4 0/4] hmat acpi: Don't require initiator value in -numa

2022-06-30 Thread Brice Goglin
Le 30/06/2022 à 14:23, Igor Mammedov a écrit : On Thu, 30 Jun 2022 09:36:47 +0200 Brice Goglin wrote: Allow -numa without initiator value when hmat=on so that we may build more complex topologies, e.g. NUMA nodes whose best initiators are not just another single node. patches looks fine cod

[PATCH v2 2/3] python/qmp/legacy: make QEMUMonitorProtocol accept a socket

2022-06-30 Thread marcandre . lureau
From: Marc-André Lureau Teach QEMUMonitorProtocol to accept an exisiting socket. Signed-off-by: Marc-André Lureau --- python/qemu/qmp/legacy.py | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/python/qemu/qmp/legacy.py b/python/qemu/qmp/legacy.py index 03

[PATCH v2 1/3] python/qmp/protocol: add open_with_socket()

2022-06-30 Thread marcandre . lureau
From: Marc-André Lureau Instead of listening for incoming connections with a SocketAddr, add a new method open_with_socket() that accepts an existing socket. Signed-off-by: Marc-André Lureau --- python/qemu/qmp/protocol.py | 25 - 1 file changed, 20 insertions(+), 5 del

[PATCH v2 0/3] python/qemu/machine: fix potential hang in QMP accept

2022-06-30 Thread marcandre . lureau
From: Marc-André Lureau Hi, As reported earlier by Richard Henderson ("virgl avocado hang" thread), avocado tests may hang when QEMU exits before the QMP connection is established. v2: - use a socketpair() for QMP (instead of async concurrent code from v1) as suggested by Daniel Berrange.

[PATCH v2 3/3] python/qemu/machine: use socketpair() for QMP by default

2022-06-30 Thread marcandre . lureau
From: Marc-André Lureau When no monitor address is given, establish the QMP communication through a socketpair() (API is also supported on Windows since Python 3.5) Signed-off-by: Marc-André Lureau --- python/qemu/machine/machine.py | 24 1 file changed, 16 insertions(

Re: [PATCH v4 0/4] hmat acpi: Don't require initiator value in -numa

2022-06-30 Thread Igor Mammedov
On Thu, 30 Jun 2022 09:36:47 +0200 Brice Goglin wrote: > Allow -numa without initiator value when hmat=on so that we may > build more complex topologies, e.g. NUMA nodes whose best initiators > are not just another single node. > patches looks fine code-wise, however something wrong with them, i

[PULL 23/27] hw/i2c: support multiple masters

2022-06-30 Thread Cédric Le Goater
From: Klaus Jensen Allow slaves to master the bus by registering a bottom halve. If the bus is busy, the bottom half is queued up. When a slave has succesfully mastered the bus, the bottom half is scheduled. Signed-off-by: Klaus Jensen [ clg : - fixed typos in commit log ] Message-Id: <20220601

[PULL 16/27] hw/sensor: add Maxim MAX31785 device

2022-06-30 Thread Cédric Le Goater
From: Maheswara Kurapati MAX31785 is a PMBus compliant 6-Channel fan controller. It supports 6 fan channels, 11 temperature sensors, and 6-Channel ADC to measure the remote voltages. Datasheet can be found here: https://datasheets.maximintegrated.com/en/ds/MAX31785.pdf This initial version of th

[PULL 15/27] hw/i2c: pmbus: Page #255 is valid page for read requests.

2022-06-30 Thread Cédric Le Goater
From: Maheswara Kurapati Current implementation of the pmbus core driver treats the read request for page 255 as invalid request and sets the invalid command bit (bit 7) in the STATUS_CML register. As per the PMBus specification it is a valid request. Refer to the PMBus specification, revision 1

[PULL 14/27] hw/arm/aspeed: add Qualcomm Firework BMC machine

2022-06-30 Thread Cédric Le Goater
From: Graeme Gregory Add base for Qualcomm Firework BMC machine. Signed-off-by: Graeme Gregory Signed-off-by: Jae Hyun Yoo Reviewed-by: Cédric Le Goater Message-Id: <20220627154703.148943-3-quic_jaeh...@quicinc.com> Signed-off-by: Cédric Le Goater --- hw/arm/aspeed.c | 34 ++

[PULL 13/27] hw/arm/aspeed: add support for the Qualcomm DC-SCM v1 board

2022-06-30 Thread Cédric Le Goater
From: Jae Hyun Yoo Add qcom-dc-scm-v1 board support. Signed-off-by: Jae Hyun Yoo Reviewed-by: Cédric Le Goater Message-Id: <20220627154703.148943-2-quic_jaeh...@quicinc.com> Signed-off-by: Cédric Le Goater --- hw/arm/aspeed.c | 35 +++ 1 file changed, 35 inser

  1   2   >