Re: Why we should avoid new submodules if possible

2022-06-28 Thread Ani Sinha
On Tue, Jun 28, 2022 at 11:30 PM Michael S. Tsirkin wrote: > > On Tue, Jun 28, 2022 at 05:15:05PM +0100, Daniel P. Berrangé wrote: > > FYI, the reason much of this is intentionally NOT under the /qemu-project > > gitlab namespace is that we did not want to be responsible for distributing > > arbit

[PATCH v3] xen/pass-through: merge emulated bits correctly

2022-06-28 Thread Chuck Zmudzinski
In xen_pt_config_reg_init(), there is an error in the merging of the emulated data with the host value. With the current Qemu, instead of merging the emulated bits with the host bits as defined by emu_mask, the emulated bits are merged with the host bits as defined by the inverse of emu_mask. In so

[PATCH v3] xen/pass-through: don't create needless register group

2022-06-28 Thread Chuck Zmudzinski
Currently we are creating a register group for the Intel IGD OpRegion for every device we pass through, but the XEN_PCI_INTEL_OPREGION register group is only valid for an Intel IGD. Add a check to make sure the device is an Intel IGD and a check that the administrator has enabled gfx_passthru in th

Re: [PATCH] target/ppc: Add error reporting when opening file fails

2022-06-28 Thread Markus Armbruster
jianchunfu writes: > Add error reporting before return when opening file fails. > > Signed-off-by: jianchunfu > --- > target/ppc/kvm.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c > index dc93b99189..ef9a871411 100644 > --- a/target/ppc/kvm.c >

Re: [PATCH v2] target/riscv: fix user-mode build issue because mhartid

2022-06-28 Thread Anup Patel
On Wed, Jun 29, 2022 at 9:27 AM Bin Meng wrote: > > Hi Rahul, > > On Wed, Jun 29, 2022 at 10:07 AM Rahul Pathak > wrote: > > > > Hi Alistair > > > > My fix patch needs to be dropped since Anup took care of this issue > > in his yesterdays series update in this patch - > > [PATCH v8 4/4] target/r

[PATCH v2 13/13] hw/arm/aspeed: Add oby35-cl machine

2022-06-28 Thread Peter Delevoryas
The fby35 machine includes 4 server boards, each of which has a "bridge interconnect" (BIC). This chip abstracts the pinout for the server board into a single endpoint that the baseboard management controller (BMC) can talk to using IPMB. The codename for this board is oby35-cl, which means "OpenB

Re: [PATCH v2] target/riscv: fix user-mode build issue because mhartid

2022-06-28 Thread Bin Meng
Hi Rahul, On Wed, Jun 29, 2022 at 10:07 AM Rahul Pathak wrote: > > Hi Alistair > > My fix patch needs to be dropped since Anup took care of this issue > in his yesterdays series update in this patch - > [PATCH v8 4/4] target/riscv: Force disable extensions if priv spec > version does not match I

[PATCH v2 12/13] hw/misc/aspeed: Add intel-me

2022-06-28 Thread Peter Delevoryas
The Intel Management Engine is an IPMI endpoint that responds to various IPMI commands. In this commit, I've added some very basic functionality that will respond back with a respond code of zero (success), while also setting an appropriate response NetFN (request NetFN + 1), a matching command ID

[PATCH v2 10/13] hw/misc/aspeed: Add PECI controller

2022-06-28 Thread Peter Delevoryas
This introduces a really basic PECI controller that responses to commands by always setting the response code to success and then raising an interrupt to indicate the command is done. This helps avoid getting hit with constant errors if the driver continuously attempts to send a command and keeps t

[PATCH v2 11/13] hw/misc/aspeed: Add fby35-sb-cpld

2022-06-28 Thread Peter Delevoryas
fby35 machines have 1 BMC on a baseboard and 2-4 server boards with BIC's. There are also CPLD's on each of the boards, one type of CPLD on the baseboard and another type on each of the server boards. This commit adds an implementation of some of the logic performed by the server board CPLD, which

[PATCH v2 09/13] hw/i2c/pmbus: Add read-only IC_DEVICE_ID support

2022-06-28 Thread Peter Delevoryas
Signed-off-by: Peter Delevoryas --- hw/i2c/pmbus_device.c| 5 + hw/sensor/isl_pmbus_vr.c | 31 +++ include/hw/i2c/pmbus_device.h| 1 + include/hw/sensor/isl_pmbus_vr.h | 1 + 4 files changed, 38 insertions(+) diff --git a/hw/i2c/pmbus_de

[PATCH v2 04/13] hw/i2c: support multiple masters

2022-06-28 Thread Peter Delevoryas
From: Klaus Jensen Allow slaves to master the bus by registering a bottom halve. If the bus is busy, the bottom half is queued up. When a slave has succesfully mastered the bus, the bottom half is scheduled. Signed-off-by: Klaus Jensen [ clg : - fixed typos in commit log ] Message-Id: <20220601

[PATCH v2 07/13] hw/i2c/aspeed: Add new-registers DMA slave mode RX support

2022-06-28 Thread Peter Delevoryas
This commit adds support for DMA RX in slave mode while using the new register set in the AST2600 and AST1030. This patch also pretty much assumes packet mode is enabled, I'm not sure if this will work in DMA step mode. This is particularly useful for testing IPMB exchanges between Zephyr and exte

[PATCH v2 05/13] hw/i2c: add asynchronous send

2022-06-28 Thread Peter Delevoryas
From: Klaus Jensen Add an asynchronous version of i2c_send() that requires the slave to explicitly acknowledge on the bus with i2c_ack(). The current master must use the new i2c_start_send_async() to indicate that it wants to do an asynchronous transfer. This allows the i2c core to check if the

[PATCH v2 00/13] hw/i2c/aspeed: Add new-registers DMA slave mode RX support

2022-06-28 Thread Peter Delevoryas
Hey Cedric, I've gone over the patch series and reordered it a little better. Changes since v1: - Replaced printf's with qemu_log_mask or trace events. - Added more detailed commit messages to several commits. - Removed one unnecessary patch through reordering intel-me before oby35-cl. - Replaced

[PATCH v2 08/13] hw/i2c/pmbus: Reset out buf after switching pages

2022-06-28 Thread Peter Delevoryas
When a pmbus device switches pages, it should clears its output buffer so that the next transaction doesn't emit data from the previous page. Fixes: 3746d5c15e70570b ("hw/i2c: add support for PMBus”) Signed-off-by: Peter Delevoryas --- hw/i2c/pmbus_device.c | 1 + 1 file changed, 1 insertion(+)

[PATCH v2 03/13] hw/i2c/aspeed: Fix MASTER_EN missing error message

2022-06-28 Thread Peter Delevoryas
aspeed_i2c_bus_is_master is checking if master mode is enabled in the I2C bus controller's function-control register, not that slave mode is enabled or something. The error here is that the guest is trying to trigger an I2C master mode command while master mode is not enabled. Fixes: ba2cccd64e90

[PATCH v2 06/13] hw/i2c/aspeed: add slave device in old register mode

2022-06-28 Thread Peter Delevoryas
From: Klaus Jensen Add slave mode functionality for the Aspeed I2C controller in old register mode. This is implemented by realizing an I2C slave device owned by the I2C controller and attached to its own bus. The I2C slave device only implements asynchronous sends on the bus, so slaves not supp

[PATCH v2 02/13] hw/i2c/aspeed: Fix DMA len write-enable bit handling

2022-06-28 Thread Peter Delevoryas
I noticed i2c rx transfers were getting shortened to "1" on Zephyr. It seems to be because the Zephyr i2c driver sets the RX DMA len with the RX field write-enable bit set (bit 31) to avoid a read-modify-write. [1] /* 0x1C : I2CM Master DMA Transfer Length Register */ I think we should be check

[PATCH v2 01/13] hw/i2c/aspeed: Fix R_I2CD_FUN_CTRL reference

2022-06-28 Thread Peter Delevoryas
Very minor, doesn't effect functionality, but this is supposed to be R_I2CC_FUN_CTRL (new-mode, not old-mode). Fixes: ba2cccd64e9 ("aspeed: i2c: Add new mode support") Signed-off-by: Peter Delevoryas --- hw/i2c/aspeed_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i

[PATCH] target/ppc: Add error reporting when opening file fails

2022-06-28 Thread jianchunfu
Add error reporting before return when opening file fails. Signed-off-by: jianchunfu --- target/ppc/kvm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index dc93b99189..ef9a871411 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -1798,6 +1798,7

Re: [PATCH] aspeed/smc: Fix potential overflow

2022-06-28 Thread Joel Stanley
On Tue, 28 Jun 2022 at 16:55, Cédric Le Goater wrote: > > Coverity warns that "ssi_transfer(s->spi, 0U) << 8 * i" might overflow > because the expression is evaluated using 32-bit arithmetic and then > used in a context expecting a uint64_t. Would it make sense to also place a limit on "size"? a

Re: [RFC v3 1/5] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls.

2022-06-28 Thread Sam Li
Damien Le Moal 于2022年6月29日周三 10:32写道: > > On 6/29/22 10:50, Sam Li wrote: > >>> +rep_size = sizeof(struct blk_zone_report) + nrz * sizeof(struct > >>> blk_zone); > >>> +g_autofree struct blk_zone_report *rep = g_new(struct > >>> blk_zone_report, nrz); > >> > >> g_

Re: [RFC v3 1/5] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls.

2022-06-28 Thread Damien Le Moal
On 6/29/22 10:50, Sam Li wrote: >>> +rep_size = sizeof(struct blk_zone_report) + nrz * sizeof(struct >>> blk_zone); >>> +g_autofree struct blk_zone_report *rep = g_new(struct >>> blk_zone_report, nrz); >> >> g_new() looks incorrect. There should be 1 struct blk_zon

[PATCH 0/2] vhost-user: Support vhost_dev_start

2022-06-28 Thread Yajun Wu
The motivation of adding vhost-user vhost_dev_start support is to improve backend configuration speed and reduce live migration VM downtime. Today VQ configuration is issued one by one. For virtio net with multi-queue support, backend needs to update RSS (Receive side scaling) on every rx queue en

[PATCH 1/2] vhost: Change the sequence of device start

2022-06-28 Thread Yajun Wu
This patch is part of adding vhost-user vhost_dev_start support. The motivation is to improve backend configuration speed and reduce live migration VM downtime. Moving the device start routines after finishing all the necessary device and VQ configuration, further aligning to the virtio specificat

[PATCH 2/2] vhost-user: Support vhost_dev_start

2022-06-28 Thread Yajun Wu
The motivation of adding vhost-user vhost_dev_start support is to improve backend configuration speed and reduce live migration VM downtime. Today VQ configuration is issued one by one. For virtio net with multi-queue support, backend needs to update RSS (Receive side scaling) on every rx queue en

Re: [PATCH] hw/riscv: virt: pass random seed to fdt

2022-06-28 Thread Alistair Francis
On Mon, Jun 13, 2022 at 10:10 PM Jason A. Donenfeld wrote: > > If the FDT contains /chosen/rng-seed, then the Linux RNG will use it to > initialize early. Set this using the usual guest random number > generation function. This is confirmed to successfully initialize the > RNG on Linux 5.19-rc2.

Re: [PATCH v2] target/riscv: fix user-mode build issue because mhartid

2022-06-28 Thread Rahul Pathak
Hi Alistair My fix patch needs to be dropped since Anup took care of this issue in his yesterdays series update in this patch - [PATCH v8 4/4] target/riscv: Force disable extensions if priv spec version does not match Thanks Rahul On Wed, Jun 29, 2022 at 7:32 AM Alistair Francis wrote: > > On T

Re: [PATCH v2] target/riscv: fix user-mode build issue because mhartid

2022-06-28 Thread Alistair Francis
On Tue, Jun 28, 2022 at 3:03 AM Rahul Pathak wrote: > > mhartid csr is not available in user-mode code path and > user-mode build fails because of its reference in > riscv_cpu_realize function > > Commit causing the issue is currently in Alistair's > riscv-to-apply.next branch and need to be squas

Re: [RFC v3 1/5] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls.

2022-06-28 Thread Sam Li
Damien Le Moal 于2022年6月29日周三 09:43写道: > > On 6/28/22 19:23, Sam Li wrote: > > Damien Le Moal 于2022年6月28日周二 17:05写道: > >> > >> On 6/28/22 17:05, Sam Li wrote: > >>> Stefan Hajnoczi 于2022年6月28日周二 14:52写道: > > On Mon, Jun 27, 2022 at 08:19:13AM +0800, Sam Li wrote: > > diff --git a/bl

Re: [RFC v3 1/5] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls.

2022-06-28 Thread Damien Le Moal
On 6/28/22 19:23, Sam Li wrote: > Damien Le Moal 于2022年6月28日周二 17:05写道: >> >> On 6/28/22 17:05, Sam Li wrote: >>> Stefan Hajnoczi 于2022年6月28日周二 14:52写道: On Mon, Jun 27, 2022 at 08:19:13AM +0800, Sam Li wrote: > diff --git a/block/block-backend.c b/block/block-backend.c > index e

Re: [PATCH v5 2/2] target/xtensa: Use semihosting/syscalls.h

2022-06-28 Thread Richard Henderson
On 6/28/22 19:08, Max Filippov wrote: On Tue, Jun 28, 2022 at 4:43 AM Richard Henderson wrote: This separates guest file descriptors from host file descriptors, and utilizes shared infrastructure for integration with gdbstub. Remove the xtensa custom console handing and rely on the generic -se

Re: running softmmu tcg target tests locally

2022-06-28 Thread Alex Bennée
Max Filippov writes: > Hello, > > there used to be an option to run tcg tests for a softmmu target with > make check-tcg > but since the commit 5377a1000192 ("tests/tcg: list test targets in > Makefile.prereqs") > it is no longer working for me. > > Is it supposed to be working and was broken b

Re: [RESEND PATCH] hw/dma: fix crash caused by race condition

2022-06-28 Thread Laurent Vivier
Le 06/05/2022 à 18:31, Tong Zhang a écrit : assert(dbs->acb) is meant to check the return value of io_func per documented in commit 6bee44ea34 ("dma: the passed io_func does not return NULL"). However, there is a chance that after calling aio_context_release(dbs->ctx); the dma_blk_cb function is

Re: [PATCH 2/2] hw/i386/xen/xen-hvm: Inline xen_piix_pci_write_config_client() and remove it

2022-06-28 Thread Laurent Vivier
Le 26/06/2022 à 11:46, Bernhard Beschow a écrit : xen_piix_pci_write_config_client() is implemented in the xen sub tree and uses PIIX constants internally, thus creating a direct dependency on PIIX. Now that xen_set_pci_link_route() is stubbable, the logic of xen_piix_pci_write_config_client() ca

Re: [PATCH 1/2] hw/i386/xen/xen-hvm: Allow for stubbing xen_set_pci_link_route()

2022-06-28 Thread Laurent Vivier
Le 26/06/2022 à 11:46, Bernhard Beschow a écrit : The only user of xen_set_pci_link_route() is xen_piix_pci_write_config_client() which implements PIIX-specific logic in the xen namespace. This makes xen-hvm depend on PIIX which could be avoided if xen_piix_pci_write_config_client() was implement

Re: Slowness with multi-thread TCG?

2022-06-28 Thread Alex Bennée
Frederic Barrat writes: > On 28/06/2022 17:12, Alex Bennée wrote: >> Frederic Barrat writes: >> >>> On 28/06/2022 13:25, Matheus K. Ferst wrote: On 27/06/2022 15:25, Frederic Barrat wrote: > [ Resending as it was meant for the qemu-ppc list ] > > Hello, > > I've been

Re: [PATCH v8 2/4] target/riscv: Set minumum priv spec version for mcountinhibit

2022-06-28 Thread Alistair Francis
On Tue, Jun 28, 2022 at 8:23 PM Anup Patel wrote: > > The minimum priv spec versino for mcountinhibit to v1.11 so that it > is not available for v1.10 (or lower). > > Fixes: eab4776b2bad ("target/riscv: Add support for hpmcounters/hpmevents") > Signed-off-by: Anup Patel Reviewed-by: Alistair Fra

Re: [PATCH 0/2] Decouple Xen-HVM from PIIX

2022-06-28 Thread Stefano Stabellini
On Tue, 28 Jun 2022, B wrote: > Am 26. Juni 2022 09:46:54 UTC schrieb Bernhard Beschow : > >hw/i386/xen/xen-hvm.c contains logic which is PIIX-specific. This makes > >xen-hvm.c depend on PIIX which can be avoided if PIIX logic was isolated in > >PIIX itself. > > > > > > > >Bernhard Beschow (2): >

Re: [PATCH 0/2] Decouple Xen-HVM from PIIX

2022-06-28 Thread B
Am 26. Juni 2022 09:46:54 UTC schrieb Bernhard Beschow : >hw/i386/xen/xen-hvm.c contains logic which is PIIX-specific. This makes >xen-hvm.c depend on PIIX which can be avoided if PIIX logic was isolated in >PIIX itself. > > > >Bernhard Beschow (2): > > hw/i386/xen/xen-hvm: Allow for stubbing

[PATCH v2] target/ppc: Return default CPU for max CPU

2022-06-28 Thread Murilo Opsfelder Araujo
All ppc CPUs represent hardware that exists in the real world, i.e.: we do not have a "max" CPU with all possible emulated features enabled. Return the default CPU type for the machine because that has greater chance of being useful as the "max" CPU. Resolves: https://gitlab.com/qemu-project/qemu/

Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held

2022-06-28 Thread Vladimir Sementsov-Ogievskiy
On 6/28/22 20:28, Emanuele Giuseppe Esposito wrote: Am 28/06/2022 um 17:26 schrieb Vladimir Sementsov-Ogievskiy: On 6/28/22 18:22, Vladimir Sementsov-Ogievskiy wrote: On 6/28/22 16:04, Emanuele Giuseppe Esposito wrote: Ok so far I did the following: - duplicated each public function as stat

Re: [PATCH] hw/arm/virt: dt: add rng-seed property

2022-06-28 Thread Jason A. Donenfeld
On 6/27/22, Jason A. Donenfeld wrote: > On 6/27/22, Peter Maydell wrote: >> On Mon, 27 Jun 2022 at 17:07, Jason A. Donenfeld wrote: >>> >>> In 60592cfed2 ("hw/arm/virt: dt: add kaslr-seed property"), the >>> kaslr-seed property was added, but the equally as important rng-seed >>> property was fo

Re: Why we should avoid new submodules if possible

2022-06-28 Thread Michael S. Tsirkin
On Tue, Jun 28, 2022 at 05:15:05PM +0100, Daniel P. Berrangé wrote: > FYI, the reason much of this is intentionally NOT under the /qemu-project > gitlab namespace is that we did not want to be responsible for distributing > arbitrary binary blobs/images. That in turn makes the QEMU project responsi

Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held

2022-06-28 Thread Emanuele Giuseppe Esposito
Am 28/06/2022 um 17:26 schrieb Vladimir Sementsov-Ogievskiy: > On 6/28/22 18:22, Vladimir Sementsov-Ogievskiy wrote: >> On 6/28/22 16:04, Emanuele Giuseppe Esposito wrote: > Ok so far I did the following: > > - duplicated each public function as static {function}_locked() They s

Re: [PATCH 0/2] python/qemu/machine: fix potential hang in QMP accept

2022-06-28 Thread John Snow
On Tue, Jun 28, 2022 at 9:49 AM wrote: > > From: Marc-André Lureau > > Hi, > > As reported earlier by Richard Henderson ("virgl avocado hang" thread), > avocado > tests may hang when QEMU exits before the QMP connection is established. > > My proposal to fix the problem here is to do both accept

Re: [PATCH v1 2/2] migration/multifd: Warn user when zerocopy not working

2022-06-28 Thread Dr. David Alan Gilbert
* Leonardo Bras Soares Passos (leob...@redhat.com) wrote: > On Tue, Jun 28, 2022 at 10:52 AM Dr. David Alan Gilbert > wrote: > > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > On Tue, Jun 28, 2022 at 09:32:04AM -0300, Leonardo Bras Soares Passos > > > wrote: > > > > On Tue, Jun 28, 2

[PATCH] aspeed/smc: Fix potential overflow

2022-06-28 Thread Cédric Le Goater
Coverity warns that "ssi_transfer(s->spi, 0U) << 8 * i" might overflow because the expression is evaluated using 32-bit arithmetic and then used in a context expecting a uint64_t. Fixes: Coverity CID 1487244 Signed-off-by: Cédric Le Goater --- hw/ssi/aspeed_smc.c | 4 ++-- 1 file changed, 2 inse

Re: [PATCH v1 2/2] migration/multifd: Warn user when zerocopy not working

2022-06-28 Thread Leonardo Bras Soares Passos
On Tue, Jun 28, 2022 at 10:52 AM Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Tue, Jun 28, 2022 at 09:32:04AM -0300, Leonardo Bras Soares Passos wrote: > > > On Tue, Jun 28, 2022 at 4:53 AM Daniel P. Berrangé > > > wrote: > > > > > > > > On Mon, Jun

running softmmu tcg target tests locally

2022-06-28 Thread Max Filippov
Hello, there used to be an option to run tcg tests for a softmmu target with make check-tcg but since the commit 5377a1000192 ("tests/tcg: list test targets in Makefile.prereqs") it is no longer working for me. Is it supposed to be working and was broken by accident? Or what is the correct way to

Re: [PATCH v4] hw: m25p80: add WP# pin and SRWD bit for write protection

2022-06-28 Thread Francisco Iglesias
On [2022 Jun 28] Tue 17:52:50, Cédric Le Goater wrote: > Alistair, Francisco, > > On 6/22/22 11:45, Francisco Iglesias wrote: > > On [2022 Jun 21] Tue 13:24:27, Iris Chen wrote: > > > From: Iris Chen > > > > > > Signed-off-by: Iris Chen > > > > Reviewed-by: Francisco Iglesias > > I am planni

Re: [PATCH 12/15] ipmi: Add an SMBus IPMI interface

2022-06-28 Thread Peter Maydell
On Thu, 19 Sept 2019 at 22:39, wrote: > > From: Corey Minyard > > Signed-off-by: Corey Minyard > --- Very old patch, but Coverity has decided it doesn't like something in this function that's still basically the same in the current codebase (CID 1487146): > +static int ipmi_write_data(SMBusDev

Re: Slowness with multi-thread TCG?

2022-06-28 Thread Frederic Barrat
On 28/06/2022 17:12, Alex Bennée wrote: Frederic Barrat writes: On 28/06/2022 13:25, Matheus K. Ferst wrote: On 27/06/2022 15:25, Frederic Barrat wrote: [ Resending as it was meant for the qemu-ppc list ] Hello, I've been looking at why our qemu powernv model is so slow when booting a

Re: [PATCH 1/3] aspeed/scu: Add trace events for read ops

2022-06-28 Thread Peter Delevoryas
> On Jun 28, 2022, at 8:47 AM, Cédric Le Goater wrote: > > Signed-off-by: Cédric Le Goater Also a nice change. Reviewed-by: Peter Delevoryas > --- > hw/misc/aspeed_scu.c | 2 ++ > hw/misc/trace-events | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/hw/misc/aspeed_scu.c b/hw/misc/

Re: Why we should avoid new submodules if possible

2022-06-28 Thread Daniel P . Berrangé
On Tue, Jun 28, 2022 at 09:24:34PM +0530, Ani Sinha wrote: > On Tue, Jun 28, 2022 at 6:09 PM Thomas Huth wrote: > > > > On 28/06/2022 13.14, Michael S. Tsirkin wrote: > > > On Tue, Jun 28, 2022 at 12:50:06PM +0200, Thomas Huth wrote: > > [...] > > >>> Come on, this is just a test. We *really* don'

Re: [PATCH 2/3] aspeed/i2c: Change trace event for NORMAL_STOP states

2022-06-28 Thread Peter Delevoryas
> On Jun 28, 2022, at 8:47 AM, Cédric Le Goater wrote: > > Using a 'stop' string seems more appropriate than 'normal'. Ha yes! This is an understatement, the change is much appreciated. I've seen that trace and never realized it was referring to ‘stop’. Reviewed-by: Peter Delevoryas > > S

Re: Why we should avoid new submodules if possible

2022-06-28 Thread Ani Sinha
On Tue, Jun 28, 2022 at 6:09 PM Thomas Huth wrote: > > On 28/06/2022 13.14, Michael S. Tsirkin wrote: > > On Tue, Jun 28, 2022 at 12:50:06PM +0200, Thomas Huth wrote: > [...] > >>> Come on, this is just a test. We *really* don't care if an ISO > >>> we use to test ACPI is using an exploitable vers

Re: [PATCH] hw/intc/armv7m_nvic: ICPRn must not unpend an IRQ that is being held high

2022-06-28 Thread Peter Maydell
On Tue, 28 Jun 2022 at 16:47, Peter Maydell wrote: > > In the M-profile Arm ARM, rule R_CVJS defines when an interrupt should > be set to the Pending state: > A) when the input line is high and the interrupt is not Active > B) when the input line transitions from low to high and the interrupt >

[PATCH 2/3] aspeed/i2c: Change trace event for NORMAL_STOP states

2022-06-28 Thread Cédric Le Goater
Using a 'stop' string seems more appropriate than 'normal'. Signed-off-by: Cédric Le Goater --- hw/i2c/aspeed_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i2c/aspeed_i2c.c b/hw/i2c/aspeed_i2c.c index 37ae1f2e04bd..9b41bc38964f 100644 --- a/hw/i2c/aspeed_i2c.c +++

Re: [PATCH v4] hw: m25p80: add WP# pin and SRWD bit for write protection

2022-06-28 Thread Cédric Le Goater
Alistair, Francisco, On 6/22/22 11:45, Francisco Iglesias wrote: On [2022 Jun 21] Tue 13:24:27, Iris Chen wrote: From: Iris Chen Signed-off-by: Iris Chen Reviewed-by: Francisco Iglesias I am planning to include this patch in the next aspeed PR if that's OK with you. Thanks, C. ---

[PATCH 3/3] aspeed: sbc: Allow per-machine settings

2022-06-28 Thread Cédric Le Goater
From: Joel Stanley In order to correctly report secure boot running firmware the values of certain registers must be set. We don't yet have documentation from ASPEED on what they mean. The meaning is inferred from u-boot's use of them. Introduce properties so the settings can be configured per-

[PATCH 1/3] aspeed/scu: Add trace events for read ops

2022-06-28 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/misc/aspeed_scu.c | 2 ++ hw/misc/trace-events | 1 + 2 files changed, 3 insertions(+) diff --git a/hw/misc/aspeed_scu.c b/hw/misc/aspeed_scu.c index 19b03471fc4e..83353649064a 100644 --- a/hw/misc/aspeed_scu.c +++ b/hw/misc/aspeed_scu.c @@ -270,6 +270,7 @@

[PATCH 0/3] aspeed: small cleanups

2022-06-28 Thread Cédric Le Goater
Hello, I was preparing a PR and I realized that these small patches had never seen the light. Here they are. Thanks, C. Cédric Le Goater (2): aspeed/scu: Add trace events for read ops aspeed/i2c: Change trace event for NORMAL_STOP states Joel Stanley (1): aspeed: sbc: Allow per-machine s

[PATCH] hw/intc/armv7m_nvic: ICPRn must not unpend an IRQ that is being held high

2022-06-28 Thread Peter Maydell
In the M-profile Arm ARM, rule R_CVJS defines when an interrupt should be set to the Pending state: A) when the input line is high and the interrupt is not Active B) when the input line transitions from low to high and the interrupt is Active (Note that the first of these is an ongoing condit

[job ad] Linaro is looking for a QEMU and virtualisation developer

2022-06-28 Thread Alex Bennée
Hi, Pretty much as the subject says, see the full listing for details: https://careers.linaro.org/jobs/1693998-qemu-and-virtualization-developer [This job ad is in line with qemu-devel policy which allows occasional brief ads if posted by list regulars] -- Alex Bennée

Re: [PATCH v5 4/5] i386/pc: relocate 4g start to 1T where applicable

2022-06-28 Thread Joao Martins
On 6/28/22 13:38, Igor Mammedov wrote: > On Mon, 20 Jun 2022 19:13:46 +0100 > Joao Martins wrote: > >> On 6/20/22 17:36, Joao Martins wrote: >>> On 6/20/22 15:27, Igor Mammedov wrote: On Fri, 17 Jun 2022 14:33:02 +0100 Joao Martins wrote: > On 6/17/22 13:32, Igor Mammedov wr

Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held

2022-06-28 Thread Vladimir Sementsov-Ogievskiy
On 6/28/22 18:22, Vladimir Sementsov-Ogievskiy wrote: On 6/28/22 16:04, Emanuele Giuseppe Esposito wrote: Ok so far I did the following: - duplicated each public function as static {function}_locked() They shouldn't be duplicates: function without _locked suffix should take the mutex. By "dup

Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held

2022-06-28 Thread Vladimir Sementsov-Ogievskiy
On 6/28/22 16:04, Emanuele Giuseppe Esposito wrote: Ok so far I did the following: - duplicated each public function as static {function}_locked() They shouldn't be duplicates: function without _locked suffix should take the mutex. By "duplicate" I mean same function name, with just _locked su

Re: [PATCH v7 01/18] job.c: make job_mutex and job_lock/unlock() public

2022-06-28 Thread Vladimir Sementsov-Ogievskiy
On 6/28/22 16:08, Emanuele Giuseppe Esposito wrote: Am 24/06/2022 um 20:22 schrieb Vladimir Sementsov-Ogievskiy: I've already acked this (honestly, because Stefan do), but still, want to clarify: On 6/16/22 16:18, Emanuele Giuseppe Esposito wrote: job mutex will be used to protect the job st

Re: Slowness with multi-thread TCG?

2022-06-28 Thread Alex Bennée
Frederic Barrat writes: > On 28/06/2022 13:25, Matheus K. Ferst wrote: >> On 27/06/2022 15:25, Frederic Barrat wrote: >>> [ Resending as it was meant for the qemu-ppc list ] >>> >>> Hello, >>> >>> I've been looking at why our qemu powernv model is so slow when booting >>> a compressed linux ker

Re: Why we should avoid new submodules if possible

2022-06-28 Thread Warner Losh
On Tue, Jun 28, 2022 at 5:10 AM Michael S. Tsirkin wrote: > git submodules are awkward basically because they are an automated wget. > I don't think an explicit wget is much better ... but > looks like I'm alone in this. Oh well. > submodules are 90% of the hassles I have in upstreaming and upd

Re: Why we should avoid new submodules if possible

2022-06-28 Thread Michael S. Tsirkin
On Tue, Jun 28, 2022 at 02:39:31PM +0200, Thomas Huth wrote: > On 28/06/2022 13.14, Michael S. Tsirkin wrote: > > On Tue, Jun 28, 2022 at 12:50:06PM +0200, Thomas Huth wrote: > [...] > > > > Come on, this is just a test. We *really* don't care if an ISO > > > > we use to test ACPI is using an explo

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

2022-06-28 Thread Michael S. Tsirkin
On Tue, Jun 28, 2022 at 06:52:55PM +0530, Ani Sinha wrote: > So why burden everyone by having bios-tables-test when it only affects > acpi/smbios developers? No it doesn't. Any change in qemu can break ACPI - it's enough to register an MR overlapping the ACPI registers. So we have a basic test ma

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

2022-06-28 Thread Michael S. Tsirkin
On Tue, Jun 28, 2022 at 01:55:48PM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 28, 2022 at 06:06:19PM +0530, Ani Sinha wrote: > > On Tue, Jun 28, 2022 at 5:40 PM Peter Maydell > > wrote: > > > > > > On Tue, 28 Jun 2022 at 12:50, Michael S. Tsirkin wrote: > > > > I think the main difference is

Re: [PATCH 3/4] tests: acpi: q35: add test for hmat nodes without initiators

2022-06-28 Thread Igor Mammedov
On Thu, 23 Jun 2022 16:59:29 +0200 Brice Goglin wrote: maybe add a description of what you are testing something along: machine with X numa nodes configured like this or that ... > expected HMAT: > > [000h 4]Signature : "HMAT"[Heterogeneous > Memory Attribu

Re: [PATCH 1/4] hmat acpi: Don't require initiator value in -numa

2022-06-28 Thread Brice Goglin
Le 28/06/2022 à 16:19, Igor Mammedov a écrit : On Thu, 23 Jun 2022 16:58:28 +0200 Brice Goglin wrote: The "Memory Proximity Domain Attributes" structure of the ACPI HMAT has a "Processor Proximity Domain Valid" flag that is currently always set because Qemu -numa requires an initiator=X value

Re: [PATCH 0/2] python/qemu/machine: fix potential hang in QMP accept

2022-06-28 Thread Daniel P . Berrangé
On Tue, Jun 28, 2022 at 05:49:37PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Hi, > > As reported earlier by Richard Henderson ("virgl avocado hang" thread), > avocado > tests may hang when QEMU exits before the QMP connection is established. > > My proposal to fix

Re: [PATCH 2/4] tests: acpi: add and whitelist *.hmat-noinitiator expected blobs

2022-06-28 Thread Igor Mammedov
On Thu, 23 Jun 2022 16:59:01 +0200 Brice Goglin wrote: > .. which will be used by follow up hmat-noinitiator test-case. > > Signed-off-by: Brice Goglin Acked-by: Igor Mammedov > --- > tests/data/acpi/q35/APIC.acpihmat-noinitiator | 0 > tests/data/acpi/q35/DSDT.acpihmat-noinitiator | 0 >

Re: [PATCH 0/4] hmat acpi: Don't require initiator value in -numa

2022-06-28 Thread Igor Mammedov
On Thu, 23 Jun 2022 16:56:58 +0200 Brice Goglin wrote: here should be a brief introduction to series [and changelog if it's not the first revision] > Brice Goglin (4): >hmat acpi: Don't require initiator value in -numa >tests: acpi: add and whitelist *.hmat-noinitiator expected blobs >

Re: [PATCH 1/4] hmat acpi: Don't require initiator value in -numa

2022-06-28 Thread Igor Mammedov
On Thu, 23 Jun 2022 16:58:28 +0200 Brice Goglin wrote: > The "Memory Proximity Domain Attributes" structure of the ACPI HMAT > has a "Processor Proximity Domain Valid" flag that is currently > always set because Qemu -numa requires an initiator=X value > when hmat=on. Unsetting this flag allows t

Re: [PATCH 2/2] python/qemu/machine: accept QMP connection asynchronously

2022-06-28 Thread Daniel P . Berrangé
On Tue, Jun 28, 2022 at 05:49:39PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > QMP accept is currently synchronous. If qemu dies before the connection > is established, it will wait there. Instead turn the code to do > concurrently accept() and wait(). Returns when the

Re: [PATCH 4/5] tests: use consistent bandwidth/downtime limits in migration tests

2022-06-28 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > The different migration test cases are using a variety of settings > to ensure convergance/non-convergance. Introduce two helpers to > extra the common functionality and ensure consistency. > > * Non-convergance: 1ms downtime, 30mbs bandwidth >

Re: [PATCH 2/5] tests: wait for migration completion before looking for STOP event

2022-06-28 Thread Daniel P . Berrangé
On Tue, Jun 28, 2022 at 03:08:29PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > When moving into the convergance phase, the precopy tests will first > > look for a STOP event and once found will look for migration completion > > status. If the test VM

Re: [PATCH 2/5] tests: wait for migration completion before looking for STOP event

2022-06-28 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > When moving into the convergance phase, the precopy tests will first > look for a STOP event and once found will look for migration completion > status. If the test VM is not converging, the test suite will be waiting > for the STOP event forever.

Re: [PATCH v8 01/15] fixup! migration: remove the QEMUFileOps 'get_buffer' callback

2022-06-28 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > This fixes a bug with the cleanup patch. Should be squashed into the patch > in subject. Yep, that one is already in; thanks. Dave > Cc: Daniel P. Berrange > Signed-off-by: Peter Xu > --- > migration/qemu-file.c | 2 +- > 1 file changed, 1 insertion(+)

[PATCH v3 2/3] target/ppc: Improve Radix xlate level validation

2022-06-28 Thread Leandro Lupori
Check if the number and size of Radix levels are valid on POWER9/POWER10 CPUs, according to the supported Radix Tree Configurations described in their User Manuals. Signed-off-by: Leandro Lupori --- target/ppc/mmu-radix64.c | 49 +++- 1 file changed, 38 insert

[PATCH v3 3/3] target/ppc: Check page dir/table base alignment

2022-06-28 Thread Leandro Lupori
According to PowerISA 3.1B, Book III 6.7.6 programming note, the page directory base addresses are expected to be aligned to their size. Real hardware seems to rely on that and will access the wrong address if they are misaligned. This results in a translation failure even if the page tables seem t

[PATCH v3 1/3] ppc: Check partition and process table alignment

2022-06-28 Thread Leandro Lupori
Check if partition and process tables are properly aligned, in their size, according to PowerISA 3.1B, Book III 6.7.6 programming note. Hardware and KVM also raise an exception in these cases. Signed-off-by: Leandro Lupori Reviewed-by: Fabiano Rosas --- hw/ppc/spapr.c | 5 + hw

[PATCH v3 0/3] ppc: Check for bad Radix configs

2022-06-28 Thread Leandro Lupori
Changes from v2: - Improved comments on patch 2 - Improved commit message on patch 3 - Now emulating CPU behavior on misaligned page table base addresses Leandro Lupori (3): ppc: Check partition and process table alignment target/ppc: Improve Radix xlate level validation target/ppc: Check pa

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

2022-06-28 Thread Peter Maydell
On Tue, 28 Jun 2022 at 14:53, Ani Sinha wrote: > > > > On Tue, Jun 28, 2022 at 19:15 Peter Maydell wrote: >> >> On Tue, 28 Jun 2022 at 14:23, Ani Sinha wrote: >> > On Tue, Jun 28, 2022 at 6:25 PM Daniel P. Berrangé >> > wrote: >> > > This proposed biosbits test also involves a considerable dow

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

2022-06-28 Thread Ani Sinha
On Tue, Jun 28, 2022 at 19:15 Peter Maydell wrote: > On Tue, 28 Jun 2022 at 14:23, Ani Sinha wrote: > > On Tue, Jun 28, 2022 at 6:25 PM Daniel P. Berrangé > wrote: > > > This proposed biosbits test also involves a considerable download. > > > > I do not think 50 MB is "considerable" . Last time

Re: [PATCH v1 2/2] migration/multifd: Warn user when zerocopy not working

2022-06-28 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Tue, Jun 28, 2022 at 09:32:04AM -0300, Leonardo Bras Soares Passos wrote: > > On Tue, Jun 28, 2022 at 4:53 AM Daniel P. Berrangé > > wrote: > > > > > > On Mon, Jun 27, 2022 at 10:09:09PM -0300, Leonardo Bras wrote: > > > > Some errors, like t

[PATCH 2/2] python/qemu/machine: accept QMP connection asynchronously

2022-06-28 Thread marcandre . lureau
From: Marc-André Lureau QMP accept is currently synchronous. If qemu dies before the connection is established, it will wait there. Instead turn the code to do concurrently accept() and wait(). Returns when the first task is completed to determine whether a connection was established. Signed-off

[PATCH 0/2] python/qemu/machine: fix potential hang in QMP accept

2022-06-28 Thread marcandre . lureau
From: Marc-André Lureau Hi, As reported earlier by Richard Henderson ("virgl avocado hang" thread), avocado tests may hang when QEMU exits before the QMP connection is established. My proposal to fix the problem here is to do both accept() and wait() concurrently by turning some code async. Obv

[PATCH 1/2] python/qemu/machine: replace subprocess.Popen with asyncio

2022-06-28 Thread marcandre . lureau
From: Marc-André Lureau The following patch is going to wait for both subprocess and accept tasks concurrently. Switch to using asyncio for subprocess handling. Signed-off-by: Marc-André Lureau --- python/qemu/machine/machine.py | 47 ++ 1 file changed, 31 inser

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

2022-06-28 Thread Peter Maydell
On Tue, 28 Jun 2022 at 14:23, Ani Sinha wrote: > On Tue, Jun 28, 2022 at 6:25 PM Daniel P. Berrangé > wrote: > > This proposed biosbits test also involves a considerable download. > > I do not think 50 MB is "considerable" . Last time I tried to run > avocado tests, my laptop ran out of disk spa

Re: [PATCH v5 0/2] target/xtensa: semihosting cleanup

2022-06-28 Thread Max Filippov
On Tue, Jun 28, 2022 at 4:43 AM Richard Henderson wrote: > > Changes for v5: > * Rebase on master. > > r~ > > > Richard Henderson (2): > target/xtensa: Use an exception for semihosting > target/xtensa: Use semihosting/syscalls.h > > target/xtensa/cpu.h | 3 +- > target/xtensa/help

Re: [PATCH v5 2/2] target/xtensa: Use semihosting/syscalls.h

2022-06-28 Thread Max Filippov
On Tue, Jun 28, 2022 at 4:43 AM Richard Henderson wrote: > > This separates guest file descriptors from host file descriptors, > and utilizes shared infrastructure for integration with gdbstub. > Remove the xtensa custom console handing and rely on the > generic -semihosting-config handling of cha

Re: [PATCH 08/12] pc-bios/s390-ccw/virtio: Beautify the code for reading virtqueue configuration

2022-06-28 Thread Cornelia Huck
On Tue, Jun 28 2022, Thomas Huth wrote: > It looks nicer if we separate the run_ccw() from the IPL_assert() > statement, and the error message should talk about "virtio device" > instead of "block device", since this code is nowadays used for > non-block (i.e. network) devices, too. > > Signed-of

  1   2   3   4   >