Re: [PATCH 1/3] vhost: Refactor vhost_reset_device() in VhostOps

2022-04-01 Thread Michael Qiu
On 2022/4/2 10:38, Jason Wang wrote: 在 2022/4/1 下午7:06, Michael Qiu 写道: Currently in vhost framwork, vhost_reset_device() is misnamed. Actually, it should be vhost_reset_owner(). In vhost user, it make compatible with reset device ops, but vhost kernel does not compatible with it, for vhost

Re: [PATCH v4] vdpa: reset the backend device in the end of vhost_net_stop()

2022-04-01 Thread Michael Qiu
On 2022/4/2 10:20, Jason Wang wrote: Adding Michael. On Sat, Apr 2, 2022 at 7:08 AM Si-Wei Liu wrote: On 3/31/2022 7:53 PM, Jason Wang wrote: On Fri, Apr 1, 2022 at 9:31 AM Michael Qiu wrote: Currently, when VM poweroff, it will trigger vdpa device(such as mlx bluefield2 VF) reset man

Re: [PATCH v4] vdpa: reset the backend device in the end of vhost_net_stop()

2022-04-01 Thread Michael Qiu
On 2022/4/2 9:48, Jason Wang wrote: On Fri, Apr 1, 2022 at 11:22 AM Michael Qiu wrote: On 2022/4/1 10:53, Jason Wang wrote: On Fri, Apr 1, 2022 at 9:31 AM Michael Qiu wrote: Currently, when VM poweroff, it will trigger vdpa device(such as mlx bluefield2 VF) reset many times(with 1 dat

Re: [PATCH 1/3] vhost: Refactor vhost_reset_device() in VhostOps

2022-04-01 Thread Jason Wang
在 2022/4/1 下午7:06, Michael Qiu 写道: Currently in vhost framwork, vhost_reset_device() is misnamed. Actually, it should be vhost_reset_owner(). In vhost user, it make compatible with reset device ops, but vhost kernel does not compatible with it, for vhost vdpa, it only implement reset device ac

Re: [PATCH v5 3/4] hw/intc/exynos4210: replace 'qemu_split_irq' in combiner and gic

2022-04-01 Thread Zongyuan Li
On Fri, Apr 1, 2022 at 9:35 PM Peter Maydell wrote: > > On Thu, 24 Mar 2022 at 18:16, Zongyuan Li wrote: > > > > Signed-off-by: Zongyuan Li > > --- > > hw/arm/exynos4210.c | 26 +++ > > hw/intc/exynos4210_combiner.c | 81 +++ > > hw/intc/exynos4

Re: [PATCH v3 1/4] hw/arm/virt: Consider SMP configuration in CPU topology

2022-04-01 Thread wangyanan (Y)
On 2022/3/30 20:50, Igor Mammedov wrote: On Sat, 26 Mar 2022 02:49:59 +0800 Gavin Shan wrote: Hi Igor, On 3/25/22 9:19 PM, Igor Mammedov wrote: On Wed, 23 Mar 2022 15:24:35 +0800 Gavin Shan wrote: Currently, the SMP configuration isn't considered when the CPU topology is populated. In this

Re: [PATCH v4] vdpa: reset the backend device in the end of vhost_net_stop()

2022-04-01 Thread Jason Wang
Adding Michael. On Sat, Apr 2, 2022 at 7:08 AM Si-Wei Liu wrote: > > > > On 3/31/2022 7:53 PM, Jason Wang wrote: > > On Fri, Apr 1, 2022 at 9:31 AM Michael Qiu wrote: > >> Currently, when VM poweroff, it will trigger vdpa > >> device(such as mlx bluefield2 VF) reset many times(with 1 datapath >

Re: [PATCH v3 1/4] hw/arm/virt: Consider SMP configuration in CPU topology

2022-04-01 Thread wangyanan (Y)
Hi Gavin, On 2022/3/23 15:24, Gavin Shan wrote: Currently, the SMP configuration isn't considered when the CPU topology is populated. In this case, it's impossible to provide the default CPU-to-NUMA mapping or association based on the socket ID of the given CPU. This takes account of SMP config

Re: [PATCH v2 0/4] Dirty ring and auto converge optimization

2022-04-01 Thread Chongyun Wu
Thanks for review. On 4/1/2022 9:13 PM, Peter Xu wrote: Chongyun, On Mon, Mar 28, 2022 at 09:32:10AM +0800, wuc...@chinatelecom.cn wrote: From: Chongyun Wu v2: -patch 1: remove patch_1 v1: -rebase to qemu/master Overview This series of patches is to optimize the performance of

Re: [PATCH 1/7] virtio-net: align ctrl_vq index for non-mq guest for vhost_vdpa

2022-04-01 Thread Jason Wang
On Sat, Apr 2, 2022 at 6:32 AM Si-Wei Liu wrote: > > > > On 3/31/2022 1:39 AM, Jason Wang wrote: > > On Wed, Mar 30, 2022 at 11:48 PM Si-Wei Liu wrote: > >> > >> > >> On 3/30/2022 2:00 AM, Jason Wang wrote: > >>> On Wed, Mar 30, 2022 at 2:33 PM Si-Wei Liu wrote: > With MQ enabled vdpa devic

Re: [PATCH 1/3] vhost: Refactor vhost_reset_device() in VhostOps

2022-04-01 Thread Michael Qiu
On 2022/4/2 8:44, Si-Wei Liu wrote: On 4/1/2022 4:06 AM, Michael Qiu wrote: Currently in vhost framwork, vhost_reset_device() is misnamed. Actually, it should be vhost_reset_owner(). In vhost user, it make compatible with reset device ops, but vhost kernel does not compatible with it, for

Re: [PATCH v3 2/4] hw/arm/virt: Fix CPU's default NUMA node ID

2022-04-01 Thread wangyanan (Y)
On 2022/3/23 15:24, Gavin Shan wrote: When CPU-to-NUMA association isn't explicitly provided by users, the default on is given by mc->get_default_cpu_node_id(). However, s/on/one the CPU topology isn't fully considered in the default association and this causes CPU topology broken warnings on

Re: [PATCH 4/7] virtio: don't read pending event on host notifier if disabled

2022-04-01 Thread Jason Wang
On Sat, Apr 2, 2022 at 4:37 AM Si-Wei Liu wrote: > > > > On 3/31/2022 1:36 AM, Jason Wang wrote: > > On Thu, Mar 31, 2022 at 12:41 AM Si-Wei Liu wrote: > >> > >> > >> On 3/30/2022 2:14 AM, Jason Wang wrote: > >>> On Wed, Mar 30, 2022 at 2:33 PM Si-Wei Liu wrote: > Previous commit prevents v

Re: [PATCH V2 4/4] intel-iommu: PASID support

2022-04-01 Thread Jason Wang
On Fri, Apr 1, 2022 at 9:43 PM Yi Liu wrote: > > > > On 2022/3/29 12:54, Jason Wang wrote: > > > > 在 2022/3/28 下午4:45, Yi Liu 写道: > >> > >> > >> On 2022/3/21 13:54, Jason Wang wrote: > >>> This patch introduce ECAP_PASID via "x-pasid-mode". Based on the > >>> existing support for scalable mode, we

Re: [PATCH v4] vdpa: reset the backend device in the end of vhost_net_stop()

2022-04-01 Thread Jason Wang
On Fri, Apr 1, 2022 at 11:22 AM Michael Qiu wrote: > > > > On 2022/4/1 10:53, Jason Wang wrote: > > On Fri, Apr 1, 2022 at 9:31 AM Michael Qiu wrote: > >> > >> Currently, when VM poweroff, it will trigger vdpa > >> device(such as mlx bluefield2 VF) reset many times(with 1 datapath > >> queue pair

Re: [PATCH 7/7] vhost-vdpa: backend feature should set only once

2022-04-01 Thread Jason Wang
On Fri, Apr 1, 2022 at 12:18 PM Si-Wei Liu wrote: > > > > On 3/31/2022 7:39 PM, Jason Wang wrote: > > On Thu, Mar 31, 2022 at 5:20 PM Eugenio Perez Martin > > wrote: > >> On Thu, Mar 31, 2022 at 10:54 AM Jason Wang wrote: > >>> > >>> 在 2022/3/31 下午4:02, Eugenio Perez Martin 写道: > On Thu, Ma

Re: [PATCH] vhost: Fix bad return of descriptors to SVQ

2022-04-01 Thread Jason Wang
On Fri, Apr 1, 2022 at 3:31 PM Eugenio Perez Martin wrote: > > On Fri, Apr 1, 2022 at 4:30 AM Jason Wang wrote: > > > > On Fri, Apr 1, 2022 at 2:14 AM Eugenio Pérez wrote: > > > > > > Only the first one of them were properly enqueued back. > > > > > > Fixes: 100890f7ca ("vhost: Shadow virtqueue

Re: [PATCH 2/3] vhost: add vhost_dev_reset()

2022-04-01 Thread Si-Wei Liu
On 4/1/2022 4:06 AM, Michael Qiu wrote: Not all vhost-user backends support ops->vhost_reset_device(). Instead of adding backend check and call backend ops directly, it's better to implement a function in vhost framework, so that it could hide vhost_ops details. SIgned-off-by: Michael Qiu --

Re: [PATCH 1/3] vhost: Refactor vhost_reset_device() in VhostOps

2022-04-01 Thread Si-Wei Liu
On 4/1/2022 4:06 AM, Michael Qiu wrote: Currently in vhost framwork, vhost_reset_device() is misnamed. Actually, it should be vhost_reset_owner(). In vhost user, it make compatible with reset device ops, but vhost kernel does not compatible with it, for vhost vdpa, it only implement reset dev

Re: [PATCH v4] vdpa: reset the backend device in the end of vhost_net_stop()

2022-04-01 Thread Si-Wei Liu
On 3/31/2022 7:53 PM, Jason Wang wrote: On Fri, Apr 1, 2022 at 9:31 AM Michael Qiu wrote: Currently, when VM poweroff, it will trigger vdpa device(such as mlx bluefield2 VF) reset many times(with 1 datapath queue pair and one control queue, triggered 3 times), this leads to below issue: vho

[RFC PATCH v1 8/8] qapi: golang: document skip function visit_array_types

2022-04-01 Thread Victor Toso
Signed-off-by: Victor Toso --- scripts/qapi/golang.py | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/scripts/qapi/golang.py b/scripts/qapi/golang.py index 5d3395514d..9a775d0691 100644 --- a/scripts/qapi/golang.py +++ b/scripts/qapi/golang.py @@ -321,7 +321,12 @@ def vi

[RFC PATCH v1 6/8] qapi: golang: Generate qapi's command types in Go

2022-04-01 Thread Victor Toso
This patch handles QAPI command types and generates data structures in Go that decodes from QMP JSON Object to Go data structure and vice versa. At the time of this writing, it generates 210 structures (208 commands) This is very similar to previous commit, that handles QAPI union types in Go. E

[RFC PATCH v1 3/8] qapi: golang: Generate qapi's struct types in Go

2022-04-01 Thread Victor Toso
This patch handles QAPI struct types and generates the equivalent types in Go. At the time of this writing, it generates 375 structures. The highlights of this implementation are: 1. Generating an Go struct that requires a @base type, the @base type is embedded in this Go structure. Examp

[RFC PATCH v1 7/8] qapi: golang: Add CommandResult type to Go

2022-04-01 Thread Victor Toso
This patch adds a struct type in Go that will handle return values for QAPI's command types. The return value of a Command is, encouraged to be, QAPI's complext types or an Array of those. The 'CommandResult' type acts in similar fashion to 'Event' and 'Command', in order to map the right return

[RFC PATCH v1 4/8] qapi: golang: Generate qapi's union types in Go

2022-04-01 Thread Victor Toso
This patch handles QAPI union types and generates the equivalent data structures and methods in Go to handle it. At the moment of this writing, it generates 67 structures. The QAPI union type can be summarized by its common members that are defined in a @base struct and a @value. The @value type

[RFC PATCH v1 2/8] qapi: golang: Generate qapi's alternate types in Go

2022-04-01 Thread Victor Toso
This patch handles QAPI alternate types and generates data structures in Go that handles it. At this moment, there are 5 alternates in qemu/qapi, they are: * BlockDirtyBitmapMergeSource * Qcow2OverlapChecks * BlockdevRef * BlockdevRefOrNull * StrOrNull Alternate types are similar to Union bu

[RFC PATCH v1 5/8] qapi: golang: Generate qapi's event types in Go

2022-04-01 Thread Victor Toso
This patch handles QAPI event types and generates data structures in Go that handles it. At the moment of this writing, it generates 51 structures (49 events) In Golang, each event is handled as a Go structure and there is no big difference, in the Go generated code, between what is a QAPI event

[RFC PATCH v1 0/8] qapi: add generator for Golang interface

2022-04-01 Thread Victor Toso
Hi, Happy 1st April. Not a joke :) /* ugh, took me too long to send */ This series is about adding a generator in scripts/qapi to produce Go data structures that can be used to communicate with QEMU over QMP. * Why Go? There are quite a few Go projects that interact with QEMU over QMP and they

[RFC PATCH v1 1/8] qapi: golang: Generate qapi's enum types in Go

2022-04-01 Thread Victor Toso
This patch handles QAPI enum types and generates its equivalent in Go. The highlights of this implementation are: 1. For each QAPI enum, we will define an int32 type in Go to be the assigned type of this specific enum 2. While in the Go codebase we can use the generated enum values, the sp

Re: [PATCH 1/7] virtio-net: align ctrl_vq index for non-mq guest for vhost_vdpa

2022-04-01 Thread Si-Wei Liu
On 3/31/2022 1:39 AM, Jason Wang wrote: On Wed, Mar 30, 2022 at 11:48 PM Si-Wei Liu wrote: On 3/30/2022 2:00 AM, Jason Wang wrote: On Wed, Mar 30, 2022 at 2:33 PM Si-Wei Liu wrote: With MQ enabled vdpa device and non-MQ supporting guest e.g. booting vdpa with mq=on over OVMF of single v

Re: [PATCH] linux-user/ppc: Narrow type of ccr in save_user_regs

2022-04-01 Thread Cédric Le Goater
On 4/1/22 21:16, Richard Henderson wrote: Coverity warns that we shift a 32-bit value by N, and then accumulate it into a 64-bit type (target_ulong on ppc64). The ccr is always 8 * 4-bit fields, and thus is always a 32-bit quantity; narrow the type to avoid the warning. Fixes: Coverity CID 1487

Re: [PATCH v3 0/3] block/dirty-bitmaps: fix and improve bitmap merge

2022-04-01 Thread Vladimir Sementsov-Ogievskiy
01.04.2022 23:17, Eric Blake wrote: On Fri, Apr 01, 2022 at 01:08:01PM +0300, Vladimir Sementsov-Ogievskiy wrote: v3: rebase on master, one patch is already merged. Vladimir Sementsov-Ogievskiy (3): block: block_dirty_bitmap_merge(): fix error path block: improve block_dirty_bitmap_merge(

[PATCH 1/1] xlnx-bbram: hw/nvram: Fix uninitialized Error *

2022-04-01 Thread Tong Ho
This adds required initialization of Error * variable. Signed-off-by: Tong Ho --- hw/nvram/xlnx-bbram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/nvram/xlnx-bbram.c b/hw/nvram/xlnx-bbram.c index b70828e5bf..6ed32adad9 100644 --- a/hw/nvram/xlnx-bbram.c +++ b/hw/nvram

Re: [PATCH 4/7] virtio: don't read pending event on host notifier if disabled

2022-04-01 Thread Si-Wei Liu
On 3/31/2022 1:36 AM, Jason Wang wrote: On Thu, Mar 31, 2022 at 12:41 AM Si-Wei Liu wrote: On 3/30/2022 2:14 AM, Jason Wang wrote: On Wed, Mar 30, 2022 at 2:33 PM Si-Wei Liu wrote: Previous commit prevents vhost-user and vhost-vdpa from using userland vq handler via disable_ioeventfd_ha

Re: [PATCH v3 0/3] block/dirty-bitmaps: fix and improve bitmap merge

2022-04-01 Thread Eric Blake
On Fri, Apr 01, 2022 at 01:08:01PM +0300, Vladimir Sementsov-Ogievskiy wrote: > v3: rebase on master, one patch is already merged. > > Vladimir Sementsov-Ogievskiy (3): > block: block_dirty_bitmap_merge(): fix error path > block: improve block_dirty_bitmap_merge(): don't allocate extra bitmap

Re: [PATCH 1/3] softfloat: Fix declaration of partsN_compare

2022-04-01 Thread Richard Henderson
On 4/1/22 12:12, Peter Maydell wrote: The types are compatible, but it's weird that the compiler doesn't warn that the prototype and definition are different types: it seems like the kind of "technically valid but usually a bug" that a warning would be nice for. Good point. Submitted https://g

Re: [PATCH v5 00/13] KVM: mm: fd-based approach for supporting KVM guest private memory

2022-04-01 Thread Andy Lutomirski
On Fri, Apr 1, 2022, at 7:59 AM, Quentin Perret wrote: > On Thursday 31 Mar 2022 at 09:04:56 (-0700), Andy Lutomirski wrote: > To answer your original question about memory 'conversion', the key > thing is that the pKVM hypervisor controls the stage-2 page-tables for > everyone in the system, all

Re: [PATCH] ppc/pnv: Fix number of registers in the PCIe controller on POWER9

2022-04-01 Thread Daniel Henrique Barboza
On 4/1/22 06:19, Frederic Barrat wrote: The spec defines 3 registers, even though only index 0 and 2 are valid on POWER9. The same model is used on POWER10. Register 1 is defined there but we currently don't use it in skiboot. So we can keep reporting an error on write. Reported by Coverity (

[PATCH 0/1] xlnx-bbram: hw/nvram: Fix Coverity CID 1487233

2022-04-01 Thread Tong Ho
This patch addresses Coverity CID 1487233 by adding the required initialiation of a local variable of type Error *. Tong Ho (1): xlnx-bbram: hw/nvram: Fix uninitialized Error * hw/nvram/xlnx-bbram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1

[PATCH] target/s390x: Fix the accumulation of ccm in op_icm

2022-04-01 Thread Richard Henderson
Coverity rightly reports that 0xff << pos can overflow. This would affect the ICMH instruction. Fixes: Coverity CID 1487161 Signed-off-by: Richard Henderson --- target/s390x/tcg/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x/tcg/translate.c b/target/

[PATCH] linux-user/ppc: Narrow type of ccr in save_user_regs

2022-04-01 Thread Richard Henderson
Coverity warns that we shift a 32-bit value by N, and then accumulate it into a 64-bit type (target_ulong on ppc64). The ccr is always 8 * 4-bit fields, and thus is always a 32-bit quantity; narrow the type to avoid the warning. Fixes: Coverity CID 1487223 Signed-off-by: Richard Henderson --- l

[PATCH] plugins: Assert mmu_idx in range before use in qemu_plugin_get_hwaddr

2022-04-01 Thread Richard Henderson
Coverity reports out-of-bound accesses here. This should be a false positive due to how the index is decoded from MemOpIdx. Fixes: Coverity CID 1487201 Signed-off-by: Richard Henderson --- plugins/api.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/plugins/api.c b/plugins/api.c index 7b

[PATCH] target/i386: Suppress coverity warning on fsave/frstor

2022-04-01 Thread Richard Henderson
Coverity warns that 14 << data32 may overflow with respect to the target_ulong to which it is subsequently added. We know this wasn't true because data32 is in [1,2], but the suggested fix is perfectly fine. Fixes: Coverity CID 1487135, 1487256 Signed-off-by: Richard Henderson --- target/i386/tc

Re: [PATCH v5 00/13] KVM: mm: fd-based approach for supporting KVM guest private memory

2022-04-01 Thread Sean Christopherson
On Fri, Apr 01, 2022, Quentin Perret wrote: > On Friday 01 Apr 2022 at 17:14:21 (+), Sean Christopherson wrote: > > On Fri, Apr 01, 2022, Quentin Perret wrote: > > I assume there is a scenario where a page can be converted from > > shared=>private? > > If so, is there a use case where that hap

Re: [PATCH 1/3] softfloat: Fix declaration of partsN_compare

2022-04-01 Thread Peter Maydell
On Fri, 1 Apr 2022 at 19:08, Richard Henderson wrote: > > On 4/1/22 07:22, Richard Henderson wrote: > > The declaration used 'int', while the definition used 'FloatRelation'. > > This should have resulted in a compiler error, but mysteriously didn't. > > Bah, of course there's no error -- this is

Re: [PATCH 1/3] softfloat: Fix declaration of partsN_compare

2022-04-01 Thread Richard Henderson
On 4/1/22 07:22, Richard Henderson wrote: The declaration used 'int', while the definition used 'FloatRelation'. This should have resulted in a compiler error, but mysteriously didn't. Bah, of course there's no error -- this is C not C++. The enumeration has values -1 ... 2, which means that t

Re: [PATCH v5 00/13] KVM: mm: fd-based approach for supporting KVM guest private memory

2022-04-01 Thread Quentin Perret
On Friday 01 Apr 2022 at 17:14:21 (+), Sean Christopherson wrote: > On Fri, Apr 01, 2022, Quentin Perret wrote: > > The typical flow is as follows: > > > > - the host asks the hypervisor to run a guest; > > > > - the hypervisor does the context switch, which includes switching > >stage-

Re: [PATCH] accel/tcg: Remove ATOMIC_MMU_IDX

2022-04-01 Thread Peter Maydell
On Fri, 1 Apr 2022 at 18:11, Richard Henderson wrote: > > The last use of this macro was removed in f3e182b10013 > ("accel/tcg: Push trace info building into atomic_common.c.inc") > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [qemu.qmp PATCH 09/13] [FIXME] move PACKAGE.rst to README.rst and update

2022-04-01 Thread John Snow
On Fri, Apr 1, 2022, 12:40 PM Kashyap Chamarthy wrote: > On Wed, Mar 30, 2022 at 02:24:20PM -0400, John Snow wrote: > > The README here will reflect both what is shown on GitLab and on the > > PyPI landing page. Update it accordingly, and freshen it up. > > > > FIXME: Update URLs when pushing to

Re: [PATCH v5 00/13] KVM: mm: fd-based approach for supporting KVM guest private memory

2022-04-01 Thread Sean Christopherson
On Fri, Apr 01, 2022, Quentin Perret wrote: > The typical flow is as follows: > > - the host asks the hypervisor to run a guest; > > - the hypervisor does the context switch, which includes switching >stage-2 page-tables; > > - initially the guest has an empty stage-2 (we don't require >

[PATCH] accel/tcg: Remove ATOMIC_MMU_IDX

2022-04-01 Thread Richard Henderson
The last use of this macro was removed in f3e182b10013 ("accel/tcg: Push trace info building into atomic_common.c.inc") Signed-off-by: Richard Henderson --- accel/tcg/cputlb.c| 1 - accel/tcg/user-exec.c | 1 - 2 files changed, 2 deletions(-) diff --git a/accel/tcg/cputlb.c b/accel/tcg/cput

[PATCH] accel/tcg: Assert mmu_idx in range before use in cputlb

2022-04-01 Thread Richard Henderson
Coverity reports out-of-bound accesses within cputlb.c. This should be a false positive due to how the index is decoded from MemOpIdx. To be fair, nothing is checking the correct bounds during encoding either. Assert index in range before use, both to catch user errors and to pacify static analys

Re: who's maintaining amd_iommu.c these days?

2022-04-01 Thread Wei Huang
On 4/1/22 11:14, Peter Maydell wrote: On Fri, 1 Apr 2022 at 17:11, Wei Huang wrote: On 3/31/22 21:09, Jason Wang wrote: On Fri, Apr 1, 2022 at 2:30 AM Peter Xu wrote: On Thu, Mar 31, 2022 at 05:01:52PM +0100, Peter Maydell wrote: (4) The claimed bit layout of the event structure does

Re: [qemu.qmp PATCH 02/13] fork qemu.qmp from qemu.git

2022-04-01 Thread Kashyap Chamarthy
On Wed, Mar 30, 2022 at 02:24:13PM -0400, John Snow wrote: > Split python/ from qemu.git, using these commands: > > > git subtree split -P python/ -b python-split-v3 > > mkdir ~/src/tmp > > cd ~/src/tmp > > git clone --no-local --branch python-split-v3 --single-branch ~/src/qemu > > cd qemu > > gi

Re: [qemu.qmp PATCH 07/13] add a couple new trove classifiers

2022-04-01 Thread Beraldo Leal
On Wed, Mar 30, 2022 at 02:24:18PM -0400, John Snow wrote: > Signed-off-by: John Snow > --- > setup.cfg | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/setup.cfg b/setup.cfg > index 776f4f1..44f913d 100644 > --- a/setup.cfg > +++ b/setup.cfg > @@ -14,6 +14,7 @@ long_description = file

Re: [qemu.qmp PATCH 05/13] update project description

2022-04-01 Thread Beraldo Leal
On Wed, Mar 30, 2022 at 02:24:16PM -0400, John Snow wrote: > Signed-off-by: John Snow > --- > setup.cfg | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/setup.cfg b/setup.cfg > index f06f944..c21f2ce 100644 > --- a/setup.cfg > +++ b/setup.cfg > @@ -7,7 +7,7 @@ maintainer

Re: who's maintaining amd_iommu.c these days?

2022-04-01 Thread Wei Huang
On 3/31/22 21:09, Jason Wang wrote: On Fri, Apr 1, 2022 at 2:30 AM Peter Xu wrote: On Thu, Mar 31, 2022 at 05:01:52PM +0100, Peter Maydell wrote: Coverity points out some problems with hw/i386/amd_iommu.c's event logging code -- specifically, CID 1487115 1487116 1487190 1487200 1487232 148

Re: [qemu.qmp PATCH 09/13] [FIXME] move PACKAGE.rst to README.rst and update

2022-04-01 Thread Kashyap Chamarthy
On Wed, Mar 30, 2022 at 02:24:20PM -0400, John Snow wrote: > The README here will reflect both what is shown on GitLab and on the > PyPI landing page. Update it accordingly, and freshen it up. > > FIXME: Update URLs when pushing to the production repo. > > Suggested-by: Kashyap Chamarthy > Signe

Re: [PULL 0/2] riscv-to-apply queue

2022-04-01 Thread Peter Maydell
:08 +0100) > > are available in the Git repository at: > > g...@github.com:alistair23/qemu.git tags/pull-riscv-to-apply-20220401 > > for you to fetch changes up to 8ff8ac63298611c8373b294ec936475b1a33f63f: > > target/riscv: rvv: Add missing early exit condition for

Re: who's maintaining amd_iommu.c these days?

2022-04-01 Thread Peter Maydell
On Fri, 1 Apr 2022 at 17:11, Wei Huang wrote: > > > > On 3/31/22 21:09, Jason Wang wrote: > > On Fri, Apr 1, 2022 at 2:30 AM Peter Xu wrote: > >> > >> On Thu, Mar 31, 2022 at 05:01:52PM +0100, Peter Maydell wrote: > >>> (4) The claimed bit layout of the event structure doesn't > >>> match up with

Re: [PATCH v2 5/7] block/block-copy: block_copy(): add timeout_ns parameter

2022-04-01 Thread Vladimir Sementsov-Ogievskiy
01.04.2022 16:16, Hanna Reitz wrote: On 01.04.22 11:19, Vladimir Sementsov-Ogievskiy wrote: Add possibility to limit block_copy() call in time. To be used in the next commit. Signed-off-by: Vladimir Sementsov-Ogievskiy ---   block/block-copy.c | 26 +++---   block/co

Re: [RFC PATCH 1/2] spapr: Report correct GTSE support via ov5

2022-04-01 Thread Fabiano Rosas
"Aneesh Kumar K.V" writes: > David Gibson writes: > >> On Mon, Mar 14, 2022 at 07:10:10PM -0300, Fabiano Rosas wrote: >>> David Gibson writes: >>> >>> > On Tue, Mar 08, 2022 at 10:23:59PM -0300, Fabiano Rosas wrote: >>> > > ... > >>> To satisfy TCG we could keep a spapr capability as ON and us

Re: use of uninitialized variable involving visit_type_uint32() and friends

2022-04-01 Thread Paolo Bonzini
On 4/1/22 15:11, Markus Armbruster wrote: If it can do really serious interprocedural analysis, it _might_ be able to see through the visitor constructor and know that the "value = *obj" is not initialized (e.g. "all callers of object_property_set use an input visitor"). I doubt that honestly, b

Re: [PATCH v4 10/11] tests/tcg/s390x: Tests for Vector Enhancements Facility 2

2022-04-01 Thread Christian Borntraeger
Am 01.04.22 um 17:02 schrieb David Miller: vrr is almost a perfect match (it is for this, larger than imm4 would need to be split). .long : this would be uglier. use enough to be filled with nops after ? or use a 32b and 16b instead if it's in .text it should make no difference. I will let Ric

[PULL 4/6] meson.build: Fix dependency of page-vary-common.c to config-poison.h

2022-04-01 Thread Thomas Huth
binieFV4N6em2.bin Description: Binary data

Re: [PATCH 2/3] i386: factor out x86_firmware_configure()

2022-04-01 Thread Xiaoyao Li
On 4/1/2022 6:36 PM, Philippe Mathieu-Daudé wrote: On 1/4/22 07:28, Xiaoyao Li wrote: On 4/1/2022 1:08 PM, Gerd Hoffmann wrote:    if (sev_enabled()) { ^^^ Can we remove the SEV check ... +    pc_system_parse_ovmf_flash(ptr, size); + +    if (sev_enabled

[PULL 5/6] 9p: move P9_XATTR_SIZE_MAX from 9p.h to 9p.c

2022-04-01 Thread Thomas Huth
binQXAZYq898R.bin Description: Binary data

[PULL 3/6] target/s390x: Fix determination of overflow condition code after subtraction

2022-04-01 Thread Thomas Huth
bina_MI2Na3ly.bin Description: Binary data

[PULL 2/6] target/s390x: Fix determination of overflow condition code after addition

2022-04-01 Thread Thomas Huth
binUXStoSsacT.bin Description: Binary data

[PULL 6/6] trace: fix compilation with lttng-ust >= 2.13

2022-04-01 Thread Thomas Huth
From: Marc-André Lureau On Fedora 36, with lttng-ust 2.13.1, compilation fails with: In file included from trace/trace-ust-all.h:49085, from trace/trace-ust-all.c:13: /usr/include/lttng/tracepoint-event.h:67:10: error: #include expects "FILENAME" or 67 | #include LTTNG_UST_

[PULL 1/6] misc: Fixes MAINTAINERS's path .github/workflows/lockdown.yml

2022-04-01 Thread Thomas Huth
From: Yonggang Luo Signed-off-by: Yonggang Luo Message-Id: <20220323080755.156-4-luoyongg...@gmail.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index cc364afef7

[PULL 0/6] Misc fixes for 7.0

2022-04-01 Thread Thomas Huth
The following changes since commit 9b617b1bb4056e60b39be4c33be20c10928a6a5c: Merge tag 'trivial-branch-for-7.0-pull-request' of https://gitlab.com/laurent_vivier/qemu into staging (2022-04-01 10:23:27 +0100) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull

Re: [PATCH v3 0/3] block/dirty-bitmaps: fix and improve bitmap merge

2022-04-01 Thread Hanna Reitz
On 01.04.22 12:08, Vladimir Sementsov-Ogievskiy wrote: v3: rebase on master, one patch is already merged. Vladimir Sementsov-Ogievskiy (3): block: block_dirty_bitmap_merge(): fix error path block: improve block_dirty_bitmap_merge(): don't allocate extra bitmap block: simplify handling o

Re: [PATCH v4 10/11] tests/tcg/s390x: Tests for Vector Enhancements Facility 2

2022-04-01 Thread David Miller
vrr is almost a perfect match (it is for this, larger than imm4 would need to be split). .long : this would be uglier. use enough to be filled with nops after ? or use a 32b and 16b instead if it's in .text it should make no difference. On Fri, Apr 1, 2022 at 2:42 AM Christian Borntraeger wrote

[PULL 6/6] target/arm: Don't use DISAS_NORETURN in STXP !HAVE_CMPXCHG128 codegen

2022-04-01 Thread Peter Maydell
In gen_store_exclusive(), if the host does not have a cmpxchg128 primitive then we generate bad code for STXP for storing two 64-bit values. We generate a call to the exit_atomic helper, which never returns, and set is_jmp to DISAS_NORETURN. However, this is forgetting that we have already emitte

[PULL 2/6] target/arm: Check VSTCR.SW when assigning the stage 2 output PA space

2022-04-01 Thread Peter Maydell
From: Idan Horowitz As per the AArch64.SS2OutputPASpace() psuedo-code in the ARMv8 ARM when the PA space of the IPA is non secure, the output PA space is secure if and only if all of the bits VTCR., VSTCR. are not set. Signed-off-by: Idan Horowitz Reviewed-by: Richard Henderson Message-id: 202

[PULL 1/6] target/arm: Fix MTE access checks for disabled SEL2

2022-04-01 Thread Peter Maydell
From: Idan Horowitz While not mentioned anywhere in the actual specification text, the HCR_EL2.ATA bit is treated as '1' when EL2 is disabled at the current security state. This can be observed in the psuedo-code implementation of AArch64.AllocationTagAccessIsEnabled(). Signed-off-by: Idan Horow

[PULL 3/6] target/arm: Take VSTCR.SW, VTCR.NSW into account in final stage 2 walk

2022-04-01 Thread Peter Maydell
From: Idan Horowitz As per the AArch64.SS2InitialTTWState() psuedo-code in the ARMv8 ARM the initial PA space used for stage 2 table walks is assigned based on the SW and NSW bits of the VSTCR and VTCR registers. This was already implemented for the recursive stage 2 page table walks in S1_ptw_tr

[PULL 5/6] MAINTAINERS: change Fred Konrad's email address

2022-04-01 Thread Peter Maydell
From: Frederic Konrad frederic.kon...@adacore.com and kon...@adacore.com will stop working starting 2022-04-01. Use my personal email instead. Signed-off-by: Frederic Konrad Reviewed-by: Fabien Chouteau > Reviewed-by: Philippe Mathieu-Daudé Message-id: 1648643217-15811-1-git-send-email-freder

[PULL 0/6] target-arm queue

2022-04-01 Thread Peter Maydell
ository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20220401 for you to fetch changes up to a5b1e1ab662aa6dc42d5a913080fccbb8bf82e9b: target/arm: Don't use DISAS_NORETURN in STXP !HAVE_CMPXCHG128 codegen (2022-04-01

[PULL 4/6] target/arm: Determine final stage 2 output PA space based on original IPA

2022-04-01 Thread Peter Maydell
From: Idan Horowitz As per the AArch64.S2Walk() pseudo-code in the ARMv8 ARM, the final decision as to the output address's PA space based on the SA/SW/NSA/NSW bits needs to take the input IPA's PA space into account, and not the PA space of the result of the stage 2 walk itself. Signed-off-by:

Re: [PATCH v5 00/13] KVM: mm: fd-based approach for supporting KVM guest private memory

2022-04-01 Thread Quentin Perret
On Thursday 31 Mar 2022 at 09:04:56 (-0700), Andy Lutomirski wrote: > On Wed, Mar 30, 2022, at 10:58 AM, Sean Christopherson wrote: > > On Wed, Mar 30, 2022, Quentin Perret wrote: > >> On Wednesday 30 Mar 2022 at 09:58:27 (+0100), Steven Price wrote: > >> > On 29/03/2022 18:01, Quentin Perret wrote

[PATCH v5 3/3] avocado/vnc: add test_change_listen

2022-04-01 Thread Vladimir Sementsov-Ogievskiy
Add simple test-case for new display-update qmp command. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Daniel P. Berrangé --- tests/avocado/vnc.py | 63 1 file changed, 63 insertions(+) diff --git a/tests/avocado/vnc.py b/tests/avocado/vn

[PATCH v5 0/3] qapi/ui: change vnc addresses

2022-04-01 Thread Vladimir Sementsov-Ogievskiy
v5: tiny tweaks, add r-bs Recently our customer requested a possibility to change VNC listen port dynamically. Happily in Rhel7-based Qemu we already have this possibility: through deprecated "change" qmp command. But since 6.0 "change" qmp command was removed, with recommendation to use change-

[PATCH v5 2/3] qapi/ui: add 'display-update' command for changing listen address

2022-04-01 Thread Vladimir Sementsov-Ogievskiy
Add possibility to change addresses where VNC server listens for new connections. Prior to 6.0 this functionality was available through 'change' qmp command which was deleted. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Daniel P. Berrangé --- docs/about/removed-features.rst | 3 +-

[PATCH v5 1/3] ui/vnc: refactor arrays of addresses to SocketAddressList

2022-04-01 Thread Vladimir Sementsov-Ogievskiy
Let's use SocketAddressList instead of dynamic arrays. Benefits: - Automatic cleanup: don't need specific freeing function and drop some gotos. - Less indirection: no triple asterix anymore! - Prepare for the following commit, which will reuse new interface of vnc_display_listen(). Signed

Re: [PULL 06/22] hw/nvram: Introduce Xilinx battery-backed ram

2022-04-01 Thread Peter Maydell
On Thu, 30 Sept 2021 at 16:12, Peter Maydell wrote: > > From: Tong Ho > > This device is present in Versal and ZynqMP product > families to store a 256-bit encryption key. Hi; Coverity points out a bug in this change (CID 1487233): > +static void bbram_bdrv_error(XlnxBBRam *s, int rc, gchar *de

[PATCH 1/2] bsd-user: Add missing semicolon

2022-04-01 Thread Maya Rashish
Signed-off-by: Maya Rashish --- bsd-user/netbsd/target_os_siginfo.h | 2 +- bsd-user/openbsd/target_os_siginfo.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bsd-user/netbsd/target_os_siginfo.h b/bsd-user/netbsd/target_os_siginfo.h index 667c19cc7c..36c2323cbe 100644 -

[PATCH 17/17] tests/tcg: fix non-static build

2022-04-01 Thread Paolo Bonzini
If linking with -static fails at configure time, -static should not be used at build time either. Do not include BUILD_STATIC in $config_target_mak. Signed-off-by: Paolo Bonzini Message-Id: <20220328140240.40798-16-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- tests/tcg/configure.sh |

Re: [PATCH v2 4/7] util: add qemu-co-timeout

2022-04-01 Thread Vladimir Sementsov-Ogievskiy
01.04.2022 16:13, Hanna Reitz wrote: On 01.04.22 11:19, Vladimir Sementsov-Ogievskiy wrote: Add new API, to make a time limited call of the coroutine. Signed-off-by: Vladimir Sementsov-Ogievskiy ---   include/qemu/coroutine.h | 13 ++   util/meson.build |  1 +   util/qemu-co-timeout

[PATCH 16/17] tests/docker: remove SKIP_DOCKER_BUILD

2022-04-01 Thread Paolo Bonzini
It is now unused. Signed-off-by: Paolo Bonzini Message-Id: <20220328140240.40798-15-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- tests/docker/Makefile.include | 12 +--- tests/docker/docker.py| 57 --- 2 files changed, 1 insertion(+), 68 dele

[PATCH 10/17] tests/tcg: remove CONFIG_LINUX_USER from config-target.mak

2022-04-01 Thread Paolo Bonzini
Just check the target name instead. Signed-off-by: Paolo Bonzini Message-Id: <20220328140240.40798-10-pbonz...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- tests/tcg/configure.sh | 2 -- tests/tcg/multiarch/Makefile.target | 2 +- tests/tcg/x86_

[PATCH 13/17] tests/tcg: list test targets in Makefile.prereqs

2022-04-01 Thread Paolo Bonzini
Omit the rules altogether for targets that do not have a compiler. Makefile.qemu now is only invoked if the tests are actually built/run. Signed-off-by: Paolo Bonzini Message-Id: <20220328140240.40798-13-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 14 +++-

[PATCH 14/17] tests/tcg: invoke Makefile.target directly from QEMU's makefile

2022-04-01 Thread Paolo Bonzini
Build the "docker.py cc" invocation directly in tests/tcg/configure.sh, and remove the Makefile.qemu wrapper around Makefile.target. The config-*.mak files now include the actual variables used when building the tests, rather than the CROSS_* variables that Makefile.qemu used to "translate". This

[PATCH 2/2] bsd-user: correct notion of return value

2022-04-01 Thread Maya Rashish
Fix EFAULT at startup. Signed-off-by: Maya Rashish --- bsd-user/netbsd/target_os_stack.h | 2 +- bsd-user/openbsd/target_os_stack.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bsd-user/netbsd/target_os_stack.h b/bsd-user/netbsd/target_os_stack.h index 503279c1a9..f3c

[PATCH 07/17] tests/docker: simplify docker-TEST@IMAGE targets

2022-04-01 Thread Paolo Bonzini
No need to go through the shell when we already have the test and images at the point where the targets are declared. Signed-off-by: Paolo Bonzini Message-Id: <20220328140240.40798-8-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- tests/docker/Makefile.include | 12 ++-- 1 file ch

[PATCH 11/17] tests/tcg: remove CONFIG_USER_ONLY from config-target.mak

2022-04-01 Thread Paolo Bonzini
Just check the target name instead. Signed-off-by: Paolo Bonzini Message-Id: <20220328140240.40798-11-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- tests/tcg/Makefile.target | 8 tests/tcg/configure.sh| 12 +++- 2 files changed, 7 insertions(+), 13 deletions(-) di

[PATCH 15/17] tests/tcg: isolate from QEMU's config-host.mak

2022-04-01 Thread Paolo Bonzini
Do not include variables for the QEMU's own compiler, as they are not necessarily related to the cross compiler used for tests/tcg. Signed-off-by: Paolo Bonzini --- configure | 3 +-- tests/tcg/Makefile.target | 3 +-- tests/tcg/configure.sh| 5 + 3 files changed, 7 inser

[PATCH 12/17] tests/tcg: prepare Makefile.prereqs at configure time

2022-04-01 Thread Paolo Bonzini
List the dependencies of the build-tcg-tests-* and run-tcg-tests-* targets in a Makefile fragment, without going through Makefile.prereqs's "parsing" of config-*.mak. Signed-off-by: Paolo Bonzini Message-Id: <20220328140240.40798-12-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- tests/Ma

[PATCH 04/17] tests/docker: remove unnecessary default definitions

2022-04-01 Thread Paolo Bonzini
The definition of DOCKER_IMAGES and DOCKER_TESTS copes already with an empty value of $(IMAGES) and $(TESTS), no need to force them to "%" if undefined. Signed-off-by: Paolo Bonzini Message-Id: <20220328140240.40798-5-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- tests/docker/Makefile.i

  1   2   3   >