Re: [PATCH v6 08/11] s390x: topology: Adding drawers to CPU topology

2022-03-15 Thread wangyanan (Y)
Hi Pierre, On 2022/2/17 21:41, Pierre Morel wrote: S390 CPU topology may have up to 5 topology containers. The first container above the cores is level 2, the sockets, and the level 3, containing sockets are the books. We introduce here the drawers, drawers is the level containing books. Let's

Re: [PATCH v2 2/2] target/riscv: Allow software access to MIP SEIP

2022-03-15 Thread Richard Henderson
On 3/15/22 18:59, Alistair Francis wrote: +if (mask & MIP_SEIP) { +env->software_seip = new_val & MIP_SEIP; +} +new_val |= env->external_seip << IRQ_S_EXT; You can move the second statement inside the if as well, since you don't need bits in new_val set that are not in mask

[PATCH v5] ui/cocoa: Use NSWindow's ability to resize

2022-03-15 Thread Akihiko Odaki
This change brings two new features: - The window will be resizable if "Zoom To Fit" is eanbled - The window can be made full screen by clicking full screen button provided by the platform. (The left-top green button.) Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 539 -

Re: [PATCH v2 1/2] target/riscv: cpu: Fixup indentation

2022-03-15 Thread Richard Henderson
On 3/15/22 18:59, Alistair Francis wrote: From: Alistair Francis Signed-off-by: Alistair Francis Reviewed-by: Bin Meng --- target/riscv/cpu.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) Reviewed-by: Richard Henderson r~

[PATCH] audio/mixeng: Do not declare unused variables

2022-03-15 Thread Akihiko Odaki
The unused variables when FLOAT_MIXENG is defined caused warnings on Apple clang version 13.1.6 (clang-1316.0.21.2). Signed-off-by: Akihiko Odaki --- audio/mixeng.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/audio/mixeng.c b/audio/mixeng.c index f27deb165b6..100a

[PATCH v3 17/17] target/m68k: Mark helper_raise_exception as noreturn

2022-03-15 Thread Richard Henderson
Also mark raise_exception_ra and raise_exception, lest we generate a warning about helper_raise_exception returning. Signed-off-by: Richard Henderson --- target/m68k/helper.h| 2 +- target/m68k/op_helper.c | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/target/m68k/

[PATCH v3 16/17] linux-user/strace: Adjust get_thread_area for m68k

2022-03-15 Thread Richard Henderson
Unlike i386, m68k get_thread_area has no arguments. Signed-off-by: Richard Henderson --- linux-user/strace.list | 5 + 1 file changed, 5 insertions(+) diff --git a/linux-user/strace.list b/linux-user/strace.list index 278596acd1..72e17b1acf 100644 --- a/linux-user/strace.list +++ b/linux-us

[PATCH v3 11/17] target/m68k: Implement TPF in terms of TRAPcc

2022-03-15 Thread Richard Henderson
TPF stands for "trap false", and is a long-form nop for ColdFire. Re-use the immediate consumption code from trapcc; the insn will already expand to a nop because of the TCG_COND_NEVER test within do_trapcc. Signed-off-by: Richard Henderson --- target/m68k/translate.c | 18 +- 1

[PATCH v3 15/17] linux-user/strace: Fix print_syscall_err

2022-03-15 Thread Richard Henderson
Errors are not all negative numbers, but only the top 4k. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/strace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index 2cdbf030ba..f235118fb6 1

[PATCH v3 12/17] target/m68k: Implement TRAPV

2022-03-15 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/m68k/translate.c | 9 + 1 file changed, 9 insertions(+) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 86e5e16f71..6118f9fcfb 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -4911,6 +4911,14 @@ DISAS_

[PATCH v3 10/17] target/m68k: Implement TRAPcc

2022-03-15 Thread Richard Henderson
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/754 Signed-off-by: Richard Henderson --- target/m68k/cpu.h | 2 ++ linux-user/m68k/cpu_loop.c | 1 + target/m68k/cpu.c | 1 + target/m68k/op_helper.c| 6 + target/m68k/translate.c| 49 +++

[PATCH v3 08/17] target/m68k: Fix address argument for EXCP_TRACE

2022-03-15 Thread Richard Henderson
According to the M68040 Users Manual, section 8.4.3, Six word stack frame (format 2), Trace (and others) is supposed to record the next insn in PC and the address of the trapping instruction in ADDRESS. Create gen_raise_exception_format2 to record the trapping pc in env->mmu.ar. Update m68k_inter

[PATCH v3 14/17] tests/tcg/m68k: Add trap.c

2022-03-15 Thread Richard Henderson
Test various trap instructions: chk, div, trap, trapv, trapcc, ftrapcc, and the signals and addresses that we expect from them. Signed-off-by: Richard Henderson --- tests/tcg/m68k/trap.c | 129 + tests/tcg/m68k/Makefile.target | 3 + 2 files changed, 13

[PATCH v3 06/17] target/m68k: Fix address argument for EXCP_CHK

2022-03-15 Thread Richard Henderson
According to the M68040 Users Manual, section 8.4.3, Six word stack frame (format 2), CHK, CHK2 (and others) are supposed to record the next insn in PC and the address of the trapping instruction in ADDRESS. Create a raise_exception_format2 function to centralize recording of the trapping pc in mm

[PATCH v3 07/17] target/m68k: Fix pc, c flag, and address argument for EXCP_DIV0

2022-03-15 Thread Richard Henderson
According to the M68040 Users Manual, section 8.4.3, Six word stack frame (format 2), Zero Div (and others) is supposed to record the next insn in PC and the address of the trapping instruction in ADDRESS. While the N, Z and V flags are documented to be undefine on DIV0, the C flag is documented a

[PATCH v3 13/17] target/m68k: Implement FTRAPcc

2022-03-15 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/m68k/translate.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 6118f9fcfb..14f8c702c1 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -55

[PATCH v3 05/17] target/m68k: Remove retaddr in m68k_interrupt_all

2022-03-15 Thread Richard Henderson
The only value this variable holds is now env->pc. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/m68k/op_helper.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/target/m68k/op_helper.c b/target/m

[PATCH v3 04/17] linux-user/m68k: Handle EXCP_TRAP1 through EXCP_TRAP15

2022-03-15 Thread Richard Henderson
These are raised by guest instructions, and should not fall through into the default abort case. Signed-off-by: Richard Henderson --- linux-user/m68k/cpu_loop.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/linux-user/m68k/cpu_loop.c b/linux-user/m68k/cpu_loop.c index a152567624..ac2555f

[PATCH v3 01/17] target/m68k: Raise the TRAPn exception with the correct pc

2022-03-15 Thread Richard Henderson
Rather than adjust the PC in all of the consumers, raise the exception with the correct PC in the first place. Reviewed-by: Laurent Vivier Signed-off-by: Richard Henderson --- linux-user/m68k/cpu_loop.c | 1 - target/m68k/op_helper.c| 9 - target/m68k/translate.c| 2 +- 3 files

[PATCH v3 09/17] target/m68k: Fix stack frame for EXCP_ILLEGAL

2022-03-15 Thread Richard Henderson
According to the M68040 Users Manual, section 8.4.3, Four word stack frame (format 0), includes Illegal Instruction. Use the correct frame format, which does not use the ADDR argument. Signed-off-by: Richard Henderson --- target/m68k/op_helper.c | 5 - 1 file changed, 4 insertions(+), 1 del

[PATCH v3 02/17] target/m68k: Switch over exception type in m68k_interrupt_all

2022-03-15 Thread Richard Henderson
Replace an if ladder with a switch for clarity. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/m68k/op_helper.c | 49 + 1 file changed, 30 insertions(+), 19 deletions(-) diff --git a/target/m6

[PATCH v3 03/17] target/m68k: Fix coding style in m68k_interrupt_all

2022-03-15 Thread Richard Henderson
Add parenthesis around & vs &&. Remove assignment to sr in function call argument -- note that sr is unused after the call, so the assignment was never needed, only the result of the & expression. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/m68k/op_helper.c

[PATCH v3 00/17] target/m68k: Conditional traps + trap cleanup

2022-03-15 Thread Richard Henderson
I should have gotten back to this right away after 7.0 devel tree opened, but oh well. There's always 7.1. I believe I've fixed up all of the comments from [v2]. r~ v1: https://lore.kernel.org/qemu-devel/20211130103752.72099-1-richard.hender...@linaro.org/ v2: https://lore.kernel.org/qemu-d

[PATCH v2] coreaudio: Commit the result of init in the end

2022-03-15 Thread Akihiko Odaki
init_out_device may only commit some part of the result and leave the state inconsistent when it encounters an error. Commit the result in the end of the function so that it commits the result iif it sees no error. With this change, handle_voice_change can rely on core->outputDeviceID to know whet

Re: [PATCH v20 5/7] net/vmnet: implement bridged mode (vmnet-bridged)

2022-03-15 Thread Akihiko Odaki
On 2022/03/16 8:07, Vladislav Yaroshchuk wrote: Signed-off-by: Vladislav Yaroshchuk --- net/vmnet-bridged.m | 128 ++-- 1 file changed, 123 insertions(+), 5 deletions(-) diff --git a/net/vmnet-bridged.m b/net/vmnet-bridged.m index 91c1a2f2c7..5936c8771

Re: [PATCH] softmmu/physmem: Use qemu_madvise

2022-03-15 Thread Peter Xu
On Tue, Mar 15, 2022 at 11:04:05PM -0500, Andrew Deason wrote: > We have a thin wrapper around madvise, called qemu_madvise, which > provides consistent behavior for the !CONFIG_MADVISE case, and works > around some platform-specific quirks (some platforms only provide > posix_madvise, and some don

Re: [PATCH v20 8/9] migration-test: Export migration-test util funtions

2022-03-15 Thread Peter Xu
On Wed, Mar 16, 2022 at 10:21:38AM +0800, huang...@chinatelecom.cn wrote: > +void cleanup(const char *filename) > +{ > +g_autofree char *path = g_strdup_printf("%s/%s", tmpfs, filename); > + > +unlink(path); > +} If to move most of these tmpfs helpers out anyway, shouldn't we also move all

[PATCH] softmmu/physmem: Use qemu_madvise

2022-03-15 Thread Andrew Deason
We have a thin wrapper around madvise, called qemu_madvise, which provides consistent behavior for the !CONFIG_MADVISE case, and works around some platform-specific quirks (some platforms only provide posix_madvise, and some don't offer all 'advise' types). This specific caller of madvise has never

Re: [PATCH v6 06/11] s390x: topology: Adding books to CPU topology

2022-03-15 Thread wangyanan (Y)
Hi Pierre, On 2022/2/17 21:41, Pierre Morel wrote: S390 CPU topology may have up to 5 topology containers. The first container above the cores is level 2, the sockets. We introduce here the books, book is the level containing sockets. Let's add books, level3, containers to the CPU topology. Si

[PATCH v3 2/3] hw/i386/acpi-build: Avoid 'sun' identifier

2022-03-15 Thread Andrew Deason
On Solaris, 'sun' is #define'd to 1, which causes errors if a variable is named 'sun'. Slightly change the name of the var for the Slot User Number so we can build on Solaris. Reviewed-by: Ani Sinha Signed-off-by: Andrew Deason --- hw/i386/acpi-build.c | 4 ++-- 1 file changed, 2 insertions(+),

[PATCH v3 3/3] util/osdep: Remove some early cruft

2022-03-15 Thread Andrew Deason
The include for statvfs.h has not been needed since all statvfs calls were removed in commit 4a1418e07bdc ("Unbreak large mem support by removing kqemu"). The comment mentioning CONFIG_BSD hasn't made sense since an include for config-host.h was removed in commit aafd75841001 ("util: Clean up incl

[PATCH v3 1/3] util/osdep: Avoid madvise proto on modern Solaris

2022-03-15 Thread Andrew Deason
On older Solaris releases (before Solaris 11), we didn't get a prototype for madvise, and so util/osdep.c provides its own prototype. Some time between the public Solaris 11.4 release and Solaris 11.4.42 CBE, we started getting an madvise prototype that looks like this: extern int madvise(void

[PATCH v3 0/3] Fixes for building on Solaris 11.4.42 CBE

2022-03-15 Thread Andrew Deason
With these minor fixes, I can build qemu on Solaris 11.4.42 CBE (Oracle's new rolling release thing), using '--disable-rdma --enable-modules --disable-dbus-display --target-list=x86_64-softmmu'. I'm just interested in the guest agent right now, so that's all I've tested (briefly), but the rest of t

Re: Time to introduce a migration protocol negotiation (Re: [PATCH v2 00/25] migration: Postcopy Preemption)

2022-03-15 Thread Peter Xu
On Tue, Mar 15, 2022 at 11:15:41AM +, Daniel P. Berrangé wrote: > > I still remember you mentioned the upper layer softwares can have > > assumption on using only 1 pair of socket for migration, I think that makes > > postcopy-preempt by default impossible. > > > > Why multifd is different her

[ANNOUNCE] QEMU 7.0.0-rc0 is now available

2022-03-15 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the first release candidate for the QEMU 7.0 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-7.0.0-rc0.tar.xz http://downlo

Re: [PATCH v2 6/6] libvduse: Add support for reconnecting

2022-03-15 Thread Yongji Xie
On Tue, Mar 15, 2022 at 9:48 PM Stefan Hajnoczi wrote: > > On Tue, Feb 15, 2022 at 06:59:43PM +0800, Xie Yongji wrote: > > +static int vduse_queue_inflight_get(VduseVirtq *vq, int desc_idx) > > +{ > > +vq->log->inflight.desc[desc_idx].counter = vq->counter++; > > +vq->log->inflight.desc[de

[PATCH v20 9/9] tests: Add dirty page rate limit test

2022-03-15 Thread huangy81
From: Hyman Huang(黄勇) Add dirty page rate limit test if kernel support dirty ring, create a standalone file to implement the test case. The following qmp commands are covered by this test case: "calc-dirty-rate", "query-dirty-rate", "set-vcpu-dirty-limit", "cancel-vcpu-dirty-limit" and "query-vc

[PATCH v20 7/9] softmmu/dirtylimit: Implement dirty page rate limit

2022-03-15 Thread huangy81
From: Hyman Huang(黄勇) Implement dirtyrate calculation periodically basing on dirty-ring and throttle virtual CPU until it reachs the quota dirty page rate given by user. Introduce qmp commands "set-vcpu-dirty-limit", "cancel-vcpu-dirty-limit", "query-vcpu-dirty-limit" to enable, disable, query d

[PATCH v20 5/9] accel/kvm/kvm-all: Introduce kvm_dirty_ring_size function

2022-03-15 Thread huangy81
From: Hyman Huang(黄勇) Introduce kvm_dirty_ring_size util function to help calculate dirty ring ful time. Signed-off-by: Hyman Huang(黄勇) Acked-by: Peter Xu --- accel/kvm/kvm-all.c| 5 + accel/stubs/kvm-stub.c | 6 ++ include/sysemu/kvm.h | 2 ++ 3 files changed, 13 insertions(+)

[PATCH v20 4/9] softmmu/dirtylimit: Implement vCPU dirtyrate calculation periodically

2022-03-15 Thread huangy81
From: Hyman Huang(黄勇) Introduce the third method GLOBAL_DIRTY_LIMIT of dirty tracking for calculate dirtyrate periodly for dirty page rate limit. Add dirtylimit.c to implement dirtyrate calculation periodly, which will be used for dirty page rate limit. Add dirtylimit.h to export util functions

[PATCH v20 8/9] migration-test: Export migration-test util funtions

2022-03-15 Thread huangy81
From: Hyman Huang(黄勇) Dirtylimit qtest can reuse the mechanisms that have been implemented by migration-test to start a vm, so export the relevant util functions. Signed-off-by: Hyman Huang(黄勇) --- tests/qtest/migration-helpers.c | 95 + tests/qtest/migrati

[PATCH v20 0/9] support dirty restraint on vCPU

2022-03-15 Thread huangy81
From: Hyman Huang(黄勇) v20 - fix the style problems and let QEMU test pass - change the dirty limit case logic: test fail if dirtyrate measurement 200ms timeout v19 - rebase on master and fix conflicts - add test case for dirty page rate limit Ping. Adding an test case and hope it can be merg

[PATCH v20 6/9] softmmu/dirtylimit: Implement virtual CPU throttle

2022-03-15 Thread huangy81
From: Hyman Huang(黄勇) Setup a negative feedback system when vCPU thread handling KVM_EXIT_DIRTY_RING_FULL exit by introducing throttle_us_per_full field in struct CPUState. Sleep throttle_us_per_full microseconds to throttle vCPU if dirtylimit is in service. Signed-off-by: Hyman Huang(黄勇) Revie

[PATCH v20 3/9] migration/dirtyrate: Refactor dirty page rate calculation

2022-03-15 Thread huangy81
From: Hyman Huang(黄勇) abstract out dirty log change logic into function global_dirty_log_change. abstract out dirty page rate calculation logic via dirty-ring into function vcpu_calculate_dirtyrate. abstract out mathematical dirty page rate calculation into do_calculate_dirtyrate, decouple it f

[PATCH v20 1/9] accel/kvm/kvm-all: Refactor per-vcpu dirty ring reaping

2022-03-15 Thread huangy81
From: Hyman Huang(黄勇) Add a non-required argument 'CPUState' to kvm_dirty_ring_reap so that it can cover single vcpu dirty-ring-reaping scenario. Signed-off-by: Hyman Huang(黄勇) Reviewed-by: Peter Xu --- accel/kvm/kvm-all.c | 23 +-- 1 file changed, 13 insertions(+), 10 del

[PATCH v20 2/9] cpus: Introduce cpu_list_generation_id

2022-03-15 Thread huangy81
From: Hyman Huang(黄勇) Introduce cpu_list_generation_id to track cpu list generation so that cpu hotplug/unplug can be detected during measurement of dirty page rate. cpu_list_generation_id could be used to detect changes of cpu list, which is prepared for dirty page rate measurement. Signed-off

[PATCH v2 2/2] target/riscv: Allow software access to MIP SEIP

2022-03-15 Thread Alistair Francis
From: Alistair Francis The RISC-V specification states that: "Supervisor-level external interrupts are made pending based on the logical-OR of the software-writable SEIP bit and the signal from the external interrupt controller." We currently only allow either the interrupt controller or s

[PATCH v2 1/2] target/riscv: cpu: Fixup indentation

2022-03-15 Thread Alistair Francis
From: Alistair Francis Signed-off-by: Alistair Francis Reviewed-by: Bin Meng --- target/riscv/cpu.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index ddda4906ff..41b757995d 100644 --- a/target/riscv/cpu.c ++

[PATCH v2 0/2] target/riscv: Allow software access to MIP SEIP

2022-03-15 Thread Alistair Francis
From: Alistair Francis The RISC-V specification states that: "Supervisor-level external interrupts are made pending based on the logical-OR of the software-writable SEIP bit and the signal from the external interrupt controller." We currently only allow either the interrupt controller or s

[PATCH 1/1] MAINTAINERS: Update maintainers for Guest x86 HAXM CPUs

2022-03-15 Thread Wang, Wenchao
diff --git a/MAINTAINERS b/MAINTAINERS index f2e9ce1da2..36f877cf74 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -492,7 +492,6 @@ Guest CPU Cores (HAXM) - X86 HAXM CPUs M: Wenchao Wang -M: Colin Xu L: haxm-t...@intel.com W: https://github.com/intel/haxm/issues S: Maintained -

[PATCH v19 9/9] tests: Add dirty page rate limit test

2022-03-15 Thread huangy81
From: Hyman Huang(黄勇) Add dirty page rate limit test if kernel support dirty ring, create a standalone file to implement the test case. The following qmp commands are covered by this test case: "calc-dirty-rate", "query-dirty-rate", "set-vcpu-dirty-limit", "cancel-vcpu-dirty-limit" and "query-vc

[PATCH v19 8/9] migration-test: Export migration-test util funtions

2022-03-15 Thread huangy81
From: Hyman Huang(黄勇) Dirtylimit qtest can reuse the mechanisms that have been implemented by migration-test to start a vm, so export the relevant util functions. Signed-off-by: Hyman Huang(黄勇) --- tests/qtest/migration-helpers.c | 95 + tests/qtest/migrati

[PATCH v19 7/9] softmmu/dirtylimit: Implement dirty page rate limit

2022-03-15 Thread huangy81
From: Hyman Huang(黄勇) Implement dirtyrate calculation periodically basing on dirty-ring and throttle virtual CPU until it reachs the quota dirty page rate given by user. Introduce qmp commands "set-vcpu-dirty-limit", "cancel-vcpu-dirty-limit", "query-vcpu-dirty-limit" to enable, disable, query d

[PATCH v19 6/9] softmmu/dirtylimit: Implement virtual CPU throttle

2022-03-15 Thread huangy81
From: Hyman Huang(黄勇) Setup a negative feedback system when vCPU thread handling KVM_EXIT_DIRTY_RING_FULL exit by introducing throttle_us_per_full field in struct CPUState. Sleep throttle_us_per_full microseconds to throttle vCPU if dirtylimit is in service. Signed-off-by: Hyman Huang(黄勇) Revie

[PATCH v19 5/9] accel/kvm/kvm-all: Introduce kvm_dirty_ring_size function

2022-03-15 Thread huangy81
From: Hyman Huang(黄勇) Introduce kvm_dirty_ring_size util function to help calculate dirty ring ful time. Signed-off-by: Hyman Huang(黄勇) Acked-by: Peter Xu --- accel/kvm/kvm-all.c| 5 + accel/stubs/kvm-stub.c | 6 ++ include/sysemu/kvm.h | 2 ++ 3 files changed, 13 insertions(+)

[PATCH v19 3/9] migration/dirtyrate: Refactor dirty page rate calculation

2022-03-15 Thread huangy81
From: Hyman Huang(黄勇) abstract out dirty log change logic into function global_dirty_log_change. abstract out dirty page rate calculation logic via dirty-ring into function vcpu_calculate_dirtyrate. abstract out mathematical dirty page rate calculation into do_calculate_dirtyrate, decouple it f

[PATCH v19 1/9] accel/kvm/kvm-all: Refactor per-vcpu dirty ring reaping

2022-03-15 Thread huangy81
From: Hyman Huang(黄勇) Add a non-required argument 'CPUState' to kvm_dirty_ring_reap so that it can cover single vcpu dirty-ring-reaping scenario. Signed-off-by: Hyman Huang(黄勇) Reviewed-by: Peter Xu --- accel/kvm/kvm-all.c | 23 +-- 1 file changed, 13 insertions(+), 10 del

[PATCH v19 0/9] support dirty restraint on vCPU

2022-03-15 Thread huangy81
From: Hyman Huang(黄勇) v19 - rebase on master and fix conflicts - add test case for dirty page rate limit Ping. Adding an test case and hope it can be merged along with previous patchset by the way. Please review. Thanks, Regards Yong v18 - squash commit "Ignore query-vcpu-dirty-limit test" i

[PATCH v19 4/9] softmmu/dirtylimit: Implement vCPU dirtyrate calculation periodically

2022-03-15 Thread huangy81
From: Hyman Huang(黄勇) Introduce the third method GLOBAL_DIRTY_LIMIT of dirty tracking for calculate dirtyrate periodly for dirty page rate limit. Add dirtylimit.c to implement dirtyrate calculation periodly, which will be used for dirty page rate limit. Add dirtylimit.h to export util functions

[PATCH v19 2/9] cpus: Introduce cpu_list_generation_id

2022-03-15 Thread huangy81
From: Hyman Huang(黄勇) Introduce cpu_list_generation_id to track cpu list generation so that cpu hotplug/unplug can be detected during measurement of dirty page rate. cpu_list_generation_id could be used to detect changes of cpu list, which is prepared for dirty page rate measurement. Signed-off

Re: [PATCH] target/riscv: Exit current TB after an sfence.vma

2022-03-15 Thread Alistair Francis
On Wed, Mar 16, 2022 at 5:26 AM Idan Horowitz wrote: > > If the pages which control the translation of the currently executing > instructions are changed, and then the TLB is flushed using sfence.vma > we have to exit the current TB early, to ensure we don't execute stale > instructions. > > Signe

Re: [PATCH v19 4/7] net/vmnet: implement host mode (vmnet-host)

2022-03-15 Thread Vladislav Yaroshchuk
On Tue, Mar 15, 2022 at 11:37 PM Akihiko Odaki wrote: > On 2022/03/16 5:27, Vladislav Yaroshchuk wrote: > > Signed-off-by: Vladislav Yaroshchuk > > --- > > net/vmnet-host.c | 110 --- > > 1 file changed, 104 insertions(+), 6 deletions(-) > > > > dif

[PATCH v20 5/7] net/vmnet: implement bridged mode (vmnet-bridged)

2022-03-15 Thread Vladislav Yaroshchuk
Signed-off-by: Vladislav Yaroshchuk --- net/vmnet-bridged.m | 128 ++-- 1 file changed, 123 insertions(+), 5 deletions(-) diff --git a/net/vmnet-bridged.m b/net/vmnet-bridged.m index 91c1a2f2c7..5936c87718 100644 --- a/net/vmnet-bridged.m +++ b/net/vmnet-b

Re: [PATCH experiment 00/16] C++20 coroutine backend

2022-03-15 Thread Paolo Bonzini
On 3/15/22 16:55, Daniel P. Berrangé wrote: Expecting maintainers to enforce a subset during code review feels like it would be a tedious burden, that will inevitably let stuff through because humans are fallible, especially when presented with uninspiring, tedious, repetitive tasks. Restricting

[PATCH v20 3/7] net/vmnet: implement shared mode (vmnet-shared)

2022-03-15 Thread Vladislav Yaroshchuk
Interaction with vmnet.framework in different modes differs only on configuration stage, so we can create common `send`, `receive`, etc. procedures and reuse them. Signed-off-by: Phillip Tennen Signed-off-by: Vladislav Yaroshchuk --- net/vmnet-common.m | 358

[PATCH v20 2/7] net/vmnet: add vmnet backends to qapi/net

2022-03-15 Thread Vladislav Yaroshchuk
Create separate netdevs for each vmnet operating mode: - vmnet-host - vmnet-shared - vmnet-bridged Signed-off-by: Vladislav Yaroshchuk --- net/clients.h | 11 net/meson.build | 7 +++ net/net.c | 10 net/vmnet-bridged.m | 25 + net/vmnet-common.m | 20

[PATCH v20 7/7] net/vmnet: update hmp-commands.hx

2022-03-15 Thread Vladislav Yaroshchuk
Signed-off-by: Vladislav Yaroshchuk --- hmp-commands.hx | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 8476277aa9..8f3d78f177 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1265,7 +1265,11 @@ ERST { .name

[PATCH v20 6/7] net/vmnet: update qemu-options.hx

2022-03-15 Thread Vladislav Yaroshchuk
Signed-off-by: Vladislav Yaroshchuk --- qemu-options.hx | 25 + 1 file changed, 25 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index 5ce0ada75e..ea00d0eeb6 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2743,6 +2743,25 @@ DEF("netdev", HAS_ARG, QE

[PATCH v20 0/7] Add vmnet.framework based network backend

2022-03-15 Thread Vladislav Yaroshchuk
macOS provides networking API for VMs called 'vmnet.framework': https://developer.apple.com/documentation/vmnet We can provide its support as the new QEMU network backends which represent three different vmnet.framework interface usage modes: * `vmnet-shared`: allows the guest to communicat

[PATCH v20 4/7] net/vmnet: implement host mode (vmnet-host)

2022-03-15 Thread Vladislav Yaroshchuk
Signed-off-by: Vladislav Yaroshchuk --- net/vmnet-host.c | 109 --- 1 file changed, 103 insertions(+), 6 deletions(-) diff --git a/net/vmnet-host.c b/net/vmnet-host.c index a461d507c5..e6d01fd65e 100644 --- a/net/vmnet-host.c +++ b/net/vmnet-host.c @@

Re: [PULL 00/21] Darwin patches for 2022-03-15

2022-03-15 Thread Peter Maydell
2-03-15 09:53:13 +) > > are available in the Git repository at: > > https://github.com/philmd/qemu.git tags/darwin-20220315 > > for you to fetch changes up to c82b7ef16f3efa59e28f821f25a9c084ef84ea9d: > > MAINTAINERS: Volunteer to maintain D

[PATCH v20 1/7] net/vmnet: add vmnet dependency and customizable option

2022-03-15 Thread Vladislav Yaroshchuk
vmnet.framework dependency is added with 'vmnet' option to enable or disable it. Default value is 'auto'. used vmnet features are available since macOS 11.0, but new backend can be built and work properly with subset of them on 10.15 too. Signed-off-by: Vladislav Yaroshchuk --- meson.build

Re: [PATCH] target/riscv: Exit current TB after an sfence.vma

2022-03-15 Thread Alistair Francis
On Wed, Mar 16, 2022 at 5:26 AM Idan Horowitz wrote: > > If the pages which control the translation of the currently executing > instructions are changed, and then the TLB is flushed using sfence.vma > we have to exit the current TB early, to ensure we don't execute stale > instructions. > > Signe

[PATCH] linux-user: Clean up arg_start/arg_end confusion

2022-03-15 Thread Richard Henderson
We had two sets of variables: arg_start/arg_end, and arg_strings/env_strings. In linuxload.c, we set the first pair to the bounds of the argv strings, but in elfload.c, we set the first pair to the bounds of the argv pointers and the second pair to the bounds of the argv strings. Remove arg_start

Re: [RFC v4 01/21] vfio-user: introduce vfio-user protocol specification

2022-03-15 Thread Alex Williamson
On Tue, 15 Mar 2022 21:43:15 + Thanos Makatos wrote: > > -Original Message- > > From: Qemu-devel > bounces+thanos.makatos=nutanix@nongnu.org> On Behalf Of Alex > > Williamson > > Sent: 09 March 2022 22:35 > > To: John Johnson > > Cc: qemu-devel@nongnu.org > > Subject: Re: [RFC

Re: [PATCH v2] gitlab: include new aarch32 job in custom-runners

2022-03-15 Thread Richard Henderson
On 3/15/22 05:19, Alex Bennée wrote: Without linking it in it won't be presented on the UI. Also while doing that fix the misnamed job from 20.40 to 20.04. Fixes: cc44a16002 ("gitlab: add a new aarch32 custom runner definition") Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson r~

RE: [RFC v4 01/21] vfio-user: introduce vfio-user protocol specification

2022-03-15 Thread Thanos Makatos
> -Original Message- > From: Qemu-devel bounces+thanos.makatos=nutanix@nongnu.org> On Behalf Of Alex > Williamson > Sent: 09 March 2022 22:35 > To: John Johnson > Cc: qemu-devel@nongnu.org > Subject: Re: [RFC v4 01/21] vfio-user: introduce vfio-user protocol > specification > > O

Re: [PATCH 2/2] target/arm: Log fault address for M-profile faults

2022-03-15 Thread Richard Henderson
On 3/15/22 13:43, Peter Maydell wrote: For M-profile, the fault address is not always exposed to the guest in a fault register (for instance the BFAR bus fault address register is only updated for bus faults on data accesses, not instruction accesses). Currently we log the address only if we're

Re: [PATCH 1/2] target/arm: Log M-profile vector table accesses

2022-03-15 Thread Richard Henderson
On 3/15/22 13:43, Peter Maydell wrote: Currently the CPU_LOG_INT logging misses some useful information about loads from the vector table. Add logging where we load vector table entries. This is particularly helpful for cases where the user has accidentally not put a vector table in their image

[PATCH 2/2] target/arm: Log fault address for M-profile faults

2022-03-15 Thread Peter Maydell
For M-profile, the fault address is not always exposed to the guest in a fault register (for instance the BFAR bus fault address register is only updated for bus faults on data accesses, not instruction accesses). Currently we log the address only if we're putting it into a particular guest-visibl

[PATCH 0/2] target/arm: Improve M-profile exception logging

2022-03-15 Thread Peter Maydell
Our current logging for M-profile exceptions has a couple of holes which are particularly confusing for the case of an exception taken immediately out of reset: * we don't log the initial PC/SP loaded from the vector table * we don't log the PC we load from the vector table when we take an exc

[PATCH 1/2] target/arm: Log M-profile vector table accesses

2022-03-15 Thread Peter Maydell
Currently the CPU_LOG_INT logging misses some useful information about loads from the vector table. Add logging where we load vector table entries. This is particularly helpful for cases where the user has accidentally not put a vector table in their image at all, which can result in confusing gu

Re: [PATCH v19 4/7] net/vmnet: implement host mode (vmnet-host)

2022-03-15 Thread Akihiko Odaki
On 2022/03/16 5:27, Vladislav Yaroshchuk wrote: Signed-off-by: Vladislav Yaroshchuk --- net/vmnet-host.c | 110 --- 1 file changed, 104 insertions(+), 6 deletions(-) diff --git a/net/vmnet-host.c b/net/vmnet-host.c index a461d507c5..8f7a638967 1006

[PATCH v19 7/7] net/vmnet: update hmp-commands.hx

2022-03-15 Thread Vladislav Yaroshchuk
Signed-off-by: Vladislav Yaroshchuk --- hmp-commands.hx | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 8476277aa9..8f3d78f177 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1265,7 +1265,11 @@ ERST { .name

Re: [PATCH v2 1/3] util/osdep: Avoid madvise proto on modern Solaris

2022-03-15 Thread Peter Maydell
On Tue, 15 Mar 2022 at 19:16, Andrew Deason wrote: > > On Tue, 15 Mar 2022 18:33:33 + > Peter Maydell wrote: > > Can you put the prototype in include/qemu/osdep.h, please? > > (Exact location not very important as long as it's inside > > the extern-C block, but I suggest just under the bit wh

[PATCH v19 5/7] net/vmnet: implement bridged mode (vmnet-bridged)

2022-03-15 Thread Vladislav Yaroshchuk
Signed-off-by: Vladislav Yaroshchuk --- net/vmnet-bridged.m | 128 ++-- 1 file changed, 123 insertions(+), 5 deletions(-) diff --git a/net/vmnet-bridged.m b/net/vmnet-bridged.m index 91c1a2f2c7..5936c87718 100644 --- a/net/vmnet-bridged.m +++ b/net/vmnet-b

[PATCH v19 2/7] net/vmnet: add vmnet backends to qapi/net

2022-03-15 Thread Vladislav Yaroshchuk
Create separate netdevs for each vmnet operating mode: - vmnet-host - vmnet-shared - vmnet-bridged Signed-off-by: Vladislav Yaroshchuk --- net/clients.h | 11 net/meson.build | 7 +++ net/net.c | 10 net/vmnet-bridged.m | 25 + net/vmnet-common.m | 20

[PATCH v19 6/7] net/vmnet: update qemu-options.hx

2022-03-15 Thread Vladislav Yaroshchuk
Signed-off-by: Vladislav Yaroshchuk --- qemu-options.hx | 25 + 1 file changed, 25 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index 5ce0ada75e..ea00d0eeb6 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2743,6 +2743,25 @@ DEF("netdev", HAS_ARG, QE

[PATCH v19 4/7] net/vmnet: implement host mode (vmnet-host)

2022-03-15 Thread Vladislav Yaroshchuk
Signed-off-by: Vladislav Yaroshchuk --- net/vmnet-host.c | 110 --- 1 file changed, 104 insertions(+), 6 deletions(-) diff --git a/net/vmnet-host.c b/net/vmnet-host.c index a461d507c5..8f7a638967 100644 --- a/net/vmnet-host.c +++ b/net/vmnet-host.c @@

[PATCH v19 3/7] net/vmnet: implement shared mode (vmnet-shared)

2022-03-15 Thread Vladislav Yaroshchuk
Interaction with vmnet.framework in different modes differs only on configuration stage, so we can create common `send`, `receive`, etc. procedures and reuse them. Signed-off-by: Phillip Tennen Signed-off-by: Vladislav Yaroshchuk --- net/vmnet-common.m | 358

[PATCH v19 1/7] net/vmnet: add vmnet dependency and customizable option

2022-03-15 Thread Vladislav Yaroshchuk
vmnet.framework dependency is added with 'vmnet' option to enable or disable it. Default value is 'auto'. used vmnet features are available since macOS 11.0, but new backend can be built and work properly with subset of them on 10.15 too. Signed-off-by: Vladislav Yaroshchuk --- meson.build

[PATCH v19 0/7] Add vmnet.framework based network backend

2022-03-15 Thread Vladislav Yaroshchuk
macOS provides networking API for VMs called 'vmnet.framework': https://developer.apple.com/documentation/vmnet We can provide its support as the new QEMU network backends which represent three different vmnet.framework interface usage modes: * `vmnet-shared`: allows the guest to communicat

Re: [PATCH v18 3/7] net/vmnet: implement shared mode (vmnet-shared)

2022-03-15 Thread Vladislav Yaroshchuk
On Tue, Mar 15, 2022 at 11:07 PM Akihiko Odaki wrote: > On 2022/03/16 4:59, Vladislav Yaroshchuk wrote: > > Interaction with vmnet.framework in different modes > > differs only on configuration stage, so we can create > > common `send`, `receive`, etc. procedures and reuse them. > > > > Signed-of

Re: [PATCH v18 3/7] net/vmnet: implement shared mode (vmnet-shared)

2022-03-15 Thread Akihiko Odaki
On 2022/03/16 4:59, Vladislav Yaroshchuk wrote: Interaction with vmnet.framework in different modes differs only on configuration stage, so we can create common `send`, `receive`, etc. procedures and reuse them. Signed-off-by: Phillip Tennen Signed-off-by: Vladislav Yaroshchuk --- net/vmnet-

[PATCH v18 5/7] net/vmnet: implement bridged mode (vmnet-bridged)

2022-03-15 Thread Vladislav Yaroshchuk
Signed-off-by: Vladislav Yaroshchuk --- net/vmnet-bridged.m | 128 ++-- 1 file changed, 123 insertions(+), 5 deletions(-) diff --git a/net/vmnet-bridged.m b/net/vmnet-bridged.m index 91c1a2f2c7..5936c87718 100644 --- a/net/vmnet-bridged.m +++ b/net/vmnet-b

[PATCH v18 4/7] net/vmnet: implement host mode (vmnet-host)

2022-03-15 Thread Vladislav Yaroshchuk
Signed-off-by: Vladislav Yaroshchuk --- net/vmnet-host.c | 110 --- 1 file changed, 104 insertions(+), 6 deletions(-) diff --git a/net/vmnet-host.c b/net/vmnet-host.c index a461d507c5..8f7a638967 100644 --- a/net/vmnet-host.c +++ b/net/vmnet-host.c @@

[PATCH v18 3/7] net/vmnet: implement shared mode (vmnet-shared)

2022-03-15 Thread Vladislav Yaroshchuk
Interaction with vmnet.framework in different modes differs only on configuration stage, so we can create common `send`, `receive`, etc. procedures and reuse them. Signed-off-by: Phillip Tennen Signed-off-by: Vladislav Yaroshchuk --- net/vmnet-common.m | 368

[PATCH v18 7/7] net/vmnet: update hmp-commands.hx

2022-03-15 Thread Vladislav Yaroshchuk
Signed-off-by: Vladislav Yaroshchuk --- hmp-commands.hx | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 8476277aa9..8f3d78f177 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1265,7 +1265,11 @@ ERST { .name

[PATCH v18 2/7] net/vmnet: add vmnet backends to qapi/net

2022-03-15 Thread Vladislav Yaroshchuk
Create separate netdevs for each vmnet operating mode: - vmnet-host - vmnet-shared - vmnet-bridged Signed-off-by: Vladislav Yaroshchuk --- net/clients.h | 11 net/meson.build | 7 +++ net/net.c | 10 net/vmnet-bridged.m | 25 + net/vmnet-common.m | 20

[PATCH v18 6/7] net/vmnet: update qemu-options.hx

2022-03-15 Thread Vladislav Yaroshchuk
Signed-off-by: Vladislav Yaroshchuk --- qemu-options.hx | 25 + 1 file changed, 25 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index 5ce0ada75e..ea00d0eeb6 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2743,6 +2743,25 @@ DEF("netdev", HAS_ARG, QE

  1   2   3   4   >