On 3/5/22 01:06, Patrick Williams wrote:
Add the 'bletchley-bmc' machine type based on the kernel DTS[1] and
hardware schematics available to me. The i2c model is as complete as
the current QEMU models support, but in some cases I substituted devices
that are close enough for present functionali
On 3/5/22 01:06, Patrick Williams wrote:
Generally all BMCs will use the fmc_model to hold their own flash
and most will have a spi_model to hold the managed system's flash,
but not all systems do. Add a simple NULL check to allow a system
to set the spi_model as NULL to indicate it should not b
> -Original Message-
> From: Stefano Garzarella [mailto:sgarz...@redhat.com]
> Sent: Wednesday, January 19, 2022 7:36 PM
> To: Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
>
> Cc: stefa...@redhat.com; m...@redhat.com; coh...@redhat.com;
> pbonz...@redhat.com; Gonglei (Are
> -Original Message-
> From: Stefano Garzarella [mailto:sgarz...@redhat.com]
> Sent: Wednesday, January 19, 2022 7:31 PM
> To: Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
>
> Cc: stefa...@redhat.com; m...@redhat.com; coh...@redhat.com;
> pbonz...@redhat.com; Gonglei (Are
On 3/4/22 18:51, matheus.fe...@eldorado.org.br wrote:
From: "Lucas Mateus Castro (alqotel)"
Some ISA v2.03 Vector Multiply instructions marked to be ISA v2.07 only.
This patch fixes it.
and MacOSX 10 is also fixed.
There are of lot invalid writes when openbios is loaded :
...
Invalid wr
Hi Stefano,
> -Original Message-
> From: Stefano Garzarella [mailto:sgarz...@redhat.com]
> Sent: Wednesday, January 19, 2022 7:24 PM
> To: Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
>
> Cc: stefa...@redhat.com; m...@redhat.com; coh...@redhat.com;
> pbonz...@redhat.com; Go
On Fri, Mar 4, 2022 at 3:23 PM Eric Blake wrote:
>
> On Fri, Mar 04, 2022 at 02:47:44PM -0500, John Snow wrote:
> > qemu_img() returning zero ought to be the rule, not the
> > exception. Remove all explicit checks against the condition in
> > preparation for making non-zero returns an Exception.
>
On 4/3/22 12:21, Peter Maydell wrote:
Currently we incorrectly think that posix_memalign() exists on
Windows. This is because of a combination of:
* the msys2/mingw toolchain/libc claim to have a
__builtin_posix_memalign when there isn't a builtin of that name
* meson will assume that i
On 2/3/22 02:50, Titus Rwantare wrote:
- add the VOUT_MIN and STATUS_MFR registers
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 24
include/hw/i2c/pmbus_device.h | 3 +++
2 files changed, 27 insertions(+)
Reviewed-by: Philippe Mathieu-Dau
On 2022/03/05 0:34, R Kim wrote:
Hello Guys,
Looks like we haven't yet official support for OpenGL on MacOS? I need
to apply third-party patches to make it work. It would be great if these
parts are imported to qemu and be official. Nowaways, it's really needed
Acceleration on VMs for who use
Cc'ing Laurent:
$ ./scripts/get_maintainer.pl -f scripts/qemu-binfmt-conf.sh
Laurent Vivier (maintainer:Linux user)
qemu-devel@nongnu.org (open list:All patches CC here)
On 5/3/22 01:06, Andreas K. Hüttel wrote:
With the command line flag -mplt and a recent toolchain, ELF binaries
generated by
On 2/3/22 02:50, Titus Rwantare wrote:
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
---
MAINTAINERS | 3 +
hw/arm/Kconfig | 1 +
hw/sensor/Kconfig| 5 +
hw/sensor/isl_pmbus_vr.c | 211 +
hw/sensor/me
On 2/3/22 02:50, Titus Rwantare wrote:
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 41 -
1 file changed, 40 insertions(+), 1 deletion(-)
static uint8_t pmbus_receive_byte(SMBusDevice *smd)
{
PMBusDevice *pmdev = PMBUS_DEVICE(s
Add the 'bletchley-bmc' machine type based on the kernel DTS[1] and
hardware schematics available to me. The i2c model is as complete as
the current QEMU models support, but in some cases I substituted devices
that are close enough for present functionality. Strap registers are
kept the same as t
Generally all BMCs will use the fmc_model to hold their own flash
and most will have a spi_model to hold the managed system's flash,
but not all systems do. Add a simple NULL check to allow a system
to set the spi_model as NULL to indicate it should not be instantiated.
Signed-off-by: Patrick Wil
With the command line flag -mplt and a recent toolchain, ELF binaries
generated by gcc can obtain EI_ABIVERSION=1, see below, which makes, e.g.,
gcc three-stage bootstrap in a mips-unknown-linux-gnu qemu-user chroot
fail since the binfmt-misc magic does not match anymore.
qemu executes these binar
On 2/3/22 02:50, Titus Rwantare wrote:
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
index 93c746bab3..6eeb0731d7 100644
--- a/hw/i2c/pmbus_device.c
+++ b/hw/i2c/pmbus_device.c
@@
On 2/3/22 02:50, Titus Rwantare wrote:
This change cleans up the inputs to pmbus_receive uint, the length of
received data is contained in PMBusDevice state and doesn't need to be
passed around.
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 18 +-
1 file changed,
On 2/3/22 02:50, Titus Rwantare wrote:
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
---
hw/sensor/isl_pmbus_vr.c | 50
include/hw/sensor/isl_pmbus_vr.h | 1 +
tests/qtest/isl_pmbus_vr-test.c | 78 ++--
3 files changed, 126 ins
On 2/3/22 02:50, Titus Rwantare wrote:
The Renesas RAA229004 is a PMBus Multiphase Voltage Regulator
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
---
hw/sensor/isl_pmbus_vr.c | 18 ++
include/hw/sensor/isl_pmbus_vr.h | 1 +
tests/qtest/isl_pmbus_vr-test.c |
On 2/3/22 02:50, Titus Rwantare wrote:
From: Shengtan Mao
Signed-off-by: Shengtan Mao
Reviewed-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 18 ++
include/hw/i2c/pmbus_device.h | 20 +++-
2 files changed, 37 insertions(+), 1 deletion(-)
Reviewed
On 2/3/22 02:50, Titus Rwantare wrote:
add self to MAINTAINERS for the PMBus subsystem and related sensors,
and set PMBus as maintained.
Signed-off-by: Titus Rwantare
---
MAINTAINERS | 10 ++
1 file changed, 10 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé
On Fri, 4 Mar 2022 at 13:43, Corey Minyard wrote:
>
> On Tue, Mar 01, 2022 at 05:50:44PM -0800, Titus Rwantare wrote:
> > v2:
> > - split PMBus commit with updates into individual fixes
> > - renamed isl_pmbus[.ch] adding _vr for voltage regulators
> >
> > v3:
> > - split uint refactor commi
On 3/4/22 07:51, matheus.fe...@eldorado.org.br wrote:
From: Víctor Colombo
Fixes: da499405aa ("target/ppc: Refactor VSX_MAX_MINC helper")
Signed-off-by: Víctor Colombo
Signed-off-by: Matheus Ferst
---
target/ppc/fpu_helper.c | 2 ++
1 file changed, 2 insertions(+)
Reviewed-by: Richard Hende
On 3/4/22 07:51, matheus.fe...@eldorado.org.br wrote:
From: Víctor Colombo
Fixes: 3909ff1fac ("target/ppc: Implement xvcvbf16spn and xvcvspbf16
instructions")
Signed-off-by: Víctor Colombo
Signed-off-by: Matheus Ferst
---
target/ppc/fpu_helper.c | 2 ++
1 file changed, 2 insertions(+)
Revi
On 3/4/22 07:51, matheus.fe...@eldorado.org.br wrote:
From: Matheus Ferst
Fixes: 7e5947df6e94 ("target/ppc: implement vrlqmi")
Signed-off-by: Matheus Ferst
---
target/ppc/translate/vmx-impl.c.inc | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
Reviewed-by: Richard Henderson
r~
On 3/4/22 07:51, matheus.fe...@eldorado.org.br wrote:
From: Matheus Ferst
Fixes: b090f4f1e3c9 ("target/ppc: Implement xxgenpcv[bhwd]m instruction")
Signed-off-by: Matheus Ferst
---
target/ppc/int_helper.c | 28 +---
target/ppc/translate/vsx-impl.c.inc | 71 +++-
On 3/4/22 07:51, matheus.fe...@eldorado.org.br wrote:
From: Matheus Ferst
Fixes: 4e272668406b ("target/ppc: implement vrlqnm")
Signed-off-by: Matheus Ferst
---
target/ppc/translate/vmx-impl.c.inc | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
Reviewed-by: Richard Henderson
On 3/4/22 07:51, matheus.fe...@eldorado.org.br wrote:
From: Matheus Ferst
Fixes: 29e9dfcf755e ("target/ppc: vmulh* instructions without helpers")
Signed-off-by: Matheus Ferst
---
target/ppc/translate/vmx-impl.c.inc | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
Reviewed-by
On 3/4/22 07:51, matheus.fe...@eldorado.org.br wrote:
From: "Lucas Mateus Castro (alqotel)"
Some ISA v2.03 Vector Multiply instructions marked to be ISA v2.07 only.
This patch fixes it.
Fixes: 80eca687c851 ("target/ppc: moved vector even and odd multiplication to
decodetree")
Reported-by: Howa
On 3/4/22 09:15, Daniel P. Berrangé wrote:
Personally I favour turning it into a non-gating job as
I don't want to invest more of my own time debugging
non-bugs in it.
I would be in favor of removing it from CI entirely, so that we don't even waste cpu time
on it by default. Those that care c
On 3/4/22 12:14, Peter Maydell wrote:
Yes, that works. I'll send an update.
Do check it with KVM as well, to check the "CPU doesn't actually
have that property" case...
Argh! No, doesn't work.
Unexpected error in object_property_find_err() at ../src/qom/object.c:1299:
qemu-system-aarch64:
On 3/3/22 05:39, Amir Gonnen wrote:
@@ -55,6 +55,7 @@ static void nios2_cpu_reset(DeviceState *dev)
memset(env->regs, 0, sizeof(uint32_t) * NUM_CORE_REGS);
memset(env->shadow_regs, 0, sizeof(uint32_t) * NUM_REG_SETS *
NUM_GP_REGS);
+env->regs[CR_STATUS] |= CR_STATUS_RSIE;
stat
On Fri, 4 Mar 2022 at 19:52, Richard Henderson
wrote:
>
> On 3/4/22 01:52, Peter Maydell wrote:
> > Is it not possible to implement this in the usual "change
> > property for older versioned machines" way of adding to
> > the hw_compat arrays?
> >
> > diff --git a/hw/core/machine.c b/hw/core/machi
On Fri, 4 Mar 2022 at 13:37, Michael S. Tsirkin wrote:
>
> The following changes since commit 6629bf78aac7e53f83fd0bcbdbe322e2302dfd1f:
>
> Merge remote-tracking branch
> 'remotes/pmaydell/tags/pull-target-arm-20220302' into staging (2022-03-03
> 14:46:48 +)
>
> are available in the Git re
On Fri, Mar 04, 2022 at 06:56:20PM +, Daniel P. Berrangé wrote:
> There are no longer any users of this method, so it can be removed to
> prevent future accidental (mis)use.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> include/sysemu/os-posix.h | 2 --
> include/sysemu/os-win32.h | 5 -
On Fri, Mar 04, 2022 at 06:56:19PM +, Daniel P. Berrangé wrote:
> With the future intent to try to move to a fully QAPI driven
> configuration system, we want to have any current command
> parsing well isolated from logic that applies the resulting
> configuration.
>
> We also don't want os-po
On Fri, Mar 04, 2022 at 06:56:18PM +, Daniel P. Berrangé wrote:
> When daemonizing QEMU it is not possible to use the stdio chardev
> backend because the file descriptors are connected to /dev/null.
> Currently the chardev checks for this scenario directly, but to
> decouple it from the system
On Fri, Mar 04, 2022 at 06:56:17PM +, Daniel P. Berrangé wrote:
> Use of the is_daemonized() method is isolated to allow it to be
> more easily eliminated in a future change.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> softmmu/vl.c | 13 +++--
> 1 file changed, 7 insertions(+), 6 d
On Fri, Mar 04, 2022 at 06:56:16PM +, Daniel P. Berrangé wrote:
> We want to decouple knowledge of daemonization from other code. What the
> logging code really wants to know is whether it can use stdio or not.
> Add an API to let the logging code be informed of this fact explicitly.
>
> Signe
On 3/3/22 05:39, Amir Gonnen wrote:
Implement shadow register set and related instructions
rdprs, wrprs. Fix eret to update either status or sstatus
according to current register set.
eret also changes register set when needed.
Signed-off-by: Amir Gonnen
---
target/nios2/cpu.c | 1 +
On Tue, Mar 01, 2022 at 05:50:44PM -0800, Titus Rwantare wrote:
> v2:
> - split PMBus commit with updates into individual fixes
> - renamed isl_pmbus[.ch] adding _vr for voltage regulators
>
> v3:
> - split uint refactor commit and removed commit renaming files
> - rename rolled into prece
09cf55e47b677256fd:
> > > Merge remote-tracking branch
> > > 'remotes/alistair/tags/pull-riscv-to-apply-20220303' into staging
> > > (2022-03-03 19:59:38 +)>
> > > are available in the Git repository at:
> > > https://github
On Fri, Mar 04, 2022 at 07:36:10PM +, Daniel P. Berrangé wrote:
> This validates that connections to an NBD server running on a UNIX
> socket can use TLS with pre-shared keys (PSK).
>
> Reviewed-by: Eric Blake
> Signed-off-by: Daniel P. Berrangé
> ---
> tests/qemu-iotests/233| 28 ++
On 3/4/22 20:30, Daniel P. Berrangé wrote:
Interesting. I wonder whether that detection is specifically related
to the fuzzing, or whether it is something we would have seen merely
by building with 'asan' and running 'make check' as normal.
IIUC, the oss-fuzz job we run in GitLab CI is mostly ju
From: Marc-André Lureau
No longer used after the previous patches.
Signed-off-by: Marc-André Lureau
Reviewed-by: Laurent Vivier
Reviewed-by: Stefan Weil
Reviewed-by: Richard Henderson
---
include/sysemu/os-posix.h | 3 ---
include/sysemu/os-win32.h | 6 --
util/oslib-win32.c|
From: Marc-André Lureau
glib provides a convenience helper to measure elapsed time. It isn't
subject to wall-clock time changes.
Note that this changes the initial OPENED time, which used to print the
current time.
Signed-off-by: Marc-André Lureau
Reviewed-by: Laurent Vivier
---
softmmu/qtes
From: Marc-André Lureau
GLib g_get_real_time() is an alternative to gettimeofday() which allows
to simplify our code.
For semihosting, a few bits are lost on POSIX host, but this shouldn't
be a big concern.
Signed-off-by: Marc-André Lureau
Reviewed-by: Laurent Vivier
---
blockdev.c
From: Marc-André Lureau
GLib g_get_real_time() is an alternative to gettimeofday() which allows
to simplify our code.
Signed-off-by: Marc-André Lureau
Reviewed-by: Laurent Vivier
---
qga/commands-posix.c | 14 --
qga/commands-win32.c | 19 ---
qga/commands.c
From: Marc-André Lureau
gettimeofday() returns 0 for success.
Signed-off-by: Marc-André Lureau
Reviewed-by: Laurent Vivier
Reviewed-by: Richard Henderson
---
target/m68k/m68k-semi.c | 2 +-
target/nios2/nios2-semi.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tar
From: Marc-André Lureau
Hi,
Here is a few patches to replace qemu_gettimeofday() helper with functions
provided by GLib.
v2:
- fix return of get-time in nanoseconds
- qga: replace with a common get-time function for qga posix/win32
- split qga patch
- add r-b tags, drop RFC
Marc-André Lureau (
Hi Richard
On Sat, Mar 5, 2022 at 12:50 AM Richard Henderson
wrote:
>
> On 3/4/22 05:27, marcandre.lur...@redhat.com wrote:
> > +g_clear_pointer(&timer, g_timer_destroy);
> > +timer = g_timer_new();
>
> Why not g_timer_{reset,start}, instead of destroying and recreating?
Well, th
On Fri, Mar 04, 2022 at 07:36:09PM +, Daniel P. Berrangé wrote:
> This validates that connections to an NBD server running on a UNIX
> socket can use TLS, and require a TLS hostname override to pass
> certificate validation.
>
> Reviewed-by: Eric Blake
> Signed-off-by: Daniel P. Berrangé
> -
On 3/3/22 05:39, Amir Gonnen wrote:
eret instruction is only allowed in supervisor mode.
Signed-off-by: Amir Gonnen
---
target/nios2/translate.c | 2 ++
1 file changed, 2 insertions(+)
Reviewed-by: Richard Henderson
r~
On 3/4/22 05:27, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
No longer used after the previous patches.
Signed-off-by: Marc-André Lureau
---
include/sysemu/os-posix.h | 3 ---
include/sysemu/os-win32.h | 6 --
util/oslib-win32.c| 20
3 fi
On 3/4/22 05:27, marcandre.lur...@redhat.com wrote:
+g_clear_pointer(&timer, g_timer_destroy);
+timer = g_timer_new();
Why not g_timer_{reset,start}, instead of destroying and recreating?
r~
Hi
On Sat, Mar 5, 2022 at 12:40 AM BALATON Zoltan wrote:
> On Fri, 4 Mar 2022, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > GLib g_get_real_time() is an alternative to gettimeofday().
> >
> > For semihosting, a few bits are lost on POSIX host, but this shouldn't
> > be
On 3/4/22 05:27, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
gettimeofday() returns 0 for success.
Signed-off-by: Marc-André Lureau
---
target/m68k/m68k-semi.c | 2 +-
target/nios2/nios2-semi.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Richard
On Fri, 4 Mar 2022, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
GLib g_get_real_time() is an alternative to gettimeofday().
For semihosting, a few bits are lost on POSIX host, but this shouldn't
be a big concern.
Signed-off-by: Marc-André Lureau
---
blockdev.c
On Fri, Mar 04, 2022 at 07:36:06PM +, Daniel P. Berrangé wrote:
> Introduce a filter for the output of qemu-nbd export list so it can be
> reused in multiple tests.
>
> The filter is a bit more permissive that what test 241 currently uses,
> as its allows printing of the export count, along wi
On Fri, Mar 04, 2022 at 02:47:44PM -0500, John Snow wrote:
> qemu_img() returning zero ought to be the rule, not the
> exception. Remove all explicit checks against the condition in
> preparation for making non-zero returns an Exception.
>
> Signed-off-by: John Snow
> ---
> +++ b/tests/qemu-iote
On 3/4/22 01:21, Peter Maydell wrote:
+ * platform APIs (for instance _alligned_malloc() will
Typo there with the 'll'.
r~
On 3/4/22 01:21, Peter Maydell wrote:
Currently qemu_try_memalign()'s behaviour if asked to allocate
0 bytes is rather variable:
* on Windows, we will assert
* on POSIX platforms, we get the underlying behaviour of
the posix_memalign() or equivalent function, which may be
either "retu
listair/tags/pull-riscv-to-apply-20220303' into staging
> > (2022-03-03 19:59:38 +)>
> > are available in the Git repository at:
> > https://github.com/cschoenebeck/qemu.git tags/pull-9p-20220304
> >
> > for you to fetch changes up to 39edfe337c418995b2932a9
The length of the attestation report buffer is never checked to be
valid before allocation is made. If the length of the report is returned
to be 0, the buffer to retrieve the attestation buffer is allocated with
length 0 and passed to the kernel to fill with contents of the attestation
report. Lea
There is a Linux kernel bug present until v5.12 that prevents
booting with FEAT_LPA2 enabled. As a workaround for TCG, allow
the feature to be disabled from -cpu max.
Since this kernel bug is present in the Fedora 31 image that
we test in avocado, disable lpa2 on the command-line.
Reviewed-by: P
On 3/4/22 01:52, Peter Maydell wrote:
Is it not possible to implement this in the usual "change
property for older versioned machines" way of adding to
the hw_compat arrays?
diff --git a/hw/core/machine.c b/hw/core/machine.c
index d856485cb4d..dac82a709ba 100644
--- a/hw/core/machine.c
+++ b/hw/
There is a Linux kernel bug present until v5.12 that prevents
booting with FEAT_LPA2 enabled. As a workaround for TCG,
disable this feature for machine versions prior to 7.0.
Signed-off-by: Richard Henderson
---
hw/core/machine.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --
re-write qemu_img() as a function that will by default raise a
VerboseProcessException (extended from CalledProcessException) on
non-zero return codes. This will produce a stack trace that will show
the command line arguments and return code from the failed process run.
Users that want something m
Changes for v5:
* Most of the patch set has been merged.
* Use hw_compat_6_2 for disabling lpa2.
r~
Richard Henderson (2):
target/arm: Provide cpu property for controling FEAT_LPA2
hw/core: Disable LPA2 for -machine virt-6.2
target/arm/cpu.h| 5 -
hw/core/machine.c
Am 2022-03-04 20:30, schrieb Philippe Mathieu-Daudé:
On 4/3/22 19:09, Patrick Williams wrote:
The w25q01jvq is a 128MB part. Support is being added to the
kernel[1]
and the two have been tested together.
1.
https://lore.kernel.org/lkml/2022022209.23108-1-potin@quantatw.com/
Signed-
qemu_img() returning zero ought to be the rule, not the
exception. Remove all explicit checks against the condition in
preparation for making non-zero returns an Exception.
Signed-off-by: John Snow
---
tests/qemu-iotests/163 | 9 +++--
tests/qemu-iotests/216
V2:
- Rebase on top of kwolf's latest PR.
- Adjust tests/graph-changes-while-io in patch 3/5
- Drop eblake's r-b on 3/5.
This is secretly V4ish of a series I started in response to Thomas
Huth's encountering a failure in qemu-img because of missing zstd
support. This series changes the qemu_img
This adds an Exception that extends the Python stdlib
subprocess.CalledProcessError.
The difference is that the str() method of this exception also adds the
stdout/stderr logs. In effect, if this exception goes unhandled, Python
will print the output in a visually distinct wrapper to the terminal
This validates that connections to an NBD server running on a UNIX
socket can use TLS with pre-shared keys (PSK).
Reviewed-by: Eric Blake
Signed-off-by: Daniel P. Berrangé
---
tests/qemu-iotests/233| 28
tests/qemu-iotests/233.out| 17 +
This validates that connections to an NBD server running on a UNIX
socket can use TLS, and require a TLS hostname override to pass
certificate validation.
Reviewed-by: Eric Blake
Signed-off-by: Daniel P. Berrangé
---
tests/qemu-iotests/233 | 24
tests/qemu-iotests/2
Fortify compare_images() to be more discerning about the status codes it
receives. If qemu_img() returns an exit code that implies it didn't
actually perform the comparison, treat that as an exceptional
circumstance and force the caller to be aware of the peril.
If a negative test is desired (perh
The length of the attestation report buffer is never checked to be
valid before allocation is made. If the length of the report is returned
to be 0, the buffer to retrieve the attestation buffer is allocated with
length 0 and passed to the kernel to fill with contents of the attestation
report. Lea
This validates that connections to an NBD server where the certificate
hostname does not match will fail. It further validates that using the
new 'tls-hostname' override option can solve the failure.
Reviewed-by: Eric Blake
Signed-off-by: Daniel P. Berrangé
---
tests/qemu-iotests/233| 1
When developing an I/O test it is typical to add some logic to the
test script, run it to view the output diff, and then apply the
output diff to the reference file. This can be drastically simplified
by letting the test runner update the reference file in place.
By setting 'QEMU_IOTESTS_REGEN=1',
>>> print(add_visual_margin(msg, width=72, name="Commit Message"))
┏━ Commit Message ━━
┃ add_visual_margin() takes a chunk of text and wraps it in a visual
┃ container that force-wraps to a specified width. An optional title
┃ label may be given,
Using standard filters is more future proof than rolling our own.
Reviewed-by: Eric Blake
Signed-off-by: Daniel P. Berrangé
---
tests/qemu-iotests/233 | 29 -
tests/qemu-iotests/233.out | 8
2 files changed, 16 insertions(+), 21 deletions(-)
diff --git
Some tests will want to use 'localhost' instead of '127.0.0.1', and
some will use the image options syntax rather than the classic URI
syntax.
Reviewed-by: Eric Blake
Signed-off-by: Daniel P. Berrangé
---
tests/qemu-iotests/common.filter | 4
1 file changed, 4 insertions(+)
diff --git a/t
The TLS usage for NBD was restricted to IP sockets because validating
x509 certificates requires knowledge of the hostname that the client
is connecting to.
TLS does not have to use x509 certificates though, as PSK (pre-shared
keys) provide an alternative credential option. These have no
requireme
When using the --list option, qemu-nbd acts as an NBD client rather
than a server. As such when using TLS, it has a need to validate
the server certificate. This adds a --tls-hostname option which can
be used to override the default hostname used for certificate
validation.
Reviewed-by: Eric Blake
This series was principally motivated by a desire to enabl use of TLS
on non-TCP transports. For x509 certificates this means we need a way
to set the hostname to use for validation. This also lets us override
the hostname when connecting on a TCP transport that is tunnelled or
port-forwarded. It a
When connecting to an NBD server with TLS and x509 credentials,
the client must validate the hostname it uses for the connection,
against that published in the server's certificate. If the client
is tunnelling its connection over some other channel, however, the
hostname it uses may not match the i
Introduce a filter for the output of qemu-nbd export list so it can be
reused in multiple tests.
The filter is a bit more permissive that what test 241 currently uses,
as its allows printing of the export count, along with any possible
error messages that might be emitted.
Reviewed-by: Eric Blake
Currently the TLS session object assumes that the caller will always
provide a hostname when using x509 creds on a client endpoint. This
relies on the caller to detect and report an error if the user has
configured QEMU with x509 credentials on a UNIX socket. The migration
code has such a check, bu
In
commit a71d597b989fd701b923f09b3c20ac4fcaa55e81
Author: Vladimir Sementsov-Ogievskiy
Date: Thu Jun 10 13:08:00 2021 +0300
block/nbd: reuse nbd_co_do_establish_connection() in nbd_open()
the use of the 'hostname' field from the BDRVNBDState struct was
lost, and 'nbd_connect' just
On Fri, Mar 04, 2022 at 10:43:45AM -0600, Eric Blake wrote:
> On Thu, Mar 03, 2022 at 04:03:26PM +, Daniel P. Berrangé wrote:
> > Introduce a filter for the output of qemu-nbd export list so it can be
> > reused in multiple tests.
> >
> > The filter is a bit more permissive that what test 241
On Fri, Mar 04, 2022 at 07:22:16PM +, Peter Maydell wrote:
> On Fri, 4 Mar 2022 at 19:15, Daniel P. Berrangé wrote:
> > On Fri, Mar 04, 2022 at 06:46:51PM +, Peter Maydell wrote:
> > > Either of these is fine; my requirement is only that either:
> > > (1) the oss-fuzz gitlab CI job needs
On 4/3/22 19:09, Patrick Williams wrote:
The w25q01jvq is a 128MB part. Support is being added to the kernel[1]
and the two have been tested together.
1. https://lore.kernel.org/lkml/2022022209.23108-1-potin@quantatw.com/
Signed-off-by: Patrick Williams
Cc: Potin Lai
---
hw/block/m
On 2/23/22 04:05, Steven Price wrote:
On 23/02/2022 11:49, Chao Peng wrote:
On Thu, Feb 17, 2022 at 11:09:35AM -0800, Andy Lutomirski wrote:
On Thu, Feb 17, 2022, at 5:06 AM, Chao Peng wrote:
On Fri, Feb 11, 2022 at 03:33:35PM -0800, Andy Lutomirski wrote:
On 1/18/22 05:21, Chao Peng wrote:
On Thu, Mar 03, 2022 at 02:14:34PM -0600, Eric Blake wrote:
> On Thu, Mar 03, 2022 at 04:03:20PM +, Daniel P. Berrangé wrote:
> > In
> >
> > commit a71d597b989fd701b923f09b3c20ac4fcaa55e81
> > Author: Vladimir Sementsov-Ogievskiy
> > Date: Thu Jun 10 13:08:00 2021 +0300
> >
> > b
On Fri, 4 Mar 2022 at 19:15, Daniel P. Berrangé wrote:
> On Fri, Mar 04, 2022 at 06:46:51PM +, Peter Maydell wrote:
> > Either of these is fine; my requirement is only that either:
> > (1) the oss-fuzz gitlab CI job needs to in practice actually
> > pass at least most of the time
> > (2) we
On Fri, Mar 04, 2022 at 06:46:51PM +, Peter Maydell wrote:
> On Fri, 4 Mar 2022 at 17:41, Paolo Bonzini wrote:
> > The test seems to be flaky, I've been fighting with it all week---trying
> > multiple versions of this pull request and removing patches until
> > build-oss-fuzz passed. The set
in the Git repository at:
https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20220304
for you to fetch changes up to cf320769476c3e2820be2a6280bfa1e15baf396f:
tcg/i386: Implement bitsel for avx512 (2022-03-04 08:50:41 -1000)
--
With the future intent to try to move to a fully QAPI driven
configuration system, we want to have any current command
parsing well isolated from logic that applies the resulting
configuration.
We also don't want os-posix.c to contain code that is specific
to the system emulators, as this file is
On Fri, Mar 04, 2022 at 01:39:32PM -0500, Tyler Fanelli wrote:
> The length of the attestation report buffer is never checked to be
> valid before allocation is made. If the length of the report is returned
> to be 0, the buffer to retrieve the attestation report is allocated with
> length 0 and pa
1 - 100 of 461 matches
Mail list logo
