Re: [PATCH] hw/timer/etraxfs_timer: Add vmstate for ETRAX timers

On 12/17/21 3:37 PM, Philippe Mathieu-Daudé wrote: ping? On 11/6/21 11:56, Philippe Mathieu-Daudé wrote: Add the vmstate for the ETRAX timers. This is in theory a migration compatibility break for the 'AXIS devboard 88' CRIS machine. Signed-off-by: Philippe Mathieu-Daudé --- hw/timer/etraxf

Re: [PATCH] target/mips: Align vector registers to 16 bytes

On 12/17/21 3:34 PM, Philippe Mathieu-Daudé wrote: Align fpr_t to 16 bytes to be able to use the TCG "Generic" vector operation expansion API from "tcg/tcg-op-gvec.h", otherwise we trigger assertions in check_size_align(). See commits ec8e23e37f8 (s390x) and 11e2bfef799 (i386) for similar justif

Re: [RFC PATCH v3 3/3] softmmu/physmem: Introduce MemTxAttrs::memory field and MEMTX_BUS_ERROR

On 12/17/21 3:18 PM, Philippe Mathieu-Daudé wrote: #define MEMTX_OK 0 #define MEMTX_ERROR (1U << 0) /* device returned an error */ #define MEMTX_DECODE_ERROR (1U << 1) /* nothing at that address */ +#define MEMTX_BUS_ERROR (1U << 2) /* bus returned an error */ Thi

Re: [PULL 0/9] Trivial branch for 7.0 patches

tches pull request 20211217 Leonardo Garcia (1): hw/virtio/vhost: Fix typo in comment. Philippe Mathieu-Daudé (7): configure: Symlink binaries using .exe suffix with MinGW target/i386/kvm: Replace use of __u32 type q

Re: [RFC PATCH v3 20/27] hw/intc: Add LoongArch extioi interrupt controller(EIOINTC)

On 04/12/2021 12:07, Xiaojuan Yang wrote: This patch realize the EIOINTC interrupt controller. Signed-off-by: Xiaojuan Yang Signed-off-by: Song Gao --- hw/intc/Kconfig| 3 + hw/intc/loongarch_extioi.c | 499 + hw/intc/meson.build

Re: [RFC PATCH v3 19/27] hw/intc: Add LoongArch ls7a msi interrupt controller support(PCH-MSI)

On 04/12/2021 12:07, Xiaojuan Yang wrote: This patch realize PCH-MSI interrupt controller. Signed-off-by: Xiaojuan Yang Signed-off-by: Song Gao --- hw/intc/Kconfig | 5 +++ hw/intc/loongarch_pch_msi.c | 67 + hw/intc/meson.build

Re: [PATCH] hw/scsi/megasas: Simplify using the ldst API

On 12/17/21 3:15 PM, Philippe Mathieu-Daudé wrote: -cdb[3] = (len >> 8) & 0xff; -cdb[4] = (len & 0xff); +stw_be_p(&cdb[2], len); Wrong offset. Otherwise, Reviewed-by: Richard Henderson r~

Re: [RFC PATCH v3 18/27] hw/intc: Add LoongArch ls7a interrupt controller support(PCH-PIC)

On 04/12/2021 12:07, Xiaojuan Yang wrote: This patch realize the PCH-PIC interrupt controller. Signed-off-by: Xiaojuan Yang Signed-off-by: Song Gao --- hw/intc/Kconfig | 4 + hw/intc/loongarch_pch_pic.c | 357 hw/intc/meson.build

Re: [PATCH] cpu: remove unnecessary #ifdef CONFIG_TCG

On 12/17/21 2:49 AM, Paolo Bonzini wrote: "if (tcg_enabled())" allows elision of the code inside it; we only need the prototype to exist, so that the code compile even for the --disable-tcg case. Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson r~

Re: [PATCH-for-7.0] hw/net/rocker: Remove unused definitions

On 11/16/21 11:39 AM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- hw/net/rocker/rocker.h | 5 - 1 file changed, 5 deletions(-) diff --git a/hw/net/rocker/rocker.h b/hw/net/rocker/rocker.h index 412fa44d017..d22bbd2bf80 100644 --- a/hw/net/rocker/rocker.h +++ b

Re: [RFC PATCH v3 17/27] hw/loongarch: Add LoongArch ipi interrupt support(IPI)

On 04/12/2021 12:07, Xiaojuan Yang wrote: This patch realize the IPI interrupt controller. Signed-off-by: Xiaojuan Yang Signed-off-by: Song Gao --- hw/intc/Kconfig | 3 + hw/intc/loongarch_ipi.c | 162 hw/intc/meson.build

Re: [RFC PATCH v3 16/27] hw/loongarch: Add LoongArch cpu interrupt support(CPUINTC)

On 04/12/2021 12:07, Xiaojuan Yang wrote: Loongson-3A5000 support 14 interrupts from 64 - 77(Timer->75 IPI->76) Loongson-3A5000 and ls7a form a legacy model and extended model irq hierarchy.Tcg mode emulate a simplified extended model which has no Legacy I/O Interrupt Controller(LIOINTC) and LPC

Re: [PATCH] tests/tcg/ppc64le: remove INT128 requirement to run non_signalling_xscv

On 12/16/21 6:09 AM, matheus.fe...@eldorado.org.br wrote: +asm("mtvsrd 0, %3\n\t" \ +"xxswapd 0, 0\n\t" \ +"mtvsrd 0, %2\n\t" \ This doesn't

Re: [PATCH 3/3] hw/input/pckbd: Rename i8042_setup_a20_line() and its a20 irq argument

On 11/22/21 12:14, Peter Maydell wrote: > On Fri, 5 Nov 2021 at 17:21, Philippe Mathieu-Daudé wrote: >> >> 'a20_out' is an input IRQ, rename it as 'a20_input'. >> i8042_setup_a20_line() doesn't take a Device parameter >> but an ISADevice one. Rename it as i8042_isa_*() to >> make it explicit. >> >

Re: [RFC PATCH v3 15/27] hw/loongarch: Add support loongson3-ls7a machine type.

On 04/12/2021 12:07, Xiaojuan Yang wrote: Emulate a 3A5000 board use the new loongarch instruction. 3A5000 belongs to the Loongson3 series processors. The board consists of a 3A5000 cpu model and the 7A1000 bridge. The host 3A5000 board is really complicated and contains many functions.Now for t

Re: [PATCH v3 1/3] hw: Move MARVELL_88W8618 Kconfig from audio/ to arm/

On 12/17/21 3:30 PM, Philippe Mathieu-Daudé wrote: The Marvell 88W8618 is a system-on-chip with an ARM core. We implement its audio codecs and network interface. Homogeneous SoC Kconfig are usually defined in the hw/$ARCH directory. Move it there. Suggested-by: Richard Henderson Signed-off-by: P

Re: [RFC PATCH v3 14/27] hw/pci-host: Add ls7a1000 PCIe Host bridge support for Loongson3 Platform

On 04/12/2021 12:07, Xiaojuan Yang wrote: This is a model of the PCIe Host Bridge found on a Loongson-5000 processor. It includes a interrupt controller, some interface for pci and nonpci devices. Mainly emulate part of it that is not exactly the same as the host and only use part devices for tc

Re: [PATCH] hw/timer/etraxfs_timer: Add vmstate for ETRAX timers

ping? On 11/6/21 11:56, Philippe Mathieu-Daudé wrote: > Add the vmstate for the ETRAX timers. > This is in theory a migration compatibility break > for the 'AXIS devboard 88' CRIS machine. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/timer/etraxfs_timer.c | 34 ++

[PATCH] target/mips: Align vector registers to 16 bytes

Align fpr_t to 16 bytes to be able to use the TCG "Generic" vector operation expansion API from "tcg/tcg-op-gvec.h", otherwise we trigger assertions in check_size_align(). See commits ec8e23e37f8 (s390x) and 11e2bfef799 (i386) for similar justifications. Signed-off-by: Philippe Mathieu-Daudé ---

[PATCH v3 1/3] hw: Move MARVELL_88W8618 Kconfig from audio/ to arm/

The Marvell 88W8618 is a system-on-chip with an ARM core. We implement its audio codecs and network interface. Homogeneous SoC Kconfig are usually defined in the hw/$ARCH directory. Move it there. Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/Kconfig | 3 +++

[PATCH v3 3/3] hw/net: Move MV88W8618 network device out of hw/arm/ directory

The Marvell 88W8618 network device is hidden in the Musicpal machine. Move it into a new unit file under the hw/net/ directory. Acked-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- include/hw/net/mv88w8618_eth.h | 12 + hw/arm/musicpal.c | 380 +---

[PATCH v3 2/3] hw/arm/musicpal: Fix coding style of code related to MV88W8618 device

We are going to move this code, so fix its style first to avoid: ERROR: spaces required around that '/' (ctx:VxV) Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/musicpal.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/a

[PATCH v3 0/3] hw/net: Move MV88W8618 network device out of hw/arm/ directory

This series simply extract the MV88W8618 device from the ARM machine in hw/arm/ and move it to hw/net/. Since v2: - declare MARVELL_88W8618 in hw/arm/Kconfig - use MARVELL_88W8618 Kconfig (rth) Since v1: - update (c) notice Philippe Mathieu-Daudé (3): hw: Move MARVELL_88W8618 Kconfig from audi

Re: [PATCH v2 2/2] hw/net: Move MV88W8618 network device out of hw/arm/ directory

On 12/17/21 23:25, Richard Henderson wrote: > On 12/16/21 4:56 AM, Philippe Mathieu-Daudé wrote: >> +softmmu_ss.add(when: 'CONFIG_MUSICPAL', if_true: >> files('mv88w8618_eth.c')) > > So... there's currently a MARVELL_88W8618 define for the audio component > of the same chip.  Should we re-use that

Re: [RFC PATCH v3 3/3] softmmu/physmem: Introduce MemTxAttrs::memory field and MEMTX_BUS_ERROR

On 12/17/21 23:34, Peter Maydell wrote: > On Wed, 15 Dec 2021 at 18:24, Philippe Mathieu-Daudé > wrote: >> >> Add the 'memory' bit to the memory attributes to restrict bus >> controller accesses to memories. >> >> Introduce flatview_access_allowed() to check bus permission >> before running any b

[PATCH] hw/scsi/megasas: Simplify using the ldst API

This code is easier to review using the load/store API. Signed-off-by: Philippe Mathieu-Daudé --- hw/scsi/megasas.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c index 619b66ef0f3..066f30e3f22 100644 --- a/hw/scsi/meg

Re: [RFC PATCH v3 3/3] softmmu/physmem: Introduce MemTxAttrs::memory field and MEMTX_BUS_ERROR

On Wed, 15 Dec 2021 at 18:24, Philippe Mathieu-Daudé wrote: > > Add the 'memory' bit to the memory attributes to restrict bus > controller accesses to memories. > > Introduce flatview_access_allowed() to check bus permission > before running any bus transaction. > > Have read/write accessors retur

Re: [PATCH v2 2/2] hw/net: Move MV88W8618 network device out of hw/arm/ directory

On 12/16/21 4:56 AM, Philippe Mathieu-Daudé wrote: +softmmu_ss.add(when: 'CONFIG_MUSICPAL', if_true: files('mv88w8618_eth.c')) So... there's currently a MARVELL_88W8618 define for the audio component of the same chip. Should we re-use that here? Otherwise, Acked-by: Richard Henderson r~

Re: [PATCH v2 1/2] hw/arm/musicpal: Fix coding style of code related to MV88W8618 device

On 12/16/21 4:56 AM, Philippe Mathieu-Daudé wrote: We are going to move this code, so fix its style first to avoid: ERROR: spaces required around that '/' (ctx:VxV) Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/musicpal.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletion

Re: [PATCH 10/10] configure: remove unnecessary symlinks

On 12/16/21 12:51 AM, Paolo Bonzini wrote: Make pc-bios/meson.build use the files in the source tree as inputs to bzip2. Signed-off-by: Paolo Bonzini --- configure | 1 - pc-bios/meson.build | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Richard Henderson

Re: [PATCH 09/10] configure, meson: move ARCH to meson.build

On 12/16/21 12:51 AM, Paolo Bonzini wrote: -if config_host['ARCH'].startswith(k) or config_target['TARGET_BASE_ARCH'].startswith(k) +if host_arch.startswith(k) or config_target['TARGET_BASE_ARCH'].startswith(k) Not a problem with this patch, but a missed use of target_base_arch variab

Re: [PATCH 08/10] meson: rename "arch" variable

On 12/16/21 12:51 AM, Paolo Bonzini wrote: Avoid confusion between the ARCH variable of configure/config-host.mak and the same-named variable of meson.build. Signed-off-by: Paolo Bonzini --- meson.build | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Richard

Re: [PATCH 07/10] configure: unify x86_64 and x32

On 12/16/21 7:30 AM, Paolo Bonzini wrote: On 12/16/21 10:10, Philippe Mathieu-Daudé wrote: On 12/16/21 09:51, Paolo Bonzini wrote: The only difference between the two, as far as either configure or Meson are concerned, is in the multilib flags passed to the compiler. For QEMU, this fixes the h

Re: [PATCH 07/10] configure: unify x86_64 and x32

On 12/16/21 12:51 AM, Paolo Bonzini wrote: The only difference between the two, as far as either configure or Meson are concerned, is in the multilib flags passed to the compiler. For QEMU, this fixes the handling of TYPE_OLDDEVT in include/exec/user/thunk.h and enables testing of dirty ring buf

Re: [PATCH 06/10] configure: unify ppc64 and ppc64le

On 12/16/21 12:51 AM, Paolo Bonzini wrote: The only difference between the two, as far as either configure or Meson are concerned, is the default endianness of the compiler. For tests/tcg, specify the endianness explicitly on the command line; for configure, do the same so that it is possible to

Re: [PATCH 05/10] configure: unify two case statements on $cpu

On 12/16/21 12:51 AM, Paolo Bonzini wrote: + s390) +CPU_CFLAGS="-m31" +ARCH=unknown ;; Eh, ok. I could also support removing the case entirely. I don't see the point in having an entry for an unsupported host. This will actively not compile as soon as my safe-signal reorg hits. Othe

[PATCH] docs/can: convert to restructuredText

From: Lucas Ramage Bug: https://gitlab.com/qemu-project/qemu/-/issues/527 Signed-off-by: Lucas Ramage --- docs/{can.txt => can.rst} | 14 ++ docs/index.rst| 1 + 2 files changed, 7 insertions(+), 8 deletions(-) rename docs/{can.txt => can.rst} (97%) diff --git a/docs/

Re: [PULL 09/36] ui: do not delay further remote resize

On 12/17/21 6:37 AM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau A remote client, such as Spice, will already avoid flooding the stream by delaying the resize requests. Signed-off-by: Marc-André Lureau Acked-by: Gerd Hoffmann --- include/ui/console.h | 2 +- ui/console.c

Re: [PATCH 1/5] migration: All this fields are unsigned

On 12/17/21 21:25, Richard Henderson wrote: > On 12/16/21 1:26 AM, Philippe Mathieu-Daudé wrote: >> On 12/16/21 10:13, Juan Quintela wrote: >>>   multifd_send_terminate_threads(bool error) "error %d" >> >> Nitpicking: bool is unsigned :) > > Eh, while the value is not negative, bool will promote t

Re: [PATCH 04/10] configure: do not set bsd_user/linux_user early

On 12/16/21 12:51 AM, Paolo Bonzini wrote: @@ -541,7 +541,6 @@ gnu/kfreebsd) ;; freebsd) bsd="yes" - bsd_user="yes" make="${MAKE-gmake}" # needed for kinfo_getvmmap(3) in libutil.h ;; @@ -586,7 +585,6 @@ haiku) ;; linux) linux="yes" - linux_user="yes" vhost_user=${

Re: [PATCH 02/10] configure: make $targetos lowercase, use windows instead of MINGW32

On 12/16/21 12:51 AM, Paolo Bonzini wrote: targetos is already mostly the same as Meson host_machine.system(), just in CamelCase. Adjust Windows, which is different, and switch to lowercase to match Meson. Signed-off-by: Paolo Bonzini --- configure | 58 ---

Re: [PATCH 01/10] configure: simplify creation of plugin symbol list

On 12/16/21 12:51 AM, Paolo Bonzini wrote: --dynamic-list is present on all supported ELF (not Windows or Darwin) platforms, since it dates back to 2006; -exported_symbols_list is likewise present on all supported versions of macOS. Do not bother doing a functional test in configure. Since stuf

Re: [PATCH 1/5] migration: All this fields are unsigned

On 12/16/21 1:26 AM, Philippe Mathieu-Daudé wrote: On 12/16/21 10:13, Juan Quintela wrote: multifd_send_terminate_threads(bool error) "error %d" Nitpicking: bool is unsigned :) Eh, while the value is not negative, bool will promote to int in stdarg. r~

Re: [PULL v3 000/101] ppc queue

https://github.com/legoater/qemu/ tags/pull-ppc-20211217 for you to fetch changes up to 0e6232bc3cb96bdf6fac1b5d7659aa9887afe657: ppc/pnv: Use QOM hierarchy to scan PEC PHB4 devices (2021-12-17 17:57:19 +0100) Changes in v3: - Fixed patch "docs: Introducing pseries documentation" wi

[PULL 4/9] hw/avr: Realize AVRCPU qdev object using qdev_realize()

From: Philippe Mathieu-Daudé TYPE_AVR_CPU inherits TYPE_CPU, which itself inherits TYPE_DEVICE. TYPE_DEVICE instances are realized using qdev_realize(), we don't need to access QOM internal values. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Michael Rolnik Message-Id: <20211205224109.32

[PULL 8/9] tests/qtest: Replace g_memdup() by g_memdup2()

From: Philippe Mathieu-Daudé Per https://discourse.gnome.org/t/port-your-module-from-g-memdup-to-g-memdup2-now/5538 The old API took the size of the memory to duplicate as a guint, whereas most memory functions take memory sizes as a gsize. This made it easy to accidentally pass a gsize t

[PULL 5/9] hw/virtio/vhost: Fix typo in comment.

From: Leonardo Garcia Signed-off-by: Leonardo Garcia Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Message-Id: Signed-off-by: Laurent Vivier --- hw/virtio/vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c ind

[PULL 9/9] checkpatch: Do not allow deprecated g_memdup()

From: Philippe Mathieu-Daudé g_memdup() is insecure and as been deprecated in GLib 2.68. QEMU provides the safely equivalent g_memdup2() wrapper. Do not allow more g_memdup() calls in the repository, provide a hint to use g_memdup2(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Eric Bla

[PULL 7/9] glib-compat: Introduce g_memdup2() wrapper

From: Philippe Mathieu-Daudé When experimenting raising GLIB_VERSION_MIN_REQUIRED to 2.68 (Fedora 34 provides GLib 2.68.1) we get: hw/virtio/virtio-crypto.c:245:24: error: 'g_memdup' is deprecated: Use 'g_memdup2' instead [-Werror,-Wdeprecated-declarations] ... g_memdup() has been updated

[PULL 2/9] target/i386/kvm: Replace use of __u32 type

From: Philippe Mathieu-Daudé QEMU coding style mandates to not use Linux kernel internal types for scalars types. Replace __u32 by uint32_t. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <2026193955.2793171-1-phi...@redhat.com> Signed-off-by: Laurent Vivi

[PULL 1/9] configure: Symlink binaries using .exe suffix with MinGW

From: Philippe Mathieu-Daudé When using the MinGW toolchain, we use the .exe suffix for the executable name. We also need to use it for the symlinks in the build directory. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Weil Acked-by: Paolo Bonzini Message-Id: <20211109144504.15412

[PULL 3/9] qemu-keymap: Add license in generated files

From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Warner Losh Message-Id: <2027174533.1900570-1-phi...@redhat.com> Signed-off-by: Laurent Vivier --- qemu-keymap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qemu-keymap.c b/qemu-keymap.c index 536e8f23

[PULL 6/9] docs/block-replication.txt: Fix replication top-id command demo

From: Zhang Chen This demo not correct, the original childs1 can't pass the the bdrv_is_root_node check in replcation_start(). Keep consistent with docs/COLO-FT.txt Signed-off-by: Zhang Chen Reviewed-by: Laurent Vivier Message-Id: <20211018085044.2788276-1-chen.zh...@intel.com> Signed-off-by:

[PULL 0/9] Trivial branch for 7.0 patches

ch-for-7.0-pull-request for you to fetch changes up to ce2ff9cccf0c5f123f9d1e3d5e4fc07d1c2c159d: checkpatch: Do not allow deprecated g_memdup() (2021-12-17 11:57:35 +0100) Trivial patches pull reques

Re: [PATCH v4 11/14] vfio-user: IOMMU support for remote device

> On Dec 16, 2021, at 9:40 AM, Stefan Hajnoczi wrote: > > On Wed, Dec 15, 2021 at 10:35:35AM -0500, Jagannathan Raman wrote: >> Assign separate address space for each device in the remote processes. > > If I understand correctly this isn't really an IOMMU. It's abusing the > IOMMU APIs to crea

Re: [RFC PATCH v3 3/3] softmmu/physmem: Introduce MemTxAttrs::memory field and MEMTX_BUS_ERROR

On 12/15/21 10:24 AM, Philippe Mathieu-Daudé wrote: +static inline bool flatview_access_allowed(MemoryRegion *mr, MemTxAttrs attrs, + hwaddr addr, hwaddr len) There's no need to mark this inline. Otherwise, Reviewed-by: Richard Henderson r~

Re: [PATCH qemu] s390x/css: fix PMCW invalid mask

On Fri, 17 Dec 2021 18:13:47 +0100 Pierre Morel wrote: > >> Previously, we required bits 5, 6 and 7 to be zero (0x07 == 0b111). But, > >> as per the principles of operation, bit 5 is ignored in MSCH and bits 0, > >> 1, 6 and 7 need to be zero. > > > > On a second thought, don't we have to make

Re: [PATCH v4 10/14] vfio-user: handle PCI BAR accesses

> On Dec 16, 2021, at 9:10 AM, Stefan Hajnoczi wrote: > > On Wed, Dec 15, 2021 at 10:35:34AM -0500, Jagannathan Raman wrote: >> +static ssize_t vfu_object_bar_rw(PCIDevice *pci_dev, hwaddr addr, size_t >> count, >> + char * const buf, const bool is_write, >> +

Re: [PATCH v4 09/14] vfio-user: handle DMA mappings

> On Dec 16, 2021, at 8:24 AM, Stefan Hajnoczi wrote: > > On Wed, Dec 15, 2021 at 10:35:33AM -0500, Jagannathan Raman wrote: >> Define and register callbacks to manage the RAM regions used for >> device DMA >> >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G Johnson >> Signed-off-b

Re: [RFC 1/2] migration: Introduce ram_transferred_add()

On 12/16/21 13:34, David Edmondson wrote: > ...and use it. > > Signed-off-by: David Edmondson > --- > migration/ram.c | 23 ++- > migration/ram.h | 1 + > 2 files changed, 15 insertions(+), 9 deletions(-) > diff --git a/migration/ram.h b/migration/ram.h > index c515396a9a..

Re: [RFC PATCH] docs/devel: more documentation on the use of suffixes

On 12/17/21 18:19, Alex Bennée wrote: > Using _qemu is a little confusing. Let's use _compat for these sorts > of things. We should also mention _impl which is another common suffix > in the code base. > > Signed-off-by: Alex Bennée > --- > docs/devel/style.rst | 7 +++ > include/glib-compa

Re: [PATCH] Target/arm: Implement Cortex-A5

Richard Henderson writes: > On 12/13/21 1:02 PM, Alex Bennée wrote: >>> +cpu->midr = 0x410fc0f1; >> hmm wikipedia lists the part number as 0xc05 (and the a15 as 0xc0f) >> but >> I can't find the actual value in the TRM. > > https://developer.arm.com/documentation/ddi0434/c > > has exactly t

Re: [PATCH v2] Revert "target/ppc: Move SPR_DSISR setting to powerpc_excp"

Richard Henderson writes: > On 12/9/21 9:33 AM, Fabiano Rosas wrote: >> This reverts commit 336e91f85332dda0ede4c1d15b87a19a0fb898a2. >> >> It breaks the --disable-tcg build: >> >> ../target/ppc/excp_helper.c:463:29: error: implicit declaration of >> function ‘cpu_ldl_code’ [-Werror=implici

Re: [PATCH v4 07/14] vfio-user: run vfio-user context

> On Dec 16, 2021, at 6:17 AM, Stefan Hajnoczi wrote: > > On Wed, Dec 15, 2021 at 10:35:31AM -0500, Jagannathan Raman wrote: >> @@ -114,6 +118,62 @@ static void vfu_object_set_device(Object *obj, const >> char *str, Error **errp) >> vfu_object_init_ctx(o, errp); >> } >> >> +static void vf

Re: [PULL v2 0/7] s390x patches (and one gitlab-CI fix)

On 12/17/21 6:46 AM, Thomas Huth wrote: Hi! The following changes since commit 29eb5c2c86f935b0e9700fad2ecfe8a32b011d57: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2021-12-16 08:39:20 -0800) are available in the Git repository at: https://gitlab.com/thu

[PULL v3 000/101] ppc queue

The following changes since commit 76b56fdfc9fa43ec6e5986aee33f108c6c6a511e: Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into staging (2021-12-14 12:46:18 -0800) are available in the Git repository at: https://github.com/legoater/qemu/ tags/pull-ppc-2021121

Re: [PULL v2 000/101] ppc queue

On 12/17/21 9:31 AM, Cédric Le Goater wrote: Maybe you can generate the email text with --inspect-emails, and then send only the cover letter manually with git send-email. That's what I wanted to do: only send the cover letter. Is that ok ? Yes, please. r~

Re: [PULL v2 000/101] ppc queue

On 12/17/21 18:24, Richard Henderson wrote: On 12/17/21 8:46 AM, Cédric Le Goater wrote: On 12/17/21 17:33, Richard Henderson wrote: Different docs failure: Warning, treated as error: /tmp/qemu-test/src/docs/system/ppc/pseries.rst:241:Unexpected indentation. You can test this yourself with m

Re: [RFC PATCH] docs/devel: more documentation on the use of suffixes

On Fri, Dec 17, 2021 at 05:19:02PM +, Alex Bennée wrote: > Using _qemu is a little confusing. Let's use _compat for these sorts > of things. We should also mention _impl which is another common suffix > in the code base. > > Signed-off-by: Alex Bennée > --- > docs/devel/style.rst | 7 ++

Re: [PULL v2 000/101] ppc queue

On 12/17/21 8:46 AM, Cédric Le Goater wrote: On 12/17/21 17:33, Richard Henderson wrote: Different docs failure: Warning, treated as error: /tmp/qemu-test/src/docs/system/ppc/pseries.rst:241:Unexpected indentation. You can test this yourself with make docker-test-build@ubuntu1804 TARGET_LIST=

[RFC PATCH] docs/devel: more documentation on the use of suffixes

Using _qemu is a little confusing. Let's use _compat for these sorts of things. We should also mention _impl which is another common suffix in the code base. Signed-off-by: Alex Bennée --- docs/devel/style.rst | 7 +++ include/glib-compat.h | 6 +++--- 2 files changed, 10 insertions(+), 3 d

Re: [PATCH 00/15] ppc/ppc405: decade cleanup

On 12/17/21 17:36, Christophe Leroy wrote: Le 15/12/2021 à 17:49, Cédric Le Goater a écrit : On 12/6/21 11:36, Cédric Le Goater wrote: Hello, The goal of these changes is to refresh the QEMU ref405ep machine and enable boot from a Linux kernel without relying on a U-Boot firmware. The reason

Re: [PATCH qemu] s390x/css: fix PMCW invalid mask

On 12/17/21 14:58, Halil Pasic wrote: On Thu, 16 Dec 2021 14:16:57 +0100 Nico Boehr wrote: Previously, we required bits 5, 6 and 7 to be zero (0x07 == 0b111). But, as per the principles of operation, bit 5 is ignored in MSCH and bits 0, 1, 6 and 7 need to be zero. On a second thought, don

Re: [PATCH v2 4/4] intel_iommu: Fix irqchip / X2APIC configuration checks

On Thu, 2021-12-16 at 16:47 +0800, Peter Xu wrote: > Hi, David, > > On Thu, Dec 09, 2021 at 10:08:40PM +, David Woodhouse wrote: > > We don't need to check kvm_enable_x2apic(). It's perfectly OK to support > > interrupt remapping even if we can't address CPUs above 254. Kind of > > pointless,

Re: [RFC PATCH] memory: Fix dma-reentrancy issues at the MMIO level

On 211217 1625, Philippe Mathieu-Daudé wrote: > On 12/17/21 15:30, Alexander Bulekov wrote: > > On 211217 1458, Philippe Mathieu-Daudé wrote: > >> On 12/17/21 04:08, Alexander Bulekov wrote: > >>> Here's my shot at fixing dma-reentracy issues. This patch adds a flag to > >>> the DeviceState, which

Re: [PATCH 00/15] ppc/ppc405: decade cleanup

Le 15/12/2021 à 17:49, Cédric Le Goater a écrit : > On 12/6/21 11:36, Cédric Le Goater wrote: >> Hello, >> >> The goal of these changes is to refresh the QEMU ref405ep machine and >> enable boot from a Linux kernel without relying on a U-Boot firmware. >> The reason for doing so is that we are un

[PATCH v2 1/2] iotests: Test qemu-img convert of zeroed data cluster

From: Kevin Wolf This demonstrates what happens when the block status changes in sub-min_sparse granularity, but all of the parts are zeroed out. The alignment logic in is_allocated_sectors() prevents that the target image remains fully sparse as expected, but turns it into a data cluster of expl

[PATCH v2 0/2] qemu-img convert: Fix sparseness detection

Hi all! 01: only update test output rebasing on master 02: replaced with my proposed solution. Kevin Wolf (1): iotests: Test qemu-img convert of zeroed data cluster Vladimir Sementsov-Ogievskiy (1): qemu-img: make is_allocated_sectors() more efficient qemu-img.c | 23 ++

Re: [PULL v2 000/101] ppc queue

On 12/17/21 17:33, Richard Henderson wrote: On 12/16/21 12:24 PM, Cédric Le Goater wrote: The following changes since commit 76b56fdfc9fa43ec6e5986aee33f108c6c6a511e:    Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into staging (2021-12-14 12:46:18 -0800) are available i

[PATCH v2 2/2] qemu-img: make is_allocated_sectors() more efficient

Consider the case when the whole buffer is zero and end is unaligned. If i <= tail, we return 1 and do one unaligned WRITE, RMW happens. If i > tail, we do on aligned WRITE_ZERO (or skip if target is zeroed) and again one unaligned WRITE, RMW happens. Let's do better: don't fragment the whole-ze

Re: [PATCH v5 28/31] block.c: assert BQL lock held in bdrv_co_invalidate_cache

On 17/12/2021 12:04, Hanna Reitz wrote: On 24.11.21 07:44, Emanuele Giuseppe Esposito wrote: bdrv_co_invalidate_cache is special: it is an I/O function, I still don’t believe it is, but well. (Yes, it is called by a test in an iothread, but I believe we’ve seen that the tests simply somet

Re: [PULL v2 000/101] ppc queue

On 12/16/21 12:24 PM, Cédric Le Goater wrote: The following changes since commit 76b56fdfc9fa43ec6e5986aee33f108c6c6a511e: Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into staging (2021-12-14 12:46:18 -0800) are available in the Git repository at: https://github.c

Re: [PATCH v2 25/25] python: rename qemu.aqmp to qemu.qmp

On Fri, Dec 17, 2021, 2:40 AM Vladimir Sementsov-Ogievskiy < vsement...@virtuozzo.com> wrote: > 17.12.2021 00:10, John Snow wrote: > > > > > > On Thu, Dec 16, 2021 at 6:41 AM Vladimir Sementsov-Ogievskiy < > vsement...@virtuozzo.com > wrote: > > > > 15.12.2021

Re: [PATCH v5 22/31] block_int-common.h: assertion in the callers of BlockDriver function pointers

On 17.12.21 16:53, Emanuele Giuseppe Esposito wrote: On 16/12/2021 19:43, Hanna Reitz wrote: On 24.11.21 07:44, Emanuele Giuseppe Esposito wrote: Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Stefan Hajnoczi ---   block.c    | 18 ++   block/create.c | 10 +++

Re: [PATCH v5 22/31] block_int-common.h: assertion in the callers of BlockDriver function pointers

On 16/12/2021 19:43, Hanna Reitz wrote: On 24.11.21 07:44, Emanuele Giuseppe Esposito wrote: Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Stefan Hajnoczi ---   block.c    | 18 ++   block/create.c | 10 ++   2 files changed, 28 insertions(+) [...] dif

Re: [RFC PATCH] memory: Fix dma-reentrancy issues at the MMIO level

On 12/17/21 15:30, Alexander Bulekov wrote: > On 211217 1458, Philippe Mathieu-Daudé wrote: >> On 12/17/21 04:08, Alexander Bulekov wrote: >>> Here's my shot at fixing dma-reentracy issues. This patch adds a flag to >>> the DeviceState, which is set/checked when we call an accessor >>> associated w

Re: [PATCH v2] hw: Add compat machines for 7.0

On Fri, Dec 17, 2021 at 03:39:48PM +0100, Cornelia Huck wrote: > Add 7.0 machine types for arm/i440fx/q35/s390x/spapr. > > Acked-by: Cédric Le Goater > Reviewed-by: Juan Quintela > Signed-off-by: Cornelia Huck > --- > > v1->v2: fix typo in i386 function chaining (thanks danpb!) > > --- > hw/

Re: [PATCH v3 02/28] glib-compat: Introduce g_memdup2() wrapper

Daniel P. Berrangé writes: > On Thu, Dec 16, 2021 at 02:11:37PM +, Alex Bennée wrote: >> >> Philippe Mathieu-Daudé writes: >> >> > When experimenting raising GLIB_VERSION_MIN_REQUIRED to 2.68 >> > (Fedora 34 provides GLib 2.68.1) we get: >> > >> > hw/virtio/virtio-crypto.c:245:24: erro

[PULL v2 0/7] s390x patches (and one gitlab-CI fix)

Hi! The following changes since commit 29eb5c2c86f935b0e9700fad2ecfe8a32b011d57: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2021-12-16 08:39:20 -0800) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/s390x-2021-12-17 for you to

Re: [PATCH v1] virtio-mem: Don't skip alignment checks when warning about block size

On 11.10.21 19:33, David Hildenbrand wrote: > If we warn about the block size being smaller than the default, we skip > some alignment checks. > > This can currently only fail on x86-64, when specifying a block size of > 1 MiB, however, we detect the THP size of 2 MiB. > > Fixes: 228957fea3a9 ("v

Re: [PATCH v3 02/28] glib-compat: Introduce g_memdup2() wrapper

On Fri, Dec 17, 2021 at 02:53:05PM +, Alex Bennée wrote: > > Daniel P. Berrangé writes: > > > On Thu, Dec 16, 2021 at 02:11:37PM +, Alex Bennée wrote: > >> > >> Philippe Mathieu-Daudé writes: > >> > >> > When experimenting raising GLIB_VERSION_MIN_REQUIRED to 2.68 > >> > (Fedora 34 pr

[PULL 35/36] ui/dbus: register D-Bus VC handler

From: Marc-André Lureau Export the default consoles over the D-Bus chardev. Signed-off-by: Marc-André Lureau Acked-by: Gerd Hoffmann --- ui/dbus.c | 53 + 1 file changed, 53 insertions(+) diff --git a/ui/dbus.c b/ui/dbus.c index 41f1716f255

[PULL 34/36] ui/dbus: add chardev backend & interface

From: Marc-André Lureau Add a new chardev backend which allows D-Bus client to handle the chardev stream & events. Signed-off-by: Marc-André Lureau Acked-by: Gerd Hoffmann --- qapi/char.json| 27 include/chardev/char-socket.h | 2 + include/qemu/dbus.h | 5

[PULL 33/36] option: add g_auto for QemuOpts

From: Marc-André Lureau Used in the next commit. Signed-off-by: Marc-André Lureau Acked-by: Gerd Hoffmann --- include/qemu/option.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/qemu/option.h b/include/qemu/option.h index 306bf0757509..bbd86e1c4eab 100644 --- a/include/qemu/op

[PULL 36/36] MAINTAINERS: update D-Bus section

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Acked-by: Gerd Hoffmann --- MAINTAINERS | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index fbd6d0b174af..7ef72fc7cc21 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2873,11 +287

[PULL 31/36] chardev: teach socket to accept no addresses

From: Marc-André Lureau The following patches are going to use CharSocket as a base class for sockets that are created with a given fd (without a given address). Signed-off-by: Marc-André Lureau Acked-by: Gerd Hoffmann --- chardev/char-socket.c | 14 +- 1 file changed, 9 insertion

[PULL 32/36] chardev: make socket derivable

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Acked-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé --- include/chardev/char-socket.h | 84 +++ chardev/char-socket.c | 58 +--- 2 files changed, 85 insertions(+), 57 d

[PULL 29/36] audio: add "dbus" audio backend

From: Marc-André Lureau Add a new -audio backend that accepts D-Bus clients/listeners to handle playback & recording, to be exported via the -display dbus. Example usage: -audiodev dbus,in.mixing-engine=off,out.mixing-engine=off,id=dbus -display dbus,audiodev=dbus Signed-off-by: Marc-André Lure

Re: [PATCH qemu] s390x/css: fix PMCW invalid mask

On Fri, 17 Dec 2021 14:58:11 +0100 Halil Pasic wrote: > On Thu, 16 Dec 2021 14:16:57 +0100 > Nico Boehr wrote: > > > Previously, we required bits 5, 6 and 7 to be zero (0x07 == 0b111). But, > > as per the principles of operation, bit 5 is ignored in MSCH and bits 0, > > 1, 6 and 7 need to be ze

[PULL 30/36] ui/dbus: add clipboard interface

From: Marc-André Lureau Expose the clipboard API over D-Bus. See the interface documentation for further details. Signed-off-by: Marc-André Lureau Acked-by: Gerd Hoffmann --- ui/dbus.h| 14 ++ ui/dbus-clipboard.c | 457 +++ ui/dbus.c

  1   2   3   >