Re: [PATCH 0/2] gitlab-ci: Add riscv64 cross builds

2021-09-14 Thread Alex Bennée
Richard Henderson writes: > The only tcg host that does not have build coverage is riscv64. > Filling this hole will help with tcg reorgs I have in the works. > > Thanks to Alex for help debugging the docker image creation. Queued to testing/next, thanks. -- Alex Bennée

[PATCH v2 1/1] python: Update for pylint 2.10

2021-09-14 Thread John Snow
A few new annoyances. Of note is the new warning for an unspecified encoding when opening a text file, which actually does indicate a potentially real problem; see https://www.python.org/dev/peps/pep-0597/#motivation It's not clear to me what the "right" encoding is; it depends on whatever encodin

[PATCH v2 0/1] Update check-python-tox test for pylint 2.10

2021-09-14 Thread John Snow
V2: It's not safe to use sys.stderr.encoding to determine a "console encoding", because that uses the "current" stderr and not a hypothetically generic one -- and doing this causes the acceptance tests to fail. Use UTF-8 instead. Question: What encoding do terminal programs use? Is there an inher

Re: ensuring a machine's buses have unique names

2021-09-14 Thread Markus Armbruster
Peter Maydell writes: > On Thu, 26 Aug 2021 at 15:08, Markus Armbruster wrote: >> Peter Maydell writes: >> > What's the right way to ensure that when a machine has multiple >> > buses of the same type (eg multiple i2c controllers, multiple >> > sd card controllers) they all get assigned unique

Re: [PATCH v3 00/22] target/ppc: DFP instructions using decodetree

2021-09-14 Thread David Gibson
On Fri, Sep 10, 2021 at 08:26:02AM -0300, Luis Pires wrote: > This series moves all existing DFP instructions to decodetree and > implements the 2 new instructions (dcffixqq and dctfixqq) from > Power ISA 3.1. > > In order to implement dcffixqq, divu128/divs128 were modified to > support 128-bit q

Re: [PATCH v2 03/22] target/riscv: Implement hgeie and hgeip CSRs

2021-09-14 Thread Alistair Francis
On Thu, Sep 2, 2021 at 9:47 PM Anup Patel wrote: > > The hgeie and hgeip CSRs are required for emulating an external > interrupt controller capable of injecting virtual external > interrupt to Guest/VM running at VS-level. > > Signed-off-by: Anup Patel Reviewed-by: Alistair Francis Alistair >

Re: [PATCH v2 20/53] target/ppc: convert to use format_state instead of dump_state

2021-09-14 Thread David Gibson
On Tue, Sep 14, 2021 at 03:20:09PM +0100, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé Acked-by: David Gibson > --- > target/ppc/cpu.h | 2 +- > target/ppc/cpu_init.c | 212 +- > 2 files changed, 126 insertions(+), 88 deletions(-)

Re: [PATCH v2 50/53] monitor: merge duplicate "info tlb" handlers

2021-09-14 Thread David Gibson
On Tue, Sep 14, 2021 at 03:20:39PM +0100, Daniel P. Berrangé wrote: > Now that all target architectures are converted to use the "format_tlb" > callback, we can merge all the duplicate "info tlb" handlers into one > and remove the architecture condition on the command. > > Signed-off-by: Daniel P.

Re: [PATCH v2 46/53] target/ppc: convert to use format_tlb callback

2021-09-14 Thread David Gibson
On Tue, Sep 14, 2021 at 03:20:35PM +0100, Daniel P. Berrangé wrote: > Change the "info tlb" implementation to use the format_tlb callback. > > Signed-off-by: Daniel P. Berrangé Acked-by: David Gibson > --- > target/ppc/cpu.h| 3 +- > target/ppc/cpu_init.c | 3 + > target/ppc/mmu

Re: [PATCH v2 16/22] hw/riscv: virt: Use AIA INTC compatible string when available

2021-09-14 Thread Alistair Francis
On Thu, Sep 2, 2021 at 9:58 PM Anup Patel wrote: > > We should use the AIA INTC compatible string in the CPU INTC > DT nodes when the CPUs support AIA feature. This will allow > Linux INTC driver to use AIA local interrupt CSRs. > > Signed-off-by: Anup Patel Reviewed-by: Alistair Francis Alist

Re: [PATCH v2 17/22] target/riscv: Allow users to force enable AIA CSRs in HART

2021-09-14 Thread Alistair Francis
On Thu, Sep 2, 2021 at 10:03 PM Anup Patel wrote: > > We add "x-aia" command-line option for RISC-V HART using which > allows users to force enable CPU AIA CSRs without changing the > interrupt controller available in RISC-V machine. > > Signed-off-by: Anup Patel Reviewed-by: Alistair Francis

Re: [PATCH v5 17/31] target/arm: Enforce alignment for LDM/STM

2021-09-14 Thread Nick Desaulniers
On Tue, Sep 7, 2021 at 6:44 AM Richard Henderson wrote: > > On 8/31/21 2:51 AM, Nathan Chancellor wrote: > > I just bisected a boot hang with an LLVM-built multi_v7_defconfig + > > CONFIG_THUMB2_KERNEL=y kernel down to this commit. I do not see the same > > hang when the kernel is compiled with GC

Re: [PATCH v2 02/22] target/riscv: Implement SGEIP bit in hip and hie CSRs

2021-09-14 Thread Alistair Francis
On Thu, Sep 2, 2021 at 9:40 PM Anup Patel wrote: > > A hypervsior can optionally take guest external interrupts using > SGEIP bit of hip and hie CSRs. > > Signed-off-by: Anup Patel Reviewed-by: Alistair Francis Alistair > --- > target/riscv/cpu.c | 3 ++- > target/riscv/cpu_bits.h | 3

Re: [PATCH 1/2] iotests: Fix unspecified-encoding pylint warnings

2021-09-14 Thread John Snow
On Tue, Aug 24, 2021 at 11:47 AM Philippe Mathieu-Daudé wrote: > On 8/24/21 5:35 PM, Hanna Reitz wrote: > > As of recently, pylint complains when `open()` calls are missing an > > `encoding=` specified. Everything we have should be UTF-8 (and in fact, > > everything should be UTF-8, period (exce

Re: [PATCH v2 04/22] target/riscv: Improve fidelity of guest external interrupts

2021-09-14 Thread Alistair Francis
On Tue, Sep 14, 2021 at 2:33 AM Anup Patel wrote: > > On Thu, Sep 9, 2021 at 12:14 PM Alistair Francis wrote: > > > > On Thu, Sep 2, 2021 at 9:26 PM Anup Patel wrote: > > > > > > The guest external interrupts for external interrupt controller are > > > not delivered to the guest running under hy

Re: [PATCH v2 0/2] hw/arm/raspi: Remove deprecated raspi2/raspi3 aliases

2021-09-14 Thread John Snow
On Fri, Aug 27, 2021 at 2:30 PM Philippe Mathieu-Daudé wrote: > On 8/27/21 8:01 PM, Willian Rampazzo wrote: > > Hi, Phil, > > > > On Thu, Aug 26, 2021 at 1:49 PM Philippe Mathieu-Daudé > wrote: > >> > >> Hi Peter, > >> > >> On 7/9/21 6:00 PM, Peter Maydell wrote: > >>> On Fri, 9 Jul 2021 at 16:3

Re: [PATCH] target/riscv: Backup/restore mstatus.SD bit when virtual register swapped

2021-09-14 Thread Alistair Francis
On Tue, Sep 14, 2021 at 11:37 AM wrote: > > From: Frank Chang > > When virtual registers are swapped, mstatus.SD bit should also be > backed up/restored. Otherwise, mstatus.SD bit will be incorrectly kept > across the world switches. > > Signed-off-by: Frank Chang > Reviewed-by: Vincent Chen T

Re: [PATCH] docs/system/riscv: sifive_u: Update U-Boot instructions

2021-09-14 Thread Alistair Francis
On Sun, Sep 12, 2021 at 1:34 AM Bin Meng wrote: > > In U-Boot v2021.07 release, there were 2 major changes for the > SiFive Unleashed board support: > > - Board config name was changed from sifive_fu540_defconfig to > sifive_unleashed_defconfig > - The generic binman tool was used to generate th

Re: [PATCH RFC v2 04/16] vfio-user: connect vfio proxy to remote server

2021-09-14 Thread John Johnson
> On Sep 14, 2021, at 6:06 AM, Stefan Hajnoczi wrote: > > On Mon, Sep 13, 2021 at 05:23:33PM +, John Johnson wrote: On Sep 9, 2021, at 10:25 PM, John Johnson wrote: > On Sep 8, 2021, at 11:29 PM, Stefan Hajnoczi wrote: > On Thu, Sep 09, 2021 at 05:11:49AM +, John Jo

Re: [PATCH] target/riscv: Backup/restore mstatus.SD bit when virtual register swapped

2021-09-14 Thread Alistair Francis
On Tue, Sep 14, 2021 at 11:37 AM wrote: > > From: Frank Chang > > When virtual registers are swapped, mstatus.SD bit should also be > backed up/restored. Otherwise, mstatus.SD bit will be incorrectly kept > across the world switches. > > Signed-off-by: Frank Chang > Reviewed-by: Vincent Chen R

Re: [PATCH] docs/system/riscv: sifive_u: Update U-Boot instructions

2021-09-14 Thread Alistair Francis
On Sun, Sep 12, 2021 at 1:34 AM Bin Meng wrote: > > In U-Boot v2021.07 release, there were 2 major changes for the > SiFive Unleashed board support: > > - Board config name was changed from sifive_fu540_defconfig to > sifive_unleashed_defconfig > - The generic binman tool was used to generate th

RE: [RFC v2 0/2] ui: Add a Wayland backend for Qemu UI (v2)

2021-09-14 Thread Kasireddy, Vivek
Hi Daniel, > On Mon, Sep 13, 2021 at 03:20:34PM -0700, Vivek Kasireddy wrote: > > Why does Qemu need a new Wayland UI backend? > > The main reason why there needs to be a plain and simple Wayland backend > > for Qemu UI is to eliminate the Blit (aka GPU copy) that happens if using > > a toolkit li

RE: [RFC v2 2/2] ui: Add a plain Wayland backend for Qemu UI

2021-09-14 Thread Kasireddy, Vivek
Hi Daniel, > On Mon, Sep 13, 2021 at 03:20:36PM -0700, Vivek Kasireddy wrote: > > Cc: Gerd Hoffmann > > Signed-off-by: Vivek Kasireddy > > --- > > configure | 8 +- > > meson.build | 33 +++ > > meson_options.txt | 2 + > > qapi/ui.json | 3 + > > ui/meson.build|

Re: [PATCH v4 05/16] tcg/s390x: Implement tcg_out_ld/st for vector types

2021-09-14 Thread Richard Henderson
On 9/14/21 3:03 PM, Richard Henderson wrote: On 9/14/21 9:46 AM, David Hildenbrand wrote: +    if (likely(data < 16)) { This actually maps to "if (likely(data <= TCG_REG_R15))", correct? Sure. I'm going to add is_general_reg and is_vector_reg predicates. r~

RE: [PULL 0/6] Vga 20210910 patches

2021-09-14 Thread Kasireddy, Vivek
Hi Gerd, Peter, > > On Fri, Sep 10, 2021 at 05:52:55PM +0100, Peter Maydell wrote: > > On Fri, 10 Sept 2021 at 14:19, Gerd Hoffmann wrote: > > > > > > The following changes since commit > > > bd662023e683850c085e98c8ff8297142c2dd9f2: > > > > > > Merge remote-tracking branch > > > 'remotes/mca

Re: [PATCH v4 05/16] tcg/s390x: Implement tcg_out_ld/st for vector types

2021-09-14 Thread Richard Henderson
On 9/14/21 9:46 AM, David Hildenbrand wrote: +    if (likely(data < 16)) { This actually maps to "if (likely(data <= TCG_REG_R15))", correct? Sure. r~

Re: [PATCH v4 05/16] tcg/s390x: Implement tcg_out_ld/st for vector types

2021-09-14 Thread Richard Henderson
On 9/14/21 9:46 AM, David Hildenbrand wrote: +static void tcg_out_insn_VRX(TCGContext *s, S390Opcode op, TCGReg v1, + TCGReg b2, TCGReg x2, intptr_t d2, int m3) Is intptr_t really the right type here? Just curious ... I'd have used an uint16_t and asserted "!(d1 & 0

[PATCH v6 2/5] ui/egl: Add egl helpers to help with synchronization

2021-09-14 Thread Vivek Kasireddy
These egl helpers would be used for creating and waiting on a sync object. Cc: Gerd Hoffmann Reviewed-by: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- include/ui/console.h | 2 ++ include/ui/egl-helpers.h | 2 ++ ui/egl-helpers.c | 26 ++ 3 files chang

[PATCH v6 5/5] virtio-gpu: Add gl_flushed callback

2021-09-14 Thread Vivek Kasireddy
Adding this callback provides a way to resume the processing of cmds in fenceq and cmdq that were not processed because the UI was waiting on a fence and blocked cmd processing. Cc: Gerd Hoffmann Reviewed-by: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- hw/display/virtio-gpu.c | 32 +++

[PATCH v6 4/5] ui/gtk-egl: Wait for the draw signal for dmabuf blobs

2021-09-14 Thread Vivek Kasireddy
Instead of immediately drawing and submitting, queue and wait for the draw signal if the dmabuf submitted is a blob. Cc: Gerd Hoffmann Reviewed-by: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- include/ui/gtk.h | 2 ++ ui/gtk-egl.c | 15 +++ ui/gtk.c | 2 +- 3 file

[PATCH v6 1/5] ui/gtk: Create a common release_dmabuf helper

2021-09-14 Thread Vivek Kasireddy
Since the texture release mechanism is same for both gtk-egl and gtk-glarea, move the helper from gtk-egl to common gtk code so that it can be shared by both gtk backends. Cc: Gerd Hoffmann Reviewed-by: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- include/ui/gtk.h | 2 -- ui/gtk-egl.c

[PATCH v6 0/5] virtio-gpu: Add a default synchronization mechanism for blobs (v6)

2021-09-14 Thread Vivek Kasireddy
When the Guest and Host are using Blob resources, there is a chance that they may use the underlying storage associated with a Blob at the same time leading to glitches such as flickering or tearing. To prevent these from happening, the Host needs to ensure that it waits until its Blit is completed

[PATCH v6 3/5] ui: Create sync objects and fences only for blobs

2021-09-14 Thread Vivek Kasireddy
Create sync objects and fences only for dmabufs that are blobs. Once a fence is created (after glFlush) and is signalled, graphic_hw_gl_flushed() will be called and virtio-gpu cmd processing will be resumed. Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- hw/display/virtio-gpu-udmabuf.c |

[PATCH RFC 10/13] hw/nvme: add experimental object x-nvme-subsystem

2021-09-14 Thread Klaus Jensen
From: Klaus Jensen Add a basic user creatable object that models an NVMe NVM subsystem. Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 26 +++--- hw/nvme/ns.c | 5 +- hw/nvme/nvme.h | 30 hw/nvme/subsys.c | 121 +++ qap

[PATCH RFC 11/13] hw/nvme: add experimental abstract object x-nvme-ns

2021-09-14 Thread Klaus Jensen
From: Klaus Jensen Add the abstract NvmeNamespace object to base proper namespace types on. Signed-off-by: Klaus Jensen --- hw/nvme/ns.c | 286 +++ hw/nvme/nvme.h | 24 hw/nvme/subsys.c | 31 + qapi/qom.json| 18 +++ 4 files cha

[PATCH RFC 09/13] hw/nvme: add experimental device x-nvme-ctrl

2021-09-14 Thread Klaus Jensen
From: Klaus Jensen Add a new experimental 'x-nvme-ctrl' device which allows us to get rid of a bunch of legacy options and slightly change others to better use the qdev property system. Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 111 + hw/n

[PATCH RFC 13/13] hw/nvme: add attached-namespaces prop

2021-09-14 Thread Klaus Jensen
From: Klaus Jensen Add a runtime property to get a list of attached namespaces per controller. Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 24 1 file changed, 24 insertions(+) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index 04e564ad6be6..ed867384e40a 100644 --

[PATCH RFC 08/13] hw/nvme: hoist qdev state from controller

2021-09-14 Thread Klaus Jensen
From: Klaus Jensen Add an abstract object NvmeState. Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 382 +-- hw/nvme/dif.c| 4 +- hw/nvme/dif.h| 2 +- hw/nvme/ns.c | 4 +- hw/nvme/nvme.h | 52 --- hw/nvme/subsys.c | 4 +

[PATCH RFC 05/13] hw/nvme: move BlockBackend to NvmeNamespaceNvm

2021-09-14 Thread Klaus Jensen
From: Klaus Jensen Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 66 +- hw/nvme/dif.c | 14 +-- hw/nvme/nvme.h | 6 + 3 files changed, 46 insertions(+), 40 deletions(-) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index 7f41181aa

[PATCH RFC 12/13] hw/nvme: add experimental objects x-nvme-ns-{nvm, zoned}

2021-09-14 Thread Klaus Jensen
From: Klaus Jensen Add implementations of namespaces that supports the NVM and Zoned Command Sets. Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 11 +- hw/nvme/dif.h | 2 + hw/nvme/meson.build | 2 +- hw/nvme/ns-nvm.c| 360 +++ hw/nvme/ns-

[PATCH RFC 07/13] hw/nvme: hoist qdev state from namespace

2021-09-14 Thread Klaus Jensen
From: Klaus Jensen Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 32 +++--- hw/nvme/ns.c | 265 ++--- hw/nvme/nvme.h | 45 ++--- 3 files changed, 187 insertions(+), 155 deletions(-) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index f05d85

[PATCH RFC 02/13] hw/nvme: move zns helpers and types into zoned.h

2021-09-14 Thread Klaus Jensen
From: Klaus Jensen Move ZNS related helpers and types into zoned.h. Use a common prefix (nvme_zoned or nvme_ns_zoned) for zns related functions. Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 92 -- hw/nvme/ns.c| 39 ++-- hw/nv

[PATCH RFC 03/13] hw/nvme: move zoned namespace members to separate struct

2021-09-14 Thread Klaus Jensen
From: Klaus Jensen In preparation for nvm and zoned namespace separation, move zoned related members from NvmeNamespace into NvmeNamespaceZoned. There are no functional changes here, basically just a s/NvmeNamespace/NvmeNamespaceZoned and s/ns/zoned where applicable. Signed-off-by: Klaus Jensen

[PATCH RFC 06/13] nvme: add structured type for nguid

2021-09-14 Thread Klaus Jensen
From: Klaus Jensen Add a structured type for NGUID. Signed-off-by: Klaus Jensen --- include/block/nvme.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/include/block/nvme.h b/include/block/nvme.h index 2bcabe561589..f41464ee19bd 100644 --- a/include/block/nvme.h +++

[PATCH RFC 01/13] hw/nvme: move dif/pi prototypes into dif.h

2021-09-14 Thread Klaus Jensen
From: Klaus Jensen Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 1 + hw/nvme/dif.c | 1 + hw/nvme/dif.h | 53 ++ hw/nvme/nvme.h | 50 --- 4 files changed, 55 insertions(+), 50 deletions(-) creat

[PATCH RFC 04/13] hw/nvme: move nvm namespace members to separate struct

2021-09-14 Thread Klaus Jensen
From: Klaus Jensen Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 282 +++-- hw/nvme/dif.c | 101 +- hw/nvme/dif.h | 12 +-- hw/nvme/ns.c | 72 +++-- hw/nvme/nvme.h | 45 +--- 5 files changed, 290 insertions(+), 22

[PATCH RFC 00/13] hw/nvme: experimental user-creatable objects

2021-09-14 Thread Klaus Jensen
From: Klaus Jensen Hi, This is an attempt at adressing a bunch of issues that have presented themselves since we added subsystem support. It's been brewing for a while now. Fundamentally, I've come to the conclusion that modeling namespaces and subsystems as "devices" is wrong. They should have

Re: [PATCH 04/20] nubus: use bitmap to manage available slots

2021-09-14 Thread Mark Cave-Ayland
On 12/09/2021 18:48, Philippe Mathieu-Daudé wrote: On 9/12/21 9:48 AM, Mark Cave-Ayland wrote: Convert nubus_device_realize() to use a bitmap to manage available slots to allow for future Nubus devices to be plugged into arbitrary slots from the command line. Update mac_nubus_bridge_init() t

Re: [PATCH 16/20] nubus-bridge: embed the NubusBus object directly within nubus-bridge

2021-09-14 Thread Mark Cave-Ayland
On 12/09/2021 18:43, Philippe Mathieu-Daudé wrote: On 9/12/21 9:49 AM, Mark Cave-Ayland wrote: Since nubus-bridge is a container for NubusBus then it should be embedded directly within the bridge device using qbus_create_inplace(). Signed-off-by: Mark Cave-Ayland --- hw/m68k/q800.c

Re: [PATCH 11/20] nubus-device: add romfile property for loading declaration ROMs

2021-09-14 Thread Mark Cave-Ayland
On 12/09/2021 18:39, Philippe Mathieu-Daudé wrote: On 9/12/21 9:49 AM, Mark Cave-Ayland wrote: The declaration ROM is located at the top-most address of the standard slot space. Signed-off-by: Mark Cave-Ayland --- hw/nubus/nubus-device.c | 43 +++- incl

Re: question on vhost, limiting kernel threads and NPROC

2021-09-14 Thread Christian Brauner
On Mon, Sep 13, 2021 at 05:32:32PM -0400, Michael S. Tsirkin wrote: > On Mon, Sep 13, 2021 at 12:04:04PM -0500, Mike Christie wrote: > > I just realized I forgot to cc the virt list so adding now. > > > > Christian see the very bottom for a different fork patch. > > > > On 7/12/21 7:05 AM, Stefan

Re: [PATCH v2 44/53] target/m68k: convert to use format_tlb callback

2021-09-14 Thread Laurent Vivier
Le 14/09/2021 à 16:20, Daniel P. Berrangé a écrit : > Change the "info tlb" implementation to use the format_tlb callback. > > Signed-off-by: Daniel P. Berrangé > --- > target/m68k/cpu.c | 3 + > target/m68k/cpu.h | 3 +- > target/m68k/helper.c | 132 ++--

Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure

2021-09-14 Thread Willian Rampazzo
On Tue, Sep 14, 2021 at 4:18 PM Peter Maydell wrote: > > On Mon, 13 Sept 2021 at 11:19, Peter Maydell wrote: > > > > Currently we define a lot of jobs for our custom runners: > > for both aarch64 and s390x we have > > - all-linux-static > > - all > > - alldbg > > - clang (manual) > > - tci >

Re: [PATCH v2 15/53] target/m68k: convert to use format_state instead of dump_state

2021-09-14 Thread Laurent Vivier
Le 14/09/2021 à 16:20, Daniel P. Berrangé a écrit : > Signed-off-by: Daniel P. Berrangé > --- > target/m68k/cpu.c | 2 +- > target/m68k/cpu.h | 2 +- > target/m68k/translate.c | 92 ++--- > 3 files changed, 51 insertions(+), 45 deletions(-) > > d

Re: [PATCH v6 3/6] spapr: introduce spapr_numa_associativity_reset()

2021-09-14 Thread Daniel Henrique Barboza
On 9/14/21 08:55, Greg Kurz wrote: On Fri, 10 Sep 2021 16:55:36 -0300 Daniel Henrique Barboza wrote: Introducing a new NUMA affinity, FORM2, requires a new mechanism to switch between affinity modes after CAS. Also, we want FORM2 data structures and functions to be completely separated from

Re: [PATCH v2 20/53] target/ppc: convert to use format_state instead of dump_state

2021-09-14 Thread Greg Kurz
On Tue, 14 Sep 2021 15:20:09 +0100 Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- Acked-by: Greg Kurz > target/ppc/cpu.h | 2 +- > target/ppc/cpu_init.c | 212 +- > 2 files changed, 126 insertions(+), 88 deletions(-) > > di

[PULL v4 00/43] tcg patch queue

2021-09-14 Thread Richard Henderson
b.com/rth7680/qemu.git tags/pull-tcg-20210914-4 for you to fetch changes up to e028eada62dbfcba134ac5afdefc3aa343ae202f: tcg/arm: More use of the TCGReg enum (2021-09-14 12:00:21 -0700) Fix translation race condition for user-only

[PATCH v4 00/43] tcg patch queue

2021-09-14 Thread Richard Henderson
b.com/rth7680/qemu.git tags/pull-tcg-20210914-4 for you to fetch changes up to e028eada62dbfcba134ac5afdefc3aa343ae202f: tcg/arm: More use of the TCGReg enum (2021-09-14 12:00:21 -0700) Fix translation race condition for user-only

Re: [PATCH v2 06/53] hw/core: introduce 'format_state' callback to replace 'dump_state'

2021-09-14 Thread Greg Kurz
On Tue, 14 Sep 2021 15:19:55 +0100 Daniel P. Berrangé wrote: > The 'dump_state' callback assumes it will be outputting to a FILE > object. This is fine for HMP, but not so useful for QMP. Introduce > a new 'format_state' callback that returns a formatted GString > instead. > > Signed-off-by: Dan

Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure

2021-09-14 Thread Peter Maydell
On Mon, 13 Sept 2021 at 11:19, Peter Maydell wrote: > > Currently we define a lot of jobs for our custom runners: > for both aarch64 and s390x we have > - all-linux-static > - all > - alldbg > - clang (manual) > - tci > - notcg (manual) > > This is overkill. The main reason to run on these

Re: [PULL 0/5] Misc patches

2021-09-14 Thread Peter Maydell
On Tue, 14 Sept 2021 at 14:01, wrote: > > From: Marc-André Lureau > > The following changes since commit c6f5e042d89e79206cd1ce5525d3df219f13c3cc: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20210913-3' into staging (2021-09-13 > 21:06:15 +0100) > > are available

Re: [PATCH v2] nbd/server: Suppress Broken pipe errors on abrupt disconnection

2021-09-14 Thread Eric Blake
[IOn Tue, Sep 14, 2021 at 03:52:00PM +0100, Richard W.M. Jones wrote: > On Tue, Sep 14, 2021 at 05:40:59PM +0300, Vladimir Sementsov-Ogievskiy wrote: > > 13.09.2021 18:19, Richard W.M. Jones wrote: > > >$ rm -f /tmp/sock /tmp/pid > > >$ qemu-img create -f qcow2 /tmp/disk.qcow2 1M > > >$ qemu-nbd -t

[PATCH 2/2] gitlab: Add cross-riscv64-system, cross-riscv64-user

2021-09-14 Thread Richard Henderson
Signed-off-by: Richard Henderson --- .gitlab-ci.d/crossbuilds.yml | 14 ++ 1 file changed, 14 insertions(+) diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml index f10168db2e..0fe4a55ac5 100644 --- a/.gitlab-ci.d/crossbuilds.yml +++ b/.gitlab-ci.d/crossbuilds.y

Re: [PATCH v2] nbd/server: Suppress Broken pipe errors on abrupt disconnection

2021-09-14 Thread Eric Blake
On Tue, Sep 14, 2021 at 05:40:59PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 13.09.2021 18:19, Richard W.M. Jones wrote: > > $ rm -f /tmp/sock /tmp/pid > > $ qemu-img create -f qcow2 /tmp/disk.qcow2 1M > > $ qemu-nbd -t --format=qcow2 --socket=/tmp/sock --pid-file=/tmp/pid > > /tmp/disk.qcow2 &

[PATCH 0/2] gitlab-ci: Add riscv64 cross builds

2021-09-14 Thread Richard Henderson
The only tcg host that does not have build coverage is riscv64. Filling this hole will help with tcg reorgs I have in the works. Thanks to Alex for help debugging the docker image creation. r~ Alex Bennée (1): tests/docker: promote debian-riscv64-cross to a full image Richard Henderson (1):

[PATCH 1/2] tests/docker: promote debian-riscv64-cross to a full image

2021-09-14 Thread Richard Henderson
From: Alex Bennée To be able to cross build QEMU itself we need to include a few more libraries. These are only available in Debian's unstable ports repo for now so we need to base the riscv64 image on sid with the the minimal libs needed to build QEMU (glib/pixman). The result works but is not

[RFC 1/1] docs/deve/ci-plan: define a high-level plan for the QEMU GitLab CI

2021-09-14 Thread Willian Rampazzo
This adds a high-level plan for the QEMU GitLab CI based on use cases. The idea is to have a base for evolving the QEMU CI. It sets high-level characteristics for the QEMU CI use cases, which helps guide its development. Signed-off-by: Willian Rampazzo --- docs/devel/ci-plan.rst | 77 +++

[RFC 0/1] docs/deve/ci-plan: define a high-level plan for the QEMU GitLab CI

2021-09-14 Thread Willian Rampazzo
This adds a high-level plan for the QEMU GitLab CI based on use cases. The idea is to have a base for evolving the QEMU CI. It sets high-level characteristics for the QEMU CI use cases, which helps guide its development. There is an opportunity to discuss the high-level QEMU CI plan and some of th

Re: [PATCH v4 08/16] tcg/s390x: Implement minimal vector operations

2021-09-14 Thread David Hildenbrand
On 26.06.21 07:02, Richard Henderson wrote: Implementing add, sub, and, or, xor as the minimal set. This allows us to actually enable vectors in query_s390_facilities. Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target.c.inc | 154 - 1 file changed,

Re: [PATCH v4 12/16] tcg/s390x: Implement TCG_TARGET_HAS_minmax_vec

2021-09-14 Thread David Hildenbrand
On 26.06.21 07:03, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target.h | 2 +- tcg/s390x/tcg-target.c.inc | 25 + 2 files changed, 26 insertions(+), 1 deletion(-) Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb

Re: [PATCH v4 11/16] tcg/s390x: Implement vector shift operations

2021-09-14 Thread David Hildenbrand
On 26.06.21 07:03, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target-con-set.h | 1 + tcg/s390x/tcg-target.h | 12 ++--- tcg/s390x/tcg-target.c.inc | 93 +- 3 files changed, 99 insertions(+), 7 deletions(-) Revie

Re: [PATCH v4 10/16] tcg/s390x: Implement TCG_TARGET_HAS_mul_vec

2021-09-14 Thread David Hildenbrand
On 26.06.21 07:03, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target.h | 2 +- tcg/s390x/tcg-target.c.inc | 7 +++ 2 files changed, 8 insertions(+), 1 deletion(-) Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb

Re: [PATCH v4 09/16] tcg/s390x: Implement andc, orc, abs, neg, not vector operations

2021-09-14 Thread David Hildenbrand
On 26.06.21 07:03, Richard Henderson wrote: These logical and arithmetic operations are optional but trivial. Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target-con-set.h | 1 + tcg/s390x/tcg-target.h | 10 +- tcg/s390x/tcg-target.c.inc | 34 +

Re: [PULL v3 00/44] tcg patch queue

2021-09-14 Thread Philippe Mathieu-Daudé
25d3df219f13c3cc: >> >> Merge remote-tracking branch >> 'remotes/pmaydell/tags/pull-target-arm-20210913-3' into staging (2021-09-13 >> 21:06:15 +0100) >> >> are available in the Git repository at: >> >> https://gitlab.com/rth7680/qemu.git t

Re: [PATCH v4 05/12] job: @force parameter for job_cancel_sync()

2021-09-14 Thread Hanna Reitz
On 08.09.21 18:33, Vladimir Sementsov-Ogievskiy wrote: 07.09.2021 15:42, Hanna Reitz wrote: Callers should be able to specify whether they want job_cancel_sync() to force-cancel the job or not. In fact, almost all invocations do not care about consistency of the result and just want the job to

Re: [PATCH v2 29/53] qapi: introduce x-query-registers QMP command

2021-09-14 Thread Philippe Mathieu-Daudé
On 9/14/21 6:04 PM, Eric Blake wrote: > On Tue, Sep 14, 2021 at 03:20:18PM +0100, Daniel P. Berrangé wrote: >> This is a counterpart to the HMP "info registers" command. It is being >> added with an "x-" prefix because this QMP command is intended as an >> ad hoc debugging tool and will thus not be

Re: [PATCH v2 29/53] qapi: introduce x-query-registers QMP command

2021-09-14 Thread Philippe Mathieu-Daudé
On 9/14/21 7:15 PM, Philippe Mathieu-Daudé wrote: > On 9/14/21 6:04 PM, Eric Blake wrote: >> On Tue, Sep 14, 2021 at 03:20:18PM +0100, Daniel P. Berrangé wrote: >>> This is a counterpart to the HMP "info registers" command. It is being >>> added with an "x-" prefix because this QMP command is inten

Re: [PATCH v2 42/53] hw/core: introduce a 'format_tlb' callback

2021-09-14 Thread Daniel P . Berrangé
On Tue, Sep 14, 2021 at 07:02:19PM +0200, Philippe Mathieu-Daudé wrote: > On 9/14/21 6:34 PM, Daniel P. Berrangé wrote: > > On Tue, Sep 14, 2021 at 05:56:09PM +0200, Philippe Mathieu-Daudé wrote: > >> On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: > >>> This will allow us to reduce duplication betwe

Re: [PATCH v4 07/10] qcow2-refcount: check_refcounts_l2(): check reserved bits

2021-09-14 Thread Hanna Reitz
On 14.09.21 14:24, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Tested-by: Kirill Tkhai Reviewed-by: Hanna Reitz --- block/qcow2.h | 1 + block/qcow2-refcount.c | 12 +++- 2 files changed, 12 insertions(+), 1 del

Re: [PULL v3 00/44] tcg patch queue

2021-09-14 Thread Peter Maydell
/tags/pull-target-arm-20210913-3' into staging (2021-09-13 > 21:06:15 +0100) > > are available in the Git repository at: > > https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20210914 > > for you to fetch changes up to a5b759b6dca7daf87fa5007a7f5784bf22f3830f: >

Re: [PATCH v4 06/10] qcow2-refcount: check_refcounts_l2(): check l2_bitmap

2021-09-14 Thread Hanna Reitz
On 14.09.21 14:24, Vladimir Sementsov-Ogievskiy wrote: Check subcluster bitmap of the l2 entry for different types of clusters: - for compressed it must be zero - for allocated check consistency of two parts of the bitmap - for unallocated all subclusters should be unallocated (or zero

Re: [PATCH v3 00/17] iotests: support zstd

2021-09-14 Thread Hanna Reitz
On 14.09.21 12:25, Vladimir Sementsov-Ogievskiy wrote: These series makes tests pass with IMGOPTS='compression_type=zstd' Also, python iotests start to support IMGOPTS (they didn't before). v3: 02-04,06,08,14,17: add Hanna's r-b 07 iotests.py: filter out successful output of qemu-img crea

Re: [PATCH v3 07/17] iotests.py: filter out successful output of qemu-img create

2021-09-14 Thread Hanna Reitz
On 14.09.21 12:25, Vladimir Sementsov-Ogievskiy wrote: The only "feature" of this "Formatting ..." line is that we have to update it every time we add new option. Let's drop it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/149.out| 21 - tests/qe

Re: [PATCH v2 42/53] hw/core: introduce a 'format_tlb' callback

2021-09-14 Thread Philippe Mathieu-Daudé
On 9/14/21 6:34 PM, Daniel P. Berrangé wrote: > On Tue, Sep 14, 2021 at 05:56:09PM +0200, Philippe Mathieu-Daudé wrote: >> On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: >>> This will allow us to reduce duplication between the different targets >>> implementing the 'info tlb' command. >>> >>> Signed

Re: [PATCH v4 06/16] tcg/s390x: Implement tcg_out_mov for vector types

2021-09-14 Thread David Hildenbrand
On 14.09.21 18:53, David Hildenbrand wrote: On 26.06.21 07:02, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target.c.inc | 72 +++--- 1 file changed, 68 insertions(+), 4 deletions(-) diff --git a/tcg/s390x/tcg-target.c.inc b/t

Re: [PATCH v4 06/16] tcg/s390x: Implement tcg_out_mov for vector types

2021-09-14 Thread David Hildenbrand
On 26.06.21 07:02, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target.c.inc | 72 +++--- 1 file changed, 68 insertions(+), 4 deletions(-) diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc index b6ea129e14..c4e

Re: [PATCH v4 05/16] tcg/s390x: Implement tcg_out_ld/st for vector types

2021-09-14 Thread David Hildenbrand
On 26.06.21 07:02, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target.c.inc | 122 + 1 file changed, 110 insertions(+), 12 deletions(-) diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc index 18233c628d..b

Re: [PATCH v2 30/53] qapi: introduce x-query-roms QMP command

2021-09-14 Thread Daniel P . Berrangé
On Tue, Sep 14, 2021 at 06:04:48PM +0200, Philippe Mathieu-Daudé wrote: > On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: > > This is a counterpart to the HMP "info roms" command. It is being > > added with an "x-" prefix because this QMP command is intended as an > > adhoc debugging tool and will th

Re: [PATCH v2 42/53] hw/core: introduce a 'format_tlb' callback

2021-09-14 Thread Daniel P . Berrangé
On Tue, Sep 14, 2021 at 05:56:09PM +0200, Philippe Mathieu-Daudé wrote: > On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: > > This will allow us to reduce duplication between the different targets > > implementing the 'info tlb' command. > > > > Signed-off-by: Daniel P. Berrangé > > --- > > hw/cor

Re: [PATCH v2] nbd/server: Suppress Broken pipe errors on abrupt disconnection

2021-09-14 Thread Richard W.M. Jones
On Tue, Sep 14, 2021 at 06:21:58PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 14.09.2021 17:52, Richard W.M. Jones wrote: > > On the > >server side when the server receives NBD_CMD_DISC it must complete any > >in-flight requests, but there's no requirement for the server to > >commit anything to

Re: [RFC v2 0/2] ui: Add a Wayland backend for Qemu UI (v2)

2021-09-14 Thread Daniel P . Berrangé
On Mon, Sep 13, 2021 at 03:20:34PM -0700, Vivek Kasireddy wrote: > Why does Qemu need a new Wayland UI backend? > The main reason why there needs to be a plain and simple Wayland backend > for Qemu UI is to eliminate the Blit (aka GPU copy) that happens if using > a toolkit like GTK or SDL (because

Re: [PATCH v4 04/16] tcg/s390x: Add host vector framework

2021-09-14 Thread David Hildenbrand
On 26.06.21 07:02, Richard Henderson wrote: Add registers and function stubs. The functionality is disabled via squashing s390_facilities[2] to 0. We must still include results for the mandatory opcodes in tcg_target_op_def, as all opcodes are checked during tcg init. Signed-off-by: Richard He

Re: [RFC v2 2/2] ui: Add a plain Wayland backend for Qemu UI

2021-09-14 Thread Daniel P . Berrangé
On Mon, Sep 13, 2021 at 03:20:36PM -0700, Vivek Kasireddy wrote: > Cc: Gerd Hoffmann > Signed-off-by: Vivek Kasireddy > --- > configure | 8 +- > meson.build | 33 +++ > meson_options.txt | 2 + > qapi/ui.json | 3 + > ui/meson.build| 52 > ui/wayland.c |

Re: [PATCH v2 30/53] qapi: introduce x-query-roms QMP command

2021-09-14 Thread Philippe Mathieu-Daudé
On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: > This is a counterpart to the HMP "info roms" command. It is being > added with an "x-" prefix because this QMP command is intended as an > adhoc debugging tool and will thus not be modelled in QAPI as fully > structured data, nor will it have long ter

Re: [PATCH v2 42/53] hw/core: introduce a 'format_tlb' callback

2021-09-14 Thread Philippe Mathieu-Daudé
On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: > This will allow us to reduce duplication between the different targets > implementing the 'info tlb' command. > > Signed-off-by: Daniel P. Berrangé > --- > hw/core/cpu-common.c | 9 + > include/hw/core/cpu.h | 11 +++ > 2 files ch

Re: [PATCH v2 29/53] qapi: introduce x-query-registers QMP command

2021-09-14 Thread Eric Blake
On Tue, Sep 14, 2021 at 03:20:18PM +0100, Daniel P. Berrangé wrote: > This is a counterpart to the HMP "info registers" command. It is being > added with an "x-" prefix because this QMP command is intended as an > ad hoc debugging tool and will thus not be modelled in QAPI as fully > structured dat

Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure

2021-09-14 Thread Peter Maydell
On Mon, 13 Sept 2021 at 11:19, Peter Maydell wrote: > > Currently we define a lot of jobs for our custom runners: > for both aarch64 and s390x we have > - all-linux-static > - all > - alldbg > - clang (manual) > - tci > - notcg (manual) > > This is overkill. The main reason to run on these

[PATCH 2/3] gdbstub: implement NOIRQ support for single step on KVM

2021-09-14 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- accel/kvm/kvm-all.c | 25 ++ gdbstub.c| 60 include/sysemu/kvm.h | 13 ++ 3 files changed, 88 insertions(+), 10 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c

[PATCH 1/3] KVM: use KVM_{GET|SET}_SREGS2 when supported.

2021-09-14 Thread Maxim Levitsky
This allows to make PDPTRs part of the migration stream and thus not reload them after migration which is against X86 spec. Signed-off-by: Maxim Levitsky --- accel/kvm/kvm-all.c | 5 ++ include/sysemu/kvm.h | 4 ++ target/i386/cpu.h | 3 ++ target/i386/kvm/kvm.c | 107 ++

Re: [RFC PATCH 3/3] tests/tcg: commit Makefile atrocities in the name of portability

2021-09-14 Thread Warner Losh
On Tue, Aug 3, 2021 at 5:02 AM Alex Bennée wrote: > Not all of the multiarch tests are pure POSIX so elide over those > tests on a non-Linux system. This allows for at least some of the > tests to be nominally usable by *BSD user builds. > > Signed-off-by: Alex Bennée > Cc: Warner Losh > --- >

  1   2   3   4   >