[Bug 1905521] Re: assert issue locates in hw/scsi/lsi53c895a.c:624: lsi_do_dma: Assertion `s->current' failed

2021-08-20 Thread Thomas Huth
** Changed in: qemu Assignee: Gaoning Pan (hades0506) => (unassigned) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1905521 Title: assert issue locates in hw/scsi/lsi53c895a.c:624: lsi_do_dma:

[Bug 1914117] Re: Short files returned via FTP on Qemu with various architectures and OSes

2021-08-20 Thread Thomas Huth
slirp has been updated for QEMU 6.1-rc2, so this should be fixed in the latest 6.1 release candidate. If you've got some spare minutes, could you please check whether it's working for you now in 6.1-rc4 ? ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug no

[Bug 1921664] Re: Coroutines are racy for risc64 emu on arm64 - crash on Assertion

2021-08-20 Thread Thomas Huth
@Christian & Tommy : Could you please check whether the problematic binaries were built with link-time optimization, i.e. with -flto ? If so, does the problem go away when you rebuild the package without LTO? ** Changed in: qemu Status: New => Incomplete ** Changed in: qemu (Ubuntu)

[Bug 1878057] Re: null-ptr dereference in megasas_command_complete

2021-08-20 Thread Thomas Huth
Thanks for moving it over! ... let's close this one here on Launchpad now. ** Changed in: qemu Status: Incomplete => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1878057 Title: nu

[Bug 1913667] Re: FPE in npcm7xx_clk_update_pll

2021-08-20 Thread Thomas Huth
Thanks for moving it over! ... let's close this one here on Launchpad now. ** Changed in: qemu Status: Confirmed => Incomplete ** Changed in: qemu Status: Incomplete => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed t

[Bug 1913669] Re: FPE in npcm7xx_adc_convert

2021-08-20 Thread Thomas Huth
Thanks for moving it over! ... let's close this one here on Launchpad now. ** Changed in: qemu Status: Confirmed => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1913669 Title: FPE

[Bug 1918321] Re: [OSS-Fuzz] Issue 31875 megasas: Null-ptr dereference in megasas_finish_dcmd

2021-08-20 Thread Thomas Huth
Thanks for moving it over! ... let's close this one here on Launchpad now. ** Changed in: qemu Status: Confirmed => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1918321 Title: [OS

Re: [PATCH v3 02/16] tcg/mips: Support unaligned access for softmmu

2021-08-20 Thread Jiaxun Yang
在2021年8月19日八月 上午4:19,Richard Henderson写道: > We can use the routines just added for user-only to emit > unaligned accesses in softmmu mode too. > > Signed-off-by: Richard Henderson Reviewed-by: Jiaxun Yang Thanks! > --- > tcg/mips/tcg-target.c.inc | 91 ++

[Bug 1917082] Re: [OSS-Fuzz] Issue 27574 e1000: Loopback-related stack-overflow

2021-08-20 Thread Thomas Huth
Thanks for moving it over! ... let's close this one here on Launchpad now. ** Changed in: qemu Status: Confirmed => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1917082 Title: [OS

[Bug 1911216] Re: abort issue locates in hw/usb/hcd-ohci.c:1297:ohci_frame_boundary

2021-08-20 Thread Thomas Huth
Thanks for moving it over! ... let's close this one here on Launchpad now. ** Changed in: qemu Status: Confirmed => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1911216 Title: abo

[Bug 1914638] Re: [OSS-Fuzz] Issue 30219: Global-buffer-overflow in mode_sense_page

2021-08-20 Thread Thomas Huth
Thanks for moving it over! ... let's close this one here on Launchpad now. ** Changed in: qemu Status: Confirmed => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1914638 Title: [OS

[Bug 1891354] Re: Heap-use-after-free in usb_packet_unmap

2021-08-20 Thread Thomas Huth
Thanks for moving it over! ... let's close this one here on Launchpad now. ** Changed in: qemu Status: Confirmed => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1891354 Title: Hea

[Bug 1890155] Re: Abort in vmxnet3_validate_interrupt_idx

2021-08-20 Thread Thomas Huth
Thanks for moving it over! ... let's close this one here on Launchpad now. ** Changed in: qemu Status: Confirmed => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1890155 Title: Abo

[Bug 1892963] Re: Heap-use-after-free in put_dwords through ehci_flush_qh

2021-08-20 Thread Thomas Huth
Thanks for moving it over! ... let's close this one here on Launchpad now. ** Changed in: qemu Status: Confirmed => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1892963 Title: Hea

[Bug 1907938] Re: [OSS-Fuzz] Issue 28524 virtio-blk: ASSERT: !s->dataplane_started

2021-08-20 Thread Thomas Huth
Thanks for moving it over! ... let's close this one here on Launchpad now. ** Changed in: qemu Status: Confirmed => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1907938 Title: [OS

[Bug 1907497] Re: [OSS-Fuzz] Issue 28435 qemu:qemu-fuzz-i386-target-generic-fuzz-intel-hda: Stack-overflow in ldl_le_dma

2021-08-20 Thread Thomas Huth
Thanks for moving it over! ... let's close this one here on Launchpad now. ** Changed in: qemu Status: Confirmed => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1907497 Title: [OS

[Bug 1909261] Re: [OSS-Fuzz] Issue 28929 xhci: ASSERT: xfer->packet.status != USB_RET_NAK

2021-08-20 Thread Thomas Huth
Thanks for moving it over! ... let's close this one here on Launchpad now. ** Changed in: qemu Status: Confirmed => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1909261 Title: [OS

[Bug 1878250] Re: Assertion failure in iov_from_buf_full through the e1000e

2021-08-20 Thread Thomas Huth
Thanks for moving it over! ... let's close this one here on Launchpad now. ** Changed in: qemu Status: Confirmed => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1878250 Title: Ass

[Bug 1878645] Re: null-ptr dereference in ich9_apm_ctrl_changed

2021-08-20 Thread Thomas Huth
Thanks for moving it over! ... let's close this one here on Launchpad now. ** Changed in: qemu Status: Confirmed => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1878645 Title: nul

[Bug 1878034] Re: memcpy param-overlap through e1000e_write_to_rx_buffers

2021-08-20 Thread Thomas Huth
Thanks for moving it over! ... let's close this one here on Launchpad now. ** Changed in: qemu Status: Confirmed => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1878034 Title: memc

[Bug 1888714] Re: Memory Leak in hpet_timer results in unusable machine

2021-08-20 Thread Thomas Huth
Thanks for moving it over! ... let's close this one here on Launchpad now. ** Changed in: qemu Status: Confirmed => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1888714 Title: Mem

[Bug 1878651] Re: Assertion failure in e1000e_write_to_rx_buffers

2021-08-20 Thread Thomas Huth
Thanks for moving it over! ... let's close this one here on Launchpad now. ** Changed in: qemu Status: Confirmed => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1878651 Title: Ass

[Bug 1891354] Re: Heap-use-after-free in usb_packet_unmap

2021-08-20 Thread Alexander Bulekov
I moved this report over to QEMU's new bug tracker on gitlab.com. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/540 ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #540 https://gitlab.com/qemu-project/qemu/-/issues/540 -- You received this

[Bug 1909261] Re: [OSS-Fuzz] Issue 28929 xhci: ASSERT: xfer->packet.status != USB_RET_NAK

2021-08-20 Thread Alexander Bulekov
I moved this report over to QEMU's new bug tracker on gitlab.com. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/544 ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #544 https://gitlab.com/qemu-project/qemu/-/issues/544 -- You received this

[Bug 1892963] Re: Heap-use-after-free in put_dwords through ehci_flush_qh

2021-08-20 Thread Alexander Bulekov
I moved this report over to QEMU's new bug tracker on gitlab.com. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/541 ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #541 https://gitlab.com/qemu-project/qemu/-/issues/541 -- You received this

[Bug 1914638] Re: [OSS-Fuzz] Issue 30219: Global-buffer-overflow in mode_sense_page

2021-08-20 Thread Alexander Bulekov
I moved this report over to QEMU's new bug tracker on gitlab.com. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/546 ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #546 https://gitlab.com/qemu-project/qemu/-/issues/546 -- You received this

[Bug 1907938] Re: [OSS-Fuzz] Issue 28524 virtio-blk: ASSERT: !s->dataplane_started

2021-08-20 Thread Alexander Bulekov
I moved this report over to QEMU's new bug tracker on gitlab.com. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/543 ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #543 https://gitlab.com/qemu-project/qemu/-/issues/543 -- You received this

[Bug 1913667] Re: FPE in npcm7xx_clk_update_pll

2021-08-20 Thread Alexander Bulekov
I moved this report over to QEMU's new bug tracker on gitlab.com. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/549 ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #549 https://gitlab.com/qemu-project/qemu/-/issues/549 -- You received this

[Bug 1911216] Re: abort issue locates in hw/usb/hcd-ohci.c:1297:ohci_frame_boundary

2021-08-20 Thread Alexander Bulekov
I moved this report over to QEMU's new bug tracker on gitlab.com. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/545 ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #545 https://gitlab.com/qemu-project/qemu/-/issues/545 -- You received this

[Bug 1907497] Re: [OSS-Fuzz] Issue 28435 qemu:qemu-fuzz-i386-target-generic-fuzz-intel-hda: Stack-overflow in ldl_le_dma

2021-08-20 Thread Alexander Bulekov
I moved this report over to QEMU's new bug tracker on gitlab.com. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/542 ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #542 https://gitlab.com/qemu-project/qemu/-/issues/542 -- You received this

[Bug 1913669] Re: FPE in npcm7xx_adc_convert

2021-08-20 Thread Alexander Bulekov
I moved this report over to QEMU's new bug tracker on gitlab.com. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/550 ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #550 https://gitlab.com/qemu-project/qemu/-/issues/550 -- You received this

[Bug 1918321] Re: [OSS-Fuzz] Issue 31875 megasas: Null-ptr dereference in megasas_finish_dcmd

2021-08-20 Thread Alexander Bulekov
I moved this report over to QEMU's new bug tracker on gitlab.com. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/548 ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #548 https://gitlab.com/qemu-project/qemu/-/issues/548 -- You received this

[Bug 1917082] Re: [OSS-Fuzz] Issue 27574 e1000: Loopback-related stack-overflow

2021-08-20 Thread Alexander Bulekov
I moved this report over to QEMU's new bug tracker on gitlab.com. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/547 ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #547 https://gitlab.com/qemu-project/qemu/-/issues/547 -- You received this

[Bug 1878651] Re: Assertion failure in e1000e_write_to_rx_buffers

2021-08-20 Thread Alexander Bulekov
I moved this report over to QEMU's new bug tracker on gitlab.com. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/537 ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #537 https://gitlab.com/qemu-project/qemu/-/issues/537 -- You received this

[Bug 1888714] Re: Memory Leak in hpet_timer results in unusable machine

2021-08-20 Thread Alexander Bulekov
I moved this report over to QEMU's new bug tracker on gitlab.com. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/538 ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #538 https://gitlab.com/qemu-project/qemu/-/issues/538 -- You received this

[Bug 1890155] Re: Abort in vmxnet3_validate_interrupt_idx

2021-08-20 Thread Alexander Bulekov
I moved this report over to QEMU's new bug tracker on gitlab.com. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/539 ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #539 https://gitlab.com/qemu-project/qemu/-/issues/539 -- You received this

[Bug 1878645] Re: null-ptr dereference in ich9_apm_ctrl_changed

2021-08-20 Thread Alexander Bulekov
I moved this report over to QEMU's new bug tracker on gitlab.com. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/536 ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #536 https://gitlab.com/qemu-project/qemu/-/issues/536 -- You received this

[Bug 1878057] Re: null-ptr dereference in megasas_command_complete

2021-08-20 Thread Alexander Bulekov
I moved this report over to QEMU's new bug tracker on gitlab.com. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/551 ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #551 https://gitlab.com/qemu-project/qemu/-/issues/551 -- You received this

[Bug 1878250] Re: Assertion failure in iov_from_buf_full through the e1000e

2021-08-20 Thread Alexander Bulekov
I moved this report over to QEMU's new bug tracker on gitlab.com. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/535 ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #535 https://gitlab.com/qemu-project/qemu/-/issues/535 -- You received this

Re: [PATCH v4 0/7] AQMP TUI Draft

2021-08-20 Thread John Snow
On Thu, Aug 19, 2021 at 1:39 PM G S Niteesh Babu wrote: > Hello all, > > Gitlab: https://gitlab.com/niteesh.gs/qemu/-/commits/aqmp-tui-prototype-v4 > CI: https://gitlab.com/niteesh.gs/qemu/-/pipelines/356024270 > > Revision since v3: > 1) Added docstrings > 2) Minor changes in AQMP TUI Draft > 3)

[Bug 1878034] Re: memcpy param-overlap through e1000e_write_to_rx_buffers

2021-08-20 Thread Alexander Bulekov
I moved this report over to QEMU's new bug tracker on gitlab.com. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/534 ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #534 https://gitlab.com/qemu-project/qemu/-/issues/534 -- You received this

[Bug 1890159] Re: Assertion failure in net_tx_pkt_add_raw_fragment through vmxnet3

2021-08-20 Thread Alexander Bulekov
Looks like this was fixed by 283f0a05e2 ("hw/net/net_tx_pkt: Fix crash detected by fuzzer") ** Changed in: qemu Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs

Re: [PATCH for 6.2 40/49] bsd-user: Add target_arch_reg to describe a target's register set

2021-08-20 Thread Warner Losh
> On Aug 10, 2021, at 10:44 AM, Richard Henderson > wrote: > > On 8/7/21 11:42 AM, Warner Losh wrote: >> From: Warner Losh >> target_reg_t is the normal register. target_fpreg_t is the floating >> point registers. target_copy_regs copies the registers out of CPU >> context for things like core

[Bug 1911839] Re: [OSS-Fuzz] Issue 29586 e1000e: Memcpy-param-overlap in flatview_write_continue

2021-08-20 Thread Alexander Bulekov
*** This bug is a duplicate of bug 1878034 *** https://bugs.launchpad.net/bugs/1878034 ** This bug has been marked a duplicate of bug 1878034 memcpy param-overlap through e1000e_write_to_rx_buffers -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [PATCH 2/2] docs: add definitions of terms for CI/testing

2021-08-20 Thread Philippe Mathieu-Daudé
On 8/20/21 11:09 PM, Willian Rampazzo wrote: > To understand the current state of QEMU CI/testing and have a base to > discuss the plans for the future, it is important to define some usual > terms. This patch defines the terms for "Automated tests", "Unit > testing", "Functional testing", "System

New contribution: Plain text files in docs/ should be converted to rst(#527)

2021-08-20 Thread Lucas Ramage
Greetings, I would like to work on https://gitlab.com/qemu-project/qemu/-/issues/527. Here is my GitLab account: lucas.ramage I also left a comment on the issue. Regards,

Re: [PATCH] memory: Have 'info mtree' remove duplicated Address Space information

2021-08-20 Thread Philippe Mathieu-Daudé
On 8/20/21 10:16 PM, Peter Xu wrote: > Phil, > > On Fri, Aug 20, 2021 at 12:58:05PM +0200, Philippe Mathieu-Daudé wrote: >>> (qemu) info mtree >>> address-space: I/O >>> - (prio 0, i/o): io >>> >>> address-space shared 9 times: >>> - cpu-memory-0 >>>

Re: [PATCH v2] net/colo: check vnet_hdr_support flag when using virtio-net

2021-08-20 Thread Eric Blake
On Thu, Aug 19, 2021 at 09:27:17AM +0800, Tao Xu wrote: > When COLO use only one vnet_hdr_support parameter between > COLO network filter(filter-mirror, filter-redirector or > filter-rewriter and colo-compare, packet will not be parsed > correctly. Acquire network driver related to COLO, if it is >

Re: [qemu-web PATCH] Add a blog post about FUSE block exports

2021-08-20 Thread Eric Blake
On Thu, Aug 19, 2021 at 12:25:01PM +0200, Hanna Reitz wrote: > This post explains when FUSE block exports are useful, how they work, > and that it is fun to export an image file on its own path so it looks > like your image file (in whatever format it was) is a raw image now. > > Signed-off-by: Ha

[PATCH 1/2] docs: split the CI docs into two files

2021-08-20 Thread Willian Rampazzo
From: Daniel P. Berrangé This splits the CI docs into one file talking about job setup and usage and another file describing provisioning of custom runners. Signed-off-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210812180403.4129067-2-berra...@redhat.com> --- doc

[PATCH 2/2] docs: add definitions of terms for CI/testing

2021-08-20 Thread Willian Rampazzo
To understand the current state of QEMU CI/testing and have a base to discuss the plans for the future, it is important to define some usual terms. This patch defines the terms for "Automated tests", "Unit testing", "Functional testing", "System testing", "Flaky tests", "Gating", and "Continuous In

[PATCH 0/2] docs: add definitions of terms for CI/testing

2021-08-20 Thread Willian Rampazzo
To understand the current state of QEMU CI/testing and have a base to discuss the plans for the future, it is important to define some usual terms. This patch defines the terms for "Automated tests", "Unit testing", "Functional testing", "System testing", "Flaky tests", "Gating", and "Continuous In

Re: [PATCH] i386/cpu: Remove AVX_VNNI feature from Cooperlake cpu model

2021-08-20 Thread Eduardo Habkost
On Fri, Aug 20, 2021 at 01:46:11PM +0800, Yang Zhong wrote: > The AVX_VNNI feature is not in Cooperlake platform, remove it > from cpu model. > > Signed-off-by: Yang Zhong Fixes: c1826ea6a052 ("i386/cpu: Expose AVX_VNNI instruction to guest") Queued, thanks! -- Eduardo

Re: [PATCH] softmmu/physmem: Improve guest memory allocation failure error message

2021-08-20 Thread Peter Xu
On Fri, Aug 20, 2021 at 05:52:11PM +0200, Philippe Mathieu-Daudé wrote: > When Linux refuses to overcommit a seriously wild allocation we get: > > $ qemu-system-i386 -m 4000 > qemu-system-i386: cannot set up guest memory 'pc.ram': Cannot allocate > memory > > Slighly improve the error me

Re: [PATCH] memory: Have 'info mtree' remove duplicated Address Space information

2021-08-20 Thread Peter Xu
Phil, On Fri, Aug 20, 2021 at 12:58:05PM +0200, Philippe Mathieu-Daudé wrote: > > (qemu) info mtree > > address-space: I/O > > - (prio 0, i/o): io > > > > address-space shared 9 times: > > - cpu-memory-0 > > - cpu-memory-1 > > - cpu-memory-2 >

Re: [PATCH v3 09/13] python/aqmp-tui: Add QMP connection manager

2021-08-20 Thread John Snow
On Wed, Aug 18, 2021 at 3:36 PM John Snow wrote: > On Tue, Aug 17, 2021 at 3:07 PM Niteesh G. S. > wrote: > >> On Tue, Aug 17, 2021 at 10:21 AM John Snow wrote: >> >>> On Fri, Jul 30, 2021 at 4:19 PM G S Niteesh Babu >>> wrote: >>> >> > Is this required? I would have hoped that after calling d

Re: [PATCH v3 13/14] tcg/arm: Reserve a register for guest_base

2021-08-20 Thread Richard Henderson
On 8/20/21 2:03 AM, Peter Maydell wrote: -} else if (datalo != addend) { +} else if (scratch_addend) { tcg_out_ld32_rwb(s, COND_AL, datalo, addend, addrlo); tcg_out_ld32_12(s, COND_AL, datahi, addend, 4); } else { I don't understand this cha

Re: [PATCH v4 0/1] hw/pflash_cfi01: Allow an administrator to reduce the memory consumption of flash devices

2021-08-20 Thread Philippe Mathieu-Daudé
Hi David, On 8/10/21 3:40 PM, David Edmondson wrote: > As described in > https://lore.kernel.org/r/20201116104216.439650-1-david.edmond...@oracle.com > and > https://lore.kernel.org/r/20210222174757.2329740-1-david.edmond...@oracle.com > I'd like to reduce the amount of memory consumed by QEMU map

[PATCH v4 20/21] target/riscv: Tidy trans_rvh.c.inc

2021-08-20 Thread Richard Henderson
Exit early if check_access fails. Split out do_hlv, do_hsv, do_hlvx subroutines. Use dest_gpr, get_gpr in the new subroutines. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/riscv/insn32.decode | 1 + target/riscv/insn_trans/trans_rvh.c.inc | 266

[PATCH v4 19/21] target/riscv: Use {get,dest}_gpr for RVD

2021-08-20 Thread Richard Henderson
Reviewed-by: Bin Meng Signed-off-by: Richard Henderson --- target/riscv/insn_trans/trans_rvd.c.inc | 125 1 file changed, 60 insertions(+), 65 deletions(-) diff --git a/target/riscv/insn_trans/trans_rvd.c.inc b/target/riscv/insn_trans/trans_rvd.c.inc index 11b9b3f90b..

[PATCH v4 17/21] target/riscv: Use gen_shift_imm_fn for slli_uw

2021-08-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/riscv/insn_trans/trans_rvb.c.inc | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/target/riscv/insn_trans/trans_rvb.c.inc b/target/riscv/insn_trans/trans_rvb.c.inc index b97c3ca5da..74cb93a2db 100644 --- a/t

[PATCH v4 14/21] target/riscv: Use {get, dest}_gpr for integer load/store

2021-08-20 Thread Richard Henderson
Reviewed-by: Bin Meng Signed-off-by: Richard Henderson --- target/riscv/insn_trans/trans_rvi.c.inc | 36 + 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/target/riscv/insn_trans/trans_rvi.c.inc b/target/riscv/insn_trans/trans_rvi.c.inc index af3e0bc0e6..

[PATCH v4 13/21] target/riscv: Use get_gpr in branches

2021-08-20 Thread Richard Henderson
Narrow the scope of t0 in trans_jalr. Reviewed-by: Bin Meng Signed-off-by: Richard Henderson --- target/riscv/insn_trans/trans_rvi.c.inc | 25 ++--- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/target/riscv/insn_trans/trans_rvi.c.inc b/target/riscv/insn_t

[PATCH v4 12/21] target/riscv: Use DisasExtend in shift operations

2021-08-20 Thread Richard Henderson
These operations are greatly simplified by ctx->w, which allows us to fold gen_shiftw into gen_shift. Split gen_shifti into gen_shift_imm_{fn,tl} like we do for gen_arith_imm_{fn,tl}. Reviewed-by: Bin Meng Signed-off-by: Richard Henderson --- target/riscv/translate.c| 110 +

[PATCH v4 21/21] target/riscv: Use {get,dest}_gpr for RVV

2021-08-20 Thread Richard Henderson
Remove gen_get_gpr, as the function becomes unused. Signed-off-by: Richard Henderson --- target/riscv/translate.c| 13 ++--- target/riscv/insn_trans/trans_rvv.c.inc | 74 +++-- 2 files changed, 26 insertions(+), 61 deletions(-) diff --git a/target/riscv/trans

[PATCH v4 10/21] target/riscv: Move gen_* helpers for RVB

2021-08-20 Thread Richard Henderson
Move these helpers near their use by the trans_* functions within insn_trans/trans_rvb.c.inc. Reviewed-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/riscv/translate.c| 233 --- target/riscv/insn_trans/trans_rvb.

[PATCH v4 15/21] target/riscv: Reorg csr instructions

2021-08-20 Thread Richard Henderson
Introduce csrr and csrw helpers, for read-only and write-only insns. Note that we do not properly implement this in riscv_csrrw, in that we cannot distinguish true read-only (rs1 == 0) from any other zero write_mask another source register -- this should still raise an exception for read-only regi

[PATCH v4 16/21] target/riscv: Use {get,dest}_gpr for RVA

2021-08-20 Thread Richard Henderson
Reviewed-by: Bin Meng Signed-off-by: Richard Henderson --- target/riscv/insn_trans/trans_rva.c.inc | 47 ++--- 1 file changed, 19 insertions(+), 28 deletions(-) diff --git a/target/riscv/insn_trans/trans_rva.c.inc b/target/riscv/insn_trans/trans_rva.c.inc index 3cc3c3b073..

[PATCH v4 08/21] target/riscv: Use gen_arith for mulh and mulhu

2021-08-20 Thread Richard Henderson
Split out gen_mulh and gen_mulhu and use the common helper. Reviewed-by: Bin Meng Reviewed-by: Alistair Francis Signed-off-by: Richard Henderson --- target/riscv/insn_trans/trans_rvm.c.inc | 40 +++-- 1 file changed, 18 insertions(+), 22 deletions(-) diff --git a/target/ri

[PATCH v4 01/21] target/riscv: Use tcg_constant_*

2021-08-20 Thread Richard Henderson
Replace uses of tcg_const_* with the allocate and free close together. Reviewed-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Signed-off-by: Richard Henderson --- target/riscv/translate.c| 36 -- target/riscv/insn_trans/trans_rvf.c.

[PATCH v4 18/21] target/riscv: Use {get,dest}_gpr for RVF

2021-08-20 Thread Richard Henderson
Reviewed-by: Bin Meng Signed-off-by: Richard Henderson --- target/riscv/insn_trans/trans_rvf.c.inc | 146 1 file changed, 70 insertions(+), 76 deletions(-) diff --git a/target/riscv/insn_trans/trans_rvf.c.inc b/target/riscv/insn_trans/trans_rvf.c.inc index fb9f7f9c00..

[PATCH v4 11/21] target/riscv: Add DisasExtend to gen_unary

2021-08-20 Thread Richard Henderson
Use ctx->w for ctpopw, which is the only one that can re-use the generic algorithm for the narrow operation. Signed-off-by: Richard Henderson --- target/riscv/translate.c| 14 ++ target/riscv/insn_trans/trans_rvb.c.inc | 24 +--- 2 files changed, 1

[PATCH v4 07/21] target/riscv: Remove gen_arith_div*

2021-08-20 Thread Richard Henderson
Use ctx->w and the enhanced gen_arith function. Reviewed-by: Bin Meng Reviewed-by: Alistair Francis Signed-off-by: Richard Henderson --- target/riscv/translate.c| 42 - target/riscv/insn_trans/trans_rvm.c.inc | 16 +- 2 files changed, 8 insertion

[PATCH v4 09/21] target/riscv: Move gen_* helpers for RVM

2021-08-20 Thread Richard Henderson
Move these helpers near their use by the trans_* functions within insn_trans/trans_rvm.c.inc. Reviewed-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Signed-off-by: Richard Henderson --- target/riscv/translate.c| 127 ta

[PATCH v4 05/21] target/riscv: Introduce DisasExtend and new helpers

2021-08-20 Thread Richard Henderson
Introduce get_gpr, dest_gpr, temp_new -- new helpers that do not force tcg globals into temps, returning a constant 0 for $zero as source and a new temp for $zero as destination. Introduce ctx->w for simplifying word operations, such as addw. Reviewed-by: Bin Meng Reviewed-by: Alistair Francis

[PATCH v4 03/21] target/riscv: Clean up division helpers

2021-08-20 Thread Richard Henderson
Utilize the condition in the movcond more; this allows some of the setcond that were feeding into movcond to be removed. Do not write into source1 and source2. Re-name "condN" to "tempN" and use the temporaries for more than holding conditions. Signed-off-by: Richard Henderson --- target/riscv/

[PATCH v4 04/21] target/riscv: Add DisasContext to gen_get_gpr, gen_set_gpr

2021-08-20 Thread Richard Henderson
We will require the context to handle RV64 word operations. Reviewed-by: Alistair Francis Reviewed-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/riscv/translate.c| 58 - target/riscv/insn_trans/trans_rva.c.

[PATCH v4 00/21] target/riscv: Use tcg_constant_*

2021-08-20 Thread Richard Henderson
Replace use of tcg_const_*, which makes a copy into a temp which must be freed, with direct use of the constant. Reorg handling of $zero, with different accessors for source and destination. Reorg handling of csrs, passing the actual write_mask instead of a regno. Use more helpers for RVH expans

[PATCH v4 06/21] target/riscv: Add DisasExtend to gen_arith*

2021-08-20 Thread Richard Henderson
Most arithmetic does not require extending the inputs. Exceptions include division, comparison and minmax. Begin using ctx->w, which allows elimination of gen_addw, gen_subw, gen_mulw. Reviewed-by: Bin Meng Reviewed-by: Alistair Francis Signed-off-by: Richard Henderson --- target/riscv/transl

[PATCH v4 02/21] tests/tcg/riscv64: Add test for division

2021-08-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tests/tcg/riscv64/test-div.c | 58 +++ tests/tcg/riscv64/Makefile.target | 5 +++ 2 files changed, 63 insertions(+) create mode 100644 tests/tcg/riscv64/test-div.c create mode 100644 tests/tcg/riscv64/Makefile.target diff -

Re: [PATCH v3 06/14] tcg/arm: Support unaligned access for softmmu

2021-08-20 Thread Richard Henderson
On 8/20/21 3:34 AM, Peter Maydell wrote: On Wed, 18 Aug 2021 at 22:32, Richard Henderson wrote: From armv6, the architecture supports unaligned accesses. All we need to do is perform the correct alignment check in tcg_out_tlb_read and not use LDRD/STRD when the access is not aligned. Signed-

Re: [PATCH] softmmu/physmem: Improve guest memory allocation failure error message

2021-08-20 Thread Peter Maydell
On Fri, 20 Aug 2021 at 17:59, Philippe Mathieu-Daudé wrote: > Anyhow I still see the size displayed in the error message as an > useful hint: > > $ qemu-system-i386 -m 64000 > qemu-system-i386: cannot set up guest memory 'pc.ram': Cannot allocate > memory > > VS: > > $ qemu-system-i386 -m 64000 >

[PATCH] target/i386: Remove unnecessary checks of b2 in SSE decode

2021-08-20 Thread Peter Maydell
In the SSE decode function gen_sse(), we combine a byte 'b' and a value 'b1' which can be [0..3], and switch on them: b |= (b1 << 8); switch (b) { ... default: unknown_op: gen_unknown_opcode(env, s); return; } In three cases inside this switch, we were then also che

Re: [PULL 03/33] i386: split cpu accelerators from cpu.c, using AccelCPUClass

2021-08-20 Thread Peter Maydell
On Fri, 20 Aug 2021 at 18:02, Philippe Mathieu-Daudé wrote: > > On 8/20/21 6:55 PM, Peter Maydell wrote: > > On Tue, 11 May 2021 at 09:22, Paolo Bonzini wrote: > >> > >> From: Claudio Fontana > >> > >> i386 is the first user of AccelCPUClass, allowing to split > >> cpu.c into: > >> > >> cpu.c

Re: [PATCH] target/i386: Fix memory leak in sev_read_file_base64()

2021-08-20 Thread Philippe Mathieu-Daudé
On 8/20/21 6:56 PM, Peter Maydell wrote: > In sev_read_file_base64() we call g_file_get_contents(), which > allocates memory for the file contents. We then base64-decode the > contents (which allocates another buffer for the decoded data), but > forgot to free the memory for the original file data

Re: [PULL 03/33] i386: split cpu accelerators from cpu.c, using AccelCPUClass

2021-08-20 Thread Philippe Mathieu-Daudé
On 8/20/21 6:55 PM, Peter Maydell wrote: > On Tue, 11 May 2021 at 09:22, Paolo Bonzini wrote: >> >> From: Claudio Fontana >> >> i386 is the first user of AccelCPUClass, allowing to split >> cpu.c into: >> >> cpu.ccpuid and common x86 cpu functionality >> host-cpu.c host x86 cpu

Re: [PATCH] softmmu/physmem: Improve guest memory allocation failure error message

2021-08-20 Thread Philippe Mathieu-Daudé
On 8/20/21 6:40 PM, Igor Mammedov wrote: > On Fri, 20 Aug 2021 18:00:26 +0200 > Philippe Mathieu-Daudé wrote: > >> On 8/20/21 5:53 PM, David Hildenbrand wrote: >>> On 20.08.21 17:52, Philippe Mathieu-Daudé wrote: When Linux refuses to overcommit a seriously wild allocation we get: >>>

[PATCH] target/i386: Fix memory leak in sev_read_file_base64()

2021-08-20 Thread Peter Maydell
In sev_read_file_base64() we call g_file_get_contents(), which allocates memory for the file contents. We then base64-decode the contents (which allocates another buffer for the decoded data), but forgot to free the memory for the original file data. Use g_autofree to ensure that the file data is

Re: [PULL 03/33] i386: split cpu accelerators from cpu.c, using AccelCPUClass

2021-08-20 Thread Peter Maydell
On Tue, 11 May 2021 at 09:22, Paolo Bonzini wrote: > > From: Claudio Fontana > > i386 is the first user of AccelCPUClass, allowing to split > cpu.c into: > > cpu.ccpuid and common x86 cpu functionality > host-cpu.c host x86 cpu functions and "host" cpu type > kvm/kvm-cpu.cKV

Re: [PATCH] libqtest: check for g_setenv() failure

2021-08-20 Thread Philippe Mathieu-Daudé
On 8/20/21 6:37 PM, Peter Maydell wrote: > g_setenv() can fail; check for it when starting a QEMU process > when we set the QEMU_AUDIO_DRV environment variable. > > Because this happens after fork() reporting an exact message > via printf() is a bad idea; just exit(1), as we already do > for the c

Re: [PATCH] softmmu/physmem: Improve guest memory allocation failure error message

2021-08-20 Thread Igor Mammedov
On Fri, 20 Aug 2021 18:00:26 +0200 Philippe Mathieu-Daudé wrote: > On 8/20/21 5:53 PM, David Hildenbrand wrote: > > On 20.08.21 17:52, Philippe Mathieu-Daudé wrote: > >> When Linux refuses to overcommit a seriously wild allocation we get: > >> > >>    $ qemu-system-i386 -m 4000 > >>    qemu

[PATCH] libqtest: check for g_setenv() failure

2021-08-20 Thread Peter Maydell
g_setenv() can fail; check for it when starting a QEMU process when we set the QEMU_AUDIO_DRV environment variable. Because this happens after fork() reporting an exact message via printf() is a bad idea; just exit(1), as we already do for the case of execlp() failure. Fixes: Coverity CID 1460117

Re: xilinx-zynq-a9: cannot set up guest memory 'zynq.ext_ram'

2021-08-20 Thread Igor Mammedov
On Fri, 20 Aug 2021 18:06:30 +0200 Philippe Mathieu-Daudé wrote: > On 8/20/21 6:03 PM, Igor Mammedov wrote: > > On Fri, 20 Aug 2021 17:47:01 +0200 > > David Hildenbrand wrote: > > > >> On 20.08.21 17:44, Igor Mammedov wrote: > >>> On Fri, 20 Aug 2021 15:39:27 +0100 > >>> Peter Maydell wrot

Re: xilinx-zynq-a9: cannot set up guest memory 'zynq.ext_ram'

2021-08-20 Thread Philippe Mathieu-Daudé
On 8/20/21 6:08 PM, Igor Mammedov wrote: > On Fri, 20 Aug 2021 17:53:41 +0200 > Philippe Mathieu-Daudé wrote: > >> On 8/20/21 5:47 PM, David Hildenbrand wrote: >>> On 20.08.21 17:44, Igor Mammedov wrote: On Fri, 20 Aug 2021 15:39:27 +0100 Peter Maydell wrote: > On Fri, 20

Re: xilinx-zynq-a9: cannot set up guest memory 'zynq.ext_ram'

2021-08-20 Thread Igor Mammedov
On Fri, 20 Aug 2021 17:53:41 +0200 Philippe Mathieu-Daudé wrote: > On 8/20/21 5:47 PM, David Hildenbrand wrote: > > On 20.08.21 17:44, Igor Mammedov wrote: > >> On Fri, 20 Aug 2021 15:39:27 +0100 > >> Peter Maydell wrote: > >> > >>> On Fri, 20 Aug 2021 at 15:34, David Hildenbrand > >>> wrot

[PATCH] migration: RDMA registrations interval optimization

2021-08-20 Thread Zhiwei Jiang
RDMA migration very hard to complete when VM run mysql benchmark on 1G host hugepage.I think the time between ram_control_before_iterate(f, RAM_CONTROL_ROUND) and after_iterate is too large when 1G host pagesize,so 1M buffer size match with mlx driver that will be good. after this patch,it will wor

Re: xilinx-zynq-a9: cannot set up guest memory 'zynq.ext_ram'

2021-08-20 Thread Philippe Mathieu-Daudé
On 8/20/21 6:03 PM, Igor Mammedov wrote: > On Fri, 20 Aug 2021 17:47:01 +0200 > David Hildenbrand wrote: > >> On 20.08.21 17:44, Igor Mammedov wrote: >>> On Fri, 20 Aug 2021 15:39:27 +0100 >>> Peter Maydell wrote: >>> On Fri, 20 Aug 2021 at 15:34, David Hildenbrand wrote: > >

Re: xilinx-zynq-a9: cannot set up guest memory 'zynq.ext_ram'

2021-08-20 Thread Igor Mammedov
On Fri, 20 Aug 2021 17:47:01 +0200 David Hildenbrand wrote: > On 20.08.21 17:44, Igor Mammedov wrote: > > On Fri, 20 Aug 2021 15:39:27 +0100 > > Peter Maydell wrote: > > > >> On Fri, 20 Aug 2021 at 15:34, David Hildenbrand wrote: > >>> > >>> On 20.08.21 16:22, Bin Meng wrote: > Hi P

Re: [PATCH] softmmu/physmem: Improve guest memory allocation failure error message

2021-08-20 Thread Philippe Mathieu-Daudé
On 8/20/21 5:53 PM, David Hildenbrand wrote: > On 20.08.21 17:52, Philippe Mathieu-Daudé wrote: >> When Linux refuses to overcommit a seriously wild allocation we get: >> >>    $ qemu-system-i386 -m 4000 >>    qemu-system-i386: cannot set up guest memory 'pc.ram': Cannot >> allocate memory >> >

Re: [PATCH] hw/acpi: refactor acpi hp modules so that targets can just use what they need

2021-08-20 Thread Philippe Mathieu-Daudé
On 8/20/21 5:43 PM, Ani Sinha wrote: > On Thu, 19 Aug 2021, Philippe Mathieu-Daudé wrote: >> On 8/12/21 9:14 AM, Ani Sinha wrote: > >>> +return; >> >> I suppose if you replace all 'return' by 'g_assert_not_reached()' >> both issues reproducers crash? >> >> Your patch is not incorrect, and inde

  1   2   >