Re: [PATCH v2] ui/gtk: Allow user to select monitor number to display qemu in full screen through new gtk display option

Hi, > " Your new option argument seems to count monitors from 1, while GTK counts > them from zero. Why the difference?" > sweeaun: It is due to gtk_window_fullscreen_on_monitor monitor index is > started from zero. I am not using zero as starting index of new option > argument to make easie

Re: [PATCH 1/2] tests/migration: parse the thread-id key of CpuInfoFast

cc original author Daniel P. Berrangé :) may be this two fixes can be squashed into a single patch. 在 2021/6/16 14:26, Hyman Huang 写道: 在 2021/6/3 22:19, huang...@chinatelecom.cn 写道: From: Hyman Huang(黄勇) thread_id in CpuInfoFast is deprecated, parse thread-id instead after execute qmp que

Re: [PATCH 26/26] target/xtensa: Use translator_use_goto_tb

On Sun, Jun 20, 2021 at 6:34 PM Richard Henderson wrote: > > Cc: Max Filippov > Signed-off-by: Richard Henderson > --- > target/xtensa/translate.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) Reviewed-by: Max Filippov -- Thanks. -- Max

Re: [PATCH 01/26] accel/tcg: Introduce translator_use_goto_tb

On Sun, Jun 20, 2021 at 6:36 PM Richard Henderson wrote: > > Add a generic version of the common use_goto_tb test. > > Signed-off-by: Richard Henderson > --- > include/exec/translator.h | 10 ++ > accel/tcg/translator.c| 11 +++ > 2 files changed, 21 insertions(+) Reviewed-b

Re: [PATCH v9] qapi: introduce 'query-kvm-cpuid' action

Eduardo Habkost writes: > On Fri, Jun 18, 2021 at 07:52:47AM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Thu, Jun 17, 2021 at 05:53:11PM +0200, Claudio Fontana wrote: >> >> On 6/17/21 5:39 PM, Valeriy Vdovin wrote: >> >> > On Thu, Jun 17, 2021 at 04:14:17PM +0200, Mark

[Bug 1907497] Re: [OSS-Fuzz] Issue 28435 qemu:qemu-fuzz-i386-target-generic-fuzz-intel-hda: Stack-overflow in ldl_le_dma

I think this [0] commit actually fixes this bug, can someone please confirm it? [0] https://github.com/qemu/qemu/commit/1bf8b88f144bee747e386c88d45d772e066bbb36 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.n

Re: [PATCH 07/26] target/avr: Mark some helpers noreturn

Reviewed-by: Michael Rolnik On Mon, Jun 21, 2021 at 4:34 AM Richard Henderson < richard.hender...@linaro.org> wrote: > All of these helpers end with cpu_loop_exit. > > Cc: Michael Rolnik > Signed-off-by: Richard Henderson > --- > target/avr/helper.h | 8 > 1 file changed, 4 insertio

Re: [PATCH v2 3/3] target/avr: Convert to TranslatorOps

Reviewed-by: Michael Rolnik Tested-by: Michael Rolnik On Mon, Jun 21, 2021 at 12:50 AM Richard Henderson < richard.hender...@linaro.org> wrote: > Signed-off-by: Richard Henderson > --- > target/avr/translate.c | 234 ++--- > 1 file changed, 128 insertions(+

RE: [PATCH v2] ui/gtk: Allow user to select monitor number to display qemu in full screen through new gtk display option

Hi Markus, Thanks for include Graphic maintainer and the coding style comments. Yes, sweeaun is my name 😊 For "full screen" be "full-screen" or even "fullscreen"? These 3 words have been being used in QEMU repo, but full-screen mostly used for variable/member. Thus, I felt full screen should b

[Bug 1914117] Re: Short files returned via FTP on Qemu with various architectures and OSes

** Changed in: qemu Status: Incomplete => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1914117 Title: Short files returned via FTP on Qemu with various architectures and OSes

Re: [PATCH 00/18] vhost-vDPA multiqueue

Patchew URL: https://patchew.org/QEMU/20210621041650.5826-1-jasow...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210621041650.5826-1-jasow...@redhat.com Subject: [PATCH 00/18] vhost-vDPA multiqueue ===

[Bug 717929] Re: Serial communication between VMs problematic

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/717929 Title: Serial commu

[Bug 1090602] Re: RFE: Allow specifying usb-host device by serial number

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1090602 Title: RFE: Allow

[Bug 1272252] Re: qemu-img ftp/http convert

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1272252 Title: qemu-img ft

[Bug 1309034] Re: A way not to grab keyboards or mice

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1309034 Title: A way not t

[Bug 1502884] Re: Super important feature req: QEMU VNC server: Introduce a keyboard "norepeat" option!

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1502884 Title: Super impor

[Bug 1724590] Re: Usermode networking hostfwd only listens on IPv4

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1724590 Title: Usermode ne

[Bug 1751264] Re: qemu-img convert issue in a tmpfs partition

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1751264 Title: qemu-img co

[Bug 813546] Re: option to disable PS/2 mouse

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/813546 Title: option to di

[Bug 903365] Re: [feature request] bind nat (-net user) to other interface (like eth0:2)

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/903365 Title: [feature req

[Bug 1815009] Re: Qemu evdev multiple guests/host switch

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1815009 Title: Qemu evdev

[Bug 1749016] Re: VHDX BAT and Metadata Region Header Required Bit Not Set

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1749016 Title: VHDX BAT an

[Bug 1378407] Re: [feature request] Partition table wrapper for single-filesystem images

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1378407 Title: [feature re

[Bug 1184089] Re: [Feature request] loadvm snapshot as read-only

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1184089 Title: [Feature re

[Bug 1801933] Re: default memory parameter too small on x86_64 today

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1801933 Title: default mem

[PATCH 16/18] virito-net: use "qps" instead of "queues" when possible

Most of the time, "queues" really means queue pairs. So this patch switch to use "qps" to avoid confusion. Signed-off-by: Jason Wang --- hw/net/virtio-net.c| 150 - include/hw/virtio/virtio-net.h | 4 +- 2 files changed, 77 insertions(+), 77 deletion

[Bug 1719689] Re: [feature request] add flag to treat warnings as errors

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1719689 Title: [feature re

[Bug 1659267] Re: It's not possible to start a VM with a network cable unplugged

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1659267 Title: It's not po

[PATCH 17/18] virtio-net: vhost control virtqueue support

This patch implements the control virtqueue support for vhost. This requires virtio-net to figure out the datapath queue pairs and control virtqueue via is_datapath and pass the number of those two types of virtqueues to vhost_net_start()/vhost_net_stop(). Signed-off-by: Jason Wang --- hw/net/vi

[Bug 1731277] Re: Provide target specific qemu man pages

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1731277 Title: Provide tar

[Bug 1817268] Re: Input/output error during migration

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1817268 Title: Input/outpu

[PATCH 13/18] vhost-vdpa: let net_vhost_vdpa_init() returns NetClientState *

This patch switches to let net_vhost_vdpa_init() to return NetClientState *. This is used for the callers to allocate multiqueue NetClientState for multiqueue support. Signed-off-by: Jason Wang --- net/vhost-vdpa.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff

[PATCH 15/18] vhost-net: control virtqueue support

We assume there's no cvq in the past, this is not true when we need control virtqueue support for vhost-user backends. So this patch implements the control virtqueue support for vhost-net. As datapath, the control virtqueue is also required to be coupled with the NetClientState. The vhost_net_start

[PATCH 11/18] vhost-vdpa: classify one time request

Vhost-vdpa uses one device multiqueue queue (pairs) model. So we need to classify the one time request (e.g SET_OWNER) and make sure those request were only called once per device. This is used for multiqueue support. Signed-off-by: Jason Wang --- hw/virtio/vhost-vdpa.c | 51 +++

[PATCH 14/18] net: introduce control client

This patch introduces a boolean for the device has control queue which can accepts control command via network queue. The first user would be the control virtqueue support for vhost. Signed-off-by: Jason Wang --- include/net/net.h | 5 + net/net.c | 24 +--- 2 f

[PATCH 18/18] vhost-vdpa: multiqueue support

This patch implements the multiqueue support for vhost-vdpa. This is done simply by reading the number of queue pairs from the config space and initialize the datapath and control path net client. Signed-off-by: Jason Wang --- hw/net/virtio-net.c | 3 +- net/vhost-vdpa.c| 98 +++

[PATCH 07/18] vhost-vdpa: tweak the error label in vhost_vdpa_add()

Introduce new error label to avoid the unnecessary checking of net pointer. Fixes: 1e0a84ea49b68 ("vhost-vdpa: introduce vhost-vdpa net client") Signed-off-by: Jason Wang --- net/vhost-vdpa.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/net/vhost-vdpa.c b/net

[PATCH 12/18] vhost-vdpa: prepare for the multiqueue support

Unlike vhost-kernel, vhost-vdpa adapts a single device multiqueue model. So we need to simply use virtqueue index as the vhost virtqueue index. This is a must for multiqueue to work for vhost-vdpa. Signed-off-by: Jason Wang --- hw/virtio/vhost-vdpa.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 04/18] vhost-vdpa: remove the unnecessary check in vhost_vdpa_add()

The VhostVDPAState is just allocated by qemu_new_net_client() via g_malloc0() in net_vhost_vdpa_init(). So s->vhost_net is NULL for sure, let's remove this unnecessary check in vhost_vdpa_add(). Signed-off-by: Jason Wang --- net/vhost-vdpa.c | 4 1 file changed, 4 deletions(-) diff --git a

[PATCH 09/18] vhost-vdpa: remove the unncessary queue_index assignment

The queue_index of NetClientState should be assigned in set_netdev() afterwards, so trying to net_vhost_vdpa_init() is meaningless. This patch removes this. Signed-off-by: Jason Wang --- net/vhost-vdpa.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index

[PATCH 08/18] vhost-vdpa: fix the wrong assertion in vhost_vdpa_init()

Vhost_vdpa_add() can fail for various reasons, so the assertion of the succeed is wrong. Instead, we should free the NetClientState and propagate the error to the caller Signed-off-by: Jason Wang --- net/vhost-vdpa.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/vho

[PATCH 10/18] vhost-vdpa: open device fd in net_init_vhost_vdpa()

This path switches to open device fd in net_init_vhost_vpda(). This is used to prepare for the multiqueue support. Signed-off-by: Jason Wang --- net/vhost-vdpa.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index

[PATCH 02/18] vhost: use unsigned int for nvqs

Switch to use unsigned int for nvqs since it's not expected to be negative. Signed-off-by: Jason Wang --- include/hw/virtio/vhost.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/virtio/vhost.h b/include/hw/virtio/vhost.h index 21a9a52088..ddd7d3d594 100644 --- a/

[PATCH 05/18] vhost-vdpa: don't cleanup twice in vhost_vdpa_add()

The previous vhost_net_cleanup is sufficient for freeing, calling vhost_vdpa_del() in this case will lead an extra round of free. Note that this kind of "double free" is safe since vhost_dev_cleanup() zero the whole structure. Signed-off-by: Jason Wang --- net/vhost-vdpa.c | 11 --- 1 fi

[PATCH 06/18] vhost-vdpa: fix leaking of vhost_net in vhost_vdpa_add()

Fixes: 1e0a84ea49b68 ("vhost-vdpa: introduce vhost-vdpa net client") Signed-off-by: Jason Wang --- net/vhost-vdpa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index f5689a7c32..21f09c546f 100644 --- a/net/vhost-vdpa.c +++ b/net/vhost-vdpa.c @@ -111,6 +

[PATCH 03/18] vhost_net: do not assume nvqs is always 2

This patch switches to initialize dev.nvqs from the VhostNetOptions instead of assuming it was 2. This is useful for implementing control virtqueue support which will be a single vhost_net structure with a single cvq. Signed-off-by: Jason Wang --- hw/net/vhost_net.c | 2 +- include/net/vhos

[PATCH 01/18] vhost_net: remove the meaningless assignment in vhost_net_start_one()

The nvqs and vqs has been initialized during vhost_net_init() and is not expected to change during the life cycle of vhost_net structure. So this patch removes the meaningless assignment. Signed-off-by: Jason Wang --- hw/net/vhost_net.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/ne

[PATCH 00/18] vhost-vDPA multiqueue

Hi All: This patch implements the multiqueue support for vhost-vDPA. The most important requirement the control virtqueue support. The virtio-net and vhost-net core are tweak to support control virtqueue as if what data queue pairs are done: a dedicated vhost_net device which is coupled with the N

Re: [PATCH v2 01/11] linux-user: handle /proc/self/exe for execve

On Sun, Jun 20, 2021 at 11:14 PM Laurent Vivier wrote: > > Le 31/05/2021 à 07:50, YAMAMOTO Takashi a écrit : > > It seems somehow common to execve /proc/self/exe in docker > > or golang community these days. > > At least, moby "reexec" and runc "libcontainer" do that. > > > > Signed-off-by: YAMAMO

[PATCH 19/26] target/rx: Use translator_use_goto_tb

Just use translator_use_goto_tb directly at the one call site, rather than maintaining a local wrapper. Cc: Yoshinori Sato Signed-off-by: Richard Henderson --- target/rx/translate.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/target/rx/translate.c b/target/rx

[PATCH 24/26] target/tricore: Use translator_use_goto_tb

Just use translator_use_goto_tb directly at the one call site, rather than maintaining a local wrapper. Cc: Bastian Koppelmann Signed-off-by: Richard Henderson --- target/tricore/translate.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/target/tricore/tr

[PATCH 25/26] target/tricore: Use tcg_gen_lookup_and_goto_ptr

The non-single-step case of gen_goto_tb may use tcg_gen_lookup_and_goto_ptr to indirectly chain. Cc: Bastian Koppelmann Signed-off-by: Richard Henderson --- target/tricore/translate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/tricore/translate.c b/target/trico

[PATCH 21/26] target/s390x: Remove use_exit_tb

We have not needed to end a TB for I/O since ba3e7926691 ("icount: clean up cpu_can_io at the entry to the block"). In use_goto_tb, the check for singlestep_enabled is in the generic translator_use_goto_tb. In s390x_tr_tb_stop, the check for singlestep_enabled is in the preceeding do_debug test.

[PATCH 16/26] target/openrisc: Use translator_use_goto_tb

Reorder the cases in openrisc_tr_tb_stop to make this easier to read. Cc: Stafford Horne Signed-off-by: Richard Henderson --- target/openrisc/translate.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/target/openrisc/translate.c b/target/openrisc/translate.c

[PATCH 23/26] target/sparc: Use translator_use_goto_tb

Cc: Mark Cave-Ayland Signed-off-by: Richard Henderson --- target/sparc/translate.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index 4bfa3179f8..fb0c242606 100644 --- a/target/sparc/translate.c +++ b

[PATCH 26/26] target/xtensa: Use translator_use_goto_tb

Cc: Max Filippov Signed-off-by: Richard Henderson --- target/xtensa/translate.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c index 14028d307d..ac42f5efdc 100644 --- a/target/xtensa/translate.c +++ b/target/xtensa/t

[PATCH 17/26] target/ppc: Use translator_use_goto_tb

Cc: David Gibson Signed-off-by: Richard Henderson --- target/ppc/translate.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index f65d1e81ea..0fb09f2301 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c

[PATCH 18/26] target/riscv: Use translator_use_goto_tb

Just use translator_use_goto_tb directly at the one call site, rather than maintaining a local wrapper. Cc: qemu-ri...@nongnu.org Signed-off-by: Richard Henderson --- target/riscv/translate.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/target/riscv/tr

[PATCH 11/26] target/m68k: Use translator_use_goto_tb

Just use translator_use_goto_tb directly at the one call site, rather than maintaining a local wrapper. Cc: Laurent Vivier Signed-off-by: Richard Henderson --- target/m68k/translate.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/target/m68k/translate.c b/targ

[PATCH 20/26] target/s390x: Use translator_use_goto_tb

Cc: David Hildenbrand Signed-off-by: Richard Henderson --- target/s390x/translate.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/target/s390x/translate.c b/target/s390x/translate.c index e243624d2a..4bb5d82a37 100644 --- a/target/s390x/translate.c +++ b/target/s390x/

[PATCH 14/26] target/mips: Fix missing else in gen_goto_tb

Do not emit dead code for the singlestep_enabled case, after having exited the TB with a debug exception. Cc: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/mips/tcg/translate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/mips/tcg/translate.c

[PATCH 07/26] target/avr: Mark some helpers noreturn

All of these helpers end with cpu_loop_exit. Cc: Michael Rolnik Signed-off-by: Richard Henderson --- target/avr/helper.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/avr/helper.h b/target/avr/helper.h index 8e1ae7fda0..4d02e648fa 100644 --- a/target/avr/hel

[PATCH 08/26] target/cris: Use translator_use_goto_tb

The test for singlestepping is done in translator_use_goto_tb, so we may elide it from cris_tr_tb_stop. Cc: Edgar E. Iglesias Signed-off-by: Richard Henderson --- target/cris/translate.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/target/cris/translate.c b/target/cr

[PATCH 13/26] target/mips: Use translator_use_goto_tb

Just use translator_use_goto_tb directly at the one call site, rather than maintaining a local wrapper. Cc: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/mips/tcg/translate.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/target/mips/

[PATCH 15/26] target/nios2: Use translator_use_goto_tb

Just use translator_use_goto_tb directly at the one call site, rather than maintaining a local wrapper. Cc: Chris Wulff Cc: Marek Vasut Signed-off-by: Richard Henderson --- target/nios2/translate.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/target/nios2

[PATCH 22/26] target/sh4: Use translator_use_goto_tb

Cc: Yoshinori Sato Signed-off-by: Richard Henderson --- target/sh4/translate.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index 9312790623..9ac9bc722e 100644 --- a/target/sh4/translate.c +++ b/target/sh4/transla

[PATCH 05/26] target/arm: Use translator_use_goto_tb

Put a wrapper in translate.h, which also checks for ss_active. The ss_active test was incorrectly missing from the a32 version. Cc: qemu-...@nongnu.org Signed-off-by: Richard Henderson --- target/arm/translate.h | 13 + target/arm/translate-a64.c | 22 +- targ

[PATCH 03/26] target/alpha: Remove in_superpage

The number of links across (normal) pages using this is low, and it will shortly violate the contract for breakpoints. Signed-off-by: Richard Henderson --- target/alpha/translate.c | 24 ++-- 1 file changed, 2 insertions(+), 22 deletions(-) diff --git a/target/alpha/translat

[PATCH 12/26] target/microblaze: Use translator_use_goto_tb

Just use translator_use_goto_tb directly at the one call site, rather than maintaining a local wrapper. Cc: Edgar E. Iglesias Signed-off-by: Richard Henderson --- target/microblaze/translate.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/target/microblaze/tran

[PATCH 10/26] target/i386: Use translator_use_goto_tb

Just use translator_use_goto_tb directly at the one call site, rather than maintaining a local wrapper. Cc: Paolo Bonzini Cc: Eduardo Habkost Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/tar

[PATCH 04/26] target/alpha: Use translator_use_goto_tb

Signed-off-by: Richard Henderson --- target/alpha/translate.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/target/alpha/translate.c b/target/alpha/translate.c index 6ea19a1d4c..1aa6d24d83 100644 --- a/target/alpha/translate.c +++ b/target/alpha/translate.c @@ -441,12

[PATCH 02/26] target/alpha: Remove use_exit_tb

We have not needed to end a TB for I/O since ba3e7926691 ("icount: clean up cpu_can_io at the entry to the block"). We do not need to use exit_tb for singlestep, which only means generate one insn per TB. Which leaves only singlestep_enabled, which means raise a debug trap after every TB, which do

[PATCH 06/26] target/avr: Use translator_use_goto_tb

Single stepping is not the only reason not to use goto_tb. If goto_tb is disallowed, and single-stepping is not enabled, then use tcg_gen_lookup_and_goto_tb to indirectly chain. Cc: Michael Rolnik Signed-off-by: Richard Henderson --- target/avr/translate.c | 9 ++--- 1 file changed, 6 inser

[PATCH 01/26] accel/tcg: Introduce translator_use_goto_tb

Add a generic version of the common use_goto_tb test. Signed-off-by: Richard Henderson --- include/exec/translator.h | 10 ++ accel/tcg/translator.c| 11 +++ 2 files changed, 21 insertions(+) diff --git a/include/exec/translator.h b/include/exec/translator.h index 24232ead41

[PATCH 09/26] target/hppa: Use translator_use_goto_tb

Signed-off-by: Richard Henderson --- target/hppa/translate.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 64af1e0d5c..952cfe09a6 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -817,10 +817,7

[PATCH 00/26] accel/tcg: Introduce translator_use_goto_tb

There are a number of inconsistencies with goto_tb usage, and I plan to make changes in order to better support breakpoints. (1) Testing CF_LAST_IO is a hold-over from since before ba3e7926691 ("icount: clean up cpu_can_io at the entry to the block"). Several targets still have this test.

Re: [PATCH v2 02/11] linux-user: Fix the execfd case of /proc/self/exe open

On Sun, Jun 20, 2021 at 11:16 PM Laurent Vivier wrote: > > Le 31/05/2021 à 07:50, YAMAMOTO Takashi a écrit : > > It's problematic to return AT_EXECFD as it is because the user app > > would close it. > > This patch opens it via /proc/self/fd instead. > > > > Signed-off-by: YAMAMOTO Takashi > > --

[PATCH v2 5/7] target/nios2: Convert to TranslatorOps

Signed-off-by: Richard Henderson --- target/nios2/translate.c | 130 --- 1 file changed, 67 insertions(+), 63 deletions(-) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index 31653b7912..06705c894d 100644 --- a/target/nios2/translate.c +++ b

[PATCH v2 2/7] target/nios2: Use global cpu_env

We do not need to copy this into DisasContext. Signed-off-by: Richard Henderson --- target/nios2/translate.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index 388fae93a2..39538e1870 100644 --- a/target/nios2/t

[PATCH v2 6/7] target/nios2: Remove assignment to env in handle_instruction

Direct assignments to env during translation do not work. As it happens, the only way we can get here is if env->pc is already set to dc->pc. We will trap on the first insn we execute anywhere on the page. Signed-off-by: Richard Henderson --- target/nios2/translate.c | 3 ++- 1 file changed, 2

[PATCH v2 1/7] target/nios2: Replace DISAS_TB_JUMP with DISAS_NORETURN

The only semantic of DISAS_TB_JUMP is that we've done goto_tb, which is the same as DISAS_NORETURN -- we've exited the tb. Signed-off-by: Richard Henderson --- target/nios2/translate.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/target/nios2/translate.c b/target/n

[PATCH v2 3/7] target/nios2: Use global cpu_R

We do not need to copy this into DisasContext. Signed-off-by: Richard Henderson --- target/nios2/translate.c | 73 +++- 1 file changed, 34 insertions(+), 39 deletions(-) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index 39538e1870..6bdd38

[PATCH v2 7/7] target/nios2: Clean up goto in handle_instruction

Signed-off-by: Richard Henderson --- target/nios2/translate.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index 31f63d9faa..276643cee0 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -753,7

[PATCH v2 4/7] target/nios2: Add DisasContextBase to DisasContext

Migrate the is_jmp, tb and singlestep_enabled fields from DisasContext into the base. Signed-off-by: Richard Henderson --- target/nios2/translate.c | 51 +--- 1 file changed, 27 insertions(+), 24 deletions(-) diff --git a/target/nios2/translate.c b/target/nio

[PATCH v2 0/7] target/nios2: Convert to TranslatorOps

I've reached a point where *all* targets must use the translator loop. Do that, plus some other obvious cleanups. Changes for v2: * Fix (drop) singlestep check for max_insns. We already do that generically. r~ Richard Henderson (7): target/nios2: Replace DISAS_TB_JUMP with DISAS_NORE

[PATCH v2 3/3] target/avr: Convert to TranslatorOps

Signed-off-by: Richard Henderson --- target/avr/translate.c | 234 ++--- 1 file changed, 128 insertions(+), 106 deletions(-) diff --git a/target/avr/translate.c b/target/avr/translate.c index 66e9882422..c06ce45bc7 100644 --- a/target/avr/translate.c +++ b/tar

[PATCH v2 2/3] target/avr: Change ctx to DisasContext* in gen_intermediate_code

Prepare for receiving it as a pointer input. Signed-off-by: Richard Henderson --- target/avr/translate.c | 84 +- 1 file changed, 43 insertions(+), 41 deletions(-) diff --git a/target/avr/translate.c b/target/avr/translate.c index 20c5062730..66e9882422 1

[PATCH v2 1/3] target/avr: Add DisasContextBase to DisasContext

Migrate the bstate, tb and singlestep_enabled fields from DisasContext into the base. Signed-off-by: Richard Henderson --- target/avr/translate.c | 58 +- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/target/avr/translate.c b/target/avr/t

[PATCH v2 0/3] target/avr: Convert to TranslatorOps

I've reached a point where *all* targets must use the translator loop. Changes for v2: * Fix (drop) singlestep check for max_insns. We already do that generically. * Fully initialize DisasContext. It was that last that caused the check-acceptance regression for v1. I simply got lucky th

[PATCH v2 08/11] target/cris: Mark static arrays const

Signed-off-by: Richard Henderson --- target/cris/translate.c | 19 ++- target/cris/translate_v10.c.inc | 6 +++--- 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/target/cris/translate.c b/target/cris/translate.c index f6d1fa914f..83b20162f1 100644 --- a/

[PATCH v2 05/11] target/cris: Fix use_goto_tb

Do not skip the page check for user-only -- mmap/mprotect can still change page mappings. Only check dc->base.pc_first, not dc->ppc -- the start page is the only one that's relevant. Signed-off-by: Richard Henderson --- target/cris/translate.c | 9 ++--- 1 file changed, 2 insertions(+), 7 d

[PATCH v2 09/11] target/cris: Move delayed branch handling to tb_stop

By moving the code here, we can re-use other end-of-tb code, e.g. the evaluation of flags. Honor single stepping. Signed-off-by: Richard Henderson --- target/cris/translate.c | 82 ++--- 1 file changed, 45 insertions(+), 37 deletions(-) diff --git a/target/c

[PATCH v2 02/11] target/cris: Replace DISAS_TB_JUMP with DISAS_NORETURN

The only semantic of DISAS_TB_JUMP is that we've done goto_tb, which is the same as DISAS_NORETURN -- we've exited the tb. Signed-off-by: Richard Henderson --- target/cris/translate.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/target/cris/translate.c b/target/cris

[PATCH v2 11/11] target/cris: Improve JMP_INDIRECT

Use movcond instead of brcond to set env_pc. Discard the btarget and btaken variables to improve register allocation and avoid unnecessary writeback. Signed-off-by: Richard Henderson --- target/cris/translate.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff

[PATCH v2 10/11] target/cris: Use tcg_gen_lookup_and_goto_ptr

We can use this in gen_goto_tb and for DISAS_JUMP to indirectly chain to the next TB. Signed-off-by: Richard Henderson --- target/cris/translate.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/cris/translate.c b/target/cris/translate.c index 0e925320b3..c33324b988

[PATCH v2 04/11] target/cris: Remove DISAS_SWI

This value is unused. Signed-off-by: Richard Henderson --- target/cris/translate.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/cris/translate.c b/target/cris/translate.c index f8b574b0b6..24dbae6d58 100644 --- a/target/cris/translate.c +++ b/target/cris/translate.c @@ -55,7 +55,6

[PATCH v2 03/11] target/cris: Mark exceptions as DISAS_NORETURN

After we've raised the exception, we have left the TB. Signed-off-by: Richard Henderson --- target/cris/translate.c | 5 +++-- target/cris/translate_v10.c.inc | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/target/cris/translate.c b/target/cris/translate.c index 2

[PATCH v2 06/11] target/cris: Convert to TranslatorOps

Signed-off-by: Richard Henderson --- target/cris/translate.c | 313 ++-- 1 file changed, 170 insertions(+), 143 deletions(-) diff --git a/target/cris/translate.c b/target/cris/translate.c index 9e1f2f9239..f6d1fa914f 100644 --- a/target/cris/translate.c +++ b/

[PATCH v2 07/11] target/cris: Mark helper_raise_exception noreturn

Signed-off-by: Richard Henderson --- target/cris/helper.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/cris/helper.h b/target/cris/helper.h index 20d21c4358..3abf608682 100644 --- a/target/cris/helper.h +++ b/target/cris/helper.h @@ -1,4 +1,4 @@ -DEF_HELPER_2(raise_e

[PATCH v2 01/11] target/cris: Add DisasContextBase to DisasContext

Migrate the is_jmp, tb and singlestep_enabled fields from DisasContext into the base. Signed-off-by: Richard Henderson --- target/cris/translate.c | 49 + target/cris/translate_v10.c.inc | 4 +-- 2 files changed, 27 insertions(+), 26 deletions(-) diff --

  1   2   >