Re: [PATCH v7 09/10] virtio-pci: add support for configure interrupt

2021-06-06 Thread Cindy Lu
On Thu, Jun 3, 2021 at 2:45 PM Jason Wang wrote: > > > 在 2021/6/2 上午11:47, Cindy Lu 写道: > > Add support for configure interrupt, use kvm_irqfd_assign and set the > > gsi to kernel. When the configure notifier was eventfd_signal by host > > kernel, this will finally inject an msix interrupt to gues

Re: [PATCH 1/2] Remove leading underscores from QEMU defines

2021-06-06 Thread Thomas Huth
On 05/06/2021 19.49, Ahmed Abouzied wrote: Leading underscores followed by a capital letter or underscore are reserved by the C standard. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/369 Signed-off-by: Ahmed Abouzied --- include/fpu/softfloat-helpers.h | 4 ++-- inclu

Re: [PATCH v7 08/10] virtio-pci: decouple virtqueue from kvm_virtio_pci_vector_use

2021-06-06 Thread Cindy Lu
On Thu, Jun 3, 2021 at 2:39 PM Jason Wang wrote: > > > 在 2021/6/2 上午11:47, Cindy Lu 写道: > > inorder > > > s/inorder/In order/ > > > > to support configure interrupt, we need to decouple > > virtqueue from vector use and vector release function > > this patch introduce vector_release_one and vector

Re: [PATCH v7 07/10] virtio-mmio: add support for configure interrupt

2021-06-06 Thread Cindy Lu
On Thu, Jun 3, 2021 at 2:36 PM Jason Wang wrote: > > > 在 2021/6/2 上午11:47, Cindy Lu 写道: > > Add configure interrupt support for virtio-mmio bus. This > > interrupt will working while backend is vhost-vdpa > > > > Signed-off-by: Cindy Lu > > --- > > hw/virtio/virtio-mmio.c | 26 +

Re: [PATCH 2/2] Remove leading underscores from Xen defines

2021-06-06 Thread Thomas Huth
On 05/06/2021 19.50, Ahmed Abouzied wrote: Identifiers with leading underscores followed by capital letters or underscores are reserved for C standards. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/369 Signed-off-by: Ahmed Abouzied --- include/hw/xen/interface/grant_table.h | 4 +

Re: [PATCH v7 05/10] vhost-vdpa: add support for config interrupt call back

2021-06-06 Thread Cindy Lu
On Thu, Jun 3, 2021 at 2:06 PM Jason Wang wrote: > > > 在 2021/6/2 上午11:47, Cindy Lu 写道: > > Add new call back function in vhost-vdpa, this call back function only > > supported in vhost-vdpa backend > > > > Signed-off-by: Cindy Lu > > --- > > hw/virtio/trace-events | 2 ++ > > hw/virtio/vhost-

Re: TCG op for 32 bit only cpu on qemu-riscv64

2021-06-06 Thread Alistair Francis
On Mon, Jun 7, 2021 at 1:09 PM LIU Zhiwei wrote: > > Hi Alistair, > > As I see, we are moving on to remove TARGET_RISCV64 macro. > > I have some questions: > > 1) Which tcg op should use when translate an instruction for 32bit cpu. > The tcg_*_i64, tcg_*_i32 or tcg_*_tl? > I see some API such as

Re: [PATCH v7 10/10] virtio-net: add peer_deleted check in virtio_net_handle_rx

2021-06-06 Thread Cindy Lu
On Thu, Jun 3, 2021 at 2:58 PM Jason Wang wrote: > > 在 2021/6/2 上午11:47, Cindy Lu 写道: > > During the test, We found this function will continue running > > while the peer is deleted, this will cause the crash. so add > > check for this. this only exist in machines type microvm > > > Any idea why

Re: [RFC PATCH 00/11] hw/nvme: reimplement all multi-aio commands with custom aiocbs

2021-06-06 Thread Klaus Jensen
Hi Vladimir, Thanks for taking the time to look through this! I'll try to comment on all your observations below. On Jun 7 08:14, Vladimir Sementsov-Ogievskiy wrote: 04.06.2021 09:52, Klaus Jensen wrote: From: Klaus Jensen This series reimplements flush, dsm, copy, zone reset and format nv

Re: [PATCH v3 1/7] file-posix: fix max_iov for /dev/sg devices

2021-06-06 Thread Vladimir Sementsov-Ogievskiy
07.06.2021 08:39, Vladimir Sementsov-Ogievskiy wrote: 03.06.2021 16:37, Paolo Bonzini wrote: Even though it was only called for devices that have bs->sg set (which must be character devices), sg_get_max_segments looked at /sys/dev/block which only works for block devices. On Linux the sg driver

Re: debug script for QEMU/KVM

2021-06-06 Thread Thomas Huth
On 07/06/2021 00.52, Kallol Biswas wrote: How can I find Qiang Li's blog and other qemu-developers' blogs? Hi, I don't know about about Qiang Li's blog, but most QEMU developers' blogs are aggregated here: https://planet.virt-tools.org/ You can find the links to the individual blogs on

[Bug 1920013] Re: Unable to pass-through PCIe devices from a ppc64le host to an x86_64 guest

2021-06-06 Thread Thomas Huth
Thanks for moving it over! ... so I'm closing this on Launchpad now. ** Changed in: qemu Status: Incomplete => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1920013 Title: Unable to

Re: The latest Qemu release can't bootup VM with latest guest kernel.

2021-06-06 Thread Yang Zhong
On Thu, Jun 03, 2021 at 04:22:55PM +0200, Claudio Fontana wrote: > On 6/3/21 4:08 PM, Dr. David Alan Gilbert wrote: > > * Yang Zhong (yang.zh...@intel.com) wrote: > >> On Sun, May 23, 2021 at 03:23:30PM +0300, Gal Hammer wrote: > >>> Hi Yang, > >>> > >>> On Thu, 20 May 2021 at 11:27, Yang Zhong wr

Re: [PATCH v3 1/7] file-posix: fix max_iov for /dev/sg devices

2021-06-06 Thread Vladimir Sementsov-Ogievskiy
03.06.2021 16:37, Paolo Bonzini wrote: Even though it was only called for devices that have bs->sg set (which must be character devices), sg_get_max_segments looked at /sys/dev/block which only works for block devices. On Linux the sg driver has its own way to provide the maximum number of iovec

Re: [RFC PATCH 00/11] hw/nvme: reimplement all multi-aio commands with custom aiocbs

2021-06-06 Thread Vladimir Sementsov-Ogievskiy
04.06.2021 09:52, Klaus Jensen wrote: From: Klaus Jensen This series reimplements flush, dsm, copy, zone reset and format nvm to allow cancellation. I posted an RFC back in March ("hw/block/nvme: convert ad-hoc aio tracking to aiocb") and I've applied some feedback from Stefan and reimplemented

Re: [RFC PATCH 5/5] target/ppc: powerpc_excp: Move interrupt raising code to QOM

2021-06-06 Thread David Gibson
On Tue, Jun 01, 2021 at 06:46:49PM -0300, Fabiano Rosas wrote: > This patch introduces a new way to dispatch the emulated interrupts in > powerpc_excp. It leverages the QEMU object model to store the > implementations for each interrupt and link them to their identifier > from POWERPC_EXCP enum. Th

Re: [PATCH 02/11] target/ppc: moved ppc_store_sdr1 to cpu.c

2021-06-06 Thread David Gibson
On Mon, May 31, 2021 at 03:17:47PM -0300, Bruno Piazera Larsen wrote: > > On 13/05/2021 00:50, David Gibson wrote: > > On Wed, May 12, 2021 at 11:08:04AM -0300, Bruno Larsen (billionai) wrote: > > > Moved this function that is required in !TCG cases into a > > > common code file > > The reasons it

Re: [RFC PATCH 4/5] target/ppc: powerpc_excp: Standardize arguments to interrupt code

2021-06-06 Thread David Gibson
On Tue, Jun 01, 2021 at 06:46:48PM -0300, Fabiano Rosas wrote: > The next patches will split the big switch statement in powerpc_excp > into individual functions so it would be cleaner if all variables are > already grouped in a structure and their names consistent. > > This patch makes it so that

Re: [RFC PATCH] target/ppc: removed usage of ppc_store_sdr1 in kvm.c

2021-06-06 Thread David Gibson
On Tue, Jun 01, 2021 at 03:42:42PM -0300, Bruno Larsen (billionai) wrote: > The only use of this function in kvm.c is right after using the KVM > ioctl to get the registers themselves, so there is no need to do the > error checks done by ppc_store_sdr1. > > The probable reason this was here before

Re: [PATCH qemu v20] spapr: Implement Open Firmware client interface

2021-06-06 Thread David Gibson
On Fri, Jun 04, 2021 at 03:59:22PM +0200, BALATON Zoltan wrote: > On Fri, 4 Jun 2021, David Gibson wrote: > > On Wed, Jun 02, 2021 at 02:29:29PM +0200, BALATON Zoltan wrote: > > > On Wed, 2 Jun 2021, David Gibson wrote: > > > > On Thu, May 27, 2021 at 02:42:39PM +0200, BALATON Zoltan wrote: > > > >

Re: [RFC PATCH 4/4] target/ppc: Moved helpers to mmu_helper.c

2021-06-06 Thread David Gibson
On Wed, Jun 02, 2021 at 04:26:04PM -0300, Lucas Mateus Castro (alqotel) wrote: > Moved helpers from target/ppc/mmu-hash64.c to target/ppc/mmu_helpers.c > and removed #ifdef CONFIG_TCG and #include exec/helper-proto.h from > mmu-hash64.c > > Signed-off-by: Lucas Mateus Castro (alqotel) > I'd pref

Re: [RFC PATCH 3/4] target/ppc: moved ppc_store_sdr1 to mmu_common.c

2021-06-06 Thread David Gibson
On Wed, Jun 02, 2021 at 04:26:03PM -0300, Lucas Mateus Castro (alqotel) wrote: > Moved ppc_store_sdr1 to mmu_common.c as it was originally in > mmu_helper.c. > > Signed-off-by: Lucas Mateus Castro (alqotel) > Reviewed-by: David Gibson Though it will need a rebase for comments on the earlier pa

Re: [PATCH qemu v20] spapr: Implement Open Firmware client interface

2021-06-06 Thread David Gibson
On Fri, Jun 04, 2021 at 03:50:28PM +0200, BALATON Zoltan wrote: > On Fri, 4 Jun 2021, David Gibson wrote: > > On Sun, May 30, 2021 at 07:33:01PM +0200, BALATON Zoltan wrote: [snip] > > > MorphOS checks the name property of the root node ("/") to decide what > > > platform it runs on so we may need

Re: [PATCH qemu v20] spapr: Implement Open Firmware client interface

2021-06-06 Thread David Gibson
On Mon, Jun 07, 2021 at 12:21:21AM +0200, BALATON Zoltan wrote: > On Fri, 4 Jun 2021, David Gibson wrote: > > On Wed, Jun 02, 2021 at 02:29:29PM +0200, BALATON Zoltan wrote: > > > On Wed, 2 Jun 2021, David Gibson wrote: > > > > On Thu, May 27, 2021 at 02:42:39PM +0200, BALATON Zoltan wrote: > > > >

Re: [PATCH v2 0/2] DEVICE_UNPLUG_ERROR QAPI event

2021-06-06 Thread David Gibson
On Fri, Jun 04, 2021 at 05:03:51PM -0300, Daniel Henrique Barboza wrote: > Hi, > > This is the v2 of a series that started with 2 events, > DEVICE_UNPLUG_ERROR and DEVICE_NOT_DELETED [1]. After discussions in v1 > we reached the conclussion that the DEVICE_NOT_DELETED wasn't doing much > of anythi

Re: [PATCH qemu v20] spapr: Implement Open Firmware client interface

2021-06-06 Thread David Gibson
On Fri, Jun 04, 2021 at 03:27:12PM +0200, BALATON Zoltan wrote: > On Fri, 4 Jun 2021, David Gibson wrote: > > On Tue, Jun 01, 2021 at 04:12:44PM +0200, BALATON Zoltan wrote: > > > On Tue, 1 Jun 2021, Alexey Kardashevskiy wrote: > > > > On 31/05/2021 23:07, BALATON Zoltan wrote: > > > > > On Sun, 30

Re: [RFC PATCH 1/4] target/ppc: Don't compile ppc_tlb_invalid_all without TCG

2021-06-06 Thread David Gibson
On Wed, Jun 02, 2021 at 04:26:01PM -0300, Lucas Mateus Castro (alqotel) wrote: > The function ppc_tlb_invalid_all is not compiled anymore in a TCG-less > environment, and the call to that function has been disabled in this > situation. > > Signed-off-by: Lucas Mateus Castro (alqotel) > --- > Is t

Re: [PATCH v2 1/2] qapi/machine.json: add DEVICE_UNPLUG_ERROR QAPI event

2021-06-06 Thread David Gibson
On Fri, Jun 04, 2021 at 05:03:52PM -0300, Daniel Henrique Barboza wrote: > At this moment we only provide one event to report a hotunplug error, > MEM_UNPLUG_ERROR. As of Linux kernel 5.12 and QEMU 6.0.0, the pseries > machine is now able to report unplug errors for other device types, such > as CP

Re: [RFC PATCH 2/4] target/ppc: divided mmu_helper.c in 2 files

2021-06-06 Thread David Gibson
On Wed, Jun 02, 2021 at 04:26:02PM -0300, Lucas Mateus Castro (alqotel) wrote: > Moved functions in mmu_helper.c that should be compiled in build to > mmu_common.c, moved declaration of functions that both files use to > cpu.h and moved struct declarations and inline functions needed by > both to t

Re: [PATCH v2 2/2] spapr: use DEVICE_UNPLUG_ERROR to report unplug errors

2021-06-06 Thread David Gibson
On Fri, Jun 04, 2021 at 05:03:53PM -0300, Daniel Henrique Barboza wrote: > Linux Kernel 5.12 is now unisolating CPU DRCs in the device_removal > error path, signalling that the hotunplug process wasn't successful. > This allow us to send a DEVICE_UNPLUG_ERROR in drc_unisolate_logical() > to signal

Re: [PATCH v2 1/2] qapi/machine.json: add DEVICE_UNPLUG_ERROR QAPI event

2021-06-06 Thread David Gibson
On Mon, Jun 07, 2021 at 12:23:08PM +1000, David Gibson wrote: > On Fri, Jun 04, 2021 at 05:03:52PM -0300, Daniel Henrique Barboza wrote: > > At this moment we only provide one event to report a hotunplug error, > > MEM_UNPLUG_ERROR. As of Linux kernel 5.12 and QEMU 6.0.0, the pseries > > machine is

TCG op for 32 bit only cpu on qemu-riscv64

2021-06-06 Thread LIU Zhiwei
Hi Alistair, As I see,  we are moving  on to remove TARGET_RISCV64 macro. I have some questions: 1) Which tcg op should use when translate an instruction for 32bit cpu. The tcg_*_i64, tcg_*_i32 or tcg_*_tl? I see some API such as gen_get_gpr that are using the tcg_*_tl. But I am not sure if i

Re: [PATCH v3 0/7] support dirtyrate at the granualrity of vcpu

2021-06-06 Thread Hyman
cc Chuan Zheng 在 2021/6/7 9:11, huang...@chinatelecom.cn 写道: From: Hyman Huang(黄勇) v3: - pick up "migration/dirtyrate: make sample page count configurable" to make patchset apply master correctly v2: - rebase to "migration/dirtyrate: make sample page count configurable" - rename "vcpu" t

[PATCH v3 5/7] migration/dirtyrate: adjust struct DirtyRateStat

2021-06-06 Thread huangy81
From: Hyman Huang(黄勇) use union to store stat data of two mutual exclusive methods. Signed-off-by: Hyman Huang(黄勇) --- migration/dirtyrate.c | 40 +--- migration/dirtyrate.h | 18 +++--- 2 files changed, 36 insertions(+), 22 deletions(-) diff --

[PATCH v3 1/7] migration/dirtyrate: make sample page count configurable

2021-06-06 Thread huangy81
From: Hyman Huang(黄勇) introduce optional sample-pages argument in calc-dirty-rate, making sample page count per GB configurable so that more accurate dirtyrate can be calculated. Signed-off-by: Hyman Huang(黄勇) --- migration/dirtyrate.c | 31 +++ migration/dirtyrate.

[PATCH v3 6/7] memory: make global_dirty_log a bitmask

2021-06-06 Thread huangy81
From: Hyman Huang(黄勇) dirty rate measurement may start or stop dirty logging during calculation. this conflict with migration because stop dirty log make migration leave dirty pages out then that'll be a problem. make global_dirty_log a bitmask can let both migration and dirty rate measurement w

[PATCH v3 2/7] hmp: Add "calc_dirty_rate" and "info dirty_rate" cmds

2021-06-06 Thread huangy81
From: Peter Xu These two commands are missing when adding the QMP sister commands. Add them, so developers can play with them easier. Signed-off-by: Peter Xu Signed-off-by: Hyman Huang(黄勇) --- hmp-commands-info.hx | 13 hmp-commands.hx | 14 + include/monitor/h

[PATCH v3 7/7] migration/dirtyrate: implement dirty-ring dirtyrate calculation

2021-06-06 Thread huangy81
From: Hyman Huang(黄勇) use dirty ring feature to implement dirtyrate calculation. to enable it, set vcpu option as true in calc-dirty-rate. add per_vcpu as mandatory option in calc_dirty_rate, to calculate dirty rate for vcpu, and use hmp cmd: (qemu) calc_dirty_rate 1 on Signed-off-by: Hyman Hua

[PATCH v3 4/7] migration/dirtyrate: add per-vcpu option for calc-dirty-rate

2021-06-06 Thread huangy81
From: Hyman Huang(黄勇) calculate dirtyrate for each vcpu if vcpu is true, add the dirtyrate of each vcpu to the return value also. Signed-off-by: Hyman Huang(黄勇) --- migration/dirtyrate.c | 45 ++- migration/dirtyrate.h | 1 + qapi/migration.json | 29

[PATCH v3 0/7] support dirtyrate at the granualrity of vcpu

2021-06-06 Thread huangy81
From: Hyman Huang(黄勇) v3: - pick up "migration/dirtyrate: make sample page count configurable" to make patchset apply master correctly v2: - rebase to "migration/dirtyrate: make sample page count configurable" - rename "vcpu" to "per_vcpu" to show the per-vcpu method - squash patch 5/6 into

[PATCH v3 3/7] KVM: introduce dirty_pages and kvm_dirty_ring_enabled

2021-06-06 Thread huangy81
From: Hyman Huang(黄勇) dirty_pages is used to calculate dirtyrate via dirty ring, when enabled, kvm-reaper will increase the dirty pages after gfns being dirtied. kvm_dirty_ring_enabled shows if kvm-reaper is working. dirtyrate thread could use it to check if measurement can base on dirty ring fe

debug script for QEMU/KVM

2021-06-06 Thread Kallol Biswas
Hi, I am planning to develop an open source debug package that will bring visibility to a KVM It will navigate through the data structures and display information in a text file and on a web page. I have never worked on Qemu/KVM and so a guideline from a book like Qiang Li's book "Qemu/KVM Sou

Re: [PATCH qemu v20] spapr: Implement Open Firmware client interface

2021-06-06 Thread BALATON Zoltan
On Fri, 4 Jun 2021, David Gibson wrote: On Wed, Jun 02, 2021 at 02:29:29PM +0200, BALATON Zoltan wrote: On Wed, 2 Jun 2021, David Gibson wrote: On Thu, May 27, 2021 at 02:42:39PM +0200, BALATON Zoltan wrote: On Thu, 27 May 2021, David Gibson wrote: On Tue, May 25, 2021 at 12:08:45PM +0200, BA

[PATCH RFC] USB Video Class device emulation.

2021-06-06 Thread Raphael Lisicki
This continues work started by Natalia Portillo , as submitted here: https://lists.nongnu.org/archive/html/qemu-devel/2010-06/msg01126.html I have updated the changes so that the patch now applies to v4.2.1. Video input has been expanded to support user-mode buffers so that an UVC device itself c

Re: [RFC PATCH 2/5] ppc/pegasos2: Introduce Pegasos2MachineState structure

2021-06-06 Thread BALATON Zoltan
On Sun, 6 Jun 2021, Philippe Mathieu-Daudé wrote: On 6/6/21 5:46 PM, BALATON Zoltan wrote: Add own machine state structure which will be used to store state needed for firmware emulation. Signed-off-by: BALATON Zoltan --- hw/ppc/pegasos2.c | 50 +++

Re: [PATCH 8/8] Fixes for seconday CPU start-up.

2021-06-06 Thread Richard Henderson
On 6/2/21 8:53 PM, Jason Thorpe wrote: Changes to make secondary CPU start-up work on NetBSD, which depends on some specific behavior in the architecture specification: - Change the internal swppal() function to take the new VPTPTR and Procedure Value as explicit arguments. Adapt do_start()

Re: [PATCH 0/8] PALcode fixes required to run NetBSD/alpha.

2021-06-06 Thread Richard Henderson
On 6/2/21 8:53 PM, Jason Thorpe wrote: Jason Thorpe (8): Make qemu-palcode build environment standalone. NFC. Fix delivery of unaligned access exceptions. Fix initialization of the hwrpb.hwrpb.cpuid field. Make some PCI macros available to other files. NFC. Fix incorrect initializ

Re: [PATCH 7/8] Provide a Console Terminal Block in the HWRPB.

2021-06-06 Thread Jason Thorpe
> On Jun 6, 2021, at 12:27 PM, Richard Henderson > wrote: > > On 6/2/21 8:53 PM, Jason Thorpe wrote: >> + hwrpb.hwrpb.ctbt_offset = offsetof(struct hwrpb_combine, ctb); >> + hwrpb.hwrpb.ctb_size = sizeof(hwrpb.ctb); >> + if (have_vga && !CONFIG_NOGRAPHICS(config)) >> +{ >> + hwrpb

[PATCH v2 5/6] memory: make global_dirty_log a bitmask

2021-06-06 Thread huangy81
From: Hyman Huang(黄勇) dirty rate measurement may start or stop dirty logging during calculation. this conflict with migration because stop dirty log make migration leave dirty pages out then that'll be a problem. make global_dirty_log a bitmask can let both migration and dirty rate measurement w

[PATCH v2 3/6] migration/dirtyrate: add per-vcpu option for calc-dirty-rate

2021-06-06 Thread huangy81
From: Hyman Huang(黄勇) calculate dirtyrate for each vcpu if vcpu is true, add the dirtyrate of each vcpu to the return value also. Signed-off-by: Hyman Huang(黄勇) --- migration/dirtyrate.c | 45 ++- migration/dirtyrate.h | 1 + qapi/migration.json | 29

[PATCH v2 6/6] migration/dirtyrate: implement dirty-ring dirtyrate calculation

2021-06-06 Thread huangy81
From: Hyman Huang(黄勇) use dirty ring feature to implement dirtyrate calculation. to enable it, set vcpu option as true in calc-dirty-rate. add per_vcpu as mandatory option in calc_dirty_rate, to calculate dirty rate for vcpu, and use hmp cmd: (qemu) calc_dirty_rate 1 on Signed-off-by: Hyman Hua

[PATCH v2 4/6] migration/dirtyrate: adjust struct DirtyRateStat

2021-06-06 Thread huangy81
From: Hyman Huang(黄勇) use union to store stat data of two mutual exclusive methods. Signed-off-by: Hyman Huang(黄勇) --- migration/dirtyrate.c | 40 +--- migration/dirtyrate.h | 18 +++--- 2 files changed, 36 insertions(+), 22 deletions(-) diff --

[PATCH v2 2/6] KVM: introduce dirty_pages and kvm_dirty_ring_enabled

2021-06-06 Thread huangy81
From: Hyman Huang(黄勇) dirty_pages is used to calculate dirtyrate via dirty ring, when enabled, kvm-reaper will increase the dirty pages after gfns being dirtied. kvm_dirty_ring_enabled shows if kvm-reaper is working. dirtyrate thread could use it to check if measurement can base on dirty ring fe

[PATCH v2 1/6] hmp: Add "calc_dirty_rate" and "info dirty_rate" cmds

2021-06-06 Thread huangy81
From: Peter Xu These two commands are missing when adding the QMP sister commands. Add them, so developers can play with them easier. Signed-off-by: Peter Xu Signed-off-by: Hyman Huang(黄勇) --- hmp-commands-info.hx | 13 hmp-commands.hx | 14 + include/monitor/h

[PATCH v2 0/6] support dirtyrate at the granualrity of vcpu

2021-06-06 Thread huangy81
From: Hyman Huang(黄勇) v2: - rebase to "migration/dirtyrate: make sample page count configurable" - rename "vcpu" to "per_vcpu" to show the per-vcpu method - squash patch 5/6 into a single one, squash patch 1/2 also - pick up "hmp: Add "calc_dirty_rate" and "info dirty_rate" cmds" - make glob

Re: [PATCH 7/8] Provide a Console Terminal Block in the HWRPB.

2021-06-06 Thread Richard Henderson
On 6/2/21 8:53 PM, Jason Thorpe wrote: + hwrpb.hwrpb.ctbt_offset = offsetof(struct hwrpb_combine, ctb); + hwrpb.hwrpb.ctb_size = sizeof(hwrpb.ctb); + if (have_vga && !CONFIG_NOGRAPHICS(config)) +{ + hwrpb.ctb.term_type = CTB_GRAPHICS; + hwrpb.ctb.turboslot = (CTB_TURBOSLOT_TYPE_P

Re: [RFC PATCH 2/5] ppc/pegasos2: Introduce Pegasos2MachineState structure

2021-06-06 Thread Philippe Mathieu-Daudé
On 6/6/21 5:46 PM, BALATON Zoltan wrote: > Add own machine state structure which will be used to store state > needed for firmware emulation. > > Signed-off-by: BALATON Zoltan > --- > hw/ppc/pegasos2.c | 50 +++ > 1 file changed, 37 insertions(+), 13 d

[Bug 1920013] Re: Unable to pass-through PCIe devices from a ppc64le host to an x86_64 guest

2021-06-06 Thread cyrozap
I've moved this bug over to GitLab here: https://gitlab.com/qemu- project/qemu/-/issues/391 ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #391 https://gitlab.com/qemu-project/qemu/-/issues/391 -- You received this bug notification because you are a member of qemu- devel-ml, which

Re: [PATCH 3/3] target/arm: Diagnose UNALLOCATED in disas_simd_three_reg_same_fp16

2021-06-06 Thread Philippe Mathieu-Daudé
On 6/4/21 8:35 PM, Richard Henderson wrote: > This fprintf+assert has been in place since the beginning. > It is after to the fp_access_check, so we need to move the > check up. Fold that in to the pairwise filter. > > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.c | 82 +++

Re: [PATCH 2/3] target/arm: Remove fprintf from disas_simd_mod_imm

2021-06-06 Thread Philippe Mathieu-Daudé
On 6/4/21 8:35 PM, Richard Henderson wrote: > The default of this switch is truly unreachable. > The switch selector is 3 bits, and all 8 cases are present. > > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Philippe Mathi

Re: [PATCH 1/3] target/arm: Diagnose UNALLOCATED in disas_simd_two_reg_misc_fp16

2021-06-06 Thread Philippe Mathieu-Daudé
On 6/4/21 8:35 PM, Richard Henderson wrote: > This fprintf+assert has been in place since the beginning. > It is prior to the fp_access_check, so we're still good to > raise sigill here. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/381 > Signed-off-by: Richard Henderson > --- > ta

Re: [Qemu-devel] [PATCH] configure: Define NCURSES_WIDECHAR if we're using curses

2021-06-06 Thread Stefan Weil
Am 02.06.17 um 16:35 schrieb Peter Maydell: We want the wide character functions from the ncurses header. Unfortunately it doesn't provide them by default, but only if either: * NCURSES_WIDECHAR is defined (for ncurses 20111030 and up) * _XOPEN_SOURCE/_XOPEN_SOURCE_EXTENDED are suitably defi

[RFC PATCH 4/5] ppc/pegasos2: Use Virtual Open Firmware as firmware replacement

2021-06-06 Thread BALATON Zoltan
The pegasos2 board comes with an Open Firmware compliant ROM based on SmartFirmware but it has some changes that are not open source therefore the ROM binary cannot be included in QEMU. Guests running on the board however depend on services provided by the firmware. The Virtual Open Firmware recent

[RFC PATCH 0/5] ppc/Pegasos2 VOF

2021-06-06 Thread BALATON Zoltan
Based-on: <20210520090557.435689-1-...@ozlabs.ru> ^ That is v20 of Alexey's VOF patch Hello, Posting these for early review now. I plan to rebase on the next VOF patch that hopefully fixes those points that I had to circumvent in patch 1 for now. I've reported these before but now all of those

[RFC PATCH 5/5] ppc/pegasos2: Implement some RTAS functions with VOF

2021-06-06 Thread BALATON Zoltan
Linux uses RTAS functions to access PCI devices so we need to provide these with VOF. Implement some of the most important functions to allow booting Linux with VOF. With this the board is now usable without a binary ROM image and we can enable it by default as other boards. Signed-off-by: BALATON

[RFC PATCH 3/5] target/ppc: Allow virtual hypervisor on CPU without HV

2021-06-06 Thread BALATON Zoltan
Change the assert in ppc_store_sdr1() to allow vhyp to be set on CPUs without HV bit. This allows using the vhyp interface for firmware emulation on pegasos2. Signed-off-by: BALATON Zoltan --- target/ppc/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/ppc/cpu.c b

[RFC PATCH 2/5] ppc/pegasos2: Introduce Pegasos2MachineState structure

2021-06-06 Thread BALATON Zoltan
Add own machine state structure which will be used to store state needed for firmware emulation. Signed-off-by: BALATON Zoltan --- hw/ppc/pegasos2.c | 50 +++ 1 file changed, 37 insertions(+), 13 deletions(-) diff --git a/hw/ppc/pegasos2.c b/hw/ppc/pe

[RFC PATCH 1/5] Misc VOF fixes

2021-06-06 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan --- hw/ppc/vof.c| 11 +++ pc-bios/vof.bin | Bin 3784 -> 3784 bytes pc-bios/vof/entry.S | 2 +- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/hw/ppc/vof.c b/hw/ppc/vof.c index a283b7d251..ac95be9666 100644 --- a/hw/ppc/vof.c ++

Re: [PATCH 01/11] hw/char: Renesas SCI module.

2021-06-06 Thread Yoshinori Sato
On Fri, 04 Jun 2021 18:09:44 +0900, Peter Maydell wrote: > > On Thu, 27 May 2021 at 06:30, Yoshinori Sato > wrote: > > > > This module supported SCI / SCIa / SCIF. > > > > Hardware manual. > > SCI / SCIF > > https://www.renesas.com/us/en/doc/products/mpumcu/001/r01uh0457ej0401_sh7751.pdf > > SCI

Re: [PATCH 02/11] hw/char: remove sh_serial.

2021-06-06 Thread Yoshinori Sato
On Fri, 04 Jun 2021 19:08:07 +0900, Peter Maydell wrote: > > On Thu, 27 May 2021 at 06:24, Yoshinori Sato > wrote: > > > > Migrate to renesas_sci. > > > > Signed-off-by: Yoshinori Sato > > --- > > hw/char/sh_serial.c | 431 > > MAINTAINERS |

Re: [PATCH 02/11] hw/char: remove sh_serial.

2021-06-06 Thread Yoshinori Sato
On Fri, 04 Jun 2021 19:08:07 +0900, Peter Maydell wrote: > > On Thu, 27 May 2021 at 06:24, Yoshinori Sato > wrote: > > > > Migrate to renesas_sci. > > > > Signed-off-by: Yoshinori Sato > > --- > > hw/char/sh_serial.c | 431 > > MAINTAINERS |

Re: [PATCH 01/11] hw/char: Renesas SCI module.

2021-06-06 Thread Yoshinori Sato
On Fri, 04 Jun 2021 18:09:44 +0900, Peter Maydell wrote: > > On Thu, 27 May 2021 at 06:30, Yoshinori Sato > wrote: > > > > This module supported SCI / SCIa / SCIF. > > > > Hardware manual. > > SCI / SCIF > > https://www.renesas.com/us/en/doc/products/mpumcu/001/r01uh0457ej0401_sh7751.pdf > > SCI

Re: [PATCH 02/11] hw/char: remove sh_serial.

2021-06-06 Thread Yoshinori Sato
On Fri, 04 Jun 2021 19:08:07 +0900, Peter Maydell wrote: > > On Thu, 27 May 2021 at 06:24, Yoshinori Sato > wrote: > > > > Migrate to renesas_sci. > > > > Signed-off-by: Yoshinori Sato > > --- > > hw/char/sh_serial.c | 431 > > MAINTAINERS |