[Bug 1922325] Re: s390x-virtio-gpu-ccw module unnecessary?

2021-05-15 Thread Toolybird
I only enable a few emulators and qemu-system-s390x isn't one of them. I was thinking it couldn't be useful on an x86_64 host, even if using the qemu-system-s390x emulator! I guess my understanding was wrong. Will close as invalid. ** Changed in: qemu Status: Incomplete => Invalid -- You

[PATCH v2 7/8] vhost-user-gpu: fix OOB write in 'virgl_cmd_get_capset' (CVE-2021-3546)

2021-05-15 Thread Li Qiang
If 'virgl_cmd_get_capset' set 'max_size' to 0, the 'virgl_renderer_fill_caps' will write the data after the 'resp'. This patch avoid this by checking the returned 'max_size'. virtio-gpu fix: abd7f08b23 ("display: virtio-gpu-3d: check virgl capabilities max_size") Fixes: CVE-2021-3546 Reported-by:

[PATCH v2 2/8] vhost-user-gpu: fix resource leak in 'vg_resource_create_2d' (CVE-2021-3544)

2021-05-15 Thread Li Qiang
Call 'vugbm_buffer_destroy' in error path to avoid resource leak. Fixes: CVE-2021-3544 Reported-by: Li Qiang Reviewed-by: Prasad J Pandit Signed-off-by: Li Qiang --- contrib/vhost-user-gpu/vhost-user-gpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/vhost-user-gpu/vhost-user-gp

[PATCH v2 8/8] vhost-user-gpu: abstract vg_cleanup_mapping_iov

2021-05-15 Thread Li Qiang
Currently in vhost-user-gpu, we free resource directly in the cleanup case of resource. If we change the cleanup logic we need to change several places, also abstruct a 'vg_create_mapping_iov' can be symmetry with the 'vg_create_mapping_iov'. This is like what virtio-gpu does, no function changed.

[PATCH v2 3/8] vhost-user-gpu: fix memory leak in vg_resource_attach_backing (CVE-2021-3544)

2021-05-15 Thread Li Qiang
Check whether the 'res' has already been attach_backing to avoid memory leak. Fixes: CVE-2021-3544 Reported-by: Li Qiang virtio-gpu fix: 204f01b309 ("virtio-gpu: fix memory leak in resource attach backing") Signed-off-by: Li Qiang --- contrib/vhost-user-gpu/vhost-user-gpu.c | 5 + 1 file c

[PATCH v2 1/8] vhost-user-gpu: fix memory disclosure in virgl_cmd_get_capset_info (CVE-2021-3545)

2021-05-15 Thread Li Qiang
Otherwise some of the 'resp' will be leaked to guest. Fixes: CVE-2021-3545 Reported-by: Li Qiang virtio-gpu fix: 42a8dadc74 ("virtio-gpu: fix information leak in getting capset info dispatch") Signed-off-by: Li Qiang --- contrib/vhost-user-gpu/virgl.c | 1 + 1 file changed, 1 insertion(+) dif

[PATCH v2 6/8] vhost-user-gpu: fix memory leak in 'virgl_resource_attach_backing' (CVE-2021-3544)

2021-05-15 Thread Li Qiang
If 'virgl_renderer_resource_attach_iov' failed, the 'res_iovs' will be leaked. Fixes: CVE-2021-3544 Reported-by: Li Qiang virtio-gpu fix: 33243031da ("virtio-gpu-3d: fix memory leak in resource attach backing") Signed-off-by: Li Qiang --- contrib/vhost-user-gpu/virgl.c | 5 - 1 file change

[PATCH v2 5/8] vhost-user-gpu: fix memory leak in 'virgl_cmd_resource_unref' (CVE-2021-3544)

2021-05-15 Thread Li Qiang
The 'res->iov' will be leaked if the guest trigger following sequences: virgl_cmd_create_resource_2d virgl_resource_attach_backing virgl_cmd_resource_unref This patch fixes this. Fixes: CVE-2021-3544 Reported-by: Li Qiang virtio-gpu fix: 5e8e3c4c75 ("virtio-gpu: fix reso

[PATCH v2 0/8] vhost-user-gpu: fix several security issues

2021-05-15 Thread Li Qiang
These security issue is low severity and is similar with the virtio-vga/virtio-gpu device. All of them can be triggered by the guest user. Change since v1: Add the CVE information: Several memory leak issues is combined assigned CVE-2021-3544. Information disclosure is assigned CVE-2021-3545. OOB

[PATCH v2 4/8] vhost-user-gpu: fix memory leak while calling 'vg_resource_unref' (CVE-2021-3544)

2021-05-15 Thread Li Qiang
If the guest trigger following sequences, the attach_backing will be leaked: vg_resource_create_2d vg_resource_attach_backing vg_resource_unref This patch fix this by freeing 'res->iov' in vg_resource_destroy. Fixes: CVE-2021-3544 Reported-by: Li Qiang virtio-gpu fix: 5e

Re: [PATCH v6 07/26] tcg: Add tcg_call_func

2021-05-15 Thread Richard Henderson
On 5/3/21 4:50 PM, Philippe Mathieu-Daudé wrote: Hi Richard, On 5/3/21 1:57 AM, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/internal.h | 5 + tcg/tcg.c | 5 ++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/tcg/internal.h b/tcg/internal.h in

Re: [PULL 21/38] tcg/tci: Implement the disassembler properly

2021-05-15 Thread Richard Henderson
On 5/15/21 5:57 AM, Philippe Mathieu-Daudé wrote: +switch (op) { +case INDEX_op_br: +case INDEX_op_call: +case INDEX_op_exit_tb: +case INDEX_op_goto_tb: +tci_args_l(&tb_ptr, &ptr); +info->fprintf_func(info->stream, "%-12s %p", op_name, ptr); +break;

Re: [PATCH 01/10] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on'

2021-05-15 Thread Bin Meng
On Sun, May 16, 2021 at 1:33 AM Philippe Mathieu-Daudé wrote: > > On 5/14/21 5:02 AM, Bin Meng wrote: > > On Fri, May 14, 2021 at 12:53 AM Philippe Mathieu-Daudé > > wrote: > >> > >> Per the kconfig.rst: > >> > >> A device should be listed [...] ``imply`` if (depending on > >> the QEMU comman

Re: Mac OS real USB device support issue

2021-05-15 Thread Programmingkid
I just wanted to give you guys an update on this issue. The libusb people have fixed the issue with USB device driver detaching on Mac OS. Here is where the code for the fix is located: https://github.com/libusb/libusb/pull/911/commits. I was able to build the library and connect it to QEMU on

[RFC v3 1/1] Implement AVR watchdog timer

2021-05-15 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- MAINTAINERS | 2 + hw/avr/Kconfig| 1 + hw/avr/atmega.c | 15 +- hw/avr/atmega.h | 2 + hw/watchdog/Kconfig | 3 + hw/watchdog/avr_wdt.c | 279 +++

[RFC v3 0/1] Implement AVR WDT (watchdog timer)

2021-05-15 Thread Michael Rolnik
1. Initial implementation of AVR WDT There are two issues with this implementation so I need your help here a. when I configure the WDT to fire an interrupt every 15ms it actually happens every 6 instructions b. when I specify --icount shift=0 qemu stucks changes since v1 1. correct

Re: [PATCH qemu v19] spapr: Implement Open Firmware client interface

2021-05-15 Thread BALATON Zoltan
On Thu, 22 Apr 2021, Alexey Kardashevskiy wrote: The PAPR platform describes an OS environment that's presented by a combination of a hypervisor and firmware. The features it specifies require collaboration between the firmware and the hypervisor. Since the beginning, the runtime component of th

Re: [PATCH v2 0/6] hw/southbridge: QOM'ify vt82c686 as VT82C686B_SOUTHBRIDGE

2021-05-15 Thread BALATON Zoltan
On Sat, 15 May 2021, Philippe Mathieu-Daudé wrote: On 5/15/21 4:37 PM, BALATON Zoltan wrote: On Thu, 13 May 2021, Philippe Mathieu-Daudé wrote: On 5/13/21 1:54 PM, BALATON Zoltan wrote: On Thu, 13 May 2021, Philippe Mathieu-Daudé wrote: On 5/11/21 3:09 PM, BALATON Zoltan wrote: On Tue, 11 Ma

Re: [PATCH] linux-user/elfload: fix filling psinfo->pr_psargs

2021-05-15 Thread Laurent Vivier
Le 13/04/2021 à 22:58, Ilya Leoshkevich a écrit : > The current code dumps the memory between arg_start and arg_end, > which contains the argv pointers. This results in the > > Core was generated by `` > > message when opening the core file in GDB. This is because the code is > supposed to du

Re: [PATCH] linux-user/elfload: add s390x core dumping support

2021-05-15 Thread Laurent Vivier
Le 13/04/2021 à 22:56, Ilya Leoshkevich a écrit : > Provide the following definitions required by the common code: > > * ELF_NREG: with the value of sizeof(s390_regs) / sizeof(long). > * target_elf_gregset_t: define it like all the other arches do. > * elf_core_copy_regs(): similar to kernel's s39

Re: [PATCH v2 12/12] hw/ppc/Kconfig: Add dependency PEGASOS2 -> ATI_VGA

2021-05-15 Thread Philippe Mathieu-Daudé
On 5/15/21 9:41 PM, BALATON Zoltan wrote: > On Sat, 15 May 2021, Philippe Mathieu-Daudé wrote: >> From: Philippe Mathieu-Daudé >> >> While the ATI VGA device isn't a requisite (no crash without it): >> >>  $ qemu-system-ppc -M pegasos2 >>  qemu-system-ppc: standard VGA not available >> >> it is us

Re: [PATCH v2 0/7] linux-user: sigaction fixes/cleanups

2021-05-15 Thread Laurent Vivier
Le 23/04/2021 à 01:02, Richard Henderson a écrit : > Alpha had two bugs, one with the non-ka_restorer fallback > using the wrong offset, and the other with the ka_restorer > value getting lost in do_sigaction. > > Sparc had another bug, where the ka_restorer field was > written to user memory. >

Re: [PATCH 6/7] linux-user: use GDateTime for formatting timestamp for core file

2021-05-15 Thread Laurent Vivier
Le 05/05/2021 à 12:37, Daniel P. Berrangé a écrit : > The GDateTime APIs provided by GLib avoid portability pitfalls, such > as some platforms where 'struct timeval.tv_sec' field is still 'long' > instead of 'time_t'. When combined with automatic cleanup, GDateTime > often results in simpler code t

Re: [PATCH 0/2] linux-user: Small fix for copy_file_range

2021-05-15 Thread Laurent Vivier
Le 03/05/2021 à 19:41, LemonBoy a écrit : > From: Giuseppe Musacchio > > An unwanted sign-extension is currently making the host kernel return > EOVERFLOW > when calling copy_file_range with a count of 0x, despite the host > being > a 64bit platform. > > The fix is only affecting 32bit

Re: [PATCH v2 09/12] hw/pci-host/Kconfig: Add missing dependency MV64361 -> I8259

2021-05-15 Thread BALATON Zoltan
On Sat, 15 May 2021, Philippe Mathieu-Daudé wrote: From: Philippe Mathieu-Daudé Looking at the MV64340 model source, there is a dependency on the 8259 interrupt controller: 523 case MV64340_PCI_1_INTERRUPT_ACKNOWLEDGE_VIRTUAL_REG: 524 /* FIXME: Should this be sent via the PCI bus

Re: [PATCH v2 00/15] linux-user/s390x: some signal fixes

2021-05-15 Thread Laurent Vivier
Le 28/04/2021 à 21:33, Richard Henderson a écrit : > Version 2 splits lazy do-it-all patch. > Patch 1 has an additional fix, so I dropped the r-b. > > r~ > > Richard Henderson (15): > linux-user/s390x: Fix sigframe types > linux-user/s390x: Use uint16_t for signal retcode > linux-user/s390x

Re: [PATCH v2 00/25] linux-user/sparc: Implement rt signals

2021-05-15 Thread Laurent Vivier
Le 26/04/2021 à 04:53, Richard Henderson a écrit : > Supercedes: 20210425155749.896330-1-richard.hender...@linaro.org > ("linux-user/sparc64: Implement signals") > > This time, in the lead-up, merge the sparc and sparc64 directories. > Implement rt signals for sparc32 as well, since there are only

Re: [PATCH] linux-user: Add strace support for printing arguments of llseek

2021-05-15 Thread Laurent Vivier
Le 12/05/2021 à 12:13, Kito Cheng a écrit : > Some target are using llseek instead of _llseek like riscv, > nios2, hexagon, and openrisc. > > Signed-off-by: Kito Cheng > --- > linux-user/strace.c| 3 ++- > linux-user/strace.list | 3 +++ > 2 files changed, 5 insertions(+), 1 deletion(-) > >

Re: [PATCH v2 10/12] hw/isa/vt82c686: Add missing Kconfig dependencies (build error)

2021-05-15 Thread BALATON Zoltan
On Sat, 15 May 2021, Philippe Mathieu-Daudé wrote: From: Philippe Mathieu-Daudé The VT82C686 device model misses various dependencies: /usr/bin/ld: libcommon.fa.p/hw_isa_vt82c686.c.o: in function `vt82c686b_realize': hw/isa/vt82c686.c:622: undefined reference to `i8259_init' /usr/bin/ld:

Re: [PATCH v2 12/12] hw/ppc/Kconfig: Add dependency PEGASOS2 -> ATI_VGA

2021-05-15 Thread BALATON Zoltan
On Sat, 15 May 2021, Philippe Mathieu-Daudé wrote: From: Philippe Mathieu-Daudé While the ATI VGA device isn't a requisite (no crash without it): $ qemu-system-ppc -M pegasos2 qemu-system-ppc: standard VGA not available it is useful to have it with the Pegasos2 machine: $ qemu-system-ppc

Re: [PATCH 0/4] linux-user/arm: fpa11 fix and cleanup

2021-05-15 Thread Laurent Vivier
Le 23/04/2021 à 18:54, Richard Henderson a écrit : > The bug fix is patch 2, the rest is a bit of tidy-up. > > > r~ > > Richard Henderson (4): > linux-user/arm: Split out emulate_arm_fpa11 > linux-user/arm: Do not emulate fpa11 in thumb mode > linux-user/arm: Do not fill in si_code for fpa

Re: [PATCH v2 11/12] hw/isa/vt82c686: Add missing Kconfig dependency (runtime error)

2021-05-15 Thread BALATON Zoltan
On Sat, 15 May 2021, Philippe Mathieu-Daudé wrote: From: Philippe Mathieu-Daudé When building the Pegasos2 machine stand-alone we get: $ qemu-system-ppc -M pegasos2 -bios pegasos2.rom ERROR:qom/object.c:714:object_new_with_type: assertion failed: (type != NULL) Bail out! ERROR:qom/object.c:

Re: [PATCH v2] linux-user: strace now handles unshare syscall args correctly

2021-05-15 Thread Laurent Vivier
Le 06/04/2021 à 16:42, Matus Kysel a écrit : > Syscall unshare did not have custom print function for strace, but it's > argument is same as flags in clone syscall, so it can be easily implemented. > Also updated missing flags from clone_flags. > > Signed-off-by: Matus Kysel > --- > linux-user/

Re: [PATCH qemu v19] spapr: Implement Open Firmware client interface

2021-05-15 Thread BALATON Zoltan
On Sat, 15 May 2021, BALATON Zoltan wrote: On Thu, 22 Apr 2021, Alexey Kardashevskiy wrote: The PAPR platform describes an OS environment that's presented by a combination of a hypervisor and firmware. The features it specifies require collaboration between the firmware and the hypervisor. Sinc

Re: [PATCH v4 17/28] linux-user: Remove dead code

2021-05-15 Thread Laurent Vivier
Le 03/03/2021 à 22:46, Philippe Mathieu-Daudé a écrit : > We can not use watchpoints in user-mode emulation because we > need the softmmu slow path to detect accesses to watchpointed > memory. This code is expanded as empty stub in "hw/core/cpu.h" > anyway, so we can drop it. > > Reviewed-by: Laur

Re: [PULL v3 0/1] Rtd patches

2021-05-15 Thread Marc-André Lureau
Hi On Sat, May 15, 2021 at 5:20 PM Philippe Mathieu-Daudé wrote: > On 5/14/21 8:33 PM, Peter Maydell wrote: > > On Fri, 14 May 2021 at 12:13, wrote: > >> > >> From: Marc-André Lureau > >> > >> The following changes since commit > 2d3fc4e2b069494b1e9e2e4a1e3de24cbc036426: > >> > >> Merge remo

[PATCH] disas/libvixl: Protect C system header for C++ compiler

2021-05-15 Thread Philippe Mathieu-Daudé
When selecting an ARM target on Debian unstable, we get: Compiling C++ object libcommon.fa.p/disas_libvixl_vixl_utils.cc.o FAILED: libcommon.fa.p/disas_libvixl_vixl_utils.cc.o c++ -Ilibcommon.fa.p -I. -I.. [...] -o libcommon.fa.p/disas_libvixl_vixl_utils.cc.o -c ../disas/libvixl/vixl/utils.

[Bug 1914870] Re: libvixl compilation failure on Debian unstable

2021-05-15 Thread Philippe Mathieu-Daudé
** Attachment added: "Full build failure log" https://bugs.launchpad.net/qemu/+bug/1914870/+attachment/5497821/+files/disas_libvixl_vixl_utils.cc.o.log -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bug

[Bug 1914870] Re: libvixl compilation failure on Debian unstable

2021-05-15 Thread Philippe Mathieu-Daudé
Looking at commit 875df03b221 logic ("osdep: protect qemu/osdep.h with extern "C"") I tried this: -- >8 -- diff --git a/disas/libvixl/vixl/utils.h b/disas/libvixl/vixl/utils.h index 5ab134e240..fc28d7456c 100644 --- a/disas/libvixl/vixl/utils.h +++ b/disas/libvixl/vixl/utils.h @@ -27,8 +27,10 @@

[Bug 1914870] Re: libvixl compilation failure on Debian unstable

2021-05-15 Thread Philippe Mathieu-Daudé
Still an issue as of commit 6d34aa9969f. ** Changed in: qemu Status: Incomplete => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1914870 Title: libvixl compilation failure on Debi

[Bug 1926521] Re: QEMU-user ignores MADV_DONTNEED

2021-05-15 Thread Vitaly Buka
New issue on GitLab https://gitlab.com/qemu-project/qemu/-/issues/326 ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #326 https://gitlab.com/qemu-project/qemu/-/issues/326 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[PATCH v2 09/12] hw/pci-host/Kconfig: Add missing dependency MV64361 -> I8259

2021-05-15 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Looking at the MV64340 model source, there is a dependency on the 8259 interrupt controller: 523 case MV64340_PCI_1_INTERRUPT_ACKNOWLEDGE_VIRTUAL_REG: 524 /* FIXME: Should this be sent via the PCI bus somehow? */ 525 if (s->gpp_int_level &&

[PATCH v2 08/12] hw/ppc/Kconfig: Add missing dependency E500 -> DS1338 RTC

2021-05-15 Thread Philippe Mathieu-Daudé
Commit 7abb479c7ab ("PPC: E500: Add FSL I2C controller and integrate RTC with it") added a global dependency on the DS1338 model, instead of a machine one (via Kconfig). This gives trouble when building standalone machines not exposing I2C bus: The following clauses were found for DS1338

Re: [PATCH v2 0/6] hw/southbridge: QOM'ify vt82c686 as VT82C686B_SOUTHBRIDGE

2021-05-15 Thread Philippe Mathieu-Daudé
On 5/15/21 4:37 PM, BALATON Zoltan wrote: > On Thu, 13 May 2021, Philippe Mathieu-Daudé wrote: >> On 5/13/21 1:54 PM, BALATON Zoltan wrote: >>> On Thu, 13 May 2021, Philippe Mathieu-Daudé wrote: On 5/11/21 3:09 PM, BALATON Zoltan wrote: > On Tue, 11 May 2021, Philippe Mathieu-Daudé wrote:

[PATCH v2 07/12] hw/riscv/Kconfig: Restrict NUMA to Virt & Spike machines

2021-05-15 Thread Philippe Mathieu-Daudé
Only the Virt and Spike machines use NUMA. Add a RISCV_NUMA Kconfig symbol and only have these machines select it. Adapt the Meson file to only built it if required. Acked-by: Paolo Bonzini Reviewed-by: Bin Meng Signed-off-by: Philippe Mathieu-Daudé --- hw/riscv/Kconfig | 5 + hw/riscv

[PATCH v2 11/12] hw/isa/vt82c686: Add missing Kconfig dependency (runtime error)

2021-05-15 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé When building the Pegasos2 machine stand-alone we get: $ qemu-system-ppc -M pegasos2 -bios pegasos2.rom ERROR:qom/object.c:714:object_new_with_type: assertion failed: (type != NULL) Bail out! ERROR:qom/object.c:714:object_new_with_type: assertion failed: (type

[PATCH v2 06/12] hw/riscv/Kconfig: Add missing dependency MICROCHIP_PFSOC -> SERIAL

2021-05-15 Thread Philippe Mathieu-Daudé
Commit a8fb0a500a6 ("hw/char: Add Microchip PolarFire SoC MMUART emulation") added a dependency on the SERIAL model, but forgot to add the Kconfig selector. Add the dependency to the MCHP_PFSOC_MMUART symbol to fix when building the MICROCHIP_PFSOC machine stand-alone: /usr/bin/ld: libcommon.fa.

[PATCH v2 05/12] hw/arm/Kconfig: Add missing SDHCI symbol to FSL_IMX25

2021-05-15 Thread Philippe Mathieu-Daudé
Commit bfae1772c43 ("hw/arm/fsl-imx25: Wire up eSDHC controllers") added a dependency on the TYPE_IMX_USDHC model, but forgot to add the Kconfig selector. Fix that to solve when built stand-alone: $ qemu-system-arm -M imx25-pdk qemu-system-arm: missing object type 'imx-usdhc' Aborted (core d

[PATCH v2 10/12] hw/isa/vt82c686: Add missing Kconfig dependencies (build error)

2021-05-15 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé The VT82C686 device model misses various dependencies: /usr/bin/ld: libcommon.fa.p/hw_isa_vt82c686.c.o: in function `vt82c686b_realize': hw/isa/vt82c686.c:622: undefined reference to `i8259_init' /usr/bin/ld: hw/isa/vt82c686.c:624: undefined reference to `i825

[PATCH v2 04/12] hw/arm/Kconfig: Remove unused DS1338 symbol from i.MX25 PDK Board

2021-05-15 Thread Philippe Mathieu-Daudé
In commit c4f00daa5b3 ("imx25-pdk: create ds1338 for qtest inside the test") we removed the DS1338 device from the i.MX25 machine but forgot to remove it in the machine Kconfig definitions, do it now. Acked-by: Paolo Bonzini Reviewed-by: Bin Meng Signed-off-by: Philippe Mathieu-Daudé --- hw/ar

[PATCH v2 03/12] hw/arm/Kconfig: Add missing dependency NPCM7XX -> SMBUS

2021-05-15 Thread Philippe Mathieu-Daudé
The TYPE_NPCM7XX_SMBUS device model exposes an SMBus, but this isn't advertised with proper Kconfig symbol, leading to an early build failure when building NPCM7XX machines standalone: The following clauses were found for AT24C config AT24C depends on I2C select AT24C if NPCM7XX Fi

[PATCH v2 12/12] hw/ppc/Kconfig: Add dependency PEGASOS2 -> ATI_VGA

2021-05-15 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé While the ATI VGA device isn't a requisite (no crash without it): $ qemu-system-ppc -M pegasos2 qemu-system-ppc: standard VGA not available it is useful to have it with the Pegasos2 machine: $ qemu-system-ppc -M pegasos2 -vga none -bios pegasos2.rom -device

[PATCH v2 01/12] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on'

2021-05-15 Thread Philippe Mathieu-Daudé
Per the kconfig.rst: A device should be listed [...] ``imply`` if (depending on the QEMU command line) the board may or may not be started without it. This is the case with the NVDIMM device (it is certainly possible to start a machine without NVDIMM) , so use the 'imply' weak reverse depe

[PATCH v2 02/12] hw/ide/Kconfig: Add missing dependency PCI -> IDE_QDEV

2021-05-15 Thread Philippe Mathieu-Daudé
The pci_ide_create_devs() function is declared i hw/ide/qdev.c: $ git grep ide_create_drive hw/ide/pci.c:491:ide_create_drive(d->bus + bus[i], unit[i], hd_table[i]); hw/ide/qdev.c:127:IDEDevice *ide_create_drive(IDEBus *bus, int unit, DriveInfo *drive) include/hw/ide/internal.h:6

[PATCH v2 00/12] hw: Various Kconfig fixes

2021-05-15 Thread Philippe Mathieu-Daudé
Various Kconfig fixes when building stand-alone machine binaries. Since v1: - Fixed Pegasos2 machine - Removed SEMIHOSTING related patches (will repost them later) Philippe Mathieu-Daudé (12): hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on' hw/ide/Kconfig: Add missing dependency PC

Re: [PATCH 01/10] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on'

2021-05-15 Thread Philippe Mathieu-Daudé
On 5/14/21 5:02 AM, Bin Meng wrote: > On Fri, May 14, 2021 at 12:53 AM Philippe Mathieu-Daudé > wrote: >> >> Per the kconfig.rst: >> >> A device should be listed [...] ``imply`` if (depending on >> the QEMU command line) the board may or may not be started >> without it. >> >> This is the c

Re: [PATCH v6 77/82] target/arm: Fix decode for VDOT (indexed)

2021-05-15 Thread Richard Henderson
On 5/13/21 2:25 PM, Peter Maydell wrote: +static bool do_neon_ddda(DisasContext *s, int q, int vd, int vn, int vm, + int data, gen_helper_gvec_4 *fn_gvec) This patch seems to be doing more than its commit message suggests. If we want to share code between trans_VDOT and

Re: [PATCH v6 77/82] target/arm: Fix decode for VDOT (indexed)

2021-05-15 Thread Richard Henderson
On 5/13/21 2:25 PM, Peter Maydell wrote: -VDOT_scalar 1110 0 . 10 1101 . q:1 index:1 u:1 rm:4 \ - vm=%vm_dp vn=%vn_dp vd=%vd_dp +VDOT_scalar 1110 0 . 10 1101 . q:1 index:1 u:1 vm:4 \ + vn=%vn_dp vd=%vd_dp Is it possible to make thi

Re: [PATCH v6 73/82] target/arm: Implement SVE2 fp multiply-add long

2021-05-15 Thread Richard Henderson
On 5/13/21 12:04 PM, Peter Maydell wrote: We now have a full set of these macros in vec_helper.c and sve_helper.c, and I'm going to need them in the MVE mve_helper.c too. This seems like a good point to pull them out into a suitable header file and add a documentation comment that makes it clear

Re: [PATCH v6 72/82] target/arm: Implement SVE2 bitwise shift immediate

2021-05-15 Thread Richard Henderson
On 5/13/21 11:57 AM, Peter Maydell wrote: On Fri, 30 Apr 2021 at 22:17, Richard Henderson wrote: From: Stephen Long Implements SQSHL/UQSHL, SRSHR/URSHR, and SQSHLU Signed-off-by: Stephen Long Message-Id: <20200430194159.24064-1-stepl...@quicinc.com> Signed-off-by: Richard Henderson ---

Re: [PATCH v3 00/11] PS/2 controller related fixes

2021-05-15 Thread Philippe Mathieu-Daudé
On 5/15/21 4:35 PM, BALATON Zoltan wrote: > On Sat, 15 May 2021, Philippe Mathieu-Daudé wrote: >> On 5/15/21 1:31 PM, Volker Rümelin wrote: >>> This patch series fixes two different PS/2 mouse stream corruptions >>> and adds a feature that allows some old misbehaving DOS programs to >>> have a work

Re: [PATCH v6 69/82] target/arm: Share table of sve load functions

2021-05-15 Thread Richard Henderson
On 5/13/21 9:25 AM, Peter Maydell wrote: @@ -5551,7 +5547,9 @@ static void do_ldrq(DisasContext *s, int zt, int pg, TCGv_i64 addr, int msz) t_pg = tcg_temp_new_ptr(); tcg_gen_addi_ptr(t_pg, cpu_env, poff); -fns[s->be_data == MO_BE][msz](cpu_env, t_pg, addr, t_desc); +gen_hel

Re: [PATCH v6 68/82] target/arm: Implement SVE2 FLOGB

2021-05-15 Thread Richard Henderson
On 5/13/21 9:18 AM, Peter Maydell wrote: +static int64_t do_float64_logb_as_int(float64 a, float_status *s) +{ +if (float64_is_normal(a)) { +return extract64(a, 52, 11) - 1023; +} else if (float64_is_infinity(a)) { +return INT64_MAX; +} else if (float64_is_any_nan(a) |

Re: [PATCH qemu v19] spapr: Implement Open Firmware client interface

2021-05-15 Thread BALATON Zoltan
On Thu, 22 Apr 2021, Alexey Kardashevskiy wrote: The PAPR platform describes an OS environment that's presented by a combination of a hypervisor and firmware. The features it specifies require collaboration between the firmware and the hypervisor. Since the beginning, the runtime component of th

[Bug 1883268] Re: random errors on aarch64 when executing __aarch64_cas8_acq_rel

2021-05-15 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1922887] Re: STR in Thumb 32 decode problem

2021-05-15 Thread Thomas Huth
Patch has been merged: https://gitlab.com/qemu-project/qemu/-/commit/8196fe9d83d6519128b5 ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs

[Bug 1926246] Re: chrome based apps can not be run under qemu user mode

2021-05-15 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/324 ** Changed in: qemu Status: New => Expired ** Bug watch

Re: [PATCH v2 0/6] hw/southbridge: QOM'ify vt82c686 as VT82C686B_SOUTHBRIDGE

2021-05-15 Thread BALATON Zoltan
On Thu, 13 May 2021, Philippe Mathieu-Daudé wrote: On 5/13/21 1:54 PM, BALATON Zoltan wrote: On Thu, 13 May 2021, Philippe Mathieu-Daudé wrote: On 5/11/21 3:09 PM, BALATON Zoltan wrote: On Tue, 11 May 2021, Philippe Mathieu-Daudé wrote: Hi Zoltan, On 5/11/21 1:28 PM, BALATON Zoltan wrote: O

Re: [PATCH v3 00/11] PS/2 controller related fixes

2021-05-15 Thread BALATON Zoltan
On Sat, 15 May 2021, Philippe Mathieu-Daudé wrote: On 5/15/21 1:31 PM, Volker Rümelin wrote: This patch series fixes two different PS/2 mouse stream corruptions and adds a feature that allows some old misbehaving DOS programs to have a working keyboard. With the last few patches, the PS/2 con- t

Re: [PATCH 2/2] tests/acceptance: Add tests for the Pegasos2 machine

2021-05-15 Thread BALATON Zoltan
On Sat, 15 May 2021, Philippe Mathieu-Daudé wrote: Add a pair of tests for the Pegasos2 machine following the steps from: https://lists.nongnu.org/archive/html/qemu-devel/2021-01/msg01553.html $ PEGASOS2_ROM_PATH=/tmp/pegasos2.rom AVOCADO_ALLOW_UNTRUSTED_CODE=1 \ avocado --show=app,console,t

Re: [PATCH v5 0/9] Allow changing bs->file on reopen

2021-05-15 Thread Vladimir Sementsov-Ogievskiy
15.05.2021 16:46, Vladimir Sementsov-Ogievskiy wrote: Hi all! Alberto, I'm sorry for not consulting with you about sending this. Actually, I wanted only one patch "block: Allow changing bs->file on reopen", as I'm going to send another series based on it. Haha. Actually I need instead a way t

[Bug 1923692] Re: qemu 5.2.0: Add reconnect option support for netdev socket

2021-05-15 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/323 ** Tags added: feature-request ** Changed in: qemu Stat

[Bug 1923663] Re: Can't(?) disable default floppy drive any more in qemu 6.0

2021-05-15 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/322 ** Changed in: qemu Status: New => Expired ** Bug watch

[Bug 1918917] Re: synchronous abort on accessing unused I/O ports on aarch64

2021-05-15 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/317 ** Changed in: qemu Status: New => Expired ** Bug watch

[Bug 1922625] Re: qemu 5.2.0 configure script explodes when in read only directory

2021-05-15 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/321 ** Changed in: qemu Status: Confirmed => Expired ** Bug

[Bug 1920602] Re: QEMU crash after a QuickBASIC program integer overflow

2021-05-15 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/318 ** Changed in: qemu Status: Confirmed => Expired ** Bug

[Bug 1921061] Re: Corsair iCUE Install Fails, qemu VM Reboots

2021-05-15 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/320 ** Changed in: qemu Status: Confirmed => Expired ** Bug

[Bug 1920913] Re: Openjdk11+ fails to install on s390x

2021-05-15 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/319 ** Changed in: qemu Status: New => Expired ** Bug watch

[Bug 1914870] Re: libvixl compilation failure on Debian unstable

2021-05-15 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[PATCH v5 5/9] block: bdrv_reopen_parse_backing(): simplify handling implicit filters

2021-05-15 Thread Vladimir Sementsov-Ogievskiy
The logic around finding overlay here is not obvious. Actually it does two simple things: 1. If new bs is already in backing chain, split from parent bs by several implicit filters we are done, do nothing. 2. Otherwise, don't try to replace implicit filter. Let's rewrite this in more obvious

[PATCH v5 2/9] block: introduce bdrv_set_file_or_backing_noperm()

2021-05-15 Thread Vladimir Sementsov-Ogievskiy
To be used for reopen in future commit. Notes: - It seems OK to update inherits_from if new bs is recursively inherits from parent bs. Let's just not check for backing_chain_contains, to support file child of non-filters. - Simply check child->frozen instead of bdrv_is_backing_chain_frozen

[PATCH v5 8/9] block: Allow changing bs->file on reopen

2021-05-15 Thread Vladimir Sementsov-Ogievskiy
From: Alberto Garcia When the x-blockdev-reopen was added it allowed reconfiguring the graph by replacing backing files, but changing the 'file' option was forbidden. Because of this restriction some operations are not possible, notably inserting and removing block filters. This patch adds suppo

[PATCH v5 9/9] iotests: Test replacing files with x-blockdev-reopen

2021-05-15 Thread Vladimir Sementsov-Ogievskiy
From: Alberto Garcia This patch adds new tests in which we use x-blockdev-reopen to change bs->file Signed-off-by: Alberto Garcia --- tests/qemu-iotests/245 | 109 - tests/qemu-iotests/245.out | 11 +++- 2 files changed, 117 insertions(+), 3 deletions(-

[PATCH v5 0/9] Allow changing bs->file on reopen

2021-05-15 Thread Vladimir Sementsov-Ogievskiy
Hi all! Alberto, I'm sorry for not consulting with you about sending this. Actually, I wanted only one patch "block: Allow changing bs->file on reopen", as I'm going to send another series based on it. I started to work on updating this one patch it and it turned into a refactoring series below.

[PATCH v5 3/9] block: bdrv_reopen_parse_backing(): don't check aio context

2021-05-15 Thread Vladimir Sementsov-Ogievskiy
We don't need this check: bdrv_set_backing_noperm() will do it anyway (actually in bdrv_attach_child_common()). Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 33 - 1 file changed, 33 deletions(-) diff --git a/block.c b/block.c index 5141c04815..4e18bc

[PATCH v5 6/9] block: move supports_backing check to bdrv_set_file_or_backing_noperm()

2021-05-15 Thread Vladimir Sementsov-Ogievskiy
Move supports_backing check of bdrv_reopen_parse_backing to called (through bdrv_set_backing_noperm()) bdrv_set_file_or_backing_noperm() function. The check applies to general case, so it's appropriate for bdrv_set_file_or_backing_noperm(). We have to declare backing support for two test drivers,

[PATCH v5 1/9] block: introduce bdrv_remove_file_or_backing_child()

2021-05-15 Thread Vladimir Sementsov-Ogievskiy
To be used for reopen in future commit. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/block.c b/block.c index 9ad725d205..75565ce4d4 100644 --- a/block.c +++ b/block.c @@ -4770,16 +4770,14 @@

[PATCH v5 7/9] block: BDRVReopenState: drop replace_backing_bs field

2021-05-15 Thread Vladimir Sementsov-Ogievskiy
It's used only in bdrv_reopen_commit(). "backing" is covered by the loop through all children except for case when we removed backing child during reopen. Make it more obvious and drop extra boolean field: qdict_del will not fail if there is no such entry. Signed-off-by: Vladimir Sementsov-Ogievs

[PATCH v5 4/9] block: bdrv_reopen_parse_backing(): don't check frozen child

2021-05-15 Thread Vladimir Sementsov-Ogievskiy
bdrv_set_backing_noperm() takes care of it (actual check is in bdrv_set_file_or_backing_noperm()), so we don't need to check it here. While being here, improve error message a bit. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c| 14 +- tests/qemu-iotests/245

[PATCH 1/2] tests/acceptance: Ignore binary data sent on serial console

2021-05-15 Thread Philippe Mathieu-Daudé
If a guest sends binary data on the serial console, we get: File "tests/acceptance/avocado_qemu/__init__.py", line 92, in _console_interaction msg = console.readline().strip() File "/usr/lib64/python3.8/codecs.py", line 322, in decode (result, consumed) = self._buffer_decode(data, self.err

[PATCH 2/2] tests/acceptance: Add tests for the Pegasos2 machine

2021-05-15 Thread Philippe Mathieu-Daudé
Add a pair of tests for the Pegasos2 machine following the steps from: https://lists.nongnu.org/archive/html/qemu-devel/2021-01/msg01553.html $ PEGASOS2_ROM_PATH=/tmp/pegasos2.rom AVOCADO_ALLOW_UNTRUSTED_CODE=1 \ avocado --show=app,console,tesseract \ run -t machine:pegasos2 tests/acce

[PATCH 0/2] tests/acceptance: Add tests for the Pegasos2 machine

2021-05-15 Thread Philippe Mathieu-Daudé
Philippe Mathieu-Daudé (2): tests/acceptance: Ignore binary data sent on serial console tests/acceptance: Add tests for the Pegasos2 machine tests/acceptance/avocado_qemu/__init__.py | 7 +- tests/acceptance/machine_ppc_pegasos.py | 98 +++ 2 files changed, 103 insert

Re: [PULL v3 0/1] Rtd patches

2021-05-15 Thread Philippe Mathieu-Daudé
On 5/14/21 8:33 PM, Peter Maydell wrote: > On Fri, 14 May 2021 at 12:13, wrote: >> >> From: Marc-André Lureau >> >> The following changes since commit 2d3fc4e2b069494b1e9e2e4a1e3de24cbc036426: >> >> Merge remote-tracking branch 'remotes/armbru/tags/pull-misc-2021-05-12' >> into staging (2021-0

[Bug 1926246] Re: chrome based apps can not be run under qemu user mode

2021-05-15 Thread Wind Li
** Changed in: qemu Status: Incomplete => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1926246 Title: chrome based apps can not be run under qemu user mode Status in QEMU: New Bug d

CFP Reminder: KVM Forum 2021

2021-05-15 Thread Paolo Bonzini
KVM Forum 2021 virtual experience September 15-16, 2021 (All submissions must be received before May 31, 2021 at 23:59 PST) = KVM Forum is an annual event that present

Re: [Bug 1914117] Re: Short files returned via FTP on Qemu with various architectures and OSes

2021-05-15 Thread Chris Pinnock
If it’s included in qemu when one downloads the sources I’m happy. Sent from my iPhone > On 15 May 2021, at 11:55, Thomas Huth <1914...@bugs.launchpad.net> wrote: > > Could we close this ticket now if there is a workaround in libslirp now? > > ** Changed in: qemu > Status: New => Incompl

Re: [PATCH v3 00/11] PS/2 controller related fixes

2021-05-15 Thread Philippe Mathieu-Daudé
On 5/15/21 1:31 PM, Volker Rümelin wrote: > This patch series fixes two different PS/2 mouse stream corruptions > and adds a feature that allows some old misbehaving DOS programs to > have a working keyboard. With the last few patches, the PS/2 con- > troller behaves more like a real controller. >

[PATCH v3 10/11] pckbd: correctly disable PS/2 communication

2021-05-15 Thread Volker Rümelin
Currently the PS/2 controller command KBD_CCMD_MOUSE_DISABLE doesn't disable the PS/2 mouse communication at all, and the PS/2 controller commands KBD_CCMD_KBD_DISABLE and KBD_CCMD_KBD_ENABLE only disable and enable the keyboard interrupt, which is very different from what a real PS/2 controller do

[PATCH v3 07/11] pckbd: add state variable for interrupt source

2021-05-15 Thread Volker Rümelin
Currently there is only one flag to distinguish between two interrupt sources and there are no available flags for more sources. Add an internal state variable to store the interrupt source. The next patch will introduce an additional interrupt source. There is no functional change. Signed-off-by:

[PATCH v3 09/11] pckbd: add function kbd_pending()

2021-05-15 Thread Volker Rümelin
Replace reads of the variable s->pending with a call to a new function kbd_pending() to ease the review of the next patch. There is no functional change. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Volker Rümelin --- hw/input/pckbd.c | 21 ++--- 1 file changed, 14 inserti

  1   2   >