Re: [Bug 1926497] Re: dp83932 stops working after a short while

2021-04-28 Thread Howard Spoelstra
On Wed, Apr 28, 2021 at 11:31 PM Jeff <1926...@bugs.launchpad.net> wrote: > > It looks like using > https://cdimage.debian.org/cdimage/ports/snapshots/2021-04-17/debian-10.0.0 > -m68k-NETINST-1.iso instead fixes the issue. Perhaps the instruction on > https://wiki.qemu.org/Documentation/Platforms/m

Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine

2021-04-28 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Wed, Apr 28, 2021 at 04:18:17PM +0200, Markus Armbruster wrote: >> Stefan Hajnoczi writes: [...] >> > The approach in this patch is okay but we should keep in mind it only >> > solves piix3-ide. ISA provides a non-qdev backdoor API and there may be >> > more instan

Re: [PATCH v4 10/12] qtest/qmp-cmd-test: Make test build-independent from accelerator

2021-04-28 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Now than we can probe if the TCG accelerator is available > at runtime with a QMP command, do it once at the beginning > and only register the tests we can run. > We can then replace the #ifdef'ry by a runtime check. > > Suggested-by: Paolo Bonzini > Signed-off-b

RE: [PATCH] Hexagon (target/hexagon) remove unused functions

2021-04-28 Thread Taylor Simpson
> -Original Message- > From: Philippe Mathieu-Daudé On > Behalf Of Philippe Mathieu-Daudé > Sent: Wednesday, April 28, 2021 11:49 PM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: richard.hender...@linaro.org; a...@rev.ng; Brian Cain > > Subject: Re: [PATCH] Hexagon (target/hexagon)

Re: [PATCH] Hexagon (target/hexagon) remove unused functions

2021-04-28 Thread Philippe Mathieu-Daudé
On Thu, Apr 29, 2021 at 6:49 AM Philippe Mathieu-Daudé wrote: > > Hi Taylor, > > On 4/29/21 5:32 AM, Taylor Simpson wrote: > > Remove gen_read_reg and gen_set_byte > > > > Reported-by: Richard Henderson > > Signed-off-by: Taylor Simpson > > --- > > To help git-tools (and reviewers), please use t

Re: [PATCH] meson: change buildtype when debug_info=no

2021-04-28 Thread Philippe Mathieu-Daudé
On 4/28/21 9:55 PM, Joelle van Dyne wrote: > Meson defaults builds to 'debugoptimized' which adds '-g -O2' > to CFLAGS. If the user specifies '--disable-debug-info' we > should instead build with 'release' which does not emit any > debug info. > > Signed-off-by: Joelle van Dyne > --- > configure

Re: [PATCH] Hexagon (target/hexagon) remove unused functions

2021-04-28 Thread Philippe Mathieu-Daudé
Hi Taylor, On 4/29/21 5:32 AM, Taylor Simpson wrote: > Remove gen_read_reg and gen_set_byte > > Reported-by: Richard Henderson > Signed-off-by: Taylor Simpson > --- To help git-tools (and reviewers), please use the 'Based-on' tag the next time you send a patch depending on another one: Based-o

Re: [RFC PATCH 3/4] target/ppc: Move SPR generation to separate file

2021-04-28 Thread David Gibson
On Wed, Apr 28, 2021 at 02:47:37PM +, Bruno Piazera Larsen wrote: > > > > This move is required to enable building without TCG. > > > > All the logic related to registering SPRs specific to > > > > some architectures or machines has been hidden in this > > > > new file. > > > > > > Hm... I thou

[PATCH v4 3/3] nvdimm: Enable sync-dax device property for nvdimm

2021-04-28 Thread Shivaprasad G Bhat
The patch adds the 'sync-dax' property to the nvdimm device. When the sync-dax is 'direct' indicates the backend is synchronous DAX capable and no explicit flush requests are required. When the mode is set to 'writeback' it indicates the backend is not synhronous DAX capable and explicit flushes t

[PATCH v4 2/3] spapr: nvdimm: Implement H_SCM_FLUSH hcall

2021-04-28 Thread Shivaprasad G Bhat
The patch adds support for the SCM flush hcall for the nvdimm devices. To be available for exploitation by guest through the next patch. The hcall expects the semantics such that the flush to return with H_BUSY when the operation is expected to take longer time along with a continue_token. The hca

[PATCH v4 1/3] spapr: nvdimm: Forward declare and move the definitions

2021-04-28 Thread Shivaprasad G Bhat
The subsequent patches add definitions which tend to get the compilation to cyclic dependency. So, prepare with forward declarations, move the defitions and clean up. Signed-off-by: Shivaprasad G Bhat --- hw/ppc/spapr_nvdimm.c | 12 include/hw/ppc/spapr_nvdimm.h | 14 ++-

[PATCH v4 0/3] nvdimm: Enable sync-dax property for nvdimm

2021-04-28 Thread Shivaprasad G Bhat
The nvdimm devices are expected to ensure write persistence during power failure kind of scenarios. The libpmem has architecture specific instructions like dcbf on POWER to flush the cache data to backend nvdimm device during normal writes followed by explicit flushes if the backend devices are no

Re: [PATCH v6 0/4] Add support for ipv6 host forwarding

2021-04-28 Thread Doug Evans
Ping. On Wed, Apr 14, 2021 at 8:39 PM Doug Evans wrote: > This patchset takes the original patch from Maxim, > https://www.mail-archive.com/qemu-devel@nongnu.org/msg569573.html > and updates it. > > Option hostfwd is extended to support ipv6 addresses. > Commands hostfwd_add, hostfwd_remove are

[PATCH] Hexagon (target/hexagon) remove unused functions

2021-04-28 Thread Taylor Simpson
Remove gen_read_reg and gen_set_byte Reported-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/genptr.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/target/hexagon/genptr.c b/target/hexagon/genptr.c index 55c7cd8..f93f895 100644 --- a/target/hexagon/genp

RE: sysemu SMP scheduling

2021-04-28 Thread Brian Cain
> -Original Message- > From: Brian Cain > Sent: Wednesday, April 28, 2021 10:06 PM > To: qemu-devel@nongnu.org > Cc: Richard Henderson ; Taylor Simpson > ; Michael Lambert ; > Manning, Sid > Subject: sysemu SMP scheduling > > For some hexagon use cases, we would prefer to have finer grain

Re: [PATCH v6 1/9] hw: Add check for queue number

2021-04-28 Thread Cindy Lu
On Tue, Apr 27, 2021 at 1:39 PM Jason Wang wrote: > > > 在 2021/4/27 上午11:39, Cindy Lu 写道: > > In order to support configure interrupt. we will use queue number -1 > > as configure interrupt > > since all these device are not support the configure interrupt > > So we will add an check here, if the

Re: [PATCH v6 7/9] virtio-pci: add support for configure interrupt

2021-04-28 Thread Cindy Lu
On Tue, Apr 27, 2021 at 3:12 PM Jason Wang wrote: > > > 在 2021/4/27 上午11:39, Cindy Lu 写道: > > Add support for configure interrupt, use kvm_irqfd_assign and set the > > gsi to kernel. When the configure notifier was eventfd_signal by host > > kernel, this will finally inject an msix interrupt to gu

sysemu SMP scheduling

2021-04-28 Thread Brian Cain
For some hexagon use cases, we would prefer to have finer grained scheduling among multiple guest cores/threads. We haven't been able to determine exactly what kind of scheduling algorithm is operating in the baseline case. If the current hw thread is ready-to-run and is spinning over a tight

[PATCH] meson: Set implicit_include_directories to false

2021-04-28 Thread Katsuhiro Ueno
Without this, libvixl cannot be compiled with macOS 11.3 SDK due to include file name conflict (usr/include/c++/v1/version conflicts with VERSION). Signed-off-by: Katsuhiro Ueno --- meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/meson.build b/meson.build index c6f4b0cf5e..d007bf

Re: [RFC PATCH v2 6/6] hw/arm/virt: Replace smp_parse with one that prefers cores

2021-04-28 Thread wangyanan (Y)
Hi Drew, On 2021/4/28 18:13, Andrew Jones wrote: On Wed, Apr 28, 2021 at 05:36:43PM +0800, wangyanan (Y) wrote: On 2021/4/27 22:58, Andrew Jones wrote: On Tue, Apr 13, 2021 at 04:07:45PM +0800, Yanan Wang wrote: From: Andrew Jones The virt machine type has never used the CPU topology parame

Re: [RFC PATCH v2 2/4] hw/arm/virt: Parse -smp cluster parameter in virt_smp_parse

2021-04-28 Thread wangyanan (Y)
Hi Drew, On 2021/4/28 18:31, Andrew Jones wrote: On Tue, Apr 13, 2021 at 04:31:45PM +0800, Yanan Wang wrote: There is a separate function virt_smp_parse() in hw/virt/arm.c used to parse cpu topology for the ARM machines. So add parsing of -smp cluster parameter in it, then total number of logic

[PATCH v3] i386/cpu: Remove the deprecated cpu model 'Icelake-Client'

2021-04-28 Thread Robert Hoo
As it's been marked deprecated since v5.2, now I think it's time remove it from code. Signed-off-by: Robert Hoo --- Changelog: v3: Update deprecated.rst. (Sorry for my carelessness in last search. I sware I did search.) v2: Update removed-features.rst. --- docs/system/deprecated.rst

Re: [RFC PATCH v2 1/4] vl.c: Add -smp, clusters=* command line support for ARM cpu

2021-04-28 Thread wangyanan (Y)
On 2021/4/28 18:23, Andrew Jones wrote: On Tue, Apr 13, 2021 at 04:31:44PM +0800, Yanan Wang wrote: A cluster means a group of cores that share some resources (e.g. cache) among them under the LLC. For example, ARM64 server chip Kunpeng 920 has 6 or 8 clusters in each NUMA, and each cluster ha

Re: [PATCH RESEND v2] i386/cpu: Remove the deprecated cpu model 'Icelake-Client'

2021-04-28 Thread Robert Hoo
On Wed, 2021-04-28 at 11:24 -0400, Eduardo Habkost wrote: > On Wed, Apr 28, 2021 at 10:41:13AM +0800, Robert Hoo wrote: > > As it's been marked deprecated since v5.2, now I think it's time > > remove it > > from code. > > > > Signed-off-by: Robert Hoo > > --- > > (Sorry, forgot to append changelo

Re: X on old (non-x86) Linux guests

2021-04-28 Thread BALATON Zoltan
On Wed, 28 Apr 2021, Dr. David Alan Gilbert wrote: * BALATON Zoltan (bala...@eik.bme.hu) wrote: On Wed, 28 Apr 2021, Andrew Randrianasulu wrote: On Wednesday, April 28, 2021, Andrew Randrianasulu wrote: On Monday, April 26, 2021, BALATON Zoltan wrote: On Mon, 26 Apr 2021, Dr. David Alan Gil

Re: [PATCH v4 00/26] Hexagon (target/hexagon) update

2021-04-28 Thread Richard Henderson
On 4/28/21 4:20 PM, Taylor Simpson wrote: I get -Wno-unused-function added to the compiler command line, so I don't see the error. Ah, looks like it's the version of glib on your system. The flag gets added in configure beneath: # Silence clang warnings triggered by glib < 2.57.2 Both w

RE: [PATCH v4 00/26] Hexagon (target/hexagon) update

2021-04-28 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Wednesday, April 28, 2021 4:13 PM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; a...@rev.ng; Brian Cain > Subject: Re: [PATCH v4 00/26] Hexagon (target/hexagon) update > > On 4/8/21 6:07 PM, Taylor Simpson w

[Bug 1926521] [NEW] QEMU-user ignores MADV_DONTNEED

2021-04-28 Thread Vitaly Buka
Public bug reported: There is comment int the code "This is a hint, so ignoring and returning success is ok" https://github.com/qemu/qemu/blob/b1cffefa1b163bce9aebc3416f562c1d3886eeaa/linux-user/syscall.c#L11941 But it seems incorrect with the current state of Linux "man madvise" or https://man

RE: [RUST] Add crate for generic vhost-user-i2c backend daemon

2021-04-28 Thread Trilok Soni
Hi, I didn't realize that you had already CCed the rust-vmm mailing list, so anyways it is a good start. -Original Message- From: Trilok Soni Sent: Wednesday, April 28, 2021 10:14 AM To: Viresh Kumar ; stratos-...@op-lists.linaro.org; rust-...@lists.opendev.org Cc: Vincent Guittot ; Mi

RE: [RUST] Add crate for generic vhost-user-i2c backend daemon

2021-04-28 Thread Trilok Soni
Viresh, For rust-vmm, you need to create the new issue in the right project. You can probably pick up vmm-reference project at rust-vmm and ask for the new crate. You can also send email to rust-vmm mailing list but github "issues" feature is used heavily in the rust-vmm project. There is also

[Bug 1926497] Re: dp83932 stops working after a short while

2021-04-28 Thread Jeff
It looks like using https://cdimage.debian.org/cdimage/ports/snapshots/2021-04-17/debian-10.0.0 -m68k-NETINST-1.iso instead fixes the issue. Perhaps the instruction on https://wiki.qemu.org/Documentation/Platforms/m68k should be updated. -- You received this bug notification because you are a mem

Re: [PATCH v2] target/i386: add "-cpu, lbr-fmt=*" support to enable guest LBR

2021-04-28 Thread Eduardo Habkost
On Tue, Apr 27, 2021 at 04:09:48PM +0800, Like Xu wrote: > The last branch recording (LBR) is a performance monitor unit (PMU) > feature on Intel processors that records a running trace of the most > recent branches taken by the processor in the LBR stack. The QEMU > could configure whether it's en

Re: [PATCH v4 00/26] Hexagon (target/hexagon) update

2021-04-28 Thread Richard Henderson
On 4/8/21 6:07 PM, Taylor Simpson wrote: This patch series is a significant update for the Hexagon target The first 16 patches address feedback from Richard Henderson and Philippe Mathieu-Daud� The next 10 patches add the remaining instructions for the Hexagon scalar core T

[Bug 1926497] Re: dp83932 stops working after a short while

2021-04-28 Thread Jeff
The kernel in my m68k disk image is vmlinux-4.16.0-1-m68k which is presumably what comes from https://cdimage.debian.org/cdimage/ports/10.0/m68k/iso-cd/debian-10.0 -m68k-NETINST-1.iso. Is there a debian image that uses a newer kernel? -- You received this bug notification because you are a member

Re: [PATCH 5/5] vhost-user-blk: Check that num-queues is supported by backend

2021-04-28 Thread Raphael Norwitz
Reviewed-by: Raphael Norwitz On Thu, Apr 22, 2021 at 07:02:21PM +0200, Kevin Wolf wrote: > Creating a device with a number of queues that isn't supported by the > backend is pointless, the device won't work properly and the error > messages are rather confusing. > > Just fail to create the devic

Re: [PATCH v4 08/30] target/mips: Declare mips_env_set_pc() inlined in "internal.h"

2021-04-28 Thread Richard Henderson
On 4/28/21 10:03 AM, Philippe Mathieu-Daudé wrote: Rename set_pc() as mips_env_set_pc(), declare it inlined and use it in cpu.c and op_helper.c. Reported-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- v4: mips_cpu_set_error_pc -> mips_env_set_pc (rth) --- target/mips/internal.

[Bug 1926497] Re: dp83932 stops working after a short while

2021-04-28 Thread Laurent Vivier
I think you must use a more recent kernel because some bugs have been fixed in QEMU and kernel that need both of them in sync. Could you extract the kernel from your m68k disk image to use it with QEMU "-kernel" and "-initrd" parameters? -- You received this bug notification because you are a me

[PATCH] meson: change buildtype when debug_info=no

2021-04-28 Thread Joelle van Dyne
Meson defaults builds to 'debugoptimized' which adds '-g -O2' to CFLAGS. If the user specifies '--disable-debug-info' we should instead build with 'release' which does not emit any debug info. Signed-off-by: Joelle van Dyne --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/config

Re: [PATCH 2/2] util/meson: Build iov/hexdump/buffer_is_zero with virtiofsd

2021-04-28 Thread Philippe Mathieu-Daudé
On 4/28/21 9:24 PM, Richard Henderson wrote: > On 4/28/21 10:56 AM, Philippe Mathieu-Daudé wrote: >> Are you suggesting to remove the 'if have_block' check? This makes build >> a the files pointlessly for user-mode-only builds... > > But since the objects are not included in the binary, I don't ca

[PATCH v2 13/15] linux-user/s390x: Add build asserts for sigset sizes

2021-04-28 Thread Richard Henderson
At point of usage, it's not immediately obvious that we don't need a loop to copy these arrays. Signed-off-by: Richard Henderson --- linux-user/s390x/signal.c | 5 + 1 file changed, 5 insertions(+) diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c index 81ba59b46a..839a7ae4

[PATCH v2 15/15] linux-user/s390x: Handle vector regs in signal stack

2021-04-28 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/s390x/signal.c | 62 +-- 1 file changed, 60 insertions(+), 2 deletions(-) diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c index 9d470e4ca0..b537646e60 100644 --- a/linux-user/s390x/signal.c +++

[PATCH v2 11/15] linux-user/s390x: Add stub sigframe argument for last_break

2021-04-28 Thread Richard Henderson
In order to properly present these arguments, we need to add code to target/s390x to record LowCore parameters for user-only. But in the meantime, at least zero the missing last_break argument, and fixup the comment style in the vicinity. Signed-off-by: Richard Henderson --- linux-user/s390x/si

RE: [RFC PATCH 3/4] target/ppc: Move SPR generation to separate file

2021-04-28 Thread Fabiano Rosas
Bruno Piazera Larsen writes: >> > > +/*/ >> > > +/* SPR definitions and registration */ >> > > + >> > > +#ifdef CONFIG_TCG >> > > +#ifdef CONFIG_USER_ONLY >> > > +#define spr_register_kvm(env, num, name, uea_read, uea_wri

Re: [PATCH v4 00/36] block: update graph permissions update

2021-04-28 Thread Vladimir Sementsov-Ogievskiy
28.04.2021 20:03, Kevin Wolf wrote: Am 28.04.2021 um 17:17 hat Vladimir Sementsov-Ogievskiy geschrieben: Hi all! And here is v4. Thanks, applied to the block branch. Thanks! And thanks a lot for reviewing! Though the error message shown by the test in patch 18 does need some improvement

[PATCH v2 09/15] linux-user/s390x: Clean up single-use gotos in signal.c

2021-04-28 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/s390x/signal.c | 29 - 1 file changed, 8 insertions(+), 21 deletions(-) diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c index eabfe4293f..64a9eab097 100644 --- a/linux-user/s390x/signal.c +++ b/linux-u

[PATCH v2 10/15] linux-user/s390x: Set psw.mask properly for the signal handler

2021-04-28 Thread Richard Henderson
Note that PSW_ADDR_{64,32} are called PSW_MASK_{EA,BA} in the kernel source. Signed-off-by: Richard Henderson --- linux-user/s390x/signal.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c index 64a9eab097..17f617c655 100644 --- a/li

Re: [PATCH] make vfio and DAX cache work together

2021-04-28 Thread Alex Williamson
On Wed, 28 Apr 2021 20:17:23 +0100 "Dr. David Alan Gilbert" wrote: > * Dev Audsin (dev.devaq...@gmail.com) wrote: > > Thanks Dave for your explanation. > > Any suggestions on how to make VFIO not attempt to map into the > > unaccessible and unallocated RAM. > > I'm not sure;: > > static bool

[PATCH v2 07/15] linux-user/s390x: Use tswap_sigset in setup_rt_frame

2021-04-28 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/s390x/signal.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c index f8515dd332..4dde55d4d5 100644 --- a/linux-user/s390x/signal.c +++ b/linux-user/s390x/signal.c @@ -182

[PATCH v2 08/15] linux-user/s390x: Tidy save_sigregs

2021-04-28 Thread Richard Henderson
The "save" routines copied from the kernel, which are currently commented out, are unnecessary in qemu. We can copy from env where the kernel needs special instructions. Fix comment style. Signed-off-by: Richard Henderson --- linux-user/s390x/signal.c | 10 ++ 1 file changed, 6 inserti

Re: [PATCH 1/5] vhost-user-blk: Don't reconnect during initialisation

2021-04-28 Thread Philippe Mathieu-Daudé
On 4/22/21 7:02 PM, Kevin Wolf wrote: > This is a partial revert of commits 77542d43149 and bc79c87bcde. > > Usually, an error during initialisation means that the configuration was > wrong. Reconnecting won't make the error go away, but just turn the > error condition into an endless loop. Avoid

Re: [PATCH v2 00/15] linux-user/s390x: some signal fixes

2021-04-28 Thread Richard Henderson
On 4/28/21 12:33 PM, Richard Henderson wrote: Version 2 splits lazy do-it-all patch. Patch 1 has an additional fix, so I dropped the r-b. ... and I realized as I hit send that this depends on the target_restore_altstack cleanup that's part of https://patchew.org/QEMU/20210426025334.1168495-1

[PATCH v2 05/15] linux-user/s390x: Fix trace in restore_regs

2021-04-28 Thread Richard Henderson
Directly reading sc->regs.psw.addr misses the bswap that may be performed by __get_user. Signed-off-by: Richard Henderson --- linux-user/s390x/signal.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c index e455a9818d.

[PATCH v2 03/15] linux-user/s390x: Remove PSW_ADDR_AMODE

2021-04-28 Thread Richard Henderson
This is an unnecessary complication since we only support 64-bit mode. Signed-off-by: Richard Henderson --- linux-user/s390x/signal.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c index fece8ab97b..1df

[Bug 1926497] Re: dp83932 stops working after a short while

2021-04-28 Thread Laurent Vivier
** Tags added: m68k q800 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1926497 Title: dp83932 stops working after a short while Status in QEMU: New Bug description: Following the instructions

[Bug 1926497] Re: dp83932 stops working after a short while

2021-04-28 Thread Jeff
I also see the same problem with version 4.2.1 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1926497 Title: dp83932 stops working after a short while Status in QEMU: New Bug description: Foll

[PATCH v2 04/15] linux-user/s390x: Remove restore_sigregs return value

2021-04-28 Thread Richard Henderson
The function cannot fail. Signed-off-by: Richard Henderson --- linux-user/s390x/signal.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c index 1dfca71fa9..e455a9818d 100644 --- a/linux-user/s390x/signal.c +

[PATCH v2 00/15] linux-user/s390x: some signal fixes

2021-04-28 Thread Richard Henderson
Version 2 splits lazy do-it-all patch. Patch 1 has an additional fix, so I dropped the r-b. r~ Richard Henderson (15): linux-user/s390x: Fix sigframe types linux-user/s390x: Use uint16_t for signal retcode linux-user/s390x: Remove PSW_ADDR_AMODE linux-user/s390x: Remove restore_sigregs re

[Bug 1926497] [NEW] dp83932 stops working after a short while

2021-04-28 Thread Jeff
Public bug reported: Following the instructions here https://wiki.qemu.org/Documentation/Platforms/m68k I was able to successfully install debian. However, running apt-get update stalls after the first 1-2MB. root@debian:~# apt-get update Get:1 http://ftp.ports.debian.org/debian-ports sid InRelea

[PATCH v2 14/15] linux-user/s390x: Clean up signal.c

2021-04-28 Thread Richard Henderson
Reorder the function bodies to correspond to the kernel source. Signed-off-by: Richard Henderson --- linux-user/s390x/signal.c | 67 --- 1 file changed, 41 insertions(+), 26 deletions(-) diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c index

[PATCH v2 02/15] linux-user/s390x: Use uint16_t for signal retcode

2021-04-28 Thread Richard Henderson
Using the right type simplifies the frame setup. Signed-off-by: Richard Henderson --- linux-user/s390x/signal.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c index 707fb603d7..fece8ab97b 100644 --- a/linux-user/

[PATCH v2 12/15] linux-user/s390x: Fix frame_addr corruption in setup_frame

2021-04-28 Thread Richard Henderson
The original value of frame_addr is still required for its use in the call to unlock_user_struct below. Signed-off-by: Richard Henderson --- linux-user/s390x/signal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c index b

[PATCH v2 06/15] linux-user/s390x: Fix sigcontext sregs value

2021-04-28 Thread Richard Henderson
Using the host address of &frame->sregs is incorrect. We need the guest address. Signed-off-by: Richard Henderson --- linux-user/s390x/signal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c index dcc6f7bc02..f8515dd332 1

[PATCH v2 01/15] linux-user/s390x: Fix sigframe types

2021-04-28 Thread Richard Henderson
Noticed via gitlab clang-user job: TESTsignals on s390x ../linux-user/s390x/signal.c:258:9: runtime error: \ 1.84467e+19 is outside the range of representable values of \ type 'unsigned long' Which points to the fact that we were performing a double-to-uint64_t conversion while storing

Re: [PATCH v4] target/ppc: code motion from translate_init.c.inc to gdbstub.c

2021-04-28 Thread Bruno Piazera Larsen
This is a test. Please disregard

Re: [PATCH 4/5] virtio: Fail if iommu_platform is requested, but unsupported

2021-04-28 Thread Raphael Norwitz
On Thu, Apr 22, 2021 at 07:02:20PM +0200, Kevin Wolf wrote: > Commit 2943b53f6 (' virtio: force VIRTIO_F_IOMMU_PLATFORM') made sure > that vhost can't just reject VIRTIO_F_IOMMU_PLATFORM when it was > requested. However, just adding it back to the negotiated flags isn't > right either because it pr

Re: [PATCH 2/2] util/meson: Build iov/hexdump/buffer_is_zero with virtiofsd

2021-04-28 Thread Richard Henderson
On 4/28/21 10:56 AM, Philippe Mathieu-Daudé wrote: Are you suggesting to remove the 'if have_block' check? This makes build a the files pointlessly for user-mode-only builds... But since the objects are not included in the binary, I don't care. The build system is already too complex, and buil

Re: [PATCH] make vfio and DAX cache work together

2021-04-28 Thread Dr. David Alan Gilbert
* Dev Audsin (dev.devaq...@gmail.com) wrote: > Thanks Dave for your explanation. > Any suggestions on how to make VFIO not attempt to map into the > unaccessible and unallocated RAM. I'm not sure;: static bool vfio_listener_skipped_section(MemoryRegionSection *section) { return (!memory_regio

Re: [PATCH] hw/avr/atmega.c: use the avr51 cpu for atmega1280

2021-04-28 Thread Philippe Mathieu-Daudé
Cc'ing Joaquín. On 4/28/21 9:15 PM, Frederic Konrad wrote: > According to the as documentation: > (https://sourceware.org/binutils/docs-2.36/as/AVR-Options.html) > > "Instruction set avr51 is for the enhanced AVR core with exactly 128K > program memory space (MCU types: atmega128, atmega128a, a

[PATCH] hw/avr/atmega.c: use the avr51 cpu for atmega1280

2021-04-28 Thread Frederic Konrad
According to the as documentation: (https://sourceware.org/binutils/docs-2.36/as/AVR-Options.html) "Instruction set avr51 is for the enhanced AVR core with exactly 128K program memory space (MCU types: atmega128, atmega128a, atmega1280, atmega1281, atmega1284, atmega1284p, atmega128rfa1, atmega

Re: [PATCH v4 12/12] tests/meson: Only build softfloat objects if TCG is selected

2021-04-28 Thread Philippe Mathieu-Daudé
On 4/28/21 9:04 PM, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > >> On 4/28/21 7:06 PM, Alex Bennée wrote: >>> Philippe Mathieu-Daudé writes: >>> Alex, Richard, do you mind reviewing this one please? >>> >>> Isn't it already merged (with my r-b tag no less ;-) >>> >>> f77147cd

Re: [PATCH v4 12/12] tests/meson: Only build softfloat objects if TCG is selected

2021-04-28 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 4/28/21 7:06 PM, Alex Bennée wrote: >> Philippe Mathieu-Daudé writes: >> >>> Alex, Richard, do you mind reviewing this one please? >> >> Isn't it already merged (with my r-b tag no less ;-) >> >> f77147cd4de8c726f89b2702f7a9d0c9711d8875 > > See ... > >>

Re: [PATCH] i386: Document when features can be added to kvm_default_props

2021-04-28 Thread Eduardo Habkost
On Fri, Sep 25, 2020 at 05:10:21PM -0400, Eduardo Habkost wrote: > It's very easy to mistakenly extend kvm_default_props to include > features that require a kernel version that's too recent. Add a > comment warning about that, pointing to the documentation file > where the minimum kernel version

Re: [PATCH 5/7] hw: Have machines Kconfig-select FW_CFG

2021-04-28 Thread Eduardo Habkost
On Mon, Apr 26, 2021 at 09:35:18PM +0200, Philippe Mathieu-Daudé wrote: > Beside the loongson3-virt machine (MIPS), the following machines > also use the fw_cfg device: > > - ARM: virt & sbsa-ref > - HPPA: generic machine > - X86: ACPI based (pc & microvm) > - PPC64: various > - SPARC: sun4m & sun

Re: [PATCH 3/5] vhost-user-blk: Get more feature flags from vhost devicey

2021-04-28 Thread Raphael Norwitz
Acked-by: Raphael Norwitz On Thu, Apr 22, 2021 at 07:02:19PM +0200, Kevin Wolf wrote: > VIRTIO_F_RING_PACKED and VIRTIO_F_IOMMU_PLATFORM need to be supported by > the vhost device, otherwise advertising it to the guest doesn't result > in a working configuration. They are currently not supported

Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine

2021-04-28 Thread Stefan Hajnoczi
On Wed, Apr 28, 2021 at 04:18:17PM +0200, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > On Tue, Apr 27, 2021 at 02:02:27PM -0400, John Snow wrote: > >> On 4/27/21 1:54 PM, Philippe Mathieu-Daudé wrote: > >> > On 4/27/21 7:16 PM, John Snow wrote: > >> > > On 4/27/21 9:54 AM, Stefan Hajn

Re: [RFC] AVR watchdog

2021-04-28 Thread Fred Konrad
Le 4/28/21 à 8:17 PM, Michael Rolnik a écrit : Hi Fred. How can I reproduce it? Thank you. Michael Rolnik Hi Michael, First sorry for the patchew noise, I didn't meant to sent a patch just an inlined diff. For the reproducer, that's pretty straight-forward with v6.0.0-rc5: $ cat > foo.S

Re: [PATCH 1/2] meson: Check for seccomp/cap-ng libraries if virtiofsd is enabled

2021-04-28 Thread Peter Maydell
On Wed, 28 Apr 2021 at 19:02, Philippe Mathieu-Daudé wrote: > On 4/28/21 6:34 PM, Richard Henderson wrote: > > I think the test should have been > > > > if (have_system or have_tools) and > > Yes but virtiofsd is not a tool... It is a standalone binary. This is not a distinction that our build/

Re: [PATCH 1/5] vhost-user-blk: Don't reconnect during initialisation

2021-04-28 Thread Raphael Norwitz
On Wed, Apr 28, 2021 at 07:31:13PM +0200, Kevin Wolf wrote: > Am 28.04.2021 um 18:52 hat Raphael Norwitz geschrieben: > > Given what you've shown with the use-after-free, I agree the changes > > need to be reverted. I'm a little uneasy about removing the reconnect > > logic from the device realizat

Re: [RFC] AVR watchdog

2021-04-28 Thread Michael Rolnik
Hi Fred. How can I reproduce it? Thank you. Michael Rolnik Sent from my cell phone, please ignore typos On Wed, Apr 28, 2021, 5:17 PM Fred Konrad wrote: > Hi, > > I fall on a segfault while running the wdr instruction on AVR: > > (gdb) bt > #0 0xadd0b23a in gdb_get_cpu_pid (cpu=

Re: [PATCH 2/5] vhost-user-blk: Use Error more consistently

2021-04-28 Thread Raphael Norwitz
Code looks ok - question about the commit message. Acked-by: Raphael Norwitz On Thu, Apr 22, 2021 at 07:02:18PM +0200, Kevin Wolf wrote: > Now that vhost_user_blk_connect() is not called from an event handler > any more, but directly from vhost_user_blk_device_realize(), we don't > have to resor

Re: [PATCH 1/2] meson: Check for seccomp/cap-ng libraries if virtiofsd is enabled

2021-04-28 Thread Philippe Mathieu-Daudé
On 4/28/21 6:34 PM, Richard Henderson wrote: > On 4/28/21 7:48 AM, Philippe Mathieu-Daudé wrote: >>   seccomp = not_found >> -if not get_option('seccomp').auto() or have_system or have_tools >> +if not get_option('seccomp').auto() or have_system or have_tools or >> not get_option('virtiofsd').auto(

Re: [PATCH 2/2] util/meson: Build iov/hexdump/buffer_is_zero with virtiofsd

2021-04-28 Thread Philippe Mathieu-Daudé
On 4/28/21 6:38 PM, Richard Henderson wrote: > On 4/28/21 7:48 AM, Philippe Mathieu-Daudé wrote: >> diff --git a/util/meson.build b/util/meson.build >> index 510765cde46..c2eda2d1374 100644 >> --- a/util/meson.build >> +++ b/util/meson.build >> @@ -59,12 +59,10 @@ >>     util_ss.add(files('aiocb.c'

Re: [PATCH 7/7] hw/nvram: Do not build FW_CFG if not required

2021-04-28 Thread Philippe Mathieu-Daudé
On 4/26/21 9:35 PM, Philippe Mathieu-Daudé wrote: > If the Kconfig 'FW_CFG' symbol is not selected, it is pointless > to build the fw_cfg device. Update the stubs. > > Signed-off-by: Philippe Mathieu-Daudé > --- > stubs/fw_cfg.c | 49 ++-- > hw/nvram

Re: [PATCH 1/5] vhost-user-blk: Don't reconnect during initialisation

2021-04-28 Thread Kevin Wolf
Am 28.04.2021 um 18:52 hat Raphael Norwitz geschrieben: > Given what you've shown with the use-after-free, I agree the changes > need to be reverted. I'm a little uneasy about removing the reconnect > logic from the device realization completely though. > > On Thu, Apr 22, 2021 at 07:02:17PM +0200

Re: [PATCH v4 12/12] tests/meson: Only build softfloat objects if TCG is selected

2021-04-28 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Alex, Richard, do you mind reviewing this one please? Isn't it already merged (with my r-b tag no less ;-) f77147cd4de8c726f89b2702f7a9d0c9711d8875 Author: Philippe Mathieu-Daudé AuthorDate: Fri Jan 22 21:44:31 2021 +0100 Commit: Paolo Bonzini

Re: [PATCH] tests/migration: fix unix socket migration

2021-04-28 Thread Wainer dos Santos Moschetta
Cleber, Maybe you could review then queue this one? - Wainer On 4/20/21 10:16 PM, Hyman Huang wrote: 在 2021/3/10 0:55, Philippe Mathieu-Daudé 写道: On 3/9/21 5:00 PM, huang...@chinatelecom.cn wrote: From: Hyman The test aborts and error message as the following be throwed: "No such file or

[PATCH v4 29/30] hw/mips: Restrict non-virtualized machines to TCG

2021-04-28 Thread Philippe Mathieu-Daudé
Only the malta and loongson3-virt machines support KVM. Restrict the other machines to TCG: - mipssim - magnum - pica61 - fuloong2e - boston Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/meson.build | 11 +++ 1 file changed, 7 insertions(+), 4 d

Re: [PATCH v7 0/7] eBPF RSS support for virtio-net.

2021-04-28 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210428164733.56547-1-and...@daynix.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210428164733.56547-1-and...@daynix.com Subject: [PATCH v7 0/7] eBPF RSS support for virtio

Re: [PATCH v2 1/7] tests/acceptance: Automatic set -cpu to the test vm

2021-04-28 Thread Wainer dos Santos Moschetta
Hi, On 4/21/21 5:16 PM, Cleber Rosa wrote: On Thu, Apr 08, 2021 at 04:52:31PM -0300, Wainer dos Santos Moschetta wrote: This introduces a new feature to the functional tests: automatic setting of the '-cpu VALUE' option to the created vm if the test is tagged with 'cpu:VALUE'. The 'cpu' propert

[PATCH v4 26/30] target/mips: Move exception management code to exception.c

2021-04-28 Thread Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/internal.h | 13 --- target/mips/tcg/tcg-internal.h | 14 +++ target/mips/cpu.c | 113 -- target/mips/exception.c| 167 + target

Re: [PATCH v2] vfio-ccw: Attempt to clean up all IRQs on error

2021-04-28 Thread Cornelia Huck
On Wed, 28 Apr 2021 16:36:52 +0200 Eric Farman wrote: > The vfio_ccw_unrealize() routine makes an unconditional attempt to > unregister every IRQ notifier, though they may not have been registered > in the first place (when running on an older kernel, for example). > > Let's mirror this behavior

Re: [PATCH v4 12/12] tests/meson: Only build softfloat objects if TCG is selected

2021-04-28 Thread Philippe Mathieu-Daudé
On 4/28/21 7:06 PM, Alex Bennée wrote: > Philippe Mathieu-Daudé writes: > >> Alex, Richard, do you mind reviewing this one please? > > Isn't it already merged (with my r-b tag no less ;-) > > f77147cd4de8c726f89b2702f7a9d0c9711d8875 See ... > Author: Philippe Mathieu-Daudé > Author

[PATCH v4 25/30] target/mips: Move TLB management helpers to tcg/sysemu/tlb_helper.c

2021-04-28 Thread Philippe Mathieu-Daudé
Move TLB management helpers to tcg/sysemu/tlb_helper.c. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/helper.h| 10 - target/mips/internal.h | 7 - target/mips/tcg/sysemu_helper.h.inc | 9 + target/mips/op_helper.c

Re: [PATCH v11 2/6] arm64: kvm: Introduce MTE VM feature

2021-04-28 Thread Catalin Marinas
On Fri, Apr 16, 2021 at 04:43:05PM +0100, Steven Price wrote: > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > index 77cb2d28f2a4..5f8e165ea053 100644 > --- a/arch/arm64/kvm/mmu.c > +++ b/arch/arm64/kvm/mmu.c > @@ -879,6 +879,26 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, > phy

Re: [PATCH v4 00/30] target/mips: Re-org to allow KVM-only builds

2021-04-28 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210428170410.479308-1-f4...@amsat.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210428170410.479308-1-f4...@amsat.org Subject: [PATCH v4 00/30] target/mips: Re-org to allo

[PATCH v4 23/30] target/mips: Move Special opcodes to tcg/sysemu/special_helper.c

2021-04-28 Thread Philippe Mathieu-Daudé
Move the Special opcodes helpers to tcg/sysemu/special_helper.c. Since mips_io_recompile_replay_branch() is set as CPUClass::io_recompile_replay_branch handler in cpu.c, we need to declare its prototype in "tcg-internal.h". Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --

[PATCH v4 28/30] target/mips: Move TCG source files under tcg/ sub directory

2021-04-28 Thread Philippe Mathieu-Daudé
To ease maintenance, move all TCG specific files under the tcg/ sub-directory. Adapt the Meson machinery. The following prototypes: - mips_tcg_init() - mips_cpu_do_unaligned_access() - mips_cpu_do_transaction_failed() can now be restricted to the "tcg-internal.h" header. Reviewed-by: Richard Hend

Re: [PATCH 6/7] hw/{arm,hppa,riscv}: Add fw_cfg arch-specific stub

2021-04-28 Thread Philippe Mathieu-Daudé
On 4/28/21 6:44 PM, Laszlo Ersek wrote: > On 04/26/21 21:35, Philippe Mathieu-Daudé wrote: >> The ARM, HPPA and RISC-V architectures don't declare any fw_cfg >> specific key. To simplify the buildsys machinery and allow building >> QEMU without the fw_cfg device (in the next commit), first add a >>

[PATCH v4 30/30] gitlab-ci: Add KVM mips64el cross-build jobs

2021-04-28 Thread Philippe Mathieu-Daudé
Add a new job to cross-build the mips64el target without the TCG accelerator (IOW: only KVM accelerator enabled). Only build the mips64el target which is known to work and has users. Reviewed-by: Richard Henderson Acked-by: Thomas Huth Reviewed-by: Willian Rampazzo Signed-off-by: Philippe Math

[PATCH v4 19/30] target/mips: Move sysemu TCG-specific code to tcg/sysemu/ subfolder

2021-04-28 Thread Philippe Mathieu-Daudé
Move cp0_helper.c and mips-semi.c to the new tcg/sysemu/ folder, adapting the Meson machinery. Move the opcode definitions to tcg/sysemu_helper.h.inc. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/helper.h | 166 +

  1   2   3   4   >