Re: [RFC PATCH v2 4/6] hw/acpi/aml-build: Add processor hierarchy node structure

2021-04-27 Thread wangyanan (Y)
Hi Drew, On 2021/4/27 21:37, Andrew Jones wrote: On Tue, Apr 13, 2021 at 04:07:43PM +0800, Yanan Wang wrote: Add a generic API to build Processor Hierarchy Node Structure(Type 0), which is strictly consistent with descriptions in ACPI 6.3: 5.2.29.1. This function will be used to build ACPI PPT

Re: [RFC PATCH v2 3/6] hw/arm/virt-acpi-build: Distinguish possible and present cpus

2021-04-27 Thread wangyanan (Y)
Hi Drew, On 2021/4/27 22:50, Andrew Jones wrote: On Tue, Apr 13, 2021 at 04:07:42PM +0800, Yanan Wang wrote: From: Ying Fang When building ACPI tables regarding CPUs we should always build them for the number of possible CPUs, not the number of present CPUs. We then ensure only the present CP

Re: [RFC PATCH v2 3/6] hw/arm/virt-acpi-build: Distinguish possible and present cpus

2021-04-27 Thread wangyanan (Y)
On 2021/4/27 21:18, Andrew Jones wrote: On Tue, Apr 13, 2021 at 04:07:42PM +0800, Yanan Wang wrote: From: Ying Fang When building ACPI tables regarding CPUs we should always build them for the number of possible CPUs, not the number of present CPUs. We then ensure only the present CPUs are ena

Re: [RFC PATCH v2 2/6] hw/arm/virt: DT: Add cpu-map

2021-04-27 Thread wangyanan (Y)
On 2021/4/27 20:36, Philippe Mathieu-Daudé wrote: On 4/27/21 12:04 PM, Andrew Jones wrote: On Tue, Apr 27, 2021 at 11:47:17AM +0200, Philippe Mathieu-Daudé wrote: Hi Yanan, Drew, On 4/13/21 10:07 AM, Yanan Wang wrote: From: Andrew Jones Support device tree CPU topology descriptions. Sign

Re: [PATCH RFC 0/1] To add HMP interface to dump PCI MSI-X table/PBA

2021-04-27 Thread Dongli Zhang
On 4/27/21 10:55 PM, Jason Wang wrote: > > 在 2021/4/28 下午1:10, Dongli Zhang 写道: >> Hi Jason, >> >> On 4/27/21 7:31 PM, Jason Wang wrote: >>> 在 2021/4/27 下午4:53, Dr. David Alan Gilbert 写道: * Dongli Zhang (dongli.zh...@oracle.com) wrote: > On 4/22/21 11:01 PM, Jason Wang wrote: >> 在

[Bug 1295587] Re: Temporal freeze and slowdown while using emulated sb16

2021-04-27 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

[Bug 601946] Re: [Feature request] qemu-img multi-threaded compressed image conversion

2021-04-27 Thread Коренберг Марк
** Changed in: qemu Status: Incomplete => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/601946 Title: [Feature request] qemu-img multi-threaded compressed image conversion Status in QEM

Re: [PATCH v3 15/33] nbd/client-connection: use QEMU_LOCK_GUARD

2021-04-27 Thread Roman Kagan
On Fri, Apr 16, 2021 at 11:08:53AM +0300, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/client-connection.c | 94 ++--- > 1 file changed, 42 insertions(+), 52 deletions(-) > > diff --git a/nbd/client-connection.c

[Bug 601946] Re: [Feature request] qemu-img multi-threaded compressed image conversion

2021-04-27 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

Re: [PATCH RFC 0/1] To add HMP interface to dump PCI MSI-X table/PBA

2021-04-27 Thread Jason Wang
在 2021/4/28 下午1:10, Dongli Zhang 写道: Hi Jason, On 4/27/21 7:31 PM, Jason Wang wrote: 在 2021/4/27 下午4:53, Dr. David Alan Gilbert 写道: * Dongli Zhang (dongli.zh...@oracle.com) wrote: On 4/22/21 11:01 PM, Jason Wang wrote: 在 2021/4/23 下午12:47, Dongli Zhang 写道: This is inspired by the discussi

Re: [PATCH 01/22] qapi/parser: Don't try to handle file errors

2021-04-27 Thread Markus Armbruster
John Snow writes: > On 4/27/21 9:47 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 4/23/21 11:46 AM, Markus Armbruster wrote: John Snow writes: > The short-ish version of what motivates this patch is: > > - The parser initializer does not possess adequate con

Re: [PATCH RFC C0/2] support allocation-map for block-dirty-bitmap-merge

2021-04-27 Thread Markus Armbruster
John Snow writes: > On 4/27/21 7:11 AM, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> It's a simpler alternative for >> "[PATCH v4 0/5] block: add block-dirty-bitmap-populate job" >><20200902181831.2570048-1-ebl...@redhat.com> >>https://lists.gnu.org/archive/html/qemu-devel/2020-09/ms

Re: [PATCH RFC 0/1] To add HMP interface to dump PCI MSI-X table/PBA

2021-04-27 Thread Dongli Zhang
Hi Jason, On 4/27/21 7:31 PM, Jason Wang wrote: > > 在 2021/4/27 下午4:53, Dr. David Alan Gilbert 写道: >> * Dongli Zhang (dongli.zh...@oracle.com) wrote: >>> >>> On 4/22/21 11:01 PM, Jason Wang wrote: 在 2021/4/23 下午12:47, Dongli Zhang 写道: > This is inspired by the discussion with Jason on be

Re: [PATCH v8 08/11] hw/core: deprecate old reset functions and introduce new ones

2021-04-27 Thread Markus Armbruster
Eduardo Habkost writes: > On Tue, Apr 27, 2021 at 02:21:28PM +0200, Philippe Mathieu-Daudé wrote: >> On 1/23/20 2:28 PM, Damien Hedde wrote: >> > Deprecate device_legacy_reset(), qdev_reset_all() and >> > qbus_reset_all() to be replaced by new functions >> > device_cold_reset() and bus_cold_reset

[PATCH v8 5/6] [RISCV_PM] Implement address masking functions required for RISC-V Pointer Masking extension

2021-04-27 Thread Alexey Baturo
From: Anatoly Parshintsev Signed-off-by: Anatoly Parshintsev Reviewed-by: Richard Henderson --- target/riscv/cpu.h | 20 target/riscv/translate.c | 36 ++-- 2 files changed, 54 insertions(+), 2 deletions(-) diff --git a/target/riscv/c

[PATCH v8 3/6] [RISCV_PM] Print new PM CSRs in QEMU logs

2021-04-27 Thread Alexey Baturo
Signed-off-by: Alexey Baturo Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis --- target/riscv/cpu.c | 25 + 1 file changed, 25 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index c04911ec05..0682410f5d 100644 --- a/target/riscv/cpu.c ++

[PATCH v8 6/6] [RISCV_PM] Allow experimental J-ext to be turned on

2021-04-27 Thread Alexey Baturo
Signed-off-by: Alexey Baturo Reviewed-by: Alistair Francis --- target/riscv/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 0682410f5d..fecc64d7ba 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -502,6 +502,7 @@ static void ri

[PATCH v8 1/6] [RISCV_PM] Add J-extension into RISC-V

2021-04-27 Thread Alexey Baturo
Signed-off-by: Alexey Baturo Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis --- target/riscv/cpu.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index 0a33d387ba..0ea9fc65c8 100644 --- a/target/riscv/cpu.h +++ b/target/riscv/cpu.h @@

[PATCH v8 4/6] [RISCV_PM] Support pointer masking for RISC-V for i/c/f/d/a types of instructions

2021-04-27 Thread Alexey Baturo
Signed-off-by: Alexey Baturo Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis --- target/riscv/insn_trans/trans_rva.c.inc | 3 +++ target/riscv/insn_trans/trans_rvd.c.inc | 2 ++ target/riscv/insn_trans/trans_rvf.c.inc | 2 ++ target/riscv/insn_trans/trans_rvi.c.inc | 2 ++ targ

[PATCH RESEND v8 2/6] [RISCV_PM] Support CSRs required for RISC-V PM extension except for the h-mode

2021-04-27 Thread Alexey Baturo
Signed-off-by: Alexey Baturo --- resend: minor codestyle fix target/riscv/cpu.c | 5 + target/riscv/cpu.h | 12 ++ target/riscv/cpu_bits.h | 66 +++ target/riscv/csr.c | 240 4 files changed, 323 insertions(+) diff --git a/ta

[PATCH RESEND v8 0/6] RISC-V Pointer Masking implementation

2021-04-27 Thread Alexey Baturo
v8-resend: Resending to trigger recheck due to minor codestyle issues. v8: Hi folks, Finally we were able to assign v0.1 draft for Pointer Masking extension for RISC-V: https://github.com/riscv/riscv-j-extension/blob/master/pointer-masking-proposal.adoc This is supposed to be the first series o

[PATCH RESEND v8 0/6] RISC-V Pointer Masking implementation

2021-04-27 Thread Alexey Baturo
v8-resend: Resending to trigger recheck due to minor codestyle issues. v8: Hi folks, Finally we were able to assign v0.1 draft for Pointer Masking extension for RISC-V: https://github.com/riscv/riscv-j-extension/blob/master/pointer-masking-proposal.adoc This is supposed to be the first series o

[PATCH RESEND v8 2/6] [RISCV_PM] Support CSRs required for RISC-V PM extension except for the h-mode

2021-04-27 Thread Alexey Baturo
Signed-off-by: Alexey Baturo --- resend: minor codestyle fix target/riscv/cpu.c | 5 + target/riscv/cpu.h | 12 ++ target/riscv/cpu_bits.h | 66 +++ target/riscv/csr.c | 240 4 files changed, 323 insertions(+) diff --git a/ta

[PATCH 2/3] linux-user/s390x: Clean up signal.c

2021-04-27 Thread Richard Henderson
The "save" routines from the kernel, which are currently commented out, are unnecessary in qemu. We can copy from env where the kernel needs special instructions. Drop the return value from restore_sigregs, as it cannot fail. Use __get_user return as input to trace, so that we properly bswap the

[PATCH 3/3] linux-user/s390x: Handle vector regs in signal stack

2021-04-27 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/s390x/signal.c | 62 +-- 1 file changed, 60 insertions(+), 2 deletions(-) diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c index fb7065f243..57752a2a96 100644 --- a/linux-user/s390x/signal.c +++

[PATCH 1/3] linux-user/s390x: Fix sigframe types

2021-04-27 Thread Richard Henderson
Noticed via gitlab clang-user job: TESTsignals on s390x ../linux-user/s390x/signal.c:258:9: runtime error: \ 1.84467e+19 is outside the range of representable values of \ type 'unsigned long' Which points to the fact that we were performing a double-to-uint64_t conversion while storing

[PATCH 0/3] linux-user/s390x: some signal fixes

2021-04-27 Thread Richard Henderson
The first patch fixes a clang sanitize=undefined abort. The second patch is probably does too much and should be split, but I'm lazy tonight. I'll wait for comment before changes. The third patch is new functionality, which should have gone in with the s390x vector support. r~ Richard Hender

RE: [PATCH V6 0/6] Passthrough specific network traffic in COLO

2021-04-27 Thread Zhang, Chen
Please give me for comments for this series, Ping Thanks Chen > -Original Message- > From: Zhang, Chen > Sent: Tuesday, April 20, 2021 11:16 PM > To: Jason Wang ; qemu-dev de...@nongnu.org>; Eric Blake ; Dr. David Alan > Gilbert ; Markus Armbruster ; > Daniel P. Berrangé ; Gerd Hoff

Re: [PATCH] Set the correct env->fpip for x86 float instructions [cleaned]

2021-04-27 Thread Ziqiao Kong
Thanks for your review! I did a full re-read of the Intel Manual about x87 programming just now and would send another patch to handle FCS:FIP and FDS:FDP. Ziqiao On Wed, Apr 28, 2021 at 1:49 AM Richard Henderson wrote: > > On 4/16/21 8:34 AM, Ziqiao Kong wrote: > > +++ b/target/i386/tcg/transla

Re: [PATCH 1/5] hw/ppc/spapr_iommu: Register machine reset handler

2021-04-27 Thread David Gibson
On Tue, Apr 27, 2021 at 11:20:07AM +0200, Philippe Mathieu-Daudé wrote: > On 4/27/21 3:45 AM, David Gibson wrote: > > On Sat, Apr 24, 2021 at 06:22:25PM +0200, Philippe Mathieu-Daudé wrote: > >> The TYPE_SPAPR_TCE_TABLE device is bus-less, thus isn't reset > >> automatically. Register a reset hand

[PATCH RESEND v2] i386/cpu: Remove the deprecated cpu model 'Icelake-Client'

2021-04-27 Thread Robert Hoo
As it's been marked deprecated since v5.2, now I think it's time remove it from code. Signed-off-by: Robert Hoo --- (Sorry, forgot to append changelog in last send.) Changelog: v2: Update removed-features.rst. Since previously no its deprecation info was recorded in docs/system/deprecated

[PATCH v2] i386/cpu: Remove the deprecated cpu model 'Icelake-Client'

2021-04-27 Thread Robert Hoo
As it's been marked deprecated since v5.2, now I think it's time remove it from code. Signed-off-by: Robert Hoo --- P.S. Since previously no its deprecation info was recorded in docs/system/deprecated.rst, nothing to update it. --- docs/system/removed-features.rst | 5 ++ target/i386/cpu.c

Re: [PATCH RFC 0/1] To add HMP interface to dump PCI MSI-X table/PBA

2021-04-27 Thread Jason Wang
在 2021/4/27 下午4:53, Dr. David Alan Gilbert 写道: * Dongli Zhang (dongli.zh...@oracle.com) wrote: On 4/22/21 11:01 PM, Jason Wang wrote: 在 2021/4/23 下午12:47, Dongli Zhang 写道: This is inspired by the discussion with Jason on below patchset. https://urldefense.com/v3/__https://lists.gnu.org/arc

Re: [PATCH] virtio-net: failover: add missing remove_migration_state_change_notifier()

2021-04-27 Thread Jason Wang
在 2021/4/27 下午9:51, Laurent Vivier 写道: In the failover case configuration, virtio_net_device_realize() uses an add_migration_state_change_notifier() to add a state notifier, but this notifier is not removed by the unrealize function when the virtio-net card is unplugged. If the card is unplugg

[PATCH v2] floppy: remove dead code related to formatting

2021-04-27 Thread Alexander Bulekov
fdctrl_format_sector was added in baca51faff ("updated floppy driver: formatting code, disk geometry auto detect (Jocelyn Mayer)") The single callsite is guarded by a check: fdctrl->data_state & FD_STATE_FORMAT However, the only place where the FD_STATE_FORMAT flag is set (in fdctrl_handle_forma

Re: [PATCH v6 0/7] eBPF RSS support for virtio-net

2021-04-27 Thread Jason Wang
在 2021/4/27 下午6:47, Andrew Melnichenko 写道: Hi, I've checked the issue. Apparently, libbpf can't work with a skeleton on Debian. Version check would not help - versioning differs at different distros. So you meant the libbpf version is too old? I've added a small check: diff --git a

Re: X on old (non-x86) Linux guests

2021-04-27 Thread Andrew Randrianasulu
On Wednesday, April 28, 2021, Andrew Randrianasulu wrote: > > > On Monday, April 26, 2021, BALATON Zoltan wrote: > >> Hello, >> >> On Mon, 26 Apr 2021, Dr. David Alan Gilbert wrote: >> >>> Over the weekend I got a Red Hat 6.x (not RHEL!) for Alpha booting >>> under QEMU which was pretty neat.

Re: [PATCH] i386/cpu: Remove the deprecated cpu model 'Icelake-Client'

2021-04-27 Thread Robert Hoo
On Tue, 2021-04-27 at 16:55 -0400, Eduardo Habkost wrote: > On Thu, Apr 22, 2021 at 05:42:16PM +0800, Robert Hoo wrote: > > As it's been marked deprecated since v5.2, now I think it's time > > remove it > > from code. > > > > Signed-off-by: Robert Hoo > > Thanks! There's only one issue: we need

Re: X on old (non-x86) Linux guests

2021-04-27 Thread Andrew Randrianasulu
On Monday, April 26, 2021, BALATON Zoltan wrote: > Hello, > > On Mon, 26 Apr 2021, Dr. David Alan Gilbert wrote: > >> Over the weekend I got a Red Hat 6.x (not RHEL!) for Alpha booting >> under QEMU which was pretty neat. But I failed to find a succesful >> combination to get X working; has any

Re: [PATCH RFC C0/2] support allocation-map for block-dirty-bitmap-merge

2021-04-27 Thread Vladimir Sementsov-Ogievskiy
27.04.2021 21:24, John Snow wrote: On 4/27/21 7:11 AM, Vladimir Sementsov-Ogievskiy wrote: Hi all! It's a simpler alternative for "[PATCH v4 0/5] block: add block-dirty-bitmap-populate job"    <20200902181831.2570048-1-ebl...@redhat.com>    https://lists.gnu.org/archive/html/qemu-devel/2020-09/

Re: [PATCH 1/2] hw/sparc: Allow building the leon3 machine stand-alone

2021-04-27 Thread Richard Henderson
On 4/27/21 12:26 PM, Philippe Mathieu-Daudé wrote: When building only the leon3 machine, we get this link failure: /usr/bin/ld: target_sparc_win_helper.c.o: in function `cpu_put_psr': target/sparc/win_helper.c:91: undefined reference to `cpu_check_irqs' This is because cpu_check_irqs() is

Re: [RFC PATCH 2/2] hw/sparc: Allow building without the leon3 machine

2021-04-27 Thread Richard Henderson
On 4/27/21 12:26 PM, Philippe Mathieu-Daudé wrote: When building without the leon3 machine, we get this link failure: /usr/bin/ld: target_sparc_int32_helper.c.o: in function `leon3_irq_manager': target/sparc/int32_helper.c:172: undefined reference to `leon3_irq_ack' This is because the le

Re: [Bug 1926044] Re: QEMU-user doesn't report HWCAP2_MTE

2021-04-27 Thread Vitaly Buka
Thanks for the quick fix! On Tue, Apr 27, 2021 at 2:55 PM Richard Henderson < 1926...@bugs.launchpad.net> wrote: > > https://patchew.org/QEMU/20210427214108.88503-1-richard.hender...@linaro.org/ > > This has missed 6.0, but should be acceptable to roll into 6.0.1. > > -- > You received this bug n

Re: [PATCH v3 14/33] nbd: move connection code from block/nbd to nbd/client-connection

2021-04-27 Thread Roman Kagan
On Fri, Apr 16, 2021 at 11:08:52AM +0300, Vladimir Sementsov-Ogievskiy wrote: > We now have bs-independent connection API, which consists of four > functions: > > nbd_client_connection_new() > nbd_client_connection_unref() > nbd_co_establish_connection() > nbd_co_establish_connection_cance

Re: [PATCH] microvm: Enable hotplug of pcie

2021-04-27 Thread Michael S. Tsirkin
On Tue, Apr 27, 2021 at 09:04:27PM +0800, suyuheng wrote: > From: Yuheng Su > > Signed-off-by: Yuheng Su seems to be extended config space as opposed to hotplug ... > --- > hw/i386/acpi-microvm.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/hw/i386/acpi-microvm.c b/

Re: [PATCH v3 13/33] block/nbd: introduce nbd_client_connection_release()

2021-04-27 Thread Roman Kagan
On Fri, Apr 16, 2021 at 11:08:51AM +0300, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/nbd.c | 43 ++- > 1 file changed, 26 insertions(+), 17 deletions(-) > > diff --git a/block/nbd.c b/block/nbd.c > index

Re: [PATCH v3 11/33] block/nbd: rename NBDConnectThread to NBDClientConnection

2021-04-27 Thread Roman Kagan
On Fri, Apr 16, 2021 at 11:08:49AM +0300, Vladimir Sementsov-Ogievskiy wrote: > We are going to move connection code to own file and want clear names > and APIs. > > The structure is shared between user and (possibly) several runs of > connect-thread. So it's wrong to call it "thread". Let's renam

Re: [PATCH v3 08/33] block/nbd: drop thr->state

2021-04-27 Thread Roman Kagan
On Fri, Apr 16, 2021 at 11:08:46AM +0300, Vladimir Sementsov-Ogievskiy wrote: > We don't need all these states. The code refactored to use two boolean > variables looks simpler. Indeed. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/nbd.c | 125 ++

Re: [PATCH v8 0/6] RISC-V Pointer Masking implementation

2021-04-27 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210427220615.12763-1-space.monkey.deliv...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210427220615.12763-1-space.monkey.deliv...@gmail.com Subject: [PATCH v8 0/6

Re: [RFC PATCH] target/mips: Allow building without Inter-Thread Communication hardware

2021-04-27 Thread Richard Henderson
On 4/27/21 12:11 PM, Philippe Mathieu-Daudé wrote: The Inter-Thread Communication unit (TYPE_MIPS_ITU) is an optional device that is only selected by a few machines. However it goes deep into the translation code, as the MTC0/MTHC0 SAAR helpers call itc_reconfigure(). When building with no machi

[PATCH v8 2/6] [RISCV_PM] Support CSRs required for RISC-V PM extension except for the h-mode

2021-04-27 Thread Alexey Baturo
Signed-off-by: Alexey Baturo --- target/riscv/cpu.c | 5 + target/riscv/cpu.h | 12 ++ target/riscv/cpu_bits.h | 66 +++ target/riscv/csr.c | 239 4 files changed, 322 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv

[PATCH v8 0/6] RISC-V Pointer Masking implementation

2021-04-27 Thread Alexey Baturo
v8: Hi folks, Finally we were able to assign v0.1 draft for Pointer Masking extension for RISC-V: https://github.com/riscv/riscv-j-extension/blob/master/pointer-masking-proposal.adoc This is supposed to be the first series of patches with initial support for PM. It obviously misses support for

[PATCH v8 6/6] [RISCV_PM] Allow experimental J-ext to be turned on

2021-04-27 Thread Alexey Baturo
Signed-off-by: Alexey Baturo Reviewed-by: Alistair Francis --- target/riscv/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 0682410f5d..fecc64d7ba 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -502,6 +502,7 @@ static void ri

[PATCH v8 5/6] [RISCV_PM] Implement address masking functions required for RISC-V Pointer Masking extension

2021-04-27 Thread Alexey Baturo
From: Anatoly Parshintsev Signed-off-by: Anatoly Parshintsev Reviewed-by: Richard Henderson --- target/riscv/cpu.h | 20 target/riscv/translate.c | 36 ++-- 2 files changed, 54 insertions(+), 2 deletions(-) diff --git a/target/riscv/c

[PATCH v8 4/6] [RISCV_PM] Support pointer masking for RISC-V for i/c/f/d/a types of instructions

2021-04-27 Thread Alexey Baturo
Signed-off-by: Alexey Baturo Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis --- target/riscv/insn_trans/trans_rva.c.inc | 3 +++ target/riscv/insn_trans/trans_rvd.c.inc | 2 ++ target/riscv/insn_trans/trans_rvf.c.inc | 2 ++ target/riscv/insn_trans/trans_rvi.c.inc | 2 ++ targ

[PATCH v8 3/6] [RISCV_PM] Print new PM CSRs in QEMU logs

2021-04-27 Thread Alexey Baturo
Signed-off-by: Alexey Baturo Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis --- target/riscv/cpu.c | 25 + 1 file changed, 25 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index c04911ec05..0682410f5d 100644 --- a/target/riscv/cpu.c ++

[PATCH v8 1/6] [RISCV_PM] Add J-extension into RISC-V

2021-04-27 Thread Alexey Baturo
Signed-off-by: Alexey Baturo Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis --- target/riscv/cpu.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index 0a33d387ba..0ea9fc65c8 100644 --- a/target/riscv/cpu.h +++ b/target/riscv/cpu.h @@

[Bug 1926044] Re: QEMU-user doesn't report HWCAP2_MTE

2021-04-27 Thread Richard Henderson
https://patchew.org/QEMU/20210427214108.88503-1-richard.hender...@linaro.org/ This has missed 6.0, but should be acceptable to roll into 6.0.1. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1926044

Re: socket.c added support for unix domain socket datagram transport

2021-04-27 Thread Stefano Brivio
On Mon, 26 Apr 2021 13:56:40 +0100 Daniel P. Berrangé wrote: > On Fri, Apr 23, 2021 at 06:54:08PM +0200, Stefano Brivio wrote: > > On Fri, 23 Apr 2021 17:21:38 +0100 > > Daniel P. Berrangé wrote: > > > The current IP socket impl for the net socket backend uses SOCK_DGRAM, > > > so from a consi

Re: socket.c added support for unix domain socket datagram transport

2021-04-27 Thread Stefano Brivio
On Mon, 26 Apr 2021 13:14:48 +0200 Ralph Schmieder wrote: > > On Apr 23, 2021, at 18:39, Stefano Brivio > > wrote: > > > > [...] > > > > Okay, so it doesn't seem to fit your case, but this specific point > > is where you actually have a small advantage using a stream-oriented > > socket. If you

Re: [PATCH v3 07/33] block/nbd: simplify waking of nbd_co_establish_connection()

2021-04-27 Thread Roman Kagan
On Fri, Apr 16, 2021 at 11:08:45AM +0300, Vladimir Sementsov-Ogievskiy wrote: > Instead of connect_bh, bh_ctx and wait_connect fields we can live with > only one link to waiting coroutine, protected by mutex. > > So new logic is: > > nbd_co_establish_connection() sets wait_co under mutex, release

[PATCH] linux-user/aarch64: Enable hwcap for RND, BTI, and MTE

2021-04-27 Thread Richard Henderson
These three features are already enabled by TCG, but are missing their hwcap bits. Update HWCAP2 from linux v5.12. Cc: qemu-sta...@nongnu.org (for 6.0.1) Buglink: https://bugs.launchpad.net/bugs/1926044 Signed-off-by: Richard Henderson --- linux-user/elfload.c | 13 + 1 file changed

Re: [PATCH v8 08/11] hw/core: deprecate old reset functions and introduce new ones

2021-04-27 Thread Eduardo Habkost
On Tue, Apr 27, 2021 at 02:21:28PM +0200, Philippe Mathieu-Daudé wrote: > On 1/23/20 2:28 PM, Damien Hedde wrote: > > Deprecate device_legacy_reset(), qdev_reset_all() and > > qbus_reset_all() to be replaced by new functions > > device_cold_reset() and bus_cold_reset() which uses resettable API. >

Re: [PATCH] i386/cpu: Remove the deprecated cpu model 'Icelake-Client'

2021-04-27 Thread Eduardo Habkost
On Thu, Apr 22, 2021 at 05:42:16PM +0800, Robert Hoo wrote: > As it's been marked deprecated since v5.2, now I think it's time remove it > from code. > > Signed-off-by: Robert Hoo Thanks! There's only one issue: we need to update docs/system/deprecated.rst and docs/system/removed-features.rst w

Re: [PATCH] Deprecate pmem=on with non-DAX capable backend file

2021-04-27 Thread Eduardo Habkost
On Mon, Jan 11, 2021 at 03:33:32PM -0500, Igor Mammedov wrote: > It is not safe to pretend that emulated NVDIMM supports > persistence while backend actually failed to enable it > and used non-persistent mapping as fall back. > Instead of falling-back, QEMU should be more strict and > error out wit

Re: [PATCH] vmbus: Don't make QOM property registration conditional

2021-04-27 Thread Eduardo Habkost
On Sun, Apr 25, 2021 at 02:21:38PM +0200, Maciej S. Szmigiero wrote: > On 11.10.2020 01:30, Maciej S. Szmigiero wrote: > > On 09.10.2020 23:33, Eduardo Habkost wrote: > > > On Fri, Oct 09, 2020 at 11:05:47PM +0200, Maciej S. Szmigiero wrote: > > > > On 09.10.2020 22:07, Eduardo Habkost wrote: > > >

[Bug 1893040] Re: External modules retreval using Go1.15 on s390x appears to have checksum and ECDSA verification issues

2021-04-27 Thread Ruixin Bao
Hello @davidhildenbrand, I have been looking into this bug recently. So far, I noticed a few things: 1: Similarly as described in comment #5, I also had success building the go file described in the reproducing steps in #4 using Ubunutu-20.04 with recent qemu-system-s390x (I did it 1 - 2 weeks ago

Re: [RFC PATCH] hw/s390x/ccw: Register qbus type in abstract TYPE_CCW_DEVICE parent

2021-04-27 Thread Eric Farman
On Sat, 2021-04-24 at 16:53 +0200, Philippe Mathieu-Daudé wrote: > Instead of having all TYPE_CCW_DEVICE children set the bus type to > TYPE_VIRTUAL_CSS_BUS, do it once in the abstract parent. > > Signed-off-by: Philippe Mathieu-Daudé > --- > RFC because I don't know these devices, maybe there is

Re: [PATCH] target/mips: Migrate missing CPU fields

2021-04-27 Thread Philippe Mathieu-Daudé
On 4/24/21 12:00 AM, Philippe Mathieu-Daudé wrote: > Add various missing fields to the CPU migration vmstate: > > - CP0_VPControl & CP0_GlobalNumber (01bc435b44b 2016-02-03) > - CMGCRBase (c870e3f52ca 2016-03-15) > - CP0_ErrCtl(0d74a222c

Re: [PATCH] target/mips: Remove spurious LOG_UNIMP of MTHC0 opcode

2021-04-27 Thread Philippe Mathieu-Daudé
On Thu, Apr 22, 2021 at 10:10 AM Philippe Mathieu-Daudé wrote: > > When running with '-d unimp' all MTHC0 opcode executed > are logged as unimplemented... Add the proper 'return' > statement missed from commit 5204ea79ea7. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/translate.c

Re: [PATCH] target/mips: Add missing CP0 check to nanoMIPS RDPGPR / WRPGPR opcodes

2021-04-27 Thread Philippe Mathieu-Daudé
On 4/21/21 8:50 PM, Philippe Mathieu-Daudé wrote: > Per the nanoMIPS32 Instruction Set Technical Reference Manual, > Revision 01.01, Chapter 3. "Instruction Definitions": > > The Read/Write Previous GPR opcodes "require CP0 privilege". > > Add the missing CP0 checks. > > Signed-off-by: Philippe

Re: [PATCH] target/mips: Fix CACHEE opcode (CACHE using EVA addressing)

2021-04-27 Thread Philippe Mathieu-Daudé
On 4/20/21 7:54 PM, Philippe Mathieu-Daudé wrote: > The CACHEE opcode "requires CP0 privilege". > > The pseudocode checks in the ISA manual is: > > if is_eva and not C0.Config5.EVA: > raise exception('RI') > > if not IsCoprocessor0Enabled(): > raise coprocessor_exception(0) >

[RFC PATCH 2/2] hw/sparc: Allow building without the leon3 machine

2021-04-27 Thread Philippe Mathieu-Daudé
When building without the leon3 machine, we get this link failure: /usr/bin/ld: target_sparc_int32_helper.c.o: in function `leon3_irq_manager': target/sparc/int32_helper.c:172: undefined reference to `leon3_irq_ack' This is because the leon3_irq_ack() is declared in hw/sparc/leon3.c, which is

[PATCH 1/2] hw/sparc: Allow building the leon3 machine stand-alone

2021-04-27 Thread Philippe Mathieu-Daudé
When building only the leon3 machine, we get this link failure: /usr/bin/ld: target_sparc_win_helper.c.o: in function `cpu_put_psr': target/sparc/win_helper.c:91: undefined reference to `cpu_check_irqs' This is because cpu_check_irqs() is defined in hw/sparc/sun4m.c, which is only built if th

[PATCH 0/2] hw/sparc: Kconfig fixes to build with/without the leon3 machine

2021-04-27 Thread Philippe Mathieu-Daudé
This series fixes link failure when building either the leon3 machine or the sun4m ones. The problem is we have hardware specific code in the architectural translation code. Move this code to hw/sparc/. The link failures can be reproduced doing: $ echo CONFIG_LEON3=y > default-configs/devices/

[RFC PATCH] target/mips: Allow building without Inter-Thread Communication hardware

2021-04-27 Thread Philippe Mathieu-Daudé
The Inter-Thread Communication unit (TYPE_MIPS_ITU) is an optional device that is only selected by a few machines. However it goes deep into the translation code, as the MTC0/MTHC0 SAAR helpers call itc_reconfigure(). When building with no machine selecting the ITU component (which is implemented

Re: [PATCH] make vfio and DAX cache work together

2021-04-27 Thread Dr. David Alan Gilbert
* Alex Williamson (alex.william...@redhat.com) wrote: > On Tue, 27 Apr 2021 17:29:37 +0100 > Dev Audsin wrote: > > > Hi Alex > > > > Based on your comments and thinking a bit, wonder if it makes sense to > > allow DMA map for the DAX cache but make unexpected mappings to be not > > fatal. Please

[PATCH] cirrus.yml: Fix the MSYS2 task

2021-04-27 Thread Thomas Huth
The MSYS2 task in the Cirrus-CI is currently failing with error messages like this: warning: database file for 'ucrt64' does not exist (use '-Sy' to download) :: Starting core system upgrade... there is nothing to do :: Starting full system upgrade... error: failed to prepare transaction (co

Re: [PATCH v2 2/7] virtiofds: Changed allocations of iovec to GLib's functions

2021-04-27 Thread Dr. David Alan Gilbert
* Mahmoud Mandour (ma.mando...@gmail.com) wrote: > On Tue, Apr 27, 2021 at 1:33 PM Dr. David Alan Gilbert > wrote: > > > * Mahmoud Mandour (ma.mando...@gmail.com) wrote: > > > On Tue, Apr 27, 2021 at 1:01 PM Dr. David Alan Gilbert < > > dgilb...@redhat.com> > > > wrote: > > > > > > > * Mahmoud Ma

Re: [PATCH RFC C0/2] support allocation-map for block-dirty-bitmap-merge

2021-04-27 Thread John Snow
On 4/27/21 7:11 AM, Vladimir Sementsov-Ogievskiy wrote: Hi all! It's a simpler alternative for "[PATCH v4 0/5] block: add block-dirty-bitmap-populate job" <20200902181831.2570048-1-ebl...@redhat.com> https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg00978.html https://patchew.org

Re: [PATCH v2 2/7] virtiofds: Changed allocations of iovec to GLib's functions

2021-04-27 Thread Mahmoud Mandour
On Tue, Apr 27, 2021 at 1:33 PM Dr. David Alan Gilbert wrote: > * Mahmoud Mandour (ma.mando...@gmail.com) wrote: > > On Tue, Apr 27, 2021 at 1:01 PM Dr. David Alan Gilbert < > dgilb...@redhat.com> > > wrote: > > > > > * Mahmoud Mandour (ma.mando...@gmail.com) wrote: > > > > On Tue, Apr 27, 2021 a

Re: [PATCH] make vfio and DAX cache work together

2021-04-27 Thread Alex Williamson
On Tue, 27 Apr 2021 17:29:37 +0100 Dev Audsin wrote: > Hi Alex > > Based on your comments and thinking a bit, wonder if it makes sense to > allow DMA map for the DAX cache but make unexpected mappings to be not > fatal. Please let me know your thoughts. I think you're still working on the assum

[PATCH v3 2/7] virtiofsd: Changed allocations of iovec to GLib's functions

2021-04-27 Thread Mahmoud Mandour
Replaced the calls to malloc()/calloc() and their respective calls to free() of iovec structs with GLib's allocation and deallocation functions and used g_autofree when appropriate. Replaced the allocation of in_sg_cpy to g_new() instead of a call to calloc() and a null-checking assertion. Not g_n

Re: [PATCH] floppy: remove unused function fdctrl_format_sector

2021-04-27 Thread John Snow
On 3/14/21 3:53 AM, Hervé Poussineau wrote: Le 12/03/2021 à 07:45, John Snow a écrit : On 1/8/21 6:01 PM, Alexander Bulekov wrote: fdctrl_format_sector was added in baca51faff ("updated floppy driver: formatting code, disk geometry auto detect (Jocelyn Mayer)") The single callsite is guarded

[PATCH v2] fdc: fix floppy boot for Red Hat Linux 5.2

2021-04-27 Thread John Snow
The image size indicates it's an 81 track floppy disk image, which we don't have a listing for in the geometry table. When you force the drive type to 1.44MB, it guesses the reasonably close 18/80. When the drive type is allowed to auto-detect or set to 2.88, it guesses a very incorrect geometry.

Re: [PATCH 2/4] hw/block/fdc: Declare shared prototypes in fdc-internal.h

2021-04-27 Thread Philippe Mathieu-Daudé
On 4/27/21 6:53 PM, John Snow wrote: > On 4/15/21 6:23 AM, Philippe Mathieu-Daudé wrote: >> We want to extract ISA/SysBus code from the generic fdc.c file. >> First, declare the prototypes we will access from the new units >> into a new local header: "fdc-internal.h". >> >> Signed-off-by: Philippe

Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine

2021-04-27 Thread John Snow
On 4/16/21 8:52 AM, Thomas Huth wrote: QEMU currently crashes when the user tries to do something like: qemu-system-x86_64 -M x-remote -device piix3-ide This happens because the "isabus" variable is not initialized with the x-remote machine yet. Add a proper check for this condition and propa

Re: [PATCH 0/4] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers

2021-04-27 Thread John Snow
On 4/15/21 6:23 AM, Philippe Mathieu-Daudé wrote: Hi, The floppy disc controllers pulls in irrelevant devices (sysbus in an ISA-only machine, ISA bus + isa devices on a sysbus-only machine). This series clean that by extracting each device in its own file, adding the corresponding Kconfig symbo

Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine

2021-04-27 Thread John Snow
On 4/27/21 1:54 PM, Philippe Mathieu-Daudé wrote: On 4/27/21 7:16 PM, John Snow wrote: On 4/27/21 9:54 AM, Stefan Hajnoczi wrote: I suggest fixing this at the qdev level. Make piix3-ide have a sub-device that inherits from ISA_DEVICE so it can only be instantiated when there's an ISA bus. Stef

Re: [PATCH 4/4] hw/block/fdc: Extract SysBus floppy controllers to fdc-sysbus.c

2021-04-27 Thread John Snow
On 4/15/21 6:23 AM, Philippe Mathieu-Daudé wrote: Some machines use floppy controllers via the SysBus interface, and don't need to pull in all the SysBus code. Extract the SysBus specific code to a new unit: fdc-sysbus.c, and add a new Kconfig symbol: "FDC_SYSBUS". Signed-off-by: Philippe Mathie

Re: [PATCH v11 5/6] KVM: arm64: ioctl to fetch/store tags in a guest

2021-04-27 Thread Catalin Marinas
On Fri, Apr 16, 2021 at 04:43:08PM +0100, Steven Price wrote: > diff --git a/arch/arm64/include/uapi/asm/kvm.h > b/arch/arm64/include/uapi/asm/kvm.h > index 24223adae150..2b85a047c37d 100644 > --- a/arch/arm64/include/uapi/asm/kvm.h > +++ b/arch/arm64/include/uapi/asm/kvm.h > @@ -184,6 +184,20 @@

Re: [PATCH 01/22] qapi/parser: Don't try to handle file errors

2021-04-27 Thread John Snow
On 4/27/21 9:47 AM, Markus Armbruster wrote: John Snow writes: On 4/23/21 11:46 AM, Markus Armbruster wrote: John Snow writes: The short-ish version of what motivates this patch is: - The parser initializer does not possess adequate context to write a good error message -- It tries to

Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine

2021-04-27 Thread Philippe Mathieu-Daudé
On 4/27/21 7:16 PM, John Snow wrote: > On 4/27/21 9:54 AM, Stefan Hajnoczi wrote: >> I suggest fixing this at the qdev level. Make piix3-ide have a >> sub-device that inherits from ISA_DEVICE so it can only be instantiated >> when there's an ISA bus. >> >> Stefan > > My qdev knowledge is shaky. Do

Re: [PATCH 1/1] Set TARGET_PAGE_BITS to be 10 instead of 8 bits

2021-04-27 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Sun, 11 Apr 2021 at 16:15, Richard Henderson > wrote: > > > > On 4/10/21 10:24 AM, Michael Rolnik wrote: > > > Please review. > > > > > > The first 256b is i/o, the next 768b are ram. But having changed the page > > size, it should mean that

Re: [PATCH] Set the correct env->fpip for x86 float instructions [cleaned]

2021-04-27 Thread Richard Henderson
On 4/16/21 8:34 AM, Ziqiao Kong wrote: +++ b/target/i386/tcg/translate.c @@ -6337,7 +6337,10 @@ static target_ulong disas_insn(DisasContext *s, CPUState *cpu) goto unknown_op; } } +tcg_gen_movi_tl(s->tmp0, pc_start - s->cs_base); +tcg_gen

[PATCH v2 15/15] target/ppc: Check cpu flags for prefixed insn support

2021-04-27 Thread Luis Pires
Prefixed instructions were introduced in Power ISA 3.1 Signed-off-by: Luis Pires --- target/ppc/translate.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 7422ea4e13..f4802a4f08 100644 --- a/target/ppc/translate.c ++

Re: [PATCH v11 1/6] arm64: mte: Sync tags for pages where PTE is untagged

2021-04-27 Thread Catalin Marinas
On Fri, Apr 16, 2021 at 04:43:04PM +0100, Steven Price wrote: > A KVM guest could store tags in a page even if the VMM hasn't mapped > the page with PROT_MTE. So when restoring pages from swap we will > need to check to see if there are any saved tags even if !pte_tagged(). > > However don't check

[PATCH v2 13/15] target/ppc: Move D/DS/X-form integer stores to decodetree

2021-04-27 Thread Luis Pires
From: Richard Henderson These are all connected by macros in the legacy decoding. Signed-off-by: Richard Henderson --- target/ppc/insn32.decode | 22 ++ target/ppc/translate.c | 85 +- target/ppc/translate/fixedpoint-impl.c.inc | 84

[PATCH v2 12/15] target/ppc: Implement prefixed integer load instructions

2021-04-27 Thread Luis Pires
From: Richard Henderson Signed-off-by: Richard Henderson --- target/ppc/insn64.decode | 15 ++ target/ppc/translate/fixedpoint-impl.c.inc | 60 ++ 2 files changed, 75 insertions(+) diff --git a/target/ppc/insn64.decode b/target/ppc/insn64.decode index

[PATCH v2 14/15] target/ppc: Implement prefixed integer store instructions

2021-04-27 Thread Luis Pires
From: Richard Henderson Signed-off-by: Richard Henderson --- target/ppc/insn64.decode | 12 target/ppc/translate/fixedpoint-impl.c.inc | 20 2 files changed, 32 insertions(+) diff --git a/target/ppc/insn64.decode b/target/ppc/insn64.decode in

  1   2   3   >