在 2021/4/27 上午11:39, Cindy Lu 写道:
Now the code for interrupt/vector are coupling
with the vq number, this patch will decouple the vritqueue
numbers from these functions.
So you need to describe why such kind of decoupling is needed,
Signed-off-by: Cindy Lu
---
hw/virtio/virtio-pci.c |
On Mon, Apr 26, 2021 at 01:03:04PM +0200, Klaus Jensen wrote:
On Apr 26 13:16, Gollu Appalanaidu wrote:
As per the TP 4056d Namespace types CNS 0x00 and CNS 0x11
CSI field shouldn't use but it is being used for these two
Identify command CNS values, fix that.
Signed-off-by: Gollu Appalanaidu
-
John Snow writes:
> On 4/25/21 3:27 AM, Markus Armbruster wrote:
>> John Snow writes:
>>
>>> The single quote token implies the value is a string. Assert this to be
>>> the case.
>>>
>>> Signed-off-by: John Snow
>>> ---
>>> scripts/qapi/parser.py | 2 ++
>>> 1 file changed, 2 insertions(+)
On Wed, Apr 21, 2021 at 7:37 AM Jose Martins wrote:
>
> The wfi exception trigger behavior should take into account user mode,
> hstatus.vtw, and the fact the an wfi might raise different types of
> exceptions depending on various factors:
>
> If supervisor mode is not present:
>
> - an illegal in
On Wed, Apr 21, 2021 at 2:19 PM wrote:
>
> From: Kito Cheng
>
> Signed-off-by: Kito Cheng
> Reviewed-by: Richard Henderson
> Signed-off-by: Frank Chang
Reviewed-by: Alistair Francis
Alistair
> ---
> target/riscv/insn32.decode | 4
> target/riscv/insn_trans/trans_rvb.c.i
John Snow writes:
> On 4/24/21 2:38 AM, Markus Armbruster wrote:
>> Mixing f-string and % interpolation. I doubt we'd write it this way
>> from scratch. I recommend to either stick to % for now (leave
>> conversion to f-strings for later), or conver the column formatting,
>> too, even though it
On Wed, Apr 21, 2021 at 2:20 PM wrote:
>
> From: Kito Cheng
>
> Signed-off-by: Kito Cheng
> Reviewed-by: Richard Henderson
> Signed-off-by: Frank Chang
Reviewed-by: Alistair Francis
Alistair
> ---
> target/riscv/insn32.decode | 2 ++
> target/riscv/insn_trans/trans_rvb.c.inc
On Wed, Apr 21, 2021 at 2:17 PM wrote:
>
> From: Kito Cheng
>
> Signed-off-by: Kito Cheng
> Signed-off-by: Frank Chang
> Reviewed-by: Richard Henderson
Reviewed-by: Alistair Francis
Alistair
> ---
> target/riscv/insn32.decode | 4
> target/riscv/insn_trans/trans_rvb.c.i
On Wed, Apr 21, 2021 at 2:17 PM wrote:
>
> From: Kito Cheng
>
> Signed-off-by: Kito Cheng
> Signed-off-by: Frank Chang
> Reviewed-by: Richard Henderson
Reviewed-by: Alistair Francis
Alistair
> ---
> target/riscv/insn32-64.decode | 3 ++
> target/riscv/insn32.decode
On Wed, Apr 21, 2021 at 2:18 PM wrote:
>
> From: Frank Chang
>
> Signed-off-by: Kito Cheng
> Reviewed-by: Richard Henderson
> Signed-off-by: Frank Chang
Reviewed-by: Alistair Francis
Alistair
> ---
> target/riscv/insn32-64.decode | 1 +
> target/riscv/insn32.decode
On Wed, Apr 21, 2021 at 2:14 PM wrote:
>
> From: Kito Cheng
>
> Signed-off-by: Kito Cheng
> Signed-off-by: Frank Chang
> Reviewed-by: Richard Henderson
> ---
> target/riscv/insn32-64.decode | 4 +++
> target/riscv/insn32.decode | 7 +++-
> target/riscv/insn_trans/tran
On Fri, Apr 23, 2021 at 4:46 PM Bin Meng wrote:
>
> On Mon, Feb 8, 2021 at 10:41 PM Bin Meng wrote:
> >
> > On Thu, Jan 21, 2021 at 10:18 PM Francisco Iglesias
> > wrote:
> > >
> > > Hi Bin,
> > >
> > > On [2021 Jan 21] Thu 16:59:51, Bin Meng wrote:
> > > > Hi Francisco,
> > > >
> > > > On Thu,
在 2021/4/27 上午11:39, Cindy Lu 写道:
In order to support configure interrupt. we will use queue number -1
as configure interrupt
since all these device are not support the configure interrupt
So we will add an check here, if the idx is -1, the function
will return;
The title is confusing since
Public bug reported:
chrome uses /proc/self/exe to fork render process.
Here a simple code to reproduce the issue. It's output parent then child but
failed with qemu: unknown option 'type=renderer'.
Maybe we can modify exec syscall to replace /proc/self/exe to the real
path.
//gcc -o self self.
Ok, thanks, since this was a regressin in Alpine, I'm marking the bug as
closed here.
** Changed in: qemu
Status: New => Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1895305
Title:
Add support for the following keys: KATAKANAHIRAGANA, HENKAN, MUHENKAN,
RO, and YEN. Before this commit, these keys did not work as expected
when a jp106 keyboard was connected to the guest as a usb-kbd device.
Signed-off-by: Katsuhiro Ueno
---
hw/input/hid.c | 4 ++--
1 file changed, 2 inserti
Patchew URL: https://patchew.org/QEMU/20210427033951.29805-1-l...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210427033951.29805-1-l...@redhat.com
Subject: [PATCH v6 0/9] vhost-vdpa: add support for con
Add support for configure interrupt, use kvm_irqfd_assign and set the
gsi to kernel. When the configure notifier was eventfd_signal by host
kernel, this will finally inject an msix interrupt to guest
---
hw/virtio/virtio-pci.c | 186 ++---
1 file changed, 120 in
On Fri, Apr 23, 2021 at 07:06:15PM -0300, Fabiano Rosas wrote:
> "Lucas Mateus Castro (alqotel)" writes:
>
> > This file should be used instead of spapr_hcall.c when compiling
> > without tcg (--disable-tcg) as it does not call tcg-only functions and
> > trips fatal error when invalid functions a
Add configure interrupt support for virtio-mmio bus. This
interrupt will working while backend is vhost-vdpa
Signed-off-by: Cindy Lu
---
hw/virtio/virtio-mmio.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c
index
Add configure notifier support in vhost and related driver
When backend support VIRTIO_NET_F_STATUS,setup the configure
interrupt function in vhost_dev_start and release the related
resource when vhost_dev_stop
Signed-off-by: Cindy Lu
---
hw/net/vhost_net.c | 9 +
hw/net/virtio-net.
Add new call back function in vhost-vdpa, this call back function only
supported in vhost-vdpa backend
Signed-off-by: Cindy Lu
---
hw/virtio/trace-events | 2 ++
hw/virtio/vhost-vdpa.c | 7 +++
2 files changed, 9 insertions(+)
diff --git a/hw/virtio/trace-events b/hw/virtio/trace-events
ind
This patch will decouple virtqueue from
virtio_queue_set_guest_notifier_fd_handler,
here queue number -1 mean the configure interrupt. The funtion
will set the config_notify_read as fd handler
Signed-off-by: Cindy Lu
---
hw/s390x/virtio-ccw.c | 6 +++---
hw/virtio/virtio-mmio.c| 8 +++
To support configure interrupt, we need to
add a new call back function for config interrupt.
Signed-off-by: Cindy Lu
---
include/hw/virtio/vhost-backend.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/hw/virtio/vhost-backend.h
b/include/hw/virtio/vhost-backend.h
index 8a6f8e2a
Now the code for interrupt/vector are coupling
with the vq number, this patch will decouple the vritqueue
numbers from these functions.
Signed-off-by: Cindy Lu
---
hw/virtio/virtio-pci.c | 51 --
1 file changed, 29 insertions(+), 22 deletions(-)
diff --gi
During the test, We found this fuction will continue running
while the peer is deleted, this will case the crash. so add
check for this.
Signed-off-by: Cindy Lu
---
hw/net/virtio-net.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.
On Fri, Apr 23, 2021 at 04:18:07PM -0300, Bruno Larsen (billionai) wrote:
65;6203;1c> finished isolation of CPU initialization logic from
> translation logic. CPU initialization now only has common code
> and may or may not call accelerator-specific code, as the
> build options require.
>
> Signed
On Mon, Apr 26, 2021 at 06:08:53PM -0300, Fabiano Rosas wrote:
> "Bruno Larsen (billionai)" writes:
>
> > This move is required to enable building without TCG.
> > All the logic related to registering SPRs specific to
> > some architectures or machines has been hidden in this
> > new file.
>
> H
In order to support configure interrupt. we will use queue number -1
as configure interrupt
since all these device are not support the configure interrupt
So we will add an check here, if the idx is -1, the function
will return;
Signed-off-by: Cindy Lu
---
hw/display/vhost-user-gpu.c| 8 +++
these patches are add the support for configure interrupt
These code are all tested in vp-vdpa (support configure interrupt)
vdpa_sim (not support configure interrupt)
test in virtio-pci bus and virtio-mmio bus
Change in v2:
Add support for virtio-mmio bus
active the notifier while the backend
On Mon, Apr 26, 2021 at 07:29:54PM +, Bruno Piazera Larsen wrote:
> > > code motion to remove opcode callback table from
> > > translate_init.c.inc to translate.c in preparation
> > > to remove #include from
> > > translate.c
> >
> > I'd mention the creation of destroy_ppc_opcodes since this p
On Fri, Apr 23, 2021 at 04:18:05PM -0300, Bruno Larsen (billionai) wrote:
> Moved all functions related to SPR read/write callbacks into a new file
> specific for holding these. This is setting up a better separation of
> SPR registration, which is required to be able to build disabling
> TCG.
>
>
> -Original Message-
> From: Philippe Mathieu-Daudé
> Sent: Monday, April 26, 2021 10:06 PM
> To: Duan, Zhenzhong ; qemu-
> de...@nongnu.org
> Cc: qemu-triv...@nongnu.org; pbonz...@redhat.com; Stefano Garzarella
>
> Subject: Re: [PATCH] cutils: Fix memleak in get_relocated_path()
>
> Hi
On Mon, Apr 26, 2021 at 03:47:06PM -0300, Bruno Larsen (billionai) wrote:
> All the code related to gdb has been moved from translate_init.c.inc
> file to the gdbstub.c file, where it makes more sense.
>
> Version 4 fixes the omission of internal.h in gdbstub, mentioned in
> <87sg3d2gf5@linux.
Hi, Dave
I think this set of patches is beneficial to upstream. Please check these
performance data. If you have any other ideas, please let me know.
Thanks
Lei.
-Original Message-
From: Rao, Lei
Sent: Friday, April 16, 2021 3:57 PM
To: dgilb...@redhat.com
Cc: qemu-devel@nongnu.org; Zh
On 2021/4/26 21:30, Daniel P. Berrangé wrote:
On Mon, Apr 26, 2021 at 10:08:52AM +0800, caodon...@kingsoft.com wrote:
Change the criteria for the initial CPU topology and maxcpus, user can
have more settings
Can you provide a better explanation of why this is needed. What
valid usage scenario
> -Original Message-
> From: Alessandro Di Federico
> Sent: Tuesday, March 30, 2021 9:38 AM
> To: qemu-devel@nongnu.org
> Cc: Taylor Simpson ; Brian Cain
> ; bab...@rev.ng; ni...@rev.ng; phi...@redhat.com;
> richard.hender...@linaro.org; Alessandro Di Federico
> Subject: [PATCH v3 09/1
> -Original Message-
> From: Alessandro Di Federico
> Sent: Thursday, April 15, 2021 11:35 AM
> To: qemu-devel@nongnu.org
> Cc: Taylor Simpson ; Brian Cain
> ; bab...@rev.ng; ni...@rev.ng; phi...@redhat.com;
> richard.hender...@linaro.org; Alessandro Di Federico
> Subject: [PATCH v4 09
On Tue, Apr 27, 2021 at 12:03:42AM +0200, BALATON Zoltan wrote:
> On Mon, 26 Apr 2021, Philippe Mathieu-Daudé wrote:
> > Beside the loongson3-virt machine (MIPS), the following machines
> > also use the fw_cfg device:
> >
> > - ARM: virt & sbsa-ref
> > - HPPA: generic machine
> > - X86: ACPI based
On Sat, Apr 24, 2021 at 06:22:28PM +0200, Philippe Mathieu-Daudé wrote:
> The OR_IRQ device is bus-less, thus isn't reset automatically.
> Add the raven_pcihost_reset() handler to manually reset the OR IRQ.
>
> Fixes: f40b83a4e31 ("40p: use OR gate to wire up raven PCI interrupts")
> Signed-off-by
On Mon, Apr 26, 2021 at 12:50:54PM -0300, Fabiano Rosas wrote:
> David Gibson writes:
>
> > On Wed, Apr 14, 2021 at 01:09:19PM -0700, Richard Henderson wrote:
> >> On 4/14/21 7:59 AM, Bruno Larsen (billionai) wrote:
> >> > All the code related to gdb has been moved from translate_init.c.inc
> >>
On Sat, Apr 24, 2021 at 06:22:25PM +0200, Philippe Mathieu-Daudé wrote:
> The TYPE_SPAPR_TCE_TABLE device is bus-less, thus isn't reset
> automatically. Register a reset handler to get reset with the
> machine.
>
> It doesn't seem to be an issue because it is that way since the
> device QDev'ifyc
On Mon, Apr 26, 2021 at 09:35:18PM +0200, Philippe Mathieu-Daudé wrote:
> Beside the loongson3-virt machine (MIPS), the following machines
> also use the fw_cfg device:
>
> - ARM: virt & sbsa-ref
> - HPPA: generic machine
> - X86: ACPI based (pc & microvm)
> - PPC64: various
> - SPARC: sun4m & sun
On Fri, Apr 23, 2021 at 10:28:14AM -0300, Fabiano Rosas wrote:
> David Gibson writes:
>
> > On Thu, Apr 22, 2021 at 04:35:34PM -0300, Fabiano Rosas wrote:
> >> Bruno Piazera Larsen writes:
> >>
> >> >> > You are correct! I've just tweaked the code that defines spr_register
> >> >> > and
> >> >
Public bug reported:
qemu 5.0, compiled from git
I am passing through a SATA cdrom via SCSI passthrough, with this
libvirt XML:
It seems to mostly work, I have written discs with it, except I am
getting errors that cause reads to take abou
virtio-fs with DAX is currently not compatible with NIC Pass through. VM
fails to boot when DAX cache is enabled and SR-IOV VF is being attached.
This patch solves the problem. Hencem DAX cache and SR-IOV VF are be
attached together.
When a SR-IOV VF attaches to a qemu process, vfio will try to
Patchew URL:
https://patchew.org/QEMU/20210426200553.145976-2-dev.devaq...@gmail.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210426200553.145976-2-dev.devaq...@gmail.com
Subject: [PATCH] skip virtio fs cache
Signed-off-by: Dev Audsin
---
hw/vfio/common.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index 6ff1daa763..3af70238bd 100644
--- a/hw/vfio/common.c
+++ b/hw/vfio/common.c
@@ -541,7 +541,8 @@ static int vfio_host_win_del(VFIOContaine
virtio-fs with DAX is currently not compatible with NIC Pass through.
When a SR-IOV VF attaches to a qemu process, vfio will try to pin the entire
DAX Window but it is empty when the guest boots and will fail.
A method to make VFIO and DAX to work together is to make vfio skip DAX cache.
Current
Signed-off-by: Dev Audsin
---
hw/vfio/common.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index 6ff1daa763..3af70238bd 100644
--- a/hw/vfio/common.c
+++ b/hw/vfio/common.c
@@ -541,7 +541,8 @@ static int vfio_host_win_del(VFIOContainer
Hi Alex and David
@Alex:
Justification on why this region cannot be a DMA target for the device,
virtio-fs with DAX is currently not compatible with NIC Pass through.
When a SR-IOV VF attaches to a qemu process, vfio will try to pin the
entire DAX Window but it is empty when the guest boots and
On 4/25/21 8:34 AM, Markus Armbruster wrote:
value: object isn't wrong, but why not _ExprValue?
Updated excuse:
because all the way back outside in _parse, we know that:
1. expr is a dict (because of get_expr(False))
2. expr['pragma'] is also a dict, because we explicitly check it there.
3.
On 4/25/21 8:32 AM, Markus Armbruster wrote:
John Snow writes:
TypeGuards wont exist in Python proper until 3.10. Ah well. We can hack
up our own by declaring this function to return the type we claim it
checks for and using this to safely downcast object -> List[str].
In so doing, I bring th
On Mon, Apr 26, 2021 at 10:21:54AM +0200, Roman Kapl wrote:
> Address was swapped with value when writing MMIO registers, so the user
> saw garbage in lot of cases. The interrupt status was not correctly set.
>
> Signed-off-by: Roman Kapl
Ouch. This API is just inconsistent, everyone else
uses a
On 4/24/21 2:38 AM, Markus Armbruster wrote:
Mixing f-string and % interpolation. I doubt we'd write it this way
from scratch. I recommend to either stick to % for now (leave
conversion to f-strings for later), or conver the column formatting,
too, even though it's not related to the patch's pu
On Mon, 26 Apr 2021, Philippe Mathieu-Daudé wrote:
Beside the loongson3-virt machine (MIPS), the following machines
also use the fw_cfg device:
- ARM: virt & sbsa-ref
- HPPA: generic machine
- X86: ACPI based (pc & microvm)
- PPC64: various
- SPARC: sun4m & sun4u
Add their FW_CFG Kconfig depend
This is not a regression (reproduced with 5.2 and 5.1)
IN: strlen
0x1000d780: 7d2a03f8 cmpb r10, r9, r0
OP:
ld_i32 tmp0,env,$0xfff0
brcond_i32 tmp0,$0x0,lt,$L0
1000d780
mov_i32 nip,$0x1000d780
mov_i32 tmp0,$0x60
mov_i32 tmp4,$0x21
call raise_exce
On Mon, 26 Apr 2021 21:50:38 +0100
Dev Audsin wrote:
> Hi Alex and David
>
> @Alex:
>
> Justification on why this region cannot be a DMA target for the device,
>
> virtio-fs with DAX is currently not compatible with NIC Pass through.
> When a SR-IOV VF attaches to a qemu process, vfio will try
"Bruno Larsen (billionai)" writes:
> This move is required to enable building without TCG.
> All the logic related to registering SPRs specific to
> some architectures or machines has been hidden in this
> new file.
Hm... I thought we ended up deciding to keep the gen_spr_
functions in translate
On Mon, 26 Apr 2021 21:27:52 +0100
Dev Audsin wrote:
> virtio-fs with DAX is currently not compatible with NIC Pass through. VM
> fails to boot when DAX cache is enabled and SR-IOV VF is being attached.
> This patch solves the problem. Hencem DAX cache and SR-IOV VF are be
> attached together.
Thank you. I can reproduce the problem.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1926202
Title:
qemu-user can't run some ppc binaries
Status in QEMU:
New
Bug description:
qemu-user v6.0.
Hello,
On behalf of the QEMU Team, I'd like to announce the availability of the
sixth release candidate for the QEMU 6.0 release. This release is meant
for testing purposes and should not be used in a production environment.
http://download.qemu-project.org/qemu-6.0.0-rc5.tar.xz
http://downlo
helloworld-centos.static.ppc is attached as part of comment #2
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1926202
Title:
qemu-user can't run some ppc binaries
Status in QEMU:
New
Bug descrip
> > The solution to move it to spr_tcg.c.inc and including it in translate.c
> > is a work in progress, any better solutions are very much appreciated.
> > Also, making the R/W functions not static is required for the next
> > commit.
>
> Looks like this could be done in the next commit then.
Sure
Could you provide directly the binary to test (helloworld-
centos.static.ppc)?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1926202
Title:
qemu-user can't run some ppc binaries
Status in QEMU:
** Tags added: linux-user
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1926202
Title:
qemu-user can't run some ppc binaries
Status in QEMU:
New
Bug description:
qemu-user v6.0.0-rc5, built i
On Sun, Apr 25, 2021 at 12:19:11AM -0500, Wei Huang wrote:
>
>
> On 4/23/21 4:27 PM, Eduardo Habkost wrote:
> > On Fri, Apr 23, 2021 at 12:32:00AM -0500, Wei Huang wrote:
> > > There was a customer request for const_tsc support on AMD guests. Right
> > > now
> > > this feature is turned off by d
"Bruno Larsen (billionai)" writes:
> Moved all functions related to SPR read/write callbacks into a new file
> specific for holding these. This is setting up a better separation of
> SPR registration, which is required to be able to build disabling
> TCG.
>
> The solution to move it to spr_tcg.c.
** Attachment added: "ppc binary that crashes qemu-user"
https://bugs.launchpad.net/qemu/+bug/1926202/+attachment/5492563/+files/helloworld-centos.static.ppc
** Description changed:
qemu-user v6.0.0-rc5, built in static mode, will crash for certain ppc
binaries. It seems to have somethin
Public bug reported:
qemu-user v6.0.0-rc5, built in static mode, will crash for certain ppc
binaries. It seems to have something to do with glibc for some Centos
versions. The problem is easiest to see with statically-linked
binaries.
The attached Dockerfile shows how to produce a ppc binary th
The ARM, HPPA and RISC-V architectures don't declare any fw_cfg
specific key. To simplify the buildsys machinery and allow building
QEMU without the fw_cfg device (in the next commit), first add a
per-architecture empty stub defining the fw_cfg_arch_key_name().
Update the MAINTAINERS section to co
fw_cfg related files are maintained in hw/nvram/, so it makes
sense to declare the FW_CFG_DMA Kconfig symbol there, along
with the FW_CFG one.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/display/Kconfig | 3 ---
hw/nvram/Kconfig | 4
2 files changed, 4 insertions(+), 3 deletions(-)
diff
The TYPE_VMGENID device depends on fw_cfg:
$ git grep \ fw_cfg hw/acpi/vmgenid.c
hw/acpi/vmgenid.c:128:fw_cfg_add_file(s, VMGENID_GUID_FW_CFG_FILE,
guid->data,
hw/acpi/vmgenid.c:131:fw_cfg_add_file_callback(s,
VMGENID_ADDR_FW_CFG_FILE, NULL, NULL, NULL,
Add the proper Kconfig depe
If the Kconfig 'FW_CFG' symbol is not selected, it is pointless
to build the fw_cfg device. Update the stubs.
Signed-off-by: Philippe Mathieu-Daudé
---
stubs/fw_cfg.c | 49 ++--
hw/nvram/meson.build | 2 +-
2 files changed, 48 insertions(+), 3 delet
Beside the loongson3-virt machine (MIPS), the following machines
also use the fw_cfg device:
- ARM: virt & sbsa-ref
- HPPA: generic machine
- X86: ACPI based (pc & microvm)
- PPC64: various
- SPARC: sun4m & sun4u
Add their FW_CFG Kconfig dependency.
Signed-off-by: Philippe Mathieu-Daudé
---
hw
User emulation or tools don't use / require the fw_cfg device.
Signed-off-by: Philippe Mathieu-Daudé
---
stubs/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/stubs/meson.build b/stubs/meson.build
index be6f6d609e5..4ff36401cf9 100644
--- a/stubs/meson.build
+++ b
Targets using the fw_cfg device might have architecture specific
keys. If so, they define the fw_cfg_arch_key_name() function.
The use of FW_CFG_MIPS is not MIPS-specific, it is simply the
architectural implementation. Rename it using the generic 'FW_CFG'
and move the Kconfig declaration in hw/nvr
Hi,
Quite a trivial series around fw_cfg:
- enforce the FW_CFG Kconfig symbol,
- add missing Kconfig dependencies,
- explicit machines using the fw_cfg device,
- allow targets not using the device to build without it.
Please review,
Phil.
Philippe Mathieu-Daudé (7):
stubs: Restrict fw_cfg stu
> > code motion to remove opcode callback table from
> > translate_init.c.inc to translate.c in preparation
> > to remove #include from
> > translate.c
>
> I'd mention the creation of destroy_ppc_opcodes since this patch is not
> strictly just moving code.
Sure, will do for v2.
> > +#if defined(
Hi Kunkun,
On 4/15/21 4:03 AM, Kunkun Jiang wrote:
> Hi Eric,
>
> On 2021/4/14 16:05, Auger Eric wrote:
>> Hi Kunkun,
>>
>> On 4/14/21 3:45 AM, Kunkun Jiang wrote:
>>> On 2021/4/13 20:57, Auger Eric wrote:
Hi Kunkun,
On 4/13/21 2:10 PM, Kunkun Jiang wrote:
> Hi Eric,
>
"Bruno Larsen (billionai)" writes:
> code motion to remove opcode callback table from
> translate_init.c.inc to translate.c in preparation
> to remove #include from
> translate.c
I'd mention the creation of destroy_ppc_opcodes since this patch is not
strictly just moving code.
>
> Signed-off-b
26.04.2021 21:30, John Snow wrote:
On 4/26/21 2:05 PM, Daniel P. Berrangé wrote:
On Mon, Apr 26, 2021 at 09:00:36PM +0300, Vladimir Sementsov-Ogievskiy wrote:
26.04.2021 20:34, John Snow wrote:
On 4/23/21 8:59 AM, Vladimir Sementsov-Ogievskiy wrote:
Modern way is using blockdev-add + blockdev
All the code related to gdb has been moved from translate_init.c.inc
file to the gdbstub.c file, where it makes more sense.
Version 4 fixes the omission of internal.h in gdbstub, mentioned in
<87sg3d2gf5@linux.ibm.com>, and the extra blank line.
Signed-off-by: Bruno Larsen (billionai)
Sugges
On 4/26/21 2:41 PM, Vladimir Sementsov-Ogievskiy wrote:
26.04.2021 21:30, John Snow wrote:
On 4/26/21 2:05 PM, Daniel P. Berrangé wrote:
On Mon, Apr 26, 2021 at 09:00:36PM +0300, Vladimir
Sementsov-Ogievskiy wrote:
26.04.2021 20:34, John Snow wrote:
On 4/23/21 8:59 AM, Vladimir Sementsov-Ogie
On 4/26/21 2:05 PM, Daniel P. Berrangé wrote:
On Mon, Apr 26, 2021 at 09:00:36PM +0300, Vladimir Sementsov-Ogievskiy wrote:
26.04.2021 20:34, John Snow wrote:
On 4/23/21 8:59 AM, Vladimir Sementsov-Ogievskiy wrote:
Modern way is using blockdev-add + blockdev-backup, which provides a
lot more c
On 4/25/21 9:27 AM, Markus Armbruster wrote:
John Snow writes:
Signed-off-by: John Snow
---
My hubris is infinite.
Score one of the three principal virtues of a programmer ;)
It was written before the prior review, but I promise I am slowing down
on adding these. I just genuinely left
On Mon, Apr 26, 2021 at 09:00:36PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 26.04.2021 20:34, John Snow wrote:
> > On 4/23/21 8:59 AM, Vladimir Sementsov-Ogievskiy wrote:
> > > Modern way is using blockdev-add + blockdev-backup, which provides a
> > > lot more control on how target is opened.
>
26.04.2021 20:34, John Snow wrote:
On 4/23/21 8:59 AM, Vladimir Sementsov-Ogievskiy wrote:
Modern way is using blockdev-add + blockdev-backup, which provides a
lot more control on how target is opened.
As example of drive-backup problems consider the following:
User of drive-backup expects tha
On 4/25/21 8:34 AM, Markus Armbruster wrote:
John Snow writes:
Annotations do not change runtime behavior.
This commit *only* adds annotations.
(Annotations for QAPIDoc are in a later commit.)
Signed-off-by: John Snow
---
scripts/qapi/parser.py | 61 ---
On 4/25/21 3:59 AM, Markus Armbruster wrote:
John Snow writes:
When the token can be None, we can't use 'x in "abc"' style membership
tests to group types of tokens together, because 'None in "abc"' is a
TypeError.
Easy enough to fix, if not a little ugly.
Signed-off-by: John Snow
---
scr
Min-Yih Hsu writes:
> Hi Alex,
>
>> On Apr 23, 2021, at 8:44 AM, Alex Bennée wrote:
>>
>>
>> Min-Yih Hsu writes:
>>
>>> Hi Alex and QEMU developers,
>>>
>>> Recently I was working with the TCG plugin. I found that
>>> `qemu_plugin_cb_flags` seems to reserve the functionality to
>>> read
On 4/25/21 3:54 AM, Markus Armbruster wrote:
John Snow writes:
Mypy cannot generally understand that these regex functions cannot
possibly fail. Add a _nofail helper that clarifies this for mypy.
Convention wants a blank line here.
Tooling failure.
stg pop -a
while stg push; and stg edit
On 4/25/21 3:27 AM, Markus Armbruster wrote:
John Snow writes:
The single quote token implies the value is a string. Assert this to be
the case.
Signed-off-by: John Snow
---
scripts/qapi/parser.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/qapi/parser.py b/scripts/qapi/
On 4/24/21 4:33 AM, Markus Armbruster wrote:
The second operand of assert provides no additional information. Please
drop it.
I don't agree with "no additional information", strictly.
I left you a comment on gitlab before you started reviewing on-list.
What I wrote there:
"Markus: I know y
On 4/24/21 2:38 AM, Markus Armbruster wrote:
Not mentioned in the commit message: you add a default parameter value.
It's not used; there's just one caller, and it passes a value.
Intentional?
No. Leftover from an earlier version where it was used. It can be made
to always be an explicit para
From: hchkuo
Pre-built CDAT table for testing, contains one CDAT header and six
CDAT entries: DSMAS, DSLBIS, DSMSCIS, DSIS, DSEMTS, and SSLBIS
respectively.
Signed-off-by: Chris Browy
---
tests/data/cdat/cdat.dat | Bin 0 -> 148 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
create mod
On 4/23/21 8:59 AM, Vladimir Sementsov-Ogievskiy wrote:
Modern way is using blockdev-add + blockdev-backup, which provides a
lot more control on how target is opened.
As example of drive-backup problems consider the following:
User of drive-backup expects that target will be opened in the same
From: hchkuo
The Data Object Exchange implementation of CXL Coherent Device Attribute
Table (CDAT). This implementation is referring to "Coherent Device
Attribute Table Specification, Rev. 1.02, Oct. 2020" and "Compute
Express Link Specification, Rev. 2.0, Oct. 2020"
The CDAT can be specified in
From: hchkuo
The Data Object Exchange implementation of CXL Compliance Mode is
referring to "Compute Express Link (CXL) Specification, Rev. 2.0, Oct.
2020".
The data structure of CXL compliance request and response is added to
the header. Due to the scope limitation of QEMU, most of the complian
Hi Wei, Eduardo,
On Fri, Apr 23, 2021 at 05:27:44PM -0400, Eduardo Habkost wrote:
> On Fri, Apr 23, 2021 at 12:32:00AM -0500, Wei Huang wrote:
> > There was a customer request for const_tsc support on AMD guests. Right now
> > this feature is turned off by default for QEMU x86 CPU types (in
> >
1 - 100 of 210 matches
Mail list logo
