Hi all,
This patch makes locally used symbols static to enable more compiler
optimizations on them. Some of the symbols turned out to not be used
at all so I marked them with ATTRIBUTE_UNUSED (as I wasn't sure if
they were ok to delete).
The symbols have been identified with a pet project of mine
I have sent a first patch around this:
https://lists.nongnu.org/archive/html/qemu-devel/2021-03/msg09391.html
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1090604
Title:
RFE: Implement support for
Hi Vaibhav,
Some comments inline..
On 3/29/21 9:52 PM, Vaibhav Jain wrote:
Add support for H_SCM_HEALTH hcall described at [1] for spapr
nvdimms. This enables guest to detect the 'unarmed' status of a
specific spapr nvdimm identified by its DRC and if its unarmed, mark
the region backed by the
On Mon, Mar 29, 2021 at 10:26:02AM -0600, Richard Henderson wrote:
> On 3/29/21 7:05 AM, Greg Kurz wrote:
> > On Wed, 24 Mar 2021 11:03:02 +1100
> > David Gibson wrote:
> >
> > > On Tue, Mar 23, 2021 at 12:43:32PM -0600, Richard Henderson wrote:
> > > > Copying flags directly from msr has drawbac
> -Original Message-
> From: Qemu-devel bounces+chen.zhang=intel@nongnu.org> On Behalf Of Markus
> Armbruster
> Sent: Tuesday, March 23, 2021 5:58 PM
> To: Zhang, Chen
> Cc: Lukas Straub ; Li Zhijian
> ; Jason Wang ; qemu-
> dev ; Dr. David Alan Gilbert
> ; Zhang Chen
> Subject: R
On Wed, Mar 24, 2021 at 09:09:02PM +0100, Klaus Jensen wrote:
From: Klaus Jensen
Add the missing nvme_adm_opc_str entry for the Namespace Attachment
command.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/block/nvme.h b/hw/block/nvme.h
in
On Wed, Mar 24, 2021 at 09:09:01PM +0100, Klaus Jensen wrote:
From: Klaus Jensen
Protection Information can only be enabled if there is at least 8 bytes
of metadata.
Signed-off-by: Klaus Jensen
---
hw/block/nvme-ns.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/
On Thu, 25 Mar 2021 19:57:05 +0300
Valeriy Vdovin wrote:
> Introducing new qapi method 'query-cpu-model-cpuid'. This method can be used
> to
> get virtualized cpu model info generated by QEMU during VM initialization in
> the form of cpuid representation.
>
> Diving into more details about virt
On Mon, 29 Mar 2021 15:32:37 -0300
Daniel Henrique Barboza wrote:
> On 3/29/21 12:32 PM, Cédric Le Goater wrote:
> > On 3/29/21 6:20 AM, David Gibson wrote:
> >> On Thu, Mar 25, 2021 at 09:56:04AM +0100, Cédric Le Goater wrote:
> >>> On 3/25/21 3:10 AM, David Gibson wrote:
> On Tue, Ma
On Tue, 23 Mar 2021 12:03:58 +1100
David Gibson wrote:
> On Fri, Mar 19, 2021 at 03:34:52PM -0300, Daniel Henrique Barboza wrote:
> > Kernel commit 4bce545903fa ("powerpc/topology: Update
> > topology_core_cpumask") cause a regression in the pseries machine when
> > defining certain SMP topologie
On Wed, 24 Mar 2021 16:09:59 -0300
Daniel Henrique Barboza wrote:
> On 3/23/21 10:40 PM, David Gibson wrote:
> > On Tue, Mar 23, 2021 at 02:10:22PM -0300, Daniel Henrique Barboza wrote:
> >>
> >>
> >> On 3/22/21 10:12 PM, David Gibson wrote:
> >>> On Fri, Mar 12, 2021 at 05:07:36PM -0300, Dan
> -Original Message-
> From: Richard Henderson
> Sent: Thursday, March 25, 2021 11:25 AM
> To: Taylor Simpson ; qemu-devel@nongnu.org
> Cc: phi...@redhat.com; a...@rev.ng; Brian Cain
> Subject: Re: [PATCH 10/15] Hexagon (target/hexagon) instructions with
> multiple definitions
>
> On 3/
On Mon, 29 Mar 2021 at 12:19, Cédric Le Goater wrote:
>
> Implement an IPMI BT interface model using a chardev backend to
> communicate with an external PowerNV machine. It uses the OpenIPMI
> simulator protocol for virtual machines described in :
>
> https://github.com/cminyard/openipmi/blob/
On Mon, 29 Mar 2021 at 21:07, Derrick McKee wrote:
>
> Hi,
>
> I am running across a scenario where a PAC signed code pointer (using
> pacia) sometimes does not successfully authenticate despite the signed
> pointer and the salt used to sign the pointer are correctly given to a
> autia instruction
Il lun 29 mar 2021, 20:33 Daniel P. Berrangé ha
scritto:
> The obvious alternative is to import the contributor covenant
>
> https://www.contributor-covenant.org/
The Contributor Covenant 1.x and 2.x are very different in that 2.x also
includes conflict resolution. Unlike the code of conduct,
On 3/28/2021 11:58 PM, Jason Wang wrote:
在 2021/3/29 上午11:03, Brad Smith 写道:
It very much is correct. We don't care about such releases anymore.
So is there a doc/wiki to say Qemu doesn't support those OpenBSD release?
The (OpenBSD itself and QEMU) project only makes a concerted effort to
On Mon, 29 Mar 2021 15:46:53 +0100
"Dr. David Alan Gilbert" wrote:
> * Igor Mammedov (imamm...@redhat.com) wrote:
> > On Tue, 23 Mar 2021 17:40:36 +
> > Daniel P. Berrangé wrote:
> >
> > > On Tue, Mar 23, 2021 at 05:54:47PM +0100, Igor Mammedov wrote:
> > > > Let me hijack this thread f
12.03.2021 21:15, Max Reitz wrote:
On 05.03.21 18:35, Vladimir Sementsov-Ogievskiy wrote:
Compressed writes are unaligned to 512, which works very slow in
O_DIRECT mode. Let's use the cache.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/coroutines.h | 3 +
block/qcow2.h
On Mon, Mar 29, 2021 at 04:35:57PM +0100, Luis Henriques wrote:
> On Thu, Mar 25, 2021 at 11:38:52AM -0400, Vivek Goyal wrote:
> > When posix access acls are set on a file, it can lead to adjusting file
> > permissions (mode) as well. If caller does not have CAP_FSETID and it
> > also does not have
Le 28/03/2021 à 20:01, Frédéric Fortier via a écrit :
> getsockopt(fd, SOL_NETLINK, NETLINK_LIST_MEMBERSHIPS, *optval, *optlen)
> syscall allows optval to be NULL/invalid if optlen points to a size of
> zero. This allows userspace to query the length of the array they should
> use to get the full m
On Mon, 29 Mar 2021 at 20:20, John Simpson wrote:
>
> Hello,
>
> Kindly ask you to have a look at this bug.
> Thank you for your replies.
>> > On Sun, Mar 28, 2021 at 12:55:23PM +0300, John Simpson via Binutils wrote:
>> > > BUILD pc-bios/optionrom/kvmvapic.img
>> > > ld: Error: unable to dis
Hello,
Kindly ask you to have a look at this bug.
Thank you for your replies.
On Mon, Mar 29, 2021 at 7:07 PM George Dunlap
wrote:
> John,
>
> Thanks for your report. Can you post your bug report
> xen-de...@lists.xenproject.org ?
>
> The bug is in the compilation of QEMU, which is an external
Add support for H_SCM_HEALTH hcall described at [1] for spapr
nvdimms. This enables guest to detect the 'unarmed' status of a
specific spapr nvdimm identified by its DRC and if its unarmed, mark
the region backed by the nvdimm as read-only.
The patch adds h_scm_health() to handle the H_SCM_HEALTH
Add tests for yank with the chardev-change case.
Signed-off-by: Lukas Straub
Reviewed-by: Marc-André Lureau
Tested-by: Li Zhang
---
MAINTAINERS| 1 +
tests/unit/meson.build | 3 +-
tests/unit/test-yank.c | 227 +
3 files changed, 230 inse
Always pass the id to chardev_new, since it is needed to register
the yank instance for the chardev. Also, after checking that
nothing calls chardev_new with id=NULL, assert() that id!=NULL.
This fixes a crash when using chardev-change to change a chardev
to chardev-socket, which attempts to regis
Hello Everyone,
These patches increase test coverage for yank, add tests and fix bugs and
crashes in yank in combination with chardev-change.
Please Review.
Regards,
Lukas Straub
Changes:
-v7:
-test: fix patchew error by not using macros
-v6:
-test: (hopefully) fix test on OSX by using qio_net
Move object_property_try_add_child out of chardev_new into it's
callers. This is a preparation for the next patches to fix yank
with the chardev-change case.
Signed-off-by: Lukas Straub
Reviewed-by: Marc-André Lureau
Tested-by: Li Zhang
---
chardev/char.c | 42 -
When changing from chardev-socket (which supports yank) to
chardev-socket again, it fails, because the new chardev attempts
to register a new yank instance. This in turn fails, as there
still is the yank instance from the current chardev. Also,
the old chardev shouldn't unregister the yank instance
On Mon, 29 Mar 2021 22:19:17 +0400
Marc-André Lureau wrote:
> Hi Lukas
>
> On Mon, Mar 29, 2021 at 8:38 PM Lukas Straub wrote:
>
> > Hello Everyone,
> > These patches increase test coverage for yank, add tests and fix bugs and
> > crashes in yank in combination with chardev-change.
> > Please
On Mon, Mar 29, 2021 at 08:01:40PM +0200, Thomas Huth wrote:
> In an ideal world, we would all get along together very well, always be
> polite and never end up in huge conflicts. And even if there are conflicts,
> we would always handle each other fair and respectfully. Unfortunately,
> this is no
On 3/29/21 12:32 PM, Cédric Le Goater wrote:
On 3/29/21 6:20 AM, David Gibson wrote:
On Thu, Mar 25, 2021 at 09:56:04AM +0100, Cédric Le Goater wrote:
On 3/25/21 3:10 AM, David Gibson wrote:
On Tue, Mar 23, 2021 at 02:21:33PM -0300, Daniel Henrique Barboza wrote:
On 3/22/21 10:03 PM, Dav
Hi Lukas
On Mon, Mar 29, 2021 at 8:38 PM Lukas Straub wrote:
> Hello Everyone,
> These patches increase test coverage for yank, add tests and fix bugs and
> crashes in yank in combination with chardev-change.
> Please Review.
>
> Regards,
> Lukas Straub
>
> Changes:
> -v6:
> -test: (hopefully)
In an ideal world, we would all get along together very well, always be
polite and never end up in huge conflicts. And even if there are conflicts,
we would always handle each other fair and respectfully. Unfortunately,
this is not an ideal world and sometimes people forget how to interact with
eac
On Mon, 29 Mar 2021 at 18:03, Philippe Mathieu-Daudé wrote:
>
> Hi Peter,
>
> If you are preparing a qemu-arm pull request, can you
> squeeze this patch in?
Yep, that was my plan.
thanks
-- PMM
On Mon, 29 Mar 2021 at 17:30, Marc-André Lureau
wrote:
>
> Hi
>
> On Mon, Mar 29, 2021 at 7:56 PM Peter Maydell
> wrote:
>>
>> On Mon, 29 Mar 2021 at 15:17, Marc-André Lureau
>> wrote:
>> > ../docs/meson.build:30: WARNING: /usr/bin/sphinx-build-3:
>> > Configuration error:
>> > The Sphinx 'sphi
On Thu, Mar 25, 2021 at 04:07:27PM +0100, Greg Kurz wrote:
> Now that virtio-scsi-pci and virtio-blk-pci map 1 virtqueue per vCPU,
> a serious slow down may be observed on setups with a big enough number
> of vCPUs.
>
> Exemple with a pseries guest on a bi-POWER9 socket system (128 HW threads):
>
On Thu, Mar 25, 2021 at 04:07:30PM +0100, Greg Kurz wrote:
> Introduce VirtioBusClass methods to begin and commit a transaction
> of setting/unsetting host notifiers. These handlers will be implemented
> by virtio-pci to batch addition and deletion of ioeventfds for multiqueue
> devices like virtio
On Thu, Mar 25, 2021 at 04:07:35PM +0100, Greg Kurz wrote:
> This allows the virtio-scsi-pci device to batch additions and deletions
> of host notifiers. This significantly improves boot time of VMs with a
> high number of vCPUs, e.g. from 6m13.969s down to 1m4.268s for a pseries
> machine with 384
From: Bin Meng
Update the 'sifive_u' machine documentation to mention the '-dtb'
option that can be used to pass a custom DTB to QEMU.
Signed-off-by: Bin Meng
---
docs/system/riscv/sifive_u.rst | 47 +-
1 file changed, 41 insertions(+), 6 deletions(-)
diff --g
On Thu, Mar 25, 2021 at 04:07:33PM +0100, Greg Kurz wrote:
> This allows the virtio-blk-pci device to batch additions and deletions
> of host notifiers. This significantly improves boot time of VMs with a
> high number of vCPUs, e.g. from 3m26.408s down to 0m59.923s for a pseries
> machine with 384
On Thu, Mar 25, 2021 at 04:07:31PM +0100, Greg Kurz wrote:
> diff --git a/softmmu/memory.c b/softmmu/memory.c
> index 1b1942d521cc..0279e5671bcb 100644
> --- a/softmmu/memory.c
> +++ b/softmmu/memory.c
> @@ -2368,7 +2368,7 @@ void memory_region_add_eventfd_full(MemoryRegion *mr,
> if (size) {
On Thu, Mar 25, 2021 at 04:07:32PM +0100, Greg Kurz wrote:
> When dataplane multiqueue support was added in QEMU 2.7, the path
> that would rollback guest notifiers assignment in case of error
> simply got dropped.
>
> Later on, when Error was added to blk_set_aio_context() in QEMU 4.1,
> another
Patchew URL: https://patchew.org/QEMU/cover.1617035720.git.lukasstra...@web.de/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: cover.1617035720.git.lukasstra...@web.de
Subject: [PATCH v6 0/4] yank: Add chardev tests and
From: Bin Meng
The OpenSBI BIOS image names are used by many RISC-V machines.
Let's define macros for them.
Signed-off-by: Bin Meng
---
include/hw/riscv/boot.h | 5 +
hw/riscv/sifive_u.c | 6 ++
hw/riscv/spike.c| 6 ++
hw/riscv/virt.c | 6 ++
4 files change
From: Klaus Jensen
Max noticed that since blk_aio_pwrite_zeroes() may invoke the callback
before returning, the callbacks will never see *count == 0 and thus
never free the count variable or decrement num_formats causing a CQE to
never be posted.
Coverity (CID 1451082) also picked up on the fact
From: Bin Meng
The supported device bullet list has an additional space before each
entry, which makes a wrong indentation level. Correct it.
Signed-off-by: Bin Meng
---
docs/system/riscv/microchip-icicle-kit.rst | 20 +++
docs/system/riscv/sifive_u.rst | 30 ++
From: Bin Meng
Since commit 78da6a1bca22 ("device_tree: add qemu_fdt_setprop_string_array
helper"),
we can use the new helper to set the compatible strings for the
SiFive test device node.
Signed-off-by: Bin Meng
---
hw/riscv/virt.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
From: Bin Meng
At present the Microchip Icicle Kit machine only supports using
'-bios' to load the HSS, and does not support '-kernel' for direct
kernel booting just like other RISC-V machines do. One has to use
U-Boot which is chain-loaded by HSS, to load a kernel for testing.
This is not so con
From: Bin Meng
Linux kernel commit a2770b57d083 ("dt-bindings: timer: Add CLINT bindings")
adds the official DT bindings for CLINT, which uses "sifive,clint0"
as the compatible string. "riscv,clint0" is now legacy and has to
be kept for backward compatibility of legacy systems.
Signed-off-by: Bi
From: Bin Meng
The official DT bindings of PLIC uses "sifive,plic-1.0.0" as the
compatible string in the upstream Linux kernel. "riscv,plic0" is
now legacy and has to be kept for backward compatibility of legacy
systems.
Signed-off-by: Bin Meng
---
hw/riscv/sifive_u.c | 4 +++-
hw/riscv/virt.
On Thu, Mar 25, 2021 at 04:07:29PM +0100, Greg Kurz wrote:
> Multiqueue devices such as virtio-scsi or virtio-blk, all open-code the
> same pattern to setup/tear down host notifiers of the request virtqueues.
> Consolidate the pattern in a new virtio_bus_set_host_notifiers() API.
> Since virtio-scs
From: Bin Meng
Since commit 78da6a1bca22 ("device_tree: add qemu_fdt_setprop_string_array
helper"),
we can use the new helper to set the clock name for the ethernet
controller node.
Signed-off-by: Bin Meng
---
hw/riscv/sifive_u.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
d
From: Klaus Jensen
If nvme_map_dptr() fails, nvme_dif_rw() will leak the bounce context.
Fix this by using the same error handling as everywhere else in the
function.
Reported-by: Coverity (CID 1451080)
Fixes: 146f720c5563 ("hw/block/nvme: end-to-end data protection")
Signed-off-by: Klaus Jensen
From: Klaus Jensen
Hi Peter,
The following changes since commit ec2e6e016d24bd429792d08cf607e4c5350dcdaa:
Merge remote-tracking branch
'remotes/vivier2/tags/linux-user-for-6.0-pull-request' into staging (2021-03-28
19:49:57 +0100)
are available in the Git repository at:
git://git.infrad
On Thu, Mar 25, 2021 at 04:07:28PM +0100, Greg Kurz wrote:
> diff --git a/include/exec/memory.h b/include/exec/memory.h
> index 5728a681b27d..98ed552e001c 100644
> --- a/include/exec/memory.h
> +++ b/include/exec/memory.h
> @@ -1848,13 +1848,25 @@ void memory_region_clear_flush_coalesced(MemoryRegi
Hi Peter,
If you are preparing a qemu-arm pull request, can you
squeeze this patch in?
On 3/26/21 7:49 PM, Philippe Mathieu-Daudé wrote:
> On 3/26/21 2:34 PM, Peter Maydell wrote:
>> ping for review?
>
> FYI:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg790977.html
>
>> On Fri, 19 Ma
I have to admit that my time budget for IDE is quite low, so I will be
unable to look into this.
If you'd like to help debug it further and you have the time, you can
try building QEMU 6.0 (RC0 or so, something quite modern) and enabling
the IDE tracing options and trying to boot Solaris as you ha
When changing from chardev-socket (which supports yank) to
chardev-socket again, it fails, because the new chardev attempts
to register a new yank instance. This in turn fails, as there
still is the yank instance from the current chardev. Also,
the old chardev shouldn't unregister the yank instance
Always pass the id to chardev_new, since it is needed to register
the yank instance for the chardev. Also, after checking that
nothing calls chardev_new with id=NULL, assert() that id!=NULL.
This fixes a crash when using chardev-change to change a chardev
to chardev-socket, which attempts to regis
Move object_property_try_add_child out of chardev_new into it's
callers. This is a preparation for the next patches to fix yank
with the chardev-change case.
Signed-off-by: Lukas Straub
Reviewed-by: Marc-André Lureau
Tested-by: Li Zhang
---
chardev/char.c | 42 -
Add tests for yank with the chardev-change case.
Signed-off-by: Lukas Straub
Reviewed-by: Marc-André Lureau
Tested-by: Li Zhang
---
MAINTAINERS| 1 +
tests/unit/meson.build | 3 +-
tests/unit/test-yank.c | 200 +
3 files changed, 203 inse
Hello Everyone,
These patches increase test coverage for yank, add tests and fix bugs and
crashes in yank in combination with chardev-change.
Please Review.
Regards,
Lukas Straub
Changes:
-v6:
-test: (hopefully) fix test on OSX by using qio_net_listener on the dummy
server socket so new client
On 3/29/21 1:42 AM, Pavel Dovgalyuk wrote:
This patch handles icount mode for timer read/write instructions,
because it is required to call gen_io_start in such cases.
Signed-off-by: Pavel Dovgalyuk
Reviewed-by: Richard Henderson
Queued for 6.0.
r~
On Mon, Mar 22, 2021 at 11:46:55AM +, Daniel P. Berrangé wrote:
> On Mon, Mar 22, 2021 at 11:36:39AM +, Stefan Hajnoczi wrote:
> > On Mon, Feb 22, 2021 at 04:13:32PM +0100, Gerd Hoffmann wrote:
> > > Hi,
> > >
> > > > > TODO:
> > > > > Enabling modular tracepoints via -trace cmd line doe
Hi
On Mon, Mar 29, 2021 at 7:56 PM Peter Maydell
wrote:
> On Mon, 29 Mar 2021 at 15:17, Marc-André Lureau
> wrote:
> >
> > Hi
> >
> > On Mon, Mar 29, 2021 at 5:54 PM Peter Maydell
> wrote:
> >>
> >> This produces a backtrace from sphinx-build which nonetheless doesn't
> >> cause a build failur
On 17.02.21 12:58, Max Reitz wrote:
Implementing FUSE exports required no changes to the storage daemon, so
we forgot to document them there. Considering that both NBD and
vhost-user-blk exports are documented in its man page (and NBD exports
in its --help text), we should probably do the same f
On Mon, 29 Mar 2021 18:16:59 +0400
Marc-André Lureau wrote:
> Hi
>
> On Mon, Mar 29, 2021 at 5:54 PM Peter Maydell
> wrote:
> > [...]
> >
> > I dunno if we can get the error message neater (I know sphinx-build,
> > especially older versions, is a bit unhelpful about what it lets us
> > report.)
On 3/29/21 7:05 AM, Greg Kurz wrote:
On Wed, 24 Mar 2021 11:03:02 +1100
David Gibson wrote:
On Tue, Mar 23, 2021 at 12:43:32PM -0600, Richard Henderson wrote:
Copying flags directly from msr has drawbacks: (1) msr bits
mean different things per cpu, (2) msr has 64 bits on 64 cpus
while tb->fl
On 11.02.21 18:22, Max Reitz wrote:
Hi,
[...]
(Speaking of “unless the WRITE permission is shared”: mirror_top is a
bit broken in that it takes no permissions (but WRITE if necessary) and
shares everything. That seems wrong. Patch 1 addresses that, so that
patch 2 can actually do something
On 28/03/2021 13:21, Catalin Marinas wrote:
On Sat, Mar 27, 2021 at 03:23:24PM +, Catalin Marinas wrote:
On Fri, Mar 12, 2021 at 03:18:58PM +, Steven Price wrote:
diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c
index 77cb2d28f2a4..b31b7a821f90 100644
--- a/arch/arm64/kvm/mmu.c
On 18.09.20 17:33, Max Reitz wrote:
For its concurrent requests, 046 has always filtered the offset,
probably because concurrent requests may settle in any order. However,
it did not filter the request length, and so if requests with different
lengths settle in an unexpected order (notably the l
On 29.03.21 10:06, Pavel Dovgalyuk wrote:
Regular virtual timers are used to emulate timings
related to vCPU and peripheral states. QCOW2 uses timers
to clean the cache. These timers should have external
flag. In the opposite case they affect the execution
and it can't be recorded and replayed.
T
On Mon, 29 Mar 2021 at 15:17, Marc-André Lureau
wrote:
>
> Hi
>
> On Mon, Mar 29, 2021 at 5:54 PM Peter Maydell
> wrote:
>>
>> This produces a backtrace from sphinx-build which nonetheless doesn't
>> cause a build failure:
>>
>>
>> Program sphinx-build found: YES
>> ../docs/meson.build:30: WARNI
On 26/03/2021 18:56, Catalin Marinas wrote:
Hi Steven,
On Fri, Mar 12, 2021 at 03:18:57PM +, Steven Price wrote:
A KVM guest could store tags in a page even if the VMM hasn't mapped
the page with PROT_MTE. So when restoring pages from swap we will
need to check to see if there are any saved
On Mon, Mar 29, 2021 at 10:28 AM Max Reitz wrote:
>
> 297 so far does not check the named tests, which reside in the tests/
> directory (i.e. full path tests/qemu-iotests/tests). Fix it.
>
> Thanks to the previous two commits, all named tests pass its scrutiny,
> so we do not have to add anything
On Mon, Mar 29, 2021 at 10:28 AM Max Reitz wrote:
>
> There are a couple of things pylint takes issue with:
> - The "time" import is unused
> - The import order (iotests should come last)
> - get_bitmap_hash() doesn't use @self and so should be a function
> - Semicolons at the end of some lines
>
On Mon, Mar 29, 2021 at 10:28 AM Max Reitz wrote:
>
> pylint complains that discards1_sha256 and all_discards_sha256 are first
> set in non-__init__ methods. Let's make it happy.
>
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test | 3 +++
> 1 file change
On Mon, Mar 29, 2021 at 10:28 AM Max Reitz wrote:
>
> 169 and 199 have been renamed and moved to tests/ (commit a44be0334be:
> "iotests: rename and move 169 and 199 tests"), so we can drop them from
> the skip list.
>
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/297 | 2 +-
> 1 file cha
On Thu, Mar 25, 2021 at 11:38:52AM -0400, Vivek Goyal wrote:
> When posix access acls are set on a file, it can lead to adjusting file
> permissions (mode) as well. If caller does not have CAP_FSETID and it
> also does not have membership of owner group, this will lead to clearing
> SGID bit in mod
On 3/29/21 6:20 AM, David Gibson wrote:
> On Thu, Mar 25, 2021 at 09:56:04AM +0100, Cédric Le Goater wrote:
>> On 3/25/21 3:10 AM, David Gibson wrote:
>>> On Tue, Mar 23, 2021 at 02:21:33PM -0300, Daniel Henrique Barboza wrote:
On 3/22/21 10:03 PM, David Gibson wrote:
> On Fri, M
Viresh Kumar writes:
> This allows is to instantiate a vhost-user-i2c device as part of a PCI
> bus. It is mostly boilerplate which looks pretty similar to the
> vhost-user-fs-pci device.
>
> Signed-off-by: Viresh Kumar
> ---
> hw/virtio/meson.build | 1 +
> hw/virtio/vhost-user-i2c
Viresh Kumar writes:
> This creates the QEMU side of the vhost-user-i2c device which connects
> to the remote daemon. It is based of vhost-user-fs code.
>
> Signed-off-by: Viresh Kumar
> ---
> hw/virtio/Kconfig | 5 +
> hw/virtio/meson.build |
Patchew URL:
https://patchew.org/QEMU/20210329145947.14280-1-alex.ben...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210329145947.14280-1-alex.ben...@linaro.org
Subject: [RFC PATCH] docs: rst-ify the r
When we allocate 'q_namespace', we forgot to set 'has_q_namespace'
to true. This can cause several issues, including a memory leak,
since qapi_free_BlockdevCreateOptions() does not deallocate that
memory, as reported by valgrind:
13 bytes in 1 blocks are definitely lost in loss record 7 of 96
This series fixes two memory leaks, found through valgrind, in the
rbd driver.
Stefano Garzarella (2):
block/rbd: fix memory leak in qemu_rbd_connect()
block/rbd: fix memory leak in qemu_rbd_co_create_opts()
block/rbd.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
--
2.
In qemu_rbd_connect(), 'mon_host' is allocated by qemu_rbd_mon_host()
using g_strjoinv(), but it's only freed in the error path, leaking
memory in the success path as reported by valgrind:
80 bytes in 4 blocks are definitely lost in loss record 5,028 of 6,516
at 0x4839809: malloc (vg_replac
No changes to the text, just plain rst-ification of the original
source text. Notably:
- fixed up indentation of bullet points
- proper :: escapes for code samples
- added titles to paper links
- moved events into a table
Signed-off-by: Alex Bennée
---
docs/devel/index.rst
* Vitaly Kuznetsov (vkuzn...@redhat.com) wrote:
> "Dr. David Alan Gilbert" writes:
>
> > * Vitaly Kuznetsov (vkuzn...@redhat.com) wrote:
> >> KVM doesn't fully support Hyper-V reenlightenment notifications on
> >> migration. In particular, it doesn't support emulating TSC frequency
> >> of the so
* Igor Mammedov (imamm...@redhat.com) wrote:
> On Tue, 23 Mar 2021 17:40:36 +
> Daniel P. Berrangé wrote:
>
> > On Tue, Mar 23, 2021 at 05:54:47PM +0100, Igor Mammedov wrote:
> > > Let me hijack this thread for beyond this case scope.
> > >
> > > I agree that for this particular bug we've do
On Thu, 25 Mar 2021 09:55:09 -0400
Matthew Rosato wrote:
> S390 PCI currently has no backup, add one. Add an additional backup
> for vfio-ccw and refresh the backup for vfio-ap.
>
> Signed-off-by: Matthew Rosato
> ---
> MAINTAINERS | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
On Mon, Mar 29, 2021 at 8:03 AM Alex Bennée wrote:
>
> Currently our gitlab registry is x86_64 only so attempting to pull an
> image from it on something else will end in tears.
>
> Signed-off-by: Alex Bennée
> ---
> tests/docker/Makefile.include | 5 -
> 1 file changed, 4 insertions(+), 1 d
Hi
On Mon, Mar 29, 2021 at 5:54 PM Peter Maydell
wrote:
> On Sun, 28 Mar 2021 at 19:45, wrote:
> >
> > From: Marc-André Lureau
> >
> > The following changes since commit
> 7b9a3c9f94bcac23c534bc9f42a9e914b433b299:
> >
> > Merge remote-tracking branch
> 'remotes/kraxel/tags/fixes-20210326-pul
On Fri, Mar 19, 2021 at 12:27:10PM -0300, Wainer dos Santos Moschetta wrote:
> Hi,
>
> On 3/19/21 8:34 AM, Philippe Mathieu-Daudé wrote:
> > On 3/19/21 11:59 AM, Paolo Bonzini wrote:
> > > On 19/03/21 11:18, Andrew Jones wrote:
> > > > > Yikes, that is 41 hours per CI run. I wonder if GitLab's CI
On 3/29/21 1:02 AM, Claudio Fontana wrote:
On 3/28/21 7:21 PM, Richard Henderson wrote:
On 3/26/21 1:36 PM, Claudio Fontana wrote:
test is TCG-only.
Signed-off-by: Claudio Fontana
Cc: Philippe Mathieu-Daudé
---
tests/qtest/bios-tables-test.c | 7 +++
1 file changed, 7 insertions(+)
On Sun, 28 Mar 2021 at 19:45, wrote:
>
> From: Marc-André Lureau
>
> The following changes since commit 7b9a3c9f94bcac23c534bc9f42a9e914b433b299:
>
> Merge remote-tracking branch
> 'remotes/kraxel/tags/fixes-20210326-pull-request' into staging (2021-03-26
> 12:58:58 +)
>
> are available i
ping!
On 25.03.2021 18:12, Denis Plotnikov wrote:
v3:
* 0003: a new patch added fixing the problem on vm shutdown
I stumbled on this bug after v2 sending.
* 0001: gramma fixing (Raphael)
* 0002: commit message fixing (Raphael)
v2:
* split the initial patch into two (Raphael)
Hi David,
@@ -241,6 +241,31 @@ static void spapr_dt_pa_features(SpaprMachineState *spapr,
/* 60: NM atomic, 62: RNG */
0x80, 0x00, 0x80, 0x00, 0x00, 0x00, /* 60 - 65 */
};
+uint8_t pa_features_310[] = { 66, 0,
+/* 0: MMU|FPU|SLB|RUN|DABR|NX, 1: fri[nzpm]|DAB
29.03.2021 15:56, Max Reitz wrote:
On 17.03.21 17:02, Vladimir Sementsov-Ogievskiy wrote:
Just demonstrate one of x-blockdev-reopen usecases. We can't simply
remove persistent bitmap from RO node (for example from backing file),
as we need to remove it from the image too. So, we should reopen th
Hi,
When reviewing Vladimir’s new addition to tests/, I noticed that 297 so
far does not cover named tests. That isn’t so good.
This series makes it cover them, and because tests/ is rather sparse at
this point, I decided to also fix up the two tests in there that don’t
pass pylint’s scrutiny ye
169 and 199 have been renamed and moved to tests/ (commit a44be0334be:
"iotests: rename and move 169 and 199 tests"), so we can drop them from
the skip list.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/297 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests
1 - 100 of 164 matches
Mail list logo
