From: Klaus Jensen
Fix two issues reported by coverity (CID 1451080 and 1451082).
Klaus Jensen (2):
hw/block/nvme: fix resource leak in nvme_dif_rw
hw/block/nvme: fix resource leak in nvme_format_ns
hw/block/nvme-dif.c | 2 +-
hw/block/nvme.c | 5 +
2 files changed, 6 insertions(+)
On Mar 18 23:03, Peter Maydell wrote:
> On Thu, 18 Mar 2021 at 11:58, Klaus Jensen wrote:
> >
> > From: Klaus Jensen
> >
> > Hi Peter,
> >
> > The following changes since commit b12498fc575f2ad30f09fe78badc7fef526e2d76:
> >
> > Merge remote-tracking branch
> > 'remotes/vivier/tags/q800-for-6.0
From: Klaus Jensen
In nvme_format_ns(), if the namespace is of zero size (which might be
useless, but not invalid), the `count` variable will leak. Fix this by
returning early in that case.
Reported-by: Coverity (CID 1451082)
Fixes: dc04d25e2f3f ("hw/block/nvme: add support for the format nvm co
From: Klaus Jensen
If nvme_map_dptr() fails, nvme_dif_rw() will leak the bounce context.
Fix this by using the same error handling as everywhere else in the
function.
Reported-by: Coverity (CID 1451080)
Fixes: 146f720c5563 ("hw/block/nvme: end-to-end data protection")
Signed-off-by: Klaus Jensen
On Thu, Feb 25, 2021 at 02:23:35PM +1100, Alexey Kardashevskiy wrote:
> There is no H_REGISTER_PROCESS_TABLE, it is H_REGISTER_PROC_TBL handler
> for which is still called h_register_process_table() though.
>
> Signed-off-by: Alexey Kardashevskiy
Applied to ppc-for-6.0.
In future, best to CC me
Hi David,
On Mon, Mar 22, 2021 at 1:24 PM David Gibson
wrote:
>
> On Mon, Mar 22, 2021 at 12:33:06PM +0800, Bin Meng wrote:
> > Hi David,
> >
> > On Mon, Mar 22, 2021 at 12:11 PM David Gibson
> > wrote:
> > >
> > > On Tue, Mar 16, 2021 at 04:15:05PM +0800, Bin Meng wrote:
> > > > As the comment
On Mon, Mar 22, 2021 at 12:33:06PM +0800, Bin Meng wrote:
> Hi David,
>
> On Mon, Mar 22, 2021 at 12:11 PM David Gibson
> wrote:
> >
> > On Tue, Mar 16, 2021 at 04:15:05PM +0800, Bin Meng wrote:
> > > As the comment of tx_padding_and_crc() says: "Never add CRC in QEMU",
> > > min_frame_len should
On 22/03/2021 00.31, Lukas Straub wrote:
Use the normal yank code instead of stubs in relevant tests to
increase coverage and to ensure that registering and unregistering
of yank instances and functions is done correctly.
Signed-off-by: Lukas Straub
---
tests/qtest/meson.build | 6 +++---
te
On Sat, Mar 13, 2021 at 08:23:31AM +0100, Greg Kurz wrote:
> spapr_memory_unplug() is the last step of the hot unplug sequence.
> It is indirectly called by:
>
> spapr_lmb_release()
> hotplug_handler_unplug()
>
> and spapr_lmb_release() already buys us that DIMM unplug state is
> present : it
On Mon, Mar 15, 2021 at 12:46:12PM -0600, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
Applied to ppc-for-6.0, thanks.
> ---
> hw/ppc/pnv_core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/ppc/pnv_core.c b/hw/ppc/pnv_core.c
> index bd2bf2e044..8
On Mon, Mar 15, 2021 at 12:46:10PM -0600, Richard Henderson wrote:
> Nothing within the translator -- or anywhere else for that
> matter -- checks MSR_SA or MSR_AP on the 602. This may be
> a mistake. However, for the moment, we need not record these
> bits in hflags.
>
> This allows us to simpl
On Mon, Mar 15, 2021 at 12:46:09PM -0600, Richard Henderson wrote:
> Because this bit was not in hflags, the privilege check
> for tlb instructions was essentially random.
> Recompute hflags when storing to LPCR.
>
> Signed-off-by: Richard Henderson
Ouch. Unlike the others which come from ancie
On Mon, Mar 15, 2021 at 12:46:11PM -0600, Richard Henderson wrote:
> We weren't recording MSR_GS in hflags, which means that BookE
> memory accesses were essentially random vs Guest State.
>
> Instead of adding this bit directly, record the completed mmu
> indexes instead. This makes it obvious t
On Mon, Mar 15, 2021 at 12:46:13PM -0600, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
Applied to ppc-for-6.0, thanks.
> ---
> hw/ppc/spapr_rtas.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c
> index 8a79f9c628..6ec3e71757
On 19/03/2021 15.39, Paolo Bonzini wrote:
The following changes since commit cf6b56d4f2107259f52413f979a1d474dad0c1e1:
Merge remote-tracking branch 'remotes/philmd/tags/pflash-20210318' into
staging (2021-03-18 23:04:41 +)
are available in the Git repository at:
https://gitlab.com/b
Hi David,
On Mon, Mar 22, 2021 at 12:11 PM David Gibson
wrote:
>
> On Tue, Mar 16, 2021 at 04:15:05PM +0800, Bin Meng wrote:
> > As the comment of tx_padding_and_crc() says: "Never add CRC in QEMU",
> > min_frame_len should excluce CRC, so it should be 60 instead of 64.
>
> Sorry, your reasoning
On Mon, Mar 15, 2021 at 12:46:08PM -0600, Richard Henderson wrote:
> Perform the test against FSCR_SCV at runtime, in the helper.
>
> This means we can remove the incorrect set against SCV in
> ppc_tr_init_disas_context and do not need to add an HFLAGS bit.
>
> Signed-off-by: Richard Henderson
>
On Mon, Mar 15, 2021 at 12:46:03PM -0600, Richard Henderson wrote:
> We have eliminated all normal uses of hflags_nmsr. We need
> not even compute it except when we want to migrate. Rename
> the field to emphasize this.
>
> Remove the fixme comment for migrating access_type. This value
> is onl
On Fri, Mar 12, 2021 at 03:38:21PM -0500, Peter Xu wrote:
> On Fri, Mar 12, 2021 at 07:28:49PM +0100, Philippe Mathieu-Daudé wrote:
> > The pci_io_non_contiguous region is mapped on top of pci_io
> > with higher priority, but simply dispatch into this region
> > address space. Simplify by directly
On Mon, Mar 15, 2021 at 12:46:07PM -0600, Richard Henderson wrote:
> Because these bits were not in hflags, the code generated
> for single-stepping on BookE was essentially random.
> Recompute hflags when storing to dbcr0.
>
> Signed-off-by: Richard Henderson
Reviewed-by: David Gibson
> ---
>
On Mon, Mar 15, 2021 at 12:46:01PM -0600, Richard Henderson wrote:
> Match cpu_post_load in using ppc_store_msr to set all of
> the cpu state implied by the value of msr. Do not restore
> hflags or hflags_nmsr, as we recompute them in ppc_store_msr.
>
> Signed-off-by: Richard Henderson
Applied
On Fri, Mar 12, 2021 at 07:28:50PM +0100, Philippe Mathieu-Daudé wrote:
> The raven bus-master memory region is exposed as an AddressSpace.
> AddressSpaces root MemoryRegion must not be mapped into other
> MemoryRegion, therefore map the region using its alias.
>
> Signed-off-by: Philippe Mathieu-
On Mon, Mar 15, 2021 at 12:46:04PM -0600, Richard Henderson wrote:
> As per hreg_compute_hflags:
>
> We 'forget' FE0 & FE1: we'll never generate imprecise exceptions
>
> remove the hflags marker from the respective comments.
>
> Signed-off-by: Richard Henderson
Applied to ppc-for-6.0, thanks
On Tue, Mar 16, 2021 at 04:15:05PM +0800, Bin Meng wrote:
> As the comment of tx_padding_and_crc() says: "Never add CRC in QEMU",
> min_frame_len should excluce CRC, so it should be 60 instead of 64.
Sorry, your reasoning still isn't clear to me. If qemu is not adding
the CRC, what is? Will it a
On Mon, Mar 15, 2021 at 12:46:06PM -0600, Richard Henderson wrote:
> It will be stored in tb->flags, which is also uint32_t,
> so let's use the correct size.
>
> Signed-off-by: Richard Henderson
Reviewed-by: David Gibson
> ---
> target/ppc/cpu.h | 4 ++--
> target/ppc/misc_helper.c |
On Mon, Mar 15, 2021 at 12:46:00PM -0600, Richard Henderson wrote:
> Keep all hflags computation in one place, as this will be
> especially important later.
>
> Introduce a new POWERPC_FLAG_HID0_LE bit to indicate when
> LE should be taken from HID0. This appears to be set if
> and only if POWERP
On Mon, Mar 15, 2021 at 12:45:59PM -0600, Richard Henderson wrote:
> Move the functions to a new file, helper_regs.c.
>
> Note int_helper.c was relying on helper_regs.h to
> indirectly include qemu/log.h.
>
> Signed-off-by: Richard Henderson
Applied to ppc-for-6.0, thanks.
> ---
> target/ppc/
On Mon, Mar 15, 2021 at 12:46:05PM -0600, Richard Henderson wrote:
> Copying flags directly from msr has drawbacks: (1) msr bits
> mean different things per cpu, (2) msr has 64 bits on 64 cpus
> while tb->flags has only 32 bits.
>
> Create a enum to define these bits. Document the origin of each
On Mon, Mar 15, 2021 at 12:46:02PM -0600, Richard Henderson wrote:
> In ppc_store_msr we call hreg_compute_hflags, which itself
> calls hreg_compute_mem_idx. Rely on ppc_store_msr to update
> everything required by the msr update.
>
> Signed-off-by: Richard Henderson
Applied to ppc-for-6.0.
>
On Mon, Mar 22, 2021 at 09:29:12AM +0800, Bin Meng wrote:
> On Tue, Mar 16, 2021 at 4:15 PM Bin Meng wrote:
> >
> > As the comment of tx_padding_and_crc() says: "Never add CRC in QEMU",
> > min_frame_len should excluce CRC, so it should be 60 instead of 64.
> >
> > Signed-off-by: Bin Meng
> > ---
On 3/19/2021 8:37 PM, Marcelo Tosatti wrote:
On Fri, Mar 19, 2021 at 10:59:20AM +0800, Chenyi Qiang wrote:
Hi Marcelo,
Thank you for your comment.
On 3/19/2021 1:32 AM, Marcelo Tosatti wrote:
On Wed, Mar 17, 2021 at 04:47:09PM +0800, Chenyi Qiang wrote:
Virtual Machines can exploit bus lo
On Fri, Mar 19, 2021 at 9:29 PM Alistair Francis
wrote:
> On Tue, Mar 9, 2021 at 2:30 AM wrote:
> >
> > From: Frank Chang
> >
> > Signed-off-by: Frank Chang
>
> I had a quick look and this looks fine. I haven't compared it to the
> spec yet though.
>
> When you send the patch series do you min
On Fri, Mar 19, 2021 at 9:30 PM Alistair Francis
wrote:
> On Tue, Mar 9, 2021 at 2:31 AM wrote:
> >
> > From: Frank Chang
> >
> > This patchset add suport of Resumable NMI (RNMI) in RISC-V.
> >
> > There are four new CSRs and one new instruction added to allow NMI to be
> > resumable in RISC-V,
On Wed, Mar 17, 2021 at 06:57:07PM +0100, Greg Kurz wrote:
> Each vCPU core exposes its timebase frequency in the DT. When running
> under KVM, this means parsing /proc/cpuinfo in order to get the timebase
> frequency of the host CPU.
>
> The parsing appears to slow down the boot quite a bit with
On Tue, Mar 16, 2021 at 9:39 AM Bin Meng wrote:
>
> On Thu, Mar 11, 2021 at 4:18 PM Bin Meng wrote:
> >
> > On Sat, Mar 6, 2021 at 2:01 PM Bin Meng wrote:
> > >
> > > From: Bin Meng
> > >
> > > Per SST25VF016B datasheet [1], SST flash requires a dummy byte after
> > > the address bytes. Note on
On Tue, Mar 16, 2021 at 4:15 PM Bin Meng wrote:
>
> As the comment of tx_padding_and_crc() says: "Never add CRC in QEMU",
> min_frame_len should excluce CRC, so it should be 60 instead of 64.
>
> Signed-off-by: Bin Meng
> ---
>
> hw/net/fsl_etsec/rings.c | 2 +-
> 1 file changed, 1 insertion(+),
On Wed, Mar 17, 2021 at 2:26 PM Bin Meng wrote:
>
> The minimum Ethernet frame length is 60 bytes. For short frames with
> smaller length like ARP packets (only 42 bytes), on a real world NIC
> it can choose either padding its length to the minimum required 60
> bytes, or sending it out directly t
Move object_property_try_add_child out of chardev_new into it's
callers. This is a preparation for the next patches to fix yank
with the chardev-change case.
Signed-off-by: Lukas Straub
---
chardev/char.c | 42 --
1 file changed, 24 insertions(+), 18 delet
Always pass the id to chardev_new, since it is needed to register
the yank instance for the chardev. Also, after checking that
nothing calls chardev_new with id=NULL, assert() that id!=NULL.
This fixes a crash when using chardev-change to change a chardev
to chardev-socket, which attempts to regis
Use the normal yank code instead of stubs in relevant tests to
increase coverage and to ensure that registering and unregistering
of yank instances and functions is done correctly.
Signed-off-by: Lukas Straub
---
tests/qtest/meson.build | 6 +++---
tests/unit/meson.build | 4 ++--
2 files chang
When changing from chardev-socket (which supports yank) to
chardev-socket again, it fails, because the new chardev attempts
to register a new yank instance. This in turn fails, as there
still is the yank instance from the current chardev. Also,
the old chardev shouldn't unregister the yank instance
Add tests for yank with the chardev-change case.
Signed-off-by: Lukas Straub
---
MAINTAINERS| 1 +
tests/unit/meson.build | 3 +-
tests/unit/test-yank.c | 240 +
3 files changed, 243 insertions(+), 1 deletion(-)
create mode 100644 tests/un
Hello Everyone,
These patches increase test coverage for yank, add tests and fix bugs and
crashes in yank in combination with chardev-change.
Regards,
Lukas Straub
Based-on: <20210316135907.3646901-1-arm...@redhat.com>
([PATCH] yank: Avoid linking into executables that don't want it)
Alternative
In bbc17caf81f, we used an alias attribute to allow target_page
to be declared const, and yet be initialized late.
This fails when using LTO with several versions of gcc.
The compiler looks through the alias and decides that the const
variable is statically initialized to zero, then propagates tha
On 3/21/21 11:46 AM, Paolo Bonzini wrote:
HRM, what about biting the bullet and making exec-vary.c a C++ source?... Then
instead of making it conditional an attribute((alias)), we make it conditional
on having a C++ compiler.
Doesn't help. The gcc bug I filed talks about c++, because that's t
HRM, what about biting the bullet and making exec-vary.c a C++ source?...
Then instead of making it conditional an attribute((alias)), we make it
conditional on having a C++ compiler.
Making cpu-all.h compile as C++ would be complex, but we can isolate all
the required declarations in a separate h
Il dom 21 mar 2021, 18:34 Richard Henderson
ha scritto:
> On 3/21/21 10:50 AM, Paolo Bonzini wrote:
> > Another workaround may be to avoid compiling exec-vary.c with
> -flto. I'm not
> > sure that my meson fu is up to that. Paolo?
> >
> > You would have to define a static library.
>
> O
On 3/21/21 10:50 AM, Paolo Bonzini wrote:
Another workaround may be to avoid compiling exec-vary.c with -flto. I'm
not
sure that my meson fu is up to that. Paolo?
You would have to define a static library.
Ok. With an extra -fno-lto flag, or can I somehow remove -flto from the
lib
From: Warner Losh
FreeBSD 12.1 has reached end of life. Use 12.2 instead so that FreeBSD's
project's packages will work. Update which timezone to pick. Work around a QEMU
bug that incorrectly raises an exception on a CRC32 instruction with the FPU
disabled. The qemu bug is described here:
https
From: David CARLIER
local directive make the configure fails on these systems.
Signed-off-by: David Carlier
Message-Id:
Signed-off-by: Thomas Huth
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 847bc4d095..61872096a8 100755
--- a
From: Wainer dos Santos Moschetta
With the recent move of the unit tests to tests/unit directory some
instructions under the "Unit tests" section became imprecise, which
are fixed by this change.
Fixes: da668aa15b99 ("tests: Move unit tests into a separate directory")
Signed-off-by: Wainer dos S
From: Emanuele Giuseppe Esposito
When building qemu with GCC 11, test-block-iothread produces the following
warning:
../tests/unit/test-block-iothread.c:148:11: error: ‘buf’ may be used
uninitialized [-Werror=maybe-uninitialized]
This is caused by buf[512] left uninitialized and passed to
bdrv_
Hi Peter!
The following changes since commit 2e1293cbaac75e84f541f9acfa8e26749f4c3562:
Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2021-03-16-v4'
into staging (2021-03-19 16:40:00 +)
are available in the Git repository at:
https://gitlab.com/thuth/qemu.git tags/pull-re
From: David CARLIER
sun is a macro on these systems, thus renaming the variables on the
client and server.
Signed-off-by: David Carlier
Message-Id:
Reviewed-by: Peter Maydell
Signed-off-by: Thomas Huth
---
contrib/ivshmem-client/ivshmem-client.c | 12 ++--
contrib/ivshmem-server/ivs
Il dom 21 mar 2021, 16:49 Richard Henderson
ha scritto:
> What exact version of gcc are you guys using? Something from rawhide that
> I can just install?
>
I am using Fedora 34. I upgraded just to test this bug and it seems stable
except that GNOME Shell extensions need an upgrade. However I ha
On 28.01.21 17:40, Peter Maydell wrote:
On Wed, 20 Jan 2021 at 22:44, Alexander Graf wrote:
We currently only support GICv2 emulation. To also support GICv3, we will
need to pass a few system registers into their respective handler functions.
This patch adds handling for all of the required
On 10.02.21 23:17, Peter Maydell wrote:
On Wed, 10 Feb 2021 at 20:25, Peter Collingbourne wrote:
On Thu, Jan 28, 2021 at 8:25 AM Peter Maydell wrote:
On Wed, 20 Jan 2021 at 22:44, Alexander Graf wrote:
+if (!seconds && nanos < 200) {
+break;
+
On 3/20/21 4:33 PM, Richard Henderson wrote:
On 3/20/21 11:52 AM, Paolo Bonzini wrote:
+int main(void)
+{
+ return read_y();
+}
I think this should be "read_y() == 1 ? 0 : 1".
As a testcase returning 0 on success, yes.
I can reproduce it with -flto -O2 but not without -flto, do you agre
Public bug reported:
It compiles until the end and then just:
[6102/6103] Linking target qemu-system-alpha
[6103/6103] Linking target qemu-system-aarch64
make[1]: Leaving directory '/home/t/.cache/kiss/proc/32129/build/qemu/build'
make: *** [GNUmakefile:11: all] Error 2
Attached is the complete l
On 21/03/21 01:17, Gavin Shan wrote:
It's still possible that the wrong value is returned from the alias
of variable even if the program can be compiled without issue. This
improves the check by executing the binary to check the result.
If alias attribute can't be working properly, the @target_p
On Sat, 20 Mar 2021 at 22:38, Adam Lackorzynski wrote:
>
> Hi,
>
> I'm seeing a regression in Arm's vfp handling, giving an undefined
> instruction when reading mvfr1 in PL2/armv7 although the FPU is enabled.
> The following makes it work again for me, however this just looks like a
> band-aid. Th
On Fri 19 Mar 2021 12:22:18 PM CET, Emanuele Giuseppe Esposito
wrote:
> When building qemu with GCC 11, test-block-iothread produces the following
> warning:
>
> ../tests/unit/test-block-iothread.c:148:11: error: ‘buf’ may be used
> uninitialized [-Werror=maybe-uninitialized]
>
> This is caused b
62 matches
Mail list logo
