Re: [PATCH v22 06/17] meson: add target_user_arch

On 2/24/21 11:35 PM, Eric Blake wrote: > On 2/24/21 3:21 PM, Philippe Mathieu-Daudé wrote: >> On 2/24/21 2:34 PM, Claudio Fontana wrote: >>> the lack of target_user_arch makes it hard to fully leverage the >>> build system in order to separate user code from sysemu code. >>> >>> Provide it, so that

Re: [Rust-VMM] vhost reply_ack negotiation (a.k.a differences in vhost-user behaviour with libvhost-user and vhost-user-backend.rs)

On Thu, Feb 25, 2021 at 1:20 PM Dylan Reid wrote: > On Tue, Feb 23, 2021 at 8:20 AM Michael S. Tsirkin wrote: > > > > Cc: Raphael > > > > On Fri, Feb 19, 2021 at 04:04:34PM +, Alex Bennée wrote: > > > Hi, > > > > > > I finally got a chance to get down into the guts of vhost-user while > > >

Re: [PATCH] arm: xlnx-versal: fix virtio-mmio base address assignment

On Mon, 2021-02-08 at 12:59 +, Peter Maydell wrote: > I just suggested something on another thread: call > memory_region_find() > and then look at the offset_within_address_space field of the > returned > MemoryRegionSection. I think that should get you the offset of the > transport within the

[PATCH] qtest: delete redundant qtest.h header files

There are 23 files that include the "sysemu/qtest.h", but they do not use any qtest functions. Signed-off-by: Chen Qun --- accel/tcg/cpu-exec.c| 1 - blockdev.c | 1 - hw/9pfs/9p.c| 1 - hw/arm/armv7m.c | 1 - hw/arm/mainstone.

[PATCH v4] virtio-mmio: improve virtio-mmio get_dev_path alog

At the moment the following QEMU command line triggers an assertion failure On xlnx-versal SOC: qemu-system-aarch64 \ -machine xlnx-versal-virt -nographic -smp 2 -m 128 \ -fsdev local,id=shareid,path=${HOME}/work,security_model=none \ -device virtio-9p-device,fsdev=shareid,mount

Re: [PATCH 04/14] softmmu: remove '-usbdevice' command line option

On 24/02/2021 15.10, Daniel P. Berrangé wrote: On Wed, Feb 24, 2021 at 02:58:19PM +0100, Thomas Huth wrote: On 24/02/2021 14.11, Daniel P. Berrangé wrote: This was replaced by the '-device usb-DEV' option. Signed-off-by: Daniel P. Berrangé --- docs/system/deprecated.rst | 9 ---

Re: [PATCH v2 1/2] tests/acceptance: replace unstable apt.armbian.com URLs for orangepi-pc, cubieboard

On 25/02/2021 00.10, Philippe Mathieu-Daudé wrote: +Thomas/Daniel/Alex/Peter/Paolo/Stefan/Markus On 2/24/21 9:02 PM, Niek Linnenbank wrote: Hi Philippe, Cleber, [...] Indeed. Just this morning I received an e-mail from github with the following text: "[GitHub] Git LFS disabled for nieklinnen

Re: [PATCH] qemu_fw_cfg: Make fw_cfg_rev_attr a proper kobj_attribute

On Thu, Feb 11, 2021 at 12:42:58PM -0700, Nathan Chancellor wrote: > fw_cfg_showrev() is called by an indirect call in kobj_attr_show(), > which violates clang's CFI checking because fw_cfg_showrev()'s second > parameter is 'struct attribute', whereas the ->show() member of 'struct > kobj_structure

QEMU CI failed due to canceled download

Hi, I just faced this failure in the CI: https://gitlab.com/thuth/qemu/-/jobs/1053467007#L73 I thought we'd handle CANCEL as "skipped"? Why did this cause the CI to fail? For reference, here's the debug.log: 19:33:28 DEBUG| PARAMS (key=arch, path=*, default=aarch64) => 'aarch64' 19:33:28 D

Re: [PATCH v22 17/17] i386: move cpu_load_efer into sysemu-only section of cpu.h

On 2/24/21 5:34 AM, Claudio Fontana wrote: > cpu_load_efer is now used only for sysemu code. > > Therefore, make this inline function not visible anymore > in CONFIG_USER_ONLY builds. > > Signed-off-by: Claudio Fontana > --- > target/i386/cpu.h | 31 --- > 1 file cha

Re: [Rust-VMM] vhost reply_ack negotiation (a.k.a differences in vhost-user behaviour with libvhost-user and vhost-user-backend.rs)

On Tue, Feb 23, 2021 at 8:20 AM Michael S. Tsirkin wrote: > > Cc: Raphael > > On Fri, Feb 19, 2021 at 04:04:34PM +, Alex Bennée wrote: > > Hi, > > > > I finally got a chance to get down into the guts of vhost-user while > > attempting to port my original C RPMB daemon to Rust using the > > vho

Re: [PATCH v22 16/17] i386: gdbstub: only write CR0/CR2/CR3/EFER for SOFTMMU

On 2/24/21 5:34 AM, Claudio Fontana wrote: > Signed-off-by: Claudio Fontana > Cc: Paolo Bonzini > --- > target/i386/gdbstub.c | 16 > 1 file changed, 16 insertions(+) > > diff --git a/target/i386/gdbstub.c b/target/i386/gdbstub.c > index 41e265fc67..9f505d6ee3 100644 > --- a/ta

Re: [PATCH v22 15/17] i386: split off sysemu part of cpu.c

On 2/24/21 5:34 AM, Claudio Fontana wrote: > Signed-off-by: Claudio Fontana > --- > target/i386/cpu-internal.h | 70 +++ > target/i386/cpu-softmmu.c | 352 ++ > target/i386/cpu.c | 383 + > target/i386/meson.build

Re: [PATCH v22 14/17] i386: split seg_helper into user-only and sysemu parts

On 2/24/21 5:34 AM, Claudio Fontana wrote: > Signed-off-by: Claudio Fontana > --- > target/i386/tcg/helper-tcg.h| 5 + > target/i386/tcg/seg_helper.h| 66 > target/i386/tcg/seg_helper.c| 233 +--- > target/i386/tcg/sysemu/seg_helper.c |

Re: [PATCH v22 13/17] i386: split svm_helper into sysemu and stub-only user

On 2/24/21 5:34 AM, Claudio Fontana wrote: > For now we just copy over the previous user stubs, but really, > > everything that requires s->cpl == 0 should be impossible > to trigger from user-mode emulation. > > Later on we should add a check that asserts this easily f.e.: > > static bool check

Re: [PATCH v22 12/17] i386: separate fpu_helper into user and sysemu parts

On 2/24/21 5:34 AM, Claudio Fontana wrote: > #if !defined(CONFIG_USER_ONLY) > -else if (ferr_irq && !(env->hflags2 & HF2_IGNNE_MASK)) { > -qemu_irq_raise(ferr_irq); > +else { > +(void)fpu_check_raise_ferr_irq(env); Given this is the only use, why split out the function at

[PATCH qemu] spapr: Fix typo in the patb_entry comment

There is no H_REGISTER_PROCESS_TABLE, it is H_REGISTER_PROC_TBL handler for which is still called h_register_process_table() though. Signed-off-by: Alexey Kardashevskiy --- include/hw/ppc/spapr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/ppc/spapr.h b/include

Re: [PATCH v22 11/17] i386: split misc helper into user and sysemu parts

On 2/24/21 5:34 AM, Claudio Fontana wrote: > +void helper_outb(CPUX86State *env, uint32_t port, uint32_t data) > +{ > +fprintf(stderr, "outb: port=0x%04x, data=%02x\n", port, data); > +} > + > +target_ulong helper_inb(CPUX86State *env, uint32_t port) > +{ > +fprintf(stderr, "inb: port=0x%04

Re: [PATCH] block/file-posix: Optimize for macOS

2021年2月25日(木) 2:31 Kevin Wolf : > > Am 24.02.2021 um 17:27 hat Stefan Hajnoczi geschrieben: > > On Fri, Feb 19, 2021 at 05:51:48PM +0900, Akihiko Odaki wrote: > > > This commit introduces "punch hole" operation and optimizes transfer > > > block size for macOS. > > > > > > This commit introduces tw

Re: [PATCH] virtio-gpu: Respect graphics update interval for EDID

2021年2月24日(水) 20:17 Gerd Hoffmann : > > On Tue, Feb 23, 2021 at 01:50:51PM +0900, Akihiko Odaki wrote: > > 2021年2月22日(月) 19:57 Gerd Hoffmann : > > > > > > On Sun, Feb 21, 2021 at 10:34:14PM +0900, Akihiko Odaki wrote: > > > > This change introduces an additional member, refresh_rate to > > > > qemu

Re: [PATCH v22 10/17] i386: move TCG btp_helper into sysemu/

On 2/24/21 5:34 AM, Claudio Fontana wrote: > @@ -8074,7 +8078,9 @@ static target_ulong disas_insn(DisasContext *s, > CPUState *cpu) > gen_svm_check_intercept(s, pc_start, SVM_EXIT_WRITE_DR0 + > reg); > gen_op_mov_v_reg(s, ot, s->T0, rm); > tcg_ge

[PATCH v3 3/3] virtio-gpu: Do not distinguish the primary console

In the past, virtio-gpu set NULL as the surface for the secondary consoles to hide its window. The distinction is now handled in ui/console and the display backends and virtio-gpu does no longer have to do that. Signed-off-by: Akihiko Odaki --- hw/display/vhost-user-gpu.c | 2 +- hw/display/vi

[PATCH v3 1/3] ui/console: Add placeholder flag to message surface

The surfaces created with former qemu_create_message_surface did not display the content from the guest and always contained simple messages describing the reason. A display backend may want to hide the window showing such a surface. This change renames the function to qemu_create_placeholder_surf

[PATCH v3 2/3] ui/console: Pass placeholder surface to displays

ui/console used to accept NULL as graphic console surface, but its semantics was inconsistent among displays: - cocoa and gtk-egl perform NULL dereference. - egl-headless, spice and spice-egl do nothing. - gtk releases underlying resources. - sdl2-2d and sdl2-gl destroys the window. - vnc shows a m

Re: [PATCH v22 09/17] i386: split tcg excp_helper into sysemu and user parts

On 2/24/21 5:34 AM, Claudio Fontana wrote: > Signed-off-by: Claudio Fontana > --- > target/i386/tcg/excp_helper.c| 572 -- > target/i386/tcg/sysemu/excp_helper.c | 581 +++ > target/i386/tcg/user/excp_helper.c | 39 ++ > target/i386/tcg/s

Re: [PATCH v22 08/17] i386: split smm helper (sysemu)

On 2/24/21 5:34 AM, Claudio Fontana wrote: > smm is only really useful for sysemu, split in two modules > around the CONFIG_USER_ONLY, in order to remove the ifdef > and use the build system instead. > > add cpu_abort() when detecting attempts to enter SMM mode via > SMI interrupt in user-mode, an

Re: [PATCH v22 07/17] i386: split off sysemu-only functionality in tcg-cpu

On 2/24/21 5:34 AM, Claudio Fontana wrote: > Signed-off-by: Claudio Fontana > --- > target/i386/tcg/tcg-cpu.h | 24 + > target/i386/tcg/sysemu/tcg-cpu.c | 83 ++ > target/i386/tcg/tcg-cpu.c | 75 ++- > target/i386/tcg

Re: [PATCH v22 03/17] accel: introduce new accessor functions

On 2/24/21 5:34 AM, Claudio Fontana wrote: > avoid open coding the accesses to cpu->accel_cpu interfaces, > and instead introduce: > > accel_cpu_instance_init, > accel_cpu_realizefn > > to be used by the targets/ initfn code, > and by cpu_exec_realizefn respectively. > > Signed-off-by: Claudio F

Re: [PATCH v22 02/17] cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn

On 2/24/21 5:34 AM, Claudio Fontana wrote: > move the call to accel_cpu->cpu_realizefn to the general > cpu_exec_realizefn from target/i386, so it does not need to be > called for every target explicitly as we enable more targets. > > Signed-off-by: Claudio Fontana > Reviewed-by: Alex Bennée > -

Re: [PATCH v22 01/17] i386: split cpu accelerators from cpu.c, using AccelCPUClass

On 2/24/21 5:34 AM, Claudio Fontana wrote: > i386 is the first user of AccelCPUClass, allowing to split > cpu.c into: > > cpu.ccpuid and common x86 cpu functionality > host-cpu.c host x86 cpu functions and "host" cpu type > kvm/kvm-cpu.cKVM x86 AccelCPUClass > hvf/hvf-cpu.c

[PATCH 1/1] accel/tcg: Replace parallel_cpus with cpu->cflags_base

Precompute the initial tb->cflags value for a cpu from its cluster and the number of cpus live in the system. This avoids having to compute this constant data every time we look up a TB. Signed-off-by: Richard Henderson --- Based-on: <20210224165811.11567-1-alex.ben...@linaro.org> ("Experimentin

Re: [RFC PATCH 0/5] Experimenting with tb-lookup tweaks

On 2/24/21 8:58 AM, Alex Bennée wrote: > Hi Richard, > > Well I spun up some of the ideas we talked about to see if there was > anything to be squeezed out of the function. In the end the results > seem to be a washout with my pigz benchmark: > > qemu-system-aarch64 -cpu cortex-a57 \ >-machi

[PATCH v4] virtio-blk: Respect discard granularity

Report the configured granularity for discard operation to the guest. If this is not set use the block size. Since until now we have ignored the configured discard granularity and always reported the block size, let's add 'report-discard-granularity' property and disable it for older machine types

[PATCH] hvf: Sign the code after installation

Before this change, the code signed during the build was installed directly. However, the signature gets invalidated because meson modifies the code to fix dynamic library install names during the install process. It also prevents meson to strip the code because the pre-signed file is not marked

Re: [PATCH v7 1/2] drivers/misc: sysgenid: add system generation id driver

On 24.02.21 23:41, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 02:45:03PM +0100, Alexander Graf wrote: Above should try harder to explan what are the things that need to be scrubbed and why. For example, I personally don't really know what is the OpenSSL session token example and what

Re: [PATCH v9 04/11] slirp: feature detection for smbd

I've noticed that my guests like Windows XP and Mac OS 10.4 cannot access the internet using the recent versions of QEMU on Mac OS 11. I'm on an M1 Mac. Does your patchset enable guests to be able to access the internet?

Re: [PATCH v2 1/2] tests/acceptance: replace unstable apt.armbian.com URLs for orangepi-pc, cubieboard

+Thomas/Daniel/Alex/Peter/Paolo/Stefan/Markus On 2/24/21 9:02 PM, Niek Linnenbank wrote: > Hi Philippe, Cleber, > > On Wed, Feb 24, 2021 at 8:14 PM Cleber Rosa > wrote: > > On Wed, Feb 24, 2021 at 10:12:10AM +0100, Philippe Mathieu-Daudé wrote: > > Hi Niek, >

[PATCH v2] target/arm: Speed up aarch64 TBL/TBX

Always perform one call instead of two for 16-byte operands. Use byte loads/stores directly into the vector register file instead of extractions and deposits to a 64-bit local variable. In order to easily receive pointers into the vector register file, convert the helper to the gvec out-of-line si

Re: [PATCH v7 1/2] drivers/misc: sysgenid: add system generation id driver

On 2/24/21, 2:44 PM, "Michael S. Tsirkin" wrote: > The mmap mechanism allows the PRNG to reseed after a genid change. Because > we don't have an event mechanism for this code path, that can happen minutes > after the resume. But that's ok, we "just" have to ensure that nobody is

Re: [PATCH v22 00/17] i386 cleanup PART 2

On 2/24/21 2:34 PM, Claudio Fontana wrote: > Claudio Fontana (17): > i386: split cpu accelerators from cpu.c, using AccelCPUClass > cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn > accel: introduce new accessor functions > target/i386: fix host_cpu_adjust_phys_bits error hand

Re: [PATCH 1/3] migration/ram: Modify the code comment of ram_save_host_page()

On Tuesday, 2021-02-23 at 10:16:43 +08, Kunkun Jiang wrote: > The ram_save_host_page() has been modified several times > since its birth. But the comment hasn't been modified as it should > be. It'd better to modify the comment to explain ram_save_host_page() > more clearly. > > Signed-off-by: Keq

Re: [PATCH v22 06/17] meson: add target_user_arch

On 2/24/21 11:35 PM, Eric Blake wrote: > On 2/24/21 3:21 PM, Philippe Mathieu-Daudé wrote: >> On 2/24/21 2:34 PM, Claudio Fontana wrote: >>> the lack of target_user_arch makes it hard to fully leverage the >>> build system in order to separate user code from sysemu code. >>> >>> Provide it, so that

[PATCH v5 3/4] qapi: Move X86 specific types to machine-target.json

X86CPURegister32 enum and X86CPUFeatureWordInfo structure are specific to the x86 architecture, move these entries to machine-target.json. Restricting the x86-specific commands to machine-target.json pulls less QAPI-generated code into non-x86 targets. Acked-by: Richard Henderson Signed-off-by:

[PATCH v5 1/4] target/i386/cpu: Introduce get_register_enum_32() helper

Introduce get_register_enum_32(), similar to get_register_name_32(). Signed-off-by: Philippe Mathieu-Daudé --- target/i386/cpu-internal.h | 4 target/i386/cpu.c | 7 ++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu-internal.h b/target/i386/cpu-

[PATCH v5 4/4] qapi/machine-target: Restrict X86 features to X86 targets

X86CPURegister32 enum and X86CPUFeatureWordInfo structure are specific to the x86 architecture, restrict them to the X86 targets. Signed-off-by: Philippe Mathieu-Daudé --- qapi/machine-target.json | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/qapi/machine-target.js

[PATCH v5 2/4] target/i386/cpu: Restrict x86_cpu_get_feature_words to sysemu

Only qemu-system-FOO and qemu-storage-daemon provide QMP monitors, therefore such declarations and definitions are irrelevant for user-mode emulation. Restricting the x86-specific commands to machine-target.json pulls less QAPI-generated code into user-mode. Signed-off-by: Philippe Mathieu-Daudé

[PATCH v5 0/4] qapi: Restrict X86 features to X86 targets

Since v4: - Rebase on Claudio's work to avoid stub This series restrict the 'feature-words' property to the x86 architecture (other archs don't have it), and to system-mode (user-mode doesn't use it). v4: https://www.mail-archive.com/qemu-devel@nongnu.org/msg746628.html Supersedes: <202010011441

[PATCH] target/arm: Speed up aarch64 TBL/TBX

Always perform one call instead of two for 16-byte operands. Use byte loads/stores directly into the vector register file instead of extractions and deposits to a 64-bit local variable. In order to easily receive pointers into the vector register file, convert the helper to the gvec out-of-line si

Re: [PATCH v7 1/2] drivers/misc: sysgenid: add system generation id driver

On Wed, Feb 24, 2021 at 02:45:03PM +0100, Alexander Graf wrote: > > Above should try harder to explan what are the things that need to be > > scrubbed and why. For example, I personally don't really know what is > > the OpenSSL session token example and what makes it vulnerable. I guess > > snapsho

[Bug 1916344] Re: User mode networking not working properly on QEMU on Mac OS X host

I'm on Mac OS 11.1 on an M1 Mac. I did some tests with QEMU 2.10.1 and 5.3 and here are the results: QEMU 2.10.1: - Ran Windows XP as a guest - qemu-system-i386 -m 700 -hda -netdev user,id=n0 -device rtl8139,netdev=n0 - Internet Explorer was able to load a web page. QEMU 5.3.x: - Tried to run W

Re: [PATCH v2] Autoconnect jack ports by default

While I get where you're coming from, those using QEMU with Jack are already advanced users that are used to reading technical documentation. Having our one client do something that is unexpected/different would not only confuse existing Jack users but also anyone following any guides/documenta

Re: [PATCH v22 06/17] meson: add target_user_arch

On 2/24/21 3:21 PM, Philippe Mathieu-Daudé wrote: > On 2/24/21 2:34 PM, Claudio Fontana wrote: >> the lack of target_user_arch makes it hard to fully leverage the >> build system in order to separate user code from sysemu code. >> >> Provide it, so that we can avoid the proliferation of #ifdef >> i

Re: [PATCH v2] Autoconnect jack ports by default

On Mittwoch, 24. Februar 2021 23:04:47 CET Geoffrey McRae wrote: > This goes against how all standard jack clients work, a new jack client > should not auto-connect at all unless explicitly configured to as if > there is an existing audio diagram configured (which is 99% of the time) > it will caus

Re: [PATCH v3 08/16] qapi/expr.py: add type hint annotations

On 2/24/21 10:27 AM, Markus Armbruster wrote: John Snow writes: Annotations do not change runtime behavior. This commit *only* adds annotations. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa --- scripts/qapi/expr.py | 71 -

Re: [PATCH v3 07/16] qapi/expr.py: Add casts in a few select cases

On 2/24/21 7:32 AM, Markus Armbruster wrote: John Snow writes: Casts are instructions to the type checker only, they aren't "safe" and should probably be avoided in general. In this case, when we perform type checking on a nested structure, the type of each field does not "stick". We don't ne

Re: [PATCH v3 06/16] qapi/expr.py: Check type of 'data' member

On 2/24/21 5:39 AM, Markus Armbruster wrote: John Snow writes: Iterating over the members of data isn't going to work if it's not some form of dict anyway, but for the sake of mypy, formalize it. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost --- scripts/qapi/expr.py | 7 +++

Re: [PATCH v2] Autoconnect jack ports by default

This goes against how all standard jack clients work, a new jack client should not auto-connect at all unless explicitly configured to as if there is an existing audio diagram configured (which is 99% of the time) it will cause unexpected/undesired behavior. Jack is not supposed to be an 'auto

Re: [PATCH v3 04/16] qapi/expr.py: Add assertion for union type 'check_dict'

On 2/24/21 5:35 AM, Markus Armbruster wrote: John Snow writes: mypy isn't fond of allowing you to check for bool membership in a collection of str elements. Guard this lookup for precisely when we were given a name. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber R

Re: [PATCH v3 03/16] qapi/expr.py: constrain incoming expression types

On 2/24/21 5:01 AM, Markus Armbruster wrote: John Snow writes: mypy does not know the types of values stored in Dicts that masquerade as objects. Help the type checker out by constraining the type. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa --- scripts

[RFC PATCH v2] meson: Only generate trace files for selected targets

We don't need to generate trace files for targets we are not building. Restrict the the ones selected. Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/meson.build b/meson.build index 05a67c20d93..8503aa1b6

[PATCH 3/3] tests/acceptance: Tagging tests with "cpu:VALUE"

The existing tests which are passing "-cpu VALUE" argument to the vm object are now properly "cpu:VALUE" tagged, so letting the avocado_qemu framework to handle that automatically. Signed-off-by: Wainer dos Santos Moschetta --- tests/acceptance/boot_linux_console.py | 16 +--- te

[PATCH 2/3] tests/acceptance: Let the framework handle "cpu:VALUE" tagged tests

The tests that are already tagged with "cpu:VALUE" don't need to add "-cpu VALUE" to the list of arguments of the vm object because the avocado_qemu framework is able to handle it automatically. So this adjust those tests and ensure their cpu's VALUE are recognized by QEMU. Signed-off-by: Wainer d

[PATCH 0/3] tests/acceptance: Handle tests with "cpu" tag

Currently the acceptance tests tagged with "machine" have the "-M TYPE" automatically added to the list of arguments of the QEMUMachine object. In other words, that option is passed to the launched QEMU. On this series it is implemented the same feature but instead for tests marked with "cpu". The

[PATCH 1/3] tests/acceptance: Automatic set -cpu to the test vm

This introduces a new feature to the functional tests: automatic setting of the '-cpu VALUE' option to the created vm if the test is tagged with 'cpu:VALUE'. The 'cpu' property is made available to the test object as well. For example, for a simple test as: def test(self): """

Re: [PATCH v3 02/16] qapi/expr.py: Check for dict instead of OrderedDict

On 2/24/21 4:30 AM, Markus Armbruster wrote: John Snow writes: OrderedDict is a subtype of dict, so we can check for a more general form. These functions do not themselves depend on it being any particular type. True. The actual arguments can only be OrderedDict, though. I think we refrain

Re: [PATCH v22 06/17] meson: add target_user_arch

On 2/24/21 2:34 PM, Claudio Fontana wrote: > the lack of target_user_arch makes it hard to fully leverage the > build system in order to separate user code from sysemu code. > > Provide it, so that we can avoid the proliferation of #ifdef > in target code. > > Signed-off-by: Claudio Fontana > Re

Re: [PATCH] qapi: Fix parse errors for removal of null from schema language

On 2/24/21 5:14 AM, Markus Armbruster wrote: Commit 9d55380b5a "qapi: Remove null from schema language" (v4.2.0) neglected to update two error messages. Do that now. One less patch in part 5. Reviewed-by: John Snow Signed-off-by: Markus Armbruster --- scripts/qapi/parser.py

Re: [PATCH v2 1/2] tests/acceptance: replace unstable apt.armbian.com URLs for orangepi-pc, cubieboard

Hi Philippe, Cleber, On Wed, Feb 24, 2021 at 8:14 PM Cleber Rosa wrote: > On Wed, Feb 24, 2021 at 10:12:10AM +0100, Philippe Mathieu-Daudé wrote: > > Hi Niek, > > > > On 2/23/21 11:53 PM, Niek Linnenbank wrote: > > > Currently the automated acceptance tests for the Orange Pi PC and > cubieboard

Re: [PATCH] Remove deprecated target tilegx

Le 24/02/2021 à 19:39, Thomas Huth a écrit : > TILE-Gx was only implemented in linux-user mode, but support for this CPU > was removed from the upstream Linux kernel in 2018, and it has also been > dropped from glibc, so there is no new Linux development taking place with > this architecture. For r

Re: [PATCH v2] Autoconnect jack ports by default

On Mittwoch, 24. Februar 2021 20:19:27 CET José Pekkarinen wrote: > This patch provides a default value to connect > jack ports when the user don't specify connect-ports. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1908832 > > Signed-off-by: José Pekkarinen > --- > audio/jackaudio.c | 15

Re: [PATCH] Remove deprecated target tilegx

Thomas Huth writes: > TILE-Gx was only implemented in linux-user mode, but support for this CPU > was removed from the upstream Linux kernel in 2018, and it has also been > dropped from glibc, so there is no new Linux development taking place with > this architecture. For running the old binari

[PATCH v2] Autoconnect jack ports by default

This patch provides a default value to connect jack ports when the user don't specify connect-ports. Buglink: https://bugs.launchpad.net/qemu/+bug/1908832 Signed-off-by: José Pekkarinen --- audio/jackaudio.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/au

RE: [PATCH v2 01/22] block: add eMMC block device type

Hi Cedric, > -Original Message- > From: Cédric Le Goater > Sent: Wednesday, February 24, 2021 7:25 PM > To: Stefan Hajnoczi ; Sai Pavan Boddu > > Cc: Philippe Mathieu-Daudé ; Markus Armbruster > ; Kevin Wolf ; Max Reitz > ; Vladimir Sementsov-Ogievskiy > ; Eric Blake ; Joel Stanley > ;

Re: [PATCH v4 10/12] target/mips: Simplify decode_opc_mxu() ifdef'ry

On 2/24/21 10:57 AM, Philippe Mathieu-Daudé wrote: > By making the prototype public and checking > 'TARGET_LONG_BITS == 32' we let the compiler > elide the decode_opc_mxu() call. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/translate.h | 3 +++ > target/mips/translate.c | 6 ++--

Re: [PATCH v4 09/12] target/mips: Convert decode_opc_mxu() to decodetree prototype

On 2/24/21 10:57 AM, Philippe Mathieu-Daudé wrote: > To easily convert MXU code to decodetree, making it return a boolean. > > Reviewed-by: Richard Henderson > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/translate.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-

Re: [PATCH v2 1/2] tests/acceptance: replace unstable apt.armbian.com URLs for orangepi-pc, cubieboard

On Wed, Feb 24, 2021 at 10:12:10AM +0100, Philippe Mathieu-Daudé wrote: > Hi Niek, > > On 2/23/21 11:53 PM, Niek Linnenbank wrote: > > Currently the automated acceptance tests for the Orange Pi PC and cubieboard > > machines are disabled by default. The tests for both machines require > > artifac

Re: [PATCH v4 08/12] target/mips: Move MUL opcode check from decode_mxu() to decode_legacy()

On 2/24/21 10:57 AM, Philippe Mathieu-Daudé wrote: > Move the check for MUL opcode from decode_opc_mxu() callee > to decode_opc_legacy() caller, so we can simplify the ifdef'ry > and elide the call in few commits. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/translate.c | 19 +++

Re: [PATCH v4 02/12] target/mips/meson: Restrict mips-semi.c to TCG

On 2/24/21 10:56 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

RE: [PATCH v2 01/22] block: add eMMC block device type

Hi Stefan > -Original Message- > From: Stefan Hajnoczi > Sent: Wednesday, February 24, 2021 5:10 PM > To: Sai Pavan Boddu > Cc: Philippe Mathieu-Daudé ; Markus Armbruster > ; Kevin Wolf ; Max Reitz > ; Vladimir Sementsov-Ogievskiy > ; Eric Blake ; Joel Stanley > ; Cédric Le Goater ; Vinc

[PATCH v4 12/12] target/mips: Extract MXU code to new mxu_translate.c file

Extract 1600+ lines from the big translate.c into a new file. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/mxu_translate.c | 1609 +++ target/mips/translate.c | 1605 -- target/mips/meson

Re: [PATCH] Autoconnect jack ports by default

On Wed, 24 Feb 2021 at 19:29, Christian Schoenebeck wrote: > On Mittwoch, 24. Februar 2021 17:47:03 CET José Ramón Muñoz Pekkarinen > wrote: > > On Wed, 24 Feb 2021 at 18:40, Christian Schoenebeck < > qemu_...@crudebyte.com> > > wrote: > > > On Mittwoch, 24. Februar 2021 17:16:58 CET José Ramón M

Re: [PATCH 00/11] scsi-generic: error handling overhaul

On 2/24/21 7:24 PM, Paolo Bonzini wrote: > This series is mostly a refresh of Hannes's patches at > https://patchew.org/QEMU/20201116184041.60465-1-h...@suse.de/, which > haven't been applied yet because they broke the testsuite. > > In addition to Hannes's introduction of host status in the SCSI

[PATCH v4 11/12] target/mips: Introduce mxu_translate_init() helper

Extract the MXU register initialization code from mips_tcg_init() as a new mxu_translate_init() helper. Make it public and replace !TARGET_MIPS64 ifdef'ry by the 'TARGET_LONG_BITS == 32' check to elide this code at preprocessing time. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu

[PATCH v4 10/12] target/mips: Simplify decode_opc_mxu() ifdef'ry

By making the prototype public and checking 'TARGET_LONG_BITS == 32' we let the compiler elide the decode_opc_mxu() call. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/translate.h | 3 +++ target/mips/translate.c | 6 ++ 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/

Re: [PATCH v4 01/12] target/mips/meson: Introduce mips_tcg source set

On 2/24/21 10:56 AM, Philippe Mathieu-Daudé wrote: > Introduce the 'mips_tcg' source set to collect TCG specific files. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/meson.build | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

[PATCH v4 08/12] target/mips: Move MUL opcode check from decode_mxu() to decode_legacy()

Move the check for MUL opcode from decode_opc_mxu() callee to decode_opc_legacy() caller, so we can simplify the ifdef'ry and elide the call in few commits. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/translate.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-

[PATCH v4 05/12] target/mips: Remove unused CPUMIPSState* from MXU functions

None of these MXU functions use their CPUMIPSState* env argument, remove it. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/translate.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/target/mips/translate.c b/targ

Re: [PATCH] Remove deprecated target tilegx

On 2/24/21 10:39 AM, Thomas Huth wrote: > TILE-Gx was only implemented in linux-user mode, but support for this CPU > was removed from the upstream Linux kernel in 2018, and it has also been > dropped from glibc, so there is no new Linux development taking place with > this architecture. For runnin

[PATCH v4 04/12] target/mips: Remove XBurst Media eXtension Unit dead code

All these unimplemented MXU opcodes end up calling gen_reserved_instruction() which is the default switch case in decode_opc_mxu(). The translate.c file is already big enough and hard to maintain, remove 1300 lines of unnecessary code and /* TODO */ comments. Reviewed-by: Richard Henderson Signe

[PATCH v4 07/12] target/mips: Use OPC_MUL instead of OPC__MXU_MUL

We already have a macro and definition to extract / check the Special2 MUL opcode. Use it instead of the unnecessary OPC__MXU_MUL macro. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH v4 01/12] target/mips/meson: Introduce mips_tcg source set

Introduce the 'mips_tcg' source set to collect TCG specific files. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/meson.build | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/target/mips/meson.build b/target/mips/meson.build index 9741545440c..75c16524606 100644

[PATCH v4 09/12] target/mips: Convert decode_opc_mxu() to decodetree prototype

To easily convert MXU code to decodetree, making it return a boolean. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/translate.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c

[PATCH v4 03/12] target/mips: Rewrite complex ifdef'ry

No need for this obfuscated ifdef'ry, KISS. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/translate.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 70891c37cdd..1f1c5

[PATCH v4 06/12] target/mips: Pass instruction opcode to decode_opc_mxu()

In the next commit we'll make decode_opc_mxu() match decodetree prototype by returning a boolean. First pass ctx->opcode as an argument. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/translate.c | 14 +++--- 1 file changed, 7 insertions(+), 7 delet

[PATCH v4 00/12] target/mips: Extract MXU code to new mxu_translate.c file

Since v3: - addressed Richard's review comments, elide code when possible This is a respin of "Extract XBurst Media eXtension Unit translation routines" v2: https://lists.gnu.org/archive/html/qemu-devel/2020-11/msg05889.html But instead of an included C file (.c.inc) we now have an independent C

[PATCH v4 02/12] target/mips/meson: Restrict mips-semi.c to TCG

Signed-off-by: Philippe Mathieu-Daudé --- target/mips/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/mips/meson.build b/target/mips/meson.build index 75c16524606..53580633ce0 100644 --- a/target/mips/meson.build +++ b/target/mips/meson.build @@ -31,10 +31,1

Re: [PATCH] qemu_fw_cfg: Make fw_cfg_rev_attr a proper kobj_attribute

On Thu, Feb 11, 2021 at 9:41 PM 'Sami Tolvanen' via Clang Built Linux wrote: > > Hi Nathan, > > On Thu, Feb 11, 2021 at 11:43 AM Nathan Chancellor wrote: > > > > fw_cfg_showrev() is called by an indirect call in kobj_attr_show(), > > which violates clang's CFI checking because fw_cfg_showrev()'s

Re: [PATCH 2/2] gitlab-ci.yml: Add jobs to test CFI flags

On 24/02/21 18:55, Daniele Buono wrote: Does it make sense to test only one target instead? I'd prefer grouping multiple targets per job so that the number of jobs doesn't explode, and stopping ninja from linking in parallel does solve the issue. Yeah, backend_max_links should do it. The 3

[PATCH 10/10] scsi: move host_status handling into SCSI drivers

From: Hannes Reinecke Some SCSI drivers like virtio have an internal mapping for the host_status. This patch moves the host_status translation into the SCSI drivers to allow those drivers to set up the correct values. Signed-off-by: Hannes Reinecke . [Added default handling to avoid touching all

[PATCH 09/10] scsi: inline sg_io_sense_from_errno() into the callers.

From: Hannes Reinecke Currently sg_io_sense_from_errno() converts the two input parameters 'errno' and 'io_hdr' into sense code and SCSI status. Having split the function off into scsi_sense_from_errno() and scsi_sense_from_host_status(), both of which are available generically, we now inline the

  1   2   3   4   >