Re: [PATCH v6 15/19] qapi/introspect.py: Add docstrings to _gen_tree and _tree_to_qlit

2021-02-17 Thread Markus Armbruster
John Snow writes: > On 2/17/21 11:35 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 2/17/21 4:39 AM, Markus Armbruster wrote: John Snow writes: > Signed-off-by: John Snow > --- >scripts/qapi/introspect.py | 18 ++ >1 file changed,

Re: [PATCH] net: e1000: check transmit descriptor field values

2021-02-17 Thread P J P
Hello Jason, +-- On Thu, 18 Feb 2021, Jason Wang wrote --+ | On 2021/2/10 下午10:52, P J P wrote: | > From: Prasad J Pandit | > | > While processing transmit (tx) descriptors in process_tx_desc() | > various descriptor fields are not checked properly. This may lead | > to infinite loop like issue

Re: [PATCH 1/1] hw/s390x: fix build for virtio-9p-ccw

2021-02-17 Thread Thomas Huth
On 18/02/2021 04.40, Halil Pasic wrote: Commit 2c44220d05 ("meson: convert hw/arch*"), which migrated the old Makefile.objs to meson.build accidentally excluded virtio-ccw-9p.c and thus the virtio-9p-ccw device from the build (and potentially also included the file virtio-ccw-blk.c twice in the

Re: [PATCH v4 71/71] gitlab: Enable cross-i386 builds of TCI

2021-02-17 Thread Thomas Huth
On 17/02/2021 21.20, Richard Henderson wrote: We're currently only testing TCI with a 64-bit host -- also test with a 32-bit host. Enable a selection of softmmu and user-only targets, 32-bit LE, 64-bit LE, 32-bit BE, as there are ifdefs for each. Reviewed-by: Philippe Mathieu-Daudé Signed-off-

Re: [PATCH v4 70/71] tests/tcg: Increase timeout for TCI

2021-02-17 Thread Thomas Huth
On 17/02/2021 21.20, Richard Henderson wrote: The longest test at the moment seems to be a (slower) aarch64 host, for which test-mmap takes 64 seconds. Signed-off-by: Richard Henderson --- configure | 3 +++ tests/tcg/Makefile.target | 6 -- 2 files changed, 7 insertions

[PATCH v5 09/10] acpi: add test case for -no-hpet

2021-02-17 Thread isaku . yamahata
From: Isaku Yamahata Reviewed-by: Igor Mammedov Signed-off-by: Isaku Yamahata --- tests/qtest/bios-tables-test.c | 24 1 file changed, 24 insertions(+) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index 93d037c29d..e020c83d2a 100644 ---

Re: [PATCH v2 1/3] pci: cleanup failover sanity check

2021-02-17 Thread Jason Wang
On 2021/2/11 上午1:45, Laurent Vivier wrote: Commit a1190ab628 has added a "allow_unplug_during_migration = true" at the end of the main "if" block, so it is not needed to set it anymore in the previous checking. Remove it, to have only sub-ifs that check for needed conditions and exit if one fa

[PATCH v5 08/10] i386: acpi: Don't build HPET ACPI entry if HPET is disabled

2021-02-17 Thread isaku . yamahata
From: Sean Christopherson Omit HPET AML if the HPET is disabled, QEMU is not emulating it and the guest may get confused by seeing HPET in the ACPI tables without a "physical" device present. The change of DSDT when -no-hpet is as follows. @@ -141,47 +141,6 @@ DefinitionBlock ("", "DSDT", 1, "B

Re: [PATCH v2 3/3] failover: really display a warning when the primary device is not found

2021-02-17 Thread Jason Wang
On 2021/2/11 上午1:45, Laurent Vivier wrote: In failover_add_primary(), we search the id of the failover device by scanning the list of the devices in the opts list to find a device with a failover_pair_id equals to the id of the virtio-net device. If the failover_pair_id is not found, QEMU igno

[PATCH v5 07/10] hw/i386: declare ACPI mother board resource for MMCONFIG region

2021-02-17 Thread isaku . yamahata
From: Isaku Yamahata Declare PNP0C01 device to reserve MMCONFIG region to conform to the spec better and play nice with guest BIOSes/OSes. According to PCI Firmware Specification[0], MMCONFIG region must be reserved by declaring a motherboard resource. It's optional to reserve the region in memo

[PATCH v5 05/10] acpi: set fadt.smi_cmd to zero when SMM is not supported

2021-02-17 Thread isaku . yamahata
From: Isaku Yamahata >From table 5.9 SMI_CMD of ACPI spec > This field is reserved and must be zero on system > that does not support System Management mode. When smm is not enabled, set it to zero to comform to the spec. When -machine smm=off is passed, the change to FACP is as follows. @@ -1,

Re: [PATCH v2 2/3] virtio-net: add missing object_unref()

2021-02-17 Thread Jason Wang
On 2021/2/11 上午1:45, Laurent Vivier wrote: failover_add_primary() calls qdev_device_add() and doesn't unref the device. Because of that, when the device is unplugged a reference is remaining and prevents the cleanup of the object. This prevents to be able to plugin back the failover primary de

[PATCH v5 06/10] acpi: add test case for smm unsupported -machine smm=off

2021-02-17 Thread isaku . yamahata
From: Isaku Yamahata Reviewed-by: Igor Mammedov Signed-off-by: Isaku Yamahata --- tests/qtest/bios-tables-test.c | 76 ++ 1 file changed, 76 insertions(+) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index 77053975aa..93d037c29d

[PATCH v5 03/10] ich9, piix4: add properoty, smm-compat, to keep compatibility of SMM

2021-02-17 Thread isaku . yamahata
From: Isaku Yamahata The following patch will introduce incompatible behavior of SMM. Introduce a property to keep the old behavior for compatibility. To enable smm compat, use "-global ICH9-LPC.smm-compat=on" or "-global PIIX4_PM.smm-compat=on" Suggested-by: Igor Mammedov Signed-off-by: Isaku

[PATCH v5 04/10] acpi/core: always set SCI_EN when SMM isn't supported

2021-02-17 Thread isaku . yamahata
From: Isaku Yamahata If SMM is not supported, ACPI fixed hardware doesn't support legacy-mode. ACPI-only platform. Where SCI_EN in PM1_CNT register is always set. The bit tells OS legacy mode(SCI_EN cleared) or ACPI mode(SCI_EN set). With the next patch (setting fadt.smi_cmd = 0 when smm isn't e

[PATCH v5 02/10] qtest: update tests/qtest/bios-tables-test-allowed-diff.h

2021-02-17 Thread isaku . yamahata
From: Isaku Yamahata The following tests will modify acpi tables. prepare qtests to allow acpi table change. add new tables for new tests. - tests/data/acpi/pc/DSDT.nohpet - tests/data/acpi/pc/FACP.nosmm - tests/data/acpi/q35/DSDT.nohpet - tests/data/acpi/q35/FACP.nosmm Acked-by: Igor Mammedov

Re: [PATCH] net: e1000: check transmit descriptor field values

2021-02-17 Thread Jason Wang
On 2021/2/10 下午10:52, P J P wrote: From: Prasad J Pandit While processing transmit (tx) descriptors in process_tx_desc() various descriptor fields are not checked properly. This may lead to infinite loop like issue. Add checks to avoid them. Reported-by: Alexander Bulekov Reported-by: Cheol

[PATCH v5 10/10] qtest/acpi/bios-tables-test: update acpi tables

2021-02-17 Thread isaku . yamahata
From: Isaku Yamahata update golden master acpi tables and empty bios-tables-test-allowed-diff.h. Signed-off-by: Isaku Yamahata --- tests/data/acpi/pc/DSDT.nohpet | Bin 0 -> 4923 bytes tests/data/acpi/pc/FACP.nosmm | Bin 0 -> 116 bytes tests/data/acpi/q35/DSDT

[PATCH v5 01/10] checkpatch: don't emit warning on newly created acpi data files

2021-02-17 Thread isaku . yamahata
From: Isaku Yamahata Newly created acpi data files(tests/data/acpi/) cause false positive warning. If file names are acpi expected file, don't emit warning. Fixes: e625ba2a41 ("checkpatch: fix acpi check with multiple file name") Signed-off-by: Isaku Yamahata --- scripts/checkpatch.pl | 4 +++-

[PATCH v5 00/10] ACPI related fixes to comform the spec better

2021-02-17 Thread isaku . yamahata
From: Isaku Yamahata Miscellaneous bug fixes related to ACPI to play nice with guest BIOSes/OSes by conforming to ACPI spec better. Changes from v4: - rebased to 1af5629673 - move compat property from 3/10 to 4/10 - use the end of the address for rage maximum of memory region - code simplificati

[PATCH 1/1] hw/s390x: fix build for virtio-9p-ccw

2021-02-17 Thread Halil Pasic
Commit 2c44220d05 ("meson: convert hw/arch*"), which migrated the old Makefile.objs to meson.build accidentally excluded virtio-ccw-9p.c and thus the virtio-9p-ccw device from the build (and potentially also included the file virtio-ccw-blk.c twice in the source set). And since CONFIG_VIRTFS can'

Re: [PATCH 0/3] virtio-net: graceful drop of vhost for TAP

2021-02-17 Thread Jason Wang
On 2021/2/10 下午4:38, Michael S. Tsirkin wrote: On Wed, Feb 10, 2021 at 02:19:59PM +0800, Jason Wang wrote: On 2021/2/9 下午11:04, Michael S. Tsirkin wrote: On Tue, Feb 09, 2021 at 02:51:05PM +, Daniel P. Berrangé wrote: On Tue, Feb 09, 2021 at 09:34:20AM -0500, Michael S. Tsirkin wrote: O

[PATCH 1/1] hw/s390x: modularize virtio-gpu-ccw

2021-02-17 Thread Halil Pasic
Since the virtio-gpu-ccw device depends on the hw-display-virtio-gpu module, which provides the type virtio-gpu-device, packaging the hw-display-virtio-gpu module as a separate package that may or may not be installed along with the qemu package leads to problems. Namely if the hw-display-virtio-gp

[PULL 19/19] hw/riscv: virt: Map high mmio for PCIe

2021-02-17 Thread Alistair Francis
From: Bin Meng Some peripherals require 64-bit PCI address, so let's map the high mmio space for PCIe. For RV32, the address is hardcoded to below 4 GiB from the highest accessible physical address. For RV64, the base address depends on top of RAM and is aligned to its size which is using 16 GiB

[PULL 14/19] goldfish_rtc: re-arm the alarm after migration

2021-02-17 Thread Alistair Francis
From: Laurent Vivier After a migration the clock offset is updated, but we also need to re-arm the alarm if needed. Signed-off-by: Laurent Vivier Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Message-id: 20201220112615.933036-7-laur...@vivier.eu Signed-off-by: Alistair Fra

[PULL 16/19] hw/riscv: Drop 'struct MemmapEntry'

2021-02-17 Thread Alistair Francis
From: Bin Meng There is already a MemMapEntry type defined in hwaddr.h. Let's drop the RISC-V defined `struct MemmapEntry` and use the existing one. Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Message-id: 20210122122958.12311-2-bmeng...@gmail.com

[PULL 12/19] docs/system: Add RISC-V documentation

2021-02-17 Thread Alistair Francis
From: Bin Meng Add RISC-V system emulator documentation for generic information. `Board-specific documentation` and `RISC-V CPU features` are only a placeholder and will be added in the future. Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Message-id: 20210126060007.12904-9-bmeng...@gm

[PULL 13/19] docs/system: riscv: Add documentation for sifive_u machine

2021-02-17 Thread Alistair Francis
From: Bin Meng This adds detailed documentation for RISC-V `sifive_u` machine, including the following information: - Supported devices - Hardware configuration information - Boot options - Machine-specific options - Running Linux kernel - Running VxWorks kernel - Running U-Boot, and with an alt

[PULL 11/19] docs/system: Sort targets in alphabetical order

2021-02-17 Thread Alistair Francis
From: Bin Meng Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Message-id: 20210126060007.12904-8-bmeng...@gmail.com Signed-off-by: Alistair Francis --- docs/system/targets.rst | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/docs/system/targets.r

[PULL 18/19] hw/riscv: virt: Limit RAM size in a 32-bit system

2021-02-17 Thread Alistair Francis
From: Bin Meng RV32 supports 34-bit physical address hence the maximum RAM size should be limitted. Limit the RAM size to 10 GiB, which leaves some room for PCIe high mmio space. Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Message-id: 20210122122958.12311-4-bmeng...@gmail.com Signed-

[PULL 10/19] hw/riscv: sifive_u: Change SIFIVE_U_GEM_IRQ to decimal value

2021-02-17 Thread Alistair Francis
From: Bin Meng All other peripherals' IRQs are in the format of decimal value. Change SIFIVE_U_GEM_IRQ to be consistent. Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Message-id: 20210126060007.12904-7-bmeng...@gmail.com Signed-off-by: Alistair Francis --- include/hw/riscv/sifive_u.h

[PULL 09/19] hw/riscv: sifive_u: Add QSPI2 controller and connect an SD card

2021-02-17 Thread Alistair Francis
From: Bin Meng This adds the QSPI2 controller to the SoC, and connects an SD card to it. The generation of corresponding device tree source fragment is also added. Specify machine property `msel` to 11 to boot the same upstream U-Boot SPL and payload image for the SiFive HiFive Unleashed board.

[PULL 08/19] hw/riscv: sifive_u: Add QSPI0 controller and connect a flash

2021-02-17 Thread Alistair Francis
From: Bin Meng This adds the QSPI0 controller to the SoC, and connects an ISSI 25WP256 flash to it. The generation of corresponding device tree source fragment is also added. Since the direct memory-mapped mode is not supported by the SiFive SPI model, the property does not populate the second

[PULL 06/19] hw/block: m25p80: Add various ISSI flash information

2021-02-17 Thread Alistair Francis
From: Bin Meng This updates the flash information table to include various ISSI flashes that are supported by upstream U-Boot and Linux kernel. Signed-off-by: Bin Meng Acked-by: Alistair Francis Message-id: 20210126060007.12904-3-bmeng...@gmail.com Signed-off-by: Alistair Francis --- hw/bloc

[PULL 17/19] hw/riscv: virt: Drop the 'link_up' parameter of gpex_pcie_init()

2021-02-17 Thread Alistair Francis
From: Bin Meng `link_up` is never used in gpex_pcie_init(). Drop it. Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Message-id: 20210122122958.12311-3-bmeng...@gmail.com Signed-off-by: Alistair Francis --- hw/riscv/virt.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletio

[PULL 07/19] hw/ssi: Add SiFive SPI controller support

2021-02-17 Thread Alistair Francis
From: Bin Meng This adds the SiFive SPI controller model for the FU540 SoC. The direct memory-mapped SPI flash mode is unsupported. Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Message-id: 20210126060007.12904-4-bmeng...@gmail.com Signed-off-by: Alistair Francis --- include/hw/ssi/s

[PULL 02/19] hw/misc: sifive_u_otp: Use error_report() when block operation fails

2021-02-17 Thread Alistair Francis
From: Bin Meng At present when blk_pread() / blk_pwrite() fails, a guest error is logged, but this is not really a guest error. Change to use error_report() instead. Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 1611026585-29971-1-git-se

[PULL 05/19] hw/block: m25p80: Add ISSI SPI flash support

2021-02-17 Thread Alistair Francis
From: Bin Meng This adds the ISSI SPI flash support. The number of dummy cycles in fast read, fast read dual output and fast read quad output commands is currently using the default 8. Likewise, the same default value is used for fast read dual/quad I/O command. Per the datasheet [1], the number

[PULL 15/19] MAINTAINERS: Add a SiFive machine section

2021-02-17 Thread Alistair Francis
Signed-off-by: Alistair Francis Acked-by: Bin Meng Acked-by: Palmer Dabbelt Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Palmer Dabbelt Message-id: 6bc077e5ae4a9512c8adf81ae194718f2f17c402.1612836645.git.alistair.fran...@wdc.com --- MAINTAINERS | 9 + 1 file changed, 9 insertions

[PULL 04/19] target-riscv: support QMP dump-guest-memory

2021-02-17 Thread Alistair Francis
From: Yifei Jiang Add the support needed for creating prstatus elf notes. This allows us to use QMP dump-guest-memory. Now ELF notes of RISC-V only contain prstatus elf notes. Signed-off-by: Yifei Jiang Signed-off-by: Mingwang Li Reviewed-by: Alistair Francis Reviewed-by: Andrew Jones Revie

[PULL 01/19] target/riscv: Declare csr_ops[] with a known size

2021-02-17 Thread Alistair Francis
From: Bin Meng csr_ops[] is currently declared with an unknown size in cpu.h. Since the array size is known, let's do a complete declaration. Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 1611024723-14293-1-git-send-email-bmeng...@gmail.

[PULL 00/19] riscv-to-apply queue

2021-02-17 Thread Alistair Francis
tags/pull-riscv-to-apply-20210217-1 for you to fetch changes up to d0867d2dad4125d2295b28d6f91fa49cf034ffd2: hw/riscv: virt: Map high mmio for PCIe (2021-02-17 17:47:19 -0800) RISC-V PR for 6.0 This PR is a collection of RISC

Re: [RFC PATCH v3 05/31] hw/cxl/device: Implement basic mailbox (8.2.8.4)

2021-02-17 Thread Ben Widawsky
On 21-02-11 17:46:39, Jonathan Cameron wrote: > On Tue, 2 Feb 2021 14:58:30 + > Jonathan Cameron wrote: > > > On Mon, 1 Feb 2021 16:59:22 -0800 > > Ben Widawsky wrote: > > > > > This is the beginning of implementing mailbox support for CXL 2.0 > > > devices. The implementation recognizes wh

Re: [PULL 00/35] hexagon initial commit

2021-02-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210217234023.1742406-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210217234023.1742406-1-richard.hender...@linaro.org Subject: [PULL 00/35] he

[PULL 00/35] hexagon initial commit

2021-02-17 Thread Richard Henderson
The following changes since commit f0f75dc174b6c79eb78a161d1c0921f82d7f1bf0: Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' into staging (2021-02-17 13:04:48 +) are available in the Git repository at: https://gitlab.com/rth7680/qemu.git tags/pull-he

[PULL 33/35] Hexagon (tests/tcg/hexagon) TCG tests - atomics/load/store/misc

2021-02-17 Thread Richard Henderson
From: Taylor Simpson Signed-off-by: Taylor Simpson Message-Id: <1612763186-18161-33-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- tests/tcg/hexagon/atomics.c | 139 +++ tests/tcg/hexagon/dual_stores.c | 60 + tests/tcg/hexagon/mem_noshuf.c|

[PULL 34/35] Hexagon (tests/tcg/hexagon) TCG tests - floating point

2021-02-17 Thread Richard Henderson
From: Taylor Simpson Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <1612763186-18161-34-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- tests/tcg/hexagon/fpstuff.c | 370 ++ tests/tcg/hexagon/Makefile.targe

[PULL 32/35] Hexagon (tests/tcg/hexagon) TCG tests - multiarch

2021-02-17 Thread Richard Henderson
From: Taylor Simpson Enable multiarch tests for Hexagon Modify tests/tcg/configure.sh Add reference files to tests/tcg/hexagon Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <1612763186-18161-32-git-send-email-tsimp...@quicinc.com>

[PULL 30/35] Hexagon (target/hexagon) translation

2021-02-17 Thread Richard Henderson
From: Taylor Simpson Read the instruction memory Create a packet data structure Generate TCG code for the start of the packet Invoke the generate function for each instruction Generate TCG code for the end of the packet Signed-off-by: Taylor Simpson Message-Id: <1612763186-18161-30-git-send-ema

[PULL 35/35] Hexagon build infrastructure

2021-02-17 Thread Richard Henderson
From: Taylor Simpson Add file to default-configs Add hexagon to meson.build Add hexagon to target/meson.build Add target/hexagon/meson.build Change scripts/qemu-binfmt-conf.sh We can build a hexagon-linux-user target and run programs on the Hexagon scalar core. With hexagon-linux-clang installe

[PULL 24/35] Hexagon (target/hexagon) opcode data structures

2021-02-17 Thread Richard Henderson
From: Taylor Simpson Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <1612763186-18161-24-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/opcodes.h | 58 target/hexagon/opc

[PULL 29/35] Hexagon (target/hexagon) TCG for floating point instructions

2021-02-17 Thread Richard Henderson
From: Taylor Simpson The imported code uses host floating point. We override them to use qemu softfloat Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <1612763186-18161-29-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/gen_

[PULL 31/35] Hexagon (linux-user/hexagon) Linux user emulation

2021-02-17 Thread Richard Henderson
From: Taylor Simpson Implementation of Linux user emulation for Hexagon Some common files modified in addition to new files in linux-user/hexagon Acked-by: Laurent Vivier Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <1612763186-18161-31-git-send-email-tsimp...@quic

[PULL 18/35] Hexagon (target/hexagon/fma_emu.[ch]) utility functions

2021-02-17 Thread Richard Henderson
From: Taylor Simpson Signed-off-by: Taylor Simpson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <1612763186-18161-18-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/fma_emu.h | 36 ++ target/hexagon/fma_emu.c | 702 +

[PULL 28/35] Hexagon (target/hexagon) TCG for instructions with multiple definitions

2021-02-17 Thread Richard Henderson
From: Taylor Simpson Helpers won't work if there are multiple definitions, so we override these instructions using #define fGEN_TCG_. Signed-off-by: Taylor Simpson Message-Id: <1612763186-18161-28-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/gen_tcg

[PULL 20/35] Hexagon (target/hexagon) generator phase 1 - C preprocessor for semantics

2021-02-17 Thread Richard Henderson
From: Taylor Simpson Run the C preprocessor across the instruction definition files and macro definition file to expand macros and prepare the semantics_generated.pyinc file. The resulting file contains one entry with the semantics for each instruction and one line with the instruction attribute

[PULL 16/35] Hexagon (target/hexagon/arch.[ch]) utility functions

2021-02-17 Thread Richard Henderson
From: Taylor Simpson Signed-off-by: Taylor Simpson Message-Id: <1612763186-18161-16-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/arch.h | 34 + target/hexagon/arch.c | 300 ++ 2 files changed, 334 insertio

[PULL 27/35] Hexagon (target/hexagon) TCG generation

2021-02-17 Thread Richard Henderson
From: Taylor Simpson Include the generated files and set up the data structures Signed-off-by: Taylor Simpson Message-Id: <1612763186-18161-27-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/genptr.h | 25 +++ target/hexagon/genptr.c | 331 +++

[PULL 26/35] Hexagon (target/hexagon) instruction classes

2021-02-17 Thread Richard Henderson
From: Taylor Simpson Determine legal VLIW slots for each instruction Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <1612763186-18161-26-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/iclass.h| 50 +++

[PULL 23/35] Hexagon (target/hexagon) generater phase 4 - decode tree

2021-02-17 Thread Richard Henderson
From: Taylor Simpson Python script that emits the decode tree in dectree_generated.h. Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <1612763186-18161-23-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/dectree.py | 351 ++

[PULL 14/35] Hexagon (target/hexagon) instruction/packet decode

2021-02-17 Thread Richard Henderson
From: Taylor Simpson Take the words from instruction memory and build a packet_t for TCG code generation The following operations are performed Convert the .new encoded offset to the register number of the producer Reorder the packet so .new producer is before consumer Apply constant

[PULL 25/35] Hexagon (target/hexagon) macros

2021-02-17 Thread Richard Henderson
From: Taylor Simpson macros to interface with the generator macros referenced in instruction semantics Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <1612763186-18161-25-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/macros

[PULL 13/35] Hexagon (target/hexagon) instruction attributes

2021-02-17 Thread Richard Henderson
From: Taylor Simpson Signed-off-by: Taylor Simpson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <1612763186-18161-13-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/attribs.h | 35 target/hexagon/

[PULL 21/35] Hexagon (target/hexagon) generator phase 2 - generate header files

2021-02-17 Thread Richard Henderson
From: Taylor Simpson Python scripts generate the following files helper_protos_generated.h.inc For each instruction we create DEF_HELPER function prototype helper_funcs_generated.c.inc For each instruction we create the helper function definition tcg_funcs_generated.c.

[PULL 17/35] Hexagon (target/hexagon/conv_emu.[ch]) utility functions

2021-02-17 Thread Richard Henderson
From: Taylor Simpson Signed-off-by: Taylor Simpson Message-Id: <1612763186-18161-17-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/conv_emu.h | 31 +++ target/hexagon/conv_emu.c | 177 ++ 2 files changed, 208 in

[PULL 09/35] Hexagon (target/hexagon) GDB Stub

2021-02-17 Thread Richard Henderson
From: Taylor Simpson GDB register read and write routines Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <1612763186-18161-9-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/internal.h | 2

[PULL 11/35] Hexagon (target/hexagon) instruction and packet types

2021-02-17 Thread Richard Henderson
From: Taylor Simpson The insn_t and packet_t are the interface between instruction decoding and TCG code generation Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <1612763186-18161-11-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/h

[PULL 22/35] Hexagon (target/hexagon) generator phase 3 - C preprocessor for decode tree

2021-02-17 Thread Richard Henderson
From: Taylor Simpson Run the C preprocessor across the instruction definition and encoding files to expand macros and prepare the iset.py file. The resulting fill contains python data structures used to build the decode tree. Signed-off-by: Taylor Simpson Reviewed-by: Philippe Mathieu-Daudé R

[PULL 15/35] Hexagon (target/hexagon) instruction printing

2021-02-17 Thread Richard Henderson
From: Taylor Simpson Signed-off-by: Taylor Simpson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <1612763186-18161-15-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/printinsn.h | 27 +++ target/hexagon/printinsn.

[PULL 10/35] Hexagon (target/hexagon) architecture types

2021-02-17 Thread Richard Henderson
From: Taylor Simpson Define types used in files imported from the Hexagon architecture library Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <1612763186-18161-10-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderso

[PULL 07/35] Hexagon (target/hexagon) register names

2021-02-17 Thread Richard Henderson
From: Taylor Simpson Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <1612763186-18161-7-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/hex_regs.h | 83 +

[PULL 12/35] Hexagon (target/hexagon) register fields

2021-02-17 Thread Richard Henderson
From: Taylor Simpson Declare bitfields within registers such as user status register (USR) Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <1612763186-18161-12-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/reg_fields.h

[PULL 06/35] Hexagon (disas) disassembler

2021-02-17 Thread Richard Henderson
From: Taylor Simpson Add hexagon to disas/meson.build Add disas/hexagon.c Add hexagon to include/disas/dis-asm.h Signed-off-by: Taylor Simpson Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Message-Id: <1612763186-18161-6-git-send-email-tsimp...@quicinc.com> Signed-off-

[PULL 05/35] Hexagon (target/hexagon) scalar core definition

2021-02-17 Thread Richard Henderson
From: Taylor Simpson Add target state header, target definitions and initialization routines Signed-off-by: Taylor Simpson Message-Id: <1612763186-18161-5-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/cpu-param.h | 29 target/hexagon/cpu.h

[PULL 08/35] Hexagon (target/hexagon) scalar core helpers

2021-02-17 Thread Richard Henderson
From: Taylor Simpson The majority of helpers are generated. Define the helper functions needed then include the generated file Signed-off-by: Taylor Simpson Message-Id: <1612763186-18161-8-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/helper.h|

[PULL 04/35] Hexagon (include/elf.h) ELF machine definition

2021-02-17 Thread Richard Henderson
From: Taylor Simpson Define EM_HEXAGON 164 Signed-off-by: Taylor Simpson Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <1612763186-18161-4-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- include/el

[PULL 03/35] Hexagon (target/hexagon) README

2021-02-17 Thread Richard Henderson
From: Taylor Simpson Gives an introduction and overview to the Hexagon target Signed-off-by: Taylor Simpson Message-Id: <1612763186-18161-3-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/README | 235 ++ 1 file

[PULL 01/35] qemu/int128: Add int128_or

2021-02-17 Thread Richard Henderson
Signed-off-by: Richard Henderson Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Message-Id: <20201021045149.1582203-2-richard.hender...@linaro.org> --- include/qemu/int128.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/

[PULL 02/35] Hexagon Update MAINTAINERS file

2021-02-17 Thread Richard Henderson
From: Taylor Simpson Add Taylor Simpson as the Hexagon target maintainer Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <1612763186-18161-2-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- MAINTAINERS | 9 + 1 file changed, 9 inserti

[PATCH v2 3/3] virtiofsd: Change umask if posix acls are enabled

2021-02-17 Thread Vivek Goyal
When parent directory has default acl and a file is created in that directory, then umask is ignored and final file permissions are determined using default acl instead. (man 2 umask). Currently, fuse applies the umask and sends modified mode in create request accordingly. fuse server can set FUSE

[PATCH v2 1/3] virtiofsd: Add an option to enable/disable posix acls

2021-02-17 Thread Vivek Goyal
fuse has an option FUSE_POSIX_ACL which needs to be opted in by fuse server to enable posix acls. Add virtiofsd option "-o posix_acl/no_posix_acl" to let users enable/disable posix acl support. By default it is disabled as of now. Currently even if file server has not opted in for FUSE_POSIX_ACL,

[PATCH v2 2/3] virtiofsd: Add umask to seccom allow list

2021-02-17 Thread Vivek Goyal
Next patch is going to make use of "umask" syscall. So allow it. Signed-off-by: Vivek Goyal --- tools/virtiofsd/passthrough_seccomp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/virtiofsd/passthrough_seccomp.c b/tools/virtiofsd/passthrough_seccomp.c index 62441cfcdb..f49ed94b5e 10

[PATCH v2 0/3] virtiofsd: Add options to enable/disable posix acl

2021-02-17 Thread Vivek Goyal
Hi, This is V2 of the patches. Changes since v1 are. - Rebased on top of latest master. - Took care of Miklos's comments to block acl xattrs if user explicitly disabled posix acl. Luis Henriques reported that fstest generic/099 fails with virtiofs. Little debugging showed that we don't enable

Re: [PATCH v2 7/7] tests/avocado: add boot_xen tests

2021-02-17 Thread Alex Bennée
Cleber Rosa writes: > On Thu, Feb 11, 2021 at 05:19:45PM +, Alex Bennée wrote: >> These tests make sure we can boot the Xen hypervisor with a Dom0 >> kernel using the guest-loader. We currently have to use a kernel I >> built myself because there are issues using the Debian kernel images. >

Re: [RFC PATCH v3 04/31] hw/cxl/device: Implement the CAP array (8.2.8.1-2)

2021-02-17 Thread Ben Widawsky
On 21-02-02 12:23:50, Jonathan Cameron wrote: > On Mon, 1 Feb 2021 16:59:21 -0800 > Ben Widawsky wrote: > > > This implements all device MMIO up to the first capability. That > > includes the CXL Device Capabilities Array Register, as well as all of > > the CXL Device Capability Header Registers.

Re: [PATCH v4 00/71] TCI fixes and cleanups

2021-02-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210217202036.1724901-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210217202036.1724901-1-richard.hender...@linaro.org Subject: [PATCH v4 00/71

Re: [qemu-web PATCH] Add Outreachy and GSoC announcement

2021-02-17 Thread Stefan Hajnoczi
On Wed, Feb 17, 2021 at 12:03:16PM +0100, Thomas Huth wrote: > On 17/02/2021 11.07, Stefan Hajnoczi wrote: > > QEMU is participating in Outreachy May-August and is applying for GSoC > > 2021. It's time to publish information on these internship programs and > > how to apply. > > Thanks, it's onlin

Re: [PATCH v7 30/35] Hexagon (linux-user/hexagon) Linux user emulation

2021-02-17 Thread Richard Henderson
On 2/17/21 12:15 PM, Laurent Vivier wrote: >> +#include "../i386/termbits.h" > > should be #include "../generic/termbits.h" > > Acked-by: Laurent Vivier Fixed against the v8 patch set. Thanks, r~

Re: [PATCH 0/2] Allwinner H3 fixes for EMAC and acceptance tests

2021-02-17 Thread Niek Linnenbank
Hi Daniel, Philippe, Op di 16 feb. 2021 10:49 schreef Daniel P. Berrangé : > On Fri, Feb 12, 2021 at 03:10:00PM +0100, Philippe Mathieu-Daudé wrote: > > Hi Niek and QEMU community, > > > > On 2/11/21 11:00 PM, Niek Linnenbank wrote: > > > The following are maintenance patches for the Allwinner

[PATCH v4 71/71] gitlab: Enable cross-i386 builds of TCI

2021-02-17 Thread Richard Henderson
We're currently only testing TCI with a 64-bit host -- also test with a 32-bit host. Enable a selection of softmmu and user-only targets, 32-bit LE, 64-bit LE, 32-bit BE, as there are ifdefs for each. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- .gitlab-ci.d/crossbu

[PATCH v4 69/71] tcg/tci: Split out tci_qemu_ld, tci_qemu_st

2021-02-17 Thread Richard Henderson
Expand the single-use macros into the new functions. Use cpu_ldsb_mmuidx_ra and cpu_ldsw_le_mmuidx_ra so that the trace event receives the correct sign flag. Signed-off-by: Richard Henderson --- tcg/tci.c | 215 +++--- 1 file changed, 75 insertions

[PATCH v4 67/71] tcg/tci: Implement mulu2, muls2

2021-02-17 Thread Richard Henderson
We already had mulu2_i32 for a 32-bit host; expand this to 64-bit hosts as well. The muls2_i32 and the 64-bit opcodes are new. Signed-off-by: Richard Henderson --- tcg/tci/tcg-target.h | 8 tcg/tci.c| 35 +-- tcg/tci/tcg-target.c.inc

[PATCH v4 70/71] tests/tcg: Increase timeout for TCI

2021-02-17 Thread Richard Henderson
The longest test at the moment seems to be a (slower) aarch64 host, for which test-mmap takes 64 seconds. Signed-off-by: Richard Henderson --- configure | 3 +++ tests/tcg/Makefile.target | 6 -- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/configure b/confi

[PATCH v4 62/71] tcg/tci: Implement goto_ptr

2021-02-17 Thread Richard Henderson
This operation is critical to staying within the interpretation loop longer, which avoids the overhead of setup and teardown for many TBs. The check in tcg_prologue_init is disabled because TCI does want to use NULL to indicate exit, as opposed to branching to a real epilogue. Signed-off-by: Rich

[PATCH v4 68/71] tcg/tci: Implement add2, sub2

2021-02-17 Thread Richard Henderson
We already had the 32-bit versions for a 32-bit host; expand this to 64-bit hosts as well. The 64-bit opcodes are new. Signed-off-by: Richard Henderson --- tcg/tci/tcg-target.h | 8 tcg/tci.c| 40 ++-- tcg/tci/tcg-target.c.inc |

[PATCH v4 56/71] tcg/tci: Split out tcg_out_op_np

2021-02-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/tci/tcg-target.c.inc | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/tcg/tci/tcg-target.c.inc b/tcg/tci/tcg-target.c.inc index eeafec6d44..e4a5872b2a 100644 --- a/tcg/tci/tcg-target.c.inc +++ b/tcg/tci/tcg-target.c.i

[PATCH v4 66/71] tcg/tci: Implement clz, ctz, ctpop

2021-02-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/tci/tcg-target.h | 12 +-- tcg/tci.c| 44 tcg/tci/tcg-target.c.inc | 9 3 files changed, 59 insertions(+), 6 deletions(-) diff --git a/tcg/tci/tcg-target.h b/tcg/tci/tcg-target

[PATCH v4 63/71] tcg/tci: Implement movcond

2021-02-17 Thread Richard Henderson
When this opcode is not available in the backend, tcg middle-end will expand this as a series of 5 opcodes. So implementing this saves bytecode space. Signed-off-by: Richard Henderson --- tcg/tci/tcg-target.h | 4 ++-- tcg/tci.c| 16 +++- tcg/tci/tcg-target.c.in

[PATCH v4 52/71] tcg/tci: Split out tcg_out_op_rrrr

2021-02-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/tci/tcg-target.c.inc | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/tcg/tci/tcg-target.c.inc b/tcg/tci/tcg-target.c.inc index f7595fbd65..c2bbd85130 100644 --- a/tcg/tci/tcg-target.c.inc +++ b/tcg/tci/tcg-target.

[PATCH v4 64/71] tcg/tci: Implement andc, orc, eqv, nand, nor

2021-02-17 Thread Richard Henderson
These were already present in tcg-target.c.inc, but not in the interpreter. Signed-off-by: Richard Henderson --- tcg/tci/tcg-target.h | 20 ++-- tcg/tci.c| 40 2 files changed, 50 insertions(+), 10 deletions(-) diff --git a/tc

  1   2   3   >