Re: [PATCH 00/10] vhost/qemu: thread per IO SCSI vq

2020-11-17 Thread Jason Wang
On 2020/11/18 下午2:57, Mike Christie wrote: On 11/17/20 11:17 PM, Jason Wang wrote: On 2020/11/18 上午12:40, Stefan Hajnoczi wrote: On Thu, Nov 12, 2020 at 05:18:59PM -0600, Mike Christie wrote: The following kernel patches were made over Michael's vhost branch: https://urldefense.com/v3/__htt

Re: [PATCH] Fix build with 64 bits time_t

2020-11-17 Thread Michael S. Tsirkin
On Tue, Nov 17, 2020 at 09:28:46PM +0100, Fabrice Fontaine wrote: > time element is deprecated on new input_event structure in kernel's > input.h [1] > > This will avoid the following build failure: > > hw/input/virtio-input-host.c: In function 'virtio_input_host_handle_status': > hw/input/virtio

Re: [PATCH for-5.2] s390x/pci: fix endianness issues

2020-11-17 Thread Cornelia Huck
On Tue, 17 Nov 2020 14:49:53 -0500 Matthew Rosato wrote: > On 11/17/20 2:21 PM, Thomas Huth wrote: > > On 17/11/2020 18.13, Cornelia Huck wrote: > >> zPCI control blocks are big endian, we need to take care that we > >> do proper accesses in order not to break tcg guests on little endian > >> h

Re: [PATCH for-5.2] docs: Fix some typos (found by codespell)

2020-11-17 Thread Michael S. Tsirkin
On Tue, Nov 17, 2020 at 08:34:48PM +0100, Stefan Weil wrote: > Fix also a similar typo in a code comment. > > Signed-off-by: Stefan Weil Reviewed-by: Michael S. Tsirkin > --- > docs/can.txt | 8 > docs/interop/vhost-user.rst | 2 +- > docs/replay.txt

Re: [PATCH 00/10] vhost/qemu: thread per IO SCSI vq

2020-11-17 Thread Mike Christie
On 11/18/20 12:57 AM, Mike Christie wrote: > On 11/17/20 11:17 PM, Jason Wang wrote: >> >> On 2020/11/18 上午12:40, Stefan Hajnoczi wrote: >>> On Thu, Nov 12, 2020 at 05:18:59PM -0600, Mike Christie wrote: The following kernel patches were made over Michael's vhost branch: https://urld

Re: [PATCH for-5.2] Revert series "spapr/xive: Allocate vCPU IPIs from the vCPU contexts"

2020-11-17 Thread Cédric Le Goater
On 11/18/20 6:24 AM, David Gibson wrote: > On Mon, Nov 16, 2020 at 04:34:22PM +0100, Greg Kurz wrote: >> This series was largely built on the assumption that IPI numbers are >> numerically equal to vCPU ids. Even if this happens to be the case >> in practice with the default machine settings, this

Re: [PATCH for-5.2] meson: Fix argument for makensis (build regression)

2020-11-17 Thread Marc-André Lureau
On Tue, Nov 17, 2020 at 11:15 PM Stefan Weil wrote: > > `make installer` with a DLL directory was broken. > > Signed-off-by: Stefan Weil Reviewed-by: Marc-André Lureau > --- > scripts/nsis.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/nsis.py b/scripts/ns

Re: [PATCH 00/10] vhost/qemu: thread per IO SCSI vq

2020-11-17 Thread Mike Christie
On 11/17/20 11:17 PM, Jason Wang wrote: > > On 2020/11/18 上午12:40, Stefan Hajnoczi wrote: >> On Thu, Nov 12, 2020 at 05:18:59PM -0600, Mike Christie wrote: >>> The following kernel patches were made over Michael's vhost branch: >>> >>> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/lin

[PATCH] qapi: Normalize version references x.y.0 to just x.y

2020-11-17 Thread Markus Armbruster
We use x.y most of the time, and x.y.0 sometimes. Normalize for consistency. Reported-by: Eduardo Habkost Signed-off-by: Markus Armbruster --- qapi/block-core.json | 28 qapi/block-export.json | 6 +++--- qapi/block.json | 2 +- qapi/char.json

Re: [PATCH] virtio-net: purge queued rx packets on queue deletion

2020-11-17 Thread Yuri Benditovich
Hi Jason, Sorry, there is a mistake in the title: should be 'net' instead of 'virtio-net'. Can you please fix it? Thanks, Yuri Benditovich On Wed, Nov 18, 2020 at 5:59 AM Jason Wang wrote: > > On 2020/11/12 下午5:46, Yuri Benditovich wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1829272

Re: [PATCH v2 5/7] qapi: Introduce QAPI_LIST_APPEND

2020-11-17 Thread Markus Armbruster
Eric Blake writes: > On 11/17/20 6:51 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Similar to the existing QAPI_LIST_PREPEND, but designed for use where >>> we want to preserve insertion order. Callers will be added in >>> upcoming patches. Note the difference in signature: PREPE

Re: [PATCH v3 2/5] memory: Add IOMMUTLBEvent

2020-11-17 Thread David Gibson
On Mon, Nov 16, 2020 at 05:55:03PM +0100, Eugenio Pérez wrote: > This way we can tell between regular IOMMUTLBEntry (entry of IOMMU > hardware) and notifications. > > In the notifications, we set explicitly if it is a MAPs or an UNMAP, > instead of trusting in entry permissions to differentiate th

Re: [PATCH for-5.2] Revert series "spapr/xive: Allocate vCPU IPIs from the vCPU contexts"

2020-11-17 Thread David Gibson
On Mon, Nov 16, 2020 at 04:34:22PM +0100, Greg Kurz wrote: > This series was largely built on the assumption that IPI numbers are > numerically equal to vCPU ids. Even if this happens to be the case > in practice with the default machine settings, this ceases to be true > if VSMT is set to a differ

Re: [PATCH 00/10] vhost/qemu: thread per IO SCSI vq

2020-11-17 Thread Jason Wang
On 2020/11/18 上午12:40, Stefan Hajnoczi wrote: On Thu, Nov 12, 2020 at 05:18:59PM -0600, Mike Christie wrote: The following kernel patches were made over Michael's vhost branch: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git/log/?h=vhost and the vhost-scsi bug fix patchset: ht

[Bug 1904652] [NEW] Assertion failure in usb-ohci

2020-11-17 Thread Cheol-Woo,Myung
Public bug reported: Hello, Using hypervisor fuzzer, hyfuzz, I found an assertion failure through usb-ohci. A malicious guest user/process could use this flaw to abort the QEMU process on the host, resulting in a denial of service. This was found in version 5.2.0 (master) ``` Progra

Re: [PATCH] virtio-net: purge queued rx packets on queue deletion

2020-11-17 Thread Jason Wang
On 2020/11/12 下午5:46, Yuri Benditovich wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1829272 When deleting queue pair, purge pending RX packets if any. Example of problematic flow: 1. Bring up q35 VM with tap (vhost off) and virtio-net or e1000e 2. Run ping flood to the VM NIC ( 1 ms inter

Re: [PATCH v2] net/e1000e_core: adjust count if RDH exceeds RDT in e1000e_ring_advance()

2020-11-17 Thread Jason Wang
On 2020/11/13 下午6:31, Mauro Matteo Cascella wrote: The e1000e_write_packet_to_guest() function iterates over a set of receive descriptors by advancing rx descriptor head register (RDH) from its initial value to rx descriptor tail register (RDT). The check in e1000e_ring_empty() is responsible f

[ANNOUNCE] QEMU 5.2.0-rc2 is now available

2020-11-17 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the third release candidate for the QEMU 5.2 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-5.2.0-rc2.tar.xz http://downl

Re: [PATCH for-6.0 1/6] qapi: Add query-accel command

2020-11-17 Thread Roman Bolshakov
On Tue, Nov 17, 2020 at 09:51:58AM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Mon, Nov 16, 2020 at 10:20:04AM -0600, Eric Blake wrote: > >> On 11/16/20 7:10 AM, Roman Bolshakov wrote: > >> > There's a problem for management applications to determine if certain > >> > accel

Re: [PATCH v6] hw/i386/pc: add max combined fw size as machine configuration option

2020-11-17 Thread McMillan, Erich
Thanks Michael. -Erich From: Michael S. Tsirkin Sent: Tuesday, November 17, 2020 10:53 AM To: McMillan, Erich Cc: qemu-devel@nongnu.org ; ler...@redhat.com ; dgilb...@redhat.com ; marcel.apfelb...@gmail.com ; imamm...@redhat.com ; kra...@redhat.com Subject: R

Re: [PATCH v2 5/7] qapi: Introduce QAPI_LIST_APPEND

2020-11-17 Thread Eric Blake
On 11/17/20 6:51 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Similar to the existing QAPI_LIST_PREPEND, but designed for use where >> we want to preserve insertion order. Callers will be added in >> upcoming patches. Note the difference in signature: PREPEND takes >> List*, APPEND ta

Re: [PATCH v9 08/12] hw/block/nvme: Support Zoned Namespace Command Set

2020-11-17 Thread Keith Busch
On Thu, Nov 12, 2020 at 08:36:39PM +0100, Klaus Jensen wrote: > On Nov 5 11:53, Dmitry Fomichev wrote: > > @@ -133,6 +300,12 @@ static Property nvme_ns_props[] = { > > DEFINE_BLOCK_PROPERTIES(NvmeNamespace, blkconf), > > DEFINE_PROP_UINT32("nsid", NvmeNamespace, params.nsid, 0), > >

[PATCH v4] fcntl: Add 32bit filesystem mode

2020-11-17 Thread Linus Walleij
It was brought to my attention that this bug from 2018 was still unresolved: 32 bit emulators like QEMU were given 64 bit hashes when running 32 bit emulation on 64 bit systems. This adds a flag to the fcntl() F_GETFD and F_SETFD operations to set the underlying filesystem into 32bit mode even if

Re: [PATCH v3 RESEND] fcntl: Add 32bit filesystem mode

2020-11-17 Thread Linus Walleij
On Tue, Oct 13, 2020 at 11:22 AM Dave Martin wrote: > > case F_SETFD: > > err = 0; > > set_close_on_exec(fd, arg & FD_CLOEXEC); > > + if (arg & FD_32BIT_MODE) > > + filp->f_mode |= FMODE_32BITHASH; > > + else > > +

Re: [PULL 0/2] Linux user for 5.2 patches

2020-11-17 Thread Peter Maydell
On Tue, 17 Nov 2020 at 15:18, Laurent Vivier wrote: > > The following changes since commit cb5ed407a1ddadf788fd373fed41c87c9e81e5b0: > > Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2020-11= > -15' into staging (2020-11-16 17:00:36 +) > > are available in the Git repos

question about bdrv_replace_node

2020-11-17 Thread Vladimir Sementsov-Ogievskiy
Hi! bdrv_replace_node_common() keeps old node parents in a list and call bdrv_replace_child_noperm() in a loop.. But bdrv_replace_child_noperm() may do aio_poll, which may trigger any graph change, up to freeing child which we keep in a loop. Actually I've reach something similar with a lot m

Re: [Virtio-fs] [PATCH] virtiofsd: Use --thread-pool-size=0 to mean no thread pool

2020-11-17 Thread Vivek Goyal
On Tue, Nov 17, 2020 at 04:00:09PM +, Venegas Munoz, Jose Carlos wrote: > > Not sure what the default is for 9p, but comparing > > default to default will definitely not be apples to apples since this > > mode is nonexistent in 9p. > > In Kata we are looking for the best config for fs co

[Bug 1894836] Re: kernel panic using hvf with CPU passthrough

2020-11-17 Thread Jordan Williams
Thanks for the response Jessica! The option you provided fixes the problem and everything works flawlessly now. Thank you!! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1894836 Title: kernel panic

Re: [PULL 0/1] QObject patches patches for 2020-11-17

2020-11-17 Thread Peter Maydell
On Tue, 17 Nov 2020 at 14:57, Markus Armbruster wrote: > > The following changes since commit 1c7ab0930a3e02e6e54722c20b6b586364f387a7: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2020-11-17 11:50:11 +) > > are available in the Git repository at: > > g

[PATCH] Fix build with 64 bits time_t

2020-11-17 Thread Fabrice Fontaine
time element is deprecated on new input_event structure in kernel's input.h [1] This will avoid the following build failure: hw/input/virtio-input-host.c: In function 'virtio_input_host_handle_status': hw/input/virtio-input-host.c:198:28: error: 'struct input_event' has no member named 'time'

Re: [PATCH 06/15] target/arm: Enforce M-profile VMRS/VMSR register restrictions

2020-11-17 Thread Peter Maydell
On Tue, 17 Nov 2020 at 19:42, Richard Henderson wrote: > > On 11/16/20 8:08 AM, Peter Maydell wrote: > > -if (a->rt == 15 && (!a->l || a->reg != ARM_VFP_FPSCR)) { > > +if (a->reg != ARM_VFP_FPSCR) { > > +return false; > > +} > > +if (a->rt == 15 && !a->l

Re: [PULL 0/9] target-arm queue

2020-11-17 Thread Peter Maydell
into > staging (2020-11-17 11:07:00 +) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20201117 > > for you to fetch changes up to ab135622cf478585bdfcb68b85e4a817d74a0c42: > > tmp105

Re: [PATCH v2] hw/char/cmsdk-apb-uart: Fix rx interrupt handling

2020-11-17 Thread Tadej Pecar
On 17. 11. 20 17:38, Peter Maydell wrote: > On Mon, 16 Nov 2020 at 19:58, Tadej Pečar wrote: >> >> Previously, the RX interrupt got missed if: >> - the character backend provided next character before >>the RX IRQ Handler managed to clear the currently served interrupt. >> - the character back

[PATCH for-5.2] meson: Fix build with --disable-guest-agent-msi

2020-11-17 Thread Stefan Weil
The QGA MSI target requires several macros which are only available without --disable-guest-agent-msi. Don't define that target if configure was called with --disable-guest-agent-msi. Signed-off-by: Stefan Weil --- qga/meson.build | 36 +++- 1 file changed, 19 in

Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category

2020-11-17 Thread Thomas Huth
On 16/11/2020 18.00, Markus Armbruster wrote: > Thomas Huth writes: > >> On 16/11/2020 14.25, Philippe Mathieu-Daudé wrote: >>> Hi Gan, >>> >>> On 11/15/20 7:49 PM, Gan Qixin wrote: Some peripherals of bcm2835 cprman have no category, put them into the 'misc' category. S

Re: Regressions in build process introduced since August

2020-11-17 Thread Stefan Weil
Am 17.11.20 um 19:01 schrieb Paolo Bonzini: On 17/11/20 18:50, Stefano Garzarella wrote: Running `configure [...] --extra-cflags="-I /xyz"` results in compiler flags `-I [...] /xyz`, so the `-I` and `/xyz` are separated by other compiler flags which obviously cannot work as expected. I could wo

Re: [PATCH 12/15] target/arm: Factor out preserve-fp-state from full_vfp_access_check()

2020-11-17 Thread Richard Henderson
On 11/16/20 8:08 AM, Peter Maydell wrote: > Factor out the code which handles M-profile lazy FP state preservation > from full_vfp_access_check(); accesses to the FPCXT_NS register are > a special case which need to do just this part (corresponding in the > pseudocode to the PreserveFPState() funct

Re: [PATCH 11/15] target/arm: Use new FPCR_NZCV_MASK constant

2020-11-17 Thread Richard Henderson
On 11/16/20 8:08 AM, Peter Maydell wrote: > We defined a constant name for the mask of NZCV bits in the FPCR/FPSCR > in the previous commit; use it in a couple of places in existing code, > where we're masking out everything except NZCV for the "load to Rt=15 > sets CPSR.NZCV" special case. > > Si

Re: [PATCH for-5.2] s390x/pci: fix endianness issues

2020-11-17 Thread Matthew Rosato
On 11/17/20 2:21 PM, Thomas Huth wrote: On 17/11/2020 18.13, Cornelia Huck wrote: zPCI control blocks are big endian, we need to take care that we do proper accesses in order not to break tcg guests on little endian hosts. Fixes: 28dc86a07299 ("s390x/pci: use a PCI Group structure") Fixes: 9670

Re: [PATCH v2 02/16] qapi/expr.py: Check for dict instead of OrderedDict

2020-11-17 Thread John Snow
On 11/17/20 1:08 PM, Eduardo Habkost wrote: On Tue, Nov 17, 2020 at 05:30:04PM +0100, Markus Armbruster wrote: John Snow writes: OrderedDict is a subtype of dict, so we can check for a more general form. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa ---

Re: [PATCH 08/15] target/arm: Move general-use constant expanders up in translate.c

2020-11-17 Thread Richard Henderson
On 11/16/20 8:08 AM, Peter Maydell wrote: > The constant-expander functions like negate, plus_2, etc, are > generally useful; move them up in translate.c so we can use them in > the VFP/Neon decoders as well as in the A32/T32/T16 decoders. > > Signed-off-by: Peter Maydell > --- > target/arm/tran

Re: [PATCH 06/15] target/arm: Enforce M-profile VMRS/VMSR register restrictions

2020-11-17 Thread Richard Henderson
On 11/16/20 8:08 AM, Peter Maydell wrote: > -if (a->rt == 15 && (!a->l || a->reg != ARM_VFP_FPSCR)) { > +if (a->reg != ARM_VFP_FPSCR) { > +return false; > +} > +if (a->rt == 15 && !a->l) { Alternately, the parenthesis are just off: if ((a->rt == 15 &&

[PATCH v3] virtiofsd: Use --thread-pool-size=0 to mean no thread pool

2020-11-17 Thread Vivek Goyal
This is V3 of the patch. A minor change since V2 is to reverse the list before executing requests. We are prepending elements to the list and that means when we start processing requests, we are processing these in the reverse order. Though we don't guarantee any ordering but it does not hurt to pr

[PATCH for-5.2] docs: Fix some typos (found by codespell)

2020-11-17 Thread Stefan Weil
Fix also a similar typo in a code comment. Signed-off-by: Stefan Weil --- docs/can.txt | 8 docs/interop/vhost-user.rst | 2 +- docs/replay.txt | 2 +- docs/specs/ppc-spapr-numa.rst | 2 +- docs/system/deprecated.rst| 4 ++-- docs/tools/virtiofsd.rst

Re: [PATCH 05/15] target/arm: Implement CLRM instruction

2020-11-17 Thread Richard Henderson
On 11/16/20 8:08 AM, Peter Maydell wrote: > In v8.1M the new CLRM instruction allows zeroing an arbitrary set of > the general-purpose registers and APSR. Implement this. > > The encoding is a subset of the LDMIA T2 encoding, using what would > be Rn=0b (which UNDEFs for LDMIA). > > Signed-o

Re: [PATCH v4 2/2] arm64: kvm: Introduce MTE VCPU feature

2020-11-17 Thread Marc Zyngier
Hi Steven, On 2020-10-26 15:57, Steven Price wrote: Add a new VM feature 'KVM_ARM_CAP_MTE' which enables memory tagging for a VM. This exposes the feature to the guest and automatically tags memory pages touched by the VM as PG_mte_tagged (and clears the tags storage) to ensure that the guest ca

Re: [PATCH 04/15] target/arm: Implement VSCCLRM insn

2020-11-17 Thread Richard Henderson
On 11/16/20 8:08 AM, Peter Maydell wrote: > +aspen = load_cpu_field(v7m.fpccr[M_REG_S]); > +sfpa = load_cpu_field(v7m.control[M_REG_S]); > +tcg_gen_andi_i32(aspen, aspen, R_V7M_FPCCR_ASPEN_MASK); > +tcg_gen_subi_i32(aspen, aspen, R_V7M_FPCCR_ASPEN_MASK); xori would be clearer, i th

Re: [PATCH for-5.2] s390x/pci: fix endianness issues

2020-11-17 Thread Thomas Huth
On 17/11/2020 19.49, Philippe Mathieu-Daudé wrote: > On 11/17/20 7:39 PM, Thomas Huth wrote: >> On 17/11/2020 19.30, Philippe Mathieu-Daudé wrote: >>> On 11/17/20 7:19 PM, Matthew Rosato wrote: On 11/17/20 12:59 PM, Philippe Mathieu-Daudé wrote: > On 11/17/20 6:13 PM, Cornelia Huck wrote:

Re: [PATCH for-5.2] s390x/pci: fix endianness issues

2020-11-17 Thread Thomas Huth
On 17/11/2020 18.13, Cornelia Huck wrote: > zPCI control blocks are big endian, we need to take care that we > do proper accesses in order not to break tcg guests on little endian > hosts. > > Fixes: 28dc86a07299 ("s390x/pci: use a PCI Group structure") > Fixes: 9670ee752727 ("s390x/pci: use a PCI

Re: [PATCH for-5.2] s390x/pci: fix endianness issues

2020-11-17 Thread Matthew Rosato
On 11/17/20 12:13 PM, Cornelia Huck wrote: zPCI control blocks are big endian, we need to take care that we do proper accesses in order not to break tcg guests on little endian hosts. Fixes: 28dc86a07299 ("s390x/pci: use a PCI Group structure") Fixes: 9670ee752727 ("s390x/pci: use a PCI Function

Re: [PATCH v4 1/2] arm64: kvm: Save/restore MTE registers

2020-11-17 Thread Marc Zyngier
Hi Steven, These patches unfortunately don't apply to -rc4 anymore, as we repainted quite a bit while working on fixes. I'd be grateful if you could rebase them. A few other things though: On 2020-10-26 15:57, Steven Price wrote: Define the new system registers that MTE introduces and contex

Re: [PATCH 00/10] vhost/qemu: thread per IO SCSI vq

2020-11-17 Thread Mike Christie
On 11/17/20 10:40 AM, Stefan Hajnoczi wrote: > On Thu, Nov 12, 2020 at 05:18:59PM -0600, Mike Christie wrote: >> The following kernel patches were made over Michael's vhost branch: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git/log/?h=vhost >> >> and the vhost-scsi bug fix patc

Re: [PATCH 03/15] target/arm: Don't clobber ID_PFR1.Security on M-profile cores

2020-11-17 Thread Richard Henderson
On 11/16/20 8:08 AM, Peter Maydell wrote: > In arm_cpu_realizefn() we check whether the board code disabled EL3 > via the has_el3 CPU object property, which we create if the CPU > starts with the ARM_FEATURE_EL3 feature bit. If it is disabled, then > we turn off ARM_FEATURE_EL3 and also zero out t

Re: [PATCH 02/15] target/arm: Implement v8.1M PXN extension

2020-11-17 Thread Richard Henderson
On 11/16/20 8:08 AM, Peter Maydell wrote: > In v8.1M the PXN architecture extension adds a new PXN bit to the > MPU_RLAR registers, which forbids execution of code in the region > from a privileged mode. > > This is another feature which is just in the generic "in v8.1M" set > and has no ID regist

[PATCH for-5.2] meson: Fix argument for makensis (build regression)

2020-11-17 Thread Stefan Weil
`make installer` with a DLL directory was broken. Signed-off-by: Stefan Weil --- scripts/nsis.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/nsis.py b/scripts/nsis.py index e1c409344e..5135a05831 100644 --- a/scripts/nsis.py +++ b/scripts/nsis.py @@ -65,7 +65,7 @@

Re: [PATCH 01/15] hw/intc/armv7m_nvic: Make all of system PPB range be RAZWI/BusFault

2020-11-17 Thread Richard Henderson
On 11/16/20 8:08 AM, Peter Maydell wrote: > For M-profile CPUs, the range from 0xe000 to 0xe00f is the > Private Peripheral Bus range, which includes all of the memory mapped > devices and registers that are part of the CPU itself, including the > NVIC, systick timer, and debug and trace co

Re: [Virtio-fs] [PATCH] virtiofsd: Use --thread-pool-size=0 to mean no thread pool

2020-11-17 Thread Vivek Goyal
On Tue, Nov 17, 2020 at 04:00:09PM +, Venegas Munoz, Jose Carlos wrote: > > Not sure what the default is for 9p, but comparing > > default to default will definitely not be apples to apples since this > > mode is nonexistent in 9p. > > In Kata we are looking for the best config for fs co

Re: [PATCH for-5.2] s390x/pci: fix endianness issues

2020-11-17 Thread Philippe Mathieu-Daudé
On 11/17/20 7:39 PM, Thomas Huth wrote: > On 17/11/2020 19.30, Philippe Mathieu-Daudé wrote: >> On 11/17/20 7:19 PM, Matthew Rosato wrote: >>> On 11/17/20 12:59 PM, Philippe Mathieu-Daudé wrote: On 11/17/20 6:13 PM, Cornelia Huck wrote: > zPCI control blocks are big endian, we need to take

[Bug 1715203] Re: Maintain Haiku support

2020-11-17 Thread Thomas Huth
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=9fc33bf4e1d694225 ... the test suite is still failing, but at least we can compile test Haiku now. Thanks! ** Changed in: qemu Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of qemu- devel-

Re: [PATCH for-5.2] s390x/pci: fix endianness issues

2020-11-17 Thread Thomas Huth
On 17/11/2020 19.30, Philippe Mathieu-Daudé wrote: > On 11/17/20 7:19 PM, Matthew Rosato wrote: >> On 11/17/20 12:59 PM, Philippe Mathieu-Daudé wrote: >>> On 11/17/20 6:13 PM, Cornelia Huck wrote: zPCI control blocks are big endian, we need to take care that we do proper accesses in order

Re: [PATCH for-5.2] s390x/pci: fix endianness issues

2020-11-17 Thread Philippe Mathieu-Daudé
On 11/17/20 7:19 PM, Matthew Rosato wrote: > On 11/17/20 12:59 PM, Philippe Mathieu-Daudé wrote: >> On 11/17/20 6:13 PM, Cornelia Huck wrote: >>> zPCI control blocks are big endian, we need to take care that we >>> do proper accesses in order not to break tcg guests on little endian >>> hosts. >>>

Re: [RFC PATCH-for-5.2] hw/s390x/pci: Fix endianness issue

2020-11-17 Thread Thomas Huth
On 17/11/2020 15.34, Matthew Rosato wrote: > On 11/17/20 9:13 AM, Cornelia Huck wrote: >> On Tue, 17 Nov 2020 09:02:37 -0500 >> Matthew Rosato wrote: >> >>> On 11/17/20 8:31 AM, Cornelia Huck wrote: On Tue, 17 Nov 2020 14:23:57 +0100 Pierre Morel wrote:    > On 11/17/20 2:00 PM

Re: [PATCH for-5.2] s390x/pci: fix endianness issues

2020-11-17 Thread Matthew Rosato
On 11/17/20 12:59 PM, Philippe Mathieu-Daudé wrote: On 11/17/20 6:13 PM, Cornelia Huck wrote: zPCI control blocks are big endian, we need to take care that we do proper accesses in order not to break tcg guests on little endian hosts. Fixes: 28dc86a07299 ("s390x/pci: use a PCI Group structure")

Re: [PATCH v2 02/16] qapi/expr.py: Check for dict instead of OrderedDict

2020-11-17 Thread Eduardo Habkost
On Tue, Nov 17, 2020 at 05:30:04PM +0100, Markus Armbruster wrote: > John Snow writes: > > > OrderedDict is a subtype of dict, so we can check for a more general form. > > > > Signed-off-by: John Snow > > Reviewed-by: Eduardo Habkost > > Reviewed-by: Cleber Rosa > > --- > > scripts/qapi/expr.

Re: [PATCH for-5.2? 2/2] authz-simple: Check that 'identity' property is set

2020-11-17 Thread Philippe Mathieu-Daudé
On 11/17/20 5:30 PM, Kevin Wolf wrote: > If the 'identify' property is not set, we'll pass a NULL pointer to > g_str_equal() and crash. Catch the error condition during the creation > of the object. > > Signed-off-by: Kevin Wolf > --- > authz/simple.c | 14 ++ > 1 file changed, 14 in

Re: Regressions in build process introduced since August

2020-11-17 Thread Paolo Bonzini
On 17/11/20 18:50, Stefano Garzarella wrote: Running `configure [...] --extra-cflags="-I /xyz"` results in compiler flags `-I [...] /xyz`, so the `-I` and `/xyz` are separated by other compiler flags which obviously cannot work as expected. I could work around that by removing the space and using

Re: [PATCH for-5.2? 1/2] authz-pam: Check that 'service' property is set

2020-11-17 Thread Philippe Mathieu-Daudé
On 11/17/20 5:30 PM, Kevin Wolf wrote: > If the 'service' property is not set, we'll call pam_start() with a NULL > pointer for the service name. This fails and leaves a message like this > in the syslog: > > qemu-storage-daemon[294015]: PAM pam_start: invalid argument: service == NULL > > Make s

Re: [PATCH for-5.2] s390x/pci: fix endianness issues

2020-11-17 Thread Philippe Mathieu-Daudé
On 11/17/20 6:13 PM, Cornelia Huck wrote: > zPCI control blocks are big endian, we need to take care that we > do proper accesses in order not to break tcg guests on little endian > hosts. > > Fixes: 28dc86a07299 ("s390x/pci: use a PCI Group structure") > Fixes: 9670ee752727 ("s390x/pci: use a PCI

Re: [PATCH v1 2/6] tests: add prefixes to the bare mkdtemp calls

2020-11-17 Thread Philippe Mathieu-Daudé
On 11/17/20 6:36 PM, Alex Bennée wrote: > The first step to debug a thing is to know what created the thing in > the first place. Add some prefixes so random tmpdir's have something > grep in the code. > > Signed-off-by: Alex Bennée > > --- > v2 > - fix long lines > --- > python/qemu/machine.

Re: Regressions in build process introduced since August

2020-11-17 Thread Stefano Garzarella
CCing Paolo and Marc-André who worked on meson integrations. On Sun, Nov 15, 2020 at 11:57:25AM +0100, Stefan Weil wrote: Dear all, yesterday I tried to build new QEMU installers for Windows and noticed two regressions which break my build process: *** Change in handling of --extra-cflags

[PATCH v1 4/6] gitlab: move remaining x86 check-tcg targets to gitlab

2020-11-17 Thread Alex Bennée
The GCC check-tcg (user) test in particular was very prone to timing out on Travis. We only actually need to move the some-softmmu builds across as we already have coverage for linux-user. As --enable-debug-tcg does increase the run time somewhat as more debug is put in let's restrict that to just

[PATCH v1 3/6] tests/avocado: clean-up socket directory after run

2020-11-17 Thread Alex Bennée
Previously we were leaving temporary directories behind. While the QEMUMachine does make efforts to clean up after itself the directory belongs to the calling function. We use TemporaryDirectory to wrap this although we explicitly clear the reference in tearDown() as it doesn't get cleaned up other

[PATCH v1 5/6] tests/docker: Install liblttng-ust-dev package in Ubuntu 20.04 image

2020-11-17 Thread Alex Bennée
From: Philippe Mathieu-Daudé Install the liblttng-ust-dev package to be able to build QEMU using the User-Space Tracer trace backend (configure --enable-trace-backends=ust). Suggested-by: Wainer dos Santos Moschetta Signed-off-by: Philippe Mathieu-Daudé Message-Id: <2020121234.3246812-2-ph

[PATCH v1 1/6] scripts/ci: clean up default args logic a little

2020-11-17 Thread Alex Bennée
This allows us to do: ./scripts/ci/gitlab-pipeline-status -w -b HEAD -p 2961854 to check out own pipeline status of a recently pushed branch. Signed-off-by: Alex Bennée --- scripts/ci/gitlab-pipeline-status | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) dif

[PATCH v1 2/6] tests: add prefixes to the bare mkdtemp calls

2020-11-17 Thread Alex Bennée
The first step to debug a thing is to know what created the thing in the first place. Add some prefixes so random tmpdir's have something grep in the code. Signed-off-by: Alex Bennée --- v2 - fix long lines --- python/qemu/machine.py| 3 ++- tests/acceptance/avocado_qemu/_

[PATCH for 5.3-rc3 v1 0/6] testing fixes (avocado, gitlab)

2020-11-17 Thread Alex Bennée
Hi, Here are a few more minor fixes for 5.2-rc3: - a tweak to the gitlab status script (from last series) - moving check-tcg to gitlab (also in last series) - fix some tempdir names and left overs - moving some more tests to gitlab The following need review: - gitlab: move remaining x

[PATCH v1 6/6] gitlab-ci: Move trace backend tests across to gitlab

2020-11-17 Thread Alex Bennée
From: Philippe Mathieu-Daudé Similarly to commit 8cdb2cef3f1, move the trace backend tests to GitLab. Note the User-Space Tracer backend is still tested on Ubuntu by the s390x jobs on Travis-CI. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <2020121234.3246812-3-phi...@redhat.com> Sign

Re: [PATCH v3 00/41] Mirror map JIT memory for TCG

2020-11-17 Thread Alex Bennée
Joelle van Dyne writes: > Sorry, are you asking for a review from me? I don’t know if I’m > qualified to review the other patches but I did review the iOS patch. Anyone can review code and given you wrote the original patches you certainly know enough about the flow to give some opinion. If th

Re: [PATCH V13 2/9] meson.build: Re-enable KVM support for MIPS

2020-11-17 Thread Philippe Mathieu-Daudé
Hi Huacai, On 10/7/20 10:39 AM, Huacai Chen wrote: > After converting from configure to meson, KVM support is lost for MIPS, > so re-enable it in meson.build. > > Fixes: fdb75aeff7c212e1afaaa3a43 ("configure: remove target configuration") > Fixes: 8a19980e3fc42239aae054bc9 ("configure: move accel

Re: [PATCH v2 4/8] qnum: qnum_value_is_equal() function

2020-11-17 Thread Eduardo Habkost
On Tue, Nov 17, 2020 at 08:53:19PM +0400, Marc-André Lureau wrote: > On Tue, Nov 17, 2020 at 7:49 PM Eduardo Habkost wrote: > > > On Tue, Nov 17, 2020 at 12:42:47PM +0400, Marc-André Lureau wrote: > > > On Tue, Nov 17, 2020 at 2:42 AM Eduardo Habkost > > wrote: > > > > > > > Extract the QNum val

[PATCH for-5.2] s390x/pci: fix endianness issues

2020-11-17 Thread Cornelia Huck
zPCI control blocks are big endian, we need to take care that we do proper accesses in order not to break tcg guests on little endian hosts. Fixes: 28dc86a07299 ("s390x/pci: use a PCI Group structure") Fixes: 9670ee752727 ("s390x/pci: use a PCI Function structure") Fixes: 1e7552ff5c34 ("s390x/pci:

Re: Use of g_return_if_fail(), g_return_val_if_fail()

2020-11-17 Thread Stefan Hajnoczi
On Tue, Nov 17, 2020 at 04:14:38PM +0100, Markus Armbruster wrote: > * block/export/vhost-user-blk-server.c:270:g_return_val_if_fail(len <= > sizeof(struct virtio_blk_config), -1); > > Stefan, why is len > sizeof(struct virtio_blk_config) a programming > error? > > Why is returning saf

Re: [PATCH-for-5.2? v5 0/2] ci: Move trace backend tests across to gitlab

2020-11-17 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Extracted from "ci: Move various jobs from Travis to GitLab CI": > https://www.mail-archive.com/qemu-devel@nongnu.org/msg758314.html Queued to for-5.2/fixes-for-rc3, thanks. > > v5: > - addressed Wainer's review comment > > Philippe Mathieu-Daudé (2): > test

Re: [PATCH v6] hw/i386/pc: add max combined fw size as machine configuration option

2020-11-17 Thread Michael S. Tsirkin
On Fri, Sep 25, 2020 at 05:57:51PM +, Erich Mcmillan wrote: > From: Erich McMillan > > At Hewlett Packard Inc. we have a need for increased fw size to enable > testing of our custom fw. > Move return statement for early return > > Signed-off-by: Erich McMillan My bad that I dropped it by

[PATCH 26/29] Revert "kernel-doc: Handle function typedefs that return pointers"

2020-11-17 Thread Paolo Bonzini
This reverts commit 19ab6044be0c55d529e875e3ee16fdd5c3b54d33. We will replace the commit with the fix from Linux. Signed-off-by: Paolo Bonzini --- scripts/kernel-doc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/kernel-doc b/scripts/kernel-doc index 780aee4e92..

[PATCH 29/29] scripts: kernel-doc: use :c:union when needed

2020-11-17 Thread Paolo Bonzini
From: Mauro Carvalho Chehab Sphinx C domain code after 3.2.1 will start complaning if :c:struct would be used for an union type: .../Documentation/gpu/drm-kms-helpers:352: ../drivers/video/hdmi.c:851: WARNING: C 'identifier' cross-reference uses wrong tag: reference name is 'union hdmi

[PATCH 22/29] scripts: kernel-doc: allow passing desired Sphinx C domain dialect

2020-11-17 Thread Paolo Bonzini
From: Mauro Carvalho Chehab When kernel-doc is called via kerneldoc.py, there's no need to auto-detect the Sphinx version, as the Sphinx module already knows it. So, add an optional parameter to allow changing the Sphinx dialect. As kernel-doc can also be manually called, keep the auto-detection

[PATCH 21/29] scripts: kernel-doc: don't mangle with parameter list

2020-11-17 Thread Paolo Bonzini
From: Mauro Carvalho Chehab While kernel-doc needs to parse parameters in order to identify its name, it shouldn't be touching the type, as parsing it is very difficult, and errors happen. One current error is when parsing this parameter: const u32 (*tab)[256] Found at ./lib/crc32.c, o

[PATCH 20/29] scripts: kernel-doc: fix typedef identification

2020-11-17 Thread Paolo Bonzini
From: Mauro Carvalho Chehab Some typedef expressions are output as normal functions. As we need to be clearer about the type with Sphinx 3.x, detect such cases. While here, fix a wrongly-indented block. Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Paolo Bonzini --- scripts/kernel-doc

[PATCH 17/29] scripts: kernel-doc: use a less pedantic markup for funcs on Sphinx 3.x

2020-11-17 Thread Paolo Bonzini
From: Mauro Carvalho Chehab Unfortunately, Sphinx 3.x parser for c functions is too pedantic: https://github.com/sphinx-doc/sphinx/issues/8241 While it could be relaxed with some configurations, there are several corner cases that it would make it hard to maintain, and will require teac

[PATCH 25/29] Revert "kernel-doc: Handle function typedefs without asterisks"

2020-11-17 Thread Paolo Bonzini
This reverts commit 3cd3c5193cde5242e243c25759f85802e267994f. We will replace the commit with the fix from Linux. Signed-off-by: Paolo Bonzini --- scripts/kernel-doc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/kernel-doc b/scripts/kernel-doc index 2d56c46933..780a

[PATCH 18/29] scripts: kernel-doc: fix troubles with line counts

2020-11-17 Thread Paolo Bonzini
From: Mauro Carvalho Chehab There's currently a bug with the way kernel-doc script counts line numbers that can be seen with: $ ./scripts/kernel-doc -rst -enable-lineno include/linux/math64.h >all && ./scripts/kernel-doc -rst -internal -enable-lineno include/linux/math64.h >int && dif

[PATCH 24/29] scripts: kernel-doc: try to use c:function if possible

2020-11-17 Thread Paolo Bonzini
From: Mauro Carvalho Chehab There are a few namespace clashes by using c:macro everywhere: basically, when using it, we can't have something like: .. c:struct:: pwm_capture .. c:macro:: pwm_capture So, we need to use, instead: .. c:function:: int pwm_capture (struct p

[PATCH 14/29] Revert "scripts/kerneldoc: For Sphinx 3 use c:macro for macros with arguments"

2020-11-17 Thread Paolo Bonzini
This reverts commit 92bb29f9b2c3d4a98eef5f0db935d4be291eec72. We will replace the commit with the fix from Linux. Signed-off-by: Paolo Bonzini --- scripts/kernel-doc | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/scripts/kernel-doc b/scripts/kernel-doc ind

[PATCH 28/29] scripts: kernel-doc: split typedef complex regex

2020-11-17 Thread Paolo Bonzini
From: Mauro Carvalho Chehab The typedef regex for function prototypes are very complex. Split them into 3 separate regex and then join them using qr. Signed-off-by: Mauro Carvalho Chehab Link: https://lore.kernel.org/r/3a4af999a0d62d4ab9dfae1cdefdfcad93383356.1603792384.git.mchehab+hua...@kern

[PATCH 16/29] scripts: kernel-doc: make it more compatible with Sphinx 3.x

2020-11-17 Thread Paolo Bonzini
From: Mauro Carvalho Chehab With Sphinx 3.x, the ".. c:type:" tag was changed to accept either: .. c:type:: typedef-like declaration .. c:type:: name Using it for other types (including functions) don't work anymore. So, there are newer tags for macro, enum, struct, union, and

[PATCH 15/29] Revert "kernel-doc: Use c:struct for Sphinx 3.0 and later"

2020-11-17 Thread Paolo Bonzini
This reverts commit 152d1967f650f67b7ece3a5dda77d48069d72647. We will replace the commit with the fix from Linux. Signed-off-by: Paolo Bonzini --- docs/sphinx/kerneldoc.py | 1 - scripts/kernel-doc | 16 +--- 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/docs/

[PATCH 11/29] kernel-doc: include line numbers for function prototypes

2020-11-17 Thread Paolo Bonzini
From: Mauro Carvalho Chehab This should solve bad error reports like this one: ./include/linux/iio/iio.h:0: WARNING: Unknown target name: "devm". Signed-off-by: Mauro Carvalho Chehab Link: https://lore.kernel.org/r/56eed0ba50cd726236acd12b11b55ce54854c5ea.1599660067.git.mchehab+hua...

[PATCH 27/29] scripts: kernel-doc: fix typedef parsing

2020-11-17 Thread Paolo Bonzini
From: Mauro Carvalho Chehab The include/linux/genalloc.h file defined this typedef: typedef unsigned long (*genpool_algo_t)(unsigned long *map,unsigned long size,unsigned long start,unsigned int nr,void *data, struct gen_pool *pool, unsigned long start_addr); Because it has a type com

[PATCH 12/29] kernel-doc: add support for ____cacheline_aligned attribute

2020-11-17 Thread Paolo Bonzini
From: Jonathan Cameron Subroutine dump_struct uses type attributes to check if the struct syntax is valid. Then, it removes all attributes before using it for output. `cacheline_aligned` is an attribute that is not included in both steps. Add it, since it is used by kernel structs. Based on

  1   2   3   4   >