Re: [PATCH v13 0/4] Add Versal usb model

On 11/10/20 7:52 AM, Sai Pavan Boddu wrote: > This patch series attempts to make 'hcd-xhci' an independent model so it can > be used by both pci and system-bus interface. This part got merged already...

Re: [PATCH-for-5.2 v3] configure: Check vhost-user is available for vhost-user-blk-server

On 11/10/20 4:15 AM, Thomas Huth wrote: > On 09/11/2020 20.15, Philippe Mathieu-Daudé wrote: >> On 11/9/20 7:52 PM, Philippe Mathieu-Daudé wrote: >>> On 11/9/20 7:44 PM, Thomas Huth wrote: On 09/11/2020 19.41, Philippe Mathieu-Daudé wrote: > On Mon, Nov 9, 2020 at 6:22 PM Thomas Huth wrot

Re: nbd: bitmap_to_extents() calls nbd_extent_array_add() without checking return value: coverity false positive?

09.11.2020 18:22, Eric Blake wrote: On 11/9/20 1:17 AM, Vladimir Sementsov-Ogievskiy wrote: 07.11.2020 01:53, Peter Maydell wrote: On Fri, 6 Nov 2020 at 20:36, Eric Blake wrote: On 11/6/20 11:22 AM, Peter Maydell wrote: Hi; Coverity's "you usually check the return value of this function but

[PATCH v13 4/4] arm: xlnx-versal: Connect usb to virt-versal

From: Vikram Garhwal Connect VersalUbs2 subsystem to xlnx-versal SOC, its placed in iou of lpd domain and configure it as dual port host controller. Add the respective guest dts nodes for "xlnx-versal-virt" machine. Signed-off-by: Vikram Garhwal Signed-off-by: Sai Pavan Boddu --- hw/arm/xlnx-

[PATCH v13 0/4] Add Versal usb model

This patch series attempts to make 'hcd-xhci' an independent model so it can be used by both pci and system-bus interface. Changes for V2: Make XHCIState non-qom Use container_of functions for retriving pci device instance Initialize the AddressSpace pointer in PATCH 1/3 itself Change

Re: [PATCH for-5.2 3/3] linux-user/sparc: Don't zero high half of PC, NPC, PSR in sigreturn

Le 05/11/2020 à 22:23, Peter Maydell a écrit : > The function do_sigreturn() tries to store the PC, NPC and PSR in > uint32_t local variables, which implicitly drops the high half of > these fields for 64-bit guests. > > The usual effect was that a guest which used signals would crash on > return

Re: [PATCH for-5.2 2/3] linux-user/sparc: Correct set/get_context handling of fp and i7

Le 05/11/2020 à 22:23, Peter Maydell a écrit : > Because QEMU's user-mode emulation just directly accesses guest CPU > state, for SPARC the guest register window state is not the same in > the sparc64_get_context() and sparc64_set_context() functions as it > is for the real kernel's versions of tho

Re: [PATCH for-5.2 1/3] linux-user/sparc: Fix errors in target_ucontext structures

Le 05/11/2020 à 22:23, Peter Maydell a écrit : > The various structs that make up the SPARC target_ucontext had some > errors: > * target structures must not include fields which are host pointers, >which might be the wrong size. These should be abi_ulong instead > * because we don't have th

[PATCH v13 3/4] usb: xlnx-usb-subsystem: Add xilinx usb subsystem

This model is a top level integration wrapper for hcd-dwc3 and versal-usb2-ctrl-regs modules, this is used by xilinx versal soc's and future xilinx usb subsystems would also be part of it. Signed-off-by: Sai Pavan Boddu --- hw/usb/meson.build | 1 + hw/usb/xlnx-usb-subsystem.c

[PATCH v13 2/4] usb: Add DWC3 model

From: Vikram Garhwal This patch adds skeleton model of dwc3 usb controller attached to xhci-sysbus device. It defines global register space of DWC3 controller, global registers control the AXI/AHB interfaces properties, external FIFO support and event count support. All of which are unimplemented

[PATCH v13 1/4] usb: Add versal-usb2-ctrl-regs module

This module emulates control registers of versal usb2 controller, this is added just to make guest happy. In general this module would control the phy-reset signal from usb controller, data coherency of the transactions, signals the host system errors received from controller. Signed-off-by: Sai P

[PATCH 2/2] virtiofsd: check whether lo_map_reserve returns NULL in main func

In main func, func lo_map_reserve is called without NULL check. If reallocing new_elems fails in func lo_map_grow, the func lo_map_reserve may return NULL. We should check whether lo_map_reserve returns NULL before using it. Signed-off-by: Haotian Li Signed-off-by: Zhiqiang Liu --- tools/virtio

[PATCH 1/2] tools/virtiofsd/buffer.c: check whether buf is NULL in fuse_bufvec_advance func

In fuse_bufvec_advance func, calling fuse_bufvec_current func may return NULL, so we should check whether buf is NULL before using it. Signed-off-by: Haotian Li Signed-off-by: Zhiqiang Liu --- tools/virtiofsd/buffer.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/virtiofsd/buffe

[PATCH v2 0/2] virtiofsd: fix some accessing NULL pointer problem

Haotian Li (2): tools/virtiofsd/buffer.c: check whether buf is NULL in fuse_bufvec_advance func virtiofsd/passthrough_ll.c: check whether lo_map_reserve returns NULL in main func tools/virtiofsd/buffer.c | 4 tools/virtiofsd/passthrough_ll.c | 10 +- 2 files chan

Re: QMP and the 'id' parameter

John Snow writes: > The QMP specification states: > >> NOTE: Some errors can occur before the Server is able to read the "id" >> member, in these cases the "id" member will not be part of the error >> response, even if provided by the client. > > I am assuming this case ONLY occurs for Parse erro

[PATCH 3/4] block/throttle-groups.c: Use lock guard macros

Replace manual lock()/unlock() calls with lock guard macros (QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD) in block/throttle-groups.c. Signed-off-by: Gan Qixin --- block/throttle-groups.c | 48 - 1 file changed, 23 insertions(+), 25 deletions(-) diff --git a/bloc

[PATCH 2/4] block/curl.c: Use lock guard macros

Replace manual lock()/unlock() calls with lock guard macros (QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD) in block/curl.c. Signed-off-by: Gan Qixin --- block/curl.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/block/curl.c b/block/curl.c index 4f907

[PATCH 1/4] block/accounting.c: Use lock guard macros

Replace manual lock()/unlock() calls with lock guard macros (QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD) in block/accounting.c. Signed-off-by: Gan Qixin --- block/accounting.c | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/block/accounting.c b/bl

[PATCH 4/4] block/iscsi.c: Use lock guard macros

Replace manual lock()/unlock() calls with lock guard macros (QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD) in block/iscsi.c. Signed-off-by: Gan Qixin --- block/iscsi.c | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index e

[PATCH 0/4] Use lock guard macros in block

Hi all, I saw some tasks to replace manual lock()/unlock() calls with lock guard macros in BiteSizedTasks. I am very interested in this and modified some of the files under block. Could someone help me check the code? Thanks, Gan Qixin Gan Qixin (4): block/accounting.c: Use lock guard macro

Re: [PATCH 0/2] virtiofsd: fix some accessing NULL pointer problem

Hi, Thanks for your suggestion. We will fix the coding style problems and resend new patches. > Patchew URL: > https://patchew.org/QEMU/eeb2fd1d-a53d-eae6-4727-7f1a6b20a...@huawei.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more informatio

Re: [PATCH 1/4] semihosting: Move ARM semihosting code to shared directories [v3]

Alistair Francis writes: > Reviewed-by: Alistair Francis Thanks much. I think we'll need some help getting the next two patches reviewed; that touches ARM code. The last patch is also RISC-V only. -- -keith signature.asc Description: PGP signature

Re: [PULL 0/6] riscv-to-apply queue

; > are available in the Git repository at: > > g...@github.com:alistair23/qemu.git tags/pull-riscv-to-apply-20201109 > > for you to fetch changes up to 96338fefc19a143abdc91f6c44f37683274b08d4: > > hw/intc/ibex_plic: Clear the claim

Re: [RFC v5 00/68] support vector extension v1.0

On Mon, Nov 9, 2020 at 6:09 PM Frank Chang wrote: > > ping 2nd~ I mentioned earlier that I will wait until this becomes a patch series to review it. Overall it looks like it's on the right track though. Alistair > > On Tue, Oct 20, 2020 at 3:42 PM Frank Chang wrote: >> >> On Wed, Sep 30, 2020

[PULL 6/6] hw/intc/ibex_plic: Clear the claim register when read

After claiming the interrupt by reading the claim register we want to clear the register to make sure the interrupt doesn't appear at the next read. This matches the documentation for the claim register as when an interrupt is claimed by a target the relevant bit of IP is cleared (which we already

[PULL 5/6] target/riscv: Split the Hypervisor execute load helpers

Split the hypervisor execute load functions into two seperate functions. This avoids us having to pass the memop to the C helper functions. Signed-off-by: Alistair Francis Reviewed-by: Richard Henderson Message-id: 5b1550f0faa3c435cc77f3c1ae811dea98ab9e36.1604464950.git.alistair.fran...@wdc.com

[PULL 3/6] target/riscv: Remove the HS_TWO_STAGE flag

The HS_TWO_STAGE flag is no longer required as the MMU index contains the information if we are performing a two stage access. Signed-off-by: Alistair Francis Reviewed-by: Richard Henderson Message-id: f514b128b1ff0fb41c85f914cee18f905007a922.1604464950.git.alistair.fran...@wdc.com --- target/

[PULL 2/6] target/riscv: Set the virtualised MMU mode when doing hyp accesses

When performing the hypervisor load/store operations set the MMU mode to indicate that we are virtualised. Signed-off-by: Alistair Francis Reviewed-by: Richard Henderson Message-id: e411c61a1452cad16853f13cac2fb86dc91ebee8.1604464950.git.alistair.fran...@wdc.com --- target/riscv/op_helper.c |

[PULL 0/6] riscv-to-apply queue

l-riscv-to-apply-20201109 for you to fetch changes up to 96338fefc19a143abdc91f6c44f37683274b08d4: hw/intc/ibex_plic: Clear the claim register when read (2020-11-09 15:09:53 -0800) This fixes two bugs in the RISC-V port. One is a

[PULL 4/6] target/riscv: Remove the hyp load and store functions

Remove the special Virtulisation load and store functions and just use the standard tcg tcg_gen_qemu_ld_tl() and tcg_gen_qemu_st_tl() functions instead. As part of this change we ensure we still run an access check to make sure we can perform the operations. Signed-off-by: Alistair Francis Revie

[PULL 1/6] target/riscv: Add a virtualised MMU Mode

Add a new MMU mode that includes the current virt mode. Signed-off-by: Alistair Francis Reviewed-by: Richard Henderson Message-id: 4b301bc0ea36da962fc1605371b65019ac3073df.1604464950.git.alistair.fran...@wdc.com --- target/riscv/cpu-param.h | 11 ++- target/riscv/cpu.h| 4 +++

Re: [PATCH 2/5 v4] KVM: SVM: Fill in conforming svm_x86_ops via macro

Hi Krish, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.10-rc3 next-20201109] [cannot apply to vhost/linux-next kvmarm/next kvm/linux-next kvms390/next] [If your patch is applied to the wrong git tree, kindly drop

Re: [PATCH] target/arm/translate-neon.c: Handle VTBL UNDEF case before VFP access check

On 11/9/20 6:53 AM, Peter Maydell wrote: > Checks for UNDEF cases should go before the "is VFP enabled?" access > check, except in special cases. Move a stray UNDEF check in the VTBL > trans function up above the access check. > > Signed-off-by: Peter Maydell > --- > Based-on: 20201105171126.8801

[Bug 1673957] Re: virtfs: mapped-xattr on mount point

Thanks for your answer! ... since this is not reproducible anymore, I'm closing the ticket now. ** Changed in: qemu Status: Incomplete => Won't Fix -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bug

[Bug 1671677] Re: vfio-pci passthrough issue after resume from suspend

Thanks for your answer, and sorry that nobody replied to your original report - sometimes there is just no expert around, or nobody has a clue about the right answer... anyway, let's close this ticket now. ** Changed in: qemu Status: Incomplete => Won't Fix -- You received this bug notifi

Re: [PATCH] ppc/translate: Fix unordered f64/f128 comparisons

On 11/9/20 2:21 AM, LemonBoy wrote: > According to the PowerISA v3.1 reference, Table 68 "Actions for xscmpudp > - Part 1: Compare Unordered", whenever one of the two operands is a NaN > the SO bit is set while the other three bits are cleared. > > Apply the same change to xscmpuqp. > > The respe

[Bug 1719339] Re: serial8250: too much work for irq3

The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

[Bug 1728256] Re: Memory corruption in Windows 10 guest / amd64

*** This bug is a duplicate of bug 1738972 *** https://bugs.launchpad.net/bugs/1738972 ** This bug has been marked a duplicate of bug 1738972 [A] KVM Windows BSOD on 4.13.x -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https

[Bug 1723731] Re: Qemu turns to black screen while starting to copy installation files of Windows 7

The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

[Bug 1728325] Re: POWER8: Wrong behaviour with float-to-int punning

The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

[Bug 1725707] Re: QEMU sends excess VNC data to websockify even when network is poor

The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

[Bug 1728635] Re: qemu-io crashes with SIGSEGV when did -c aio_write 9233408 28160 on a image_fuzzer image

The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

[Bug 1731277] Re: Provide target specific qemu man pages

** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1731277 Title: Provide target specific qemu man pages Status in QEMU: New Bug description:

[Bug 1731347] Re: VFIO Passthrough of SAS2008-based HBA card fails on E3-1225v3 due to failed DMA mapping (-14)

The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

Re: [PATCH-for-5.2 v3] configure: Check vhost-user is available for vhost-user-blk-server

On 09/11/2020 20.15, Philippe Mathieu-Daudé wrote: > On 11/9/20 7:52 PM, Philippe Mathieu-Daudé wrote: >> On 11/9/20 7:44 PM, Thomas Huth wrote: >>> On 09/11/2020 19.41, Philippe Mathieu-Daudé wrote: On Mon, Nov 9, 2020 at 6:22 PM Thomas Huth wrote: > On 09/11/2020 15.07, Philippe Mathieu

Re: [PATCH v3 0/3] tcg-cpus: split into 3 tcg variants

On 11/9/20 8:02 AM, Claudio Fontana wrote: > On 10/19/20 5:00 PM, Richard Henderson wrote: >> On 10/15/20 7:32 AM, Claudio Fontana wrote: >>> Claudio Fontana (3): >>> accel/tcg: split CpusAccel into three TCG variants >>> accel/tcg: split tcg_start_vcpu_thread >>> accel/tcg: rename tcg-cpus f

Re: [PATCH] pvpanic: Advertise the PVPANIC_CRASHLOADED event support

(CC Maciej) Hi Paolo, Thank you for fixing the patch. One comment below.. On 11/9/2020 9:33 AM, Paolo Bonzini wrote: Advertise both types of events as supported when the guest OS queries the pvpanic device. Currently only PVPANIC_PANICKED is exposed; PVPANIC_CRASHLOADED must also be advertise

Re: [RFC PATCH 0/6] eBPF RSS support for virtio-net

On 2020/11/9 下午9:33, Yuri Benditovich wrote: On Mon, Nov 9, 2020 at 4:14 AM Jason Wang > wrote: On 2020/11/5 下午11:13, Yuri Benditovich wrote: > First of all, thank you for all your feedbacks > > Please help me to summarize and let us understand b

Re: [RFC v5 00/68] support vector extension v1.0

ping 2nd~ On Tue, Oct 20, 2020 at 3:42 PM Frank Chang wrote: > On Wed, Sep 30, 2020 at 3:04 AM wrote: > >> From: Frank Chang >> >> This patchset implements the vector extension v1.0 for RISC-V on QEMU. >> >> This patchset is sent as RFC because RVV v1.0 is still in draft state. >> v2 patchset

Re: [RFC PATCH 1/6] migration: Add multi-thread compress method

On 2020/11/9 23:57, Eric Blake wrote: > On 11/9/20 3:08 AM, Zeyu Jin wrote: >> A multi-thread compress method parameter is added to hold the method we >> are going to use. By default the 'zlib' method is used to maintain the >> compatibility as before. >> >> Signed-off-by: Zeyu Jin >> Signed-off-b

Re: [PATCH for-5.2] vhost-user: fix VHOST_USER_ADD/REM_MEM_REG truncation

On Mon, Nov 9, 2020 at 12:59 PM Stefan Hajnoczi wrote: > > QEMU currently truncates the mmap_offset field when sending > VHOST_USER_ADD_MEM_REG and VHOST_USER_REM_MEM_REG messages. The struct > layout looks like this: > > typedef struct VhostUserMemoryRegion { > uint64_t guest_phys_addr; >

Re: [PATCH 4/5 v4] KVM: VMX: Fill in conforming vmx_x86_ops via macro

Hi Krish, On 2020/11/10 9:23, Krish Sadhukhan wrote: @@ -1192,7 +1192,7 @@ void vmx_set_host_fs_gs(struct vmcs_host_state *host, u16 fs_sel, u16 gs_sel, } } -void vmx_prepare_switch_to_guest(struct kvm_vcpu *vcpu) +void vmx_prepare_guest_switch(struct kvm_vcpu *vcpu) What do you

QMP and the 'id' parameter

The QMP specification states: > NOTE: Some errors can occur before the Server is able to read the "id" > member, in these cases the "id" member will not be part of the error > response, even if provided by the client. I am assuming this case ONLY occurs for Parse errors: {'class': 'GenericError

Re: Question on UEFI ACPI tables setup and probing on arm64

On 11/7/2020 1:09 AM, Laszlo Ersek wrote: On 11/05/20 05:30, Ying Fang wrote: I see it in Qemu the *loader_start* is fixed at 1 GiB on the physical address space which points to the DRAM base. In ArmVirtQemu.dsc PcdDeviceTreeInitialBaseAddress is set 0x4000 with correspondence. Here I a

[Bug 1902470] Re: migration with TLS-MultiFD is stuck when the dst-libvirtd service restarts

this commit is sent and may fix this issue, waiting for review. https://www.mail-archive.com/qemu-devel@nongnu.org/msg758017.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1902470 Title: migrat

Re: [PATCH v2] migration/multifd: close TLS channel before socket finalize

Kindly ping. Maybe this bugfix is need for qemu-5.2 version. On 2020/11/6 18:54, Chuan Zheng wrote: > Since we now support tls multifd, when we cancel migration, the TLS > sockets will be left as CLOSE-WAIT On Src which results in socket > leak. > Fix it by closing TLS channel before socket finali

[PATCH 3/5 v4] KVM: nSVM: Fill in conforming svm_nested_ops via macro

The names of the nested_svm_ops functions do not have a corresponding 'nested_svm_' prefix. Generate the names using a macro so that the names are conformant. Fixing the naming will help in better readability and maintenance of the code. Suggested-by: Vitaly Kuznetsov Suggested-by: Paolo Bonzini

[PATCH 2/5 v4] KVM: SVM: Fill in conforming svm_x86_ops via macro

The names of some of the svm_x86_ops functions do not have a corresponding 'svm_' prefix. Generate the names using a macro so that the names are conformant. Fixing the naming will help in better readability and maintenance of the code. Suggested-by: Vitaly Kuznetsov Suggested-by: Paolo Bonzini S

[PATCH 1/5 v4] KVM: x86: Change names of some of the kvm_x86_ops functions to make them more semantical and readable

Suggested-by: Vitaly Kuznetsov Suggested-by: Paolo Bonzini Signed-off-by: Sean Christopherson Signed-off-by: Krish Sadhukhan --- arch/arm64/include/asm/kvm_host.h | 2 +- arch/mips/include/asm/kvm_host.h| 2 +- arch/powerpc/include/asm/kvm_host.h | 2 +- arch/s390/kvm/kvm-s390.c

[PATCH 4/5 v4] KVM: VMX: Fill in conforming vmx_x86_ops via macro

The names of some of the vmx_x86_ops functions do not have a corresponding 'vmx_' prefix. Generate the names using a macro so that the names are conformant. Fixing the naming will help in better readability and maintenance of the code. Suggested-by: Vitaly Kuznetsov Suggested-by: Paolo Bonzini S

[PATCH 5/5 v4] KVM: nVMX: Fill in conforming vmx_nested_ops via macro

The names of some of the vmx_nested_ops functions do not have a corresponding 'nested_vmx_' prefix. Generate the names using a macro so that the names are conformant. Fixing the naming will help in better readability and maintenance of the code. Suggested-by: Vitaly Kuznetsov Suggested-by: Paolo

[PATCH 0/5 v4] KVM: x86: Fill in conforming {vmx|svm}_x86_ops and {vmx|svm}_nested_ops via macros

v3 -> v4: 1. v3 did not include a few x86_ops and x86_nested_ops in the macro expansion process of function names. This set has covered all those left-out ops. 2. Patch# 6 from v3 has been dropped as those changes already exist in QEMU source. [PAT

Re: [PATCH-for-6.0 0/2] target/mips: CP0 housekeeping patches for Nov 2020

Reviewed-by: Huacai Chen On Tue, Nov 10, 2020 at 1:37 AM Richard Henderson wrote: > > On 11/9/20 1:04 AM, Philippe Mathieu-Daudé wrote: > > Based-on: <20201108234234.2389789-1-f4...@amsat.org> > > > > Philippe Mathieu-Daudé (2): > > target/mips: Replace magic values by CP0PM_MASK or > > TA

Re: [PATCH 0/2] virtiofsd: fix some accessing NULL pointer problem

Patchew URL: https://patchew.org/QEMU/eeb2fd1d-a53d-eae6-4727-7f1a6b20a...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: eeb2fd1d-a53d-eae6-4727-7f1a6b20a...@huawei.com Subject: [PATCH 0/2] virtiofsd: fix some accessin

[PATCH 2/2] virtiofsd: check whether lo_map_reserve returns NULL in main func

In main func, func lo_map_reserve is called without NULL check. If reallocing new_elems fails in func lo_map_grow, the func lo_map_reserve may return NULL. We should check whether lo_map_reserve returns NULL before using it. Signed-off-by: Haotian Li Signed-off-by: Zhiqiang Liu --- tools/virtio

[PATCH 1/2] tools/virtiofsd/buffer.c: check whether buf is NULL in fuse_bufvec_advance func

In fuse_bufvec_advance func, calling fuse_bufvec_current func may return NULL, so we should check whether buf is NULL before using it. Signed-off-by: Haotian Li Signed-off-by: Zhiqiang Liu --- tools/virtiofsd/buffer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/virtiofsd/buffer

[PATCH 0/2] virtiofsd: fix some accessing NULL pointer problem

Hi, We find some potential NULL pointer bugs on tools/virtiofsd. Two patches are made to fix them. Haotian Li (2): tools/virtiofsd/buffer.c: check whether buf is NULL in fuse_bufvec_advance func virtiofsd/passthrough_ll.c: check whether lo_map_reserve returns NULL in main func tool

RE: [PATCH] hw/intc: fix heap-buffer-overflow in rxicu_realize()

Ping, Fix: e78597cc457ff7611 Maybe this bug needs to qemu-5.2 version. The "icu->nr_sense" is array length. It's a typical out-of-bounds array bug. Thanks, Chen Qun > -Original Message- > From: Chenqun (kuhn) > Sent: Thursday, November 5, 2020 3:06 PM > To: qemu-devel@nongnu.org; qem

RE: [PATCH v3 1/3] hw/block/m25p80: Fix Numonyx NVCFG DIO and QIO bit polarity

Hi Philippe, -Original Message- From: Philippe Mathieu-Daudé Sent: Monday, November 9, 2020 6:21 AM To: Joe Komlodi ; qemu-devel@nongnu.org; Cédric Le Goater ; Edgar Iglesias Cc: Francisco Eduardo Iglesias ; alist...@alistair23.me; philippe.mathieu.da...@gmail.com; qemu-bl...@nongnu.o

Re: [PATCH v2 4/4] hw/riscv: Load the kernel after the firmware

On Thu, Nov 5, 2020 at 8:15 PM Anup Patel wrote: > > > > > -Original Message- > > From: Qemu-riscv > bounces+anup.patel=wdc@nongnu.org> On Behalf Of Palmer Dabbelt > > Sent: 06 November 2020 08:19 > > To: alistai...@gmail.com > > Cc: qemu-ri...@nongnu.org; bmeng...@gmail.com; Alistair

Re: [PATCH 1/4] semihosting: Move ARM semihosting code to shared directories [v3]

On Wed, Oct 28, 2020 at 11:57 AM Keith Packard via wrote: > > This commit renames two files which provide ARM semihosting support so > that they can be shared by other architectures: > > 1. target/arm/arm-semi.c -> hw/semihosting/common-semi.c > 2. linux-user/arm/semihost.c -> linux-user/sem

Re: [PATCH v1 1/1] hw/intc/ibex_plic: Clear the claim register when read

On Fri, Nov 6, 2020 at 6:20 AM Philippe Mathieu-Daudé wrote: > > On 11/6/20 3:32 AM, Alistair Francis wrote: > > After claiming the interrupt by reading the claim register we want to > > clear the register to make sure the interrupt doesn't appear at the next > > read. > > > > This matches the doc

[Bug 1734474] Re: Maemo does not boot on emulated N800

This change on current head-of-git, which is effectively just reverting the logic-change part of commit cb5ef3fa1871522a08, is sufficient to allow the n800 image to boot again. But that commit was trying to fix a bug, so we probably need to look more carefully at the logic rather than just reve

[Bug 1734474] Re: Maemo does not boot on emulated N800

Bisection thinks commit cb5ef3fa1871522a08 is the cause. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1734474 Title: Maemo does not boot on emulated N800 Status in QEMU: Confirmed Bug descript

[Bug 1734474] Re: Maemo does not boot on emulated N800

Thanks. I can confirm that there's been a regression since 1.2.0 that's still not fixed in master. ** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1

[RFC 2/2] docs: Build and install all the docs in a single manual

When we first converted our documentation to Sphinx, we split it into multiple manuals (system, interop, tools, etc), which are all built separately. The primary driver for this was wanting to be able to avoid shipping the 'devel' manual to end-users. However, this is working against the grain of

[RFC 0/2] Build a single Sphinx manual, not five

When we first converted our documentation to Sphinx, we split it into multiple manuals (system, interop, tools, etc), which are all built separately. The primary driver for this was wanting to be able to avoid shipping the 'devel' manual to end-users. However, this is working against the grain of

[RFC 1/2] docs: Mark rst files in the top level directory as orphan

We have a handful of rst files currently in the top level docs directory. These need to be moved into their proper places in the new manual framework, possibly involving splitting them into multiple pieces. In the meantime, to avoid warnings about these documents being orphaned if you build a sing

Re: [PATCH v2 6/6] qemu-option: warn for short-form boolean options

Il lun 9 nov 2020, 22:19 Markus Armbruster ha scritto: > This function now warns, except for "help" and "?". The exception > applies even when we treat "help" and "?" as sugar for "help=on" and > "?=on" because opts_accepts_any(). > Right, because again help_wanted will be false for non-validat

Re: [PATCH 0/8] qom: Use qlit to represent property defaults

Patchew URL: https://patchew.org/QEMU/20201109212556.3934583-1-ehabk...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20201109212556.3934583-1-ehabk...@redhat.com Subject: [PATCH 0/8] qom: Use qlit to represent propert

[PATCH 8/8] qom: Use qlit to represent property defaults

Using QLitObject lets us get rid of most of the .set_default_value functions, and just use object_property_set_default() directly. Signed-off-by: Eduardo Habkost --- include/hw/qdev-properties-system.h | 2 +- include/qom/field-property-internal.h | 4 --- include/qom/field-property.h

[PATCH 7/8] qom: Make object_property_set_default() public

The function will be used outside qom/object.c, to simplify the field property code that sets the property default value. Signed-off-by: Eduardo Habkost --- include/qom/object.h | 11 +++ qom/object.c | 2 +- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/include

[PATCH 5/8] qlit: Support all types of QNums

Use QNumValue to represent QNums, so we can also support uint64_t and double QNum values. Add new QLIT_QNUM_(INT|UINT|DOUBLE) macros for each case. The QLIT_QNUM() macro is being kept for compatibility with existing code, but becomes just a wrapper for QLIT_QNUM_INT(). Signed-off-by: Eduardo Hab

[PATCH 6/8] qlit: qlit_type() function

Useful function where we need to check for the qlit type before converting it to an actual QObject. Signed-off-by: Eduardo Habkost --- include/qapi/qmp/qlit.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/qapi/qmp/qlit.h b/include/qapi/qmp/qlit.h index f9e356d31e..acddb80831 1

[PATCH 2/8] qnum: Make qnum_get_double() get const pointer

qnum_get_double() won't change the object, the argument can be const. Signed-off-by: Eduardo Habkost --- include/qapi/qmp/qnum.h | 2 +- qobject/qnum.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/qapi/qmp/qnum.h b/include/qapi/qmp/qnum.h index 25f4733e

[PATCH 1/8] qobject: Include API docs in docs/devel/qobject.html

Render existing doc comments at docs/devel/qobject.html. Signed-off-by: Eduardo Habkost --- docs/devel/index.rst | 1 + docs/devel/qobject.rst | 11 + include/qapi/qmp/qnum.h| 4 +++- include/qapi/qmp/qobject.h | 48 +- qobject/qnum.c

[PATCH 4/8] qnum: qnum_value_is_equal() function

Extract the QNum value comparison logic to a function that takes QNumValue* as argument. Signed-off-by: Eduardo Habkost --- include/qapi/qmp/qnum.h | 1 + qobject/qnum.c | 29 +++-- 2 files changed, 20 insertions(+), 10 deletions(-) diff --git a/include/qapi/qm

[PATCH 3/8] qnum: QNumValue type for QNum value literals

Provide a separate QNumValue type that can be used for QNum value literals without the referencing counting and memory allocation features provided by QObject. Signed-off-by: Eduardo Habkost --- include/qapi/qmp/qnum.h | 40 +++-- qobject/qnum.c | 78

[PATCH 0/8] qom: Use qlit to represent property defaults

Based-on: 20201104160021.2342108-1-ehabk...@redhat.com Git branch: https://gitlab.com/ehabkost/qemu/-/commits/work/qdev-qlit-defaults This extend qlit.h to support all QNum types (signed int, unsigned int, and double), and use QLitObject to represent field property defaults. It allows us to get r

[Bug 1706296] Re: Booting NT 4 disk causes /home/rjones/d/qemu/cpus.c:1580:qemu_mutex_lock_iothread: assertion failed: (!qemu_mutex_iothread_locked())

With the original repro command line, the guest now crashes "cleanly", ie without triggering a QEMU assert. If you give the guest a CPU type it recognizes, eg '-cpu pentium' (as noted in comment 7) then it boots OK, at least to the point of user control in the installer. So I think this is fixed.

Re: [PULL for-5.2 0/1] qemu-ga patch queue for hard-freeze

On Mon, 9 Nov 2020 at 20:18, Michael Roth wrote: > > The following changes since commit 3493c36f0371777c62d1d72b205b0eb6117e2156: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20201106' into > staging (2020-11-06 13:43:28 +) > > are available in the Git repository at: > > gi

Re: [PATCH v2 6/6] qemu-option: warn for short-form boolean options

Paolo Bonzini writes: > Options such as "server" or "nowait", that are commonly found in -chardev, > are sugar for "server=on" and "wait=off". This is quite surprising and > also does not have any notion of typing attached. It is even possible to > do "-device e1000,noid" and get a device with

Re: [PATCH-for-6.0 v4 05/17] gitlab-ci: Split CONFIGURE_ARGS one argument per line for build-disabled

On 11/8/20 6:45 PM, Philippe Mathieu-Daudé wrote: We will keep adding/removing options to our 'configure' script, so for easier maintainability it makes sense to have CONFIGURE_ARGS declared as one option per line. This way we can review diff easily (or rebase/cherry-pick). No logical change.

[PULL for-5.2 0/1] qemu-ga patch queue for hard-freeze

The following changes since commit 3493c36f0371777c62d1d72b205b0eb6117e2156: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20201106' into staging (2020-11-06 13:43:28 +) are available in the Git repository at: git://github.com/mdroth/qemu.git tags/qga-pull-2020-11-09-tag for

Re: [RFC PATCH for-QEMU-5.2] vfio: Make migration support experimental

On Mon, 9 Nov 2020 19:44:17 + "Dr. David Alan Gilbert" wrote: > * Alex Williamson (alex.william...@redhat.com) wrote: > > Per the proposed documentation for vfio device migration: > > > > Dirty pages are tracked when device is in stop-and-copy phase > > because if pages are marked dirty

Re: [PATCH v2 00/44] Make qdev static property API usable by any QOM type

On Mon, Nov 09, 2020 at 08:27:21PM +0100, Paolo Bonzini wrote: > On 09/11/20 19:55, Eduardo Habkost wrote: > > On Mon, Nov 09, 2020 at 06:33:04PM +0100, Paolo Bonzini wrote: > > > On 09/11/20 18:16, Eduardo Habkost wrote: > > > > I mean extending the API to let custom setters and getters appear > >

[PULL for-5.2 1/1] qga: fix missing closedir() in qmp_guest_get_disks()

We opendir("/sys/block") at the beginning of the function, but we never close it prior to returning. Fixes: Coverity CID 1436130 Fixes: fed3956429d5 ("qga: add implementation of guest-get-disks for Linux") Reported-by: Peter Maydell Cc: Marc-André Lureau Cc: Tomáš Golembiovský Reviewed-by: Phil

[Bug 1734474] Re: Maemo does not boot on emulated N800

It's available here: https://4pda.ru/forum/index.php?showtopic=870847 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1734474 Title: Maemo does not boot on emulated N800 Status in QEMU: New Bug d

Re: [PULL v2 00/15] Block patches for 5.2.0-rc1

On Mon, 9 Nov 2020 at 17:50, Max Reitz wrote: > > The following changes since commit 2a190a7256a3e0563b29ffd67e0164097b4a6dac: > > Merge remote-tracking branch > 'remotes/philmd-gitlab/tags/renesas-fixes-20201109' into staging (2020-11-09 > 11:20:25 +)

[Bug 1706296] Re: Booting NT 4 disk causes /home/rjones/d/qemu/cpus.c:1580:qemu_mutex_lock_iothread: assertion failed: (!qemu_mutex_iothread_locked())

commit 8b81253332b5a3f claims in its subject line that it "fixes #1706296", and it implements Paolo's option (2) from comment #4. So I'd go with "already fixed". The bug has a simple reproducer in the report though, so it's also easy to test... -- You received this bug notification because you ar

  1   2   3   4   >