Build virtio-gpu vga devices modular. Must be a separate module because
not all qemu softmmu variants come with VGA support.
Signed-off-by: Gerd Hoffmann
---
util/module.c | 3 +++
hw/display/meson.build | 10 --
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/
Hi David,
On Fri, Oct 23, 2020 at 6:49 AM David Gibson wrote:
> On Thu, 22 Oct 2020 11:01:04 -0400
> "Michael S. Tsirkin" wrote:
>
> > On Thu, Oct 22, 2020 at 05:50:51PM +0300, Marcel Apfelbaum wrote:
> > [...]
> >
> > Right. After detecting just failing unconditionally it a bit too
> > simpli
Build virtio-gpu pci devices modular. Must be a separate module because
not all qemu softmmu variants come with PCI support.
Signed-off-by: Gerd Hoffmann
---
util/module.c | 3 +++
hw/display/meson.build | 11 +--
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a
Gerd Hoffmann (2):
virtio-gpu: add virtio-gpu-pci module
virtio-gpu: add virtio-vga module
util/module.c | 6 ++
hw/display/meson.build | 21 +
2 files changed, 23 insertions(+), 4 deletions(-)
--
2.27.0
On 23/10/2020 08.12, Chen Qun wrote:
> Properly free each command resp to avoid memory leak.
> ASAN shows memory leak stack:
>
> Indirect leak of 2352520 byte(s) in 571 object(s) allocated from:
> #0 0x7f6ca3308d4e in __interceptor_calloc (/lib64/libasan.so.5+0x112d4e)
> #1 0x7f6ca3127a50
On Oct 22 22:51, Philippe Mathieu-Daudé wrote:
> On 9/22/20 10:45 AM, Klaus Jensen wrote:
> > +static uint16_t nvme_dma(NvmeCtrl *n, uint8_t *ptr, uint32_t len,
>
> Using a 'void *ptr' would simplify your API, avoiding the callers
> to cast.
>
You are correct, but there is a bunch of work being
Hi Michael,
On Thu, Oct 22, 2020 at 6:01 PM Michael S. Tsirkin wrote:
> On Thu, Oct 22, 2020 at 05:50:51PM +0300, Marcel Apfelbaum wrote:
> >
> >
> > On Thu, Oct 22, 2020 at 5:33 PM Michael S. Tsirkin
> wrote:
> >
> > On Thu, Oct 22, 2020 at 05:10:43PM +0300, Marcel Apfelbaum wrote:
> >
On Oct 23 07:25, Klaus Jensen wrote:
> On Oct 22 23:02, Philippe Mathieu-Daudé wrote:
> > On 10/22/20 8:49 PM, Klaus Jensen wrote:
> > > -/* support DULBE */
> > > -id_ns->nsfeat |= 0x4;
> > > +/* support DULBE and I/O optimization fields */
> > > +id_ns->nsfeat |= (0x4 | 0x10);
> >
From: Pan Nengyuan
Missing g_error_free on error path in ga_channel_write_all(). Fix that.
Reported-by: Euler Robot
Signed-off-by: Pan Nengyuan
Reviewed-by: Li Qiang
Signed-off-by: Chen Qun
---
Cc: Michael Roth
---
qga/channel-posix.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion
From: Pan Nengyuan
'local_err' forgot to free in colo_process_incoming_thread error path.
Fix that.
Reported-by: Euler Robot
Signed-off-by: Pan Nengyuan
Reviewed-by: Li Qiang
Signed-off-by: Chen Qun
---
Cc: Hailiang Zhang
Cc: Juan Quintela
Cc: "Dr. David Alan Gilbert"
---
migration/colo.
From: Pan Nengyuan
'local_err' seems forgot to propagate in error path, it'll cause
a memleak. Fix it.
Reported-by: Euler Robot
Signed-off-by: Pan Nengyuan
Reviewed-by: Kevin Wolf
Reviewed-by: Li Qiang
Signed-off-by: Chen Qun
---
blockdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git
Properly free each command resp to avoid memory leak.
ASAN shows memory leak stack:
Indirect leak of 2352520 byte(s) in 571 object(s) allocated from:
#0 0x7f6ca3308d4e in __interceptor_calloc (/lib64/libasan.so.5+0x112d4e)
#1 0x7f6ca3127a50 in g_malloc0 (/lib64/libglib-2.0.so.0+0x55a50)
From: Pan Nengyuan
local_err is not initialized to NULL, it will cause a assert error as below:
qemu/util/error.c:59: error_setv: Assertion `*errp == NULL' failed.
Fixes: c6447510690
Reported-by: Euler Robot
Signed-off-by: Pan Nengyuan
Reviewed-by: Stefano Garzarella
Reviewed-by: Kevin Wolf
From: Pan Nengyuan
Missing g_error_free in pdb_init_from_file() error path. Fix that.
Reported-by: Euler Robot
Signed-off-by: Pan Nengyuan
Reviewed-by: Viktor Prutyanov
Reviewed-by: Li Qiang
Signed-off-by: Chen Qun
---
contrib/elf2dmp/pdb.c | 1 +
1 file changed, 1 insertion(+)
diff --git
Hi all,
Here are some memory leak patches reported by EulerRobot.
Some patch submissions have been unattended for a while and I resend
them.
Thanks,
Chen Qun
Chen Qun (1):
tests/migration: fix memleak in wait_command/wait_command_fd
Pan Nengyuan (6):
qga/channel-posix: Plug memory leak i
From: Pan Nengyuan
Missing g_error_free in QEMU_Elf_init() error path. Fix that.
Reported-by: Euler Robot
Signed-off-by: Pan Nengyuan
Reviewed-by: Viktor Prutyanov
Reviewed-by: Li Qiang
Signed-off-by: Chen Qun
---
contrib/elf2dmp/qemu_elf.c | 1 +
1 file changed, 1 insertion(+)
diff --git
On 09/07/2020 12.22, Thomas Huth wrote:
> On 09/07/2020 12.16, Gerd Hoffmann wrote:
>> Hi,
>>
2. wiki.qemu.org is a MediaWiki instance. Account creation is a hurdle
to one-time or new contributors. It is unclear whether GitLab's wiki
is expressive enough for a lossless conversion o
On 22/10/2020 18.28, John Snow wrote:
> There's no reason to keep this here; the versions described are
> ancient. Everything here is still mirrored on
> https://wiki.qemu.org/ChangeLog/old if anyone is curious; otherwise, use
> the git history.
>
> Signed-off-by: John Snow
> ---
> Changelog | 5
On Oct 22 23:02, Philippe Mathieu-Daudé wrote:
> Hi Klaus,
>
Hi Philippe,
Thanks for your comments!
> On 10/22/20 8:49 PM, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > Add support for the Dataset Management command and the Deallocate
> > attribute. Deallocation results in discards being
On 10/22/20 3:06 PM, Philippe Mathieu-Daudé wrote:
> Cc'ing Guenter who had a similar patch and might be interested
> to test :)
>
I applied the series on top of qemu mainline and ran all my test with it
(raspi2 with qemu-system-arm as well as qemu-system-aarch64, and raspi3
in both big endian and
On Thu, 22 Oct 2020 11:01:04 -0400
"Michael S. Tsirkin" wrote:
> On Thu, Oct 22, 2020 at 05:50:51PM +0300, Marcel Apfelbaum wrote:
> [...]
>
> Right. After detecting just failing unconditionally it a bit too
> simplistic IMHO.
There's also another factor here, which I thought I'd mentioned
a
To use MSI-X interrupt in my PCIe device, In realize() function I make a MSIX
initialization like this:
#define MYDEV_MSIX_VEC_NUM 5
void realize() {
memory_region_init(&mydev->msix, OBJECT(edu), "mydev-msix",
MYDEV_MSIX_SIZE);
pci_register_bar(pdev, MYDEV_MSIX_IDX
On Thu, 22 Oct 2020 16:55:10 +0300
Marcel Apfelbaum wrote:
> Hi David, Michael,
>
> On Thu, Oct 22, 2020 at 3:56 PM David Gibson wrote:
>
> [...]
> [...]
> [...]
> [...]
> [...]
> [...]
> [...]
> [...]
> [...]
> [...]
> [...]
> [...]
> [...]
> [...]
>
On Thu, 22 Oct 2020 09:15:28 -0400
"Michael S. Tsirkin" wrote:
> On Thu, Oct 22, 2020 at 11:56:32PM +1100, David Gibson wrote:
> [...]
> [...]
> [...]
> > >
> > > Probably the only way to handle for existing machine types.
> > > For new ones, can't we queue it in host memory somewhere?
Hi Niek,
On Thu, Oct 22, 2020 at 11:20 PM Niek Linnenbank
wrote:
>
> Hi Bin, Philippe,
>
> If im correct the acceptance tests for orange pi need to be run with a flag
> ARMBIAN_ARTIFACTS_CACHED set that explicitly allows them to be run using the
> armbian mirror. So if you pass that flag on the
On Thu, Oct 22, 2020 at 4:58 PM Moises Arreola wrote:
>
> Hello everyone, my name is Moses and I'm trying to set up a VM for a risc-v
> processor, I'm using the Risc-V Getting Started Guide and on the final step
> I'm getting an error while trying to launch the virtual machine using the cmd:
He
> > PTWRITE provides a mechanism by which software can instrument the
> > Intel PT trace. The current implementation will mask off this feature
> > when the PTWRITE is supported on the host because of the Intel PT
> > CPUID is a constant value(ICX CPUID) in qemu. This patch will expose
> > the PTWR
Hello everyone, my name is Moses and I'm trying to set up a VM for a risc-v
processor, I'm using the Risc-V Getting Started Guide and on the final step
I'm getting an error while trying to launch the virtual machine using the
cmd:
sudo qemu-system-riscv64 -nographic -machine virt \
-kernel linux/a
Hi,
On 10/22/20 3:06 PM, Philippe Mathieu-Daudé wrote:
> Cc'ing Guenter who had a similar patch and might be interested
> to test :)
>
great. I think my patch doesn't work anymore since qemu 5.0 (at least not
for raspi3), and it was pretty hackish anyway. I'll give the series a try.
Guenter
>
Get rid of manually written property getters/setters.
Signed-off-by: Eduardo Habkost
---
Cc: Paolo Bonzini
Cc: Richard Henderson
Cc: Eduardo Habkost
Cc: "Michael S. Tsirkin"
Cc: Marcel Apfelbaum
Cc: qemu-devel@nongnu.org
---
hw/i386/pc.c | 57 +---
Signed-off-by: Eduardo Habkost
---
Cc: "Daniel P. Berrangé"
Cc: qemu-devel@nongnu.org
---
authz/listfile.c | 27 +++
1 file changed, 3 insertions(+), 24 deletions(-)
diff --git a/authz/listfile.c b/authz/listfile.c
index aaf930453d..911c4e45f2 100644
--- a/authz/listfile
Get rid if some manually written properties getters/setters.
Not all properties could be converted because they have extra
logic in the property setter.
Signed-off-by: Eduardo Habkost
---
Cc: Eduardo Habkost
Cc: Marcel Apfelbaum
Cc: qemu-devel@nongnu.org
---
hw/core/machine.c | 78 ---
Provide helpers for registering boolean properties that simply
read/write a struct field, to reduce the need to manually write
property getters and setters.
Signed-off-by: Eduardo Habkost
---
Cc: Paolo Bonzini
Cc: "Daniel P. Berrangé"
Cc: Eduardo Habkost
Cc: qemu-devel@nongnu.org
---
include/
Based-on: 20201009160122.1662082-1-ehabk...@redhat.com
Git branch: https://github.com/ehabkost/qemu work/qom-bool-ptr-prop
This series introduces a helper to make it easier to register
simple boolan QOM properties. It will be useful for simplifying
existing property code in some types that can't
** Changed in: debian
Status: In Progress => Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1894869
Title:
Chelsio T4 has old MSIX PBA offset bug
Status in QEMU:
Invalid
Status in
On Thu, 22 Oct 2020 16:42:07 +0530
Kirti Wankhede wrote:
> Added amount of bytes transferred to the VM at destination by all VFIO
> devices
>
> Signed-off-by: Kirti Wankhede
> Reviewed-by: Dr. David Alan Gilbert
> ---
> hw/vfio/common.c| 20
> hw/vfio/migratio
Cc'ing Guenter who had a similar patch and might be interested
to test :)
patch 16/15 fixup:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg752113.html
On 10/10/20 3:57 PM, Luc Michel wrote:
v2 -> v3:
- patch 03: moved clock_new definition to hw/core/clock.c [Phil]
- patch 03: comm
As IDE used to be, NVMe emulation is becoming an active
subsystem. Move it into its own namespace.
Signed-off-by: Philippe Mathieu-Daudé
---
sent as RFC, it case it helps NVMe developers. As nvme-next
has patches queues, if the idea of moving seems useful, this
patch can resend later.
---
meson.
On 10/14/20 6:52 AM, Vladimir Sementsov-Ogievskiy wrote:
>> docs/interop/nbd.txt | 27 ++---
>
> [..]
>
>> +In the allocation depth context, bits 0 and 1 form a tri-state value:
>> +
>> + bits 0-1: 00: NBD_STATE_DEPTH_UNALLOC, the extent is unallocated
>> + 01: NBD_STATE
On Thu, Oct 22, 2020 at 07:06:58AM +0200, Markus Armbruster wrote:
[...]
> > I don't love object*_property_add_*_ptr() either. I consider the
> > qdev property API better. But we need a reasonable alternative,
> > because the qdev API can't be used by non-device objects yet.
>
> Emphasis on *yet
On Thu, 22 Oct 2020 16:41:50 +0530
Kirti Wankhede wrote:
> Hi,
>
> This Patch set adds migration support for VFIO devices in QEMU.
We're cutting it pretty close for the 5.2 soft freeze, but clearly
we've seen this series a few times. The key points for me are that I
no longer see anything that
On Thu, Oct 22, 2020 at 11:02:04PM +0200, Philippe Mathieu-Daudé wrote:
> On 10/22/20 8:49 PM, Klaus Jensen wrote:
> > +static uint16_t nvme_dsm(NvmeCtrl *n, NvmeRequest *req)
> > +{
> > +NvmeNamespace *ns = req->ns;
> > +NvmeDsmCmd *dsm = (NvmeDsmCmd *) &req->cmd;
> > +NvmeDsmRange *ra
23.07.2020 11:35, Max Reitz wrote:
On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote:
The further change of moving backup to be a on block-copy call will
-on?
make copying chunk-size and cluster-size a separate things. So, even
s/a/two/
with 64k cluster sized qcow2 image, default chu
On 10/22/20 6:39 PM, Daniel P. Berrangé wrote:
On Thu, Oct 22, 2020 at 12:24:16PM -0400, Alexander Bulekov wrote:
+CC Prasad
On 201022 1219, Alexander Bulekov wrote:
Hello,
QEMU was accepted into Google's oss-fuzz continuous-fuzzing platform [1]
earlier this year. The fuzzers currently running
23.07.2020 11:19, Max Reitz wrote:
On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote:
The further change of moving backup to be a on block-copy call will
-on?
one :)
make copying chunk-size and cluster-size a separate things. So, even
s/a/two/
with 64k cluster sized qcow2 image,
23.07.2020 11:03, Max Reitz wrote:
On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote:
After introducing parallel async copy requests instead of plain
cluster-by-cluster copying loop, backup job may finish earlier than
final assertion in do_test_stop. Let's require slow backup explicitly
by s
On 10/22/20 10:29 PM, Laurent Vivier wrote:
They are unused since the target has been converted to TCG.
Fixes: e1f3808e03f7 ("Convert m68k target to TCG.")
Signed-off-by: Laurent Vivier
Reviewed-by: Philippe Mathieu-Daudé
---
target/m68k/cpu.h | 4
1 file changed, 4 deletions(-)
d
Hi Klaus,
On 10/22/20 8:49 PM, Klaus Jensen wrote:
From: Klaus Jensen
Add support for the Dataset Management command and the Deallocate
attribute. Deallocation results in discards being sent to the underlying
block device. Whether of not the blocks are actually deallocated is
affected by the s
On Thu, Oct 22, 2020 at 06:39:37PM +0200, Jean-Philippe Brucker wrote:
> So what I'd like to do for next version:
>
> * Set qemu_real_host_page_mask as the default page mask, instead of the
> rather arbitrary TARGET_PAGE_MASK.
Oh, I thought TARGET_PAGE_MASK was intended - kernel committ 39b3b3c
On 9/22/20 10:45 AM, Klaus Jensen wrote:
From: Klaus Jensen
For now, support the Data Block, Segment and Last Segment descriptor
types.
See NVM Express 1.3d, Section 4.4 ("Scatter Gather List (SGL)").
Signed-off-by: Klaus Jensen
Reviewed-by: Keith Busch
---
include/block/nvme.h | 6 +-
22.07.2020 14:28, Max Reitz wrote:
On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote:
Add function to cancel running async block-copy call. It will be used
in backup.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/block/block-copy.h | 7 +++
block/block-copy.c | 22
22.07.2020 15:22, Max Reitz wrote:
On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote:
Add new parameters to configure future backup features. The patch
doesn't introduce aio backup requests (so we actually have only one
worker) neither requests larger than one cluster. Still, formally we
sat
On Thu, 22 Oct 2020 16:42:04 +0530
Kirti Wankhede wrote:
> When vIOMMU is enabled, register MAP notifier from log_sync when all
> devices in container are in stop and copy phase of migration. Call replay
> and get dirty pages from notifier callback.
>
> Suggested-by: Alex Williamson
> Signed-of
Signed-off-by: Laurent Vivier
---
target/m68k/cpu.h| 1 +
target/m68k/cpu.c| 193 ++-
target/m68k/fpu_helper.c | 10 +-
3 files changed, 198 insertions(+), 6 deletions(-)
diff --git a/target/m68k/cpu.h b/target/m68k/cpu.h
index 9a6f0400fcfe.
First patch is a cleanup patch.
The second patch defines the vmstate structure for M68kCPU.
I have tested the migration with my experimental machine virt-m68k.
I didn't check if q800 machine type has all the needed vmstates
for all the hardware devices it uses.
Thanks,
Laurent
Laurent Vivier (
They are unused since the target has been converted to TCG.
Fixes: e1f3808e03f7 ("Convert m68k target to TCG.")
Signed-off-by: Laurent Vivier
---
target/m68k/cpu.h | 4
1 file changed, 4 deletions(-)
diff --git a/target/m68k/cpu.h b/target/m68k/cpu.h
index 521ac67cdd04..9a6f0400fcfe 100644
Paolo,
I think this would need your ack. Thanks,
Alex
On Thu, 22 Oct 2020 16:42:00 +0530
Kirti Wankhede wrote:
> mr->ram_block is NULL when mr->is_iommu is true, then fr.dirty_log_mask
> wasn't set correctly due to which memory listener's log_sync doesn't
> get called.
> This patch returns l
On Thu, 22 Oct 2020 16:41:59 +0530
Kirti Wankhede wrote:
> Sequence during _RESUMING device state:
> While data for this device is available, repeat below steps:
> a. read data_offset from where user application should write data.
> b. write data of data_size to migration region from data_offset
Philippe Mathieu-Daudé writes:
> Let GitLab runners use GitLab repository directly.
Queued to testing/next, thanks.
> Suggested-by: Paolo Bonzini
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> .gitlab-ci.yml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.gitlab-ci.yml b/.gitlab
On Thu, Oct 22, 2020 at 08:19:54PM +0100, Dr. David Alan Gilbert wrote:
> * Stefan Hajnoczi (stefa...@redhat.com) wrote:
> > virtiofsd cannot run in a container because CAP_SYS_ADMIN is required to
> > create namespaces.
> >
> > Introduce a weaker sandbox mode that is sufficient in container
> > e
* Stefan Hajnoczi (stefa...@redhat.com) wrote:
> virtiofsd cannot run in a container because CAP_SYS_ADMIN is required to
> create namespaces.
>
> Introduce a weaker sandbox mode that is sufficient in container
> environments because the container runtime already sets up namespaces.
> Use chroot t
Rename bitmaps migration tests and move them to tests subdirectory to
demonstrate new human-friendly test naming.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test} | 0
.../{199.out => tests/migrate-bitmaps-postcopy-test.out}
Just use classes introduced in previous three commits. Behavior
difference is described in these three commits.
Drop group file, as it becomes unused.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/check | 977 ++-
tests/qemu-iotests/group
We are going to drop group file. Define group in tests as a preparatory
step.
The patch is generated by
cd tests/qemu-iotests
grep '^[0-9]\{3\} ' group | while read line; do
file=$(awk '{print $1}' <<< "$line");
groups=$(sed -e 's/^... //' <<< "$line");
awk "NR==2
Add TestRunner class, which will run tests in a new python iotests
running framework.
There are some differences with current ./check behavior, most
significant are:
- Consider all tests self-executable, just run them, don't run python
by hand.
- Elapsed time is cached in json file
- Elapsed tim
All other test files are executable, except for this one. Fix that.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Reviewed-by: Philippe Mathieu-Daudé
---
tests/qemu-iotests/283 | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100644 => 100755 tests/qemu-
Add TestEnv class, which will handle test environment in a new python
iotests running framework.
Difference with current ./check interface:
- -v (verbose) option dropped, as it is unused
- -xdiff option is dropped, until somebody complains that it is needed
- same for -n option
Signed-off-by: Vl
We are going to be stricter about comparing test result with .out
files. So, fix some whitespaces now.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/175.out | 2 +-
tests/qemu-iotests/271.out | 12 ++--
tests/qemu-iotests/287.out | 10 +-
3 files changed, 12
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/294 | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qemu-iotests/294 b/tests/qemu-iotests/294
index 9c95ed8c9a..4bdb7364af 100755
--- a/tests/qemu-iotests/294
+++ b/tests/qemu-iotests/294
@@ -1,3 +1,4 @@
+#!/usr/bin/env
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/299 | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100644 => 100755 tests/qemu-iotests/299
diff --git a/tests/qemu-iotests/299 b/tests/qemu-iotests/299
old mode 100644
new mode 100755
--
2.21.3
Add python script with new logic of searching for tests:
Current ./check behavior:
- tests are named [0-9][0-9][0-9]
- tests must be registered in group file (even if test doesn't belong
to any group, like 142)
Behavior of findtests.py:
- group file is dropped
- tests are all files in test
If you run './check 277', check includes common.config which adjusts
$PATH to include '.' first, and therefore finds nbd-fault-injector.py
on PATH. But if you run './277' directly, there is nothing to adjust
PATH, and if '.' is not already on your PATH by other means, the test
fails because the ex
On Thu, 22 Oct 2020 16:41:57 +0530
Kirti Wankhede wrote:
> Define flags to be used as delimiter in migration stream for VFIO devices.
> Added .save_setup and .save_cleanup functions. Map & unmap migration
> region from these functions at source during saving or pre-copy phase.
>
> Set VFIO devic
Hi all!
These series has 3 goals:
- get rid of group file
- introduce human-readable names for tests
- rewrite check into python
v5: [rebase on master]
02: new
03: updated
05,06: new
07: updated
09: rebased on master:
vxhs removed
qemu_prog path changed
build_iotests path calculation ch
If you run './check 303', check includes common.config which adjusts
$PATH to include '.' first, and therefore finds qcow2.py on PATH. But
if you run './303' directly, there is nothing to adjust PATH, and if
'.' is not already on your PATH by other means, the test fails because
the executable is n
From: Klaus Jensen
Add support for the Dataset Management command and the Deallocate
attribute. Deallocation results in discards being sent to the underlying
block device. Whether of not the blocks are actually deallocated is
affected by the same factors as Write Zeroes (see previous commit).
From: Klaus Jensen
Add support for reporting the Deallocated or Unwritten Logical Block
Error (DULBE).
Rely on the block status flags reported by the block layer and consider
any block with the BDRV_BLOCK_ZERO flag to be deallocated.
Multiple factors affect when a Write Zeroes command result in
From: Klaus Jensen
This adds support for the Deallocated or Unwritten Logical Block error
recovery feature as well as the Dataset Management command.
I wanted to add support for the NPDG and NPDA fields such that the host
could get a hint on how many blocks to request deallocation of for the
dea
On Oct 22 10:50, Keith Busch wrote:
> On Thu, Oct 22, 2020 at 07:43:33PM +0200, Klaus Jensen wrote:
> > On Oct 22 08:01, Keith Busch wrote:
> > > On Thu, Oct 22, 2020 at 09:33:13AM +0200, Klaus Jensen wrote:
> > > > +if (--(*discards)) {
> > > > +status = NVME_NO_COMPLETE;
> > >
On Mon, Oct 19, 2020 at 8:37 PM Green Wan wrote:
>
> Add '-drive' support to OTP device. Allow users to assign a raw file
> as OTP image.
>
> test commands for 16k otp.img filled with zero:
>
> $ dd if=/dev/zero of=./otp.img bs=1k count=16
> $ ./qemu-system-riscv64 -M sifive_u -m 256M -nographic -
If the flag BDRV_REQ_PREFETCH was set, skip idling read/write
operations in COR-driver. It can be taken into account for the
COR-algorithms optimization. That check is being made during the
block stream job by the moment.
Signed-off-by: Andrey Shinkevich
---
block/copy-on-read.c | 12 ---
On Thu, 22 Oct 2020 23:11:39 +0530
Kirti Wankhede wrote:
> On 10/22/2020 10:05 PM, Alex Williamson wrote:
> > On Thu, 22 Oct 2020 16:41:55 +0530
> > Kirti Wankhede wrote:
> >
> >> VM state change handler is called on change in VM's state. Based on
> >> VM state, VFIO device state should be ch
Avoid writing a filter JSON file name and a filter format name to QCOW2
image when the backing file is changed after the block stream job.
A user is still able to assign the 'backing-file' parameter for a
block-stream job keeping in mind the possible issue mentioned above.
If the user does not spec
The test case #310 is similar to #216 by Max Reitz. The difference is
that the test #310 involves a bottom node to the COR filter driver.
Signed-off-by: Andrey Shinkevich
---
tests/qemu-iotests/310 | 109 +
tests/qemu-iotests/310.out | 15 +++
Create the BlockdevOptionsCor structure for COR driver specific options
splitting it off form the BlockdevOptionsGenericFormat. The only option
'bottom' node in the structure denotes an image file that limits the
COR operations in the backing chain.
Suggested-by: Max Reitz
Signed-off-by: Andrey S
Add the new member supported_read_flags to the BlockDriverState
structure. It will control the flags set for copy-on-read operations.
Make the block generic layer evaluate supported read flags before they
go to a block driver.
Suggested-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Andrey Shink
We are going to use the COR-filter for a block-stream job.
To limit COR operations by the base node in the backing chain during
stream job, pass the bottom node name, that is the first non-filter
overlay of the base, to the copy-on-read driver as the base node itself
may change due to possible conc
This patch completes the series with the COR-filter insertion for
block-stream operations. Adding the filter makes it possible for copied
regions to be discarded in backing files during the block-stream job,
what will reduce the disk overuse.
The COR-filter insertion incurs changes in the iotests c
The node insert/remove functions were added at the block generic layer.
COR-filter options structure was added to the QAPI.
The test case #310 was added to check the 'bottom' node limit for COR.
The 'supported_read_flags' member was added to the BDS structure
(with the flags check at the block gene
Modify the comment for the flag BDRV_REQ_PREFETCH as we are going to
use it alone and pass it to the COR-filter driver for further
processing.
Signed-off-by: Andrey Shinkevich
---
include/block/block.h | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/include/block/bloc
Add support for the recently introduced functions
bdrv_co_preadv_part()
and
bdrv_co_pwritev_part()
to the COR-filter driver.
Signed-off-by: Andrey Shinkevich
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/copy-on-read.c | 28
1 file changed, 16 insertions(+), 1
Provide API for the COR-filter removal. Also, drop the filter child
permissions for an inactive state when the filter node is being
removed. This function may be considered as an intermediate solution
before we are able to use bdrv_remove_node(). It will be possible once
the QEMU permission update
Provide API for a node insertion to and removal from a backing chain.
Suggested-by: Max Reitz
Signed-off-by: Andrey Shinkevich
---
block.c | 49 +
include/block/block.h | 3 +++
2 files changed, 52 insertions(+)
diff --git a/block.
Limit COR operations to the bottom node (inclusively) in the backing
chain when the bottom node name is given. It will be useful for a block
stream job when the COR-filter is applied. The bottom node is passed as
the base itself may change due to concurrent commit jobs on the same
backing chain.
S
Provide the possibility to pass the 'filter-node-name' parameter to the
block-stream job as it is done for the commit block job.
Signed-off-by: Andrey Shinkevich
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/monitor/block-hmp-cmds.c | 4 ++--
block/stream.c | 4 +++-
block
Add the BDRV_REQ_COPY_ON_READ and BDRV_REQ_PREFETCH flags to the
supported_read_flags of the COR-filter.
Signed-off-by: Andrey Shinkevich
---
block/copy-on-read.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/block/copy-on-read.c b/block/copy-on-read.c
index 8178a91..a2b180a 100644
--- a
On 201022 1739, Daniel P. Berrangé wrote:
> On Thu, Oct 22, 2020 at 12:24:16PM -0400, Alexander Bulekov wrote:
> > +CC Prasad
> >
> > On 201022 1219, Alexander Bulekov wrote:
> > > Hello,
> > > QEMU was accepted into Google's oss-fuzz continuous-fuzzing platform [1]
> > > earlier this year. The fu
On Thu, Oct 22, 2020 at 07:43:33PM +0200, Klaus Jensen wrote:
> On Oct 22 08:01, Keith Busch wrote:
> > On Thu, Oct 22, 2020 at 09:33:13AM +0200, Klaus Jensen wrote:
> > > +if (--(*discards)) {
> > > +status = NVME_NO_COMPLETE;
> > > +} else {
> > > +g_free(d
On Oct 22 08:20, Keith Busch wrote:
> On Thu, Oct 22, 2020 at 03:24:02PM +0200, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > The first patch is a follow up to "hw/block/nvme: fix prp mapping status
> > codes" and fixes some status codes in the nvme_create_{sq,cq} functions.
> >
> > The sec
On Oct 22 08:01, Keith Busch wrote:
> On Thu, Oct 22, 2020 at 09:33:13AM +0200, Klaus Jensen wrote:
> > +if (--(*discards)) {
> > +status = NVME_NO_COMPLETE;
> > +} else {
> > +g_free(discards);
> > +req->opaque = NULL;
>
> This case needs a
>
>
1 - 100 of 343 matches
Mail list logo
