Re: Emulate Rpi with QEMU fails

2020-10-06 Thread Paul Zimmerman
On Tue, Oct 6, 2020 at 11:28 PM Thomas <74cmo...@gmail.com> wrote: > > Hello! > > Many thanks for your support. > > I managed to get emulated RPi starting. > > However there's one question I want to ask: > How can I accelerate the startup sequence? > I mean booting the emulated RPi takes more than

Re: [PATCH 1/2] docker: Add win32/msys2/mingw64 docker

2020-10-06 Thread Thomas Huth
On 07/10/2020 04.41, Yonggang Luo wrote: > This docker is used to preparing a msys2/mingw with basic software installed. > > Signed-off-by: Yonggang Luo > --- > tests/docker/dockerfiles/msys2.docker | 57 +++ > 1 file changed, 57 insertions(+) > create mode 100644 tests/

Re: [PATCH v3 2/2] hw/virtio-pci Added AER capability.

2020-10-06 Thread Andrew Melnichenko
Ok, Main motivation: > According to Microsoft driver\device certification requirements for next > version of Window Server, PCIe device must support AER. > The exact quote of Microsoft certification requirements: > "Windows Server PCI Express devices are required to support Advanced > Error Report

Re: [PATCH v3 2/2] hw/virtio-pci Added AER capability.

2020-10-06 Thread Yan Vugenfirer
Hi Michael, > On 5 Oct 2020, at 8:46 PM, Michael S. Tsirkin wrote: > > On Mon, Oct 05, 2020 at 02:56:01PM +0300, and...@daynix.com wrote: >> From: Andrew >> >> Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1878465 > > That's a private bug - what information can you share about > the

Re: [PATCH v2 0/9] 5p80: Add SFDP support

2020-10-06 Thread Cédric Le Goater
On 10/7/20 3:43 AM, Joel Stanley wrote: > On Wed, 2 Sep 2020 at 09:31, Cédric Le Goater wrote: >> >> Hello, >> >> JEDEC STANDARD JESD216 for Serial Flash Discovery Parameters (SFDP) >> provides a mean to describe the features of a serial flash device >> using a set of internal parameter tables. Su

Re: Emulate Rpi with QEMU fails

2020-10-06 Thread Thomas
Hello! Many thanks for your support. I managed to get emulated RPi starting. However there's one question I want to ask: How can I accelerate the startup sequence? I mean booting the emulated RPi takes more than 3 minutes. Regards Thomas Am 06.10.20 um 11:58 schrieb Alex Bennée: > Thomas Schne

Re: [PATCH v2 1/6] spapr/xive: Introduce a StoreEOI capability

2020-10-06 Thread Cédric Le Goater
On 10/6/20 6:42 PM, Greg Kurz wrote: > On Mon, 5 Oct 2020 18:51:42 +0200 > Cédric Le Goater wrote: > >> When an interrupt has been handled, the OS notifies the interrupt >> controller with an EOI sequence. On the XIVE interrupt controller >> (POWER9 and POWER10), this can be done with a load o

Re: [PULL 00/16] s390-ccw bios update

2020-10-06 Thread Christian Borntraeger
On 06.10.20 20:31, Thomas Huth wrote: > Hi Peter, > > the following changes since commit d7c5b788295426c1ef48a9ffc3432c51220f69ba: > > Merge remote-tracking branch > 'remotes/stefanha-gitlab/tags/block-pull-request' into staging (2020-10-06 > 12:15:59 +0100) > > are available in the Git

Re: [PATCH v7 14/14] tests/acceptance: add reverse debugging test

2020-10-06 Thread Philippe Mathieu-Daudé
On 10/6/20 9:55 PM, Philippe Mathieu-Daudé wrote: > On 10/3/20 7:14 PM, Pavel Dovgalyuk wrote: >> From: Pavel Dovgalyuk >> >> This is a test for GDB reverse debugging commands: reverse step and reverse >> continue. >> Every test in this suite consists of two phases: record and replay. >> Recordin

Re: acceptance-system-fedora failures

2020-10-06 Thread Philippe Mathieu-Daudé
On 10/7/20 1:07 AM, John Snow wrote: > I'm seeing this gitlab test fail quite often in my Python work; I don't > *think* this has anything to do with my patches, but maybe I need to try > and bisect this more aggressively. > > The very first hint of an error I see is on line 154: > > https://gitl

Re: [PATCH 18/20] python/qemu/qmp.py: re-raise OSError when encountered

2020-10-06 Thread Philippe Mathieu-Daudé
On 10/7/20 1:58 AM, John Snow wrote: > Nested if conditions don't change when the exception block fires; we > need to explicitly re-raise the error if we didn't intend to capture and > suppress it. > > Signed-off-by: John Snow > --- > python/qemu/qmp.py | 6 +++--- > 1 file changed, 3 insertions

Re: [PATCH 01/20] python/qemu: use isort to lay out imports

2020-10-06 Thread Philippe Mathieu-Daudé
On 10/7/20 1:57 AM, John Snow wrote: > Borrowed from the QAPI cleanup series, use the same configuration to > standardize the way we write and sort imports. > > Signed-off-by: John Snow > --- > python/qemu/.isort.cfg| 7 +++ > python/qemu/accel.py | 1 + > python/qemu/cons

Re: [PATCH 17/20] python/qemu/qmp.py: Preserve error context on re-raise

2020-10-06 Thread Philippe Mathieu-Daudé
On 10/7/20 1:58 AM, John Snow wrote: > Use the "from ..." phrasing when re-raising errors to preserve their > initial context, to help aid debugging when things go wrong. > > This also silences a pylint 2.6.0+ error. > > Signed-off-by: John Snow > --- > python/qemu/qmp.py | 9 + > 1 fil

Re: [PATCH 09/20] python/qemu: make 'args' style arguments immutable

2020-10-06 Thread Philippe Mathieu-Daudé
On 10/7/20 1:58 AM, John Snow wrote: > These arguments don't need to be mutable and aren't really used as > such. Clarify their types as immutable and adjust code to match where > necessary. > > In general, It's probably best not to accept a user-defined mutable > object and store it as internal o

Re: [PATCH 06/20] python/machine.py: use qmp.command

2020-10-06 Thread Philippe Mathieu-Daudé
On 10/7/20 1:58 AM, John Snow wrote: > machine.py and qmp.py both do the same thing here; refactor machine.py > to use qmp.py's functionality more directly. > > Signed-off-by: John Snow > Reviewed-by: Kevin Wolf > --- > python/qemu/machine.py | 32 > 1 file chan

Re: [PATCH 03/20] python/machine.py: reorder __init__

2020-10-06 Thread Philippe Mathieu-Daudé
On 10/7/20 1:58 AM, John Snow wrote: > Put the init arg handling all at the top, and mostly in order (deviating > when one is dependent on another), and put what is effectively runtime > state declaration at the bottom. > > Signed-off-by: John Snow > --- > python/qemu/machine.py | 44 +++

Re: [PATCH 12/14] arc: Add Synopsys ARC emulation boards

2020-10-06 Thread Philippe Mathieu-Daudé
Hi Cupertino, Claudiu, On 9/30/20 10:46 PM, cupertinomira...@gmail.com wrote: > From: Claudiu Zissulescu > > Add the Synopsys ARC boards, arc_sim for testing, sim-hs main emulation > board using standard UART and nsim which includes a Synopsys ARC specific > UART implementation. > > Signed-off-

[Bug 562107] Re: QEmu GDB stub uses IPv6 instead of v4 (or both)

2020-10-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/562107 Title: QEmu GDB stu

[Bug 897466] Re: UHCI Host Controller no longer present with -usb

2020-10-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/897466 Title: UHCI Host Co

[Bug 897466] Re: UHCI Host Controller no longer present with -usb

2020-10-06 Thread Launchpad Bug Tracker
[Expired for qemu-kvm (Ubuntu Precise) because there has been no activity for 60 days.] ** Changed in: qemu-kvm (Ubuntu Precise) Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launch

[Bug 897466] Re: UHCI Host Controller no longer present with -usb

2020-10-06 Thread Launchpad Bug Tracker
[Expired for qemu-kvm (Ubuntu) because there has been no activity for 60 days.] ** Changed in: qemu-kvm (Ubuntu) Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/897

[Bug 1180923] Re: unused memory filled with 0x00 instead of 0xFF

2020-10-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1180923 Title: unused memo

[Bug 1187319] Re: Ctrl-Alt-- and Ctrl-Alt-+ have no effect in SDL

2020-10-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1187319 Title: Ctrl-Alt--

[Bug 754635] Re: -d option outs wrong info about sections

2020-10-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/754635 Title: -d option ou

Re: [PATCH] Changes to support booting NetBSD/alpha

2020-10-06 Thread Philippe Mathieu-Daudé
Hi Jason, On 10/7/20 5:24 AM, Jason Thorpe wrote: > Along with the previous patch set for qemu-palcode, these changes > allow NetBSD/alpha to run in qemu-system-alpha. > > - Allow a the minimum PCI device number to be passed to typhoon_init(). > Use this to specify a minimum PCI device number o

[Bug 1196145] Re: usb-host: hostaddr=0XX is parsed as octal number

2020-10-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1196145 Title: usb-host: h

[Bug 1193555] Re: Add scale options to window menu

2020-10-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1193555 Title: Add scale o

[Bug 1219234] Re: -device ide-hd will assign bus with with no free units

2020-10-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1219234 Title: -device ide

[Bug 1306818] Re: resetting moder register in opencores_eth.c code (ethernet IP core specification code)

2020-10-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1306818 Title: resetting m

[Bug 1245543] Re: Wrong implementation of SSE4.1 pmovzxbw and similar instructions

2020-10-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1245543 Title: Wrong imple

[Bug 1030807] Re: PCI host bridge should ignore 1- and 2-byte I/O accesses

2020-10-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1030807 Title: PCI host br

[Bug 1323758] Re: Mouse stops working when connected usb-storage-device

2020-10-06 Thread Launchpad Bug Tracker
[Expired for qemu (Ubuntu) because there has been no activity for 60 days.] ** Changed in: qemu (Ubuntu) Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1323758 Ti

[Bug 1280521] Re: Plan 9 can't use GUI well emulating a RTL8139 card

2020-10-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1280521 Title: Plan 9 can'

[Bug 1248959] Re: pdpe1gb flag is missing in guest running on Intel h/w

2020-10-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1248959 Title: pdpe1gb fla

[Bug 1323758] Re: Mouse stops working when connected usb-storage-device

2020-10-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1323758 Title: Mouse stops

[Bug 1505041] Re: Live snapshot revert times increases linearly with snapshot age

2020-10-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1505041 Title: Live snapsh

[Bug 1462949] Re: vmdk files cause qemu-img to consume lots of time and memory

2020-10-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1462949 Title: vmdk files

[Bug 1478376] Re: PL050 KMIDATA register does not reset

2020-10-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1478376 Title: PL050 KMIDA

[Bug 1479717] Re: Auto resize VM doesn't work with windows 10 guest

2020-10-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1479717 Title: Auto resize

Re: [PATCH 13/14] arc: Add support for ARCv2

2020-10-06 Thread Philippe Mathieu-Daudé
On 9/30/20 10:46 PM, cupertinomira...@gmail.com wrote: > From: Shahab Vahedi > > Add remaining bits of the Synopsys ARCv2 (EM/HS) support into QEMU, > configure bits, arch_init and configuration files for softmmu (hardware > emulation). > > Signed-off-by: Shahab Vahedi > --- > configure

Re: [PATCH 01/14] arc: Add initial core cpu files

2020-10-06 Thread Philippe Mathieu-Daudé
Hi Cupertino, On 9/30/20 10:45 PM, cupertinomira...@gmail.com wrote: > From: Cupertino Miranda > > Signed-off-by: Cupertino Miranda > --- ... > diff --git a/target/arc/Makefile.objs b/target/arc/Makefile.objs > new file mode 100644 > index 00..7b2afd08e4 > --- /dev/null > +++ b/target/

Re: [PATCH v2 0/9] 5p80: Add SFDP support

2020-10-06 Thread Joel Stanley
On Wed, 7 Oct 2020 at 01:43, Joel Stanley wrote: > > On Wed, 2 Sep 2020 at 09:31, Cédric Le Goater wrote: > > > > Hello, > > > > JEDEC STANDARD JESD216 for Serial Flash Discovery Parameters (SFDP) > > provides a mean to describe the features of a serial flash device > > using a set of internal pa

[PATCH v3 3/3] cirrus: msys2/mingw speed is up, add excluded target back

2020-10-06 Thread Yonggang Luo
The following target are add back: i386-softmmu,arm-softmmu,ppc-softmmu,mips-softmmu Signed-off-by: Yonggang Luo --- .cirrus.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index bf5a0990ec..39a175d569 100644 --- a/.cirrus.yml +++ b/.cirrus.yml

[PATCH v3 0/3] Improve cirrus msys2

2020-10-06 Thread Yonggang Luo
Fixes the broken msys2/mingw ci and speed it up. V2-V3 Add one more patch: cirrus: msys2/mingw speed is up, add excluded target back Do not build sphinx on windows, that's failing set the number of parallel count to fixed number 8 V1-V2 Resolve the cirrus conflict Yonggang Luo (3): docker: Add

[PATCH v3 2/3] cirrus: Fixing and speedup the msys2/mingw CI

2020-10-06 Thread Yonggang Luo
Using a prepared https://github.com/lygstate/qemu/releases/download/v5.1.0/msys2-x86_64.tar.xz for speed up the msys2/mingw prepare speed on the cirrus CI. This file are generated by the msys2.docker Signed-off-by: Yonggang Luo --- .cirrus.yml | 60 ++

[PATCH v3 1/3] docker: Add win32/msys2/mingw64 docker

2020-10-06 Thread Yonggang Luo
This docker is used to preparing a msys2/mingw with basic software installed. Signed-off-by: Yonggang Luo --- tests/docker/dockerfiles/msys2.docker | 57 +++ 1 file changed, 57 insertions(+) create mode 100644 tests/docker/dockerfiles/msys2.docker diff --git a/tests/doc

Re: [PATCH] Changes to support booting NetBSD/alpha

2020-10-06 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201007032417.26044-1-thor...@me.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201007032417.26044-1-thor...@me.com Subject: [PATCH] Changes to support booting NetBSD/alpha

[PATCH] Changes to support booting NetBSD/alpha

2020-10-06 Thread Jason Thorpe
Along with the previous patch set for qemu-palcode, these changes allow NetBSD/alpha to run in qemu-system-alpha. - Allow a the minimum PCI device number to be passed to typhoon_init(). Use this to specify a minimum PCI device number of 1 in the Clipper system emulation, since that's the lowes

[PATCH v2 2/2] cirrus: Fixing and speedup the msys2/mingw CI

2020-10-06 Thread Yonggang Luo
Using a prepared https://github.com/lygstate/qemu/releases/download/v5.1.0/msys2-x86_64.tar.xz for speed up the msys2/mingw prepare speed on the cirrus CI. This file are generated by the msys2.docker Signed-off-by: Yonggang Luo --- .cirrus.yml | 58 ++

[PATCH v2 1/2] docker: Add win32/msys2/mingw64 docker

2020-10-06 Thread Yonggang Luo
This docker is used to preparing a msys2/mingw with basic software installed. Signed-off-by: Yonggang Luo --- tests/docker/dockerfiles/msys2.docker | 57 +++ 1 file changed, 57 insertions(+) create mode 100644 tests/docker/dockerfiles/msys2.docker diff --git a/tests/doc

[PATCH v2 0/2] Improve cirrus msys2

2020-10-06 Thread Yonggang Luo
Fixes the broken msys2/mingw ci and speed it up. V1-V2 Resolve the cirrus conflict Yonggang Luo (2): docker: Add win32/msys2/mingw64 docker cirrus: Fixing and speedup the msys2/mingw CI .cirrus.yml | 58 +++ tests/docker/dockerfiles/msys2.do

[PATCH] qemu-palcode: Changes to support booting NetBSD/alpha

2020-10-06 Thread Jason Thorpe
There are additional changes in Qemu itself. Those will be sent as a follow-up. - Change the $a2 value at VM start from "cpu count" to "config word". Bits 0-5 are cpu count, and bit 6 communicates the "-nographic" option from the VM. - Provide a Console Terminal Block in the HWRPB. Initiali

[Bug 1897194] Re: Test failure in test-crypto-secret.c

2020-10-06 Thread Toolybird
Ping. Nobody else seeing this? I can only assume you don't have keyutils-dev (or equivalent) installed on your system. This is a key difference (pardon the pun!) between Arch and the bigger distros. Arch tends to avoid splitting development libs and headers into separate packages, which might exp

[PATCH 2/2] cirrus: Fixing and speedup the msys2/mingw CI

2020-10-06 Thread Yonggang Luo
Using a prepared https://github.com/lygstate/qemu/releases/download/v5.1.0/msys2-x86_64.tar.xz for speed up the msys2/mingw prepare speed on the cirrus CI. This file are generated by the msys2.docker Signed-off-by: Yonggang Luo --- .cirrus.yml | 60 ++

[PATCH 0/2] Improve cirrus msys2

2020-10-06 Thread Yonggang Luo
Fixes the broken msys2/mingw ci and speed it up. Yonggang Luo (2): docker: Add win32/msys2/mingw64 docker cirrus: Fixing and speedup the msys2/mingw CI .cirrus.yml | 60 +++ tests/docker/dockerfiles/msys2.docker | 57 +

[PATCH 1/2] docker: Add win32/msys2/mingw64 docker

2020-10-06 Thread Yonggang Luo
This docker is used to preparing a msys2/mingw with basic software installed. Signed-off-by: Yonggang Luo --- tests/docker/dockerfiles/msys2.docker | 57 +++ 1 file changed, 57 insertions(+) create mode 100644 tests/docker/dockerfiles/msys2.docker diff --git a/tests/doc

Re: [PATCH v2 0/9] 5p80: Add SFDP support

2020-10-06 Thread Joel Stanley
On Wed, 2 Sep 2020 at 09:31, Cédric Le Goater wrote: > > Hello, > > JEDEC STANDARD JESD216 for Serial Flash Discovery Parameters (SFDP) > provides a mean to describe the features of a serial flash device > using a set of internal parameter tables. Support in Linux has been > added some time ago an

[PATCH 18/20] python/qemu/qmp.py: re-raise OSError when encountered

2020-10-06 Thread John Snow
Nested if conditions don't change when the exception block fires; we need to explicitly re-raise the error if we didn't intend to capture and suppress it. Signed-off-by: John Snow --- python/qemu/qmp.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/python/qemu/qmp.py

[PATCH 15/20] python/qemu/console_socket.py: Add type hint annotations

2020-10-06 Thread John Snow
Finish the typing of console_socket.py with annotations and no code changes. Signed-off-by: John Snow --- python/qemu/console_socket.py | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/python/qemu/console_socket.py b/python/qemu/console_socket.py index d4669

[PATCH 17/20] python/qemu/qmp.py: Preserve error context on re-raise

2020-10-06 Thread John Snow
Use the "from ..." phrasing when re-raising errors to preserve their initial context, to help aid debugging when things go wrong. This also silences a pylint 2.6.0+ error. Signed-off-by: John Snow --- python/qemu/qmp.py | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

[PATCH 13/20] python/qemu/console_socket.py: fix typing of settimeout

2020-10-06 Thread John Snow
The types and names of the parameters must match the socket.socket interface. Signed-off-by: John Snow --- python/qemu/console_socket.py | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/python/qemu/console_socket.py b/python/qemu/console_socket.py index cb3400a0385.

[PATCH 20/20] python: add mypy config

2020-10-06 Thread John Snow
Formalize the options used for checking the python library. You can run mypy from the directory that mypy.ini is in by typing `mypy qemu/`. Signed-off-by: John Snow --- python/mypy.ini | 4 1 file changed, 4 insertions(+) create mode 100644 python/mypy.ini diff --git a/python/mypy.ini b/p

[PATCH 12/20] python/qemu/console_socket.py: Correct type of recv()

2020-10-06 Thread John Snow
The type and parameter names of recv() should match socket.socket(). OK, easy enough, but in the cases we don't pass straight through to the real socket implementation, we probably can't accept such flags. OK, for now, assert that we don't receive flags in such cases. Signed-off-by: John Snow --

[PATCH 19/20] python/qemu/qmp.py: Straighten out exception hierarchy

2020-10-06 Thread John Snow
Be a little more rigorous about which exception we use, and when. Primarily, this makes QMPCapabilitiesError an extension of QMPprotocolError. The family of errors: QMPError (generic base) QMPConnectError (For connection issues) QMPTimeoutError (when waiting for an event expires) QMPProtoco

[PATCH 16/20] python/console_socket: avoid encoding to/from string

2020-10-06 Thread John Snow
We can work directly in bytes instead of translating back and forth to string, which removes the question of which encodings to use. Signed-off-by: John Snow --- python/qemu/console_socket.py | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/python/qemu/co

[PATCH 08/20] python/machine.py: fix _popen access

2020-10-06 Thread John Snow
As always, Optional[T] causes problems with unchecked access. Add a helper that asserts the pipe is present before we attempt to talk with it. Signed-off-by: John Snow --- python/qemu/machine.py | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/python/qemu/mac

[PATCH 14/20] python/qemu/console_socket.py: Clarify type of drain_thread

2020-10-06 Thread John Snow
Mypy needs just a little help to guess the type here. Signed-off-by: John Snow --- python/qemu/console_socket.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/python/qemu/console_socket.py b/python/qemu/console_socket.py index 39456825064..d4669c441d0 100644 --- a/python/

[PATCH 11/20] python/qemu: Add mypy type annotations

2020-10-06 Thread John Snow
These should all be purely annotations with no changes in behavior at all. You need to be in the python folder, but you should be able to confirm that these annotations are correct (or at least self-consistent) by running `mypy --strict qemu`. Signed-off-by: John Snow --- python/qemu/accel.py

[PATCH 04/20] python/machine.py: Don't modify state in _base_args()

2020-10-06 Thread John Snow
Don't append to the _remove_files list during _base_args; instead do so during _launch. Rework _base_args as a @property to help facilitate this impression. This has the additional benefit of making the type of _console_address easier to analyze statically. Signed-off-by: John Snow Reviewed-by:

[PATCH 10/20] iotests.py: Adjust HMP kwargs typing

2020-10-06 Thread John Snow
mypy wants to ensure there's consistency between the kwargs arguments types and any unspecified keyword arguments. In this case, conv_keys is a bool, but the remaining keys are Any type. Mypy (correctly) infers the **kwargs type to be **Dict[str, str], which is not compatible with conv_keys: bool.

[PATCH 06/20] python/machine.py: use qmp.command

2020-10-06 Thread John Snow
machine.py and qmp.py both do the same thing here; refactor machine.py to use qmp.py's functionality more directly. Signed-off-by: John Snow Reviewed-by: Kevin Wolf --- python/qemu/machine.py | 32 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/

[PATCH 05/20] python/machine.py: Handle None events in events_wait

2020-10-06 Thread John Snow
If the timeout is 0, we can get None back. Handle this explicitly. Signed-off-by: John Snow Reviewed-by: Kevin Wolf --- python/qemu/machine.py | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/python/qemu/machine.py b/python/qemu/machine.py index 8

[PATCH 00/20] python/qemu: strictly typed mypy conversion, pt2

2020-10-06 Thread John Snow
Continuing where I left off prior to the 5.1 release, this series touches up a few odds and ends and introduces mypy hints. What's new: - Using isort to solidify import order - Patches adding small corrections and typing for console_socket - A few error class changes for qmp.py Like my QAPI seri

[PATCH 09/20] python/qemu: make 'args' style arguments immutable

2020-10-06 Thread John Snow
These arguments don't need to be mutable and aren't really used as such. Clarify their types as immutable and adjust code to match where necessary. In general, It's probably best not to accept a user-defined mutable object and store it as internal object state unless there's a strong justification

[PATCH 02/20] python/machine.py: Fix monitor address typing

2020-10-06 Thread John Snow
Prior to this, it's difficult for mypy to intuit what the concrete type of the monitor address is; it has difficulty inferring the type across two variables. Create _monitor_address as a property that always returns a valid address to simplify static type analysis. To preserve our ability to clea

[PATCH 07/20] python/machine.py: Add _qmp access shim

2020-10-06 Thread John Snow
Like many other Optional[] types, it's not always a given that this object will be set. Wrap it in a type-shim that raises a meaningful error and will always return a concrete type. Signed-off-by: John Snow --- python/qemu/machine.py | 24 +--- 1 file changed, 13 insertions(+

[PATCH 01/20] python/qemu: use isort to lay out imports

2020-10-06 Thread John Snow
Borrowed from the QAPI cleanup series, use the same configuration to standardize the way we write and sort imports. Signed-off-by: John Snow --- python/qemu/.isort.cfg| 7 +++ python/qemu/accel.py | 1 + python/qemu/console_socket.py | 2 +- python/qemu/machine.py

[PATCH 03/20] python/machine.py: reorder __init__

2020-10-06 Thread John Snow
Put the init arg handling all at the top, and mostly in order (deviating when one is dependent on another), and put what is effectively runtime state declaration at the bottom. Signed-off-by: John Snow --- python/qemu/machine.py | 44 -- 1 file changed, 25

Re: [PATCH v11 2/3] usb: Add DWC3 model

2020-10-06 Thread Vikram Garhwal
Hi Edgar, Thanks for reviewing this one. On Tue, Sep 29, 2020 at 04:25:47PM +0200, Edgar E. Iglesias wrote: > On Tue, Sep 29, 2020 at 04:25:41PM +0530, Sai Pavan Boddu wrote: > > From: Vikram Garhwal > > > > This patch adds skeleton model of dwc3 usb controller attached to > > xhci-sysbus device.

acceptance-system-fedora failures

2020-10-06 Thread John Snow
I'm seeing this gitlab test fail quite often in my Python work; I don't *think* this has anything to do with my patches, but maybe I need to try and bisect this more aggressively. The very first hint of an error I see is on line 154: https://gitlab.com/jsnow/qemu/-/jobs/776334918#L154 22:05:3

[PULL 19/21] memory: Explicitly tag doc comments for structs

2020-10-06 Thread Eduardo Habkost
This will allow us to remove the QEMU-specific $decl_type='type name' hack from the kernel-doc script. Signed-off-by: Eduardo Habkost Reviewed-by: Paolo Bonzini Message-Id: <20201003024123.193840-5-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- include/exec/memory.h | 6 +++--- 1 file

[PULL 20/21] kernel-doc: Remove $decl_type='type name' hack

2020-10-06 Thread Eduardo Habkost
The $decl_type='type name' hack makes it impossible to document macros with uppercase names (e.g. most of the macros in object.h). Now that we have explicitly tagged the struct and typedef doc comments in memory.h and object.h, we don't need that hack anymore. This will make the documentation for

[PULL 21/21] numa: hmat: require parent cache description before the next level one

2020-10-06 Thread Eduardo Habkost
From: Igor Mammedov Spec[1] defines 0 - 3 level memory side cache, however QEMU CLI allows to specify an intermediate cache level without specifying previous level. Such option(s) silently ignored when building HMAT table, which leads to incomplete cache information. Make sure that previous level

[PULL 14/21] docs/devel/qom: Remove usage of

2020-10-06 Thread Eduardo Habkost
is not valid reST syntax. Function @argument references don't need additional markup, so just remove . Constants were changed to use reST ``code`` syntax Signed-off-by: Eduardo Habkost Reviewed-by: Paolo Bonzini Message-Id: <20201003025424.199291-6-ehabk...@redhat.com> Signed-off-by: Eduardo

[PULL 18/21] qom: Explicitly tag doc comments for typedefs and structs

2020-10-06 Thread Eduardo Habkost
If we explicitly indicate we are documenting a typedef or a struct, we'll be able to remove the $decl_type='type name' hack from kernel-doc. Signed-off-by: Eduardo Habkost Reviewed-by: Paolo Bonzini Message-Id: <20201003024123.193840-4-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- in

[PULL 12/21] docs/devel/qom: Fix indentation of code blocks

2020-10-06 Thread Eduardo Habkost
Some code blocks had one extra space, fix that. Signed-off-by: Eduardo Habkost Reviewed-by: Paolo Bonzini Message-Id: <20201003025424.199291-4-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- docs/devel/qom.rst | 76 +++--- 1 file changed, 38 inse

[PULL 13/21] docs/devel/qom: Use *emphasis* for emphasis

2020-10-06 Thread Eduardo Habkost
is not valid reST syntax. Signed-off-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Paolo Bonzini Message-Id: <20201003025424.199291-5-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- docs/devel/qom.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PULL 09/21] qom: Improve error message displayed with missing object properties

2020-10-06 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé Instead of only displaying the property missing, also display the object name. This help developer to quickly figure out the mistake without opening a debugger. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Eduardo Habkost Reviewed-by: Li Qiang Acked-by: Pa

[PULL 15/21] docs/devel/qom: Avoid long lines

2020-10-06 Thread Eduardo Habkost
Long code lines don't look good in the rendered documents, make them shorter. Signed-off-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Paolo Bonzini Message-Id: <20201003025424.199291-7-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- docs/devel/qom.rst | 9 +

[PULL 11/21] docs/devel/qom: Fix indentation of bulleted list

2020-10-06 Thread Eduardo Habkost
The list was incorrectly parsed as a literal block due to indentation. Signed-off-by: Eduardo Habkost Reviewed-by: Paolo Bonzini Message-Id: <20201003025424.199291-3-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- docs/devel/qom.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deleti

[PULL 17/21] kernel-doc: Handle function typedefs without asterisks

2020-10-06 Thread Eduardo Habkost
Example of typedef that was not parsed by kernel-doc: typedef void (ObjectUnparent)(Object *obj); Signed-off-by: Eduardo Habkost Reviewed-by: Paolo Bonzini Message-Id: <20201003024123.193840-3-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- scripts/kernel-doc | 2 +- 1 file changed,

[PULL 10/21] qom: Fix DECLARE_*CHECKER documentation

2020-10-06 Thread Eduardo Habkost
Correct copy/paste mistake in the DECLARE_INSTANCE_CHECKER and DECLARE_CLASS_CHECKERS documentation. Signed-off-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Paolo Bonzini Message-Id: <20201003025424.199291-2-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- inclu

[PULL 07/21] hw/core/qdev-properties: Extract system-mode specific properties

2020-10-06 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé Move properties specific to machines into a separate file. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20200930164949.1425294-9-phi...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/core/qdev-properties-system.c | 687

[PULL 04/21] hw/core/qdev-properties: Export enum-related functions

2020-10-06 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé We are going to split this file and reuse these static functions. Add the local "qdev-prop-internal.h" header declaring them. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20200930164949.1425294-6-phi...@redhat.com> Signed-off-by

[PULL 06/21] hw/core/qdev-properties: Export some integer-related functions

2020-10-06 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé We are going to split this file and reuse these static functions. Declare them in the local "qdev-prop-internal.h" header. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20200930164949.1425294-8-phi...@redhat.com> Signed-off-by: E

[PULL 08/21] hw/core/cpu: Add missing 'exec/cpu-common.h' include

2020-10-06 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé cpu_common_reset() uses tcg_flush_softmmu_tlb() which is declared in "exec/cpu-common.h". Add the missing header to avoid when refactoring other headers: hw/core/cpu.c: In function ‘cpu_common_reset’: hw/core/cpu.c:273:9: error: implicit declaration of function

[PULL 16/21] kernel-doc: Handle function typedefs that return pointers

2020-10-06 Thread Eduardo Habkost
One example that was not being parsed correctly by kernel-doc is: typedef Object *(ObjectPropertyResolve)(Object *obj, void *opaque, const char *part); Signed-off-by: Eduardo Habkost Reviewed-by: Paolo Bonzini

[PULL 02/21] hw/core/qdev-properties: Use qemu_strtoul() in set_pci_host_devaddr()

2020-10-06 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé Replace strtoul() by qemu_strtoul() so checkpatch.pl won't complain if we move this code later. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20200930164949.1425294-4-phi...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/cor

[PULL 05/21] hw/core/qdev-properties: Export qdev_prop_enum

2020-10-06 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20200930164949.1425294-7-phi...@redhat.com> Signed-off-by: Eduardo Habkost --- include/hw/qdev-properties.h | 1 + hw/core/qdev-properties.c| 7 +++ 2 files changed, 8 insert

[PULL 03/21] hw/core/qdev-properties: Fix code style

2020-10-06 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé We will soon move this code, fix its style to avoid checkpatch.pl to complain. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20200930164949.1425294-5-phi...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/core/qdev-properties

  1   2   3   4   5   >