Re: [PATCH] spapr: Handle HPT allocation failure in nested guest

2020-09-13 Thread David Gibson
On Fri, Sep 11, 2020 at 01:31:23AM -0300, Fabiano Rosas wrote: > The nested KVM code does not yet support HPT guests. Calling the > KVM_CAP_PPC_ALLOC_HTAB ioctl currently leads to KVM setting the guest > as HPT and erroneously executing code in L1 that should only run in > hypervisor mode, leading

Re: [PATCH] checkpatch: Detect '%#' or '%0#' in printf-style format strings

2020-09-13 Thread Philippe Mathieu-Daudé
+qemu-perl team On 9/14/20 8:01 AM, Dov Murik wrote: > According to the coding style document, we should use literal '0x' prefix > instead of printf's '#' flag (which appears as '%#' or '%0#' in the format > string). Add a checkpatch rule to enforce that. > > Note that checkpatch already had a s

Re: [PATCH v8 00/27] W32, W64 msys2/mingw patches

2020-09-13 Thread Yonggang Luo
On Mon, Sep 14, 2020 at 2:38 PM Stefan Weil wrote: > > Am 14.09.20 um 08:27 schrieb 罗勇刚(Yonggang Luo): > > > Thanks, I am learning how to submit patches properly, in old days, when I am using pull request on github have no such problems. easy to follow up > > > May I also ask you to send text-onl

Re: [PATCH 11/14] block/qcow2-bitmap: return startus from qcow2_store_persistent_dirty_bitmaps

2020-09-13 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 11.09.2020 18:22, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> 11.09.2020 14:21, Greg Kurz wrote: On Fri, 11 Sep 2020 13:18:32 +0300 Vladimir Sementsov-Ogievskiy wrote: [...] > Hmm.. With this series I understand t

[Bug 1882851] Re: QEMU video freezes with "Guest disabled display" (virtio driver)

2020-09-13 Thread Diego Viola
This bug is now fixed with Linux 5.9-rc5, thank you. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1882851 Title: QEMU video freezes with "Guest disabled display" (virtio driver) Status in QEMU:

Re: [PATCH v8 00/27] W32, W64 msys2/mingw patches

2020-09-13 Thread Philippe Mathieu-Daudé
On 9/14/20 8:27 AM, 罗勇刚(Yonggang Luo) wrote: > > > On Mon, Sep 14, 2020 at 2:10 PM Thomas Huth > wrote: > > On 13/09/2020 00.44, Yonggang Luo wrote: > > It first introduce msys2 CI on cirrus by fixes nfs, capstone, > curses and > > disable partial test-c

Re: [REPORT] Nightly Performance Tests - Sunday, September 13, 2020

2020-09-13 Thread Philippe Mathieu-Daudé
Hi Ahmed, On 9/14/20 12:07 AM, Ahmed Karaman wrote: > Host CPU : Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz > Host Memory : 15.49 GB > > Start Time (UTC) : 2020-09-13 21:35:01 > End Time (UTC) : 2020-09-13 22:07:44 > Execution Time : 0:32:42.230467 > > Status : SUCCESS >

Re: [PATCH v2 2/2] hw/timer/hpet: Fix DPRINTF format string

2020-09-13 Thread Dov Murik
On 13/09/2020 14:40, Philippe Mathieu-Daudé wrote: On 9/12/20 7:40 PM, Dov Murik wrote: Hi Phil, On 10/09/2020 16:58, Philippe Mathieu-Daudé wrote: Fix building with HPET_DEBUG enabled:    hw/timer/hpet.c:512:73: error: format specifies type 'unsigned int' but the argument has type 'uint6

Re: [PATCH v8 00/27] W32, W64 msys2/mingw patches

2020-09-13 Thread Stefan Weil
Am 14.09.20 um 08:27 schrieb 罗勇刚(Yonggang Luo): > > Thanks, I am learning how to submit patches properly, in old days,  > when I am using pull request on github have no such problems. easy to > follow up May I also ask you to send text-only e-mails? Your HTML e-mails are really hard to read. Th

Re: [PATCH v3 05/15] hw/block/nvme: Define trace events related to NS Types

2020-09-13 Thread Philippe Mathieu-Daudé
On 9/14/20 12:14 AM, Dmitry Fomichev wrote: > A few trace events are defined that are relevant to implementing > Namespace Types (NVMe TP 4056). > > Signed-off-by: Dmitry Fomichev > Reviewed-by: Klaus Jensen > --- > hw/block/trace-events | 10 ++ > 1 file changed, 10 insertions(+) Revi

Re: [PATCH] hw/scsi/vmw_pvscsi.c: Fix wrong usage of gboolean types in PVSCSIState

2020-09-13 Thread Philippe Mathieu-Daudé
Hi Amey, On 9/14/20 1:44 AM, Amey Narkhede wrote: > rings_info_valid, msg_ring_info_valid and use_msg fields of struct > PVSCSIState are using gboolean TRUE/FALSE values with the type uint8_t. > Change their type to bool along with the usage of initialization macro > VMSTATE_BOOL during initializa

Re: [PATCH v8 00/27] W32, W64 msys2/mingw patches

2020-09-13 Thread Yonggang Luo
On Mon, Sep 14, 2020 at 2:10 PM Thomas Huth wrote: > On 13/09/2020 00.44, Yonggang Luo wrote: > > It first introduce msys2 CI on cirrus by fixes nfs, capstone, curses and > > disable partial test-char tests. > > And then fixes all unit tests failure on msys2/mingw > > This fixes the reviews sugge

Re: [PATCH 11/11] disas: Enable capstone disassembly for sparc

2020-09-13 Thread Philippe Mathieu-Daudé
+SPARC maintainers On 9/14/20 2:01 AM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > disas.c| 2 ++ > target/sparc/cpu.c | 4 > meson.build| 10 ++ > 3 files changed, 16 insertions(+) > > diff --git a/disas.c b/disas.c > index 5e943181d8.

Re: [PATCH v8 00/27] W32, W64 msys2/mingw patches

2020-09-13 Thread Thomas Huth
On 13/09/2020 00.44, Yonggang Luo wrote: > It first introduce msys2 CI on cirrus by fixes nfs, capstone, curses and > disable partial test-char tests. > And then fixes all unit tests failure on msys2/mingw > This fixes the reviews suggested in the mailling list > All cirrus CI are passed Hi, sin

[PATCH v4 14/15] replay: create temporary snapshot at debugger connection

2020-09-13 Thread Pavel Dovgalyuk
When record/replay does not uses overlays for storing the snapshots, user is not capable of issuing reverse debugging commands. This patch adds creation of the VM snapshot on the temporary overlay image, when the debugger connects to QEMU. Therefore the execution can be rewind to the moment of the

[PATCH v4 13/15] docs: convert replay.txt to rst

2020-09-13 Thread Pavel Dovgalyuk
This patch converts record/replay documentation into rst format. Signed-off-by: Pavel Dovgalyuk --- docs/replay.txt| 410 docs/system/index.rst |1 docs/system/replay.rst | 410 3 fi

[PATCH v4 09/15] replay: flush rr queue before loading the vmstate

2020-09-13 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk Non-empty record/replay queue prevents saving and loading the VM state, because it includes pending bottom halves and block coroutines. But when the new VM state is loaded, we don't have to preserve the consistency of the current state anymore. Therefore this patch just flus

[PATCH v4 08/15] replay: implement replay-seek command

2020-09-13 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch adds hmp/qmp commands replay_seek/replay-seek that proceed the execution to the specified instruction count. The command automatically loads nearest snapshot and replays the execution to find the desired instruction count. Signed-off-by: Pavel Dovgalyuk Acked-by

[PATCH v4 06/15] replay: introduce info hmp/qmp command

2020-09-13 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch introduces 'info replay' monitor command and corresponding qmp request. These commands request the current record/replay mode, replay log file name, and the instruction count (number of recorded/replayed instructions). The instruction count can be used with the r

[PATCH v4 05/15] qapi: introduce replay.json for record/replay-related stuff

2020-09-13 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch adds replay.json file. It will be used for adding record/replay-related data structures and commands. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Markus Armbruster Reviewed-by: Alex Bennée --- MAINTAINERS |1 + include/sysemu/replay.h |1 +

[PATCH v4 15/15] tests/acceptance: add reverse debugging test

2020-09-13 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This is a test for GDB reverse debugging commands: reverse step and reverse continue. Every test in this suite consists of two phases: record and replay. Recording saves the execution of some instructions and makes an initial VM snapshot to allow reverse execution. Replay s

[PATCH v4 11/15] gdbstub: add reverse continue support in replay mode

2020-09-13 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch adds support of the reverse continue operation for gdbstub. Reverse continue finds the last breakpoint that would happen in normal execution from the beginning to the current moment. Implementation of the reverse continue replays the execution twice: to find the b

Re: [PATCH 02/11] capstone: Update to upstream "next" branch

2020-09-13 Thread Philippe Mathieu-Daudé
On 9/14/20 2:01 AM, Richard Henderson wrote: > This branch contains a number of improvements over master, > including making all of the disassembler data constant. > > We are skipping past the 4.0 branchpoint, which changed > the location of the includes within the source directory. > > Signed-of

[PATCH v4 12/15] replay: describe reverse debugging in docs/replay.txt

2020-09-13 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch updates the documentation and describes usage of the reverse debugging in QEMU+GDB. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Alex Bennée -- v4 changes: - added an example of the command line for reverse debugging of the diskless machine --- docs/repla

[PATCH v4 02/15] replay: provide an accessor for rr filename

2020-09-13 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch adds an accessor function for the name of the record/replay log file. Adding an accessor instead of making variable global, prevents accidental modification of this variable by other modules. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Alex Bennée --- include/

[PATCH v4 01/15] replay: don't record interrupt poll

2020-09-13 Thread Pavel Dovgalyuk
Interrupt poll is not a real interrupt event. It is needed only for thread safety. This interrupt is used for i386 and converted to hardware interrupt by cpu_handle_interrupt function. Therefore it is not needed to be recorded, because hardware interrupt will be recorded after converting. Signed-o

[PATCH v4 07/15] replay: introduce breakpoint at the specified step

2020-09-13 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch introduces replay_break, replay_delete_break qmp and hmp commands. These commands allow stopping at the specified instruction. It may be useful for debugging when there are some known events that should be investigated. replay_break command has one argument - numb

[PATCH v4 10/15] gdbstub: add reverse step support in replay mode

2020-09-13 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk GDB remote protocol supports two reverse debugging commands: reverse step and reverse continue. This patch adds support of the first one to the gdbstub. Reverse step is intended to step one instruction in the backwards direction. This is not possible in regular execution. Bu

[PATCH v4 04/15] migration: introduce icount field for snapshots

2020-09-13 Thread Pavel Dovgalyuk
Saving icount as a parameters of the snapshot allows navigation between them in the execution replay scenario. This information can be used for finding a specific snapshot for proceeding the recorded execution to the specific moment of the time. E.g., 'reverse step' action (introduced in one of the

[PATCH v4 03/15] qcow2: introduce icount field for snapshots

2020-09-13 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch introduces the icount field for saving within the snapshot. It is required for navigation between the snapshots in record/replay mode. Signed-off-by: Pavel Dovgalyuk Acked-by: Kevin Wolf --- block/qcow2-snapshot.c |7 +++ block/qcow2.h |3

[PATCH v4 00/15] Reverse debugging

2020-09-13 Thread Pavel Dovgalyuk
GDB remote protocol supports reverse debugging of the targets. It includes 'reverse step' and 'reverse continue' operations. The first one finds the previous step of the execution, and the second one is intended to stop at the last breakpoint that would happen when the program is executed normally.

[PATCH] checkpatch: Detect '%#' or '%0#' in printf-style format strings

2020-09-13 Thread Dov Murik
According to the coding style document, we should use literal '0x' prefix instead of printf's '#' flag (which appears as '%#' or '%0#' in the format string). Add a checkpatch rule to enforce that. Note that checkpatch already had a similar rule for trace-events files. Example usage: $ scripts

Re: [PATCH 10/11] disas/capstone: Add skipdata hook for s390x

2020-09-13 Thread Philippe Mathieu-Daudé
On 9/14/20 2:01 AM, Richard Henderson wrote: > It is always possible to tell the length of an insn, even if the > actual insn is unknown. Skip the correct number of bytes, so that > we stay in sync with the instruction stream. > > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-D

Re: [PATCH 05/11] disas: Use qemu/bswap.h for bfd endian loads

2020-09-13 Thread Philippe Mathieu-Daudé
On 9/14/20 2:01 AM, Richard Henderson wrote: > Use the routines we have already instead of open-coding. Yay \o/ Reviewed-by: Philippe Mathieu-Daudé > > Signed-off-by: Richard Henderson > --- > include/disas/dis-asm.h | 32 > disas.c | 55 --

Re: Moving to C11? (was Re: Redefinition of typedefs (C11 feature))

2020-09-13 Thread Thomas Huth
On 13/09/2020 04.51, Eduardo Habkost wrote: > On Sat, Sep 12, 2020 at 08:45:19AM +0200, Thomas Huth wrote: >> On 11/09/2020 22.06, Eduardo Habkost wrote: >>> On Fri, Sep 11, 2020 at 08:06:10PM +0100, Peter Maydell wrote: On Fri, 11 Sep 2020 at 19:49, Eduardo Habkost wrote: > > I'm won

Re: [PULL v2] Block layer patches

2020-09-13 Thread Thomas Huth
On 12/09/2020 20.38, Peter Maydell wrote: > On Sat, 12 Sep 2020 at 13:27, Thomas Huth wrote: >> Peter, why did this slip through your merge tests, do you still skip the >> iotests there? > > I forget what the reason for them being skipped is, maybe > it's because they demand a gnu sed ? The test

Re: [PATCH V2 00/10] fix some comment spelling errors

2020-09-13 Thread zhaolichang
ping

Re: [RFC 1/4] memory: add memory_region_init_io_with_dev interface

2020-09-13 Thread Jason Wang
On 2020/9/10 下午10:37, Li Qiang wrote: Alexander Bulekov 于2020年9月9日周三 下午10:28写道: On 200909 1258, Li Qiang wrote: Gerd Hoffmann 于2020年9月9日周三 下午12:49写道: On Wed, Sep 09, 2020 at 10:15:47AM +0800, Jason Wang wrote: On 2020/9/9 上午12:41, Li Qiang wrote: Currently the MR is not explicitly connec

Re: [PATCH] lockable.h: always define unknown_lock_type

2020-09-13 Thread Richard Henderson
On 9/13/20 6:42 PM, mingli...@windriver.com wrote: > From: Mingli Yu > > There comes below build failure when use gcc 10.1.0 and > "-Og" passed to compiler. > | > /usr/lib/gcc/x86_64-wrs-linux/10.1.0/../../../../x86_64-wrs-linux/bin/ld.bfd: > /mnt/build/tmp/work/x86_64-linux/qemu-system-native

[PULL 4/4] qga: add command guest-get-devices for reporting VirtIO devices

2020-09-13 Thread Michael Roth
From: Tomáš Golembiovský Add command for reporting devices on Windows guest. The intent is not so much to report the devices but more importantly the driver (and its version) that is assigned to the device. This gives caller the information whether VirtIO drivers are installed and/or whether inad

[PULL 1/4] qga/commands-posix: Rework build_guest_fsinfo_for_real_device() function

2020-09-13 Thread Michael Roth
From: Thomas Huth We are going to support non-PCI devices soon. For this we need to split the generic GuestDiskAddress and GuestDiskAddressList memory allocation and list chaining into a separate function first. Signed-off-by: Thomas Huth Reviewed-by: Daniel P. Berrangé Signed-off-by: Michael

[PULL 3/4] qga/commands-posix: Support fsinfo for non-PCI virtio devices, too

2020-09-13 Thread Michael Roth
From: Thomas Huth QEMU on s390x uses virtio via channel I/O instead of PCI by default. Add a function to detect and provide information for virtio-scsi and virtio-block devices here, too. Signed-off-by: Thomas Huth Reviewed-by: Daniel P. Berrangé Signed-off-by: Michael Roth --- qga/commands-

[PULL 0/4] qemu-ga patch queue

2020-09-13 Thread Michael Roth
The following changes since commit c47edb8dda0660180f86df4defae2a1f60e345db: Merge remote-tracking branch 'remotes/berrange-gitlab/tags/crypt-perf-pull-request' into staging (2020-09-12 21:17:22 +0100) are available in the Git repository at: git://github.com/mdroth/qemu.git tags/qga-pull-2

[PULL 2/4] qga/commands-posix: Move the udev code from the pci to the generic function

2020-09-13 Thread Michael Roth
From: Thomas Huth The libudev-related code is independent from the other pci-related code and can be re-used for non-pci devices (like ccw devices on s390x). Thus move this part to the generic function. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1755075 Signed-off-by: Thomas Huth Revi

[PATCH] lockable.h: always define unknown_lock_type

2020-09-13 Thread mingli.yu
From: Mingli Yu There comes below build failure when use gcc 10.1.0 and "-Og" passed to compiler. | /usr/lib/gcc/x86_64-wrs-linux/10.1.0/../../../../x86_64-wrs-linux/bin/ld.bfd: /mnt/build/tmp/work/x86_64-linux/qemu-system-native/5.1.0-r0/qemu-5.1.0/fsdev/qemu-fsdev-throttle.c:25: undefined r

Re: [PATCH v6 2/7] hw/misc/led: Allow connecting from GPIO output

2020-09-13 Thread Richard Henderson
On 9/12/20 6:40 AM, Philippe Mathieu-Daudé wrote: > Some devices expose GPIO lines. > > Add a GPIO qdev input to our LED device, so we can > connect a GPIO output using qdev_connect_gpio_out(). > > When used with GPIOs, the intensity can only be either > minium or maximum. This depends of the pol

Re: [PATCH v6 2/7] hw/misc/led: Allow connecting from GPIO output

2020-09-13 Thread Richard Henderson
On 9/12/20 6:40 AM, Philippe Mathieu-Daudé wrote: > Some devices expose GPIO lines. > > Add a GPIO qdev input to our LED device, so we can > connect a GPIO output using qdev_connect_gpio_out(). > > When used with GPIOs, the intensity can only be either > minium or maximum. This depends of the pol

Re: [PATCH 01/11] capstone: Convert Makefile bits to meson bits

2020-09-13 Thread Richard Henderson
On 9/13/20 5:01 PM, Richard Henderson wrote: > case "$capstone" in > - git | internal) > + git) > if test "$capstone" = git; then >git_submodules="${git_submodules} capstone" > fi The if here can be removed now. Alternately... > -mkdir -p capstone > -if test "$mingw3

Re: [PATCH v1 2/2] colo-compare: Record packet creation time by QEMU_CLOCK_REALTIME

2020-09-13 Thread Derek Su
Zhang, Chen 於 2020年9月14日 週一,上午4:06寫道: > > > > > > -Original Message- > > > From: Zhang, Chen > > > Sent: Monday, September 14, 2020 4:02 AM > > > To: 'Derek Su' ; qemu-devel@nongnu.org > > > Cc: lizhij...@cn.fujitsu.com; jasow...@redhat.com > > > Subject: RE: [PATCH v1 2/2] colo-compare: R

Re: [PATCH v1 1/2] colo-compare: Fix incorrect data type conversion

2020-09-13 Thread Derek Su
Hi, Chen Got it, thank you :) Regards, Derek Zhang, Chen 於 2020年9月14日 週一,上午4:02寫道: > > > > > > -Original Message- > > > From: Derek Su > > > Sent: Saturday, September 12, 2020 3:05 AM > > > To: qemu-devel@nongnu.org > > > Cc: Zhang, Chen ; lizhij...@cn.fujitsu.com; > > > jasow...@redha

Re: qemu disassembler status

2020-09-13 Thread Richard Henderson
On 9/12/20 12:03 AM, Thomas Huth wrote: > Is capstone good enough already to replace libvixl? Yes as far as the version that we currently have imported, but no if we were to update vixl. In particular, capstone has no support for SVE or other v8.2+ additions. > And what about the other old disas

[PATCH 10/11] disas/capstone: Add skipdata hook for s390x

2020-09-13 Thread Richard Henderson
It is always possible to tell the length of an insn, even if the actual insn is unknown. Skip the correct number of bytes, so that we stay in sync with the instruction stream. Signed-off-by: Richard Henderson --- disas/capstone.c | 42 +- 1 file changed,

[PATCH 08/11] disas: Split out capstone code to disas/capstone.c

2020-09-13 Thread Richard Henderson
There is nothing target-specific about this code, so it can be added to common_ss. This also requires that the base capstone dependency be added to common_ss, so that we get the correct include paths added to CFLAGS. Signed-off-by: Richard Henderson --- include/disas/dis-asm.h | 12 ++ disas.c

[PATCH 06/11] disas: Cleanup plugin_disas

2020-09-13 Thread Richard Henderson
Do not retain a GString in thread-local storage. Allocate a new one and free it on every invocation. Do not g_strdup the result; return the buffer from the GString. Do not use warn_report. Using cs_disasm allocated memory via the &insn parameter, but that was never freed. Use cs_disasm_iter so

[PATCH 04/11] disas: Clean up CPUDebug initialization

2020-09-13 Thread Richard Henderson
Rename buffer_read_memory to host_read_memory. Make a bunch of functions static that are not used outside this file. Replace INIT_DISASSEMBLE_INFO with a trio of functions. Signed-off-by: Richard Henderson --- include/disas/dis-asm.h | 60 disas.c | 323 +++

[PATCH 09/11] disas: Enable capstone disassembly for s390x

2020-09-13 Thread Richard Henderson
Enable s390x, aka SYSZ, in the git submodule build. Set the capstone parameters for both s390x host and guest. Signed-off-by: Richard Henderson --- disas.c| 3 +++ target/s390x/cpu.c | 4 meson.build| 11 +++ 3 files changed, 18 insertions(+) diff --git a/disa

[PATCH 02/11] capstone: Update to upstream "next" branch

2020-09-13 Thread Richard Henderson
This branch contains a number of improvements over master, including making all of the disassembler data constant. We are skipping past the 4.0 branchpoint, which changed the location of the includes within the source directory. Signed-off-by: Richard Henderson --- capstone| 2 +- meson.bui

[PATCH 01/11] capstone: Convert Makefile bits to meson bits

2020-09-13 Thread Richard Henderson
There are better ways to do this, e.g. meson cmake subproject, but that requires cmake 3.7 and some of our CI environments only provide cmake 3.5. Nor can we add a meson.build file to capstone/, because the git submodule would then always report "untracked files". Fixing that would require creati

[PATCH 11/11] disas: Enable capstone disassembly for sparc

2020-09-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- disas.c| 2 ++ target/sparc/cpu.c | 4 meson.build| 10 ++ 3 files changed, 16 insertions(+) diff --git a/disas.c b/disas.c index 5e943181d8..b71d06d890 100644 --- a/disas.c +++ b/disas.c @@ -196,6 +196,8 @@ static void init

[PATCH 07/11] disas: Configure capstone for aarch64 host without libvixl

2020-09-13 Thread Richard Henderson
The ifdef tangle failed to set cap_arch if libvixl itself was not configured (e.g. due to lack of c++ compiler). Signed-off-by: Richard Henderson --- disas.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/disas.c b/disas.c index ed9965c32f..5d81403125 100644 --- a/disa

[PATCH 05/11] disas: Use qemu/bswap.h for bfd endian loads

2020-09-13 Thread Richard Henderson
Use the routines we have already instead of open-coding. Signed-off-by: Richard Henderson --- include/disas/dis-asm.h | 32 disas.c | 55 - 2 files changed, 27 insertions(+), 60 deletions(-) diff --git a/include/di

[PATCH 03/11] disas: Move host asm annotations to tb_gen_code

2020-09-13 Thread Richard Henderson
Instead of creating GStrings and passing them into log_disas, just print the annotations directly in tb_gen_code. Fix the annotations for the slow paths of the TB, after the part implementing the final guest instruction. Signed-off-by: Richard Henderson --- include/disas/disas.h | 2 +- in

[PATCH 00/11] capstone + disassembler patches

2020-09-13 Thread Richard Henderson
The primary change here is the update for capstone to meson. This bypasses capstone's build system entirely. There's more commentary on that subject with the first patch. Plus a collection of other fixes and cleanups in the area. There are a couple of other targets that could use capstone: The

[PATCH] hw/scsi/vmw_pvscsi.c: Fix wrong usage of gboolean types in PVSCSIState

2020-09-13 Thread Amey Narkhede
rings_info_valid, msg_ring_info_valid and use_msg fields of struct PVSCSIState are using gboolean TRUE/FALSE values with the type uint8_t. Change their type to bool along with the usage of initialization macro VMSTATE_BOOL during initialization of vmstate_pvscsi and pvscsi_properties. Signed-off-b

[PATCH v3 13/15] hw/block/nvme: Add injection of Offline/Read-Only zones

2020-09-13 Thread Dmitry Fomichev
ZNS specification defines two zone conditions for the zones that no longer can function properly, possibly because of flash wear or other internal fault. It is useful to be able to "inject" a small number of such zones for testing purposes. This commit defines two optional device properties, "offl

[PATCH v3 11/15] hw/block/nvme: Introduce max active and open zone limits

2020-09-13 Thread Dmitry Fomichev
Added two module properties, "max_active" and "max_open" to control the maximum number of zones that can be active or open. Once these variables are set to non-default values, these limits are checked during I/O and Too Many Active or Too Many Open command status is returned if they are exceeded.

[PATCH v3 07/15] hw/block/nvme: Add support for active/inactive namespaces

2020-09-13 Thread Dmitry Fomichev
From: Niklas Cassel In NVMe, a namespace is active if it exists and is attached to the controller. CAP.CSS (together with the I/O Command Set data structure) defines what command sets are supported by the controller. CC.CSS (together with Set Profile) can be set to enable a subset of the availa

[PATCH v3 06/15] hw/block/nvme: Add support for Namespace Types

2020-09-13 Thread Dmitry Fomichev
From: Niklas Cassel Namespace Types introduce a new command set, "I/O Command Sets", that allows the host to retrieve the command sets associated with a namespace. Introduce support for the command set and enable detection for the NVM Command Set. The new workflows for identify commands rely hea

[PATCH v3 15/15] hw/block/nvme: Document zoned parameters in usage text

2020-09-13 Thread Dmitry Fomichev
Added brief descriptions of the new device properties that are now available to users to configure features of Zoned Namespace Command Set in the emulator. This patch is for documentation only, no functionality change. Signed-off-by: Dmitry Fomichev --- hw/block/nvme.c | 43

[PATCH v3 05/15] hw/block/nvme: Define trace events related to NS Types

2020-09-13 Thread Dmitry Fomichev
A few trace events are defined that are relevant to implementing Namespace Types (NVMe TP 4056). Signed-off-by: Dmitry Fomichev Reviewed-by: Klaus Jensen --- hw/block/trace-events | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/block/trace-events b/hw/block/trace-events index

[PATCH v3 10/15] hw/block/nvme: Support Zoned Namespace Command Set

2020-09-13 Thread Dmitry Fomichev
The emulation code has been changed to advertise NVM Command Set when "zoned" device property is not set (default) and Zoned Namespace Command Set otherwise. Handlers for three new NVMe commands introduced in Zoned Namespace Command Set specification are added, namely for Zone Management Receive,

[PATCH v3 14/15] hw/block/nvme: Use zone metadata file for persistence

2020-09-13 Thread Dmitry Fomichev
A ZNS drive that is emulated by this module is currently initialized with all zones Empty upon startup. However, actual ZNS SSDs save the state and condition of all zones in their internal NVRAM in the event of power loss. When such a drive is powered up again, it closes or finishes all zones that

[PATCH v3 04/15] hw/block/nvme: Introduce the Namespace Types definitions

2020-09-13 Thread Dmitry Fomichev
From: Niklas Cassel Define the structures and constants required to implement Namespace Types support. Signed-off-by: Niklas Cassel Signed-off-by: Dmitry Fomichev --- hw/block/nvme.c | 2 +- hw/block/nvme.h | 3 ++ include/block/nvme.h | 74 +++-

[PATCH v3 09/15] hw/block/nvme: Define Zoned NS Command Set trace events

2020-09-13 Thread Dmitry Fomichev
The Zoned Namespace Command Set / Namespace Types implementation that is being introduced in this series adds a good number of trace events. Combine all tracepoint definitions into a separate patch to make reviewing more convenient. Signed-off-by: Dmitry Fomichev --- hw/block/trace-events | 26 +

[PATCH v3 02/15] hw/block/nvme: Report actual LBA data shift in LBAF

2020-09-13 Thread Dmitry Fomichev
Calculate the data shift value to report based on the set value of logical_block_size device property. In the process, use a local variable to calculate the LBA format index instead of the hardcoded value 0. This makes the code more readable and it will make it easier to add support for multiple L

[PATCH v3 12/15] hw/block/nvme: Support Zone Descriptor Extensions

2020-09-13 Thread Dmitry Fomichev
Zone Descriptor Extension is a label that can be assigned to a zone. It can be set to an Empty zone and it stays assigned until the zone is reset. This commit adds a new optional module property, "zone_descr_ext_size". Its value must be a multiple of 64 bytes. If this value is non-zero, it becomes

[PATCH v3 03/15] hw/block/nvme: Add Commands Supported and Effects log

2020-09-13 Thread Dmitry Fomichev
This log page becomes necessary to implement to allow checking for Zone Append command support in Zoned Namespace Command Set. This commit adds the code to report this log page for NVM Command Set only. The parts that are specific to zoned operation will be added later in the series. Signed-off-b

[PATCH v3 00/15] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2020-09-13 Thread Dmitry Fomichev
v2 -> v3: - Moved nvme_fill_data() function to the NSTypes patch as it is now used there to output empty namespace identify structs. - Fixed typo in Maxim's email address. v1 -> v2: - Rebased on top of qemu-nvme/next branch. - Incorporated feedback from Klaus and Alistair. - Dropped "Sim

[PATCH v3 01/15] hw/block/nvme: Define 64 bit cqe.result

2020-09-13 Thread Dmitry Fomichev
From: Ajay Joshi A new write command, Zone Append, is added as a part of Zoned Namespace Command Set. Upon successful completion of this command, the controller returns the start LBA of the performed write operation in cqe.result field. Therefore, the maximum size of this variable needs to be cha

[PATCH v3 08/15] hw/block/nvme: Make Zoned NS Command Set definitions

2020-09-13 Thread Dmitry Fomichev
Define values and structures that are needed to support Zoned Namespace Command Set (NVMe TP 4053) in PCI NVMe controller emulator. All new protocol definitions are located in include/block/nvme.h and everything added that is specific to this implementation is kept in hw/block/nvme.h. In order to

[REPORT] Nightly Performance Tests - Sunday, September 13, 2020

2020-09-13 Thread Ahmed Karaman
Host CPU : Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz Host Memory : 15.49 GB Start Time (UTC) : 2020-09-13 21:35:01 End Time (UTC) : 2020-09-13 22:07:44 Execution Time : 0:32:42.230467 Status : SUCCESS Note: Changes denoted by '-' are less than 0.01%. -

Re: [PULL 00/30] riscv-to-apply queue

2020-09-13 Thread Peter Maydell
On Thu, 10 Sep 2020 at 19:20, Alistair Francis wrote: > > The following changes since commit 9435a8b3dd35f1f926f1b9127e8a906217a5518a: > > Merge remote-tracking branch > 'remotes/kraxel/tags/sirius/ipxe-20200908-pull-request' into staging > (2020-09-08 21:21:13 +0100) > > are available in the

Re: [PATCH resend] configure: actually disable 'git_update' mode with --disable-git-update

2020-09-13 Thread Philippe Mathieu-Daudé
Cc'ing Daniel as this is related to 'GIT submodules' which he maintains: $ scripts/get_maintainer.pl -f scripts/git-submodule.sh "Daniel P. Berrangé" (odd fixer:GIT submodules) On 9/13/20 8:57 PM, Dan Streetman wrote: > The --disable-git-update configure param sets git_update=no, but > some late

[Bug 1717414] Re: Sending certain keysyms results in wrong symbol input

2020-09-13 Thread Iordan Iordanov
Seems to work fine now. Thank you!! iordan -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1717414 Title: Sending certain keysyms results in wrong symbol input Status in QEMU: Incomplete Bug des

[Bug 1895053] Re: Cannot nspawn raspbian 10 [FAILED] Failed to start Journal Service.

2020-09-13 Thread Petunia
Mhm, that doesnt work for me. My output is unchanged... file /mnt/usr/bin/qemu-arm-* /mnt/usr/bin/qemu-arm-org:ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, stripped /mnt/usr/bin/qemu-arm-static: ELF 64-bit LSB executable, x86-64, version 1 (GNU/Linux), statica

RE: [PATCH v1 2/2] colo-compare: Record packet creation time by QEMU_CLOCK_REALTIME

2020-09-13 Thread Zhang, Chen
> -Original Message- > From: Zhang, Chen > Sent: Monday, September 14, 2020 4:02 AM > To: 'Derek Su' ; qemu-devel@nongnu.org > Cc: lizhij...@cn.fujitsu.com; jasow...@redhat.com > Subject: RE: [PATCH v1 2/2] colo-compare: Record packet creation time by > QEMU_CLOCK_REALTIME > > > > > -

RE: [PATCH v1 2/2] colo-compare: Record packet creation time by QEMU_CLOCK_REALTIME

2020-09-13 Thread Zhang, Chen
> -Original Message- > From: Derek Su > Sent: Saturday, September 12, 2020 3:05 AM > To: qemu-devel@nongnu.org > Cc: Zhang, Chen ; lizhij...@cn.fujitsu.com; > jasow...@redhat.com; Derek Su > Subject: [PATCH v1 2/2] colo-compare: Record packet creation time by > QEMU_CLOCK_REALTIME > >

RE: [PATCH v1 1/2] colo-compare: Fix incorrect data type conversion

2020-09-13 Thread Zhang, Chen
> -Original Message- > From: Derek Su > Sent: Saturday, September 12, 2020 3:05 AM > To: qemu-devel@nongnu.org > Cc: Zhang, Chen ; lizhij...@cn.fujitsu.com; > jasow...@redhat.com; Derek Su > Subject: [PATCH v1 1/2] colo-compare: Fix incorrect data type conversion > > Fix data type con

[PATCH v5 8/8] qapi: Extract PCI commands to 'pci.json'

2020-09-13 Thread Philippe Mathieu-Daudé
Only qemu-system-FOO and qemu-storage-daemon provide QMP monitors, therefore such declarations and definitions are irrelevant for user-mode emulation. Extracting the PCI commands to their own schema reduces the size of the qapi-misc* headers generated, and allows pulling less declarations/definiti

[PATCH v5 6/8] qapi: Restrict device memory commands to machine code

2020-09-13 Thread Philippe Mathieu-Daudé
Only qemu-system-FOO and qemu-storage-daemon provide QMP monitors, therefore such declarations and definitions are irrelevant for user-mode emulation. Restricting the memory commands to machine.json allows pulling less declarations/definitions to user-mode. Acked-by: Igor Mammedov Acked-by: Paol

[PATCH v5 7/8] qapi: Extract ACPI commands to 'acpi.json'

2020-09-13 Thread Philippe Mathieu-Daudé
Only qemu-system-FOO and qemu-storage-daemon provide QMP monitors, therefore such declarations and definitions are irrelevant for user-mode emulation. Extracting the ACPI commands to their own schema reduces the size of the qapi-misc* headers generated, and allows pulling less declarations/definit

[PATCH v5 3/8] qapi: Restrict balloon-related commands to machine code

2020-09-13 Thread Philippe Mathieu-Daudé
Only qemu-system-FOO and qemu-storage-daemon provide QMP monitors, therefore such declarations and definitions are irrelevant for user-mode emulation. Restricting the balloon-related commands to machine.json allows pulling less declarations/definitions to user-mode. Reviewed-by: David Hildenbrand

[PATCH v5 5/8] qapi: Restrict query-uuid command to machine code

2020-09-13 Thread Philippe Mathieu-Daudé
Only qemu-system-FOO and qemu-storage-daemon provide QMP monitors, therefore such declarations and definitions are irrelevant for user-mode emulation. Restricting the query-uuid command to machine.json allows pulling less declarations/definitions to user-mode. Acked-by: Markus Armbruster Acked-b

[PATCH v5 4/8] qapi: Restrict query-vm-generation-id command to machine code

2020-09-13 Thread Philippe Mathieu-Daudé
Only qemu-system-FOO and qemu-storage-daemon provide QMP monitors, therefore such declarations and definitions are irrelevant for user-mode emulation. Restricting the query-vm-generation-id command to machine.json allows pulling less declarations/definitions to user-mode. Acked-by: Igor Mammedov

[PATCH v5 2/8] qapi: Correct balloon documentation

2020-09-13 Thread Philippe Mathieu-Daudé
The documentation incorrectly uses the "size of the balloon" description when it should be "logical size of the VM". Fix it. The relation between both values is: logical_vm_size = vm_ram_size - balloon_size Reported-by: David Hildenbrand Suggested-by: David Hildenbrand Reviewed-by: David Hil

[PATCH v5 1/8] qapi: Restrict LostTickPolicy enum to machine code

2020-09-13 Thread Philippe Mathieu-Daudé
Acked-by: Markus Armbruster Acked-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé --- qapi/machine.json| 32 qapi/misc.json | 32 include/hw/rtc/mc146818rtc.h | 2 +- hw/core/qdev-properties.c

[PATCH v5 0/8] user-mode: Prune build dependencies (part 2)

2020-09-13 Thread Philippe Mathieu-Daudé
This is the second part of a series reducing user-mode dependencies. By stripping out unused code, the build and testing time is reduced (as is space used by objects). Series is fully Acked. Part 2: - Extract code not related to user-mode from qapi/misc.json Since v4: - Rebased on "QOM boilerpla

Re: [PULL 00/10] testing and other mix fixes

2020-09-13 Thread Peter Maydell
On Thu, 10 Sep 2020 at 14:15, Alex Bennée wrote: > > The following changes since commit 9435a8b3dd35f1f926f1b9127e8a906217a5518a: > > Merge remote-tracking branch > 'remotes/kraxel/tags/sirius/ipxe-20200908-pull-request' into staging > (2020-09-08 21:21:13 +0100) > > are available in the Git r

[Bug 1895471] [NEW] compilation error with clang in util/async.c

2020-09-13 Thread Amey Narkhede
Public bug reported: configured with ` CC=clang CXX=clang++ ../configure --target- list=x86_64-softmmu --enable-kvm --enable-curl --enable-debug --enable- jemalloc --enable-fuzzing --enable-sdl` and after make I get the following error related to c11 atomics. I'm using clang because I'm experiment

[PATCH resend] configure: actually disable 'git_update' mode with --disable-git-update

2020-09-13 Thread Dan Streetman
The --disable-git-update configure param sets git_update=no, but some later checks only look for the .git dir. This changes the --enable-git-update to set git_update=yes but also fail if it does not find a .git dir. Then all the later checks for the .git dir can just be changed to a check for $git_

  1   2   >